isl_basic_map_align_divs: fix potential invalid access

isl_basic_map_align_divs is currently only called on inputs that are
known not to be NULL, but since we check whether they are NULL anyway,
we might as well only access them after this test.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_multi_aff_from_map: detect strides in output dimensions

If the input map is of the form

{ [i] -> [j] : exists a: j = 4 a and i - 1 <= j <= i }

then the detection mechanism of the previous commit will not
be able to read off the definition of j directly from the constraints.
However, if we plug in j = 4 j', we obtain

{ [i] -> [j'] : i - 1 <= 4 j' <= i }

from which we can read off j' = floor(i/4), which can then be plugged
back into j = 4 j' to obitain j = 4 * floor(i/4).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_multi_aff_from_map: detect easy floors directly from constraints

If the input map has constraints of the form

{ [i] -> [j] : i - 1 <= 2 j <= i }

then we can easily detect that j can be taken to be equal to floor(i / 2).
Detecting these conditions directly from the constraints saves us
from having to compute a minimum on this dimension
using parametric integer programming.  Not only can such an operation
be fairly costly, it can also lead to needless subdivisions if there
are any other constraints on the dimension to be minimized.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_map_is_set

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_*_pullback_pw_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_*_pullback_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_aff_pullback_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_pullback_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_local_space_preimage_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_preimage_pw_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_preimage_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_preimage_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_new_str: fail on NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_multi_aff_align_divs

We will need it in the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_add_div_constraints

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_is_subset: support rational maps

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_map: fix parsing of Omega input

Support for parsing such input was broken by fc5018d (isl_stream_read_map:
accept alternative [i][j] tuple syntax, Sun Jul 3 21:01:01 2011 +0200)
as the two tuples in, say, {Sym=[n] [i] : i <= n } would get merged
into a single tuple (i.e., [n,i]).

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_map: add partial support for reading rational sets

The support is incomplete, but enough to read the inputs in the test
cases of the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_nonneg_set: return a rational set if the input is marked rational

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_aff_zero_set: return a rational set if the input is marked rational

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_list_set_rational

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_set_rational

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_set_set_rational

We will need it in the next commit.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_has_rational

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

reimplement isl_stream_read_aff in terms of isl_stream_read_multi_aff

Reading an isl_aff is essentially a special case of reading an isl_multi_aff.
We therefore do not need any special code for reading an isl_aff, but can
instead read it as an isl_multi_aff and then extract out the isl_aff.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

declare isl_stream_read_multi_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_multi_aff: read tuples directly

The original code would call isl_stream_read_pw_multi_aff, which in
turn first parsed the input as a map.  Not only does this lead to
needless, potentially expensive, conversions, it also makes it difficult
to parse rational expressions.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_input.c: change tuple parsing

Instead of immediately updating an isl_map, we first collect the
information in an isl_multi_pw_aff and then update the isl_map
based on this information.
This will allow us to reuse the tuple parsing in an improved
isl_stream_read_multi_aff.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_multi_aff_range_product

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_splice

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_range_splice

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_set_tuple_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_range_product

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_add_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_*_insert_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_pw_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_multi_aff_from_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_templ.c: rename align_params_multi_set_and to include MULTI(BASE)

This allows isl_pw_multi.c to be included twice from the same file.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_templ.h: avoid reference to explicit element type

This will make it easier to create additional isl_multi_* types.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_multi_*_reset_space_and_domain: call isl_*_reset_domain_space

The original code would call isl_*_reset_space_and_domain,
but the space of the multi_* is clearly different from the space of the *,
so it does not make sense to pass that space to the *.
In case of isl_multi_aff, this does not cause any problems because
isl_aff_reset_space_and_domain ignore the first argument.
However, for an isl_multi_pw_aff, this would cause problems.
Call isl_*_reset_domain_space instead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

generalize isl_multi_aff_flat_range_product

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

generalize isl_multi_aff_drop_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

generalize isl_multi_aff_set_dim_name

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

generalize isl_multi_aff_zero

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

generalize isl_multi_aff_identity

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_zero_on_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_var_on_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_aff_var_on_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_input.c: obj_read_body: simplify error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_drop_constraints_not_involving_dims

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_{set,map}_drop_constraints_involving_dims

We implement these functions on top of the existing
isl_basic_set_drop_constraints_involving which handles dimensions
in terms of absolute positions.  We may want to convert the users
of this old function over to the new functions at some point.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_unshifted_simple_hull

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_stream_read_union_map: force result to be a map

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_union_map_subtract_range

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_set_from_pw_multi_aff: handle NULL input

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_union_map.c: plain_injective_on_range: silence clang warning

Recent clangs complain that "n" may be used uninitialized in the call
to free_isl_fixed_map_array.  However, this only happens data.v is NULL,
in which case free_isl_fixed_map_array does not even look at n.

By moving the initialization of n up, we can silence this warning.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_transitive_closure.c: union_components: avoid invalid access on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_range.c qpolynomial_bound_on_domain_range: avoid invalid access on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_convex_hull.c: initial_facet_constraint: avoid invalid access on error path

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_union: special case universal input

In particular, there is no need to construct a new isl_map
as we can simply return the universal input map.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_gist: special case universal and equal inputs

In both these cases, the solution is trivial and we do not need to
go into the regular computation.
Moreover, if the inputs are equal but not convex, then the original
code would not be able to come to the conclusion that the gist
is the universe.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

export isl_set_plain_cmp

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

doc: clarify use of identifiers

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_set_remove_unknown_divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

and isl_pw_aff_tdiv_q and isl_pw_aff_tdiv_r

These are useful for expressing the result of the corresponding C operators.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_aff_div

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_set_is_disjoint

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_plain_is_disjoint: special case obviously empty inputs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_map_is_empty: special case universal input

In particular, there is no need to compute any sample point on
universal inputs.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_plain_is_disjoint: fix error handling

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff.c: fix typo in comment

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: combine identical divs

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: plug in divs with denominator one

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

extract out isl_local_space_substitute_seq

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

extract out common isl_seq_substitute

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_aff_normalize: sort divs in local space of affine expression

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_local_space_swap_div

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

privately export isl_mat_cmp_div

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

fix isl_union_map_detect_equalities memory management annotation

The signature of that function had accidently an __isl_keep annotation
instead of an __isl_take. Fix this such that the signature in the
header matches the signature of the implementation.

Signed-off-by: Tobias Grosser <tobias@grosser.es>
Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_map_uncurry

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_union_map_subtract_domain

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_pw_*_gist: avoid intersection of domain with context

The intersection was introduced in cf42ba2 (isl_pw_qpolynomial_gist:
substitute equalities in polynomials, Mon Oct 25 13:49:22 2010 +0200)
in order to be able to detect and exploit equalities in the intersection.
However, there is no need to change the domain itself as we can just
as well use a temporary object.

Intersecting the domain with the context is not what the user would
expect as the purpose of the gist operation is to only keep the most
salient information, which is quite the opposite of introducing
extra constraints.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_intersect_domain: avoid useless double reverse

Implementing isl_map_intersect_domain in terms of isl_map_intersect_range
was easier than a proper implementation, but the two calls to
isl_map_reverse can lead to needless inefficiencies.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_intersect_{range,domain}: stop allowing intersection with parameter set

The test was in fact too liberal and would also allow presumably unintended
cases.  Users should call isl_map_intersect_params instead.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_intersect: special case universal input

In particular, there is no need to construct a new isl_map
if one of the arguments to isl_map_intersect is obviously universal.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_constraint_list

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_multi_aff_set_pw_aff

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_pw_multi_aff_identity

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

declare isl_pw_multi_aff_align_params

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

declare isl_basic_map_remove_divs_involving_dims

This function was added in 720f32e (add isl_set_remove_divs_involving_dims,
Wed Oct 27 13:04:04 2010 +0200), but was not exported.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_vec_fdiv_r

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_*_list_insert

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

declare isl_map_fix

This function was added in 72ccd88 (add isl_set_fix,
Wed Oct 21 14:04:29 2009 +0200), but was not exported.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_map_upper_bound_si

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_basic_map_order_ge

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

declare isl_aff_zero_basic_set

This function was added in 6dc44e1 (add isl_pw_aff_eq_set,
Sat Jul 9 12:28:59 2011 +0200), but was not exported.

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

add isl_vec_concat

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_vec_free: return NULL

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_map_free: return NULL

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>

isl_basic_set_free: return NULL

Signed-off-by: Sven Verdoolaege <skimo@kotnet.org>