Kevin Sawicki [Mon, 30 Jan 2017 23:22:44 +0000 (15:22 -0800)]
Update example to use new option keys
Kevin Sawicki [Mon, 30 Jan 2017 22:01:40 +0000 (14:01 -0800)]
Add path and args to LoginItemSettings struct
Charlie Hess [Fri, 27 Jan 2017 19:24:46 +0000 (11:24 -0800)]
Oh, browser_linux is a thing too.
CharlieHess [Thu, 26 Jan 2017 22:15:59 +0000 (14:15 -0800)]
Don't append "%1" in the Run registry key.
It's only necessary for the protocol launch path.
Charlie Hess [Thu, 26 Jan 2017 21:00:47 +0000 (13:00 -0800)]
I will never appreciate standard.
CharlieHess [Thu, 26 Jan 2017 20:35:46 +0000 (12:35 -0800)]
Make sure the spec takes arguments into account.
Charlie Hess [Thu, 26 Jan 2017 20:24:33 +0000 (12:24 -0800)]
Add a spec for this behavior on Windows.
Charlie Hess [Thu, 26 Jan 2017 19:54:37 +0000 (11:54 -0800)]
Fix method signature on macOS.
CharlieHess [Thu, 26 Jan 2017 10:18:18 +0000 (02:18 -0800)]
Line Lengths!
CharlieHess [Thu, 26 Jan 2017 10:05:47 +0000 (02:05 -0800)]
Provide guidance in the docs.
CharlieHess [Thu, 26 Jan 2017 10:05:35 +0000 (02:05 -0800)]
This is rubbish let's pull the escape hatch.
Make all these arguments user-provided instead.
CharlieHess [Wed, 25 Jan 2017 10:19:22 +0000 (02:19 -0800)]
Close to a working Squirrel shortcut.
Charlie Hess [Tue, 24 Jan 2017 03:24:50 +0000 (19:24 -0800)]
First pass at auto-launch supporting Squirrel.
Kevin Sawicki [Fri, 3 Feb 2017 17:58:29 +0000 (09:58 -0800)]
Merge pull request #8509 from electron/upgrading-chrome-doc
Add initial upgrading chrome checklist
Zeke Sikelianos [Fri, 3 Feb 2017 17:55:43 +0000 (09:55 -0800)]
Merge pull request #8583 from crowchirp/docs-typo-fixes
Docs typo fixes
Kevin Sawicki [Wed, 25 Jan 2017 20:31:06 +0000 (12:31 -0800)]
Add initial upgrading chrome checklist
Kevin Sawicki [Fri, 3 Feb 2017 17:53:53 +0000 (09:53 -0800)]
Merge pull request #8572 from electron/content-tracing-app-ready
Document using content tracing after app ready
Kevin Sawicki [Thu, 2 Feb 2017 21:20:38 +0000 (13:20 -0800)]
Use content tracing after app ready
Kevin Sawicki [Fri, 3 Feb 2017 17:44:57 +0000 (09:44 -0800)]
Merge pull request #8570 from electron/force-refresh-menu-role
Add forcereload menu item role
Kevin Sawicki [Thu, 2 Feb 2017 20:01:58 +0000 (12:01 -0800)]
Add forcereload to MenuItem doc
Kevin Sawicki [Thu, 2 Feb 2017 19:18:35 +0000 (11:18 -0800)]
Add forcereload menu item role
Kevin Sawicki [Fri, 3 Feb 2017 17:39:22 +0000 (09:39 -0800)]
Merge pull request #8569 from electron/webview-default-node-integration
Mention presence of webview attributes enables them
Kevin Sawicki [Thu, 2 Feb 2017 18:50:32 +0000 (10:50 -0800)]
Use querySelector to make examples more portable
Kevin Sawicki [Thu, 2 Feb 2017 18:49:05 +0000 (10:49 -0800)]
Change wording from on to present
Kevin Sawicki [Fri, 3 Feb 2017 17:31:58 +0000 (09:31 -0800)]
Merge pull request #8568 from electron/initialize-color-listener-after-app-is-ready
Initialize color listener after app is ready
Kevin Sawicki [Thu, 2 Feb 2017 17:34:20 +0000 (09:34 -0800)]
Initialize color listener after app is ready
Kevin Sawicki [Fri, 3 Feb 2017 16:58:52 +0000 (08:58 -0800)]
Merge pull request #8566 from electron/prompt-to-create-property
Support returning non-existent file paths from Windows open dialog
Chandan Rai [Fri, 3 Feb 2017 16:53:35 +0000 (22:23 +0530)]
Merge remote-tracking branch 'origin/patch-3' into docs-typo-fixes
Chandan Rai [Fri, 3 Feb 2017 16:53:21 +0000 (22:23 +0530)]
Merge remote-tracking branch 'origin/patch-2' into docs-typo-fixes
Chandan Rai [Fri, 3 Feb 2017 13:56:37 +0000 (19:26 +0530)]
corrected typo
Chandan Rai [Fri, 3 Feb 2017 13:41:37 +0000 (19:11 +0530)]
corrected typo
Chandan Rai [Fri, 3 Feb 2017 13:28:21 +0000 (18:58 +0530)]
corrected typo
Kevin Sawicki [Thu, 2 Feb 2017 20:48:19 +0000 (12:48 -0800)]
Merge pull request #8565 from electron/protocol-client-specs
Add protocol client specs on Windows
Kevin Sawicki [Thu, 2 Feb 2017 16:41:14 +0000 (08:41 -0800)]
Add protocol constant
Kevin Sawicki [Thu, 2 Feb 2017 16:11:34 +0000 (08:11 -0800)]
Add procotol client specs on Windows
Kevin Sawicki [Thu, 2 Feb 2017 18:33:20 +0000 (10:33 -0800)]
Merge pull request #8561 from liusy182/!-liusy182-br
add 'code' property in 'before-input-event''s 'input' argument
Kevin Sawicki [Thu, 2 Feb 2017 16:30:02 +0000 (08:30 -0800)]
Add support for FOS_CREATEPROMPT option
liusy182 [Thu, 2 Feb 2017 13:16:30 +0000 (21:16 +0800)]
fix linting error
liusi [Thu, 2 Feb 2017 08:23:07 +0000 (16:23 +0800)]
'before-input-event' is missing the code property #8471
Kevin Sawicki [Mon, 30 Jan 2017 23:34:24 +0000 (15:34 -0800)]
Merge pull request #8487 from leethomas/feature/osx-relative-window-levels
Feature/macOS relative window levels
Kevin Sawicki [Mon, 30 Jan 2017 23:32:05 +0000 (15:32 -0800)]
Wrap params at 80 characters
Kevin Sawicki [Mon, 30 Jan 2017 23:27:51 +0000 (15:27 -0800)]
Indent relativeLevel docs
Kevin Sawicki [Mon, 30 Jan 2017 18:36:15 +0000 (10:36 -0800)]
Merge pull request #8539 from electron/require-wrapper
Update require wrapper to allow redefinition of process and global
Kevin Sawicki [Mon, 30 Jan 2017 18:08:12 +0000 (10:08 -0800)]
Use strictEqual for global variable asserts
Kevin Sawicki [Mon, 30 Jan 2017 17:58:44 +0000 (09:58 -0800)]
Redeclare process/global as strings
Kevin Sawicki [Mon, 30 Jan 2017 17:38:15 +0000 (09:38 -0800)]
Remove throws and assert object directly
James Ide [Wed, 11 Jan 2017 03:29:22 +0000 (19:29 -0800)]
Update the Node submodule to use the new module wrapper
See the fixed issue for the context. This pulls in a vendored copy of Node that includes the described patch.
Fixes #8358
Test Plan: Built Electron and verified it loaded the sample app correctly and that the module wrapper is the new one by viewing Node's source code in the Blink Inspector.
Added specs and tested with `npm test -- --grep "global variables"`
leethomas [Fri, 27 Jan 2017 03:12:10 +0000 (19:12 -0800)]
use kCGMinimumWindowLevelKey to get the minimum level
Kevin Sawicki [Fri, 27 Jan 2017 01:10:21 +0000 (17:10 -0800)]
Merge pull request #8511 from electron/start-drag-crash
Fix startDrag crash on macOS with empty image
Kevin Sawicki [Fri, 27 Jan 2017 00:15:10 +0000 (16:15 -0800)]
Schedule function after executeJavaScript completes
Kevin Sawicki [Thu, 26 Jan 2017 23:48:57 +0000 (15:48 -0800)]
Merge pull request #8421 from oukan/feature/translate-zh-CN
translate zh cn
Kevin Sawicki [Thu, 26 Jan 2017 19:04:59 +0000 (11:04 -0800)]
Mention image cannot be empty on macOS
Kevin Sawicki [Thu, 26 Jan 2017 18:38:13 +0000 (10:38 -0800)]
Require a non-empty drag image to prevent crash
Kevin Sawicki [Thu, 26 Jan 2017 18:34:27 +0000 (10:34 -0800)]
Add specs for missing startDrag options
Kevin Sawicki [Thu, 26 Jan 2017 23:43:58 +0000 (15:43 -0800)]
Merge pull request #8507 from electron/fix-node-upgrade-patches
Redo node 7.4 error handling patch
Kevin Sawicki [Wed, 25 Jan 2017 18:19:38 +0000 (10:19 -0800)]
Fix typo in spec description
Kevin Sawicki [Wed, 25 Jan 2017 17:24:24 +0000 (09:24 -0800)]
Upgrade node for new 7.4 patches and changes
Kevin Sawicki [Wed, 25 Jan 2017 17:04:25 +0000 (09:04 -0800)]
Add spec for unhandledRejection event in main process
Kevin Sawicki [Wed, 25 Jan 2017 16:55:38 +0000 (08:55 -0800)]
Add failing spec for uncaught main process errors
Kevin Sawicki [Thu, 26 Jan 2017 22:44:45 +0000 (14:44 -0800)]
Merge pull request #8519 from electron/consolidate-panel-showing
Use helper function to show last dev tools panel
Kevin Sawicki [Thu, 26 Jan 2017 17:59:07 +0000 (09:59 -0800)]
Remove linter warning
Kevin Sawicki [Thu, 26 Jan 2017 17:57:53 +0000 (09:57 -0800)]
Clear interval before setting new one
Kevin Sawicki [Thu, 26 Jan 2017 17:56:40 +0000 (09:56 -0800)]
Guard against destroyed window or web contents
Kevin Sawicki [Thu, 26 Jan 2017 17:42:45 +0000 (09:42 -0800)]
Use helper function to show last dev tools panel
Kevin Sawicki [Thu, 26 Jan 2017 17:08:52 +0000 (09:08 -0800)]
Merge pull request #8510 from electron/empty-image-crashes
Fix empty image crashes
leethomas [Thu, 26 Jan 2017 15:24:20 +0000 (07:24 -0800)]
fix signature for SetAlwaysOnTop in native window views
leethomas [Thu, 26 Jan 2017 15:14:47 +0000 (07:14 -0800)]
fix js lint errors
leethomas [Thu, 26 Jan 2017 03:39:57 +0000 (19:39 -0800)]
spec to ensure an error is thrown when relativeLevel is set out of bounds
Kevin Sawicki [Wed, 25 Jan 2017 21:52:18 +0000 (13:52 -0800)]
Only call getNativeHandle on macOS
Kevin Sawicki [Wed, 25 Jan 2017 21:22:44 +0000 (13:22 -0800)]
Return empty buffers when image is empty
Kevin Sawicki [Wed, 25 Jan 2017 20:57:20 +0000 (12:57 -0800)]
Add failing spec for empty image crashes
Kevin Sawicki [Wed, 25 Jan 2017 22:23:57 +0000 (14:23 -0800)]
Merge pull request #8357 from electron/remote-events-error-message
Don't crash when calling stale remote listeners
Kevin Sawicki [Tue, 24 Jan 2017 23:09:41 +0000 (15:09 -0800)]
Fix standard linting error
Kevin Sawicki [Tue, 24 Jan 2017 23:05:34 +0000 (15:05 -0800)]
Check that sender is a WebContents instance
Charlie Hess [Thu, 19 Jan 2017 00:09:46 +0000 (16:09 -0800)]
Move console.warn inside the helper method.
Charlie Hess [Wed, 18 Jan 2017 20:44:26 +0000 (12:44 -0800)]
Assert that listener count decreases after a remove event.
Charlie Hess [Fri, 13 Jan 2017 20:28:11 +0000 (12:28 -0800)]
Write a warning instead of crashing.
Charlie Hess [Fri, 13 Jan 2017 02:23:04 +0000 (18:23 -0800)]
Argh.
Charlie Hess [Fri, 13 Jan 2017 01:20:50 +0000 (17:20 -0800)]
Use EventEmitter public methods instead of _events.
Kevin Sawicki [Fri, 13 Jan 2017 00:31:02 +0000 (16:31 -0800)]
Assert remote event names
Charlie Hess [Thu, 12 Jan 2017 23:02:24 +0000 (15:02 -0800)]
Add a spec for the "renderer window closed" error.
Charlie Hess [Wed, 11 Jan 2017 23:33:44 +0000 (15:33 -0800)]
Simplify.
Charlie Hess [Wed, 11 Jan 2017 23:32:43 +0000 (15:32 -0800)]
Review CommentZ
Charlie Hess [Fri, 6 Jan 2017 22:18:14 +0000 (14:18 -0800)]
L I N T I N G P T I I
Charlie Hess [Fri, 6 Jan 2017 22:14:52 +0000 (14:14 -0800)]
L I N T I N G
Charlie Hess [Fri, 6 Jan 2017 21:09:48 +0000 (13:09 -0800)]
Display more information about remote event crashes.
If possible, we'll dig into the function args and print the ones that are attached remotely.
Kevin Sawicki [Wed, 25 Jan 2017 18:54:56 +0000 (10:54 -0800)]
Merge pull request #8497 from electron/enable-crash-reporter-specs-on-ci
Run crash reporter server specs on CI
Kevin Sawicki [Tue, 24 Jan 2017 22:12:35 +0000 (14:12 -0800)]
Run crash reporter server specs on CI
Kevin Sawicki [Wed, 25 Jan 2017 17:46:40 +0000 (09:46 -0800)]
Merge pull request #8478 from deepak1556/load_url_max_char_patch
WebContents: emit did-fail-load event when url exceeds character limit
deepak1556 [Wed, 25 Jan 2017 08:50:33 +0000 (14:20 +0530)]
fix spec
leethomas [Wed, 25 Jan 2017 04:08:08 +0000 (20:08 -0800)]
throw an error for out of bounds window levels
Kevin Sawicki [Tue, 24 Jan 2017 22:08:36 +0000 (14:08 -0800)]
Merge pull request #8430 from ramya-rao-a/crash-for-children-docs
Updated docs for crash reporter to support child processes
Kevin Sawicki [Tue, 24 Jan 2017 22:08:10 +0000 (14:08 -0800)]
Use template strings
Kevin Sawicki [Tue, 24 Jan 2017 22:07:00 +0000 (14:07 -0800)]
Use crashesDirectory in example
Kevin Sawicki [Tue, 24 Jan 2017 22:04:56 +0000 (14:04 -0800)]
Mention how to test
Kevin Sawicki [Tue, 24 Jan 2017 22:03:54 +0000 (14:03 -0800)]
Capitalize Electron, fence as JS
Kevin Sawicki [Tue, 24 Jan 2017 22:02:47 +0000 (14:02 -0800)]
Merge pull request #8109 from ramya-rao-a/crash-for-children
Expose crash reporter start for child node processes
Kevin Sawicki [Tue, 24 Jan 2017 21:58:39 +0000 (13:58 -0800)]
:art:
Kevin Sawicki [Tue, 24 Jan 2017 21:53:05 +0000 (13:53 -0800)]
Add StartInstance helper on CrashReporter
Kevin Sawicki [Tue, 24 Jan 2017 21:49:45 +0000 (13:49 -0800)]
Add spec for crashing node process