platform/upstream/dotnet/runtime.git
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 5 May 2022 00:56:40 +0000 (00:56 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable ZipFile_Unix.UnixCreateSetsPermissionsInExternalAttributes...
Carlos Sanchez [Thu, 5 May 2022 00:44:25 +0000 (17:44 -0700)]
[release/6.0] Disable ZipFile_Unix.UnixCreateSetsPermissionsInExternalAttributes (#68867)

Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 4 May 2022 20:25:23 +0000 (20:25 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] JIT: fix bug where a gc struct is not zero initialized (#68050)
Andy Ayers [Wed, 4 May 2022 20:12:23 +0000 (13:12 -0700)]
[release/6.0] JIT: fix bug where a gc struct is not zero initialized (#68050)

Port of #67825 to release/6.0.

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 4 May 2022 19:51:10 +0000 (19:51 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix in-process decoding of DateTime in EventSource (#68352)
github-actions[bot] [Wed, 4 May 2022 19:37:54 +0000 (12:37 -0700)]
[release/6.0] Fix in-process decoding of DateTime in EventSource (#68352)

* Fix in-process decoding of DateTime in EventSource

* Update eventlistener test to validate DateTime is correctly decoded in-process

* Use UTC time everywhere

Co-authored-by: John Salem <josalem@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 4 May 2022 17:56:59 +0000 (17:56 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] add support for parsing Unified TLS hello (#68425)
Tomas Weinfurt [Wed, 4 May 2022 17:44:36 +0000 (10:44 -0700)]
[release/6.0] add support for parsing Unified TLS hello (#68425)

* add support for parsing Unified TLS hello

* feedback from review

* update comment

2 years ago[release/6.0] Handle parameterless ctors in structs in STJ's ReflectionEmitMemberAcce...
Egor Bogatov [Wed, 4 May 2022 17:43:47 +0000 (19:43 +0200)]
[release/6.0] Handle parameterless ctors in structs in STJ's ReflectionEmitMemberAccessor (#67901)

* [release/6.0] backport #62989 "Handle parameterless ctors in structs in STJ's ReflectionEmitMemberAccessor"

* Add explicit parameterless constructors in the tests

* Update ConstructorTests.ParameterMatching.cs

* address feedback

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 4 May 2022 02:42:20 +0000 (02:42 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Use x64 directory if running x64 process on arm64 apphost (#68583)
Elinor Fung [Wed, 4 May 2022 02:29:11 +0000 (19:29 -0700)]
[release/6.0] Use x64 directory if running x64 process on arm64 apphost (#68583)

* Use x64 directory if running x64 process on arm64 apphost

Backport of #59890

* Fix is_emulating_x64 on Windows (#68671)

Co-authored-by: Mateo Torres-Ruiz <mateoatr@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 4 May 2022 00:03:06 +0000 (00:03 +0000)]
Merge in 'release/6.0' changes

2 years agoDisable profiler multiple test against JIT and GC stress runs (#68501)
Tom McDonald [Tue, 3 May 2022 23:50:19 +0000 (19:50 -0400)]
Disable profiler multiple test against JIT and GC stress runs (#68501)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 3 May 2022 23:37:20 +0000 (23:37 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Tue, 3 May 2022 23:36:39 +0000 (23:36 +0000)]
Merge in 'release/6.0' changes

2 years ago[Release/6.0] Backport test fixes (#68332)
Radek Zikmund [Tue, 3 May 2022 23:34:22 +0000 (16:34 -0700)]
[Release/6.0] Backport test fixes (#68332)

* Resolve System.Net.Security.Tests.LoggingTest SkipTestException failure (#65322)

* improve Tls12 detection on Windows7 (#67935)

* disable Tls 1.0 and 1.1 tests on new Windows (#68083)

* Don't throw from RemoteExecutor on SkipTestExceptions (#65105)

* update SSL tests to deal better with disabled protocols (#65120)

* update SSL tests to deal better with disabled protocols

* Improve detection of Null encryption on Windows

* update expectation for Mismatched protocols

* update detection

* wrap win32 exception

* update ProtocolMismatchData sets

* remove debug print

* final cleanup

* generate mismatch data

* avoid SslProtocols.Default

Co-authored-by: Miha Zupan <mihazupan.zupan1@gmail.com>
Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
2 years ago[release/6.0] Fix the logic for regions detection (#67995)
github-actions[bot] [Tue, 3 May 2022 23:31:53 +0000 (16:31 -0700)]
[release/6.0] Fix the logic for regions detection (#67995)

* Fix the logic for regions detection

* Fix region check name on .NET 6

Co-authored-by: Andrew Au <andrewau@microsoft.com>
Co-authored-by: Juan Sebastian Hoyos Ayala <juan.hoyos@microsoft.com>
2 years agoAdd single-file debugging to DBI (#67934)
Mike McLaughlin [Tue, 3 May 2022 23:31:22 +0000 (18:31 -0500)]
Add single-file debugging to DBI (#67934)

Add new CoreCLRCreateCordbObjectEx2 API that takes the DAC module path instead of
assuming the DAC module is in the same directory as DBI.

2 years ago[release/6.0] Don't cache commandline in coreclr diagnostics server (#63356)
github-actions[bot] [Tue, 3 May 2022 23:25:28 +0000 (16:25 -0700)]
[release/6.0] Don't cache commandline in coreclr diagnostics server (#63356)

* Don't cache commandline in coreclr diagnostics server

* Validate behavior of ProcessInfo command before and after suspension point (#63382)

This only applies to CoreCLR Unix processes.

* Apply feedback to prevent rare race

* Add InterlockedCompareExchange to ensure we only leak once if ever

Co-authored-by: John Salem <josalem@microsoft.com>
2 years agoUpdate branding to 6.0.6 (#68825)
vseanreesermsft [Tue, 3 May 2022 23:24:53 +0000 (16:24 -0700)]
Update branding to 6.0.6 (#68825)

* Update branding to 6.0.6

* Reset GeneratePackageOnBuild in OOB packages.

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 16:47:07 +0000 (16:47 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix cancel in PipeReader.ReadAtLeastAsync (#66870)
github-actions[bot] [Wed, 13 Apr 2022 16:36:31 +0000 (09:36 -0700)]
[release/6.0] Fix cancel in PipeReader.ReadAtLeastAsync (#66870)

* Fix cancel in PipeReader.ReadAtLeastAsync

* Add missing GeneratePackageOnBuild and bump version

Co-authored-by: Brennan <brecon@microsoft.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
2 years agoEnsure serializer reflection-dependency sentinel is accurate (#67104)
Eirik Tsarpalis [Wed, 13 Apr 2022 16:33:23 +0000 (17:33 +0100)]
Ensure serializer reflection-dependency sentinel is accurate (#67104)

* Ensure serializer reflection-dependency sentinel is accurate

* update servicing version

Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 16:04:32 +0000 (16:04 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 16:01:15 +0000 (16:01 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Disable test Runtime_56953 (#67604)
Bruce Forstall [Wed, 13 Apr 2022 16:00:10 +0000 (09:00 -0700)]
[release/6.0] Disable test Runtime_56953 (#67604)

This avoids a JIT assert in jitstress test runs.

We don't intend to fix the underlying issues in release/6.0 branch.

Tracking: https://github.com/dotnet/runtime/issues/67603

2 years agoUpgrading the version of Package Validation used in the repo to reduce Build flakines...
Jose Perez Rodriguez [Wed, 13 Apr 2022 15:57:39 +0000 (08:57 -0700)]
Upgrading the version of Package Validation used in the repo to reduce Build flakiness when loading Roslyn (#66635)

* Upgrading the version of Package Validation used in the repo to reduce Build flakiness when loading Roslyn

* remove workaround

Co-authored-by: Dan Moseley <danmose@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 15:55:32 +0000 (15:55 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] [Mono] Fix uninitialized vtable bug (#67759)
github-actions[bot] [Wed, 13 Apr 2022 15:55:05 +0000 (08:55 -0700)]
[release/6.0] [Mono] Fix uninitialized vtable bug (#67759)

* Add functional test

* Fix vtable setup

* Add suggested code changes

* Improve arguments ordering

Co-authored-by: Simon Rozsival <simon@rozsival.com>
2 years ago[wasm] Bundle net472 dependencies for MonoAOTCompiler task (#67757)
github-actions[bot] [Wed, 13 Apr 2022 15:54:04 +0000 (08:54 -0700)]
[wasm] Bundle net472 dependencies for MonoAOTCompiler task (#67757)

.. same as what we do for WasmAppBuilder, and MonoTargets.

Without this, it would work if msbuild/VS happened to load the expected
System.Reflection.Metadata assembly before loading the task. But break
when it didn't. And that breakage happens with 7.0*p3 with VS 17.2 .

msbuild, and VS break with:
```
The "MonoAOTCompiler" task failed unexpectedly.System.IO.FileNotFoundException: Could not load file or assembly 'System.Reflection.Metadata, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies.
    The system cannot find the file specified.File name: 'System.Reflection.Metadata, Version=6.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
        at MonoAOTCompiler.FilterAssemblies(IEnumerable`1 assemblies)
        at MonoAOTCompiler.ExecuteInternal()
        at MonoAOTCompiler.Execute()
        at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
        at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

    WRN: Assembly binding logging is turned OFF.To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.Note: There is some performance penalty associ ated with assembly bind failure logging.To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
```

These are the files bundled for net472 now:

```
tasks/net472/Microsoft.Bcl.AsyncInterfaces.dll
tasks/net472/Microsoft.Build.dll
tasks/net472/Microsoft.Build.Framework.dll
tasks/net472/Microsoft.Build.Tasks.Core.dll
tasks/net472/Microsoft.Build.Utilities.Core.dll
tasks/net472/Microsoft.NET.StringTools.dll
tasks/net472/Microsoft.VisualStudio.Setup.Configuration.Interop.dll
tasks/net472/MonoAOTCompiler.dll
tasks/net472/MonoAOTCompiler.dll.config
tasks/net472/System.Buffers.dll
tasks/net472/System.Collections.Immutable.dll
tasks/net472/System.Configuration.ConfigurationManager.dll
tasks/net472/System.Memory.dll
tasks/net472/System.Numerics.Vectors.dll
tasks/net472/System.Reflection.Metadata.dll
tasks/net472/System.Resources.Extensions.dll
tasks/net472/System.Runtime.CompilerServices.Unsafe.dll
tasks/net472/System.Security.AccessControl.dll
tasks/net472/System.Security.Permissions.dll
tasks/net472/System.Security.Principal.Windows.dll
tasks/net472/System.Text.Encodings.Web.dll
tasks/net472/System.Text.Json.dll
tasks/net472/System.Threading.Tasks.Dataflow.dll
tasks/net472/System.Threading.Tasks.Extensions.dll
tasks/net472/System.ValueTuple.dll
```

Issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1520454

Co-authored-by: Ankit Jain <radical@gmail.com>
2 years agoAdd arm64 cross-arch msi installers (#67265)
github-actions[bot] [Wed, 13 Apr 2022 15:50:45 +0000 (08:50 -0700)]
Add arm64 cross-arch msi installers (#67265)

Expanding architecture support

Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
2 years agoAdd a --aot-lazy-assembly-load command line option to load assemblies… (#67024) ...
Aleksey Kliger (λgeek) [Wed, 13 Apr 2022 15:49:03 +0000 (11:49 -0400)]
Add a --aot-lazy-assembly-load command line option to load assemblies… (#67024) (#67103)

* Add a --aot-lazy-assembly-load command line option to load assemblies referenced by AOT images lazily.

Note that this requires the assemblies used at AOT time to exactly match
the assemblies loaded at runtime, otherwise the runtime will abort
when it loads the mismatching reference.

* Handle the options added by options.h in mono_jit_parse_options ().

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
2 years agoAdd additional trace to HttpConnectionPool (#66958)
Natalia Kondratyeva [Wed, 13 Apr 2022 15:48:34 +0000 (17:48 +0200)]
Add additional trace to HttpConnectionPool (#66958)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 15:47:56 +0000 (15:47 +0000)]
Merge in 'release/6.0' changes

2 years agoFix unaligned UTF16 string read in collect tracing EventPipe command. (#66828)
Johan Lorensson [Wed, 13 Apr 2022 15:43:47 +0000 (17:43 +0200)]
Fix unaligned UTF16 string read in collect tracing EventPipe command. (#66828)

Collect tracing 2 EventPipe command triggers an unaligned UTF16 string
read that could cause a SIGBUS on platforms not supporting unalinged
reads of UTF16 strings (so far only seen on 32-bit ARM Linux CI machine).

On CoreCLR this could even cause a unalinged int read due to
optimizations used in UTF8Encoding::GetByteCount.

2 years agoFix macOS ARM64 stack overflow detection (#66612)
github-actions[bot] [Wed, 13 Apr 2022 15:43:18 +0000 (08:43 -0700)]
Fix macOS ARM64 stack overflow detection (#66612)

We were incorrectly using exception_data_type_t instead of mach_exception_data_type_t
in the PAL due to a missing change when we have added support for ARM64 macOS.

The wrong type was 32 bit and it caused the address of a hardware exception to have
the upper 32 bits cut off. That prevented us from detecting stack overflow correctly.

Co-authored-by: Jan Vorlicek <janvorli@microsoft.com>
2 years agoMerged PR 21350: [MSRC 69437] Apply MaxResponseHeadersLength limit for trailing headers
Miha Zupan [Wed, 13 Apr 2022 15:36:55 +0000 (15:36 +0000)]
Merged PR 21350: [MSRC 69437] Apply MaxResponseHeadersLength limit for trailing headers

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 15:36:33 +0000 (15:36 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Add dynamic shim for SSL_CTX_set_options and SSL_set_options (#67145)
github-actions[bot] [Wed, 13 Apr 2022 15:35:53 +0000 (08:35 -0700)]
[release/6.0] Add dynamic shim for SSL_CTX_set_options and SSL_set_options (#67145)

* Add dynamic shim for SSL_CTX_set_options

This works around ABI breaking change made between OpenSSL 1.1 and 3.0 where argument type and return type was changed from unsigned long to uint64_t, which caused issues on arm32 architectures with OpenSSL 3.0 installed.

* Fix typo

* Update src/native/libs/System.Security.Cryptography.Native/pal_ssl.c

Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/native/libs/System.Security.Cryptography.Native/pal_ssl.c

Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
* Code review feedback

Co-authored-by: Radek Zikmund <r.zikmund.rz@gmail.com>
Co-authored-by: Radek Zikmund <32671551+rzikm@users.noreply.github.com>
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Co-authored-by: Tomas Weinfurt <tweinfurt@yahoo.com>
2 years ago[release/6.0] Fix DNS cancellation deadlock (#67291)
github-actions[bot] [Wed, 13 Apr 2022 15:34:50 +0000 (08:34 -0700)]
[release/6.0] Fix DNS cancellation deadlock (#67291)

* tests

* remove lock

* comments, outerloop

* use Volatile.Write

* test comments

* SafeHandle to avoid use-after-free race condition

* use NativeMemory APIs

* Disable DnsGetHostEntry_PostCancelledToken_Throws on Win7

* Fix compilation

Co-authored-by: Anton Firszov <antonfir@gmail.com>
Co-authored-by: Radek Zikmund <radekzikmund@microsoft.com>
2 years agoAvoid issuing connection attempts for already cancelled requests (#66992) (#67226)
Miha Zupan [Wed, 13 Apr 2022 15:31:54 +0000 (17:31 +0200)]
Avoid issuing connection attempts for already cancelled requests (#66992) (#67226)

* Avoid issuing connection attempts for already canceled requests

* Cancelled => Canceled

* Guard SocketsHttpHandler tests under SocketsHttpHandler.IsSupported

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 15:31:40 +0000 (15:31 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Load R2R images on osx-arm64 according to Apple's guidelines (#67438)
Jonathan Giannuzzi [Wed, 13 Apr 2022 15:24:01 +0000 (16:24 +0100)]
[release/6.0] Load R2R images on osx-arm64 according to Apple's guidelines (#67438)

* Fix Compiler::impImportNewObjArray on osx-arm64

* Reject R2R images containing calls to CORINFO_HELP_NEW_MDARR

* Load R2R images on osx-arm64 according to Apple's guidelines

2 years ago[release/6.0] Ignore non-X509 certificates in SignedCms (#67462)
Jeremy Barton [Wed, 13 Apr 2022 15:23:24 +0000 (08:23 -0700)]
[release/6.0] Ignore non-X509 certificates in SignedCms  (#67462)

* Ignore non-X509 certificates in SignedCms

This allows for AttributeCertificateV1/AttributeCertificateV2/OtherCertificate
entries in the SignedCms without causing a decode error.  That data is not presented
to callers via the SignedCms object, but the behavior is consistent with SignedCms on
.NET Framework and its underlying WinCryptMsg counterpart.

* Add packaging changes for servicing

2 years ago[release/6.0] Fix loop cloning of array of struct with array field (#67496)
Bruce Forstall [Wed, 13 Apr 2022 15:20:55 +0000 (08:20 -0700)]
[release/6.0] Fix loop cloning of array of struct with array field (#67496)

Loop cloning needs to parse what morph creates from GT_INDEX nodes
to determine if there are array accesses with bounds checks that
could potentially be optimized. For jagged array access, this can
be a "comma chain" of bounds checks and array element address expressions.
For a case where an array of structs had a struct field, such as
`ValueTuple<int[], int>[]`, cloning was confusing the expression
`a[i].Item1[j]` for the jagged array access `a[i][j]`.

The fix here is to keep track of the type of the `GT_INDEX` node that is
being morphed, in the `GT_BOUNDS_CHECK` node that is created for it.
(This is the only thing cloning parses, to avoid the need to parse
the very complex trees morph can create.) This type is then checked
when parsing the "comma chain" trees. If a non-`TYP_REF` is found (such
as a `TYP_STRUCT` in the above example), no more levels of array indexing
are considered. (`TYP_REF` is what an array object would have, for a jagged
array.)

Fixes #66254.

2 years ago[release/6.0] [AOT] Don't set the 'CorrectedSynthesize' flag in the objc_imageinfo...
github-actions[bot] [Wed, 13 Apr 2022 15:19:31 +0000 (08:19 -0700)]
[release/6.0] [AOT] Don't set the 'CorrectedSynthesize' flag in the objc_imageinfo section. (#67534)

* [AOT] Don't set the 'CorrectedSynthesize' flag in the objc_imageinfo section.

According to Apple's headers, it's not used anymore, and ignored.

However, with Xcode 13.3, it seems Apple has re-used this value for something
else, and it's causing warnings in the linker:

> ld: warning: '[...]/arm64/Xamarin.iOS.dll.o' was built with class_ro_t pointer signing enabled, but previous .o files were not

Fixes https://github.com/mono/mono/issues/21450.

Ref: https://opensource.apple.com/source/objc4/objc4-818.2/runtime/objc-abi.h.auto.html

* Don't set the 'CorrectedSynthesize' flag when using LLVM either.

Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
2 years agoMerge pull request #67602 from mikem8361/fixunwind60
Carlos Sanchez [Wed, 13 Apr 2022 15:18:33 +0000 (08:18 -0700)]
Merge pull request #67602 from mikem8361/fixunwind60

Fix remote unwinding on MacOS Monterey (12)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 13 Apr 2022 04:44:58 +0000 (04:44 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge pull request #67928 from vseanreesermsft/internal-merge-6.0-2022-04-12-1157
Carlos Sanchez [Wed, 13 Apr 2022 04:30:21 +0000 (21:30 -0700)]
Merge pull request #67928 from vseanreesermsft/internal-merge-6.0-2022-04-12-1157

Merging internal commits for release/6.0

2 years agoMerge commit 'be98e88c760526452df94ef452fff4602fb5bded' into internal-merge-6.0-2022...
Sean Reeser [Tue, 12 Apr 2022 18:57:57 +0000 (11:57 -0700)]
Merge commit 'be98e88c760526452df94ef452fff4602fb5bded' into internal-merge-6.0-2022-04-12-1157

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 11 Apr 2022 18:25:11 +0000 (18:25 +0000)]
Merge in 'release/6.0' changes

2 years agoAdd libssl3 dependency (#67705)
github-actions[bot] [Mon, 11 Apr 2022 18:08:58 +0000 (11:08 -0700)]
Add libssl3 dependency (#67705)

Co-authored-by: Nikola Milosavljevic <nikolam@microsoft.com>
2 years agoCode review feedback. Update licensing
Mike McLaughlin [Wed, 6 Apr 2022 17:56:02 +0000 (10:56 -0700)]
Code review feedback. Update licensing

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 6 Apr 2022 15:41:02 +0000 (15:41 +0000)]
Merge in 'release/6.0' changes

2 years agoimprove SslStream tests on server 2022 (#67240)
Natalia Kondratyeva [Wed, 6 Apr 2022 15:27:10 +0000 (17:27 +0200)]
improve SslStream tests on server 2022 (#67240)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 6 Apr 2022 00:17:51 +0000 (00:17 +0000)]
Merge in 'release/6.0' changes

2 years agoMove to Windows.10.Amd64.Server2022.ES.Open (#67054)
Elinor Fung [Wed, 6 Apr 2022 00:05:30 +0000 (17:05 -0700)]
Move to Windows.10.Amd64.Server2022.ES.Open (#67054)

2 years agoUpdate branding to 6.0.5 (#67615)
vseanreesermsft [Wed, 6 Apr 2022 00:03:57 +0000 (17:03 -0700)]
Update branding to 6.0.5 (#67615)

* Update branding to 6.0.5

* Remove GeneratePackageOnBuild from all projects which added it in 6.0.4

Co-authored-by: Eric StJohn <ericstj@microsoft.com>
2 years agoCode review feedback
Mike McLaughlin [Tue, 5 Apr 2022 22:04:12 +0000 (15:04 -0700)]
Code review feedback

2 years agoFix remote unwinding on MacOS Monterey (12)
Mike McLaughlin [Wed, 30 Mar 2022 23:37:08 +0000 (16:37 -0700)]
Fix remote unwinding on MacOS Monterey (12)

VS4Mac crash reports on MacOS v12 (Monterey) are missing native stack frames. Can not properly triage VS4Mac failures.

Issue: https://github.com/dotnet/diagnostics/issues/2924

The amd64 frameless compact encoding is being used now in MacOS version 12 and needed to be implemented.

VS4Mac confirmed that this fixes the missing native frame issue on MacOS x64.

Low. Only affects createdump and DAC.

2 years agoMerged PR 21497: [release/6.0] MSRC 68590 - newlines in domain literals
Tomas Weinfurt [Mon, 14 Mar 2022 16:20:56 +0000 (16:20 +0000)]
Merged PR 21497:  [release/6.0] MSRC 68590 - newlines in domain literals

This add validation for embedded newlines in email addresses.
Based on https://dev.azure.com/dnceng/internal/_git/dotnet-runtime/pullrequest/20738
There is opt-in System.Net.Mail.EnableFullDomainLiterals switch to allow previous behavior

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Mon, 14 Mar 2022 03:03:20 +0000 (03:03 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Update dependencies from dotnet/emsdk dotnet/arcade (#66144)
dotnet-maestro[bot] [Mon, 14 Mar 2022 02:46:09 +0000 (19:46 -0700)]
[release/6.0] Update dependencies from dotnet/emsdk dotnet/arcade (#66144)

* Update dependencies from https://github.com/dotnet/arcade build 20220222.7

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22107.2 -> To Version 2.5.1-beta.22122.7

* Update dependencies from https://github.com/dotnet/emsdk build 20220308.1

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.2 -> To Version 6.0.3

* Fix weird character problem

* Update dependencies from https://github.com/dotnet/emsdk build 20220308.2

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
 From Version 6.0.2 -> To Version 6.0.4

* Update dependencies from https://github.com/dotnet/arcade build 20220309.8

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22107.2 -> To Version 2.5.1-beta.22159.8

* On run package validation for CSProj-built packages

This fixes an issue where a non-CSProj built package would load
MS.CA.dll , then a CSProj would try to load MS.CA.CS.dll of a different
version and it's MS.CA types would not agree with those already bound
to the task from previous load.

Further details:
https://github.com/dotnet/sdk/pull/22277

* Update dependencies from https://github.com/dotnet/emsdk build 20220311.2

Microsoft.NET.Workload.Emscripten.Manifest-6.0.100 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.200 , Microsoft.NET.Workload.Emscripten.Manifest-6.0.300
 From Version 6.0.4 -> To Version 6.0.4

* Update dependencies from https://github.com/dotnet/arcade build 20220311.1

Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.GenAPI , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.GenFacades , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk
 From Version 2.5.1-beta.22107.2 -> To Version 2.5.1-beta.22161.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 11 Mar 2022 20:55:46 +0000 (20:55 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] update expected exception for cases when all requested TLS versions...
github-actions[bot] [Fri, 11 Mar 2022 20:51:44 +0000 (12:51 -0800)]
[release/6.0] update expected exception for cases when all requested TLS versions are disabled (#65046)

* update expected exception for cases when all requested TLS versions are disabled

* port test fix

Co-authored-by: wfurt <tweinfurt@yahoo.com>
Co-authored-by: Dan Moseley <danmose@microsoft.com>
2 years agoImprove SSL platform detection (#64923) (#65054)
Tomas Weinfurt [Fri, 11 Mar 2022 20:42:03 +0000 (12:42 -0800)]
Improve SSL platform detection (#64923) (#65054)

* CI matrix change: add Windows Server 2022

* Add registry check for ssl3 - tls1.2 tests

* Disable TLS1.3 on framework code

* Fix typo

* revert queue change

Co-authored-by: Jan Jahoda <jajahoda@microsoft.com>
Co-authored-by: Jan Jahoda <jajahoda@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 11 Mar 2022 20:17:42 +0000 (20:17 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] improve SslStream tests on misconfigured systems (#65024)
github-actions[bot] [Fri, 11 Mar 2022 20:02:29 +0000 (12:02 -0800)]
[release/6.0] improve SslStream tests on misconfigured systems (#65024)

* improve SslStream tests on misconfigured systems

* feedback from review

Co-authored-by: wfurt <tweinfurt@yahoo.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 11 Mar 2022 19:34:39 +0000 (19:34 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix catching of generic exception in crossgened shared generic code...
github-actions[bot] [Fri, 11 Mar 2022 19:20:17 +0000 (11:20 -0800)]
[release/6.0] Fix catching of generic exception in crossgened shared generic code  (#66207)

* Add regression test for #66005

* Fix

* Update src/coreclr/tools/Common/JitInterface/CorInfoImpl.cs

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Fri, 11 Mar 2022 01:12:57 +0000 (01:12 +0000)]
Merge in 'release/6.0' changes

2 years agostabilize quic tests on server 2022 (#65097)
github-actions[bot] [Fri, 11 Mar 2022 01:07:35 +0000 (17:07 -0800)]
stabilize quic tests on server 2022 (#65097)

Co-authored-by: wfurt <tweinfurt@yahoo.com>
2 years ago[release/6.0] Run tests for internal azdo PRs (#65526)
Santiago Fernandez Madero [Fri, 11 Mar 2022 01:02:29 +0000 (17:02 -0800)]
[release/6.0] Run tests for internal azdo PRs (#65526)

* Run tests for internal azdo PRs

* PR Feedback

* Fix PGO jobs on official builds

We missed passing in the `isOfficialBuild` variable on the PGO jobs.

* Don't run upload-intermediate-artifacts-step.yml for PGO leg

* Fix .yml

Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years agoDefine SystemReflectionMetadataLoadContextVersion property for package references...
Michael Simons [Fri, 11 Mar 2022 00:56:28 +0000 (18:56 -0600)]
Define SystemReflectionMetadataLoadContextVersion property for package references (#65614)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 23:17:50 +0000 (23:17 +0000)]
Merge in 'release/6.0' changes

2 years agoRID for Ubuntu 22.04 (#66225)
Tomas Weinfurt [Thu, 10 Mar 2022 23:05:01 +0000 (15:05 -0800)]
RID for Ubuntu 22.04 (#66225)

2 years agoFix compatibility with NTLM authentication to McAfee Web Gateway (#66315)
github-actions[bot] [Thu, 10 Mar 2022 23:03:28 +0000 (15:03 -0800)]
Fix compatibility with NTLM authentication to McAfee Web Gateway (#66315)

Co-authored-by: Filip Navara <navara@emclient.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 21:16:11 +0000 (21:16 +0000)]
Merge in 'release/6.0' changes

2 years agobackport of 66295 (#66301)
Thays Grazia [Thu, 10 Mar 2022 21:01:02 +0000 (18:01 -0300)]
backport of 66295 (#66301)

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 20:48:45 +0000 (20:48 +0000)]
Merge in 'release/6.0' changes

2 years ago[monoapi] Add mono_method_get_unmanaged_callers_only_ftnptr (#66299)
Aleksey Kliger (λgeek) [Thu, 10 Mar 2022 20:44:48 +0000 (15:44 -0500)]
[monoapi] Add mono_method_get_unmanaged_callers_only_ftnptr (#66299)

Like `RuntimeMethodHandle.GetFunctionPointer`, but callable from native code

2 years agoRemove redundant allocations from JsonSerializerOptions.GetConverter calls (#65898)
Eirik Tsarpalis [Thu, 10 Mar 2022 20:42:32 +0000 (20:42 +0000)]
Remove redundant allocations from JsonSerializerOptions.GetConverter calls (#65898)

* Fix default converter reallocation on each call to JsonSerializerOptions.GetConverter

* ensure package is released

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 20:40:51 +0000 (20:40 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 20:39:10 +0000 (20:39 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 20:38:25 +0000 (20:38 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0] Fix Queryable-to-Enumerable overload mapping logic (#65857)
github-actions[bot] [Thu, 10 Mar 2022 20:37:58 +0000 (12:37 -0800)]
[release/6.0] Fix Queryable-to-Enumerable overload mapping logic (#65857)

* Fix Queryable-to-Enumerable overload mapping logic

* fix linker warnings

* address feedback

* use strict order when calculating maximal elements

Co-authored-by: Eirik Tsarpalis <eirik.tsarpalis@gmail.com>
2 years ago[release/6.0] Backport Fix PerformanceCounter's when running with Globalization Invar...
Tarek Mahmoud Sayed [Thu, 10 Mar 2022 20:36:32 +0000 (12:36 -0800)]
[release/6.0] Backport Fix PerformanceCounter's when running with Globalization Invariant Mode (#65537)

* [dotnet/runtime] Backport Fix PerformanceCounter's when running with Globalization Invariant Mode (PR #65414)

* Add GeneratePackageOnBuild & ServicingVersion project properties

2 years ago[release/6.0] [mono] Fix stacktrace from DIM (#65509)
Thays Grazia [Thu, 10 Mar 2022 20:35:27 +0000 (17:35 -0300)]
[release/6.0] [mono] Fix stacktrace from DIM (#65509)

* Backport of #60770 and #64566

* Fixing missing end line

2 years agoRemove OpenSSL error queue checking after initialization (#65501)
github-actions[bot] [Thu, 10 Mar 2022 20:35:03 +0000 (12:35 -0800)]
Remove OpenSSL error queue checking after initialization (#65501)

Co-authored-by: Radek Zikmund <r.zikmund.rz@gmail.com>
2 years ago[release/6.0] [Android] Workaround for invalid return value from clock_nanosleep...
Simon Rozsival [Thu, 10 Mar 2022 20:31:16 +0000 (21:31 +0100)]
[release/6.0] [Android] Workaround for invalid return value from clock_nanosleep (#65372)

* [Android] Workaround for invalid return value from clock_nanosleep (#64679)

There used to be a bug in Android libc implementation of `clock_nanosleep`. The return value should be `errno` on errors  but instead in it returns `-1` and sets `errno`. The libc (Bionic) bug [has been fixed](https://android-review.googlesource.com/c/platform/bionic/+/110652/) since Android 6 and newer but it causes problems to [customers who are unable to update Android on their devices](https://github.com/xamarin/xamarin-android/issues/6600#issuecomment-1026023654).

Fixes https://github.com/xamarin/xamarin-android/issues/6600

* Account for incorrect implementation of clock_nanosleep in older Android libc

* Shorten comments

* Add g_clock_nanosleep function

* Add remap definition

* Fix build

* Make sure the extra check runs only on Android

* Make Windows builds happy

* Try making wasm builds happy

* Fix leftover direct call to clock_nanosleep

2 years ago[mono] Fix r8->i conversion on amd64/arm64. (#65329)
github-actions[bot] [Thu, 10 Mar 2022 20:27:31 +0000 (12:27 -0800)]
[mono] Fix r8->i conversion on amd64/arm64. (#65329)

Fixes https://github.com/dotnet/runtime/issues/64386.

Co-authored-by: Zoltan Varga <vargaz@gmail.com>
2 years ago[mono][s390x] Fix OP_FCONV_TO_I and OP_RCONV_TO_I (#65328)
github-actions[bot] [Thu, 10 Mar 2022 20:23:58 +0000 (12:23 -0800)]
[mono][s390x] Fix OP_FCONV_TO_I and OP_RCONV_TO_I (#65328)

* OP_[FR]CONV_TO_I should result in an 8-byte integer

Co-authored-by: Ulrich Weigand <ulrich.weigand@de.ibm.com>
2 years ago[release/6.0] vtable setup fix for generic default interface methods in mono runtime...
github-actions[bot] [Thu, 10 Mar 2022 20:23:37 +0000 (12:23 -0800)]
[release/6.0] vtable setup fix for generic default interface methods in mono runtime (#64754)

* vtable setup fix for generic default interface methods in mono runtime

When processing the overrides from interface default methods we should
check if the interface class is a generic type definition first and
inflate with the interface class context.

Test case included.

* Update test to ensure that the correct context is used

Co-authored-by: Bill Holmes <bill.holmes@unity3d.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 19:56:33 +0000 (19:56 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge pull request #66373 from steveisok/bump-manifest-band-300
Eric StJohn [Thu, 10 Mar 2022 19:41:23 +0000 (11:41 -0800)]
Merge pull request #66373 from steveisok/bump-manifest-band-300

[release/6.0] Bump runtime workload manifest to 300 / update emsdk dependency

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 18:44:31 +0000 (18:44 +0000)]
Merge in 'release/6.0' changes

2 years agoMerge pull request #65330 from dotnet/backport/pr-65326-to-release/6.0
Eric StJohn [Thu, 10 Mar 2022 18:29:46 +0000 (10:29 -0800)]
Merge pull request #65330 from dotnet/backport/pr-65326-to-release/6.0

[release/6.0] Remove Unused Encoding on UriHelper

2 years agoMerge in 'release/6.0' changes
dotnet-bot [Thu, 10 Mar 2022 18:22:29 +0000 (18:22 +0000)]
Merge in 'release/6.0' changes

2 years ago[release/6.0][wasm] Backport skipping System.Text.Json tests for aot configuration...
Steve Pfister [Thu, 10 Mar 2022 18:05:45 +0000 (13:05 -0500)]
[release/6.0][wasm] Backport skipping System.Text.Json tests for aot configuration (#66366)

Partial backport of https://github.com/dotnet/runtime/pull/65413

https://github.com/dotnet/runtime/issues/61524 - OOM while linking `System.Text.Json.Tests`

Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
2 years agoMerge in 'release/6.0' changes
dotnet-bot [Wed, 9 Mar 2022 20:00:57 +0000 (20:00 +0000)]
Merge in 'release/6.0' changes