Christopher Michael [Wed, 29 May 2019 19:37:07 +0000 (15:37 -0400)]
evas_inline: Clean up evas_object_is_opaque function
Summary:
This file is full of functions called as:
foo(eo_obj, obj);
Most of them can be reduced to foo(obj); and internally get the eo_obj
with obj->object
This would make it impossible to screw up calling them passing an
unrelated pair, and make calling code a little more readable.
ref T7230
Depends on D9048
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7230
Differential Revision: https://phab.enlightenment.org/D9049
Christopher Michael [Wed, 29 May 2019 19:36:59 +0000 (15:36 -0400)]
evas_inline: Clean up evas_object_is_proxy_visible function
Summary:
This file is full of functions called as:
foo(eo_obj, obj);
Most of them can be reduced to foo(obj); and internally get the eo_obj
with obj->object
This would make it impossible to screw up calling them passing an
unrelated pair, and make calling code a little more readable.
ref T7230
Depends on D9046
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7230
Differential Revision: https://phab.enlightenment.org/D9048
Christopher Michael [Wed, 29 May 2019 19:36:53 +0000 (15:36 -0400)]
evas_inline: Clean up evas_object_is_visible function
Summary:
This file is full of functions called as:
foo(eo_obj, obj);
Most of them can be reduced to foo(obj); and internally get the eo_obj
with obj->object
This would make it impossible to screw up calling them passing an
unrelated pair, and make calling code a little more readable.
ref T7230
Depends on D9045
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7230
Differential Revision: https://phab.enlightenment.org/D9046
Christopher Michael [Wed, 29 May 2019 19:36:46 +0000 (15:36 -0400)]
evas_inline: Clean up evas_object_was_visible function
Summary:
This file is full of functions called as:
foo(eo_obj, obj);
Most of them can be reduced to foo(obj); and internally get the eo_obj
with obj->object
This would make it impossible to screw up calling them passing an
unrelated pair, and make calling code a little more readable.
ref T7230
Reviewers: raster, cedric, zmike
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7230
Differential Revision: https://phab.enlightenment.org/D9045
Daniel Kolesa [Wed, 29 May 2019 19:02:33 +0000 (21:02 +0200)]
eolian: fix unit version check
Lauro Moura [Wed, 29 May 2019 18:13:53 +0000 (18:13 +0000)]
eolian-cxx: Fix some warnings from cppcheck
Differential Revision: https://phab.enlightenment.org/D9052
Cedric BAIL [Sun, 28 Apr 2019 17:58:41 +0000 (10:58 -0700)]
ecore: enable property reflection support in Efl.CompositeModel.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D8754
Cedric BAIL [Wed, 29 May 2019 17:49:36 +0000 (13:49 -0400)]
eina: add test for eina_slstr_copy_new_length.
Summary: Depends on D8800
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7832
Differential Revision: https://phab.enlightenment.org/D9016
Cedric BAIL [Wed, 29 May 2019 17:49:26 +0000 (13:49 -0400)]
eina: add eina_slstr_copy_new_length.
Reviewers: SanghyeonLee, bu5hm4n, zmike, segfaultxavi, lauromoura, felipealmeida, raster
Reviewed By: bu5hm4n, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7832
Differential Revision: https://phab.enlightenment.org/D8800
Stefan Schmidt [Wed, 29 May 2019 16:20:15 +0000 (12:20 -0400)]
ci/travis: add meson windows cross build
Summary:
catchup with the windows cross build autotools build we have and provide
the matching meson build.
Depends on D9042
Reviewers: bu5hm4n, zmike, vtorri
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9043
Stefan Schmidt [Wed, 29 May 2019 16:20:10 +0000 (12:20 -0400)]
travis: re-enable updated mingw windows cross-build
Summary:
Updated mingw toolchain (6.0 plus gcc 9.3) based on Fedora 30.
Also updated ewpi with more and newer cross compiled deps.
Depends on D9041
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9042
Stefan Schmidt [Wed, 29 May 2019 16:20:00 +0000 (12:20 -0400)]
ci: enhance native bootstrap script for cross builds
Summary:
So far we only did generate a newer eolian_gen binary here due to the
frequent changes, but we really need way more native tools when doing the
cross build. Edje_cc, eet and elm_prefs_cc to name them.
Maintaining a special target for these (when they need almost all of
efl/elm anyway) looks like a burden so we are going with a full efl
build. Still speeding it up quite a bit by disabling bindings, examples
and tests when dong the native tooling build.
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9041
Mike Blumenkrantz [Wed, 29 May 2019 13:32:06 +0000 (09:32 -0400)]
tests/elm_focus: explicitly set widgets to expand+fill in test
Summary:
some widgets do not create a minimum size for themselves, resulting in
a 0x0 layout which can affect tests that rely on object visibility to
succeed without errors
Depends on D9007
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9008
Mike Blumenkrantz [Wed, 29 May 2019 13:31:58 +0000 (09:31 -0400)]
tests/genlist: fix some shadowed variable warnings
Summary: Depends on D9006
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9007
Mike Blumenkrantz [Wed, 29 May 2019 13:31:54 +0000 (09:31 -0400)]
tests/elm: explicitly denote cases where error messages are intentional
Summary:
we want to make it clear in our tests where it is intended that warnings
and errors may occur
Depends on D9005
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9006
Mike Blumenkrantz [Wed, 29 May 2019 13:31:49 +0000 (09:31 -0400)]
ecore-imf/xim: only call ecore_x_shutdown if init was previously called
Summary:
this isn't a perfect fix, but it's probably the best that can be done
given the current ecore-imf module api which calls the exit() module
function unconditionally during module cleanup even if the module was
never initialized
@fix
Depends on D9003
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9005
Mike Blumenkrantz [Wed, 29 May 2019 13:31:33 +0000 (09:31 -0400)]
emotion: don't update crop clipper geometry if crop clipper doesn't exist
Summary:
this object does not exist if no image border is set
@fix
Depends on D9002
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9003
Mike Blumenkrantz [Wed, 29 May 2019 13:31:28 +0000 (09:31 -0400)]
elm_widget_item_static_focus: check for adapter existence in unrealize cb
Summary:
adapter can be null if it was previously destroyed
@fix
Depends on D9001
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9002
Mike Blumenkrantz [Wed, 29 May 2019 13:31:23 +0000 (09:31 -0400)]
elm/scroller: return immediately from updating focused scroll region without content
Summary:
there is nothing to update here if the scroller has no content to update
@fix
Depends on D9000
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9001
Mike Blumenkrantz [Wed, 29 May 2019 13:31:17 +0000 (09:31 -0400)]
elm/map: move setting initial zoom to later in construction
Summary:
this ensures that all necessary objects exist in order to successfully
perform the zoom
@fix
Depends on D8999
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9000
Mike Blumenkrantz [Wed, 29 May 2019 13:31:12 +0000 (09:31 -0400)]
elm/list: return early from min_limit_cb if list object is dead
Summary:
no further recalculating should be done on dead objects
@fix
Depends on D8998
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8999
Mike Blumenkrantz [Wed, 29 May 2019 13:31:06 +0000 (09:31 -0400)]
elm/interface_scrollable: return immediately from setting region if no content
Summary:
this is a valid case and should be handled without erroring
@fix
Depends on D8997
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8998
Mike Blumenkrantz [Wed, 29 May 2019 13:30:59 +0000 (09:30 -0400)]
elm/index: create event_rect[0] earlier in construction
Summary:
this ensures that the object exists during init functions which make calls
on it
@fix
Depends on D8996
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8997
Mike Blumenkrantz [Wed, 29 May 2019 13:30:54 +0000 (09:30 -0400)]
elm/genlist: handle genlist finding of nearest visible item when not realized
Summary:
FIXME--
@fix
Depends on D8995
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8996
Mike Blumenkrantz [Wed, 29 May 2019 13:30:49 +0000 (09:30 -0400)]
elm/genlist: handle cache item deletion without errors
Summary:
@fix
Depends on D8994
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8995
Mike Blumenkrantz [Wed, 29 May 2019 13:30:43 +0000 (09:30 -0400)]
elm/genlist: trigger unrealize event after unsetting unrealized flag
Summary:
this flag is accessed by other components (e.g., focus) during the event
and so it must reflect the emitted event
@fix
Depends on D8993
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8994
Mike Blumenkrantz [Wed, 29 May 2019 13:30:37 +0000 (09:30 -0400)]
elm/genlist: unify all creation of calc jobs, skip if genlist is dead
Summary:
there is no need to recalculate any genlist attributes if the genlist is
dead
@fix
Depends on D8992
Reviewers: cedric, bu5hm4n
Reviewed By: cedric, bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8993
Mike Blumenkrantz [Wed, 29 May 2019 13:30:31 +0000 (09:30 -0400)]
elm/gen*: only call focus_object_setup_order_non_recursive if realized
Summary:
this function cannot process unrealized items
@fix
Depends on D8990
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8992
Mike Blumenkrantz [Wed, 29 May 2019 13:29:57 +0000 (09:29 -0400)]
elm/gengrid: trigger unrealize event after unsetting unrealized flag
Summary:
this flag is accessed by other components (e.g., focus) during the event
and so it must reflect the emitted event
@fix
Depends on D8989
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8990
Mike Blumenkrantz [Wed, 29 May 2019 13:29:51 +0000 (09:29 -0400)]
elm/code: check for cursor layout existence before emitting signals to it
Summary:
non-editable widgets do not have this object and will trigger errors
@fix
Depends on D8988
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8989
Mike Blumenkrantz [Wed, 29 May 2019 13:29:45 +0000 (09:29 -0400)]
elm/popup: remove del callback for internal table object during destruction
Summary:
the table object's destruction is no longer relevant after this point and
its callback can trigger unnecessary errors
@fix
Depends on D8986
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8988
Mike Blumenkrantz [Wed, 29 May 2019 13:29:20 +0000 (09:29 -0400)]
elm/fileselector: return early in theme_apply during construction
Summary:
the remainder of this function is used to setup styles for subobjects
which don't yet exist at this point
@fix
Depends on D8984
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8985
Mike Blumenkrantz [Wed, 29 May 2019 13:29:14 +0000 (09:29 -0400)]
efl_ui/widget: skip updating access info during parent_set(NULL) if dead
Summary:
no need to update access info for dead objects
@fix
Depends on D8983
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8984
Mike Blumenkrantz [Wed, 29 May 2019 13:29:08 +0000 (09:29 -0400)]
efl_ui/video: do not set 0x0 aspect hint
Summary:
this is an error
@fix
Depends on D8982
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8983
Mike Blumenkrantz [Wed, 29 May 2019 13:28:47 +0000 (09:28 -0400)]
efl_ui/progressbar: check for part existence before using parts
Summary:
some progressbar styles do not have certain parts, so it's necessary to
check part existence on theme load to avoid triggering unnecessary
errors
@fix
Depends on D8981
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8982
Mike Blumenkrantz [Wed, 29 May 2019 13:26:15 +0000 (09:26 -0400)]
efl_ui/layout: only freeze internal layout during delete if it exists
Summary:
if the layout object does not exist here then there is nothing to freeze
@fix
Depends on D8980
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8981
Mike Blumenkrantz [Wed, 29 May 2019 13:26:08 +0000 (09:26 -0400)]
efl_ui/layout: do not trigger sizing eval on subobj delete if layout is dead
Summary: @fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8980
Mike Blumenkrantz [Wed, 29 May 2019 13:25:24 +0000 (09:25 -0400)]
efl_ui/layout: do not trigger sizing eval on hint change if object is dead
Summary:
this fixes a huge number of errors during object deletion
@fix
Depends on D8979
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8987
Mike Blumenkrantz [Wed, 29 May 2019 13:25:14 +0000 (09:25 -0400)]
efl_ui/image: check image object existence before using it in sizing
Summary:
when triggered before the image is loaded, this code cannot be run
@fix
Depends on D8978
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8979
Mike Blumenkrantz [Wed, 29 May 2019 13:25:08 +0000 (09:25 -0400)]
efl_ui/check: check icon swallow existence before getting its content
Summary:
some check styles do not have this part
@fix
Depends on D8977
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8978
Mike Blumenkrantz [Wed, 29 May 2019 13:23:44 +0000 (09:23 -0400)]
eldbus: don't print warnings for user-canceled calls
Summary:
these are intentionally canceled and not something to be concerned with
@fix
Depends on D8974
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8976
Mike Blumenkrantz [Wed, 29 May 2019 13:23:29 +0000 (09:23 -0400)]
efl/io_model: check for parent object existence before removing wref
Summary:
if the wref automatically removes this pointer then there's no need to
remove the wref on the pointer
@fix
Depends on D8973
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8974
Mike Blumenkrantz [Wed, 29 May 2019 13:23:23 +0000 (09:23 -0400)]
ecore-x: protect ecore_x_shutdown from creating a negative init count
Summary:
@fix
Depends on D8972
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8973
Mike Blumenkrantz [Wed, 29 May 2019 13:23:18 +0000 (09:23 -0400)]
ecore-evas: check for internal evas presence before using it during free
Summary:
some engines do not have an evas
@fix
Depends on D8971
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8972
Mike Blumenkrantz [Wed, 29 May 2019 13:23:12 +0000 (09:23 -0400)]
efl_ui/button: check icon swallow existence before getting its content
Summary:
some button styles do not have this part
@fix
Depends on D8970
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8971
Mike Blumenkrantz [Wed, 29 May 2019 13:22:25 +0000 (09:22 -0400)]
elm/slider: check for interval/range state before using that functionality
Summary:
the part elm.dragable2.slider only exists when the slider is set to range
mode, so verify that this mode is active before attempting to use that part
@fix
Depends on D8968
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8969
Mike Blumenkrantz [Wed, 29 May 2019 13:18:31 +0000 (09:18 -0400)]
elm/slider: avoid emitting double events when range slider value changes
Summary:
in range mode, there are two slider endpoints, but only one event should be
emitted if a change is detected during update
@fix
Depends on D8967
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8968
Mike Blumenkrantz [Wed, 29 May 2019 13:18:26 +0000 (09:18 -0400)]
elm/map: ignore zoom events during construction which cannot be handled
Summary:
sd->obj is null until after the object is finalized, so this codepath
cannot be processed until then
@fix
Depends on D8966
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8967
Mike Blumenkrantz [Wed, 29 May 2019 13:18:20 +0000 (09:18 -0400)]
elm: fix value of datadir when running in tree
Summary:
this makes it possible to successfully run elm_test out of the tree
without installing
@fix
Depends on D8965
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8966
Mike Blumenkrantz [Wed, 29 May 2019 13:18:15 +0000 (09:18 -0400)]
elm: don't attempt to load clouseau when running in tree
Summary:
clouseau doesn't work anyway
Depends on D8964
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8965
Mike Blumenkrantz [Wed, 29 May 2019 13:18:09 +0000 (09:18 -0400)]
elm/hovers: don't trigger more errors when setting null hover parent
Summary:
null is not a valid subobject, do not attempt to add it
@fix
Depends on D8963
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8964
Mike Blumenkrantz [Wed, 29 May 2019 13:18:01 +0000 (09:18 -0400)]
elm/gengrid: handle focus events when no previous focus item was set
Summary:
this triggers fewer error messages
@fix
Depends on D8962
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8963
Mike Blumenkrantz [Wed, 29 May 2019 13:17:55 +0000 (09:17 -0400)]
elm/gengrid: more null checks for setting mirrored state during construction
Summary:
sd->obj is only non-null later in construction, so add even more checks for it
here
@fix
Depends on D8961
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8962
Mike Blumenkrantz [Wed, 29 May 2019 13:17:24 +0000 (09:17 -0400)]
elm/gengrid: handle cache item deletion without errors
Summary:
@fix
Depends on D8959
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8960
Mike Blumenkrantz [Wed, 29 May 2019 13:17:18 +0000 (09:17 -0400)]
elm/entry: use edje functions directly for interacting with edje objects
Summary:
this eliminates a number of errors triggered when processing class hierarchy
to reach the desired subobject with these edje functions
@fix
Depends on D8958
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8959
Mike Blumenkrantz [Wed, 29 May 2019 13:17:12 +0000 (09:17 -0400)]
elm/diskselector: trigger sizing eval during theme set only if finalized
Summary:
this can't be successfully completed until the object has been fully constructed
@fix
Depends on D8957
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8958
Mike Blumenkrantz [Wed, 29 May 2019 13:17:07 +0000 (09:17 -0400)]
elm/diskselector: fix handling in theme data setup
Summary:
the previous code checked for the object which was required to execute
the remainder of the function, then returned if that object existed instead
of continuing with the function. hello?
@fix
Depends on D8956
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8957
Mike Blumenkrantz [Wed, 29 May 2019 13:17:00 +0000 (09:17 -0400)]
elm/colorselector: return early from theme apply if object is not yet finalized
Summary:
the remainder of this function cannot be handled until objects are set up
later in construction
@fix
Depends on D8955
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8956
Mike Blumenkrantz [Wed, 29 May 2019 13:16:53 +0000 (09:16 -0400)]
elm/layout: do not trigger sizing eval at end of canvas_group_add
Summary:
this can never succeed as there will never be an object to successfully
size with at this point
@fix
Depends on D8954
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8955
Mike Blumenkrantz [Wed, 29 May 2019 13:16:48 +0000 (09:16 -0400)]
elm/layout: do not trigger sizing eval on subobj deletion if no resize_obj set
Summary:
this has no effect since the resize_obj is what determines sizing
@fix
Depends on D8953
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8954
Mike Blumenkrantz [Wed, 29 May 2019 13:16:41 +0000 (09:16 -0400)]
efl_ui_focus_manager/calc: handle redirect setting if no previous redirect set
Summary:
use same pointer for conditional to improve readability, avoid passing null to
efl_ui_focus_manager_reset_history() which cannot be passed null
@fix
Depends on D8952
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8953
Mike Blumenkrantz [Wed, 29 May 2019 13:16:35 +0000 (09:16 -0400)]
eina/prefix: ignore magic files when running in tree
Summary:
this just can't work.
@fix
Depends on D8951
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8952
Mike Blumenkrantz [Wed, 29 May 2019 13:16:30 +0000 (09:16 -0400)]
eina/file: use INFO log level when eina_file_open fails
Summary:
this function is commonly used to detect the existence of files using
its return value. for this purpose, printing warnings any time the file
cannot be opened is spammy and not very helpful in the context of detecting
actual errors.
Depends on D8950
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8951
Mike Blumenkrantz [Wed, 29 May 2019 13:15:13 +0000 (09:15 -0400)]
efl_canvas_layout: permit part_type_get on invalid parts
Summary:
this is the only way to determine whether a part is invalid, so it should
be usable without triggering errors
@fix
Depends on D8948
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8949
Mike Blumenkrantz [Wed, 29 May 2019 13:15:06 +0000 (09:15 -0400)]
edje/load: (more) correctly handle part updates after changing edje group
Summary:
if a part changes its type, verify that the new type is compatible AND
exists before attempting to re-set the previous state, otherwise take
action and print warning
@fix
Depends on D8947
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8948
Mike Blumenkrantz [Wed, 29 May 2019 13:14:56 +0000 (09:14 -0400)]
ecore/timer: fix handling of timer freeze during construction
Summary:
timer has no loop pointer until it is finalized
@fix
Depends on D8918
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8947
Mike Blumenkrantz [Wed, 29 May 2019 13:14:08 +0000 (09:14 -0400)]
gl_generic: handle image orientation setting when texture has not been created
Summary:
this occurs when orientation is set during image construction
@fix
Reviewers: segfaultxavi, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl_rendering
Differential Revision: https://phab.enlightenment.org/D8916
Mike Blumenkrantz [Wed, 29 May 2019 13:13:10 +0000 (09:13 -0400)]
edje/calc: correctly handle swallow/group objects as clippers for state clips
Summary:
in the case where the clipper being set was an indirect object, it's necessary
to resolve the lookup for that part and use the actual part object to avoid
setting a placeholder rect as the clipper
@fix
Depends on D8850
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8851
Xavi Artigas [Wed, 29 May 2019 13:13:32 +0000 (15:13 +0200)]
Efl.Ui.Flip: Silence warning
The Efl.Ui.Orientation enum is actually made of flags, which we can OR
together, and it includes bitmasks for easier manipulation.
gcc expects switch() statemenets to include all enum values and nothing
but the valid enum values, which is abit too restrictive for flags.
Casting to int removes the warning.
Yeongjong Lee [Wed, 29 May 2019 08:24:30 +0000 (17:24 +0900)]
efl_ui_relative_layout: prevent infinite loop in chain calculation
Test Plan:
test code
```
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Eo *win, *layout, *btn1, *btn2, *btn3;
win = efl_add(EFL_UI_WIN_CLASS, efl_main_loop_get());
layout = efl_add(EFL_UI_RELATIVE_LAYOUT_CLASS, win,
efl_content_set(win, efl_added));
btn1 = efl_add(EFL_UI_BUTTON_CLASS, layout);
btn2 = efl_add(EFL_UI_BUTTON_CLASS, layout);
efl_ui_relative_layout_relation_right_set(layout, btn1, btn2, 0.0);
efl_ui_relative_layout_relation_right_set(layout, btn2, btn1, 0.0);
efl_ui_relative_layout_relation_left_set(layout, btn2, btn1, 1.0);
efl_ui_relative_layout_relation_left_set(layout, btn1, btn2, 1.0);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9032
Yeongjong Lee [Wed, 29 May 2019 08:24:21 +0000 (17:24 +0900)]
efl_ui_relative_layout: allow to respect the min size of its child
Summary: It will have the same policy as the Efl.Ui.Box, Table.
Test Plan: elementary_test -to 'efl.ui.relative_layout'
Reviewers: Jaehyun_Cho, herb
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9029
Jaehyun Cho [Fri, 31 May 2019 12:26:06 +0000 (21:26 +0900)]
fix migration build error of missing efl_ui_clickable
efl_ui_clickable.c and efl_ui_clickable_util.c are moved in elementary
so Makefile_Elementary_Tizen.am should contain these files.
Change-Id: Ie273c58fe3e00bd517a274dccc7f56b08e6140a1
JunsuChoi [Thu, 30 May 2019 10:55:01 +0000 (19:55 +0900)]
Edje_types: Remove @beta mark
Change-Id: I72fc1f20c87df11cb6e59a7d42790c2144b1e96b
JunsuChoi [Thu, 30 May 2019 01:17:24 +0000 (10:17 +0900)]
fix migration build errors
Gerrit efl HEAD :
4f51631cff14e68c3c37c227b3f575d0113b945d
Opensource efl HEAD :
4f51631cff14e68c3c37c227b3f575d0113b945d
Change-Id: Ibb873816d1fd38e08b58826fc674d3b0db78152e
Marcel Hollerbach [Tue, 28 May 2019 16:01:57 +0000 (12:01 -0400)]
efl_ui: add a helper for not tollerating errors in a testsuite
Summary:
We now also fail in the focus tests
Depends on D9021
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9022
Marcel Hollerbach [Tue, 28 May 2019 16:01:50 +0000 (12:01 -0400)]
efl_ui_suite: fix errors in focus tests
Summary:
there have been a few cases where things were just wrong. Like missing
regular nodes in a focus manager that received focus, and stuff like
this. This now fixes all those cases.
Reviewers: zmike, cedric, segfaultxavi
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9021
Vincent Torri [Tue, 28 May 2019 15:37:03 +0000 (11:37 -0400)]
Evil: fix infinite loop with setlocale
Summary: evil_setlocale was defined as setlocale in evil_private.h *before* evil_setlocale, hence evil_setlocale was calling itself. The solution was to not call evil_private.h in evil_locale.c
Test Plan: compialtion and elementary_test
Reviewers: zmike, raster, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7985
Differential Revision: https://phab.enlightenment.org/D9030
Xavi Artigas [Tue, 28 May 2019 15:13:49 +0000 (17:13 +0200)]
eolian: allow parts named like methods
Summary:
The C# bindings turn parts into class properties, so part names cannot clash
with method names.
However, a "Part" prefix has been recently added, just like it was done for
events, and therefore this eolian restriction can be lifted.
With this patch part name clashes are only checked among parts, just like it
is done for events.
Relates to D8582
Test Plan: Everything still builds, because we have no part-method name clashes in the tree, but now they are possible.
Reviewers: q66, SanghyeonLee
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9031
Alastair Poole [Sun, 26 May 2019 23:59:56 +0000 (23:59 +0000)]
build: Fix on OpenBSD.
This adds support for OpenBSD with meson build
system. Also use better paths. This resolves
further issues when building EFL.`
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9028
Vincent Torri [Mon, 27 May 2019 06:58:51 +0000 (15:58 +0900)]
ecore_evas win32: fix warning reported by clang
Test Plan: compilation
Reviewers: zmike, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9025
Vincent Torri [Mon, 27 May 2019 06:56:41 +0000 (15:56 +0900)]
Evas gesture: do not use abs when dealing with double, use fabs instead
Summary: clang reports a warning here. We compare the result of abs (casting to an int, returning an int) to a double value. Hence we should use fabs instead
Test Plan: compilation
Reviewers: Jaehyun, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9024
Hermet Park [Mon, 27 May 2019 05:36:44 +0000 (14:36 +0900)]
efl_ui_textpath: redraw text properly.
It needs redraw since text draw depends on the obj' size.
Daniel Kolesa [Sun, 26 May 2019 16:35:48 +0000 (18:35 +0200)]
eolian: add runtime API to get file format version
This is useful for FFI based bindings (like the Lua or Python ones)
and so on.
Daniel Kolesa [Sun, 26 May 2019 16:30:02 +0000 (18:30 +0200)]
eolian: prevent parsing when eo file version is too new
Daniel Kolesa [Sun, 26 May 2019 16:24:40 +0000 (18:24 +0200)]
eolian: add test for file versioning
Daniel Kolesa [Sun, 26 May 2019 16:21:27 +0000 (18:21 +0200)]
elua: add version_get API for units in eolian bindings
Daniel Kolesa [Sun, 26 May 2019 16:19:20 +0000 (18:19 +0200)]
eolian: add API to query unit version
Daniel Kolesa [Sun, 26 May 2019 16:09:34 +0000 (18:09 +0200)]
eolian: initial versioning implementation
This implements initial support for specifying unit versions.
The default version is 1, specifying the basic feature level.
If you want to specify another version, you need to specify
something like `#version 2` at the beginning of the .eo or
.eot file; the version number must be higher than 0 and lower
than USHRT_MAX (typically 65536).
The beginning of the file is now called the "header section";
other things may be added into the header section later.
Version cannot be specified twice, and it cannot be specified
once other contents (like types or class definition) appear.
Comments do not count as other contents, so those are fine
to appear before #version.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:41:22 +0000 (17:41 +0200)]
eolian: rename @warn_unused and its associated API
@warn_unused in syntax is now called @no_unused - this is because
"warning about unused" is a C thing (or rather, an extension to C)
and various languages might want to use stricter behavior for this.
Its associated API does the reverse now - it lets you query whether
being unused is allowed at all. This is to match future behavior
of Eolian (once it supports versioning) that will likely reverse it.
@feature
Daniel Kolesa [Sun, 26 May 2019 15:25:15 +0000 (17:25 +0200)]
eolian: remove param @nonull
This has been deprecated for a while and is not strictly necessary
- as a part of an effort to stabilize Eolian, remove this. Eolian
will eventually gain support for versioning and use a reversed
behavior (i.e. no NULL by default), but the API it wlll use for
that will be very different. Features can always be added, it's
much harder to drop them.
@feature
Xavi Artigas [Fri, 24 May 2019 16:30:31 +0000 (12:30 -0400)]
Rename Efl.Ui.Direction -> Efl.Ui.Layout_Orientation
Summary:
This clarifies a bit the whole Orientation vs. Direction confusion, at the
expense of longer names (Image_Orientation vs. Layout_Orientation).
Also, the interfaces are now adjectives (Orientable) and the enums have long
names (*_Orientation).
Pretty big patch, but no functional changes.
Relates to T7863
Test Plan:
Everything builds and passes tests.
Elementary_tests show same behavior, including the "inverted" widgets, which
are the only parts which received a bit of code changes.
Proof:
https://travis-ci.org/Enlightenment/efl/builds/
536277282
Reviewers: zmike, bu5hm4n, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8946
Xavi Artigas [Fri, 24 May 2019 09:26:06 +0000 (11:26 +0200)]
Fix last missing reference to old efl_orientation headers
This is now efl_gfx_orientable.
We are not building the C++ examples, so I did not pick this up sooner.
Travis does not build C++ bidings at all.
Jaehyun Cho [Fri, 24 May 2019 08:46:16 +0000 (17:46 +0900)]
efl_mono: fix autogen make check error
Previously, autogen make check error happened because
some .eo.h files were not generated but were included in
libefl_mono_native_test.h.
Now, all .eo.c and .eo.h files are generated.
Also CLEANFILES are fixed to include all the generated files.
Lauro Moura [Thu, 23 May 2019 23:45:29 +0000 (20:45 -0300)]
csharp: Fix autotools build
Summary: After the tests split
Reviewers: vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9015
Mike Blumenkrantz [Thu, 23 May 2019 17:55:50 +0000 (13:55 -0400)]
efl/gesture: include .h file in private header, not .c file
Summary:
a generated eolian c file cannot be included multiple times or else it will
create multiple definitions of symbols defined in that file and break the build
ref
54175998d538e0b2173fc023bb822f1e6536e58f
fix T7960
Reviewers: devilhorns, vtorri
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Maniphest Tasks: T7960
Differential Revision: https://phab.enlightenment.org/D8945
Mike Blumenkrantz [Thu, 23 May 2019 13:32:11 +0000 (09:32 -0400)]
elm_widget_item_static_focus: mark param as used
Summary: Depends on D8935
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8936
Mike Blumenkrantz [Thu, 23 May 2019 13:32:00 +0000 (09:32 -0400)]
efl_ui_focus_manager_sub: handle manager change when tree is set to unfocusable
Summary:
in this case, the event is emitted and no manager exists because the objects
are not focusable
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8935
Mike Blumenkrantz [Thu, 23 May 2019 13:31:50 +0000 (09:31 -0400)]
elm_color_class: use legacy event for genlist selection
Summary:
this fixes the selection callback and makes the widget work again
@fix
Reviewers: bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl_widgets
Differential Revision: https://phab.enlightenment.org/D8913
Mike Blumenkrantz [Thu, 23 May 2019 13:31:42 +0000 (09:31 -0400)]
evas/render: fix proxy clipping when source_clip is disabled
Summary:
when source_clip is disabled, the clipper used should be the one used by
the proxy object. previously this would never be the case, meaning that
disabling source_clip had no effect
@fix
Depends on D8879
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8880
Vincent Torri [Thu, 23 May 2019 11:25:27 +0000 (20:25 +0900)]
Emotion gst1 module: fix "empty if statement" warning
Summary: the macro GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS can be undefined (see gst core doc), hence the if statement may have no body
Test Plan: compilation
Reviewers: zmike, raster, cedric, Hermet
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D8939
projects / platform / upstream / efl.git / log