platform/core/csapi/xsf.git
5 years ago[Android] Pass correct measurement values to item content (#6285)
E.Z. Hart [Sat, 1 Jun 2019 01:40:25 +0000 (19:40 -0600)]
[Android] Pass correct measurement values to item content (#6285)

* Test case to reproduce the issue

* Set proper height/width values in measure for layouts; fixes #5765

* More descriptive test name

* Avoid unnecessary FromPixel calls

* Remove double include

fixes #5765
fixes #5782

5 years agoCheckbox (#6232)
Shane Neuville [Thu, 30 May 2019 16:32:28 +0000 (10:32 -0600)]
Checkbox (#6232)

* Add CheckBox class and Renderer

* Add CheckBoxCell class

* Add Control Gallery for CheckBox and CheckBoxCell.
Add stubs only for Android for now.

* Update to fast renderer for Android, Implement Checked and Unchecked Colors!

* Initial UWP implementation, no colors yet.

* Add iOS implementation for checkbox. It's not pretty, but it is a start!

* Updates from Frank

* Code cleanup with frank

* Finalize iOS checkbox!!! it is a circle!

* Fix WPF build and Add a checkbox!!!

* Cell Renderers and macOS

* UWP switchcell

* Update CheckBox Cell on ios/android with colors

* Remove all instances of CheckBoxCell per demand

* Added UITests and UnitTests

* Changed colors to TintColor which makes sense. Added a IsChecked visual state property and a sample!

* checkbox cleanup, tint color fixes, and material

* uwp fix when changing TintBrush

* add checkbox to visual controls page

* formatting fix

* formatting fix

* formatting fix

* convert to tabs

* formatting

* checkbox tabs

* roll back formatting changes to WPFResources

* android renderer overrides

* uwp fix and sizing fix ios

* mask checkbox

* use a single image for ios inatead of always drawing new ones

* wpf fix

* rename to color and add css interfaces

* missing wpf file

* designer hack

* fix wpf for ios builds

* assembly info

* fix default tint color and infinite crash

* [iOS] fixes change checked state from control
simplification
added to dynamic galery

* [iOS material] fix crash when dispose

* [UWP, WPF] fix vertical alignment

* [Android] fixes does not change size when the reduction HeightRequest

* Update Xamarin.Forms.Material.iOS/MaterialCheckboxRenderer.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
* [Android] TabStop support

* alphabetize gallery, fix color update when disabled, unsubscribe from event in dispose

* cleanup assembly info

* fix assembly attributes

* remove assembly info

* pr comments

* couple of more dispose fixes

* One Last Dispose

* fix api 19 call to ClipToOutline

5 years agoFix build
Samantha Houts [Wed, 29 May 2019 02:15:37 +0000 (19:15 -0700)]
Fix build

5 years agoMerge branch '4.0.0'
Samantha Houts [Wed, 29 May 2019 01:53:09 +0000 (18:53 -0700)]
Merge branch '4.0.0'

5 years ago[Android] Remove call to update Image on button during measure (#6274)
Shane Neuville [Wed, 29 May 2019 01:40:39 +0000 (19:40 -0600)]
[Android] Remove call to update Image on button during measure (#6274)

* remove update call before measure

* apply to material as well
fixes #6260

5 years agoIssue4879 ImageButton Padding (UWP) (#5837)
Matt Lacey [Wed, 29 May 2019 00:53:17 +0000 (01:53 +0100)]
Issue4879 ImageButton Padding (UWP) (#5837)

* Apply ImageButton.Padding on UWP like other platforms

For #4879

* Apply ImageButton.Padding on UWP like other platforms

For #4879

* Apply ImageButton.Padding on UWP like other platforms

For #4879

* don't use obsolete property after rebasing to 4.0

fixes #4879

5 years agoiOS: Setting FormattedText doesn't use TextDecorations (#5803)
Andrei Nitescu [Wed, 29 May 2019 00:50:52 +0000 (03:50 +0300)]
iOS: Setting FormattedText doesn't use TextDecorations (#5803)

fixes #5801

5 years agoroll back IButtonLayoutRenderer to its former 3.6 glory (#6290)
Shane Neuville [Wed, 29 May 2019 00:27:26 +0000 (18:27 -0600)]
roll back IButtonLayoutRenderer to its former 3.6 glory (#6290)

5 years agoCheck for correct API version (#6306)
E.Z. Hart [Tue, 28 May 2019 19:48:17 +0000 (13:48 -0600)]
Check for correct API version (#6306)

fixes #5693

5 years ago[Android] propagate elevation after initial elevation changes android (#6271)
Shane Neuville [Tue, 28 May 2019 18:56:40 +0000 (12:56 -0600)]
[Android] propagate elevation after initial elevation changes android (#6271)

fixes #6262

5 years ago[Shell, Android] Fixes crash on api 22 or less (#6198)
Pavel Yakovlev [Tue, 28 May 2019 17:56:31 +0000 (10:56 -0700)]
[Shell, Android] Fixes crash on api 22 or less (#6198)

fixes #6197

5 years ago[GTK] Add Alpha support to Frame background (#6092)
mtz [Tue, 28 May 2019 17:55:05 +0000 (19:55 +0200)]
[GTK] Add Alpha support to Frame background (#6092)

* [GTK] Add transparent background support for Gtk.Frame

Fixes https://github.com/xamarin/Xamarin.Forms/issues/4700

* [GTK] Disable Frame shadow

fixes #4700

5 years agoMake CollectionView SelectedItem and SelectedItems binding function correctly (#6085)
E.Z. Hart [Tue, 28 May 2019 17:54:09 +0000 (11:54 -0600)]
Make CollectionView SelectedItem and SelectedItems binding function correctly (#6085)

* Add automated test for CollectionView single selection bound item

* Make SelectedItem Two-Way

* Multiple selection test page

* Bindable SelectedItems implementation

* Add automated test

* Simplify null checks

* Add Preserve attribute so linker doesn't break test

* Make multi-item select test smaller so it passes UITests on smaller screens

* Clearer list-to-string method

* Clear native selection on iOS when SelectedItem set to null

fixes #6158
fixes #5832

5 years ago[Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)
Kangho Hur [Tue, 28 May 2019 15:12:47 +0000 (00:12 +0900)]
[Tizen] Add TFM identifier and version explictly for vs2019 16.1 (#6304)

5 years ago[Build] This actually doesn't fix the issue
Rui Marinho [Tue, 28 May 2019 11:01:09 +0000 (12:01 +0100)]
[Build] This actually doesn't fix the issue

5 years agoMerge branch '4.0.0'
Rui Marinho [Sat, 25 May 2019 00:43:59 +0000 (01:43 +0100)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Sat, 25 May 2019 00:33:08 +0000 (01:33 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix env variable for release nuget (#6311)
Rui Marinho [Sat, 25 May 2019 00:30:00 +0000 (01:30 +0100)]
[Build]  Fix env variable for release nuget (#6311)

5 years agoMerge branch '4.0.0'
Rui Marinho [Fri, 24 May 2019 23:18:49 +0000 (00:18 +0100)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 23:18:10 +0000 (00:18 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Fix release variable name
Rui Marinho [Fri, 24 May 2019 23:02:44 +0000 (00:02 +0100)]
[Build] Fix release variable name

5 years agoMerge branch '4.0.0'
Rui Marinho [Fri, 24 May 2019 22:19:32 +0000 (23:19 +0100)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Fri, 24 May 2019 21:10:57 +0000 (22:10 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoFix packageversion (#6288)
Rui Marinho [Fri, 24 May 2019 21:08:24 +0000 (22:08 +0100)]
Fix packageversion (#6288)

* [Build] Simplify package version

* [Build] Update the semver package version

* [Build] Remove prepare and set tags

* [Build] Update win build

* [Build] Fix tags

* Update Version.targets

* Update azure-pipelines.yml

* Update Version.targets

* [Build] Fix sign

* Update azure-pipelines.yml

5 years ago[Build] Add a global.json to specify what netcore sdk to use (#6279)
Rui Marinho [Thu, 23 May 2019 15:09:08 +0000 (16:09 +0100)]
[Build] Add a global.json to specify what netcore sdk to use (#6279)

5 years ago[MacOS] Fix build error #6153
Rui Marinho [Thu, 23 May 2019 01:21:18 +0000 (02:21 +0100)]
[MacOS] Fix build error #6153

5 years agoProperly guard against statusbar usage (#5999)
Morten Nielsen [Thu, 23 May 2019 00:44:22 +0000 (17:44 -0700)]
Properly guard against statusbar usage (#5999)

If you add the `Microsoft.Toolkit.Uwp.PlatformSpecificAnalyzer` nuget package, you'll find the analyzer points out these locations as not correctly guarded against usage.

5 years agoMerge branch '4.0.0'
Rui Marinho [Thu, 23 May 2019 00:38:28 +0000 (01:38 +0100)]
Merge branch '4.0.0'

5 years agoAllow third party libs to display animated images correctly in view recycling scenari...
Daniel Luberda [Thu, 23 May 2019 00:31:01 +0000 (02:31 +0200)]
Allow third party libs to display animated images correctly in view recycling scenarios (#6153)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

* Allows to display animated images on iOS in recycled views (CollectionView, ListView)

5 years ago[Tizen] Enhancement CollectionView implementation on Tizen (#6181)
Seungkeun Lee [Thu, 23 May 2019 00:21:38 +0000 (09:21 +0900)]
[Tizen] Enhancement CollectionView implementation on Tizen  (#6181)

* Implement ItemsView.ItemSizingStrategy property

* CollectionView - Optimization Item size calculation with cache

* Implement ItemsView.ItemSizingStrategy property on GridItemsLayout

 - refactoring CollectionView

* CollectionView - Support DataTemplateSelector

* Fix FrameRenderer

 - Inherit from LayoutRenderer because Frame is subclass of Layout

* Fix minor layout issue on CollectionView

* Allow CollectionView items to resize with their content

* Fix miss typo and remove comment

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Thu, 23 May 2019 00:06:47 +0000 (01:06 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build] Update version target (#6270)
Rui Marinho [Thu, 23 May 2019 00:04:53 +0000 (01:04 +0100)]
[Build] Update version target (#6270)

5 years agoMerge branch '4.0.0'
Rui Marinho [Wed, 22 May 2019 21:32:28 +0000 (22:32 +0100)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 21:21:31 +0000 (22:21 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years ago[Build]Yaml consolidate nuget (#6266)
Rui Marinho [Wed, 22 May 2019 18:33:27 +0000 (19:33 +0100)]
[Build]Yaml consolidate nuget (#6266)

* [Build] Consolidate nuget version

* [Build] Allow to continue to other steps if package fails to push on internal feed

* [Build] Fix script

5 years ago[Build] Clean Xamarin.Forms.Build
Rui Marinho [Wed, 22 May 2019 16:37:20 +0000 (17:37 +0100)]
[Build] Clean Xamarin.Forms.Build

5 years agoMerge branch '3.6.0' into 4.0.0
Rui Marinho [Wed, 22 May 2019 15:23:05 +0000 (16:23 +0100)]
Merge branch '3.6.0' into 4.0.0

5 years agoLoad resources (#6243)
Stephane Delcroix [Wed, 22 May 2019 12:02:45 +0000 (14:02 +0200)]
Load resources (#6243)

* internal method to only reload RDs

* fix test

5 years ago[Build] Fix Version for branches with dashes
Rui Marinho [Wed, 22 May 2019 03:04:10 +0000 (04:04 +0100)]
[Build] Fix Version for branches with dashes

5 years ago[Build] Also build tags on yaml
Rui Marinho [Wed, 22 May 2019 01:45:17 +0000 (02:45 +0100)]
[Build] Also build tags on yaml

5 years ago[Build] Update yaml builds (#6230)
Rui Marinho [Wed, 22 May 2019 01:16:26 +0000 (02:16 +0100)]
[Build] Update yaml builds (#6230)

* [Build] Update build yaml

* [MacOS]Fix warning

* [Build] Enable binlog

* [Build] Run tests after build, update nuget version

* [Build] Don't build PagesGallery and Embedding

5 years ago[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)
Rui Marinho [Wed, 22 May 2019 00:06:59 +0000 (01:06 +0100)]
[Build] Update builds, remove submodule, update AssemblyInfo with GitInfo (#6068)

* [Build] Remove submodule

* [Build] Use GitInfo to set Assembly metadata

* [Build] Remove extra prop

* [Build] Update version

* [Build] Update versions to be consistent with existing Build.Tasks

* [Build] Update build number

* [Build] make sure build tasks gets info

* [Build] Add assembly info unit test

* [Test] Refactor test for gitinfo on vsts

5 years agofixes BindableLayout DataTemplate - XamlC #5486 (#6178)
inforithmics [Mon, 20 May 2019 18:00:46 +0000 (20:00 +0200)]
fixes BindableLayout DataTemplate - XamlC #5486 (#6178)

fixes #5651
fixes #5486

* Update TypeReferenceExtensions.cs

5 years agoMerge branch '4.0.0'
Stephane Delcroix [Mon, 20 May 2019 06:57:51 +0000 (08:57 +0200)]
Merge branch '4.0.0'

5 years agomove imports to Directory.Build.[props|targets] (#6212)
Stephane Delcroix [Sat, 18 May 2019 12:19:09 +0000 (05:19 -0700)]
move imports to Directory.Build.[props|targets] (#6212)

5 years agoHeight -> Width; fixes #6168 (#6213)
E.Z. Hart [Fri, 17 May 2019 00:21:16 +0000 (17:21 -0700)]
Height -> Width; fixes #6168 (#6213)

5 years agoCreated UITest for issue B43527 (#5898)
puppetSpace [Wed, 15 May 2019 21:54:13 +0000 (23:54 +0200)]
Created UITest for issue B43527 (#5898)

* Add UITest to issue B43527

* Cleanup of Bugzilla43527

* change unit test to use WaitForNoElement

5 years ago[UITests] Remove flaky test
Rui Marinho [Tue, 14 May 2019 21:19:34 +0000 (14:19 -0700)]
[UITests] Remove flaky test

5 years ago[Tizen] Support new Named Font Sizes for Tizen (#6113)
Kangho Hur [Tue, 14 May 2019 19:30:55 +0000 (04:30 +0900)]
[Tizen] Support new Named Font Sizes for Tizen (#6113)

5 years agoMerge branch '4.0.0'
Rui Marinho [Tue, 14 May 2019 19:29:12 +0000 (12:29 -0700)]
Merge branch '4.0.0'

5 years agoInvalidateLayout after reload to avoid iOS 10 crash (#6190)
E.Z. Hart [Tue, 14 May 2019 19:20:29 +0000 (12:20 -0700)]
InvalidateLayout after reload to avoid iOS 10 crash (#6190)

5 years agoMake NSScrollView for NSTableView not draw background, and add test case. (#6050)
Oliver Brown [Sat, 11 May 2019 19:43:01 +0000 (20:43 +0100)]
Make NSScrollView for NSTableView not draw background, and add test case. (#6050)

fixes #6021

5 years agoMerge branch '4.0.0'
Samantha Houts [Sat, 11 May 2019 19:14:20 +0000 (12:14 -0700)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 11 May 2019 19:12:26 +0000 (12:12 -0700)]
Merge branch '3.6.0' into 4.0.0

5 years agoitem template attached, fix icon propagations (#6173)
Shane Neuville [Sat, 11 May 2019 19:09:10 +0000 (12:09 -0700)]
item template attached, fix icon propagations (#6173)

* item template attached, fix icon propagations

* tabs

5 years ago[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)
Samantha Houts [Sat, 11 May 2019 19:08:21 +0000 (12:08 -0700)]
[Bug] ListView HasUnevenRows was not working in iOS 10 (#6166)

* Add repro for #5888

Co-Authored-By: melimion <melimion@users.noreply.github.com>
* [iOS] Fix HasUnevenRows for iOS11+

Co-Authored-By: melimion <melimion@users.noreply.github.com>
fixes #5888

5 years agoremove safe area from inset (#6169)
Shane Neuville [Sat, 11 May 2019 19:07:49 +0000 (12:07 -0700)]
remove safe area from inset (#6169)

5 years ago[iOS] Fix NRE when looking for internal buttons (#6170)
Rui Marinho [Sat, 11 May 2019 01:33:50 +0000 (18:33 -0700)]
[iOS] Fix NRE when looking for internal buttons (#6170)

5 years ago[iOS] Shell _headerView can apparently be null (#6164)
Samantha Houts [Fri, 10 May 2019 20:57:55 +0000 (13:57 -0700)]
[iOS] Shell _headerView can apparently be null (#6164)

5 years ago[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties...
Samantha Houts [Fri, 10 May 2019 20:38:39 +0000 (13:38 -0700)]
[Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText... (#6165)

* [Android] _shellContext.Shell.FlyoutIcon was null, crashing AutomationProperties.GetHelpText

But more concerning is that the `shellIconTextDescription` isn't used at all. Is it leftover code, or is this a mistake?

* [Android] Remove dead code from shellIconTextDescripion

5 years agoMerge branch '4.0.0'
Samantha Houts [Fri, 10 May 2019 04:14:54 +0000 (21:14 -0700)]
Merge branch '4.0.0'

5 years agostack the elevation of elements (#6108)
Shane Neuville [Fri, 10 May 2019 04:08:14 +0000 (21:08 -0700)]
stack the elevation of elements (#6108)

* stack the elevation of elements

* only layer implicit elevations

* check elevation of incoming elemelements

* fix api 19
fixes #2989
fixes #3543

5 years agofix up shell menu items, fix templates, fix bindings (#6117)
Shane Neuville [Fri, 10 May 2019 03:58:04 +0000 (20:58 -0700)]
fix up shell menu items, fix templates, fix bindings (#6117)

* fix up shell menu items, fix templates, fix bindings

* propagate bindingcontext changed on menu items

* address feedback
fixes #4399
fixes #5707

5 years agoRemove experimental flag for shell and change a few apis (#6086) fixes #2415
Shane Neuville [Thu, 9 May 2019 21:18:04 +0000 (14:18 -0700)]
Remove experimental flag for shell and change a few apis (#6086) fixes #2415

* api changes for shell official

* Update Xamarin.Forms.Core/Shell/Shell.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellSection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Core/Shell/ShellItem.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix compile errors

* fix ui test

* fix ui test

* removed some more properties

* remove a couple more

5 years ago[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956
Shane Neuville [Thu, 9 May 2019 21:17:30 +0000 (14:17 -0700)]
[Shell] propagate css to logical child element (#6082) fixes #4683 fixes #5956

* create an actual logical child structure for page to use for propagation

* JustTheLogicalChildren

* only iterate over ActuallyLogicalChildren

* fix naming

* reuse ChildrenNotDrawnByThisElement

* testing

* fix unit test

5 years ago[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109...
Shane Neuville [Thu, 9 May 2019 21:16:52 +0000 (14:16 -0700)]
[iOS] Shell flyout header on iOS now is dynamic based on the header content (#6109) fixes #3875

* fix the flyout header to size based on content opposed to a fixed height

* update storeshell

* added height slider into storeshell

* resize header if underlying measure changes

* unsubscribe

5 years agoFix comment typo (#6148)
Adam Patridge [Thu, 9 May 2019 20:06:04 +0000 (14:06 -0600)]
Fix comment typo (#6148)

5 years ago[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)
Samantha Houts [Thu, 9 May 2019 18:00:14 +0000 (11:00 -0700)]
[Android] Fix WebView EnableZoomControls and DisplayZoomControls api (#6137)

* Add tests for #6132 and #6130

* [Android] Fix EnableZoomControl BP name and fix helper methods

fixes #6132
fixes #6130

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

5 years ago[Android] VisualElementRenderer and ElevationHelper should be public (#6131)
Daniel Luberda [Thu, 9 May 2019 17:57:59 +0000 (19:57 +0200)]
[Android] VisualElementRenderer and ElevationHelper should be public (#6131)

* VisualElementRenderer and ElevationHelper should be public

* ElevationHelper.SetElevation should be public

* remove comment

5 years ago[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchH...
Rui Marinho [Thu, 9 May 2019 17:42:19 +0000 (10:42 -0700)]
[Shell,iOS,Android] Add Colors, Font, HorizontalAlignment. Keyboard, Focus to SearchHandler (#5810)

* [Shell,iOS] Add Colors, Font , HorizontalAlignment and keyboard support to SearchHandler

* {Android]Allow set colors and customize text on Shell SearchHandler

* [Android] Update icons color on SearchView

* [Android] Update Placeholdericon color from one place

* [iOS] Update shell cancel button colours

* [iOS,Android] Update IconPlaceholder color

* [Core] Fix missing region

* [Controls] Add shell SearchHandlerPage

* [iOS] Fix alignment changes on SearchHandlerAppearanceTraccker

* [Shell,Core] Add focus to SearchHandler

* [Android] Add SearchHandler focus

* [iOS] Add SearchHandler focus

* [Controls] Reuse dynamic gallery for SearchHandler

* [Controls] Fixes to gallery

* [Android] Remove cancel button code

* [Android] Add extension point for SearchHandlerAppearanceTracker

* [Android] Fix spelling

* fix bad merge

fixes #3125
fixes #5768

5 years agoAdded memory leak gallery (#5795)
Pavel Yakovlev [Thu, 9 May 2019 16:49:01 +0000 (19:49 +0300)]
Added memory leak gallery (#5795)

* Added memory leak gallery

* fixes getting content

5 years ago[Android] Fix Frame size (#6115) fixes #5766
Pavel Yakovlev [Thu, 9 May 2019 16:20:37 +0000 (19:20 +0300)]
[Android] Fix Frame size (#6115) fixes #5766

5 years ago4.0 ABI Fixes (#6133) fixes #6123
Shane Neuville [Thu, 9 May 2019 16:17:59 +0000 (10:17 -0600)]
4.0 ABI Fixes (#6133) fixes #6123

* fix background image type

* additional abi fixes

* updated 4915 to test nav icon

* uwp fixes

* Update Xamarin.Forms.Platform.UAP/TabbedPageStyle.xaml

5 years ago[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items...
Rui Marinho [Thu, 9 May 2019 16:14:25 +0000 (09:14 -0700)]
[Shell,iOS,Android] Add accessibility features for navigation bar and toolbar items (#5758) fixes #5132

* [Controls,Shell] Add automation properties to FlyoutIcon

* [iOS] Set accessibility properties from flyout icon on ShellPageRenderer

* [Android] Add accessibility features to Shell flyout icon

* [Android] Add accessibility to shell toolbar and button items

* [Controls] Add uitest for issue #5132

* [Controls] Fix uitest android

* [Controls] Use new types

* [UItests] Only run on iOS and Android

Co-Authored-By: rmarinho <me@ruimarinho.net>
* [Controls] Add scrollview to test page

* [Android] Set icon AutomationId using NavigationContentDescription

* [Android] Restore code on AutomationPropertiesProvider

* [Android] Set help text or AutomationID for toolbar navigation content description

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

5 years ago[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)
Shane Neuville [Thu, 9 May 2019 07:05:57 +0000 (01:05 -0600)]
[iOS] add DesignerFlyoutRenderer when running as previewer (#6119)

* add DesignerFlyoutRenderer

* private and hack comment

* internal

5 years agoremove route params from shell (#6081)
Shane Neuville [Wed, 8 May 2019 23:15:43 +0000 (17:15 -0600)]
remove route params from shell (#6081)

* remove route params from shell

* Update Xamarin.Forms.Core.UnitTests/ShellTests.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
* fix unit test

5 years ago[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)
Shane Neuville [Wed, 8 May 2019 23:15:18 +0000 (17:15 -0600)]
[Shell] Add Tab bar and auto promote tabs to nearest TabBar (#6023)

* add tab bar and promote implicit tabs to same tabbar

* - remove parent

* remove tab bar from flyout

* Update Xamarin.Forms.Core/Shell/ShellItemCollection.cs

Co-Authored-By: PureWeen <shane94@hotmail.com>
5 years agoMake Android CollectionView smarter about recycling elements/renderers (#5980)
E.Z. Hart [Wed, 8 May 2019 23:14:18 +0000 (17:14 -0600)]
Make Android CollectionView smarter about recycling elements/renderers (#5980)

5 years ago[iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)
kicsiede [Wed, 8 May 2019 17:41:08 +0000 (19:41 +0200)]
[iOS] Fix: memory leak when Navigation.RemovePage is used (#5695)

* Fix: memoryleak when Navigation.RemovePage is used

The leak occurs in a MasterDetailPage.Detail = NavigationPage(ContentPage) scenario if the ContentPage has ToolBarItems. (ToolBarItems create a strong dependency therefore the ViewController of the NavigationPage must be explicitly disposed)

* + unit test

* fix issue attribute

5 years ago[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089...
E.Z. Hart [Wed, 8 May 2019 16:02:14 +0000 (10:02 -0600)]
[iOS] Add missing call to ReloadData on NotifyCollectionChangedAction.Reset (#6089) fixes #5793

* Add missing call to ReloadData on INCC Reset; fixes #5793

* Automated test for INCC Reset

5 years agoProfiler v11; No man init (#6087)
kingces95 [Tue, 7 May 2019 20:12:00 +0000 (10:12 -1000)]
Profiler v11; No man init (#6087)

5 years agoMerge branch '4.0.0'
Rui Marinho [Tue, 7 May 2019 17:07:23 +0000 (10:07 -0700)]
Merge branch '4.0.0'

5 years agoApply round corners shape based on radius (#6099)
Shane Neuville [Tue, 7 May 2019 16:52:53 +0000 (10:52 -0600)]
Apply round corners shape based on radius (#6099)

* Apply round corners shape based on radius

* update gallery

* apply to SmallComponentShape

* add color scheme back

* basic fixes

* - make corner radius default the same
- reapply theme on ios so corner is changeable
- force set ios border width to size

* fix border width for default and remove extra call to bgcolor

5 years agobetter exception message (#6101)
Stephane Delcroix [Tue, 7 May 2019 07:21:27 +0000 (09:21 +0200)]
better exception message (#6101)

5 years agoreturn from designer earlier (#6102)
Shane Neuville [Tue, 7 May 2019 01:44:00 +0000 (19:44 -0600)]
return from designer earlier (#6102)

* return from designer earlier

* - initialize fake coordinator layout for designer

* change to a non appcompat compatible layout

5 years agoUpdate screen size info after orientation change on Android/iOS (#5975)
E.Z. Hart [Mon, 6 May 2019 22:27:43 +0000 (16:27 -0600)]
Update screen size info after orientation change on Android/iOS (#5975)

* Update Android screen size info in Device when changing orientation;
Fixes #4992

* Add test instructions

* Update iOS screen size on orientation change

* Fix build error in UI Test projects

* Fix errors with #if directives in iOS/macOS projects

* Update Xamarin.Forms.Platform.MacOS/MacDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.Android/Forms.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
* Update Xamarin.Forms.Platform.iOS/IOSDeviceInfo.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
5 years agoTemplated view GetTemplateChild(string) (#5691)
Andrei Nitescu [Mon, 6 May 2019 21:49:10 +0000 (00:49 +0300)]
Templated view GetTemplateChild(string) (#5691)

* TemplatedView.GetTemplateChild(string)

* Small refactoring
fixes #1620
fixes #5674
closes #5343

5 years agorename SearchBoxVisibility (#6103)
Shane Neuville [Mon, 6 May 2019 20:31:06 +0000 (14:31 -0600)]
rename SearchBoxVisibility (#6103)

5 years agoHopefully fix the mdoc issues with the localization typo (#6105)
E.Z. Hart [Mon, 6 May 2019 20:29:27 +0000 (14:29 -0600)]
Hopefully fix the mdoc issues with the localization typo (#6105)

5 years ago[Android] Image load fixes (#6062)
Shane Neuville [Mon, 6 May 2019 17:13:36 +0000 (11:13 -0600)]
[Android] Image load fixes (#6062)

* fix loading for lollipop

* cache

* fix some loading behavior

* requested changes

* cache fixes

* API 19 fix

* fix sizeof and use lazy

* add better management over requests to same key

* add caching validity checks

* remove remove and fire and forget put

* synchronous put

* add disposed check for bitmap data

* max memory

5 years ago[iOS] Add missing null check to `SelectableItemsViewRenderer.SetupNewElement`. (...
E.Z. Hart [Mon, 6 May 2019 17:05:29 +0000 (11:05 -0600)]
[iOS] Add missing null check to `SelectableItemsViewRenderer.SetupNewElement`. (#6057)

* Reproduction

* Automate test

* Handle null element in SetupElement in the SelectableItemsViewRenderer
Fixes #5949

* Add manual test instructions

* Fix build errors

5 years agoMerge branch '4.0.0'
Stephane Delcroix [Mon, 6 May 2019 09:29:04 +0000 (11:29 +0200)]
Merge branch '4.0.0'

5 years agoIVT HotReload
Stephane Delcroix [Tue, 23 Apr 2019 20:03:10 +0000 (22:03 +0200)]
IVT HotReload

5 years agochanges transition to enter mask (#6066)
Shane Neuville [Fri, 3 May 2019 18:38:46 +0000 (12:38 -0600)]
changes transition to enter mask (#6066)

fixes #5216

5 years agoreport file location on error (#6024)
Stephane Delcroix [Fri, 3 May 2019 18:29:08 +0000 (20:29 +0200)]
report file location on error (#6024)

5 years ago[Xaml[C]] Allow to connect to static event handler (#5119)
Akihiko Odaki [Fri, 3 May 2019 18:25:03 +0000 (03:25 +0900)]
[Xaml[C]] Allow to connect to static event handler (#5119)

5 years agoChanged error message when Map.ItemTemplate is a DataTemplateSelector to direct the...
jcmanke [Fri, 3 May 2019 18:20:04 +0000 (13:20 -0500)]
Changed error message when Map.ItemTemplate is a DataTemplateSelector to direct the user to the ItemTemplateSelector property (#5944)

5 years ago[X] pass the instance along the rlq (#6007)
Stephane Delcroix [Thu, 2 May 2019 15:51:12 +0000 (17:51 +0200)]
[X] pass the instance along the rlq (#6007)

allow resourceprovider to track lifecycle of xaml-generated object

5 years ago[Android] Fix previewer exceptions with shell (#5955)
Shane Neuville [Thu, 2 May 2019 10:26:42 +0000 (04:26 -0600)]
[Android] Fix previewer exceptions with shell (#5955)

* shell preivewer

* nonappcompat hack

* - moove up null check

* internal IsDesignerContext

5 years agoAdd B40005 test case (#5912)
mkieres [Wed, 1 May 2019 18:42:21 +0000 (04:42 +1000)]
Add B40005 test case (#5912)

fixes #2339