caseq@chromium.org [Mon, 9 Apr 2012 17:36:53 +0000 (17:36 +0000)]
Web Inspector: zoom on vertical mousewheel in Timeline overview
https://bugs.webkit.org/show_bug.cgi?id=83379
Reviewed by Pavel Feldman.
- added support for zooming around mouse cursor upon mousewheel event;
- handle mousewheel event by _onMouseWheel, not scrollWindow, so we only zoom on events internal to overview.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow):
(WebInspector.TimelineOverviewWindow.prototype._endWindowSelectorDragging):
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113591
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bbudge@chromium.org [Mon, 9 Apr 2012 17:17:25 +0000 (17:17 +0000)]
Cross-origin preflight request should not include credentials.
https://bugs.webkit.org/show_bug.cgi?id=37676
Source/WebCore:
Modifies createAccessControlPreflightRequest so it never allows credentials.
Reviewed by Adam Barth.
http/tests/xmlhttprequest/access-control-preflight-credential-sync.html
http/tests/xmlhttprequest/access-control-preflight-credential-async.html
* loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest):
* loader/CrossOriginAccessControl.h:
(WebCore):
* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequestWithPreflight):
LayoutTests:
Modifies preflight credential tests to make sure that cookies aren't sent along with the
CORS prefetch request.
Reviewed by Adam Barth.
* http/tests/xmlhttprequest/access-control-preflight-credential-async-expected.txt:
* http/tests/xmlhttprequest/access-control-preflight-credential-async.html:
* http/tests/xmlhttprequest/access-control-preflight-credential-sync-expected.txt:
* http/tests/xmlhttprequest/access-control-preflight-credential-sync.html:
* http/tests/xmlhttprequest/resources/basic-auth/access-control-auth-basic.php:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113589
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 9 Apr 2012 17:01:06 +0000 (17:01 +0000)]
Don't expose internal CSSValues in API
https://bugs.webkit.org/show_bug.cgi?id=83426
Reviewed by Andreas Kling.
The CSSValues returned from functions like CSSStyleDeclaration.getPropertyCSSValue() are currently
the same instances we use internally. This creates various problems. The values can't be shared between
documents as the wrappers would be shared too. Having to maintain per-document CSSValuePools complicate
the architecture and increase memory usage. This also blocks sharing style sheet data structures
between documents.
This patch adds a concept of CSSOM-safe CSSValue. Only the safe values can be wrapped for JS access.
Values are unsafe by default. The CSSOM functions that return CSSValues create safe instances by
cloning the internal values.
The use of APIs that return CSSValues is very rare (the currect CSSOM draft deprecates them) and
cloning is cheap in any case. Future patches will eliminate the per-document value pool in favor
of a global one for a memory win.
In the future we want to replace internally used CSSValues with true internal types (StyleValues) and
use CSSValues exclusively as wrappers (similar to how CSSStyleRule wraps internal StyleRule).
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore):
(WebCore::CSSImageSetValue::cloneForCSSOM):
* css/CSSImageSetValue.h:
(CSSImageSetValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::cleanup):
Opportunistically fix a string leak for CSS_COUNTER_NAME values.
Add all cases, remove default.
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::setCSSOMSafe):
* css/CSSValue.cpp:
(WebCore):
(TextCloneCSSValue):
(WebCore::TextCloneCSSValue::create):
(WebCore::TextCloneCSSValue::cssText):
(WebCore::TextCloneCSSValue::TextCloneCSSValue):
Most non-primitive value types are not exposed in CSSOM. For those we create a dummy value
that contains only the data that is accessible though the base CSSValue interface.
(WebCore::CSSValue::addSubresourceStyleURLs):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
* css/CSSValue.h:
(WebCore):
(CSSValue):
(WebCore::CSSValue::isCSSOMSafe):
(WebCore::CSSValue::isSubtypeExposedToCSSOM):
(WebCore::CSSValue::CSSValue):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::CSSValueList):
(WebCore):
(WebCore::CSSValueList::cloneForCSSOM):
* css/CSSValueList.h:
(CSSValueList):
* css/Counter.h:
(Counter):
(WebCore::Counter::cloneForCSSOM):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
(WebCore::PropertySetCSSStyleDeclaration::didMutate):
(WebCore):
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM):
Maintain a map of safe CSSValues so we can maintain object identity.
* css/PropertySetCSSStyleDeclaration.h:
(WebCore::PropertySetCSSStyleDeclaration::setNeedsStyleRecalc):
(PropertySetCSSStyleDeclaration):
* css/RGBColor.cpp:
(WebCore::RGBColor::red):
(WebCore::RGBColor::green):
(WebCore::RGBColor::blue):
(WebCore::RGBColor::alpha):
* css/Rect.h:
(WebCore::RectBase::RectBase):
(RectBase):
(Rect):
(WebCore::Rect::cloneForCSSOM):
(WebCore::Rect::Rect):
(Quad):
(WebCore::Quad::cloneForCSSOM):
(WebCore::Quad::Quad):
* css/WebKitCSSFilterValue.cpp:
(WebCore::WebKitCSSFilterValue::WebKitCSSFilterValue):
(WebCore):
(WebCore::WebKitCSSFilterValue::cloneForCSSOM):
* css/WebKitCSSFilterValue.h:
(WebKitCSSFilterValue):
* css/WebKitCSSTransformValue.cpp:
(WebCore::WebKitCSSTransformValue::WebKitCSSTransformValue):
(WebCore):
(WebCore::WebKitCSSTransformValue::cloneForCSSOM):
* css/WebKitCSSTransformValue.h:
(WebKitCSSTransformValue):
* svg/SVGColor.cpp:
(WebCore::SVGColor::SVGColor):
(WebCore):
(WebCore::SVGColor::cloneForCSSOM):
* svg/SVGColor.h:
(SVGColor):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::SVGPaint):
(WebCore):
(WebCore::SVGPaint::cloneForCSSOM):
* svg/SVGPaint.h:
(SVGPaint):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::getPresentationAttribute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113588
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Apr 2012 16:44:15 +0000 (16:44 +0000)]
Web Inspector: get rid of WebInspector.Resource.category, use WebInspector.Resource.type instead.
https://bugs.webkit.org/show_bug.cgi?id=83467
Reviewed by Yury Semikhatsky.
Source/WebCore:
WebInspector.Resource.category is derived from the WebInspector.Resource.type and there is no real need it maintaining both.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AuditLauncherView.js:
(WebInspector.AuditLauncherView.prototype._onResourceStarted):
(WebInspector.AuditLauncherView.prototype._onResourceFinished):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
(WebInspector.AuditRules.CombineJsResourcesRule):
(WebInspector.AuditRules.CombineCssResourcesRule):
(WebInspector.AuditRules.ParallelizeDownloadRule.prototype.doRun):
(WebInspector.AuditRules.UnusedCssRule.prototype.doRun.evalCallback.selectorsCallback):
(WebInspector.AuditRules.CacheControlRule.prototype.isCompressible):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
(WebInspector.CSSStyleModelResourceBinding.prototype.setContent):
(WebInspector.CSSStyleModelResourceBinding.prototype._innerStyleSheetChanged):
* inspector/front-end/ContentProviders.js:
(WebInspector.ResourceContentProvider):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModelResourceBinding):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype._getPopoverAnchor):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._makeResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._mimeTypeIsConsistentWithType):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.responseReceived):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._createFilterStatusBarItems):
(WebInspector.NetworkLogView.prototype._updateSummaryBar):
(WebInspector.NetworkDataGridNode.prototype.isFilteredOut):
(WebInspector.NetworkDataGridNode.prototype.refreshResource):
(WebInspector.NetworkDataGridNode.prototype._refreshNameCell):
(WebInspector.NetworkDataGridNode.prototype.refreshGraph):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.registerDomainModelBinding):
(WebInspector.Resource.prototype.set type):
(WebInspector.Resource.prototype.isEditable):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.requestContent):
* inspector/front-end/ResourceCategory.js: Removed.
* inspector/front-end/ResourcePreviewView.js:
(WebInspector.ResourcePreviewView.prototype._createPreviewView):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._onResourceUpdated):
(WebInspector.ResourceTreeModel.prototype._onResourceUpdateDropped):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
* inspector/front-end/ResourceType.js: Added.
(WebInspector.ResourceType):
(WebInspector.ResourceType.prototype.name):
(WebInspector.ResourceType.prototype.title):
(WebInspector.ResourceType.prototype.categoryTitle):
(WebInspector.ResourceType.prototype.color):
(WebInspector.ResourceType.prototype.isTextType):
(WebInspector.ResourceType.prototype.toString):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.hasTextContent):
(WebInspector.ResourceView.nonSourceViewForResource):
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameTreeElement.prototype.appendResource):
(WebInspector.FrameResourceTreeElement):
(WebInspector.FrameResourceTreeElement.prototype.onattach):
(WebInspector.ResourceRevisionTreeElement):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* http/tests/inspector/network/async-xhr-json-mime-type-expected.txt:
* http/tests/inspector/network/network-iframe-load-and-delete-expected.txt:
* http/tests/inspector/network/network-xhr-async-expected.txt:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource.html:
* http/tests/inspector/network/network-xhr-sync-expected.txt:
* http/tests/inspector/resource-tree/resource-tree-invalid-mime-type-css-content.html:
* http/tests/inspector/resource-tree/resource-tree-mimetype.html:
* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest.InspectorTest.dumpResourceTreeEverything):
(initialize_ResourceTreeTest):
* inspector/debugger/raw-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113587
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Mon, 9 Apr 2012 16:37:33 +0000 (16:37 +0000)]
Unreviewed, adding a missing header for the Qt port.
* Target.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113586
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Apr 2012 16:35:58 +0000 (16:35 +0000)]
Web Inspector: [network panel] type column shows "undefined" instead of "(Pending)" upon load.
https://bugs.webkit.org/show_bug.cgi?id=83470
Reviewed by Yury Semikhatsky.
isPingRequest is tested for as a field, not a function return value.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshTypeCell):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Mon, 9 Apr 2012 16:34:46 +0000 (16:34 +0000)]
REGRESSION (r94492): Incorrect initial layout of absolutely positioned <input> inside centering div
https://bugs.webkit.org/show_bug.cgi?id=77754
Reviewed by David Hyatt.
Source/WebCore:
The correct static position of an center-aligned, inline, absolutely positioned object with a block child can't be known
until the width of the child has been computed. This means that setStaticPositions() in RenderBlockLineLayout is setting
the position too early, before the width of the child has been finalised. To fix, adjust the static position of the inline
positioned object once its child's width has been calculated.
Test: fast/css/align-positioned-object-on-resize.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutPositionedObjects):
LayoutTests:
* fast/css/align-positioned-object-on-resize-expected.txt: Added.
* fast/css/align-positioned-object-on-resize.html: Added.
* platform/qt/Skipped: Skipped on Qt as window.resizeTo() does not work properly in Qt DRT.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 9 Apr 2012 16:12:24 +0000 (16:12 +0000)]
WebVTT parser unnecessarily limits the value of a timestamp
https://bugs.webkit.org/show_bug.cgi?id=83422
Reviewed by Dan Bernstein.
Source/WebCore:
Test: media/track/track-large-timestamp.html
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::collectTimeStamp): Make all constants double instead of int so
the maximum number of hours is increased and so we don't need any casts.
LayoutTests:
* media/track/captions-webvtt/large-timestamp.vtt: Added.
* media/track/track-large-timestamp-expected.txt: Added.
* media/track/track-large-timestamp.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Mon, 9 Apr 2012 16:03:46 +0000 (16:03 +0000)]
Incorrect placement of new child to table when before child parent is not |this|.
https://bugs.webkit.org/show_bug.cgi?id=82630
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/table/table-row-split2.html
fast/table/table-section-split2.html
fast/table/table-split.html
fast/table/table-split2.html
and tested by layouttests in commits r97180, r108127, and a few others.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks): function rename, block->box.
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks): ditto.
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): ditto.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::moveChildTo): move these functions from RenderBlock, needs to be
used in RenderBox::splitAnonymousBoxesAroundChild.
(WebCore):
(WebCore::RenderBox::moveChildrenTo): ditto.
(WebCore::markBoxForRelayoutAfterSplit): helper to mark a block or table part for complete relayout
after anonymous boxes are split around child.
(WebCore::RenderBox::splitAnonymousBoxesAroundChild): moved from RenderBlock to be able
to work with table parts.
* rendering/RenderBox.h:
(RenderBox):
(WebCore::RenderBox::moveChildTo):
(WebCore::RenderBox::moveAllChildrenTo):
(WebCore::RenderBox::moveChildrenTo):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild): no longer need the hack added in r95461.
* rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveChildren): function rename, block->box.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild): Use splitAnonymousBoxesAroundChild function when |beforeChild| != |this|.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::addChild): ditto.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::addChild): ditto.
LayoutTests:
* fast/table/cell-in-row-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
* fast/table/cell-in-row-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
* fast/table/row-in-tbody-before-misnested-text-crash-css-expected.txt: rebaseline, corrects layout.
* fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: rebaseline, corrects layout.
* fast/table/table-row-split2-expected.png: Added.
* fast/table/table-row-split2-expected.txt: Added.
* fast/table/table-row-split2.html: Added.
* fast/table/table-section-split2-expected.png: Added.
* fast/table/table-section-split2-expected.txt: Added.
* fast/table/table-section-split2.html: Added.
* fast/table/table-split-expected.png: Added.
* fast/table/table-split-expected.txt: Added.
* fast/table/table-split.html: Added.
* fast/table/table-split2-expected.png: Added.
* fast/table/table-split2-expected.txt: Added.
* fast/table/table-split2.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jocelyn.turcotte@nokia.com [Mon, 9 Apr 2012 15:31:10 +0000 (15:31 +0000)]
WebSocketServer: Honour WebSocketFrame::masked in makeFrameData
https://bugs.webkit.org/show_bug.cgi?id=83042
Reviewed by Kent Tamura.
Frames from the server should not be masked.
Currently, the flag is set to false, but the frames were masked anyway.
This causes clients with recent builds of WebKit to abort the connection to the
inspector server, refusing masked frames from the server as per the spec.
This doesn't change the behavior of WebSocket clients, which set the masked flag to true.
* Modules/websockets/WebSocketFrame.cpp:
(WebCore::appendFramePayload):
(WebCore::WebSocketFrame::makeFrameData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Mon, 9 Apr 2012 15:29:47 +0000 (15:29 +0000)]
Layout Test in svg are failing
https://bugs.webkit.org/show_bug.cgi?id=82232
Unreviewed Chromium expectations update.
All the tests covered by this bug ran without crashes over a five day
period. Given the previous crash rates, this suggests we've fixed the
problem.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis.menard@openbossa.org [Mon, 9 Apr 2012 13:43:25 +0000 (13:43 +0000)]
[Part 5] We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=83466
Reviewed by Kentaro Hara.
CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers, this patch should adress the last remaining occurences of ints rather than CSSPropertyIDs.
No new tests : There should be no behavior change in this patch.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* css/CSSStyleSelector.h:
(CSSStyleSelector):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::removePropertiesInSet):
* page/animation/AnimationBase.cpp:
(WebCore::gatherEnclosingShorthandProperties):
(WebCore::AnimationBase::animatableShorthandsAffectingProperty):
* page/animation/AnimationBase.h:
(AnimationBase):
* page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::pauseTransitionAtTime):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
(WebCore::KeyframeAnimation::getAnimatedStyle):
(WebCore::KeyframeAnimation::overrideAnimations):
(WebCore::KeyframeAnimation::resumeOverriddenAnimations):
(WebCore::KeyframeAnimation::timeToNextService):
* rendering/style/KeyframeList.cpp:
(WebCore::KeyframeList::insert):
* rendering/style/KeyframeList.h:
(WebCore::KeyframeValue::addProperty):
(WebCore::KeyframeValue::containsProperty):
(WebCore::KeyframeValue::properties):
(KeyframeValue):
(WebCore::KeyframeList::addProperty):
(WebCore::KeyframeList::containsProperty):
(WebCore::KeyframeList::beginProperties):
(WebCore::KeyframeList::endProperties):
(KeyframeList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Mon, 9 Apr 2012 13:34:54 +0000 (13:34 +0000)]
Unreviewed, rebaselined run-bindings-tests results.
* bindings/scripts/test/JS/JSFloat64Array.cpp:
(WebCore::JSFloat64ArrayConstructor::getOwnPropertySlot):
(WebCore::JSFloat64ArrayConstructor::getOwnPropertyDescriptor):
(WebCore::jsFloat64ArrayConstructor):
(WebCore::JSFloat64Array::getConstructor):
(WebCore::jsFloat64ArrayPrototypeFunctionFoo):
(WebCore::toFloat64Array):
* bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertySlot):
(WebCore::JSTestActiveDOMObjectConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectConstructor):
(WebCore::JSTestActiveDOMObject::getConstructor):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionPostMessage):
(WebCore::JSTestActiveDOMObjectOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestActiveDOMObjectOwner::finalize):
(WebCore::toTestActiveDOMObject):
* bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertySlot):
(WebCore::JSTestCustomNamedGetterConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::JSTestCustomNamedGetter::getConstructor):
(WebCore::jsTestCustomNamedGetterPrototypeFunctionAnotherFunction):
(WebCore::JSTestCustomNamedGetterOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestCustomNamedGetterOwner::finalize):
(WebCore::toTestCustomNamedGetter):
* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestEventConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestEventConstructorConstructor::constructJSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorConstructor):
(WebCore::JSTestEventConstructor::getConstructor):
(WebCore::JSTestEventConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventConstructorOwner::finalize):
(WebCore::toTestEventConstructor):
* bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetConstructor::getOwnPropertySlot):
(WebCore::JSTestEventTargetConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestEventTargetConstructor):
(WebCore::JSTestEventTarget::getConstructor):
(WebCore::jsTestEventTargetPrototypeFunctionItem):
(WebCore::jsTestEventTargetPrototypeFunctionAddEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionRemoveEventListener):
(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::indexGetter):
(WebCore::JSTestEventTargetOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestEventTargetOwner::finalize):
(WebCore::toTestEventTarget):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
(WebCore::jsTestInterfaceConstructor):
(WebCore::setJSTestInterfaceSupplementalStr2):
(WebCore::setJSTestInterfaceSupplementalStr3):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::JSTestInterface::getConstructor):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod1):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod3):
(WebCore::JSTestInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestInterfaceOwner::finalize):
(WebCore::toTestInterface):
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertyDescriptor):
(WebCore::jsTestMediaQueryListListenerConstructor):
(WebCore::JSTestMediaQueryListListener::getConstructor):
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):
(WebCore::JSTestMediaQueryListListenerOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestMediaQueryListListenerOwner::finalize):
(WebCore::toTestMediaQueryListListener):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertySlot):
(WebCore::JSTestNamedConstructorConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor):
(WebCore::JSTestNamedConstructor::getConstructor):
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestNamedConstructorOwner::finalize):
(WebCore::toTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestObjConstructor::constructJSTestObj):
(WebCore::jsTestObjReadOnlyIntAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjIntAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjSequenceAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjAttrWithGetterException):
(WebCore::jsTestObjAttrWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjConditionalAttr4Constructor):
(WebCore::jsTestObjConditionalAttr5Constructor):
(WebCore::jsTestObjConditionalAttr6Constructor):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjImmutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjStrictFloat):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjConstructor):
(WebCore::setJSTestObjShortAttr):
(WebCore::setJSTestObjUnsignedShortAttr):
(WebCore::setJSTestObjIntAttr):
(WebCore::setJSTestObjLongLongAttr):
(WebCore::setJSTestObjUnsignedLongLongAttr):
(WebCore::setJSTestObjStringAttr):
(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjSequenceAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjCreate):
(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedIntegralAttr):
(WebCore::setJSTestObjReflectedUnsignedIntegralAttr):
(WebCore::setJSTestObjReflectedBooleanAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomIntegralAttr):
(WebCore::setJSTestObjReflectedCustomBooleanAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):
(WebCore::setJSTestObjAttrWithGetterException):
(WebCore::setJSTestObjAttrWithSetterException):
(WebCore::setJSTestObjStringAttrWithGetterException):
(WebCore::setJSTestObjStringAttrWithSetterException):
(WebCore::setJSTestObjCustomAttr):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjConditionalAttr1):
(WebCore::setJSTestObjConditionalAttr2):
(WebCore::setJSTestObjConditionalAttr3):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::setJSTestObjStrawberry):
(WebCore::setJSTestObjStrictFloat):
(WebCore::setJSTestObjId):
(WebCore::JSTestObj::getConstructor):
(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomMethod):
(WebCore::jsTestObjPrototypeFunctionCustomMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces):
(WebCore::jsTestObjPrototypeFunctionWithScriptArgumentsAndCallStack):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalString):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsUndefined):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7):
(WebCore::jsTestObjPrototypeFunctionMethodWithUnsignedLongArray):
(WebCore::jsTestObjPrototypeFunctionGetSVGDocument):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert3):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionMutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionImmutablePointFunction):
(WebCore::jsTestObjPrototypeFunctionOrange):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::JSTestObjOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestObjOwner::finalize):
(WebCore::toTestObj):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceConstructor):
(WebCore::setJSTestSerializedScriptValueInterfaceValue):
(WebCore::setJSTestSerializedScriptValueInterfaceCachedValue):
(WebCore::JSTestSerializedScriptValueInterface::getConstructor):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
(WebCore::toTestSerializedScriptValueInterface):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Mon, 9 Apr 2012 13:24:04 +0000 (13:24 +0000)]
[BlackBerry] Upstream BlackBerry change to WebCore::TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=83454
Reviewed by Rob Buis.
BlackBerry-port enhances the TouchEvent by adding member variables
to indicate if the event is double-tap or touch-hold.
* dom/TouchEvent.cpp:
(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):
* dom/TouchEvent.h:
(TouchEvent):
(WebCore::TouchEvent::setDoubleTap):
(WebCore::TouchEvent::isDoubleTap):
(WebCore::TouchEvent::setTouchHold):
(WebCore::TouchEvent::isTouchHold):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 9 Apr 2012 12:35:56 +0000 (12:35 +0000)]
[CMake] Build fix for USE_SYSTEM_MALLOC after r113570.
.:
* Source/cmakeconfig.h.cmake:
Source/WTF:
* wtf/CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 11:42:18 +0000 (11:42 +0000)]
Remove partially implemented per-Element visibility checks from requestAnimationFrame logic
https://bugs.webkit.org/show_bug.cgi?id=74232
Patch by James Robinson <jamesr@chromium.org> on 2012-04-09
Reviewed by Dean Jackson.
Source/WebCore:
The initial requestAnimationFrame implementation had an Element parameter as the second argument to the
function. This element was intended to convey the element associated with the animation so that when the element
was not visible the animation callback would not be run. The checked in implementation does a very limited check
- testing for display:none and being detached from the tree - but does it in a way that does not work correctly
if an element's visibility is manipulated by a callback running from a different document. It also adds
significant complexity to the code, making it less hackable and easy to introduce subtle security bugs or
infinite loops.
This patch removes the parameter. Since it has always been marked optional, there is no web compat risk.
If this functionality is added back in the future it needs to be implemented in a way that considers all
callbacks within a Page and not only those within a single Document.
* dom/Document.cpp:
(WebCore::Document::webkitRequestAnimationFrame):
* dom/Document.h:
* dom/RequestAnimationFrameCallback.h:
* dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
* dom/ScriptedAnimationController.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitRequestAnimationFrame):
* page/DOMWindow.h:
* page/DOMWindow.idl:
LayoutTests:
Remove tests for removed functionality.
* fast/animation/request-animation-frame-display-expected.txt: Removed.
* fast/animation/request-animation-frame-display.html: Removed.
* fast/animation/script-tests/request-animation-frame-display.js: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 9 Apr 2012 10:58:06 +0000 (10:58 +0000)]
Build fix for WinCE after r113570.
* Scripts/build-webkit: Do not use FastMalloc for WinCE.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 9 Apr 2012 10:49:40 +0000 (10:49 +0000)]
Remove HAVE_STDINT_H
https://bugs.webkit.org/show_bug.cgi?id=83434
Reviewed by Kentaro Hara.
HAVE_STDINT_H is defined with 1 all the time and we us stdint.h without HAVE(STDINT_H) already.
Source/JavaScriptCore:
* config.h:
Source/WTF:
* config.h:
* wtf/FastMalloc.cpp:
* wtf/TCPageMap.h:
* wtf/TCSpinLock.h:
* wtf/TCSystemAlloc.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Mon, 9 Apr 2012 10:45:15 +0000 (10:45 +0000)]
[CMake] Share build system options across ports
https://bugs.webkit.org/show_bug.cgi?id=72815
Reviewed by Daniel Bates.
Don't define the generic features for every port again.
Add a few macros for reusing the central defined options.
* CMakeLists.txt:
* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmake/OptionsEfl.cmake:
* Source/cmake/OptionsWinCE.cmake:
* Source/cmake/WebKitFeatures.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 10:33:22 +0000 (10:33 +0000)]
[Blackberry] m_isRequestedByPlugin should be copied in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=83447
Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-04-09
Reviewed by George Staikos.
It is an obvious error, We should copy m_isRequestedByPlugin in ResourceReuest.
No new tests, because those existing plugin test cases are enough.
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore::ResourceRequest::doPlatformCopyData):
(WebCore::ResourceRequest::doPlatformAdopt):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 9 Apr 2012 10:19:25 +0000 (10:19 +0000)]
Subscribe eric.carlson@apple.com to Media-related changes
https://bugs.webkit.org/show_bug.cgi?id=83421
Reviewed by Dan Bernstein.
* Scripts/webkitpy/common/config/watchlist:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 9 Apr 2012 10:02:11 +0000 (10:02 +0000)]
Layout Test http/tests/media/media-document.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=83391
[Chromium] Unreviewed gardening.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Mon, 9 Apr 2012 09:50:18 +0000 (09:50 +0000)]
several http tests are flaky and crashing on win, debug
https://bugs.webkit.org/show_bug.cgi?id=82505
Remove the expectations of a crash now that the fix (http://crrev.com/131170)
has rolled into webkit in http://trac.webkit.org/changeset/113512
Reviewed by Tony Chang.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 09:48:31 +0000 (09:48 +0000)]
check-webkit-style should ignore NULL usage in gtk_style_context_get_style
https://bugs.webkit.org/show_bug.cgi?id=83412
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-09
Reviewed by David Levin.
Accept NULL as an argument for gtk_style_context_get_style, because it's
used as a sentinel in a variable argument list.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_for_null): Add an exception.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_null_false_zero): Add a test for the exception.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Apr 2012 09:42:56 +0000 (09:42 +0000)]
Not reviewed: fixing inspector front-end compilation that has been broken by the
recent SaveAs and DOMStorage changes.
* inspector/front-end/DOMStorage.js:
* inspector/front-end/externs.js:
(WebInspector.isURLSaved):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Apr 2012 09:39:21 +0000 (09:39 +0000)]
Web Inspector: remove ComboBoxFileSelector and SingleFileEditorContainer.
https://bugs.webkit.org/show_bug.cgi?id=83460
Reviewed by Yury Semikhatsky.
Source/WebCore:
We are now using scripts navigator and tabbed editor container, removing the old components.
This change removes the corresponding classes and the abstractions used during the
transition period.
* English.lproj/localizedStrings.js:
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype._scriptSelected):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.get this):
(WebInspector.ScriptsPanel.prototype.get defaultFocusedElement):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype.setScriptSourceIsDirty):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype._showFile):
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._editorClosed):
(WebInspector.ScriptsPanel.prototype._scriptSelected):
(WebInspector.ScriptsPanel.prototype._hidePinnedNavigator):
(WebInspector.ScriptsPanel.prototype.set _pinNavigator):
* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainerDelegate):
(WebInspector.TabbedEditorContainerDelegate.prototype.viewForFile):
(get WebInspector):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
* inspector/front-end/scriptsPanel.css:
LayoutTests:
* inspector/debugger/scripts-combobox-file-selector-history-expected.txt: Removed.
* inspector/debugger/scripts-combobox-file-selector-history.html: Removed.
* inspector/debugger/scripts-file-selector-expected.txt:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Mon, 9 Apr 2012 09:22:44 +0000 (09:22 +0000)]
webkitpy: use the filesystem object properly in fileuploader
https://bugs.webkit.org/show_bug.cgi?id=83326
Reviewed by Adam Barth.
We should be using the filesystem object rather than the codecs
object.
* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader.upload_as_multipart_form_data):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 09:05:50 +0000 (09:05 +0000)]
[chromium] Make culling work with clipped rects
https://bugs.webkit.org/show_bug.cgi?id=83217
Patch by Dana Jansens <danakj@chromium.org> on 2012-04-09
Reviewed by Adrienne Walker.
Source/WebCore:
Use new CCMathUtil transformation methods to deal with rects that clip
the camera plane. This fixes three things:
1. A layer completely behind the camera is not visible and should not
occlude.
2. A layer that is clipped by the camera is treated like a
non-axis-aligned transform, as the result of a mapClippedRect() is a
bounding box and may contain pixels not in the original rect. This guards
our use of mapRect() when transforming occluded regions.
3. A layer's occlusion must be clipped by its scissor rect. This scissor
rect exists in its target space, so occlusion in screen space is only
possible if its target also is axis aligned in the screen, such that
the layer's scissor rect remains a rect in screen space.
Unit tests: CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude
CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::computeOcclusionBehindLayer):
(WebCore::::markOccludedBehindLayer):
(WebCore::testContentRectOccluded):
(WebCore::computeUnoccludedContentRect):
Source/WebKit/chromium:
* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude):
(WebKitTests::CCOcclusionTrackerTestLayerBehindCameraDoesNotOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect):
(WebKitTests::CCOcclusionTrackerTestLargePixelsOccludeInsideClipRect::runMyTest):
* tests/CCQuadCullerTest.cpp:
(WebCore::TestCCOcclusionTrackerImpl::TestCCOcclusionTrackerImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 08:49:02 +0000 (08:49 +0000)]
[Gtk] Web Inspector noinst_DATA images are copied into innacurately named directory
https://bugs.webkit.org/show_bug.cgi?id=83423
Patch by Zan Dobersek <zandobersek@gmail.com> on 2012-04-09
Reviewed by Martin Robinson.
Copy Web Inspector images that are a part of the data not meant
for installation into a directory named 'Images' rather than
a lower-case version of that. This is required as until now,
when using these inspector resources (for example during layout
tests or manually pointing WEBKIT_INSPECTOR_PATH env to that
location), the images were not displayed as they were not loadable.
No new tests - no new functionality.
* GNUmakefile.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 9 Apr 2012 07:55:12 +0000 (07:55 +0000)]
Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329
Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
line 62, in _create_unit_test_results
return UnitTestResults.results_from_string(results_xml)
NameError: global name 'UnitTestResults' is not defined
* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_create_unit_test_results):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 9 Apr 2012 07:50:42 +0000 (07:50 +0000)]
Web Inspector: move breakpoints active state from scripts panel to debugger presentation model.
https://bugs.webkit.org/show_bug.cgi?id=83374
Reviewed by Yury Semikhatsky.
Source/WebCore:
Just moves the state and adds event to propagate it. This is needed to abstract
JavaScriptSourceFrame from the ScriptsPanel.
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.prototype.setBreakpointsActive):
(WebInspector.DebuggerPresentationModel.prototype.breakpointsActive):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
(WebInspector.ScriptsPanel.prototype._breakpointsActiveStateChanged):
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
LayoutTests:
* http/tests/inspector/debugger-test.js:
* inspector/debugger/debugger-breakpoints-not-activated-on-reload.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 9 Apr 2012 07:48:08 +0000 (07:48 +0000)]
DFG should not load the property storage if it is inline.
https://bugs.webkit.org/show_bug.cgi?id=83455
Reviewed by Gavin Barraclough.
We had previously decided to have all property storage accesses go through
the property storage pointer even if they don't "really" have to, because
we were thinking this would help GC barriers somehow. Well, we never ended
up doing anything with that. Hence, doing these wasted loads of the
property storage pointer when the storage is inline is just a waste of CPU
cycles.
This change makes the DFG's inline property accesses (GetByOffset and
PutByOffset) go directly to the inline property storage if the structure(s)
tell us that it's OK.
This looks like an across-the-board 1% win.
* bytecode/StructureSet.h:
(JSC):
(JSC::StructureSet::allAreUsingInlinePropertyStorage):
(StructureSet):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillStorage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 9 Apr 2012 05:25:55 +0000 (05:25 +0000)]
[mac] REGRESSION (r113467): Some canvas tests are failing in WebKit1 when run after compositing/tiled-layers-hidpi.html
https://bugs.webkit.org/show_bug.cgi?id=83453
Reviewed by Sam Weinig.
* WebView/WebView.mm:
(-[WebView _setCustomBackingScaleFactor:]): When the scale factor parameter was 0, meaning
no custom scale factor, this method was setting the Page scale factor to 0, and that value
was used by canvas. Changed it to correctly set the Page scale factor back to the device
scale factor.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 9 Apr 2012 04:59:28 +0000 (04:59 +0000)]
<content> in <meter> is not rendered correctly.
https://bugs.webkit.org/show_bug.cgi?id=81311
This code changes a code location where MeterValueElement's value
attribute is initialized. In the old code, HTMLMeterElement's attach
did. It is better to initialize the attribute just after creating
meter's shadow subtree.
Patch by Takashi Sakamoto <tasak@google.com> on 2012-04-08
Reviewed by Hajime Morita.
No new tests, because an existing test,
content-element-in-meter-element.html covers.
However test_expectations.txt is changed. Now the test passes.
* html/HTMLMeterElement.cpp:
* html/HTMLMeterElement.h:
(HTMLMeterElement):
(HTMLMeterElement::attach):
Removed attach method, because attach method is just calling
LabelableElement::attach after removing didElementStateChange.
(HTMLMeterElement::createShadowSubTree):
Added setWidthPercentage to initialize MeterValueElement's value
attribute.
* LayoutTests/platform/chromium/test_expectations.txt:
Removed BUGWK81311 fast/dom/shadow/content-element-in-meter.html,
because now contentElementInMeterElement passes.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 9 Apr 2012 04:04:22 +0000 (04:04 +0000)]
The port object is missing unit_tests_results_path
https://bugs.webkit.org/show_bug.cgi?id=83448
Unreviewed.
This is causing the cr-linux-ews to throw an exception.
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.unit_tests_results_path):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sun, 8 Apr 2012 20:50:50 +0000 (20:50 +0000)]
Command-line jsc's exception handling should be rationalized
https://bugs.webkit.org/show_bug.cgi?id=83437
Reviewed by Dan Bernstein.
- If an exception is thrown during run() execution, it is now propagated,
so that it will terminate program execution unless it is caught.
- If program execution terminates with an exception, the exception is now
always printed.
- When printing the exception, the backtrace is now also printed if one is
available. It will only not be available if you use something akin to my
favorite line of code, 'throw "error"', since primitives don't have
properties and hence we cannot attach a "stack" property to them.
* jsc.cpp:
(functionRun):
(runWithScripts):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sun, 8 Apr 2012 20:46:12 +0000 (20:46 +0000)]
Forced OSR exits should lead to recompilation based on count, not rate
https://bugs.webkit.org/show_bug.cgi?id=83247
<rdar://problem/
10720925>
Reviewed by Geoff Garen.
Track which OSR exits happen because of inadequate coverage. Count them
separately. If the count reaches a threshold, immediately trigger
reoptimization.
This is in contrast to the recompilation trigger for all other OSR exits.
Normally recomp is triggered when the exit rate exceeds a certain ratio.
Looks like a slight V8 speedup (sub 1%).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::forcedOSRExitCounter):
(JSC::CodeBlock::addressOfForcedOSRExitCounter):
(JSC::CodeBlock::offsetOfForcedOSRExitCounter):
(JSC::CodeBlock::shouldReoptimizeNow):
(JSC::CodeBlock::shouldReoptimizeFromLoopNow):
(CodeBlock):
* bytecode/DFGExitProfile.h:
(JSC::DFG::exitKindToString):
* dfg/DFGOSRExitCompiler.cpp:
(JSC::DFG::OSRExitCompiler::handleExitCounts):
(DFG):
* dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sun, 8 Apr 2012 18:35:53 +0000 (18:35 +0000)]
Build fix for !ENABLE(CSS_FILTERS) && ASSERT_DISABLED after r109953.
* platform/graphics/ca/GraphicsLayerCA.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scherkus@chromium.org [Sun, 8 Apr 2012 03:45:55 +0000 (03:45 +0000)]
2012-04-07 Andrew Scherkus <scherkus@chromium.org>
[Chromium] Unreviewed, checking in baselines for video-frame-size-change.html.
* platform/chromium-linux/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-linux/platform/chromium/media/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-leopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-leopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/media/video-frame-size-change-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-mac/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
* platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.png: Added.
* platform/chromium-mac/platform/chromium/media/video-frame-size-change-expected.txt: Added.
* platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.png: Added.
* platform/chromium-win/platform/chromium/compositing/video-frame-size-change-expected.txt: Added.
* platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.png: Added.
* platform/chromium-win/platform/chromium/media/video-frame-size-change-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Sat, 7 Apr 2012 18:47:20 +0000 (18:47 +0000)]
Added fast/canvas/webgl/array-message-passing.html to skipped tests on mac.
Tracked by https://bugs.webkit.org/show_bug.cgi?id=83427
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 7 Apr 2012 17:14:40 +0000 (17:14 +0000)]
[CMake] Cleanup WTF include directories
https://bugs.webkit.org/show_bug.cgi?id=82716
Reviewed by Eric Seidel.
Source/WebCore:
* CMakeLists.txt:
Source/WebKit:
* CMakeLists.txt:
Source/WebKit2:
* CMakeLists.txt:
Tools:
* DumpRenderTree/efl/CMakeLists.txt:
* WinCELauncher/CMakeLists.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sat, 7 Apr 2012 15:30:43 +0000 (15:30 +0000)]
[BlackBerry] Add Battery Status API support
https://bugs.webkit.org/show_bug.cgi?id=82615
Reviewed by George Staikos.
.:
Enable BATTERY_STATUS.
* Source/cmake/OptionsBlackBerry.cmake:
Source/WebKit:
Add BatteryClientBlackBerry.cpp to the build.
* PlatformBlackBerry.cmake:
Source/WebKit/blackberry:
Add client implementation for Battery API.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init): initialize BatteryClient.
* WebCoreSupport/BatteryClientBlackBerry.cpp: Added.
(WebCore):
(WebCore::BatteryClientBlackBerry::BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::setController):
(WebCore::BatteryClientBlackBerry::startUpdating):
(WebCore::BatteryClientBlackBerry::stopUpdating):
(WebCore::BatteryClientBlackBerry::batteryControllerDestroyed):
(WebCore::BatteryClientBlackBerry::onLevelChange):
(WebCore::BatteryClientBlackBerry::onChargingChange):
(WebCore::BatteryClientBlackBerry::onChargingTimeChange):
(WebCore::BatteryClientBlackBerry::onDischargingTimeChange):
* WebCoreSupport/BatteryClientBlackBerry.h: Added.
(WebCore):
(BatteryClientBlackBerry):
(WebCore::BatteryClientBlackBerry::~BatteryClientBlackBerry):
Tools:
Enable BATTERY_STATUS.
* Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Sat, 7 Apr 2012 14:31:52 +0000 (14:31 +0000)]
Remove dead code in SVGCSSParser
https://bugs.webkit.org/show_bug.cgi?id=83404
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Remove code that was there to create a SVGColor representation for color, but was never reached. Since
SVGColor is deprecated now (also see bug 15012), this code has lost any potential. Should SVGColor come
back in SVG2 we can revisit this.
Add a test to confirm for SVG we follow the CSS3 handling of color="currentColor". This is something the
removed code never dealt with, but the existing code in CSSParser.cpp handles, make sure we stick to this
behaviour in the future using this test.
Test: svg/custom/currentColor-on-color.html
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
LayoutTests:
Test that we support color="currentColor" in SVG. This follows from the CSS3 spec, see
http://www.w3.org/TR/css3-color/#currentcolor. This matches FF behaviour.
* svg/custom/currentColor-on-color-expected.txt: Added.
* svg/custom/currentColor-on-color.html: Added.
* svg/custom/script-tests/currentColor-on-color.js: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 7 Apr 2012 13:13:55 +0000 (13:13 +0000)]
[Qt] Unreviewed Easter gardening, skip new failing tests to paint the bots green.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 7 Apr 2012 08:21:18 +0000 (08:21 +0000)]
2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline three results on Lion, so my baseline passes with tolerance 0 again.
* platform/mac/svg/W3C-SVG-1.1/animate-elem-30-t-expected.png: Images have wrong colorspace in those results.
* platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png: Ditto.
* platform/mac/svg/carto.net/selectionlist-expected.png: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 7 Apr 2012 08:09:47 +0000 (08:09 +0000)]
2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>
FrameData constructor zeroes all fields, causing ImageOrientation to be 0
https://bugs.webkit.org/show_bug.cgi?id=83416
Inofficially rubber-stamped by Tim Horton.
Lots of svg/as-image/ crash on debug builds. FrameData is used in a Vector and currently
special VectorTraits force it to be initialized with memset(), nulling all members, instead
of properly initializing them causing the ImageOrientation bug. To be able to remove the
SimpleClassVectorTraits specialization, we have to allow FrameData to be copied.
* platform/graphics/BitmapImage.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Sat, 7 Apr 2012 07:38:48 +0000 (07:38 +0000)]
2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577
Reviewed by Filip Pizlo.
Unskip several tests on Lion, now that the libxml2 bug doesn't affect us anymore.
* platform/mac-lion/Skipped:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
* platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
* platform/mac/svg/custom/preserve-aspect-ratio-syntax-expected.txt:
* platform/mac/svg/custom/viewbox-syntax-expected.png:
* platform/mac/svg/custom/viewbox-syntax-expected.txt:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
2012-04-07 Nikolas Zimmermann <nzimmermann@rim.com>
Work around an entity parsing bug in libxml2 2.7.3 (supplied with Lion) and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=82577
Reviewed by Filip Pizlo.
Work-around entity expansion bug that affects several SVG tests on Lion.
Sample test document which is currently broken:
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Basic//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-basic.dtd" [
<!ENTITY Smile "<rect x='.5' y='.5' width='29' height='39' fill='black' stroke='red'/>">
]>
<svg xmlns="http://www.w3.org/2000/svg">&Smile;</svg>
The expanded rect carries no namespace, thus an Element will be created for it, instead of a SVGRectElement.
libxml2 2.7.4 fixed this bug (https://bugzilla.gnome.org/show_bug.cgi?id=502960) in 2009 already, but Lion
still ships with 2.7.3, so we need to find a work-around for the problem. It works like this:
- When an entity is requested (getEntityHandler) determine whether the entity is being declared (while the <!ENTITY.. parses)
or wheter its references (when the &Smile; is parsed). If its referenced, record the current depth of the libxml2 parser.
- When startElementNs is called while we're expanding entities, be sure to transfer the namespace of the parent node
to the new node, but only do this if the current depth() is greater than the depth() at the time where entity expansion started.
This way we only apply our workaround for elements inside entities, that get expanded at the insertion point.
- When endElementNs is called, and our current depth() is less than our equal to the depth() where entity expansion started,
clear the recorded detph(), and stop executing the workaround.
It requires storing an extra integer & boolean in XMLDocumentParser, which is only used for this work-around.
* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
(WebCore::XMLDocumentParser::isParsingEntityDeclaration):
(WebCore::XMLDocumentParser::setIsParsingEntityDeclaration):
(WebCore::XMLDocumentParser::depthTriggeringEntityExpansion):
(WebCore::XMLDocumentParser::setDepthTriggeringEntityExpansion):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::hackAroundLibXMLEntityParsingBug):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::entityDeclarationHandler):
(WebCore::getEntityHandler):
(WebCore::XMLDocumentParser::initializeParserContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 7 Apr 2012 05:47:04 +0000 (05:47 +0000)]
Versioning.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 7 Apr 2012 03:28:38 +0000 (03:28 +0000)]
Unreviewed, rolling out r113526.
http://trac.webkit.org/changeset/113526
https://bugs.webkit.org/show_bug.cgi?id=83417
speculative rollout for broken chrome browser_test (Requested
by simonjam on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-06
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore):
(WebCore::DocumentLoader::setParsedArchiveData):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL):
* loader/DocumentLoader.h:
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData):
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::finishedLoadingDocument):
(WebCore):
* loader/FrameLoader.h:
(FrameLoader):
(WebCore::FrameLoader::archive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 7 Apr 2012 02:13:14 +0000 (02:13 +0000)]
[chromium] Avoid deleting impl tree when becoming invisible
https://bugs.webkit.org/show_bug.cgi?id=83396
Patch by James Robinson <jamesr@chromium.org> on 2012-04-06
Reviewed by Adrienne Walker.
This bit of code in CCLayerTreeHost::didBecomeInvisible..() was an attempt to drop resources when becoming
invisible. However, it's fairly confused - we drop textures via TextureManagers when going invisible and
CCLayerImpl destructors can't delete non-managed resources since they do not have access to a context - so this
code was never actually freeing up GPU resources. Having a sometimes-null CCLayerImpl tree when we still have a
valid LayerChromium tree has lead to various tricky bugs.
No new tests since this code wasn't doing anything useful in the first place.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leo.yang@torchmobile.com.cn [Sat, 7 Apr 2012 02:06:26 +0000 (02:06 +0000)]
LocalFileSystem::initializeLocalFileSystem should be static
https://bugs.webkit.org/show_bug.cgi?id=83356
Reviewed by Rob Buis.
LocalFileSystem::initializeLocalFileSystem should be static because
static LocalFileSystem::localFileSystem() requires initializeLocalFileSystem()
is called before it gets called.
No functionalities changed, no new tests.
* Modules/filesystem/LocalFileSystem.h:
(LocalFileSystem):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scherkus@chromium.org [Sat, 7 Apr 2012 02:04:32 +0000 (02:04 +0000)]
2012-04-06 Andrew Scherkus <scherkus@chromium.org>
[chromium] Add layout tests that exercise rendering path for videos that have changing resolutions.
https://bugs.webkit.org/show_bug.cgi?id=83383
Reviewed by James Robinson.
* platform/chromium/compositing/video-frame-size-change.html: Added.
* platform/chromium/media/video-frame-size-change.html: Changed from dumpAsText() to pixel test
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 7 Apr 2012 02:02:48 +0000 (02:02 +0000)]
clone baselines from platform/win to platform/chromium-win
https://bugs.webkit.org/show_bug.cgi?id=83394
Unreviewed, baselines update.
Removes a bunch of "generic" baselines that were mistakenly
cloned in r113509. I forgot to filter out the baselines that
were for win-specific tests, as opposed to win-specific
baselines for generic tests.
* platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Removed.
* platform/chromium-win/accessibility/document-enabled-state-expected.txt: Removed.
* platform/chromium-win/accessibility/document-role-expected.txt: Removed.
* platform/chromium-win/accessibility/focus-events-expected.txt: Removed.
* platform/chromium-win/accessibility/heading-elements-expected.txt: Removed.
* platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Removed.
* platform/chromium-win/accessibility/linked-elements-expected.txt: Removed.
* platform/chromium-win/accessibility/list-item-role-expected.txt: Removed.
* platform/chromium-win/accessibility/list-marker-role-expected.txt: Removed.
* platform/chromium-win/accessibility/list-role-expected.txt: Removed.
* platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Removed.
* platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Removed.
* platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Removed.
* platform/chromium-win/accessibility/parent-element-expected.txt: Removed.
* platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Removed.
* platform/chromium-win/accessibility/select-element-role-expected.txt: Removed.
* platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Removed.
* platform/chromium-win/accessibility/selection-and-focus-expected.txt: Removed.
* platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Removed.
* platform/chromium-win/accessibility/single-select-children-expected.txt: Removed.
* platform/chromium-win/accessibility/text-role-expected.txt: Removed.
* platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Removed.
* platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Removed.
* platform/chromium-win/fast/events/alt-numpad-expected.txt: Removed.
* platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Removed.
* platform/chromium-win/fast/events/context-click-events-expected.txt: Removed.
* platform/chromium-win/fast/events/double-dead-char-expected.txt: Removed.
* platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Removed.
* platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Removed.
* platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Removed.
* platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Removed.
* platform/chromium-win/inverted-colors/non-composited-expected.png: Removed.
* platform/chromium-win/inverted-colors/non-composited-expected.txt: Removed.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Removed.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Removed.
* platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Removed.
* platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Removed.
* platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Removed.
* platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Removed.
* platform/chromium-win/plugins/visibility-hidden-expected.png: Removed.
* platform/chromium-win/plugins/visibility-hidden-expected.txt: Removed.
* platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Removed.
* platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Removed.
* platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Sat, 7 Apr 2012 01:54:52 +0000 (01:54 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 7 Apr 2012 01:25:53 +0000 (01:25 +0000)]
[GTK] Accelerated compositing is broken after recent TextureMapper reorganizations
https://bugs.webkit.org/show_bug.cgi?id=83393
Patch by Martin Robinson <mrobinson@igalia.com> on 2012-04-06
Reviewed by Noam Rosenthal.
Source/WebCore:
No new tests. This will be covered by existing accelerated compositing tests
once the implementation is complete.
The GTK+ implementation doesn't clip currently, so hold off enabling the
scissor test until necessary.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::beginPainting): Do not enable the scissor test.
(WebCore::TextureMapperGL::beginScissorClip): Enable the scissor test once
we know for sure we will be using scissored clipping.
Source/WebKit/gtk:
Ensure that the layer tree is synced when the root layer is resized.
* WebCoreSupport/AcceleratedCompositingContextGL.cpp:
(WebKit::AcceleratedCompositingContext::resizeRootLayer): Ensure that the layer
tree is synced when the root layer resizes and remove a call to recomposite
the tree, as it happens anyway.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Sat, 7 Apr 2012 01:17:19 +0000 (01:17 +0000)]
Remove obsolete parts of <datalist> support code
https://bugs.webkit.org/show_bug.cgi?id=83117
Source/WebCore:
Removing HTMLInputElement::selectedOption because it was removed from the specification.
Removing -webkit-appearance:list-button and -webkit-input-list-button pseudo selector
related code because we decided not to use it.
Reviewed by Kent Tamura.
* WebCore.order:
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::nameToPseudoTypeMap):
(WebCore::CSSSelector::extractPseudoType):
* css/CSSSelector.h:
* css/CSSValueKeywords.in:
* css/html.css:
(datalist):
* html/HTMLInputElement.cpp:
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLInputElement.idl:
* inspector/front-end/SourceCSSTokenizer.js:
(WebInspector.SourceCSSTokenizer):
* inspector/front-end/SourceCSSTokenizer.re2js:
* inspector/front-end/StylesSidebarPane.js:
* platform/ThemeTypes.h:
* platform/chromium/ThemeChromiumMac.mm:
(WebCore::setupButtonCell):
(WebCore::paintButton):
(WebCore::ThemeChromiumMac::controlSize):
(WebCore::ThemeChromiumMac::minimumControlSize):
(WebCore::ThemeChromiumMac::controlBorder):
(WebCore::ThemeChromiumMac::paint):
* platform/mac/ThemeMac.mm:
(WebCore::setUpButtonCell):
(WebCore::paintButton):
(WebCore::ThemeMac::controlSize):
(WebCore::ThemeMac::minimumControlSize):
(WebCore::ThemeMac::controlBorder):
(WebCore::ThemeMac::paint):
* platform/qt/RenderThemeQtMobile.cpp:
(WebCore::RenderThemeQtMobile::computeSizeBasedOnStyle):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustRepaintRect):
LayoutTests:
Removed tests for HTMLInputElement.selectedOption and -webkit-appearance:list-button.
Reviewed by Kent Tamura.
* fast/forms/datalist/input-selectedoption-expected.txt: Removed.
* fast/forms/datalist/input-selectedoption.html: Removed.
* platform/chromium-linux/fast/forms/datalist/input-selectedoption-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/datalist/input-selectedoption-expected.png: Removed.
* platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.png: Removed.
* platform/chromium-mac/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
* platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.png: Removed.
* platform/chromium-win/fast/forms/datalist/input-selectedoption-expected.txt: Removed.
* platform/chromium-win/platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
* platform/gtk/fast/forms/input-selectedoption-expected.txt: Removed.
* platform/mac-leopard/fast/forms/input-list-button-size-expected.png: Removed.
* platform/mac/Skipped:
* platform/mac/fast/forms/input-list-button-size-expected.png: Removed.
* platform/mac/fast/forms/input-list-button-size-expected.txt: Removed.
* platform/mac/fast/forms/input-list-button-size.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Sat, 7 Apr 2012 01:12:53 +0000 (01:12 +0000)]
Subscribe feature-media-reviews@c.o to Media-related changes.
https://bugs.webkit.org/show_bug.cgi?id=83397
Reviewed by David Levin.
* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Sat, 7 Apr 2012 01:12:09 +0000 (01:12 +0000)]
Do not abuse ArrayStorage's m_length for testing array consistency
https://bugs.webkit.org/show_bug.cgi?id=83403
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-06
Reviewed by Geoffrey Garen.
Array creation from a list of values is a 3 steps process:
-JSArray::tryCreateUninitialized()
-JSArray::initializeIndex() for each values
-JSArray::completeInitialization()
Previously, the attribute m_length was not set to the final size
JSArray::tryCreateUninitialized() because it was used to test the array
consistency JSArray::initializeIndex().
This caused the initialization loop using JSArray::initializeIndex() maintain
two counters:
-index of the loop
-storage->m_length++
This patch fixes this by using the index of the initialization loop for the indinces of
JSArray::initializeIndex(). For testing consistency, the variable m_initializationIndex
is introduced if CHECK_ARRAY_CONSISTENCY is defined.
The patch also fixes minor unrelated build issue when CHECK_ARRAY_CONSISTENCY is defined.
This improves the performance of JSArray creation from literals by 8%.
* runtime/JSArray.cpp:
(JSC::JSArray::tryFinishCreationUninitialized):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(ArrayStorage):
(JSC::JSArray::initializeIndex):
(JSC::JSArray::completeInitialization):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Sat, 7 Apr 2012 01:09:56 +0000 (01:09 +0000)]
[chromium] Add virtual test suite for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=82263
Reviewed by James Robinson.
Add compositing/visibility as a virtual test suites to test threaded
compositing with. This is a reasonable smoke test of 9 tests, none of
which have any expectations in the non-threaded case.
To fix many of the remaining tests in this virtual test suite, there
will need to be some serious refactoring to merge the conflict between
the way CCScheduler wants to draw frames and the way DRT also wants to
control things. So, in the short term, enable a few simple tests that
are known to be passing.
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.virtual_test_suites):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 7 Apr 2012 01:03:25 +0000 (01:03 +0000)]
Accessing the returnValue of a modal dialog should be performed directly on the global object.
https://bugs.webkit.org/show_bug.cgi?id=83414
Reviewed by Gavin Barraclough.
Presumably during the mass-devirtualising of JSObject, this deliberate use of
the GlobalObject's property lookup logic directly was replaced with a dynamic
call. That results in the DOMWindow filtering out the lookup. This regression
was masked by r93567.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::DialogHandler::returnValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Sat, 7 Apr 2012 00:57:19 +0000 (00:57 +0000)]
Build fix for Windows bots.
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: export missing symbol.
Source/WebKit2:
* win/WebKit2.def: Add missing export symbol.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Sat, 7 Apr 2012 00:43:17 +0000 (00:43 +0000)]
Move Archive processing to DocumentLoader, instead of FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=83055
Reviewed by Adam Barth.
No new tests, no functionality change intended.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
(WebCore::DocumentLoader::maybeCreateArchive): Renamed from
FrameLoader::finishedLoadingDocument(). Returns true if an archive
was created.
(WebCore::DocumentLoader::setArchive):
(WebCore::DocumentLoader::scheduleArchiveLoad):
(WebCore::DocumentLoader::documentURL): Add a check for whether an archive url
should be returned, so that we don't need special handling in Document and
FrameLoader for overriding the document url later.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedFirstData): Remove archive special cases, since
DocumentLoader::documentURL() will return the right thing for legacy archives
and maybeCreateArchive() will override the base url for mhtml.
(WebCore::FrameLoader::loadArchive):
* loader/FrameLoader.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Sat, 7 Apr 2012 00:33:16 +0000 (00:33 +0000)]
[BlackBerry] Build fix to match the latest WebCore change
https://bugs.webkit.org/show_bug.cgi?id=83358
Reviewed by Rob Buis.
Source/WebCore:
Update the BlackBerry cmake file to reflect the fact that:
1.VDMXParser.cpp moved from graphics/skia to graphics/chromium.
2.geolocation moved to Modules/geolocation
3.websockets moved to Modules/websockets
* PlatformBlackBerry.cmake:
Source/WebKit:
* PlatformBlackBerry.cmake:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
charles.wei@torchmobile.com.cn [Sat, 7 Apr 2012 00:30:36 +0000 (00:30 +0000)]
[BlackBerry] Restore some code which was deleted by accident.
https://bugs.webkit.org/show_bug.cgi?id=83357
Reviewed by Rob Buis.
No new tests, just BlackBerry build fix.
* platform/network/blackberry/ResourceRequest.h:
(ResourceRequest):
* platform/network/blackberry/ResourceRequestBlackBerry.cpp:
(WebCore):
(WebCore::mimeTypeRequestTypeMap):
(WebCore::ResourceRequest::targetTypeFromMimeType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hbono@chromium.org [Sat, 7 Apr 2012 00:14:02 +0000 (00:14 +0000)]
REGRESSION: Cannot write a word with Korean double consonant
https://bugs.webkit.org/show_bug.cgi?id=81186
Reviewed by Dan Bernstein.
WebKit change r103859 posts fake mouse-move events when the keyboard status is
changed. Unfortunately, these mouse events go to input methods and confuse a
Korean input method. This change directly calls handleMouseEvent() instead of
-mouseMoved: to prevent sending these fake events to input methods.
* UIProcess/API/mac/WKView.mm:
(-[WKView _postFakeMouseMovedEventForFlagsChangedEvent:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Sat, 7 Apr 2012 00:13:19 +0000 (00:13 +0000)]
[Chromium] Unreviewed gardening.
* platform/chromium-linux/fast/text/atsui-partial-selection-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png.
* platform/chromium-mac-snowleopard/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
* platform/chromium-mac-snowleopard/svg/text/non-bmp-positioning-lists-expected.txt: Removed.
* platform/chromium-mac/fullscreen/full-screen-stacking-context-expected.png:
* platform/chromium-mac/svg/custom/shape-rendering-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Sat, 7 Apr 2012 00:06:02 +0000 (00:06 +0000)]
Unreviewed gardening.
Explicitly position canvases for these tests to avoid cross-platform differences.
* fast/canvas/webgl/webgl-composite-modes-expected.png:
* fast/canvas/webgl/webgl-composite-modes-repaint-expected.png:
* fast/canvas/webgl/webgl-composite-modes-repaint.html:
* fast/canvas/webgl/webgl-composite-modes.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 7 Apr 2012 00:03:28 +0000 (00:03 +0000)]
Fix bug in ContainerNode::getRect with scale transforms
https://bugs.webkit.org/show_bug.cgi?id=83385
Patch by Alexandre Elias <aelias@google.com> on 2012-04-06
Reviewed by Simon Fraser.
The bottom-right corner calculation for non-inline and replaced
elements in ContainerNode::getRect was incorrect in the presence of
scaling, because the untransformed element size was added after the
transformation is applied. The rest of the calculations are careful
to always apply the transformation as the last step, but this had been
forgotten in this codepath. The fix is just to make sure the size is
included in the localToAbsolute call.
One bug caused by this was that a scaled element would be cut off
when scrollIntoView(false) is called to scroll its parent container
to make it bottom-visible.
New layout test case in fast/transforms/scrollIntoView-transformed.html
Source/WebCore:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::getLowerRightCorner):
LayoutTests:
* fast/transforms/scrollIntoView-transformed-expected.txt:
* fast/transforms/scrollIntoView-transformed.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 6 Apr 2012 23:41:35 +0000 (23:41 +0000)]
m_shouldRespectImageOrientation is used uninitialized
https://bugs.webkit.org/show_bug.cgi?id=83410
Reviewed by Simon Fraser.
Initialize Settings's m_shouldRespectImageOrientation to false.
* page/Settings.cpp:
(WebCore::Settings::Settings):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 6 Apr 2012 23:26:09 +0000 (23:26 +0000)]
[Mac] Adopt a different method of telling AppKit when inline input isn't supported
https://bugs.webkit.org/show_bug.cgi?id=83408
<rdar://problem/9205734>
Reviewed by Adele Peterson.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 6 Apr 2012 23:09:41 +0000 (23:09 +0000)]
[chromium] Clear values in combinedClear path not respected in WebGLRenderingContext::clearIfComposited()
https://bugs.webkit.org/show_bug.cgi?id=83407
Source/WebCore:
Reviewed by Kenneth Russell.
When doing a combined clear in the drawing buffer path, we have to use the user specified values for the clear
color / mask / depth and not all 0s.
Covered by slight modification to fast/canvas/webgl/canvas-test.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::clearIfComposited):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clearFramebuffers):
(WebCore::DrawingBuffer::reset):
* platform/graphics/gpu/DrawingBuffer.h:
LayoutTests:
Force a composite on each tick to more closely match the test's behavior in an actual browser.
* fast/canvas/webgl/canvas-test.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 23:02:09 +0000 (23:02 +0000)]
[chromium] Unreviewed gardening.
This test is passing on Chromium Linux, but we have a different expectation
checked in for Chromium Win which uses lighttpd.
* platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 22:57:27 +0000 (22:57 +0000)]
[chromium] merge redundant conditions in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=83319
Reviewed by Adam Barth.
There were duplicate conditions in some of the targets (e.g., 2
OS=="win" sections) so I merged them and if possible, used an else
block of an existing condition.
No new tests, just refactoring the build file.
* WebCore.gyp/WebCore.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 6 Apr 2012 22:55:45 +0000 (22:55 +0000)]
Rename paintingGoesToWindow() to paintsIntoWindow()
https://bugs.webkit.org/show_bug.cgi?id=83406
Reviewed by Dirk Schulze.
Rename paintingGoesToWindow() to paintsIntoWindow() to be consistent
with some future refactoring.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintsWithTransform):
(WebCore::RenderLayer::setBackingNeedsRepaint):
(WebCore::RenderLayer::setBackingNeedsRepaintInRect):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::paintsIntoWindow):
(WebCore::RenderLayerBacking::paintIntoLayer):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer):
* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simonjam@chromium.org [Fri, 6 Apr 2012 22:53:20 +0000 (22:53 +0000)]
Roll out change to HTMLParserIdioms.cpp from 82857
https://bugs.webkit.org/show_bug.cgi?id=83402
Change 82857 causes a DCHECK on fast/forms/number/ValidityState-typeMismatch-number.html
Darin suggested we roll out this file here: https://bugs.webkit.org/show_bug.cgi?id=82857#c20
Unreviewed, rolling out change that broke tests.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::parseToDoubleForNumberType):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Fri, 6 Apr 2012 22:49:11 +0000 (22:49 +0000)]
Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=83389
Unreviewed, just a DEPS roll (130110:131183)
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
isherman@chromium.org [Fri, 6 Apr 2012 22:48:44 +0000 (22:48 +0000)]
Allow site authors to override autofilled fields' colors.
https://bugs.webkit.org/show_bug.cgi?id=66032
http://code.google.com/p/chromium/issues/detail?id=46543
Reviewed by Simon Fraser.
Source/WebCore:
* css/html.css:
(input:-webkit-autofill): Remove !important declarations.
LayoutTests:
* fast/forms/input-autofilled-expected.txt:
* fast/forms/input-autofilled.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Fri, 6 Apr 2012 22:44:02 +0000 (22:44 +0000)]
Provide Obj-C private API to simplify markup.
https://bugs.webkit.org/show_bug.cgi?id=83334
<rdar://problem/
11033861>
Reviewed by Sam Weinig.
Source/WebCore:
Added test in TestWebKitAPI
* WebCore.exp.in:
* editing/Editor.cpp:
(WebCore::Editor::simplifyMarkup): Exposing the new command through the editor.
* editing/Editor.h:
Source/WebKit/mac:
* WebView/WebView.mm:
(-[WebView _simplifyMarkup:endNode:]): Added.
* WebView/WebViewPrivate.h:
Tools:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
(-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
* TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 6 Apr 2012 22:43:54 +0000 (22:43 +0000)]
clone baselines from platform/win to platform/chromium-win
https://bugs.webkit.org/show_bug.cgi?83394
Unreviewed, expectations change.
Copies the win baselines that chromium depends on into a
chromium dir, so that we can remove the dependency on win down
the road.
* platform/chromium-win/accessibility/aria-fallback-roles-expected.txt: Added.
* platform/chromium-win/accessibility/detached-object-notification-crash-expected.txt: Added.
* platform/chromium-win/accessibility/document-enabled-state-expected.txt: Added.
* platform/chromium-win/accessibility/document-role-expected.txt: Added.
* platform/chromium-win/accessibility/focus-events-expected.txt: Added.
* platform/chromium-win/accessibility/heading-elements-expected.txt: Added.
* platform/chromium-win/accessibility/img-alt-attribute-expected.txt: Added.
* platform/chromium-win/accessibility/linked-elements-expected.txt: Added.
* platform/chromium-win/accessibility/list-item-role-expected.txt: Added.
* platform/chromium-win/accessibility/list-marker-role-expected.txt: Added.
* platform/chromium-win/accessibility/list-role-expected.txt: Added.
* platform/chromium-win/accessibility/multiple-select-element-role-expected.txt: Added.
* platform/chromium-win/accessibility/option-element-position-and-size-expected.txt: Added.
* platform/chromium-win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
* platform/chromium-win/accessibility/parent-element-expected.txt: Added.
* platform/chromium-win/accessibility/scroll-to-anchor-expected.txt: Added.
* platform/chromium-win/accessibility/select-element-role-expected.txt: Added.
* platform/chromium-win/accessibility/select-element-valuechange-event-expected.txt: Added.
* platform/chromium-win/accessibility/selection-and-focus-expected.txt: Added.
* platform/chromium-win/accessibility/single-select-children-changed-expected.txt: Added.
* platform/chromium-win/accessibility/single-select-children-expected.txt: Added.
* platform/chromium-win/accessibility/text-role-expected.txt: Added.
* platform/chromium-win/compositing/plugins/composited-plugin-expected.txt: Added.
* platform/chromium-win/compositing/plugins/small-to-large-composited-plugin-expected.txt: Added.
* platform/chromium-win/editing/selection/anchor-focus2-expected.txt: Added.
* platform/chromium-win/editing/selection/anchor-focus3-expected.txt: Added.
* platform/chromium-win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/chromium-win/editing/selection/doubleclick-should-not-expand-across-lines-expected.txt: Added.
* platform/chromium-win/editing/selection/drag-text-delay-expected.txt: Added.
* platform/chromium-win/editing/selection/extend-selection-home-end-expected.txt: Added.
* platform/chromium-win/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/chromium-win/editing/selection/shift-page-up-down-expected.txt: Added.
* platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt: Added.
* platform/chromium-win/fast/css/zoom-body-scroll-expected.txt: Added.
* platform/chromium-win/fast/dom/Element/id-in-deletebutton-expected.txt: Added.
* platform/chromium-win/fast/dom/Window/window-properties-expected.txt: Added.
* platform/chromium-win/fast/dom/prototype-inheritance-2-expected.txt: Added.
* platform/chromium-win/fast/events/alt-numpad-expected.txt: Added.
* platform/chromium-win/fast/events/alt-space-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/context-click-events-expected.txt: Added.
* platform/chromium-win/fast/events/double-dead-char-expected.txt: Added.
* platform/chromium-win/fast/events/keyLocation-numpad-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-click-hyperlink-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-correct-direction-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-event-fired-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-image-no-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-imageMap-href-no-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-imageMap-noHref-scroll-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-nested-divs-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-no-iframe-jump-expected.txt: Added.
* platform/chromium-win/fast/events/panScroll-preventDefault-expected.txt: Added.
* platform/chromium-win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
* platform/chromium-win/fast/forms/select-popup-pagekeys-expected.txt: Added.
* platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt: Added.
* platform/chromium-win/fast/js/global-constructors-expected.txt: Added.
* platform/chromium-win/fast/loader/stateobjects/state-url-sets-links-visited-expected.txt: Added.
* platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added.
* platform/chromium-win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/chromium-win/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
* platform/chromium-win/fast/text/capitalize-boundaries-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-expected.png: Added.
* platform/chromium-win/fast/text/emphasis-expected.txt: Added.
* platform/chromium-win/fast/text/emphasis-vertical-expected.png: Added.
* platform/chromium-win/fast/text/emphasis-vertical-expected.txt: Added.
* platform/chromium-win/fast/text/fallback-traits-fixup-expected.txt: Added.
* platform/chromium-win/fast/text/international/hindi-whitespace-expected.png: Added.
* platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt: Added.
* platform/chromium-win/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/chromium-win/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.png: Added.
* platform/chromium-win/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
* platform/chromium-win/fast/text/international/vertical-text-metrics-test-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-complex-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-simple-expected.txt: Added.
* platform/chromium-win/fast/text/justify-ideograph-vertical-expected.txt: Added.
* platform/chromium-win/fast/text/uniscribe-item-boundary-crash-expected.txt: Added.
* platform/chromium-win/fast/text/uniscribe-missing-glyph-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png: Added.
* platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png: Added.
* platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png: Added.
* platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.png: Added.
* platform/chromium-win/fast/writing-mode/text-orientation-basic-expected.txt: Added.
* platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt: Added.
* platform/chromium-win/inverted-colors/non-composited-expected.png: Added.
* platform/chromium-win/inverted-colors/non-composited-expected.txt: Added.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.png: Added.
* platform/chromium-win/platform/win/plugins/draws-gradient-expected.txt: Added.
* platform/chromium-win/plugins/call-javascript-that-destroys-plugin-expected.txt: Added.
* platform/chromium-win/plugins/get-value-netscape-window-expected.txt: Added.
* platform/chromium-win/plugins/iframe-inside-overflow-expected.txt: Added.
* platform/chromium-win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
* platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
* platform/chromium-win/plugins/plugin-javascript-access-expected.txt: Added.
* platform/chromium-win/plugins/resize-from-plugin-expected.txt: Added.
* platform/chromium-win/plugins/visibility-hidden-expected.png: Added.
* platform/chromium-win/plugins/visibility-hidden-expected.txt: Added.
* platform/chromium-win/plugins/window-geometry-initialized-before-set-window-expected.txt: Added.
* platform/chromium-win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
* platform/chromium-win/plugins/windowless-paint-rect-coordinates-expected.txt: Added.
* platform/chromium-win/printing/page-rule-in-media-query-expected.txt: Added.
* platform/chromium-win/sputnik/Conformance/11_Expressions/11.5_Multiplicative_Operators/11.5.3_Percent/S11.5.3_A4_T6-expected.txt: Added.
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 6 Apr 2012 22:35:55 +0000 (22:35 +0000)]
Renamed
WeakHeap => WeakSet
HandleHeap => HandleSet
Reviewed by Sam Weinig.
These sets do have internal allocators, but it's confusing to call them
heaps because they're sub-objects of an object called "heap".
* heap/HandleHeap.cpp: Removed.
* heap/HandleHeap.h: Removed.
* heap/HandleSet.cpp: Copied from JavaScriptCore/heap/HandleHeap.cpp.
* heap/WeakHeap.cpp: Removed.
* heap/WeakHeap.h: Removed.
* heap/WeakSet.cpp: Copied from JavaScriptCore/heap/WeakHeap.cpp.
* heap/WeakSet.h: Copied from JavaScriptCore/heap/WeakHeap.h.
Plus global rename using grep.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 6 Apr 2012 22:30:37 +0000 (22:30 +0000)]
new-run-webkit-tests: fix bugs in 'mock' drt implementation
https://bugs.webkit.org/show_bug.cgi?id=83341
Reviewed by Eric Seidel.
The current implementation crashed in some circumstances for
reference tests and files that were missing expected results.
This patch fixes those cases and adds more unit tests; it is a
precursor to adding unit tests each port that actually uses this
code, in order to get better coverage of the port/*
implementations.
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(parse_options):
(MockDRT.input_from_line):
(MockDRT.output_for_test):
(MockDRT.run_one_test):
(MockChromiumDRT.input_from_line):
(MockChromiumDRT.output_for_test):
(MockChromiumDRT.run_one_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.make_input_output):
(MockDRTTest.expected_output):
(MockDRTTest):
(MockDRTTest.assertTest):
(MockDRTTest.test_missing_image):
(MockDRTTest.test_missing_text):
(MockDRTTest.test_reftest_match):
(MockDRTTest.test_reftest_mismatch):
(MockChromiumDRTTest.expected_output):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 22:24:49 +0000 (22:24 +0000)]
[chromium] Unreviewed gardening. This test is passing on chromium win and linux.
* platform/chromium-linux-x86/fast/text/atsui-partial-selection-expected.png: Added.
* platform/chromium-win/fast/text/atsui-partial-selection-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin@webkit.org [Fri, 6 Apr 2012 22:23:32 +0000 (22:23 +0000)]
Get rid of the useless flag PREEMPT_GEOLOCATION_PERMISSION
https://bugs.webkit.org/show_bug.cgi?id=83325
Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-04-06
Reviewed by Ryosuke Niwa.
Source/WebCore:
The flag WTF_USE_PREEMPT_GEOLOCATION_PERMISSION was added in r63742 but
was never disabled by anyone. Supporting this feature added complexity by
introducing two authorization scheme.
This patch removes WTF_USE_PREEMPT_GEOLOCATION_PERMISSION and the code supporting
granting the authorization after startUpdating().
* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::GeoNotifier::runSuccessCallback): With the simplified
authorization code, we ensure stronger constraint on GeoNotifier::runSuccessCallback().
(WebCore::Geolocation::stop):
(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::clearWatch):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged): The case (!isAllowed()) was there
to support granting the authorization for WTF_USE_PREEMPT_GEOLOCATION_PERMISSION.
(WebCore::Geolocation::handlePendingPermissionNotifiers):
* Modules/geolocation/Geolocation.h:
(Geolocation):
Source/WebKit/blackberry:
* WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
* wtf/Platform.h: Remove the flag.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 22:16:08 +0000 (22:16 +0000)]
[chromium] Unreviewed, rebaseline a test on Vista/Win7.
* platform/chromium-linux/fast/encoding/invalid-UTF-8-expected.txt: Removed.
* platform/chromium-win/fast/encoding/invalid-UTF-8-expected.png:
* platform/chromium-win/fast/encoding/invalid-UTF-8-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tsepez@chromium.org [Fri, 6 Apr 2012 22:15:02 +0000 (22:15 +0000)]
Block cross-origin iframe scroll to fragment.
https://bugs.webkit.org/show_bug.cgi?id=73083
Reviewed by Adam Barth.
Add a restriction similar to what FF has done for all iframes for over a
year now. Our change is less disruptive in that it only does this in the
cross-orgin case, which is where the fragment scrolling is problematic.
Source/WebCore:
Test: http/tests/navigation/anchor-frames-cross-origin.html
* dom/Document.cpp:
(WebCore::Document::canBeAccessedByEveryAncestorFrame):
(WebCore):
* dom/Document.h:
(Document):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedParsing):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::shouldPerformFragmentNavigation):
(WebCore::FrameLoader::scrollToFragmentIfAllowed):
(WebCore):
* loader/FrameLoader.h:
(FrameLoader):
LayoutTests:
* http/tests/inspector/resource-parameters-expected.txt:
* http/tests/navigation/anchor-frames-cross-origin-expected.txt: Added.
* http/tests/navigation/anchor-frames-cross-origin.html: Added.
* http/tests/navigation/resources/frame-with-anchor-cross-origin.html: Added.
* http/tests/security/xssAuditor/anchor-url-dom-write-location-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-inline-event-null-char-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location-javascript-URL-expected.txt:
* http/tests/security/xssAuditor/anchor-url-dom-write-location2-expected.txt:
* http/tests/security/xssAuditor/dom-write-location-inline-event-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 6 Apr 2012 21:49:11 +0000 (21:49 +0000)]
WebFullScreenManagerProxy::isFullScreen() will create an empty full screen window; steal focus.
https://bugs.webkit.org/show_bug.cgi?id=83388
Reviewed by Geoffrey Garen.
Calling WebFullScreenManagerProxy::isFullScreen() will create a WKFullScreenWindowController if
one does not already exist, since the -[WKView fullScreenWindowController] method will create-on-access.
Add a new call, -[WKView hasFullScreenWindowController], which does not auto-create the controller
and add that check to WebFullScreenManagerProxy::isFullScreen().
* UIProcess/API/mac/WKView.mm:
(-[WKView hasFullScreenWindowController]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/mac/WebFullScreenManagerProxyMac.mm:
(WebKit::WebFullScreenManagerProxy::isFullScreen):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 21:48:33 +0000 (21:48 +0000)]
[chromium] Unreviewed, remove a passing test.
tables/mozilla/bugs/bug9024.html is passing on Leopard.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 6 Apr 2012 21:45:50 +0000 (21:45 +0000)]
Enable webkit_unit_tests for commit queue and EWS while tracking failures
https://bugs.webkit.org/show_bug.cgi?id=83329
Reviewed by Adam Barth.
This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
the commit queue and EWS can reject patches that cause regressions.
* Scripts/webkitpy/common/config/ports.py:
(ChromiumPort.run_webkit_unit_tests_command):
* Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.unit_tests_results_path):
* Scripts/webkitpy/common/net/layouttestresults.py:
(LayoutTestResults.__init__):
(LayoutTestResults.failing_tests):
(LayoutTestResults):
(LayoutTestResults.add_unit_test_failures):
* Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
(UnitTestResults):
(UnitTestResults.results_from_string):
* Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
(UnitTestResultsTest):
(UnitTestResultsTest.test_nostring):
(UnitTestResultsTest.test_emptystring):
(UnitTestResultsTest.test_nofailures):
(test_onefailure):
(test_multiple_failures_per_test):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(MockCommitQueue.test_results):
(MockCommitQueue.archive_last_test_results):
(FailingTestCommitQueue.test_results):
(test_flaky_test_failure):
(test_failed_archive):
* Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
(LayoutTestResultsReader._create_unit_test_results):
(LayoutTestResultsReader.results):
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_missing_layout_test_results):
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTaskDelegate.test_results):
(PatchAnalysisTaskDelegate.archive_last_test_results):
(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):
(PatchAnalysisTask._test_patch):
* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.test_results):
(AbstractEarlyWarningSystem.archive_last_test_results):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(EarlyWarningSytemTest._test_testing_ews):
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.test_results):
(CommitQueue.archive_last_test_results):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_rollout):
(test_manual_reject_during_processing):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):
* Scripts/webkitpy/tool/steps/runtests_unittest.py:
(RunTestsTest.test_webkit_run_unit_tests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Fri, 6 Apr 2012 21:38:33 +0000 (21:38 +0000)]
Foreground of apple.com/iphone video page visible during full screen animation.
https://bugs.webkit.org/show_bug.cgi?id=83080
Reviewed by Simon Fraser.
Source/WebCore:
No new tests; updated fullscreen/full-screen-stacking-context.html
The apple.com/iphone video page uses a -webkit-mask: CSS style, which creates a stacking
context and causes the page to pop in front of the full screen renderer. Add all the
styles suggested by the W3C full screen spec to the -webkit-full-screen-ancestor rule
to keep these stacking contexts from being created.
* css/fullscreen.css:
(:-webkit-full-screen-ancestor:not(iframe)):
LayoutTests:
* fullscreen/full-screen-stacking-context.html:
* platform/mac/fullscreen/full-screen-stacking-context-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Fri, 6 Apr 2012 21:32:55 +0000 (21:32 +0000)]
Virtualize createAnonymousBoxWithSameTypeAs.
https://bugs.webkit.org/show_bug.cgi?id=83229
Reviewed by Julien Chaffraix.
This helps to use the same function to create anonymous
table parts and in the future extend to more classes
derived from RenderBox.
The current switch case situation was going to be messy as
we will need to mix cases that were very dependent on the
class, so it made sense to add a virtual function.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::splitAnonymousBlocksAroundChild):
(WebCore::RenderBlock::createAnonymousBoxWithSameTypeAs):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.h:
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(RenderBox):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitFlow):
* rendering/RenderTable.h:
(WebCore::RenderTable::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableRow.h:
(WebCore::RenderTableRow::createAnonymousBoxWithSameTypeAs):
* rendering/RenderTableSection.h:
(WebCore::RenderTableSection::createAnonymousBoxWithSameTypeAs):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Fri, 6 Apr 2012 21:31:02 +0000 (21:31 +0000)]
[cg] REGRESSION (r101517): Animating the transform of a <rect> with shape-rendering: crispEdges leaves behind garbage
https://bugs.webkit.org/show_bug.cgi?id=82963
<rdar://problem/
11170476>
Reviewed by Simon Fraser.
CoreGraphics can inflate the stroke by 1px when drawing a rectangle
with antialiasing disabled at non-integer coordinates, we need to
compensate by inflating the RenderSVGRect repaint bounds by 1px.
No new tests, as this is not reproducible in DRT or WKTR.
* rendering/svg/RenderSVGRect.cpp:
(WebCore::RenderSVGRect::createShape):
(WebCore::RenderSVGRect::strokeBoundingBox):
* rendering/svg/RenderSVGRect.h:
(RenderSVGRect):
New Mac baselines for two tests which have SVG <rect>s with shape-rendering: crispEdges.
* platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
* platform/mac/svg/custom/shape-rendering-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 6 Apr 2012 21:19:26 +0000 (21:19 +0000)]
Tools: Enable MediaSource feature for DumpRenderTree so
MediaSource LayoutTests will pass for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=83053
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
LayoutTests: Fix MediaSource LayoutTests to work with the new XHR behavior
that requires asynchronous requests for the 'arraybuffer'
responseType.
https://bugs.webkit.org/show_bug.cgi?id=83053
Patch by Aaron Colwell <acolwell@chromium.org> on 2012-04-06
Reviewed by Dimitri Glazkov.
* http/tests/media/media-source/webm/video-media-source-errors.html:
* http/tests/media/media-source/webm/video-media-source-play.html:
* http/tests/media/media-source/webm/video-media-source-seek.html:
* http/tests/media/media-source/webm/video-media-source-state-changes.html:
* http/tests/media/media-source/webm/webm-media-source.js:
(getData.request.onload):
(createClusterGetFunction.return.if):
(createClusterGetFunction):
(loadWebMData):
(getCluster):
(appendCluster):
(getReadyStateName):
(expectSourceState):
(expectReadyState):
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 6 Apr 2012 21:17:55 +0000 (21:17 +0000)]
Avoid trying to set filters on transform layers
https://bugs.webkit.org/show_bug.cgi?id=83344
Reviewed by Dean Jackson.
Return early from GraphicsLayerCA::setFilters() when the filters
haven't changed. This avoids trying to clear filters on CALayers
which never had them, which should both help performance, and avoids
console spew related to setting shadow properties on transform layers.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setFilters):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 6 Apr 2012 21:15:55 +0000 (21:15 +0000)]
WebGL content swapped at wrong time in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=82275
Reviewed by Kenneth Russell.
Source/WebCore:
When using threaded compositing, we need to defer touching the texture ID being used by the compositor until the
appropriate point in the synchronization routine and not before. Specifically, there is no time at which it is
safe to manipulate the texture the compositor may be using from the main thread. This breaks up the presentation
path into a few pieces (depending on the context attributes) in order to maintain these invariants.
Depending on the context attributes and if we're in threaded mode, there are a few different possible back/front
buffer combinations:
- When the context is antialiased, we have a multisampled renderbuffer and associated framebuffer.
- In all cases, we have a color texture back buffer.
- When preserveDrawingBuffer is set or threaded compositing is enabled, we have a separate color texture as a
front buffer.
The resource update is in two phases. First, on the main thread, we prepare the back buffer. This resolves from
the multisampled FBO into the back color buffer if multisampled and swaps the front / back color buffer textures
if preserveDrawingBuffer is false and we're using separate front / back color buffers. Second, on the compositor
thread, we do a texture copy from the back to the front color buffer if preserveDrawingBuffer is true. After
these steps are complete the main thread is free to manipulate the back buffer color texture without affecting
any resources the compositor is using.
One incidental cleanup this patch also does is remove all state queries from DrawingBuffer::clearFramebuffer().
Tests: fast/canvas/webgl/webgl-composite-modes-repaint.html
fast/canvas/webgl/webgl-composite-modes.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::WebGLRenderingContext):
(WebCore::WebGLRenderingContext::clearIfComposited):
(WebCore::WebGLRenderingContext::restoreStateAfterClear):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
* html/canvas/WebGLRenderingContext.h:
(WebGLRenderingContext):
* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/cairo/DrawingBufferCairo.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/chromium/DrawingBufferChromium.cpp:
(WebCore::generateColorTexture):
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::initialize):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::WebGLLayerChromium):
(WebCore::WebGLLayerChromium::paintContentsIfDirty):
(WebCore::WebGLLayerChromium::updateCompositorResources):
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
(WebCore::WebGLLayerChromium::setNeedsDisplayRect):
(WebCore::WebGLLayerChromium::setDrawingBuffer):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
* platform/graphics/clutter/DrawingBufferClutter.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::initializeContext):
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::create):
(WebCore::DrawingBuffer::clear):
(WebCore::DrawingBuffer::clearFramebuffer):
(WebCore::DrawingBuffer::reset):
(WebCore::DrawingBuffer::discardResources):
* platform/graphics/gpu/DrawingBuffer.h:
(DrawingBuffer):
* platform/graphics/gpu/mac/DrawingBufferMac.mm:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore::DrawingBuffer::frontColorBuffer):
* platform/graphics/gpu/qt/DrawingBufferQt.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore::DrawingBuffer::platformLayer):
(WebCore::DrawingBuffer::prepareBackBuffer):
(WebCore::DrawingBuffer::requiresCopyFromBackToFrontBuffer):
(WebCore):
(WebCore::DrawingBuffer::frontColorBuffer):
Source/WebKit/chromium:
* tests/WebGLLayerChromiumTest.cpp:
(WebKit::TEST):
LayoutTests:
Adds some pixel tests for compositing all different combinations of alpha/antialias/preserveDrawingBuffer on
WebGL content.
* fast/canvas/webgl/webgl-composite-modes-expected.png: Added.
* fast/canvas/webgl/webgl-composite-modes-expected.txt: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint-expected.png: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint-expected.txt: Added.
* fast/canvas/webgl/webgl-composite-modes-repaint.html: Added.
* fast/canvas/webgl/webgl-composite-modes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 6 Apr 2012 21:10:59 +0000 (21:10 +0000)]
[chromium] Unreviewed, land some mac/win baselines for table tests after r111742.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac-leopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-mac/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-mac/fast/table/cell-pref-width-invalidation-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2123-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2509-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug34176-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug59252-expected.txt: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7243-expected.txt: Added.
* platform/chromium-win/fast/repaint/scroll-inside-table-cell-expected.png:
* platform/chromium-win/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 6 Apr 2012 20:41:20 +0000 (20:41 +0000)]
Unreviewed build fix after r113486 and r113487.
* rendering/RenderObject.cpp:
Added missing #include.
* rendering/RenderView.h:
Removed bad OVERRIDE.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 6 Apr 2012 20:20:19 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=81939
-webkit-image-set should update dynamically when the device scale factor
changes
-and corresponding-
<rdar://problem/
11101108>
Reviewed by Darin Adler.
Source/WebCore:
New member variable to keep track of the scale factor.
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::CSSImageSetValue):
(WebCore::CSSImageSetValue::bestImageForScaleFactor):
Merge the two cachedImageSet functions. There was no need for two functions here.
(WebCore::CSSImageSetValue::cachedImageSet):
cachedOrPendingImageSet() now takes a Document as a parameter so that it can
access the deviceScaleFactor. If there is a cached image already and the
Document's deviceScaleFactor doesn't match m_scaleFactor, then m_imageSet is set
to a pending image so that the best fit image will be reassessed and then
loaded.
(WebCore::CSSImageSetValue::cachedOrPendingImageSet):
* css/CSSImageSetValue.h:
(WebCore):
(CSSImageSetValue):
cachedOrPendingImageSet() now takes a Document.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
StyleCachedImageSet should inherit from CachedImageClient just like
StyleCachedImage. It should add and remove itself as a client upon creation
and destruction, respectively.
* rendering/style/StyleCachedImageSet.cpp:
(WebCore::StyleCachedImageSet::StyleCachedImageSet):
(WebCore):
(WebCore::StyleCachedImageSet::~StyleCachedImageSet):
* rendering/style/StyleCachedImageSet.h:
(StyleCachedImageSet):
LayoutTests:
* fast/hidpi/image-set-background-dynamic.html: Added.
* fast/hidpi/image-set-border-image-dynamic.html: Added.
* fast/hidpi/image-set-in-content-dynamic.html: Added.
* platform/mac/fast/hidpi/image-set-background-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-background-dynamic-expected.txt: Added.
* platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-border-image-dynamic-expected.txt: Added.
* platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.png: Added.
* platform/mac/fast/hidpi/image-set-in-content-dynamic-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Fri, 6 Apr 2012 20:12:41 +0000 (20:12 +0000)]
Turn on vibration support for BlackBerry.
Reviewed by Rob Buis.
* Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
schenney@chromium.org [Fri, 6 Apr 2012 20:07:27 +0000 (20:07 +0000)]
[Chromium} Rebaseline some failing Leopard tests
https://bugs.webkit.org/show_bug.cgi?id=83387
Unreviewed chromium test expectations update.
* platform/chromium-mac-leopard/fast/text/atsui-multiple-renderers-expected.png: Added.
* platform/chromium-mac-leopard/fast/text/find-kana-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 6 Apr 2012 20:04:56 +0000 (20:04 +0000)]
Update LayoutUnit usage in RenderView
https://bugs.webkit.org/show_bug.cgi?id=83147
Reviewed by Julien Chaffraix.
Updating the usage of LayoutUnits in RenderView in preparation for sub-pixel layout. This mostly
affects paint and repaint functions, which take LayoutRects up to the RenderView level. This is
necessary as we continue to accumulate sub-pixel offsets up to this level.
No new tests. No change in behavior.
* rendering/RenderView.cpp:
(WebCore::RenderView::paint): Adding an assert that we're being called to paint on pixel
boundaries. We don't currently ever position RenderViews at sub-pixel offsets.
(WebCore::RenderView::shouldRepaint):
(WebCore::RenderView::repaintViewRectangle): Switching to a LayoutRect and cleaning up a fixme
that used decomposed offsets. Pixel snapping is applied before handing the rect up to the
FrameView.
(WebCore::RenderView::repaintRectangleInViewAndCompositedLayers): Pixel snapping before handing
the rect up to the Compositor.
(WebCore::RenderView::computeRectForRepaint):
(WebCore::RenderView::selectionBounds):
(WebCore::RenderView::viewRect):
(WebCore::RenderView::unscaledDocumentRect):
* rendering/RenderView.h:
(RenderView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc