Daniel Stenberg [Sat, 31 Mar 2007 10:39:54 +0000 (10:39 +0000)]
Removed check for ftpcode being NULL, as later it is derefenced unconditionally
anyway and we can just as well rely on it being valid.
CID 12, coverity.com scan
Yang Tse [Sat, 31 Mar 2007 03:21:08 +0000 (03:21 +0000)]
sshd might fail to start if given an unsupported configuration option.
Try to avoid this problem checking for some possible unsupported options,
and avoid using them in the configuration file.
Dan Fandrich [Fri, 30 Mar 2007 22:07:48 +0000 (22:07 +0000)]
Fixed some typos in the comments.
Dan Fandrich [Fri, 30 Mar 2007 22:04:14 +0000 (22:04 +0000)]
Resurrected old FTPS error tests 402 and 403 as 404 and 405.
Daniel Stenberg [Fri, 30 Mar 2007 20:54:32 +0000 (20:54 +0000)]
Pointer "conn" dereferenced before NULL check. found by coverity.com scan
Daniel Stenberg [Fri, 30 Mar 2007 20:52:42 +0000 (20:52 +0000)]
Pointer "cur_pos" dereferenced before NULL check, found by coverity.com scan.
Removed the NULL check since the pointer must be valid already.
Daniel Stenberg [Fri, 30 Mar 2007 20:50:31 +0000 (20:50 +0000)]
pointless check for 'out' being non-NULL, since it was badly done and is
unnecessary - found by coverity.com scan
Daniel Stenberg [Fri, 30 Mar 2007 19:59:15 +0000 (19:59 +0000)]
dead code removed, found by the coverity.com scan
Dan Fandrich [Fri, 30 Mar 2007 18:50:55 +0000 (18:50 +0000)]
Added HTTP --max-filesize tests and FTPS CCC failure test.
Yang Tse [Fri, 30 Mar 2007 10:11:49 +0000 (10:11 +0000)]
Searching for sshd and sftp-server will be done first
in the PATH and afterwards in other common locations.
Yang Tse [Fri, 30 Mar 2007 02:59:39 +0000 (02:59 +0000)]
ignore more generated files
Dan Fandrich [Fri, 30 Mar 2007 01:13:47 +0000 (01:13 +0000)]
Don't tear down the ftp connection if the maximum filesize was exceeded
and added tests 290 and 291 to check.
Dan Fandrich [Fri, 30 Mar 2007 00:08:41 +0000 (00:08 +0000)]
Added FTP-SSL failure test 402
Dan Fandrich [Thu, 29 Mar 2007 22:50:23 +0000 (22:50 +0000)]
Added ftps upload test 401
Dan Fandrich [Thu, 29 Mar 2007 21:01:07 +0000 (21:01 +0000)]
Added a libssh2 section.
Dan Fandrich [Thu, 29 Mar 2007 20:44:06 +0000 (20:44 +0000)]
Show an absolute sftp: file path to give an additional example.
Dan Fandrich [Thu, 29 Mar 2007 19:19:06 +0000 (19:19 +0000)]
Eliminated extra / in scp/sftp URLs.
Dan Fandrich [Thu, 29 Mar 2007 19:17:18 +0000 (19:17 +0000)]
Send an EOF message before closing a channel, as recommended by RFC4254.
Enable libssh2 tracing when ssh debugging is turned on.
Dan Fandrich [Thu, 29 Mar 2007 18:46:09 +0000 (18:46 +0000)]
Add another option to tighten the test environment.
Yang Tse [Thu, 29 Mar 2007 12:29:32 +0000 (12:29 +0000)]
fix compiler warning
Dan Fandrich [Thu, 29 Mar 2007 05:25:11 +0000 (05:25 +0000)]
Abort if attempting to run as root.
Yang Tse [Thu, 29 Mar 2007 00:11:55 +0000 (00:11 +0000)]
fix error introduced in last commit
Yang Tse [Wed, 28 Mar 2007 23:53:13 +0000 (23:53 +0000)]
Update comment
Yang Tse [Wed, 28 Mar 2007 19:05:43 +0000 (19:05 +0000)]
fix compiler warning
Yang Tse [Wed, 28 Mar 2007 18:59:42 +0000 (18:59 +0000)]
Improve detection of socket events which allow a further recv() call
to complete with no delay and actually find out what happened with
the socket. As well as detection of socket send()able condition.
This also allows removal of a Cygwin specific block of code.
Gisle Vanem [Wed, 28 Mar 2007 04:48:11 +0000 (04:48 +0000)]
djgpp uses gcc which has varadic macros.
Gisle Vanem [Wed, 28 Mar 2007 04:44:14 +0000 (04:44 +0000)]
Fix compiler warning.
Dan Fandrich [Wed, 28 Mar 2007 04:36:09 +0000 (04:36 +0000)]
Only show exit status in verbose mode.
Gisle Vanem [Wed, 28 Mar 2007 04:23:33 +0000 (04:23 +0000)]
Simplified code around 'tld_errmsg' a bit.
Dan Fandrich [Wed, 28 Mar 2007 04:05:55 +0000 (04:05 +0000)]
Don't launch sshd as a daemon so its output can be logged.
Gunter Knauf [Tue, 27 Mar 2007 19:27:43 +0000 (19:27 +0000)]
added variadic macro stuff.
Yang Tse [Tue, 27 Mar 2007 18:16:35 +0000 (18:16 +0000)]
Update message
Yang Tse [Tue, 27 Mar 2007 18:15:26 +0000 (18:15 +0000)]
New Internal wrapper function Curl_select() around select (2), it
uses poll() when a fine poll() is available, so now libcurl can be
built without select() support at all if a fine poll() is available.
Yang Tse [Tue, 27 Mar 2007 15:22:49 +0000 (15:22 +0000)]
don't retry select() call upon unrecoverable error EBADF
Dan Fandrich [Tue, 27 Mar 2007 05:10:20 +0000 (05:10 +0000)]
Daniel Johnson's fix for shared object extension detection on Mac OS X.
Yang Tse [Tue, 27 Mar 2007 04:17:26 +0000 (04:17 +0000)]
Platforms that lack autotools support should define HAVE_VARIADIC_MACROS_C99
and/or HAVE_VARIADIC_MACROS_GCC for specific compiler versions that support
variadic macros with C99 style and/or old gcc style in their specific config.h
file.
If previous definitions are not done, even when aplicable, and --disable-verbose
is used, the fallback (void) method will be used to define infof, avoiding the
inclusion of unwanted strings in the resulting library/executable.
Dan Fandrich [Tue, 27 Mar 2007 04:01:39 +0000 (04:01 +0000)]
Tighten up a few more OpenSSH options
Yang Tse [Mon, 26 Mar 2007 23:26:07 +0000 (23:26 +0000)]
Fix date
Yang Tse [Mon, 26 Mar 2007 23:23:46 +0000 (23:23 +0000)]
Internal function Curl_select() renamed to Curl_socket_ready()
Dan Fandrich [Mon, 26 Mar 2007 19:23:00 +0000 (19:23 +0000)]
Added SFTP and SCP upload tests in test602 & test603
Dan Fandrich [Mon, 26 Mar 2007 18:04:05 +0000 (18:04 +0000)]
Added test600 and test601, SFTP and SCP file retrieval tests.
Gunter Knauf [Mon, 26 Mar 2007 17:18:36 +0000 (17:18 +0000)]
catch up new lib extension when build with gcc/nlmconv.
Gunter Knauf [Mon, 26 Mar 2007 17:01:35 +0000 (17:01 +0000)]
changed link lib order to make nlmconv happy.
Gunter Knauf [Mon, 26 Mar 2007 01:54:06 +0000 (01:54 +0000)]
added CVS Id tag.
Gunter Knauf [Mon, 26 Mar 2007 01:50:44 +0000 (01:50 +0000)]
fixed build to use compiler-default lib extension.
Daniel Stenberg [Sun, 25 Mar 2007 08:41:41 +0000 (08:41 +0000)]
#92 is fixed
Daniel Stenberg [Sun, 25 Mar 2007 08:41:22 +0000 (08:41 +0000)]
Added the How to get your patches into the libcurl sources instruction posted
recently
Daniel Stenberg [Sun, 25 Mar 2007 08:16:42 +0000 (08:16 +0000)]
added Daniel Johnson
Daniel Stenberg [Sun, 25 Mar 2007 08:16:16 +0000 (08:16 +0000)]
- Daniel Johnson fixed multi code to traverse the easy handle list properly.
A left-over bug from the February 21 fix.
Daniel Stenberg [Sun, 25 Mar 2007 07:44:05 +0000 (07:44 +0000)]
addressed (replied to with comments) most out-stading release issues and moved
one over to KNOWN_BUGS
Yang Tse [Sun, 25 Mar 2007 03:20:17 +0000 (03:20 +0000)]
fix compiler warning
Yang Tse [Sun, 25 Mar 2007 02:30:58 +0000 (02:30 +0000)]
fix compiler warning
Yang Tse [Sun, 25 Mar 2007 01:59:52 +0000 (01:59 +0000)]
fix compiler warning
Dan Fandrich [Sat, 24 Mar 2007 17:23:01 +0000 (17:23 +0000)]
Fixed a couple of compile problems.
Dan Fandrich [Sat, 24 Mar 2007 06:29:58 +0000 (06:29 +0000)]
Added sshserver.pl
Dan Fandrich [Sat, 24 Mar 2007 02:15:20 +0000 (02:15 +0000)]
Fixed a memory leak when specifying a proxy with a file: URL and added
test case 288 to verify it.
Dan Fandrich [Sat, 24 Mar 2007 01:01:28 +0000 (01:01 +0000)]
Changed the test harness to attempt to gracefully shut down servers
before resorting to the kill -9 hammer.
Added test harness infrastructure to support scp/sftp tests, using
OpenSSH as the server.
Daniel Stenberg [Fri, 23 Mar 2007 22:25:04 +0000 (22:25 +0000)]
add missing state name for the debug state switch output
Daniel Stenberg [Fri, 23 Mar 2007 22:24:33 +0000 (22:24 +0000)]
fix debug message
Dan Fandrich [Fri, 23 Mar 2007 17:59:40 +0000 (17:59 +0000)]
Added --pubkey option to curl and made --key also work for SCP/SFTP,
plus made --pass work on an SSH private key as well.
Yang Tse [Fri, 23 Mar 2007 12:13:08 +0000 (12:13 +0000)]
fix yet another leftover in previous commit
Yang Tse [Fri, 23 Mar 2007 12:09:16 +0000 (12:09 +0000)]
fix leftover in previous commit
Yang Tse [Fri, 23 Mar 2007 12:01:19 +0000 (12:01 +0000)]
fix compiler warning: empty body in an if/else-statement
Yang Tse [Fri, 23 Mar 2007 04:23:53 +0000 (04:23 +0000)]
Change spelling, ONE_TERRABYTE -> ONE_TERABYTE
Shave off a couple of function calls in the part of
Curl_pgrsUpdate() which is always executed when called.
Fix a couple of comments.
Dan Fandrich [Fri, 23 Mar 2007 00:03:34 +0000 (00:03 +0000)]
Don't shut down sftp in an error if it was never started.
Dan Fandrich [Thu, 22 Mar 2007 19:45:20 +0000 (19:45 +0000)]
Free some additional strings on exit to avoid memory leaks.
Yang Tse [Thu, 22 Mar 2007 18:59:14 +0000 (18:59 +0000)]
fix wrong macro name introduced in las commit
Yang Tse [Thu, 22 Mar 2007 18:25:38 +0000 (18:25 +0000)]
Add check for compiler variadic macro support in configuration script
Dan Fandrich [Thu, 22 Mar 2007 17:58:01 +0000 (17:58 +0000)]
Fixed unused variable compiler warning.
Dan Fandrich [Thu, 22 Mar 2007 17:18:41 +0000 (17:18 +0000)]
Use C99-style variadic macros when available.
Yang Tse [Thu, 22 Mar 2007 15:32:28 +0000 (15:32 +0000)]
Add a couple of local macros to improve code readability.
For completeness sake, wait_ms() might also get interrupted when
experimental CURL_ACKNOWLEDGE_EINTR is defined.
Daniel Stenberg [Thu, 22 Mar 2007 15:23:00 +0000 (15:23 +0000)]
-z hasn't supported "yesterday" for quite some time...
Yang Tse [Thu, 22 Mar 2007 14:41:10 +0000 (14:41 +0000)]
attempt to keep message length below 80 chars
Yang Tse [Wed, 21 Mar 2007 13:09:39 +0000 (13:09 +0000)]
reverted back to previous version => curl.haxx.se/mail/lib-2007-03/0258.html
Yang Tse [Wed, 21 Mar 2007 08:17:13 +0000 (08:17 +0000)]
avoid the use of variadic macros for greater portability
Yang Tse [Wed, 21 Mar 2007 07:29:03 +0000 (07:29 +0000)]
fix compiler warning: implicit conversion from "long" to "int"
Yang Tse [Tue, 20 Mar 2007 20:00:40 +0000 (20:00 +0000)]
Fixed: When a signal was caught awaiting for an event using Curl_select()
or Curl_poll() with a non-zero timeout both functions would restart the
specified timeout. This could even lead to the extreme case that if a
signal arrived with a frecuency lower to the specified timeout neither
function would ever exit.
Added experimental symbol definition check CURL_ACKNOWLEDGE_EINTR in
Curl_select() and Curl_poll(). When compiled with CURL_ACKNOWLEDGE_EINTR
defined both functions will return as soon as a signal is caught. Use it
at your own risk, all calls to these functions in the library should be
revisited and checked before fully supporting this feature.
Gisle Vanem [Tue, 20 Mar 2007 16:30:14 +0000 (16:30 +0000)]
Remove unneeded 'HAVE_*' defines.
Yang Tse [Mon, 19 Mar 2007 15:41:28 +0000 (15:41 +0000)]
Avoid false positive detection of yaSSL
Daniel Stenberg [Mon, 19 Mar 2007 12:14:49 +0000 (12:14 +0000)]
committed
Yang Tse [Mon, 19 Mar 2007 12:02:33 +0000 (12:02 +0000)]
Bryan Henderson fixed the progress function so that it can get called
more frequently allowing same calling frecuency for the client progress
callback, while keeping the once a second frecuency for speed calculations
and internal display of the transfer progress.
Daniel Stenberg [Sun, 18 Mar 2007 23:16:36 +0000 (23:16 +0000)]
language fix
Daniel Stenberg [Sun, 18 Mar 2007 23:13:45 +0000 (23:13 +0000)]
Removed: yassl build breaks
Added: Frequent calling of user progress callback
Daniel Stenberg [Sun, 18 Mar 2007 22:37:23 +0000 (22:37 +0000)]
detect and show if built with yassl, but also set the "openssl" flag internally
since that is the API yassl attempts to provide
Daniel Stenberg [Sun, 18 Mar 2007 22:36:34 +0000 (22:36 +0000)]
detect if built with the OpenSSL API "emulated" by yassl
Yang Tse [Sun, 18 Mar 2007 17:29:24 +0000 (17:29 +0000)]
Fix compiler warning/error: ISO C90 forbids mixed declarations and code
Yang Tse [Sun, 18 Mar 2007 04:51:40 +0000 (04:51 +0000)]
Code refactoring, extracting a new function wait_ms() from Curl_select and
Curl_poll() which is called whenever not a single valid file descriptor is
passed to these functions.
Improve readibility using a poll() macro to replace WSApoll().
Gisle Vanem [Sat, 17 Mar 2007 18:19:15 +0000 (18:19 +0000)]
Remove unneeded 'HAVE_*' defines. Detect i386 OS-target (gcc).
Gisle Vanem [Sat, 17 Mar 2007 17:58:45 +0000 (17:58 +0000)]
Added cvs id. Use TOPDIR variable. Updated CSOURCES.
Dependencies are now put in external file depend.dj.
Gisle Vanem [Sat, 17 Mar 2007 17:56:21 +0000 (17:56 +0000)]
Added a hack to work around the circular dependency when
CURL_DEBUG is defined.
Daniel Stenberg [Fri, 16 Mar 2007 22:44:46 +0000 (22:44 +0000)]
openssl/bio.h doesn't exist when we build with yassl so avoid trying
Dan Fandrich [Fri, 16 Mar 2007 04:34:53 +0000 (04:34 +0000)]
Fixed the test case to use a truly invalid urlglob range.
Daniel Stenberg [Thu, 15 Mar 2007 22:43:11 +0000 (22:43 +0000)]
Sebastien Trottier's issue
Daniel Stenberg [Thu, 15 Mar 2007 22:34:49 +0000 (22:34 +0000)]
eight fresh issues to keep track of
Dan Fandrich [Thu, 15 Mar 2007 22:29:10 +0000 (22:29 +0000)]
Various memory leaks plugged and NULL pointer fixes made in the ssh code.
Daniel Stenberg [Thu, 15 Mar 2007 22:05:01 +0000 (22:05 +0000)]
- Nick made the curl tool accept globbing ranges that only is one number, i.e
you can now use [1-1] without curl complaining.
Dan Fandrich [Thu, 15 Mar 2007 21:25:56 +0000 (21:25 +0000)]
Fixed some memory leaks in various error paths.
Yang Tse [Thu, 15 Mar 2007 15:35:51 +0000 (15:35 +0000)]
show better description for AMD64-linux static libraries PIC check
Dan Fandrich [Thu, 15 Mar 2007 00:04:41 +0000 (00:04 +0000)]
Fixed a memory leak.
Daniel Stenberg [Wed, 14 Mar 2007 23:40:46 +0000 (23:40 +0000)]
yassl doesn't have SSL_get_shutdown() in its OpenSSL() layer so we check for
it and avoid it, even if this cripples the CCC command