Sergio Paracuellos [Sun, 9 Oct 2016 15:51:26 +0000 (17:51 +0200)]
staging: wlan-ng: fix block comments style in p80211conv.h
This patch fixes the following checkpatch.pl warning in p80211conv.h:
Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sabitha George [Mon, 10 Oct 2016 06:33:12 +0000 (12:03 +0530)]
staging: ks7010: use netdev_* instead of printk()
1. Fixes checkpatch warning on printk usage in ks_hostif.c
2. Dropped "ks_wlan" prefix from the messages
3. Removed the "Memory squeeze,dropping packet" messages
Signed-off-by: Sabitha George <sabitha.george@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Akshay Mariyanna [Sun, 9 Oct 2016 19:12:20 +0000 (00:42 +0530)]
staging: ks7010: fix space related style issues in ks7010_sdio.c
This fixes the following checkpatch warnings:
WARNING: Unnecessary space before function pointer arguments
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Akshay Mariyanna [Sun, 9 Oct 2016 19:12:18 +0000 (00:42 +0530)]
staging: ks7010: fix indent style in ks7010_sdio.c
This patch fixes the following checkpatch error:
ERROR: code indent should use tabs where possible
Signed-off-by: Akshay Mariyanna <akmlkcc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:29:22 +0000 (17:29 +0200)]
staging: wlan-ng: get memory from kernel allocators instead of big static buffer
This patch fix the following sparse warnings in prism2fw.c:
warning: memset with byte count of 120000
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:13:21 +0000 (17:13 +0200)]
staging: wlan-ng: avoid new typedef CTLX_STATE
This patch fixes the following checkpatch.pl warning in hfa384x.h:
WARNING: do not add new typedefs
It applies for typedef CTLX_STATE
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:32 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2fw.c
This patch fix the following checkpatch.pl warnings in prism2fw.c
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:30 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2sta.c
This patch fix the following checkpatch.pl warnings in prism2sta.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:29 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2mib.c
This patch fix the following checkpatch.pl warnings in prism2mib.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:28 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in prism2mgmt.c
This patch fix the following checkpatch.pl warnings in prism2mgmt.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:27 +0000 (17:10 +0200)]
staging: wlan-ng: fix line style warnings in p80211wep.c
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:26 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211wep.c
This patch fix the following checkpatch.pl warnings in p80211wep.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:25 +0000 (17:10 +0200)]
staging: wlan-ng: fix line style warnings in p80211req.c
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:24 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211req.c
This patch fix the following checkpatch.pl warnings in p80211req.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:23 +0000 (17:10 +0200)]
staging: wlan-ng: do not return -ENOSYS
Fixed coding style issue by replacing ENOSYS with EINVAL.
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: ENOSYS means 'invalid syscall nr' and nothing else
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:22 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211netdev.c
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:21 +0000 (17:10 +0200)]
staging: wlan-ng: fix line style warnings in p80211netdev.c
This patch fix the following checkpatch.pl warnings in p80211netdev.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:20 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in p80211conv.c
This patch fix the following checkpatch.pl warnings in p80211conv.c:
WARNING: Block comments should align the * on each line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:19 +0000 (17:10 +0200)]
staging: wlan-ng: fix block comment warnings in hfa384x_usb.c
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: Block comments should align the * on each line
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sergio Paracuellos [Sun, 9 Oct 2016 15:10:18 +0000 (17:10 +0200)]
staging: wlan-ng: fix line style warnings in hfa384x_usb.c
This patch fix the following checkpatch.pl warnings in hfa384x_usb.c:
WARNING: line over 80 characters
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:33 +0000 (01:01 +0700)]
staging:r8188eu: remove unnecessary type cast for update_recvframe_phyinfo_88e argument
pphy_status alreay is (struct phy_stat *).
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:32 +0000 (01:01 +0700)]
staging:r8188eu: refactor recvbuf2recvframe function
Reduce number of nesting levels.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:31 +0000 (01:01 +0700)]
staging:r8188eu: change poiter type from u8 to void for pallocated_frame_buf member of recv_priv structure
pallocated_frame_buf used only to preserve pointer for vfree function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:30 +0000 (01:01 +0700)]
staging:r8188eu: remove precv_frame_buf member of recv_priv structure
precv_frame_buf is used as local variable only in one function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:29 +0000 (01:01 +0700)]
staging:r8188eu: remove rx_pending_cnt member of recv_priv structure
Value of this variable does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:28 +0000 (01:01 +0700)]
staging:r8188eu: remove free_recvframe_cnt member of recv_priv structure
Value of free_recvframe_cnt does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:27 +0000 (01:01 +0700)]
staging:r8188eu: remove intf_stop member of adapter structure
call usb_intf_stop directly.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:26 +0000 (01:01 +0700)]
staging:r8188eu: remove pallocated_recv_buf member of the recv_priv structure
recv_priv used instead.
recv_priv does not changed after assigning
and it can be used as kfree argument
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:25 +0000 (01:01 +0700)]
staging:r8188eu: change type of the precv_buf member of recv_priv structure
To avoid unnecessary typecast.
To use compiler type checking.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:24 +0000 (01:01 +0700)]
staging:r8188eu: remove prhdr local variable from rtw_free_stainfo function
This variable is unnecessary.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:23 +0000 (01:01 +0700)]
staging:r8188eu: remove unused function declerations
rtl8188eu_recv_hdl and rtl8188e_query_rx_phy_status doesn't used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:22 +0000 (01:01 +0700)]
staging:r8188eu: remove padapter and free_sz arguments of rtw_os_xmit_resource_free function
These argumets does not used by rtw_os_xmit_resource_free function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:21 +0000 (01:01 +0700)]
staging:r8188eu: remove rtw_endofpktfile function
rtw_endofpktfile is one-line function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:20 +0000 (01:01 +0700)]
staging:r8188eu: remove ANTTEST(ALL|A|B) definitions
These defintions does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:19 +0000 (01:01 +0700)]
staging:r8188eu: remove bTXPowerTrackingInit member of odm_rf_cal structure
bTXPowerTrackingInit assigned, but not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:18 +0000 (01:01 +0700)]
staging:r8188eu: refactor rtl88eu_dm_txpower_tracking_callback_thermalmeter function
Remove is2t and rf local variables from this function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:17 +0000 (01:01 +0700)]
staging:r8188eu: remove NumTotalRFPath member of hal_data_8188e structure
NumTotalRFPath is 1 for r8188eu chip.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:16 +0000 (01:01 +0700)]
staging:r8188eu: remove RF_TYPE_8190P enumeration
This enumeration does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:15 +0000 (01:01 +0700)]
staging:r8188eu: remove rf_chip member of hal_data_8188e structure
This member is constant.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:14 +0000 (01:01 +0700)]
staging:r8188eu: remove Antenna_(Lfet|Right) enumeration items
These defintions does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:13 +0000 (01:01 +0700)]
staging:r8188eu: remove unused members of hal_data_8188e structure
These members of hal_data_8188e structure does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:12 +0000 (01:01 +0700)]
staging:r8188eu: remove ExternalPA member of hal_data_8188e structure
ExternalPA always is false.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:11 +0000 (01:01 +0700)]
staging:r8188eu: remove bLedOpenDrain member of hal_data_8188e structure
bLedOpenDrain always is true.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:10 +0000 (01:01 +0700)]
staging:r8188eu: remove bLedStartToLinkBlinkInProgress and bSWLedCtrl members of LED_871x structure
These members of LED_871x structure does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:09 +0000 (01:01 +0700)]
staging:r8188eu: remove bRegUseLed member of led_priv structure
bRegUseLed always is true.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:08 +0000 (01:01 +0700)]
staging:r8188eu: remove wrappers for LedControl8188eu function
There is no reason to use these wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:07 +0000 (01:01 +0700)]
staging:r8188eu: remove ff_hwaddr member of recv_priv structure
Its value used instead.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:06 +0000 (01:01 +0700)]
staging:r8188eu: remove (u32 cnt) argument of usb_read_port function
This argument does not used by usb_read_port function.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:05 +0000 (01:01 +0700)]
staging:r8188eu: change usb_read_port last argument type to (struct *recv_buf)
To avoid unnecessary typecasts.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:04 +0000 (01:01 +0700)]
staging:r8188eu: remove skb data alignment in r8188eu driver code
(__)netdev_alloc_skb align skb data.
Also this function set skb device.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:03 +0000 (01:01 +0700)]
staging:r8188eu: remove free_recv_buf_queue_cnt member of recv_priv structure
This variable does not used.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:02 +0000 (01:01 +0700)]
staging:r8188eu: remove pm_netdev_open function
netdev_open and ips_netdrv_open are used instead of pm_netdev_open.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:01 +0000 (01:01 +0700)]
staging:r8188eu: remove wrappers for rtw_hal_inirp_init function
There is no reason to use these wrappers.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ivan Safonov [Fri, 7 Oct 2016 18:01:00 +0000 (01:01 +0700)]
staging:r8188eu: remove rtw_os_recv_resource_alloc function
This simple function does not allocate any resource.
Signed-off-by: Ivan Safonov <insafonov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:21 +0000 (17:10 +0200)]
staging: most: hdm-usb: fix mbo buffer leak
This patch fixes an MBO leak by replacing the proprietary
free_anchored_buffers() function with the usb_kill_anchored_urbs() function
of the USB subsystem and guarantees that the mbo->complete() completion
function is being called for each URB.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:20 +0000 (17:10 +0200)]
staging: most: hdm-dim2: remove tracing of mac address
This patch removes tracing of the MAC address from the DIM2 HDM as it is
already done in the networking AIM.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:19 +0000 (17:10 +0200)]
staging: most: hdm-usb: remove filtering of networking state
In case the networking interface goes down and up again, the USB HDM does
not report the state the MOST networking interface controller is in. This
might lead to nonfunctional network.
Since the networking AIM already takes care of hardware address checking
and tracing it can be removed from the HDM USB, which is what this patch is
doing.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:18 +0000 (17:10 +0200)]
staging: most: aim-network: avoid calling netdev_info()
This patch removes the needless call of function netdev_info() from
function most_nd_setup().
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:17 +0000 (17:10 +0200)]
staging: most: aim-network: setup mac address before ifup has finished
The networking AIM implements a non-standard behavior as it starts the
networking interface with an invalid MAC address and changes it by the time
a valid one is available.
This patch introduces a completion object to set the MAC address of the
networking interface before the .ndo_open callback (ifup) of the net_device
returns.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:16 +0000 (17:10 +0200)]
staging: most: aim-network: fix startup scenario.
In case the networking interface (running on MediaLB) is being started
before the MOST network is, it remains disabled even after the MOST network
has transitioned to active mode.
This patch removes the dependency on the MOST link status to keep the
networking queue active and the networking interface working for the
case described above.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:15 +0000 (17:10 +0200)]
staging: most: core: update examples on how to link channels
This patch updates the comments with examples on how to use the "add_link"
and "remove_link" properties.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:14 +0000 (17:10 +0200)]
staging: most: core: remove processing of deprecated names
The USB HDM does not use the "@" character for channel names anymore. This
patch cleans up the code processing such names and adapts the corresponding
examples on how to use the properties "add_link" and "remove_link".
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:13 +0000 (17:10 +0200)]
staging: most: core: remove read option from remove_link
The attribute "remove_link" returns the latest link that has been removed
of a certain channel. Since this piece information isn't particulary
useful this patch is going to remove it.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Andrey Shvetsov [Tue, 4 Oct 2016 15:10:12 +0000 (17:10 +0200)]
staging: most: core: remove member add_link
This patch removes the unused field add_link of struct most_aim_obj.
Signed-off-by: Andrey Shvetsov <andrey.shvetsov@k2l.de>
Signed-off-by: Christian Gromm <christian.gromm@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Fri, 7 Oct 2016 14:21:28 +0000 (19:51 +0530)]
Staging: fwserial: remove unused function fill_unplug_req
The function fill_unplug_req is not used anywhere in the kernel, so
remove it. Done using Coccinelle.
@r1@
identifier func;
type T;
@@
static T func(...)
{
...
}
@r@
identifier r1.func;
@@
func
@delete depends on !r@
identifier r1.func;
type r1.T;
@@
- static T func(...){...}
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Harman Kalra [Sun, 9 Oct 2016 14:44:05 +0000 (20:14 +0530)]
Staging: fbtft: Fixed open parenthesis alignment check
This patch resolves all the following CHECKs caught by checkpatch.pl
CHECK: Alignment should match open parenthesis
Signed-off-by: Harman Kalra <harman4linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sun, 9 Oct 2016 07:56:28 +0000 (13:26 +0530)]
Staging: emxx_udc: constify usb_ep_ops structure
Declare the structure usb_ep_ops as constant as it is only stored in the
ops field of a usb_ep structure which is a field of a nbu2ss_ep structure.
The ops field is of type const struct usb_ep_ops *, so usb_ep_ops
structures having this property can be decalared as const.
Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct usb_ep_ops i@p = {...};
@ok1@
identifier r1.i;
position p;
struct nbu2ss_ep s;
@@
s.ep.ops=&i@p
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct usb_ep_ops i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct usb_ep_ops i;
File size before:
text data bss dec hex filename
16007 376 3720 20103 4e87
drivers/staging/emxx_udc/emxx_udc.o
File size after:
text data bss dec hex filename
16095 280 3720 20095 4e7f
drivers/staging/emxx_udc/emxx_udc.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sat, 8 Oct 2016 09:59:54 +0000 (15:29 +0530)]
Staging: emxx_udc: Remove useless type conversion
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sat, 8 Oct 2016 10:28:04 +0000 (15:58 +0530)]
Staging: skein: skein_api: Remove useless type conversion
Some type conversions like casting a pointer to a pointer of same type,
casting to the original type using addressof(&) operator etc. are not
needed. Therefore, remove them. Done using coccinelle:
@@
type t;
t *p;
t a;
@@
(
- (t)(a)
+ a
|
- (t *)(p)
+ p
|
- (t *)(&a)
+ &a
)
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Jakub Jedelsky [Tue, 4 Oct 2016 22:32:55 +0000 (00:32 +0200)]
staging: comedi: Align the * on block comments
Block comments should align the * on each line as reported by checkpatch
Signed-off-by: Jakub Jedelsky <jakub.jedelsky@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elizabeth Ferdman [Thu, 6 Oct 2016 21:44:28 +0000 (14:44 -0700)]
staging: i4l: add blank line after declarations
Fix checkpatch error "missing blank line after declarations" to conform
to kernel coding style.
Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elizabeth Ferdman [Thu, 6 Oct 2016 21:41:18 +0000 (14:41 -0700)]
staging: i4l: move open brace to previous line
Fix checkpatch error "open brace should be on previous line" since only
functions should have their opening brace on a new line.
Signed-off-by: Elizabeth Ferdman <gnudevliz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Benoit Hiller [Sat, 8 Oct 2016 19:49:55 +0000 (15:49 -0400)]
staging: dgnc: make find_board_by_major static
Fixes the following sparse warning:
drivers/staging/dgnc/dgnc_tty.c:933:19: warning: symbol 'find_board_by_major' was not declared. Should it be static?
Signed-off-by: Benoit Hiller <benoit.hiller@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:18:55 +0000 (23:18 +0000)]
staging: rts5208: xd.c: Remove multiple assignments
Checkpatch found multiple assignments on one line so move
them to their own lines.
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:18:38 +0000 (23:18 +0000)]
staging: rts5208: xd.c: Fix CamelCase
Covert CamelCase as checkpatch suggests
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:18:20 +0000 (23:18 +0000)]
staging: rts5208: xd.c: Clean up comparison to NULL
Checkpatch recommended changes
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:18:01 +0000 (23:18 +0000)]
staging: rts5208: xd.c: Remove unnecessary parentheses
Issues found with checkpatch
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:17:26 +0000 (23:17 +0000)]
staging: rts5208: Logical continuation fixes
Checkpatch detected multiple instances of logical continuation warnings
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:17:05 +0000 (23:17 +0000)]
staging: rts5208: Alignment fix
Coding style checks found by checkpatch
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Mon, 3 Oct 2016 23:16:43 +0000 (23:16 +0000)]
staging: rts5208: xd.h: Alignment fix
Change alignment to match open parenthesis
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Sun, 9 Oct 2016 10:35:23 +0000 (16:05 +0530)]
Staging: media: radio-bcm2048: constify v4l2_ioctl_ops structure
Declare the structure v4l2_ioctl_ops as const as it is only stored in
the ioctl_ops field of video_device structure. As this field is of type
const struct v4l2_ioctl_ops *, so v4l2_ioctl_ops structures having this
property can also be made const.
Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_ioctl_ops i@p = {...};
@ok1@
identifier r1.i;
position p;
struct video_device s;
@@
s.ioctl_ops=&i@p;
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct v4l2_ioctl_ops i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_ioctl_ops i;
File size before:
text data bss dec hex filename
20465 3220 32 23717 5ca5
drivers/staging/media/bcm2048/radio-bcm2048.o
File size after:
text data bss dec hex filename
21425 2260 32 23717 5ca5
drivers/staging/media/bcm2048/radio-bcm2048.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elise Lennion [Sun, 9 Oct 2016 03:50:29 +0000 (00:50 -0300)]
staging: media: lirc: Format block comments.
Fix checkpatch warning:
WARNING: Block comments use a trailing */ on a separate line
Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sabitha George [Sun, 9 Oct 2016 05:54:02 +0000 (11:24 +0530)]
staging: ks7010: Replace header files
This patch replaces inclusion of asm/atomic.h with linux/atomic.h and
asm/io.h with linux/io.h to fix checkpatch warning in ks_wlan.h
Signed-off-by: Sabitha George <sabitha.george@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mihaela Muraru [Sat, 8 Oct 2016 07:22:17 +0000 (10:22 +0300)]
Staging: ks7010: Delete unnecessary return statement
This is a patch to ks_hostif.c file that fixes up a checkpatch.pl
WARNING: void function return statements are not generally useful.
The 'return' statement is not useful here, because it is not necessary to be
forced the exit of the function.
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mihaela Muraru [Fri, 7 Oct 2016 22:58:11 +0000 (01:58 +0300)]
Staging: ks7010: __packed instedad of __attribute__((packed))
Fix a issue found by checkpatch.pl tool:
"WARNING: __packed is preferred over __attribute__((packed))".
Replace __attribute__((packed)) with __packed.
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Ebru Akagunduz [Fri, 7 Oct 2016 11:17:49 +0000 (14:17 +0300)]
staging: ks7010: remove unnecessary else statement
This patch removes else statement which is not
usefull after a return. Issue found by checkpatch.pl.
Signed-off-by: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pontus Fuchs [Thu, 6 Oct 2016 20:50:20 +0000 (22:50 +0200)]
staging: ks7010: Use printk format specifier for MAC addresses
Convert to %pM instead of custom code.
Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Pontus Fuchs [Thu, 6 Oct 2016 20:50:19 +0000 (22:50 +0200)]
staging: ks7010: Remove unnecessary cast
sdio functions takes unsigned int as address. No need to cast.
Signed-off-by: Pontus Fuchs <pontus.fuchs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Muraru Mihaela [Tue, 4 Oct 2016 20:08:25 +0000 (23:08 +0300)]
Staging: ks7010: fix brace coding style issue
This is a patch to the ks_wlan_net.c file that fixes up a brace coding
style warning found by checkpatch.pl tool, by deleting the unnecessary braces for single statement blocks.
Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Muraru Mihaela [Mon, 3 Oct 2016 19:28:52 +0000 (22:28 +0300)]
Staging: ks7010: add blank line after declaration
This patch fixes a coding style WARNING:
Missing a blank line after declaration, found by checkpatch.pl.
By adding a blank line after declaration of a variable.
Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Hoefflin [Mon, 3 Oct 2016 00:57:26 +0000 (02:57 +0200)]
staging: ks7010: fix checkpatch "space after #ifdef" error
Fix checkpatch "ERROR: exactly one space required after that #ifdef"
error in ks_hostif.c.
Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Hoefflin [Mon, 3 Oct 2016 00:57:25 +0000 (02:57 +0200)]
staging: ks7010: reformat makro ps_confirm_wait_inc()
Reformat the makro ps_confirm_wait_inc() to fix several checkpatch
errors and warnings:
- ERROR: space required before the open brace '{'
- ERROR: space required before the open parenthesis '('
- ERROR: code indent should use tabs where possible
- ERROR: space required after that close brace '}'
- ERROR: space required before the open parenthesis '('
- WARNING: line over 80 characters
- WARNING: please, no spaces at the start of a line
Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Hoefflin [Mon, 3 Oct 2016 00:57:24 +0000 (02:57 +0200)]
staging: ks7010: use tabs for indentation
Fix all occurences of checkpatch "ERROR: code indent should use tabs
where possible" errors in ks_hostif.c.
Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Philipp Hoefflin [Mon, 3 Oct 2016 00:57:23 +0000 (02:57 +0200)]
staging: ks7010: fix "prohibited space" errors reported by checkpatch
Fix all occurences of the following checkpatch errors in ks_hostif.c:
- ERROR: space prohibited after that '&' (ctx:WxW)
- ERROR: space prohibited after that open parenthesis '('
- ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Philipp Hoefflin <p.hoefflin@posteo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Juliana Rodrigues [Sat, 8 Oct 2016 20:49:28 +0000 (17:49 -0300)]
staging: rtl8188eu: core: fixes tabstop alignment
Fixes a tabstop alignment checkpatch issue by removing extra blank
spaces.
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Juliana Rodrigues [Sat, 8 Oct 2016 20:48:21 +0000 (17:48 -0300)]
staging: rtl8188eu: core: removes unecessary parenthesis
Removes unecessary parenthesis from rtw_led.c file that were causing
checkpatch warnings.
Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Thu, 6 Oct 2016 18:02:20 +0000 (23:32 +0530)]
Staging: rtl8712: remove unused functions
Remove the functions sleep_schedulable, down_scanned_network,
up_scanned_network and get_free_xmit_queue as they are not used anywhere
in the kernel. Functions detected using coccinelle but changes done by
hand.
Script:
@initialize:python@
@@
def display(name,p):
print(name,p[0].file)
@r1@
identifier func;
type T;
position p;
@@
static T func@p(...)
{
...
}
@r@
identifier r1.func;
@@
func
@script:python depends on !r@
func << r1.func;
p << r1.p;
@@
display(func,p)
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Bhumika Goyal [Tue, 4 Oct 2016 17:52:36 +0000 (23:22 +0530)]
Staging: rtl8192e: rtl_core: Constify rtllib_qos_parameters structures
Declare the structure rtllib_qos_parameters as constant as it is only
passed as the second argument to the function memcpy. This argument
is constant so the fields of rtllib_qos_parameters structure are
never modified and hence it can be declared as const.
Done using coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct rtllib_qos_parameters i@p = {...};
@ok1@
identifier r1.i;
position p;
expression e1,e2;
@@
memcpy(e1,&i@p,e2)
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct rtllib_qos_parameters i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct rtllib_qos_parameters i;
File size before:
text data bss dec hex filename
30910 496 201 31607 7b77
drivers/staging/rtl8192e/rtl8192e/rtl_core.o
File size after:
text data bss dec hex filename
30942 464 201 31607 7b77
drivers/staging/rtl8192e/rtl8192e/rtl_core.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Elise Lennion [Sun, 9 Oct 2016 01:40:24 +0000 (22:40 -0300)]
staging: sm750fb: Replace printk() with pr_info().
Fix checkpatch warning:
WARNING: printk() should include KERN_ facility level
New checkpatch warning appears after including KERN_ facility level.
Fix checkpatch warning:
WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Wayne Porter [Fri, 30 Sep 2016 22:39:52 +0000 (22:39 +0000)]
staging: android: ion_test: remove extra line per checkpatch.pl
Cleanup extra line found by checkpatch.pl
Signed-off-by: Wayne Porter <wporter82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
projects / platform / kernel / linux-exynos.git / log