Geoff Kizer [Thu, 21 Feb 2019 21:52:02 +0000 (13:52 -0800)]
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
333fabaffeabf3b4de5d6ba45e54b2078f57adcf
Geoff Kizer [Wed, 20 Feb 2019 20:54:39 +0000 (12:54 -0800)]
add StreamState and rework HTTP2 stream state handling
cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
1eba83637d47fde09c8e1748b0ebb4ca42da5ca4
Jeremy Barton [Wed, 20 Feb 2019 19:43:18 +0000 (11:43 -0800)]
Bump S.S.C.Pkcs AssemblyVersion Minor version (dotnet/corefx#35429)
* Bump S.S.C.Pkcs AssemblyVersion Minor version
New API was added for .NET Core 3.0, so the assembly minor needs to bump.
* Fix packaging validation errors
* Apply review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
b4f94abd2bc7c8f3167cd7301147a08cbf2ea3df
Stephen Toub [Wed, 20 Feb 2019 19:38:31 +0000 (14:38 -0500)]
Simplify ConnectHelper.ConnectAsync to just return Stream (dotnet/corefx#35411)
* Simplify ConnectHelper.ConnectAsync to just return Stream
SocketsHttpHandler's ConnectHelper.ConnectAsync currently returns a tuple of (Socket, Stream). We can instead just have it return the Stream and allow the call site to fish out the Socket from the Stream if it can. This is slightly more efficient memory-wise, in that the state machine involved will be smaller, but it also allows for a potential extensibility point that's simpler (abstracting out the ConnectAsync as a callback) and potentially allows us to in the future get a Socket in more cases, e.g. any connection helper handing back a NetworkStream.
Unfortunately, NetworkStream.Socket is protected rather than public. Until such time that there's a public property for this, there are two options here:
1. Use reflection to create a delegate we can then use to get at the property; "Socket" is part of the exposed surface area, so the only dependency here is on documented surface area.
2. Create a custom NetworkStream-derived type that exposes the protected as a public.
I started with (2), which works fine for our own internal needs currently, but shifted to (1), as it's more flexible.
* Don't use reflection
Commit migrated from https://github.com/dotnet/corefx/commit/
d9cdbc3cca0f75e5d7692f9ae03978dd0ed9b2e9
Stephen Toub [Wed, 20 Feb 2019 19:35:52 +0000 (14:35 -0500)]
Stop blocking thread pool threads in VirtualNetwork-based tests (dotnet/corefx#35453)
The SslStream tests and others use an internal VirtualNetwork helper. It's stream's ReadAsync method currently queues a work item to the thread pool that then blocks. This results in spurious failures and timeouts as all of the threads in the pool get blocked under load.
Commit migrated from https://github.com/dotnet/corefx/commit/
6b2628c69abaafda37dcd4fcb57e173a4f689e0c
Geoff Kizer [Wed, 20 Feb 2019 19:26:12 +0000 (11:26 -0800)]
Merge pull request dotnet/corefx#35432 from geoffkizer/windowupdatethreshold
defer sending WINDOW_UDPATE frames until a minimum threshold has been met
Commit migrated from https://github.com/dotnet/corefx/commit/
852602a3cebc2bfa14199cf6c39368bad1903c6c
Viktor Hofer [Wed, 20 Feb 2019 17:52:01 +0000 (18:52 +0100)]
Add net472 build3260 blobs (dotnet/corefx#35448)
Commit migrated from https://github.com/dotnet/corefx/commit/
b018ced265fe099679be0ec1e7afa805a154d49a
Konstantin Baladurin [Wed, 20 Feb 2019 16:53:12 +0000 (19:53 +0300)]
Fix tizen rootfs building (dotnet/corefx#35450)
Move tizen-release package from base to unified repo
Commit migrated from https://github.com/dotnet/corefx/commit/
17344dbf36ab683804eb69a173f61c66de1a605d
dotnet-maestro-bot [Wed, 20 Feb 2019 15:38:19 +0000 (07:38 -0800)]
Update CoreFxOptimizationData, ProjectNTfs, ProjectNTfsTestILC to master-
20190220.1, beta-27420-00, beta-27420-00, respectively (dotnet/corefx#35440)
Commit migrated from https://github.com/dotnet/corefx/commit/
c71537350eeb786e80326473bfa5d7fcab172988
David Fowler [Wed, 20 Feb 2019 11:56:06 +0000 (03:56 -0800)]
Added some doc comments to AsStream (dotnet/corefx#35442)
Commit migrated from https://github.com/dotnet/corefx/commit/
817d0557250ba0ea57f3aeba10934e1188fc0e88
Viktor Hofer [Wed, 20 Feb 2019 09:16:12 +0000 (10:16 +0100)]
Merge pull request dotnet/corefx#35415 from ViktorHofer/UWP-CI
Reenable UWP CI legs and upgrade to RS5
Commit migrated from https://github.com/dotnet/corefx/commit/
5385874fa7ab20f9e33997ebd20f31ae272bf7c5
Geoff Kizer [Wed, 20 Feb 2019 03:54:30 +0000 (19:54 -0800)]
PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8b4d2f58cd89efbe0d0b2a487d5ce96353c83150
dotnet-maestro-bot [Wed, 20 Feb 2019 01:50:37 +0000 (17:50 -0800)]
Update CoreFxOptimizationData to master-
20190219.1 (dotnet/corefx#35431)
Commit migrated from https://github.com/dotnet/corefx/commit/
a92b750a5edd4d262422e16260c4223ef7771c39
Max Kerr [Wed, 20 Feb 2019 01:29:37 +0000 (17:29 -0800)]
Disallow dangerous Unicode decompositions (dotnet/corefx#35428)
* Merged PR 159084: [2.2 Servicing] MSRC 47421: Disallow dangerous Unicode decompositions in System.Uri
This is a direct port of PR 158405.
This change blocks any Unicode decompositions that change the semantics of a URI. See the comments included in the change for more details.
Unlike the netfx implementation of this change, there is no mechanism for users to disable the fix. I believe that this is the correct choice for two reasons:
(1) Domain name registrars have disallowed these characters for almost as long as they have allowed punycode, so it's unlikely there are legitimate domains using them.
(2) The consequences of disabling the fix are significant, and are likely non-obvious to most users.
* Temporarily disable test on netfx
* Add a note on why the test is disabled on netfx.
Commit migrated from https://github.com/dotnet/corefx/commit/
b8654425442fef4ba4b58510be53d9859887be1a
Stephen Toub [Wed, 20 Feb 2019 01:27:49 +0000 (20:27 -0500)]
Make Http2Connection.SendFrameAsync return ValueTask (dotnet/corefx#35426)
This method frequently completes synchronously, and in such cases we can avoid the task allocation.
Commit migrated from https://github.com/dotnet/corefx/commit/
52993e52f9d3ab30da54884f7c5e0cdea2518e28
Alaa Masoud [Wed, 20 Feb 2019 01:04:45 +0000 (04:04 +0300)]
Remove dead code (dotnet/corefx#35430)
Commit migrated from https://github.com/dotnet/corefx/commit/
000aa2e0740524bdc2db690201e1b3521dd417a3
Geoff Kizer [Tue, 19 Feb 2019 09:43:27 +0000 (01:43 -0800)]
defer sending WINDOW_UDPATE frames until a minimum threshold has been met
Commit migrated from https://github.com/dotnet/corefx/commit/
99f8d99738f78b6791e2b30b9fababa9f8daa643
David Shulman [Tue, 19 Feb 2019 22:33:43 +0000 (14:33 -0800)]
Improve HTTP2 connection diagnostics in SocketsHttpHandler (dotnet/corefx#35423)
Modified the top-level exception being returned (HttpRequestException) to always include
the inner exception.
Contributes to dotnet/corefx#35422
Commit migrated from https://github.com/dotnet/corefx/commit/
fcf46bea903c78accd9586fa2fb355ade70c485e
David Fowler [Tue, 19 Feb 2019 22:24:50 +0000 (14:24 -0800)]
Added AsStream to PipeReader and PipeWriter (dotnet/corefx#35399)
- This adds a new virtual member to PipeReader and PipeWriter to get a read only or write only stream from the PipeReader and PipeWriter
- This introduces a new field on the base types
- Added tests
Commit migrated from https://github.com/dotnet/corefx/commit/
968a6a4450ca5acd3aed6a6f6e1f8b445348e729
Matt Mitchell [Tue, 19 Feb 2019 18:29:21 +0000 (10:29 -0800)]
Use SourceBranch vs. SourceBranchName (dotnet/corefx#35413)
* Use SourceBranch vs. SourceBranchName
SourceBranchName only evaluates to the last path name of the branch:
- 3.0 in release/3.0
We want the full branch, with refs/heads for consistency with the rest of the repos
Commit migrated from https://github.com/dotnet/corefx/commit/
36167bc544b968ed0bd67915f6512043a07734e0
Alaa Masoud [Tue, 19 Feb 2019 17:54:29 +0000 (20:54 +0300)]
Remove dead code (dotnet/corefx#35405)
Commit migrated from https://github.com/dotnet/corefx/commit/
9ccba7612721c347c8373cd4d226b1ac1329a73f
Viktor [Tue, 19 Feb 2019 17:20:35 +0000 (18:20 +0100)]
Upgrade uwp windows machines to RS5
Commit migrated from https://github.com/dotnet/corefx/commit/
56ad4b45a23b13f289fb9145c6eb5dca1969a1cc
Viktor [Tue, 19 Feb 2019 17:18:06 +0000 (18:18 +0100)]
Revert "Don't run tests on uap PR leg"
This reverts commit dotnet/corefx@
c34a9be660974ca1461a5f87d99e6750ae8dcb6b.
Commit migrated from https://github.com/dotnet/corefx/commit/
e8d186bc8eff2878ebe4a129cfba61a23343b516
David Shulman [Tue, 19 Feb 2019 17:14:44 +0000 (09:14 -0800)]
Fix Negotiate/SPNEGO Kerberos to NTLM fallback on Linux (dotnet/corefx#35383)
This PR adds support to our Linux gssapi layer so that we properly handle the Negotiate
protocol (SPNEGO) being able to to fall back from Kerberos to NTLM.
Windows Negotiate SSPI implements the SPNEGO protocol. However, it has built-in error
handling for dealing with quick fallback from Kerberos to NTLM in error cases such as where
the client is not on a domain/Kerberos realm, the client is using a local credential, the
client is talking to a non-domain server, etc.
However, the Linux implementation of SPNEGO doesn't handle those error cases very well.
So, I added the proper retry logic when generating the initial context token. Now, we will
be able to fall back from SPNEGO-wrapped Kerberos to SPNEGO-wrapped NTLM protocol blobs.
A similar bug exists in libcurl which is why Curl and CurlHandler are unable to connect to
Negotiate servers when not part of the Kerberos realm. I am considering proposing my fixes
to the libcurl repo as well.
I added more tests to support this PR and did manual testing. I added some additional
EventSource tracing as well.
Contributes to dotnet/corefx#34878
Commit migrated from https://github.com/dotnet/corefx/commit/
1fd3ba126538c2fed76d2279db26dc7ba5ceed41
Jan Kotas [Tue, 19 Feb 2019 16:18:53 +0000 (08:18 -0800)]
Fix product name included in the binaries (dotnet/corefx#35408)
Commit migrated from https://github.com/dotnet/corefx/commit/
6999d5e9809c22be73b71ab1f16d83721cc245e4
dotnet-maestro-bot [Tue, 19 Feb 2019 15:07:11 +0000 (07:07 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27419-00, beta-27419-00, respectively (dotnet/corefx#35402)
Commit migrated from https://github.com/dotnet/corefx/commit/
d9e276e451a8f4dded8272822d13001555a28ff3
Stephen Toub [Tue, 19 Feb 2019 05:38:07 +0000 (00:38 -0500)]
Use Environment.TickCount instead of DateTime{Offset}.UtcNow in SocketsHttpHandler (dotnet/corefx#35401)
We don't need the accuracy of UtcNow nor the absolute time when getting a time stamp in order to determine whether a connection should be retired; rather, we only need an approximate difference in time. This means the resolution of TickCount is fine, and the worst that happens if a connection happens to be alive for more than its ~49 day period is we may allow the connection to then live even longer than we otherwise would. In exchange, we get a much cheaper mechanism (~20x on Windows) mechanism for computing the connection age.
Commit migrated from https://github.com/dotnet/corefx/commit/
dca39727b02ceb4413d0fde11467965099ab4a2f
Viktor Hofer [Tue, 19 Feb 2019 02:40:02 +0000 (03:40 +0100)]
Remove old TestCategories property (dotnet/corefx#35397)
Commit migrated from https://github.com/dotnet/corefx/commit/
18452453fe8de55a065841798eb5e7a56c3436cb
Alaa Masoud [Tue, 19 Feb 2019 02:39:38 +0000 (05:39 +0300)]
Remove dead code in IpHlpApi (dotnet/corefx#35398)
Commit migrated from https://github.com/dotnet/corefx/commit/
24b8e537c4e880942bae2fbfe87d78c19ca60d44
Grant [Mon, 18 Feb 2019 19:40:46 +0000 (11:40 -0800)]
Unit tests for BitOps (dotnet/corefx#35193)
Commit migrated from https://github.com/dotnet/corefx/commit/
23f36ed60cd5afa6bafd4ed8e976f37fc2b07613
dotnet-maestro-bot [Mon, 18 Feb 2019 08:22:18 +0000 (00:22 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27418-00, beta-27418-00, respectively (dotnet/corefx#35389)
Commit migrated from https://github.com/dotnet/corefx/commit/
638ddfb1c6e625e5a702600c8d42bc6e254e2eb5
Ben Adams [Sun, 17 Feb 2019 15:40:48 +0000 (15:40 +0000)]
Skip lock in GetMemory/GetSpan if memory available (dotnet/corefx#35234)
Commit migrated from https://github.com/dotnet/corefx/commit/
c8f93fdd5e5f32ba854782714531af6737e5e26c
Francis Nguyen [Sun, 17 Feb 2019 11:45:20 +0000 (04:45 -0700)]
Collections cleanup (dotnet/corefx#35339)
* Removed dead strings for System.Collection.NonGeneric (dotnet/corefx#17905)
* Removed dead private ctor for LinkedList<T>.Enumerator
Commit migrated from https://github.com/dotnet/corefx/commit/
2086662ac52143972fdde887be506485115db503
Vladimir Sadov [Sun, 17 Feb 2019 05:15:33 +0000 (21:15 -0800)]
Merge pull request dotnet/corefx#35373 from VSadov/SslTestTimeout
Updating timeout in `SslStream_SameCertUsedForClientAndServer_Ok` test
Commit migrated from https://github.com/dotnet/corefx/commit/
7fe70b715c8535145c8aa7a39af7b507e005443a
Vladimir Sadov [Sun, 17 Feb 2019 00:10:44 +0000 (16:10 -0800)]
Updating timeout in `SslStream_SameCertUsedForClientAndServer_Ok` to match the rest of the tests in the area.
All other passing tests standardise on `TestConfiguration.PassingTestTimeoutMilliseconds`
There seems to be no reasons for SslStream_SameCertUsedForClientAndServer_Ok` to use a hardcoded timeout.
Also the hardcoded timeout is significantly shorter and occasionally leads to failures on low-spec test VMs.
Commit migrated from https://github.com/dotnet/corefx/commit/
8919cbdd960f41ba2f87c210d5f85d0d8a3c1276
Stephen Toub [Fri, 15 Feb 2019 23:13:47 +0000 (18:13 -0500)]
Merge pull request dotnet/corefx#35324 from stephentoub/http2allocs
Remove more Http2Connection/Stream allocations
Commit migrated from https://github.com/dotnet/corefx/commit/
55f7269536eb9c072cabd8bbcdd7644cd18bd001
dotnet-maestro-bot [Fri, 15 Feb 2019 20:40:25 +0000 (12:40 -0800)]
Update BuildTools, ProjectNTfs, ProjectNTfsTestILC to preview1-03715-01, beta-27415-00, beta-27415-00, respectively (dotnet/corefx#35353)
Commit migrated from https://github.com/dotnet/corefx/commit/
f40cb8ea05d8b1f3d9acdcd8cf257c764ef56693
Stephen Toub [Fri, 15 Feb 2019 16:40:17 +0000 (11:40 -0500)]
Address PR feedback and additional cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
c0f24cf4136f22e508e1b9289062e541bad6af88
Santiago Fernandez Madero [Fri, 15 Feb 2019 20:16:34 +0000 (14:16 -0600)]
Remove groovy and json files for unused pipelines (dotnet/corefx#35355)
Commit migrated from https://github.com/dotnet/corefx/commit/
babb33b15afe35d5ce8dd06d9f2f6f16ea4b71be
Stephen Toub [Fri, 15 Feb 2019 19:17:55 +0000 (14:17 -0500)]
Fix some XML comments in Base64Encoder/Decoder (dotnet/corefx#35354)
* Fix some XML comments in Base64Encoder/Decoder
* Update Base64Encoder.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
ec34e99b876ea1119f37986ead894f4eded1a19a
Stephen Toub [Fri, 15 Feb 2019 02:43:21 +0000 (21:43 -0500)]
Remove uap config from System.Net.Http UnitTests
These tests are compiling in internal sources and running tests against them directly. The only configuration we need is netcoreapp.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9d1057321c17d8692e829b311c925660e23f8db
Stephen Toub [Fri, 15 Feb 2019 02:20:59 +0000 (21:20 -0500)]
Use StaticTable for writing known headers
Commit migrated from https://github.com/dotnet/corefx/commit/
65a101d6968bac28f343ed2e352cf54f8e122f21
Geoff Kizer [Thu, 14 Feb 2019 22:26:49 +0000 (17:26 -0500)]
Implement static table for writing some headers
Commit migrated from https://github.com/dotnet/corefx/commit/
1b0b62a3a6fa0ea0fa301b0bac9b9c350ad6c14c
Stephen Toub [Thu, 14 Feb 2019 22:23:12 +0000 (17:23 -0500)]
Don't pool Http2Connection buffers
Http2Connection keeps these buffers for a really long time; we don't want it to starve the pool. It also leads to lifetime issues, as the buffers need to be (but currently aren't) released back to the pool, yet work can end up accessing the ArrayBuffer after the connection is logically disposed.
Commit migrated from https://github.com/dotnet/corefx/commit/
847f64fa812362e75dfcbd0bdcf41541921d607c
Stephen Toub [Thu, 14 Feb 2019 17:55:31 +0000 (12:55 -0500)]
Avoid per-request HeaderCallback delegate allocation
Commit migrated from https://github.com/dotnet/corefx/commit/
14ef1be63af22bc610223eab337bdab99e6af4a8
Stephen Toub [Thu, 14 Feb 2019 18:04:03 +0000 (13:04 -0500)]
Avoid lock object allocation in CreditManager
Commit migrated from https://github.com/dotnet/corefx/commit/
701102c5c0282b3d29edc76aca12d985af8ff70f
Stephen Toub [Thu, 14 Feb 2019 02:55:46 +0000 (21:55 -0500)]
Avoid syncobj object allocation in Http2Connection
Just use one of the other readonly objects.
Commit migrated from https://github.com/dotnet/corefx/commit/
d74108c671abffa3d314b011b7269806eedb7df7
Santiago Fernandez Madero [Fri, 15 Feb 2019 17:37:04 +0000 (11:37 -0600)]
Disable jenkins legs as we transition to use azure devops. (dotnet/corefx#35326)
* Disable jenkins legs to transition to azure devops
* Don't run tests on uap PR leg
Commit migrated from https://github.com/dotnet/corefx/commit/
af90ef6e49e766f8062eca740b4b3d03cf2745b5
joshudson [Fri, 15 Feb 2019 16:50:46 +0000 (08:50 -0800)]
Use vfork() improve performance when starting processes. (dotnet/corefx#33289)
* Use vfork() to start child processes where this yields a performance improvement due to getting rid of page faults.
* Remove specific dependency on shared memory vfork so that cross compiles work again.
* Added signal mask code so that a child process can't confuse the parent; also took care of pthread cancellation mask in case third-party native code tries to use it
* Fix issues from vfork() pull request review
* Check handler before replacing it
* Improve readability of signal handler removing
* Convert tabs to spaces
* use NSIG instead of dynamic probing because glibc punches a hole in the middle of the signal list
* Exclude Mac OSX from vfork() because we don't quite trust it.
* Fix one last batch of typos
Commit migrated from https://github.com/dotnet/corefx/commit/
0a561e3c71ec9b98f07b90d0c1f20f8956adafaa
Jan Kotas [Fri, 15 Feb 2019 08:11:29 +0000 (00:11 -0800)]
Fix CoreFX build breaks
Commit migrated from https://github.com/dotnet/corefx/commit/
f078da3a4ddcb99cbb26b59fb67f59fdfb200548
Michal Strehovský [Fri, 15 Feb 2019 10:46:31 +0000 (11:46 +0100)]
Add support for default interface methods in DispatchProxy (dotnet/corefx#34720)
The generated dispatch proxy shouldn't try to override non-virtual or final methods.
This also fixes a pre-existing bug where we would try to override static method on interfaces (while C# can't emit them, the CLR has supported them for ages).
Fixes dotnet/coreclrdotnet/corefx#15646.
Commit migrated from https://github.com/dotnet/corefx/commit/
89b67cc789c78ceb65bf996969aba6e30b0679d0
Kevin Jones [Fri, 15 Feb 2019 01:36:23 +0000 (20:36 -0500)]
macOS: Allow loading first X509 certificate from PEM sequence
* macOS X509 PAL support for concatenated PEM.
* GetCertContentType should throw on macOS to be consistent with Unix and Windows.
Commit migrated from https://github.com/dotnet/corefx/commit/
ef6e6693329981588384e98f463f814f5763c13d
Tanner Gooding [Thu, 14 Feb 2019 19:45:43 +0000 (11:45 -0800)]
Regenerating the System.Runtime.Intrinsics ref assembly to pick up the API changes. (dotnet/corefx#35321)
Commit migrated from https://github.com/dotnet/corefx/commit/
84bedcf58cfe951d37c5b3eba2957ddb2410f34d
Krzysztof Wicher [Thu, 14 Feb 2019 18:19:46 +0000 (10:19 -0800)]
System.IO.Ports native package (dotnet/corefx#35126)
* System.IO.Ports native package
* add inputs and outputs
* fix build
* change the way native package is build
* fix pkgproj and props per feedback
* NativeFile -> File
* add workaround for the package test
* exclude runtime.native.Syystem.IO.Ports from package testing
* disable also System.IO.Ports
* Add BaselineVersion and InboxOn in packageIndex.json
Commit migrated from https://github.com/dotnet/corefx/commit/
c776f656fd19cb371a05015dc452385a5222663b
Santiago Fernandez Madero [Thu, 14 Feb 2019 17:18:49 +0000 (11:18 -0600)]
Publish build artifacts only in official builds (dotnet/corefx#35320)
Commit migrated from https://github.com/dotnet/corefx/commit/
52a759ec38af649a5d39e9b3e977cf2bb04be749
dotnet-maestro-bot [Thu, 14 Feb 2019 13:21:59 +0000 (05:21 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27414-00, beta-27414-00, respectively (dotnet/corefx#35311)
Commit migrated from https://github.com/dotnet/corefx/commit/
e18f88caa7cc2be47ec00cbd2d3a2e3faa80a116
Layomi Akinrinade [Thu, 14 Feb 2019 02:45:35 +0000 (21:45 -0500)]
Add roundtrip tests for EncoderFallbackBufferHelper (dotnet/corefx#35008)
This increases branch test coverage for
System.Text.EncoderFallbackBufferHelper from 9% to 40.9%.
Commit migrated from https://github.com/dotnet/corefx/commit/
ed0a57d42d859a4b8fee19441c504bc296c2a2ae
dotnet-maestro-bot [Thu, 14 Feb 2019 02:41:30 +0000 (18:41 -0800)]
Update BuildTools to preview1-03713-01 (dotnet/corefx#35295)
Commit migrated from https://github.com/dotnet/corefx/commit/
f5717c1754f9ed3d845fdf5cc104492f7f5216f8
Afsaneh Rafighi [Wed, 13 Feb 2019 22:04:52 +0000 (14:04 -0800)]
Fix SqlClient udtTest (dotnet/corefx#35304)
* Fix UdtTest2
* fix UdtBulkCopyTest
Commit migrated from https://github.com/dotnet/corefx/commit/
8a8f95bda5a10c156ecb81e3b3590a77001c0f2c
Stephen Toub [Wed, 13 Feb 2019 20:17:50 +0000 (15:17 -0500)]
Merge pull request dotnet/corefx#34476 from Marusyk/rmarusyk/System-Runtime-Caching
System.Runtime.Caching. Refactor DllImports
Commit migrated from https://github.com/dotnet/corefx/commit/
66f8d08489dbe4772654ccad410a2328bbbe70fc
dotnet-maestro[bot] [Wed, 13 Feb 2019 20:07:33 +0000 (20:07 +0000)]
Update dependencies from dotnet/coreclr (dotnet/corefx#35291)
* Update dependencies from https://github.com/dotnet/coreclr build
20190212.74
This change updates the following dependencies
- Microsoft.NET.Sdk.IL - 3.0.0-preview4-27412-74
- Microsoft.NETCore.ILAsm - 3.0.0-preview4-27412-74
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview4-27412-74
* Expose new rounding modes and fix failing test
* Stop checking for null exception argument in Font test
Commit migrated from https://github.com/dotnet/corefx/commit/
a546587fbfb0137176353a4e5ab2de206e4975e9
Santiago Fernandez Madero [Wed, 13 Feb 2019 19:52:15 +0000 (13:52 -0600)]
Reenable Fedora27 queue (dotnet/corefx#35298)
Commit migrated from https://github.com/dotnet/corefx/commit/
add4cacbfb7f7d3f5f07630d10b24e38da4ad027
Afsaneh Rafighi [Wed, 13 Feb 2019 19:42:26 +0000 (11:42 -0800)]
Merge pull request dotnet/corefx#34393 from Wraith2/sqlperf-metadata
SqlClient reduce metadata size
Commit migrated from https://github.com/dotnet/corefx/commit/
f0f514117a40236129564e9756d8cf8fb0dc4f03
Afsaneh Rafighi [Wed, 13 Feb 2019 19:29:07 +0000 (11:29 -0800)]
Merge pull request dotnet/corefx#34711 from Wraith2/sqlfix-misc1
SqlClient minor cleanup to close old issues
Commit migrated from https://github.com/dotnet/corefx/commit/
ee6cf5ab949c05cf85cdf44678fa7763cd59910c
Afsaneh Rafighi [Wed, 13 Feb 2019 19:25:36 +0000 (11:25 -0800)]
Merge pull request dotnet/corefx#34546 from Wraith2/sqltests-updates
SqlClient Manual Test fixes and documentation update
Commit migrated from https://github.com/dotnet/corefx/commit/
f749fcae910fec7199f570ab5fb9f6c684c1b2ee
Stephen Toub [Wed, 13 Feb 2019 19:10:51 +0000 (14:10 -0500)]
Fix race condition in DiagnosticSourceEventSource (dotnet/corefx#35269)
* Use RemoteInvoke in DiagnosticSourceEventListener tests
Running these concurrently with other tests in the same process can result in spurious failures.
* Fix race condition in DiagnosticSourceEventSource
If multiple threads all try to write different objects at the same time, PropertySpec.Fetch can manifest a race condition that results in potentially trying to cast one call's object to another call's type. The fix is to allow for atomically storing the cached data, and using a local to ensure that a calling thread's view is consistent.
Commit migrated from https://github.com/dotnet/corefx/commit/
7c50828052ba55e3474ff5dd29ee7fcf5bbfa03d
William Godbe [Wed, 13 Feb 2019 18:07:08 +0000 (10:07 -0800)]
Merge pull request dotnet/corefx#35279 from wtgodbe/preview4
Update branding for preview4
Commit migrated from https://github.com/dotnet/corefx/commit/
5726c1ee1c70d06dd7dee318e868c8cd820e479b
Viktor Hofer [Wed, 13 Feb 2019 17:44:07 +0000 (18:44 +0100)]
Remove optionaltooling buildtools dependency (dotnet/corefx#34946)
* Remove optionaltooling buildtools dependency
* Disable uapaot Jenkins leg
Commit migrated from https://github.com/dotnet/corefx/commit/
9fa041a04df9a38ab4167e76fbee6133eb627f71
Stephen Toub [Wed, 13 Feb 2019 16:23:59 +0000 (11:23 -0500)]
Simplify Dbg to minimal tracing
Commit migrated from https://github.com/dotnet/corefx/commit/
84a67e49ca345d5d1ed10ce9b77c1c6093e75661
Roma Marusyk [Wed, 9 Jan 2019 18:59:10 +0000 (20:59 +0200)]
System.Runtime.Caching. Refactor DllImports
Commit migrated from https://github.com/dotnet/corefx/commit/
efe793dcfa40fbf64fffab55d2c584e408677f6c
dotnet-maestro-bot [Wed, 13 Feb 2019 16:13:26 +0000 (08:13 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27413-00, beta-27413-00, respectively (master) (dotnet/corefx#35286)
* Update ProjectNTfs, ProjectNTfsTestILC to beta-27413-00, beta-27413-00, respectively
* Remove EventCounter from System.Diagnostics.Tracing aot builds
Commit migrated from https://github.com/dotnet/corefx/commit/
d93c3864553f78002c674051e9cfafcceed6b2b8
Hugh Bellamy [Wed, 13 Feb 2019 15:58:15 +0000 (15:58 +0000)]
Introduce and use common calendar test base (dotnet/corefx#35150)
* Introduce common test base for Calendars
* Consolidate more tests
* Fix netfx test run
* Fix TwoYearDigitMax tests
Commit migrated from https://github.com/dotnet/corefx/commit/
8be17f83dfb6f9615b960d9fd048e1bb17c30533
Santiago Fernandez Madero [Wed, 13 Feb 2019 14:06:44 +0000 (08:06 -0600)]
Fix native build for x86 (dotnet/corefx#35289)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a85c72d570e279b8b609c24bb7a10e40fe64f2f
Stephen Toub [Wed, 13 Feb 2019 12:08:23 +0000 (07:08 -0500)]
Add a few more Parse_Subspan_Success inline datas (dotnet/corefx#35285)
Addressing PR feedback that I missed.
Commit migrated from https://github.com/dotnet/corefx/commit/
314c7a108debebc51a97f75b6c8a9eb53017e328
Santiago Fernandez Madero [Wed, 13 Feb 2019 07:45:27 +0000 (01:45 -0600)]
Fix official builds to publish to BAR using new sdk-task (dotnet/corefx#35287)
Commit migrated from https://github.com/dotnet/corefx/commit/
f15d18e904534a1dcadfd86a17340950d1d06e21
Stephen Toub [Wed, 13 Feb 2019 04:47:23 +0000 (23:47 -0500)]
Fix argument name in GCHandleTests (dotnet/corefx#35284)
A GCHandle test is validating that an argument exception contains a null parameter name. That's been fixed in coreclr, so this test will start to fail when we ingest a new coreclr. For now, just removing the null validation, as it's not useful.
Commit migrated from https://github.com/dotnet/corefx/commit/
b36cbda1a26ab4aa28fad9fb9a08c613bde4f609
Hugh Bellamy [Wed, 13 Feb 2019 03:44:06 +0000 (03:44 +0000)]
Cleanup AssociatedMetadataTypeTypeDescriptor (dotnet/corefx#35077)
Commit migrated from https://github.com/dotnet/corefx/commit/
b745257c15ba1ec8bdfd761aa0f38ecbc14d3fd8
David Shulman [Wed, 13 Feb 2019 02:12:03 +0000 (18:12 -0800)]
Add simple http Windows auth tests using loopback server (dotnet/corefx#35280)
I added this test to help get familiar with the new GenericLoopbackServer
test pattern as well as use the new SkipTestException() ability.
The test is not an end-to-end test. It simply validates that the client is able
to begin the multi-leg Windows auth handshake and send the initial Authorization
header.
In addition, once https://github.com/dotnet/core-eng/issues/5135 is completed,
the 'IsNtlmInstalled' condition will always be true for the CI machines. Thus,
we will get better test coverage for Windows auth scenarios.
Contributes to dotnet/corefx#34878
Commit migrated from https://github.com/dotnet/corefx/commit/
48bcedf786f264aa15adcb55b161ecc0cb2b2172
Steve MacLean [Mon, 4 Feb 2019 19:47:25 +0000 (14:47 -0500)]
Add AssemblyLoadContext.GetLoadContext(SPC) test
Commit migrated from https://github.com/dotnet/corefx/commit/
197d2a82ea38a5ea707a876fb055eabb3348e2a6
Geoff Kizer [Tue, 12 Feb 2019 20:54:50 +0000 (12:54 -0800)]
Merge pull request dotnet/corefx#34345 from geoffkizer/genericloopbackserver
Add GenericLoopbackServer for HttpClient testing
Commit migrated from https://github.com/dotnet/corefx/commit/
3de6ad8c1233ccf9c781d42a0cdb88b0aeb24cb7
Tomas Weinfurt [Tue, 12 Feb 2019 19:45:13 +0000 (11:45 -0800)]
enable SendAsync_RequestVersion20_ResponseVersion20IfHttp2Supported on Unix (dotnet/corefx#35201)
* enable SendAsync_RequestVersion20_ResponseVersion20IfHttp2Supported on Unix
* use IsWinHttpHandler to skip platform test on older windows
* reorder using statement
Commit migrated from https://github.com/dotnet/corefx/commit/
caba0ef9ea05f66aaae814e89848acc98c23f327
Ben Adams [Tue, 12 Feb 2019 17:54:39 +0000 (17:54 +0000)]
BufferSegment Handle Memory Set/Reset better (dotnet/corefx#35256)
Commit migrated from https://github.com/dotnet/corefx/commit/
838291cf1444e3a383dc296ab9190a3c0b642523
Viktor Hofer [Tue, 12 Feb 2019 16:04:29 +0000 (17:04 +0100)]
Add a shared framework and host for global tools in helix submissions (dotnet/corefx#35208)
* Add a shared framework and host for global tools
Adding the shared framework and host from the .dotnet directory to the
helix submission to provide a runtime for global tools.
* Darc update from build '
20190212.3'
Commit migrated from https://github.com/dotnet/corefx/commit/
6315ab5343fd4a15f2a8fedef2506f60ff5328d5
Geoff Kizer [Tue, 12 Feb 2019 12:00:04 +0000 (04:00 -0800)]
fix netfx build
Commit migrated from https://github.com/dotnet/corefx/commit/
0919bf7fde56a88f8cb2598d3b3709e6a75d279d
Filip Navara [Tue, 12 Feb 2019 08:52:56 +0000 (09:52 +0100)]
Add tests for ResourceManager on custom Assembly type. (dotnet/corefx#34617)
Commit migrated from https://github.com/dotnet/corefx/commit/
24450dad74b0df3fc81026d7726b8441c41ae429
Matthijs Breemans [Tue, 12 Feb 2019 08:47:40 +0000 (09:47 +0100)]
fix: pointed ProjectUrl to the Github repository instead of the .net homepage (dotnet/corefx#35154)
Commit migrated from https://github.com/dotnet/corefx/commit/
ca6d54bea4b8c98c030e138adf41c652856d5f9f
Hugh Bellamy [Tue, 12 Feb 2019 08:46:36 +0000 (08:46 +0000)]
Fix NullReferenceException in AssociationAttribute (dotnet/corefx#35078)
Commit migrated from https://github.com/dotnet/corefx/commit/
584b2af6b5c20b2c0429e1ccd18e345f87d66e15
Hugh Bellamy [Tue, 12 Feb 2019 08:44:28 +0000 (08:44 +0000)]
Add ObjectModel tests (dotnet/corefx#35013)
Commit migrated from https://github.com/dotnet/corefx/commit/
596c31093b61a19c0a5d8dbda8b2954442b2bf6b
dotnet-maestro-bot [Tue, 12 Feb 2019 07:38:55 +0000 (23:38 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27412-00, beta-27412-00, respectively (dotnet/corefx#35255)
Commit migrated from https://github.com/dotnet/corefx/commit/
e902847cda101afbc6fc5397b03f3d4dcaec20e3
Sung Yoon Whang [Tue, 12 Feb 2019 06:05:40 +0000 (22:05 -0800)]
Merge pull request dotnet/corefx#35227 from dotnet/fix-eventsource-test
System.Runtime added to known test list in BasicEventSourceTest
Commit migrated from https://github.com/dotnet/corefx/commit/
e8e469653ca46e0499c925dfaaea796fc6f61cb0
Santiago Fernandez Madero [Tue, 12 Feb 2019 03:55:42 +0000 (21:55 -0600)]
Publish build logs as artifacts and produce a binlog to publish to helix (dotnet/corefx#35235)
* Publish build logs as artifacts and produce a binlog to publish to helix
* Flow Configuration property to arcade for logs to be binplaced correctly
Commit migrated from https://github.com/dotnet/corefx/commit/
0d5348f8836debced9d7f93a780e07016cf2e83c
Santiago Fernandez Madero [Tue, 12 Feb 2019 03:53:20 +0000 (21:53 -0600)]
Support building corefx in VS2019 (dotnet/corefx#35197)
* Support building corefx in VS2019
* PR Feedback and update docs for VS2019
Commit migrated from https://github.com/dotnet/corefx/commit/
fd736ea93d3b2b4bfa0288afdde34ebd9c9a680a
Santiago Fernandez Madero [Tue, 12 Feb 2019 03:52:40 +0000 (21:52 -0600)]
Remove Jenkins uap and all configurations legs (dotnet/corefx#35249)
Commit migrated from https://github.com/dotnet/corefx/commit/
23ec14f59138c41754238183d6fe216d7210bee2
Ahson Khan [Tue, 12 Feb 2019 02:37:51 +0000 (18:37 -0800)]
Make sure SequencePosition is saved as part of JsonReaderState (dotnet/corefx#35245)
Commit migrated from https://github.com/dotnet/corefx/commit/
53486e44427e096a4d7f672a0667980e8b65de63
David Shulman [Tue, 12 Feb 2019 01:27:04 +0000 (17:27 -0800)]
Fix HttpClient EKU tests (dotnet/corefx#35240)
A set of HttpClient tests related to ClientCertificates were always failing on my machine:
System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ClientCertificates_Test
* method="Manual_SendClientCertificateWithClientAuthEKUToRemoteServer_OK"
* method="Manual_SendClientCertificateWithNoEKUToRemoteServer_OK"
* method="Manual_SendClientCertificateWithServerAuthEKUToRemoteServer_Forbidden"
These tests would generate an exception:
>System.Net.Http.HttpRequestException: An error occurred while sending the request. --->
System.IO.IOException: The remote party requested renegotiation when AllowRenegotiation was set to false.
Similar to the tests failing and fixed in PR dotnet/corefx#35225, the CI machines don't have the test
root certificate installed. So, the tests weren't running in CI and the failures weren't noticed.
The root cause of the test failures is due to using SocketsHttpHandler. It is always setting
`SslStream.AllowRenegotiation` to false when first attempting to connect via HTTP/2. This is fine
if the connection is truely HTTP/2 since HTTP/2 doesn't support TLS renegotiation. However, if the
remote endpoint doesn't support HTTP/2 and thus connects with HTTP/1.1, then the SslStream should
not have AllowRenegotiation set to false. Client certificate scenarios frequently have the server
ask for the client certificate later in the connection process. So, TLS renegotiation is used. Opened
new issue dotnet/corefx#35239 to fix this in SocketsHttpHandler (or SslStream).
As part of fixing these tests, I refactored them into a single Theory test. But I had to workaround
complications due to using RemoteInvoke. I added a new RemoteInvoke overload to handling passing
an additional parameter.
Commit migrated from https://github.com/dotnet/corefx/commit/
0c2ccd172157e0ebf1957e1bbcd5f07786ad6e3d
Martin Baulig [Tue, 12 Feb 2019 01:21:54 +0000 (20:21 -0500)]
Fix ServerAsyncAuthenticateTest. (dotnet/corefx#35170)
In ServerAsyncSslHelper, pass a certificate validation callback to both
client and server.
Commit migrated from https://github.com/dotnet/corefx/commit/
a46d64a21591dd36292b0f6f0946fc55babced11
Jeremy Barton [Tue, 12 Feb 2019 01:07:05 +0000 (17:07 -0800)]
Make DEBUG builds always print chain errors (dotnet/corefx#35243)
Commit migrated from https://github.com/dotnet/corefx/commit/
24d614dd0b79e470163f0a392ee227a097199b35
Kevin Jones [Tue, 12 Feb 2019 00:41:07 +0000 (19:41 -0500)]
Ignore CTRequired when building an X509 chain. (dotnet/corefx#35246)
Commit migrated from https://github.com/dotnet/corefx/commit/
e8a88e8e0270977edc74019a282c73eab940b872
Santiago Fernandez Madero [Tue, 12 Feb 2019 00:31:12 +0000 (18:31 -0600)]
Reenable Ubuntu testing (dotnet/corefx#35248)
Commit migrated from https://github.com/dotnet/corefx/commit/
3ae95c99ffe82aaf087c64857ee6982a6c9e1ba6
Viktor Hofer [Mon, 11 Feb 2019 23:14:08 +0000 (00:14 +0100)]
Thread principal unauthenticated (dotnet/corefx#35112)
* Remove bind error for thread principal
* Disable threadpool test for uapaot
* Disable MailMessage reflection test on uapaot
* Disable ValueTask reflection tests on uapaot
* Guard System.TestEnvironment against ILC
* Revert AppDomain UnauthenticatedPrincipal change
Commit migrated from https://github.com/dotnet/corefx/commit/
0424e9db4628029b3308380f26312c79912bfb42