Chris Forbes [Fri, 1 Sep 2017 17:10:12 +0000 (10:10 -0700)]
layers: Remove remnants of old perf warning for disturbing sets
Half of this was removed, but the surrounding plumbing was left in
place. If we want to quietly add some 'was disturbed' bits so we can
produce a better error at a later draw, that should go on the
record-side of this validation, not here.
Removes the other case that the previous change missed, along with the
vestigial bits of the previous check.
Remove subtest and surrounding scaffolding that tested this
John Zupin [Mon, 21 Aug 2017 22:36:45 +0000 (16:36 -0600)]
CMake: GH1989, add wayland include dir to cmake
On some Linux distributions (e.g openSUSE) the wayland headers are in
a subdirectory.
Adding WAYLAND_CLIENT_INCLUDE_DIR to include_directories in CMakeLists.txt
will fix this issue.
Mike Weiblen [Fri, 1 Sep 2017 17:25:50 +0000 (11:25 -0600)]
external: Update commit ID: glslang
Update to most recent glslang-specified commit.
Change-Id: I35d8438833319e2d662dcf20353199d52f0b2ac0
Mark Lobodzinski [Mon, 21 Aug 2017 16:33:07 +0000 (10:33 -0600)]
layers: Account for push descriptor sets in CV
Change-Id: I1095edce0f26e2a4ced6fa301143622dc5cd0afd
Mark Lobodzinski [Thu, 17 Aug 2017 17:54:52 +0000 (11:54 -0600)]
layers: Match state record pattern for VOID APIs
Also straightened out the locking/unlocking for PushDescriptorSets.
Change-Id: Ic72bc693d16e7fa85df117d29abc1adc5a29ada6
Mark Lobodzinski [Wed, 16 Aug 2017 20:02:21 +0000 (14:02 -0600)]
layers: Update desc binding state for PushDescSets
Using PushDescriptorSets in a pipeline with normal Allocated descriptor
sets resulted in incorrect descriptor binding validation errors.
PushDescriptors are now run through the descriptor binding
state-update functions.
Change-Id: Ib702949af6de0b8638401c7eeb841c2590998e82
Mark Lobodzinski [Wed, 16 Aug 2017 16:25:59 +0000 (10:25 -0600)]
layers: Intercept PushDescriptorSets in CV
Change-Id: Ifabf7058b4ded33ab191a0043d9ef390b4c8cb06
Mark Lobodzinski [Wed, 16 Aug 2017 15:30:32 +0000 (09:30 -0600)]
layers: Refactor CmdBindDescSets for pre/post
Validation and state updates are now somewhat less tangled.
Change-Id: Ia666215a73ce02d2fbc326fb5b37b3361d83bbe3
Cody Northrop [Tue, 29 Aug 2017 21:09:39 +0000 (15:09 -0600)]
android: Update shader toolchain revisions
Pulled from:
https://github.com/google/shaderc/blob/
90a90d6f745704ac05afe70b7e8f759bec2ff493/known_good.json
Lenny Komow [Tue, 29 Aug 2017 22:08:39 +0000 (16:08 -0600)]
loader: Fix GetProcAddress loading illegal funcs
The loader would return an unknown device extension handler when
specifying a function from a layer that was available, but not
enabled.
Change-Id: I0d77a7489d66e4d77aa8446018ec545c930f5bcf
Mike Weiblen [Mon, 28 Aug 2017 22:18:37 +0000 (16:18 -0600)]
external: Update commit IDs: glslang, tools, header
Change-Id: Ic0777dda7b6958d2454dfec288630044e6f70db3
Jeff Juliano [Sat, 26 Aug 2017 14:22:22 +0000 (10:22 -0400)]
build: Improve component enables usage text
Jeff Juliano [Sat, 26 Aug 2017 14:04:29 +0000 (10:04 -0400)]
build: Add no-sync to update_ext_srcs batch file
Complete support for cygwin environment by adding --no-sync support
to update_external_sources.bat. Also change command line parsing for
the the .bat script to be similar to the .sh script.
Change-Id: Ie813938654e7f4bb9575eef2587f36ca2933f30c
Jeff Juliano [Sat, 26 Aug 2017 12:20:51 +0000 (08:20 -0400)]
build: Improve cygwin build support
Partially support cygwin environment by adding --no-build to
update_external_sources.sh
Change-Id: I9fa35d6c720dd05a11c307d3da4d09415934899e
Jeff Juliano [Sat, 26 Aug 2017 12:28:57 +0000 (08:28 -0400)]
build: Add missing quotes
Change-Id: Icff4a71bbedc3ee95d2dc2b85224a3c2eee74cb6
Mike Schuchardt [Thu, 24 Aug 2017 21:15:02 +0000 (15:15 -0600)]
scripts: PV codegen handle multiple requires
Modify parameter validation codegen to handle multiple require blocks in
an extension, each with additional extension dependencies.
Change-Id: I336569ca19808f3dca342eb65fd076599c4fb329
Chris Forbes [Fri, 25 Aug 2017 16:32:34 +0000 (09:32 -0700)]
layers: use unique_ptr for pipeline map
Slawomir Cygan [Fri, 25 Aug 2017 08:54:03 +0000 (10:54 +0200)]
Loader: Fix out-of-memory handling in loaderGetDeviceRegistryFiles
Wrongly handled OOM error causes
dEQP-VK.api.object_management.alloc_callback_fail test to fail, because wrong
error code is returned.
Chris Forbes [Fri, 25 Aug 2017 18:21:19 +0000 (11:21 -0700)]
layers: Fix crash in CreateGraphicsPipelines reading from moved-from ptr
Chris Forbes [Fri, 25 Aug 2017 18:19:44 +0000 (11:19 -0700)]
Revert "Revert "layers: unique_ptr for temp compute pipelines""
This reverts commit
615dc4e3ea0495bc28130377b9e637e9979a560e.
Chris Forbes [Fri, 25 Aug 2017 18:19:39 +0000 (11:19 -0700)]
Revert "Revert "layers: Introduce some unique_ptr into pipeline creation""
This reverts commit
5d6aaa553b634747fb2761c6e5b665bdae54d206.
Chris Forbes [Fri, 25 Aug 2017 16:37:35 +0000 (09:37 -0700)]
Revert "layers: Introduce some unique_ptr into pipeline creation"
This reverts commit
7d35703bdc03d94cad272b5ea3ede8d586f57e88.
Chris Forbes [Fri, 25 Aug 2017 16:37:28 +0000 (09:37 -0700)]
Revert "layers: unique_ptr for temp compute pipelines"
This reverts commit
cfc1ed15584a12ef62e113c8daf673c6a68ce29c.
Chris Forbes [Fri, 25 Aug 2017 16:16:00 +0000 (09:16 -0700)]
layers: unique_ptr for temp compute pipelines
Chris Forbes [Thu, 24 Aug 2017 22:45:08 +0000 (15:45 -0700)]
layers: Introduce some unique_ptr into pipeline creation
Mark Lobodzinski [Wed, 23 Aug 2017 21:23:23 +0000 (15:23 -0600)]
scripts: Enable instance extension checks in PV
Parameter_validation's hammer for excluding some pdev-ish checks was
too large. This adds extension dependency checks for about 50 more
APIs.
Change-Id: Icb44cdb36c8c0384781e04e207ceb18d9f67ff0c
Mark Lobodzinski [Mon, 21 Aug 2017 16:34:38 +0000 (10:34 -0600)]
header: Update to version 1.0.59 of the vulkan hdr
- updated vulkan.h
- updated vk.xml
- updated Win/Lin json files
- rebuilt and updated vulkan.hpp
- updated vk_validation_error_database.txt
- updated vk_validation_error_messages.h
- added new code-generated VUIDs (16) to error database
- modified object tracker for VUID corner-case
- updated vulkaninfo.c for STYPE name change
Change-Id: I0870e8bc4e84867e05bd466c13c7428b9b7365ac
Gabríel Arthúr Pétursson [Sat, 19 Aug 2017 16:44:45 +0000 (16:44 +0000)]
layers: Use correct data layer in vkCreateInstance in param validation
Tobin Ehlis [Tue, 22 Aug 2017 19:11:23 +0000 (13:11 -0600)]
layers:Remove disturbed descriptor perf warning
Fixes #2020
Support from devs to remove this perf warning so just killing it.
Added a comment for future work where we can track which descriptors
are disturbed and reference that if a user attempts to use a
disturbed descriptor that isn't bound.
Also commented out associated test and filed #2022 to track enhancement
making note of disturbed descriptors if used unbound.
Jeremy Kniager [Wed, 16 Aug 2017 20:57:42 +0000 (14:57 -0600)]
layers: Fix memory leaks in functions
Change-Id: I8e25adabefde3a04be5536ce4c5c2d5920a76140
Cody Northrop [Wed, 16 Aug 2017 23:38:15 +0000 (17:38 -0600)]
vkjson: Add support for Android
This commit adds vkjson and vkjson_info to the Android build.
It is only generated as an executable for devices with root
access, but it could be expanded to an APK with some more
boilerplate work.
See updates to BUILD.md for how to build and run on the device.
Chris Forbes [Wed, 16 Aug 2017 20:29:41 +0000 (13:29 -0700)]
layers: Wire up static_status check for CmdSetScissor
Chris Forbes [Wed, 16 Aug 2017 20:26:00 +0000 (13:26 -0700)]
layers: Wire up static_status check for CmdSetViewport
Chris Forbes [Wed, 16 Aug 2017 20:18:37 +0000 (13:18 -0700)]
layers: Drop error for binding compute pipeline inside renderpass
It's perfectly valid to bind the compute pipeline inside a renderpass.
An application only may not /dispatch/ compute work inside a
renderpass.
Chris Forbes [Wed, 16 Aug 2017 20:16:31 +0000 (13:16 -0700)]
layers: Drop out some redundant checks already covered by OT
Chris Forbes [Wed, 16 Aug 2017 19:58:48 +0000 (12:58 -0700)]
layers: Calculate viewport/scissor state bits correctly
Chris Forbes [Wed, 16 Aug 2017 19:56:01 +0000 (12:56 -0700)]
layers: (re)-add viewport and scissor cbstatus flags
We won't actually check these at draw time since we have more precise
per-viewport and per-scissor support there, but we need these in order
to easily reject CmdSetViewport/CmdSetScissor when the pipeline doesn't
have the appropriate dynamic state enabled.
Cody Northrop [Wed, 16 Aug 2017 19:25:22 +0000 (13:25 -0600)]
android: Updates for NDK r15
Removes app_dummy from apps that use native activity.
For more details refer to: https://github.com/android-ndk/ndk/issues/381
Alex Smith [Wed, 16 Aug 2017 08:23:27 +0000 (09:23 +0100)]
layers: Fix img layout state in CmdExecuteCommands
Previously the layout state in the primary command buffer was just
overwritten with the state in the secondary command buffer.
This can lead to spurious errors upon submission of the primary CB, if
an image used in the secondary CB is used prior to CmdExecuteCommands
in the primary CB with a different initial layout. This is because the
initialLayout field for the image on the primary CB is overwritten
with that of the secondary CB.
An example case that was incorrectly erroring (these commands refer to
the same image, newly created):
(primary buffer)
vkCmdPipelineBarrier, transition UNDEFINED -> TRANSFER_DST_OPTIMAL
vkCmdExecuteCommands
(secondary buffer)
...
vkCmdCopyBufferToImage, layout TRANSFER_DST_OPTIMAL
Just before the CmdExecuteCommands, the image had initialLayout =
UNDEFINED and layout = TRANSFER_DST_OPTIMAL on the primary CB, and
initialLayout = layout = TRANSFER_DST_OPTIMAL on the secondary.
After CmdExecuteCommands, the primary CB state is overwritten, so
it has initialLayout = layout = TRANSFER_DST_OPTIMAL. At submission,
this then errors because the global image layout is UNDEFINED.
Fix by only setting initialLayout on the primary CB from the secondary
if the image hasn't already been used on the primary.
Change-Id: Iae248ed09b1f87598fd192ba3d6f0bcf7ad38ada
Alex Smith [Wed, 16 Aug 2017 08:17:54 +0000 (09:17 +0100)]
layers: Copy queue submit fcns in CmdExecuteCommands
When a secondary command buffer is executed, copy all functions in its
queue_submit_functions list to the primary command buffer.
This is needed e.g. to ensure that functions registered to validate and
update memory validity state for a command in the secondary CB get run
upon submission of the primary CB.
Fixes spurious memory invalid warnings on later commands after an
image's memory has been initially made valid inside a secondary CB.
Change-Id: I39d5a34f074942d5dedbf4c5a0295af957a92361
Mark Lobodzinski [Wed, 16 Aug 2017 18:08:12 +0000 (12:08 -0600)]
layers: Update Database to fix CI
Couple of VUIDS were not added to the database.
Change-Id: I8ad8868182c8d129622d616241f5e0a14cb5054e
Chris Forbes [Tue, 15 Aug 2017 22:07:37 +0000 (15:07 -0700)]
layers: Check cb::static_status for most dynamic state setters
Chris Forbes [Tue, 15 Aug 2017 21:48:50 +0000 (14:48 -0700)]
layers: Track static state bits separately
This gives us two advantages:
- We no longer need to recalculate the state bits to remove for the old
pipeline when binding a new pipeline.
- We now have the set of bits to test against when trying to bind
dynamic state for #614
Chris Forbes [Tue, 15 Aug 2017 19:28:16 +0000 (12:28 -0700)]
layers: Invalidate old pipeline's static state when binding
Previously we'd only ever or in new bits, causing us to miss cases where
some state changes from static to dynamic within a CB.
Also only fiddle with the state masks when binding a graphics pipeline
-- previously we'd miss some other cases because binding a compute
pipeline would set all the state bits.
Chris Forbes [Tue, 15 Aug 2017 18:23:40 +0000 (11:23 -0700)]
layers: inline set_cb_pso_status into sole caller
Chris Forbes [Tue, 15 Aug 2017 18:09:13 +0000 (11:09 -0700)]
Split out dynamicstate->flags conversion
Mark Lobodzinski [Tue, 8 Aug 2017 20:16:51 +0000 (14:16 -0600)]
layers: Move PV custom funcptrs into map
Simplifies steps necessary for new custom functions.
Change-Id: Ib2d80346ebc42011dce74fdd8cee62adb4b3432c
Mark Lobodzinski [Tue, 1 Aug 2017 19:02:20 +0000 (13:02 -0600)]
layers: Re-architect parameter validation layer
Changed the codegen to autogenerate validation functions for any new
APIs without user intervention. Manual updates are only necessary to
extend PV functionality.
- parameter_validation.h is now checked into the layers directory
- parameter_validation.cpp is now generated
- parameter_validation_utils.cpp is new and contains any custom
(non-generated) or housekeeping functions.
- parameter_validation_utils.h is deprecated
- updated database for new VUID coverage
Change-Id: Ib9261894386145573ba9e8906ba4ad4e9fecbdfd
Jeremy Kniager [Tue, 18 Jul 2017 17:10:28 +0000 (11:10 -0600)]
layers: Add checks for Image/ImageView usage
Change-Id: Ibb2ac5b5f4b4176f5745007598c2fe64665237c2
Karl Schultz [Tue, 15 Aug 2017 15:08:53 +0000 (09:08 -0600)]
demos: Fix disappearing objects in smoketest
When an object reaches the end of its "curve" path
it receives a new curve. To ease the transition from
the old curve to the new curve, the origin of the new
curve is the ending point of the old curve. However,
this can result in the starting point of the new curve
being out of the view. This results in objects slowing
leaving the view.
Add code to move the origin of the new curve back inside
the original view bounds only if the end of the old curve
is out of the view bounds. This does not add any additional
jarring because any object getting a new origin is already
outside the view anyway.
Change-Id: I50e88be453f31b9c37878f63c97d4c7c8154e718
Mark Lobodzinski [Mon, 14 Aug 2017 21:26:30 +0000 (15:26 -0600)]
header: Update to version 1.0.58 of the vulkan hdr
- updated vulkan.h
- updated vk.xml
- updated cgenerator.py
- updated Win/Lin json files
- updated vulkan.hpp
- updated vk_validation_error_messages.h
- updated vk_validation_error_database.h
Change-Id: I8c525b6a2bd69914440c6d7984a67446b27e6c23
Tony Barbour [Mon, 14 Aug 2017 18:02:30 +0000 (12:02 -0600)]
demos: Add compositeAlphaFlags fix to cube.c
Change-Id: Id19d11e909ffc21c4aa6a419b071ba53594ae94f
gwizdz [Mon, 7 Aug 2017 23:17:01 +0000 (01:17 +0200)]
demos: cube.cpp - iterating over compositeAlphaFlags
Error in for loop condition
Change-Id: I8c775f961a6c05dd36e7acfdda6e94399365f90d
Mark Lobodzinski [Thu, 10 Aug 2017 17:25:01 +0000 (11:25 -0600)]
layers: Fix layer settings file debug action name
Change-Id: Ic5a6828d57515efb50c12e21ef45e690c058c96a
Mark Lobodzinski [Thu, 10 Aug 2017 17:01:17 +0000 (11:01 -0600)]
layers: GH1991, Implement BREAK debug action
Change-Id: I19ee76db3a380116c7c25819a112751d988e23b4
Lenny Komow [Thu, 10 Aug 2017 15:25:49 +0000 (09:25 -0600)]
loader: Replace overzealous warnings with info
The new ICD search functionality was logging warnings in some places
where information was more appropriate, such as when opening a device
or for some errors that simply indicated that the new format is not
supported yet.
Change-Id: Ifc8ce33d778783f3f55102783bf6ede0dd7c2a00
Lenny Komow [Wed, 9 Aug 2017 22:01:59 +0000 (16:01 -0600)]
loader: Don't load manifest files more than once
Change-Id: I2802ad0c1fd16c0287ed24b96ec6d81c4b3c711a
Slawomir Cygan [Wed, 9 Aug 2017 09:36:52 +0000 (11:36 +0200)]
loader: Fix size handling when scanning registries
loaderGetRegistryFiles() should not start from 4096 size, if
loaderGetDeviceRegistryFiles function has already appended something
into the buffer.
Slawomir Cygan [Mon, 3 Jul 2017 14:47:52 +0000 (16:47 +0200)]
loader: Add new ICD search paths to loader
This change extends the functionality of searching for ICD JSONs by
adding registry locations specific to given display adapter and
software components associated with this display adapter.
The exact locations in registry are queried using Windows public PnP
Configuration Manager API[1].
This change is required, as previous ICD locations (constant path
in "HKLM/Software") may be unreachable for drivers and their
installers on Windows RS3[2].
Similar change is being made for OpenCL[2]
[1]https://msdn.microsoft.com/en-us/library/windows/hardware/
ff549713.aspx
[2]https://github.com/KhronosGroup/OpenCL-ICD-Loader/pull/21
Petr Kraus [Tue, 8 Aug 2017 19:46:02 +0000 (21:46 +0200)]
layers: PR1950, Update subresource range VUIDs
With updated test names in database.
Change-Id: Ie6cb2dfa9fa84de2dd0dea645249fe03c6780eba
Tobin Ehlis [Wed, 9 Aug 2017 15:10:37 +0000 (09:10 -0600)]
layers:Fix consecutive binding updates
Fixes #1992
When we're wrapping a descriptor update for consecutive bindings, fix
code so that index into update array consistently increases.
Bas Nieuwenhuizen [Tue, 25 Jul 2017 21:58:20 +0000 (23:58 +0200)]
build: PR1972, Install vk_layer_dispatch_table.h hdr
vk_layer.h is installed and includes it. Also, vk_layer.h is needed
to write third party layers, so I don't think not installing vk_layer.h
is an option.
Change-Id: I3e34d8484fdc5092edff3bab72991303a4aeb2c7
Chris Forbes [Wed, 9 Aug 2017 00:35:51 +0000 (17:35 -0700)]
layers: Untangle side effects in CmdWaitEvents
Tony Barbour [Tue, 8 Aug 2017 18:51:33 +0000 (12:51 -0600)]
layers: Fix CmdPushDescriptorSet object tracker
Ignore the dstSet field of VkWriteDescriptorSet as indicated
by the spec
Change-Id: I28ca6ea3059f5528bdf369954e1621ef670e0d54
Mike Weiblen [Mon, 7 Aug 2017 18:02:27 +0000 (12:02 -0600)]
Update commit IDs: glslang,tools
Change-Id: Ie24b136b2df3718ba1c9ee493d69716304795a11
Mike Schuchardt [Mon, 7 Aug 2017 19:11:09 +0000 (13:11 -0600)]
demos: Revert AppDevInitFormat changes
Calling vkGetPhysicalDeviceFormatProperties with extension formats is
not valid and causes crashes on some drivers. Revert the list of
VkFormats to the original range.
Change-Id: I2b7f0bd5bb49a66cd073216e93e3bba35c67ab98
Cort [Sat, 5 Aug 2017 23:32:14 +0000 (16:32 -0700)]
layers: Fix swapchain extent check
This fixes a regression introduced -- by me :( -- in commit
583b0c41dfd0876d0481920f2e6d8d87433bc1d7. The swapchain's
imageExtent must always be within the surface's min/max extent,
regardless of the surface's current extent.
Mark Lobodzinski [Wed, 2 Aug 2017 16:45:24 +0000 (10:45 -0600)]
layers: Fix incorrect VUID for negative viewport ht
Layers used the wrong VUID for the checks for negative viewport
height if the extensions were not enabled.
Fixed existing test, added a new test, and updated the database,
and removed special case from validation_stats script.
Change-Id: Ia165e6245990a4fabb3745102b345a7b4f1b0202
Chris Forbes [Wed, 2 Aug 2017 00:19:52 +0000 (17:19 -0700)]
layers: Don't do bogus transitions in invalidateCommandBuffers
Total nonsense like:
RECORDING -> INVALID_INCOMPLETE -> INVALID_COMPLETE
was possible when there were two invalidations.
Mark Lobodzinski [Tue, 1 Aug 2017 15:15:06 +0000 (09:15 -0600)]
header: Update to version 1.0.57 of the vulkan hdr
- updated vulkan.h
- updated vk.xml
- updated cgenerator.py
- updated Win/Lin json files
- updated and fixed vk_validation_error_database.h
- updated vk_validation_error_messages.h
- updated vulkan.hpp
Change-Id: Idebc490660833daac43d234db44131e9bf2b910b
Mike Weiblen [Fri, 28 Jul 2017 19:18:39 +0000 (13:18 -0600)]
external: Update commit IDs: glslang,tools,header
Update external reference commit IDs for Desktop and Android
Change-Id: I0b79c9e030e06479d1f07d4d3372dcc96bfa2f0e
Tobin Ehlis [Fri, 28 Jul 2017 18:11:30 +0000 (12:11 -0600)]
layers:Rename lambda function container
Change name to queue_submit_functions to reflect the fact that validate
functions in this container are executed at QueueSubmit() time.
Tobin Ehlis [Fri, 28 Jul 2017 17:56:04 +0000 (11:56 -0600)]
layers:Pass framebuffer into barrier lambda
Pass framebuffer into image barrier validation lambda so that secondary
CB state doesn't have to be updated in CmdExecuteCommands. Just pass in
framebuffer from primary CB instead.
Update secondary CB lambda container name to reflect the fact that those
functions are executed at CmdExecuteCommands() time.
Tobin Ehlis [Thu, 27 Jul 2017 17:08:00 +0000 (11:08 -0600)]
layers:Delay barrier validation for secondary CB
When a secondary command buffer doesn't have a framebuffer, queue up
any renderPass barrier validation until submit time when we know we'll
have a framebuffer bound.
Added a separate vector of validation functions that are added to
secondary command buffer for this case and then executed at
CmdExecuteCommands() time.
Migrated the image validation that needs to be delayed to its own
function. This makes it easy to add to the delayed function array and
capture a copy of the image barrier that needs to be validated.
In CmdExecuteCommands() when validation runs inherit the activeFB
from the primaryCB into the secondary CB.
Tony Barbour [Fri, 28 Jul 2017 15:08:26 +0000 (09:08 -0600)]
demos: Fix cube to use correct pipeline stage for barrier
Change-Id: Ia85e0acc67694d859077044ad24b13b0ad834811
Tony Barbour [Fri, 28 Jul 2017 16:08:24 +0000 (10:08 -0600)]
tests: Update VALIDATION_ERROR_1b800942
Change-Id: I14651b387848d3d1cc8bd3f5e0051ba8dce12e66
Tobin Ehlis [Mon, 24 Jul 2017 20:58:09 +0000 (14:58 -0600)]
layers:Verify dstAccessMask supported by stageMask
This is VALIDATION_ERROR_1b800942.
Verify that barrier drcAccessMask is supported by drcStageMask.
Tobin Ehlis [Mon, 24 Jul 2017 20:34:24 +0000 (14:34 -0600)]
tests:Test srcAccessMask/srcStageMask conflict
New test case for VALIDATION_ERROR_1b800940.
Create srcAccessMask conflict with srcStageMask in memory barrier.
Fix a bunch of existing test cases that were triggering this new
check b/c srcStageMask conflicted w/ barrier srcAccessMask.
Tobin Ehlis [Mon, 24 Jul 2017 20:32:51 +0000 (14:32 -0600)]
layers:Verify accessMask supported by stageMask
This is VALIDATION_ERROR_1b800940.
Verify that barrier srcAccessMask is supported by srcStageMask.
Tobin Ehlis [Mon, 24 Jul 2017 18:57:52 +0000 (12:57 -0600)]
tests:Test queueFamilyIndex for image barrier
Add test for VALIDATION_ERROR_1b80093c to RenderPassBarrierConflicts.
For image barrier in renderPass, src&dstQueueFamilyIndex must be
VK_QUEUE_FAMILY_IGNORED.
Tobin Ehlis [Mon, 24 Jul 2017 17:35:57 +0000 (11:35 -0600)]
layers:Verify image barrier queueFamilyIndices
This is VALIDATION_ERROR_1b80093c.
For image barrier in renderPass both src & dst queueFamilyIndex members
must be VK_QUEUE_FAMILY_IGNORED.
Mark Lobodzinski [Thu, 27 Jul 2017 18:09:08 +0000 (12:09 -0600)]
scripts: Exclude disable extension enums
Including these enums hosed up the private builds.
Change-Id: I74fcb628171dfd70e7bce03e7ede35d4d22a75b5
Mark Lobodzinski [Wed, 26 Jul 2017 20:16:21 +0000 (14:16 -0600)]
layers: Add VUID for LogicOp validation check
Change-Id: I19f10ee8e45af336290b36107db8bfe1c41c3a88
Mark Lobodzinski [Tue, 25 Jul 2017 21:32:11 +0000 (15:32 -0600)]
layers: Remove PV dead code, fixup comments
Change-Id: I94804f0b994618982afcb344dc88b92a9bee3336
Mark Lobodzinski [Tue, 25 Jul 2017 21:29:57 +0000 (15:29 -0600)]
scripts: Generate PV calls to ranged_enum_array fcn
Change-Id: I106fe73c2199d1b4d8aa090bd22bb79884637d58
Mark Lobodzinski [Tue, 25 Jul 2017 21:29:36 +0000 (15:29 -0600)]
layers: Add new ranged_enum_array val routine
Change-Id: I2b78d90bd248a6800f719ef89c534140cb217ad8
Mark Lobodzinski [Tue, 25 Jul 2017 21:10:29 +0000 (15:10 -0600)]
scripts: Generate calls to new enum PV function
Change-Id: I9692f1b2101d6cc1eef3bf55582dbf7980c4e8d2
Mark Lobodzinski [Tue, 25 Jul 2017 20:49:06 +0000 (14:49 -0600)]
layers: Add new PV ranged enum validation function
Uses new enum lists.
Change-Id: I24629770e1018f5938fa82d2a3da8eb1cd716de7
Mark Lobodzinski [Tue, 25 Jul 2017 20:29:42 +0000 (14:29 -0600)]
scripts: Generate param_validation valid enum lists
Change-Id: I0dd6bf95bf54baa9a71f41a482bc52527944aea8
Mark Lobodzinski [Mon, 24 Jul 2017 22:15:37 +0000 (16:15 -0600)]
layers: GH1924, Improve unavailable feature msg
Modified the unavailable requested feature error message to print the
feature name instead of just an index.
Change-Id: Idcb66921fc592014330dce6946631984d85cd866
Mark Lobodzinski [Mon, 24 Jul 2017 22:14:16 +0000 (16:14 -0600)]
scripts: Add PDevFeature index print helper
In the Enum string helper header, tack on a routine to convert an
index into a VkPhysicalDeviceFeatures structure into its
corresponding feature string.
Change-Id: I8fbfb6fcbfa63361a851ffc93ffd832696050d51
Mike Schuchardt [Sun, 23 Jul 2017 18:47:47 +0000 (12:47 -0600)]
scripts: Switch codegen to use structextends
Replace all usages of the deprecated validextensionstructs member
attribute with the registry.validextensionstructs dict. Internally the
registry builds this extension dictionary using the new structextends
type attribute.
Change-Id: I072ff707bfdfa1f576266291e4196837da526287
Mark Lobodzinski [Mon, 24 Jul 2017 17:05:40 +0000 (11:05 -0600)]
header: Update to version 1.0.56 of the Vulkan hdr
- updated vulkan.h
- updated vk.xml
- updated Win/Lin .json files
- updated vk_validation_error_database.h
- updated vk_validation_error_messages.h
- updated vulkan.hpp
Change-Id: Ibf64c8a1760743b3118794b0ef5f6d34b108bbbc
Tobin Ehlis [Fri, 21 Jul 2017 20:12:23 +0000 (14:12 -0600)]
layers:Refactor image barrier validation
Move image barrier validation within a renderPass into its own function
in order to break up existing code a bit. Add a check to make sure
framebuffer is valid before attempting to use FB state.
Tobin Ehlis [Fri, 21 Jul 2017 19:45:31 +0000 (13:45 -0600)]
layers:Minor refactor for clarity
Add comment and move VkSubpassDescription local variable assignment to
clarify what's going on.
Tobin Ehlis [Fri, 21 Jul 2017 16:17:07 +0000 (10:17 -0600)]
tests:Add image mis-matched layout test
Test for VALIDATION_ERROR_1b800938.
Verify check fires when subpass attachment layout does not match image
barrier layout.
Tobin Ehlis [Fri, 21 Jul 2017 16:16:08 +0000 (10:16 -0600)]
layers:Refactor barrier check order
Do the renderPass barrier check first and early return to avoid
potential redundant errors from remaining layout and barrier checks.
Tobin Ehlis [Thu, 20 Jul 2017 23:56:48 +0000 (17:56 -0600)]
layers:Check image barrier layout vs attachment
This is VALIDATION_ERROR_1b800938.
Make sure that the attachment references by current subpass description
has a layout that matches image barrier layout.
Tobin Ehlis [Thu, 20 Jul 2017 23:47:24 +0000 (17:47 -0600)]
layers:Check barrier image vs subpass attachments
This is the second half of VALIDATION_ERROR_1b800936, for which the
first half was already implemented. Make sure that VkSubpassDescription
for current subpass references the attachment that has an image
matching the image barrier.
Tobin Ehlis [Thu, 20 Jul 2017 23:44:50 +0000 (17:44 -0600)]
layers:Only deref active subpass once
Grab active subpass once initially to avoid repeated defers of cb_state