Matthias Springer [Wed, 4 Jan 2023 09:56:43 +0000 (10:56 +0100)]
[mlir][affine][NFC] Extract core functionality of `canonicalizeMinMaxOp`
Move code from SCF to Affine: Add a new helper function `simplifyConstrainedMinMaxOp` to Affine/Analysis/Utils.h. `canonicalizeMinMaxOp` was originally designed for loop peeling, but it is not SCF-specific and can be used to simplify any affine.min/max ops.
Various functions in SCF/Transforms are simplified by dropping unnecessary parameters.
Differential Revision: https://reviews.llvm.org/D140962
Tom Eccles [Fri, 23 Dec 2022 21:03:14 +0000 (21:03 +0000)]
[mlir] Allow overriding AbstractDenseDataFlowAnalysis::visitOperation
AbstractDenseDataFlowAnalysis::visitOperation controls how the dataflow
analysis proceeds around control flow. In particular, conservative
assumptions are made about call operations which can prevent some
analysis from succeeding.
The motivating case for this change is https://reviews.llvm.org/D140415,
for which it is correct and necessary for the lattice to be preserved
after call operations.
Some renaming was necessary to avoid confusion with
DenseDataFlowAnalysis::visitOperation.
AbstractDenseDataFlowAnalysis::visitRegionBranchOperation and
DenseDataFlowAnalysis::visitOperationImpl are also made protected
to allow implementation of AbstractDenseDataFlowAnalysis::visitOperation,
although I did not need these to be virtual.
Differential Revision: https://reviews.llvm.org/D140879
chenglin.bi [Wed, 4 Jan 2023 09:49:40 +0000 (17:49 +0800)]
[InstCombine] add more tests into select-factorize; NFC
Haojian Wu [Mon, 2 Jan 2023 11:04:49 +0000 (12:04 +0100)]
[clang-tidy] Don't emit misc-unused-using-decl warnings for header files.
Using decls in header files are special, usually as part of the
public API, the check should not emit warnings on these.
The check already detects unused using-decls which are in the current main
file, but if the main file happens to be a header file, we still
emit warnings, this patch suppresses that.
Differential Revision: https://reviews.llvm.org/D140894
chenglin.bi [Wed, 4 Jan 2023 08:31:42 +0000 (16:31 +0800)]
[Instcombine] Regenerate tests for logical-select; NFC
Vitaly Buka [Wed, 4 Jan 2023 03:30:43 +0000 (19:30 -0800)]
[libcxx] Fix build with GLIBC
Reviewed By: #libc, philnik
Differential Revision: https://reviews.llvm.org/D140946
serge-sans-paille [Wed, 4 Jan 2023 07:14:42 +0000 (08:14 +0100)]
Move from llvm::makeArrayRef to ArrayRef deduction guides
Since we're now requiring C++17, Let's get rid of makeXXX functions like
makeArrayRef, and use deduction guides instead.
This is a first step: Introduce the deduction guide. Following steps
will be a) use them and b) deprecate makeArrayRef.
Apart from codebase modernization, there isn't much benefit from that
move, but I can still mention that it would slightly (probably
negligibly) decrease the number of symbols / debug info, as deduction
guides don't generate new code.
Differential Revision: https://reviews.llvm.org/D140896
Yeting Kuo [Tue, 20 Dec 2022 05:24:01 +0000 (13:24 +0800)]
[VP][RISCV] Add vp.ctlz/cttz and RISC-V support.
The patch also adds expandVPCTLZ and expandVPCTTZ to expand vp.ctlz/cttz nodes
and the cost model of vp.ctlz/cttz.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D140370
Xiaodong Liu [Wed, 4 Jan 2023 06:10:43 +0000 (14:10 +0800)]
[LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions
Instruction formats:
`movgr2fcsr fcsr, rj`
`movfcsr2gr rd, fcsr`
MOVGR2FCSR modifies the value of the software writable field
corresponding to the FCSR (floating-point control and status
register) `fcsr` according to the value of the lower 32 bits of
the GR (general purpose register) `rj`.
MOVFCSR2GR sign extends the 32-bit value of the FCSR `fcsr`
and writes it into the GR `rd`.
Add "i32 @llvm.loongarch.movfcsr2gr(i32)" intrinsic for MOVFCSR2GR
instruction. The argument is FCSR register number. The return value
is the value in the FCSR.
Add "void @llvm.loongarch.movgr2fcsr(i32, i32)" intrinsic for MOVGR2FCSR
instruction. The first argument is the FCSR number, the second argument
is the value in GR.
Reviewed By: SixWeining, xen0n
Differential Revision: https://reviews.llvm.org/D140685
Amaury Séchet [Wed, 4 Jan 2023 02:05:30 +0000 (02:05 +0000)]
[NFC] Autogenerate test/Transforms/InstCombine/fls.ll
Amir Ayupov [Wed, 4 Jan 2023 01:39:55 +0000 (17:39 -0800)]
[BOLT][CMake] Add merge-fdata to bolt component
Build and install `merge-fdata` tool as part of `bolt` component:
```
$ ninja bolt
# builds llvm-bolt, perf2bolt and merge-fdata
$ cmake --install . --component bolt --prefix $HOME/test-install-bolt
-- Install configuration: "Release"
-- Install configuration: "Release"
-- Installing: /home/aaupov/test-install-bolt/lib/libbolt_rt_instr.a
-- Installing: /home/aaupov/test-install-bolt/lib/libbolt_rt_hugify.a
-- Installing: /home/aaupov/test-install-bolt/lib/libbolt_rt_instr_osx.a
-- Installing: /home/aaupov/test-install-bolt/bin/llvm-bolt
-- Installing: /home/aaupov/test-install-bolt/bin/perf2bolt
-- Installing: /home/aaupov/test-install-bolt/bin/llvm-boltdiff
-- Installing: /home/aaupov/test-install-bolt/bin/merge-fdata
```
Fixes #57249.
Reviewed By: #bolt, rafauler
Differential Revision: https://reviews.llvm.org/D139972
Amir Ayupov [Wed, 4 Jan 2023 01:38:52 +0000 (17:38 -0800)]
[BOLT][Docs] Add Sphinx documentation
Add stub Sphinx documentation, with configuration copy-pasted from lld and
index page converted from bolt/README.md.
Reviewed By: #bolt, rafauler
Differential Revision: https://reviews.llvm.org/D140156
Amir Ayupov [Wed, 4 Jan 2023 01:31:44 +0000 (17:31 -0800)]
[BOLT][NFC] Use llvm::reverse
Use llvm::reverse instead of `for (auto I = rbegin(), E = rend(); I != E; ++I)`
Reviewed By: #bolt, rafauler
Differential Revision: https://reviews.llvm.org/D140516
Matt Arsenault [Mon, 19 Dec 2022 16:23:27 +0000 (11:23 -0500)]
CodeGen: Clean up some tests with broken "strictfp" attribute
Johannes Doerfert [Wed, 28 Dec 2022 06:05:44 +0000 (22:05 -0800)]
[OpenMP][AMDGPU][NFC] Improve error message for errors
Johannes Doerfert [Wed, 28 Dec 2022 06:03:52 +0000 (22:03 -0800)]
[OpenMP][JIT][FIX] Create the default O0 pipeline for -O0
Johannes Doerfert [Wed, 28 Dec 2022 04:43:10 +0000 (20:43 -0800)]
[OpenMP] Unify "exec_mode" query code and default to SPMD
Defaulting to Generic mode doesn't make much sense as the kernel needs
to be prepared for it. SPMD mode is the "native" execution, e.g., for
"bare" kernels. It also is the execution method for constructors and
destructors (as we might otherwise throw an extra warp onto them).
Differential Revision: https://reviews.llvm.org/D140718
Matt Arsenault [Wed, 7 Dec 2022 18:20:39 +0000 (13:20 -0500)]
clang: Don't emit "frame-pointer"="none"
This is the default behavior and cuts down on attribute spam.
Probably should also do something to consolidate the option spellings;
printing and parsing it is repeated in at least 3 different places.
In the OpenMP tests, I had to manually delete some metadata check
lines update_cc_test_checks was inserting that included the local
build revision.
Craig Topper [Wed, 4 Jan 2023 00:25:08 +0000 (16:25 -0800)]
[SelectionDAG][GlobalISel] Move even divisor optimization for division by constant into UnsignedDivideUsingMagic implementation. NFC
I've added a bool to UnsignedDivideUsingMagic so we can continue
testing it in the unit test with and without this optimization in
the unit test.
This is a step towards supporting "uncooperative" odd divisors.
See https://ridiculousfish.com/blog/posts/labor-of-division-episode-iii.html
Reviewed By: lebedev.ri
Differential Revision: https://reviews.llvm.org/D140924
Tony Tye [Sat, 24 Dec 2022 01:04:30 +0000 (01:04 +0000)]
[AMDGPU][NFC] DWARF extensions minor update
1. Minor editorial corrections.
2. Allow different call frames to be associated with different target
architectures in a single thread.
Reviewed By: scott.linder
Differential Revision: https://reviews.llvm.org/D140646
Fangrui Song [Tue, 3 Jan 2023 23:48:17 +0000 (15:48 -0800)]
[ELF] Improve --obj-path tests
Combine two ThinLTO --obj-path tests and improve checks.
Add a --obj-path test for regular LTO.
Fangrui Song [Tue, 3 Jan 2023 23:06:43 +0000 (15:06 -0800)]
[ELF] Simplify --thinlto-index-only tests
James Y Knight [Fri, 16 Dec 2022 18:48:39 +0000 (13:48 -0500)]
[AMDGPU] Fix useDeprecatedPositionallyEncodedOperands errors.
This is a follow-on to https://reviews.llvm.org/D134073.
The errors in the R600 half were fixed previously in
https://reviews.llvm.org/D134078. Originally, I thought that the fixes
to the AMDGPU half would be tricky, but upon taking another look,
there were only a couple minor issues that needed fixing:
1. Previously, buffer load instructions (`BUFFER_LOAD_*_LDS_*`) were
populating the `vdata` field in the instruction from the `swz`
operand. This was incorrect, but harmless, as when the LDS option is
set, the instruction does not use the vdata field.
2. The `BUFFER_STORE_LDS_DWORD_gfx90a` instruction was populating
`acc` from the `swz` operand, because `acc` was set to `?`. (I believe
that the intent here was to leave the instruction bit as an "unknown
value", but you can't do that except by setting the bits on `Inst`
directly). Also harmless, for the same reason.
Differential Revision: https://reviews.llvm.org/D140918
Philip Reames [Tue, 3 Jan 2023 22:34:28 +0000 (14:34 -0800)]
[RISCV][InsertVSETVLI] Split out demanded property for zero/non-zero of VL
The scalar move instructions (vmv.s.x, and fvmv.s.f) depend solely on whether the VL is 0 or non-zero. By tracking the fact we only demand the zeroness and not the whole VL value, we can allow changing VL over a scalar move. This helps to eliminate vsetvli toggles.
Differential Revision: https://reviews.llvm.org/D140157
V Donaldson [Tue, 3 Jan 2023 18:31:30 +0000 (10:31 -0800)]
[flang] Control flow graph issues
Address several issues involving control flow graph generation and
structured code ops.
- Fix a problem with constructs nested inside unstructured selection
constructs. This is a general problem involving branches that are
implied rather than explicit. It is addressed in the generic genFIR
"wrapper" function that calls individual statement-specific genFIR calls.
- The previous fix requires some compensating changes in IF and DO
construct code lowering.
- Streamline the code to generate explicit DO loop variable updates.
- Fix a problem with the individual detailed genFIR calls made in the
genFIR(SelectTypeConstruct) call.
- Modify control flow graph generation to support the insertion of
deallocation and finalization code when lowering most END <construct>
statements.
Amir Ayupov [Thu, 22 Dec 2022 00:31:26 +0000 (16:31 -0800)]
[BOLT] Check no-LBR samples in mayHaveProfileData
No-LBR mode wasn't tested and slipped when mayHaveProfileData was added for
Lite mode. This enables processing of profiles collected without LBR and
converted with `perf2bolt -nl` option.
Test Plan:
bin/llvm-lit -a tools/bolt/test/X86/nolbr.s
https://github.com/rafaelauler/bolt-tests/pull/20
Reviewed By: #bolt, rafauler
Differential Revision: https://reviews.llvm.org/D140256
Rob Suderman [Tue, 3 Jan 2023 22:14:43 +0000 (14:14 -0800)]
[mlir][tosa] Add broadcasting case for tosa.resize to linalg implementation
When lowering tosa.resize it is possible there is an unary input dimension.
Lowering to a new tosa.resize and explicit broadcast simplifies the
tosa.resize operation to avoid recomputing the identical broadcasted values.
This change reworks the broadcast optimization reuse the tosa.resize generic
implementation.
Reviewed By: jpienaar
Differential Revision: https://reviews.llvm.org/D139963
Owen Anderson [Sat, 31 Dec 2022 06:12:20 +0000 (23:12 -0700)]
[ValueTracking] Improve ComputeNumSignBits to handle Trunc
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D140796
Philip Reames [Tue, 3 Jan 2023 22:22:38 +0000 (14:22 -0800)]
[RISCV] Minor type fix [nfc]
Philip Reames [Tue, 3 Jan 2023 22:17:33 +0000 (14:17 -0800)]
[RISCV][InsertVSETVLI] Rewrite scalar insert forward rule in terms of demanded fields
This is mostly geared at consolidating logic into one form to reduce code duplication, but also has the effect of being a slight generalization. Since these operations aren't masked, we can ignore the mask policy bit when deciding on compatibility. The previous code was overly strict in checking that both policy bits matched.
Note: There's a slight difference from the reviewed version. The reviewed version was based on a local revision which included the isCompatible change to only check AVL if VL is used. I apparently never landed that change, and while functional, the functional change isn't visible without this one. I chose to role the extra change into this patch.
Differential Revision: https://reviews.llvm.org/D140147
LLVM GN Syncbot [Tue, 3 Jan 2023 22:08:13 +0000 (22:08 +0000)]
[gn build] Port
a455c91601a8
Matt Arsenault [Mon, 2 Jan 2023 02:29:20 +0000 (21:29 -0500)]
llvm-reduce: Add reduction for invokes
Main thing I was unsure about was to whether try to delete the now
dead landing blocks, or leave that for the unreachable block reduction.
Personality function is not reduced, but that should be a separate
reduction on the function.
Fixes #58815
Matt Arsenault [Sun, 1 Jan 2023 23:07:07 +0000 (18:07 -0500)]
llvm-reduce: Fix invalid reductions for exceptions, tokens and swifterror
Copies the same special cases that bugpoint uses. Technically the
token condition is stricter than what the verifier enforces.
Part 1 of #58815
Matt Arsenault [Tue, 3 Jan 2023 21:59:32 +0000 (16:59 -0500)]
llvm-reduce: Speculative fix for windows build bot
I'm guessing grep wasn't matching the backtick in the message for some
reason.
Matt Arsenault [Tue, 3 Jan 2023 21:44:37 +0000 (16:44 -0500)]
llvm-reduce: Remove leftover comment
Yitzhak Mandelbaum [Tue, 3 Jan 2023 20:50:01 +0000 (20:50 +0000)]
[clang][dataflow] Fix bug in optional-checker's handling of nullopt constructor.
Currently, the checker only recognizes the nullopt constructor when it is called
without sugar, resulting in a crash in the (rare) case where it has been wrapped
in sugar. This relaxes the constraint by checking the constructor decl directly
(which always contains the same, desugared form) rather than the construct
expression (where the spelling depends on the context).
Differential Revision: https://reviews.llvm.org/D140921
Philip Reames [Tue, 3 Jan 2023 21:56:23 +0000 (13:56 -0800)]
[RISCV][InsertVSETVLI] Add debug output capability to DemandedFields [nfc]
JP Lehr [Thu, 22 Dec 2022 23:28:19 +0000 (18:28 -0500)]
[OpenMP] Solve potential VERSION script error w/ OMPT symbols
The patch adds the symbols if OMPT_SUPPORT is not defined.
Github issue: https://github.com/llvm/llvm-project/issues/59660
Reviewed By: jhuber6
Differential Revision: https://reviews.llvm.org/D140591
Matt Arsenault [Sun, 1 Jan 2023 15:34:56 +0000 (10:34 -0500)]
OpenMPOpt: Fix null dereference on missing declaration cache
Found by llvm-reduce fuzzing.
Matt Arsenault [Sun, 1 Jan 2023 19:27:15 +0000 (14:27 -0500)]
OpenMPOpt: Fix using wrong address space for alloca
Using the function's address space makes no sense. Copied from the
existing test, with more addrspace variation. Could just replace the
existing one with this version if it's redundant.
Fangrui Song [Tue, 3 Jan 2023 21:18:46 +0000 (13:18 -0800)]
[test] Fix #if
Fangrui Song [Tue, 3 Jan 2023 21:17:39 +0000 (13:17 -0800)]
[dfsan] Support Linux AArch64
compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake:ALL_DFSAN_SUPPORTED_ARCH
allows AArch64 but currently the instrumentation will crash.
Port Linux AArch64 memory mappings from msan but use
SizeClassAllocator64 for a slightly more efficient allocator (used by
asan/lsan). Change dfsan/lit.cfg.py to allow Linux aarch64. All tests
should pass.
* dfsan/origin_invalid.c uses x86_64 assembly. Just make it x86_64 specific.
* dfsan/interceptors.c our mallinfo interceptor takes an argument
instead of returning a struct. This does not work on AArch64 which
uses different registers for the two function types. Disable AArch64
as msan/Linux/mallinfo.cpp does.
Reviewed By: #sanitizers, vitalybuka
Differential Revision: https://reviews.llvm.org/D140770
Johannes Doerfert [Thu, 22 Dec 2022 01:03:35 +0000 (17:03 -0800)]
[Attributor][FIX] Treat undef as zero offset in AAPointerInfoFloating
Matt Arsenault [Fri, 9 Dec 2022 16:02:49 +0000 (11:02 -0500)]
llvm-reduce: Refine missing argument behavior
We required the test and input arguments for --print-delta-passes
which is unhelpful. Also, start printing the help output if no
arguments were supplied.
It looks like there's more sophisticated ways to accomplish this with
the opt library, but it was less work to manually emit these errors.
Matt Arsenault [Tue, 3 Jan 2023 13:00:03 +0000 (08:00 -0500)]
llvm-reduce: Don't remove strictfp
The verifier should fail if constrained intrinsics are used in
functions with strictfp, but that patch hasn't been pushed yet.
Ideally we would be able to analyze the function body to see if any
constrained intrinsics were used, but we seem to be missing a utility
function to check for any constrained ops.
Matt Arsenault [Mon, 2 Jan 2023 15:55:59 +0000 (10:55 -0500)]
llvm-reduce: Avoid invalid attribute reduction on optnone functions
We have this ridiculous restriction that optnone requires noinline,
so the pair needs to be removed if we want to remove noinline.
Craig Topper [Tue, 3 Jan 2023 20:24:14 +0000 (12:24 -0800)]
Recommit "[M68k] Regenerate divide-by-constant.ll. NFC"
Division algorithm was improved in D140750.
Fixes #59802.
Craig Topper [Tue, 3 Jan 2023 20:23:53 +0000 (12:23 -0800)]
Revert "[M68k] Regenerate divide-by-constant.ll. NFC"
This reverts commit
0277f849c36ab6fe122b4fa1ae739e82869b5613.
I pasted the wrong bug number.
Craig Topper [Tue, 3 Jan 2023 20:17:46 +0000 (12:17 -0800)]
[M68k] Regenerate divide-by-constant.ll. NFC
Division algorithm was improved by D140750.
Fixes #59791.
Johannes Doerfert [Wed, 28 Dec 2022 19:19:27 +0000 (11:19 -0800)]
[OpenMP][2/2] Make device functions have hidden visibility
Similar to https://reviews.llvm.org/D136111, this time for class
methods.
D136111 summary:
In OpenMP target offloading an in other offloading languages, we
maintain a difference between device functions and kernel functions.
Kernel functions must be visible to the host and act as the entry point
to the target device. Device functions however cannot be called directly
by the host and must be called by a kernel function. Currently, we make
all definitions on the device protected by default. Because device
functions cannot be called or used by the host they should have hidden
visibility. This allows for the definitions to be better optimized via
LTO or other passes.
This patch marks every device class methods in the AST as having hidden
visibility. The kernel function is generated later at code-gen and we
set its visibility explicitly so it should not be affected. This
prevents the user from overriding the visibility, but since the user
can't do anything with these symbols anyway there is no point exporting
them right now.
Corentin Jabot [Mon, 12 Dec 2022 23:26:13 +0000 (00:26 +0100)]
[Clang] Fix a crash when encountering an ill-formed delimited UCN.
\u<DIGIT>{...} was incorrectly parsed as a valid UCN instead
of emitting a diagnostic, causing an assertion failure.
Reviewed By: tahonermann
Differential Revision: https://reviews.llvm.org/D139889
a.puschin [Tue, 3 Jan 2023 19:37:59 +0000 (11:37 -0800)]
[mlir][tosa] Fix out-of-boundaries iteration for tosa-to-linalg
When the number of elements of two shapes are not equal, a Reshape operation cannot be used to transfer one into another
Function findIntermediateShape(...) can cause out-of-boundaries operator[] call if the abovementioned condition strikes
The test-case I used now causes no error as its root-cause was an issue in Tosa dialect with padded Conv2D operations lowering which is already solved in commit
69c984b6
Reviewed By: rsuderman
Differential Revision: https://reviews.llvm.org/D140013
Dinar Temirbulatov [Tue, 3 Jan 2023 19:45:24 +0000 (19:45 +0000)]
[SLP][AArch64] Incorrectly estimated intrinsic as a function call.
We incorrectly assume intrinsic as a function call and it prevents us from
the opportunity to vectorize. On Aarch64 Cortex-A53 we think that
llvm.fmuladd.f64 is a function call which is wrong.
Differential Revision: https://reviews.llvm.org/D140392
Rob Suderman [Tue, 3 Jan 2023 19:21:25 +0000 (11:21 -0800)]
[mlir][tosa] Fix tosa.transpose_conv2d decompositions for new version
The decomposition was no longer correct for transpose_conv2d to conv2d
after the updated TOSA specification. Specifically the behavior for
padding was changed to refer to padding the tranpsose_conv2d instead
of referencing the conv applied to the inverse transform.
Test was validated using the TOSA conformance tests.
Reviewed By: NatashaKnk
Differential Revision: https://reviews.llvm.org/D140503
Blue Gaston [Thu, 22 Dec 2022 19:06:59 +0000 (14:06 -0500)]
[Sanitizers] Fix procmap tests for apple arm64
As part of effort to enable sanitizer common unit tests on arm64 apple devices.
Add kModuleArchARM64 as expected Arch
Differential Revision: https://reviews.llvm.org/D140567
William Huang [Wed, 28 Dec 2022 21:26:16 +0000 (21:26 +0000)]
[llvm-profdata] Remove unnecessary file size check
Unsure why profile reader checks profile size to be less than 4 GB. This breaks builds using a very large profile.
The limit is not seen anywhere else, so I am not sure why is it there in the first place.
Reviewed By: davidxl
Differential Revision: https://reviews.llvm.org/D140741
Rob Suderman [Tue, 3 Jan 2023 19:06:04 +0000 (11:06 -0800)]
[mlir][tosa] Canonicalize tosa.transpose to tosa.reshape
Added tosa.transpose canonicalization for case where a tosa.transpose is
equivalent to a tosa.reshape. This occurs when the permutation does not
permutate non-unary dimensions.
Reviewed By: NatashaKnk
Differential Revision: https://reviews.llvm.org/D140356
Qiao Zhang [Tue, 3 Jan 2023 19:06:30 +0000 (19:06 +0000)]
[mlir][python] Expose fp8 types with pybind.
Expose fp8 types with pybind.
Reviewed By: stellaraccident
Differential Revision: https://reviews.llvm.org/D140746
Luke Lau [Tue, 3 Jan 2023 19:06:14 +0000 (19:06 +0000)]
[WebAssembly][NFC] Add test case for {u,s}itofp on SIMD types
These test cases should be updated in a following patch once fixed
Part of https://github.com/llvm/llvm-project/issues/57182
v1nh1shungry [Tue, 3 Jan 2023 08:12:39 +0000 (03:12 -0500)]
[clangd] show underlying type in type hint for `decltype(expr)`
Reviewed By: nridge
Differential Revision: https://reviews.llvm.org/D140814
Jacques Pienaar [Tue, 3 Jan 2023 18:55:07 +0000 (10:55 -0800)]
[mlir][shape] Fix overridden arguments and fit to 80 col (NFC)
Noticed one of the ops had its arguments overridden (two consecutive let
statements) so fixed that and then went through fitting to file to 80
col/making document paragraphs more consistent.
Chris Bieneman [Tue, 3 Jan 2023 18:32:58 +0000 (12:32 -0600)]
[DX] Improve parse error messages
This change refactors the parte parsing logic to operate on StringRefs
of the part data rather than starting from an offset and splicing down.
It also improves some of the error reporting around part layout.
Specifically, this code now reports a distinct error if there isn't
enough data in the buffer to store the part size and it reports an
error if the parts overlap.
Reviewed By: bob80905
Differential Revision: https://reviews.llvm.org/D139681
Mehdi Amini [Thu, 22 Dec 2022 22:30:51 +0000 (22:30 +0000)]
Apply clang-tidy fixes for readability-identifier-naming in TestBackwardDataFlowAnalysis.cpp (NFC)
Mehdi Amini [Thu, 22 Dec 2022 22:30:16 +0000 (22:30 +0000)]
Apply clang-tidy fixes for llvm-qualified-auto in TestBackwardDataFlowAnalysis.cpp (NFC)
Craig Topper [Tue, 3 Jan 2023 18:46:26 +0000 (10:46 -0800)]
[RISCV] Remove some non-Zfh instructions from rv64zfh-invalid.s. NFC
Doru Bercea [Tue, 3 Jan 2023 18:19:59 +0000 (12:19 -0600)]
Fix initializer name.
Dani Ferreira Franco Moura [Fri, 30 Dec 2022 14:09:40 +0000 (14:09 +0000)]
[clang][dataflow] Treat unions as structs.
This is a straightfoward way to handle unions in dataflow analysis. Without this change, nullability verification crashes on files that contain unions.
Reviewed By: gribozavr2, ymandel
Differential Revision: https://reviews.llvm.org/D140696
Chris Bieneman [Tue, 20 Dec 2022 20:09:42 +0000 (14:09 -0600)]
[YAML] Support serializing MutableArrayRef
While the YAML format itself doesn't support fixed-sized arrays, some
of the data structures we encode in and out of YAML (specifically in
ObjectYAML) are actually fixed-sized arrays which we end up expressing
as resizable arrays.
Enabling the YAML tooling to support reading and writing from
fixed-sized arrays using MutableArrayRef can simplify some of the error
reporting and use logic for cases where the sizes of arrays are defined
by the target format.
Note: my SFINAE-foo isn't the best, so if there is a cleaner way to
implement the traits please advise.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D140427
Ron Lieberman [Tue, 3 Jan 2023 18:26:39 +0000 (12:26 -0600)]
Revert "[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support."
This reverts commit
135f6a1ee8b20bb392ebad2fa5aef78e3a30ddb4.
Siva Chandra Reddy [Tue, 3 Jan 2023 18:00:57 +0000 (18:00 +0000)]
[libc][NFC] Remove a constexpr marking to fix GCC build.
Alexey Bataev [Tue, 3 Jan 2023 16:44:51 +0000 (08:44 -0800)]
[SLP]Fix crash on casting non-instruction extractelement.
Need to check if the extractelement operation is an extraction before
trying to move it around the buildblocks to avoid crash on cast.
Fangrui Song [Tue, 3 Jan 2023 17:23:55 +0000 (09:23 -0800)]
[dfsan] Remove injectMetadataGlobals
D97409 added injectMetadataGlobals to differentiate the shadow mode.
This feature has been unused and is unneeded after D103745 removed fast16 mode.
Reviewed By: browneee
Differential Revision: https://reviews.llvm.org/D140797
Florian Hahn [Tue, 3 Jan 2023 17:07:43 +0000 (17:07 +0000)]
[ConstraintElim] Adjust position in LTO pipeline.
This runs ConstraintElim earlier during LTO, similar to non-LTO.
Discussed and split off from D135915.
Ron Lieberman [Tue, 3 Jan 2023 17:04:13 +0000 (11:04 -0600)]
[libomptarget][plugin-nextgen] fix for [TypePromotion] NewPM support.
Juan Manuel MARTINEZ CAAMAÑO [Tue, 3 Jan 2023 12:56:48 +0000 (13:56 +0100)]
[MCDwarf][NFC] Typo in function documentation
Matt Arsenault [Sun, 1 Jan 2023 15:52:02 +0000 (10:52 -0500)]
llvm-reduce: Reduce individual operands of named metadata
The current reduction tries all or nothing elimination of named
metadata. I noticed in one case where one of the module flags was
necessary, but it left the rest. Reduce the individual operands of
named metadata nodes that are known to behave like lists. Be
conservative since some named metadata may have more specific verifier
requirements for the operands.
Matt Arsenault [Sun, 1 Jan 2023 19:12:55 +0000 (14:12 -0500)]
OpenMPOpt: Use getFnAttributeAsParsedInteger
Jonas Devlieghere [Tue, 3 Jan 2023 16:31:05 +0000 (08:31 -0800)]
[lldb] Remove spurious `n` at the end of option error message
When migrating to `ReportError` the newline (`\n`) at the end of the
error message was meant to be removed, but instead only the backslash
got deleted.
Matt Arsenault [Tue, 3 Jan 2023 15:37:08 +0000 (10:37 -0500)]
AMDGPU: Create alloca wide load/store with explicit alignment
This was introducing transient UB by using the default alignment of a
larger vector type.
Nikita Popov [Tue, 3 Jan 2023 15:58:25 +0000 (16:58 +0100)]
[InstCombine] Convert some tests to opaque pointers (NFC)
These involved regenerating test checks. There are two significant
differences here:
1. With typed pointers we sometimes swapped gep and addrspacecast,
as a side-effect of other transforms. However, the current
direction is likely undesirable, and we should canonicalize in
the reverse direction instead (gep of ac, instead of ac of gep).
This should be done after typed pointers are removed, to avoid
conflicting transforms.
2. The "descaling" optimization isn't really compatible with
opaque pointers. This will be addressed longer-term by moving
away from type-based GEP, at which point the form with explicit
multiplications will be the canonical one.
Jonas Hahnfeld [Sun, 1 Jan 2023 18:07:32 +0000 (19:07 +0100)]
[JITLink][RISCV] Homogenize immediate handling
Name the variables based on which part of the immediate value is
extracted, as it was already done for R_RISCV_JAL. This makes it
much easier to compare the logic with the spec.
Differential Revision: https://reviews.llvm.org/D140820
Jonas Hahnfeld [Sun, 1 Jan 2023 18:07:32 +0000 (19:07 +0100)]
[JITLink][RISCV] Improve R_RISCV_JAL
Only take the lower 12 bits of RawInstr.
Differential Revision: https://reviews.llvm.org/D140820
Simon Pilgrim [Tue, 3 Jan 2023 16:10:06 +0000 (16:10 +0000)]
[APInt] Add APInt::isOneBitSet helper.
Equivalent tester for the APInt::getOneBitSet builder.
This should allow us to remove a number of cases where we're doing "Val == (1 << BitNo)" style code patterns.
Matt Arsenault [Mon, 2 Jan 2023 14:38:22 +0000 (09:38 -0500)]
llvm-reduce: Reduce prologue data
Identical to the prefix data handling, and also had broken cloning.
Matt Arsenault [Mon, 2 Jan 2023 13:51:38 +0000 (08:51 -0500)]
llvm-reduce: Reduce prefix data
Also fixes broken cloning.
Matt Arsenault [Mon, 2 Jan 2023 13:25:26 +0000 (08:25 -0500)]
llvm-reduce: Add reduction for function personalities
Fixes second piece of #58815
Matt Arsenault [Tue, 3 Jan 2023 15:03:58 +0000 (10:03 -0500)]
AMDGPU: Use cast instead of unchecked dyn_cast
Matt Arsenault [Sun, 1 Jan 2023 19:33:15 +0000 (14:33 -0500)]
OpenMPOpt: Fix introducing empty nvvm.annotations into module
luxufan [Tue, 3 Jan 2023 15:05:18 +0000 (23:05 +0800)]
[LoopFusion] Exit early if one of fusion candidate has guarded branch but the another has not
Fixes: https://github.com/llvm/llvm-project/issues/59024
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D138269
Matt Arsenault [Mon, 2 Jan 2023 21:47:08 +0000 (16:47 -0500)]
llvm-reduce: Avoid push_back for constant array
Matt Arsenault [Mon, 2 Jan 2023 19:11:47 +0000 (14:11 -0500)]
llvm-reduce: Remove unused class
Matt Arsenault [Sun, 1 Jan 2023 23:06:33 +0000 (18:06 -0500)]
llvm-reduce: Restrict set of run delta passes in invoke test
Also stop using cat
Matt Arsenault [Mon, 2 Jan 2023 03:39:08 +0000 (22:39 -0500)]
Utils: Fix comment typos
Samuel Parker [Tue, 3 Jan 2023 14:42:25 +0000 (14:42 +0000)]
[TypePromotion] NewPM support.
Differential Revision: https://reviews.llvm.org/D140893
Samuel Parker [Tue, 3 Jan 2023 15:03:41 +0000 (15:03 +0000)]
[NFC] Formatting
Format opt PassNameExact vector to make diffs, that remove strings,
cleaner.
Erich Keane [Tue, 3 Jan 2023 14:27:07 +0000 (06:27 -0800)]
Reapply "[NFC] Update CXXSTatus to show we implement CWG 2061""
This reverts commit
a5ae5afa521f75e87f9018d8361aa5a1cadc7a86.
FIx the test that didn't consider the test was running in pre-C++11
mode.
Matt Arsenault [Tue, 3 Jan 2023 14:56:19 +0000 (09:56 -0500)]
llvm-reduce: Try to fix error message test on windows
It seems the execute implementations have gone out of their way to
produce inconsistent error messages. The unix version explicitly
checks if the file exists before trying to execute. The windows
version checks if it's executable. I don't understand why they
wouldn't just try the execution and check the error code.
luxufan [Tue, 20 Dec 2022 15:03:04 +0000 (23:03 +0800)]
[CVP] Simplify SRem when constantrange abs(lhs) < abs(rhs)
For `srem x, y`, if abs(constant range of x) less than abs(constant
range of y), we can simplify it as:
`srem x, y => x` if y is guaranteed to be positive.
'srem x, y => -x' if y is guaranteed to be negative.
Differential Revision: https://reviews.llvm.org/D140405
Lucas Prates [Tue, 20 Dec 2022 14:23:28 +0000 (14:23 +0000)]
[NFC][AArch64] Adjust comments in tablegen file
Muhammad Omair Javaid [Tue, 3 Jan 2023 14:40:57 +0000 (18:40 +0400)]
[LLDB] Skip python exception unit test on AArch64/Windows
This patch marks python exception test as skipped for AArch64/Windows
platform. This is temporary to make LLDB WoA buildbot happy until a proper
fix is found.