platform/upstream/dotnet/runtime.git
5 years agoRemove create assembly name (dotnet/coreclr#24154)
Steve MacLean [Mon, 22 Apr 2019 14:07:13 +0000 (10:07 -0400)]
Remove create assembly name (dotnet/coreclr#24154)

* Remove RuntimeAssembly.CreateAssemblyName

Fixes dotnet/coreclr#24135

CreateAssemblyName was not compatible with AssemblyLoadContext isolation.

Assembly.Load(string)
Assembly.LoadWithPartialName(string)
Activator.CreateInstance(...)

* Remove unused AssemblyNameNative::Init arguments

* Temp disable corefx CreateInstanceAssemblyResolve

Commit migrated from https://github.com/dotnet/coreclr/commit/479d7edafe8035c5e8301c8ab098835614e401e7

5 years agoFix Arm64 UpperVector save/restore (dotnet/coreclr#24043)
Carol Eidt [Mon, 22 Apr 2019 11:04:59 +0000 (04:04 -0700)]
Fix Arm64 UpperVector save/restore (dotnet/coreclr#24043)

* Fix Arm64 UpperVector save/restore

Change the general handling of end-of-block restores so that we always have a RefPosition on which to allocate the register needed on Arm64.

Fix dotnet/coreclr#23885

Commit migrated from https://github.com/dotnet/coreclr/commit/a8d5756796b57d2347e31deb405db4cf1a7e055b

5 years agoFix AssemblyName cache hash and key (dotnet/coreclr#24138)
Steve MacLean [Sun, 21 Apr 2019 22:25:04 +0000 (18:25 -0400)]
Fix AssemblyName cache hash and key (dotnet/coreclr#24138)

* Add ContextualReflection LoadWithPartialName case

* Remove unnecessary MethodImplOptions.NoInlining

* Remove m_assembly warning

* Fix AssemblyName hash function

* AssemblyNative::Load fix stackMark usage

Do not use the stackMark if (ptrLoadContextBinder != NULL)

* Temporarily disable DefaultContextOverrideTPA

Test is failing due to a logic error.
Fix is pending in https://github.com/dotnet/corefx/pull/37071

Commit migrated from https://github.com/dotnet/coreclr/commit/a36bc61442d89d0b5c58b0b14e7bd3bde218f24d

5 years agoFixed link to .NET Core SDK (dotnet/coreclr#24147)
Yoh Deadfall [Sun, 21 Apr 2019 16:59:20 +0000 (19:59 +0300)]
Fixed link to .NET Core SDK (dotnet/coreclr#24147)

Commit migrated from https://github.com/dotnet/coreclr/commit/c48969221da787abaa0c6f1477ec9c864f0455d2

5 years agoUpdate BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively...
dotnet-maestro-bot [Sun, 21 Apr 2019 03:37:21 +0000 (20:37 -0700)]
Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively (master) (dotnet/coreclr#24060)

* Update BuildTools, CoreClr to preview4-03917-01, preview5-27618-71, respectively

* Fix build errors

* Disable warning with pragma and linked issue

Commit migrated from https://github.com/dotnet/coreclr/commit/472d840077d05336c812657353de5334e8fdccf0

5 years agoEventpipe Crst ordering fix (dotnet/coreclr#24101)
Sung Yoon Whang [Sat, 20 Apr 2019 22:56:19 +0000 (15:56 -0700)]
Eventpipe Crst ordering fix (dotnet/coreclr#24101)

* Adding PendingTypeLoadEntry to Crst order for EventPipeCrst

* update header file

Commit migrated from https://github.com/dotnet/coreclr/commit/9a7be98147755d337c3c5c1d8972afe32adaf797

5 years agoTighten asserts (dotnet/coreclr#24124)
Andrew Au [Sat, 20 Apr 2019 20:18:54 +0000 (13:18 -0700)]
Tighten asserts (dotnet/coreclr#24124)

Commit migrated from https://github.com/dotnet/coreclr/commit/b2693453717f43bf90c47b8a87c60d92203551b7

5 years agoMerge pull request dotnet/coreclr#24131 from sandreenko/addAReproTest
Sergey Andreenko [Sat, 20 Apr 2019 08:49:30 +0000 (01:49 -0700)]
Merge pull request dotnet/coreclr#24131 from sandreenko/addAReproTest

Add a repro test for dotnet/coreclr#24114.

Commit migrated from https://github.com/dotnet/coreclr/commit/69436a80895770a5dde4d52f05b9a72596ce2af5

5 years agoFix Timezone whitespace (dotnet/coreclr#24137)
Steve MacLean [Sat, 20 Apr 2019 06:07:42 +0000 (02:07 -0400)]
Fix Timezone whitespace (dotnet/coreclr#24137)

Commit migrated from https://github.com/dotnet/coreclr/commit/bf0600c9ce4b9de06d80b7a02b33eb174b3dd64b

5 years agoThe thread triggering finalizer shutdown events should be in an alertable state....
Aaron Robinson [Sat, 20 Apr 2019 05:11:39 +0000 (22:11 -0700)]
The thread triggering finalizer shutdown events should be in an alertable state. (dotnet/coreclr#24133)

Commit migrated from https://github.com/dotnet/coreclr/commit/324344f82a6f8221d28f9015f64be06779632468

5 years agoPulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (dotnet...
Tanner Gooding [Sat, 20 Apr 2019 03:33:46 +0000 (20:33 -0700)]
Pulling in CoreFX changes and fixing up Sse2.StoreLow to be Sse2.StoreScalar (dotnet/coreclr#24123)

* Update dependencies from https://github.com/dotnet/corefx build 20190419.5

    - Microsoft.NETCore.Platforms - 3.0.0-preview5.19219.5
    - Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19219.5

* Removing the Sse2.StoreLow(long/ulong*, ...) methods that have been replaced

* Moving the Sse2.StoreLow(long/ulong*, ...) tests to be Sse2.StoreScalar tests

* Fixing some existing usages of Sse2.StoreLow(long/ulong*, ...)

Commit migrated from https://github.com/dotnet/coreclr/commit/0f93182d5d8eeefe18ec50b1d4d32fd5d05333eb

5 years agoImplement APIs for some threading metrics (CoreCLR) (dotnet/coreclr#24113)
Koundinya Veluri [Sat, 20 Apr 2019 02:22:53 +0000 (19:22 -0700)]
Implement APIs for some threading metrics (CoreCLR) (dotnet/coreclr#24113)

Implement APIs for some threading metrics (CoreCLR)

API review: https://github.com/dotnet/corefx/issues/35500

Commit migrated from https://github.com/dotnet/coreclr/commit/0410c3e4fe54590eea34aead28f550539d814b98

5 years agoAdd a repro test.
Sergey Andreenko [Fri, 19 Apr 2019 22:42:23 +0000 (15:42 -0700)]
Add a repro test.

Commit migrated from https://github.com/dotnet/coreclr/commit/83d07828c04758a3332f611cf54b9b9b5c371fb2

5 years agoMerge pull request dotnet/coreclr#24126 from sandreenko/fixStmtBug
Sergey Andreenko [Sat, 20 Apr 2019 01:05:58 +0000 (18:05 -0700)]
Merge pull request dotnet/coreclr#24126 from sandreenko/fixStmtBug

Fix bug in impGetStructAddr.

Commit migrated from https://github.com/dotnet/coreclr/commit/924d4fcc6961a76881a42a5a4a80479352708ace

5 years agoFix `impGetStructAddr`.
Sergey Andreenko [Fri, 19 Apr 2019 22:49:39 +0000 (15:49 -0700)]
Fix `impGetStructAddr`.

Commit migrated from https://github.com/dotnet/coreclr/commit/b8916d5c8be8bd9701fa36b875f10721bde8ce16

5 years agoMerge pull request dotnet/coreclr#24127 from sandreenko/fixArmUbuntuCoreFXTesting
Sergey Andreenko [Sat, 20 Apr 2019 00:15:02 +0000 (17:15 -0700)]
Merge pull request dotnet/coreclr#24127 from sandreenko/fixArmUbuntuCoreFXTesting

Fix Arm32 Ubuntu CoreFX script.

Commit migrated from https://github.com/dotnet/coreclr/commit/26178682d96d83fdf4c09e83806836f6382ba0f1

5 years agoFix Arm32 Ubuntu CoreFX script.
Sergey Andreenko [Fri, 19 Apr 2019 23:15:34 +0000 (16:15 -0700)]
Fix Arm32 Ubuntu CoreFX script.

Commit migrated from https://github.com/dotnet/coreclr/commit/3bd49adadf30d9437efd0b592518ad64fc6c8c5c

5 years ago[master] Update dependencies from dotnet/corefx (dotnet/coreclr#24058)
dotnet-maestro[bot] [Fri, 19 Apr 2019 22:49:32 +0000 (15:49 -0700)]
[master] Update dependencies from dotnet/corefx (dotnet/coreclr#24058)

* Update dependencies from https://github.com/dotnet/corefx build 20190418.11

- Microsoft.NETCore.Platforms - 3.0.0-preview5.19218.11
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview5.19218.11

* Disable outdated test

Commit migrated from https://github.com/dotnet/coreclr/commit/6a7bf9c3af1d3d6e78d7247eef07c48c89a57112

5 years agoLarge Pages on Linux & macOS (dotnet/coreclr#24098)
Mukul Sabharwal [Fri, 19 Apr 2019 21:54:35 +0000 (14:54 -0700)]
Large Pages on Linux & macOS (dotnet/coreclr#24098)

Commit migrated from https://github.com/dotnet/coreclr/commit/4029007b7edd290c236901a246ef48ac3e9de4b6

5 years agoExclude failing tests on all platforms/architectures (dotnet/coreclr#24121)
Fadi Hanna [Fri, 19 Apr 2019 21:17:18 +0000 (14:17 -0700)]
Exclude failing tests on all platforms/architectures (dotnet/coreclr#24121)

Commit migrated from https://github.com/dotnet/coreclr/commit/533564b6f241ee733b30e71ab4f5fbb758c30aad

5 years agoFix project metadata in test (dotnet/coreclr#24119)
Fadi Hanna [Fri, 19 Apr 2019 21:10:09 +0000 (14:10 -0700)]
Fix project metadata in test (dotnet/coreclr#24119)

* Fix project metadata in test

Commit migrated from https://github.com/dotnet/coreclr/commit/76478fccdc83e6c37a82e01aef24fb2cce082378

5 years agoRemove commit triggered linux_arm ReadyToRun jobs
Russ Keldorph [Fri, 19 Apr 2019 13:35:55 +0000 (06:35 -0700)]
Remove commit triggered linux_arm ReadyToRun jobs

We don't have the capacity to run these on every commit

Commit migrated from https://github.com/dotnet/coreclr/commit/f47de43230df6d8400b22159ae06ed80cfc9cb7f

5 years agoMove CLR_ADDITIONAL_COMPILER_OPTIONS to be set after default options (dotnet/coreclr...
Andrew Wang [Fri, 19 Apr 2019 16:08:12 +0000 (09:08 -0700)]
Move CLR_ADDITIONAL_COMPILER_OPTIONS to be set after default options (dotnet/coreclr#24044)

CLR_ADDITIONAL_COMPILER_OPTIONS was set before visibility settings and
thus adding additional compiler options would be overwritten.

Commit migrated from https://github.com/dotnet/coreclr/commit/9c81799a25a83056c37e671cefeab6cefe043000

5 years agoFix build errors in Interop.Errors
Santiago Fernandez Madero [Fri, 19 Apr 2019 05:45:29 +0000 (22:45 -0700)]
Fix build errors in Interop.Errors

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/92750102f85e4fedfdc6df2e65507ccd250d1d78

5 years agoDisable warning in ValueStringBuilder.ToString
Santiago Fernandez Madero [Fri, 19 Apr 2019 01:43:28 +0000 (18:43 -0700)]
Disable warning in ValueStringBuilder.ToString

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/3459f8183a7c94bd7a7488fffe333bf3b1efbaf2

5 years agoBlock usage of default interfaces feature in COM scenarios (dotnet/coreclr#23970)
Aaron Robinson [Fri, 19 Apr 2019 16:05:23 +0000 (09:05 -0700)]
Block usage of default interfaces feature in COM scenarios (dotnet/coreclr#23970)

* Block default interface usage in COM scenarios

Add additional test cases and move some CCW functions to a more
consolidated layout.

Commit migrated from https://github.com/dotnet/coreclr/commit/df6b6f621898915e5a8ba0579c2dc8a6a6cd6ec3

5 years agoLook for IBC data outside Windows (dotnet/coreclr#24062)
Michal Strehovský [Fri, 19 Apr 2019 13:59:52 +0000 (15:59 +0200)]
Look for IBC data outside Windows (dotnet/coreclr#24062)

dotnet/coreclr#23363 added a crossplat implementation of `GetWin32Resource`, but forgot to enable places that call it.

Commit migrated from https://github.com/dotnet/coreclr/commit/4049a3e9bb28eb4ed7963adf691e2a58a982eb32

5 years agoNullable: couple of missing #nullable enable (dotnet/coreclr#24094)
Krzysztof Wicher [Fri, 19 Apr 2019 01:37:37 +0000 (18:37 -0700)]
Nullable: couple of missing #nullable enable (dotnet/coreclr#24094)

Commit migrated from https://github.com/dotnet/coreclr/commit/ea70542185ef413dd23d685958a55a9721c6e9a7

5 years agoNullable: System.Collections.Concurrent (dotnet/coreclr#24054)
Stephen Toub [Fri, 19 Apr 2019 01:36:10 +0000 (21:36 -0400)]
Nullable: System.Collections.Concurrent (dotnet/coreclr#24054)

Commit migrated from https://github.com/dotnet/coreclr/commit/c05d03ca6e4282df798e3f3dc81c05b427bd3fcb

5 years agoFix performance regression on glibc on Linux (dotnet/coreclr#24099)
Filip Navara [Fri, 19 Apr 2019 13:07:47 +0000 (15:07 +0200)]
Fix performance regression on glibc on Linux (dotnet/coreclr#24099)

Commit migrated from https://github.com/dotnet/coreclr/commit/0ca6b8978a894a1eda5322427af640b31406f750

5 years agoMove R2R-specific code to be outside FEATURE_PREJIT (dotnet/coreclr#24075)
Jan Kotas [Fri, 19 Apr 2019 02:57:17 +0000 (19:57 -0700)]
Move R2R-specific code to be outside FEATURE_PREJIT (dotnet/coreclr#24075)

This refactoring is preparation for disabling fragile NGen support in the runtime. It keeps fragile-NGen specific code under FEATURE_PREJIT and moves the code required to support R2R to be outside FEATURE_PREJIT.

The eventual goal is to compile the runtime without FEATURE_PREJIT defined to avoid fragile-NGen specific overhead.

Commit migrated from https://github.com/dotnet/coreclr/commit/b7167889bc94c084527f184f852b867b2a1c1d56

5 years agoAdding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128...
Tanner Gooding [Fri, 19 Apr 2019 00:44:56 +0000 (17:44 -0700)]
Adding Sse2.StoreScalar(long*, V128) which will replace Sse2.StoreLow(long*, V128) (dotnet/coreclr#24102)

Commit migrated from https://github.com/dotnet/coreclr/commit/4686029068df93a6a54ae27d3363ff62b1e5515b

5 years agoDon't return value types as const (dotnet/coreclr#24103)
Omair Majid [Fri, 19 Apr 2019 00:33:22 +0000 (20:33 -0400)]
Don't return value types as const (dotnet/coreclr#24103)

These types are value types; they are returned by copying. Marking the
return type as const has no effect: since the value is copied, the
caller can modify it anyway.

This resolves all the -Wignored-qualifiers warnings produced by clang 7
(when those warnings are explicitly enabled).

Commit migrated from https://github.com/dotnet/coreclr/commit/e4e261feb7d618b19f88064a9052a37355dbd3b9

5 years agoMerge pull request dotnet/coreclr#24105 from BruceForstall/ReduceLinuxArm32PeriodicJobs
Bruce Forstall [Thu, 18 Apr 2019 23:29:38 +0000 (16:29 -0700)]
Merge pull request dotnet/coreclr#24105 from BruceForstall/ReduceLinuxArm32PeriodicJobs

Reduce the number of Linux arm32 periodic jobs triggered

Commit migrated from https://github.com/dotnet/coreclr/commit/65f74d45de115d1c8ddc5435a1cea3d9974769a6

5 years agoAllow UpperVector Save and Restore without base type (dotnet/coreclr#24080)
Carol Eidt [Thu, 18 Apr 2019 23:05:34 +0000 (16:05 -0700)]
Allow UpperVector Save and Restore without base type (dotnet/coreclr#24080)

Fixes an issue with crossgen on Arm64/linux

Commit migrated from https://github.com/dotnet/coreclr/commit/7e8c5b66c1126b56e28874d634465825f2b07c50

5 years agoReduce the number of Linux arm32 periodic jobs triggered
Bruce Forstall [Thu, 18 Apr 2019 22:45:05 +0000 (15:45 -0700)]
Reduce the number of Linux arm32 periodic jobs triggered

Only the corefx jobs are left. The rest should be done in AzDO,
and scheduling both AzDO and Jenkins is causing too much work
for the few machines we have.

Commit migrated from https://github.com/dotnet/coreclr/commit/8d4fccb658f5765f6ab3c691736d06fcb672cc5c

5 years agoFix RVA field placement order (dotnet/coreclr#24047)
Fadi Hanna [Thu, 18 Apr 2019 21:16:47 +0000 (14:16 -0700)]
Fix RVA field placement order (dotnet/coreclr#24047)

* Static RVA fields should be placed sequentially after the qsort operation to not break Managed C++ binaries in R2R

* Add regression test

Commit migrated from https://github.com/dotnet/coreclr/commit/1a2bc6c63ebeff1452ac9ae05b2b0eda058062fa

5 years agoDisable native-client tests on IL round-trip (dotnet/coreclr#24041)
Jeremy Koritzinsky [Thu, 18 Apr 2019 20:49:36 +0000 (15:49 -0500)]
Disable native-client tests on IL round-trip (dotnet/coreclr#24041)

Commit migrated from https://github.com/dotnet/coreclr/commit/cae14d02be194bb68e8b90b556d6931ab37ac2ba

5 years agoIf IPC connections fails, then remove active session. (dotnet/coreclr#24082)
José Rivero [Thu, 18 Apr 2019 20:18:26 +0000 (13:18 -0700)]
If IPC connections fails, then remove active session. (dotnet/coreclr#24082)

Commit migrated from https://github.com/dotnet/coreclr/commit/b874895d6ec17d51d9f4b271fb878f89ce674543

5 years agoMerge pull request dotnet/coreclr#24071 from AndyAyersMS/Fix24055
Russ Keldorph [Thu, 18 Apr 2019 18:11:59 +0000 (11:11 -0700)]
Merge pull request dotnet/coreclr#24071 from AndyAyersMS/Fix24055

JIT: fix arm64 crossgen simd issue

Commit migrated from https://github.com/dotnet/coreclr/commit/af83b8ad6fe02b45321741e26d996ee4b738d67f

5 years agoAdd a destructor for sos::GCHeap (dotnet/coreclr#24072)
Omair Majid [Thu, 18 Apr 2019 17:36:25 +0000 (13:36 -0400)]
Add a destructor for sos::GCHeap (dotnet/coreclr#24072)

The constructor allocates memory via new[]. It should be freed up via
delete[] by a destructor to avoid a memory leak.

Commit migrated from https://github.com/dotnet/coreclr/commit/12d7055fe427c6ab4d8c04d28a9f6a35ade6815c

5 years agoMerge pull request dotnet/coreclr#23853 from jkoritzinsky/cmake-ninja-fix
Jan Vorlicek [Thu, 18 Apr 2019 15:42:30 +0000 (17:42 +0200)]
Merge pull request dotnet/coreclr#23853 from jkoritzinsky/cmake-ninja-fix

Fix CMake warning about clrjit.exports.in file when using Ninja generator

Commit migrated from https://github.com/dotnet/coreclr/commit/42b5509b1b8f3be12876579aa23a3cb3ed2ca7a4

5 years agoMerge pull request dotnet/coreclr#24066 from janvorli/put-back-cpu-limits
Jan Vorlicek [Thu, 18 Apr 2019 14:53:57 +0000 (16:53 +0200)]
Merge pull request dotnet/coreclr#24066 from janvorli/put-back-cpu-limits

Put back the CPU limiting in GC

Commit migrated from https://github.com/dotnet/coreclr/commit/576ac07df17d52fcbf24e472b3b4aa1edb0f61f9

5 years agoSkip type sanity checks for CoreLib (dotnet/coreclr#24074)
Jan Kotas [Thu, 18 Apr 2019 14:13:33 +0000 (07:13 -0700)]
Skip type sanity checks for CoreLib (dotnet/coreclr#24074)

Commit migrated from https://github.com/dotnet/coreclr/commit/3188635a14e9c60acdd220add720ebb86e3b9862

5 years agoFixed ChunkEnumerator.Current NRE (dotnet/coreclr#24076)
Benjamin Bartels [Thu, 18 Apr 2019 12:53:22 +0000 (13:53 +0100)]
Fixed ChunkEnumerator.Current NRE (dotnet/coreclr#24076)

* Fixed ChunkEnumerator.Current NRE

* Added Nullable Flow analysis annotation comment

* Changed TODO-NULLABLE comment to link to appropriate issue

Commit migrated from https://github.com/dotnet/coreclr/commit/4111fae1ce185de69d1bf532503b5d369f2a5c53

5 years agoMerge pull request dotnet/coreclr#23934 from franksinankaya/gcc_cleanup_18
Jan Vorlicek [Thu, 18 Apr 2019 08:27:27 +0000 (10:27 +0200)]
Merge pull request dotnet/coreclr#23934 from franksinankaya/gcc_cleanup_18

Integer Conversion Issues from GCC

Commit migrated from https://github.com/dotnet/coreclr/commit/837ac49c1ac46729df88ddb4a5d73ade6cc55cfc

5 years agoMerge pull request dotnet/coreclr#23762 from dotnet/NullableFeature
Santiago Fernandez Madero [Thu, 18 Apr 2019 01:17:55 +0000 (20:17 -0500)]
Merge pull request dotnet/coreclr#23762 from dotnet/NullableFeature

Nullable feature into master

Commit migrated from https://github.com/dotnet/coreclr/commit/52aff202cd382c233d903d432da06deffaa21868

5 years agoanother similar fix
Andy Ayers [Thu, 18 Apr 2019 00:03:12 +0000 (17:03 -0700)]
another similar fix

Commit migrated from https://github.com/dotnet/coreclr/commit/7876c66480b09556eadca985bb78468a74dbe6b9

5 years agoRemoving the unnecessary friend relationship
Andrew Au [Wed, 17 Apr 2019 18:37:26 +0000 (11:37 -0700)]
Removing the unnecessary friend relationship

Commit migrated from https://github.com/dotnet/coreclr/commit/0c1f6b9e3282f04d48b756afc8dbe60334ffd9b1

5 years agoMerge pull request dotnet/coreclr#24067 from briansull/desktop-fix2
Brian Sullivan [Wed, 17 Apr 2019 22:23:02 +0000 (15:23 -0700)]
Merge pull request dotnet/coreclr#24067 from briansull/desktop-fix2

Fix for Desktop build break

Commit migrated from https://github.com/dotnet/coreclr/commit/3c9d270325585c00d4d5bc3eab495080e78274d7

5 years agoAdded comment on #endif
Brian Sullivan [Wed, 17 Apr 2019 22:21:03 +0000 (15:21 -0700)]
Added comment on #endif

Commit migrated from https://github.com/dotnet/coreclr/commit/dc4d6d72fe153d66406ec0da4ba4d94ab9d49416

5 years agoJIT: fix arm64 crossgen simd issue
Andy Ayers [Wed, 17 Apr 2019 21:32:07 +0000 (14:32 -0700)]
JIT: fix arm64 crossgen simd issue

Need to check `supportSIMDType()` and not `featureSIMD` in rationalize.

Fixes dotnet/coreclr#24055.

Commit migrated from https://github.com/dotnet/coreclr/commit/496d1b4b5714a4724253662b20e0486a5e74b744

5 years agoJIT: ignore pinning of non-gc types (dotnet/coreclr#24010)
Andy Ayers [Wed, 17 Apr 2019 21:23:11 +0000 (14:23 -0700)]
JIT: ignore pinning of non-gc types (dotnet/coreclr#24010)

We may see pin modifiers on locals that are not gc types.
Ignore these modifiers.

Closes dotnet/coreclr#23950.

Also added a missing copyright header on an unrelated test.

Commit migrated from https://github.com/dotnet/coreclr/commit/ea12523aaca4f8dd2f2e877d0998b72d9a34de91

5 years agoFix StringBuilder annotations and debug.asserts (dotnet/coreclr#24069)
Santiago Fernandez Madero [Wed, 17 Apr 2019 20:10:13 +0000 (15:10 -0500)]
Fix StringBuilder annotations and debug.asserts (dotnet/coreclr#24069)

Commit migrated from https://github.com/dotnet/coreclr/commit/e73ad9cac0b7efc4ac1460b386295289e02e40d5

5 years agoRuntime counters naming change and setting default rates. (dotnet/coreclr#24052)
Sung Yoon Whang [Wed, 17 Apr 2019 20:05:57 +0000 (13:05 -0700)]
Runtime counters naming change and setting default rates.  (dotnet/coreclr#24052)

* Renaming runtime counters and giving them DisplayNames

* fix build err

* Adding default DisplayRateTimeScale to runtime counters

Commit migrated from https://github.com/dotnet/coreclr/commit/4f00e74c1c884060511a85ed71926aef85d830fc

5 years agoRestrict morph add rearrangement. (dotnet/coreclr#23984)
Eugene Rozenfeld [Wed, 17 Apr 2019 19:59:31 +0000 (12:59 -0700)]
Restrict morph add rearrangement. (dotnet/coreclr#23984)

Morph has transformations
((x + const) + y) => ((x + y) + const)
and
((x + const1) + (y + const2)) => ((x + y) + (const1 + const2))

If x or y is a GC pointer and one of the int operands may be negative,
this may result in a byref temp that points outside of the ref object.
If the code is in a non-interruptible region and a GC happens, the byref
won't be updated.

This change disallows the transformations if one of the non-const
operands is a GC pointer.

Fixes dotnet/coreclr#23792.

Commit migrated from https://github.com/dotnet/coreclr/commit/b0d17dc29f9a58a5580e8899ea8dae47c2d4c2aa

5 years agoMerge pull request dotnet/coreclr#24065 from sandreenko/fixCoreFXScripts
Sergey Andreenko [Wed, 17 Apr 2019 19:31:33 +0000 (12:31 -0700)]
Merge pull request dotnet/coreclr#24065 from sandreenko/fixCoreFXScripts

Add --runtime-path to CoreFX test runner.

Commit migrated from https://github.com/dotnet/coreclr/commit/176d0e108daa13b9503075a252ff19ef6d3b0a0c

5 years agoFix for Desktop build break
Brian Sullivan [Wed, 17 Apr 2019 18:18:09 +0000 (11:18 -0700)]
Fix for Desktop build break

Commit migrated from https://github.com/dotnet/coreclr/commit/5cd3582febac17dba773f5c7db956fd862e2d716

5 years agoAdd lvIsImplicitByRef information to lvaSetStruct (dotnet/coreclr#19223)
Jarret Shook [Wed, 17 Apr 2019 18:06:16 +0000 (11:06 -0700)]
Add lvIsImplicitByRef information to lvaSetStruct (dotnet/coreclr#19223)

Before implicit byrefs were tracked by setting lvIsParam and lvIsTemp.
This change explicitly adds a flag for implicitByRef instead of overloading.
In addition, it fixes the decision to copy an implicitByRef for arm64 varargs.

Temporarily bump weight on byref params to match old behavior and avoid codegen
diffs.

Re-enabled various tests and parts of tests.

Closes dotnet/coreclr#20046
Closes dotnet/coreclr#19860

Commit migrated from https://github.com/dotnet/coreclr/commit/adf6d4661a5f7367e70256ac1c37d71149a37f5b

5 years agoPut back the CPU limiting in GC
Jan Vorlicek [Wed, 17 Apr 2019 17:59:41 +0000 (10:59 -0700)]
Put back the CPU limiting in GC

The CPU limiting was accidentally removed during refactoring of the CPU
groups support in GC. This change puts them back.

Commit migrated from https://github.com/dotnet/coreclr/commit/0d9114b1f5d0b125f04f1ec17064a761fb26ba66

5 years agoAdd --runtime-path to CoreFX test runner.
Sergey Andreenko [Wed, 17 Apr 2019 17:52:05 +0000 (10:52 -0700)]
Add --runtime-path to CoreFX test runner.

Commit migrated from https://github.com/dotnet/coreclr/commit/f7b245ccadbae6ee4d6bab4a6a36551e4ffd6270

5 years agoUpdate the types consumers of Index and Range (dotnet/coreclr#24036)
Tarek Mahmoud Sayed [Wed, 17 Apr 2019 16:54:51 +0000 (17:54 +0100)]
Update the types consumers of Index and Range (dotnet/coreclr#24036)

* Update the types consumers of Index and Range

The C# compiler now can automatically support the indexers with Index and Range parameters on any type meet the conditions:
- The type exposes Length or Count property which returning integer.
- The type has indexer of integer parameter.
- The type has a Slice method which takes 2 integers

The change here is to remove the methods and indexers of the types which we previously added it as the compiler will automatically provide those.

* Remove the JIT failing test

Commit migrated from https://github.com/dotnet/coreclr/commit/35172e140236d5197a4d7d19f46d627dd6c119c1

5 years agoExclude ToString_NullFrame_ThrowsNullReferenceException test from nullable change
Santiago Fernandez Madero [Wed, 17 Apr 2019 04:19:13 +0000 (21:19 -0700)]
Exclude ToString_NullFrame_ThrowsNullReferenceException test from nullable change

Commit migrated from https://github.com/dotnet/coreclr/commit/8db25ad7931c06e1c3d10aa7bc3859e913bf01e5

5 years agoFix a ZeroMemory call in methodcontext.cpp (dotnet/coreclr#23843)
Omair Majid [Wed, 17 Apr 2019 03:18:37 +0000 (23:18 -0400)]
Fix a ZeroMemory call in methodcontext.cpp (dotnet/coreclr#23843)

The argument is of type `GetArgTypeValue` and so the `sizeof()` should be
done on `GetArgTypeValue`, not on the different type `GetArgType`.

Commit migrated from https://github.com/dotnet/coreclr/commit/df2f4c4feb273545e91fd8d7d170dc424b741f19

5 years agoNit: Update comment (dotnet/coreclr#23896)
Next Turn [Wed, 17 Apr 2019 03:17:33 +0000 (11:17 +0800)]
Nit: Update comment (dotnet/coreclr#23896)

Commit migrated from https://github.com/dotnet/coreclr/commit/97da6051f962014e7df0b7837fecbcdea0f9e248

5 years agoUpdate CoreClr to preview5-27616-71 (dotnet/coreclr#24020)
dotnet-maestro-bot [Wed, 17 Apr 2019 03:15:18 +0000 (20:15 -0700)]
Update CoreClr to preview5-27616-71 (dotnet/coreclr#24020)

Commit migrated from https://github.com/dotnet/coreclr/commit/40233545da8b1498632250dd54b4f6d28f2e57e8

5 years agoRemove limits on IVT public key lengths. (dotnet/coreclr#24042)
Jeremy Koritzinsky [Wed, 17 Apr 2019 03:13:29 +0000 (20:13 -0700)]
Remove limits on IVT public key lengths. (dotnet/coreclr#24042)

Commit migrated from https://github.com/dotnet/coreclr/commit/61d84b9644fe875a9d8bb3b1b2b70c4fe45fbab2

5 years agoChanging Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitude to propagate...
Tanner Gooding [Wed, 17 Apr 2019 03:13:12 +0000 (20:13 -0700)]
Changing Math.Max, Math.Min, Math.MaxMagnitude, and Math.MinMagnitude to propagate NaN inputs (dotnet/coreclr#24039)

Commit migrated from https://github.com/dotnet/coreclr/commit/c5b2e71106b1a8d2480e1f08bffcb09358f0a45a

5 years agoFix incorrect EHCount calculation (dotnet/coreclr#24048)
Levi Broderick [Wed, 17 Apr 2019 03:12:12 +0000 (20:12 -0700)]
Fix incorrect EHCount calculation (dotnet/coreclr#24048)

Commit migrated from https://github.com/dotnet/coreclr/commit/aa9825aad965879fae2dab9afd1a86564f856fe9

5 years agoFix incorrect thread affinitization (dotnet/coreclr#24045)
Jan Vorlicek [Wed, 17 Apr 2019 03:11:35 +0000 (05:11 +0200)]
Fix incorrect thread affinitization (dotnet/coreclr#24045)

The PAL_SetCurrentThreadAffinity was incorrectly adding the specified processor
to the current thread affinity set instead of setting the affinity to only
the processor specified.
It was causing significant performance hit in aspnet benchmarks on machines with
many cores.
This change crept in when I was refactoring the related code while removing
CPU groups emulation.

Commit migrated from https://github.com/dotnet/coreclr/commit/2a6ca5c3eb8f5597be776aea85fb4086a53ac0ad

5 years ago[EventPipe] Minor bug fixes, and remove redundant/unused code. (dotnet/coreclr#23956)
José Rivero [Wed, 17 Apr 2019 01:58:31 +0000 (18:58 -0700)]
[EventPipe] Minor bug fixes, and remove redundant/unused code. (dotnet/coreclr#23956)

- Update MicrosoftDiagnosticsTracingTraceEventPackageVersion
- Delete connection if the request is unknown/unhandled
- Adding missing error handling.
  - Provider names must be defined.
- Some renaming, error handling, and build warnings.
- Removing test code, and merge EventPipe::Enable functions.
- Remove commented/non-used lines.

Commit migrated from https://github.com/dotnet/coreclr/commit/b388f6cd87d87f4a07fe966aaa1bc92f245165d9

5 years agoMerge pull request dotnet/coreclr#24037 from BruceForstall/ReduceStackRequirement
Bruce Forstall [Tue, 16 Apr 2019 23:28:49 +0000 (16:28 -0700)]
Merge pull request dotnet/coreclr#24037 from BruceForstall/ReduceStackRequirement

Reduce stack requirements of test

Commit migrated from https://github.com/dotnet/coreclr/commit/f360bbc0cf893bcd612516563145729743d3af2b

5 years agoMerge pull request dotnet/coreclr#24002 from sandreenko/fixDesktopFailure
Sergey Andreenko [Tue, 16 Apr 2019 21:52:15 +0000 (14:52 -0700)]
Merge pull request dotnet/coreclr#24002 from sandreenko/fixDesktopFailure

Another surgery fix for genPutArgStk to fix desktop build.

Commit migrated from https://github.com/dotnet/coreclr/commit/b992648503ff2083c1064b42c74ea302eb062b05

5 years agoFix if condition in AssemblyLoadContext
Santiago Fernandez Madero [Tue, 16 Apr 2019 20:24:55 +0000 (13:24 -0700)]
Fix if condition in AssemblyLoadContext

Commit migrated from https://github.com/dotnet/coreclr/commit/fc1cea76ccb643f962409af410aa33b3c776638d

5 years agoMerge pull request dotnet/coreclr#23947 from sandreenko/reenableSystem.ComponentModel...
Sergey Andreenko [Tue, 16 Apr 2019 19:48:27 +0000 (12:48 -0700)]
Merge pull request dotnet/coreclr#23947 from sandreenko/reenableSystem.ComponentModel.Composition.Tests

Reenable System.ComponentModel.Composition.Tests arm64 Windows.

Commit migrated from https://github.com/dotnet/coreclr/commit/87ef27bf081432457e6f1fd635a765b147406a96

5 years agoReduce stack requirements of test
Bruce Forstall [Tue, 16 Apr 2019 18:52:04 +0000 (11:52 -0700)]
Reduce stack requirements of test

Fixes dotnet/coreclr#24021

Commit migrated from https://github.com/dotnet/coreclr/commit/40d4d525136b9185e6a8f4620da06f3ce13d8f64

5 years agoUse lvaGetDesc.
Sergey Andreenko [Tue, 16 Apr 2019 18:12:13 +0000 (11:12 -0700)]
Use lvaGetDesc.

Commit migrated from https://github.com/dotnet/coreclr/commit/ba152cf08ab38a58e8f03d1cc5afd1666f3e8728

5 years agoNullable: Addition COM types (dotnet/coreclr#24032)
Stephen Toub [Tue, 16 Apr 2019 17:24:31 +0000 (13:24 -0400)]
Nullable: Addition COM types (dotnet/coreclr#24032)

Somehow these slipped through previous rounds of annotating.

Commit migrated from https://github.com/dotnet/coreclr/commit/b6907db12eff4fa7cf956eb770f66c8ffa7b274d

5 years agoMerge remote-tracking branch 'dotnet/master' into NullableFeature
Santiago Fernandez Madero [Tue, 16 Apr 2019 16:55:59 +0000 (09:55 -0700)]
Merge remote-tracking branch 'dotnet/master' into NullableFeature

Commit migrated from https://github.com/dotnet/coreclr/commit/38b1ff9e0d235860fc158ce2595cc2598f9f9183

5 years agoDowngrade xUnit package version (dotnet/coreclr#23944)
Egor Chesakov [Tue, 16 Apr 2019 16:49:38 +0000 (09:49 -0700)]
Downgrade xUnit package version (dotnet/coreclr#23944)

* Use the same version of xUnit that arcade uses (2.4.1-pre.build.4059)

Commit migrated from https://github.com/dotnet/coreclr/commit/8252365bfb7651a5473e98d3bdaeaa8cb22c0ec3

5 years agoArm64 vector ABI (dotnet/coreclr#23675)
Carol Eidt [Tue, 16 Apr 2019 16:35:49 +0000 (09:35 -0700)]
Arm64 vector ABI (dotnet/coreclr#23675)

* Support for Arm64 Vector ABI

Extend HFA support to support vectors as well as floating point types.
This requires that the JIT recognize vector types even during crossgen,
so that the ABI is supported consistently.

Also, fix and re-enable the disabled Arm64 Simd tests.

Fix dotnet/coreclr#16022

Commit migrated from https://github.com/dotnet/coreclr/commit/5be6b66ff3597df6a1ce3b66a8cf65b0beb40856

5 years agoTest remove ContextualReflectionProxy (dotnet/coreclr#24006)
Steve MacLean [Tue, 16 Apr 2019 15:23:43 +0000 (11:23 -0400)]
Test remove ContextualReflectionProxy (dotnet/coreclr#24006)

Commit migrated from https://github.com/dotnet/coreclr/commit/11a3859c10dcc20a6c5865135334f4df62d2358c

5 years agoUpdate ContextualReflection doc (dotnet/coreclr#24018)
Steve MacLean [Tue, 16 Apr 2019 15:20:31 +0000 (11:20 -0400)]
Update ContextualReflection doc (dotnet/coreclr#24018)

* Update ContextualReflection doc

* PR Feedback

Commit migrated from https://github.com/dotnet/coreclr/commit/b1fac634bb6c39ea88fb4a343d61dca22e455e65

5 years agoUse delete [] on array types (dotnet/coreclr#24027)
Omair Majid [Tue, 16 Apr 2019 14:43:09 +0000 (10:43 -0400)]
Use delete [] on array types (dotnet/coreclr#24027)

Calling delete on types allocated with new[] leads to undefined
behaviour.

Commit migrated from https://github.com/dotnet/coreclr/commit/bef5dd6507f2e8ac163941646ef9936d6ced3715

5 years agoMove EventSource to shared CoreLib partition (dotnet/coreclr#23925)
Filip Navara [Tue, 16 Apr 2019 13:52:53 +0000 (15:52 +0200)]
Move EventSource to shared CoreLib partition (dotnet/coreclr#23925)

* Move most of EventSource to shared CoreLib partition

* Reenable some code that can be shared with Microsoft.Diagnostics.Tracing.EventSource.Redist in CoreFX

* Remove unused functions

* Fix placement of #endregion

* Clean up P/Invoke prototypes

* Move remaining code from EventSource_CoreCLR to shared partition (guarded by !CORERT)

* Remove more unnecessary marshalling attributes

* Move remaining CoreRT/ProjectN code to shared partition

* Avoid using Windows errors on non-Windows platforms

Commit migrated from https://github.com/dotnet/coreclr/commit/f7020d98c49d8c89fdad41aae64c018be63c623a

5 years agoMerge pull request dotnet/coreclr#24009 from sandreenko/fixLsraBlockEpochCheck
Sergey Andreenko [Tue, 16 Apr 2019 08:49:23 +0000 (01:49 -0700)]
Merge pull request dotnet/coreclr#24009 from sandreenko/fixLsraBlockEpochCheck

Fix lsraBlockEpoch check.

Commit migrated from https://github.com/dotnet/coreclr/commit/994a50ee370cfe62ea4e56d3e55dc5babb65d575

5 years agoUse NewArrayHolder for array types in src/debug (dotnet/coreclr#24013)
Omair Majid [Tue, 16 Apr 2019 05:14:48 +0000 (01:14 -0400)]
Use NewArrayHolder for array types in src/debug (dotnet/coreclr#24013)

Using a NewHolder with array types means that when the holder is ready
to release the  memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.

Use NewArrayHolder isntead to fix this.

Commit migrated from https://github.com/dotnet/coreclr/commit/08318afbeb726eb80f212c70310e5750daec5abf

5 years agoUse NewArrayHolder for array types (dotnet/coreclr#24017)
Omair Majid [Tue, 16 Apr 2019 05:12:39 +0000 (01:12 -0400)]
Use NewArrayHolder for array types (dotnet/coreclr#24017)

This touches all the code outside of src/debug/.

Using a NewHolder with array types means that when the holder is ready
to release the memory, it ends up invoking `delete` (instead of
`delete[]`) on that array. This is an undefined behaviour.

Use NewArrayHolder instead to fix this.

Commit migrated from https://github.com/dotnet/coreclr/commit/0f838a7c22c6e19748582ced5e03a8e273f63062

5 years agoConversion issues
Sinan Kaya [Fri, 12 Apr 2019 05:57:37 +0000 (05:57 +0000)]
Conversion issues

Commit migrated from https://github.com/dotnet/coreclr/commit/034c81b00c101ab1654b9592274ce0a0a9ee312b

5 years agoFix an issue with literal 0xFFFFFFFFFFFFF000LL being treated as unsigned long long...
Egor Chesakov [Tue, 16 Apr 2019 04:07:33 +0000 (21:07 -0700)]
Fix an issue with literal 0xFFFFFFFFFFFFF000LL being treated as unsigned long long int (dotnet/coreclr#24011)

Commit migrated from https://github.com/dotnet/coreclr/commit/f6938e2b5497cce88ab7b3643ab5f3174d8bb3e7

5 years agoUpdate clr-configuration-knobs and cleanups (dotnet/coreclr#24016)
Adeel Mujahid [Tue, 16 Apr 2019 02:36:44 +0000 (03:36 +0100)]
Update clr-configuration-knobs and cleanups (dotnet/coreclr#24016)

Commit migrated from https://github.com/dotnet/coreclr/commit/ee2c5d63810de5c663f644821751ecc6f56c5149

5 years agoFix incorrect bit match pattern in UTF-16 validation (dotnet/coreclr#24015)
Levi Broderick [Tue, 16 Apr 2019 01:28:39 +0000 (18:28 -0700)]
Fix incorrect bit match pattern in UTF-16 validation (dotnet/coreclr#24015)

Commit migrated from https://github.com/dotnet/coreclr/commit/fcc4beb884b7e38a9886b7a354ec8b6cdb8aad83

5 years agoFold ResourceSet::CommonInit into constructor (dotnet/coreclr#23993)
Jan Kotas [Tue, 16 Apr 2019 00:37:41 +0000 (17:37 -0700)]
Fold ResourceSet::CommonInit into constructor (dotnet/coreclr#23993)

Commit migrated from https://github.com/dotnet/coreclr/commit/4aeedc147f45b63e6f07155fea1446b084cb9a46

5 years agoFix lsraBlockEpoch check.
Sergey Andreenko [Mon, 15 Apr 2019 22:38:44 +0000 (15:38 -0700)]
Fix lsraBlockEpoch check.

Commit migrated from https://github.com/dotnet/coreclr/commit/4905d63d9d03cc1b8b46f6830b50489ee93ce33f

5 years agoInitialize IsolatedComponentLoadContext.Name (dotnet/coreclr#24001)
Steve MacLean [Mon, 15 Apr 2019 23:59:36 +0000 (19:59 -0400)]
Initialize IsolatedComponentLoadContext.Name (dotnet/coreclr#24001)

Commit migrated from https://github.com/dotnet/coreclr/commit/b97f0681a4ebfb79ee0b931602cda645bad2125e

5 years agoAdd "partial" to MarshalAsAttribute (dotnet/coreclr#24014)
Egor Bogatov [Mon, 15 Apr 2019 23:44:04 +0000 (02:44 +0300)]
Add "partial" to MarshalAsAttribute (dotnet/coreclr#24014)

Commit migrated from https://github.com/dotnet/coreclr/commit/47c6539dc73a23bf167e5eaadce475475c512f44

5 years agoDelete unused YieldProcessorScalingFactor from GC (dotnet/coreclr#23994)
Jan Kotas [Mon, 15 Apr 2019 23:30:00 +0000 (16:30 -0700)]
Delete unused YieldProcessorScalingFactor from GC (dotnet/coreclr#23994)

Commit migrated from https://github.com/dotnet/coreclr/commit/577f8b84113fdf5ff001732b93da6733842123ec

5 years agoRemove redundant UnderlyingSystemType calls (dotnet/coreclr#24000)
Jan Kotas [Mon, 15 Apr 2019 23:29:41 +0000 (16:29 -0700)]
Remove redundant UnderlyingSystemType calls (dotnet/coreclr#24000)

UnderlyingSystemType is virtual

Commit migrated from https://github.com/dotnet/coreclr/commit/a6326409fd033f4145e1387955504d46f50850a5

5 years agoCheck for null methodhandle before checking if the method is in the same version...
Fadi Hanna [Mon, 15 Apr 2019 23:25:16 +0000 (16:25 -0700)]
Check for null methodhandle before checking if the method is in the same version bubble (dotnet/coreclr#23940)

Commit migrated from https://github.com/dotnet/coreclr/commit/ee41ee41bcf5f6c1d77a261fa7cae469475b268a

5 years agoFix precompiling CoreRoot overlay with crossgen for Windows arm/arm64 (dotnet/coreclr...
Sergiy Kuryata [Mon, 15 Apr 2019 23:07:35 +0000 (16:07 -0700)]
Fix precompiling CoreRoot overlay with crossgen for Windows arm/arm64 (dotnet/coreclr#23946)

Commit migrated from https://github.com/dotnet/coreclr/commit/a49cc4ad01b51b26165c371579be763c5ccc30f5