Stephane Delcroix [Sun, 4 Dec 2016 21:08:11 +0000 (22:08 +0100)]
[Xaml] support arrays as x:Arguments (#545)
* [Xaml] port some FactoryMethod tests to XamlC
* [Xaml] support array parameters in factory ctors
* [XamlC] support arrays as x:Arguments
* fix build
adrianknight89 [Sun, 4 Dec 2016 13:44:40 +0000 (07:44 -0600)]
dispose tap gesture (#601)
Rui Marinho [Sat, 3 Dec 2016 00:40:38 +0000 (00:40 +0000)]
Fix iOS10 build lane info
Jimmy Garrido [Sat, 3 Dec 2016 00:17:38 +0000 (16:17 -0800)]
Fix CommandBar overlaying content (#593)
E.Z. Hart [Fri, 2 Dec 2016 23:52:31 +0000 (16:52 -0700)]
Restore old Alert/ActionSheet method for iOS 8 (#595)
* Rename action sheet overload
* Restoring iOS8-compatible alert/actionsheet handling
E.Z. Hart [Fri, 2 Dec 2016 21:47:57 +0000 (14:47 -0700)]
Update NavigationPage Platform Specifics demo with pre-393 compatible color
Stephane Delcroix [Fri, 2 Dec 2016 21:01:57 +0000 (22:01 +0100)]
fix build
E.Z. Hart [Fri, 2 Dec 2016 20:48:42 +0000 (13:48 -0700)]
Allow CommandBar to expand and show command labels (#594)
* Allow CommandBar to expand and show command labels
Consolidate command bar placement code
* Make title text wrapping consistent between NavigationPage and MasterDetailPage
* Align toolbar/navigation bar behavior with other platforms
Stephane Delcroix [Fri, 2 Dec 2016 20:36:10 +0000 (21:36 +0100)]
[XamlC] passing test for 47703
Stephane Delcroix [Thu, 1 Dec 2016 22:39:47 +0000 (23:39 +0100)]
fix the tests
Mike Norman [Thu, 1 Dec 2016 21:55:02 +0000 (15:55 -0600)]
Last of Xamarin.Forms namespace internal items. (#589)
Stephane Delcroix [Thu, 1 Dec 2016 21:54:14 +0000 (22:54 +0100)]
Revert "Jimmgarrido uwp toolbar (#588)"
This reverts commit
1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.
Stephane Delcroix [Thu, 1 Dec 2016 21:40:20 +0000 (22:40 +0100)]
[XamlC] provide backward compat for ProvideValueTarget without Target… (#583)
* [XamlC] provide backward compat for ProvideValueTarget without TargetProperty
* docs
Stephane Delcroix [Thu, 1 Dec 2016 21:39:43 +0000 (22:39 +0100)]
Jimmgarrido uwp toolbar (#588)
* Fixed CommandBar being clipped when expanded by removing explicit Height
* Add UITest
Stephane Delcroix [Thu, 1 Dec 2016 21:34:39 +0000 (22:34 +0100)]
[XamlC] use op_implicit where we should (#580)
* [XamlC] (passing) test for 48242
* [XamlC] (failing) test for 48242
* [XamlC] more op_implicit conversions
* additional test
* fix rebase
Stephane Delcroix [Thu, 1 Dec 2016 21:26:05 +0000 (22:26 +0100)]
[Xaml] support non-int enums (#575)
E.Z. Hart [Thu, 1 Dec 2016 21:15:17 +0000 (14:15 -0700)]
Don't run Command CanExecute on incorrect inherited binding context type (#572)
* Allow Command CanExecute to recover when run on inherited bindingcontext
* Make exception handler more generic
* Checking types in Command delegates to avoid exception in the first place
* Adding type chekc to other Command constructor
* Use nameof for ArgumentNullExceptions
* Add unit tests for null parameters, handle value types and Nullable<T>
Stephane Delcroix [Thu, 1 Dec 2016 21:14:22 +0000 (22:14 +0100)]
[XamlC] assigned derived type to generic BP (#566)
* [XamlC] assigned derived type to generic BP
* [XamlC] fix 48554
* f
Stephane Delcroix [Thu, 1 Dec 2016 21:10:11 +0000 (22:10 +0100)]
[XamlC] support non-generic IMarkup on ABPs (#562)
* [XamlC] support custom markups on ABPs
* [XamlC] test for 47950
adrianknight89 [Thu, 1 Dec 2016 00:29:16 +0000 (18:29 -0600)]
fix NRE in packager dispose (#561)
Rui Marinho [Wed, 30 Nov 2016 20:09:57 +0000 (20:09 +0000)]
[iOS] Avoid using DrawRect on base VisualElementRenderer (#570)
* [Controls] Add retro for Bugzilla 48158
* [iOS] Avoid using DrawRect as this will make some properties not being applied to the layer
* [iOS] Make sure BoxRenderer calls base LayoutSubviews
* [iOS] Better fix for adding the Blur effect and avoid override draw’s
* [Controls] Remove extra nunit category
E.Z. Hart [Wed, 30 Nov 2016 18:08:30 +0000 (11:08 -0700)]
Fix Issue 774 test so it works with wrapped IApp on phone and tablet
Rui Marinho [Wed, 30 Nov 2016 11:21:30 +0000 (11:21 +0000)]
[Win] Update cert (#579)
E.Z. Hart [Wed, 30 Nov 2016 07:46:37 +0000 (00:46 -0700)]
Have UI test for 21177 clean up after itself
E.Z. Hart [Wed, 30 Nov 2016 03:29:14 +0000 (20:29 -0700)]
Don't instantiate the various core gallery pages until we actually need them
E.Z. Hart [Mon, 28 Nov 2016 17:09:17 +0000 (10:09 -0700)]
Updating 35733 test to use a URL XF controls
adrianknight89 [Thu, 24 Nov 2016 19:34:46 +0000 (13:34 -0600)]
fix weakreferences (#558)
Samantha Houts [Tue, 22 Nov 2016 18:48:50 +0000 (10:48 -0800)]
Fix issue description
E.Z. Hart [Tue, 22 Nov 2016 17:01:20 +0000 (10:01 -0700)]
Fix broken alerts for iPad (#549)
* Fix broken alerts for iPad
* Remove unnecessary parameter and add null check
* Dropping test limit to 10 so we can get iOS passing
Stephane Delcroix [Tue, 22 Nov 2016 14:41:01 +0000 (15:41 +0100)]
fix mdoc path in Makefile
Jason Smith [Tue, 22 Nov 2016 13:02:12 +0000 (05:02 -0800)]
[UWP]Track user location when IsShowingUser enabled (#556)
E.Z. Hart [Mon, 21 Nov 2016 16:11:33 +0000 (09:11 -0700)]
Turning down number of consecutive tests to avoid jetsam ejections on iOS
E.Z. Hart [Sat, 19 Nov 2016 19:34:35 +0000 (12:34 -0700)]
Adding some restart logic to the UI tests if navigation fails (#550)
E.Z. Hart [Fri, 18 Nov 2016 22:55:26 +0000 (15:55 -0700)]
Add missing semicolon
E.Z. Hart [Fri, 18 Nov 2016 21:24:50 +0000 (14:24 -0700)]
Removing inconclusive result from Issue342 test
Marking 35736 test for manual review
Rui Marinho [Fri, 18 Nov 2016 20:32:48 +0000 (20:32 +0000)]
[iOS] Revert changes in popping navigation (#547)
* [iOS] Revert changes in popping navigation
* [iOS] Remove unified if
E.Z. Hart [Fri, 18 Nov 2016 19:47:52 +0000 (12:47 -0700)]
Have PresentAlert hide new window when alert is dismissed (#543)
adrianknight89 [Fri, 18 Nov 2016 19:46:34 +0000 (13:46 -0600)]
[Android] Do not show cell context actions if input views are long clicked (#544)
* Disable long click on cells if touch is on an input view
* remove redundant check
E.Z. Hart [Fri, 18 Nov 2016 16:42:57 +0000 (09:42 -0700)]
Correct test name
E.Z. Hart [Fri, 18 Nov 2016 15:26:10 +0000 (08:26 -0700)]
Disable 35736 test for Android
Stephane Delcroix [Fri, 18 Nov 2016 15:07:41 +0000 (16:07 +0100)]
update cecil (#546)
Paul DiPietro [Fri, 18 Nov 2016 12:38:30 +0000 (06:38 -0600)]
Platform specifics naming adjustments (#526)
E.Z. Hart [Thu, 17 Nov 2016 23:00:42 +0000 (16:00 -0700)]
Merge branch 'master' of github.com:xamarin/Xamarin.Forms
E.Z. Hart [Thu, 17 Nov 2016 22:59:59 +0000 (15:59 -0700)]
Put UI test using directive inside UITest block
Jason Smith [Thu, 17 Nov 2016 21:43:43 +0000 (13:43 -0800)]
Update nuget license file link
Mike Norman [Thu, 17 Nov 2016 21:04:03 +0000 (15:04 -0600)]
API docs: typo fixes in button nested classes docs (#542)
E.Z. Hart [Thu, 17 Nov 2016 20:37:07 +0000 (13:37 -0700)]
Merge branch 'master' of github.com:xamarin/Xamarin.Forms
E.Z. Hart [Thu, 17 Nov 2016 20:36:29 +0000 (13:36 -0700)]
Move 36802 test into Issues namespace
Mike Norman [Thu, 17 Nov 2016 20:30:30 +0000 (14:30 -0600)]
API work. (#534)
* Button and Cell doc updates.
* Configuration<T1, T2> API docs.
* ConstraintExpression API doc changes.
* API docs: Some new APIs; Marked many interfaces "internal for renderers"
Stephane Delcroix [Thu, 17 Nov 2016 19:31:05 +0000 (20:31 +0100)]
[Xaml] cleanup xmlns usage, add XmlnsDefinition (#531)
* [Xaml] cleanup xmlns usage, add XmlnsDefinition
* docs
E.Z. Hart [Wed, 16 Nov 2016 21:07:30 +0000 (14:07 -0700)]
Run multiple UI tests without restarting ControlGallery (#539)
* Allow UI tests to bypass "manual" navigation to isses pages
* Add missing Preserve attribute
* Make Issue198 test work with direct navigation
* Remove empty UI tests
* Fix error handling for iOS
* Use navigation which works for subsequent TestNavigationPages on iOS
* Fix race condition in 39530 test
Remove master page nesting when doing direct nav for UI tests
* Set up and run a single instance of Control Gallery for UI tests
* Force NavigateToIssue to wait for main page appearing to deal with iOS timing
* Move remaining UI tests into Issues namespace
* Change the connection check URL so it'll work on iOS
* Make Appearing Gallery tests work without restarting app
* Prevent ContextActions tests from stepping on each other
* Make context menu test more robust
* Move ButtonExtensions back to Controls namespace
* Have test 774 dismiss the action sheet before ending
* Update UITest package to 2.0.0 stable
* Make 2948 restore orientation when it's done
* Null check on PageController before calling SendDisappearing
* Adding a wait for the root page in the core tests
* Add consecutive tests reset to prevent memory slog on older iOS devices
Stephane Delcroix [Wed, 16 Nov 2016 21:05:28 +0000 (22:05 +0100)]
[W] Support 0 as valid BorderWidth (#537)
Paul DiPietro [Wed, 16 Nov 2016 20:59:21 +0000 (14:59 -0600)]
[iOS] Update Editor text from autocorrect when losing focus (#535)
adrianknight89 [Wed, 16 Nov 2016 20:55:15 +0000 (14:55 -0600)]
Set TabBarItem properly (#530)
adrianknight89 [Wed, 16 Nov 2016 20:45:58 +0000 (14:45 -0600)]
[Android] Preserve Toolbar Subtitle on page orientation change (#528)
* add ability to preserve toolbar values
* added null check
* better fix
* fix indentation
* fixed comment
E.Z. Hart [Wed, 16 Nov 2016 20:43:33 +0000 (13:43 -0700)]
Make CommitAllowingStateLoss the default (#527)
Samantha Houts [Wed, 16 Nov 2016 20:14:00 +0000 (12:14 -0800)]
[iOS] Add Platform Specific option to not adjust the status bar text color based on the luminosity of the NavigationBar text color (#517)
* Add reproduction for 37431
* [Core] Add iOS PS StatusBarTextColorMode
* [iOS] Implement StatusBarTextColorMode on NavPage
* Add reproduction for 44777
* Add instructions to 44777 repro
* Update docs
Stephane Delcroix [Wed, 9 Nov 2016 14:15:12 +0000 (15:15 +0100)]
[C] Use a Binding for ItemsSource object selection
Joakim Carselind [Wed, 9 Nov 2016 08:23:52 +0000 (09:23 +0100)]
Squashed commit of the following:
commit
8d784ec7459335ca33003844a793c3dd266c5861
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Tue Aug 23 00:30:25 2016 +0200
Added DisplayConverter property of type IValueConverter to perform conversion from object to string
commit
afb606f05c16b14e24785fad017540dd83dbf373
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Tue Aug 23 00:07:55 2016 +0200
Use IsValueType
commit
4742c22ed33309f40a55c536b161292eb5db40f8
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Fri Aug 19 18:58:40 2016 +0200
Fixed bug with nested property expression
commit
70a121e6172a61dbcf8835137bf58bd972cf2065
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Fri Aug 19 18:43:14 2016 +0200
Added more tests
commit
49c7876bda4185c699f5fd9b3a66763efca9623c
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 18 13:28:36 2016 +0200
Siimplified setting SelectedItem. Added property to provide full control over how to display the objects by DisplayFunc. Added tests
commit
5c1d5e149dc21c58cebf7cdbc6677d1ccec04ed4
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 11 17:15:36 2016 +0200
Trying to fix formatting with tabs instead of spaces
commit
d64663ce3ef6b223a04d477274e93ec87bd38ff4
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 11 17:10:39 2016 +0200
Formatting. Handle Reset,Move,Replace collection changed action equal by re binding Items collection
commit
8d4641810cb3b11fb6b47f8215bb5950a9641ba2
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 11 16:33:03 2016 +0200
Removed inline documentation. Fixed formatting
commit
28010a1b31da02879fd2d549d5b02458766544d5
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 11 16:29:37 2016 +0200
Removed SelectedValue since SelectedIndex and SelectedItem make it redundant
commit
ac9d65816fe6db7b467c304e6dc3168a84d3166b
Author: Joakim Carselind <joakim.carselind@cub.se>
Date: Thu Aug 11 14:51:20 2016 +0200
Initial attempt on bindable picker
Stephane Delcroix [Wed, 16 Nov 2016 19:51:53 +0000 (20:51 +0100)]
[XamlC] use correct filePath for XamlC error reporting (#513)
* [XamlG] decorate partial classes with [XamlFile] attribute
* [XamlC] use correct filePath for XamlC error reporting
* [docs] update docs
E.Z. Hart [Wed, 16 Nov 2016 17:14:17 +0000 (10:14 -0700)]
Use static method syntax to prevent mono compiler error (#538)
Paul DiPietro [Wed, 16 Nov 2016 12:43:30 +0000 (06:43 -0600)]
[A] Check for parent NavigationPage when setting MDP detail's TopPadding (#473)
rebased
Paul DiPietro [Wed, 16 Nov 2016 10:02:54 +0000 (04:02 -0600)]
[iOS] Add Platform Specific features for PrefersStatusBarHidden/UIStatusBarAnimation (#463)
* [iOS] Add Platform Specific features for PrefersStatusBarHidden/UIStatusBarAnimation
* Update docs
adrianknight89 [Wed, 16 Nov 2016 08:24:21 +0000 (02:24 -0600)]
BindingContext changes are called multiple times on app start (#470)
* inherited binding context fix
* add check for child binding context
* Revert "add check for child binding context"
This reverts commit
71952f39129cfedc2358a32100deb07bd32a3080.
* unit tests
Jimmy Garrido [Wed, 16 Nov 2016 08:21:55 +0000 (00:21 -0800)]
[iOS] Fix AccessoryView covered by section index list (#493)
* [iOS] Fix AccessoryView below section index list
* Add UITest
adrianknight89 [Tue, 15 Nov 2016 22:35:24 +0000 (16:35 -0600)]
fix MasterDetailPage dispose (#505)
adrianknight89 [Tue, 15 Nov 2016 22:17:29 +0000 (16:17 -0600)]
[iOS] Text should not overflow Entry if it can't fit inside the bounds (#400)
* Entry subviews should clip to parent bounds
* Adding sample code
* Adding sample code
* Adding sample code
* remove sample
* remove sample
* add back the sample code
* add back missing include
* use spaces instead of tabs
Stephane Delcroix [Tue, 1 Nov 2016 09:35:14 +0000 (10:35 +0100)]
[C] Add cornerRadius validation, docs
Andrei N [Sun, 9 Oct 2016 07:52:38 +0000 (10:52 +0300)]
Added CornerRadius property To Frame control
Samantha Houts [Tue, 15 Nov 2016 19:43:34 +0000 (11:43 -0800)]
[UWP] Explicitly set mobile StatusBar colors to white Background/black Foreground on Light theme (#491)
* [UWP] Encapsulate MobileStatusBar
* [UWP] Set StatusBar colors on Light theme
* Add test code to override status bar color
Paul DiPietro [Tue, 15 Nov 2016 19:41:19 +0000 (13:41 -0600)]
[WinRT] Fix ModalPushed/ModalPopped not firing (#490)
Stephane Delcroix [Tue, 15 Nov 2016 19:39:48 +0000 (20:39 +0100)]
[XamlC] TypedBindings, some tests, a compiler, ... (#489)
E.Z. Hart [Tue, 15 Nov 2016 19:39:23 +0000 (12:39 -0700)]
Creating category constants for UI test categories (#487)
* Creating a category just for core UI tests
* Grouping all of the core UI tests
* Adjusting categories so we can run in smaller batches
* Adding some of the Issues tests to categories
* Fix shared project nonsense
* Fix non-existent test category
* Testing global category for Issues
Paul DiPietro [Tue, 15 Nov 2016 19:36:49 +0000 (13:36 -0600)]
[iOS] Use separate UIWindow for UIAlertController (#481)
* [iOS] Use separate UIWindow for UIAlertController
* Add similar behavior for DisplayActionSheet; consolidate behavior into PresentAlert method
adrianknight89 [Tue, 15 Nov 2016 19:30:23 +0000 (13:30 -0600)]
[Android] Show keyboard on app resume if control has focus (#480)
* show keyboard on resume if control has focus
* refactor
* changed property name
Jimmy Garrido [Tue, 15 Nov 2016 19:26:16 +0000 (11:26 -0800)]
[WinRT] Setting ActivityIdicator color works now (#479)
E.Z. Hart [Tue, 15 Nov 2016 16:52:20 +0000 (09:52 -0700)]
Attempting to fix possible race conditions in Automation ID tests (#533)
E.Z. Hart [Tue, 15 Nov 2016 16:52:09 +0000 (09:52 -0700)]
Making text longer so the test works even if the device ends up in landscape mode (#532)
adrianknight89 [Tue, 15 Nov 2016 00:28:49 +0000 (18:28 -0600)]
[Internal] Change test template to use Bugzilla (#501)
* added a new template for bugzilla
* Revert "added a new template for bugzilla"
This reverts commit
e141d845849244e484143119b06c5247c28b2423.
* change template to use bugzilla
Mike Norman [Mon, 14 Nov 2016 13:31:47 +0000 (07:31 -0600)]
Marked all I___Controller interfaces as for internal use by renderers in docs. (#522)
Mike Norman [Thu, 10 Nov 2016 00:21:18 +0000 (18:21 -0600)]
Applinks API docs, and a link fix in BindableProperty.xml. (#519)
E.Z. Hart [Wed, 9 Nov 2016 20:27:20 +0000 (13:27 -0700)]
Update badge URLs to point at current build lanes (#516)
E.Z. Hart [Wed, 9 Nov 2016 17:24:20 +0000 (10:24 -0700)]
Removing PCLStorage references until it's determined that we need them
E.Z. Hart [Wed, 9 Nov 2016 17:04:12 +0000 (10:04 -0700)]
Excising the 43569 UI Test until the PCLStorage issue can be dealt with
Jimmy Garrido [Tue, 8 Nov 2016 15:38:17 +0000 (07:38 -0800)]
[UWP] Fix Transparent Default Button (#468)
Stephane Delcroix [Tue, 8 Nov 2016 15:30:19 +0000 (16:30 +0100)]
fix identation
softlion [Fri, 30 Sep 2016 08:59:58 +0000 (10:59 +0200)]
Add extensibility point to load tab icons from another source (using the tab.SetIcon(drawable) overload) on Android
Alan McGovern [Tue, 8 Nov 2016 08:14:44 +0000 (08:14 +0000)]
[Android] Always set a non-null Device.Info (#504)
When we run under the context of layoutlib the `Context` object
that is created will not implement IDeviceInfoProvider. All this
means is that we will not get change notifications when the
orientation changes, but that's ok! This won't happen anyway.
If we instantiate the Device.Info object then everywhere else in
the code will be able to get access to the screen properties.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=44893
adrianknight89 [Thu, 3 Nov 2016 18:38:38 +0000 (13:38 -0500)]
[Android] Allow path-based icons to be loaded as toolbar icons (#437)
* Created a bitmap method to check for resource as well as path
* Update platform and navigationrenderer to get images from two locations
* CellAdapter could use path-based icon finding
* sample app to test toolbaritem icons
Alan McGovern [Thu, 3 Nov 2016 11:08:30 +0000 (11:08 +0000)]
Update ContextExtensions.cs (#502)
* [Android] Handle missing android services gracefully
When rendering inside layoutlib, like the Android Designer does,
we will not have access to the normal android services.
* [Android] Handle null InputManagers here too
Just in case this codepath is hit at some point during the
android designer's rendering codepath.
Jimmy Garrido [Wed, 2 Nov 2016 18:09:55 +0000 (11:09 -0700)]
Fixed tab not updating when page title is changed (#327)
* Fixed tab not updating when page title is changed
* Remove OnPagePropertyChanged Event From Pages When Disposing
* Meet coding standards and remove unnecessary parameters
E.Z. Hart [Mon, 31 Oct 2016 15:22:54 +0000 (09:22 -0600)]
Attempt to get UI test for 44166 working on iOS (#485)
* Attempt to get UI test for 44166 working on iOS
* Another attempt to get this running consistently on iOS
* Adding screenshots so I can figure out why this doesn't work when XTC runs it
* Maybe there's confusion between the back buttons?
* Hey, it works now! Removing the debugging stuff.
* Clean up extra build constants
adrianknight89 [Mon, 31 Oct 2016 11:41:46 +0000 (06:41 -0500)]
[Android] Forward ScrollView touch events to custom renderers (#472)
* Forward touch events
* remove double cast
Mike Norman [Sun, 30 Oct 2016 21:57:15 +0000 (16:57 -0500)]
On<t> summaries. (#492)
Samantha Houts [Wed, 26 Oct 2016 19:02:14 +0000 (12:02 -0700)]
[Win] Toolbar placement works with initial value (#488)
* Defer UpdateToolbarPlacement until CommandBar is in the control hierarchy
* Cleanup
Paul DiPietro [Wed, 26 Oct 2016 17:11:58 +0000 (12:11 -0500)]
[iOS] Add check for UIGestureRecognizerState.Cancelled when closing context action (#442)
adrianknight89 [Tue, 25 Oct 2016 17:07:57 +0000 (12:07 -0500)]
ScrollView should account for Content margin (#392)
* ScrollView should account for Content margin
* Unit tests for content margin
adrianknight89 [Mon, 24 Oct 2016 21:28:58 +0000 (16:28 -0500)]
[Android] Internal keyboard hide/show should handle null views (#418)
* Check for null input view before trying to hide keyboard
* Adding null check to ShowKeyboard
* change to throw an exception
Samantha Houts [Thu, 20 Oct 2016 20:24:09 +0000 (13:24 -0700)]
[Android] SoftInputMode works with initial value (#465)
E.Z. Hart [Thu, 20 Oct 2016 20:19:27 +0000 (14:19 -0600)]
Make Editor focused background color behavior consistent with Entry on Windows (#456)