platform/core/csapi/xsf.git
5 years agoMerge branch '4.0.0'
Samantha Houts [Thu, 7 Mar 2019 17:49:56 +0000 (09:49 -0800)]
Merge branch '4.0.0'

5 years agoContextCompat.getColor if API < 23 (#5450)
kingces95 [Thu, 7 Mar 2019 17:18:57 +0000 (07:18 -1000)]
ContextCompat.getColor if API < 23 (#5450)

Update Xamarin.Forms.Platform.Android/Forms.cs

Does this do all the suggestions?

Co-Authored-By: kingces95 <kingces95@users.noreply.github.com>
ContextCompat.getColor if API < 23

5 years ago[UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)
Shane Neuville [Thu, 7 Mar 2019 17:17:43 +0000 (10:17 -0700)]
[UWP] Roll back PR 3400 so the correct context is passed into Tapped (#5476)

* [UWP] pass the correct object to ItemView

* - remove object from source

5 years ago[XamlC] throw on invalid DataType (#5335)
Stephane Delcroix [Wed, 6 Mar 2019 08:39:12 +0000 (09:39 +0100)]
[XamlC] throw on invalid DataType (#5335)

Invalid x:DataType was ignored up to now. Change the behavior so it
throws a XPE.

- fixes #5330

5 years agoMerge branch '4.0.0'
Samantha Houts [Wed, 6 Mar 2019 00:54:49 +0000 (16:54 -0800)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Wed, 6 Mar 2019 00:54:26 +0000 (16:54 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agoUwp restart uitests on crash (#5420)
Shane Neuville [Tue, 5 Mar 2019 18:07:57 +0000 (11:07 -0700)]
Uwp restart uitests on crash (#5420)

* [UWP] if a UI tests crashes the UWP window this will restart the window so all the rest of the tests can run

* simplify

5 years ago[iOS] Check new element before creating placeholder label (#5432)
E.Z. Hart [Tue, 5 Mar 2019 18:06:27 +0000 (11:06 -0700)]
[iOS] Check new element before creating placeholder label (#5432)

* Check new element before creating placeholder label

* additional checks

* create placeholder once

5 years ago[Android] remove android specific target (#5442)
Shane Neuville [Mon, 4 Mar 2019 23:43:22 +0000 (16:43 -0700)]
[Android] remove android specific target (#5442)

* [Android] get rid of specific android targets

* change to AndroidApplication

* remove before/after targets

* MonoAndroid

5 years agoMerge branch '4.0.0'
Samantha Houts [Sat, 2 Mar 2019 03:17:26 +0000 (19:17 -0800)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Sat, 2 Mar 2019 03:16:42 +0000 (19:16 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agofix changed apis (#5426)
Shane Neuville [Sat, 2 Mar 2019 03:15:08 +0000 (20:15 -0700)]
fix changed apis (#5426)

* fix changed apis

* increment language version

* bring some back

* update font

* VisualElement fixes

fixes #4644
fixes #5170

5 years agoupdate readme to include vs for mac instructions (#5419)
Shane Neuville [Sat, 2 Mar 2019 01:10:02 +0000 (18:10 -0700)]
update readme to include vs for mac instructions (#5419)

5 years agoFix WPFResources, EntryCell (#5361)
Matthijs ter Woord [Fri, 1 Mar 2019 23:49:49 +0000 (00:49 +0100)]
Fix WPFResources, EntryCell (#5361)

Also bind Isenabled
fixes #5360

5 years ago[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)
Gerald Versluis [Fri, 1 Mar 2019 23:47:31 +0000 (00:47 +0100)]
[C, iOS, AND, UWP] TabbedPage SelectedTabColor and UnselectedTabColor (#4899)

* Implemented Core and iOS

* Implemented Android

* Supressed platform specific obsolete warnings for now

* Implemented UWP

* Make selected page on UWP not rely on title

* Review feedback

* Removed references to (now) obsolete members

* Review feedback fixes

* Code review feedback

* Changed obsolete msg to reflect right XF version

* Apply suggestions from code review

Co-Authored-By: jfversluis <github@geraldversluis.nl>
fixes #3478

5 years agoMerge branch '4.0.0'
Samantha Houts [Fri, 1 Mar 2019 18:08:12 +0000 (10:08 -0800)]
Merge branch '4.0.0'

5 years agoMerge branch '3.6.0' into 4.0.0
Samantha Houts [Fri, 1 Mar 2019 18:07:45 +0000 (10:07 -0800)]
Merge branch '3.6.0' into 4.0.0

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Fri, 1 Mar 2019 18:06:34 +0000 (10:06 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years agofixed crash (#5363)
Andrei [Fri, 1 Mar 2019 18:06:08 +0000 (21:06 +0300)]
fixed crash (#5363)

5 years agoReverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping...
Samantha Houts [Fri, 1 Mar 2019 17:59:21 +0000 (09:59 -0800)]
Reverts "[Xaml] require escaping curly braces (#4723)" and "[X] only require escaping if starts with '{' (#5169)" (#5424)

* Revert "[X] only require escaping if starts with '{' (#5169)"

This reverts commit cd73391c3a2d7ff60a95449cac255c1425e81a43.

* Revert "[Xaml] require escaping curly braces (#4723)"

This reverts commit 6753ace40e68f8aa6d45eefa90117f5650984c6f.

* Make sure parsing doesn't fail when there *are* curly braces now

5 years ago[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987
Pavel Yakovlev [Fri, 1 Mar 2019 17:22:18 +0000 (20:22 +0300)]
[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987

5 years agoMerge branch '3.6.0'
Samantha Houts [Fri, 1 Mar 2019 02:12:27 +0000 (18:12 -0800)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Fri, 1 Mar 2019 02:10:53 +0000 (18:10 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years ago[X] bubble markup exception to previewer (#5411)
Stephane Delcroix [Fri, 1 Mar 2019 00:17:13 +0000 (01:17 +0100)]
[X] bubble markup exception to previewer (#5411)

- fixes #5407

5 years agoFix iOS EmptyView crash; properly handle EmptyView swapping (#5353)
E.Z. Hart [Thu, 28 Feb 2019 20:02:49 +0000 (13:02 -0700)]
Fix iOS EmptyView crash; properly handle EmptyView swapping (#5353)

5 years ago[X] allow previewer fallback on rootnode (#5413)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)

* [X] allow previewer fallback on rootnode

- fixes #5410

* additional test case

5 years ago[X] allow previewer fallback on rootnode (#5413)
Stephane Delcroix [Thu, 28 Feb 2019 19:41:34 +0000 (20:41 +0100)]
[X] allow previewer fallback on rootnode (#5413)

* [X] allow previewer fallback on rootnode

- fixes #5410

* additional test case

5 years ago[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible...
Shane Neuville [Thu, 28 Feb 2019 18:57:20 +0000 (11:57 -0700)]
[Android] Remove changes to IVisualElementRenderer so it remains backwards compatible (#5398)

* return IVisualElementRenderer to previous state

* set to internal

5 years agopreviewer; PageRenderer trap for missing bg image (#5342)
kingces95 [Thu, 28 Feb 2019 02:32:57 +0000 (16:32 -1000)]
previewer; PageRenderer trap for missing bg image (#5342)

* previewer; PageRenderer trap for missing bg image

* previewer; PageRenderer trap for missing bg image

* fix macOS; remove ext for macOS

fixes #5300

5 years agoMerge branch '3.6.0'
Samantha Houts [Thu, 28 Feb 2019 02:22:37 +0000 (18:22 -0800)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Thu, 28 Feb 2019 02:21:59 +0000 (18:21 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years ago[iOS, Android] Prevent NREs in ScrollViews (#5383)
Samantha Houts [Thu, 28 Feb 2019 02:08:47 +0000 (18:08 -0800)]
[iOS, Android] Prevent NREs in ScrollViews (#5383)

* Add null checks on new code paths added in #4522

fixes #5161

* Fix cast...

Fixes #5247

5 years agoAllow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the Recycler...
E.Z. Hart [Thu, 28 Feb 2019 02:06:48 +0000 (19:06 -0700)]
Allow SelectableItemsViewRenderer/Adapted to deselect ViewHolders not in the RecyclerView's child collection (#5358)

Fixes #5078

5 years ago[X] more conv exception, bubble to previewer (#5400)
Stephane Delcroix [Thu, 28 Feb 2019 01:58:58 +0000 (02:58 +0100)]
[X] more conv exception, bubble to previewer (#5400)

Catch more exception cases, make sure the previewer can recover from them

- fixes #5397

5 years ago[Android, iOS] added re-measure of TimePicker after change value (#4999)
Pavel Yakovlev [Thu, 28 Feb 2019 01:49:11 +0000 (04:49 +0300)]
[Android, iOS] added re-measure of TimePicker after change value (#4999)

5 years agoMerge branch '3.6.0'
ShaneN [Thu, 28 Feb 2019 01:20:24 +0000 (18:20 -0700)]
Merge branch '3.6.0'

5 years ago[UITests] remove extra reference
ShaneN [Thu, 28 Feb 2019 01:19:57 +0000 (18:19 -0700)]
[UITests]  remove extra reference

5 years ago[Android] move android renderers to separate nuget (#5405)
Shane Neuville [Thu, 28 Feb 2019 01:04:52 +0000 (18:04 -0700)]
[Android] move android renderers to separate nuget (#5405)

* [Android] move renderers to separate nuget

* additional android dependency

* rebase with material changes

* add android to material check

* simplify assembly info

* - add context to Init for future cases

5 years ago[Visual] Visual tidy (#5356)
Shane Neuville [Wed, 27 Feb 2019 23:48:45 +0000 (16:48 -0700)]
[Visual] Visual tidy (#5356)

* [Visual] remove visual flag and tidy up code

* - added basic loading ui test

* change material namespaces to be Xamarin.Forms.Material.<Platform>

* api 19 fixes

* fix casing on resources

5 years agodirectly load specified Font Family or other valid PostScript Font Name fixes #5372...
Dan Siegel [Wed, 27 Feb 2019 21:20:14 +0000 (13:20 -0800)]
directly load specified Font Family or other valid PostScript Font Name fixes #5372 (#5373)

5 years agoFix the issue when building on a mac (#5406)
Matthew Leibowitz [Wed, 27 Feb 2019 21:03:40 +0000 (23:03 +0200)]
Fix the issue when building on a mac (#5406)

- mac should not build this assembly, but as it has to do so, exclude everything

5 years agofix https://github.com/xamarin/Xamarin.Forms/issues/5346 (#5379)
Andrei [Wed, 27 Feb 2019 21:02:49 +0000 (00:02 +0300)]
fix https://github.com/xamarin/Xamarin.Forms/issues/5346 (#5379)

5 years ago[C] deprecate GetValues (#5324)
Stephane Delcroix [Wed, 27 Feb 2019 07:56:27 +0000 (08:56 +0100)]
[C] deprecate GetValues (#5324)

* [C] deprecate GetValues

Deprecate GetValues, as it no longer make snes now that the properties
store is a Dictionary and no longer a List.

Update the code to be C#7-ish.

Take this refactoring opportunity to move similar method next to each other.

- fixes #5015

* Apply suggestions from code review

Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
5 years agoBindableProperty: More explanatory exception message (#5384)
Andrei Nitescu [Wed, 27 Feb 2019 07:55:47 +0000 (09:55 +0200)]
BindableProperty: More explanatory exception message (#5384)

5 years ago[UWP] fix so tests are compatible with UWP (#4984)
Shane Neuville [Wed, 27 Feb 2019 00:58:40 +0000 (17:58 -0700)]
[UWP] fix so tests are compatible with UWP (#4984)

* [UWP] fix so tests are compatible with UWP

* [UWP] when UI tests run don't load issues list

* [uwp] add preload of tests back in

* added UWP Ignore

5 years ago[Visual] Material Editor (#5345)
Shane Neuville [Tue, 26 Feb 2019 19:46:48 +0000 (12:46 -0700)]
[Visual] Material Editor (#5345)

* [Material] Visual

* - gallery and simplify android renderers

* Update Xamarin.Forms.Material.iOS/MaterialEditorRenderer.cs

* Update Xamarin.Forms.Platform.Android/Material/MaterialEditorRenderer.cs

* wire up done and fix ph bug

* - ios fix auto sizing issues

* fix NRE

* - Android: fix bounce and IsreadOnly
- iOS: fix IsReadonly and sizing issue

* - fix editor

* Fix ios Editor to shrink when lines are deleted

* Update Xamarin.Forms.Material.iOS/MaterialMultiLineTextField.cs

* - formatting fixes

5 years agoMerge branch '3.6.0'
Stephane Delcroix [Tue, 26 Feb 2019 19:12:27 +0000 (20:12 +0100)]
Merge branch '3.6.0'

5 years ago[previewer] resilience on createvalue (#5369)
Stephane Delcroix [Tue, 26 Feb 2019 19:09:16 +0000 (20:09 +0100)]
[previewer] resilience on createvalue (#5369)

- fixes #5171

5 years ago[X] wrap typeconverter exceptions in XPE (#5388)
Stephane Delcroix [Tue, 26 Feb 2019 19:07:17 +0000 (20:07 +0100)]
[X] wrap typeconverter exceptions in XPE (#5388)

- fixes #5378

5 years ago[Visual] Check if assembly is dynamic before calling GetExportedTypes (#5389)
Shane Neuville [Tue, 26 Feb 2019 17:38:10 +0000 (10:38 -0700)]
[Visual] Check if assembly is dynamic before calling GetExportedTypes (#5389)

* check if assembly is dynamic

* add filenotfound catch

5 years ago[Android] add build error if TargetFramework is too low (#5350)
Shane Neuville [Tue, 26 Feb 2019 17:22:48 +0000 (10:22 -0700)]
[Android] add build error if TargetFramework is too low (#5350)

* [Android] add build error if TargetFramework is to low

* change to Corecompile

* add disable condition

5 years agoVisual equality (#5380)
Matthew Leibowitz [Tue, 26 Feb 2019 13:59:29 +0000 (15:59 +0200)]
Visual equality (#5380)

No one gets to go to the top, not even the great Material Design. All pages are equal, and are listed alphabetically.

5 years ago[Visual] Visual xaml and Visual registrations (#5304)
Shane Neuville [Mon, 25 Feb 2019 20:54:02 +0000 (13:54 -0700)]
[Visual] Visual xaml and Visual registrations (#5304)

* [visual] add intellisense popups for visual

* Add visual registrations into type converter

* combine VisualMarker and VisualRendererMarker

* remove visual from class name for intellisense

* set Match Parent to internal

* Remove register code and just scan assemblies

* [Visual] Add Visual Attribute and some additional attribute checks

* remove registrar changes

* renamed to specific VisualTypes

* - move check up to LINQ statement

* Make sure the other platforms can create visuals

* fix renderer names

* move stepper renderer

* rename converter

5 years agoUpdate BindableLayout.cs to fix #5213 (#5243)
Jeremy Marcus [Mon, 25 Feb 2019 19:44:00 +0000 (14:44 -0500)]
Update BindableLayout.cs to fix #5213 (#5243)

- fixes #5213

* Add Test for BindableLayout RemoveAll

* Update BindableLayout.cs to fix RemoveAll exception

* Missing using statements

5 years ago┬──┬◡ノ(° -°ノ)
Stephane Delcroix [Mon, 25 Feb 2019 09:46:32 +0000 (10:46 +0100)]
┬──┬◡ノ(° -°ノ)

5 years agoMerge branch '3.6.0'
Stephane Delcroix [Mon, 25 Feb 2019 07:33:25 +0000 (08:33 +0100)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Stephane Delcroix [Mon, 25 Feb 2019 07:20:29 +0000 (08:20 +0100)]
Merge branch '3.5.0' into 3.6.0

5 years ago[Visual] Material Pickers (#5194)
Shane Neuville [Mon, 25 Feb 2019 03:21:39 +0000 (20:21 -0700)]
[Visual] Material Pickers (#5194)

* [Material] Change Picker EditText fields to Material

* [Visual] add material placeholder properties

* - add ios placeholder changes

* - remove placeholder apis

* - shrink entry fields when they have no place holder

* - invalidate measure

* - remove marshalling

5 years ago[Android CollectionView] Fixes crash when ItemSource Changed (#5146)
Pavel Yakovlev [Sun, 24 Feb 2019 18:00:31 +0000 (21:00 +0300)]
[Android CollectionView] Fixes crash when ItemSource Changed (#5146)

5 years ago[Android iOS Visual] fixes background in ActivityIndicator (#5283)
Pavel Yakovlev [Sat, 23 Feb 2019 09:30:47 +0000 (12:30 +0300)]
[Android iOS Visual] fixes background in ActivityIndicator (#5283)

* [Android, iOS Visual] fixes background in AcrivityIndicator

* [Android] reduce nesting layouts

* [Android] simplification

* Some calculations for iOS

* [Android] removed padding, added size limit
[iOS] fixes stroke width

* [iOS] default size as in Android

* Use the Android ratio of 10 instead of the spec of 12

* [Android] fix API23

* [iOS] fix unexpected padding

* [Android] fixes padding in API 23 -- IsRunning -- added gallery

* [Android] fixes start with IsRunning = false

* [Android] again fix isRunning

* address comments

5 years ago[Material] [Android, iOS] Materializing the stepper (#5027)
Matthew Leibowitz [Fri, 22 Feb 2019 19:51:45 +0000 (21:51 +0200)]
[Material] [Android, iOS] Materializing the stepper (#5027)

* [Android] [Material] Refactored the Stepper on Android #5011
 - reuse code between default and material
 - added material stepper

* [Android] [Material] Using the "Fast" renderer style for the stepper #5011
 - switched the button style to the outlined buttons

* [Android] [Material] Adding the tab stops support (#5000)

* [Android] [Material] Switching back to a traditional renderer for now to get tabstops working

* [Material] [iOS] Added a Material stepper for iOS

* [Material] [Android, iOS] Addressed the PR feedback

* [Material] Remove private

* Update MaterialStepperRenderer.cs

* Update StepperRendererManager.cs

* Fixed the merge issues

* add steppers to visual gallery

* The material stepper buttons now resize to fit the available space.

* Update Xamarin.Forms.Controls/ControlGalleryPages/VisualGallery.xaml

Co-Authored-By: mattleibow <mattleibow@live.com>
* [Material] [Stepper] Don't set the background color for steppers
 - we still need to decide on the logic behind the coloring of outline buttons

* Fixed the Android accessibility

* Change UI tests to not use a Text search for locating stepper controls

5 years ago[Material] rename iOS assembly to be non platform specific (#5332)
Shane Neuville [Fri, 22 Feb 2019 15:29:25 +0000 (08:29 -0700)]
[Material] rename iOS assembly to be non platform specific (#5332)

* [Material] rename iOS assembly

* fix title and Internals Visible To

5 years agoAdd UI test to B41600 (#5174)
Ione Souza Junior [Fri, 22 Feb 2019 01:08:31 +0000 (22:08 -0300)]
Add UI test to B41600 (#5174)

5 years ago[CSS] fix mapping for vertical-align (#5275)
Stephane Delcroix [Fri, 22 Feb 2019 00:59:48 +0000 (01:59 +0100)]
[CSS] fix mapping for vertical-align (#5275)

5 years ago[XamlC] Identify generic instance types correctly when importing ctor (#5309)
Akihiko Odaki [Fri, 22 Feb 2019 00:56:42 +0000 (09:56 +0900)]
[XamlC] Identify generic instance types correctly when importing ctor (#5309)

The old implementation fails to identify generic instance types for typed
binding getter, whose type is:
System.Func`2<TSource, ValueTuple<TProperty, bool>>

This fixes the issue by taking generic arguments into account.

5 years ago[Android] Fix SearchBar renderer height on API24 (#5329)
Rui Marinho [Fri, 22 Feb 2019 00:23:32 +0000 (00:23 +0000)]
[Android] Fix SearchBar renderer height on API24 (#5329)

5 years ago[Android] Include default proguard file so user doesn't have to create rules for...
Shane Neuville [Thu, 21 Feb 2019 20:22:39 +0000 (15:22 -0500)]
[Android] Include default proguard file so user doesn't have to create rules for XF (#5143)

* [2709] Add default proguard config file

* add proguard.cfg file to nuspec

5 years agoFix NRE in Android ResourceManager when reference resource in Previewer (#5331)
Tim Barham [Thu, 21 Feb 2019 01:24:18 +0000 (11:24 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5331)

Fixes part of #5300

(cherry picked from commit fb59591580ea474e7f48e5941854fd790dc5a8cb)

5 years ago[Controls] Fix Restart UITest Android
Rui Marinho [Wed, 20 Feb 2019 12:03:05 +0000 (12:03 +0000)]
[Controls] Fix Restart UITest Android

5 years ago[iOS] Fixed updating Label TextDecorations when no Text is set (#5013)
Andrei Nitescu [Tue, 19 Feb 2019 14:55:19 +0000 (16:55 +0200)]
[iOS] Fixed updating Label TextDecorations when no Text is set (#5013)

- fixes #5003
- fixes #5149
- fixes #5258

5 years ago[XamlC] compiled binding to int indexers (#5271)
Stephane Delcroix [Tue, 19 Feb 2019 14:26:30 +0000 (15:26 +0100)]
[XamlC] compiled binding to int indexers (#5271)

- fixes #5254

5 years ago[XamlC] avoid cast exception on overriden members (#5269)
Stephane Delcroix [Tue, 19 Feb 2019 14:25:51 +0000 (15:25 +0100)]
[XamlC] avoid cast exception on overriden members (#5269)

avoid InvalidCastException if an event is overriden with the new keyword
to a bindableproperty. Kids, DO NOT EVER DO THIS AT HOME.

- fixes #5256 for XamlC

5 years ago[iOS] Fix the layout of the button (#5221) * fixes #5160
Matthew Leibowitz [Tue, 19 Feb 2019 12:36:59 +0000 (14:36 +0200)]
[iOS] Fix the layout of the button (#5221) * fixes #5160

- it appears that iOS has a nice little delay when setting the title to the layout

5 years agoFix NRE in Android ResourceManager when reference resource in Previewer (#5305)
Tim Barham [Tue, 19 Feb 2019 11:34:26 +0000 (21:34 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5305)

Fixes part of #5300

5 years agoAdd (passing) test for #5290
Stephane Delcroix [Tue, 19 Feb 2019 10:17:02 +0000 (11:17 +0100)]
Add (passing) test for #5290

5 years agoRevert "Update Forms.cs"
Alan McGovern [Tue, 19 Feb 2019 08:56:36 +0000 (08:56 +0000)]
Revert "Update Forms.cs"

This reverts commit e4fa2c0603dab511fef9cb72daa2a4a5c6222082.

5 years agoUpdate Forms.cs
Alan McGovern [Tue, 19 Feb 2019 08:56:08 +0000 (08:56 +0000)]
Update Forms.cs

If you want a foolproof way of getting a reference to the assembly from
the Android head project, then just use the EntryAssembly
property of the AppDomain.

5 years agoFix dynamic resources in merged dictionaries #3661 (#4993) * fixes #3661
Patrick Allwood [Mon, 18 Feb 2019 14:57:23 +0000 (14:57 +0000)]
Fix dynamic resources in merged dictionaries #3661 (#4993) * fixes #3661

5 years agoMerge branch '3.6.0'
Stephane Delcroix [Mon, 18 Feb 2019 11:49:32 +0000 (12:49 +0100)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Stephane Delcroix [Mon, 18 Feb 2019 11:49:11 +0000 (12:49 +0100)]
Merge branch '3.5.0' into 3.6.0

5 years ago[C] Binding null on nullable (#5255)
Stephane Delcroix [Thu, 14 Feb 2019 19:08:16 +0000 (20:08 +0100)]
[C] Binding null on nullable (#5255)

* fixes #5274

bindings should allow null for nullable valuetypes!

* [C] Binding null on nullable

@kicsiede's fix for #5242, plus unit test, targetted to 3.6.0

- closes #5242

5 years ago[iOS] add single parameter constructor back (#5281) * fixes #5278
Shane Neuville [Mon, 18 Feb 2019 11:31:55 +0000 (04:31 -0700)]
[iOS] add single parameter constructor back (#5281) * fixes #5278

5 years agoSetup sandbox app inside our project (#5264)
Shane Neuville [Mon, 18 Feb 2019 11:30:08 +0000 (04:30 -0700)]
Setup sandbox app inside our project (#5264)

* [Visual] Material Pickers and setup sandbox app

* Fixed the ambiguous types for UWP

5 years ago[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)
Kevin Petit [Mon, 18 Feb 2019 11:24:26 +0000 (12:24 +0100)]
[Android] Fix ObjectDisposedException on MasterDetailPageRenderer update (#4955)

* Android - MasterDetailPageRenderer - Fix ObjectDisposedException on update.

* Fix update call to master.

* Move checks inside update methods.
Add HandleMasterPropertyChanged handler unsubscribing.

5 years ago[MacOs] Slider inside StackLayout Horizontal Orientation crash (#5191) * fixes #3610
Andrei [Mon, 18 Feb 2019 11:21:54 +0000 (14:21 +0300)]
[MacOs] Slider inside StackLayout Horizontal Orientation crash (#5191) * fixes #3610

* fix https://github.com/xamarin/Xamarin.Forms/issues/3610

* updated default size

* Added info comment

5 years agoImplement FlowDirection propagation to items in CollectionView (#5051) * fixes #4583
E.Z. Hart [Mon, 18 Feb 2019 11:21:10 +0000 (04:21 -0700)]
Implement FlowDirection propagation to items in CollectionView (#5051) * fixes #4583

* Implement FlowDirection propagation to items in CollectionView; fixes #4583

* Run logical child detachment via CellDisplayingEnded

* Fix Visual propagation on iOS

* Fix Visual propagation on Android

* Fix rebase error

5 years ago[Android] Set Page background color (#5066) * Fixes #5057 * closes #4916 * Fixes...
Andrei Nitescu [Mon, 18 Feb 2019 11:19:57 +0000 (13:19 +0200)]
[Android] Set Page background color (#5066) * Fixes #5057 * closes #4916 * Fixes #5073

* [Android] Fix setting Page background color

* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5057.xaml.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5057.xaml.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>
* Refactoring and added test info

* Update Xamarin.Forms.Platform.Android/Renderers/PageRenderer.cs

Co-Authored-By: andreinitescu <nitescua@yahoo.com>
5 years agoCollectionview uitest (#5231)
Rui Marinho [Mon, 18 Feb 2019 11:18:50 +0000 (11:18 +0000)]
Collectionview uitest (#5231)

* [UITests] Add basic CollectionView tests

* [UITests] Enable uitests ObservableCollectionGallery

* [UITests] Update itemssource

* Update Xamarin.Forms.Controls/GalleryPages/CollectionViewGalleries/CollectionViewGallery.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>
5 years agoMerge branch '3.6.0'
Stephane Delcroix [Mon, 18 Feb 2019 08:15:37 +0000 (09:15 +0100)]
Merge branch '3.6.0'

5 years ago[C] Binding null on nullable (#5255)
Stephane Delcroix [Thu, 14 Feb 2019 19:08:16 +0000 (20:08 +0100)]
[C] Binding null on nullable (#5255)

* fixes pull #4453

bindings should allow null for nullable valuetypes!

* [C] Binding null on nullable

@kicsiede's fix for #5242, plus unit test, targetted to 3.6.0

- closes #5242

5 years agoAdd AllowMultiple=true to QueryPropertyAttribute (#5180) (#5251)
Stephane Delcroix [Thu, 14 Feb 2019 09:54:30 +0000 (10:54 +0100)]
Add AllowMultiple=true to QueryPropertyAttribute (#5180) (#5251)

In the process of building a demo app (https://github.com/matthewrdev/xamarin-forms-4), I discovered that I could not apply multiple parameters; doing so would cause a compile-time error.

The usage of this property in ShellContent, specifically in ApplyQueryAttributes, indicates that the intended behaviour is to allow users to specify multiple URL arguments that will be applied onto the page. Changing AllowMultiple to true fixes this.

For reference, when AllowMultiple is not explicitly set, it's default value is false. See: https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/concepts/attributes/attributeusage.

5 years agoMerge branch '3.6.0'
Samantha Houts [Thu, 14 Feb 2019 00:57:13 +0000 (16:57 -0800)]
Merge branch '3.6.0'

5 years agoMerge branch '3.5.0' into 3.6.0
Samantha Houts [Thu, 14 Feb 2019 00:55:00 +0000 (16:55 -0800)]
Merge branch '3.5.0' into 3.6.0

5 years ago[Android] Fix ImageRenderer URI (#5241)
Rui Marinho [Thu, 14 Feb 2019 00:22:40 +0000 (00:22 +0000)]
[Android] Fix ImageRenderer URI (#5241)

* ignore check if imageview isn't set

* [Controls] Add repo case for #5172

* [Controls] Use xf github image url

fixes #5172

5 years agoapply Remove suggestion bar in iOS picker (#4634)
Yun Chen [Wed, 13 Feb 2019 23:42:11 +0000 (12:42 +1300)]
apply  Remove suggestion bar in iOS picker (#4634)

fixes #4629

5 years ago[Material] [Android, iOS] Added Slider and ProgressBar (#5209)
Matthew Leibowitz [Wed, 13 Feb 2019 23:36:55 +0000 (01:36 +0200)]
[Material] [Android, iOS] Added Slider and ProgressBar (#5209)

* [Android Material] Linear Progress Indicator (#5079)

Merging into the material "slider" / "progress" bar branch so that we can share some code as they are the same control

* [Material] [Slider, ProgressBar] Updated the progress bard and added the slider

* Renamed the gallery

fixes #5008
fixes #5079
fixes #5018

5 years agoFixed passing container (#5158)
Andrei Nitescu [Wed, 13 Feb 2019 23:33:14 +0000 (01:33 +0200)]
Fixed passing container (#5158)

fixes #5156

5 years agoRevert "[Android] fixes issue content set after an await is not visible (#4861)"...
Samantha Houts [Wed, 13 Feb 2019 23:21:31 +0000 (15:21 -0800)]
Revert "[Android] fixes issue content set after an await is not visible (#4861)" (#5245)

This reverts commit bf0733129dda78349c14d7cb6ae39cd61ebe2288.

5 years agoBackport some 3.6 previewer changes to 3.5 (#5227)
Stephane Delcroix [Wed, 13 Feb 2019 21:41:45 +0000 (22:41 +0100)]
Backport some 3.6 previewer changes to 3.5 (#5227)

* [X] add callback for previewer on failing ctor (#5101)

Add a callback when object instantiation or creation fails, so the
previewer can replace it by an educated guess

* Allow the previewer to use design flag on RDs (#5096)

* [Xaml] Better handling of exception on properties (#5099)

Allow the previewer to recover and continue on throwing property setters
or BindableProperties.

* [Previewer] Fallback for factorymethod not found (#5139)

- fixes #5138

* [previewer] more info to the callback (#5155)

5 years ago[iOS] Fix ImageRenderer dispose (#5222)
Rui Marinho [Wed, 13 Feb 2019 19:45:15 +0000 (19:45 +0000)]
[iOS] Fix ImageRenderer dispose (#5222)

* [iOS] Fix ViewRenderer dispose

* Revert "[iOS] Fix ViewRenderer dispose"

This reverts commit 94ee061b0cc000b527f193963e6f911b57ec34f9.

* [iOS] Fix for ImageRenderer