platform/upstream/libSkiaSharp.git
11 years agoadd kMultiply_Mode to switch statement (fix warning)
reed@google.com [Mon, 4 Feb 2013 20:46:08 +0000 (20:46 +0000)]
add kMultiply_Mode to switch statement (fix warning)

git-svn-id: http://skia.googlecode.com/svn/trunk@7556 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoland https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS...
reed@google.com [Mon, 4 Feb 2013 20:06:00 +0000 (20:06 +0000)]
land https://codereview.appspot.com/7221086/ -- add Multiply xfermode matching CSS spec

git-svn-id: http://skia.googlecode.com/svn/trunk@7553 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSimplify and speed up SkIntroSort.
bungeman@google.com [Mon, 4 Feb 2013 19:54:15 +0000 (19:54 +0000)]
Simplify and speed up SkIntroSort.
https://codereview.appspot.com/7273048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7552 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCommit file missing from r7550
bsalomon@google.com [Mon, 4 Feb 2013 18:46:49 +0000 (18:46 +0000)]
Commit file missing from r7550

git-svn-id: http://skia.googlecode.com/svn/trunk@7551 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix GLPrograms test on ANGLE bot.
bsalomon@google.com [Mon, 4 Feb 2013 18:39:24 +0000 (18:39 +0000)]
Attempt to fix GLPrograms test on ANGLE bot.

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7281050

git-svn-id: http://skia.googlecode.com/svn/trunk@7550 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGo from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
reed@google.com [Mon, 4 Feb 2013 18:21:23 +0000 (18:21 +0000)]
Go from a 1x2 to a 2x2 dither cell, and change/simplify the logic for how we
compute the "dithered" version of a color to just a graduated fixed-point-round.
Also, add this new dither to conical and sweep, which before had no dithering.

Disabled for now using SK_IGNORE_GRADIENT_DITHER_FIX. Will enable this and
and rebaseline skia.

http://code.google.com/p/skia/issues/detail?id=1098
Review URL: https://codereview.appspot.com/7248046

git-svn-id: http://skia.googlecode.com/svn/trunk@7549 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoextend gradient_create bench to test opaque and alpha gradient ramps
reed@google.com [Mon, 4 Feb 2013 18:09:58 +0000 (18:09 +0000)]
extend gradient_create bench to test opaque and alpha gradient ramps

git-svn-id: http://skia.googlecode.com/svn/trunk@7548 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocleanup: use DEF_BENCH macro
reed@google.com [Mon, 4 Feb 2013 18:00:54 +0000 (18:00 +0000)]
cleanup: use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7547 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix unused variable warning
reed@google.com [Mon, 4 Feb 2013 17:59:02 +0000 (17:59 +0000)]
fix unused variable warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7546 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement support for origin-TopLeft render targets in GL backend.
senorblanco@chromium.org [Mon, 4 Feb 2013 17:29:51 +0000 (17:29 +0000)]
Implement support for origin-TopLeft render targets in GL backend.

Review URL: https://codereview.appspot.com/7230049

git-svn-id: http://skia.googlecode.com/svn/trunk@7545 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new gms for shallow_gradient, in preparation for improving their quality
reed@google.com [Mon, 4 Feb 2013 16:56:15 +0000 (16:56 +0000)]
add new gms for shallow_gradient, in preparation for improving their quality

git-svn-id: http://skia.googlecode.com/svn/trunk@7544 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange comment to avoid warning (don't end line comment with '\').
bungeman@google.com [Mon, 4 Feb 2013 16:24:44 +0000 (16:24 +0000)]
Change comment to avoid warning (don't end line comment with '\').

git-svn-id: http://skia.googlecode.com/svn/trunk@7542 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Mon, 4 Feb 2013 16:22:06 +0000 (16:22 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7541 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GPU unit tests use GrContexts of different GL types.
bsalomon@google.com [Mon, 4 Feb 2013 16:13:32 +0000 (16:13 +0000)]
Make GPU unit tests use GrContexts of different GL types.
Review URL: https://codereview.appspot.com/7281046

git-svn-id: http://skia.googlecode.com/svn/trunk@7540 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd sk_ignore_unused_variable to avoid warnings.
bungeman@google.com [Mon, 4 Feb 2013 15:58:08 +0000 (15:58 +0000)]
Add sk_ignore_unused_variable to avoid warnings.
https://codereview.appspot.com/7218045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7539 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
reed@google.com [Mon, 4 Feb 2013 14:57:28 +0000 (14:57 +0000)]
add benchmark for stroked drawRect/drawOval/drawRRect, to prepare for optimizing
those based on special-casing stroking for single-contour-convex shapes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7537 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 4 Feb 2013 14:06:49 +0000 (14:06 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7535 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Mon, 4 Feb 2013 12:57:42 +0000 (12:57 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7533 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove kStyleCount out of Style enum, and into its own, to avoid
mike@reedtribe.org [Mon, 4 Feb 2013 05:17:10 +0000 (05:17 +0000)]
move kStyleCount out of Style enum, and into its own, to avoid
1. someone passing kStyleCount as a parameter
2. warnings about not handling all enum values in a switch

We should probably move to remove kCountFoo from all of our enums for these reasons.

git-svn-id: http://skia.googlecode.com/svn/trunk@7532 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse DEF_BENCH macro
mike@reedtribe.org [Mon, 4 Feb 2013 05:05:36 +0000 (05:05 +0000)]
use DEF_BENCH macro

git-svn-id: http://skia.googlecode.com/svn/trunk@7531 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle...
rmistry@google.com [Sun, 3 Feb 2013 21:04:27 +0000 (21:04 +0000)]
Rebaselined webpage image GMs for ['base-shuttle_ubuntu12_ati5770', 'base-shuttle-win7-intel-float', 'base-shuttle-win7-intel-angle', 'base-shuttle-win7-intel-directwrite'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7530 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAccelerate handling of clipRRect in calls to SkPictureUtils::GatherPixelRefs
junov@chromium.org [Fri, 1 Feb 2013 20:39:48 +0000 (20:39 +0000)]
Accelerate handling of clipRRect in calls to SkPictureUtils::GatherPixelRefs

BUG=https://code.google.com/p/chromium/issues/detail?id=173718
Review URL: https://codereview.appspot.com/7252048

git-svn-id: http://skia.googlecode.com/svn/trunk@7527 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: report max-pixel-error if comparing against PNG files (not checksums)
epoger@google.com [Fri, 1 Feb 2013 20:39:15 +0000 (20:39 +0000)]
gm: report max-pixel-error if comparing against PNG files (not checksums)
Review URL: https://codereview.appspot.com/7241064

git-svn-id: http://skia.googlecode.com/svn/trunk@7526 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove dither toggle logic into common helper functions, to make it easier to
reed@google.com [Fri, 1 Feb 2013 19:34:59 +0000 (19:34 +0000)]
Move dither toggle logic into common helper functions, to make it easier to
change their behavior later. No functional change.
Review URL: https://codereview.appspot.com/7241063

git-svn-id: http://skia.googlecode.com/svn/trunk@7525 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agolanding https://codereview.appspot.com/7225077/ -- tweak for GIF 5.x api
reed@google.com [Fri, 1 Feb 2013 19:05:48 +0000 (19:05 +0000)]
landing https://codereview.appspot.com/7225077/ -- tweak for GIF 5.x api

git-svn-id: http://skia.googlecode.com/svn/trunk@7523 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix init order warning
bsalomon@google.com [Fri, 1 Feb 2013 18:42:50 +0000 (18:42 +0000)]
Fix init order warning

git-svn-id: http://skia.googlecode.com/svn/trunk@7522 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove the kMultiply_Mode alias for kModulate_Mode. We plan to re-target kMultiply_Mode
reed@google.com [Fri, 1 Feb 2013 16:44:50 +0000 (16:44 +0000)]
remove the kMultiply_Mode alias for kModulate_Mode. We plan to re-target kMultiply_Mode
in the future, to match the CSS spec.

git-svn-id: http://skia.googlecode.com/svn/trunk@7518 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrevent SkPictureUtils::GatherPixelRefs from generating bitmaps from gradient
junov@google.com [Fri, 1 Feb 2013 16:41:47 +0000 (16:41 +0000)]
Prevent SkPictureUtils::GatherPixelRefs from generating bitmaps from gradient
shaders.

BUG=https://code.google.com/p/chromium/issues/detail?id=173657
Review URL: https://codereview.appspot.com/7220074

git-svn-id: http://skia.googlecode.com/svn/trunk@7517 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly support SkPicture abort for Android due to the fragility of the existing API
djsollen@google.com [Fri, 1 Feb 2013 16:18:09 +0000 (16:18 +0000)]
Only support SkPicture abort for Android due to the fragility of the existing API

Review URL: https://codereview.appspot.com/7225083

git-svn-id: http://skia.googlecode.com/svn/trunk@7515 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android errors when unflattening an SkImageRef_ashmem object.
djsollen@google.com [Fri, 1 Feb 2013 15:57:13 +0000 (15:57 +0000)]
Fix android errors when unflattening an SkImageRef_ashmem object.

Review URL: https://codereview.appspot.com/7228071

git-svn-id: http://skia.googlecode.com/svn/trunk@7514 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix unused var warning-as-error
bsalomon@google.com [Fri, 1 Feb 2013 15:42:59 +0000 (15:42 +0000)]
Fix unused var warning-as-error

git-svn-id: http://skia.googlecode.com/svn/trunk@7513 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't use NULL when comparing against ints/size_t (fixes warning)
reed@google.com [Fri, 1 Feb 2013 15:05:18 +0000 (15:05 +0000)]
don't use NULL when comparing against ints/size_t (fixes warning)

git-svn-id: http://skia.googlecode.com/svn/trunk@7512 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd width() and height() helpers
reed@google.com [Fri, 1 Feb 2013 15:01:24 +0000 (15:01 +0000)]
add width() and height() helpers

git-svn-id: http://skia.googlecode.com/svn/trunk@7511 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorevert name changes to SkBlendImageFilter. It (correctly) named its enum kMultiply_Mode,
reed@google.com [Fri, 1 Feb 2013 14:35:09 +0000 (14:35 +0000)]
revert name changes to SkBlendImageFilter. It (correctly) named its enum kMultiply_Mode,
and handled that itself internally, rather than calling SkXfermode. This CL removes
the kModulate_Mode alias from its list.

git-svn-id: http://skia.googlecode.com/svn/trunk@7509 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake drawIndexedInstances non-virtual and rewrite GrIODB's drawRect on top of drawInd...
bsalomon@google.com [Fri, 1 Feb 2013 14:19:27 +0000 (14:19 +0000)]
Make drawIndexedInstances non-virtual and rewrite GrIODB's drawRect on top of drawIndexedInstances.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7221078

git-svn-id: http://skia.googlecode.com/svn/trunk@7508 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.
rmistry@google.com [Fri, 1 Feb 2013 14:12:49 +0000 (14:12 +0000)]
Rebaselined webpage image GMs for ['base-shuttle-win7-intel-angle'] on Google Storage.

git-svn-id: http://skia.googlecode.com/svn/trunk@7507 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorestore cache-count for gradients to p.o.2. so we can perform fancier dithering
reed@google.com [Fri, 1 Feb 2013 12:59:40 +0000 (12:59 +0000)]
restore cache-count for gradients to p.o.2. so we can perform fancier dithering
in the future.
Review URL: https://codereview.appspot.com/7254043

git-svn-id: http://skia.googlecode.com/svn/trunk@7506 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange vertex buffer allocator functions to take size rather than layout, take two.
jvanverth@google.com [Thu, 31 Jan 2013 21:34:25 +0000 (21:34 +0000)]
Change vertex buffer allocator functions to take size rather than layout, take two.
Resubmission of r7498.

https://codereview.appspot.com/7228078

git-svn-id: http://skia.googlecode.com/svn/trunk@7501 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix warnings resulting from 7496.
bungeman@google.com [Thu, 31 Jan 2013 20:36:30 +0000 (20:36 +0000)]
Fix warnings resulting from 7496.

git-svn-id: http://skia.googlecode.com/svn/trunk@7500 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 31 Jan 2013 20:28:24 +0000 (20:28 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7499 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange vertex buffer allocator functions to take size rather than layout.
jvanverth@google.com [Thu, 31 Jan 2013 20:15:36 +0000 (20:15 +0000)]
Change vertex buffer allocator functions to take size rather than layout.

https://codereview.appspot.com/7228078

git-svn-id: http://skia.googlecode.com/svn/trunk@7498 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SHA1 and MD5 to utils.
bungeman@google.com [Thu, 31 Jan 2013 19:47:48 +0000 (19:47 +0000)]
Add SHA1 and MD5 to utils.
https://codereview.appspot.com/7071055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7496 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded cast to make SkIntToScalar happy with size_t in debug (in SkDrawCommand.cpp)
robertphillips@google.com [Thu, 31 Jan 2013 16:52:43 +0000 (16:52 +0000)]
Added cast to make SkIntToScalar happy with size_t in debug (in SkDrawCommand.cpp)

git-svn-id: http://skia.googlecode.com/svn/trunk@7495 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoved unused variable
robertphillips@google.com [Thu, 31 Jan 2013 16:45:43 +0000 (16:45 +0000)]
Removed unused variable

git-svn-id: http://skia.googlecode.com/svn/trunk@7494 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: force all pixels opaque earlier in the process
epoger@google.com [Thu, 31 Jan 2013 16:30:55 +0000 (16:30 +0000)]
gm: force all pixels opaque earlier in the process
Review URL: https://codereview.appspot.com/7251043

git-svn-id: http://skia.googlecode.com/svn/trunk@7493 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate filter tool to allow more flexible filtering
robertphillips@google.com [Thu, 31 Jan 2013 15:56:22 +0000 (15:56 +0000)]
Update filter tool to allow more flexible filtering

https://codereview.appspot.com/7227055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7492 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agooptimize region::intersect when one wholly contains the other
reed@google.com [Thu, 31 Jan 2013 15:24:24 +0000 (15:24 +0000)]
optimize region::intersect when one wholly contains the other

clone of https://codereview.appspot.com/7237055/

git-svn-id: http://skia.googlecode.com/svn/trunk@7491 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new test for region::intersect, when one is a rect, and it wholly contains
reed@google.com [Thu, 31 Jan 2013 15:23:44 +0000 (15:23 +0000)]
add new test for region::intersect, when one is a rect, and it wholly contains
a complex region.

git-svn-id: http://skia.googlecode.com/svn/trunk@7490 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-tests: add 565 mode testing, in addition to 8888 mode
epoger@google.com [Thu, 31 Jan 2013 15:06:36 +0000 (15:06 +0000)]
gm self-tests: add 565 mode testing, in addition to 8888 mode
Review URL: https://codereview.appspot.com/7229061

git-svn-id: http://skia.googlecode.com/svn/trunk@7489 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAll skp files in Google Storage have been updated (AddDashboardAnnotation)
rmistry@google.com [Thu, 31 Jan 2013 14:17:14 +0000 (14:17 +0000)]
All skp files in Google Storage have been updated (AddDashboardAnnotation)

git-svn-id: http://skia.googlecode.com/svn/trunk@7487 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds after r7485
rmistry@google.com [Thu, 31 Jan 2013 12:18:51 +0000 (12:18 +0000)]
Whitespace change to trigger rebuilds after r7485

git-svn-id: http://skia.googlecode.com/svn/trunk@7486 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 31 Jan 2013 07:06:15 +0000 (07:06 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7484 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSpeculative change to SkImageFilterUtils.cpp to try to get compiling in Chrome
robertphillips@google.com [Thu, 31 Jan 2013 02:33:09 +0000 (02:33 +0000)]
Speculative change to SkImageFilterUtils.cpp to try to get compiling in Chrome

git-svn-id: http://skia.googlecode.com/svn/trunk@7483 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding kMultiply_Mode (as an alias to kModulate_Mode) in SkBlendImageFilter.h to...
robertphillips@google.com [Thu, 31 Jan 2013 01:47:58 +0000 (01:47 +0000)]
Adding kMultiply_Mode (as an alias to kModulate_Mode) in SkBlendImageFilter.h to get Chrome compiling

git-svn-id: http://skia.googlecode.com/svn/trunk@7482 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReadding kMultiply_Mode (as an alias to kModulate_Mode) in SkXfermode.h to get Chrome...
robertphillips@google.com [Thu, 31 Jan 2013 01:23:39 +0000 (01:23 +0000)]
Readding kMultiply_Mode (as an alias to kModulate_Mode) in SkXfermode.h to get Chrome to compile

git-svn-id: http://skia.googlecode.com/svn/trunk@7480 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkImageFilterUtils.h to effects.gypi
robertphillips@google.com [Thu, 31 Jan 2013 00:03:27 +0000 (00:03 +0000)]
Add SkImageFilterUtils.h to effects.gypi

git-svn-id: http://skia.googlecode.com/svn/trunk@7479 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years ago[PDF] Fix multi-level page count calculation.
vandebo@chromium.org [Wed, 30 Jan 2013 21:44:40 +0000 (21:44 +0000)]
[PDF] Fix multi-level page count calculation.

BUG=1091

Review URL: https://codereview.appspot.com/7220045

git-svn-id: http://skia.googlecode.com/svn/trunk@7478 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoclone of https://codereview.appspot.com/7208043/
reed@google.com [Wed, 30 Jan 2013 21:36:11 +0000 (21:36 +0000)]
clone of https://codereview.appspot.com/7208043/
Review URL: https://codereview.appspot.com/7232062

git-svn-id: http://skia.googlecode.com/svn/trunk@7476 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkNextLog2 requires positive values.
bungeman@google.com [Wed, 30 Jan 2013 21:23:13 +0000 (21:23 +0000)]
SkNextLog2 requires positive values.

git-svn-id: http://skia.googlecode.com/svn/trunk@7474 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkNextLog2 requires values > 0.
bungeman@google.com [Wed, 30 Jan 2013 21:10:05 +0000 (21:10 +0000)]
SkNextLog2 requires values > 0.

git-svn-id: http://skia.googlecode.com/svn/trunk@7472 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded option of profiling GPU backend to debugger
robertphillips@google.com [Wed, 30 Jan 2013 21:09:09 +0000 (21:09 +0000)]
Added option of profiling GPU backend to debugger

https://codereview.appspot.com/7248045/

git-svn-id: http://skia.googlecode.com/svn/trunk@7471 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid possible O(n) stack space use by skqsort.
bungeman@google.com [Wed, 30 Jan 2013 21:01:26 +0000 (21:01 +0000)]
Avoid possible O(n) stack space use by skqsort.
https://codereview.appspot.com/7222043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7470 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoStart addressing the clang static analyzer issues
robertphillips@google.com [Wed, 30 Jan 2013 20:33:12 +0000 (20:33 +0000)]
Start addressing the clang static analyzer issues

https://codereview.appspot.com/7249043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7469 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_compare proper spacing and tab option.
bungeman@google.com [Wed, 30 Jan 2013 19:22:51 +0000 (19:22 +0000)]
bench_compare proper spacing and tab option.
https://codereview.appspot.com/6908056/

git-svn-id: http://skia.googlecode.com/svn/trunk@7468 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for...
senorblanco@chromium.org [Wed, 30 Jan 2013 19:08:47 +0000 (19:08 +0000)]
This changes the signature of SkImageFilter::filterImageGPU() to use SkBitmaps for input and output, and removes the rect param.  This allows us to return textures which are larger than the actual result, such as when GrAutoScratchTextures are used.  The SkBitmap's size represents the active region, while the GrTexture's size is the full texture size.

This fixes the bicubic image filter GM on the GPU, which otherwise draws garbage outside the filtered region.  It also moves us closer to unifying the signatures of SkImageFilter::onFilterImage() and SkImageFilter::filterImageGPU().

Review URL: https://codereview.appspot.com/7180048

git-svn-id: http://skia.googlecode.com/svn/trunk@7467 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws...
bsalomon@google.com [Wed, 30 Jan 2013 16:12:41 +0000 (16:12 +0000)]
Add GrDrawTarget::DrawInfo, combine API for performing indexed/non-indexed draws in subclasses.
Review URL: https://codereview.appspot.com/7237045

git-svn-id: http://skia.googlecode.com/svn/trunk@7466 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding a new unit test that demonstrates that dithering affects constant gradients
junov@chromium.org [Wed, 30 Jan 2013 15:52:06 +0000 (15:52 +0000)]
Adding a new unit test that demonstrates that dithering affects constant gradients
Related bug: crbug.com/169602
Review URL: https://codereview.appspot.com/7220063

git-svn-id: http://skia.googlecode.com/svn/trunk@7465 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreturn if we're invertible for the fast scale+trans case when we have no inverse
reed@google.com [Wed, 30 Jan 2013 15:47:42 +0000 (15:47 +0000)]
return if we're invertible for the fast scale+trans case when we have no inverse
matrix to return.
Review URL: https://codereview.appspot.com/7231063

git-svn-id: http://skia.googlecode.com/svn/trunk@7464 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdds SkMWCRandom, which generates random numbers using a variant of George Marsaglia...
jvanverth@google.com [Wed, 30 Jan 2013 15:42:19 +0000 (15:42 +0000)]
Adds SkMWCRandom, which generates random numbers using a variant of George Marsaglia's multiply-with-carry "mother-of-all" method. This passes the tuftests suite so it should be much better than the current method (which does not).

https://codereview.appspot.com/7235056/

git-svn-id: http://skia.googlecode.com/svn/trunk@7463 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enbling blurrect gm test wich no longer fails with rtree/tileGrid
junov@chromium.org [Wed, 30 Jan 2013 15:34:57 +0000 (15:34 +0000)]
Re-enbling blurrect gm test wich no longer fails with rtree/tileGrid
Some re-baselining may be necessary since the existing ones may be out of date.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7462 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK option, to disable check for
reed@google.com [Wed, 30 Jan 2013 13:17:32 +0000 (13:17 +0000)]
add SK_DISABLE_PIXELREF_LOCKCOUNT_BALANCE_CHECK option, to disable check for
lock-count-balance when we use pixelrefs.

git-svn-id: http://skia.googlecode.com/svn/trunk@7460 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Wed, 30 Jan 2013 12:50:38 +0000 (12:50 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7459 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 30 Jan 2013 07:05:59 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7458 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 29 Jan 2013 20:28:49 +0000 (20:28 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7453 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark SkPictureStateTree::Draw::operator< as const.
bungeman@google.com [Tue, 29 Jan 2013 19:04:14 +0000 (19:04 +0000)]
Mark SkPictureStateTree::Draw::operator< as const.
https://codereview.appspot.com/7222043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7452 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix Japanese font issue for devices running JB MR1 and higher.
djsollen@google.com [Tue, 29 Jan 2013 15:39:35 +0000 (15:39 +0000)]
Fix Japanese font issue for devices running JB MR1 and higher.

Android JB MR1 is using a new format of /system/etc/fallback_fonts.xml.
This CL preserves backwards compatibility, while also recognizing the
new fallback_fonts.xml format ("lang" attrbiute in <file/>).

NOTE: This CL was originally sumbitted for Chrome on Android (m18)

Review URL: https://codereview.appspot.com/7226053

git-svn-id: http://skia.googlecode.com/svn/trunk@7448 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Tue, 29 Jan 2013 14:34:03 +0000 (14:34 +0000)]
shape ops work in progress

update gyp files

git-svn-id: http://skia.googlecode.com/svn/trunk@7445 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SK_API to SkMutex (for chrome)
reed@google.com [Tue, 29 Jan 2013 13:03:36 +0000 (13:03 +0000)]
add SK_API to SkMutex (for chrome)

git-svn-id: http://skia.googlecode.com/svn/trunk@7443 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger rebuilds
rmistry@google.com [Tue, 29 Jan 2013 12:25:35 +0000 (12:25 +0000)]
Whitespace change to trigger rebuilds

git-svn-id: http://skia.googlecode.com/svn/trunk@7442 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change (SkipBuildbotRuns)
rmistry@google.com [Tue, 29 Jan 2013 12:23:53 +0000 (12:23 +0000)]
Whitespace change (SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@7441 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Tue, 29 Jan 2013 07:05:52 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7439 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotweak to comments, ws change to trigger bots
reed@google.com [Mon, 28 Jan 2013 22:36:34 +0000 (22:36 +0000)]
tweak to comments, ws change to trigger bots

git-svn-id: http://skia.googlecode.com/svn/trunk@7435 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove a workaround in gm/xfermodes.cpp
scroggo@google.com [Mon, 28 Jan 2013 21:14:21 +0000 (21:14 +0000)]
Remove a workaround in gm/xfermodes.cpp

We were performing a deep copy of the pixels in a SkBitmap to work around a bug where drawing an SkBitmap whose pixel memory was set with setPixels to an SkPicture did not preserve the pixel memory.

Since the workaround was written, we have fixed the bug in two ways:
1. If setPixels is called with a pointer, we wrap the pixels in an SkPixelRef.
2. Picture recording now makes a deep copy of mutable bitmaps.

Also switch to using onOnceBeforeDraw, an existing feature on GM that performs the purpose of the init function.

BUG=http://code.google.com/p/skia/issues/detail?id=224

Review URL: https://codereview.appspot.com/7220054

git-svn-id: http://skia.googlecode.com/svn/trunk@7433 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd missing params to renderer->resetState().
jvanverth@google.com [Mon, 28 Jan 2013 21:09:05 +0000 (21:09 +0000)]
Add missing params to renderer->resetState().

https://codereview.appspot.com/7234051/

git-svn-id: http://skia.googlecode.com/svn/trunk@7431 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing crash in cloning empty SkPicture object
junov@chromium.org [Mon, 28 Jan 2013 21:04:44 +0000 (21:04 +0000)]
Fixing crash in cloning empty SkPicture object

BUG=https://code.google.com/p/chromium/issues/detail?id=172062
TEST=Pictures unit test, test_clone_empty
Review URL: https://codereview.appspot.com/7223048

git-svn-id: http://skia.googlecode.com/svn/trunk@7430 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix assert
robertphillips@google.com [Mon, 28 Jan 2013 20:55:42 +0000 (20:55 +0000)]
Fix assert

https://codereview.appspot.com/7234050/

git-svn-id: http://skia.googlecode.com/svn/trunk@7428 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build
reed@google.com [Mon, 28 Jan 2013 20:53:22 +0000 (20:53 +0000)]
fix build
Review URL: https://codereview.appspot.com/7229052

git-svn-id: http://skia.googlecode.com/svn/trunk@7426 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoREBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build...
reed@google.com [Mon, 28 Jan 2013 20:43:09 +0000 (20:43 +0000)]
REBASELINE: enable setline fix for scan converter, with SK_IGNORE_SETLINE_FIX build guard.
Review URL: https://codereview.appspot.com/7225056

git-svn-id: http://skia.googlecode.com/svn/trunk@7425 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange the method for timing individual tiles in bench_pictures.
scroggo@google.com [Mon, 28 Jan 2013 20:40:24 +0000 (20:40 +0000)]
Change the method for timing individual tiles in bench_pictures.

When timing individual tiles in bench_pictures, keep a timer running
across all repeats, and then take the average. The former method of
timing each iteration separately runs into precision errors on some
platforms.

Running on my Mac Pro with OSX 10.8, the cmsecs for the new method
and the old method are roughly the same when checking the CPU time.
When checking the wall time, the old method often gives me 0ms,
while the new method gives me a larger value. I don't think this
can be entirely attributed to rounding though, since on occasion I
see the old method showing a short time period (.05 - .15ms) while
the new method shows .15ms higher (which is in range for the
difference I'm seeing for other tiles where the old method reports
0ms).

Some other changes:
PictureRenderer::resetState now takes a boolean parameter. If called
with false, it will only do a flush, while if called with true, it
will also call finish.

resetState is now called with true everywhere except in between
iterations of drawing the same tile (when timing individual tiles).

render_pictures_main no longer calls resetState directly, since it
already calls end, which calls resetState.

BUG=http://code.google.com/p/skia/issues/detail?id=1066

Review URL: https://codereview.appspot.com/7101060

git-svn-id: http://skia.googlecode.com/svn/trunk@7424 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove vertex layout definitions from GrDrawTarget to GrDrawState.
jvanverth@google.com [Mon, 28 Jan 2013 20:39:48 +0000 (20:39 +0000)]
Move vertex layout definitions from GrDrawTarget to GrDrawState.

This is the first step in revising vertex layouts so that the currently
installed GrEffects determine the current vertex layout.

https://codereview.appspot.com/7235051/

git-svn-id: http://skia.googlecode.com/svn/trunk@7423 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded toString to SkDrawLooper-derived classes
robertphillips@google.com [Mon, 28 Jan 2013 20:21:59 +0000 (20:21 +0000)]
Added toString to SkDrawLooper-derived classes

https://codereview.appspot.com/7195054/

git-svn-id: http://skia.googlecode.com/svn/trunk@7422 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Mon, 28 Jan 2013 19:25:51 +0000 (19:25 +0000)]
shape ops work in progress

good checkpoint: nearly all tests pass solidly here

git-svn-id: http://skia.googlecode.com/svn/trunk@7420 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd data() to all QString::toASCII Qt calls to help out Linux compiler
robertphillips@google.com [Mon, 28 Jan 2013 19:25:43 +0000 (19:25 +0000)]
Add data() to all QString::toASCII Qt calls to help out Linux compiler

https://codereview.appspot.com/7232052/

git-svn-id: http://skia.googlecode.com/svn/trunk@7419 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd command line options to debugger
robertphillips@google.com [Mon, 28 Jan 2013 17:43:26 +0000 (17:43 +0000)]
Add command line options to debugger

https://codereview.appspot.com/7221048/

git-svn-id: http://skia.googlecode.com/svn/trunk@7418 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd (disabled) test for big dashing
reed@google.com [Mon, 28 Jan 2013 16:57:29 +0000 (16:57 +0000)]
add (disabled) test for big dashing

git-svn-id: http://skia.googlecode.com/svn/trunk@7417 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix debug build. Unreviewed.
senorblanco@chromium.org [Mon, 28 Jan 2013 16:48:51 +0000 (16:48 +0000)]
Fix debug build.  Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@7416 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build break after r7411 when GR_STATIC_RECT_VB is enabled.
bsalomon@google.com [Mon, 28 Jan 2013 16:46:55 +0000 (16:46 +0000)]
Fix build break after r7411 when GR_STATIC_RECT_VB is enabled.
Review URL: https://codereview.appspot.com/7220051

git-svn-id: http://skia.googlecode.com/svn/trunk@7415 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd an origin flag for backend (external) textures. Some textures in WebKit have...
senorblanco@chromium.org [Mon, 28 Jan 2013 16:42:38 +0000 (16:42 +0000)]
Add an origin flag for backend (external) textures.  Some textures in WebKit have a topdown orientation, and skia needs to be notified of this, so that they are not drawn upside-down.

Review URL: https://codereview.appspot.com/7200048

git-svn-id: http://skia.googlecode.com/svn/trunk@7414 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't...
bsalomon@google.com [Mon, 28 Jan 2013 15:35:28 +0000 (15:35 +0000)]
Make a bunch of virtuals in GrDrawTarget and GrGpu private. Subclasses shouldn't call them directly.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7228048

git-svn-id: http://skia.googlecode.com/svn/trunk@7413 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unnecessary ptr derefs int r7411 (deref result is not used).
bsalomon@google.com [Mon, 28 Jan 2013 14:31:19 +0000 (14:31 +0000)]
Remove unnecessary ptr derefs int r7411 (deref result is not used).

git-svn-id: http://skia.googlecode.com/svn/trunk@7412 2bbb7eff-a529-9590-31e7-b0007b416f81