platform/upstream/libvpx.git
11 years agoInitial support for resolution changes on P-frames
John Koleszar [Wed, 6 Feb 2013 23:54:52 +0000 (15:54 -0800)]
Initial support for resolution changes on P-frames

Allows inter-frames to change resolution. Currently these are
almost equivalent to keyframes, as only intra prediction modes
are allowed, but without the other context resets that occur on
keyframes.

Change-Id: Icd1a2a5af0d9462cc792588427b0a1f5b12e40d3

11 years agoAvoid allocating memory when resizing frames
John Koleszar [Wed, 6 Feb 2013 22:22:17 +0000 (14:22 -0800)]
Avoid allocating memory when resizing frames

As long as the new frame is smaller than the size that was originally
allocated, we don't need to free and reallocate the memory allocated.
Instead, do the allocation on the size of the first frame. We could
make this passed in from the application instead, if we wanted to
support external upscaling.

Change-Id: I204d17a130728bbd91155bb4bd863a99bb99b038

11 years agoAdds a test for the VP8E_SET_SCALEMODE control
John Koleszar [Wed, 6 Feb 2013 20:44:20 +0000 (12:44 -0800)]
Adds a test for the VP8E_SET_SCALEMODE control

Tests that the external interface to set the internal codec scaling
works as expected. Also updates the test to pull the height from
the decoded frame size rather than parsing the keyframe header,
in anticipation of allowing resolution changes on non-keyframes.

Change-Id: I3ed92117d8e5288fbbd1e7b618f2f233d0fe2c17

11 years agoRestore SSSE3 subpixel filters in new convolve framework
John Koleszar [Fri, 8 Feb 2013 01:00:37 +0000 (17:00 -0800)]
Restore SSSE3 subpixel filters in new convolve framework

This commit adds the 8 tap SSSE3 subpixel filters back into the code
underneath the convolve API. The C code is still called for 4x4
blocks, as well as compound prediction modes. This restores the
encode performance to be within about 8% of the baseline.

Change-Id: Ife0d81477075ae33c05b53c65003951efdc8b09c

11 years agoConvert subpixel filters to use convolve framework
John Koleszar [Tue, 29 Jan 2013 00:59:03 +0000 (16:59 -0800)]
Convert subpixel filters to use convolve framework

Update the code to call the new convolution functions to do subpixel
prediction rather than the existing functions. Remove the old C and
assembly code, since it is unused. This causes a 50% performance
reduction on the decoder, but that will be resolved when the asm for
the new functions is available.

There is no consensus for whether 6-tap or 2-tap predictors will be
supported in the final codec, so these filters are implemented in
terms of the 8-tap code, so that quality testing of these modes
can continue. Implementing the lower complexity algorithms is a
simple exercise, should it be necessary.

This code produces slightly better results in the EIGHTTAP_SMOOTH
case, since the filter is now applied in only one direction when
the subpel motion is only in one direction. Like the previous code,
the filtering is skipped entirely on full-pel MVs. This combination
seems to give the best quality gains, but this may be indicative of a
bug in the encoder's filter selection, since the encoder could
achieve the result of skipping the filtering on full-pel by selecting
one of the other filters. This should be revisited.

Quality gains on derf positive on almost all clips. The only clip
that seemed to be hurt at all datarates was football
(-0.115% PSNR average, -0.587% min). Overall averages 0.375% PSNR,
0.347% SSIM.

Change-Id: I7d469716091b1d89b4b08adde5863999319d69ff

11 years agoAdd 8-tap generic convolver
John Koleszar [Fri, 25 Jan 2013 17:47:09 +0000 (09:47 -0800)]
Add 8-tap generic convolver

This commit introduces a new convolution function which will be used to
replace the existing subpixel interpolation functions. It is much the
same as the existing functions, but allows for changing the filter
kernel on a per-pixel basis, and doesn't bake in knowledge of the
filter to be applied or the size of the resulting block into the
function name.

Replacing the existing subpel filters will come in a later commit.

Change-Id: Ic9a5615f2f456cb77f96741856fc650d6d78bb91

11 years agoMerge "Adding a frame parallel decoding mode" into experimental
Deb Mukherjee [Wed, 30 Jan 2013 20:03:45 +0000 (12:03 -0800)]
Merge "Adding a frame parallel decoding mode" into experimental

11 years agoMerge "don't code the branch for the predicted seg_id if that flag is false." into...
Ronald S. Bultje [Wed, 30 Jan 2013 18:02:51 +0000 (10:02 -0800)]
Merge "don't code the branch for the predicted seg_id if that flag is false." into experimental

11 years agodon't code the branch for the predicted seg_id if that flag is false.
Ronald S. Bultje [Wed, 30 Jan 2013 17:30:46 +0000 (09:30 -0800)]
don't code the branch for the predicted seg_id if that flag is false.

Change-Id: Icb6e21dc0c2d9918faa33c8bf70943660df7ad88

11 years agoMerge "Default superblock skip flag to 32x32 for skip-blocks." into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 17:12:17 +0000 (09:12 -0800)]
Merge "Default superblock skip flag to 32x32 for skip-blocks." into experimental

11 years agoMerge "Reset skip flag in superblock RD loop." into experimental
Ronald S. Bultje [Wed, 30 Jan 2013 17:12:02 +0000 (09:12 -0800)]
Merge "Reset skip flag in superblock RD loop." into experimental

11 years agoMerge "Further improvement on compound inter-intra expt" into experimental
Deb Mukherjee [Wed, 30 Jan 2013 16:38:17 +0000 (08:38 -0800)]
Merge "Further improvement on compound inter-intra expt" into experimental

11 years agoDefault superblock skip flag to 32x32 for skip-blocks.
Ronald S. Bultje [Wed, 30 Jan 2013 05:46:31 +0000 (21:46 -0800)]
Default superblock skip flag to 32x32 for skip-blocks.

This is identical to the later decisions made in encode_superblock().
This commit doesn't actually change anything, but makes the mbmi state
more consistent between the RD loop and the final encode result.

Change-Id: I9e735afb7c5a52e5b61728cb88c67ef9b9bf59be

11 years agoReset skip flag in superblock RD loop.
Ronald S. Bultje [Wed, 30 Jan 2013 05:42:46 +0000 (21:42 -0800)]
Reset skip flag in superblock RD loop.

This is the superblock equivalent of commit 290b83a.

Change-Id: Ib3945dd9e992fa9ec1fdea5a11e17a3cc0e37637

11 years agoWrite only visible area (for better comparison with rec.yuv).
Ronald S. Bultje [Wed, 30 Jan 2013 00:58:52 +0000 (16:58 -0800)]
Write only visible area (for better comparison with rec.yuv).

Change-Id: I32bf4ee532a15af78619cbcd8a193224029fab50

11 years agoMerge "Fix block pointer corruption in intra8x8 prediction with 4x4 transform." into...
Ronald S. Bultje [Tue, 29 Jan 2013 20:49:42 +0000 (12:49 -0800)]
Merge "Fix block pointer corruption in intra8x8 prediction with 4x4 transform." into experimental

11 years agoMerge "Fix overread/write reported by valgrind if (mb_cols) & 3 != 0." into experimental
Ronald S. Bultje [Tue, 29 Jan 2013 20:49:22 +0000 (12:49 -0800)]
Merge "Fix overread/write reported by valgrind if (mb_cols) & 3 != 0." into experimental

11 years agoMerge "Remove eob_max_offset markers." into experimental
Paul Wilkins [Tue, 29 Jan 2013 17:29:45 +0000 (09:29 -0800)]
Merge "Remove eob_max_offset markers." into experimental

11 years agoMerge "Segment Skip Flag" into experimental
Paul Wilkins [Tue, 29 Jan 2013 17:29:26 +0000 (09:29 -0800)]
Merge "Segment Skip Flag" into experimental

11 years agoMerge "Added eob == 0 check to vp9_dequant_idct_add_32x32_c" into experimental
Scott LaVarnway [Tue, 29 Jan 2013 17:19:58 +0000 (09:19 -0800)]
Merge "Added eob == 0 check to vp9_dequant_idct_add_32x32_c" into experimental

11 years agoFix block pointer corruption in intra8x8 prediction with 4x4 transform.
Ronald S. Bultje [Sat, 26 Jan 2013 00:08:19 +0000 (16:08 -0800)]
Fix block pointer corruption in intra8x8 prediction with 4x4 transform.

The RD loop would change the pointer after the first mode (DC) was tested,
leading to corrupt block objects being provided for the others. This
would essentially render the i8x8 predictor useless.

Change-Id: I16c5906ca64fb34878ac32ce59af8974e4582bb8

11 years agoRemove eob_max_offset markers.
Paul Wilkins [Tue, 29 Jan 2013 13:33:17 +0000 (13:33 +0000)]
Remove eob_max_offset markers.

Remove eob_max_offset markers and replace
with the generic skip_block flag to indicate
to the quantizer that all coeffs to be set to 0
and eob position set to 0;

Change-Id: Id477e8f8d4ec1a5562758904071013c24b76bfd7

11 years agoFurther improvement on compound inter-intra expt
Deb Mukherjee [Thu, 24 Jan 2013 23:22:57 +0000 (15:22 -0800)]
Further improvement on compound inter-intra expt

Adds a special combination mode specific to intra prediciton
mode D45.

Current results with the compound inter/intra experiment:
derf: 0.2%
yt: 0.55%
std-hd: 0.75%
hd: 0.74%

Change-Id: I8976bdf3b9b0b66ab8c5c628bbc62c14fc72ca86

11 years agoSegment Skip Flag
Paul Wilkins [Mon, 28 Jan 2013 15:22:53 +0000 (15:22 +0000)]
Segment Skip Flag

First step in simplifying the segment mode and
segment EOB flags into a simpler segment skip
flag that implies 0,0 mv and EOB at position 0.

Change-Id: Ib750cac31a7a02dc21082580498efd9f7d8d72a5

11 years agoMerge "Simplify Zero bin and zero bin run code." into experimental
Paul Wilkins [Mon, 28 Jan 2013 16:35:36 +0000 (08:35 -0800)]
Merge "Simplify Zero bin and zero bin run code." into experimental

11 years agoSimplify Zero bin and zero bin run code.
Paul Wilkins [Thu, 24 Jan 2013 18:28:33 +0000 (18:28 +0000)]
Simplify Zero bin and zero bin run code.

Simplification to eliminate a number of very large data
data structures. All zero run, zbin boosts for different
transform sizes are now limited to a maximum run length
of 15 before they max out the boost.

Some further work still needs be done to refactor, rationalize
and optimize the multiple quantizer functions.

The simplification coupled with tweaks to the 16 element array
now used for all transform sizes, has minimal effect on quality.

Change-Id: I6f3948b8ca0418b60d4db9030ff19026a34ed423

11 years agoTweak DropFramesWithoutRecovery params
John Koleszar [Sat, 26 Jan 2013 01:48:18 +0000 (17:48 -0800)]
Tweak DropFramesWithoutRecovery params

The previous parameters did not pass with VP8.

Change-Id: I1505171fbd713d21029541828ebdbe4c7dea79b8

11 years agoFix overread/write reported by valgrind if (mb_cols) & 3 != 0.
Ronald S. Bultje [Sat, 26 Jan 2013 00:03:15 +0000 (16:03 -0800)]
Fix overread/write reported by valgrind if (mb_cols) & 3 != 0.

We'd backup and restore all cols for a 64x64 SB, but the array wouldn't
be big enough to hold all that data.

Change-Id: Ic68ea721bf07e0b2f3937bd16b0b734bcc743ce1

11 years agoAdding a frame parallel decoding mode
Deb Mukherjee [Fri, 25 Jan 2013 19:30:28 +0000 (11:30 -0800)]
Adding a frame parallel decoding mode

Adds a flag to disable features that would inhibit frame parallel
decoding. This includes backward adaptation and MV sorting based
on search in ref frame buffer.

Also includes some minor clean-ups.

Change-Id: I434846717a47b7bcb244b37ea670c5cdf776f14d

11 years agoMerge "Remove "update_context" variable from VP9_COMP context." into experimental
Ronald S. Bultje [Fri, 25 Jan 2013 17:43:42 +0000 (09:43 -0800)]
Merge "Remove "update_context" variable from VP9_COMP context." into experimental

11 years agoAdded eob == 0 check to vp9_dequant_idct_add_32x32_c
Scott LaVarnway [Fri, 25 Jan 2013 01:09:56 +0000 (17:09 -0800)]
Added eob == 0 check to vp9_dequant_idct_add_32x32_c

Added a quick eob == 0 check.  Once the integer version of the dct32x32 is
complete, we can check for other eob cases.

For the 1080p clip used, the decoder performance improved by 4%.

Change-Id: I9390b6ed3c8be0c0c0a0c44c578d9a031d6e026e

11 years agoRemove "update_context" variable from VP9_COMP context.
Ronald S. Bultje [Fri, 25 Jan 2013 00:28:53 +0000 (16:28 -0800)]
Remove "update_context" variable from VP9_COMP context.

The variable is always zero.

Change-Id: Id5cdbecad543bca465a5b1d471badaec7e112c8d

11 years agoMvref speedup
Paul Wilkins [Thu, 24 Jan 2013 12:52:13 +0000 (12:52 +0000)]
Mvref speedup

Quality / decode speed trade off changes.
Simpler insert method without sort. Quality impact small.

Change-Id: Id0c0941bc508d985405abd06a13ffe7489170b62

11 years agoMerge "MSVS compiler error" into experimental
Paul Wilkins [Thu, 24 Jan 2013 17:21:49 +0000 (09:21 -0800)]
Merge "MSVS compiler error" into experimental

11 years agoMSVS compiler error
Paul Wilkins [Thu, 24 Jan 2013 11:42:38 +0000 (11:42 +0000)]
MSVS compiler error

Visual Studio reports and error on the line
  static const int bsize2 = bsize >> 1;

"error C2099: initializer is not a constant"

Also warnings on signed/unsigned mismatch

Change-Id: I76cb06f736bd9c90107a26bfb3c130ec3f6c33de

11 years agoMerge "Intrinsic version of loopfilter now matches C code" into experimental
Scott LaVarnway [Thu, 24 Jan 2013 16:45:22 +0000 (08:45 -0800)]
Merge "Intrinsic version of loopfilter now matches C code" into experimental

11 years agoAdds an error-resilient mode with test
Deb Mukherjee [Tue, 15 Jan 2013 14:43:35 +0000 (06:43 -0800)]
Adds an error-resilient mode with test

Adds an error-resilient mode where frames can be continued
to be decoded even when there are errors (due to network losses)
on a prior frame. Specifically, backward updates are turned off
and probabilities of various symbols are reset to defaults at
the beginning of each frame. Further, the last frame's mvs are
not used for the mv reference list, and the sorting of the
initial list based on search on previous frames is turned off
as well.

Also adds a test where an arbitrary set of frames are skipped
from decoding to simulate errors. The test verifies (1) that if
the error frames are droppable - i.e. frame buffer updates have
been turned off - there are no mismatch errors for the remaining
frames after the error frames; and (2) if the error-frames are non
droppable, there are not only no decoding errors but the mismatch
PSNR between the decoder's version of the post-error frames and the
encoder's version is at least 20 dB.

Change-Id: Ie6e2bcd436b1e8643270356d3a930e8989ff52a5

11 years agoMerge "Support multiple codecs in test infrastructure" into experimental
John Koleszar [Wed, 23 Jan 2013 22:52:22 +0000 (14:52 -0800)]
Merge "Support multiple codecs in test infrastructure" into experimental

11 years agoSupport multiple codecs in test infrastructure
John Koleszar [Fri, 18 Jan 2013 19:51:12 +0000 (11:51 -0800)]
Support multiple codecs in test infrastructure

This commit starts to convert the tests to a system where the codec
to be used is provided by a factory object. Currently no tests are
instantiated for VP9 since they all fail for various reasons, but it
was verified that they're called and the correct codec is
instantiated.

Change-Id: Ia7506df2ca3a7651218ba3ca560634f08c9fbdeb

11 years agoMerge "Modifies the comp inter-intra expt" into experimental
Deb Mukherjee [Wed, 23 Jan 2013 17:43:07 +0000 (09:43 -0800)]
Merge "Modifies the comp inter-intra expt" into experimental

11 years agoIntrinsic version of loopfilter now matches C code
Scott LaVarnway [Wed, 23 Jan 2013 17:31:40 +0000 (09:31 -0800)]
Intrinsic version of loopfilter now matches C code

Updated the instrinsic code to match Yaowu's latest loopfilter change.
(I584393906c4f5f948a581d6590959522572743bb)

The decoder performance improved by ~30% for the test clip used.

Change-Id: I026cfc75d5bcb7d8d58be6f0440ac9e126ef39d2

11 years agoMerge changes Ia82cef79,I7324a75a,I7b66daad,I73344451,I91dc210f,I5945b5ce into experi...
John Koleszar [Tue, 22 Jan 2013 16:31:55 +0000 (08:31 -0800)]
Merge changes Ia82cef79,I7324a75a,I7b66daad,I73344451,I91dc210f,I5945b5ce into experimental

* changes:
  Use alt-ref frame context for keyframes
  Preserve the previous golden frame on golden updates
  Generalize and increase frame coding contexts
  Start to anonymize reference frames
  Update encoder to use fb_idx_ref_cnt
  Remove buffer-to-buffer copy logic

11 years agoUse alt-ref frame context for keyframes
John Koleszar [Fri, 18 Jan 2013 22:35:20 +0000 (14:35 -0800)]
Use alt-ref frame context for keyframes

This matches the behavior prior to generalizing the frame context
selection, and intuitively makes sense in that the first forward ref
is immediately after the keyframe, so it's quality is improved a bit
by using the keyframe's entropy context rather than the default.

Change-Id: Ia82cef79382b9d8cfafdc44ba0533d4dc3e44053

11 years agoa minor change to a portion of loop filtering
Yaowu Xu [Thu, 17 Jan 2013 21:26:24 +0000 (13:26 -0800)]
a minor change to a portion of loop filtering

The loop filtering used for MB edge or internal edge of a MB using 8x8
tranform was reading 5 pixel each side and writting 3 pixel each side.
With suggestion from Aki and Scott on hardware&software performance,
this commit changed to read 4 pixel each side and write 3 pixel each
side.

Change-Id: I584393906c4f5f948a581d6590959522572743bb

11 years agoPreserve the previous golden frame on golden updates
John Koleszar [Wed, 16 Jan 2013 20:19:42 +0000 (12:19 -0800)]
Preserve the previous golden frame on golden updates

This commit restores the quality lost when the buffer-to-buffer copy
logic was removed. Note that this is specific to the current use of
golden frames and will need rework when RTC functionality is added.

Change-Id: I7324a75acd96eafd9e0f9b8633d782e390d5dc21

11 years agoGeneralize and increase frame coding contexts
John Koleszar [Tue, 15 Jan 2013 23:57:11 +0000 (15:57 -0800)]
Generalize and increase frame coding contexts

Previously there were two frame coding contexts tracked, one for normal
frames and one for alt-ref frames. Generalize this by signalling the
context to use in the bitstream, rather than tieing it to the alt ref
refresh bit. Also increase the number of contexts available to 4, which
may be useful for temporal scalability.

Change-Id: I7b66daaddd55c535c20cd16713541fab182b1662

11 years agoStart to anonymize reference frames
John Koleszar [Tue, 15 Jan 2013 21:49:44 +0000 (13:49 -0800)]
Start to anonymize reference frames

Remove lst_fb_idx, gld_fb_idx, alt_fb_idx, refresh_last_frame,
refresh_golden_frame, refresh_alt_ref_frame from common. Gold/Alt are
encode side conventions. From the decoder's perspective, we want to be
dealing with numbered references.

Updates to active_ref 2 signal mode context switches, vestigial from
refresh_alt_ref_frame. This needs some clean up to make sense with
increased numbers of reference frames, as well as reimplementing the
swapping of alt/golden which was previously done using the
buffer-to-buffer copy mechanism removed in an earlier commit.

Change-Id: I7334445158b7666f9295d2a2dd22aa03f4485f58

11 years agoUpdate encoder to use fb_idx_ref_cnt
John Koleszar [Mon, 14 Jan 2013 23:52:20 +0000 (15:52 -0800)]
Update encoder to use fb_idx_ref_cnt

Do reference counting the same way on the encoder as the decoder does,
rather than maintaining the 'flags' member of YV12_BUFFER_CONFIG.

Change-Id: I91dc210ffca081acaf9d5c09a06e7461b3c3139c

11 years agoRemove buffer-to-buffer copy logic
John Koleszar [Mon, 14 Jan 2013 22:44:39 +0000 (14:44 -0800)]
Remove buffer-to-buffer copy logic

This is the first in a series of commits to add additional reference
frames to the codec. Each frame will be able to update any of the
available references, but copying between references is not
supported.

Change-Id: I5945b5ce6cc3582c495102b4e7eed4f08c44d5a1

11 years agofix a number issues that cause failures
Yaowu Xu [Tue, 15 Jan 2013 02:03:34 +0000 (18:03 -0800)]
fix a number issues that cause failures

During master jenkins verification proces

Change-Id: I3722b8753eaf39f99b45979ce407a8ea0bea0b89

11 years agoModifies the comp inter-intra expt
Deb Mukherjee [Tue, 15 Jan 2013 01:32:26 +0000 (17:32 -0800)]
Modifies the comp inter-intra expt

Uses a single 1D table to implement the weighting of the predictors
for the compound inter-intra experiment.

Change-Id: I204ffbe4f9fc79d5d43b6c724ad253d800461012

11 years agoUse INT64_MAX instead of LLONG_MAX
John Koleszar [Mon, 14 Jan 2013 19:49:30 +0000 (11:49 -0800)]
Use INT64_MAX instead of LLONG_MAX

These variables have the type int64_t, not long long. long long could
be a larger type than 64 bits. Emulate INT64_MAX for older versions of
MSVC, and remove the unreferenced vpx_ports/vpxtypes.h

Change-Id: Ideaca71838fcd3849d816d5ab17aa347c97d03b0

11 years agoRemove compound intra-intra experiment.
Ronald S. Bultje [Mon, 14 Jan 2013 22:37:53 +0000 (14:37 -0800)]
Remove compound intra-intra experiment.

This experiment gives little gains and adds relatively much code
complexity (and it hinders other experiments), so let's get rid of
it.

Change-Id: Id25e79a137a1b8a01138aa27a1fa0ba4a2df274a

11 years agoMerge experiment "subpelrefmv"
Yaowu Xu [Mon, 14 Jan 2013 22:39:54 +0000 (14:39 -0800)]
Merge experiment "subpelrefmv"

Change-Id: Iac7f3d108863552b850c92c727e00c95571c9e96

11 years agoMerge experiment "widerlpf"
Yaowu Xu [Mon, 14 Jan 2013 20:11:06 +0000 (12:11 -0800)]
Merge experiment "widerlpf"

Change-Id: I0c94475075e66e13cfe4c20fab7db6474441ae86

11 years agoMerge "changed UV plane loop filtering for TX_8X8" into experimental
Yaowu Xu [Mon, 14 Jan 2013 22:47:31 +0000 (14:47 -0800)]
Merge "changed UV plane loop filtering for TX_8X8" into experimental

11 years agoMerge "change to evaluate reference mvs using above only" into experimental
Yaowu Xu [Mon, 14 Jan 2013 22:40:38 +0000 (14:40 -0800)]
Merge "change to evaluate reference mvs using above only" into experimental

11 years agochanged UV plane loop filtering for TX_8X8
Yaowu Xu [Mon, 14 Jan 2013 17:28:35 +0000 (09:28 -0800)]
changed UV plane loop filtering for TX_8X8

In commit 9a1d73d, loop filtering was added for UV 4x4 boundaries
when TX_8X8 is used by a MB. This commit further refined the decision
to be based on the actual transform used for the UV planes. When
UV planes use 4x4 transform, i.e. when prediction mode used is either
I8X8_PRED or SPLITMV, UV planes are filtered on 4x4 boundaries, and no
filtering is applied on 4x4 block boundaries when UV planes use 8X8
transform.

Change-Id: Ibb404face0a1d129b4b4abaf67c55d82e8df8bec

11 years agoMerge "Fix compiler warnings" into experimental
Paul Wilkins [Mon, 14 Jan 2013 22:20:57 +0000 (14:20 -0800)]
Merge "Fix compiler warnings" into experimental

11 years agoMerge "Merge prediction filter" into experimental
Adrian Grange [Mon, 14 Jan 2013 22:18:21 +0000 (14:18 -0800)]
Merge "Merge prediction filter" into experimental

11 years agochange to evaluate reference mvs using above only
Yaowu Xu [Thu, 10 Jan 2013 23:38:29 +0000 (15:38 -0800)]
change to evaluate reference mvs using above only

Change-Id: Ibcc342efac0a9be7a21d9b2c09984d9e16bbb225

11 years agoFix compiler warnings
Yaowu Xu [Mon, 14 Jan 2013 21:56:52 +0000 (13:56 -0800)]
Fix compiler warnings

The warnings caused verify failure with gerrit for several  commits

Change-Id: I030df8638bd69b8783a3ac58e720ff9f0bfd546c

11 years agoMerge prediction filter
Adrian Grange [Mon, 14 Jan 2013 20:57:07 +0000 (12:57 -0800)]
Merge prediction filter

Removed the experimental flag from around the prediction filter.

Change-Id: Ic1dd2db8fe8ac17ed5129f83094d4c5cdd5527d2

11 years agoReset x->skip for each iteration in the RD loop.
Ronald S. Bultje [Mon, 14 Jan 2013 20:43:12 +0000 (12:43 -0800)]
Reset x->skip for each iteration in the RD loop.

This prevents ill-defined behaviour, such as setting x->skip for a mode
that is excluded because of frame-level flags (e.g. filter selection,
compound prediction selection), then not breaking out of the RD loop
because the mode is not allowed, but keeping the flag on. Whatever mode
is iterated through next in the RD loop will then carry this flag, and
all sort of bad stuff happens, such as x->skip being set on intra pred
modes.

Change-Id: I5bec46b36e38292174acb1c564b3caf00a9b4b9a

11 years agoFix unused variable warnings
John Koleszar [Mon, 14 Jan 2013 20:10:11 +0000 (12:10 -0800)]
Fix unused variable warnings

Previous commit does not build cleanly on Jenkins with the DWT/DCT
hybrid experiment enabled (--enable-dwtdcthybrid).

Change-Id: Ia67e8f59d17ef2d5200ec6b90dfe6711ed6835a5

11 years agoFurther enhancements/fixes on dct/dwt hybrid txfm
Deb Mukherjee [Wed, 9 Jan 2013 14:26:54 +0000 (06:26 -0800)]
Further enhancements/fixes on dct/dwt hybrid txfm

Fixes some scaling issues. Adds an option to only compute the
dct on the low-low subband for 32x32 and 64x64 blocks using
only a single 16x16 dct after 1 and 2 wavelet decomposition
levels respectively. Also adds an option to use a 8x8 dct
as building block.

Currenlty with the 2/6 filter and with a single 16x16 dct on
the low low band, the reuslts compared to full 32x32 dct is
as follows:
derf: -0.15%
yt: -0.29%
std-hd: -0.18%
hd: -0.6%
These are my current recommended settings, since the 2/6 filter
is very simple.

Results with 8x8 dct are about 0.3% worse.

Change-Id: I00100cdc96e32deced591985785ef0d06f325e44

11 years agoMerge "WIP: Added sse2 version of vp9_mb_lpf_horizontal_edge_w" into experimental
Jim Bankoski [Sat, 12 Jan 2013 01:15:41 +0000 (17:15 -0800)]
Merge "WIP: Added sse2 version of vp9_mb_lpf_horizontal_edge_w" into experimental

11 years agoWIP: Added sse2 version of vp9_mb_lpf_horizontal_edge_w
Scott LaVarnway [Sat, 12 Jan 2013 01:11:04 +0000 (17:11 -0800)]
WIP: Added sse2 version of vp9_mb_lpf_horizontal_edge_w

and vp9_mb_lpf_vertical_edge_w_sse2.  This was quickly done so we can
run some tests over the weekend.  Future commits will optimize/refactor these
functions further.

The decoder performance improved by ~17% for the clip used.

Change-Id: I612687cd5a7670ee840a0cbc3c68dc2b84d4af76

11 years agoMerge "Upstream changes from Chromium Android Clang build." into experimental
Jim Bankoski [Sat, 12 Jan 2013 01:06:26 +0000 (17:06 -0800)]
Merge "Upstream changes from Chromium Android Clang build." into experimental

11 years agoMerge "Add loop filtering for UV plane" into experimental
Yaowu Xu [Sat, 12 Jan 2013 00:56:39 +0000 (16:56 -0800)]
Merge "Add loop filtering for UV plane" into experimental

11 years agoAdd loop filtering for UV plane
Yaowu Xu [Fri, 11 Jan 2013 23:53:32 +0000 (15:53 -0800)]
Add loop filtering for UV plane

On block boundary within a MB when 8x8 block boundary only is filtered
for Y.

Change-Id: Ie1c804c877d199e78e2fecd8c2d3f1e114ce9ec1

11 years agoUpstream changes from Chromium Android Clang build.
Frank Galligan [Fri, 11 Jan 2013 23:34:05 +0000 (15:34 -0800)]
Upstream changes from Chromium Android Clang build.

See https://codereview.chromium.org/11875006/

Change-Id: Ied2a17df2b3222635f84aef120eaa9feb53750d2

11 years agoMerge "Initial sse2 version of the wide loopfilters" into experimental
Scott LaVarnway [Fri, 11 Jan 2013 23:34:26 +0000 (15:34 -0800)]
Merge "Initial sse2 version of the wide loopfilters" into experimental

11 years agoInitial sse2 version of the wide loopfilters
Scott LaVarnway [Fri, 11 Jan 2013 22:54:14 +0000 (14:54 -0800)]
Initial sse2 version of the wide loopfilters

Updated the rtcd_defs and used the sse2 uv version
of the loopfilter.  The performance improved by ~8%
for the test clip used.

Change-Id: I5a0bca3b6674198d40ca4a77b8cc722ddde79c36

11 years agoRemove INT64_MAX references.
Paul Wilkins [Fri, 11 Jan 2013 19:41:39 +0000 (19:41 +0000)]
Remove INT64_MAX references.

Replace INT64_MAX references with LLONG_MAX
for windows build.

Change-Id: Ib8b45c1e9c15c043b2f54c27ed83b8682b2be34f

11 years agoMerge "Reduce the usage of widerlpf" into experimental
Yaowu Xu [Fri, 11 Jan 2013 19:15:43 +0000 (11:15 -0800)]
Merge "Reduce the usage of widerlpf" into experimental

11 years agortcd for new wider loop filters
Jim Bankoski [Fri, 11 Jan 2013 17:45:45 +0000 (09:45 -0800)]
rtcd for new wider loop filters

Change-Id: I8826bcdcf72ba6d86bde31cd13902a710399805c

11 years agoReduce the usage of widerlpf
Yaowu Xu [Thu, 10 Jan 2013 18:55:07 +0000 (10:55 -0800)]
Reduce the usage of widerlpf

The commit changed to not to use wider lpf within a superblock when
32x32 transform is used for the block.

The commit also changed to use the shorter version of loop filtering:
for UV planes.

Change-Id: I344c1fb9a3be9d1200782a788bcb0b001fedcff8

11 years agoFix wrong pitch argument in dct32x32 unit test.
Ronald S. Bultje [Thu, 10 Jan 2013 16:36:42 +0000 (08:36 -0800)]
Fix wrong pitch argument in dct32x32 unit test.

Change-Id: Id9474a1686daebfa3d004e21823bf1888ec9e534

11 years agoMerge tx32x32 experiment.
Ronald S. Bultje [Thu, 10 Jan 2013 16:23:59 +0000 (08:23 -0800)]
Merge tx32x32 experiment.

Change-Id: I615651e4c7b09e576a341ad425cf80c393637833

11 years agoMerge "Merge superblocks64 experiment." into experimental
Ronald S. Bultje [Thu, 10 Jan 2013 16:18:33 +0000 (08:18 -0800)]
Merge "Merge superblocks64 experiment." into experimental

11 years agoMerge superblocks64 experiment.
Ronald S. Bultje [Thu, 10 Jan 2013 01:21:28 +0000 (17:21 -0800)]
Merge superblocks64 experiment.

Change-Id: If6c88752dffdb566f8d4322f135145270716fb8e

11 years agoexperiment a wider loop filter for MB border
Yaowu Xu [Wed, 19 Dec 2012 23:53:03 +0000 (15:53 -0800)]
experiment a wider loop filter for MB border

when larger transforms are used

Change-Id: I25251442b44bf251df4c25a1c1fcf71fb2ad913b

11 years agoNew prediction filter
Adrian Grange [Tue, 8 Jan 2013 22:14:01 +0000 (14:14 -0800)]
New prediction filter

This patch removes the old pred-filter experiment and replaces it
with one that is implemented using the switchable filter framework.

If the pred-filter experiment is enabled, three interopolation
filters are tested during mode selection; the standard 8-tap
interpolation filter, a sharp 8-tap filter and a (new) 8-tap
smoothing filter.

The 6-tap filter code has been preserved for now and if the
enable-6tap experiment is enabled (in addition to the pred-filter
experiment) the original 6-tap filter replaces the new 8-tap smooth
filter in the switchable mode.

The new experiment applies the prediction filter in cases of a
fractional-pel motion vector. Future patches will apply the filter
where the mv is pel-aligned and also to intra predicted blocks.

Change-Id: I08e8cba978f2bbf3019f8413f376b8e2cd85eba4

11 years agoAdds 64x64 hybrid dct/dwt transform
Deb Mukherjee [Tue, 8 Jan 2013 20:18:16 +0000 (12:18 -0800)]
Adds 64x64 hybrid dct/dwt transform

This is to add to the 64x64 transform experiment as an alternative to
a 64x64 DCT.
Two levels of wavelet decomposition is used on a 64x64 block, followed
by 16x16 DCT on the four lowest subbands. The highest three subbands
are left untransformed after the first level DWT.

Change-Id: I3d48d5800468d655191933894df6b46e15adca56

11 years agoMerge "Merge superblocks (32x32) experiment." into experimental
Ronald S. Bultje [Tue, 8 Jan 2013 21:31:37 +0000 (13:31 -0800)]
Merge "Merge superblocks (32x32) experiment." into experimental

11 years agoMerge "vp9_sub_pixel_variance16x2 SSE2 optimization" into experimental
Yunqing Wang [Tue, 8 Jan 2013 20:59:08 +0000 (12:59 -0800)]
Merge "vp9_sub_pixel_variance16x2 SSE2 optimization" into experimental

11 years agoMerge superblocks (32x32) experiment.
Ronald S. Bultje [Tue, 8 Jan 2013 18:29:22 +0000 (10:29 -0800)]
Merge superblocks (32x32) experiment.

Change-Id: I0df99742029834a85c4933652b0587cf5b6b2587

11 years agovp9_sub_pixel_variance16x2 SSE2 optimization
Yunqing Wang [Tue, 8 Jan 2013 18:44:19 +0000 (10:44 -0800)]
vp9_sub_pixel_variance16x2 SSE2 optimization

About 5% decoder speedup.

Change-Id: Ib6687d337af758a536a0e7e289f400990f1f9794

11 years agoMerge vp9-preview changes into experimental branch
John Koleszar [Tue, 8 Jan 2013 18:11:26 +0000 (10:11 -0800)]
Merge vp9-preview changes into experimental branch

Incorportate vp9-preview changes by merging master branch into experimental.

Conflicts:
test/test.mk
vp9/common/vp9_filter.c
vp9/common/vp9_idctllm.c
vp9/common/vp9_invtrans.h
vp9/common/vp9_mbpitch.c
vp9/common/vp9_rtcd_defs.sh
vp9/common/vp9_systemdependent.h
vp9/common/vp9_type_aliases.h
vp9/common/x86/vp9_asm_stubs.c
vp9/common/x86/vp9_subpixel_mmx.asm
vp9/decoder/vp9_decodframe.c
vp9/decoder/vp9_dequantize.c
vp9/decoder/vp9_dequantize.h
vp9/decoder/vp9_onyxd_int.h
vp9/encoder/vp9_bitstream.c
vp9/encoder/vp9_encodeframe.c
vp9/encoder/vp9_rdopt.c

Change-Id: I17f51c3666d1b59cf1a699f87607cbc5d30a87c5

11 years agoreset segement map on key frame
Yaowu Xu [Fri, 14 Dec 2012 07:53:11 +0000 (23:53 -0800)]
reset segement map on key frame

This is to fix a decoder crash when decoder skips a number of frame to
continue decoding from a later key frame.

Change-Id: I3ba116eba6c3440e0528a21f53745f694302e4ad

11 years agoMerge "minor loop filter refactoring and cleanup" into experimental
Yaowu Xu [Tue, 8 Jan 2013 16:40:03 +0000 (08:40 -0800)]
Merge "minor loop filter refactoring and cleanup" into experimental

11 years agominor loop filter refactoring and cleanup
Yaowu Xu [Wed, 19 Dec 2012 19:34:49 +0000 (11:34 -0800)]
minor loop filter refactoring and cleanup

This commit did a couple of minor cleanup/refactoring to prepare for
futher loop filter experiments. It merged y_only version of loop filter
function into the regular one, which makes sure that same logic is used
for functions for picking level and for actual loop filtering.

Change-Id: Id10c94dccd45f58e5310bacfdf6ee63cbb60b86f

11 years agoRemove a few redundant function arguments in encodeframe.c.
Ronald S. Bultje [Mon, 7 Jan 2013 19:41:49 +0000 (11:41 -0800)]
Remove a few redundant function arguments in encodeframe.c.

Also reindent a block of code that was misindented after addition of
the tx32x32 experiment.

Change-Id: Ic3e4aae3effd8a40136da68c9f382af03632ba08

11 years agoRe-enable support for static_threshold (encode_breakout).
Ronald S. Bultje [Mon, 7 Jan 2013 19:02:14 +0000 (11:02 -0800)]
Re-enable support for static_threshold (encode_breakout).

Change-Id: Ibd7380f478d3127f9db91d0a4fd2fd0dfde961ab

11 years agoDon't use tx32x32 for macroblocks.
Ronald S. Bultje [Fri, 4 Jan 2013 20:05:40 +0000 (12:05 -0800)]
Don't use tx32x32 for macroblocks.

Change-Id: Ib674e0153ca360867ab7a20ba291ac9171a01250

11 years ago64x64 blocksize support.
Ronald S. Bultje [Sun, 6 Jan 2013 02:20:25 +0000 (18:20 -0800)]
64x64 blocksize support.

3.2% gains on std/hd, 1.0% gains on hd.

Change-Id: I481d5df23d8a4fc650a5bcba956554490b2bd200

11 years agoFix mode selection infinite loop bug
Adrian Grange [Fri, 4 Jan 2013 17:00:47 +0000 (09:00 -0800)]
Fix mode selection infinite loop bug

Mode selection for SBs could enter an infinite loop because
the interpolation filter mode index was not being reset
correctly.

Change-Id: I4bbe726f29ef5b6836e94884067c46084713cc11

11 years agoFurther change to mv reference search.
Paul Wilkins [Thu, 3 Jan 2013 15:14:36 +0000 (15:14 +0000)]
Further change to mv reference search.

This experimental change reorders the search so
that all possible references that match the target
reference frame are tested first and these in order
of distance from the current block. These will usually
be the highest scoring candidates.

If we do not find enough good candidates this way
we try non matching cases. These will usually be lower
scoring candidates.

The change in order together with breakouts when
we have found enough candidates should reduce
the computational cost and especially reduce the number
of sort operations.

Quality Results:
Std Hd +0.228%, Hd +0.074%, YT +0.046%, derf +0.137%

This effect is probably due to the fact that more distant
weak candidates are now less likely to get "promoted" over
near candidates even if they are repeated.

Change-Id: Iec37e77d88a48ad0ee1f315b14327a95d63f81f6

11 years agoUse seg/ref/mode offsets in loop_filter_partial.
Marco Paniconi [Thu, 3 Jan 2013 23:47:34 +0000 (15:47 -0800)]
Use seg/ref/mode offsets in loop_filter_partial.

Use the proper seg/mode/ref filter offsets when selecting the
frame loop filter level for fast mode (pick_filter_level_fast).

Change-Id: I2473e2131c800ad19755cb6211ad735fecfe2ac0