Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Icb8ab043f942c02aa8571ffdd8f92ebd1ff606e1

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Ieb2b1e6bc78c052aab00f2e519afc897b12809f8

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I738103ad40372749d96b5357726361812828d3ef

Adds geometry shader check for test

Components: Vulkan
VK-GL-CTS Issue: 1900

Affects:
dEQP-VK.query_pool.statistics_query.input_assembly*.primary.*adjacency

Change-Id: I6aeb72143231d59711cb1d6ea98bc2cc0264bc84
(cherry picked from commit c4416209513122ba8f21ca1d9c016a07d65bb7ba)

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ibf71699514dcc482235457301c8cb591e5ef4ac2

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I147ae97908fe69487a55770d3c3e7dd9b29f6356

Remove event tests which use illegal behaviour

Two event tests were relying on being able to wait on the device for
an event to be set on the host. This behaviour is not allowed.

Affects:

dEQP-VK.synchronization.smoke.events
dEQP-VK.synchronization.basic.event.host_set_device_wait

Components: Vulkan

VK-GL-CTS issue: 2108

Change-Id: Idbb8b4e2468d617b3e47d5055622789a2dd3eb00
(cherry picked from commit b45f4268074897cb4ee7da4b81a17b310301d77b)
(cherry picked from commit 8be9e27df3c1e1d9f50e549d7293bc202072d80d)

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I88785d64ee5ce89b2ddcc47e317c39a09cf36c8b

Remove event tests which use illegal behaviour

Two event tests were relying on being able to wait on the device for
an event to be set on the host. This behaviour is not allowed.

Affects:

dEQP-VK.synchronization.smoke.events
dEQP-VK.synchronization.basic.event.host_set_device_wait

Components: Vulkan

VK-GL-CTS issue: 2108

Change-Id: I3e3185d4b6ca3be94609b1d5d218e0d46076243d
(cherry picked from commit b45f4268074897cb4ee7da4b81a17b310301d77b)

Remove event tests which use illegal behaviour

Two event tests were relying on being able to wait on the device for
an event to be set on the host. This behaviour is not allowed.

Affects:

dEQP-VK.synchronization.smoke.events
dEQP-VK.synchronization.basic.event.host_set_device_wait

Components: Vulkan

VK-GL-CTS issue: 2108

Change-Id: Idbb8b4e2468d617b3e47d5055622789a2dd3eb00
(cherry picked from commit b45f4268074897cb4ee7da4b81a17b310301d77b)

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I758092828fa1c8cf4398dd34630ba40de3ca4399

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Ie94ff317fc6fc42057ce607e751d774529af844f

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I7771bb8031b5cf0d28faf840bfc4fa9d8e6c3828

Half-float texture interpolation tolerance is too small.

Need to increase the precision tolerance for VSI mobile GPUs.

Components: Vulkan

Affects: dEQP-VK.texture.explicit_lod.2d.*

VK-GL-CTS issue: 2273

Change-Id: I957f8af87dd7413d6a4e50f2141cc777f5e292d6

Use vkBindImageMemory2 to bind disjoint images

Vulkan specification says that applications must not use
vkBindImageMemory to attach memory to a VkImage object created with
the VK_IMAGE_CREATE_DISJOINT_BIT.

Component: Vulkan

Affects: dEQP-VK.ycbcr.plane_view.memory_alias.*

VK-GL-CTS Issue: 2289

Change-Id: Icdcf802ff9da6018e71a66fd27954923600863d2

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I36c436cd72ec705b74e162b7bd11aff4a684f123

More vertex-invocation fixes for synchronisation tests

The fix for multiple vertex-shader instances was missed when the
timeline semaphore version of these tests was added. This is the fix
from https://gerrit.khronos.org/c/4451 applied to these new tests.

Components: Vulkan
VK-GL-CTS issue: 2253, 1958
Affects: dEQP-VK.synchronization.op.*.timeline_semaphore.write_indirect_buffer_draw*

Change-Id: I6013ef88a0acd362948c179416928c1d3fc064dd

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ifeab9cfd06891288494e9080d40819c62a2092a7

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I6221b31126a23415f4aceb05f91fc8c7b166c876

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: Ie332664c1049e2e1339f60aa7dd2615d1aa83105

Fix dEQP-VK.geometry.layered.2d_array.readback

The patch fixes several image memory barriers that
are missing the (color or depth/stencil) read access
mask. The read access mask is needed because the
attachments are setup with the VK_ATTACHMENT_LOAD_OP_LOAD
load operation.

Components: Vulkan

VK-GL-CTS Issue: 2227

Affects: dEQP-VK.geometry.layered.2d_array.readback

Change-Id: I22b696f449cb83d88f3ec15d928577d6b3d65b6f

Correctly handle normalized formats in FloatFormat

For the texture explict lod tests normalized values were treated as 8
bit floating point formats when calculating the reference interval.
This ignores the fact that normalized formats are encoded as 1 / N,
where N is an integer, this results in the rounding used in tests not
being able to accurately round normalized formats.

This incorrect rounding causes the acceptable ranges to be
significantly smaller than other formats and extremely asymetric
around the ideal filtered value for certain samples.

Affects: dEQP-VK.texture.explicit_lod.*

Components: Vulkan

VK-GL-CTS issue: 2189

Change-Id: Ia4f3adefab4bfb5d9c91bd7033199b0e107179d5

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: If35028985c57f66a6fc3f3d11ac1a9485493f7f2

Return Quality Warning for inaccurate filtering

For cases when the relaxed precision has to be used to verify a sample
in the explicit lod tests return a quality warning rather than a pass.

Affects: dEQP-VK.texture.explicit_lod.*

Components: Vulkan

VK-GL-CTS issue: 2189

Change-Id: If1cad3ae74bc91636527215f6871faa2e1feee79

Fix dEQP-VK.geometry.layered.2d_array.readback

The patch fixes several image memory barriers that
are missing the (color or depth/stencil) read access
mask. The read access mask is needed because the
attachments are setup with the VK_ATTACHMENT_LOAD_OP_LOAD
load operation.

Components: Vulkan

VK-GL-CTS Issue: 2227

Affects: dEQP-VK.geometry.layered.2d_array.readback

Change-Id: Ie96c93e6d8fee1ea0c0a63417707ec7479551413

Protected Memory allocation tests require compatible device

For memory allocation tests that detect protected memory capability,
ensure that the device being used first enables the protected memory
feature. If the physical device does not support protected memory,
the allocation type is skipped in the test.

Affects: dEQP-VK.memory.allocation.*

Components: Vulkan

VK-GL-CTS issue: 2163

Change-Id: I899c7cf7e13d04f2674de47c3bb4d08f3de589f4

Protected Memory allocation tests require compatible device

For memory allocation tests that detect protected memory capability,
ensure that the device being used first enables the protected memory
feature. If the physical device does not support protected memory,
the allocation type is skipped in the test.

Affects: dEQP-VK.memory.allocation.*

Components: Vulkan

VK-GL-CTS issue: 2163

Change-Id: I899c7cf7e13d04f2674de47c3bb4d08f3de589f4

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I0b304876f100815c74515584179d954ac0f65788

Only require geometryStreams feature in XFB query tests if needed

Change transform feedback query tests to only require the
geometryStreams feature for test cases using stream ID != 0.

Affects:
- dEQP-VK.transform_feedback.simple.query_0_*
- dEQP-VK.transform_feedback.simple.host_query_reset_0_*

Components: Vulkan

VK-GL-CTS Issue: 2197

Change-Id: Id1378f58e6634dd70ad89843e000d047af0ea496

Fix transform feedback triangle strip verification

Vulkan specifies that the first vertex in a multi vertex primitive is
implementation specific, but the winding must be respected.

This change allows any first vertex as long as the vertices and winding
are correct.

Components: Vulkan

Affects:
dEQP-VK.transform_feedback.simple.triangle_strip_with_adjacency_*

VK-GL-CTS Issue: 2193

Change-Id: I3d195c50a4b3b1f51529014fb97cebef19f872b7

Fix dEQP-VK.api.image_clearing.*.clear_depth_stencil_image

Check device extensions before trying to create the renderpass using
vkCreateRenderPass2KHR.

Components: Vulkan

VK-GL-CTS Issue: 2208

Affects: dEQP-VK.api.image_clearing.*

Change-Id: I02bb1ccb8f07c7f2baa7357a639f4bdcc1dcd73f

Add memory barrier to fragment shader interlock tests.

Image or buffer written by GPU are copied to host-visible buffer used to
verify test's results.
Added a TRANSFER_WRITE/HOST_READ pipeline barrier to make sure that the data
accessed by host is up-to-date.

Component: Vulkan

Affects: dEQP-VK.fragment_shader_interlock.basic.*

VK-GL-CTS Issue: 2165

Change-Id: I6d458b2e650a3813e62948d670b8a53e864aed37

Modify test line position in LinesTestInstance::generateLines()

This slightly change a test line position in order to fix
dEQP-VK.rasterization.primitives.no_stipple.smooth_lines_wide, to avoid
a false failure according to comments in CL#5152.

Affects: dEQP-VK.rasterization.primitives.*

Components: Vulkan

Change-Id: Ie8bde1d1d32f76939ce4a4ba21aaec4c471edd63

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I654934956a489ddcdec47ac8fc3e2fe638929950

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I420bc4aa41a2f7a67434b4f674c3d3aa161dc6c3

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: Id9ed312f96fa266a0e3809211b14566ece03e791

Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3

Change-Id: I37d5b18d5980372057827bc4435239be98fd30bc

Fix SPIR-V assembly tests with bad cfgs

* Update SPIR-V assembly tests to not declare a continue target as a
merge block

Component: Vulkan

VK-GL-CTS Issue: 2122

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.switch_block_order.out_of_order*
dEQP-VK.spirv_assembly.instruction.graphics.opphi.out_of_order*
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_loop_construct*
dEQP-VK.spirv_assembly.instruction.graphics.loop.multi_block_continue_construct*
dEQP-VK.spirv_assembly.instruction.graphics.loop.continue*
dEQP-VK.spirv_assembly.instruction.graphics.loop.break*
dEQP-VK.spirv_assembly.instruction.graphics.loop.return*

Change-Id: I370331414aae27b53ed79b448b72581e2352c3d7

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Id7608050ab3f1c5ce3d26a1480af0de7d90d75ff

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I51213fc50189215a04c9206a8b805962052235cb

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I2a051b8a36b997c3f904ddd78657de8c1719a53b

Allows NaNs in an assert

Components: Vulkan
VK-GL-CTS Issue: 2103

Affects:
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_*

Change-Id: I5848660d120b5a4a07df589a74f47b8ca30befb5

Adds subgroup ops stage check

Components: Vulkan
VK-GL-CTS Issue: 2084

Affects:
dEQP-VK.memory_model.message_passing.*.subgroup.*
dEQP-VK.memory_model.write_after_read.ext.*.subgroup.*

Change-Id: Ibb820b4d3de1782bc844f3eb32b6e752745e9976

Re-enable tests

Change-Id: Ic4d90d99b69ef931ba2f3f49538201762eb6746e

Account for VS executing more than once when atomics are used.

Components: Vulkan

Affects: dEQP-VK.glsl.opaque_type_indexing.atomic_counter.*
         dEQP-VK.glsl.atomic_operations.*

Change-Id: I15eabf9b47af204fd13370efdc323af141b6b11b

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I0f9446b635621472d72566a6176c7d0c00306263

Avoid undefined behaviour when calculating subgroup ballot masks

The affected tests are shifting the bits of the last component of the
computed ballot masks by 32. However, the SPIR-V specification
establishes that the result of OpShift* is undefined if `Shift` is
greater than *or equal* to the bit width of the components of `Base`.

Affects:

dEQP-VK.subgroups.ballot_other.*

Components: Vulkan

VK-GL-CTS issue: 2083

Change-Id: I8c9b4373f1429669a40741986916e8d71b7eb573

Fix bad merge from https://gerrit.khronos.org/#/c/5107/

When https://gerrit.khronos.org/#/c/4874/ was cherry-picked
to the vulkan-cts-1.1.6 branch it would have hit conflicts
with the new VK_EXT_line_rasterization tests from
https://gerrit.khronos.org/#/c/3997/.

This CL fixes a bad conflict resolution in
tcuRasterizationVerifier.cpp that forced the verification
mode of all line types top be scrict, when they should
have got their verification mode from
scene.verificationMode.

This CL also modifies the position of the test lines
for case 2 of LinesTestInstance::generateLines(). The
position of the last line, added with CL 5107, was moved
lower to avoid excessive overlap with the other three
lines. This excessive overlap caused many pixels to
share edges and aggravate a minor flaw in the software
line rasterizer where it always assumes full coverage on
pixels that share edges of two or more triangles.
They may actually still be only partial coverage when
doing smooth or multisample rendering, and forcing it
to full coverage won't match what hardware does.

Affects: dEQP-VK.rasterization.primitives.*

Components: Vulkan

VK-GL-CTS Issue: 2062

Change-Id: Ie865f46c24e8265fd47354faaf9be5efd002b2d4

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I7054b3a97f5f57fb5d5829f21991efe70108c77a

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I4d9b046396a757d9fce9a0a326b150deb37015ce

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: Ia01386a2e8fec477414b8488a7bfa883265c32ec

Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3

Change-Id: Iecc5fe7d8f5119a46a78fd7d6f3c3b613c45059d

Re-include some Android CTS tests

Components: Android

Included tests:

dEQP-VK.glsl.builtin.precision.*
dEQP-VK.spirv_assembly.instruction.compute.opfunord.*
dEQP-VK.spirv_assembly.instruction.*.indexing.*u32*
dEQP-VK.spirv_assembly.instruction.*.indexing.*s32*

Change-Id: Ib9be1f9ef388c7baeaf8f11b1dd7e60efdf72dc5

Provide a highp variable to MAKE_HIGH_BALLOT_RESULT

The MAKE_HIGH_BALLOT_RESULT macro assumes the input is 32bit.
Given a mediump variable, ex: gl_SubgroupSize, would produce an
undefined result when the input value is >= 16 and the computation
is in 16 bits.
Provide a highp input would ensure the computation is in 32 bits.

Affects:
  dEQP-VK.subgroups.ballot_other.*

Components: vulkan

VK-GL-CTS issue: 1894

Change-Id: I22987f20be3d08444c52cb722fc23494777a5636

Fix incorrect use of dlopen/dlclose

Function pointers returned by dlsym are retained after dlclose() is
called. If the library is actually unloaded by that dlclose() call, then
calling through those function pointers then triggers undefined
behavior.

Components: Vulkan
Affects: dEQP-VK.api.external.memory.android_hardware_buffer.*

Google Bug: b/140826027

Change-Id: I1da2d10e97e5567578bf06d768820764882f7126

Fix memory leaks in dEQP-VK.api.invariance.random

Test dEQP-VK.api.invariance.random contains memory leaks.
Change fixes memory leaks.

Components: Vulkan

VK-GL-CTS Issue: 2110

Affects: dEQP-VK.api.invariance.random

Change-Id: I4ccd9d87b69f51da661ca85f10eb347086594aaa

Fix invalid SPIR-V in GraphicsFuzz tests

Components: Vulkan

VK-GL-CTS Issue: 2122

Affected tests:

dEQP-VK.graphicsfuzz.continue-and-merge
dEQP-VK.graphicsfuzz.control-flow-switch
dEQP-VK.graphicsfuzz.discard-continue-return
dEQP-VK.graphicsfuzz.fragcoord-control-flow-2
dEQP-VK.graphicsfuzz.fragcoord-control-flow
dEQP-VK.graphicsfuzz.loop-call-discard
dEQP-VK.graphicsfuzz.mat-array-deep-control-flow
dEQP-VK.graphicsfuzz.mat-array-distance
dEQP-VK.graphicsfuzz.return-in-loop-in-function
dEQP-VK.graphicsfuzz.unreachable-continue-statement

Change-Id: Iaa7448ee4a815d9e3a1c8a5582214ecd599ac143

Whitelist Vulkan CTS 1.1.6.3

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: Ib46d2ea03898930641539bd0ad1cf657c2994aa4

uvec2 tests for VK_KHR_buffer_device_address

Add variants of the 'convert' tests that convert to and from uvec2
rather than uint64_t.

Components: Vulkan
VK-GL-CTS Issue: 2018

Affects: dEQP-VK.binding_model.buffer_device_address.*
Change-Id: I9e1a2f031e295b9200faff571aae2fc5cbb9005c
(cherry picked from commit bcc3bf2dee4bcd8505c1b0c16ee05cafad185749)

Tests for VK_KHR_buffer_device_address

Components: Vulkan
Affects: dEQP-VK.binding_model.buffer_device_address*
Affects: dEQP-VK.compute.cooperative_matrix*phys*
Affects: dEQP-VK.memory_model.*phys*
Affects: dEQP-VK.ssbo.*phys*
Affects: dEQP-VK.spirv_assembly.*phys*
Change-Id: I045b5832e9857f6e826957e204237a32e0bcbce4
(cherry picked from commit 86db0cf343430c2b434f9313c6c4ef5188d9bc23)

Bump timeout for the basic fence tests

10ms for the LONG_FENCE_WAIT could cause spurious test failures for CPU-based
Vulkan implementations when the CPU is under heavy load.
This is now bumped to a second, but assuming the test passes, this should never
block for the entire second.

Affects: dEQP-VK.synchronization.basic.fence.*

Components: Vulkan
Change-Id: Ice07a1697b57e789b9f57f4a5da663c83a0c132a

Temporarily remove lines_wide tests

Components: Vulkan

Affects:
dEQP-VK.rasterization.primitives.no_stipple.smooth_lines_wide
dEQP-VK.rasterization.primitives_multisample_2_bit.no_stipple.smooth_lines_wide
dEQP-VK.rasterization.primitives_multisample_4_bit.no_stipple.smooth_lines_wide
dEQP-VK.rasterization.primitives_multisample_8_bit.no_stipple.rectangular_line_strip_wide
dEQP-VK.rasterization.primitives_multisample_8_bit.no_stipple.smooth_lines_wide
dEQP-VK.rasterization.primitives_multisample_16_bit.no_stipple.smooth_lines_wide

Change-Id: Id74c00f56519d03fb300a4a06bc20f8f0365bd3e

Fix RGB9E5 encode

The overflow correction was broken and resulted in encoded values being
2x too large.

Components: Framework
VK-GL-CTS issue: 2132
Affects: dEQP-VK.*e5*

Change-Id: Ibcab4c889b044c8668aae3c7a1288b8cda1ff0e6

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: Ie910031c0296648e7ff34fb69cdbed0de5f24a1b

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I13e1238c4bfc3cb1366e25def3b081591a8101de

Do the 'from UNDEFINED' layout transition only on the first pass

The test uses multiple submissions, each rendering to a part
of the same render target. Only the first submission should do
the transition 'from' UNDEFINED layout, otherwise each pass (submit)
would invalidate render target contents from previous submits.

Components: Vulkan

VK-GL-CTS Issue: 2131

Change-Id: Ic424e391e0348f6333b50d4c0f4f57d161ec95fb
Affects: dEQP-VK.descriptor_indexing.*

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I4d9bef08ce50fbba4d6a61cbba1e3cdb28051543

Add two more formats with proper threshold values.

Need to add two more formats with proper threshold values in
vkApiCopiesAndBlittingTests.cpp: getFormatThreshold() to make
CTS pass on some VSI mobile GPUs.

Affects:
dEQP-VK.api.copy_and_blit.core.blit_image.simple_tests.*
dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.*
dEQP-VK.api.copy_and_blit.dedicated_allocation.blit_image.*

Components: Vulkan

VK-GL-CTS issue: 2112

Change-Id: Ia3a314fd825ed13c44e49720fffffa2dff8f26af

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I0845a703755ac572d54f56394a04a9a4ace2fdce

Extend rasterization testing, modify verification

dEQP-VK.rasterization.primitives.lines tests are extended to add tests
drawing vertical and horizontal lines.

Extend dEQP-VK.rasterization.primitives.lines and
dEQP-VK.rasterization.primitives_multisample_n_bit.lines to test at 258
resolution (a non power of two resolution).

The strict line verification coverage is modified to allow checking of
vertical and horizontal lines. Previously pixels in vertical or hori-
zontal lines were marked as partially covered and hence the test did
not detect whether the lines were rendered correctly or not.

Affects: dEQP-VK.rasterization.primitives*

Components: Vulkan

VK-GL-CTS Issue: 2062

Change-Id: Ifb76a44ba1ebdc97353bbd1a4b2552e415f2723d

Check memory model support in volatile atomic tests

Volatile atomic tests were not checking vulkan memory model support.

Components: Vulkan
VK-GL-CTS issue: 2125

Affected tests:

   dEQP-VK.spirv_assembly.*atomic*

Change-Id: I67557361e2df9fc057ab38a1104f66512a532cf0
(cherry picked from commit 5ded1abda3169e29a6116b6e6b53ce0b9a6d5ab2)

Add feature checks to subgroups tests

Components: Vulkan
VK-GL-CTS Issue: 2082

Affects:
dEQP-VK.subgroups.*

Change-Id: Ide9aeaf106dcf1efbc2cf90cd6b46a61586c4f72

Extend rasterization testing, modify verification

dEQP-VK.rasterization.primitives.lines tests are extended to add tests
drawing vertical and horizontal lines.

Extend dEQP-VK.rasterization.primitives.lines and
dEQP-VK.rasterization.primitives_multisample_n_bit.lines to test at 258
resolution (a non power of two resolution).

The strict line verification coverage is modified to allow checking of
vertical and horizontal lines. Previously pixels in vertical or hori-
zontal lines were marked as partially covered and hence the test did
not detect whether the lines were rendered correctly or not.

Affects: dEQP-VK.rasterization.primitives*

Components: Vulkan

VK-GL-CTS Issue: 2062

Change-Id: Ifb76a44ba1ebdc97353bbd1a4b2552e415f2723d

Fix SFR swapchain test's implicit layout transitions

The Vulkan spec says that layout transitions done on peer bound
image memory requires the implementation to support
VK_PEER_MEMORY_FEATURE_GENERIC_SRC_BIT and
VK_PEER_MEMORY_FEATURE_GENERIC_DST_BIT. The test never checked
for this capability and did implicit render pass layout
transitions anyway.

This CL updates the test to use an explicit layout transitions
on local aliases of the image when the implementation doesn't
support doing peer-to-peer transfer.

This CL also fixes a bug in the SFR rects definition in
VkBindImageMemoryDeviceGroupInfo to specify the correct number
of rectangles.

Affects:

dEQP-VK.wsi.win32.swapchain.render.*
dEQP-VK.wsi.win32.swapchain.modify.*

Components: Vulkan

VK-GL-CTS issue: 2094

Change-Id: I31b7099a6d5c4f11be83d6d14a5c02cca6408441

Apply the same relaxed precision fix for interface_blocks.* to basic_type.*

Fix relaxed precision and no perspective dEQP tests

In the RelaxedPrecision case, change epsilon to 2e-3 for a 16-bit float.
In the NoPerspective case, change epsilon to 3e-7 for a 32-bit float.

The epsilon is now relative to the correct value.

Affects:
dEQP-VK.spirv_assembly.instruction.graphics.cross_stage.basic_type.*

Components: Vulkan

VK-GL-CTS issue: 1818

Change-Id: I615e65f2f6e4287dc41ff981f18972cf14bcb374

Remove verification of string bytes after null termination.

Spec does not require to zero bytes after the null-termination of the string.

Components: Vulkan

VK-GL-CTS Issue: 2117

Affects: dEQP-VK.pipeline.executable_properties.*

Change-Id: Ia07b51f22379cea28ca73fe0a1594ef5230c27af

Fix cbuffer packing test

Components: Vulkan

VK-GL-CTS issue: 2109

Affects:
dEQP-VK.spirv_assembly.instruction.compute.hlsl_cases.cbuffer_packing

Change-Id: Iebedd63004bceed7542a433da9be3d43a59fed2e

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I6690ecfeeaf879819d23bb2a8a65c1713809e6a1

Re-align importing dedicated memory to spec

Re-implemented importing dedicated memory for synchronization test to
better align with the Vulkan spec. The current solution
makes the assumption that not requiring memory to be dedicated upon
import implies that the memory is required to not be dedicated, and this
does not appear to align with the spec.

Affects:
    * dEQP-VK.synchronization.signal_order.*

Components: Vulkan

VK-GL-CTS issue: 2071

Change-Id: Ie1ada8e4966e044ff0d265dce65f4a0680b311aa

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I163fd1d3c3f3a600e3a89031d350eb2b08f81e4d

Add memory barrier to VK transform_feedback tests

The transform feedback tests are reading the transform
feedback buffers which was written by the GPU from the
host. Added a memory barrier to make sure the data is up to
date when it is accessed by the host.

Affects: dEQP-VK.transform_feedback.*
Components: Vulkan
VK-GL-CTS issue: 2096

Change-Id: Ibf9f86e9c1f02bdbfe822f62c44c30155ed8c555

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: Idea5f48ee1eb6dfa2290d738cabff96c7e88daad

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: I9adaa87d0bf5d06a12bfc2fcd4b8a30568cefb48

Whitelist Vulkan CTS 1.1.6.2

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: I88e01d7a9c754c8a11cb5f4505257fd338eabbf7

Do not reset perf queries in multi submitted cmdbuffer

Some implementations can require multiple passes to gather values for
their performance queries. It's important not to reset the query pool
in a batch that can be submitted multiple times, otherwise the queries
result risk to never become available.

Compontents: Vulkan
Affects: dEQP-VK.query_pool.performance_query.*

Change-Id: Ief00457fc0808a7c5ee7c0bf6aaf7de7f3042ca5

Update VK_KHR_performance_query enumerate

Components: Vulkan
Affects: dEQP-VK.query_pool.performance_query.enumerate*

Change-Id: I443c1c9b7a1903063b27b77fc47cbb88259aa407
(cherry picked from commit bc519fecec3d1b27e0e5ee1a4947257260202eff)

Tests for VK_KHR_performance_query

Add tests:
 * dEQP-VK.query_pool.performance_query.*

Components: Vulkan

VK-GL-CTS issue: 1302

Update VK_KHR_performance_query headers

Align CTS header for VK_KHR_performance_query with API MR 3268
Components: Vulkan

Affects:
 dEQP-VK.query_pool.performance_query.*
 dEQP-VK.api.info.get_physical_device_properties2.features
 dEQP-VK.api.info.get_physical_device_properties2.properties

VK-GL-CTS issue: 1947

Change-Id: I4d3c62dace2d259061f78d3014deb05bc4eac9d7
(cherry picked from commit 32556493fcafd676ec5d8fcfd3492a8c30fa0f97)
(cherry picked from commit 57bdbad1c7d6d527a30ae211164edab945818def)

Check renderpass2 support in image clearing tests

This commit makes sure VK_KHR_create_renderpass2 is supported before
using it in some image clearing tests.

Affected tests:
dEQP-VK.api.image_clearing.*separate_layouts*

Components: Vulkan
VK-GL-CTS issue: 2101

Change-Id: Ib1a44b44f771bb31fd1ef798d2727370d143a1fa

Fix check of api features

Fixes the cherry pick 282341d2cf5da0d9aaea1547958eb54c3f84ee0f.

Compontents: Vulkan
Affects: dEQP-VK.api.info.get_physical_device_properties2.features

Change-Id: I1d102716767c7bef0b872a5ebe1eb1d77bcd11b5

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I96bc5705c41b8ec87b7f14afc0cfa354b84cad4e

Split descriptor set indexing render pass workload

The render pass workload for descriptor set indexing tests which call
DynamicBuffersInstance::iterate should be split into multiple
submissions to prevent timeouts observed in
dEQP-VK.descriptor_indexing.uniform_buffer_dynamic_in_loop
test.

A number (16) of command buffers, each for a separate render area, are
created and submitted separately.

Affects: dEQP-VK.descriptor_indexing*

Components: Vulkan

VK-GL-CTS Issue: 2061

Change-Id: Ib232854a1224aadbd63eaad30e15f893eeb48f85

Investigation for Khronos issue;
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/2061

Change-Id: Ib232854a1224aadbd63eaad30e15f893eeb48f85

Reduce dEQP-VK.pipeline.render_to_image allocs to within platform limits

These tests allocate an image of upto 25% of VkMemoryHeap heapSize and
should be limited to the value in
PlatformMemoryLimits.totalSystemMemory.

Component: Vulkan

VK-GL-CTS Issue: 2087

Affects:
dEQP-VK.pipeline.render_to_image*

Change-Id: Ie7d775cc55fdb54e448fc1c973d1e17925711e47

Fix descriptor_indexing.input_attachment subpass description

The input attachments in the subpass description did not match the
descriptor set layout and shader. Unused attachment references have
been inserted to pad out the subpass description.

Components: Vulkan

VK-GL-CTS Issue: 2072

Affects: dEQP-VK.descriptor_indexing.input_attachment*

Change-Id: Iab36be779007828ddb25fe0600305a19be448804

Merge vk-gl-cts/vulkan-cts-1.1.4 into vk-gl-cts/vulkan-cts-1.1.5

Change-Id: I74696bcb3e23aa3e8bde59ebea3137b262dd1394

Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4

Change-Id: Ia5d78f0656fb1a2b2e4f989ba556edc3154856f7

Tests for VK_KHR_separate_depth_stencil_layouts

Test coverage for VK_KHR_separate_depth_stencil_layouts. See
https://gitlab.khronos.org/vulkan/vulkan/merge_requests/3172

This change modifies several test groups to use a single
image aspect bit for depth+stencil formats rather than the
VU required D+S aspects.

Where appropriate the tests are also modified to use
the new depth-only or stencil-only optimal layouts.

Affects:

dEQP-VK.api.copy_and_blit.*d16_unorm_s8_uint*
dEQP-VK.api.copy_and_blit.*d24_unorm_s8_uint*
dEQP-VK.api.copy_and_blit.*d32_sfloat_s8_uint*

dEQP-VK.api.image_clearing*d16_unorm_s8_uint*
dEQP-VK.api.image_clearing*d24_unorm_s8_uint*
dEQP-VK.api.image_clearing*d32_sfloat_s8_uint*

dEQP-VK.pipeline.stencil*d16_unorm_s8_uint*
dEQP-VK.pipeline.stencil*d24_unorm_s8_uint*
dEQP-VK.pipeline.stencil*d32_sfloat_s8_uint*

dEQP-VK.pipeline.depth*d16_unorm_s8_uint*
dEQP-VK.pipeline.depth*d24_unorm_s8_uint*
dEQP-VK.pipeline.depth*d32_sfloat_s8_uint*

dEQP-VK.*.depth_stencil_resolve*d16_unorm_s8_uint*
dEQP-VK.*.depth_stencil_resolve*d24_unorm_s8_uint*
dEQP-VK.*.depth_stencil_resolve*d32_sfloat_s8_uint*

Change-Id: I147f3736614cc897f1319c5aac5ed1fdba2d7b66
Compontents: Vulkan
(cherry picked from commit 39e17004ec33f0e546e6f391f933fb938e8c507d)

Whitelist Vulkan CTS 1.1.6.1

Affects: dEQP-VK.api.driver_properties.properties

Components: Vulkan

Change-Id: Id79758cf4688ec414176433edae0914826f088df

Merge vk-gl-cts/vulkan-cts-1.1.5 into vk-gl-cts/vulkan-cts-1.1.6

Change-Id: I592b6674f5e3a5a1f2a6d050dcc7263b0e5d682c

Add missing write to PointSize

The primitive topology is POINT_LIST for test cases covering the vertex
stage, but the vertex shader in these cases isn't supplying a value for
PontSize.

Affects:

dEQP-VK.binding_model.buffer_device_address.*.vert

Components: Vulkan

VK-GL-CTS issue: 2080

Change-Id: Ibbbeb143bf957f9494b1df84e69bc4a01c891c6a

Fix missing image memory barrier in WSI display timing tests

The key part of the missing image memory barrier is changing
VK_IMAGE_LAYOUT_UNDEFINED to VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL
(for the first time).

Affects: dEQP-VK.wsi.android.display_timing.*

Components: Vulkan

VK-GL-CTS issue: 2079

Change-Id: I79e142c9c2a602e066a51e69e3aca9a1d2c0e650