Nico Weber [Thu, 6 Apr 2023 00:13:57 +0000 (20:13 -0400)]
Chia-hung Duan [Thu, 6 Apr 2023 00:06:34 +0000 (00:06 +0000)]
Revert "[scudo] Switch to use MemMap in tests"
This reverts commit
4151477021170d8937f8fc820187d5934eb93c7d.
Chia-hung Duan [Wed, 5 Apr 2023 22:38:32 +0000 (22:38 +0000)]
[scudo] Fix __require_constant_initialization__ on Android
Differential Revision: https://reviews.llvm.org/D147667
Vitaly Buka [Wed, 5 Apr 2023 23:16:49 +0000 (16:16 -0700)]
[lsan] Rename IgnoreObjectLocked into IgnoreObject
We don't lock allocator for this call.
Vitaly Buka [Wed, 5 Apr 2023 23:12:04 +0000 (16:12 -0700)]
[hwasan] Use GetBlockBegin instead of GetBlockBeginFastLocked
Asan and lsan use non-locked version as well.
IgnoreObjectLocked name is missleading.
Aart Bik [Tue, 4 Apr 2023 22:14:32 +0000 (15:14 -0700)]
[mlir][sparse][gpu] end-to-end example with sparse GPU pipeline
Reviewed By: Peiming
Differential Revision: https://reviews.llvm.org/D147576
Ilia Kuklin [Wed, 5 Apr 2023 22:49:53 +0000 (15:49 -0700)]
[MSP430] Add CFI instructions for MSP430.
Implement emission of DWARF CFI instructions for MSP430. This includes descriptions of stack frame layout and location of callee-saved registers that could be used for backtracing.
Differential Revision: https://reviews.llvm.org/D146966
Dávid Bolvanský [Wed, 5 Apr 2023 22:49:55 +0000 (00:49 +0200)]
[Tests] More InlineCost tests with attributes only on callsites
Bill Wendling [Tue, 4 Apr 2023 23:17:52 +0000 (16:17 -0700)]
[Clang][NFC] Refactor "Designators" to be more similar
This makes the two interfaces for designators more similar so that it's
easier to merge them together in a future refactoring.
Differential Revision: https://reviews.llvm.org/D147580
Richard Smith [Wed, 5 Apr 2023 21:28:57 +0000 (14:28 -0700)]
Lazily deserialize default member initializers.
This is important to break deserialization cycles, where a lambda in a
default member initializer can refer to the field as its context
declaration, and the initializer of the field can refer back to the
lambda.
This is a follow-up to
bc73ef0031b5, which applied the same fix to
variable declarations for the same reason.
Matt Arsenault [Fri, 3 Mar 2023 17:11:58 +0000 (13:11 -0400)]
RegAllocFast: Fix dropping subreg indexes on unassigned subreg defs
This was assuming all register operands were assigned to physical registers.
This should ignore the operands which weren't assigned in this run.
Fixes #61134
Aart Bik [Wed, 5 Apr 2023 19:57:23 +0000 (12:57 -0700)]
[mlir][sparse][gpu] sparse GPU code generator pipeline setup
Reviewed By: Peiming
Differential Revision: https://reviews.llvm.org/D147571
Han Zhu [Wed, 5 Apr 2023 22:01:04 +0000 (15:01 -0700)]
[isel] Pre-commit test for pr61964 fix
Dávid Bolvanský [Wed, 5 Apr 2023 21:58:06 +0000 (23:58 +0200)]
[Tests] Added InlineCost test when arg is known as dereferenceable
Jeff Byrnes [Thu, 23 Mar 2023 16:59:31 +0000 (09:59 -0700)]
[AMDGPU] Add Lower Bound to PipelineSolver
Ziqing Luo [Wed, 5 Apr 2023 21:52:49 +0000 (14:52 -0700)]
Reland "[-Wunsafe-buffer-usage] Fix-Its transforming `&DRE[any]` to `&DRE.data()[any]`"
This commit relands
87b5807d3802b932c06d83c4287014872aa2caab, where a
test fails on a few specific targets. Now hard-code a target
for the test.
V Donaldson [Wed, 5 Apr 2023 18:13:36 +0000 (11:13 -0700)]
[flang] Nonconformant assigned gotos
Modify code generation for assigned gotos to generate a runtime error
for most cases that violate F90 Clause 8.2.4, rather than treating a
nonconformant GOTO as a nop. For example, generate a runtime error for
a GOTO that attempts to branch to a label for a FORMAT statement.
Relax the requirement that an assigned GOTO with a label list must
branch to a label in the list, and instead allow a branch to any valid
assigned GOTO target in scope.
Jon Phillips [Wed, 5 Apr 2023 21:28:56 +0000 (14:28 -0700)]
[clang-format] Fix bugs with "LambdaBodyIndentation: OuterScope"
The previous implementation of the option corrupted the parenthesis
state stack. (See https://reviews.llvm.org/D102706.)
Fixes #55708.
Fixes #53212.
Fixes #52846.
Fixes #59954.
Differential Revision: https://reviews.llvm.org/D146042
Chia-hung Duan [Wed, 5 Apr 2023 21:19:11 +0000 (21:19 +0000)]
[scudo] Switch to use MemMap in tests
Reviewed By: cferris
Differential Revision: https://reviews.llvm.org/D146570
Chia-hung Duan [Tue, 4 Apr 2023 21:32:22 +0000 (21:32 +0000)]
[scudo] Manage pages with MemMap in Secondary Allocator
Replace the uses of raw map()/unmap(), .etc calls with MemMap. Also
remove the direct use of MapPlatformData in the secondary allocator.
Also add setMemoryPermission() in MemMap.
Reviewed By: cryptoad
Differential Revision: https://reviews.llvm.org/D146454
Chia-hung Duan [Tue, 4 Apr 2023 20:13:13 +0000 (20:13 +0000)]
[scudo] Manage pages with MemMap in SizeClassAllocator64
Introduce a new data structure to manage the allocated pages from the
system. This is meant to deprecate certain memory system call wrappers
in Scudo, e.g., map()/unmap(). Besides, we would like to make
MapPlatformData to be appeared in platform specific data structure only.
Given that there are several allocators in Scudo and each of them has
different way of page management. The deprecation will be done in
several CLs. In this commit, we start from SizeClassAllocator64.
Reviewed By: cferris
Differential Revision: https://reviews.llvm.org/D146009
Jon Chesterfield [Wed, 5 Apr 2023 21:24:21 +0000 (22:24 +0100)]
[amdgpu][nfc] Remove dead code associated with LDS lowering
Pass disabled since approximately D104962 for miscompiling openmp
The functions under ReplaceConstant miscompile phis as noted in D112717 and
have no users in tree other than the disabled pass. It seems likely it has no
users out of tree.
Deletes the test cases associated with the disabled pass as well.
Reviewed By: rampitec
Differential Revision: https://reviews.llvm.org/D147586
Justin Lebar [Wed, 5 Apr 2023 06:36:06 +0000 (23:36 -0700)]
Mark threadIdx.x and friends as noundef.
threadIdx.x and similar functions never return undef.
Simple enough to say, but why does it matter?
Consider the following IR that reads threadIdx.x and blockIdx.x.
%a = call i32 @llvm.nvvm.read.ptx.sreg.ctaid.x(), !range !138
%b = call i32 @llvm.nvvm.read.ptx.sreg.tid.x(), !range !139
%c = shl nuw nsw i32 %a, 6
%linear_index = or i32 %c, %b
%linear_index.fr = freeze i32 %linear_index
If %a or %b may be undef, then computeKnownBits will not recurse through
the freeze instruction. Therefore we will not know anything about the
known bits of linear_index.fr, even though we have range metadata! Bad
Things fall out of this.
Differential Revision: https://reviews.llvm.org/D147589
Valentin Clement [Wed, 5 Apr 2023 20:34:23 +0000 (13:34 -0700)]
[flang] Keep the extended value for assumed-type optional
Keep the extended value when lowering optional assumed type
dummy argument. The extended value is needed to lower correctly the
rest of the code.
Reviewed By: PeteSteinfeld, jeanPerier
Differential Revision: https://reviews.llvm.org/D147575
Joseph Huber [Wed, 5 Apr 2023 20:30:48 +0000 (15:30 -0500)]
[libc] Only add extra runtime dependencies if the target exists
Summary:
If the target for these tools doesn't exist we should simply assume that
they will be provided externally. This allows building `libc` standalone
with an external installation of `clang`.
Matthew Voss [Wed, 5 Apr 2023 20:25:04 +0000 (13:25 -0700)]
Update clang :: Driver/debug-options.c to fix the buildbots
The format of the LTO debug options generated for orbis-ld changed,
breaking this test.
https://lab.llvm.org/buildbot/#/builders/230/builds/11367
Alexey Lapshin [Wed, 5 Apr 2023 18:45:00 +0000 (20:45 +0200)]
[ADT][ConcurrentHashTable] Change thread_local to LLVM_THREAD_LOCAL inside unit test.
Not all platform support C++11 thread_local. Use portable
LLVM_THREAD_LOCAL macro instead.
Differential Revision: https://reviews.llvm.org/D147649
Joseph Huber [Wed, 5 Apr 2023 19:24:34 +0000 (14:24 -0500)]
[OpenMP] Add tool dependencies in runtimes mode
The OpenMP offloading device runtime depends on multiple tools. We
should ensure that these tools are build before invoking the OpenMP
build.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D147654
Joseph Huber [Wed, 5 Apr 2023 19:16:53 +0000 (14:16 -0500)]
[libc] Search for the CUDA patch explicitly when testing
The packaged version of the `libc` library does not depend on the CUDA
installation because it only uses `clang` and emits LLVM-IR. However,
for testing we directly need the CUDA toolkit to emit and execute the
files. This patch explicitly passes `--cuda-path` to the relevant
compilations for NVPTX testing.
Reviewed By: tra
Differential Revision: https://reviews.llvm.org/D147653
Petr Hosek [Wed, 30 Jun 2021 06:34:18 +0000 (23:34 -0700)]
[CMake] Support runtimes targets without specifying triple
Currently, for BUILTIN_TARGETS and RUNTIME_TARGETS you can either use
the special "default" value, or a target triple.
For the "default" value, we don't set any target triple and passthrough
a subset of CMake variables into the subbuild. This is typically used
on Darwin where we build universal binaries and a single target triple
therefore isn't sufficient.
For the target triple value, you can set arbitrary CMake variables
through RUNTIMES_<target>_<variable>, but we always set target triple
to <target>. This gives more flexibility, because we can precisely
control what variables are set in the subbuild, but is unsuitable for
platforms like Darwin.
To address this, we would like to introduce a third option which is
similar to the second option, except we won't set target triple in
the subbuild (you can always do so yourself by setting the appropriate
CMake variable, e.g. RUNTIMES_<name>_CMAKE_C_COMPILER_TARGET=<triple>).
This change is a first step in that direction, by eliminating the support
of target triples from builtin_register_target and runtime_register_target
helper functions.
Differential Revision: https://reviews.llvm.org/D117263
Manna, Soumi [Wed, 5 Apr 2023 19:41:54 +0000 (15:41 -0400)]
[NFC][clang] Fix Coverity static analyzer tool concerns about auto_causes_copy
Reported by Coverity:
AUTO_CAUSES_COPY
Unnecessary object copies can affect performance
Inside FrontendActions.cpp file,
In clang::DumpModuleInfoAction::ExecuteAction(): Using the auto keyword without an & causes the copy of an object of type pair.
Inside ComputeDependence.cpp file,
In clang::computeDependence(clang::OverloadExpr *, bool, bool, bool): Using the auto keyword without an & causes the copy of an object of type TemplateArgumentLoc.
Reviewed By: erichkeane, aaron.ballman
Differential Revision: https://reviews.llvm.org/D147574
Matthew Voss [Wed, 5 Apr 2023 19:57:21 +0000 (12:57 -0700)]
[PS4][clang] Fix the format of the LTO debug options passed to orbis-ld
Currently, we pass multiple LTO debug options to orbis-ld like this:
orbis-ld --lto=thin --lto-thin-debug-options=<arg1> --lto-thin-debug-options=<arg2> ...
When it should be like this:
orbis-ld --lto=thin "--lto-thin-debug-options= <arg1> <arg2>" ...
Differential Revision: https://reviews.llvm.org/D147546
Jan Svoboda [Wed, 5 Apr 2023 19:27:07 +0000 (12:27 -0700)]
[clang][deps] NFC: Make PCH test more debuggable
Overwriting CDB files made it difficult to debug earlier clang-scan-deps invocations. This commit creates separate files for each.
Jan Svoboda [Wed, 5 Apr 2023 19:25:10 +0000 (12:25 -0700)]
[clang][deps] NFC: Don't collect PCH input files
Since
b4c83a13, PCH input files are no longer necessary.
Thurston Dang [Mon, 3 Apr 2023 23:44:29 +0000 (23:44 +0000)]
Remove unintended __sanitizer_get_allocation_bounds declaration
This removes an unintentional function declaration, that was accidentally
added in D147005 (from an incomplete refactoring of __sanitizer_get_allocation_bounds).
Differential Revision: https://reviews.llvm.org/D147486
Francesco Petrogalli [Wed, 5 Apr 2023 18:53:20 +0000 (20:53 +0200)]
Revert "[clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR."
This reverts commit
029212617ca8bdedd949d17bf2d33750605ea607.
Reverting because of failures when setting
`CLANG_CRASH_DIAGNOSTICS_DIR` before invoking `ninja check-clang`.
Guillaume Chatelet [Wed, 5 Apr 2023 18:47:39 +0000 (18:47 +0000)]
[libc][NFC] Rework generic memory operations
Zequan Wu [Wed, 5 Apr 2023 18:43:52 +0000 (14:43 -0400)]
Add release note for D147569.
Zequan Wu [Tue, 4 Apr 2023 20:40:11 +0000 (16:40 -0400)]
[Coverage] Fix crash when visiting PseudoObjectExpr.
This is a split of D147073.
Fixes #45481
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D147569
Aart Bik [Mon, 3 Apr 2023 22:46:23 +0000 (15:46 -0700)]
[mlir][sparse][gpu] a first prototype sparse GPU code generator
This implements a proof-of-concept GPU code generator
to the sparse compiler pipeline, currently only capable
of generating CUDA threads for outermost parallel loops.
The objective, obviously, is to grow this concept
to a full blown GPU code generator, capable of the
right combinaton of code generation as well as exploiting
idiomatic kernels or vector specific libraries (think cuSparse).
Reviewed By: ThomasRaoux
Differential Revision: https://reviews.llvm.org/D147483
Daniel Thornburgh [Mon, 3 Apr 2023 18:15:31 +0000 (11:15 -0700)]
[Object] Refactor build ID parsing into Object lib.
This makes parsing for build IDs in the markup filter slightly more
permissive, in line with fromHex.
It also removes the distinction between missing build ID and empty build
ID; empty build IDs aren't a useful concept, since their purpose is to
uniquely identify a binary. This removes a layer of indirection wherever
build IDs are obtained.
Reviewed By: jhenderson
Differential Revision: https://reviews.llvm.org/D147485
Pavel Labath [Wed, 5 Apr 2023 18:10:31 +0000 (20:10 +0200)]
[lldb] Remove unused functions from RegisterContextLinux_x86
These should be overridden by individual subclasses, they ended up here
because of copy-pasta.
Keith Smiley [Tue, 4 Apr 2023 04:43:36 +0000 (21:43 -0700)]
[dsymutil] Remove empty reproducer directory on exit
In the case the reproducer isn't generated, we don't want to leave
around an empty temporary directory.
Fixes https://github.com/llvm/llvm-project/issues/61920
Differential Revision: https://reviews.llvm.org/D147498
Andrew Gozillon [Wed, 5 Apr 2023 17:34:57 +0000 (12:34 -0500)]
[OpenMP][MLIR][Flang][bbc][Driver] Add OpenMP RTL Flags to Flang and generate omp.FlagsAttr from them
This patch ports OpenMP RTL flags from the shared Clang compiler
options to Flang. As well as adding a limited subset to bbc.
This patch enables the flags below (and any equals or inverse variants)
for Flang that exist in Clang:
-fopenmp-target-debug
-fopenmp-assume-threads-oversubscription
-fopenmp-assume-teams-oversubscription
-fopenmp-assume-no-nested-parallelism
-fopenmp-assume-no-thread-state
For the bbc tool it only utilises the primary variants to minimize
additional complexity in the tool.
The patch also provides FlagAttr generation from these flags. Which
will be lowered to LLVM-IR in a subsequent patch.
Reviewers: kiranchandramohan, awarzynski
Differential Revision: https://reviews.llvm.org/D147324
Mike Rice [Wed, 5 Apr 2023 15:10:57 +0000 (08:10 -0700)]
[MSVC] Allow declaration of multi-dim 'property' array fields
MSVC allows declaration of multi-dim arrays like this:
__declspec(property(get=GetX, put=PutX)) int x[][][];
This syntax can appear in generated typelib headers.
Currently clang errors on declarators like this since it forms an array
type of incomplete array. Rather than try to handle such a type, ignore
adjacent empty chunks so this is treated as if there was only one empty
array chunk (i.e. int x[]).
The functionality to handle multi-dim subscripts of property fields
already works, but only if declared as a single-dim array.
Aaron Ballman [Wed, 5 Apr 2023 17:25:07 +0000 (13:25 -0400)]
Fix LLVM sphinx build
This addresses issues found by:
https://lab.llvm.org/buildbot/#/builders/30/builds/33698
Aaron Ballman [Wed, 5 Apr 2023 17:13:42 +0000 (13:13 -0400)]
Add some additional comments to this test; NFC
It isn't immediately obvious why that code should be accepted given the
wording of C2x 6.7.10p4, so this adds a comment explaining that there
is an existing extension to support zero-sized arrays in C, and that
empty initialization of an unbounded array in C++ deduces the array
extent as zero, so C is exposing the same extension as in C++.
Shao-Ce SUN [Tue, 28 Mar 2023 16:38:18 +0000 (00:38 +0800)]
[flang][runtime] Support L editing of Logical
I tested gfortran and flang(old). https://godbolt.org/z/c89foro4G
Reviewed By: klausler
Differential Revision: https://reviews.llvm.org/D146989
Roy Sundahl [Tue, 4 Apr 2023 13:09:58 +0000 (06:09 -0700)]
[sanitizers] Simplify Explainer about dyld and weak overrides on Darwin. (NFC)
Presenting more than one way to satisfy the single-weak-ref requirement leads to
confusing messaging for the end user. Use the introduction of a single unused
weak variable as the preferred solution. This differential modifies D146745.
rdar://
103453678
Reviewed By: yln, thetruestblue
Differential Revision: https://reviews.llvm.org/D147526
Michael Jones [Mon, 3 Apr 2023 21:00:43 +0000 (14:00 -0700)]
[libc] fix strtofloat on large exponents
Previously if you specified an exponent of more than 10000 in string to
float (e.g. "1e10001") it would treat it as 10000. A bug was discovered
where by having more than 10000 zeroes after a decimal point and an
exponent of more than 10000 this would cause the code to return the
incorrect value.
Reviewed By: lntue
Differential Revision: https://reviews.llvm.org/D147474
Philip Reames [Wed, 5 Apr 2023 16:33:10 +0000 (09:33 -0700)]
[RISCV][TTI] Cost model for SK_ExtractSubvector
Differential Revision: https://reviews.llvm.org/D147618
David Green [Wed, 5 Apr 2023 16:50:01 +0000 (17:50 +0100)]
[LV] Cleanup and reformatting for some debug messages. NFC
This is just some cleanup of various debug messages, pulled out of another
patch to simplify it a little.
Alexey Bataev [Mon, 20 Mar 2023 14:26:33 +0000 (07:26 -0700)]
[SLP]Find reused scalars in buildvector sequences, if any.
Patch generalizes analysis of scalars. The main part is outlined into
lambda, which can be used to find reused inserted scalars and emit
shuffle for them instead of multiple insertelement instructions, if the
permutation is found alreadyi. I.e. some scalars are transformed by the
permutation of previously vectorized nodes, and some are inserted
directly.
Reworked part of D110978
Differential Revision: https://reviews.llvm.org/D146564
Philip Reames [Wed, 5 Apr 2023 16:26:17 +0000 (09:26 -0700)]
[IVDescriptors] Add pointer InductionDescriptors with non-constant strides (try 2)
(JFYI - This has been heavily reframed since original attempt at landing.)
This change updates the InductionDescriptor logic to allow matching a pointer IV with a non-constant stride, but also updates the LoopVectorizer to bailout on such descriptors by default. This preserves the default vectorizer behavior.
In review, it was pointed out that there's multiple unfortunate performance implications which need to be addressed before this can be enabled. Having a flag allows us to exercise the behavior, and write test cases for logic which is otherwise unreachable (or hard to reach).
This will also enable non-constant stride pointer recurrences for other consumers. I've audited said code, and don't see any obvious issues.
Differential Revision: https://reviews.llvm.org/D147336
Martin Storsjö [Sat, 1 Apr 2023 22:02:37 +0000 (01:02 +0300)]
[libunwind] Fix a case of inconsistent indentation. NFC.
Stefan Gränitz [Tue, 4 Apr 2023 17:06:10 +0000 (19:06 +0200)]
[JITLink][AArch32] Implement ELF::R_ARM_ABS32 after we stopped skipping debug info sections
We create LinkGraph sections with NoAlloc lifetime now since
f05ac803ffe76c7f4299a4e1288cc6bb8b098410
This means we do process debug info sections now with all their relocations. That's ok for the moment.
Adrian Prantl [Wed, 5 Apr 2023 16:00:46 +0000 (09:00 -0700)]
Skip tests under asan
Shengchen Kan [Wed, 5 Apr 2023 15:39:32 +0000 (23:39 +0800)]
[X86][mem-fold] Simplify code by using StringRef::drop_back, NFCI
OCHyams [Wed, 5 Apr 2023 15:23:02 +0000 (16:23 +0100)]
[DebugInfo] Update test to use opaque ptrs
The test was added in D99169.
Shengchen Kan [Wed, 5 Apr 2023 15:22:18 +0000 (23:22 +0800)]
[X86][mem-fold] Remove the logic for FoldGenData, NFCI
Nikita Popov [Wed, 5 Apr 2023 15:03:20 +0000 (17:03 +0200)]
Revert "[SimplifyCFG][LICM] Preserve nonnull, range and align metadata when speculating"
This reverts commit
78b1fbc63f78660ef10e3ccf0e527c667a563bc8.
This causes or exposes miscompiles in Rust, revert until they
have been investigated.
Paul Scoropan [Wed, 5 Apr 2023 14:31:16 +0000 (14:31 +0000)]
[Flang] Fix usage of uninitialized resolution variable
Recent Flang PowerPC intrinsics patch used resolution variable without checking if it exists first, causing segmentation faults in some scenarios. This patch checks that the resolution variable exists first before usage.
Reviewed By: DanielCChen
Differential Revision: https://reviews.llvm.org/D147616
Nikita Popov [Wed, 5 Apr 2023 14:59:04 +0000 (16:59 +0200)]
[Coroutines] Convert test to opaque pointers (NFC)
Philip Reames [Wed, 5 Apr 2023 14:47:24 +0000 (07:47 -0700)]
[RISCV] Account for LMUL in memory op costs
Generally, the cost of a memory op will scale with the number of vector registers accessed. Machines might exist which have a narrow memory access than vector register width, but machines with a wider memory access width than vector register width seem unlikely.
I noticed this because we were preferring wide loads + deinterleaves on examples where the cost of a short gather (actually a strided load) would be better. Touching 8 vector registers instead of doing a 4 element gather is not a good tradeoff.
Differential Revision: https://reviews.llvm.org/D147470
Dávid Bolvanský [Wed, 5 Apr 2023 10:52:30 +0000 (12:52 +0200)]
[AggressiveInstCombine] Enable also for -O2
Next step after https://reviews.llvm.org/D113179
Recently a set of patches by @anton-afanasyev improved many cases (better and cleaner vectorized code) thanks to improvements to AIC's TruncInstCombine (IC cannot handle it) motivated by real examples in bug reports. There was a discussion that -O2 could benefit from AIC as well, but discussion then stalled, so I would like restart it, with new numbers from LLVM compile time tracker.
As -O2 pipeline is not tracked by LLVM compile time tracker, I disabled AIC for -O3 to get an idea how expensive is it. Without AIC, I observed that geomean was cca -0.10%. Given that it seems like AIC is quite cheap, heavily tested by -O3 pipeline, I am proposing to enable it also with -O2 and similar to improve quality to vectorized code.
https://llvm-compile-time-tracker.com/compare.php?from=
a1df5abef5f27646c809c7b85cf6170eb68f7735&to=
e1ba6068f58c6ca862b920b8750faccb42a5843c&stat=instructions:u
Differential Revision: https://reviews.llvm.org/D147604
Reviewed-By: nikic
Florian Hahn [Wed, 5 Apr 2023 14:49:06 +0000 (15:49 +0100)]
[Matrix] Limit dot lowering to column major matrixes.
Limit to dot product lowering to column major matrixes for now. This
simplifies the code and reasoning for upcoming planned improvements.
Support for row-major matrixes can be added later as extension.
David Sherwood [Mon, 3 Apr 2023 10:19:19 +0000 (10:19 +0000)]
[AArch64][SME] Disable ZA LDR/STR addressing optimisations
Since the same encoded offset is used for both the vector
select offset and the address offset we have to spot two
patterns simulatenously in the ldr/str intrinsic inputs, i.e.
vector select = base + off
address = base + (off * VL)
whereas currently we only look for the address pattern. I
don't think this is possible in tablegen, so I suspect we'll
have to do this manually as part of lowering or as a target
DAG combine. For now, I've removed these tablegen patterns
so that we at least do the correct thing even if the code
quality isn't great.
I've also changed some of the ldr/str tests to pass in the
same vector select pattern (base + off) as the address
pattern.
Differential Revision: https://reviews.llvm.org/D147433
Nikita Popov [Wed, 5 Apr 2023 14:22:56 +0000 (16:22 +0200)]
[InstCombine] Remove varargs cast transform (NFC)
This is no longer relevant with opaque pointers.
Also drop the CastInst::isLosslessCast() method, which was only
used here.
Jie Fu [Wed, 5 Apr 2023 14:34:42 +0000 (22:34 +0800)]
[Transforms] Fix -Wunused-function for 'GetReplicateRegion' with -DLLVM_ENABLE_ASSERTIONS=OFF (NFC)
/Users/jiefu/llvm-project/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:614:23: error: unused function 'GetReplicateRegion' [-Werror,-Wunused-function]
static VPRegionBlock *GetReplicateRegion(VPRecipeBase *R) {
^
1 error generated.
Krzysztof Parzyszek [Wed, 5 Apr 2023 13:54:31 +0000 (06:54 -0700)]
[Hexagon] Remove -opaque-pointers=0 from tests
Two tests still had opaque-pointers=0:
(1) llvm/test/CodeGen/Hexagon/addrmode.ll
(2) llvm/test/CodeGen/Hexagon/swp-epilog-phi7.ll
Deleted (1) since it no longer exercised the original scenario, modified
(2) to reflect codegen changes.
This fixes https://github.com/llvm/llvm-project/issues/61928
Nikita Popov [Wed, 5 Apr 2023 14:06:34 +0000 (16:06 +0200)]
[CodeGenCXX] Convert some tests to opaque pointers (NFC)
In particular also fixes fallout from instcombine changes.
Nikita Popov [Wed, 5 Apr 2023 13:59:29 +0000 (15:59 +0200)]
[InstCombine] Remove convertBitCastToGEP() fold (NFC)
This only applies to typed pointers, so the fold is no longer
necessary.
Richard Howell [Tue, 4 Apr 2023 19:35:45 +0000 (12:35 -0700)]
[clang] don't serialize MODULE_DIRECTORY with ModuleFileHomeIsCwd
Fix a bug in the MODULE_DIRECTORY serialization logic
that would cause MODULE_DIRECTORY to be serialized when
`-fmodule-file-home-is-cwd` is specified.
This matches the original logic added in:
https://github.com/apple/llvm-project/commit/
f7b41371d9ede1aecf0930e5bd4a463519264633
Reviewed By: keith
Differential Revision: https://reviews.llvm.org/D147561
Florian Hahn [Wed, 5 Apr 2023 14:19:11 +0000 (15:19 +0100)]
[Matrix] Add dotproduct tests with row-major default layout.
Jie Fu [Wed, 5 Apr 2023 14:17:36 +0000 (22:17 +0800)]
[InstCombine] Remove unneeded internal function 'decomposeSimpleLinearExpr' in InstCombineCasts.cpp (NFC)
/data/llvm-project/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:32:15: error: function 'decomposeSimpleLinearExpr' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
static Value *decomposeSimpleLinearExpr(Value *Val, unsigned &Scale,
^
1 error generated.
Shengchen Kan [Wed, 5 Apr 2023 14:16:17 +0000 (22:16 +0800)]
[X86][mem-fold] Remove the logic for TB_NO_FORWARD | TB_NO_REVERSE, NFCI
Eric Gullufsen [Tue, 4 Apr 2023 19:33:37 +0000 (15:33 -0400)]
[InstCombine] Preserve nsw/nuw flags in canonicalization
canonicalizeLogicFirst reorders logic op / math op for suitable
constants, and this commit makes this function pass through
nsw/nuw flags on the Add.
Differential Revision: https://reviews.llvm.org/D147568
Eric Gullufsen [Tue, 4 Apr 2023 18:30:14 +0000 (14:30 -0400)]
[InstCombine] Add baseline tests for nsw/nuw (NFC)
nsw/nuw flags are currently not preserved when canonicalizing,
adding baseline tests here and subsequent patch will fix.
Differential Revision: https://reviews.llvm.org/D147566
Florian Hahn [Wed, 5 Apr 2023 14:04:05 +0000 (15:04 +0100)]
[Matrix] Add test variants where 2nd operand of dotprod is add/sub.
Fangrui Song [Wed, 5 Apr 2023 13:59:09 +0000 (06:59 -0700)]
[RuntimeDyld][ELF] Actually fix R_AARCH64_ABS{16,32} overflow check
7b58259481417bb22d144a9c12ee8f4fb0a046e0 is incorrect.
Nikita Popov [Wed, 5 Apr 2023 13:41:53 +0000 (15:41 +0200)]
[InstCombine] Remove PromoteCastOfAllocation() fold (NFC)
This fold does not apply to opaque pointers, and as such is no
longer needed.
Nikita Popov [Wed, 5 Apr 2023 13:53:15 +0000 (15:53 +0200)]
[Coroutines] Convert some tests to opaque pointers (NFC)
Alex Bradbury [Wed, 5 Apr 2023 13:52:08 +0000 (14:52 +0100)]
[docs][RISCV] Remove outdated note about zfa implementation status
MC layer and codegen support for fli.{h,s,d} has since been implemented.
Fangrui Song [Wed, 5 Apr 2023 13:52:54 +0000 (06:52 -0700)]
[RuntimeDyld][ELF] Fix off-by-1 issues in R_AARCH64_ABS{16,32} overflow checks
Florian Hahn [Wed, 5 Apr 2023 13:49:12 +0000 (14:49 +0100)]
[AArch64] Add cost-model tests for fshr.
Alex Bradbury [Wed, 5 Apr 2023 13:46:44 +0000 (14:46 +0100)]
[RISCV][NFC] Use RISCVSubtarget method for predicate in RISCVFeatures.td when available
As RISCVSubtarget defines hasStdExtZfhOrZfhmin() and hasStdExtCOrZca(),
just use these for the matching Predicate definitions rather than
repeating the logic.
Benjamin Kramer [Wed, 5 Apr 2023 13:35:02 +0000 (15:35 +0200)]
[mlir] Fix a use after free when loading dependent dialects
The way dependent dialects are implemented is by recursively calling
loadDialect in the constructor. This means we have to reload from the
dialect table because the constructor might have rehashed that table.
The steps for loading a dialect are
1. Insert a nullptr into loadedDialects. This indicates the dialect is
loading
2. Call ctor(). This recursively loads dependent dialects
3. Insert the new dialect into the table.
We had a conflict between steps 2 and 3 here. You have to be extremely
unlucky though as rehashing is rare and operator[] does no generation
checking on DenseMap. Changing that to an iterator would've uncovered
this issue immediately.
Alex Zinenko [Wed, 5 Apr 2023 13:42:02 +0000 (15:42 +0200)]
Alexey Lapshin [Wed, 5 Apr 2023 13:40:02 +0000 (15:40 +0200)]
Revert "[dsymutil][NFC] Move ARM specific test into the ARM directory."
This reverts commit
adeb1fa7a34d097825f71dfdfe5c62a242353bb9.
Florian Hahn [Wed, 5 Apr 2023 13:29:24 +0000 (14:29 +0100)]
[VPlan] Replace check for replicate regions with assert (NFCI).
After recent changes, replication regions only get introduced later, so
there's no need to check for them.
Shengchen Kan [Wed, 5 Apr 2023 13:23:12 +0000 (21:23 +0800)]
[X86][mem-fold] Remove definition of NotMemoryFoldable and move code into a def file, NFCI
The goal is to centralize the logic of the memory fold.
Nikita Popov [Wed, 5 Apr 2023 13:17:15 +0000 (15:17 +0200)]
[InstCombine] Convert tests to opaque pointers (NFC)
The two debuginfo tests go away because the relevant transforms
no longer occur in this form, e.g. the "cast of alloca" transform
just doesn't exist with opaque pointers.
Nikita Popov [Wed, 5 Apr 2023 13:14:03 +0000 (15:14 +0200)]
[InstCombine] Regenerate test checks (NFC)
Nikita Popov [Wed, 5 Apr 2023 13:07:26 +0000 (15:07 +0200)]
[InstCombine] Name instructions in test (NFC)
Nikita Popov [Wed, 5 Apr 2023 13:05:16 +0000 (15:05 +0200)]
[InstCombine] Regenerate test checks (NFC)
Nikita Popov [Wed, 5 Apr 2023 13:02:02 +0000 (15:02 +0200)]
[InstCombine] Use CreateGEP() API (NFC)
Use the IRBuilder API that accepts inbounds as a boolean parameter,
rather than using a ternary.
Christian Ulmann [Wed, 5 Apr 2023 12:55:22 +0000 (12:55 +0000)]
[mlir][Analysis] Introduce LoopInfo in mlir
This commit introduces an instantiation of LLVM's LoopInfo for CFGs in
MLIR. To test the LoopInfo, a test pass is added the checks the analysis
results for a set of CFGs.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D147323
Simon Pilgrim [Wed, 5 Apr 2023 12:42:02 +0000 (13:42 +0100)]
[X86] combinePredicateReduction - reuse LowerVectorAllEqual for all_of/any_of(vXi1 eq/ne) reductions
Nikita Popov [Wed, 5 Apr 2023 12:33:11 +0000 (14:33 +0200)]
[ArgPromotion] Require noundef to copy poison-generating metadata
For poison-generating (rather than IUB) metadata, only copy it
from the dominating must-exec load if it is combined with !noundef.
This could be further extended by additionall intersecting the
metadata from all loads, which does not require !noundef.
Simon Pilgrim [Wed, 5 Apr 2023 11:28:26 +0000 (12:28 +0100)]
[X86] LowerVectorAllEqual - split ALLOF(CMPEQ(X,Y)) -> AND(CMPEQ(X[0],Y[0]),CMPEQ(X[1],Y[1]),....) on MOVMSK codegen
Fix minor regression on pre-PTEST targets, since these are always 128-bits we're better off reducing the comparison results (assuming we're not comparing against 0/-1).