Shilpa Singh [Tue, 4 Feb 2014 16:29:14 +0000 (01:29 +0900)]
spinner: After long press of inc/dec buttons, start continuously increasing/decreasing
Summary:
When inc/dec buttons are pressed, start changing value after longpress has happened on buttons and not immediately.
Signed-off by: Mohammad Irfan (mohammad.i@samsung.com)
Signed-off by: Shilpa Singh(shilpa.singh@samsung.com)
Test Plan: Long press on inc/dec buttons of spinner.
Reviewers: seoz, woohyun
CC: Hermet, jchanwook, raster
Differential Revision: https://phab.enlightenment.org/D365
Ryuan Choi [Tue, 4 Feb 2014 16:26:37 +0000 (01:26 +0900)]
datetime_input_ctxpopup: delay creation of ctxpopup until it is really needed.
Daniel Juyung Seo [Tue, 4 Feb 2014 16:23:22 +0000 (01:23 +0900)]
test_button: Removed evas_object_show() calls for icon from test code.
Summary: Icon is an internal object of button. There is no need to call evas_object_show() for icon widget.
Reviewers: seoz
Differential Revision: https://phab.enlightenment.org/D517
Ryuan Choi [Tue, 4 Feb 2014 15:53:14 +0000 (00:53 +0900)]
datetime: Correct the validation of parameter in _field_format_get/_field_limit_get
Because field_list is an array, we should check boundary instead of NULL.
Amitesh Singh [Tue, 4 Feb 2014 13:27:58 +0000 (22:27 +0900)]
win: removed printf in _elm_win_focus_highlight_geometry_get()
Reviewers: seoz
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D516
nirajkr [Tue, 4 Feb 2014 11:29:29 +0000 (20:29 +0900)]
focus: Added test cases for the existing issues/feature enhancement relate to focus
Summary:
Below are the test cases to reproduce the exisiting issues with focus or feature enhancement
1. Focus cut for the first/last item by scroller.
2. Focus animation on the last item.
3. Focus goes out of view point while scrolling.
4. Focus moves but the area of focus does not change.
5. No focus highlight on widget items.
6. No animation on widget item.
7. No focus movement between widget to widget items.
Reviewers: seoz, woohyun
CC: singh.amitesh
Differential Revision: https://phab.enlightenment.org/D502
Jaehwan Kim [Tue, 4 Feb 2014 07:00:42 +0000 (16:00 +0900)]
config: Change the value of THUMBSCROLL_SENSITIVITY_FRICTION in mobile config for an optimization.
Daniel Juyung Seo [Tue, 4 Feb 2014 03:24:30 +0000 (12:24 +0900)]
po: Updated po files.
Daniel Juyung Seo [Tue, 4 Feb 2014 03:23:37 +0000 (12:23 +0900)]
theme: Fixed distcheck by adding necessary image lists needed by efm
theme.
This was b0rken by latest efm theme changes.
Daniel Juyung Seo [Tue, 4 Feb 2014 03:15:48 +0000 (12:15 +0900)]
po: Update POTFILES.in according to the latest elementary test changes.
Special thanks to Simotek-Work for the report.
ChunEon Park [Tue, 4 Feb 2014 01:21:04 +0000 (10:21 +0900)]
mapbuf - don't leave the dangling static map pointer that won't be freed.
Some memory profiler tools regard this as the memory leak.
it makes engineers waste time to check this. especially app developers.
Ryuan Choi [Mon, 3 Feb 2014 16:41:45 +0000 (01:41 +0900)]
datetime: fix doxygen
Daniel Juyung Seo [Mon, 3 Feb 2014 16:34:34 +0000 (01:34 +0900)]
elm: Fixed comments and documentations on test_focus and genlist header.
Ryuan Choi [Mon, 3 Feb 2014 16:23:10 +0000 (01:23 +0900)]
fileselector: Fixed typo of warning message in ELM_FILESELECTOR_INTERFACE_CHECK
It's c&p mistake.
Daniel Juyung Seo [Mon, 3 Feb 2014 15:30:37 +0000 (00:30 +0900)]
Colorselector: Item_signal_emit_hook added.
Summary:
Issue: If application has to preselect an item, or change item properties by customizing theme
there is no option provided for the same.
Solution: Add item_signal_emit_hook.
Signed-off by: Shilpa Singh <shilpa.singh@samsung.com>
Test Plan:
Send a signal to item and verify UI
Elm_Object_Item *item = elm_colorselector_palette_color_add(cs, 133, 100, 255, 255);
elm_object_item_signal_emit(item, "elm,state,selected", "elm");
Reviewers: seoz, Hermet
Reviewed By: seoz
CC: govi
Differential Revision: https://phab.enlightenment.org/D504
Daniel Juyung Seo [Mon, 3 Feb 2014 10:08:33 +0000 (19:08 +0900)]
test_focus2: Remove unnecessary test file as test_focus2 is moved into
test_focus.c
It was moved to test_focus.c in
1977c8fca3d3687a5dc5d17918d72bb1af21b31e
Amitesh Singh [Mon, 3 Feb 2014 08:44:16 +0000 (17:44 +0900)]
focus: Added "focus_part" support on elm widget.
Summary:
Currently, focus highlight comes on the widget's geometry. Elementary does not have option to provide the focus highlight on widget's part.
This patch provides the option to provide focus highlight on the widget's part.
e.g. data.item: "focus_part" "part";
The focus highlight would come on part's geometry instead of widget's geometry. This patch only works on widgets which uses
resize_obj.
Reviewers: seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D499
Daniel Juyung Seo [Mon, 3 Feb 2014 05:58:08 +0000 (14:58 +0900)]
hoversel: Removed unnecessary null check for elm_object apis.
Daniel Juyung Seo [Mon, 3 Feb 2014 00:28:16 +0000 (09:28 +0900)]
test_flip_page: Revert wrong initialize routine.
Ryuan Choi [Mon, 3 Feb 2014 00:03:26 +0000 (09:03 +0900)]
datetime: Refactor to launch test_datetime little bit faster
- Added enabled_filed_count to avoid loop in _elm_datetime_smart_sizing_eval().
sizing_eval is called many times but field_count is only changed when called
_reload_format().
- Moved redundant if statement out of the loop in _field_list_display().
- Removed redundant call from _elm_datetime_smart_add().
_field_list_arrange() is called in _reload_format().
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 23:05:33 +0000 (08:05 +0900)]
theme - efm icons - update/improve generic icons.
as per T575 - this is an improvement of the base icons, or a start on
it, with more to come.
Daniel Juyung Seo [Sun, 2 Feb 2014 16:24:11 +0000 (01:24 +0900)]
test_focus: Internal refactoring of focus tests.
- Moved focus2, focus3 from test_focus2.c to test_focus.c
- Renamed "Focus 3" to "Focus Hide/Del".
- Renamed "Focus Custom" to "Focus Style"
- Renamed test_focus3.c to test_focus_custom_chain.c
Daniel Juyung Seo [Sun, 2 Feb 2014 14:14:23 +0000 (23:14 +0900)]
test: Initialize structure on declarations with { 0 }.
No need to call memset manually.
Daniel Juyung Seo [Sun, 2 Feb 2014 08:25:25 +0000 (17:25 +0900)]
test: Removed size hint macros from reference codes.
Using additional macros in reference codes was not a good idea.
This will make codes more inconsistent and confusing.
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 09:46:50 +0000 (18:46 +0900)]
theme - packagekit - adjust text to be in right spot and subtle inset
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 09:39:52 +0000 (18:39 +0900)]
theme - e - remove wrong group from packagekit group
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 07:15:32 +0000 (16:15 +0900)]
theme - packagekit - make theme match default for module
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 01:20:16 +0000 (10:20 +0900)]
add tests to window moves.
Carsten Haitzler (Rasterman) [Sun, 2 Feb 2014 01:02:07 +0000 (10:02 +0900)]
theme - pager16 - remove shadow as now shadow is back in comp
Carsten Haitzler (Rasterman) [Wed, 29 Jan 2014 22:46:01 +0000 (07:46 +0900)]
make iconify effects moe natural (faster to deiconify to make it feel snappy)
Mike Blumenkrantz [Wed, 29 Jan 2014 18:30:05 +0000 (13:30 -0500)]
remove e comp iconify theme hacks, add basic iconify effect
maxerba [Wed, 29 Jan 2014 18:20:39 +0000 (19:20 +0100)]
Updating hungarian translation
Mike Blumenkrantz [Wed, 29 Jan 2014 15:52:36 +0000 (10:52 -0500)]
add screensaver active edje signal for idle freezing
I forgot to commit this the other day I guess
Ryuan Choi [Wed, 29 Jan 2014 14:08:55 +0000 (23:08 +0900)]
fileselector: Fixed that data of "done" signal may start with two slash
When moved to root(/) and typed something in name_entry,
ok button sent //something as as data of "done" signal.
This patch checked current path string not to concatenate two slash.
Carsten Haitzler (Rasterman) [Wed, 29 Jan 2014 09:53:10 +0000 (18:53 +0900)]
theme - support icon provider message for e comp frames
Daniel Hirt [Tue, 28 Jan 2014 14:36:38 +0000 (14:36 +0000)]
elm entry: Fix anchor bug finding wrong anchor geometry.
Summary: Fix a bug with finding the proper geometry when reporting anchor
interaction. It's easy to see in entry anchor2 test in elementary_test
when clicking on the lower border of the anchor.
Anchor geometries are relative to the textblock object. The problem was
that this was accounted for using the edje object's geometry instead of
the textblock geometry thus causing an offset.
Reviewers: JackDanielZ, tasn
CC: seoz
Differential Revision: https://phab.enlightenment.org/D436
TAsn: Commit message edited by me.
Ryuan Choi [Tue, 28 Jan 2014 07:16:44 +0000 (16:16 +0900)]
fileselector: Fixed that does not navigate / on path_entry
href=/> are not working because /> is considered to self closing tag.
Instead. href='/'> is fine since rEFL2d4ba9e8d
Mike Blumenkrantz [Mon, 27 Jan 2014 14:46:22 +0000 (09:46 -0500)]
reduce iconify animation durations for fast comp effect groups
T860
davemds [Sun, 26 Jan 2014 22:49:07 +0000 (23:49 +0100)]
Packagekit module: try a new icon.
New icon for the E module as discussed on T427, I'm not
really happy by all the bits but its a good start. Also put
in the inkscape svg mockup file.
Thanks to ragecryx that draw the base icon!
Daniel Juyung Seo [Sun, 26 Jan 2014 17:07:44 +0000 (02:07 +0900)]
elm: Unified the usage of strncmp.
- Use strlen instead of sizeof(x) - 1 for string length calculation.
- Use !strncmp for null check.
Ryuan Choi [Sun, 26 Jan 2014 03:20:03 +0000 (12:20 +0900)]
test_web_ui: Added a button to test select tag and window.open()
elm_web provide UI compoents by extending ewebkit.
This patch adds a button to test select tag and window.open()
Ryuan Choi [Sun, 26 Jan 2014 03:16:07 +0000 (12:16 +0900)]
web: Follow latest webkit change to fix build break with latest ewebkit
ewk_view_tiled was dropped.
ewk_view_single -> ewk_view.
ChunEon Park [Sat, 25 Jan 2014 17:19:23 +0000 (02:19 +0900)]
fileselector - use the internal widget apis as possible.
We already know some apis are just wrapping the internal widget apis.
Iternally we don't need to call the external apis that have additional object validation checking.
Tom Hacohen [Fri, 24 Jan 2014 17:35:37 +0000 (17:35 +0000)]
Revert "[naviframe] Fix to hide the previous view by emitting signal"
This breaks elementary_config (open it and you'll see the weird bugs on
the top left corner). Please fix it and recommit as needed. I have no
time to dive into naviframe and see what this patch is meant to be
doing.
This reverts commit
e3784b68e01849a99e06f31e02192ffb19d1275c.
Cedric BAIL [Fri, 24 Jan 2014 03:08:33 +0000 (12:08 +0900)]
PKGBUILD - follow changes in defining version with efl.m4
Reviewers: cedric
Differential Revision: https://phab.enlightenment.org/D492
Signed-off-by: Cedric BAIL <cedric.bail@samsung.com>
Cedric BAIL [Fri, 24 Jan 2014 02:13:28 +0000 (11:13 +0900)]
autotools: let's override what we just did set.
ChunEon Park [Fri, 24 Jan 2014 02:07:58 +0000 (11:07 +0900)]
elementary - fix the build break.
caused by commit
9aa68bca91678dcd83de3e35be1a7121094d6ef7.
fix please cedric if this is wrong.
Daniel Juyung Seo [Fri, 24 Jan 2014 01:51:12 +0000 (10:51 +0900)]
naviframe: Better structure packing for naviframe item and added more
description about item structure members.
Cedric BAIL [Fri, 24 Jan 2014 01:28:05 +0000 (10:28 +0900)]
autotools: restore support of static compilation.
This should fix T599.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:15:39 +0000 (23:15 +0900)]
elm: Defined the same macro, MAX and MIN, in elm_priv.h
MAX and MIN are defined in a couple of places and they was already
defined in elm_priv.h. So use elm_priv.h's one.
I also moved CEIL to elm_priv.h that can be used in another places.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:11:12 +0000 (23:11 +0900)]
list: Used macro for list swipe time like genlist.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:09:28 +0000 (23:09 +0900)]
entry: Renamed internal macro name with prefix ELM_ENTRY for
consistency.
_CHUNK_SIZE -> ELM_ENTRY_CHUNK_SIZE.
Daniel Juyung Seo [Thu, 23 Jan 2014 14:05:24 +0000 (23:05 +0900)]
entry: Used macro for entry delay write time.
Daniel Juyung Seo [Thu, 23 Jan 2014 13:58:56 +0000 (22:58 +0900)]
conform: Use macro for indicator timer.
Daniel Juyung Seo [Thu, 23 Jan 2014 11:08:10 +0000 (20:08 +0900)]
edje_externals: Fixed formatting before working on it.
Ryuan Choi [Thu, 23 Jan 2014 13:22:33 +0000 (22:22 +0900)]
elm_cnp: Fix that calls _x11_elm_widget_xwin_get two times at elm_cnp_selection_{set|get}
small refactoring.
ChunEon Park [Thu, 23 Jan 2014 11:20:43 +0000 (20:20 +0900)]
elementary - override widget translation but work also the base widget's behavior.
Some widgets override the widget translation but it didn't inherit the base widget's function.
Becuase of it,The language changed won't be properly called in the widget tree.
Now it fixed it.
ChunEon Park [Thu, 23 Jan 2014 11:07:20 +0000 (20:07 +0900)]
elementary - support language changed callback from a few widgets.
support a language,changed callback if a widget has the text part in default.
ChunEon Park [Thu, 23 Jan 2014 10:30:34 +0000 (19:30 +0900)]
elementary - send signal "language,changed" with one way in the widget.
Call the smart callback in the widget infra so that each widget don't need to hook the smart_translate only for the smart call.
This makes reducing duplicated code and supporting language,chagned from all widgets.
ChunEon Park [Thu, 23 Jan 2014 08:24:19 +0000 (17:24 +0900)]
elementary - use the focused/unfocused string in widget defined.
Now, it will share the strings so that reduce the binary size also user uses it in one way.
WooHyun Jung [Thu, 23 Jan 2014 06:07:33 +0000 (15:07 +0900)]
test_focus3: Correct wrong data for smart callback.
Amitesh Singh [Thu, 23 Jan 2014 05:12:46 +0000 (14:12 +0900)]
focus: Fixed focus issue that the highlight was not visible on first
click.
Summary:
Focus highlight was not visible on first click on a widget with focus_highlight enabled on the window.
This happens because on first click, the "elm,action,focus,show" signal was emitted before setting focus highlight edje object as theme object of elm window.
In this patch, moved the _elm_win_focus_highlight_visible_set() call after focus highlight edje object set as theme object of window.
This fixes T774.
Test Plan:
elementary_test->focus then click any widget. Focus won't appear for the first time.
Reviewers: seoz, raster, woohyun
Maniphest Tasks: T774
Differential Revision: https://phab.enlightenment.org/D462
Carsten Haitzler (Rasterman) [Thu, 23 Jan 2014 02:59:07 +0000 (11:59 +0900)]
naviframe - don't access item after del
Daniel Juyung Seo [Wed, 22 Jan 2014 16:51:04 +0000 (01:51 +0900)]
test_hoversel: Change the hoversel button text when an hoversel item is
selected.
This reveals hoversel bug on mobile profile that changes the size of
text parts on continuous item change.
Daniel Juyung Seo [Wed, 22 Jan 2014 16:24:42 +0000 (01:24 +0900)]
spinner: Uncomment ctype.h inclusion because isspace is used.
It looks like ctype.h is included in some other headers by luck but it
is recommended to explicitly include the necessary header.
Confirmed by glima as he commented this out.
Daniel Juyung Seo [Wed, 22 Jan 2014 15:11:48 +0000 (00:11 +0900)]
spinner: Internal code clean up for spinner.
- Used macro for constant.
- Changed timer name to be more descriptive.
- Added descriptions about timers.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 15:28:13 +0000 (00:28 +0900)]
theme - win shadow - stack under all so pulsing icon is not BELOW the shadow.
Daniel Juyung Seo [Wed, 22 Jan 2014 14:33:16 +0000 (23:33 +0900)]
naviframe: Use elm_widget_item_del() when you want to delete the item
data.
It will call del_pre_func and free the item data.
Special thanks to glima for the report.
Jaehyun Cho [Wed, 22 Jan 2014 13:13:51 +0000 (22:13 +0900)]
[naviframe] Fix to enable item deletion in pop_cb
Summary: Fix to enable item deletion in the registered pop_cb function
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D487
Jaehyun Cho [Wed, 22 Jan 2014 13:09:16 +0000 (22:09 +0900)]
[naviframe] do not size evaluate during deletion
Summary: Author: Shinwoo Kim <cinoo.kim@samsung.com> 2012-12-11 20:13:39
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D485
Jaehyun Cho [Wed, 22 Jan 2014 13:07:30 +0000 (22:07 +0900)]
[naviframe] Fix to hide the previous view by emitting signal
Summary:
Previously, previous view was hidden by evas_object_hide.
However, this method is no longer correct because size calculation of naviframe causes evas_object_show.
Now, previous view is hidden by emitting signal to naviframe theme and clipper hides the previous view.
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D484
Daniel Juyung Seo [Wed, 22 Jan 2014 06:53:49 +0000 (15:53 +0900)]
fileselector: Make fileselector focusable. Ok on Enter key and Cancel on Escape key.
Now fileselector accepts the key event on Enter and Escape.
Daniel Juyung Seo [Wed, 22 Jan 2014 09:25:55 +0000 (18:25 +0900)]
fileselector_button: Added missing description about focus signals.
WooHyun Jung [Wed, 22 Jan 2014 09:36:13 +0000 (18:36 +0900)]
popup: Replace focus_direction_go with focus_cycle.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 09:32:24 +0000 (18:32 +0900)]
theme update to handle rename on/off in efm
shoudl fix T799
WooHyun Jung [Wed, 22 Jan 2014 07:24:25 +0000 (16:24 +0900)]
elm_widget: Fixed some codes about focus custom chain.
- When appending an object to the focus custom chain,
event callback about deletion should be added.
- When a widget is deleted, its focus custom chain should be
managed correctly.
Daniel Juyung Seo [Wed, 22 Jan 2014 06:17:45 +0000 (15:17 +0900)]
ctxpopup: Fixed typo and flourished comment.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:19:17 +0000 (15:19 +0900)]
elm filesel - scale button in filesel button.
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:17:47 +0000 (15:17 +0900)]
elm filesel - fix theme layout for button+entry
Carsten Haitzler (Rasterman) [Wed, 22 Jan 2014 06:14:15 +0000 (15:14 +0900)]
inwin - the "greying out" fade looks just wrong - make it black.
Jihoon Kim [Wed, 22 Jan 2014 04:20:15 +0000 (13:20 +0900)]
fix some typos in comment and description
Daniel Juyung Seo [Wed, 22 Jan 2014 03:32:32 +0000 (12:32 +0900)]
test_conform_indicator: Refactor internal code of conform_indicator test
code.
- removed unnecessary casting.
- removed unnecessary internal variables.
- removed wrong window resize object addition.
- changed parent parameter correctly.
- fixed wrong grammar in command line message.
- fixed resource leak.
- enhanced comments.
- removed unnecessary size hint align set.
- removed unnecessary parameter passing.
Daniel Juyung Seo [Wed, 22 Jan 2014 03:07:55 +0000 (12:07 +0900)]
config: Added more description about elm_config_indicator_service_get().
Youngbok Shin [Wed, 22 Jan 2014 02:32:08 +0000 (11:32 +0900)]
entry: Fixed to emit "*enabled" signal to scr_edje when it is not disabled.
Summary: This fixes coverity issue CID 1162751.
Reviewers: seoz, woohyun, tasn
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D482
Daniel Juyung Seo [Wed, 22 Jan 2014 02:14:23 +0000 (11:14 +0900)]
elm: Removed unnecessary null checks.
As all efl public free apis and free function get null as valid parameter,
we do not need to check null. I also used ELM_SAFE_FREE if necessary.
After this job code got cleaner.
This is a continue of a commit
e3372339.
Daniel Juyung Seo [Wed, 22 Jan 2014 02:13:30 +0000 (11:13 +0900)]
elm: Removed unnecessary null check for eina_hash_free and
elm_widget_stringlist_free.
Daniel Juyung Seo [Wed, 22 Jan 2014 02:08:47 +0000 (11:08 +0900)]
elm: Removed unnecessary null check for free.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:47:33 +0000 (10:47 +0900)]
elm: Removed unnecessary null check for eina_list_free.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:47:03 +0000 (10:47 +0900)]
elm: Removed unnecessary null check for ecore_event_handler_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:38:55 +0000 (10:38 +0900)]
elm: Removed unnecessary null check for evas_object_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 01:12:44 +0000 (10:12 +0900)]
elm: Removed unnecessary null check for eina_stringshare_del.
Daniel Juyung Seo [Wed, 22 Jan 2014 00:55:58 +0000 (09:55 +0900)]
elm: Removed unnecessary null check for ecore_idler_del, ecore_idle_enterer_del.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:53:48 +0000 (23:53 +0900)]
test, examples fileselector_entry: Changed the usage of deprecated APIs
to recommended APIs.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:50:31 +0000 (23:50 +0900)]
fileselector_entry: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:43:59 +0000 (23:43 +0900)]
test, examples fileselector_button: Changed the usage of deprecated APIs to recommended
APIs.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:42:56 +0000 (23:42 +0900)]
fileselector_button: Moved declarations of deprecated APIs to
elm_deprecated.h and marked them as EINA_DEPRECATED in c code.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:23:37 +0000 (23:23 +0900)]
url: Added underscore(_) to elm internal functions, elm_url_xxx.
- _elm_url_download, _elm_url_cancel, _elm_url_get
- other internal functions in elm_priv.h also have same prefix.
Daniel Juyung Seo [Tue, 21 Jan 2014 14:16:41 +0000 (23:16 +0900)]
elm: Removed unnecessary null check for ecore_timer_del,
ecore_animator_del, and ecore_job_del.
As all efl public free apis get null as valid parameter, we do not need
to check null. I also removed some null check for other free apis which
were right next to timer/animator/job del. After this job code got
cleaner.
Ryuan Choi [Tue, 21 Jan 2014 13:50:35 +0000 (22:50 +0900)]
Introduce fileselector interface and applied to elm_fileselector.
Summary:
fileselector_button and fileselector_entry should have almost same interfaces with fileselector.
Previously , we exposed them individually such as elm_fileselector_is_save_set().
Instead of adding the same APIs three times, we can reuse one fileselector's API using Eo interface.
This patch introduced fileselector interface and applied it to elm_fileselector.
Reviewers: seoz, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D475
Daniel Juyung Seo [Tue, 21 Jan 2014 13:12:53 +0000 (22:12 +0900)]
spinner: Create an internal entry when it is really needed.
Do not create the internal entry on smart add. Create that when it is
needed with editable mode.