robertphillips@google.com [Thu, 12 Dec 2013 14:24:20 +0000 (14:24 +0000)]
Reverting r12635 (Make leak counters thread-safe - https://codereview.chromium.org/
99483003) due to compile errors on Mac 10.6 & in Chrome
git-svn-id: http://skia.googlecode.com/svn/trunk@12637
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 12 Dec 2013 14:00:12 +0000 (14:00 +0000)]
Make leak counters thread-safe and turn them on by default for Debug
Make leak counters implemented with SK_DECLARE_INST_COUNT thread-safe.
Enable the leak counting for Debug builds.
Protect the instance counter initialization step (initStep) by
using SkOnce.
Makes SkOnce.h part of the public API, since SkInstCnt is public.
Protect the per-class child list shared variable with a per-class mutex.
Changes the behavior in the way that if the child list has been
"cleaned up", it will still try to create subsequent child lists.
BUG=skia:1219
R=robertphillips@google.com, mtklein@google.com, bungeman@gmail.com, bsalomon@google.com, bungeman@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
99483003
git-svn-id: http://skia.googlecode.com/svn/trunk@12635
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 12 Dec 2013 14:00:01 +0000 (14:00 +0000)]
Whitespace change to test commit queue.
(SkipBuildbotRuns)
BUG=
TBR=borenet@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
94103005
git-svn-id: http://skia.googlecode.com/svn/trunk@12634
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 23:54:31 +0000 (23:54 +0000)]
[PDF] Fix font width generation when glyph 0 is used.
Using glyph 0 caused gid 0 to be in the subset list twice, which violated an assumption in the code. Added an assert for the assumption and updated the code to not insert gid 0 into the subset list twice.
BUG=skia:1889
R=bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/
113093004
git-svn-id: http://skia.googlecode.com/svn/trunk@12632
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 21:22:39 +0000 (21:22 +0000)]
Revert "remvoe duplicate impl for SkImageInfo flattening"
Reason: breaks chrome_mac_tests which still have non-imageinfo constructors
This reverts commit
a06b8cf60b39bda93e9ef1a73579007b2b930d29.
BUG=
Review URL: https://codereview.chromium.org/
103033005
git-svn-id: http://skia.googlecode.com/svn/trunk@12631
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 21:15:58 +0000 (21:15 +0000)]
Revert "Revert of https://codereview.chromium.org/
108773003/"
This reverts commit
947e6a3142af66b750f1247ef933b11ed8455dd4.
BUG=
Review URL: https://codereview.chromium.org/
112963003
git-svn-id: http://skia.googlecode.com/svn/trunk@12630
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 20:55:41 +0000 (20:55 +0000)]
Revert of https://codereview.chromium.org/
108773003/
Reason for revert: breaks chrome-mac-tests
TBR=
NOTREECHECKS=true
NOTRY=true
Author: reed@google.com
Review URL: https://codereview.chromium.org/
113193003
git-svn-id: http://skia.googlecode.com/svn/trunk@12629
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 20:19:42 +0000 (20:19 +0000)]
Tiny, urgent fix for rebaseline_server to accept new baselines.
(SkipBuildbotRuns)
R=jcgregorio@google.com
TBR=jcgregorio
NOTREECHECKS=True
NOTRY=True
BUG=
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
99763007
git-svn-id: http://skia.googlecode.com/svn/trunk@12628
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Wed, 11 Dec 2013 20:11:27 +0000 (20:11 +0000)]
Update stroke-fill_pdf-native.png after r12625
TBR=bungeman@google.com
Review URL: https://codereview.chromium.org/
102443006
git-svn-id: http://skia.googlecode.com/svn/trunk@12627
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 20:08:18 +0000 (20:08 +0000)]
remaining GM baselines for pdf-poppler
R=vandebo@chromium.org
TBR=vandebo
BUG=
(SkipBuildbotRuns)
NOTRY=True
NOTREECHECKS=True
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
112973004
git-svn-id: http://skia.googlecode.com/svn/trunk@12626
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 18:47:11 +0000 (18:47 +0000)]
[PDF] Fix bug in ToUnicode table generation for Type 3 fonts.
True glyphIDs where being using in the Type3 ToUnicode table instead of IDs of 1-255. This causes poppler to complain about each entry.
BUG:skia:1565
R=bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/
112053005
git-svn-id: http://skia.googlecode.com/svn/trunk@12625
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 18:38:46 +0000 (18:38 +0000)]
remvoe duplicate impl for SkImageInfo flattening
Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""""
This reverts commit
eabd6b2ed4e494b323c08f32358f45950a0368c3.
BUG=
Review URL: https://codereview.chromium.org/
108773003
git-svn-id: http://skia.googlecode.com/svn/trunk@12624
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 18:19:10 +0000 (18:19 +0000)]
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""""
This reverts commit
d08eca87a0bef10112a211de540f89656a80b86a.
BUG=
Review URL: https://codereview.chromium.org/
108303003
git-svn-id: http://skia.googlecode.com/svn/trunk@12623
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 18:04:56 +0000 (18:04 +0000)]
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""""
BUG=
Review URL: https://codereview.chromium.org/
110503003
git-svn-id: http://skia.googlecode.com/svn/trunk@12622
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 17:34:58 +0000 (17:34 +0000)]
Added canvas.fillStyle with support for just the "#RRGGBB" style of colors.
Also renamed drawRect to fillRect, which now take x,y,w,h parameters.
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
108813004
git-svn-id: http://skia.googlecode.com/svn/trunk@12621
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 17:05:23 +0000 (17:05 +0000)]
Fix SampleApp bounding box hierarchy shortcut collision.
'b' is currently bound to the AA toggle, AND to the bounding box
hierachy toggle.
The CL switches BBH to 'B', and fixes a deferred title update issue.
R=reed@google.com, robertphillips@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
112903002
git-svn-id: http://skia.googlecode.com/svn/trunk@12620
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 11 Dec 2013 15:35:41 +0000 (15:35 +0000)]
be more careful about OOB source pixels in the scanline rescaler, and
less certain about why the standalone scaler might have faileds
BUG=
R=reed@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
100473011
git-svn-id: http://skia.googlecode.com/svn/trunk@12619
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 11 Dec 2013 15:30:24 +0000 (15:30 +0000)]
add more tests for discardable caches
BUG=
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
112833003
git-svn-id: http://skia.googlecode.com/svn/trunk@12618
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 11 Dec 2013 07:02:06 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12617
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 23:06:54 +0000 (23:06 +0000)]
Avoid heap allocation in SkPictureStateTree constructor
This makes empty state trees cheaper. ~1% improvement on rasterize_and_record_micro.key_silk_cases on Android.
BUG=1772
R=tomhudson@chromium.org, tomhudson@google.com
Author: skyostil@chromium.org
Review URL: https://codereview.chromium.org/
111573002
git-svn-id: http://skia.googlecode.com/svn/trunk@12616
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 10 Dec 2013 22:25:53 +0000 (22:25 +0000)]
More signed/unsigned comparison warnings.
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
100103006
git-svn-id: http://skia.googlecode.com/svn/trunk@12615
2bbb7eff-a529-9590-31e7-
b0007b416f81
fmalita@google.com [Tue, 10 Dec 2013 22:12:40 +0000 (22:12 +0000)]
Fix warning after
bbe43a9ce051.
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
108973006
git-svn-id: http://skia.googlecode.com/svn/trunk@12614
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 21:51:06 +0000 (21:51 +0000)]
Add SkTileGridPicture SampleApp playback support.
SampleApp already supports switching to a bbox hierarchy playback mode
('b' shortcut). This CL adds an SkTileGridPicture bbox mode.
R=reed@google.com, robertphillips@google.com, fmalita@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
108513006
git-svn-id: http://skia.googlecode.com/svn/trunk@12613
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Tue, 10 Dec 2013 21:11:12 +0000 (21:11 +0000)]
Sk_API for SkImageGenerator and SkInstallDiscardablePixelRef
Added SK_API to SkImageGenerator (already in include/).
Moved SkDiscardablePixelRef::Install to SkInstallDiscardablePixelRef,
added SK_API to that function, and moved declaration to
SkImageGenerator.h
This keeps the SkDiscardablePixelRef internal to Skia, but exposes a
method to install it into a bitmap.
Modifed tests that rely on this functio to use new version.
BUG=
R=mtklein@google.com, reed@google.com
Review URL: https://codereview.chromium.org/
111713002
git-svn-id: http://skia.googlecode.com/svn/trunk@12612
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 20:37:41 +0000 (20:37 +0000)]
Support MSAA4 and (non-ES) OpenGL in Android SampleApp
Add a menu item to set the OpenGL context type that SampleApp uses on
Android. The submenu of the new item will present options to create
OpenGL ES or OpenGL, aliased or multisampled.
R=djsollen@google.com, bsalomon@google.com
Author: kkinnunen@nvidia.com
Review URL: https://codereview.chromium.org/
60273006
git-svn-id: http://skia.googlecode.com/svn/trunk@12610
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Tue, 10 Dec 2013 18:33:07 +0000 (18:33 +0000)]
Implement SkAshmemDiscardableMemory
- Implement ashmem-backed SkDiscardableMemory subclass:
This class in only accesible via the SkDiscardableMemory::Create()
function, which replaces the mock implementation in
SkDiscardableMemory_none.cpp
- Added SkDiscardableMemory_ashmem.cpp to the Android port of Skia
Removed SkDiscardableMemory_none.cpp from the Android port.
- Added DiscardableMemoryTest.
Still needs work.
- SkDiscardablePixelRef Bugfix:
onLockPixels() now calls SkDELETE on the SkDiscardableMemory pointer
when it fails to unlock.
- Improved documentation inside ashmem.h
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
83563002
git-svn-id: http://skia.googlecode.com/svn/trunk@12608
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Tue, 10 Dec 2013 18:09:36 +0000 (18:09 +0000)]
improve bitmap font support (FreeType only)
This commit improves SkFontHost_FreeType's support for bitmap fonts,
adding a number of features:
- Intelligent bitmap strike selection.
- Inter-strike bitmap font scaling.
- Colour bitmap font support (FreeType 2.5.0+).
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
23684041
git-svn-id: http://skia.googlecode.com/svn/trunk@12607
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 17:59:04 +0000 (17:59 +0000)]
Revert of https://codereview.chromium.org/
111853003/
Reason for revert: Was not the culprit.
R=bungeman@google.com, reed@google.com
TBR=bungeman@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
102243009
git-svn-id: http://skia.googlecode.com/svn/trunk@12606
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 10 Dec 2013 17:22:41 +0000 (17:22 +0000)]
Revert "[PDF] Fix font embedding restrictions."
This reverts r12600 and r12601, likely causing crash on Mac.
Review URL: https://codereview.chromium.org/
111893002
git-svn-id: http://skia.googlecode.com/svn/trunk@12604
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 17:08:55 +0000 (17:08 +0000)]
Revert of https://codereview.chromium.org/
109033002/
Reason for revert: I suspect this is causing GM to crash on Mac.
R=bungeman@google.com, reed@google.com
TBR=bungeman@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
111853003
git-svn-id: http://skia.googlecode.com/svn/trunk@12603
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 10 Dec 2013 16:53:13 +0000 (16:53 +0000)]
change 'n' toggle to cycle through all filterlevels
BUG=
R=humper@google.com
Review URL: https://codereview.chromium.org/
109473004
git-svn-id: http://skia.googlecode.com/svn/trunk@12602
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Tue, 10 Dec 2013 16:49:25 +0000 (16:49 +0000)]
Fix missing ; in win code.
Review URL: https://codereview.chromium.org/
104533005
git-svn-id: http://skia.googlecode.com/svn/trunk@12601
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 16:32:06 +0000 (16:32 +0000)]
[PDF] Fix font embedding restrictions.
Stop using restricted font outlines and honor don't subset restriction.
R=reed@google.com, bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/
107863002
git-svn-id: http://skia.googlecode.com/svn/trunk@12600
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 16:27:44 +0000 (16:27 +0000)]
Shut up the CoreText performance note.
Aped from https://codereview.qt-project.org/70097
Please keep in mind: https://www.google.com/search?q=i+have+no+idea+what+i'm+doing+dog&tbm=isch
BUG=
R=bungeman@google.com, reed@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
109033002
git-svn-id: http://skia.googlecode.com/svn/trunk@12599
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Dec 2013 15:51:43 +0000 (15:51 +0000)]
Fix error in r12597 (can't forget that newline at the end of a file)
git-svn-id: http://skia.googlecode.com/svn/trunk@12598
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Dec 2013 15:19:32 +0000 (15:19 +0000)]
New Composite CSS border object
https://codereview.chromium.org/
86263003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12597
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 14:53:16 +0000 (14:53 +0000)]
Add support for reading a directory of images with --expectations (-r).
DM writes out its images in a hierarchy that's a little different than GM,
so this can't read GM's output. But it can read its own, written with -w.
Example usage:
$ out/Release/dm -w /tmp/baseline
$ out/Release/dm -r /tmp/baseline -w /tmp/new
(and optionally)
$ mkdir /tmp/diff; out/Release/skdiff /tmp/baseline /tmp/new /tmp/diff
GM's IndividualImageExpectationsSource and Expectations are a little too eager
about decoding and hashing the expected images, so I took the opportunity to
add DM::Expectations that mostly replaces skiagm::ExpectationsSource and
skiagm::Expectations in DM. It mainly exists to move the image decoding and
comparison off the main thread, which would otherwise be a major speed
bottleneck.
I tried to use skiagm code where possible. One notable place where I differed
is in this new feature. When -r is a directory of images, DM does no hashing.
It considerably faster to read the expected file into an SkBitmap and do a
byte-for-byte comparison than to hash the two bitmaps and check those.
The example usage above isn't quite working 100% yet. Expectations on some GMs
fail, even with no binary change. I haven't pinned down whether this is due to
- a bug in DM
- flaky GMs
- unthreadsafe GMs
- flaky image decoding
- unthreadsafe image decoding
- something else
but I intend to. Leon, Derek and I have suspected PNG decoding isn't
threadsafe, but are as yet unable to prove it.
I also seem to be able to cause malloc to fail on my laptop if I run too many
configs at once, though I never seem to be using more than ~1G of RAM. Will
track that down too.
BUG=
R=reed@google.com, bsalomon@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
108963002
git-svn-id: http://skia.googlecode.com/svn/trunk@12596
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 14:13:03 +0000 (14:13 +0000)]
Add a canvas object with drawRect() and inval().
BUG=
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
110693002
git-svn-id: http://skia.googlecode.com/svn/trunk@12595
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 10 Dec 2013 12:56:56 +0000 (12:56 +0000)]
Add clipped-bitmap-shaders-*-hq_angle.png to ignore-tests.txt
git-svn-id: http://skia.googlecode.com/svn/trunk@12594
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 12:54:21 +0000 (12:54 +0000)]
Correct baseline images for new "bitmapshaders" test
(SkipBuildbotRuns)
NOTRY=True
BUG=
R=djsollen@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
110643002
git-svn-id: http://skia.googlecode.com/svn/trunk@12593
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 12:53:56 +0000 (12:53 +0000)]
Add support for MIPS to android build
R=borenet@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
109323004
git-svn-id: http://skia.googlecode.com/svn/trunk@12592
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 10 Dec 2013 12:53:39 +0000 (12:53 +0000)]
Make GrBicubicEffect take tile modes rather than GrTextureParams.
GrTextureParams allows the caller to override the filter mode. But no filtering other than nearest neighbor makes sense.
Also removes coord set from creation signature since it is unused.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
99523008
git-svn-id: http://skia.googlecode.com/svn/trunk@12591
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 10 Dec 2013 07:02:03 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12590
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Mon, 9 Dec 2013 23:22:15 +0000 (23:22 +0000)]
[PDF] PDF rasterizers fed garbage data in release mode.
BUG=skia:1885
TBR=epoger@google.com
Review URL: https://codereview.chromium.org/
103213007
git-svn-id: http://skia.googlecode.com/svn/trunk@12589
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Dec 2013 22:29:30 +0000 (22:29 +0000)]
support scaledimagecache instantiable using discardablememory
Add this to your build/gyp system to use discardable instead of malloc+budget
#define SK_USE_DISCARDABLE_SCALEDIMAGECACHE
R=halcanary@google.com
Review URL: https://codereview.chromium.org/
105933003
git-svn-id: http://skia.googlecode.com/svn/trunk@12588
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Dec 2013 22:09:41 +0000 (22:09 +0000)]
add
git-svn-id: http://skia.googlecode.com/svn/trunk@12587
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Dec 2013 22:01:03 +0000 (22:01 +0000)]
make info real in SkPixelRef, and add bitmap::asImageInfo
BUG=
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
108663004
git-svn-id: http://skia.googlecode.com/svn/trunk@12586
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Mon, 9 Dec 2013 21:02:11 +0000 (21:02 +0000)]
GM expectations: create initial empty expectations for Test-Ubuntu12-ShuttleA-ATI5770-x86_64-Release-Valgrind
(SkipBuildbotRuns)
TBR=djsollen
Review URL: https://codereview.chromium.org/
100643003
git-svn-id: http://skia.googlecode.com/svn/trunk@12585
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Dec 2013 20:52:47 +0000 (20:52 +0000)]
add hq clipped biptmap shader GMs to ignored-tests.txt
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
93633003
git-svn-id: http://skia.googlecode.com/svn/trunk@12584
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 9 Dec 2013 20:52:40 +0000 (20:52 +0000)]
New Nexus4 baselines due to r12571.
R=robertphillips
Review URL: https://codereview.chromium.org/
110603003
git-svn-id: http://skia.googlecode.com/svn/trunk@12583
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Dec 2013 20:41:00 +0000 (20:41 +0000)]
Mark rrect_clip_aa, skbug1719, and pathopsskpclip as ignored on N4 gpu
BUG=skia:1888
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/
107843003
git-svn-id: http://skia.googlecode.com/svn/trunk@12582
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 9 Dec 2013 20:35:03 +0000 (20:35 +0000)]
Revert the revert of (ARM Skia NEON patches - 34 - Blur Filter - https://codereview.chromium.org/
109403004/)
git-svn-id: http://skia.googlecode.com/svn/trunk@12581
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Dec 2013 20:31:50 +0000 (20:31 +0000)]
cast -1 to Mode to avoid warning (enum compared to signed int)
git-svn-id: http://skia.googlecode.com/svn/trunk@12580
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 9 Dec 2013 20:16:17 +0000 (20:16 +0000)]
Reverting r12568 (ARM Skia NEON patches - 34 - Blur Filter - https://codereview.chromium.org/
109403004) due to image quality regressions on the N4.
git-svn-id: http://skia.googlecode.com/svn/trunk@12578
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 9 Dec 2013 19:30:28 +0000 (19:30 +0000)]
Fix one too many levels of indirection introduced in 12573.
git-svn-id: http://skia.googlecode.com/svn/trunk@12577
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Dec 2013 19:15:37 +0000 (19:15 +0000)]
Do not use GrBicubic effect when downscaling. Also, don't use glTexStorage as it interferes with deleyed mipmap generation.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
105353002
git-svn-id: http://skia.googlecode.com/svn/trunk@12576
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Dec 2013 19:08:44 +0000 (19:08 +0000)]
adding to whitespace.txt using a pure git checkout
(SkipBuildbotRuns)
BUG=
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
110553002
git-svn-id: http://skia.googlecode.com/svn/trunk@12574
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 9 Dec 2013 18:58:31 +0000 (18:58 +0000)]
Fix threading issue in DirectWrite port initialization.
The DirectWrite port maintains a global instance of an IDWriteFactory,
which is used to create all other DirectWrite objects. However, the
initialization of this object is not currently thread safe.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/
107963003
git-svn-id: http://skia.googlecode.com/svn/trunk@12573
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 9 Dec 2013 18:48:51 +0000 (18:48 +0000)]
fix file names in gpu.gypi
Review URL: https://codereview.chromium.org/
99193004
git-svn-id: http://skia.googlecode.com/svn/trunk@12572
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 9 Dec 2013 18:31:42 +0000 (18:31 +0000)]
Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
This also includes some changes to the xfermodeimagefilter and tileimagefilter GMs to properly handle the CTM. This worked before only because SkBitmapSource was ignoring the CTM. Now that it respects it, we need to give the correct transform. This also means the GMs now work while zoomed. It also implements CTM support for SkTileImageFilter.
NOTE: this will require rebaselining a number of imagefilter GMs on Nexus4, since they render in perspective (using the CTM). The changes to the results should all be improvements.
R=reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/
106933002
git-svn-id: http://skia.googlecode.com/svn/trunk@12571
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Dec 2013 17:03:02 +0000 (17:03 +0000)]
Make texture domain a helper so that it can be incorporated into other effects.
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
98893006
git-svn-id: http://skia.googlecode.com/svn/trunk@12569
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Dec 2013 16:03:30 +0000 (16:03 +0000)]
ARM Skia NEON patches - 34 - Blur Filter
Improve a little on Blur
Grouping operations gives a 5-15% speed improvement on a Cortex-A15 based Chromebook.
before:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 30887.69
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 30751.35
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 30757.92
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 30673.88
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 19602.17
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 20613.81
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 17855.46
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 17957.79
after:
running bench [640 480] blur_image_filter_large_10.00_10.00 8888: cmsecs = 27015.75
running bench [640 480] blur_image_filter_small_10.00_10.00 8888: cmsecs = 27148.02
running bench [640 480] blur_image_filter_large_1.00_1.00 8888: cmsecs = 27241.60
running bench [640 480] blur_image_filter_small_1.00_1.00 8888: cmsecs = 27077.44
running bench [640 480] blur_image_filter_large_0.00_1.00 8888: cmsecs = 18458.10
running bench [640 480] blur_image_filter_large_0.00_10.00 8888: cmsecs = 19643.42
running bench [640 480] blur_image_filter_large_1.00_0.00 8888: cmsecs = 16176.73
running bench [640 480] blur_image_filter_large_10.00_0.00 8888: cmsecs = 16450.50
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=senorblanco@chromium.org, mtklein@google.com, luisjoseromeroesclusa@hotmail.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
109403004
git-svn-id: http://skia.googlecode.com/svn/trunk@12568
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 9 Dec 2013 13:55:33 +0000 (13:55 +0000)]
Add more valgrind suppressions
https://codereview.chromium.org/
102443003/
git-svn-id: http://skia.googlecode.com/svn/trunk@12561
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Mon, 9 Dec 2013 13:45:02 +0000 (13:45 +0000)]
SkDecodingImageGenerator now uses SkStreamRewindable
This makes sense since Android will be giving us a stream and the
decoders expect a stream. This also removes some glue code,
DecodeMemoryToTarget, that works better using a SkImageGenerator.
Motivation: This is a necessary step to move from SkImageRef to
SkDiscardablePixelRef.
SkImageDecoder::DecodeMemoryToTarget function removed.
BUG=
R=reed@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
101973005
git-svn-id: http://skia.googlecode.com/svn/trunk@12560
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 9 Dec 2013 13:41:06 +0000 (13:41 +0000)]
add SkImageInfo to SkGrPixelRef constructor, to prep for larger CL
BUG=
Review URL: https://codereview.chromium.org/
104923011
git-svn-id: http://skia.googlecode.com/svn/trunk@12559
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 9 Dec 2013 09:14:59 +0000 (09:14 +0000)]
Just a typo. Rename StrokeRect to StrokeRects in strokerects.cpp, making it different from the class name in strokerect.cpp for debugging.
R=bungeman@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
99573004
git-svn-id: http://skia.googlecode.com/svn/trunk@12557
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 7 Dec 2013 07:02:21 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12555
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 22:59:02 +0000 (22:59 +0000)]
gpudevice should never allocate pixels for its backend
BUG=
R=bsalomon@google.com, mtklein@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
109013002
git-svn-id: http://skia.googlecode.com/svn/trunk@12554
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 22:16:10 +0000 (22:16 +0000)]
remove explicit when we have 2 args
git-svn-id: http://skia.googlecode.com/svn/trunk@12553
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 22:07:17 +0000 (22:07 +0000)]
add SK_SUPPORT_LEGACY_PIXELREF_CONSTRUCTOR, initially always on
BUG=
Review URL: https://codereview.chromium.org/
106183007
git-svn-id: http://skia.googlecode.com/svn/trunk@12552
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 21:43:05 +0000 (21:43 +0000)]
Revert "Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."""
This reverts commit
5f035e90d6dea0139a4f204b634e7b7b3b4976d7.
Reverting because it breaks chrome/blink due to new SkPixelRef constructor arg.
BUG=
Review URL: https://codereview.chromium.org/
108993002
git-svn-id: http://skia.googlecode.com/svn/trunk@12551
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 20:31:45 +0000 (20:31 +0000)]
Revert "Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.""
This reverts commit
4174afb18a9746bbad2a06c0ec2d4ad35f72d790.
BUG=
Review URL: https://codereview.chromium.org/
108723003
git-svn-id: http://skia.googlecode.com/svn/trunk@12547
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 20:14:55 +0000 (20:14 +0000)]
Additional SampleApp tiling options.
Adding some more tiling options (both relative and fixed size):
kNo_Tiling,
kAbs_128x128_Tiling,
kAbs_256x256_Tiling,
kRel_4x4_Tiling,
kRel_1x16_Tiling,
kRel_16x1_Tiling,
R=bungeman@google.com, reed@google.com, fmalita@google.com
Author: fmalita@chromium.org
Review URL: https://codereview.chromium.org/
108213004
git-svn-id: http://skia.googlecode.com/svn/trunk@12545
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 20:14:46 +0000 (20:14 +0000)]
Fixed a few places where uninitialized memory could have been read
Also added early exit in SkImageFilter's constructor to avoid attempting to deserialize all inputs once a bad input has been found. This avoids hanging if a filter pretends to have 1 billion inputs when that's just an error on the number of inputs read by the filter.
BUG=326206,326197,326229
R=senorblanco@chromium.org, senorblanco@google.com, reed@google.com, sugoi@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
106943002
git-svn-id: http://skia.googlecode.com/svn/trunk@12544
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 20:14:39 +0000 (20:14 +0000)]
Add GM to test bitmap shaders with basic geometry and bitmap masks.
R=reed@google.com, bsalomon@google.com, rmistry@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
98433004
git-svn-id: http://skia.googlecode.com/svn/trunk@12543
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 18:51:08 +0000 (18:51 +0000)]
Revert "PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap."
This reverts commit
154e08b2f5904ef533da694e3510befcb9a3f3e2.
revert due to warnings
Review URL: https://codereview.chromium.org/
108513003
git-svn-id: http://skia.googlecode.com/svn/trunk@12538
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 6 Dec 2013 18:41:33 +0000 (18:41 +0000)]
PixelRef now returns (nearly) everything that is currently in SkBitmap. The goal is to refactor bitmap later to remove redundancy, and more interestingly, remove the chance for a disconnect between the actual (pixelref) rowbytes and config, and the one claimed by the bitmap.
R=mtklein@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
68973005
git-svn-id: http://skia.googlecode.com/svn/trunk@12537
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 18:05:03 +0000 (18:05 +0000)]
Fix #define for distance field fonts
R=robertphillips@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
108413002
git-svn-id: http://skia.googlecode.com/svn/trunk@12536
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 6 Dec 2013 17:59:33 +0000 (17:59 +0000)]
Nobody knows the rebaselines I've seen...
git-svn-id: http://skia.googlecode.com/svn/trunk@12535
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 6 Dec 2013 17:44:15 +0000 (17:44 +0000)]
Reverting 12528 & 12533 (Implement srcRect and dstRect functionality in SkBitmapSource) due to image differences on N4
https://codereview.chromium.org/
108623002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12534
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 6 Dec 2013 17:08:50 +0000 (17:08 +0000)]
Fix Windows compiler warnings/errors
https://codereview.chromium.org/
108563002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12533
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 17:08:19 +0000 (17:08 +0000)]
Whitespace change to test CQ.
(SkipBuildbotRuns)
BUG=
TBR=borenet@google.com
NOTREECHECKS=true
NOTRY=true
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
108553002
git-svn-id: http://skia.googlecode.com/svn/trunk@12532
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Fri, 6 Dec 2013 17:03:39 +0000 (17:03 +0000)]
Generalize valgrind suppressions & a 2 more
https://codereview.chromium.org/
107443004/
git-svn-id: http://skia.googlecode.com/svn/trunk@12531
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 6 Dec 2013 17:03:25 +0000 (17:03 +0000)]
commit remaining pdf-poppler GM results as unreviewed-by-humans
BUG=skia:1884
TBR=vandebo
Review URL: https://codereview.chromium.org/
103033004
git-svn-id: http://skia.googlecode.com/svn/trunk@12530
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 6 Dec 2013 16:35:26 +0000 (16:35 +0000)]
pdf-poppler GM results: updated more still-unreviewed expectations
(The prior revision of these expectations were unreviewed-by-humans anyway)
BUG=skia:1578,skia:1759
TBR=vandebo
Review URL: https://codereview.chromium.org/
93883003
git-svn-id: http://skia.googlecode.com/svn/trunk@12529
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 15:59:03 +0000 (15:59 +0000)]
Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
This also includes some changes to the xfermodeimagefilter and tileimagefilter GMs to properly handle the CTM. This worked before only because SkBitmapSource was ignoring the CTM. Now that it respects it, we need to give the correct transform. This also means the GMs now work while zoomed.
R=reed@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
106933002
git-svn-id: http://skia.googlecode.com/svn/trunk@12528
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 15:24:52 +0000 (15:24 +0000)]
A simple draw() function in Javascript.
R=robertphillips@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
102803003
git-svn-id: http://skia.googlecode.com/svn/trunk@12527
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Fri, 6 Dec 2013 15:23:15 +0000 (15:23 +0000)]
Really truly final (?) rebaseline for https://codereview.chromium.org/
102683002/
git-svn-id: http://skia.googlecode.com/svn/trunk@12526
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 6 Dec 2013 11:32:27 +0000 (11:32 +0000)]
ARM Skia NEON patches - 32 - Xfermode: 1-pixel NEON modeprocs
In some cases, it's easy to provide a NEON version of the 1-pixel modeprocs.
Combined with https://codereview.chromium.org/
23724013/ (merged) it allows
up to 35% speed improvement on Xfermodes when aa is non-NULL.
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=
R=djsollen@google.com, reed@google.com, mtklein@google.com, luisjoseromeroesclusa@hotmail.com
Author: kevin.petit.arm@gmail.com
Review URL: https://codereview.chromium.org/
104883004
git-svn-id: http://skia.googlecode.com/svn/trunk@12525
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 6 Dec 2013 07:02:04 +0000 (07:02 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@12524
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 5 Dec 2013 23:06:07 +0000 (23:06 +0000)]
Revert "Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource"." until I can sort out the xfermodeimagefilter and tileimagefilter failures.
This reverts commit
b26725c8c9755415284c34399e76be098868e01a, aka r12522.
BUG=
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
107093005
git-svn-id: http://skia.googlecode.com/svn/trunk@12523
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 5 Dec 2013 22:41:53 +0000 (22:41 +0000)]
Implement srcRect and dstRect functionality in SkBitmapSource. This is required for the "preserveAspectRatio" options of SVG's feImage. Covered by new GM "bitmapsource".
Note: I initially implemented this as a fully-generic SkResizeImageFilter, but then I realized that the dstRect should always be transformed by the filter matrix, but that the srcRect should not (since it's specified relative to the dimensions of the original bitmap). Since this would be confusing for someone attempting to use this as a generic resizing filter, I decided to build the functionality into SkBitmapSource instead.
BUG=
R=reed@google.com
Review URL: https://codereview.chromium.org/
106933002
git-svn-id: http://skia.googlecode.com/svn/trunk@12522
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 5 Dec 2013 22:07:08 +0000 (22:07 +0000)]
Update not-reviewed-by-human poppler baselines
BUG=skia:1657,skia:1578
TBR=vandebo
These were already annotated as belonging to
https://code.google.com/p/skia/issues/detail?id=1578 ('commit GM actuals
as expectations for all tests, marking them as unreviewed'),
which means they had not been visually reviewed in the first place.
So we have no reason to believe their current results are incorrect
(for all we know, they were wrong before)
For these and all other expectations with the bug1578 annotation, we should
figure out a way to validate them. But that's for another day...
Review URL: https://codereview.chromium.org/
107293002
git-svn-id: http://skia.googlecode.com/svn/trunk@12521
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 5 Dec 2013 21:14:02 +0000 (21:14 +0000)]
Fix refcounting bug for Type1 font usage with more than 255 characters.
R=bungeman@google.com
Author: vandebo@chromium.org
Review URL: https://codereview.chromium.org/
103423003
git-svn-id: http://skia.googlecode.com/svn/trunk@12520
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Thu, 5 Dec 2013 20:40:04 +0000 (20:40 +0000)]
Fix change src/ports/SkImageDecoder_empty.cpp missed in
103033002
BUG=
R=robertphillips@google.com
Review URL: https://codereview.chromium.org/
107123002
git-svn-id: http://skia.googlecode.com/svn/trunk@12519
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 5 Dec 2013 19:20:49 +0000 (19:20 +0000)]
SkOnce: let f be any functor, update comments
BUG=
R=bungeman@google.com
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
104433005
git-svn-id: http://skia.googlecode.com/svn/trunk@12518
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 5 Dec 2013 18:45:18 +0000 (18:45 +0000)]
expectations/gm/ignored-tests.txt: add links to tracking bugs
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/
106643003
git-svn-id: http://skia.googlecode.com/svn/trunk@12516
2bbb7eff-a529-9590-31e7-
b0007b416f81
halcanary@google.com [Thu, 5 Dec 2013 18:31:42 +0000 (18:31 +0000)]
Big Cleanup: SkBitmapFactory, SkLazyPixelRef, SkImageCache
Removed SkBitmapFactory since no clients were using it. New cache
selection mechanism can simply pass a SkDiscardableMemory::Factory
into the SkDiscardablePixelRef if non-default SkDiscardableMemory
should be used. Removed BitmapFactoryTest.
SkDiscardableMemory::Factory interface. Android will need this
functionality in the future inside their BitmapFactory.
Removed SkLazyPixelRef, since it's functionality is now subsumed into
SkDiscardablePixelRef. Removed LazyPixelRef test.
Modified SkDiscardablePixelRef to optionally allow it to use a
SkDiscardableMemory::Factory. This tiny change makes it a replacement
for SkLazyPixelRef. This functioanlity is also necessary for moving
Android over to SkDiscardablePixelRef from SkImageRef in a later CL.
Added a test for this.
SkDecodingImageGenerator::Install can optionally pass a factory in to
SkDiscardablePixelRef.
Removed SkImageCache, SkLruImageCache, and SkPurgeableImageCache.
This functionality can be handled much more cleanly by
SkDiscardableMemory.
New SkDiscardableMemoryPool class to replace SkLruImageCache. In a
later CL, we will replace SkImageRef_GlobalPool (used by android) as
well. This is a concrete implementation of
SkDiscardableMemory::Factory. Added a test for this.
modified gm/factory.cpp to remove dependnce on SkBitmapFactory +
SkLruImageCache. Now uses SkDecodingImageGenerator +
SkDiscardablePixelRef + SkDiscardableMemoryPool.
SkImageDecoder::Target replaces SkBitmapFactory::Target. The
DecodeMemoryToTarget function may disappear in the future.
Moved SkLazyCachingPixelRef::DecodeProc replaces
SkBitmapFactory::DecodeProc. This is a short term change, since
another CL changes SkLazyCachingPixelRef to use SkImageGenerator
instead of DecodeProc.
Modified DrawBitmapRectTest to use SkDiscardablePixelRef instead of
SkLazyPixelRef.
tools/LazyDecodeBitmap.cpp now uses SkDecodingImageGenerator +
SkDiscardablePixelRef instead of a SkBitmapFactory.
bench_pictures uses the Global SkDiscardableMemoryPool instead of a
global gLruImageCache.
R=reed@google.com, scroggo@google.com
Review URL: https://codereview.chromium.org/
103033002
git-svn-id: http://skia.googlecode.com/svn/trunk@12515
2bbb7eff-a529-9590-31e7-
b0007b416f81
jvanverth@google.com [Thu, 5 Dec 2013 18:12:47 +0000 (18:12 +0000)]
One last rebaseline (I hope)
git-svn-id: http://skia.googlecode.com/svn/trunk@12514
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Thu, 5 Dec 2013 18:03:24 +0000 (18:03 +0000)]
rebaseline_server: add "deep linking" to allow bookmarking of particular views
(SkipBuildbotRuns)
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/
104623003
git-svn-id: http://skia.googlecode.com/svn/trunk@12513
2bbb7eff-a529-9590-31e7-
b0007b416f81
projects / platform / upstream / libSkiaSharp.git / log