platform/upstream/v8.git
13 years agoChange threshold for using ComplexIndexOf (using Boyer-Moore string
sandholm@chromium.org [Wed, 8 Sep 2010 12:57:50 +0000 (12:57 +0000)]
Change threshold for using ComplexIndexOf (using Boyer-Moore string
search) from 5 to 7.
Review URL: http://codereview.chromium.org/3294016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoStore pattern.length() in a local.
sandholm@chromium.org [Wed, 8 Sep 2010 11:05:54 +0000 (11:05 +0000)]
Store pattern.length() in a local.
Review URL: http://codereview.chromium.org/3300020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoDon't generate preparse data if lazy-flag is false.
lrn@chromium.org [Wed, 8 Sep 2010 10:33:15 +0000 (10:33 +0000)]
Don't generate preparse data if lazy-flag is false.

Review URL: http://codereview.chromium.org/3304012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPrepare push of version 2.4.2 to trunk.
ager@chromium.org [Wed, 8 Sep 2010 06:20:09 +0000 (06:20 +0000)]
Prepare push of version 2.4.2 to trunk.
Review URL: http://codereview.chromium.org/3324010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5424 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoMove stack check below while statement.
podivilov@chromium.org [Tue, 7 Sep 2010 15:34:16 +0000 (15:34 +0000)]
Move stack check below while statement.

Call to Runtime_StackGuard should be generated after loop body.
Otherwise, break position will be the previous position before
loop statement.

Review URL: http://codereview.chromium.org/3302012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5423 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAvoid pushing arguments twice in GenericBinaryOpStub.
kaznacheev@chromium.org [Tue, 7 Sep 2010 13:33:40 +0000 (13:33 +0000)]
Avoid pushing arguments twice in GenericBinaryOpStub.

Under some conditions (ADD, non-number arguments passed in registers)
GenerateRegisterArgumentsPush was called twice and the stack broke.

Review URL: http://codereview.chromium.org/3290012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAvoid (some) symbol lookups at parse time if preparse data is available.
lrn@chromium.org [Tue, 7 Sep 2010 12:52:16 +0000 (12:52 +0000)]
Avoid (some) symbol lookups at parse time if preparse data is available.

Review URL: http://codereview.chromium.org/3308010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemoving a wrong check.
serya@chromium.org [Tue, 7 Sep 2010 11:32:20 +0000 (11:32 +0000)]
Removing a wrong check.

A strings which represents an array index with length 8 and 9 digits do not pass this check. However generated hash is valid.

Review URL: http://codereview.chromium.org/3295017

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix the ambigous Operand(0) for newer C++ compilers.
whesse@chromium.org [Tue, 7 Sep 2010 11:09:45 +0000 (11:09 +0000)]
Fix the ambigous Operand(0) for newer C++ compilers.
Review URL: http://codereview.chromium.org/3351010/show
Committed for Thiago Farina <tfarina@chromium.org>

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoEnsure that empty descriptor array is marked before visiting any maps in marking...
vegorov@chromium.org [Tue, 7 Sep 2010 09:15:15 +0000 (09:15 +0000)]
Ensure that empty descriptor array is marked before visiting any maps in marking phase.

Review URL: http://codereview.chromium.org/3318014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5416 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd test for calls to native runtime functions in extensions.
whesse@chromium.org [Mon, 6 Sep 2010 12:54:41 +0000 (12:54 +0000)]
Add test for calls to native runtime functions in extensions.
Review URL: http://codereview.chromium.org/3356007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5415 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoTurn visitor_id into a byte field and free back one word in Map.
vitalyr@chromium.org [Mon, 6 Sep 2010 12:50:11 +0000 (12:50 +0000)]
Turn visitor_id into a byte field and free back one word in Map.

Review URL: http://codereview.chromium.org/3364007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPrepare push to trunk. Now working on version 2.4.2.
kmillikin@chromium.org [Mon, 6 Sep 2010 11:31:07 +0000 (11:31 +0000)]
Prepare push to trunk. Now working on version 2.4.2.

Review URL: http://codereview.chromium.org/3305012

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoImprove performance of Error.stack when stack contains local functions.
sgjesse@chromium.org [Mon, 6 Sep 2010 09:10:11 +0000 (09:10 +0000)]
Improve performance of Error.stack when stack contains local functions.

BUG=http://crbug.com/53303
TEST=Use the test case attached in the bug report.

Patch by Xianzhu Wang <wangxianzhu@google.com>

Review URL: http://codereview.chromium.org/3167042

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd and use AsciiAlphaToLower. Move RemoveLast test. Add Clear test. This is a...
erik.corry@gmail.com [Fri, 3 Sep 2010 12:59:52 +0000 (12:59 +0000)]
Add and use AsciiAlphaToLower.  Move RemoveLast test.  Add Clear test. This is a commit of codereview.chromium.org/3307003/show http://codereview.chromium.org/3312007/show and http://codereview.chromium.org/3341002/show for tfarina

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix compilation on 64-bit Windows (a third try)
sgjesse@chromium.org [Fri, 3 Sep 2010 12:56:08 +0000 (12:56 +0000)]
Fix compilation on 64-bit Windows (a third try)
Review URL: http://codereview.chromium.org/3295014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix compilation on 64-bit Windows (a second try)
sgjesse@chromium.org [Fri, 3 Sep 2010 12:31:43 +0000 (12:31 +0000)]
Fix compilation on 64-bit Windows (a second try)

TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3290009

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoHandle argument conversion in StringAddStub.
vitalyr@chromium.org [Fri, 3 Sep 2010 12:10:44 +0000 (12:10 +0000)]
Handle argument conversion in StringAddStub.

In case one of the arguments is known to be a string we emit a few
fast conversion attempts for the other.  This allows using the
StringAddStub instead of STRING_ADD_{LEFT,RIGHT} builtins.

Review URL: http://codereview.chromium.org/3338007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix compilation on 64-bit Windows
sgjesse@chromium.org [Fri, 3 Sep 2010 12:00:05 +0000 (12:00 +0000)]
Fix compilation on 64-bit Windows

TBR=pmehta@chromium.org
Review URL: http://codereview.chromium.org/3333015

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd API callback for tracking allocated memory
sgjesse@chromium.org [Fri, 3 Sep 2010 11:31:58 +0000 (11:31 +0000)]
Add API callback for tracking allocated memory

Allows the host application to provide a mechanism for notification and custom logging through a callback (set through the API V8::AddMemoryAllocationCallback and removed through V8::RemoveMemoryAllocationCallback), when V8 allocates ro frees memory.

This replaces the current histogram data "V8.ExecutableMemoryMax" by allowing usage data to be logged by the application as required rather than always through V8.

BUG=http://crbug.com/54222
TEST=Set the callback function with the API and cause V8 to allocate memory.

Patch by Paul Mehta <pmehta@chromium.org>

Review URL: http://codereview.chromium.org/3329006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoClang compatibility changes. This is a commit of http://codereview.chromium.org...
erik.corry@gmail.com [Thu, 2 Sep 2010 10:18:44 +0000 (10:18 +0000)]
Clang compatibility changes.  This is a commit of codereview.chromium.org/3364002 for coldredlemur

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoARM: Handle bitwise operations with literal Smi for 32bits integers without calling...
erik.corry@gmail.com [Thu, 2 Sep 2010 08:30:52 +0000 (08:30 +0000)]
ARM: Handle bitwise operations with literal Smi for 32bits integers without calling the GenericBinaryOpStub.  Refactored and updated the routine to convert a signed int to a double.  This is a commit of codereview.chromium.org/3247008 for Rodolph Perfetta.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5401 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix parsing of /**/--> on first line of input.
lrn@chromium.org [Thu, 2 Sep 2010 07:36:30 +0000 (07:36 +0000)]
Fix parsing of /**/--> on first line of input.

BUG=53548
TEST=

Review URL: http://codereview.chromium.org/3330001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5400 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix bug in JSON character quote table.
lrn@chromium.org [Thu, 2 Sep 2010 07:35:35 +0000 (07:35 +0000)]
Fix bug in JSON character quote table.

Review URL: http://codereview.chromium.org/3349006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoMake JSON.stringify not quote non-ASCII characters. Fix bug 855.
lrn@chromium.org [Thu, 2 Sep 2010 07:09:28 +0000 (07:09 +0000)]
Make JSON.stringify not quote non-ASCII characters. Fix bug 855.

Review URL: http://codereview.chromium.org/3336001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoia32 StringAddStub: fast two character case.
vitalyr@chromium.org [Wed, 1 Sep 2010 17:20:36 +0000 (17:20 +0000)]
ia32 StringAddStub: fast two character case.

Review URL: http://codereview.chromium.org/3327001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoDon't access PagedSpace::executability after the object has been destroyed
yurys@chromium.org [Wed, 1 Sep 2010 17:01:58 +0000 (17:01 +0000)]
Don't access PagedSpace::executability after the object has been destroyed

Review URL: http://codereview.chromium.org/3344001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in test...
whesse@chromium.org [Wed, 1 Sep 2010 13:13:31 +0000 (13:13 +0000)]
Remove CodeGenerator::PatchInlineRuntimeEntry and replace its single use in test-log-stack-tracer.cc with an alternative implementation.
Review URL: http://codereview.chromium.org/3311002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix memory overrun possibility during tick samples processing.
mikhail.naganov@gmail.com [Wed, 1 Sep 2010 13:08:39 +0000 (13:08 +0000)]
Fix memory overrun possibility during tick samples processing.

This really can cause crash described in crbug/51919.

BUG=51919
TEST=NONE

Review URL: http://codereview.chromium.org/3334001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoInitialize all VariableProxy fields in its constructor
yurys@chromium.org [Wed, 1 Sep 2010 12:25:46 +0000 (12:25 +0000)]
Initialize all VariableProxy fields in its constructor
Review URL: http://codereview.chromium.org/3330002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPrepare push of version 2.4.0 to trunk. Now working on version 2.4.1.
ricow@chromium.org [Wed, 1 Sep 2010 06:37:49 +0000 (06:37 +0000)]
Prepare push of version 2.4.0 to trunk. Now working on version 2.4.1.

Review URL: http://codereview.chromium.org/3303002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoCPU profiler: limit the number of simultaneously collected profiles.
mikhail.naganov@gmail.com [Tue, 31 Aug 2010 14:16:01 +0000 (14:16 +0000)]
CPU profiler: limit the number of simultaneously collected profiles.

This is related to Chromium issue 51919

BUG=51919
TEST=test-profile-generator/Issue51919

Review URL: http://codereview.chromium.org/3287005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5384 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix win64 compilation (using static_cast)
ricow@chromium.org [Tue, 31 Aug 2010 12:20:22 +0000 (12:20 +0000)]
Fix win64 compilation (using static_cast)

Review URL: http://codereview.chromium.org/3225011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5383 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoSimplify Array.splice by simply returning the result of AllocateEmptyJSArray.
ricow@chromium.org [Tue, 31 Aug 2010 10:39:12 +0000 (10:39 +0000)]
Simplify Array.splice by simply returning the result of AllocateEmptyJSArray.

Review URL: http://codereview.chromium.org/3216014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove assertion that is no longer valid in InitializeStringSearch.
ricow@chromium.org [Tue, 31 Aug 2010 10:39:02 +0000 (10:39 +0000)]
Remove assertion that is no longer valid in InitializeStringSearch.

This assertion is no longer valid because r5380 changes the assumption
about the pat parameter.

In addition, we embed the no allocation part of StringSplit in a block
to reenable allocation later in that method.

Review URL: http://codereview.chromium.org/3254010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoSimplify code by removing special-casing for single-character patterns
sandholm@chromium.org [Tue, 31 Aug 2010 09:22:53 +0000 (09:22 +0000)]
Simplify code by removing special-casing for single-character patterns
Review URL: http://codereview.chromium.org/3276004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoGet gcc to check that we don't ignore return values of functions that can
erik.corry@gmail.com [Tue, 31 Aug 2010 08:05:42 +0000 (08:05 +0000)]
Get gcc to check that we don't ignore return values of functions that can
fail to allocate because we need a GC.
Review URL: http://codereview.chromium.org/3274008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAddress some issues with detecting the architecture. See
erik.corry@gmail.com [Tue, 31 Aug 2010 08:05:33 +0000 (08:05 +0000)]
Address some issues with detecting the architecture.  See
http://code.google.com/p/v8/issues/detail?id=429
Review URL: http://codereview.chromium.org/3261003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix mozilla and debug check failures.
ricow@chromium.org [Tue, 31 Aug 2010 07:31:25 +0000 (07:31 +0000)]
Fix mozilla and debug check failures.

This removes the expected failure of a mozilla test that we now pass
(an empty array is returned if Array.splice is called with no
arguments) and fixes debug check failure by allocating a new empty
array using AllocateEmptyArray if splice is called with zero arguments
(makes sure we can always create a handle).

Review URL: http://codereview.chromium.org/3218010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFollow Safari and Firefox in returning empty array from array splice
ager@chromium.org [Mon, 30 Aug 2010 18:08:50 +0000 (18:08 +0000)]
Follow Safari and Firefox in returning empty array from array splice
with no arguments.

Review URL: http://codereview.chromium.org/3277005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoSet the code pointer when compiling a function.
vitalyr@chromium.org [Mon, 30 Aug 2010 13:39:07 +0000 (13:39 +0000)]
Set the code pointer when compiling a function.

Without this fix LazyCompile has to be called twice to set it.

Review URL: http://codereview.chromium.org/3253003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix a error in SamplingCircularQueue found using Valgrind memcheck.
mikhail.naganov@gmail.com [Mon, 30 Aug 2010 13:30:54 +0000 (13:30 +0000)]
Fix a error in SamplingCircularQueue found using Valgrind memcheck.

Review URL: http://codereview.chromium.org/3251004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoForce relinking of paged space if first attempt to recommit from space fails.
antonm@chromium.org [Mon, 30 Aug 2010 12:34:32 +0000 (12:34 +0000)]
Force relinking of paged space if first attempt to recommit from space fails.

That could improve chances for commit success as currently,
if we moved free pages out of order, we cannot shrink spaces.
However, when we experience problems commiting from space back, we should
use most of resources at our disposal.

Also get rid of currently unused parameter to DeallocateFunction.

Review URL: http://codereview.chromium.org/3260001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd os_error stat to oom_dump utility.
antonm@chromium.org [Mon, 30 Aug 2010 12:26:58 +0000 (12:26 +0000)]
Add os_error stat to oom_dump utility.

Review URL: http://codereview.chromium.org/3150028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove dependence of code-stubs on codegen, the virtual frame code generator. Move...
whesse@chromium.org [Mon, 30 Aug 2010 11:48:07 +0000 (11:48 +0000)]
Remove dependence of code-stubs on codegen, the virtual frame code generator.  Move some functions used by code-stubs and full-codegen from codegen to macro-assembler.
Review URL: http://codereview.chromium.org/3169049

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd functionality for finding code objects from a pc that points into
ricow@chromium.org [Mon, 30 Aug 2010 08:54:43 +0000 (08:54 +0000)]
Add functionality for finding code objects from a pc that points into
the code object's instructions.

This allows us to find a code object using just the pc. This approach
uses a cache (PcToCodeCache) to make sure we don't continuously have
to iterate heap pages.

This change eliminates the need for cooking and uncooking of stack frames.

Review URL: http://codereview.chromium.org/3226014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5369 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoImprove header file inclusions. Drop some unneeded includes, and add some needed...
whesse@chromium.org [Mon, 30 Aug 2010 07:10:40 +0000 (07:10 +0000)]
Improve header file inclusions.  Drop some unneeded includes, and add some needed ones.
Review URL: http://codereview.chromium.org/3253001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix regress-851.js to use assertNull instead of assertFalse.
vegorov@chromium.org [Fri, 27 Aug 2010 13:23:14 +0000 (13:23 +0000)]
Fix regress-851.js to use assertNull instead of assertFalse.
Review URL: http://codereview.chromium.org/3232002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoCheck result of JSObject::NormalizeElements() in JSObject::PreventExtensions().
vegorov@chromium.org [Fri, 27 Aug 2010 13:06:50 +0000 (13:06 +0000)]
Check result of JSObject::NormalizeElements() in JSObject::PreventExtensions().

Normalization requires allocation so Failure object can be returned.

BUG=http://code.google.com/p/v8/issues/detail?id=851
TEST=test/mjsunit/regress/regress-851.js

Review URL: http://codereview.chromium.org/3262001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5364 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFixing build error r5362 (adding missing files).
serya@chromium.org [Fri, 27 Aug 2010 12:16:00 +0000 (12:16 +0000)]
Fixing build error r5362 (adding missing files).

Review URL: http://codereview.chromium.org/3258001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5363 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoUsing array index hash code for string-to-number conversion.
serya@chromium.org [Fri, 27 Aug 2010 11:47:12 +0000 (11:47 +0000)]
Using array index hash code for string-to-number conversion.
Review URL: http://codereview.chromium.org/3141022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5362 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoReordered function entries in PreParse data to be ordered by start position.
lrn@chromium.org [Fri, 27 Aug 2010 08:26:29 +0000 (08:26 +0000)]
Reordered function entries in PreParse data to be ordered by start position.
Also add skip to entry, to skip pre-data for the body of the function.
Preparser data is now only accessed linearly, in the same order it was created.

Review URL: http://codereview.chromium.org/3185026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5361 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix presumbit errors in previous commit
sgjesse@chromium.org [Fri, 27 Aug 2010 07:41:46 +0000 (07:41 +0000)]
Fix presumbit errors in previous commit

TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/3249001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5360 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd file missing from last commit.
sgjesse@chromium.org [Fri, 27 Aug 2010 07:26:35 +0000 (07:26 +0000)]
Add file missing from last commit.

TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/3248001

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoCleanup the way the debugger stores live registers when entering at a break
sgjesse@chromium.org [Fri, 27 Aug 2010 07:08:03 +0000 (07:08 +0000)]
Cleanup the way the debugger stores live registers when entering at a break

The live registers are now only stored to the expression stack with the non pointer values being stored as smis (on the 32-bit platforms these values are assumed to be 31-bit max).

This makes the CEntryStub entry/exit code much simpler, and there is no longer any need for a mode (debug or normal) on it.

Fix a missing live register when breaking at ARM keyed load.
Review URL: http://codereview.chromium.org/3141047

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFast string construct stub (ia32 only for now).
vitalyr@chromium.org [Thu, 26 Aug 2010 13:59:37 +0000 (13:59 +0000)]
Fast string construct stub (ia32 only for now).

Review URL: http://codereview.chromium.org/3211002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5357 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix indention in v8natives.js - no functionality change.
ricow@chromium.org [Thu, 26 Aug 2010 13:03:17 +0000 (13:03 +0000)]
Fix indention in v8natives.js - no functionality change.
Review URL: http://codereview.chromium.org/3110041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5354 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoTemporarily disable test-heap-profiler/HeapSnapshotsDiff until the test is fixed...
ricow@chromium.org [Thu, 26 Aug 2010 09:27:14 +0000 (09:27 +0000)]
Temporarily disable test-heap-profiler/HeapSnapshotsDiff until the test is fixed (issue 848)

Review URL: http://codereview.chromium.org/3209005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5353 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix incorrect encoding of single and double precision registers for some VFP instruct...
erik.corry@gmail.com [Thu, 26 Aug 2010 08:53:00 +0000 (08:53 +0000)]
Fix incorrect encoding of single and double precision registers for some VFP instructions. Also fix incorrect disassembling of vldr/vstr.  This is a commit of codereview.chromium.org/3107027 for Rodolph Perfetta.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5352 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd inlining of binary smi operations in the full codegens on IA32
kasperl@chromium.org [Thu, 26 Aug 2010 08:50:38 +0000 (08:50 +0000)]
Add inlining of binary smi operations in the full codegens on IA32
and x64 (on IA32 we even fold constants into the instructions for
a more compact representation) and prepare the ARM full codegen for
the doing the same there.
Review URL: http://codereview.chromium.org/3195028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFixes bug in Object.freeze and Object.seal causing them to misbehave when Array.proto...
ricow@chromium.org [Thu, 26 Aug 2010 08:35:49 +0000 (08:35 +0000)]
Fixes bug in Object.freeze and Object.seal causing them to misbehave when Array.prototype has changed.

Object.freeze and Object.seal uses GetOwnPropertyNames which
returns an array with local property names. This array will also have
the additional properties defined on Array.prototype or
Object.prototype.

Note that, the implementation of GetOwnPropertyNames (when used as
Object.getOwnPropertyNames) is correct, since the spec says to create
a new Array (which would also have these properties).

Review URL: http://codereview.chromium.org/3137041

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5350 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoExplicitly set expected number of properties for instances of builtin types.
vitalyr@chromium.org [Wed, 25 Aug 2010 17:50:37 +0000 (17:50 +0000)]
Explicitly set expected number of properties for instances of builtin types.

We used to inherit an estimate on the expected number of properties in
%SetCode. It is not accurate and does not help for the types where
adding custom properties is rare (String, Date, etc.).

Review URL: http://codereview.chromium.org/3191026

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5348 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPrepare push of version 2.3.11 to trunk. Now working on version 2.4.0
ricow@chromium.org [Wed, 25 Aug 2010 15:02:07 +0000 (15:02 +0000)]
Prepare push of version 2.3.11 to trunk. Now working on version 2.4.0

This includes the ChangeLog part from the last push to trunk, since
the "prepare push to trunk" cl for that push was never committed.

Review URL: http://codereview.chromium.org/3111034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5344 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPrepare for optionally inlining smi cases in the code generated
kasperl@chromium.org [Wed, 25 Aug 2010 14:22:03 +0000 (14:22 +0000)]
Prepare for optionally inlining smi cases in the code generated
by the full codegens.
Review URL: http://codereview.chromium.org/3116042

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5343 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoReapplying r5147 (caching maps for slow case objects).
kaznacheev@chromium.org [Wed, 25 Aug 2010 13:25:54 +0000 (13:25 +0000)]
Reapplying r5147 (caching maps for slow case objects).

r5147 wrongly assumed that a code cache for a slow case map is always empty.
This patch solves this: whenever we attempt to add a stub to a map's code cache
we check that this map is cached. If it is we give the object its own copy
of the map and only then modify the map.

Review URL: http://codereview.chromium.org/3134027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5342 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoChange code contains function to allow a return address just after the last instruction
sgjesse@chromium.org [Wed, 25 Aug 2010 12:51:27 +0000 (12:51 +0000)]
Change code contains function to allow a return address just after the last instruction

Then patching the return sequence for debugger break at return a call is placed at the very end of the instruction stream causing the return address to be just after the actual instruction in the code object.
Review URL: http://codereview.chromium.org/3151037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5341 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoConvert this.length to uint32 in Array.prototype.[last]indexOf.
lrn@chromium.org [Wed, 25 Aug 2010 12:16:46 +0000 (12:16 +0000)]
Convert this.length to uint32 in Array.prototype.[last]indexOf.

Review URL: http://codereview.chromium.org/3104033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5340 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoStart using the overwrite mode from the full codegens to generate
kasperl@chromium.org [Wed, 25 Aug 2010 11:10:05 +0000 (11:10 +0000)]
Start using the overwrite mode from the full codegens to generate
slightly better code and allow passing arguments to binary op stubs
in registers on the platforms that support it.
Review URL: http://codereview.chromium.org/3203005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5339 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoMove code stub implementations from codegen-[platform].cc files to new code-stub...
whesse@chromium.org [Wed, 25 Aug 2010 09:44:44 +0000 (09:44 +0000)]
Move code stub implementations from codegen-[platform].cc files to new code-stub-[platform].cc files, and declarations to new code-stub-[platform].h files.
Remaining work is to do the same for platform-independent code stub declarations, and to remove all dependencies on codegen header files from code stub files.
Review URL: http://codereview.chromium.org/3195022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoImprove the code generated by the full codegen by keeping
kasperl@chromium.org [Wed, 25 Aug 2010 08:57:21 +0000 (08:57 +0000)]
Improve the code generated by the full codegen by keeping
track of the fall-through label and avoiding silly jumps.
Review URL: http://codereview.chromium.org/3166033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5337 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoHide test failure be being less GC agressive in the test
sgjesse@chromium.org [Wed, 25 Aug 2010 07:26:12 +0000 (07:26 +0000)]
Hide test failure be being less GC agressive in the test

This is a temporary fix until the root cause is resolved.

TBR=kasperl@chromium.org
Review URL: http://codereview.chromium.org/3122038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5336 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoSimplify the way constructors are called and avoid pushing
kasperl@chromium.org [Wed, 25 Aug 2010 07:18:32 +0000 (07:18 +0000)]
Simplify the way constructors are called and avoid pushing
a dummy receiver that we end up ignoring anyway.
Review URL: http://codereview.chromium.org/3136032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5335 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoUse collector for preparse data.
lrn@chromium.org [Wed, 25 Aug 2010 06:46:53 +0000 (06:46 +0000)]
Use collector for preparse data.

This is in preparation of adding more data to the preparse record.
Using a collector instead of a list avoids copying data when the backing
store grows.

Review URL: http://codereview.chromium.org/3153037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5334 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix a bug in the handling of debug break in CallIC
sgjesse@chromium.org [Wed, 25 Aug 2010 05:57:02 +0000 (05:57 +0000)]
Fix a bug in the handling of debug break in CallIC

The change of calling convention in the CallIC was not reflected in the debug break code. Without the change to the debug break code the added test crashed.
Review URL: http://codereview.chromium.org/3167037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5333 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoAdd position information for compares, binary ops, and count
kasperl@chromium.org [Tue, 24 Aug 2010 13:51:23 +0000 (13:51 +0000)]
Add position information for compares, binary ops, and count
operations.
Review URL: http://codereview.chromium.org/3120027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5332 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPorted string call IC-s to arm.
vitalyr@chromium.org [Tue, 24 Aug 2010 13:45:53 +0000 (13:45 +0000)]
Ported string call IC-s to arm.

Review URL: http://codereview.chromium.org/3143038

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5331 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoPorted string call IC-s to x64.
vitalyr@chromium.org [Tue, 24 Aug 2010 13:39:29 +0000 (13:39 +0000)]
Ported string call IC-s to x64.

Review URL: http://codereview.chromium.org/3156045

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5330 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRefactor the tools/test.py script and related testcfg.py files.
ricow@chromium.org [Tue, 24 Aug 2010 13:34:59 +0000 (13:34 +0000)]
Refactor the tools/test.py script and related testcfg.py files.

This makes it possible to run several variants of the tests (with different flags that is) by adding extra lists to the VARIANT_FLAGS list. In addition, there is a number of smaller refactorings.

Review URL: http://codereview.chromium.org/3164023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5329 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoIntroduce a new intermediate AST node for encapsulating the
kasperl@chromium.org [Tue, 24 Aug 2010 12:56:45 +0000 (12:56 +0000)]
Introduce a new intermediate AST node for encapsulating the
increment part of a count operation.
Review URL: http://codereview.chromium.org/3150032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5328 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoEnsure that scanner state is correctly reset when an error is encountered.
lrn@chromium.org [Tue, 24 Aug 2010 12:29:50 +0000 (12:29 +0000)]
Ensure that scanner state is correctly reset when an error is encountered.

Add a scope object to ensure that leaving a literal scanning prematurely
will clean up after itself.
Also reset the literal buffer if a scanner is reinitialized with a new
source code.

Review URL: http://codereview.chromium.org/3137037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5327 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoOptimize 'typeof <expr> == <string literal>' in the full codegen.
kasperl@chromium.org [Tue, 24 Aug 2010 11:41:26 +0000 (11:41 +0000)]
Optimize 'typeof <expr> == <string literal>' in the full codegen.
Review URL: http://codereview.chromium.org/3110034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5326 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoCreated collector class and used it to collect identifiers during scanning.
lrn@chromium.org [Tue, 24 Aug 2010 10:53:44 +0000 (10:53 +0000)]
Created collector class and used it to collect identifiers during scanning.

The collector class automatically expands to hold the values added to it,
like a List, but doesn't ensure that the backing store is contiguous, which
allows it to avoid copying back and forth as the buffer grows.

This is in preparation for identifyng identical symbols during preparsing.

Review URL: http://codereview.chromium.org/3181036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5325 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove the full codegen syntax checker completely but be
kasperl@chromium.org [Tue, 24 Aug 2010 09:04:17 +0000 (09:04 +0000)]
Remove the full codegen syntax checker completely but be
careful to avoid making code with loops run too slowly.
Review URL: http://codereview.chromium.org/3107033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5324 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoCleanup the AST code by removing unused parts and get rid of the
kasperl@chromium.org [Tue, 24 Aug 2010 07:26:49 +0000 (07:26 +0000)]
Cleanup the AST code by removing unused parts and get rid of the
flow graph code completely. Add new AST node for null compares
and use it to make the full codegens better at generating code
for null comparisons.
Review URL: http://codereview.chromium.org/3146037

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5323 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFixed remaining bugs in COW-regexp-results.
lrn@chromium.org [Mon, 23 Aug 2010 13:58:56 +0000 (13:58 +0000)]
Fixed remaining bugs in COW-regexp-results.

Review URL: http://codereview.chromium.org/3197011

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5322 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoMove the function name inferrer code from the AstOptimizer to
kasperl@chromium.org [Mon, 23 Aug 2010 13:26:03 +0000 (13:26 +0000)]
Move the function name inferrer code from the AstOptimizer to
the parser in preparation for not using the optimizer when
using the full codegen. Code covered by existing tests.
Review URL: http://codereview.chromium.org/3141034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoSimplified the full codegens by removing the Expression::kTestValue
kasperl@chromium.org [Mon, 23 Aug 2010 12:55:29 +0000 (12:55 +0000)]
Simplified the full codegens by removing the Expression::kTestValue
and Expression::kValueTest. At the same time, prepare the code for
keeping track of fall through labels to avoid unnecessary jumps.
Review URL: http://codereview.chromium.org/3152042

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5320 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoDon't do a smi check twice in the TO_INTEGER macro.
sandholm@chromium.org [Mon, 23 Aug 2010 11:46:59 +0000 (11:46 +0000)]
Don't do a smi check twice in the TO_INTEGER macro.
Review URL: http://codereview.chromium.org/3115024

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5319 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix bug in 64 bit codegen causing us to always go slowcase in apply.
ricow@chromium.org [Mon, 23 Aug 2010 11:21:09 +0000 (11:21 +0000)]
Fix bug in 64 bit codegen causing us to always go slowcase in apply.

After introducing the direct instruction pointer in functions the
CallApplyLazy method was changed on all platforms. The change made to
the 64 bit version was wrong, not using the right operand for the code
comparisons always forcing us into slow case.

Review URL: http://codereview.chromium.org/3104027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5317 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix an issue in the ARM port where a left shift was predicted to have a Smi result...
erik.corry@gmail.com [Mon, 23 Aug 2010 09:04:31 +0000 (09:04 +0000)]
Fix an issue in the ARM port where a left shift was predicted to have a Smi result when it had an int32 result.  This is a commit of codereview.chromium.org/3195004 for Rodolph Perfetta.  Part 2

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5316 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix an issue in the ARM port where a left shift was predicted to have a Smi result...
erik.corry@gmail.com [Mon, 23 Aug 2010 07:53:03 +0000 (07:53 +0000)]
Fix an issue in the ARM port where a left shift was predicted to have a Smi result when it had an int32 result.  This is a commit of codereview.chromium.org/3195004 for Rodolph Perfetta

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5315 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove the virtual declaration from a couple of non-virtual JumpTarget
ager@chromium.org [Mon, 23 Aug 2010 07:30:09 +0000 (07:30 +0000)]
Remove the virtual declaration from a couple of non-virtual JumpTarget
methods to avoid compiler warnings with some gcc versions.

Review URL: http://codereview.chromium.org/3170036

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5314 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix mismatched new[]/delete for external string resources only used
ager@chromium.org [Mon, 23 Aug 2010 06:30:00 +0000 (06:30 +0000)]
Fix mismatched new[]/delete for external string resources only used
for testing.

Review URL: http://codereview.chromium.org/3165051

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5313 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRe-enable test-api/RegExpInterruption on arm.
ricow@chromium.org [Fri, 20 Aug 2010 13:00:22 +0000 (13:00 +0000)]
Re-enable test-api/RegExpInterruption on arm.

This test has been disabled for a very long time, and the fix in
http://code.google.com/p/v8/source/detail?r=5308 should make this go
away.

I will watch the buildbot continuously over the next few days to make
sure it does not appear again. If it does not I will close bug 240.

Review URL: http://codereview.chromium.org/3127023

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5312 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoWe can use the array trim trick in old paged space as well as
erik.corry@gmail.com [Fri, 20 Aug 2010 12:38:33 +0000 (12:38 +0000)]
We can use the array trim trick in old paged space as well as
new space.
Review URL: http://codereview.chromium.org/3143032

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5311 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoUse Copy-on-write arrays for cached regexp results.
lrn@chromium.org [Fri, 20 Aug 2010 09:37:22 +0000 (09:37 +0000)]
Use Copy-on-write arrays for cached regexp results.

Review URL: http://codereview.chromium.org/3158020

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5310 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoChange code pointer in function objects to a pointer to the first
ricow@chromium.org [Fri, 20 Aug 2010 07:10:18 +0000 (07:10 +0000)]
Change code pointer in function objects to a pointer to the first
instruction.

By changing the pointer to the code object to a pointer to the first
instruction we can call directly this instruction directly instead of
looking up the address through the code object.

Review URL: http://codereview.chromium.org/3156028

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5309 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix local handle leak in RegExpStringModificationTest.
vitalyr@chromium.org [Thu, 19 Aug 2010 14:00:58 +0000 (14:00 +0000)]
Fix local handle leak in RegExpStringModificationTest.

Review URL: http://codereview.chromium.org/3133027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5308 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoRemove unused function.
vitalyr@chromium.org [Thu, 19 Aug 2010 13:28:28 +0000 (13:28 +0000)]
Remove unused function.

Review URL: http://codereview.chromium.org/3107022

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5307 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

13 years agoFix indentation in utils.h.
ager@chromium.org [Thu, 19 Aug 2010 08:49:26 +0000 (08:49 +0000)]
Fix indentation in utils.h.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5306 ce2b1a6d-e550-0410-aec6-3dcde31c8c00