Jan Vorlicek [Thu, 10 Nov 2016 01:28:29 +0000 (17:28 -0800)]
Fix missing exports in mscordaccore.so (#8058)
I have recently added some exports to the mscordaccore.so and it was
found that they were not honored and libsos.so got some unresolved
symbols.
I have found that the issue is that unlike for libcoreclr.so, we
were not asking linker to include the whole PAL and so it has
eliminated those functions due to the fact they were not called
from the PAL itself.
This change fixes it.
Roman Shchekin [Thu, 10 Nov 2016 00:06:40 +0000 (03:06 +0300)]
Memory growth algorithm improvement in coreconsole (#7870)
* Now Append will work properly if strLen is big (for example 3xm_capacity). And value 1.5 is better for memory growth.
* Correct way of calculating 1.5 (without floating point calculation, thanks mikedn)
* After long discussion we decided that simple and aggressive allocation is better for this case
Andy Ayers [Wed, 9 Nov 2016 23:03:23 +0000 (15:03 -0800)]
Inliner: enable inlining of methods with conditional throws (#8038)
* Inliner: enable inlining of methods with conditional throws
Remove inlining limitation for methods that return values and have
conditional throws. This limitation was most likely a vestige of an
older inlining implementation that did not break trees at inline
call sites.
Also removed the now-unused observation and the `seenConditionalJump`
member variable. Merged ifdef blocks in `impInit`.
Ran full desktop testing, no issues.
Enables a handful of inlines in the various code size suites. For the
most part these slightly increase code size but can often shorten the
non-EH paths in the code.
sandreenko [Wed, 9 Nov 2016 22:49:51 +0000 (14:49 -0800)]
Merge pull request #7981 from sandreenko/fix_vn_in_cse
Don't transform GT_SUB tree outside the global morph phase.
Russ Keldorph [Wed, 9 Nov 2016 21:25:23 +0000 (13:25 -0800)]
Merge pull request #8033 from RussKeldorph/nopopup
Disable GUI dialogs for assertion failures on Windows by default
Eric StJohn [Wed, 9 Nov 2016 20:15:06 +0000 (12:15 -0800)]
Merge pull request #8041 from ericstj/updateBuildTools
Update BuildToolsVersion to 01007-02
Sivarv [Wed, 9 Nov 2016 18:20:47 +0000 (10:20 -0800)]
Merge pull request #8049 from sivarv/lsraAssertFix
If the very first ref position of an interval has a register assignment of RBM_NONE indicate it could also be a regOptional
Russ Keldorph [Mon, 7 Nov 2016 22:40:14 +0000 (14:40 -0800)]
Disable GUI dialogs on Windows by default
This change disables creating pop-up dialog boxes by default on Windows
when assertions fail. The change consists of two pieces:
1) Make COMPlus_NoGuiOnAssert effective in Release builds (currently only
Debug/Checked builds)
2) Make DebuggerAssert::ShowDefaultAssertDialog honor the
COMPlus_NoGuiOnAssert variable.
3) Make COMPlus_NoGuiOnAssert=1 by default.
Note that COMPlus_NoGuiOnAssert was already honored for assertions
originating from native code such as the JIT. If pop-ups are desired,
one can still set COMPlus_NoGuiOnAssert=0.
Fixes #7678
Matt Mitchell [Wed, 9 Nov 2016 17:31:19 +0000 (09:31 -0800)]
Merge pull request #8022 from mmitche/disable-email-pub
Remove email publishing calls
Evgeny Pavlov [Wed, 9 Nov 2016 17:08:49 +0000 (20:08 +0300)]
[Linux][GDBJIT] Fix crashes related with locals debug info generation (#7874)
* [GDBJIT] Fix several issues related with generation debug info for locals:
* Fix crash on generics static
* Add support of pointer type
* Fix incorrect processing of classes when we have several locals with the same class type
* Move gdbjit.cpp from VM_SOURCES_DAC_AND_WKS_COMMON to VM_SOURCES_WKS
Eric St. John [Wed, 9 Nov 2016 16:48:31 +0000 (08:48 -0800)]
Fix IntermediateOutputPath for mscorlib facade
Previously we were working around this by using double backslash but
GenFacades broke this when adding response file support and double-
unescaping. Workaround using a forward slash instead.
Tarek Mahmoud Sayed [Wed, 9 Nov 2016 04:38:41 +0000 (20:38 -0800)]
Avoid failures when allocate memory in native (#8028)
* Avoid failures when allocate memory in native
using new in the native side can throw and the app will shutdown. instead we detect the failure and throw a managed exception
* Use same mechanism we return the error code from GetSortHandle
* Add assert
* Dispose the safeHandle
Stephen Toub [Wed, 9 Nov 2016 03:29:51 +0000 (22:29 -0500)]
Merge pull request #8043 from stephentoub/remove_delegate_alloc
Remove delegate allocation per ThreadPoolBoundHandleOverlapped
sivarv [Wed, 9 Nov 2016 02:08:31 +0000 (18:08 -0800)]
If the very first ref position of an interval has a register assignment of RBM_NONE indicate it could also be a regOptional
sandreenko [Tue, 8 Nov 2016 23:50:11 +0000 (15:50 -0800)]
Merge pull request #8040 from sandreenko/additional-commit-for-PR-8014
additional commit to PR 8014
Pat Gavlin [Tue, 8 Nov 2016 23:33:11 +0000 (15:33 -0800)]
Merge pull request #8023 from pgavlin/MoveAltJitCrossgen
Use the alt JIT for S.P.CoreLib if altjitcrossgen is specified and change crossgen to always pass USE_SSE2 to the JIT.
Bruce Forstall [Tue, 8 Nov 2016 22:13:14 +0000 (14:13 -0800)]
Merge pull request #8035 from hseok-oh/fix_7871
SuperPMI: Support GetHFAType for ARM32 hardFP
Stephen Toub [Tue, 8 Nov 2016 21:36:56 +0000 (16:36 -0500)]
Remove delegate allocation per ThreadPoolBoundHandleOverlapped
Eric St. John [Tue, 8 Nov 2016 20:51:42 +0000 (12:51 -0800)]
Update BuildToolsVersion to 01007-02
Faizur Rahman [Tue, 8 Nov 2016 20:50:52 +0000 (12:50 -0800)]
Merge pull request #8004 from shrah/master
Expose Marshal.CleanupUnusedObjectsInCurrentContext
Sergey Andreenko [Tue, 8 Nov 2016 20:41:45 +0000 (12:41 -0800)]
Revert Michal jit changes
Michal Strehovský [Tue, 8 Nov 2016 19:16:41 +0000 (11:16 -0800)]
Report CORINFO_FLG_CONTAINS_GC_PTR for TypedReference (#8014)
Faizur Rahman [Fri, 4 Nov 2016 21:50:02 +0000 (14:50 -0700)]
Expose Marshal.CleanupUnusedObjectsInCurrentContext
This change exposes Marshal.CleanupUnusedObjectsInCurrentContext. Also it a GetHINSTANCE implementation for non-windows platform by throwing
ArgumentNullException as per https://msdn.microsoft.com/en-us/library/system.runtime.interopservices.marshal.gethinstance(v=vs.110).aspx.
Igor Kulaychuk [Tue, 8 Nov 2016 16:24:08 +0000 (19:24 +0300)]
[Linux][GDB-JIT] Fix lldb stepping issues (#7777)
* Pass more info about source to native line mapping from SymbolReader
Pass mapping info for zero and HiddenLine line numbers.
Also supply ICorDebugInfo::SourceTypes info for each line.
Lines are reorganized to have ascending native addresses.
* Fix DWARF line info generation for negative line change
* Add prologue_end and epilogue_begin to DWARF line info
* Generate DWARF method description for each code range with PROLOG and EPILOG
* Map each called __thunk symbol as a separate section
Special .thunk sections from different methods may overlap which
prevent the debugger from correctly resolving symbols (__thunk_*)
from those sections.
Mapping each called __thunk symbol as a separate section (.thunk_#)
allows the debugger to resolve __thunk* symbols correctly.
The code for searching first valid line number of a method
now checks only line numbers. There is no need for additional
check of non-empty filename.
If no valid line number was found then do not generate debug info at all.
* Fix buffer overrun when generating ELF symbol name
* Fix memory leak when generating ELF symbol name
* Fix memory leak when NotifyGdb::MethodCompiled fails
Manage array of FunctionMember pointers with NewArrayHolder.
* Refactor counting number of ELF sections in GDBJIT
* Refactor building ELF section names and headers
* Refactor hardcoded ELF section indeces
* Refactor memory allocation for ELF section names
When currently allocated memory is not enough for next
section name, the memory is reallocated with some
extra amount which grows twice on each reallocation.
Hyeongseok Oh [Tue, 8 Nov 2016 04:37:08 +0000 (13:37 +0900)]
fix typo
Hyeongseok Oh [Tue, 8 Nov 2016 02:31:29 +0000 (11:31 +0900)]
Support GetHFAType in SuperPMI for ARM32 hardFP
Rama krishnan Raghupathy [Tue, 8 Nov 2016 00:42:06 +0000 (16:42 -0800)]
Merge pull request #7988 from ramarag/lockjson
Removing the copy of project.lock.json to bin folder
Jarret Shook [Mon, 7 Nov 2016 23:24:58 +0000 (15:24 -0800)]
Merge pull request #8026 from jashook/arm64_g_flag_multiregstructarg
Arm64 add missing G flag and possibly X flags
Carol Eidt [Mon, 7 Nov 2016 21:47:52 +0000 (13:47 -0800)]
Update testing-with-corefx.md
Clarify the way the `BUILDTOOLS_OVERRIDE_RUNTIME` option is passed.
jashook [Mon, 7 Nov 2016 21:06:20 +0000 (13:06 -0800)]
Arm64 add missing G flag and possibly X flags
For indirections created by morphing obj(16) make sure the G and
X flag are set.
Pat Gavlin [Mon, 7 Nov 2016 20:08:00 +0000 (12:08 -0800)]
Change crossgen to always pass USE_SSE2 to the JIT.
.NET Core and the RyuJIT x86/x64 backends require SSE2. Always pass this
flag to the JIT.
Sergey Andreenko [Thu, 3 Nov 2016 00:33:04 +0000 (17:33 -0700)]
Set VN argument for changeOper during morph.
Sivarv [Mon, 7 Nov 2016 19:17:41 +0000 (11:17 -0800)]
Merge pull request #8011 from sivarv/lsraFix
While unassigning a phyReg, establish association with a previous interval only if it is different from the one it is being unassigned
Matt Mitchell [Mon, 7 Nov 2016 19:07:49 +0000 (11:07 -0800)]
Remove email publishing calls
The new server's email plugin version has different syntax and the email publishing doesn't work currently anyway. Will be re-enabled at a future time
Pat Gavlin [Mon, 7 Nov 2016 19:01:53 +0000 (11:01 -0800)]
Use the alt JIT for S.P.CoreLib if altjitcrossgen is specified.
The check for altjitcrossgen was previously located s.t. only mscorlib
was being crossgen'd using the alt JIT (which is not very insteresting,
as mscorlib is just a facade these days). This change moves the check
back s.t. the alt JIT is also used for System.Private.CoreLib.
Pat Gavlin [Mon, 7 Nov 2016 18:55:24 +0000 (10:55 -0800)]
Merge pull request #8006 from pgavlin/VSO278369
Fix VN propagation for binops.
Jonghyun Park [Mon, 7 Nov 2016 18:04:39 +0000 (03:04 +0900)]
Enforces aligned access for Single/Double values (#7993)
Pat Gavlin [Mon, 7 Nov 2016 17:15:34 +0000 (09:15 -0800)]
Merge pull request #8007 from pgavlin/VSO284785
Add a regression test for VSO 284785.
Russ Keldorph [Mon, 7 Nov 2016 16:51:58 +0000 (08:51 -0800)]
Merge pull request #7949 from hqueue/arm/sizeof
Exclude six sizeof related tests from ARM
varocarbas [Sun, 6 Nov 2016 14:41:33 +0000 (15:41 +0100)]
Removal of the ansicurrSymbol variable. (#7999)
Stephen Toub [Sat, 5 Nov 2016 18:36:00 +0000 (14:36 -0400)]
Change default file permissions on Unix to 666 (#7995)
Alex Ghiondea [Sat, 5 Nov 2016 06:10:15 +0000 (23:10 -0700)]
Merge pull request #7985 from AlexGhiondea/ExposeMarshalAPI
Expose the Marshal APIs that use SecureString
Jan Vorlicek [Sat, 5 Nov 2016 04:05:51 +0000 (21:05 -0700)]
Remove more PAL functions (#8009)
This change removes the following PAL functions and their related PAL tests:
_i64tow
_itow
lstrcatW
lstrcpyW
wsprintfA
wsprintfW
lstrcpynW
The lstrcpynW was actually used in two functions in palrt and I have replaced it
with StringCchCopyNW.
The _i64tow and _itow were used as an implementation of the _i64tow_s and _itow_s.
Since these _s versions were also implemented in PAL for its internal purposes,
I have exposed them and got rid of the unsafe versions.
Russ Keldorph [Sat, 5 Nov 2016 03:43:07 +0000 (20:43 -0700)]
Move remaining NETCoreApp references from 1.0 to 1.1 (#8008)
This gets us down from "a zillion" warnings to just "a lot."
Related: #7626
sivarv [Sat, 5 Nov 2016 00:13:57 +0000 (17:13 -0700)]
While unassigning a phyReg, establish association with a previous interval
only if it is different from the one it is unassigned.
Pat Gavlin [Fri, 4 Nov 2016 22:34:24 +0000 (15:34 -0700)]
Fix VN propagation for binops.
When value numbering processes certain binary operators, it may attempt
to propagate the value number of one operand to the operator itself.
Unfortunately, this propagation was done irrespective of the type of the
operand, and therefore produced incorrect results when the type of the
operand did not match the type of the operator. This change only
performs this sort of propagation only when the types of the operator
and the operand agree.
Pat Gavlin [Fri, 4 Nov 2016 22:39:31 +0000 (15:39 -0700)]
Add a regression test for VSO 284785.
Just what it says on the tin.
Alex Ghiondea [Thu, 3 Nov 2016 23:45:49 +0000 (16:45 -0700)]
Expose the Marshal APIs that use SecureString
Joseph Tremoulet [Fri, 4 Nov 2016 21:54:51 +0000 (17:54 -0400)]
Merge pull request #7996 from JosephTremoulet/OptRepeat
Add JitOptRepeat debug config flags
Tarek Mahmoud Sayed [Fri, 4 Nov 2016 20:15:17 +0000 (13:15 -0700)]
make the returning of DTFI & NFI in CultureInfo atomic (#7998)
we got some cases when more than one thread trying to get DTFI or NFI from the shared current culture object which can result returning different instances.
Although the returning object contents will be exactly but it'll be better to return same instance as apps may assume that. also returning the same instance will help reduce reinitializing more deeper fields when get requested.
Joseph Tremoulet [Fri, 4 Nov 2016 19:11:57 +0000 (15:11 -0400)]
Merge pull request #7911 from JosephTremoulet/CloneExprsForUnroll
Clone exprs for unroll
Joseph Tremoulet [Fri, 14 Oct 2016 17:57:38 +0000 (13:57 -0400)]
Add unroller support to CloneBlockState
This helper is used by the loop cloner to copy a block's attributes and
statements. Expand it so it can also be used by the loop unroller:
- Accept var/val parameters to pass through to `gtCloneExpr` to
perform in-place substitutions
- When presented with an expression that `gtCloneExpr` can't clone,
return false rather than dereferencing null
Joseph Tremoulet [Wed, 26 Oct 2016 21:01:57 +0000 (17:01 -0400)]
Clear *_ASG_LHS flags in ResetOptAnnotations
This works around an apparent bug in SSA construction (GitHub issue #7846),
specifically `fgPerNodeLocalVarLiveness`, where heap uses are not
considered upwards-exposed if they follow a heap def in their block (which
is incorrect because the store and load are not necessarily must-alias).
In the non-repeat configuration, these flags are always cleared coming
into SSA construction, because `TreeRenameVariables` is the only thing
that sets them.
Joseph Tremoulet [Fri, 30 Sep 2016 19:14:10 +0000 (15:14 -0400)]
Reset EH pred cache in ResetOptAnnotations
The cache created in the first iteration may not be correct in the second.
It seems there is a more general problem with failure to invalidate this
cache (GitHub issue #7844), that this change is working around for the
optRepeat case.
Joseph Tremoulet [Wed, 28 Sep 2016 16:57:01 +0000 (12:57 -0400)]
Add JitOptRepeat debug config flags
Add flag JitOptRepeat that specifies a set of methods on which to
iteratively perform global optimizations multiple times, and flag
JitOptRepeatCount to set the number of iterations (default 2) to apply
when JitOptRepeat kicks in.
These flags are debug-only; they are intended to facilitate performing
experiments investigating optimization opportunities missed due to phase
ordering issues.
Joseph Tremoulet [Thu, 3 Nov 2016 15:50:05 +0000 (11:50 -0400)]
Clear defnums and post-order nums in fgResetForSsa
SSA construction will overwrite these annotations, but only for reachable
code. Clear the annotations in all code in `fgResetForSsa` so that
downstream analysis won't stumble over stale/invalid SSA annotations
in unreachable code.
Joseph Tremoulet [Fri, 30 Sep 2016 19:18:55 +0000 (15:18 -0400)]
Clear heap PerSsaData, heapSsaMap in fgResetForSsa
These need to be cleared for the same reasons as the locals' PerSsaData;
their omission seems to be a simple oversight.
Pat Gavlin [Fri, 4 Nov 2016 18:20:55 +0000 (11:20 -0700)]
Merge pull request #7983 from pgavlin/VSO284785
Fix int->long cast folding for 32-bit platforms.
Joseph Tremoulet [Wed, 19 Oct 2016 22:14:24 +0000 (18:14 -0400)]
Avoid clobbering FldSeq annotations in cloneExpr
The overload of cloneExpr that takes a variable number and value to
perform replacements is intended to be used by the loop unroller, which
runs between Morph (where FldSeq annotations are generated) and value
numbering (where FldSeq annotations are consumed). Update that codepath
to call `LabelIndex` when replacing a `GTF_VAR_ARR_INDEX` node, and to
avoid calling `gtFoldExpr` (which does not preserve these annotations).
Downstream constant folding should be capable of doing that optimization.
Joseph Tremoulet [Fri, 14 Oct 2016 17:34:45 +0000 (13:34 -0400)]
Do not replace assign LHS in gtCloneExpr
Split the var/val parameters into two sets -- one for the current level of
recursion, the other for deeper levels. Use this to suppress one level of
replacement when recursing to the LHS of an assign. This both avoids
creating nonsensical assign-to-immediate trees and allows replacing uses
of the given var while leaving defs in the code.
Andy Ayers [Fri, 4 Nov 2016 04:28:16 +0000 (21:28 -0700)]
Jit: fix regression in non-AVX SIMD codegen (#7989)
Vector codegen for dot product was inadvertenly altered in non-DEBUG
builds.
Closes #7977.
Alex Ghiondea [Fri, 4 Nov 2016 04:28:01 +0000 (21:28 -0700)]
Add the serialization ctor for CryptographicException to model.xml (#7974)
Joseph Tremoulet [Wed, 2 Nov 2016 15:46:06 +0000 (11:46 -0400)]
Fix check for float args under windows x64 remorph
When re-morphing, `argx` will not have the argument's type if the argument
has been moved to the late args list, so check the arg table entry
instead. The unix x64 codepath already had the correct code, so just
remove the ifdef.
Joseph Tremoulet [Thu, 3 Nov 2016 18:51:17 +0000 (14:51 -0400)]
Clear GTF_VAR_USEDEF when folding <op>= forms
The `GTF_VAR_USEDEF` flag is applied to the def of an expression like "x =
x + y". The `GTF_VAR_USEASG` flag is applied to the op1 of an expression
like "x += y". Update the code to clear the `GTF_VAR_USEDEF` flag (in
addition to setting the `GTF_VAR_USEASG` flag) when folding the former to
the latter.
Jan Kotas [Fri, 4 Nov 2016 03:35:50 +0000 (20:35 -0700)]
Merge pull request #7991 from dotnet/revert-7946-armci_crashed
Revert "ARM-CI : Use archived root-fs and run tests with --sequential option"
Jan Kotas [Fri, 4 Nov 2016 03:35:35 +0000 (20:35 -0700)]
Revert "ARM-CI : Use archived root-fs and run tests with --sequential option"
Jonghyun Park [Fri, 4 Nov 2016 02:43:24 +0000 (11:43 +0900)]
Do not use FP registers when soft-fp ABI is used (#7869)
Soft FP ABI enforces a return value to be passed via integer registers
even though it is of float/double type (which means that 'r0 ~ r4' should
be preseved even for functions that return a float/double value).
The current implementation of 'ArgIteratorTemplate<ARGITERATOR_BASE>::ComputeReturnFlags()' does
not consider this ABI difference, which makes 'CallDescrWorkerInternal'
function to preserve FP registers instead of 'r0 ~ r4' (and spoils
'r0/r1' during preservation), which leads to #7868.
This commit revises this function in order to fix #7868.
Sujin Kim [Fri, 4 Nov 2016 02:31:30 +0000 (11:31 +0900)]
ARM-CI : Use archived root-fs and run tests with --sequential option (#7946)
* ARM-CI : Use archived root-fs and run tests with --sequential option
To make sure the reason of test failure ramdomly( #6298 ),
We checked segmentation faults occurred from mounted rootfs and the multi thread processing.
So I changed root-fs to archived root-fs and run tests with --sequential option.
* change to original clang version
Bruce Forstall [Fri, 4 Nov 2016 00:58:29 +0000 (17:58 -0700)]
Fix JIT build host/target confusion (#7979)
Also, add RyuJIT to Windows ARM32 cross components build (as protojit.dll).
Jan Kotas [Fri, 4 Nov 2016 00:57:48 +0000 (17:57 -0700)]
Merge pull request #7978 from AlexGhiondea/RemoveSecureStringMarshal
The SecureStringMarshal type was an artifact of the layering we had i…
Jan Kotas [Fri, 4 Nov 2016 00:12:04 +0000 (17:12 -0700)]
Merge pull request #7982 from dotnet/revert-7677-StructOpts
Revert "Enable optimization of structs"
Rama Krishnan Raghupathy [Thu, 3 Nov 2016 23:58:09 +0000 (16:58 -0700)]
Removing the copy of project.lock.json to bin folder
Michelle McDaniel [Thu, 3 Nov 2016 23:38:26 +0000 (16:38 -0700)]
Merge pull request #7972 from adiaaida/storeShiftRotate32
Force store of lcl var for shift/rotate by 32
Rama krishnan Raghupathy [Thu, 3 Nov 2016 23:02:20 +0000 (16:02 -0700)]
Merge pull request #7965 from ramarag/GetType
Enabling Type.Getype with overloads for assembly and type resolvers
Rama krishnan Raghupathy [Thu, 3 Nov 2016 23:02:03 +0000 (16:02 -0700)]
Merge pull request #7945 from ramarag/MemoryFailPoint
Disabling checks in MemoryFailPoint for Xplat
Jan Kotas [Thu, 3 Nov 2016 22:33:08 +0000 (15:33 -0700)]
Revert "Enable optimization of structs"
Pat Gavlin [Thu, 3 Nov 2016 22:00:16 +0000 (15:00 -0700)]
Fix int->long cast folding for 32-bit platforms.
The RyuJIT frontend does not allow for the folding of an int->long cast
that is known to overflow into a throw outside of global morph. The
folding, however, was unconditionally changing the operand to the cast
from an integer constant to a long constant, which can change the
behavior of the cast. This rewrite is not necessary, so this change
simply removes it.
Rama Krishnan Raghupathy [Thu, 3 Nov 2016 19:05:56 +0000 (12:05 -0700)]
Enabling Type.GetType with overloads for assembly and type resolvers
Alex Ghiondea [Thu, 3 Nov 2016 21:09:32 +0000 (14:09 -0700)]
The SecureStringMarshal type was an artifact of the layering we had in CoreFx.
This type should not have been added to CoreCLR as part of the SecureString move.
Michelle McDaniel [Thu, 3 Nov 2016 16:13:06 +0000 (09:13 -0700)]
Force store of lcl var for shift/rotate by 32
In the shift/rotate by 32 case, we move the lo op into the high op. In the
shift case, we set the lo op to 0, in the rotate case, we are swapping lo
and hi, so we also move hi into lo. In the instance that we are reusing
the same lclvars, we need to explicitly store the ops that we are moving
so that we don't overwrite the vars before using them. This change
explicitly replaces the uses of the ops with lclvars so we don't overwrite
vars before finishing the swap.
sandreenko [Thu, 3 Nov 2016 20:58:25 +0000 (13:58 -0700)]
Merge pull request #7908 from sandreenko/fix_tail_call_in_R2R
Correct pattern check for tail calls
Vance Morrison [Thu, 3 Nov 2016 20:37:53 +0000 (13:37 -0700)]
Fix a issue where ETW was losing RCW and CCW in heap dumps. (#7971)
Basically our builk events for RCWs and CCWs were too big, causing ETW to reject them, and thus losing information.
However you have to have at least several hundred befor you have enough to force the problem.
Pat Gavlin [Thu, 3 Nov 2016 19:09:50 +0000 (12:09 -0700)]
Merge pull request #7958 from pgavlin/VSO280123
Make a few VN methods tolerant of NoVN.
John Chen [Thu, 3 Nov 2016 18:59:40 +0000 (11:59 -0700)]
Make CrossGen documentation up to date (#7973)
Sergey Andreenko [Mon, 31 Oct 2016 19:31:10 +0000 (12:31 -0700)]
Correct pattern check
sequense
localVariable = cast.int(call.small_type());
return localVaribale
is correct tail call pattern.
Pat Gavlin [Thu, 3 Nov 2016 17:35:28 +0000 (10:35 -0700)]
Merge pull request #7956 from pgavlin/VSO280110
Properly update block flags during branch opt.
Pat Gavlin [Thu, 3 Nov 2016 17:35:05 +0000 (10:35 -0700)]
Format code.
Pat Gavlin [Thu, 3 Nov 2016 17:29:57 +0000 (10:29 -0700)]
Merge pull request #7959 from pgavlin/VSO280116
Fix an assert condition in lowering.
Pat Gavlin [Thu, 3 Nov 2016 17:29:32 +0000 (10:29 -0700)]
Format code.
Andy Ayers [Thu, 3 Nov 2016 17:11:25 +0000 (10:11 -0700)]
Merge pull request #7968 from AndyAyersMS/CaptureNewObservations
Inliner: capture new observations
Stephen Toub [Thu, 3 Nov 2016 10:06:36 +0000 (06:06 -0400)]
Mark NonRandomizedStringEqualityComparer as serializable (#7966)
Andy Ayers [Tue, 1 Nov 2016 23:22:10 +0000 (16:22 -0700)]
Inliner: capture new observations
Rebase the DiscretionaryPolicy on the EnhancedLegacyPolicy, and
capture and report some of the new observations that have been added
recently.
This change adds a new HAS_GC_STRUCT observation in addition to the
more specific RARE_GC_STRUCT, so that the DiscretionaryPolicy can
be notified of GC struct locals and temps for all candidates, not
just ones invoked from rare call sites.
No changes in codegen.
Jonghyun Park [Thu, 3 Nov 2016 02:46:19 +0000 (11:46 +0900)]
Revises 'JitTimer::PrintCsvHeader' to use 'append' mode (#7073)
* Revises 'JitTimer::PrintCsvHeader' to use 'append' mode
The current implementation of 'JitTimer::PrintCsvHeader' opens a CSV
file with 'read' mode and re-opens it with 'write' mode if it is absent.
The current implementation has two problems:
First, "read" file pointer will be closed even if it is null,
which is reported in #7072.
Second, "write" file pointer will be leaked as there is no corresponding
fclose.
This commit rewrites 'JitTimer::PrintCsvHeader' to fix #7072.
varocarbas [Thu, 3 Nov 2016 02:33:46 +0000 (03:33 +0100)]
ParseNumber & related more efficient (#3163)
David Mason [Thu, 3 Nov 2016 02:23:18 +0000 (19:23 -0700)]
Merge pull request #7936 from vancem/EventSourceDisposeRace.11-01-16
Fix Deadlock associated with ETW commands happening during dispose.
Dmitry-Me [Thu, 3 Nov 2016 01:38:49 +0000 (04:38 +0300)]
Fix race condition (#7928)
chunseoklee [Wed, 2 Nov 2016 22:18:53 +0000 (07:18 +0900)]
Suppress SOS.NETCore.dll error msg in release mode (#6975)
Suppress error msg when running coreclr without
SOS.NETCore.dll in release mode
Pat Gavlin [Wed, 2 Nov 2016 21:52:58 +0000 (14:52 -0700)]
Fix an assert condition in lowering.
Tail calls via the tail call helper must live in GC-safe blocks. A block
is GC-safe if either it or all of its dominators are also GC-safe. If we
are not optimizing, we will not compute dominators, and will therfore
not mark blocks whose dominators are all GC-safe. When deciding whether
or not we need to make a block GC-safe during tail call morphing,
however, we allow a tail call in an unmarked block iff the entry block
is GC-safe, as the entry block trivially dominates every reachable
block. This change fixes an assert that was not allowing for a tail call
in a block that is not marked GC-safe where the entry block is marked
GC-safe.
Jonghyun Park [Wed, 2 Nov 2016 21:44:24 +0000 (06:44 +0900)]
Set pRetVal as NULL on error inside 'VIRTUALCommitMemory' (#7920)
Pat Gavlin [Wed, 2 Nov 2016 21:23:09 +0000 (14:23 -0700)]
Merge pull request #7917 from pgavlin/VSO280120
Fix VSO280120.