Philip Withnall [Mon, 13 Jun 2011 09:54:23 +0000 (10:54 +0100)]
Bug 650414 — Need better APIs to handle image data
Change AvatarDetails.avatar to have type LoadableIcon. By introducing
a libfolks-wide avatar cache, propagate this change to all the backends.
This breaks the API of AvatarDetails.
Closes: bgo#650414
Travis Reitter [Thu, 21 Jul 2011 14:46:38 +0000 (07:46 -0700)]
Add missing copyright/license notices to tests.
Travis Reitter [Wed, 20 Jul 2011 18:28:40 +0000 (11:28 -0700)]
Don't notify twice for EDS Persona nickname changes.
Closes: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Wed, 20 Jul 2011 18:28:12 +0000 (11:28 -0700)]
Return early when setting an Edsf.Persona attribute to its current value.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 20:16:08 +0000 (13:16 -0700)]
Allow Edsf.PersonaStore._set_*name() sname arg to be null.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 20:14:15 +0000 (13:14 -0700)]
Allow Edsf.PersonaStore._set_*avatar() avatar arg to be null.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Wed, 20 Jul 2011 18:29:57 +0000 (11:29 -0700)]
Make Folks.Utils public and add Gee structure equality checking.
Helps: bgo#655019 - Don't notify twice for nickname changes
Travis Reitter [Thu, 21 Jul 2011 16:41:58 +0000 (09:41 -0700)]
Update for
142f9b74: make Individual.calendar_event_id nullable
Travis Reitter [Wed, 20 Jul 2011 18:29:45 +0000 (11:29 -0700)]
Un-break the EDS PersonaStore test for groups.
Philip Withnall [Sun, 10 Jul 2011 18:52:03 +0000 (19:52 +0100)]
Make BirthdayDetails.calendar_event_id nullable
This includes expanding its documentation a little.
Philip Withnall [Sun, 10 Jul 2011 18:43:20 +0000 (19:43 +0100)]
Fix visibility of TrfPersona.postal_addresses setter
Philip Withnall [Sun, 10 Jul 2011 18:42:25 +0000 (19:42 +0100)]
Add a default implementation of TrfPersona.calendar_event_id
It was missing; it might as well return a sensible default value and not
allow setting of the value rather than doing nothing.
Philip Withnall [Sun, 10 Jul 2011 18:41:46 +0000 (19:41 +0100)]
Fix visibility of TpfPersona.avatar and SwfPersona.avatar setters
Philip Withnall [Sun, 10 Jul 2011 18:41:23 +0000 (19:41 +0100)]
Minor documentation fix for SwfPersona.avatar
Philip Withnall [Sun, 10 Jul 2011 18:38:16 +0000 (19:38 +0100)]
Bug 650422 — Add API for easily checking whether details are writeable
Add Persona.writeable_properties, listing the properties of that Persona
for which updated values will be stored. It's intended that the property
value will be constant for a given Persona subclass, but this isn't
guaranteed; it's possible that Persona subclasses may vary the value of
writeable-properties at run time in future.
Closes: bgo#650422
Tiffany Antopolski [Wed, 20 Jul 2011 13:48:01 +0000 (15:48 +0200)]
Minor style change in presence-details.vala
Moved left brace of enum from end of line
to start of next line to match Folks style.
Philip Withnall [Sun, 3 Jul 2011 19:38:29 +0000 (20:38 +0100)]
Bug 645549 — Add a way to get the individual from a persona
Add a Persona.individual property which is updated by
Individual._connect_to_persona() and ._disconnect_from_persona() as
appropriate, so should remain in lock-step with the Individual whose persona
set the Persona instance is currently in.
Closes: bgo#645549
Philip Withnall [Sun, 3 Jul 2011 19:18:33 +0000 (20:18 +0100)]
Ensure that all modifications of Individual.personas happen in _set_personas()
This ensures that signals are handled consistently, and the overall internal
state of the Individual is kept consistent. This probably also fixes the
implementation of store_removed signal handling for Individuals, which looked
rather broken.
Philip Withnall [Sun, 10 Jul 2011 17:44:31 +0000 (18:44 +0100)]
Fix the error domain of PersonaStore.remove_persona()
Philip Withnall [Sun, 10 Jul 2011 17:41:25 +0000 (18:41 +0100)]
Bug 652425 — Failure codes for removing personas needed in PersonaStoreError
Add PersonaStoreError.PERMISSION_DENIED and PersonaStoreError.REMOVE_FAILED,
which will be useful for the e-d-s backend.
Closes: bgo#652425
Philip Withnall [Sat, 25 Jun 2011 09:13:01 +0000 (10:13 +0100)]
Remove AliasDetails support from Trf.Persona
The persona's alias was being stored as its nickname. Since we want to make
nicknames writeable (bgo#652048) we have to store the nickname there
instead. There's no ontology for storing aliases, so AliasDetails support
has to be dropped.
Closes: bgo#652048 — Make Individual.nickname writeable
Travis Reitter [Tue, 19 Jul 2011 16:03:59 +0000 (09:03 -0700)]
Support nickname writability in the EDS backend.
Helps: bgo#652048 — Make Individual.nickname writeable
Philip Withnall [Sat, 25 Jun 2011 09:11:39 +0000 (10:11 +0100)]
Allow NameDetails.nickname to be writeable
Helps: bgo#652048 — Make Individual.nickname writeable
Travis Reitter [Mon, 18 Jul 2011 23:09:53 +0000 (16:09 -0700)]
Un-break parallel building the eds backend.
It would fail after a maintainer-clean or distclean with:
make[4]: *** No rule to make target `folks-eds.vapi', needed by `all-am'.
Stop.
make[4]: *** Waiting for unfinished jobs....
This is because we were setting VALAFLAGS, which was overriding the
definition from configure.ac and generally causing havok.
Travis Reitter [Mon, 18 Jul 2011 22:07:48 +0000 (15:07 -0700)]
Cut unreachable libsocialweb test code.
Philip Withnall [Wed, 13 Jul 2011 22:06:50 +0000 (23:06 +0100)]
eds: Add support for contact groups/categories
Philip Withnall [Wed, 13 Jul 2011 22:04:45 +0000 (23:04 +0100)]
eds: Mark read-only address books as non-addable-to and non-removable-from
Philip Withnall [Wed, 13 Jul 2011 22:02:52 +0000 (23:02 +0100)]
eds: Fix persona store removal in the Backend
Embarrassing typo.
Philip Withnall [Wed, 13 Jul 2011 22:01:55 +0000 (23:01 +0100)]
inspect: Don't print details of unprepared persona stores
We're not supposed to, and they're not very useful anyway. Instead, we now
print a message saying that the persona store is not prepared.
Philip Withnall [Wed, 13 Jul 2011 18:30:01 +0000 (19:30 +0100)]
eds: Fix linker warnings for the e-d-s backend tests
Philip Withnall [Wed, 13 Jul 2011 18:29:46 +0000 (19:29 +0100)]
eds: Fix a variable's visibility in the e-d-s Backend
This also takes the opportunity to s/addressbook/address book/ an environment
variable, since the official GNOME terminology is “address book” rather than
“addressbook”.
Philip Withnall [Wed, 13 Jul 2011 18:28:38 +0000 (19:28 +0100)]
eds: Tidy up the e-d-s Backend.unprepare() method
This makes sure we disconnect from all the right signals, and abstracts
adding and removing address books out into a single pair of methods.
Travis Reitter [Wed, 13 Jul 2011 00:01:36 +0000 (17:01 -0700)]
Update NEWS for bgo#654509.
Travis Reitter [Wed, 13 Jul 2011 00:00:08 +0000 (17:00 -0700)]
Bump required version of Vala (needed for EDS).
Closes: bgo#654509 - Folks master not building
Travis Reitter [Tue, 12 Jul 2011 21:59:08 +0000 (14:59 -0700)]
Set the backend name for the EDS backend.
Travis Reitter [Tue, 12 Jul 2011 21:56:09 +0000 (14:56 -0700)]
Tidy up EDS CLEANFILES.
Travis Reitter [Tue, 12 Jul 2011 21:50:26 +0000 (14:50 -0700)]
Re-locate the EDS headers.
This is related to bgo#649790 - Vala uses the wrong includes
Philip Withnall [Tue, 12 Jul 2011 19:23:47 +0000 (20:23 +0100)]
eds: Add source list change notification to the eds backend
This means that Edsf.PersonaStores can come and go at run time.
This also adds a little bit of debug output to the eds Backend.
Philip Withnall [Tue, 12 Jul 2011 19:23:22 +0000 (20:23 +0100)]
eds: Ensure that errors are thrown by Edsf.PersonaStore.prepare() properly
Raul Gutierrez Segales [Tue, 12 Jul 2011 18:00:00 +0000 (19:00 +0100)]
Add an EDS backend
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=638281
Travis Reitter [Thu, 7 Jul 2011 18:12:43 +0000 (11:12 -0700)]
Fix the valadoc string for FieldDetails.value.
Philip Withnall [Thu, 30 Jun 2011 17:55:41 +0000 (18:55 +0100)]
Bug 653746 — mismatch between hash and equals in Note
Ensure that Note instances compare equal iff their UIDs are equal (as well as
iff their contents are equal).
Closes: bgo#653746
Philip Withnall [Sat, 2 Jul 2011 19:43:21 +0000 (20:43 +0100)]
Re-add a dependency on dbus-glib for the Telepathy test library
Files in tests/lib/telepathy/contactlist/ still use dbus-glib, and have to
because they're also using telepathy-glib.
Travis Reitter [Thu, 30 Jun 2011 23:03:24 +0000 (16:03 -0700)]
Fix a typo in the IndividualAggregator.individuals_changed docs.
Travis Reitter [Fri, 24 Jun 2011 17:04:54 +0000 (10:04 -0700)]
Make valadoc a hard dependency when using --enable-docs
Closes: bgo#653325 — Build system does not complain if trying to build docs
without vala-doc installed
Philip Withnall [Mon, 13 Jun 2011 13:25:20 +0000 (14:25 +0100)]
Bug 652449 — Folks.Individual's property getters should be read only
Make the getters of container types in Folks.Individual return read-only
views of the containers.
Closes: bgo#652449
Travis Reitter [Fri, 24 Jun 2011 16:27:03 +0000 (09:27 -0700)]
Cut meaningless 'Tests' output from configure.
Travis Reitter [Fri, 24 Jun 2011 15:21:54 +0000 (08:21 -0700)]
Fix the configure output for docs.
Based upon a couple issues raised in bgo#653325
Philip Withnall [Wed, 15 Jun 2011 17:44:18 +0000 (18:44 +0100)]
Bug 652660 — Make Individual.id more stable and well-defined
Travis Reitter [Wed, 22 Jun 2011 23:05:58 +0000 (16:05 -0700)]
Don't make the folks-telepathy docs depend directly upon dbus-glib.
Closes: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Wed, 22 Jun 2011 22:46:28 +0000 (15:46 -0700)]
Don't make the Libsocialweb backend depend directly upon dbus-glib.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Wed, 22 Jun 2011 22:38:16 +0000 (15:38 -0700)]
Don't make the Telepathy tests depend directly upon dbus-glib.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Wed, 22 Jun 2011 20:41:15 +0000 (13:41 -0700)]
Handle both the dbus-glib and GDBus missing logger errors.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Wed, 22 Jun 2011 20:35:44 +0000 (13:35 -0700)]
Update Tp test backend suppression to match GDBus behavior.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 21 Jun 2011 23:31:18 +0000 (16:31 -0700)]
Cut unnecessary log message suppressions in the Aggregation test.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 21 Jun 2011 23:14:04 +0000 (16:14 -0700)]
Properly disconnect the logger::invalidated handler.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 7 Jun 2011 23:16:47 +0000 (16:16 -0700)]
Port Tpf.Logger to GDBus.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 7 Jun 2011 23:15:31 +0000 (16:15 -0700)]
Factor out Tpf.Logger.prepare() from its constructor.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Wed, 8 Jun 2011 15:39:28 +0000 (08:39 -0700)]
Use the GLib definition of Error instead of DBus.Error.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 7 Jun 2011 18:23:43 +0000 (11:23 -0700)]
Use the GLib definition for Object.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 7 Jun 2011 18:21:53 +0000 (11:21 -0700)]
Use the GLib definition for ObjectPath.
Helps: bgo#629716 - Migrate Folks to GDBus
Travis Reitter [Tue, 7 Jun 2011 18:16:21 +0000 (11:16 -0700)]
Don't build dbus-glib into Telepathy backend.
Helps: bgo#629716 - Migrate Folks to GDBus
Philip Withnall [Mon, 13 Jun 2011 16:20:34 +0000 (17:20 +0100)]
Bug 652472 — Handle failure in getting the logger service better
If we fail to get the logger from the bus, get_object() may return NULL. If
we check for this, we don't then try and connect a signal to a NULL object
instance and emit criticals.
Closes: bgo#652472
Travis Reitter [Wed, 22 Jun 2011 23:39:35 +0000 (16:39 -0700)]
Fix the link within the PresenceDetails.presence_status docs
Philip Withnall [Tue, 14 Jun 2011 14:21:29 +0000 (15:21 +0100)]
Bug 648071 — Add support for presence status from Telepathy
Add a presence_status property to PresenceDetails to expose the detailed
presence status string that Telepathy exposes.
Closes: bgo#648071
Travis Reitter [Tue, 21 Jun 2011 22:08:45 +0000 (15:08 -0700)]
Don't crash if a provided TpContact ID is NULL.
Travis Reitter [Tue, 21 Jun 2011 21:43:06 +0000 (14:43 -0700)]
Don't add null Personas in personas-changed signal arguments.
Travis Reitter [Tue, 21 Jun 2011 21:08:47 +0000 (14:08 -0700)]
Note closing of bgo#652434 — Add ability to run any tests through gdb
Closes: bgo#652434
Travis Reitter [Fri, 10 Jun 2011 17:39:27 +0000 (10:39 -0700)]
Add ability to run any of our tests through gdb
Run a test through gdb with:
make -C tests/<dir> <test name>.gdb
Travis Reitter [Fri, 17 Jun 2011 15:06:22 +0000 (16:06 +0100)]
Cut redundant EXTRA_DIST entry.
Travis Reitter [Fri, 17 Jun 2011 15:05:38 +0000 (16:05 +0100)]
More-cleanly define gir and vapi files.
Travis Reitter [Fri, 17 Jun 2011 14:15:44 +0000 (15:15 +0100)]
Add Make rule for generating tracker-test.vapi.
After a maintainer-clean, Make doesn't know how to generate this file otherwise.
Travis Reitter [Fri, 17 Jun 2011 12:58:47 +0000 (13:58 +0100)]
Dist but don't include the tracker-test vapi files.
Philip Withnall [Mon, 13 Jun 2011 14:20:55 +0000 (15:20 +0100)]
Bug 652463 — Tidy up CLEANFILES
Tidy up pkg-config and configure-generated files in CLEANFILES and
DISTCLEANFILES.
Closes: bgo#652463
Philip Withnall [Mon, 13 Jun 2011 11:09:34 +0000 (12:09 +0100)]
Bug 646244 — Incomplete logic to handle attribute updates in Folks.Individual
Tidy up some of the update methods in Folks.Individual to handle null values
a little better.
Closes: bgo#646244
Travis Reitter [Thu, 9 Jun 2011 22:29:53 +0000 (15:29 -0700)]
Don't delete tp-test-contactlist.deps when maintainer-cleaning.
This fixes a bug introduced by
b983fee7
Travis Reitter [Thu, 9 Jun 2011 15:43:54 +0000 (08:43 -0700)]
Handle ownership of TpContact.connection automatically.
It recently changed in telepathy-glib and/or Vala 0.14.x finally detected that
the TpContact.connection property returns an owned TpConnection (making our use
of "unowned Connection connection = contact.connection" invalid).
Emilio Pozuelo Monfort [Wed, 8 Jun 2011 11:17:43 +0000 (12:17 +0100)]
Dist the tp-test-contactlist.deps file
It was missing from tarballs, which causes folks to fail to build
in some circumstances.
Raul Gutierrez Segales [Sun, 5 Jun 2011 10:49:20 +0000 (11:49 +0100)]
Move tracker's test image to a common location
Moving this to tests/data so it can be shared by other
backends.
Raul Gutierrez Segales [Tue, 24 May 2011 17:56:12 +0000 (18:56 +0100)]
Play nicely with new API in Vala 0.14
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=650997
Alban Crequy [Wed, 11 May 2011 13:19:46 +0000 (14:19 +0100)]
libsocialweb: Swf.Persona stores SocialWebClient.Contact
Closes: bgo#649925 - expose SocialWebClient.Contact in Swf.Persona
Travis Reitter [Wed, 1 Jun 2011 18:07:14 +0000 (11:07 -0700)]
Post-release bump.
Travis Reitter [Wed, 1 Jun 2011 16:14:09 +0000 (09:14 -0700)]
Release version 0.5.2.
Travis Reitter [Wed, 1 Jun 2011 16:06:48 +0000 (09:06 -0700)]
Note fix for bgo#650268 build failure in NEWS.
Travis Reitter [Wed, 1 Jun 2011 16:05:22 +0000 (09:05 -0700)]
Fix location of NEWS entry for bgo#650067 fix.
Travis Reitter [Wed, 1 Jun 2011 16:01:57 +0000 (09:01 -0700)]
Define the proper autoconf constant when enabling the libsocialweb backend.
Travis Reitter [Tue, 31 May 2011 23:21:33 +0000 (16:21 -0700)]
Don't re-build the vapi files unless we've been configured with Vala.
Travis Reitter [Tue, 31 May 2011 22:28:38 +0000 (15:28 -0700)]
Don't require [lib]valadoc to build docs.
Travis Reitter [Tue, 31 May 2011 22:04:48 +0000 (15:04 -0700)]
Only check for libsocialweb Vala deps if Vala is enabled.
Travis Reitter [Tue, 31 May 2011 23:40:53 +0000 (16:40 -0700)]
Check for folks-telepathy.h in the proper dir when building docs.
Raul Gutierrez Segales [Tue, 24 May 2011 17:11:49 +0000 (18:11 +0100)]
[tracker] Deal with null Avatars being set on a Trf.Persona
Fixes: bgo#650067 - Tracker backend warns when setting a NULL
avatar (ie, unsetting the avatar)
Travis Reitter [Fri, 13 May 2011 19:16:26 +0000 (12:16 -0700)]
Post-release version bump.
Travis Reitter [Thu, 12 May 2011 22:51:20 +0000 (15:51 -0700)]
Release Folks 0.5.1.
Travis Reitter [Fri, 13 May 2011 16:35:13 +0000 (09:35 -0700)]
Generate backend library headers in folks/ subdirs.
This is to allow in-tree building, since we changed the includedir, which
makes the vapi files include headers as <folks/header.h>. Outputting our
headers in a folks/ subdir works around this issue by making the
backend/*/lib dir match the expected includedir layout.
Travis Reitter [Fri, 13 May 2011 05:20:40 +0000 (22:20 -0700)]
Don't depend upon removed LinkedHashSet stamp file.
Travis Reitter [Thu, 12 May 2011 23:36:22 +0000 (16:36 -0700)]
Strip tab characters from valadocs to unbreak doc building.
Travis Reitter [Fri, 13 May 2011 05:59:17 +0000 (22:59 -0700)]
Properly distribute the typelib file.
Travis Reitter [Fri, 13 May 2011 05:55:49 +0000 (22:55 -0700)]
Distribute Folks-*.gir and Folks-*.typelib
Travis Reitter [Fri, 13 May 2011 05:54:35 +0000 (22:54 -0700)]
Allow generated source files to exist after distcleancheck.
It turns out to be nearly impossible to satisfy a standard distcleancheck
with Vala and its automake support. This is specifically a work-around
because there doesn't seem to be any obvious way to satisfy these
requirements:
* the release tarball can be built without gobject-introspection, valac,
or vapigen
* it's safe to run "make distclean" in the release tarball without
suddenly requiring the tools listed above (due to generated files
being removed)
* "make distcheck" doesn't fail its "distcleancheck" phase due to the
following files remaining after distclean:
- tests/lib/telepathy/contactlist/tp-test-contactlist.gir
- tests/lib/telepathy/contactlist/tp-test-contactlist.vapi
- backends/telepathy/lib/tp-lowlevel.gir
- backends/telepathy/lib/tp-lowlevel.vapi
We've hit this last issue multiple times, and no fix seems to stick. So
stripping out this check seems to be the best option (until we can
remove the Vala/GObject-Introspection-free build requirement, when
they've stabilized more and we don't depend upon the latest versions which
may not be in all the major distros).
Travis Reitter [Thu, 12 May 2011 21:00:02 +0000 (14:00 -0700)]
Allow the types argument for PostalAddress() to be null.