Keerat Singh [Sat, 4 Aug 2018 01:14:58 +0000 (18:14 -0700)]
Fixed issue and added Manual Test.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd49053b9c379dd3c0f470762343345e23c9d97c
Filip Navara [Wed, 25 Jul 2018 22:26:03 +0000 (00:26 +0200)]
Usa AsnReader.ThrowIfNotEmpty instead of explicit checks.
Commit migrated from https://github.com/dotnet/corefx/commit/
90aed6e851d7ad2d7374b294cca601dbaeb01083
Martin Baulig [Wed, 25 Jul 2018 22:22:01 +0000 (18:22 -0400)]
Make CertificateData.ReadReverseRdns() accept T61String.
Commit migrated from https://github.com/dotnet/corefx/commit/
5a1c99a35456fee918da5f712dd3f078c86d1709
Keerat Singh [Wed, 25 Jul 2018 22:21:33 +0000 (15:21 -0700)]
Merge pull request dotnet/corefx#31211 from keeratsingh/gh_31082_ExistingTransaction_SqlBulkCopy
[Fix] GH 31082 'Unexpected existing transaction' exception occurs when use SqlBulkCopy
Commit migrated from https://github.com/dotnet/corefx/commit/
bf2083a75d65038d9e6f14b160853a0adbafd224
Huangli Wu [Wed, 25 Jul 2018 22:20:53 +0000 (15:20 -0700)]
Use ReferencePath instead of Reference so it contain the project reference. (dotnet/corefx#31234)
Commit migrated from https://github.com/dotnet/corefx/commit/
9824353f83a5d45aef94b732a13f097b836a4687
Pavel Krymets [Wed, 25 Jul 2018 22:07:05 +0000 (15:07 -0700)]
Syncronize cancellation in ReadAsyncCompletesIfFlushAsyncCanceledMidFlush (dotnet/corefx#31365)
Commit migrated from https://github.com/dotnet/corefx/commit/
dd4a30881d8c0979c65cba7bfdf1f3ab27b3f79b
Anirudh Agnihotry [Wed, 25 Jul 2018 21:58:16 +0000 (14:58 -0700)]
Added Tests and packaging for System.Windows.Extensions. (dotnet/corefx#31334)
* Adding packaging for System.Windows.Extensions
* Implemenation fixed and tests added
* feedback and dead code removed
Commit migrated from https://github.com/dotnet/corefx/commit/
2de91853bcc016958950c42e27cfa40e7d84cabe
Matt Galbraith [Wed, 25 Jul 2018 21:04:30 +0000 (14:04 -0700)]
Merge pull request dotnet/corefx#31366 from dotnet/max-retry-increase
Increase retry count for Windows test runs
Commit migrated from https://github.com/dotnet/corefx/commit/
f5e69a38ef312a1cdc33da96738bba4f1699f626
Matt Galbraith [Wed, 25 Jul 2018 18:07:04 +0000 (11:07 -0700)]
Increase retry count
Add /p:MaxRetryCount=3 to get more retries for flaky OS issues
Commit migrated from https://github.com/dotnet/corefx/commit/
18dd0c4b6ef98eb7ff135a75961ad90effcfa877
Bruce Bowyer-Smyth [Wed, 25 Jul 2018 17:53:30 +0000 (03:53 +1000)]
Port and test VB Information, DoubleType, DecimalType, Versioned (dotnet/corefx#31252)
* Port from referencesource
* Cleanup and tests
* Remove parameter name validation
* Address PR feedback
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
5f635b214b74e69324c65d0f1863653b6249e7d4
David Perfors [Wed, 25 Jul 2018 16:35:02 +0000 (18:35 +0200)]
Updated some incorrect grammar (dotnet/corefx#31356)
Commit migrated from https://github.com/dotnet/corefx/commit/
131062cf61a209d99af8aee0209348ce6f67c8b7
Koundinya Veluri [Wed, 25 Jul 2018 14:06:17 +0000 (07:06 -0700)]
Expose SpinWait.SpinOnce(int sleep1Threshold) overload (dotnet/corefx#29989)
Expose SpinWait.SpinOnce(int sleep1Threshold) overload
Depends on https://github.com/dotnet/coreclr/pull/18204
To allow customizing the spin count threshold for Sleep(1) usage, and to allow disabling the use of Sleep(1).
API review: https://github.com/dotnet/corefx/issues/29623
Part of fix for https://github.com/dotnet/corefx/issues/29595
Commit migrated from https://github.com/dotnet/corefx/commit/
ee03cd041fdf8ac44b01e20b1225d2e2207cb13e
Kevin Jones [Wed, 25 Jul 2018 02:55:58 +0000 (22:55 -0400)]
Added GetInt32 to RandomNumberGenerator. (dotnet/corefx#31243)
Fixes 30873.
Commit migrated from https://github.com/dotnet/corefx/commit/
928873f0027f3c4fbea94c501990a7037ad27066
Paulo Janotti [Tue, 24 Jul 2018 22:50:28 +0000 (15:50 -0700)]
No repro for issue dotnet/corefx#14750 - enable test (dotnet/corefx#31337)
Commit migrated from https://github.com/dotnet/corefx/commit/
f8928fec18a2f326b9a37dc4f3ddc8dab6b36e23
Tanner Gooding [Mon, 23 Jul 2018 15:05:55 +0000 (08:05 -0700)]
Renaming System.Runtime.Intrinsics.Experimental to System.Runtime.Intrinsics
Commit migrated from https://github.com/dotnet/corefx/commit/
3bd2157ac90cd50a4c3bd742f52781b2f5ac9bdd
Dan Moseley [Tue, 24 Jul 2018 19:47:44 +0000 (12:47 -0700)]
Fix vbproj build in VS and update configurations (dotnet/corefx#31303)
* Update configurations including .vbproj
* merge
Commit migrated from https://github.com/dotnet/corefx/commit/
313d0d29725a347b5ef869aa9de0e9b545be0205
Aaron Robinson [Tue, 24 Jul 2018 19:32:50 +0000 (12:32 -0700)]
Set active issue on test (dotnet/corefx#31331)
Commit migrated from https://github.com/dotnet/corefx/commit/
3df90884f58a879a749324e44ce0a2178a4e5b77
Geoff Kizer [Tue, 24 Jul 2018 19:18:49 +0000 (12:18 -0700)]
Merge pull request dotnet/corefx#31317 from geoffkizer/http2issues
HTTP2: Add issue #s in code, and reorganize some code
Commit migrated from https://github.com/dotnet/corefx/commit/
461c30391aa82ed2f592241c80351b3be1c1b63c
Hugh Bellamy [Tue, 24 Jul 2018 18:46:28 +0000 (19:46 +0100)]
Add tests for System.Runtime.Serialization.Primitives (dotnet/corefx#31256)
* Add tests for System.Runtime.Serialization.Primitives
* Cleanup System.Runtime.Serialization.Primitives code
* Add tests for forwarded classes in Serialization.Primitives
* Address PR feedback
* Fix order
Commit migrated from https://github.com/dotnet/corefx/commit/
795957f4e18238ae7688ccab729f1ef8e825ab3a
Tomas Weinfurt [Tue, 24 Jul 2018 18:10:18 +0000 (11:10 -0700)]
add back parsing for simple configuration (dotnet/corefx#31314)
* add back simplified proxy configuration
* add tracing
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
2c5f29064929d4f1c60be7c5c301a488dfab02c4
Geoff Kizer [Tue, 24 Jul 2018 17:41:14 +0000 (10:41 -0700)]
fix UWP build
Commit migrated from https://github.com/dotnet/corefx/commit/
44cc8e1b43893347a209478e30e68f10921b898e
Rajiv Sharma [Tue, 24 Jul 2018 17:34:59 +0000 (17:34 +0000)]
Unit Test Cases for System.Xml.PreloadedResolver (dotnet/corefx#31273)
* Initial Test Case creation for System.Xml
* PR Review comments resolution
* PR comment resolution. Build files deleted
* Unit Test Cases for XmlPreloadedResolver Tests
* Code review comments resolution
Commit migrated from https://github.com/dotnet/corefx/commit/
55c5aa63025c207cde6a9369eb209c7ad7a028de
Pavel Krymets [Tue, 24 Jul 2018 17:08:28 +0000 (10:08 -0700)]
Fix ReadAsync not returning when cancellation token fires during FlushAsync (dotnet/corefx#31212)
Commit migrated from https://github.com/dotnet/corefx/commit/
3cf0de34db47bc1cbe454974daf9b0e935c3b624
Hugh Bellamy [Tue, 24 Jul 2018 16:44:48 +0000 (17:44 +0100)]
Run /T:GenerateReferenceSource in VB and change the source to match the ref (dotnet/corefx#31254)
* Run /T:GenerateReferenceSource in VB and change the source to match the ref
* Fix name
Commit migrated from https://github.com/dotnet/corefx/commit/
4d281194e24206c1b1879784453f90f98c92a7d2
dotnet-maestro-bot [Tue, 24 Jul 2018 16:42:12 +0000 (09:42 -0700)]
Update CoreClr, CoreFx to preview1-26724-05, preview1-26724-02, respectively (dotnet/corefx#31324)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1ac553f141c99aa20afd0d76f17434388b7f228
Hugh Bellamy [Tue, 24 Jul 2018 16:39:47 +0000 (17:39 +0100)]
Port and test VB attributes and event args (dotnet/corefx#31185)
* Expose and test ComClassAttribute
* Cleanup and test HideModuleNameAttribute
* Expose and test MyGroupCollectionAttribute
* Expose and test VBFixedArrayAttribute
* Expose and test VBFixedStringAttribute
* Cleanup and test DesignerGeneratedAttribute
* Cleanup and test OptionCompareAttribute
* Cleanup and test OptionTextAttribute
* Cleanup and test StandardModuleAttribute
* Expose and test various event args
* Cleanups
Commit migrated from https://github.com/dotnet/corefx/commit/
f938a83ebf0a904ceee37060d624c1d0ae44bc28
Maxim Lipnin [Tue, 24 Jul 2018 13:33:59 +0000 (16:33 +0300)]
Mark ProtectedData tests as Windows-specific in source
The corefx build mainly gets the differentiator from Configuration.props, but the class-level attribute allows it to be included in another assembly and maintain Windows-specific-ness.
Commit migrated from https://github.com/dotnet/corefx/commit/
7942e7c3ed03cf7f19dffe539e23b84b4a85ad5a
dotnet-maestro-bot [Tue, 24 Jul 2018 07:13:29 +0000 (00:13 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-26724-00, beta-26724-00, respectively (dotnet/corefx#31311)
Commit migrated from https://github.com/dotnet/corefx/commit/
36bf44fd1021653bfa8e4e1030578b484e80b09b
Jeremy Barton [Tue, 24 Jul 2018 06:48:36 +0000 (23:48 -0700)]
Ensure that exporting an unsorted attributes signed payload doesn't sort them.
Commit migrated from https://github.com/dotnet/corefx/commit/
f81b5c549dfd38cd538c1f6cab8dbc408d9e6e80
Geoff Kizer [Tue, 24 Jul 2018 06:30:38 +0000 (23:30 -0700)]
move HPACK files under SocketsHttpHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
e62cd96b81d0b6546ca893d75f9bd2ca436c351b
Geoff Kizer [Tue, 24 Jul 2018 06:22:41 +0000 (23:22 -0700)]
add issues and refactor some files
Commit migrated from https://github.com/dotnet/corefx/commit/
6ea9bba7ed88902583f42ee1c8da2892b596d4e6
Filip Navara [Tue, 24 Jul 2018 06:17:43 +0000 (08:17 +0200)]
Fix X509Certificates test failures on macOS Mojave.
Fix tests which were passing on Developer Preview 1, but started failing for Developer Preview 2.
Commit migrated from https://github.com/dotnet/corefx/commit/
fe2925b0353a02b96b30718683d36963aea82b04
Marco Rossignoli [Tue, 24 Jul 2018 05:48:37 +0000 (07:48 +0200)]
Add back most CreateInstance APIs to AppDomain and Activator (dotnet/corefx#30809)
Commit migrated from https://github.com/dotnet/corefx/commit/
ab6f3daaab793f7146c4676d74a36dcd9601c555
Martin Baulig [Tue, 24 Jul 2018 02:52:17 +0000 (22:52 -0400)]
Partial cleanup of `Internal.Cryptography.Helpers`. (dotnet/corefx#31228)
* Partial cleanup of `Internal.Cryptography.Helpers`.
At the moment, each of the `System.Security.Cryptography.*` projects defines its own
`Internal.Cryptography.Helpers` and several of them contain identical helper methods
such as for instance `CloneByteArray()`.
This causes problems for Mono when we're trying to combine pieces from multiple of these
projects into our assemblies.
This is a partial cleanup, which adds a `partial` modifier to all these classes and
moves the `CloneByteArray()` into a new shared file.
* Add the missing file to `System.Security.Cryptography.X509Certificates`.
* Make it build.
* Unconditionally include the common Helpers.cs.
Commit migrated from https://github.com/dotnet/corefx/commit/
b1b9233dda4dc83b39a785f184ef43400d8e64e5
Hugh Bellamy [Tue, 24 Jul 2018 02:50:21 +0000 (03:50 +0100)]
Add some Unix console tests (dotnet/corefx#31244)
* Add some Unix console tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
672255c1de97e2ed2c4791f6526f57e3fdcb883b
dotnet-maestro-bot [Tue, 24 Jul 2018 02:49:47 +0000 (19:49 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-26724-01, preview1-26724-01, preview1-26723-04, beta-26723-00, beta-26723-00, respectively (dotnet/corefx#31292)
Commit migrated from https://github.com/dotnet/corefx/commit/
65ccd1070309c76fd1d90081ddc9290478207a73
Geoff Kizer [Tue, 24 Jul 2018 02:44:34 +0000 (19:44 -0700)]
Merge pull request dotnet/corefx#31289 from geoffkizer/fixvpntestissue
fix a test issue caused by new MSIT VPN adapter
Commit migrated from https://github.com/dotnet/corefx/commit/
9dd8bbc2f043813499e05783bde5ba1f08d0a868
Divino César [Tue, 24 Jul 2018 00:17:18 +0000 (17:17 -0700)]
Moving setup-vs-tools.cmd to buildpipeline/ (dotnet/corefx#31286)
Commit migrated from https://github.com/dotnet/corefx/commit/
24c1fe9d851c5d1f6d9938c324a43f3c93efd5e5
Geoff Kizer [Mon, 23 Jul 2018 22:29:31 +0000 (15:29 -0700)]
fix a test issue caused by new MSIT VPN adapter
Commit migrated from https://github.com/dotnet/corefx/commit/
d730ec04c0ba9b96be1b88f282cd13635513a214
Anirudh Agnihotry [Mon, 23 Jul 2018 20:42:06 +0000 (13:42 -0700)]
Maintaining the consistency of tests among master and release branch (dotnet/corefx#31164)
* Feedback Addressed
* Fixing original tests and for appContainers
* comment corrected
Commit migrated from https://github.com/dotnet/corefx/commit/
7d916b0fe6c5e723374be7232c79706eedc64466
Hugh Bellamy [Mon, 23 Jul 2018 20:22:49 +0000 (21:22 +0100)]
Add more Marshal exception tests (dotnet/corefx#31235)
* Add and cleanup Marshal exception tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
baa56b0bbe4c4953016c29daab9bc64bd7e9411f
Dan Moseley [Mon, 23 Jul 2018 20:21:06 +0000 (13:21 -0700)]
Handle overflow in uname -r (dotnet/corefx#31261)
* Avoid overflow in Unix uname -r parsing
* tests
* Add test
* Fix
Commit migrated from https://github.com/dotnet/corefx/commit/
f9bb2de5b9a324994914c1cd5231be6126e9c121
Divino César [Mon, 23 Jul 2018 18:51:57 +0000 (11:51 -0700)]
Patching windows.groovy to execute on a helix queue with .net 472 (dotnet/corefx#31165)
* Patching windows.groovy to execute on a helix queue with .net 472
* Adding setup-vst-tools.cmd and using it to find our way to VsDevCmd.bat
Commit migrated from https://github.com/dotnet/corefx/commit/
9abd46a778221a562a4dd9be281851caad84e892
Filip Navara [Mon, 23 Jul 2018 16:49:38 +0000 (18:49 +0200)]
Fix X509Certificate.GetName/GetIssuerName to match NetFX
Return subject and issuer name in obsolete GetName/GetIssuerName methods in the encoded (non-reversed) order to match NetFX.
Commit migrated from https://github.com/dotnet/corefx/commit/
d24a86c443735f465e5b15398f1ed4c9eb607b80
Filip Navara [Mon, 23 Jul 2018 16:29:16 +0000 (18:29 +0200)]
Fix unbalanced reference count in X509Store.Remove on macOS.
Without this change a call to X509Store.Remove which doesn't throw ends up bumping the reference count of the input cert handle.
This change additionally enables the managed side to call delete with a SecIdentityRef, which already has coverage due to existing tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
2b3d3686dda4e1a1f5b16134bf87805845435cac
Filip Navara [Mon, 23 Jul 2018 15:34:38 +0000 (17:34 +0200)]
Fix byte order in X509Certificate serial number properties and methods.
.NET Core now matches .NET Framework:
* SerialNumber: Big-Endian hex
* GetSerialNumberString(): Big-Endian hex
* GetSerialNumber(): Little-Endian bytes
Commit migrated from https://github.com/dotnet/corefx/commit/
479bf1a55403e5165a75b7121a27f2f6a22752de
Jan Kotas [Mon, 23 Jul 2018 11:19:44 +0000 (04:19 -0700)]
Expose MemoryMarshal.AsRef (dotnet/corefx#31236)
* Expose MemoryMarshal.AsRef
- Add tests
- Take advantage of the new API in CoreFX
Fixes dotnet/corefx#30613
* Auto-generated System.Memory ref
Commit migrated from https://github.com/dotnet/corefx/commit/
e34fa6ac5fcc49be5cb22f46119c6d99219483b6
Michal Strehovský [Mon, 23 Jul 2018 07:44:40 +0000 (09:44 +0200)]
Update RD.XML for TypeConverterAttribute (dotnet/corefx#31183)
`GetDefaultAttribute` will look for a field named `Default` on things and there are code paths through which this is reachable with the `TypeConverterAttribute`.
https://github.com/dotnet/corefx/blob/dotnet/corefx@
b996738f877d17b0fe426c75b01f0a8ecdc21e07/src/System.ComponentModel.TypeConverter/src/System/ComponentModel/AttributeCollection.cs#L267-L269
Commit migrated from https://github.com/dotnet/corefx/commit/
af4f4610d196459441a760fee6c4f372d06e31ba
Rajiv Sharma [Mon, 23 Jul 2018 06:44:46 +0000 (06:44 +0000)]
Initial Test Case creation for System.Xml (dotnet/corefx#31129)
* Initial Test Case creation for System.Xml
* PR review comments resolution
* PR Review comments resolution
* PR comment resolution. Build files deleted
* Removed dependency on Properties and Targets file
* Added helper class to extract out XmlNodeReader construction
* Changes incorporating code review comments
* Changes for code review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
ef760ce9359200f8179c2888ace0b1ff7ec44ed3
Hugh Bellamy [Mon, 23 Jul 2018 06:04:08 +0000 (07:04 +0100)]
Add/cleanup Free/PtrTo tests (dotnet/corefx#31151)
Add/cleanup Free/PtrTo tests
Commit migrated from https://github.com/dotnet/corefx/commit/
2a86a4a72bc4746f4df97b65955b3315ea5774c4
Hugh Bellamy [Mon, 23 Jul 2018 06:01:22 +0000 (07:01 +0100)]
Add delegate Marshal tests (dotnet/corefx#31166)
* Add delegate Marshal tests
Commit migrated from https://github.com/dotnet/corefx/commit/
790cdd518e71e8f089f3e1731e34072a2fa26b87
Adam Gauthier [Sun, 22 Jul 2018 19:24:42 +0000 (15:24 -0400)]
Add note for "access is denied" errors to windows build instructions (dotnet/corefx#31251)
Commit migrated from https://github.com/dotnet/corefx/commit/
6ed61acebe3214fcf79b4274f2bb9b55c0604a4d
Adam Gauthier [Sun, 22 Jul 2018 02:21:53 +0000 (22:21 -0400)]
Use nameof in ArgumentNullExceptions that throw the paramName (dotnet/corefx#31250)
Commit migrated from https://github.com/dotnet/corefx/commit/
b6b9a1ad24339266a27fef826233dbbe192cf254
Tomas Weinfurt [Sun, 22 Jul 2018 00:02:06 +0000 (17:02 -0700)]
Adjust DataOffset so SocketAddress.ToString() works similar to Windows (dotnet/corefx#31134)
Correct DataOffset and add test for ToString() function.
Fixes dotnet/corefx#30523
Commit migrated from https://github.com/dotnet/corefx/commit/
4ce283d92d06b3b759155c5803e8036ca865ef22
Tomas Weinfurt [Sat, 21 Jul 2018 23:59:37 +0000 (16:59 -0700)]
improve port parsing to be more resilient against trailing characters (dotnet/corefx#31232)
improve port parsing to be more resilient against trailing characters
Commit migrated from https://github.com/dotnet/corefx/commit/
56d177d8ed94096c13ac14894945899783b1a3df
David Shulman [Sat, 21 Jul 2018 21:42:35 +0000 (14:42 -0700)]
Fix revoked certificate tests to use more stable external party server (dotnet/corefx#31245)
System.Net.Http.Functional.Tests.SocketsHttpHandler_HttpClientHandler_ServerCertificates_Test.NoCallback_RevokedCertificate_NoRevocationChecking_Succeeds tests was failing because the external third-party server we use is no longer working.
Switching to the more reliable *.badssl.com servers will fix this.
Commit migrated from https://github.com/dotnet/corefx/commit/
4dbfee476de93faf189d4fa0de2f772f38d5e99e
Caesar Chen [Fri, 20 Jul 2018 23:51:02 +0000 (16:51 -0700)]
Add more logging for authentication failure (dotnet/corefx#31225)
* add logging
* address feedback
* feedback 2
* change Info to Error
Commit migrated from https://github.com/dotnet/corefx/commit/
3ea1a8cf78073491f9532e36a738a7b8be44829a
Jeremy Kuhne [Fri, 20 Jul 2018 22:42:54 +0000 (15:42 -0700)]
Improve perfromance for loading from Stream on Windows (dotnet/corefx#31142)
* Improve perfromance for loading from Stream on Windows
- Make IStream blittable and move to Interop
- Change GPStream to use Span APIs
- Make STATSTG blittable and move to Interop
- Fill out corners correctly in GPStream
- Remove extra allocations opening Gifs
- Fix allocations in FrameDimensionsList and move to shared
- Move IPicture to Icon.Windows (was Windows specific and used IStream, needs cleanup and moving to Interop)
- Add perf tests for opening images
* Add netcoreapp2.0 variant
* Fall back to heap for large frame counts
* Add netcoreapp2.0 to packages.
* Fix issue in GpStream and add test
Undo netcoreapp2.1 change
Commit migrated from https://github.com/dotnet/corefx/commit/
dee434428ee392302ff2050bbee304c9fce68b2f
Jeremy Barton [Fri, 20 Jul 2018 22:20:07 +0000 (15:20 -0700)]
Allow SignedCms to verify documents whose signer didn't sort attributes.
The CMS RFC says that when computing the digest value for a SignerInfo
which contains attributes that the digest should be over the DER encoded
SET OF attributes. DER rules for SET OF include applying a data sort.
Signers exist in the wild which do not appropriately sort their attributes before
computing the signature, and Windows has a compatibility fallback to allow
these signers' signatures to be considered valid. This change adds a similar
fallback to the managed implementation of SignedCms so that documents
do not go from valid to invalid when transitioning from .NET Framework to
.NET Core.
Commit migrated from https://github.com/dotnet/corefx/commit/
dea42667cf35e1c0ed4724229203d895db706246
Caesar Chen [Fri, 20 Jul 2018 21:59:23 +0000 (14:59 -0700)]
Add more logging for certificate exchange/validation (dotnet/corefx#31168)
* add logging
* address feedback
* address feedback 2
Commit migrated from https://github.com/dotnet/corefx/commit/
5f6b7b2bdfda61d1799b71d0785c6d85a4f3dea2
Keerat Singh [Fri, 20 Jul 2018 21:20:19 +0000 (14:20 -0700)]
Addressed Saurabh's feedback, removed method GetDataSource
Commit migrated from https://github.com/dotnet/corefx/commit/
6f76e0fafbe901db09a5388fd3cbed7d59d8348f
Hugh Bellamy [Fri, 20 Jul 2018 20:10:13 +0000 (21:10 +0100)]
Cleanup and add More Marshal.Read/Write tests (dotnet/corefx#31149)
Commit migrated from https://github.com/dotnet/corefx/commit/
d1da90321472db20592319336f1ba164c2674fdd
Hugh Bellamy [Fri, 20 Jul 2018 20:09:27 +0000 (21:09 +0100)]
Cleanup and add more Marshal.Copy tests (dotnet/corefx#31148)
Commit migrated from https://github.com/dotnet/corefx/commit/
b871c9145aaabdfe14a2d3124689ae3237b99d42
Omair Majid [Wed, 18 Jul 2018 22:57:54 +0000 (18:57 -0400)]
Update runtime IDs for new RHEL/OL/Fedora releases
CentOS does not include a minor version in runtime id.
Commit migrated from https://github.com/dotnet/corefx/commit/
a35a59f40d2a12bacbb6fb819645f235f71a2794
dotnet-maestro-bot [Fri, 20 Jul 2018 16:33:37 +0000 (09:33 -0700)]
Update CoreClr to preview1-26720-05 (dotnet/corefx#31223)
Commit migrated from https://github.com/dotnet/corefx/commit/
96c235bbc59e5648400300f9c4202fad6471d6de
Keerat Singh [Fri, 20 Jul 2018 16:14:26 +0000 (09:14 -0700)]
Addressed Afsaneh's feedback, removed unused namespaces, added .NET header
Commit migrated from https://github.com/dotnet/corefx/commit/
5219c1da5b4da0064d99a4df352c0e755b62fbb4
Paulo Janotti [Fri, 20 Jul 2018 14:26:44 +0000 (07:26 -0700)]
Add cross-platform section to experiment w/ Coverlet
Commit migrated from https://github.com/dotnet/corefx/commit/
d32eb8f517add4deb2f8fe26f63d05290fb48470
Stephen Toub [Fri, 20 Jul 2018 11:06:35 +0000 (04:06 -0700)]
Remove method moved to shared
Commit migrated from https://github.com/dotnet/corefx/commit/
09285497b4fff817b6e3ce3328e99da3b211f176
Jan Kotas [Fri, 20 Jul 2018 10:13:43 +0000 (03:13 -0700)]
Avoid complex inefficient marshaling in System.Diagnostics.PerformanceCounter (dotnet/corefx#31219)
Related to https://github.com/dotnet/corert/issues/6122
Commit migrated from https://github.com/dotnet/corefx/commit/
1d5f8f15a025919118b14ed0a0772cee7757f6b3
dotnet-maestro-bot [Fri, 20 Jul 2018 08:54:00 +0000 (01:54 -0700)]
Update CoreFx, ProjectNTfs, ProjectNTfsTestILC to preview1-26720-01, beta-26720-00, beta-26720-00, respectively (dotnet/corefx#31216)
Commit migrated from https://github.com/dotnet/corefx/commit/
3e52ffd07a48d1464a21bbb94e43261f483048b7
Stephen Toub [Fri, 20 Jul 2018 03:34:15 +0000 (20:34 -0700)]
Merge pull request dotnet/corefx#31188 from dotnet-maestro-bot/master-UpdateDependencies
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03020-01, preview1-26720-01, preview1-26719-04, preview1-26719-04, beta-26719-00, beta-26719-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
4d915fd1c7bd7242a3f549603d402a27b3b5ab79
Stephen Toub [Fri, 20 Jul 2018 02:37:26 +0000 (19:37 -0700)]
Fix netfx test failure
Commit migrated from https://github.com/dotnet/corefx/commit/
1e7d4d88f2c3d4e6dacb5c58ad7fed721d506654
Aaron R Robinson [Fri, 20 Jul 2018 00:43:15 +0000 (17:43 -0700)]
Disable tests that rely on GetComObjectData() and SetComObjectData() semantics
Fix bug in Prelink_NonRuntimeMethod_ThrowsArgumentException test.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ac44d4df5b6623b13c18b0da840b271faef6de1
dotnet-maestro-bot [Fri, 20 Jul 2018 01:07:24 +0000 (18:07 -0700)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, ProjectNTfs, ProjectNTfsTestILC to preview1-03020-01, preview1-26720-01, preview1-26719-04, preview1-26719-04, beta-26719-00, beta-26719-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
59739cde2a56b9db3b38a29df119ab321b874e73
Max Kerr [Fri, 20 Jul 2018 00:56:24 +0000 (17:56 -0700)]
Ensure Windows specific DNS resolution errors throw the correct exception (dotnet/corefx#31210)
* Ensure that Windows specific DNS resolution errors throw the correct exception type.
* Whitespace.
Commit migrated from https://github.com/dotnet/corefx/commit/
28a95c35272ec491cacc672161336060e704995d
Jan Kotas [Thu, 19 Jul 2018 23:28:13 +0000 (16:28 -0700)]
Mark Decimal as readonly (dotnet/corefx#31198)
* Mark Decimal as readonly
* Baseline uapaot
Commit migrated from https://github.com/dotnet/corefx/commit/
966f1d83aa21f3fe8066da0f451f58626ca025ff
Santiago Fernandez Madero [Thu, 19 Jul 2018 23:27:12 +0000 (16:27 -0700)]
Disable System.Drawing.Tests.Graphics_DrawLinetests.DrawLines_Points (dotnet/corefx#31204)
Commit migrated from https://github.com/dotnet/corefx/commit/
e7b5ad2e3c4fc12fd5d7b83d60ec0369328ac13f
Paulo Janotti [Thu, 19 Jul 2018 23:26:49 +0000 (16:26 -0700)]
Add coverlet runtime deps to testhost shared runtime (dotnet/corefx#31209)
Commit migrated from https://github.com/dotnet/corefx/commit/
8dfc18ef68c455660823cc3c78753e03d95a9fb3
Keerat Singh [Thu, 19 Jul 2018 23:19:11 +0000 (16:19 -0700)]
Removed unused reference `System.Text.RegularExpressions`
Commit migrated from https://github.com/dotnet/corefx/commit/
18480bcb97f19ca98c4051b208d4b7e1c4683803
Keerat Singh [Thu, 19 Jul 2018 23:11:31 +0000 (16:11 -0700)]
Merge branch 'master' of https://github.com/dotnet/corefx into gh_31082_ExistingTransaction_SqlBulkCopy
Commit migrated from https://github.com/dotnet/corefx/commit/
a2ae928f562fd1403eb9c59b207c02a7c7bd0ee1
Keerat Singh [Thu, 19 Jul 2018 23:11:01 +0000 (16:11 -0700)]
Removed duplicate method Helpers.Execute, updated all references in SqlClient Manual Tests of Helpers.Execute to Helpers.TryExecute
Commit migrated from https://github.com/dotnet/corefx/commit/
ac494f6d55f865e1a5a0dcb307b2db92710e0eea
Keerat Singh [Thu, 19 Jul 2018 23:00:39 +0000 (16:00 -0700)]
Added test "SqlBulkCopyTest.AzureDistributedTransactionTest"
Commit migrated from https://github.com/dotnet/corefx/commit/
fec7ef7f19591bc13e72b1db21c789d7f18d7957
Eric Erhardt [Thu, 19 Jul 2018 22:21:51 +0000 (17:21 -0500)]
Update Common.Tests.sln file for new SDK project changes. (dotnet/corefx#31205)
Commit migrated from https://github.com/dotnet/corefx/commit/
1739a03a89665afeb2facf2e2ef70771e7c9b9d6
Anirudh Agnihotry [Thu, 19 Jul 2018 18:48:43 +0000 (11:48 -0700)]
Porting X509Certificate2UI to .Net Core (dotnet/corefx#31111)
* Ref build Successful
* Basic tests proj added
* src build Successful
* Moved from framework
* Moved handles
* build successful
* build successful
* strings added and build fixed
* Interop guidelines followed
* ref and src build properly
* BasicTests
* minor changes
* namespace name change
* Feedback addressed
* fixing reference build
* name of function changed and using using statement
* changing parameter to X509Certificate2
Commit migrated from https://github.com/dotnet/corefx/commit/
a6159bb0929b5eb8b297a9a8ebba595d5f3a9bb0
Atsushi Kanamori [Thu, 19 Jul 2018 18:47:00 +0000 (11:47 -0700)]
Add back TypeBuilder.DefinePInvokeMethod (dotnet/corefx#31096)
* Add back TypeBuilder.DefinePInvokeMethod
https://github.com/dotnet/corefx/issues/30355
* Fix UAPAOT build
* Fix packaging build
* Remove S.R.I reference
Commit migrated from https://github.com/dotnet/corefx/commit/
c454d79db0dd8ef49135d38c0825a532f39e357d
Hugh Bellamy [Thu, 19 Jul 2018 16:41:25 +0000 (17:41 +0100)]
Cleanup and add more Marshal.StringTo tests (dotnet/corefx#31150)
* Cleanup and add more Marshal.StringTo tests
* Remove blank lines
Commit migrated from https://github.com/dotnet/corefx/commit/
ce37aae38fdf2c74512569856401c568f959bb09
Dan Seefeldt [Thu, 19 Jul 2018 16:38:27 +0000 (11:38 -0500)]
Default generatedefaultsource to true (dotnet/corefx#31161)
* Default generatedefaultsource to true
* Change option to skip versiongeneration for bootstrap script.
Commit migrated from https://github.com/dotnet/corefx/commit/
9dfcd8fb53dd0e388a81e328b55f68409c7333ad
Santiago Fernandez Madero [Thu, 19 Jul 2018 16:26:39 +0000 (09:26 -0700)]
Port System.Drawing.Design members needed by winforms (dotnet/corefx#31110)
* Port System.Drawing.Design members needed by winforms
* Add a few tests and fix configurations to only support netcoreapp
* PR Feedback
* Add more tests, rename and condition tests to gdiplusavailable
* Fix perf tests build error
Commit migrated from https://github.com/dotnet/corefx/commit/
8d6f4d1e9bfde867e2c862977b651d80feddb66a
Paulo Janotti [Thu, 19 Jul 2018 15:21:20 +0000 (08:21 -0700)]
Add coverlet.msbuild package for experiments (dotnet/corefx#31171)
Commit migrated from https://github.com/dotnet/corefx/commit/
9e3d0618bc4aff22e7a77ffb3e1e1ecfe5a1f392
Stephen Toub [Thu, 19 Jul 2018 14:12:50 +0000 (07:12 -0700)]
Add even more integer parsing tests (dotnet/corefx#31089)
* Add more integer parsing tests
In particular to improve UInt32/UInt64 coverage and to reuse more Int32 tests for other types.
* Fix test
Commit migrated from https://github.com/dotnet/corefx/commit/
0d6c1088eb5cb1a20caebf2dcf4295c2a641ee66
Marco Rossignoli [Thu, 19 Jul 2018 13:46:36 +0000 (15:46 +0200)]
Update .NET SDK link (dotnet/corefx#30703)
* update .NET SDK link
* Update benchmarking.md
update link
Commit migrated from https://github.com/dotnet/corefx/commit/
8d24439634a491cce36545adb5f0a424dd2fe6d1
Dan Friedman [Thu, 19 Jul 2018 12:48:49 +0000 (07:48 -0500)]
Add command line install (dotnet/corefx#29154)
Commit migrated from https://github.com/dotnet/corefx/commit/
4469b2037f24c5a06a1837c90509864d0feaeb93
Wes Haggard [Thu, 19 Jul 2018 06:59:38 +0000 (23:59 -0700)]
Filter binplacepackage depproj's to only direct reference (dotnet/corefx#31167)
Don't copy out the full closure of all packages for binplacePackages.
Commit migrated from https://github.com/dotnet/corefx/commit/
eb41cd4480f831de784666ad63acb9f2088fd97c
Stephen Toub [Thu, 19 Jul 2018 04:13:12 +0000 (21:13 -0700)]
Merge pull request dotnet/corefx#31175 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs to preview1-26719-01, preview1-26717-04, preview1-26718-04, beta-26718-00, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
156aebead70e4950f08463d047b548620d5921b6
Tomas Weinfurt [Thu, 19 Jul 2018 04:11:26 +0000 (21:11 -0700)]
support for correct Tools on Linux/ARM (dotnet/corefx#31160)
Commit migrated from https://github.com/dotnet/corefx/commit/
a53adfc55bcb028d36a8647e45c66f7be5374f92
Stephen Toub [Thu, 19 Jul 2018 02:52:03 +0000 (19:52 -0700)]
Revert ProjectNtfs update
Commit migrated from https://github.com/dotnet/corefx/commit/
3ab406c043410715d1fee8f8ab119c13ffc91bb0
dotnet-maestro-bot [Thu, 19 Jul 2018 02:16:58 +0000 (19:16 -0700)]
Update CoreClr, CoreFx, CoreSetup, ProjectNTfs to preview1-26719-01, preview1-26717-04, preview1-26718-04, beta-26718-00, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
04f92159cc494feb1ce1a0510ef78d54b7607b37
Keerat Singh [Wed, 18 Jul 2018 19:53:08 +0000 (12:53 -0700)]
Update TransactionType to include Distributed Transaction.
Commit migrated from https://github.com/dotnet/corefx/commit/
53ab2623bd08b19c247512c24125e99e2289447b
Stephen Toub [Wed, 18 Jul 2018 19:17:04 +0000 (12:17 -0700)]
Add more TimeSpan formatting tests (dotnet/corefx#31157)
* Add more TimeSpan formatting tests
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
84d044411b400044f75ee90c744a7f9bd6e4fe1d
Maxim Lipnin [Wed, 18 Jul 2018 17:59:51 +0000 (20:59 +0300)]
Pkcs9SigningTime: normalize exception on time < 1601
Make Pkcs9SigningTime throw CryptographicException for all times which cannot be encoded.
In .NET Framework (and prior versions of .NET Core) an ArgumentException is thrown for values which cannot be expressed as a FILETIME value, and a CryptographicException for dates in [1601, 1949] and [2050, ...)
Commit migrated from https://github.com/dotnet/corefx/commit/
826f821eab39f6fd6140a44f1511543fdf35f4f1