platform/core/dotnet/diagnostics.git
2 years ago[main] Update dependencies from dotnet/source-build-reference-packages (#3861)
dotnet-maestro[bot] [Tue, 9 May 2023 16:25:50 +0000 (09:25 -0700)]
[main] Update dependencies from dotnet/source-build-reference-packages (#3861)

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230428.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23226.1 -> To Version 8.0.0-alpha.1.23228.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230501.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23226.1 -> To Version 8.0.0-alpha.1.23251.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230503.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23226.1 -> To Version 8.0.0-alpha.1.23253.2

* Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230508.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23226.1 -> To Version 8.0.0-alpha.1.23258.2

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years ago[main] Update dependencies from dotnet/symstore (#3863)
dotnet-maestro[bot] [Tue, 9 May 2023 16:25:26 +0000 (09:25 -0700)]
[main] Update dependencies from dotnet/symstore (#3863)

* Update dependencies from https://github.com/dotnet/symstore build 20230501.1

Microsoft.SymbolStore
 From Version 1.0.422401 -> To Version 1.0.425101

* Update dependencies from https://github.com/dotnet/symstore build 20230508.1

Microsoft.SymbolStore
 From Version 1.0.422401 -> To Version 1.0.425801

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agoFix issue with !sos maddress (#3868)
Lee Culver [Mon, 8 May 2023 22:50:30 +0000 (15:50 -0700)]
Fix issue with !sos maddress (#3868)

Previous refactoring accidently eliminated the case where the CLR region perfectly overlapped the memory region.

2 years agodotnet-stack: Fix parsing of thread names (#3860)
Grisha Kotler [Tue, 2 May 2023 22:49:57 +0000 (01:49 +0300)]
dotnet-stack: Fix parsing of thread names (#3860)

2 years agoEnable UpDownCounter For Dotnet-Counters and Dotnet-Monitor (#3849)
kkeirstead [Tue, 2 May 2023 16:55:11 +0000 (09:55 -0700)]
Enable UpDownCounter For Dotnet-Counters and Dotnet-Monitor (#3849)

* Use value from UDC event payload.
* Adding support for UpDownCounter reporting a value instead of a rate
* Check for payload version, don't attempt to parse if version 0
* Don't get rate for updowncounter payload

2 years agoDeal with 8.0 DAC passing bigger thread context to data target's GetThreadContext...
Mike McLaughlin [Fri, 28 Apr 2023 17:36:38 +0000 (10:36 -0700)]
Deal with 8.0 DAC passing bigger thread context to data target's GetThreadContext() (#3856)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Thu, 27 Apr 2023 14:01:24 +0000 (14:01 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230426.1 (#3858)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoFit and Finish: Clean up SOS command table output (#3852)
Lee Culver [Wed, 26 Apr 2023 22:39:06 +0000 (15:39 -0700)]
Fit and Finish: Clean up SOS command table output (#3852)

* Initial version of Table

* Update !dumpheap

* Update DumpObjGCRefsHelper.cs

* Update !dumpruntimetypes

* Fix dml escape issue

* Update !dso

* Update !eeheap

* Update !fq

* Fix truncation for types

* Update FindEphemeralReferencesToLOHCommand.cs

* Update !lno

* Update !findpointersin

* Add BorderedTable

* Update !ephrefs

* Update !sos GCHeapStat

* Update !gcroot

* Update GCToNative

* Update GCWhere

* Update maddress

* Update SizeStatsCommand.cs

* Update !vh

* Update !threadpool

* Add a reason to !verifyheap

* Remove debug code

* Dml cleanup

* Remove DumpHeapSegment

* Update comments

* Fix test whitespace dependency

* Revert previous test behavior, change !dumpheap

* Ignore whitespace

* One last fix?

* Code review feedback

2 years agoUpdate docker images to latest tags (#3535)
Adeel Mujahid [Wed, 26 Apr 2023 21:20:51 +0000 (00:20 +0300)]
Update docker images to latest tags (#3535)

* Update docker images to latest tags

* Make the CentOS7 builds temporarily build only.

* Add buildAndSkipTest. Remove _BuildOnly; it didn't do what it was named

---------

Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
2 years agoImprove lldb discovery for tests (#3855)
Adeel Mujahid [Wed, 26 Apr 2023 19:17:34 +0000 (22:17 +0300)]
Improve lldb discovery for tests (#3855)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Wed, 26 Apr 2023 13:46:31 +0000 (13:46 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230425.2 (#3854)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20230424.1 (#3850)
dotnet-maestro[bot] [Tue, 25 Apr 2023 18:25:14 +0000 (18:25 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20230424.1 (#3850)

[main] Update dependencies from dotnet/symstore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 25 Apr 2023 13:33:50 +0000 (13:33 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230424.3 (#3851)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoReimplement !dso and !fq in C# (#3837)
Lee Culver [Mon, 24 Apr 2023 15:14:01 +0000 (08:14 -0700)]
Reimplement !dso and !fq in C# (#3837)

* Add initial managed !fq command

* Update ClrMD version

* Finish managed !fq implementation

* Implement managed !dumpstackobjs

* Remove !dso and !fq C++ implementations

* Remove more dead code

* More dead code

* Remove ObjectSize helpers

* Remove usages of g_snapshot

* Remove GCHeap logic from SOS

* Cleanup

* Add RcwCleanup output

* Ensure what we don't read past stack range

* Change validation

* Update validation

* Add registers, fix output

* Remove !dso heading in C++

* Fix dso regexes

* Always print the statistics table

* Always print dumpheap statistics

* Add proper flush check

* Restore previous DumpHeapService behavior

Only print header when we have objects.

* Update ClrMD version

* Code review feedback

* TESTONLY:  Add !runtimes to get more diagnostics

* TESTONLY:  Fix previous command

* TESTONLY: Write all warning/errors to normal

* TESTONLY: Printf debugging

* Fix DumpStackObject failures. Remove the test only code. Enable sos logging to a file

---------

Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Sat, 22 Apr 2023 13:29:07 +0000 (13:29 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230421.1 (#3848)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Fri, 21 Apr 2023 13:41:45 +0000 (13:41 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230420.1 (#3847)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Thu, 20 Apr 2023 13:47:10 +0000 (13:47 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230418.5 (#3846)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20230418.1 (#3845)
dotnet-maestro[bot] [Thu, 20 Apr 2023 13:22:26 +0000 (13:22 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20230418.1 (#3845)

[main] Update dependencies from dotnet/symstore

2 years agoRemove BOM marker from the middle of !traversexml (#3844)
Lee Culver [Wed, 19 Apr 2023 18:55:53 +0000 (11:55 -0700)]
Remove BOM marker from the middle of !traversexml (#3844)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 18 Apr 2023 17:53:38 +0000 (17:53 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230417.1 (#3838)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoFix #3699 (#3836)
Nickolas McDonald [Tue, 18 Apr 2023 05:40:13 +0000 (01:40 -0400)]
Fix #3699 (#3836)

2 years agoFix incorrect rendering of counters (#3816)
Tom McDonald [Tue, 18 Apr 2023 03:07:57 +0000 (23:07 -0400)]
Fix incorrect rendering of counters (#3816)

* Fix incorrect rendering of counters

* Fixing IDE0008 Use explicit type instead of 'var' build error

* PR feedback and truncate output for multiple providers

* Simplify counter refresh console output

* Better drawing for very small console height screens

* Remove lambda to avoid unnecessary memory allocations

2 years agoUpdate ClrMD (#3835)
Lee Culver [Sat, 15 Apr 2023 02:59:00 +0000 (19:59 -0700)]
Update ClrMD (#3835)

* Updates with breaking changes from ClrMD 3.0 beta

* Update NativeAddressHelper with ISOSDacInterface13 improvements

* Fix null size issue

* Fix assert

* Properly handle GCBookkeeping regions

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Fri, 14 Apr 2023 20:25:29 +0000 (20:25 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230414.3 (#3831)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agodotnet-dump returns failure after exhausting retries on ERROR_PARTIAL_COPY (#3830)
Andrew Moskevitz [Fri, 14 Apr 2023 19:41:27 +0000 (15:41 -0400)]
dotnet-dump returns failure after exhausting retries on ERROR_PARTIAL_COPY (#3830)

* updated to retry on ERROR_PARTIAL_COPY more times and to return a failure on the last loop

* Update Dumper.Windows.cs

---------

Co-authored-by: apmoskevitz <andrew.moskevitz@gdbiw.com>
2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230413.2 (...
dotnet-maestro[bot] [Thu, 13 Apr 2023 17:23:52 +0000 (17:23 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230413.2 (#3827)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20230412.1 (#3826)
dotnet-maestro[bot] [Thu, 13 Apr 2023 16:46:48 +0000 (16:46 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20230412.1 (#3826)

[main] Update dependencies from dotnet/symstore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Thu, 13 Apr 2023 16:46:37 +0000 (16:46 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230413.2 (#3825)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoImplement !threadpool in C# (#3824)
Lee Culver [Thu, 13 Apr 2023 15:18:29 +0000 (08:18 -0700)]
Implement !threadpool in C# (#3824)

* Add initial ThreadPoolCommand

Only implemented dumping work items.

* Remove -live

* Fix issue with Marshal.SizeOf

Marshal.SizeOf does not allow enums.  Unsafe.SizeOf is what we want here.

* Implement the remainder of ThreadPool

* Use C# version of !threadpool

* Remove ObjectIterator and GCHeap

* Bump clrmd version

* Fix issue with usingPortableCompletionPorts

threadPool.Portable means that we found a PortableThreadPool in the BCL.  We need to check that we found that portable threadpool and also that the PortableIOField is true (or missing), instead of if the portable threadpool exists at all.

* Move cancellation to inside the loop

2 years agoSupport debug connecting to a remote port (#3813)
Thays Grazia [Wed, 12 Apr 2023 21:37:05 +0000 (18:37 -0300)]
Support debug connecting to a remote port (#3813)

* support for connect to remote port

* Fix compilation
Add \n in the last line of dbgshim.h
Remove sleep to attach debugger.
Add exports.

2 years agoReimplement !verifyobj and !dumpruntimetypes (#3811)
Lee Culver [Wed, 12 Apr 2023 21:36:19 +0000 (14:36 -0700)]
Reimplement !verifyobj and !dumpruntimetypes (#3811)

* Update ClrMD Version

* Add C# based VerifyHeap command

* Fix verifyobj command impl

* Add !sos dumpruntimetypes

* Remove dead code

* Remove object verification code

* Remove last use of RefIterator

* Remove RefIterator

* Test updates

* Update src/Microsoft.Diagnostics.ExtensionCommands/ExtensionMethodHelpers.cs

Co-authored-by: Günther Foidl <gue@korporal.at>
* Update src/Microsoft.Diagnostics.ExtensionCommands/VerifyObjectCommand.cs

Co-authored-by: Günther Foidl <gue@korporal.at>
* Fix managed commands

* Update soscommand.cpp

---------

Co-authored-by: Günther Foidl <gue@korporal.at>
2 years agoUpdate Logging and AsyncInterfaces versions (#3819)
Juan Hoyos [Wed, 12 Apr 2023 21:25:40 +0000 (14:25 -0700)]
Update Logging and AsyncInterfaces versions (#3819)

* Update Logging and AsyncInterfaces versions

* Update Versions.props

2 years agoChange lldb behavior for new managed command implementations (#3822)
Lee Culver [Wed, 12 Apr 2023 20:33:06 +0000 (13:33 -0700)]
Change lldb behavior for new managed command implementations (#3822)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Wed, 12 Apr 2023 17:54:49 +0000 (10:54 -0700)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230412.2 (#3820)

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 8.0.0-alpha.1.23211.2 -> To Version 8.0.0-alpha.1.23212.2

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230412.2 (...
dotnet-maestro[bot] [Wed, 12 Apr 2023 17:48:51 +0000 (17:48 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230412.2 (#3821)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230410.11 ...
dotnet-maestro[bot] [Tue, 11 Apr 2023 17:49:42 +0000 (17:49 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230410.11 (#3817)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 11 Apr 2023 17:23:36 +0000 (17:23 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230411.2 (#3814)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoReimplement !traverseheap (#3810)
Lee Culver [Mon, 10 Apr 2023 17:22:32 +0000 (10:22 -0700)]
Reimplement !traverseheap (#3810)

* Add TraverseHeapCommand

* Remove HeapTraverser

* Remove TypeTree

* Remove Flags

2 years agoUpdate ClrMD version (#3804)
Lee Culver [Fri, 7 Apr 2023 00:21:23 +0000 (17:21 -0700)]
Update ClrMD version (#3804)

I moved the the "Generation" enum to ClrMD itself. It's far more useful (and accurate) to talk about an object's generation as a member of an enum which describes it rather than a simple integer. This change flowed through the SOS commands which used ClrSegment.GetGeneration.

I manually tested all commands affected.

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230406.4 (...
dotnet-maestro[bot] [Thu, 6 Apr 2023 16:34:02 +0000 (16:34 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230406.4 (#3807)

[main] Update dependencies from dotnet/aspnetcore

2 years ago[main] Update dependencies from dotnet/source-build-reference-packages (#3787)
dotnet-maestro[bot] [Thu, 6 Apr 2023 15:56:31 +0000 (15:56 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#3787)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agomaddress -orderBySize (#3803)
Lee Culver [Wed, 5 Apr 2023 18:19:23 +0000 (11:19 -0700)]
maddress -orderBySize (#3803)

Added an option to order the output of !maddress by size descending, as requested by the GC team.

2 years agoFix IndexOutOfRangeException (#3800)
Lee Culver [Tue, 4 Apr 2023 19:37:05 +0000 (12:37 -0700)]
Fix IndexOutOfRangeException (#3800)

* Fix IndexOutOfRangeException

Fix an IndexOutOfRangeException with !sos maddress.

* Add initial parts length check

* One more fix

2 years agoAdd !dumpheap fragmentation statistics (#3799)
Lee Culver [Tue, 4 Apr 2023 16:06:28 +0000 (09:06 -0700)]
Add !dumpheap fragmentation statistics (#3799)

In my previous !dumpheap change I overlooked the fragmentation output.  This adds fragmentation output in the exact same was as the previous C++ code.

The new code now validates the Free region is actually followed by the next object, and that those objects do not live on the Pinned, Frozen, or Large object heaps.

2 years agoAdd -list to !sos maddress (#3798)
Lee Culver [Fri, 31 Mar 2023 19:54:25 +0000 (12:54 -0700)]
Add -list to !sos maddress (#3798)

- Added a way to list all kinds of a specific memory type
- Added caching to NativeAddressHelper, as it was recalculating every run

2 years agoFix issue where DmlExec isn't implemented in Repl (#3794)
Lee Culver [Thu, 30 Mar 2023 22:52:22 +0000 (15:52 -0700)]
Fix issue where DmlExec isn't implemented in Repl (#3794)

* Fix issue where DmlExec isn't implemented in Repl

WriteDmlExec is meant to work even if DML is disabled, but the Repl project throws NotSupportedException instead of passing the text argument.

* Write the raw output when DML is present

Also print output when WriteDml is called.  This shouldn't happen in the current codebase, but at least it won't cause the command to stop.

2 years agoImprove !maddress (#3792)
Lee Culver [Thu, 30 Mar 2023 17:50:50 +0000 (10:50 -0700)]
Improve !maddress (#3792)

- Using single '-' instead of '--' for Options to match the rest of SOS
- Change the default behavior of maddress to print the entire list of memory, this matches !address
- Only display the HandleTable if we can efficiently do so (or if the user requests that we show HandleTable data anyway)
- Use the RootCacheService to only walk the handle table once per runtime

2 years agoAdd GC inter-generational analysis commands (#3790)
Lee Culver [Thu, 30 Mar 2023 17:44:47 +0000 (10:44 -0700)]
Add GC inter-generational analysis commands (#3790)

* Add GC inter-generational analysis commands

Added SOS commands requested by the GC team:
!sos FindEphemeralReferencesToLOH - Finds references between gen0/gen1 objects and the Large Object Heap.
!sos FindReferencesToEphemeral Finds all object references which point to a lower generation than the current object
!sos SizeStats - Prints statistics about objects sizes

* Code review feedback

- shorten command names
- check for cancellation
- change a couple of object checks to filter better

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230329.5 (...
dotnet-maestro[bot] [Thu, 30 Mar 2023 16:46:50 +0000 (16:46 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230329.5 (#3791)

[main] Update dependencies from dotnet/aspnetcore

2 years agoTrim away netframework targets in source-build (#3788)
Nikola Milosavljevic [Wed, 29 Mar 2023 19:58:23 +0000 (12:58 -0700)]
Trim away netframework targets in source-build (#3788)

2 years ago[main] Update dependencies from microsoft/clrmd (#3778)
dotnet-maestro[bot] [Wed, 29 Mar 2023 18:08:13 +0000 (18:08 +0000)]
[main] Update dependencies from microsoft/clrmd (#3778)

[main] Update dependencies from microsoft/clrmd

 - Merge branch 'main' into darc-main-ade01c5a-e569-4564-8b2a-7df2f9db90a4

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230328.4 (...
dotnet-maestro[bot] [Wed, 29 Mar 2023 18:04:03 +0000 (18:04 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230328.4 (#3786)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 28 Mar 2023 14:06:02 +0000 (14:06 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230328.3 (#3785)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230327.14 ...
dotnet-maestro[bot] [Tue, 28 Mar 2023 13:29:52 +0000 (13:29 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230327.14 (#3784)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Mon, 27 Mar 2023 17:02:03 +0000 (17:02 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230327.1 (#3783)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230325.2 (...
dotnet-maestro[bot] [Sun, 26 Mar 2023 18:20:40 +0000 (18:20 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230325.2 (#3781)

[main] Update dependencies from dotnet/aspnetcore

2 years ago[main] Update dependencies from dotnet/source-build-reference-packages (#3776)
dotnet-maestro[bot] [Sat, 25 Mar 2023 13:45:22 +0000 (13:45 +0000)]
[main] Update dependencies from dotnet/source-build-reference-packages (#3776)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230324.11 ...
dotnet-maestro[bot] [Sat, 25 Mar 2023 13:22:16 +0000 (13:22 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230324.11 (#3780)

[main] Update dependencies from dotnet/aspnetcore

2 years ago[main] Update dependencies from dotnet/aspnetcore (#3775)
dotnet-maestro[bot] [Fri, 24 Mar 2023 17:50:41 +0000 (17:50 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#3775)

[main] Update dependencies from dotnet/aspnetcore

2 years agoFix !gcroot issue (#3777)
Lee Culver [Thu, 23 Mar 2023 18:54:33 +0000 (11:54 -0700)]
Fix !gcroot issue (#3777)

* Fix !gcroot issue

Update ClrMD to apply proposed fix for stack/handle walking

* Update ClrMD

* Remove stopwatch output

2 years agoRemove GCRootImpl - reimplement commands in C# (#3766)
Lee Culver [Tue, 21 Mar 2023 23:10:03 +0000 (16:10 -0700)]
Remove GCRootImpl - reimplement commands in C# (#3766)

* Add TableOutput.Indent

* Add GCRootComamnd

* Incorrect ArgumentNullException

* Add source resolution

* Minor cleanup

* Update ClrMD version

* Add PathTo command

* Minor fixes

* Split DumpHeapCommand into a command and service

* Initial ObjSize implementation

* RootCache cleanup

* Fix spacing

* Fix ObjSize

* Add !gcroot helper for !findroots

* Implement !analyzeoom

* Remove !fq dependency on GCRootImpl

* Excise GcRootImpl

* Managed implementation of !gcheapstat

* Remove dead code

* Update NotReachableInRangeCommand.cs

* Update ClrMD version

* Replace HelperCommandAttribute with a property

* Fix issue with IL offsets

* Update scripts for new output

* Update SymbolService.DownloadPE to find PDBs

* Fix spacing issue

* Fix exception issue

* Fix spacing issue

* Remove -all from tests

We now always print all roots

* Temporarily disable gcroot PDB testing

* Remove added using

* Remove explicit gcroot from SOSCommand

* Remove ShowInHelp

* Update ClrMD version

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 21 Mar 2023 13:42:59 +0000 (13:42 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230320.3 (#3773)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230321.1 (...
dotnet-maestro[bot] [Tue, 21 Mar 2023 13:38:24 +0000 (13:38 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230321.1 (#3770)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230319.3 (#3771)
dotnet-maestro[bot] [Tue, 21 Mar 2023 13:28:26 +0000 (13:28 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230319.3 (#3771)

[main] Update dependencies from microsoft/clrmd

2 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20230320.1 (#3772)
dotnet-maestro[bot] [Tue, 21 Mar 2023 13:24:07 +0000 (13:24 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20230320.1 (#3772)

[main] Update dependencies from dotnet/symstore

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230319.3 (...
dotnet-maestro[bot] [Mon, 20 Mar 2023 16:38:09 +0000 (16:38 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230319.3 (#3768)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/arcade build 20230318.1 (#3767)
dotnet-maestro[bot] [Mon, 20 Mar 2023 13:32:10 +0000 (13:32 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 20230318.1 (#3767)

[main] Update dependencies from dotnet/arcade
- Coherency Updates:
  - Microsoft.SourceLink.GitHub: from 1.2.0-beta-23117-02 to 1.2.0-beta-23165-02 (parent: Microsoft.DotNet.Arcade.Sdk)

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230317.3 (#3764)
dotnet-maestro[bot] [Sat, 18 Mar 2023 16:46:02 +0000 (16:46 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230317.3 (#3764)

[main] Update dependencies from microsoft/clrmd

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Sat, 18 Mar 2023 13:23:55 +0000 (13:23 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230317.2 (#3765)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230317.7 (...
dotnet-maestro[bot] [Sat, 18 Mar 2023 13:22:54 +0000 (13:22 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230317.7 (#3763)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Fri, 17 Mar 2023 13:57:20 +0000 (13:57 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230316.3 (#3760)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230316.2 (#3759)
dotnet-maestro[bot] [Fri, 17 Mar 2023 13:28:45 +0000 (13:28 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230316.2 (#3759)

[main] Update dependencies from microsoft/clrmd

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230317.1 (...
dotnet-maestro[bot] [Fri, 17 Mar 2023 13:27:29 +0000 (13:27 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230317.1 (#3758)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230315.1 (#3754)
dotnet-maestro[bot] [Thu, 16 Mar 2023 15:26:58 +0000 (08:26 -0700)]
Update dependencies from https://github.com/microsoft/clrmd build 20230315.1 (#3754)

Microsoft.Diagnostics.Runtime , Microsoft.Diagnostics.Runtime.Utilities
 From Version 3.0.0-beta.23164.1 -> To Version 3.0.0-beta.23165.1

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Thu, 16 Mar 2023 13:44:22 +0000 (13:44 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230315.1 (#3755)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230315.6 (...
dotnet-maestro[bot] [Thu, 16 Mar 2023 13:21:59 +0000 (13:21 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230315.6 (#3753)

[main] Update dependencies from dotnet/aspnetcore

2 years agoAdd AssemblyLoadContext for loading extensions (#3649)
Mike McLaughlin [Wed, 15 Mar 2023 22:46:08 +0000 (15:46 -0700)]
Add AssemblyLoadContext for loading extensions (#3649)

* Add AssemblyLoadContext for loading extensions

Add and use ServiceManager.NotifyExtensionLoadFailure event.

Replace Provider scope with ProviderExport attribute

Removing the DAC or DBI check in GetLocalPath() keeps invalid DACs or DBIs
from being loaded if in the current directory. The download path will find
a DAC in the same directory as the core dump when under dotnet-dump.

Update extensibility doc

* Update to 7.0.3 and 6.0.14

* Change the context service ordering to prevent creating runtimes if not needed

* Fix analyzer issues

* Fix overflow in WebApp tests

* Code review feedback

* Fix desktop SOS tests

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Wed, 15 Mar 2023 13:52:17 +0000 (13:52 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230314.1 (#3752)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years ago[main] Update dependencies from dotnet/aspnetcore (#3744)
dotnet-maestro[bot] [Wed, 15 Mar 2023 13:24:47 +0000 (13:24 +0000)]
[main] Update dependencies from dotnet/aspnetcore (#3744)

[main] Update dependencies from dotnet/aspnetcore

2 years agoAdd a way to filter !eeheap (#3750)
Lee Culver [Wed, 15 Mar 2023 00:49:46 +0000 (17:49 -0700)]
Add a way to filter !eeheap (#3750)

* Add a way to filter !eeheap

- !eeheap now only operates on the currently selected runtime (again)
- Maoni requested a feature where we can give filters to !eeheap, as its output can be too long and detailed on larger dumps
- Added the same -segment, -heap, and [memory, range] arguments to !eeheap to filter the output down to the requested ranges, segments, or heaps.
- Loader/Modules heaps will also be filtered by "[memory, range]" (not not -heap and -segment).
- Changed "Total" to "Partial" whenever we filter the heap.  e.g. 'Total bytes consumed by CLR' -> 'Partial bytes consumed by CLR'.

* Add DML to !eeheap -gc

* Fix format mistake

2 years agoImprove/reimplement !listnearobj and !gcwhere (#3748)
Lee Culver [Wed, 15 Mar 2023 00:49:20 +0000 (17:49 -0700)]
Improve/reimplement !listnearobj and !gcwhere (#3748)

* Update ClrMD version

* Add !gcwhere, !listnearobj commands

* Update ListNearObjCommand.cs

* Use C# versions, remove dead code

* Fix command name

* Output fixes

* Fix build warning

* Test fixes

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230313.4 (#3745)
dotnet-maestro[bot] [Tue, 14 Mar 2023 17:46:55 +0000 (17:46 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230313.4 (#3745)

[main] Update dependencies from microsoft/clrmd

2 years agoReimplement !dumpheap and !verifyheap in C# (#3738)
Lee Culver [Tue, 14 Mar 2023 17:30:22 +0000 (10:30 -0700)]
Reimplement !dumpheap and !verifyheap in C# (#3738)

* C# !verifyheap implementation

* Bump ClrMD version

* Add DML support to TableOutput

* Add Segment filter, clean up parsing

* Cleanups

* Allow cancellation

* Remove test code, cleanup

* Add SimulateGCHeapCorruption

* Output improvements

* Update VerifyHeapCommand.cs

* Add class to filter segments and objects

* Initial DumpHeap command

* Initial !dumpheap implementation

Still needs -thinlocks and -string.

* Cleanups and timer output

* Add -strings support

* Update C++ commands to use C# verify/dump heap

* CodeFormatting fixes

* Better Sanitize method

Co-authored-by: Günther Foidl <gue@korporal.at>
* Fix Span issue

Co-authored-by: Günther Foidl <gue@korporal.at>
* Fix a few warnings

* Use pattern matching in FileLoggingConsoleService

* Update ClrMD version

* Remove accidental include

* Implement !dumpheap -thinlock

* Fix CommandLine parsing

* Handle invalid objects

* Test fixes

* Add back MINIDUMP_NOT_SUPPORTED

* Fix concurrent dictionary tests

* Fix DECVAL

* Fix DECVAL again

* Fix !verifyheap failures

* Fix coding style

* Code review feedback

* Fix !dumpobj format

* Fix DML issues

---------

Co-authored-by: Günther Foidl <gue@korporal.at>
2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 14 Mar 2023 13:48:08 +0000 (13:48 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230313.2 (#3747)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/symstore build 20230313.1 (#3746)
dotnet-maestro[bot] [Tue, 14 Mar 2023 13:22:59 +0000 (13:22 +0000)]
Update dependencies from https://github.com/dotnet/symstore build 20230313.1 (#3746)

[main] Update dependencies from dotnet/symstore

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230311.5 (#3740)
dotnet-maestro[bot] [Sun, 12 Mar 2023 18:49:44 +0000 (18:49 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230311.5 (#3740)

[main] Update dependencies from microsoft/clrmd

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230310.17 ...
dotnet-maestro[bot] [Sat, 11 Mar 2023 14:20:06 +0000 (14:20 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230310.17 (#3739)

[main] Update dependencies from dotnet/aspnetcore

2 years agoAdd analyzers, fix issues detected by them, style enforcement, and some misc bugs...
Juan Hoyos [Sat, 11 Mar 2023 01:00:25 +0000 (17:00 -0800)]
Add analyzers, fix issues detected by them, style enforcement, and some misc bugs in SOSRunner (#3721)

Enforcement of style to be consistent with dotnet/runtime.
Enable more analyzers that are compliant with SDL requirements.
Misc bug fixes around sync contexts and async IO.
Use some utility methods available in .NET 6 when possible.

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230309.7 (#3734)
dotnet-maestro[bot] [Fri, 10 Mar 2023 19:25:10 +0000 (19:25 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230309.7 (#3734)

[main] Update dependencies from microsoft/clrmd

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Fri, 10 Mar 2023 18:47:29 +0000 (18:47 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230309.2 (#3735)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230309.10 ...
dotnet-maestro[bot] [Fri, 10 Mar 2023 18:43:45 +0000 (18:43 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230309.10 (#3733)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230309.2 (...
dotnet-maestro[bot] [Thu, 9 Mar 2023 14:36:16 +0000 (14:36 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230309.2 (#3731)

[main] Update dependencies from dotnet/aspnetcore

2 years agoUpdate dependencies from https://github.com/microsoft/clrmd build 20230309.1 (#3732)
dotnet-maestro[bot] [Thu, 9 Mar 2023 14:26:18 +0000 (14:26 +0000)]
Update dependencies from https://github.com/microsoft/clrmd build 20230309.1 (#3732)

[main] Update dependencies from microsoft/clrmd

2 years ago[main] Update dependencies from microsoft/clrmd (#3723)
dotnet-maestro[bot] [Thu, 9 Mar 2023 04:57:27 +0000 (20:57 -0800)]
[main] Update dependencies from microsoft/clrmd (#3723)

* Update dependencies from https://github.com/microsoft/clrmd build 20230306.2

Microsoft.Diagnostics.Runtime , Microsoft.Diagnostics.Runtime.Utilities
 From Version 3.0.0-beta.23155.1 -> To Version 3.0.0-beta.23156.2

* Updates for ClrMD 3.0 changes

---------

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Lee Culver <leculver@microsoft.com>
2 years ago[Dotnet Monitor] Adding `SystemDiagnosticsMetrics` Trigger (#3697)
kkeirstead [Wed, 8 Mar 2023 22:03:30 +0000 (14:03 -0800)]
[Dotnet Monitor] Adding `SystemDiagnosticsMetrics` Trigger (#3697)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Wed, 8 Mar 2023 14:37:46 +0000 (14:37 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230307.4 (#3729)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230307.27 ...
dotnet-maestro[bot] [Wed, 8 Mar 2023 14:22:18 +0000 (14:22 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230307.27 (#3728)

[main] Update dependencies from dotnet/aspnetcore

2 years agoHandle exception in System.Console.SetCursorPosition in some environments for dotnet...
Hyungju Lee [Wed, 8 Mar 2023 10:11:48 +0000 (19:11 +0900)]
Handle exception in System.Console.SetCursorPosition in some environments for dotnet-* tools (#3678)

2 years agoUpdate dependencies from https://github.com/dotnet/source-build-reference-packages...
dotnet-maestro[bot] [Tue, 7 Mar 2023 14:54:17 +0000 (14:54 +0000)]
Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20230306.5 (#3725)

[main] Update dependencies from dotnet/source-build-reference-packages

2 years agoUpdate dependencies from https://github.com/dotnet/aspnetcore build 20230307.1 (...
dotnet-maestro[bot] [Tue, 7 Mar 2023 14:36:20 +0000 (14:36 +0000)]
Update dependencies from https://github.com/dotnet/aspnetcore build 20230307.1 (#3722)

[main] Update dependencies from dotnet/aspnetcore