Tanner Gooding [Tue, 20 Nov 2018 20:01:25 +0000 (12:01 -0800)]
Fixing up some issues with the HWIntrinsic test templates (#21104)
* Updating the VectorNotSupportedTest to throw on failure
* Updating the HWIntrinsic test templates to check success on a per-scenario basis
* Regenerating the templated HWIntrinsic tests
Stephen Toub [Tue, 20 Nov 2018 19:58:47 +0000 (14:58 -0500)]
Replace custom AnsiToLower with more efficient ToLowerAsciiInvariant (#21121)
Avoids all of the StringBuilder-related costs.
Jan Kotas [Tue, 20 Nov 2018 18:56:12 +0000 (10:56 -0800)]
Delete CORCOMPILE_IMPORT_TABLE_ENTRY (#21109)
Tom Deseyn [Tue, 20 Nov 2018 18:52:46 +0000 (19:52 +0100)]
Linux: FlushProcessWriteBuffers using membarrier when available (#20949)
* Linux: FlushProcessWriteBuffers using membarrier when available
* Ensure __NR_membarrier is defined for x64 portable build.
* Define __NR_membarrier on all portable architectures
Tanner Gooding [Tue, 20 Nov 2018 15:56:52 +0000 (07:56 -0800)]
Adding some AggressiveInlining attributes to the Vector64/128/256 helper methods (#21111)
dotnet-maestro[bot] [Tue, 20 Nov 2018 14:53:47 +0000 (14:53 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 402 (#21118)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18569.4
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18569.4
Stephen Toub [Tue, 20 Nov 2018 10:08:00 +0000 (05:08 -0500)]
Improve async iterator exception stack traces (#21103)
- The current stack trace prettying logic assumes that a method only has one StateMachineAttribute, but that's no longer true with async iterators, which (at least with the current implementation) can have both an AsyncStateMachineAttribute and an IteratorStateMachineAttribute. As such, we change the prettying logic to look through all StateMachineAttributes rather than stopping at the first one.
- ManualResetValueTaskSourceCore.GetResult is responsible for propagating exceptions, but it's infrastructure and isn't particularly meaningful in a call stack. Hide it from the stack trace, as we do for other such GetResult methods in Task and ValueTask.
Sergey Andreenko [Tue, 20 Nov 2018 05:53:14 +0000 (21:53 -0800)]
Make code in `getTargetMethodDesc` more reliable. (#21101)
* Make code in `getTargetMethodDesc` more reliable.
Fixes DevDiv_723667.
* change the condition to make sure that we do not have false true cases.
Sergey Andreenko [Tue, 20 Nov 2018 05:39:49 +0000 (21:39 -0800)]
format spmi sources (#21094)
We do not do it automatically because we do not change it often.
Hugh Bellamy [Tue, 20 Nov 2018 05:31:30 +0000 (05:31 +0000)]
Cleanup System.Reflection.Emit code and delete dead code (#21086)
* Cleanup System.Reflection.Emit code
* Delete dead code from System.Reflection.Emit
Jan Kotas [Tue, 20 Nov 2018 05:30:40 +0000 (21:30 -0800)]
Update xunit version to match corefx (#21098)
* Update xunit version to match corefx
Fixes https://github.com/dotnet/corefx/issues/33587
* Disabled outdated test
Carol Eidt [Tue, 20 Nov 2018 03:43:03 +0000 (19:43 -0800)]
Add asserts for the types of the Span indexers. (#21037)
Also, add a test for #20958
Omair Majid [Tue, 20 Nov 2018 00:32:13 +0000 (19:32 -0500)]
Fix search for headers and libraries via LLVM_HOME (#21084)
Commit
b89e2305 (PR #18873) renamed WITH_LLDB_LIBS to LLDB_LIB_DIR and
WITH_LLDB_INCLUDES to LLDB_INCLUDE_DIR. But it forgot to update the
usage of these variables in some find_library and find_path calls.
As a result, setting LLVM_HOME is no longer enough to compile coreclr on
platforms with non-standard locations for lldb. This commit fixes that.
Tarek Mahmoud Sayed [Mon, 19 Nov 2018 20:50:33 +0000 (12:50 -0800)]
Fix Getting Max Japanese Era (#21087)
We were using the ICU API ucal_getLimit and askin gto get the maximum value of the Japanese eras. it looks this API is just return the era matching the current system clock which prevent returning any future defined era in the system (which ICU 63.1 can support with some environment variable).
We raised the issue to the ICU owners but would be better just to get the era of Gregorian year 9999 which always should return the max era anyway.
Stephen Toub [Mon, 19 Nov 2018 20:45:25 +0000 (15:45 -0500)]
Disable stale sockets test (#21083)
Hugh Bellamy [Sat, 17 Nov 2018 19:05:39 +0000 (19:05 +0000)]
Cleanup RtType.cs code
Hugh Bellamy [Sat, 17 Nov 2018 18:45:30 +0000 (18:45 +0000)]
Fix Type.GetInterface for null namespace and non-null interface namespace
dotnet-maestro[bot] [Mon, 19 Nov 2018 15:23:43 +0000 (15:23 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 385 (#21082)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18568.1
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18568.1
Jacek Blaszczynski [Mon, 19 Nov 2018 11:29:11 +0000 (12:29 +0100)]
Add headers to crossgen, cee_crossgen, corzap_crossgen vcxproj files (#20082)
Michal Strehovský [Mon, 19 Nov 2018 08:23:22 +0000 (09:23 +0100)]
Make type comparisons more general purpose (#20940)
This has two parts:
## Part 1
CoreRT represents native type handles differently from CoreCLR - on CoreCLR, `RuntimeTypeHandle` is a wrapper over `RuntimeType` and RyuJIT is aware of that. On CoreRT, `RuntimeTypeHandle` wraps the native type handle, not a `RuntimeType`.
The knowledge is hardcoded in importer when importing the sequence "ldtoken foo / call Type.GetTypeFromHandle" - importer just removes the call and bashes the result of ldtoken to be a reference type. CoreRT had to avoid reporting `Type.GetTypeFromHandle` as an intrinsic because of that.
I'm adding another helper that lets RyuJIT avoid hardcoding that knowledge. Instead of just bashing the return type, we swap the helper call.
## Part 2
Native type handle equality checks need to go through a helper, unless the EE side says it's okay to compare native type handles directly.
Ben Adams [Mon, 19 Nov 2018 06:18:57 +0000 (06:18 +0000)]
Single pass Vectorize Span<byte>.IndexOfAny(..., ReadOnlySpan<byte>) for 2,3 lengths (#20738)
Jacek Blaszczynski [Sun, 18 Nov 2018 20:08:31 +0000 (21:08 +0100)]
Add headers to all md*, v3binder*, and ceefgen vcxproj (#20163)
Work toward #14884
Hugh Bellamy [Sun, 18 Nov 2018 18:31:28 +0000 (18:31 +0000)]
Add ICustomMarshaler tests (#19195)
* Add ICustomMarshaler tests
dotnet-maestro[bot] [Sun, 18 Nov 2018 14:50:14 +0000 (14:50 +0000)]
Update dependency files (#21067)
* Update dependencies from https://github.com/dotnet/arcade build 379
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18566.6
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18566.6
* Update dependencies from https://github.com/dotnet/arcade build 382
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18567.1
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18567.1
Hugh Bellamy [Sun, 18 Nov 2018 04:08:27 +0000 (04:08 +0000)]
Fix incorrect exception thrown in Marshal.ReleaseComObject(null) (#21072)
Tanner Gooding [Sat, 17 Nov 2018 18:24:58 +0000 (10:24 -0800)]
Removing the legacy helper intrinsics and adding tests for their replacements (#20994)
* Removing helper intrinsics from the x86 APIs in S.P.Corelib
* Removing JIT support for the removed x86 helper intrinsics
* Removing the x86 HardwareIntrinsics tests for the removed helper APIs
* Fixing up existing usages to no longer use the removed x86 helper intrinsics
* Skip CoreFX tests dependent on the removed x86 helper intrinsics
* Adding a GenerateTests.csx and templates for the new shared helper intrinsics
* Generating the new shared helper intrinsics from their templates
* Disabling some tests for arm and arm64 that are failing due to an assert
Egor Chesakov [Sat, 17 Nov 2018 18:20:13 +0000 (10:20 -0800)]
Force Unicode in test_location parameter in delete_existing_wrappers() (#21056)
Nick Craver [Sat, 17 Nov 2018 08:11:54 +0000 (03:11 -0500)]
Optimization: Further reduce allocations in GetCustomAtttributes() paths (#20795)
* Remove PseudoCustomAttribute allocations
Inside CustomAttribute, PseudoCustomAttribute is the mechanism used to return Attribute instances for what are really flags and such underneath in most cases. This is just an implentation detail, but this detail creates an intermediate array just for passing things around inside CustomAttribute...that's not necessary. This replaces the Attribute[] allocations with the ListBuilder<Attribute> struct for accumulating and relaying this attributes to parent methods.
Many overloads had a lot of duplicate coalescing code on this path as well...DRYed up that series of methods.
This change reduces allocation overhead for all calls by 40 bytes. In the case of a miss where none would be returned (e.g. .GetCustomAttributes<Attribute>() on a non-attributed class), this reduces allocations down to zero.
* CustomAttribute: split GetCustomAttributes into total and additive use cases
The split here was simple, but allocated an extra intermediate array for each parent type when searching for attributes in the inheritance case. Instead of doing that, we now move that to the second use case exclusively (which uses/returns the array created). The other use case adds to the ListBuilder<object> struct to accumulate through the inheritance hierarchy crawl (rather than an after-the-fact copy).
Note some parameter removals on the filter side...those weren't used already (and got in the way of this change).
* CustomAttributes: Cleanup of unused ops
Just removing the cruft that isn't actually used in here anymore (some of it in quite some time). Trivial amounts of speed gain, but every little bit helps!
* Param typo and red passing for GetCombinedList()
* Assume zero pseudo attributes by default (the most likely case)
Thsi eats the resize on the > 1 case, but that's so rare it's a net win to start with 0 here.
* Pseudo attributes: use out instead of return
A bit if a performance boost from the struct copy removal
* Pseudo attributes: switch to out everywhere and remove uneeded code paths
In relation to #20795, these old calls seem to be for consistency but they're not likely to change and a comment (I think) accomplishes the same goal with less code...so here's a commit demonstrating it.
* Comment spacing for pseudo attribute fetching
Make it clear that pseudo attributes are a distinct thing (e.g. why not in *this* method) than the return line.
Sergey Andreenko [Sat, 17 Nov 2018 01:38:00 +0000 (17:38 -0800)]
Exclude GC stress failure test. (#21059)
Sergey Andreenko [Sat, 17 Nov 2018 00:51:12 +0000 (16:51 -0800)]
Exclude tests from GCStress failing due to 21044 (#21060)
Bruce Forstall [Sat, 17 Nov 2018 00:42:58 +0000 (16:42 -0800)]
Merge pull request #21004 from BruceForstall/UpdateRuntestHelp
Update help output of runtest.cmd/sh
Zeng Jiang [Sat, 17 Nov 2018 00:25:43 +0000 (08:25 +0800)]
Add PInvoke/Decimal tests (#19301)
* Add PInvoke/Decimal Tests
* Remove tests that fail on both .NET Framework and .NET Core.
* Refactor away the Windows-only headers.
* Make Decimal tests build on Linux.
* Remove some dead code.
* Clean up formatting.
* Don't run Decimal <--> Currency tests off-Windows.
* Make calling conventions and parameter/return marshalling more explicit
Jan Kotas [Fri, 16 Nov 2018 21:00:41 +0000 (13:00 -0800)]
Delete unnecessary StackCrawlMarks in RtFieldInfo (#21054)
Left over from Code Access Security
Fixes #20965
Jan Vorlicek [Fri, 16 Nov 2018 18:08:29 +0000 (19:08 +0100)]
Fix unloadability races (#21024)
* Fix LoaderAllocator::AllocateHandle
When another thread wins the race in growing the handle table, the code
was not refreshing the slotsUsed local to the new up to date value. This
was leading to overwriting / reusing a live handle.
This change fixes it.
* Embed ThreadLocalBlock in Thread
Instead of allocating ThreadLocalBlock dynamically, embed it in the
Thread. That solves race issue between thread destruction and
LoaderAllocator destruction. The ThreadLocalBlock could have been
deleted during Thread shutdown while the LoaderAllocator's destruction
would be working with it.
Tarek Mahmoud Sayed [Fri, 16 Nov 2018 17:02:02 +0000 (09:02 -0800)]
Fix Formatting Japanese First Year on Linux (#21039)
When formatting the first year with Gannen symbol we are checking if the year is followed by single quote which this is the case on Windows but it is not neccessay the case on Linux
Jan Kotas [Fri, 16 Nov 2018 07:11:28 +0000 (23:11 -0800)]
Add workaround for https://github.com/dotnet/coreclr/issues/21051
Jan Kotas [Fri, 16 Nov 2018 06:33:52 +0000 (22:33 -0800)]
Add explicit signatures for Span indexer
Fixes #21032 and #20958
Dan Moseley [Fri, 16 Nov 2018 15:14:11 +0000 (07:14 -0800)]
Eliminate CMAKE dependency when not required (#21040)
dotnet-maestro[bot] [Fri, 16 Nov 2018 14:53:21 +0000 (14:53 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 365 (#21052)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18565.9
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18565.9
Jeremy Koritzinsky [Fri, 16 Nov 2018 07:48:16 +0000 (23:48 -0800)]
Add simple tests for ArrayWithOffset marshaling. (#21013)
* Add simple tests for ArrayWithOffset marshaling.
* PR Feedback.
* Fix visibility
* Fix DllImport library name
Zeng Jiang [Fri, 16 Nov 2018 07:47:51 +0000 (15:47 +0800)]
Add Interop/PInvoke/Attributes tests (#19107)
* Add Interop/PInvoke/Attributes tests
* Fix PR comments
* Fix compile warnings
* Remove comment
* Clean up test files to match current build system.
* Fix up test and make it windows only (as FEATURE_LCID is only enabled on Windows)
* Fixed string const issues.
Zeng Jiang [Fri, 16 Nov 2018 07:46:51 +0000 (15:46 +0800)]
Add PInvoke/CriticalHandles tests (#19297)
* Add PInvoke/CreticalHandles tests
* Bring up to current infrastructure.
* Fix ReverseTest.
Jan Kotas [Fri, 16 Nov 2018 03:35:35 +0000 (19:35 -0800)]
Delete HAS_FLS_SUPPORT and related code (#21035)
szehetner [Fri, 16 Nov 2018 02:14:03 +0000 (03:14 +0100)]
Fixed signatures of ref readonly methods in JIT ETW events (#20981)
* fixed ETW method signature of ref readonly methods
* added type token
* extract method for printing classes
* fixed optional_modifier, use CorSigUncompressToken_EndPtr
Zeng Jiang [Fri, 16 Nov 2018 01:49:41 +0000 (09:49 +0800)]
Add PInvoke/SafeHandles tests (#19330)
* Add PInvoke/SafeHandles tests
* Fix compile warnings - include header file with relative path
* Run SafeHandle tests only on Windows. The tests are very Windows-centric, so we'd have to do quite a bit of a re-write to get them working xplat.
* Fix CMake project references.
* Fix interface CMakeLists project reference.
* Add casts for string literals.
* Use LPOLESTR and the W macro instead of OLECHAR* cast and L prefix.
Jeremy Koritzinsky [Fri, 16 Nov 2018 01:16:11 +0000 (17:16 -0800)]
Add Tests for VBByRefStr marshalling (#20982)
* Add tests for VBByRefStr marshalling.
* Compile native for VBByRefStr on all platforms.
* Fix encoding.
* PR Feedback.
* Fix PInvokeDefs file.
* Fix visibility
Jeremy Koritzinsky [Fri, 16 Nov 2018 01:14:35 +0000 (17:14 -0800)]
Add tests for marshalling as VARIANT_BOOL or VARIANT (#20856)
* Add native side impl for VARIANT_BOOL test.
* More bool native code.
* Add VariantBool marshalling tests.
* Add infrastructure for tests for object -> VARIANT marshalling.
* Add variant tests for all built-in types.
* Clean up Variant tests.
* Add test for passing custom structure as object.
* Add test for VARIANT_BOOL byref.
* Added byref tests for VARIANT marshalling.
* Add field marshalling tests for VARIANT.
* Move ByValue tests to not have two sources of truth.
* Make managed code the one source of truth.
* Clean up formatting/unused methods.
* Clean up some whitespace issues.
* Add tests for BStrWrapper and CurrencyWrapper marshalling.
* Add UnknownWrapper tests.
* Add a test for VariantWrapper and PInvoke.
* PR Feedback.
* Remove ToString.
* Fix visibility
* Fix MSBuild import path.
* Clean up Variant tests.
dotnet-maestro-bot [Fri, 16 Nov 2018 00:37:39 +0000 (16:37 -0800)]
Update BuildTools, CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview1-03415-01, preview-27115-03, preview.18565.4, preview-27115-04, master-
20181115-0045, master-
20181115-0044, respectively (#21005)
Zeng Jiang [Fri, 16 Nov 2018 00:31:38 +0000 (08:31 +0800)]
Add PInvoke/SizeParamIndex tests (#19348)
* Add PInvoke/SizeParamIndex tests
* Fix compile warnings
* First pass cleaning up native code.
* Get ParamSizeIndex tests working xplat (excluding the BSTR array tests)
* Fix incorrect definition of ULONG off-windows.
* Disable reverse-PInvoke throwing test off-Windows.
Egor Chesakov [Thu, 15 Nov 2018 22:53:08 +0000 (14:53 -0800)]
Stop using Hostx86/arm crossgen in crossgen_comparison scenario (#21021)
* And also create Linux arm64 crossgen_comparison scenarios in netci.groovy
Zeng Jiang [Thu, 15 Nov 2018 22:51:02 +0000 (06:51 +0800)]
Add PInvoke/DllImportpath tests (#19270)
* Add PInvoke/DllImportpath tests
* Refactor test to current toolset and remove Windows-only Path API searching.
* Remove explicit calling convention from managed and add correct convention to test.
* Get environment test passing on Unix.
* Update test to pass off-Windows.
* Include feature/platform defines in tests.
* Fix environment test (again).
* Remove zero-width character that's breaking CI
* Fix zero-width character I missed.
* Remove invalid parens around LD_LIBRARY_PATH
* Ensure the path added to the LD_LIBRARY_PATH exists before the test starts.
* Combine all DllImportPath CMakeLists.txt files into one file.
* Include clr.coreclr.props when also including clr.defines.targets so we get the feature defines correctly as well.
* Disable unicode test for our OSX 10.12 CI builds.
Jeremy Koritzinsky [Thu, 15 Nov 2018 22:50:00 +0000 (14:50 -0800)]
Add tests for ANSI BSTRs (#20985)
* Add tests for ANSI BSTRs
* Fix signed/unsigned mismatch in comparisons. Add xplatform include
* Use regular memcpy
* Enable ANSI BSTR off-windows.
* Also enable UnmanagedType.TBStr off-Windows since both BStr variants are available off-Windows.
* Make sure the AnsiBSTR marshaller is hooked up off-Windows.
* Remove a few more ifdefs I missed.
* remove ifdefs around binder definitions and the C# stub helpers.
* PR Feedback.
* Add xplat ARRAYSIZE macro
* Move xplat ARRAYSIZE to platformdefines.h
Brian Sullivan [Thu, 15 Nov 2018 22:45:02 +0000 (14:45 -0800)]
Merge pull request #21008 from briansull/new-toolset
Fix warnings from the new toolset
Morgan Brown [Thu, 15 Nov 2018 22:23:58 +0000 (14:23 -0800)]
Fixes for Azure DevOps official build (#21017)
* Fix endpoint for internal jobs
Fix external vs internal queues
Properly quote scenarios argument to msbuild
Increase queue timeout since most P1 jobs couldn't finish in time
Levi Broderick [Thu, 15 Nov 2018 21:56:55 +0000 (13:56 -0800)]
Allow rune enumeration from string and ROS<char> (#21007)
Zeng Jiang [Thu, 15 Nov 2018 21:32:25 +0000 (05:32 +0800)]
Add PInvoke/Array tests (#19266)
* Add PInvoke/Array tests
* Fix compile warnings
* Get tests passing on Windows again.
* Change error_t type to work xplat.
* Change error_t in types.h as well
* Clean up build slightly.
* PR feedback and native test code refactoring.
* Clean up header.
* Add a xplat implementation of _itoa_s for our tests.
* CHAR -> char
* Make calling convention cdecl to avoid stdcall mangling.
* Make return test native code cdecl as well (missed it before).
* Fix bug in platformdefines _itoa_s
* Return early in TP_itoX_s when num == 0
David Wrighton [Thu, 15 Nov 2018 20:06:08 +0000 (12:06 -0800)]
Update CrstTypeTool to produce spaces (#21029)
Brian Sullivan [Thu, 15 Nov 2018 19:32:47 +0000 (11:32 -0800)]
Changed back to use m_filtered
Brian Sullivan [Thu, 15 Nov 2018 19:03:59 +0000 (11:03 -0800)]
Code Review feedback
Egor Chesakov [Thu, 15 Nov 2018 18:43:05 +0000 (10:43 -0800)]
Combine ExcludeList in AltJit scenarios for both host and altjit archs (#21018)
* Add -altjitarch command line argument in tests/runtest.cmd and -altjit_arch in tests/runtest.py
* Specify altjitarch in for x86_arm_altjit and x64_arm64_altjit jobs in netci.groovy
* Use AltJitArch MSBuild variable in tests/issues.targets to exclude tests based on either BuildArch or AltJitArch since both two JITs are running in altjit scenarios
Zeng Jiang [Thu, 15 Nov 2018 18:10:25 +0000 (02:10 +0800)]
Add PInvoke/Miscellaneous tests (#19326)
* Add PInvoke/Miscellaneous tests
* Clean up HandleRef test.
Pent Ploompuu [Thu, 15 Nov 2018 17:04:19 +0000 (19:04 +0200)]
Update Unicode data and optimize CharUnicodeInfo indexes (#20983)
* Update Unicode data and optimize CharUnicodeInfo indexes
* Add new GenUnicodeProp to tools
* Add licence headers
* Add big-endian support
dotnet-maestro[bot] [Thu, 15 Nov 2018 15:08:32 +0000 (15:08 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 347 (#21023)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18564.20
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18564.20
Michal Strehovský [Thu, 15 Nov 2018 13:08:27 +0000 (14:08 +0100)]
Allow supressing exceptions in diamond inheritance cases (#20458)
Aaron Robinson [Thu, 15 Nov 2018 07:37:45 +0000 (23:37 -0800)]
Re-enable optimizations in interop helper functions. (#21016)
Aaron Robinson [Thu, 15 Nov 2018 02:54:12 +0000 (18:54 -0800)]
Fix invalid tests for COM native server (#21012)
Aaron Robinson [Thu, 15 Nov 2018 02:52:35 +0000 (18:52 -0800)]
Disable COM tests being CrossGen'd (#21010)
* Disable running CrossGen on COM tests since the CrossGen tool doesn't support app manifests on Windows.
* Update ObjectStackAllocation test to use MSBuild property to disable CrossGen support.
Jeremy Koritzinsky [Wed, 14 Nov 2018 23:18:23 +0000 (15:18 -0800)]
Add test for marshalling ArgIterators on Windows (#20888)
* Add (windows-only) tests for __arglist and ArgIterator marshalling.
* Add explicit calling convention notation to pinvokes.
* Add license header
* Update VarargsTest.cs
* Fix calling conventions.
* PR Feedback
* Add explicit calling convention.
* Update VarargsNative.cpp
* Don't reference System.Private.Corelib directly
Brian Sullivan [Wed, 14 Nov 2018 22:20:26 +0000 (14:20 -0800)]
Use correct printf type specifier
Brian Sullivan [Wed, 14 Nov 2018 21:40:55 +0000 (13:40 -0800)]
Jit changes from the desktop Toolset Update
Bruce Forstall [Wed, 14 Nov 2018 21:52:34 +0000 (13:52 -0800)]
Update CoreFX-in-CoreCLR testing instructions (#21002)
Update to reflect changes in the repo, and fix various formatting issues.
Sergey Andreenko [Wed, 14 Nov 2018 21:46:44 +0000 (13:46 -0800)]
Fix arm64 PUTARG_STK(contained OBJ(contained LCL_FLD_ADDR)). (#20995)
* add a repro test
* Fix the issue.
Do not mark `GT_OBJ` as containned for arm64.
We already do the same in `NewPutArg`.
Swaroop Sridhar [Wed, 14 Nov 2018 03:21:13 +0000 (19:21 -0800)]
Fix warnings because of Bool incompatibality
Fix a compile warning because of bool vs BOOL incompatibality.
Fixes a build break in the new VS compiler.
Bruce Forstall [Wed, 14 Nov 2018 19:14:46 +0000 (11:14 -0800)]
Update help output of runtest.cmd/sh
dotnet-maestro[bot] [Wed, 14 Nov 2018 15:29:51 +0000 (15:29 +0000)]
Update dependencies from https://github.com/dotnet/arcade build 327 (#21000)
This change updates the following dependencies
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.18563.21
- Microsoft.DotNet.Helix.Sdk - 1.0.0-beta.18563.21
Tanner Gooding [Wed, 14 Nov 2018 15:20:49 +0000 (07:20 -0800)]
Cleanup on the new Math APIs (#20993)
* Updating the cached HAVE_COMPATIBLE_ILOGB0_EXITCODE and HAVE_COMPATIBLE_ILOGBNAN_EXITCODE to 1
* Fixing MaxMagnitude and MinMagnitude to correctly handle the case when ax and ay are equal
dotnet-maestro-bot [Wed, 14 Nov 2018 13:02:03 +0000 (05:02 -0800)]
Update CoreClr, CoreFx, CoreSetup, IbcData, PgoData to preview-27113-06, preview.18563.5, preview-27114-01, master-
20181114-0045, master-
20181114-0044, respectively (#20950)
Brian Sullivan [Wed, 14 Nov 2018 03:21:07 +0000 (19:21 -0800)]
Merge pull request #20961 from briansull/const-eval-fix
Improve CanEvalForConstantArgs
Eugene Rozenfeld [Tue, 13 Nov 2018 23:35:05 +0000 (15:35 -0800)]
Undo a workaround added in #20442.
Eugene Rozenfeld [Sat, 10 Nov 2018 00:53:49 +0000 (16:53 -0800)]
Fix for bug 20499.
When the jit is copying a struct-typed return to the return local in a synchronous method on arm64,
it ends up invoking an importer utility outside the importer, where impTreeLast is not set.
The call sequence is
fgMorphBlocks --> gtNewTempAssign --> impAssignStruct --> impAssignStructPtr --> impAppendTree
When impAssignStructPtr sees GT_COMMA src nodes, it unwraps them and inserts additional statements.
The fix is to pass an insertion point statement through this call chain to prevent impAssignStruct
and impAssignStructPtr from calling impAppendTree outside of the importer.
Eugene Rozenfeld [Tue, 13 Nov 2018 21:15:12 +0000 (13:15 -0800)]
Disable R2R for object stack allocation tests.
Object stack allocation currently doesn't work in R2R mode
because we lower R2R allocations to helper calls in the importer.
That will be fixed but for now we need to disable R2R for these tests.
Fixes #20977.
Levi Broderick [Wed, 14 Nov 2018 01:05:02 +0000 (17:05 -0800)]
Initial commit for System.Text.Rune (#20935)
This type represents a Unicode scalar value ([ U+0000..U+D7FF ], inclusive; and [ U+E000..U+10FFFF ], inclusive). The primary scenario is for having a consistent representation of Unicode data regardless of the underlying input encoding type, including abstracting away surrogate code points.
Brian Sullivan [Mon, 12 Nov 2018 23:36:18 +0000 (15:36 -0800)]
Fix CanEvalForConstantArgs(VNFunc vnf)
Change the default return value for new GenTree nodes to false
This allows new nodes to be added without immediately implementing
the compile time folding logic.
Added method header comment for CanEvalForConstantArgs
Maoni Stephens [Tue, 13 Nov 2018 23:17:18 +0000 (15:17 -0800)]
n_heaps needs to be initialized before init_static_data is called (#20968)
Egor Chesakov [Tue, 13 Nov 2018 22:37:04 +0000 (14:37 -0800)]
Specify version of xunit.console.dll during the custom build (#20975)
* Use stable Xunit v2.4.1
* Use xunit.console.dll with specified assembly version to avoid issues with Ready2Run jobs
* Update comment regarding building xunit with specified version in tests/runtest.py
Jeremy Koritzinsky [Tue, 13 Nov 2018 22:13:57 +0000 (14:13 -0800)]
Add tests for AsAny Marshalling (#20963)
* Copy over tests from .NET Framework.
* Convert tests to use CoreCLRTestLibrary. Clean up tests that weren't self-consistent.
* Pass in context for non best-fit-mapping tests.
* Move around/group declarations.
* Clean up typedef names/usage.
* Fix signedness.
* Use ptrdiff_t and size_t instead of C99 types.
* Fix printf specifiers
* Remove unneeded now duplicate typedef
Jan Vorlicek [Tue, 13 Nov 2018 21:51:20 +0000 (22:51 +0100)]
Change GetAppDomain to return AppDomain from the global static (#20910)
* Change GetAppDomain to return it from the global static
The current implementation of the GetAppDomain takes it from the TLS for
the current thread. But we only have one AppDomain in the system, so we
can change it to return just that one.
I have still left the ThreadLocalInfo.m_pAppDomain and its setter
present, because SOS uses that to access the AppDomain and the SOS needs
to be runtime versino agnostic.
This makes it to perform better for Unix where accessing TLS is not
trivial.
* Move the AppDomain instance pointer to own static
To enable access to the one and only AppDomain without unnecessary
indirections, I have moved the pointer out of the SystemDomain class.
Tomáš Rylek [Tue, 13 Nov 2018 21:28:32 +0000 (22:28 +0100)]
Initial support for normalized 'naked' R2RDump output (#20875)
* Initial support for normalized 'naked' R2RDump output
This change introduces a new option "--naked" that takes output
normalization even further - it intentionally leaves out any
position information to make the output easier to diff between
CPAOT and Crossgen.
One other new option is "--entrypoints" which dumps a plain
list of JITted methods in the R2R executable. This can be used
for comparisons between CPAOT and Crossgen and / or for static
analysis of what methods were actually emitted by the compiler.
* Addressed Zach's PR feedback
1) Added argument consistency check for the invalid combination
"--naked" + "--raw".
2) Added dump of multi-dimensional array lower bounds and sizes
when available.
Thanks
Tomas
Jan Kotas [Tue, 13 Nov 2018 21:20:35 +0000 (13:20 -0800)]
Unify ThrowHelper style (#20974)
Russ Keldorph [Tue, 13 Nov 2018 15:24:44 +0000 (07:24 -0800)]
Increase FreeBSD job time allowance
Fadi Hanna [Tue, 13 Nov 2018 20:44:49 +0000 (12:44 -0800)]
Optimize vtable calls (#20696)
* Implementation of R2R vtable call thunks. These thunks will fetch the target code pointer from the vtable of the input thisPtr, and jump to that address.
This is especially helpful with generics, since we can avoid a generic dictionary lookup cost for a simple vtable call.
Overall, these thunks cause the CPU to have less branch mispredictions, and give a small performance boost to vtable calls.
These stubs are under VirtualCallStubManager so that the managed debugger can handle stepping through them.
dotnet-maestro[bot] [Tue, 13 Nov 2018 15:23:47 +0000 (15:23 +0000)]
Updating version files (#20969)
Michal Strehovský [Tue, 13 Nov 2018 13:01:34 +0000 (14:01 +0100)]
Handle generics in methodimpls for default interface methods (#20404)
The existing logic looking at MethodImpls to find the default interface implementation was not correct in the presence of generics. The MethodImpl records we build during type load only contain inexact MethodDescs for the declMethod that are not suitable for comparisons.
The fix is to pipe through the token and resolve the declaring method from it at the time of dispatch.
Tanner Gooding [Tue, 13 Nov 2018 07:03:20 +0000 (23:03 -0800)]
Fixing Utf8Parser.Number to not modify the value of 'c' (#20967)
Egor Chesakov [Tue, 13 Nov 2018 03:31:17 +0000 (19:31 -0800)]
Exclude failing System.Memory.Tests (#20958) on Linux/ARM and Linux/ARM64 (#20962)
Andrew Au [Tue, 13 Nov 2018 03:00:44 +0000 (19:00 -0800)]
Passing the CONTEXT in ICorDebugManagedCallback4::DataBreakpoint (#20960)
* Passing the CONTEXT in ICorDebugManagedCallback4::DataBreakpoint
* ifdef out the message sending on configurations that does not support data breakpoint
Egor Chesakov [Tue, 13 Nov 2018 01:21:06 +0000 (17:21 -0800)]
Simplify build.sh command line arguments for Linux/arm cross build (Part 1) (#20836)
* Don't use crosscomponent|-crosscomponent command line args in build.sh
* Don't use CROSSCOMPONENT environment variable in build.sh src/pal/tools/gen-buildsys-clang.sh
* Remove mentioning -crosscomponent from usage() in build-test.sh
* Don't use -crosscomponent in buildpipeline
* Don't use -crosscomponent in Groovy files
* Remove mentioning crosscomponent in Documentation/building/linux-instructions.md
* Stop building Hostx86/armel crossgen in build.sh
* Disable CrossGen-ing of System.Private.CoreLib on Linux/armel
Egor Chesakov [Tue, 13 Nov 2018 00:41:01 +0000 (16:41 -0800)]
Lower fast tail call wasn't patching control expression (#20740)
Lower fast tail call can replace local variables (holding Caller stack arguments) with new temps in order to set up Callee stack arguments correctly. This involves patching corresponding LCL_VAR and LCL_VAR_ADDR nodes and replacing them with the location of a new temp.
This was not done for control expression which continued pointing to the old location and could contain a Callee argument.
Eugene Rozenfeld [Mon, 12 Nov 2018 21:16:19 +0000 (13:16 -0800)]
Disable stress random inlining for object stack allocation tests.
ObjectStackAllocationTests are sensitive to inlining so we need
to disable stress random inlining.
Fixes #20944.
Tanner Gooding [Mon, 12 Nov 2018 23:46:55 +0000 (15:46 -0800)]
Moving the Utf8Formatter and Utf8Parser into S.P.Corelib (#20934)
* Moving the Utf8Formatter and Utf8Parser into S.P.Corelib
* Doing some minimal cleanup to lineup types and get the Utf8Parser/Utf8Formatter building
* Updating the Utf8 Float Parser to have different buffers for Single vs Double
* Fixing the Utf8Parser to track trailing zero digits and to properly mark the end of the buffer
* Fixing a couple of issues in Utf8Parser.Number