Tanner Gooding [Fri, 29 Mar 2019 18:30:38 +0000 (11:30 -0700)]
Merge pull request dotnet/coreclr#23561 from tannergooding/NullableSRI
Nullable: System.Runtime.Intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
6d775033d841506a1e418222e15619127bb220f5
Tanner Gooding [Fri, 29 Mar 2019 18:29:34 +0000 (11:29 -0700)]
Merge pull request dotnet/coreclr#23560 from tannergooding/NullableFeature
Merge remote-tracking branch 'dotnet/master' into NullableFeature
Commit migrated from https://github.com/dotnet/coreclr/commit/
427beddffbd19950be16b9c9de36fa6095d1b07f
Tanner Gooding [Fri, 29 Mar 2019 16:19:17 +0000 (09:19 -0700)]
Nullable: System.Runtime.Intrinsics
Commit migrated from https://github.com/dotnet/coreclr/commit/
2ec44fc26d10ac8bea1b95fd2562969d2dfa712b
Tanner Gooding [Fri, 29 Mar 2019 17:24:49 +0000 (10:24 -0700)]
Fixing the StringInfo constructor to work with the nullability analysis
Commit migrated from https://github.com/dotnet/coreclr/commit/
90cb11070a64b717a5bd653633ed6b98fc10fe20
Tanner Gooding [Fri, 29 Mar 2019 15:48:06 +0000 (08:48 -0700)]
Merge remote-tracking branch 'dotnet/master' into NullableFeature
Commit migrated from https://github.com/dotnet/coreclr/commit/
313a79fcc5b46b175cf038585e060d4a6e34ec7f
buyaa-n [Fri, 29 Mar 2019 14:17:13 +0000 (07:17 -0700)]
Nullable: Internal.Console, System.ValueType (dotnet/coreclr#23505)
* Nullable: Internal.Console, System.ValueType
* Making ToString() nullable
Commit migrated from https://github.com/dotnet/coreclr/commit/
1f3187e92f343476b0f3af49dd0609cdc826cc5a
Tanner Gooding [Fri, 29 Mar 2019 13:32:52 +0000 (06:32 -0700)]
Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively (dotnet/coreclr#23536)
* Removing FeedTasksPackageVersion from dependencies.props
* The corresponding metadata was removed in https://github.com/dotnet/coreclr/pull/22884
* Updating BuildTools, CoreCLR to preview4-03828-01, preview4-27528-71, respectively
* Adding a ! in String.Searching.cs
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f2b33e9e124c1a6be86fa83c21a1a8134a9ca10
Ben Adams [Fri, 29 Mar 2019 06:49:08 +0000 (23:49 -0700)]
Avoid boxing allocations for async in Tier0 (dotnet/coreclr#22984)
Commit migrated from https://github.com/dotnet/coreclr/commit/
dc0d0721aca6c6b1da99346dfb95de78d7c83d6f
Sergey Andreenko [Fri, 29 Mar 2019 06:37:29 +0000 (23:37 -0700)]
Delete simple unused vars2 (dotnet/coreclr#23491)
* Clean `valuenum.cpp`.
* Clean `emitarm64.cpp`.
* Clean `lsraarm64.cpp`.
* Clean `lsraarmarch.cpp`.
* Clean `lowerarmarch.cpp`.
* Clean `lower.cpp`.
* Clean `ssabuilder.cpp`.
* Clean `simd.cpp`.
* Clear `simdcodegenxarch.cpp`.
* Clean `lowerxarch.cpp`.
* Clean `scopeinfo.cpp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ecf92d0664acc8a36ee7ae69efefca5bb5a7dee5
Marek Safar [Fri, 29 Mar 2019 06:09:12 +0000 (07:09 +0100)]
Simplify StackFrame class (dotnet/coreclr#23483)
Commit migrated from https://github.com/dotnet/coreclr/commit/
f3747cd376bd870e01eef9448de15dda97117ca1
Jan Kotas [Fri, 29 Mar 2019 06:00:53 +0000 (23:00 -0700)]
Delete RuntimeThread.cs (dotnet/coreclr#23532)
No longer needed
Commit migrated from https://github.com/dotnet/coreclr/commit/
b1b8718355a687c7223de9f4a45e10937d2bf3f1
Levi Broderick [Fri, 29 Mar 2019 05:25:16 +0000 (22:25 -0700)]
Improve performance of Marvin32 (dotnet/coreclr#22816)
Commit migrated from https://github.com/dotnet/coreclr/commit/
ff25b931d519c1399838c3ac36ea41f264ae7cf3
Sergey Andreenko [Fri, 29 Mar 2019 02:00:01 +0000 (19:00 -0700)]
Exclude failing in PRs tests 2. (dotnet/coreclr#23540)
* exclude failing in PRs tests
* And another one.
* Exclude for all platforms.
Commit migrated from https://github.com/dotnet/coreclr/commit/
10510b5f9fae3361ec5b161b35014ae2cdefc009
Sergey Andreenko [Fri, 29 Mar 2019 01:54:03 +0000 (18:54 -0700)]
Delete `setup_coredis_tools` from runtest.py. (dotnet/coreclr#23495)
* Delete `setup_coredis_tools` from runtest.py.
* delete dead `setup_coredis_tools` .
Commit migrated from https://github.com/dotnet/coreclr/commit/
3483c6e33b47bd956c433c7437bffad7ab5aca21
Sung Yoon Whang [Fri, 29 Mar 2019 00:25:00 +0000 (17:25 -0700)]
Fix increment calculation in IncrementingPollingCounter (dotnet/coreclr#23502)
* Add test for IncrementingPollingCounter
* Fix a bug in Increment calculation in IncrementingPollingCounter
* Remove setting DisplayName property since that's a private property for now
* fix comment
* Remove unused variables
Commit migrated from https://github.com/dotnet/coreclr/commit/
9517ad0821e339418b3d3d31145dc0bbb1afc38d
Sergey Andreenko [Fri, 29 Mar 2019 00:21:50 +0000 (17:21 -0700)]
Exclude failing in PRs tests. (dotnet/coreclr#23535)
* exclude failing in PRs tests
Commit migrated from https://github.com/dotnet/coreclr/commit/
72a3f75791be7d78c825ce1f4f02a54c8a7fa344
Krzysztof Wicher [Thu, 28 Mar 2019 23:58:31 +0000 (16:58 -0700)]
Nullable: DateTimeFormat, DateTimeFormatInfoScanner, SortKey, StringInfo, TextElementEnumerator, TimeSpanFormat, TimeSpanParse (dotnet/coreclr#23486)
* nullable: DateTimeFormat, DateTimeFormatInfoScanner, SortKey, StringInfo, TextElementEnumerator, TimeSpanFormat, TimeSpanParse
* prefix workaround comment with TODO-NULLABLE
* add TODO-NULLABLE
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a28c47bbf9570929d3b4fd8f6358f48cc6b5a37
Krzysztof Wicher [Thu, 28 Mar 2019 23:21:31 +0000 (16:21 -0700)]
Nullable: NumberFormatInfo, CultureInfo (dotnet/coreclr#23459)
* Nullable: NumberFormatInfo, CultureInfo
* fix build
* fix windows
* fix APPX issue
* another appx failure
* get rid of line split
* mark retVal as nullable
Commit migrated from https://github.com/dotnet/coreclr/commit/
f414bbdebcd361a653191dc2465f7f7d63223ca0
Santiago Fernandez Madero [Thu, 28 Mar 2019 21:59:23 +0000 (14:59 -0700)]
Nullable: Exception, SystemException, Argument*Exception (dotnet/coreclr#23515)
* Nullable: Exception, SystemException, Argument*Exception
* Add Debug.Assert rather than comment
Commit migrated from https://github.com/dotnet/coreclr/commit/
aba605f9a7e19467c01c486cb99a3184b5528654
Carol Eidt [Thu, 28 Mar 2019 20:45:32 +0000 (13:45 -0700)]
Fix codegen for StoreNonTemporal (dotnet/coreclr#23511)
* Fix codegen for StoreNonTemporal
Also, add some asserts and mark some intrinsics as not supporting containment.
Fix dotnet/coreclr#23509
Commit migrated from https://github.com/dotnet/coreclr/commit/
ffe8a331dca0edce1d5bc9537537ed2bfba31b71
Egor Chesakov [Thu, 28 Mar 2019 20:26:23 +0000 (13:26 -0700)]
Restrict Ubuntu.1404.Arm32.Open from running against PRs (dotnet/coreclr#23523)
Commit migrated from https://github.com/dotnet/coreclr/commit/
d1f914ca36acf46aa64ebc35719f367b2ed1d96f
Santiago Fernandez Madero [Thu, 28 Mar 2019 19:15:16 +0000 (12:15 -0700)]
Nullable: make Object.ToString() return nullable (dotnet/coreclr#23510)
Commit migrated from https://github.com/dotnet/coreclr/commit/
1cdbdb09cb4938240f2358974324e77d96ff23d0
Carol Eidt [Thu, 28 Mar 2019 18:23:10 +0000 (11:23 -0700)]
Struct & SIMD improvements (dotnet/coreclr#22255)
* [WIP] Struct & SIMD improvements
- Enable CSE of struct values when handle is available (and add code to get the handle of HW SIMD types)
- Don't require block nodes for SIMD assignments
- Don't set `GTF_GLOB_REF` on `GT_OBJ` if it is local
- Set `lvRegStruct` on promoted SIMD fields
- Add tests for dotnet/coreclr#19910 (fixed with this PR) and dotnet/coreclr#3539 & dotnet/coreclr#19438 (fixed with dotnet/coreclr#21314)
- Additional cleanup
Fix dotnet/coreclr#19910
Commit migrated from https://github.com/dotnet/coreclr/commit/
3d4a1d5cea0ae71eed1482990ce6e575049829d8
Jeremy Koritzinsky [Thu, 28 Mar 2019 18:22:04 +0000 (11:22 -0700)]
Fix Helix queue names (dotnet/coreclr#23468)
* Fix Helix queue names
* Fix open Deb9 queue name.
Commit migrated from https://github.com/dotnet/coreclr/commit/
a32f7e6b176fc18973581d48d919112d66e321aa
Egor Chesakov [Thu, 28 Mar 2019 18:18:06 +0000 (11:18 -0700)]
Switch to BYOC BuildPools in internal project (dotnet/coreclr#23501)
* dnceng-linux-internal-temp -> BuildPool.Ubuntu.1604.Amd64
* dotnet-internal-temp -> BuildPool.Windows.10.Amd64.VS2017
Commit migrated from https://github.com/dotnet/coreclr/commit/
3027b9d4cc4ee4637834eec99c08b16bc54b38bb
Bruce Forstall [Thu, 28 Mar 2019 18:08:05 +0000 (11:08 -0700)]
Merge pull request dotnet/coreclr#23519 from BruceForstall/RestoreWindowsArmBuildJobs
Restore Windows arm32/arm64 innerloop build jobs
Commit migrated from https://github.com/dotnet/coreclr/commit/
2d0a5baba4cb1e4f09845d92f8d610a419a83f58
Santiago Fernandez Madero [Wed, 27 Mar 2019 22:17:36 +0000 (15:17 -0700)]
Nullable: System.Object (dotnet/coreclr#23466)
Commit migrated from https://github.com/dotnet/coreclr/commit/
62fb2047ac7f037296fcf11466f7731c40ca1e70
Krzysztof Wicher [Wed, 27 Mar 2019 18:25:12 +0000 (11:25 -0700)]
Nullable: all calendars (dotnet/coreclr#23469)
* calendar
* nullable: all calendars
* fix likely corert error
Commit migrated from https://github.com/dotnet/coreclr/commit/
90f5615e349a002fc00288c147e82b965ecfa1b0
Santiago Fernandez Madero [Wed, 27 Mar 2019 17:54:45 +0000 (10:54 -0700)]
Nullable: System.Char (dotnet/coreclr#23480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
5b00a73b86470d77103808e2b59b3c42ecf46223
Bruce Forstall [Thu, 28 Mar 2019 16:55:55 +0000 (09:55 -0700)]
Restore Windows arm32/arm64 innerloop build jobs
These are required by the innerloop flow jobs.
Commit migrated from https://github.com/dotnet/coreclr/commit/
51c84cbde3c1d7531a149e33cc445bee34fc081e
Vladimir Sadov [Thu, 28 Mar 2019 17:25:25 +0000 (10:25 -0700)]
Merge pull request dotnet/coreclr#23325 from VSadov/CmpExchA64
Resolve 22303 (interlocked failures on ARM64)
Commit migrated from https://github.com/dotnet/coreclr/commit/
e5bfd7d89ad0704a23545ac1e6d6a80918e2dbe5
Santiago Fernandez Madero [Thu, 28 Mar 2019 17:23:43 +0000 (10:23 -0700)]
Nullable: System.Double, System.Single (dotnet/coreclr#23503)
Commit migrated from https://github.com/dotnet/coreclr/commit/
aca27205dadff0d984ae6786a02c82ff9f8b5c7b
simplejackcoder [Thu, 28 Mar 2019 15:20:15 +0000 (08:20 -0700)]
GetPinnableReference on String.cs (dotnet/coreclr#23428)
* GetPinnableReference on String.cs
* Add attributes for debugger and performance
Commit migrated from https://github.com/dotnet/coreclr/commit/
7c4717e01baf2cc5f4f6a73fc56109b527311c2d
Jan Kotas [Thu, 28 Mar 2019 05:37:22 +0000 (22:37 -0700)]
Move QueryPerformanceCounter PInvokes to shared (dotnet/corefxdotnet/coreclr#36409)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
378a0424d350911b569ff3ab0263bb1c1e5fa5ba
Santiago Fernandez Madero [Wed, 27 Mar 2019 22:17:36 +0000 (15:17 -0700)]
Nullable: System.Object (dotnet/coreclr#23466)
Commit migrated from https://github.com/dotnet/coreclr/commit/
652234cec57b0d65c21fcd88c94bd82287d90a4c
Krzysztof Wicher [Wed, 27 Mar 2019 18:25:12 +0000 (11:25 -0700)]
Nullable: all calendars (dotnet/coreclr#23469)
* calendar
* nullable: all calendars
* fix likely corert error
Commit migrated from https://github.com/dotnet/coreclr/commit/
bbcfd3af26a5a2cd0a404b71a8d66351a4fd883b
Santiago Fernandez Madero [Wed, 27 Mar 2019 17:54:45 +0000 (10:54 -0700)]
Nullable: System.Char (dotnet/coreclr#23480)
Commit migrated from https://github.com/dotnet/coreclr/commit/
891a2355a5272757523cec218809198d1e9b682e
buyaa-n [Wed, 27 Mar 2019 02:15:17 +0000 (19:15 -0700)]
Nullable updates for byte type (dotnet/coreclr#23460)
Commit migrated from https://github.com/dotnet/coreclr/commit/
9f285b762839d916683f08b06d450fd9969004fe
buyaa-n [Tue, 26 Mar 2019 16:32:15 +0000 (09:32 -0700)]
Nullable changes for boolean type (dotnet/coreclr#23451)
* Nullable changes for boolean type
Commit migrated from https://github.com/dotnet/coreclr/commit/
4907260fc84002da9aa86362b97f0f991269e847
Santiago Fernandez Madero [Tue, 26 Mar 2019 16:27:32 +0000 (09:27 -0700)]
Nullable: String (dotnet/coreclr#23450)
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe73f198d553334838bfeeb9e33e9b58a0ea4c67
Krzysztof Wicher [Tue, 26 Mar 2019 16:23:00 +0000 (09:23 -0700)]
nullable: number (dotnet/coreclr#23454)
Commit migrated from https://github.com/dotnet/coreclr/commit/
626633d6c52cbc91c187def2e547e3ffdbe7e095
Krzysztof Wicher [Tue, 26 Mar 2019 04:10:24 +0000 (21:10 -0700)]
Nullable: Uint32, (U)Int16, (U)Int64 (dotnet/coreclr#23449)
* Nullable: UInt32
* (U)Int16, (U)Int64
* Make NumberFormatInfo non-nullable
Commit migrated from https://github.com/dotnet/coreclr/commit/
1af82292d5495e5119109927afd7de71b6622e12
Krzysztof Wicher [Tue, 26 Mar 2019 02:13:42 +0000 (19:13 -0700)]
Nullable: Int32 (dotnet/coreclr#23443)
* Nullable: Int32
* remove restore and move nullable up front
* remove trailing \n after #nullable to make it easier to remove later
Commit migrated from https://github.com/dotnet/coreclr/commit/
e0362db668b468925190ad3ff9f0a6f2b4c7a539
Steve MacLean [Thu, 28 Mar 2019 00:15:45 +0000 (20:15 -0400)]
ALC Enhancement nits (dotnet/coreclr#23506)
isCollectible default should be false
String should be string
Commit migrated from https://github.com/dotnet/coreclr/commit/
75250f4edf8e6142e2e70fb7b3966bf2348fe0e1
Steve MacLean [Wed, 27 Mar 2019 23:49:17 +0000 (19:49 -0400)]
ALC enhancements (dotnet/coreclr#22273)
* Initial implementatation of ALC enhancements
Add public constructor with name
Add Name property
Add Assemblies property
Add All property
Override ToString
Name Default and Assembly.Load(...) ALCs
Add AssemblyLoadContext30Extensions test
Commit migrated from https://github.com/dotnet/coreclr/commit/
f1440bb696e2eee957a30f37c6c735f51696edad
Steve MacLean [Wed, 27 Mar 2019 21:24:00 +0000 (17:24 -0400)]
Extend WindowsEventLog test for EntryPointFilter (dotnet/coreclr#23178)
* Extend WindowsEventLog test
Verify EntryPointFilter solves logging problem with native host swallowing exceptions
WindowsEventLog only look at new entries
WindowsEventLog remove time check
Add mechanism to corhost to emulate host swallowing all exceptions
* PR feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
66c05cea421a9f388eaebece2b9e64ce4560c5c5
Swaroop Sridhar [Wed, 27 Mar 2019 21:03:25 +0000 (14:03 -0700)]
Update DllMap doc (dotnet/coreclr#22804)
* Update DllMap doc
Update DllMap design doc:
* To note the NativeLibrary APIs that can be used to implement DllMap
* To point to a sample implementation of DllMap.
Commit migrated from https://github.com/dotnet/coreclr/commit/
c3e1bd5ccc482c9a7670762676bda95ebd34707d
Steve MacLean [Wed, 27 Mar 2019 18:02:18 +0000 (14:02 -0400)]
Add ALC.ContextualReflection.md (dotnet/coreclr#23335)
Commit migrated from https://github.com/dotnet/coreclr/commit/
6a48f05c77e80b604d71a9b84cc6b014306e849e
Sergey Andreenko [Wed, 27 Mar 2019 17:59:04 +0000 (10:59 -0700)]
Revert "Delete unused variables in jit. Part 2. (dotnet/coreclr#23481)" (dotnet/coreclr#23488)
This reverts commit dotnet/coreclr@
6cb120cc74ca61fc314e3cc43007778d2aafd041.
Commit migrated from https://github.com/dotnet/coreclr/commit/
cbeadacafba718557e47fc166d7fd688b01515d7
Sergey Andreenko [Wed, 27 Mar 2019 17:22:18 +0000 (10:22 -0700)]
Delete unused variables in jit. Part 2. (dotnet/coreclr#23481)
* Clean `valuenum.cpp`.
* Clean `emitarm64.cpp`.
* Clean `lsraarm64.cpp`.
* Clean `lsraarmarch.cpp`.
* Clean `lowerarmarch.cpp`.
* Clean `lower.cpp`.
* Clean `ssabuilder.cpp`.
* Clean `simd.cpp`.
* Clear `simdcodegenxarch.cpp`.
* Clean `lowerxarch.cpp`.
* Clean `scopeinfo.cpp`.
* Clean `hwintrinsiccodegenxarch.cpp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
6cb120cc74ca61fc314e3cc43007778d2aafd041
Andrew Au [Wed, 27 Mar 2019 00:38:27 +0000 (17:38 -0700)]
Eliminate EventPipeBuffer::Close()
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa077b43cc3a1911e67fc63eb592dd36caaa0d70
Tanner Gooding [Wed, 27 Mar 2019 10:33:56 +0000 (03:33 -0700)]
Fixing the codegen for x64 intrinsics to use EA_8BYTE where needed. (dotnet/coreclr#23461)
Commit migrated from https://github.com/dotnet/coreclr/commit/
94db6145bca291313156eec40cb16518f7f9fc1d
Sergey Andreenko [Wed, 27 Mar 2019 07:25:06 +0000 (00:25 -0700)]
Add call to setup-stress-dependencies.sh to build-test.sh. (dotnet/coreclr#23435)
Commit migrated from https://github.com/dotnet/coreclr/commit/
808e048c8535f9fd704acb75f1fa4aecdf36b72e
Sergey Andreenko [Wed, 27 Mar 2019 07:14:38 +0000 (00:14 -0700)]
Update CoreFX arm64 test exclusions. (dotnet/coreclr#23463)
Commit migrated from https://github.com/dotnet/coreclr/commit/
bae057b3c1018cd519989517c4c11adad732bb06
Fadi Hanna [Wed, 27 Mar 2019 03:56:57 +0000 (20:56 -0700)]
Replacing the /Trusted_Platform_Assemblies switch with a simpler /r switch that can be used multiple times in the command line to provide a list of reference assemblies. Reference assemblies can now be passed as individual file entries instead of a giant string of semi-column separated entries. (dotnet/coreclr#23462)
Commit migrated from https://github.com/dotnet/coreclr/commit/
621a66cb9644c49df03611f353764da03460f48d
Egor Chesakov [Wed, 27 Mar 2019 03:47:48 +0000 (20:47 -0700)]
Use DotNet-HelixApi-Access only in internal project (dotnet/coreclr#23479)
Commit migrated from https://github.com/dotnet/coreclr/commit/
c8a576928086f8ead922dcadc4f1cf984316eb61
Carol Eidt [Tue, 26 Mar 2019 23:13:40 +0000 (16:13 -0700)]
Handle addressing modes for HW intrinsics (dotnet/coreclr#22944)
* Handle addressing modes for HW intrinsics
Also, eliminate some places where the code size estimates were over-estimating.
Contribute to dotnet/coreclr#19550
Fix dotnet/coreclr#19521
Commit migrated from https://github.com/dotnet/coreclr/commit/
da6ed1197abcb1be420351af1bb3758de6048c8f
vsadov [Tue, 26 Mar 2019 22:10:26 +0000 (15:10 -0700)]
Make tests outerloop again
Commit migrated from https://github.com/dotnet/coreclr/commit/
743b42a782651d5f3b14ef5643684b9f31890389
Tanner Gooding [Tue, 26 Mar 2019 15:48:03 +0000 (08:48 -0700)]
Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning (dotnet/coreclr#36071)
* Cleaning up the P/Invoke signatures for QPF and QPC to avoid marshalling and pinning
* Responding to PR feedback.
* Dropping support for low resolution stopwatch
* Removing BestFitMapping=false
* Removing unneeded unsafe declarations
* Addressing more PR feedback
* Fixing the pal_time header file
* Fixing the Unix P/Invoke signatures for GetTimestamp and GetTimestampResolution to return ulong.
* Fixing GetTimestampResolution to scale the result for HAVE_CLOCK_MONOTONIC
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
aa072b639fc2eb0e60a8083e4c74426db91341e0
Jan Vorlicek [Mon, 25 Mar 2019 23:20:32 +0000 (00:20 +0100)]
Merge pull request dotnet/coreclr#23430 from janvorli/disable-ijw-load-in-collectible-alc
Disable loading IJW assemblies into collectible ALC
Commit migrated from https://github.com/dotnet/coreclr/commit/
2520798548b0c414f513aaaf708399f8ef5a4f6c
David Wrighton [Mon, 25 Mar 2019 23:04:26 +0000 (16:04 -0700)]
Replace Win32 resource reading logic with cross platform implementation (dotnet/coreclr#23363)
* FindResource direct implementation in PEDecoder
* Fixup bugs identified in resource reading
Commit migrated from https://github.com/dotnet/coreclr/commit/
36c34ed6724416f212aa81eb8596f0bfed59d3f1
Andy Ayers [Mon, 25 Mar 2019 22:05:45 +0000 (15:05 -0700)]
JIT: don't treat whitespace as separator in assembly name lists (dotnet/coreclr#23410)
Only recognize ";" as a separator, so that we can support exclusions or inclusions
of assemblies whose names include spaces.
Impacts the altjit exclude list, and the disasm include list.
Addresses dotnet/jitutilsdotnet/coreclr#200.
Commit migrated from https://github.com/dotnet/coreclr/commit/
32df0e741befb3cc815927c37cb29dd039e62158
Andy Ayers [Mon, 25 Mar 2019 22:00:26 +0000 (15:00 -0700)]
Mark test GitHub_18582 as optimization sensitive (dotnet/coreclr#23434)
Jitstress on OSX will turn on cloning stress in `Test` and cause stack overflows
cloning the large `GT_LIST` subtree of the call.
See issue dotnet/coreclr#23346.
Commit migrated from https://github.com/dotnet/coreclr/commit/
ca2eec2fbaa127fd62d9427be0a5c9fd99680bca
Jan Vorlicek [Mon, 25 Mar 2019 17:07:25 +0000 (18:07 +0100)]
Disabled new IJW tests
There were couple of IJW tests added since the master I've based my
changes on. Adding disabling of those for unloadability testing.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8fede4ddd8002a1794f86c2dd9ac7f05c326a929
Jan Vorlicek [Fri, 22 Mar 2019 13:53:31 +0000 (14:53 +0100)]
Disable loading IJW assemblies into collectible ALC
Commit migrated from https://github.com/dotnet/coreclr/commit/
7a928d80d2c6eb227b70144a0a8018f3ec67066b
Jan Vorlicek [Mon, 25 Mar 2019 16:57:08 +0000 (17:57 +0100)]
Merge pull request dotnet/coreclr#23413 from luhenry/fix-gh22302-2
Improve detection of CPU limits when running inside a Container
Commit migrated from https://github.com/dotnet/coreclr/commit/
e6c49f73eac2413fdc7a1024fc0f1585e39db026
Tomáš Rylek [Mon, 25 Mar 2019 16:22:46 +0000 (17:22 +0100)]
Miscellaneous R2RDump improvements (dotnet/coreclr#23215)
1) In Naked mode, hide the distinction amongst METHOD_ENTRY vs.
METHOD_ENTRY_REF_TOKEN vs. METHOD_ENTRY_DEF_TOKEN as it's not
important for correctness and causes undesirable churn in diffs.
This required propagating the DumpOptions around in a couple
of places.
2) For historical reasons, the DisassemblingTypeProvider had
its own implementations of metadata formatting that is now provided
by MetadataNameFormatter. I have removed at least a part of this
duplication in this change. [It was causing undesirable diffs as
one version used to output type owner assemblies whereas the other
did not.]
Thanks
Tomas
Commit migrated from https://github.com/dotnet/coreclr/commit/
368639e46a903b6ff44a21d67b0e0fea661c91d7
Tarek Mahmoud Sayed [Mon, 25 Mar 2019 15:23:33 +0000 (08:23 -0700)]
Re-enable Index/Range Jit test (dotnet/coreclr#23415)
Commit migrated from https://github.com/dotnet/coreclr/commit/
b6b3d15118c47380ced62f99767f25fac44fad4c
Nick Schonning [Sun, 24 Mar 2019 20:46:16 +0000 (16:46 -0400)]
typo: Double word "both" (dotnet/corefxdotnet/coreclr#36272)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
a593024b85a6e074770c88867491f4f30cc6fc8a
Nick Schonning [Sun, 24 Mar 2019 20:44:51 +0000 (16:44 -0400)]
typo: Double word "never" (dotnet/corefxdotnet/coreclr#36300)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
41f619d4b4e88a51f620b1b7be8ef78a48066c35
Nick Schonning [Sun, 24 Mar 2019 20:43:54 +0000 (16:43 -0400)]
typo: Double word "to" (dotnet/corefxdotnet/coreclr#36264)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
44994cc61cb00e310d560462ad5de0cfc135c950
Nick Schonning [Sun, 24 Mar 2019 20:43:04 +0000 (16:43 -0400)]
typo: Double word "that" (dotnet/corefxdotnet/coreclr#36269)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
3038a7871ebc8f7e552bdd0086bc55a0d5cfee7c
Nick Schonning [Sun, 24 Mar 2019 20:41:06 +0000 (16:41 -0400)]
typo: Double word "a" (dotnet/corefxdotnet/coreclr#36271)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
03d3253f94a7c02a7d156fe378c73b736b202777
Nick Schonning [Sun, 24 Mar 2019 20:41:37 +0000 (16:41 -0400)]
typo: Double word "in" (dotnet/corefxdotnet/coreclr#36270)
* typo: Double word "in"
* Update src/System.Console/src/System/Console.cs
Co-Authored-By: nschonni <nschonni@gmail.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
769664075ef81b87fa749d02047e1da1a4113e1c
Nick Schonning [Sun, 24 Mar 2019 20:40:10 +0000 (16:40 -0400)]
typo: Double word "the" (dotnet/corefxdotnet/coreclr#36274)
* typo: Double word "the"
* Apply suggestions from code review
Co-Authored-By: nschonni <nschonni@gmail.com>
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
13777718e79f10c4908f23403cd7cfa5bae363e0
Nick Schonning [Sun, 24 Mar 2019 20:40:35 +0000 (16:40 -0400)]
typo: Double word "this" (dotnet/corefxdotnet/coreclr#36273)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
df550d77db2e21ff19ac02f0421c26ca1c53231a
Nick Schonning [Sun, 24 Mar 2019 20:39:15 +0000 (16:39 -0400)]
typo: Double word "are" (dotnet/corefxdotnet/coreclr#36275)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
026ff36a4fa9a37c7ee5ded0f77e4bb3d99c3883
Nick Schonning [Sun, 24 Mar 2019 20:38:54 +0000 (16:38 -0400)]
typo: Double word "types" (dotnet/corefxdotnet/coreclr#36276)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
4afc0b26fecd1443cee8ebaab8ad6f9145d04c06
Nick Schonning [Sun, 24 Mar 2019 20:36:34 +0000 (16:36 -0400)]
typo: Double word "is" (dotnet/corefxdotnet/coreclr#36283)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
fe142a0aead0064230c82d3671ef0f98eeaf803c
Nick Schonning [Sun, 24 Mar 2019 20:34:57 +0000 (16:34 -0400)]
typo: Double word "we" (dotnet/corefxdotnet/coreclr#36288)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
92a191e6c772990c54a03192e2ff58dab0188891
Nick Schonning [Sun, 24 Mar 2019 20:30:06 +0000 (16:30 -0400)]
typo: Double word "as" (dotnet/corefxdotnet/coreclr#36277)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/
2f4a7564beb6f8c1f4929504ee2221953d25fc39
Sergey Andreenko [Sat, 23 Mar 2019 09:00:53 +0000 (02:00 -0700)]
Revert "Add call to setup-stress-dependencies.sh to build-test.sh. (dotnet/coreclr#23354)" (dotnet/coreclr#23419)
This reverts commit dotnet/coreclr@
22c4ff5c1d339119c12547ac2d1b35211162df49.
Commit migrated from https://github.com/dotnet/coreclr/commit/
8343724ab5f0d9fc21cca7fa676301040f26bd69
Sergey Andreenko [Sat, 23 Mar 2019 05:13:12 +0000 (22:13 -0700)]
Add call to setup-stress-dependencies.sh to build-test.sh. (dotnet/coreclr#23354)
* Add call to setup-stress-dependencies.sh to build-test.sh.
* Fix args.
* hack __DistroRid
* Do not use bash source.
* Do not use bash source 2.
* Fix init-distro-rid permissions.
* Fix tabs.
* return deleted source where it was needed
Commit migrated from https://github.com/dotnet/coreclr/commit/
22c4ff5c1d339119c12547ac2d1b35211162df49
Levi Broderick [Sat, 23 Mar 2019 04:43:27 +0000 (21:43 -0700)]
Replace slow implementations in ASCIIUtility with fast implementations (dotnet/coreclr#22516)
Commit migrated from https://github.com/dotnet/coreclr/commit/
125e7c95e72629d5eb560844791c0b3507973998
Jeremy Koritzinsky [Sat, 23 Mar 2019 00:09:21 +0000 (17:09 -0700)]
Fix WinRT marshalling for NotifyPropertyChangedEventArgs and NotifyCollectionChangedEventArgs (CoreCLR side) (dotnet/coreclr#23401)
* Enable marshalling IntPtr and UIntPtr in WinRT scenarios to support our marshalling infrastructure.
* Enable getting an RCW for a native COM object while ignoring WinRT projections.
* Rename to Marshal.GetUniqueObjectForIUnknownWithoutUnboxing
* Clean up contract.
* Move GetUniqueObjectForIUnknownWithoutUnboxing to WindowsRuntimeMarshal.
* Move WinRT-specific FCalls to WindowsRuntimeMarshal.
Commit migrated from https://github.com/dotnet/coreclr/commit/
acd1164c8c89582f13163e309a0183c72bc13924
Sergey Andreenko [Fri, 22 Mar 2019 23:33:23 +0000 (16:33 -0700)]
Delete unused variables in jit. Part1. (dotnet/coreclr#23399)
* Clean `assertionprop.cpp`.
* Clean `codegencommon.cpp`.:
* Clean `codegenlinear.cpp`.
* Clean `compiler.cpp`.
* Clean `earlyprop.cpp`.
* Clean `gschecks.cpp`.
* Clean 'lclvars.cpp`.
* Clean `jiteh.cpp`.
* Clean `liveness.cpp`.
* Clean `hashbv.cpp`.
* Clean `gcinfo.cpp`.
* Clean `optimizer.cpp`.
Commit migrated from https://github.com/dotnet/coreclr/commit/
017ded3c6acd653b875f4ef12c232617855dea09
Tarek Mahmoud Sayed [Fri, 22 Mar 2019 22:22:50 +0000 (15:22 -0700)]
Apply Optimization in Index.GetOffset suggested by Levi (dotnet/coreclr#23349)
* Apply Optimization in Index.GetOffset suggested by Levi
* Add Comment
* address the feedback
Commit migrated from https://github.com/dotnet/coreclr/commit/
39b1b6338015c9d6ef193986e0579f0ae0e60566
Marek Safar [Fri, 22 Mar 2019 20:16:41 +0000 (21:16 +0100)]
Move Exception to shared partition (dotnet/coreclr#23361)
* Move Exception to shared partition
* Remove class name caching
* Not useful comments removal
Commit migrated from https://github.com/dotnet/coreclr/commit/
a63da9e80defe0187d8ee59b9732a978ce4c493e
Andy Hanson [Fri, 22 Mar 2019 20:14:40 +0000 (13:14 -0700)]
Merge pull request dotnet/coreclr#23366 from andy-ms/heap_hard_limit
Don't compact LOH just because a heap_hard_limit exists
Commit migrated from https://github.com/dotnet/coreclr/commit/
513ccfc64a398055e7e7afc380d578cd2237b885
Ludovic Henry [Thu, 21 Mar 2019 21:37:14 +0000 (14:37 -0700)]
Improve detection of CPU limits when running inside a Container
This focuse on better supporting `--cpuset-cpus` which limits the number of processors we have access to on the CPU; it also specifies which specific processor we have access to, but that’s irrelevant here
The work has been done here for all runtime components except `Environment.ProcessorCount`. The work consist in fixing `PAL_GetLogicalCpuCountFromOS` to use `sched_getaffinity`.
Fixes https://github.com/dotnet/coreclr/issues/22302
Commit migrated from https://github.com/dotnet/coreclr/commit/
06d7406722011ccab83cd1d2507f0b14c7d91b0b
Jeremy Koritzinsky [Fri, 22 Mar 2019 05:14:19 +0000 (22:14 -0700)]
Update Ubuntu 18.04 ARM64 queues (dotnet/coreclr#23374)
* Update Ubuntu 18.04 queue.
* Update Debian 9 ARM queues as well.
Commit migrated from https://github.com/dotnet/coreclr/commit/
5d57b87227b7fd116735edf9f5f75b3154953d8e
Andrew Hoefling [Fri, 22 Mar 2019 02:23:53 +0000 (22:23 -0400)]
Updated Exception Handling for Collection<T> (dotnet/coreclr#23290)
* Updated Argument Helper param from list->collection since the parameter name is collection
* Updated exception message to use an out of range exception that doesn't explicitly reference a list
* Simplified if statements that verify if the index is out of range
* Updated if logic to be simplified using (uint)
* Updated exception handling to throw ThrowHelper.ThrowArgumentOutOfRange_IndexException() when the ExceptionArgument was 'Index'
Commit migrated from https://github.com/dotnet/coreclr/commit/
01adae878ded6fe51f6def1370255d816ab42d78
Brian Sullivan [Fri, 22 Mar 2019 00:10:42 +0000 (17:10 -0700)]
Merge pull request dotnet/coreclr#23391 from briansull/pipeline-work
Add azure-pipeline job: coreclr-ci (Test Pri0 Linux_musl x64 release)
Commit migrated from https://github.com/dotnet/coreclr/commit/
badf173369fa09d33893017ec201cbeb39da3b9c
vsadov [Wed, 20 Mar 2019 23:32:10 +0000 (16:32 -0700)]
Removed unnecessary string compares and Sleeps.
Made sure tests actually test something
Commit migrated from https://github.com/dotnet/coreclr/commit/
dbb4f684d2f0f1ff0cbe9dbaa1a04a6f24631e59
Brian Sullivan [Thu, 21 Mar 2019 21:19:05 +0000 (14:19 -0700)]
Correct Linux_musl_x64
Commit migrated from https://github.com/dotnet/coreclr/commit/
0e71dfa5634aec9b115f4c66acb9c8ea1c7048cb
Jan Vorlicek [Thu, 21 Mar 2019 21:12:11 +0000 (22:12 +0100)]
Merge pull request dotnet/coreclr#23321 from franksinankaya/gcc_cleanup_14
Integer Conversion issues
Commit migrated from https://github.com/dotnet/coreclr/commit/
29dc90c13a5d091c21e21e4ba5d3c4bcd3eab18d
Andrew Au [Mon, 18 Mar 2019 22:19:45 +0000 (15:19 -0700)]
Avoid stack walk as specified in the exclusion list
Commit migrated from https://github.com/dotnet/coreclr/commit/
a7c9ca110096c27de23f045cd176c2109d0676d9
Bruce Forstall [Thu, 21 Mar 2019 20:50:53 +0000 (13:50 -0700)]
Merge pull request dotnet/coreclr#23369 from BruceForstall/UpdateStaticStats
Update emitter statistics
Commit migrated from https://github.com/dotnet/coreclr/commit/
ceca0a77e8b48e30f9c6b67d2992c3276aba2177
Brian Bohe [Thu, 21 Mar 2019 18:19:03 +0000 (11:19 -0700)]
Moving gen stack level to code gen interface (dotnet/coreclr#23328)
* Make genStackLevel accessible from CodeGenInterface
* Initializing stackLevel before fist BasicBlock's code is generated
* Typo
* Removing extra line on comments
Commit migrated from https://github.com/dotnet/coreclr/commit/
9497b0c77819d7b64a0f3c8bf22921182c99c09d
Brian Sullivan [Thu, 21 Mar 2019 17:39:23 +0000 (10:39 -0700)]
Add coreclr-ci (Test Pri0 Linux_musl x64 release)
Commit migrated from https://github.com/dotnet/coreclr/commit/
eb053bdc938c26353372a6b14f6b5c05b823f7d0