Sung Yoon Whang [Sat, 15 Jun 2019 23:46:02 +0000 (16:46 -0700)]
Add active timer counter (#25186)
* Add active timer counter
* fix typo
Elinor Fung [Sat, 15 Jun 2019 05:32:22 +0000 (22:32 -0700)]
Fix duplicate imports in managed product build (#25174)
Egor Chesakov [Sat, 15 Jun 2019 03:30:51 +0000 (20:30 -0700)]
Don't change LCL_FLD node type when replacing param with its shadow copy (#20900)
Fix an issue that is reproduced when:
1) a method requires GSSecurityCookie (e.g. when allocating unsafe buffer using localloc) and
2) one of the method parameters is "vulnerable" and requires a shadow variable to be created and used instead of the original parameter variable and
3) the method parameter has small signed integer type (i.e. int8 or int16) and
4) the value of the parameter is converted to unsigned type (e.g. uint8 or uint16).
Sergey Andreenko [Sat, 15 Jun 2019 01:19:13 +0000 (18:19 -0700)]
abort build-tests if failed to restore stress dependencies (#25140)
* abort build-tests if failed to restore stress dependencies
* Fix arm condition.
* Add arm64 condition.
* Skip runtime dependencies for arm32/arm64.
Sergey Andreenko [Sat, 15 Jun 2019 01:18:49 +0000 (18:18 -0700)]
Merge pull request #25162 from sandreenko/FixGCStressSettingForTheTest
Do not force GcStress=0xc for GitHub_23199 on OSX.
Marek Safar [Sat, 15 Jun 2019 01:12:52 +0000 (03:12 +0200)]
Move parts of RuntimeType to shared partition (#25176)
José Rivero [Fri, 14 Jun 2019 20:47:04 +0000 (13:47 -0700)]
Moving non-EventPipe types out of eventpipe.* (#25161)
* Replace runtime check with compile time assert.
* Move EventPipeEventPayload to its own file.
* Move `StackContents` to its own file.
* Move other classes declaration/definition out of eventpipe.*
Sergey Andreenko [Fri, 14 Jun 2019 20:38:41 +0000 (13:38 -0700)]
Delete OSX condition.
Sergey Andreenko [Fri, 14 Jun 2019 19:49:29 +0000 (12:49 -0700)]
Do not force GCStress at all.
It doesn't work on OSX and Alpine.
It shows random failures on Windows as well, that we do not want to see in our PR/CI outerloop testing.
Koundinya Veluri [Fri, 14 Jun 2019 19:48:45 +0000 (12:48 -0700)]
Fix crash/corruption in VSD hash tables when backpatching entry point slots is enabled (#25158)
Fixes https://github.com/dotnet/coreclr/issues/25080
- The prober used to look for an item (`DispatchStub` or `ResolveCacheElem`) stores information specific to the table
- Cooperative GC mode guarantees that the information stored in the prober remains valid when the prober is reused to add a new item when one is not found
- The lock taken to record/backpatch an item's slot exits and reenters cooperative GC mode, which can cause the table to be reclaimed and replaced with a new table, and the prober still refers to the old table
- Upon adding the new item it may crash or corrupt some other memory
- Fixed by resetting the prober if a path is taken that may reenter cooperative GC mode
Jarret Shook [Fri, 14 Jun 2019 18:45:46 +0000 (11:45 -0700)]
Add a build option to skip building managed tools (#25171)
This specifically will set __BuildManagedTools=0 and skip building R2RDump and runincontext.
dotnet-maestro[bot] [Fri, 14 Jun 2019 18:12:09 +0000 (11:12 -0700)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190614.1 (#25170)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190614.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190614.1
Tarek Mahmoud Sayed [Fri, 14 Jun 2019 18:04:34 +0000 (19:04 +0100)]
Update the SDK version (#25141)
* Update the SDK version
The updated SDK version has a fix for the issue causing msbuild to crash during the build on Linux environment.
* Use the version recommended by Eric
Sung Yoon Whang [Fri, 14 Jun 2019 17:30:31 +0000 (10:30 -0700)]
Make DisplayUnits string.Empty by default instead of null (#25104)
* Make DisplayUnits string.Empty by default instead of null
* PR feedback on DisplayName and setter validation
Tarek Mahmoud Sayed [Fri, 14 Jun 2019 16:56:53 +0000 (17:56 +0100)]
Fix French Decimal number parsing (#25154)
dotnet-maestro[bot] [Fri, 14 Jun 2019 16:31:56 +0000 (12:31 -0400)]
Update dependencies from https://github.com/dotnet/core-setup build
20190613.08 (#25169)
- Microsoft.NETCore.App - 3.0.0-preview7-27813-08
dotnet-maestro[bot] [Fri, 14 Jun 2019 16:29:34 +0000 (12:29 -0400)]
Update dependencies from https://github.com/dotnet/arcade build
20190613.18 (#25168)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19313.18
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19313.18
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19313.18
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19313.18
Jarret Shook [Fri, 14 Jun 2019 15:31:47 +0000 (08:31 -0700)]
Merge pull request #25138 from jashook/write_pgo_opt_version_to_intermediates_dir
Change how build.sh/build.cmd parse the PGO and IBC versions
jashook [Fri, 14 Jun 2019 14:53:24 +0000 (07:53 -0700)]
Address all feedback
Jan Kotas [Fri, 14 Jun 2019 11:29:25 +0000 (04:29 -0700)]
Optimize Activator.CreateInstance (#25145)
* Optimize Activator.CreateInstance
- Short-circuit Activator.CreateInstance<T>() for value types without default constructor
- Cache default constructor delegate on RuntimeType instead of fixed-size singleton cache
jashook [Fri, 14 Jun 2019 05:33:08 +0000 (22:33 -0700)]
Partially address comments
Stephen Toub [Thu, 13 Jun 2019 14:03:40 +0000 (10:03 -0400)]
Update Corelib to adapt to compiler nullability updates
dotnet-maestro [Thu, 13 Jun 2019 12:26:02 +0000 (12:26 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190612.21
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19312.21
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19312.21
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19312.21
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19312.21
Koundinya Veluri [Fri, 14 Jun 2019 01:50:11 +0000 (18:50 -0700)]
Fix code version table lock / coop GC mode switch ordering (#25129)
Fixes https://github.com/dotnet/coreclr/issues/25086
- The lock is taken inside other unsafe locks in coop mode, in some paths it may not be legal to switch to preemptive mode before taking the lock
- Iterating over the cross loader allocator hash table to backpatch entry point slots needs coop GC mode, and was being done inside the lock
- Moved the switch to coop GC mode to before acquiring the lock to maintain consistent ordering between the two
Sergey Andreenko [Fri, 14 Jun 2019 00:50:15 +0000 (17:50 -0700)]
Do not force GcStress=0xc for GitHub_23199.
There was a typo for Unix (it is COMPlus_GCStress, not COMPlus_GcStress, but COMPlus_GcStressOnDirectCalls was correct). That was why the test passed on OSX.
Egor Chesakov [Thu, 13 Jun 2019 23:33:42 +0000 (16:33 -0700)]
Add platformGroup parameter to platform-matrix.yml (#25111)
Michal Strehovský [Thu, 13 Jun 2019 22:24:59 +0000 (00:24 +0200)]
Allow pregenerating most HW intrinsics in CoreLib (#24917)
* Allow pregenerating all HW intrinsics in CoreLib
This is a follow up to #24689 that lets us pregenerate all hardware intrinsics in CoreLib.
We ensures the potentially unsupported code will never be reachable at runtime on CPUs that don't support it by not reporting the `IsSupported` property as intrinsic in crossgen. This ensures the support checks are always JITted. JITting the support checks is very cheap.
There is cost in the form of an extra call and failure to do constant propagation of the return value, but the cost is negligible in practice and gets eliminated once the tiered JIT tiers the method up.
We only do this in CoreLib because user code could technically not guard intrinsic use in `IsSupported` checks and pregenerating the code could lead to illegal instruction traps at runtime (instead of `PlatformNotSupportedException` throws) - it's a bad user experience.
dotnet-maestro[bot] [Thu, 13 Jun 2019 22:11:10 +0000 (18:11 -0400)]
[master] Update dependencies from dotnet/core-setup (#25121)
* Update dependencies from https://github.com/dotnet/core-setup build
20190612.01
- Microsoft.NETCore.App - 3.0.0-preview7-27812-01
* Update dependencies from https://github.com/dotnet/core-setup build
20190612.11
- Microsoft.NETCore.App - 3.0.0-preview7-27812-11
dotnet-maestro[bot] [Thu, 13 Jun 2019 22:10:37 +0000 (18:10 -0400)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25122)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190612.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190612.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190612.1
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190613.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190613.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190613.1
Fadi Hanna [Thu, 13 Jun 2019 21:59:12 +0000 (14:59 -0700)]
Update crossgen.md
Add instructions on how to use the /r switch. Update instructions to use /p instead of /Platform_Assemblies_Paths (shorter version)
Fadi Hanna [Thu, 13 Jun 2019 21:26:12 +0000 (14:26 -0700)]
Merge pull request #25137 from fadimounir/SuppressWarnings
Add a switch to suppress crossgen warnings
Ben Adams [Thu, 13 Jun 2019 21:21:40 +0000 (22:21 +0100)]
Intrinsicify SpanHelpers.IndexOf(char) (#22505)
* Helpers to support Intrinsics in SpanHelpers.Char
* Intrinsicify SpanHelpers.IndexOf(char)
* Feedback
* fix
* Fix assert
* Improve comment warning
* fix
* fix
* Fix
* Fix
jashook [Thu, 13 Jun 2019 21:02:53 +0000 (14:02 -0700)]
Remove duplicate not
jashook [Thu, 13 Jun 2019 20:29:27 +0000 (20:29 +0000)]
Address PR feedback.
José Rivero [Thu, 13 Jun 2019 18:14:03 +0000 (11:14 -0700)]
Multiple EventPipe related bugs/issues (#25112)
* Taking the event pipe lock around s_tracingInitialized.
https://github.com/dotnet/coreclr/pull/24896#discussion_r291790885
* Remove unused `EventPipe::s_fileSwitchTimerHandle` and `EventPipe::s_lastFlushTime` static variables.
* Improve `EventPipe::Shutdown` thread-safety (This is not complete yet as shutting down configuration might cause an AV if WriteEvent happens during or after `EventPipe::Shutdown`).
* Make sure we call `EventPipe::Shutdown` only once (the first time around).
* Move two EventPipe methods to `private`
fadimounir [Wed, 12 Jun 2019 22:05:56 +0000 (15:05 -0700)]
Add a switch to suppress crossgen warnings
Carol Eidt [Thu, 13 Jun 2019 17:28:58 +0000 (10:28 -0700)]
Don't try to fold constants for GT_HWIntrinsic (#25139)
Fix #25133
jashook [Thu, 13 Jun 2019 16:31:33 +0000 (16:31 +0000)]
Add more context to the nmake comment
jashook [Thu, 13 Jun 2019 16:05:53 +0000 (16:05 +0000)]
Fix nmake build
Michal Strehovský [Thu, 13 Jun 2019 07:58:50 +0000 (09:58 +0200)]
Emit a message when skipping a method in crossgen (#25125)
Since crossgen normally prints a message when the compilation didn't happen (because e.g. something is not supported), we should print something here too. Otherwise the `/verbose` log makes it look like pregeneration succeeded and sends someone down a wrong path investigating why it's not picked up at runtime...
jashook [Thu, 13 Jun 2019 05:11:49 +0000 (05:11 +0000)]
Fix set syntax
jashook [Thu, 13 Jun 2019 04:29:29 +0000 (04:29 +0000)]
Also use WriteLinesToFile for IBC merge and read in the file in build.cmd
jashook [Thu, 13 Jun 2019 03:59:50 +0000 (03:59 +0000)]
Add ${__CommonMSBuildArgs} to pass buildtype and arch
Santiago Fernandez Madero [Thu, 13 Jun 2019 01:12:07 +0000 (20:12 -0500)]
Fix a couple of annotations on Type (#25136)
* Fix a couple of annotations on Type
* PR Feedback
Kai Ruhnau [Thu, 13 Jun 2019 00:23:20 +0000 (02:23 +0200)]
Also set the *__TRYRUN_OUTPUT cache value to something. (#24631)
CMake 3.14 fails in a cross-compilation ARM build and complains
that both both *_EXITCODE and *_EXITCODE__TRYRUN_OUTPUT have
to be set. Doing this re-enables the build.
Jarret Shook [Wed, 12 Jun 2019 22:17:07 +0000 (15:17 -0700)]
use nodeReuse:false in build.sh and build-test.sh. (#25101)
* use nodeReuse:false in build.sh and build-test.sh.
* Address feedback
jashook [Wed, 12 Jun 2019 22:16:40 +0000 (22:16 +0000)]
Change how build.sh/build.cmd parse the PGO and IBC versions
This will reduce fragility in our build pipeline, by explicitely controlling the output of dotnet msbuild. It also unblocks the source-build effort, as source-build will write extra console output breaking our old parsing.
Stephen Toub [Wed, 12 Jun 2019 19:09:49 +0000 (15:09 -0400)]
Replace 'where T : object` with `where T : notnull`
dotnet-maestro[bot] [Wed, 12 Jun 2019 17:41:32 +0000 (10:41 -0700)]
Update dependencies from dotnet/arcade (dotnet/corefx#38474)
* Update dependencies from https://github.com/dotnet/arcade build
20190611.2
- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19311.2
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19311.2
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19311.2
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19311.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19311.2
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19311.2
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19311.2
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19311.2
* Update `where T : object` constraint to be `where T : notnull`
* Update several TODO-NULLABLE comments
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Stephen Toub [Wed, 12 Jun 2019 15:12:31 +0000 (11:12 -0400)]
Fix nullable annotations on Binder.ReorderArgumentArray
Stephen Toub [Wed, 12 Jun 2019 15:00:51 +0000 (11:00 -0400)]
Remove defunct !s and update some TODO-NULLABLE comments
dotnet-maestro [Wed, 12 Jun 2019 12:25:40 +0000 (12:25 +0000)]
Update dependencies from https://github.com/dotnet/arcade build
20190611.2
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19311.2
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19311.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19311.2
Jeremy Koritzinsky [Wed, 12 Jun 2019 17:16:42 +0000 (10:16 -0700)]
Allocate handles for custom marshalers in ALCs instead of in the AppDomain. (#25105)
Jan Vorlicek [Wed, 12 Jun 2019 17:15:22 +0000 (19:15 +0200)]
Enable coreclr-runincontext in azure pipelines (#25073)
* Enable coreclr-runincontext in azure pipelines
jashook [Wed, 12 Jun 2019 17:07:38 +0000 (17:07 +0000)]
Address feedback
Carol Eidt [Wed, 12 Jun 2019 16:07:32 +0000 (09:07 -0700)]
SuperPMI: Fix `getFieldType` (#25102)
* SuperPMI: Fix `getFieldType`
The `structType` out parameter is optional (i.e. it may be null), but it's not used as a key, so we need to update the map if we've saved a null but encounter a non-null.
Marek Safar [Wed, 12 Jun 2019 14:33:18 +0000 (16:33 +0200)]
Convert PermissionSet NIE to PlatformNotSupportedException (#25114)
Michal Strehovský [Wed, 12 Jun 2019 14:32:53 +0000 (16:32 +0200)]
Expose readonly heap segments to DAC (#25113)
This was in CoreRT's copy of gcinterface.dac.h, but got lost in dotnet/corert#7517.
Stephen Toub [Wed, 12 Jun 2019 13:42:08 +0000 (06:42 -0700)]
Add missing TraceOperationCreation log event in GetStateMachineBox (#25097)
This was removed accidentally as part of overhauling the async infrastructure in 2.1. VS depends on it for some task tracking logic.
Jan Vorlicek [Wed, 12 Jun 2019 11:27:12 +0000 (13:27 +0200)]
Fix Module::IsInSameVersionBubble contract (#25106)
* Fix Module::IsInSameVersionBubble contract
The function had an incorrect contract indicating that it cannot throw
and that it cannot trigger GC. This is not true in case the underlying
GetNativeAssemblyImport loads the manifest.
Change the contract to STANDARD_VM_CONTRACT
Suchiman [Tue, 11 Jun 2019 19:38:23 +0000 (21:38 +0200)]
CoreRT change
Suchiman [Sun, 9 Jun 2019 16:18:44 +0000 (18:18 +0200)]
Ensure gen0_max_size to be initially >= gen0_min_size
Otherwise, gen0_min_size is eventually capped by gen0_max_size, which makes it impossible to raise gen0 size above the default max sizes for gen0.
This is required for some scenarios (CppCodeGen, WASM) in CoreRT.
Suchiman [Tue, 11 Jun 2019 19:32:51 +0000 (21:32 +0200)]
Multiple CoreRT changes
Suchiman [Tue, 11 Jun 2019 19:30:57 +0000 (21:30 +0200)]
Fix casts
Suchiman [Tue, 11 Jun 2019 19:17:46 +0000 (21:17 +0200)]
Fix Redhawk defines
Suchiman [Tue, 11 Jun 2019 19:14:57 +0000 (21:14 +0200)]
UNREFERENCED_PARAMETER
Suchiman [Tue, 11 Jun 2019 18:18:39 +0000 (20:18 +0200)]
Port typo fixes from CoreRT
Andy Ayers [Wed, 12 Jun 2019 01:17:47 +0000 (18:17 -0700)]
JIT: use stress mode tail call validation info for implicit tail calls (#25093)
If a call site fails tail call stress validation, don't consider it for
implicit tail calling either.
In normal jitting we defer this level of validation until impImportCall
to avoid duplicating work.
This avoids an assert when we have invalid IL.
Fixes #25027.
Juan Hoyos [Wed, 12 Jun 2019 00:16:25 +0000 (17:16 -0700)]
Fix context restore for ARM/ARM64 debugging (#25089)
Andy Hanson [Tue, 11 Jun 2019 23:20:29 +0000 (16:20 -0700)]
Fall back to CpuId if failed to get cache size from OS (#24989)
* Fall back to CpuId if failed to get cache size from OS
It's possible for GetLogicalProcessorCacheSizeFromOS() to fail;
this happens on alpine linux where it compiles to just `return 0;`.
As a fallback, we can get the cache size from CpuId. Previously that
was specific to x86; this PR preserves the behavior that we never call
GetLogicalProcessorCacheSizeFromOS on x86.
CpuId only works on x86 and amd64; on other systems we may still return
0 from here. Then GC defaults to a cache size of only 0.25MB.
Note: Removed the code in an `#ifdef _WIN64` that was nested inside of
`#if defined (_TARGET_X86_)`. Presuming that is dead code.
* Fix exception handler
Jan Vorlicek [Tue, 11 Jun 2019 22:42:46 +0000 (00:42 +0200)]
Fix ForeignThreadExceptions test (#25074)
This test creates a native thread on which it calls a managed callback. It uses
std::thread to create the thread. The problem is that on MUSL based Linux distros,
the default stack size for secondary threads is 80kB, which is not enough for this
test.
Since std::thread has no way to set the thread stack size, the fix is to use
pthreads on Unix and keep the std::thread for Windows only.
jashook [Tue, 11 Jun 2019 21:57:57 +0000 (21:57 +0000)]
use nodeReuse:false in build.sh and build-test.sh.
Bruce Forstall [Tue, 11 Jun 2019 21:18:08 +0000 (14:18 -0700)]
Improve corefx testing (#24962)
CoreFX tests are now used to test CoreCLR on Windows/x64 and Linux/x64.
PR testing includes normal and no-tiered modes. CI testing will include
all JIT stress modes that apply to CoreCLR testing. Many tests have been
disabled to allow the jobs to (mostly) run error-free.
Support for other platforms requires fixes to the testhost generation.
Sinan Kaya [Tue, 11 Jun 2019 21:08:08 +0000 (17:08 -0400)]
Compilation fixes (#25084)
Koundinya Veluri [Tue, 11 Jun 2019 20:56:40 +0000 (13:56 -0700)]
Track timer count and add Timer.ActiveCount (#25061)
* Track timer count and add Timer.Count
Part of https://github.com/dotnet/corefx/issues/38422
* Use lock to prevent tearing
* Add assert
* Rename Count to ActiveCount
* Fix build
Andrew Au [Tue, 11 Jun 2019 20:51:09 +0000 (13:51 -0700)]
Use the per session configuration to invoke the EventPipeProvider callbacks (#25088)
* Use the per session configuration to invoke the EventPipeProvider callbacks
* Avoid making the callback if the session does not have the provider
Jan Kotas [Tue, 11 Jun 2019 20:18:03 +0000 (13:18 -0700)]
Delete dead code (#25066)
David Wrighton [Tue, 11 Jun 2019 20:13:09 +0000 (13:13 -0700)]
R2R ilstubs (#24823)
* Basic support for precompiled pinvoke stubs
* Generate R2R file with multiple references to same IL stub (one per method which the IL stub is associated with)
* Not all il stubs are p/invokes. Don't fail when they aren't.
* Consistently use IsDynamicScope and GetModule to avoid unsafe memory access in IL stub compilation paths
* Enable full p/invoke il stubs when compiling System.Private.Corelib
* Disable IL Stub generation in crossgen for ARM32.
- The cross bitness logic is not correct for IL Stub generation
dotnet-maestro[bot] [Tue, 11 Jun 2019 19:00:31 +0000 (12:00 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190611.01 (#25078)
- Microsoft.NETCore.App - 3.0.0-preview7-27811-01
Andrew Au [Tue, 11 Jun 2019 18:00:34 +0000 (11:00 -0700)]
Make GetSessionProvider const (#25085)
Koundinya Veluri [Tue, 11 Jun 2019 17:58:05 +0000 (10:58 -0700)]
Refactor one-time ETL rundown event firing (#24993)
- Moved the `RuntimeInformation` and `TieredCompilation/Settings` events to fire on rundown on attach/detach
Stephen Toub [Tue, 11 Jun 2019 16:08:18 +0000 (09:08 -0700)]
Update IEquatable/IComparable<T> for nullability (#25053)
We need to revise our use of nullable for `IComparable<T>` and `IEquatable<T>`:
- For reference types that implement `IComparable<T>`, the implementation should use `IComparable<T?>`, e.g. `String : IComparable<String?>`, so that the type can be used in methods with a `where T : IComparable<T>` constraint: `IComparable<T>`'s contravariance then allows both `T` and `T?` to work as generic type arguments.
- For reference types that implement `IEquatable<T>`, we can't take advantage of such contravariance, as by design `IEquatable<T>` is invariant (it would be a breaking change to make it contravariant, and even if it wasn't doing so is of questionable design given that equality and inheritance don't mix well). Given the current language design, we have little option but to explicitly make any reference type implementations of `IEquatable<T>` be oblivious, and also make all `where T : IEquatable<T>` constraints be oblivious. Otherwise, regardless nullable annotations, a developer will get a warning for using either or both of `T`/`T?` with any given method employing such a constraint.
dotnet-maestro[bot] [Tue, 11 Jun 2019 14:22:26 +0000 (14:22 +0000)]
Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190610.3 (#25079)
- optimization.IBC.CoreCLR - 99.99.99-master-
20190610.3
- optimization.PGO.CoreCLR - 99.99.99-master-
20190610.3
dotnet-maestro[bot] [Tue, 11 Jun 2019 14:08:08 +0000 (07:08 -0700)]
Update dependencies from https://github.com/dotnet/corefx build
20190611.1 (#25077)
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19311.1
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19311.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19311.1
dotnet-maestro[bot] [Tue, 11 Jun 2019 14:07:54 +0000 (07:07 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190610.24 (#25076)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19310.24
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19310.24
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19310.24
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19310.24
Jan Vorlicek [Tue, 11 Jun 2019 08:54:52 +0000 (10:54 +0200)]
Enable lab support for coreclr tests in unloadable context (#25064)
Koundinya Veluri [Tue, 11 Jun 2019 06:27:02 +0000 (23:27 -0700)]
Add optimization tiers to the Linux perf maps for perfcollect (#24967)
Add optimization tiers to the Linux perf maps for perfcollect
Fixes https://github.com/dotnet/coreclr/issues/23222:
- It looks like module unloads are currently not taken into account. Once they would be taken into account, Although we have method JIT events from `lttng` with the code address and optimization tier, samples can only be associated with method JIT events by associating the time range when the module is loaded with times of samples, and the event times from `lttng` would not necessarily correspond with times from samples taken by `perf`.
- Updated to include the optimization tier in the perf map for each jitted or R2R method code address
- Refactored common code between eventtrace and perfmap for getting jit tiers
Jeremy Koritzinsky [Tue, 11 Jun 2019 04:33:00 +0000 (21:33 -0700)]
Switch P/Invokes into libcoreclr for the PAL to QCalls (#25055)
* Switch PInvokes into libcoreclr to QCalls
* Register QCalls in runtime. Remove pal exports from libcoreclr
* Alphabetize new ecalllist.h entries
* Remove W suffixes from native side of QCall
* Interop signatures are in nested classes (which doesn't show up here) in the root namespace. So we don't want to pass a namespace in here
* Convert the interop test in R2R to use a local native library instead of calling into the CoreCLR PAL via DllImport.
Avi Avni [Tue, 11 Jun 2019 00:22:34 +0000 (03:22 +0300)]
fix generic attribute bug when generic attribute has parameters and the parameters (#25054)
* fix generic attribute bug
* add missing test cases
Jan Vorlicek [Tue, 11 Jun 2019 00:22:13 +0000 (02:22 +0200)]
Fix inline tracking (#25062)
Inline tracking didn't correctly place the right key into the
inline tracking map for generics. The logic places the instantiated
methoddesc into the tracking map, and then attempts to find it by
looking up the uninstantiated form. This would generally be a silent
failure, but in unloadable assembly testing we have an assert that the
CrossLoaderAllocatorHash holds as keys items from a matching
LoaderAllocator.
This issue also results in an assert `key->GetLoaderAllocator() ==
m_pLoaderAllocator` in CrossLoaderAllocatorHash when the code is
running inside of a collectible AssemblyLoadContext.
dotnet-maestro[bot] [Mon, 10 Jun 2019 23:20:44 +0000 (16:20 -0700)]
[master] Update dependencies from dotnet/core-setup (#25005)
* Update dependencies from https://github.com/dotnet/core-setup build
20190605.02
- Microsoft.NETCore.App - 3.0.0-preview7-27805-02
* Update dependencies from https://github.com/dotnet/core-setup build
20190606.03
- Microsoft.NETCore.App - 3.0.0-preview7-27806-03
* Update dependencies from https://github.com/dotnet/core-setup build
20190608.01
- Microsoft.NETCore.App - 3.0.0-preview7-27808-01
* Update dependencies from https://github.com/dotnet/core-setup build
20190609.01
- Microsoft.NETCore.App - 3.0.0-preview7-27809-01
* Update dependencies from https://github.com/dotnet/core-setup build
20190610.02
- Microsoft.NETCore.App - 3.0.0-preview7-27810-02
Leandro A. F. Pereira [Mon, 10 Jun 2019 22:44:29 +0000 (15:44 -0700)]
Use pread() to read DOS/NT headers when mapping PE files (#25059)
Shaves off two syscalls per managed assembly load.
Jarret Shook [Mon, 10 Jun 2019 21:13:27 +0000 (14:13 -0700)]
Add source-build hook for dotnet install (#24929)
* Add source-build hook for dotnet install
* Fix batch syntax
* Address feedback
* Use the correct returned variables:
unix: _InitializeDotNetCli
windows: DOTNET_TOOL_DIR
* Remove changes to dotnet.cmd
* Do not export, just use _InitializeDotNetCli
Maryam Ariyan [Mon, 10 Jun 2019 21:09:07 +0000 (14:09 -0700)]
Make Debug.Print(string) behavior consistent with .NET Framework (#25036)
* Debug.Print should call Debug.WriteLine
- to behave similar to .NET Framework
* temporarily disable tests
- Waiting for coreclr/fx changes to propagate
noahfalk [Mon, 10 Jun 2019 20:48:50 +0000 (13:48 -0700)]
Add support for the NetTrace EventPipe file format
Right now the new format is not on by default, but it can be enabled using COMPlus_EventPipeNetTraceFormat = 1 for testing purposes. The plan to have a follow up PR that will add shipping configuration mechanisms and change the default setting.
See the documentation in the PerfView repo for more details about the format. At a glance the goal is to create a format that is more efficient to produce, has a smaller on disk size, and offers enhanced functionality in a few areas:
a) 64 bit thread id support
b) Detection of dropped events via sequence numbers
c) Better support for extracting subsets of the file
Together with the change there was also some refactoring of the EventPipeBufferManager and EventPipeThread.
This change addresses (at least in part) the following issues:
#19688, #23414, #24188, #20751, #20555, #21827, #24852, #25046
dotnet-maestro[bot] [Mon, 10 Jun 2019 15:22:45 +0000 (15:22 +0000)]
[master] Update dependencies from dnceng/internal/dotnet-optimization (#25023)
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190606.3
- optimization.IBC.CoreCLR - 99.99.99-master-
20190606.3
- optimization.PGO.CoreCLR - 99.99.99-master-
20190606.3
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build
20190610.1
- optimization.IBC.CoreCLR - 99.99.99-master-
20190610.1
- optimization.PGO.CoreCLR - 99.99.99-master-
20190610.1
dotnet-maestro[bot] [Mon, 10 Jun 2019 15:11:43 +0000 (11:11 -0400)]
[master] Update dependencies from dotnet/corefx (#25022)
* Update dependencies from https://github.com/dotnet/corefx build
20190606.9
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19306.9
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19306.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19306.9
* Update dependencies from https://github.com/dotnet/corefx build
20190607.10
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19307.10
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19307.10
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19307.10
* Update dependencies from https://github.com/dotnet/corefx build
20190609.1
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19309.1
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19309.1
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19309.1
* Update dependencies from https://github.com/dotnet/corefx build
20190609.5
- Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview7.19309.5
- Microsoft.NETCore.Platforms - 3.0.0-preview7.19309.5
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview7.19309.5
dotnet-maestro[bot] [Mon, 10 Jun 2019 15:11:04 +0000 (11:11 -0400)]
Update dependencies from https://github.com/dotnet/arcade build
20190609.1 (#25051)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19309.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19309.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19309.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19309.1
Mukul Sabharwal [Mon, 10 Jun 2019 15:09:12 +0000 (08:09 -0700)]
Use SIZE_T for SectionSize in RegisterFrozenSegment (#25044)
Jan Vorlicek [Mon, 10 Jun 2019 14:33:42 +0000 (16:33 +0200)]
Fix field offset computation for large version bubble (#25029)
There was a discrepancy in field offset calculations at crossgen time
and at runtime in some rare cases due to the alignment of a derived
class offset.
The issue happened due to MethodTableBuilder::NeedsAlignedBaseOffset not
taking into account the fact that the module of the parent and child
class can both be in large version bubble.
We also had a bug in the PEDecoder::GetNativeManifestMetadata. When it
was called for regular crossgened image without large version bubble, it
left the pDir uninitialized due to the fact that there was no
READYTORUN_SECTION_MANIFEST_METADATA. And then it tried to dereference
that.