platform/upstream/coreutils.git
20 years agochown --dereference did nothing when the owner/group of a
Jim Meyering [Sun, 16 May 2004 21:39:35 +0000 (21:39 +0000)]
chown --dereference did nothing when the owner/group of a
symlink matched the desired owner/group.  Reported by David Malone.
Also reported in 1999 as http://bugs.debian.org/39642.

(change_file_owner): When --dereference has
been specified, and when processing a symlink, stat it to get the
owner and group of the referent.

20 years ago*** empty log message ***
Jim Meyering [Sun, 16 May 2004 19:32:37 +0000 (19:32 +0000)]
*** empty log message ***

20 years agoIn shred, check for errors from fdatasync more carefully. If
Jim Meyering [Sun, 16 May 2004 19:32:30 +0000 (19:32 +0000)]
In shred, check for errors from fdatasync more carefully.  If
fdatasync fails with errno==EINVAL, it means this implementation
does not support synchronized I/O for this file.  Do not report
this as an error, as (for example) AIX 5.2 fdatasync reports it
for raw disk devices.  Problem reported by Albert Chin in
<http://mail.gnu.org/archive/html/bug-gnu-utils/2004-05/msg00028.html>.

Check for write errors, though: the old code ignored them.
Improve error checking in a few other cases, too (e.g., close of a
directory).

Also, change several 'int' values to 'bool', so that the error
checking is a bit clearer.  Similarly, change unsigned values
to size_t where appropriate.

* src/shred.c: Include "dirname.h".
(datasync) [!HAVE_FDATASYNC]: Remove.
(dosync): New function.
(dopass): Use it.  Return 1 on write error, -1 on other error.
All callers changed.  Report write error if dosync does.
(do_wipefd, wipefd, wipename, wipefile): Return bool (true/false),
not int (0/-1).  All callers changed.  Return false if there's a
write error.
(incname): Return bool (true/false), not int (0/1).  Accept
size_t length, not unsigned.  All callers changed.  Do not
bother checking for non-digits; it can't happen.  Replace
recursion with iteration.
(wipename): Use dir_name, base_name, etc. instead of assuming
Unix file names.  Use size_t for length, not unsigned.
Report error if unlink or close fails.
(wipename, main): Use bool for booleans.

(names): Use only digits and uppercase letters, for greater
portability.

20 years ago*** empty log message ***
Jim Meyering [Sun, 16 May 2004 14:18:50 +0000 (14:18 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Sun, 16 May 2004 14:17:53 +0000 (14:17 +0000)]
*** empty log message ***

20 years ago(TESTS): Add deref.
Jim Meyering [Sun, 16 May 2004 14:10:17 +0000 (14:10 +0000)]
(TESTS): Add deref.

20 years agoNew test for the yesterday's change.
Jim Meyering [Sun, 16 May 2004 14:10:10 +0000 (14:10 +0000)]
New test for the yesterday's change.

20 years ago*** empty log message ***
Jim Meyering [Sat, 15 May 2004 18:27:38 +0000 (18:27 +0000)]
*** empty log message ***

20 years ago.
Jim Meyering [Sat, 15 May 2004 14:59:15 +0000 (14:59 +0000)]
.

20 years ago(AD_pop_and_chdir): Eliminate an unnecessary call to AC_stack_top.
Jim Meyering [Fri, 14 May 2004 15:47:53 +0000 (15:47 +0000)]
(AD_pop_and_chdir): Eliminate an unnecessary call to AC_stack_top.

20 years ago.
Jim Meyering [Fri, 14 May 2004 09:16:23 +0000 (09:16 +0000)]
.

20 years ago*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:34:16 +0000 (07:34 +0000)]
*** empty log message ***

20 years agoImprove performance of `sort -m' on large files, at the cost of
Jim Meyering [Fri, 14 May 2004 07:34:09 +0000 (07:34 +0000)]
Improve performance of `sort -m' on large files, at the cost of
making some contrived examples unsafe.  POSIX allows this
optimization.  Performance problem reported by Jonathan Baker in
<http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00071.html>.

(first_same_file): Do not treat input pipes
differently from other files.

20 years agoDocument that "sort -m -o F" might write F before reading all the input.
Jim Meyering [Fri, 14 May 2004 07:33:48 +0000 (07:33 +0000)]
Document that "sort -m -o F" might write F before reading all the input.

20 years ago*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:33:23 +0000 (07:33 +0000)]
*** empty log message ***

20 years ago(sort invocation): Document that "sort -m -o F"
Jim Meyering [Fri, 14 May 2004 07:32:56 +0000 (07:32 +0000)]
(sort invocation): Document that "sort -m -o F"
might write F before reading all the input.

20 years ago*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:29:41 +0000 (07:29 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Fri, 14 May 2004 07:29:04 +0000 (07:29 +0000)]
*** empty log message ***

20 years agoFix typo: s/supercede/supersede/.
Jim Meyering [Fri, 14 May 2004 07:28:39 +0000 (07:28 +0000)]
Fix typo: s/supercede/supersede/.

20 years ago*** empty log message ***
Jim Meyering [Thu, 13 May 2004 07:27:25 +0000 (07:27 +0000)]
*** empty log message ***

20 years ago(unquote, make_printable_str): Use e.g. '\a' rather than '\007',
Jim Meyering [Thu, 13 May 2004 07:27:10 +0000 (07:27 +0000)]
(unquote, make_printable_str): Use e.g. '\a' rather than '\007',
for portability to EBCDIC hosts.

20 years ago(print_esc_char): Use e.g. '\a' rather than '\007',
Jim Meyering [Thu, 13 May 2004 07:26:46 +0000 (07:26 +0000)]
(print_esc_char): Use e.g. '\a' rather than '\007',
for portability to EBCDIC hosts.

20 years ago(print_ascii, dump_strings): Use e.g. '\a' rather than
Jim Meyering [Thu, 13 May 2004 07:26:14 +0000 (07:26 +0000)]
(print_ascii, dump_strings): Use e.g. '\a' rather than
'\007', for portability to EBCDIC hosts.

20 years ago*** empty log message ***
Jim Meyering [Thu, 13 May 2004 07:05:05 +0000 (07:05 +0000)]
*** empty log message ***

20 years ago Don't assume that "make -C" works; Solaris "make" doesn't have -C.
Jim Meyering [Thu, 13 May 2004 07:04:58 +0000 (07:04 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.

* src/Makefile.am (all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.
* tests/Makefile.am (all_programs): Use it.
* man/Makefile.am (all_programs): Likewise.  Renamed from programs,
for consistency.  All uses changed.

20 years ago Don't assume that "make -C" works; Solaris "make" doesn't have -C.
Jim Meyering [Thu, 13 May 2004 07:03:52 +0000 (07:03 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.

* src/Makefile.am (all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.
* tests/Makefile.am (all_programs): Use it.

20 years agoDon't assume that "make -C" works; Solaris "make" doesn't have -C.
Jim Meyering [Thu, 13 May 2004 07:03:00 +0000 (07:03 +0000)]
Don't assume that "make -C" works; Solaris "make" doesn't have -C.

(all_programs.list): New rule, copied from
man/Makefile.am and tests/Makefile.am, except that we use the
system tr rather than ./tr and we don't use tr -s.

20 years ago*** empty log message ***
Jim Meyering [Wed, 12 May 2004 09:35:19 +0000 (09:35 +0000)]
*** empty log message ***

20 years ago(AD_pop_and_chdir): Move lstat-`.' into if-block
Jim Meyering [Wed, 12 May 2004 09:35:06 +0000 (09:35 +0000)]
(AD_pop_and_chdir): Move lstat-`.' into if-block
where the result is used.  This avoids one unnecessary lstat call
per command line argument.

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 19:41:37 +0000 (19:41 +0000)]
*** empty log message ***

20 years ago(TESTS): Add unread3.
Jim Meyering [Tue, 11 May 2004 19:41:33 +0000 (19:41 +0000)]
(TESTS): Add unread3.

20 years agoNew test, for the above fix and today's lib/save-cwd.c improvement.
Jim Meyering [Tue, 11 May 2004 19:41:23 +0000 (19:41 +0000)]
New test, for the above fix and today's lib/save-cwd.c improvement.

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 18:34:56 +0000 (18:34 +0000)]
*** empty log message ***

20 years ago(save_cwd): If opening `.' read-only fails, try write-only.
Jim Meyering [Tue, 11 May 2004 18:34:38 +0000 (18:34 +0000)]
(save_cwd): If opening `.' read-only fails, try write-only.

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 18:25:32 +0000 (18:25 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:50:25 +0000 (16:50 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:48:42 +0000 (16:48 +0000)]
*** empty log message ***

20 years ago(save_cwd) [HAVE_FCHDIR]: Don't fail just
Jim Meyering [Tue, 11 May 2004 16:42:17 +0000 (16:42 +0000)]
(save_cwd) [HAVE_FCHDIR]: Don't fail just
because opening `.' failed.  Resort to using xgetcwd.

20 years ago*** empty log message ***
Jim Meyering [Tue, 11 May 2004 16:14:22 +0000 (16:14 +0000)]
*** empty log message ***

20 years agoDon't include "save-cwd.h". It's no longer used.
Jim Meyering [Tue, 11 May 2004 16:14:11 +0000 (16:14 +0000)]
Don't include "save-cwd.h".  It's no longer used.

20 years ago.
Jim Meyering [Mon, 10 May 2004 18:15:41 +0000 (18:15 +0000)]
.

20 years ago*** empty log message ***
Jim Meyering [Mon, 10 May 2004 15:13:52 +0000 (15:13 +0000)]
*** empty log message ***

20 years ago(TESTS): Add trap.
Jim Meyering [Mon, 10 May 2004 15:13:45 +0000 (15:13 +0000)]
(TESTS): Add trap.

20 years agoNew file. Test for bug fix of 2004-04-18.
Jim Meyering [Mon, 10 May 2004 15:13:29 +0000 (15:13 +0000)]
New file.  Test for bug fix of 2004-04-18.

20 years ago*** empty log message ***
Jim Meyering [Mon, 10 May 2004 14:27:53 +0000 (14:27 +0000)]
*** empty log message ***

20 years ago(AD_push): Don't use errno in diagnostic about `changed dev/ino'.
Jim Meyering [Mon, 10 May 2004 14:27:45 +0000 (14:27 +0000)]
(AD_push): Don't use errno in diagnostic about `changed dev/ino'.

20 years ago*** empty log message ***
Jim Meyering [Mon, 10 May 2004 07:15:56 +0000 (07:15 +0000)]
*** empty log message ***

20 years agoRemove this generated file from CVS.
Jim Meyering [Mon, 10 May 2004 07:15:03 +0000 (07:15 +0000)]
Remove this generated file from CVS.

20 years ago.
Jim Meyering [Mon, 10 May 2004 07:04:59 +0000 (07:04 +0000)]
.

20 years ago.
Jim Meyering [Sun, 9 May 2004 19:44:10 +0000 (19:44 +0000)]
.

20 years ago.
Jim Meyering [Sun, 9 May 2004 19:43:35 +0000 (19:43 +0000)]
.

20 years ago*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:43:27 +0000 (19:43 +0000)]
*** empty log message ***

20 years ago(check-texinfo): grep -w IO
Jim Meyering [Sun, 9 May 2004 19:43:23 +0000 (19:43 +0000)]
(check-texinfo): grep -w IO

20 years ago*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:42:23 +0000 (19:42 +0000)]
*** empty log message ***

20 years ago(stat invocation): Change IO to I/O.
Jim Meyering [Sun, 9 May 2004 19:42:19 +0000 (19:42 +0000)]
(stat invocation): Change IO to I/O.

20 years ago*** empty log message ***
Jim Meyering [Sun, 9 May 2004 19:29:54 +0000 (19:29 +0000)]
*** empty log message ***

20 years ago(unquote): Use xcalloc rather than xmalloc and
Jim Meyering [Sun, 9 May 2004 19:29:42 +0000 (19:29 +0000)]
(unquote): Use xcalloc rather than xmalloc and
a loop initializing the just-allocated memory to zero.

20 years ago*** empty log message ***
Jim Meyering [Sat, 8 May 2004 22:24:25 +0000 (22:24 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Sat, 8 May 2004 12:49:57 +0000 (12:49 +0000)]
*** empty log message ***

20 years ago(TESTS): Add no-give-up.
Jim Meyering [Sat, 8 May 2004 12:49:53 +0000 (12:49 +0000)]
(TESTS): Add no-give-up.

20 years agoFix bug where "rm" gave up too easily, reported by Dan Jacobsen in
Jim Meyering [Sat, 8 May 2004 12:49:22 +0000 (12:49 +0000)]
Fix bug where "rm" gave up too easily, reported by Dan Jacobsen in
<http://mail.gnu.org/archive/html/bug-coreutils/2004-05/msg00013.html>.

(remove_entry): Check for errno values like ENOENT
that show the file cannot be directory, instead of for errno
values like EPERM that show the file might be a directory.  This
is necessary because, when a single unlink() call has multiple
reasons to fail, it can set errno to any of those reasons; it's
only the rare errno value like ENOENT that excludes all the other
possible reasons to fail even when the file is a directory.
(remove_cwd_entries): Don't attempt chdir if the file is known
to not be a directory.
(remove_dir): Use the same method that remove_cwd_entries uses
(for some reason they differed).  Don't assert that saved_errno
must be EPERM; it might be just about anything.

20 years agoNew file; check for the above fix.
Jim Meyering [Sat, 8 May 2004 12:47:23 +0000 (12:47 +0000)]
New file; check for the above fix.

20 years agoUpdate from gnulib.
Jim Meyering [Fri, 7 May 2004 06:48:31 +0000 (06:48 +0000)]
Update from gnulib.
(obstack_finish): Rename local: s/value/__value/.

20 years agoUpdate from gnulib.
Jim Meyering [Fri, 7 May 2004 06:48:12 +0000 (06:48 +0000)]
Update from gnulib.
(_): Define only if not already defined.

20 years ago*** empty log message ***
Jim Meyering [Thu, 6 May 2004 15:35:13 +0000 (15:35 +0000)]
*** empty log message ***

20 years ago(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:51:20 +0000 (14:51 +0000)]
(main): Use xnmalloc, rather than xmalloc.

20 years ago(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:50:17 +0000 (14:50 +0000)]
(main): Use xnmalloc, rather than xmalloc.

20 years ago(list_entries_users): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:49:32 +0000 (14:49 +0000)]
(list_entries_users): Use xnmalloc, rather than xmalloc.

20 years ago(do_wipefd): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:48:07 +0000 (14:48 +0000)]
(do_wipefd): Use xnmalloc, rather than xmalloc.

20 years ago(xgetgroups): Use variable name, rather than type name in computing buffer
Jim Meyering [Thu, 6 May 2004 14:46:00 +0000 (14:46 +0000)]
(xgetgroups): Use variable name, rather than type name in computing buffer
size for xnmalloc.

20 years ago(xgetgroups): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:43:31 +0000 (14:43 +0000)]
(xgetgroups): Use xnmalloc, rather than xmalloc.
Don't add `1' to the buffer size (it was to protect against malloc
implementations that fail to allocate a buffer of size zero).
That is no longer necessary, since we use a malloc wrapper
on such systems.

20 years ago(main): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:24:50 +0000 (14:24 +0000)]
(main): Use xnmalloc, rather than xmalloc.

20 years ago(elide_tail_bytes_pipe): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:24:16 +0000 (14:24 +0000)]
(elide_tail_bytes_pipe): Use xnmalloc, rather than xmalloc.

20 years ago(get_input_fstatus): Use xnmalloc, rather than xmalloc.
Jim Meyering [Thu, 6 May 2004 14:23:08 +0000 (14:23 +0000)]
(get_input_fstatus): Use xnmalloc, rather than xmalloc.

20 years ago.
Jim Meyering [Tue, 4 May 2004 11:36:13 +0000 (11:36 +0000)]
.

20 years ago*** empty log message ***
Jim Meyering [Tue, 4 May 2004 07:26:41 +0000 (07:26 +0000)]
*** empty log message ***

20 years ago(show_disk, show_point): If several filesystems are
Jim Meyering [Tue, 4 May 2004 07:26:33 +0000 (07:26 +0000)]
(show_disk, show_point): If several filesystems are
mounted on the same mount point, prefer the last one, not the first.
Problem reported by Christian Jones in
<http://mail.gnu.org/archive/html/bug-coreutils/2004-04/msg00200.html>.
(show_disk): Remove unused statp arg.  Return bool, not int.
(show_point): Rewrite to avoid gotos.  Use the same algorithm
for lofs and dummies for each pass through the mount table,
rather than subtly different algorithms (which are probably
inadvertent).

20 years ago*** empty log message ***
Jim Meyering [Mon, 3 May 2004 12:50:32 +0000 (12:50 +0000)]
*** empty log message ***

20 years ago(lchown) [CHOWN_MODIFIES_SYMLINK]: Just call chown.
Jim Meyering [Mon, 3 May 2004 12:50:24 +0000 (12:50 +0000)]
(lchown) [CHOWN_MODIFIES_SYMLINK]: Just call chown.

20 years ago*** empty log message ***
Jim Meyering [Mon, 3 May 2004 11:52:46 +0000 (11:52 +0000)]
*** empty log message ***

20 years ago*** empty log message ***
Jim Meyering [Mon, 3 May 2004 11:52:39 +0000 (11:52 +0000)]
*** empty log message ***

20 years ago(EXTRA_DIST): Add m4/ChangeLog, now that we no longer have m4/Makefile*.
Jim Meyering [Mon, 3 May 2004 11:52:33 +0000 (11:52 +0000)]
(EXTRA_DIST): Add m4/ChangeLog, now that we no longer have m4/Makefile*.

20 years ago*** empty log message ***
Jim Meyering [Mon, 3 May 2004 11:50:52 +0000 (11:50 +0000)]
*** empty log message ***

20 years ago.
Jim Meyering [Mon, 3 May 2004 11:07:59 +0000 (11:07 +0000)]
.

20 years agoTemporary work-around for the problem reported here:
Jim Meyering [Mon, 3 May 2004 11:03:14 +0000 (11:03 +0000)]
Temporary work-around for the problem reported here:
http://sources.redhat.com/ml/automake/2004-05/msg00023.html
(FIXME: the number `23' may not be accurate)

(AM_GNU_GETTEXT): Don't require AM_INTL_SUBDIR.
(AM_INTL_SUBDIR): Comment out definition.

20 years ago*** empty log message ***
Jim Meyering [Sat, 1 May 2004 16:45:58 +0000 (16:45 +0000)]
*** empty log message ***

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:45:39 +0000 (16:45 +0000)]
Remove unused file.

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:44:31 +0000 (16:44 +0000)]
Remove unused file.

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:43:46 +0000 (16:43 +0000)]
Remove unused file.

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:41:43 +0000 (16:41 +0000)]
Remove unused file.

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:41:02 +0000 (16:41 +0000)]
Remove unused file.

20 years agoRemove unused file.
Jim Meyering [Sat, 1 May 2004 16:39:48 +0000 (16:39 +0000)]
Remove unused file.

20 years agoRemove file. This is now part of mktime.m4.
Jim Meyering [Sat, 1 May 2004 16:38:12 +0000 (16:38 +0000)]
Remove file.  This is now part of mktime.m4.

20 years ago.
Jim Meyering [Sat, 1 May 2004 16:20:22 +0000 (16:20 +0000)]
.

20 years ago.
Jim Meyering [Sat, 1 May 2004 14:42:45 +0000 (14:42 +0000)]
.

20 years ago*** empty log message ***
Jim Meyering [Sat, 1 May 2004 14:42:06 +0000 (14:42 +0000)]
*** empty log message ***

20 years ago(gl_MACROS): Move fchown-checking code to chown.m4.
Jim Meyering [Sat, 1 May 2004 14:42:00 +0000 (14:42 +0000)]
(gl_MACROS): Move fchown-checking code to chown.m4.

20 years ago(gl_PREREQ_CHOWN): Check for fcntl.h.
Jim Meyering [Sat, 1 May 2004 14:41:21 +0000 (14:41 +0000)]
(gl_PREREQ_CHOWN): Check for fcntl.h.
See if we need an fchown replacement.
(gl_FUNC_CHOWN_FOLLOWS_SYMLINK): New macro.
(gl_FUNC_CHOWN): Require gl_FUNC_CHOWN_FOLLOWS_SYMLINK,
and use the replacement function if we detect either defect.

20 years ago(rpl_chown) [CHOWN_FAILS_TO_HONOR_ID_OF_NEGATIVE_ONE]:
Jim Meyering [Sat, 1 May 2004 14:36:29 +0000 (14:36 +0000)]
(rpl_chown) [CHOWN_FAILS_TO_HONOR_ID_OF_NEGATIVE_ONE]:
Wrap old code with this conditional.
[CHOWN_MODIFIES_SYMLINK]: Try to work around a chown
function that does not dereference symlinks.

20 years agoWhen chown or chgrp is modifying the referent of a symlink,
Jim Meyering [Sat, 1 May 2004 14:33:41 +0000 (14:33 +0000)]
When chown or chgrp is modifying the referent of a symlink,
use the chown(2) function, if possible.

(change_file_owner): Don't hard-code the
open/fchown/close kludge here.  Use `chown' instead.
The chown function works just fine on conforming systems.
Other systems now go through the new chown wrapper that
resorts to the old kludge.