platform/upstream/dotnet/runtime.git
8 years agoAdd regression test
Mike Danes [Wed, 22 Jun 2016 20:59:17 +0000 (23:59 +0300)]
Add regression test

Commit migrated from https://github.com/dotnet/coreclr/commit/58c043d6907f1720b4b2bc2cfd2fe34fd15059b7

8 years agoFix statement insertion point in GT_STORE_LCL_VAR decomposition
Mike Danes [Wed, 22 Jun 2016 16:44:34 +0000 (19:44 +0300)]
Fix statement insertion point in GT_STORE_LCL_VAR decomposition

In some cases a newly created statement is inserted between the current statement and its embedded statements instead of being inserted after the current statement and its embedded statements.

Commit migrated from https://github.com/dotnet/coreclr/commit/b193390eca99368683835efdecb1f382b1443af3

8 years agoGeneric dictionary minor performance improvement and simplification for R2R (dotnet...
Fadi Hanna [Tue, 21 Jun 2016 18:51:05 +0000 (11:51 -0700)]
Generic dictionary minor performance improvement and simplification for R2R (dotnet/coreclr#5690)

A set of refactoring changes to slighly improve the performance of generic dictionary access on R2R images, and simplifying the codebase:
    1) Removing dependency on CEEInfo::ComputeRuntimeLookupForSharedGenericTokenStatic (and deleting the API).
    2) Stop parsing the generic type/method signatures when generating the R2R dictionary lookup assembly stub.
    3) Avoid re-encoding the generic type/method signatures in a new in-memory blob using a SigBuilder  (signatures used directly from the R2R image)
    4) Moved the parsing/loading of type/method signatures to Dictionary::PopulateEntry()
    5) Dictionary index and slot number are now encoded in the generated assembly stub instead of the signature (stub takes a pointer to a data blob, which contains the signature, the dictionary index and slot, and the module pointer)

Commit migrated from https://github.com/dotnet/coreclr/commit/b9f5ae88cc49836c8d31f07db7800707165cdb06

8 years agoMerge pull request dotnet/coreclr#5895 from briansull/UnboxingStub-Fix
Brian Sullivan [Tue, 21 Jun 2016 18:45:15 +0000 (11:45 -0700)]
Merge pull request dotnet/coreclr#5895 from briansull/UnboxingStub-Fix

Fix for generic unboxing stub with x8 return buffer argument

Commit migrated from https://github.com/dotnet/coreclr/commit/fb79613c44df5ad80831dba1460ffb14dd6497a3

8 years agoMerge pull request dotnet/coreclr#5813 from mikedn/no-setflags
Carol Eidt [Tue, 21 Jun 2016 18:10:47 +0000 (11:10 -0700)]
Merge pull request dotnet/coreclr#5813 from mikedn/no-setflags

Remove useless gtSetFlags calls

Commit migrated from https://github.com/dotnet/coreclr/commit/0d462da2173627b454dbe74f33828e0698cd963b

8 years agoMerge pull request dotnet/coreclr#5885 from brianrob/docker_perf
Brian Robbins [Tue, 21 Jun 2016 17:42:10 +0000 (10:42 -0700)]
Merge pull request dotnet/coreclr#5885 from brianrob/docker_perf

Update Linux Tracing Instructions for Docker Containers

Commit migrated from https://github.com/dotnet/coreclr/commit/51f010f8f219810282391a9e0dd08188bafd5a93

8 years agoMerge pull request dotnet/coreclr#5887 from gkhanna79/Fix5883
Gaurav Khanna [Tue, 21 Jun 2016 15:46:09 +0000 (08:46 -0700)]
Merge pull request dotnet/coreclr#5887 from gkhanna79/Fix5883

Update Prerelease version to Beta and increment patch version.

Commit migrated from https://github.com/dotnet/coreclr/commit/a576c83b0401fcfcc9e47e5cd3dcbe4c13871f58

8 years agoFix for generic unboxing stub with x8 return buffer argument
Brian Sullivan [Tue, 21 Jun 2016 01:29:11 +0000 (18:29 -0700)]
Fix for generic unboxing stub with x8 return buffer argument

When we have nonstandard args we have to handle them before
we setup to expect the return buffer arg.

Added additional JitDump information about the call and its return type in impImportCall.

All of the ARM64 EXPECTED_PASS tests will now pass when hasFixedRerBufReg is enabled.
Additional changes are needed for the IL_STUB_PInvoke to get the Interop tests to pass
But these tests are currentlt alreay in the EXPECTED_FAIL catagory.

Commit migrated from https://github.com/dotnet/coreclr/commit/3ddcd852cd36b350bcbb97ff0b6667e318e41e58

8 years agoUpdate Prerelease version to Beta and increment patch version.
Gaurav Khanna [Mon, 20 Jun 2016 20:56:09 +0000 (13:56 -0700)]
Update Prerelease version to Beta and increment patch version.

Commit migrated from https://github.com/dotnet/coreclr/commit/af7598e06f0df2a2df4894bbdfb5eb36b9dabb0d

8 years agoMerge pull request dotnet/coreclr#5893 from rahku/test
Rahul Kumar [Tue, 21 Jun 2016 01:52:22 +0000 (18:52 -0700)]
Merge pull request dotnet/coreclr#5893 from rahku/test

Enable building only native test components

Commit migrated from https://github.com/dotnet/coreclr/commit/cb0bb4e65ee1d2af116e3fb4e2dca116ae56fc03

8 years agoMerge pull request dotnet/coreclr#4983 from benaadams/patch-2
Aditya Mandaleeka [Tue, 21 Jun 2016 01:26:16 +0000 (18:26 -0700)]
Merge pull request dotnet/coreclr#4983 from benaadams/patch-2

Add slack channel

Commit migrated from https://github.com/dotnet/coreclr/commit/370e4143dfec911790c0e06a15156ddf5c91f310

8 years agoMerge pull request dotnet/coreclr#3074 from Dmitry-Me/useElseIfForExclusive
Aditya Mandaleeka [Tue, 21 Jun 2016 01:18:06 +0000 (18:18 -0700)]
Merge pull request dotnet/coreclr#3074 from Dmitry-Me/useElseIfForExclusive

Use else-if for mutually exclusive conditions

Commit migrated from https://github.com/dotnet/coreclr/commit/1973f0f500e33ca237f1587dfea71073bb9a997e

8 years agoEnable building only native test components
Rahul Kumar [Tue, 21 Jun 2016 00:01:34 +0000 (17:01 -0700)]
Enable building only native test components

Commit migrated from https://github.com/dotnet/coreclr/commit/ffac9c48557b58dc8e6369de92c66d6e97525afe

8 years agoMerge pull request dotnet/coreclr#5889 from wtgodbe/Loader
William Godbe [Mon, 20 Jun 2016 23:47:12 +0000 (16:47 -0700)]
Merge pull request dotnet/coreclr#5889 from wtgodbe/Loader

Fix race condition in Loader regression 523654 test

Commit migrated from https://github.com/dotnet/coreclr/commit/f6ad954733e4c8f0bbb342bc3412747663905cb2

8 years agoMerge pull request dotnet/coreclr#5879 from mattwarren/patch-1
Aditya Mandaleeka [Mon, 20 Jun 2016 23:38:49 +0000 (16:38 -0700)]
Merge pull request dotnet/coreclr#5879 from mattwarren/patch-1

Added links to CoreCLR issues, small formatting fix

Commit migrated from https://github.com/dotnet/coreclr/commit/cd469732bc763516dbde160ef5859afcc058cc65

8 years agoMerge pull request dotnet/coreclr#5888 from adityamandaleeka/generate_core_dumps_runtest
Aditya Mandaleeka [Mon, 20 Jun 2016 23:35:14 +0000 (16:35 -0700)]
Merge pull request dotnet/coreclr#5888 from adityamandaleeka/generate_core_dumps_runtest

Set coredump_filter to include shared library code in CI core dumps

Commit migrated from https://github.com/dotnet/coreclr/commit/742df17fff977695cd36337169b16af0057ad723

8 years agoFix race condition in Loader regression 523654 test
wtgodbe [Mon, 20 Jun 2016 22:21:44 +0000 (15:21 -0700)]
Fix race condition in Loader regression 523654 test

Commit migrated from https://github.com/dotnet/coreclr/commit/27e1cdfe3fc50b5e9250ea5b4c7deec793b5f6b0

8 years agoMerge pull request dotnet/coreclr#5886 from swgillespie/longgc-netci
Sean Gillespie [Mon, 20 Jun 2016 21:56:29 +0000 (14:56 -0700)]
Merge pull request dotnet/coreclr#5886 from swgillespie/longgc-netci

Switch to double-quotes for interpolated string in netci.groovy

Commit migrated from https://github.com/dotnet/coreclr/commit/cbddfc0dfd42077a23def2118636fe5061c6093a

8 years agoSet coredump_filter to include shared library code.
Aditya Mandaleeka [Mon, 20 Jun 2016 21:29:37 +0000 (14:29 -0700)]
Set coredump_filter to include shared library code.

Commit migrated from https://github.com/dotnet/coreclr/commit/e42ea2920222716e9751f78fa72b3256f85d8d4e

8 years agoUpdate Linux tracing instructions for Docker containers.
Brian Robbins [Fri, 17 Jun 2016 23:04:10 +0000 (16:04 -0700)]
Update Linux tracing instructions for Docker containers.

Commit migrated from https://github.com/dotnet/coreclr/commit/f5f41ae0baa783fae5c63a85f2bb53758ae55632

8 years agoSwitch to double-quotes for interpolated string
Sean Gillespie [Mon, 20 Jun 2016 20:11:18 +0000 (13:11 -0700)]
Switch to double-quotes for interpolated string

Commit migrated from https://github.com/dotnet/coreclr/commit/dedf88fadb44e046cc570e76c5c78fac70681e21

8 years agoMerge pull request dotnet/coreclr#5882 from stephentoub/fix_ev_bytearray
Stephen Toub [Mon, 20 Jun 2016 19:34:27 +0000 (15:34 -0400)]
Merge pull request dotnet/coreclr#5882 from stephentoub/fix_ev_bytearray

Fix EventSource deserializing of byte[]s

Commit migrated from https://github.com/dotnet/coreclr/commit/f5a854bd323e5e327ec1a011dc494d2abb1e7721

8 years agoMerge pull request dotnet/coreclr#5875 from pgavlin/JitStdoutVbuf
Pat Gavlin [Mon, 20 Jun 2016 17:25:07 +0000 (10:25 -0700)]
Merge pull request dotnet/coreclr#5875 from pgavlin/JitStdoutVbuf

Disable buffering on jitstdout.

Commit migrated from https://github.com/dotnet/coreclr/commit/ee680783778ed0abb186ae41a8c861d5cdcadccd

8 years agoFix EventSource deserializing of byte[]s
Stephen Toub [Mon, 20 Jun 2016 17:05:18 +0000 (13:05 -0400)]
Fix EventSource deserializing of byte[]s

It's incorrectly repeating the first element for all elements.

Commit migrated from https://github.com/dotnet/coreclr/commit/4a3ab6816124ef63e371bd9e7f80e05709f7a761

8 years agoMerge pull request dotnet/coreclr#5876 from dotnet-bot/UpdateDependencies20160620061718
Gaurav Khanna [Mon, 20 Jun 2016 15:35:28 +0000 (08:35 -0700)]
Merge pull request dotnet/coreclr#5876 from dotnet-bot/UpdateDependencies20160620061718

Updating External dependencies to rc4-24220-00

Commit migrated from https://github.com/dotnet/coreclr/commit/79ae4d44b7dc71f098ab97e712f8af7c493e720f

8 years agoAdded links to CoreCLR issues, small formatting fix
Matt Warren [Mon, 20 Jun 2016 10:29:55 +0000 (11:29 +0100)]
Added links to CoreCLR issues, small formatting fix

Commit migrated from https://github.com/dotnet/coreclr/commit/60de14e7ebb4f42d358e84ec192d64f0266cb39f

8 years agoFix GC background thread start in OOM (dotnet/coreclr#5840)
Jan Vorlicek [Mon, 20 Jun 2016 09:57:00 +0000 (11:57 +0200)]
Fix GC background thread start in OOM (dotnet/coreclr#5840)

This change fixes a problem that happened when the `gc_heap::create_bgc_thread`
calls SetupUnstartedThread and it fails to allocate a Thread object and throws.
The GC doesn't expect that and so when the stack is unwound, the `gc_heap::gc_started`
stays set. Now we try to allocate memory for the Throwable for the exception, so we go
to GC heap and since there is not enough space, we end up calling
`gc_heap::try_allocate_more_space`, which calls `gc_heap::wait_for_gc_done`.
And that’s the end of it, since the `gc_started` is still set and we wait forever.

The fix is to catch exception from the SetupUnstartedThread. I have also fixed couple of
places where this method was being called and the exception was not expected.

As an additional cleanup, I have moved the thread creation in GC to the GCToEEInterface.

Commit migrated from https://github.com/dotnet/coreclr/commit/878cd5d88fc38fe0131455c84a6793c562238f70

8 years agoUpdating External dependencies to rc4-24220-00
dotnet-bot [Mon, 20 Jun 2016 06:17:18 +0000 (06:17 +0000)]
Updating External dependencies to rc4-24220-00

Commit migrated from https://github.com/dotnet/coreclr/commit/600b46bd294b81b41dfa5d275938098975ca622e

8 years agoDisable buffering on jitstdout.
Pat Gavlin [Mon, 20 Jun 2016 04:42:09 +0000 (21:42 -0700)]
Disable buffering on jitstdout.

This avoid the need to call fflush() throughout the code.

Commit migrated from https://github.com/dotnet/coreclr/commit/bc3533fb742458bd6939f7f878bf8f477cbac791

8 years agoMerge pull request dotnet/coreclr#5380 from sejongoh/x86_decompose_storeind
Sejong Oh [Mon, 20 Jun 2016 02:01:55 +0000 (19:01 -0700)]
Merge pull request dotnet/coreclr#5380 from sejongoh/x86_decompose_storeind

Decomposing 64-bit storeind instruction to 32-bit storeind instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/b464dc317d49b84cf2e3a2e4f65813c23ea51a41

8 years agoDecomposing 64-bit storeind instruction to 32-bit storeind instructions
Sejong Oh [Wed, 25 May 2016 01:11:52 +0000 (18:11 -0700)]
Decomposing 64-bit storeind instruction to 32-bit storeind instructions

Commit migrated from https://github.com/dotnet/coreclr/commit/780400f1e579621f0a0d2347f8393498012b1549

8 years agoFix source/line info in unhandled exceptions (dotnet/coreclr#5874)
Mike McLaughlin [Sun, 19 Jun 2016 22:24:49 +0000 (15:24 -0700)]
Fix source/line info in unhandled exceptions (dotnet/coreclr#5874)

* Fix no source/line info for unhandled exceptions.

Issue dotnet/coreclr#5828.

* Remove comment.

Commit migrated from https://github.com/dotnet/coreclr/commit/4144d4cb720399fb9fe0a8a03bffac07ba8fb065

8 years agoRemove the corner cases from sscanf test (dotnet/coreclr#5873)
Peter Jas [Sun, 19 Jun 2016 18:37:06 +0000 (21:37 +0300)]
Remove the corner cases from sscanf test (dotnet/coreclr#5873)

Commit migrated from https://github.com/dotnet/coreclr/commit/5546991296f5e407cf6797a914092cf8317b0ec0

8 years agoUpdate GC from CoreRT (dotnet/coreclr#5859)
Jan Kotas [Sun, 19 Jun 2016 16:40:48 +0000 (09:40 -0700)]
Update GC from CoreRT (dotnet/coreclr#5859)

https://github.com/dotnet/corert/tree/master/src/Native/gc dotnet/coreclr@53276850bc2e7e531908434b2d062fcff3e1d58d

Commit migrated from https://github.com/dotnet/coreclr/commit/734f9814f534b324a9268804371cf9da9245ec78

8 years agoMerge pull request dotnet/coreclr#5858 from dotnet-bot/from-tfs
Jan Kotas [Sat, 18 Jun 2016 04:03:23 +0000 (21:03 -0700)]
Merge pull request dotnet/coreclr#5858 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/0e5f844e008b3a9ea537a0dfcb84f51f8b79e60b

8 years agoMerge pull request dotnet/coreclr#5865 from kyulee1/fixgcstruct
Kyungwoo Lee [Sat, 18 Jun 2016 03:46:05 +0000 (20:46 -0700)]
Merge pull request dotnet/coreclr#5865 from kyulee1/fixgcstruct

ARM64: Fix GC hole for Multi-Reg Struct

Commit migrated from https://github.com/dotnet/coreclr/commit/22788578877f3a4741f4448eb06ae14687870e03

8 years agoMerge pull request dotnet/coreclr#5863 from adityamandaleeka/generate_core_dumps_runtest
Aditya Mandaleeka [Sat, 18 Jun 2016 02:38:35 +0000 (19:38 -0700)]
Merge pull request dotnet/coreclr#5863 from adityamandaleeka/generate_core_dumps_runtest

Add option to runtest.sh to enable limited dump generation.

Commit migrated from https://github.com/dotnet/coreclr/commit/84948692baac873d9f7407c6ca2863a900c04a0e

8 years agoMerge pull request dotnet/coreclr#5868 from AndyAyersMS/BooleansRule
Andy Ayers [Sat, 18 Jun 2016 01:45:25 +0000 (18:45 -0700)]
Merge pull request dotnet/coreclr#5868 from AndyAyersMS/BooleansRule

JIT: standardize on bool for return type of GenTree OperIs methods

Commit migrated from https://github.com/dotnet/coreclr/commit/e787b60ab7fbe8ab62f1986145b7aec6104fd4c2

8 years agoMerge pull request dotnet/coreclr#5862 from adityamandaleeka/remove_dead_code
Aditya Mandaleeka [Sat, 18 Jun 2016 01:30:06 +0000 (18:30 -0700)]
Merge pull request dotnet/coreclr#5862 from adityamandaleeka/remove_dead_code

Remove some dead code in notifyexternals

Commit migrated from https://github.com/dotnet/coreclr/commit/1e513085692a1d5208efc002e2dead5bb895fb3b

8 years agoMerge pull request dotnet/coreclr#5831 from briansull/fix-5759
Brian Sullivan [Fri, 17 Jun 2016 23:27:25 +0000 (16:27 -0700)]
Merge pull request dotnet/coreclr#5831 from briansull/fix-5759

Fix for issue 5795

Commit migrated from https://github.com/dotnet/coreclr/commit/13675a3c6df31caad2db8e634d9ba7fac26e896d

8 years agoJIT: standardize on bool for return type of GenTree OperIs methods
Andy Ayers [Fri, 17 Jun 2016 22:31:32 +0000 (15:31 -0700)]
JIT: standardize on bool for return type of GenTree OperIs methods

We had a mixture of bool and int return types. Standardize on bool.
Otherwise callers must match the mixed typing to avoid the fatal
C4800 warning on windows.

Commit migrated from https://github.com/dotnet/coreclr/commit/b1988c8d4029b20d68b8e6102e7d863385595c51

8 years agoRemove dead code in notifyexternals
Aditya Mandaleeka [Fri, 17 Jun 2016 19:42:27 +0000 (12:42 -0700)]
Remove dead code in notifyexternals

Commit migrated from https://github.com/dotnet/coreclr/commit/839e5aba21fea49c7b046ec14205d200de4ab55d

8 years agoEnable core dump generation in CI test jobs
Aditya Mandaleeka [Fri, 17 Jun 2016 22:13:19 +0000 (15:13 -0700)]
Enable core dump generation in CI test jobs

Commit migrated from https://github.com/dotnet/coreclr/commit/1ad32ce9c82b0e5c1594ecec88423803045cc824

8 years agoARM64: Fix GC hole for Multi-Reg Struct
Kyungwoo Lee [Fri, 17 Jun 2016 21:27:36 +0000 (14:27 -0700)]
ARM64: Fix GC hole for Multi-Reg Struct

Fixes https://github.com/dotnet/coreclr/issues/5817
When we pass struct in multi-reg, we dropped the GC info on creating
instruction.
The fix is that for GT_LCL_FLD, we enforce non-float type size while
holding the gc type.

Validate with small cutdown. And also confirmed that the gc range is
reasonable in System.Reflection.RuntimeParameterInfo.GetParameters.

Commit migrated from https://github.com/dotnet/coreclr/commit/9a153fb228a59017a632549bc6501b60838b9177

8 years agoMerge pull request dotnet/coreclr#5836 from RussKeldorph/nogcsosx
Russ Keldorph [Fri, 17 Jun 2016 22:02:55 +0000 (15:02 -0700)]
Merge pull request dotnet/coreclr#5836 from RussKeldorph/nogcsosx

Disable GCStress=C periodic triggers for OSX

Commit migrated from https://github.com/dotnet/coreclr/commit/ee3ad560653dc74e2a98642b2bdf4115f9d208f1

8 years agoMerge pull request dotnet/coreclr#5856 from AndyAyersMS/ConstantObservations
Andy Ayers [Fri, 17 Jun 2016 21:42:02 +0000 (14:42 -0700)]
Merge pull request dotnet/coreclr#5856 from AndyAyersMS/ConstantObservations

JIT: Cleanup code in and around fgFindJumpTargets

Commit migrated from https://github.com/dotnet/coreclr/commit/42d3f36d802b902c54288d75526908c4f8050026

8 years agoAdd option to runtest.sh to enable limited dump generation.
Aditya Mandaleeka [Fri, 17 Jun 2016 20:49:53 +0000 (13:49 -0700)]
Add option to runtest.sh to enable limited dump generation.

Commit migrated from https://github.com/dotnet/coreclr/commit/b202782ae96981535e9194bd42a2ff5c6ba8fd78

8 years agoFix for issue 5795
Brian Sullivan [Thu, 16 Jun 2016 17:06:55 +0000 (10:06 -0700)]
Fix for issue 5795

We incorrectly pass the ret buf arg in x9 instead of x8

It is required that we call SortArgs and EvalArgsToTemps whenever we have any register arguments
We were not doing that when we only had a retBufArg argument in x8.

Fix for UNIX_AMD64 structs

Commit migrated from https://github.com/dotnet/coreclr/commit/0809be00850fec3eca9a968d36750fc44d69e2f3

8 years agoMerge pull request dotnet/coreclr#5854 from dotnet-bot/from-tfs
Jan Kotas [Fri, 17 Jun 2016 17:43:24 +0000 (10:43 -0700)]
Merge pull request dotnet/coreclr#5854 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/b387b6eb6f4e1ddf4c20aece8d1508d011915c4c

8 years agoJIT: Cleanup code in and around fgFindJumpTargets
Andy Ayers [Thu, 16 Jun 2016 22:33:48 +0000 (15:33 -0700)]
JIT: Cleanup code in and around fgFindJumpTargets

Reorder code to remove gotos. Extract two large chunks of logic as
subroutines. Add braces and update comments. Bring `fgStack` class up
to current Jit coding conventions.  Reunite some orphaned comments for
fgFindJumpTargets.

No behavior change expected. No diffs seen via jit-diff tool. No diffs
seen in desktop testing.

Commit migrated from https://github.com/dotnet/coreclr/commit/06f902ab0614e76efb978249e62e4273f555431f

8 years agoMerge pull request dotnet/coreclr#5839 from swgillespie/gc-batch-fix
Sean Gillespie [Fri, 17 Jun 2016 16:55:33 +0000 (09:55 -0700)]
Merge pull request dotnet/coreclr#5839 from swgillespie/gc-batch-fix

Fix GC test batch script skip conditions that were behaving unexpectedly

Commit migrated from https://github.com/dotnet/coreclr/commit/61c639ba82beea7483b20d1adad352ffddfe23f5

8 years agoFix full framework build break
Jan Kotas [Fri, 17 Jun 2016 15:17:25 +0000 (08:17 -0700)]
Fix full framework build break

[tfs-changeset: 1613359]

Commit migrated from https://github.com/dotnet/coreclr/commit/8f606f32391ee12babe38a91b3501cc31019f94b

8 years agoMerge pull request dotnet/coreclr#5852 from gkhanna79/Fix5837
Gaurav Khanna [Fri, 17 Jun 2016 15:09:45 +0000 (08:09 -0700)]
Merge pull request dotnet/coreclr#5852 from gkhanna79/Fix5837

Correctly resolve binding from Resolving event for static load

Commit migrated from https://github.com/dotnet/coreclr/commit/585d669d73a613f92501199cbf11a8fee13fbbe9

8 years agoChanges to update TFS packages post 1.0
Eric St. John [Fri, 17 Jun 2016 14:16:31 +0000 (07:16 -0700)]
Changes to update TFS packages post 1.0

[tfs-changeset: 1613358]

Commit migrated from https://github.com/dotnet/coreclr/commit/4d0f26aeeae7fbbd3ede20bc89f9acd6e7a7eac6

8 years agoAdd missing check to allow assembly bound using the Resolving event to be used during...
Gaurav Khanna [Fri, 17 Jun 2016 13:29:41 +0000 (06:29 -0700)]
Add missing check to allow assembly bound using the Resolving event to be used during static binding scenario

Commit migrated from https://github.com/dotnet/coreclr/commit/c335d794bd56f4971bd37bbb220b753ea04ec837

8 years agoMerge pull request dotnet/coreclr#5843 from dotnet-bot/UpdateDependencies20160617052045
Gaurav Khanna [Fri, 17 Jun 2016 12:32:04 +0000 (05:32 -0700)]
Merge pull request dotnet/coreclr#5843 from dotnet-bot/UpdateDependencies20160617052045

Updating External dependencies to rc4-24217-00

Commit migrated from https://github.com/dotnet/coreclr/commit/7b1dfcf9adb52e2d2382259786ffe939c494510c

8 years agoUse LEAF_END_MARKED instead of LEAF_END for ARM64 debugbreak.S (dotnet/coreclr#5850)
Jonghyun Park [Fri, 17 Jun 2016 11:36:07 +0000 (20:36 +0900)]
Use LEAF_END_MARKED instead of LEAF_END for ARM64 debugbreak.S (dotnet/coreclr#5850)

This commit applies the changes in dotnet/coreclr#5847 (which fixes dotnet/coreclr#5845) into ARM64
stub.

Commit migrated from https://github.com/dotnet/coreclr/commit/6ea358025edca8908cf9823ad62734530dc85578

8 years agoUse Use LEAF_END_MARKED instead of LEAF_END for various functions (dotnet/coreclr...
Jonghyun Park [Fri, 17 Jun 2016 08:55:43 +0000 (17:55 +0900)]
Use Use LEAF_END_MARKED instead of LEAF_END for various functions (dotnet/coreclr#5849)

This commit fixes dotnet/coreclr#5848.

Commit migrated from https://github.com/dotnet/coreclr/commit/897fe098ad1cf08a83e68da76a33c68dad82f3e7

8 years agoUse LEAF_END_MARKED instead of LEAF_END for DBG_DebugBreak (dotnet/coreclr#5847)
Jonghyun Park [Fri, 17 Jun 2016 08:55:24 +0000 (17:55 +0900)]
Use LEAF_END_MARKED instead of LEAF_END for DBG_DebugBreak (dotnet/coreclr#5847)

This commit tries to fix dotnet/coreclr#5845

Commit migrated from https://github.com/dotnet/coreclr/commit/1df2061b82e10047463e425aaeb7008c7a5f3209

8 years agoMerge pull request dotnet/coreclr#5842 from prajwal-aithal/devel/arm-ci-emul-fix
Jarret Shook [Fri, 17 Jun 2016 06:21:43 +0000 (23:21 -0700)]
Merge pull request dotnet/coreclr#5842 from prajwal-aithal/devel/arm-ci-emul-fix

ARM-CI: Create mount path if not already present

Commit migrated from https://github.com/dotnet/coreclr/commit/7b32045a32ac744105c607a15c03855508279b25

8 years agoUpdating External dependencies to rc4-24217-00
dotnet-bot [Fri, 17 Jun 2016 05:20:45 +0000 (05:20 +0000)]
Updating External dependencies to rc4-24217-00

Commit migrated from https://github.com/dotnet/coreclr/commit/bd79c382864f6bd0e6dc84771cf037083a30b2e4

8 years agoARM-CI: Create mount path if not already present
Prajwal A N [Fri, 17 Jun 2016 03:24:24 +0000 (12:24 +0900)]
ARM-CI: Create mount path if not already present

* Previous PRs assumed that the mount path is already created on the CI machine
* This results in errors if the same is not true

Signed-off-by: Prajwal A N <an.prajwal@samsung.com>
Commit migrated from https://github.com/dotnet/coreclr/commit/173e56ed4a43ff7863bb78e95d94bb4a1673970a

8 years agoMerge pull request dotnet/coreclr#5841 from rahku/master
Rahul Kumar [Fri, 17 Jun 2016 01:05:11 +0000 (18:05 -0700)]
Merge pull request dotnet/coreclr#5841 from rahku/master

Fix arm64 build break

Commit migrated from https://github.com/dotnet/coreclr/commit/9593aae441d823e2bfe912a33e4b463b704b020e

8 years agoFix arm64 build break
Rahul Kumar [Fri, 17 Jun 2016 00:59:06 +0000 (17:59 -0700)]
Fix arm64 build break

Commit migrated from https://github.com/dotnet/coreclr/commit/32c9ea52468df18285efa8eb617d16c1baf87fd4

8 years agoMerge pull request dotnet/coreclr#5822 from adityamandaleeka/setup-runtime-dependenci...
Aditya Mandaleeka [Thu, 16 Jun 2016 23:36:36 +0000 (16:36 -0700)]
Merge pull request dotnet/coreclr#5822 from adityamandaleeka/setup-runtime-dependencies_changes

Remove set -x from tests/setup-runtime-dependencies.sh.

Commit migrated from https://github.com/dotnet/coreclr/commit/f64c1eea8f1c898d02362549cb3acd7eb9c4b56c

8 years agoFix GC test batch script skip conditions that were behaving unexpectedly
Sean Gillespie [Thu, 16 Jun 2016 23:30:54 +0000 (16:30 -0700)]
Fix GC test batch script skip conditions that were behaving unexpectedly

Commit migrated from https://github.com/dotnet/coreclr/commit/8964be339e7836c1da8acae1d1c47d4ca4aee6e2

8 years agoDisable GCStress=C periodic triggers for OSX
Russ Keldorph [Thu, 16 Jun 2016 22:29:19 +0000 (15:29 -0700)]
Disable GCStress=C periodic triggers for OSX

Fixes dotnet/coreclr#5763

Commit migrated from https://github.com/dotnet/coreclr/commit/9360831fb2acfc6f13023b4e8c084f2c956bf34e

8 years agoMerge pull request dotnet/coreclr#5835 from wtgodbe/buildFix
William Godbe [Thu, 16 Jun 2016 22:05:19 +0000 (15:05 -0700)]
Merge pull request dotnet/coreclr#5835 from wtgodbe/buildFix

Fix error when passing msbuild args to build.cmd/buildtest.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/d3ab0326868872a0d65d7cd092fcbd4cdf253a72

8 years agoFix error when passing msbuild args to build.cmd/buildtest.cmd
wtgodbe [Thu, 16 Jun 2016 19:47:06 +0000 (12:47 -0700)]
Fix error when passing msbuild args to build.cmd/buildtest.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/54dd349dbf706aef10515d9e907fd18ae377717a

8 years agoMark Volatile methods with NonVersionable attribute (dotnet/coreclr#5830)
Jan Kotas [Thu, 16 Jun 2016 19:32:16 +0000 (12:32 -0700)]
Mark Volatile methods with NonVersionable attribute (dotnet/coreclr#5830)

Commit migrated from https://github.com/dotnet/coreclr/commit/d3371a42051db96b3f93a6d01358d17b2db9103b

8 years agoFix some typos in setup-runtime-dependencies.cmd
Aditya Mandaleeka [Thu, 16 Jun 2016 18:57:06 +0000 (11:57 -0700)]
Fix some typos in setup-runtime-dependencies.cmd

Commit migrated from https://github.com/dotnet/coreclr/commit/bbf48b9f2481ef48146b5d5892e804396286bbd7

8 years agoMerge pull request dotnet/coreclr#5821 from kyulee1/fixwb
Kyungwoo Lee [Thu, 16 Jun 2016 18:08:16 +0000 (11:08 -0700)]
Merge pull request dotnet/coreclr#5821 from kyulee1/fixwb

ARM64: Fix WriteBarrier

Commit migrated from https://github.com/dotnet/coreclr/commit/9c504436ed09e6a31251f3b7d85d457f9c5da9f9

8 years agoARM64: Fix WriteBarrier
Kyungwoo Lee [Wed, 15 Jun 2016 22:57:19 +0000 (15:57 -0700)]
ARM64: Fix WriteBarrier

I think this finally fixes most of long outstanding GC issues that appear in different
forms so far that include dotnet/coreclr#4877, dotnet/coreclr#4879, dotnet/coreclr#4890 and more.

The issues was WriteBarrier implementation.
When we update card table, the address has been already incremented by 8.

With this fix, all corefx tests seem to run on xunit framework without crashing.
I verified this with an out-of-date build locally, so there are not found
assembly errors like System.Runtime.Extensions with different versions, though.
These are what I tested so far that safely finished all runs with very high percentage of pass.
System.Collections.Tests
System.Dynamic.Runtime.Tests
System.Linq.Expressions.Tests
System.Linq.Parallel.Tests

Potentially more coreclr tests will pass. I will update them as tests go.

Commit migrated from https://github.com/dotnet/coreclr/commit/49c2eec8568b4471f1dcbc0e0f4016ff62c7c989

8 years agoMerge pull request dotnet/coreclr#5824 from dotnet-bot/UpdateDependencies20160616051753
Wes Haggard [Thu, 16 Jun 2016 17:04:18 +0000 (10:04 -0700)]
Merge pull request dotnet/coreclr#5824 from dotnet-bot/UpdateDependencies20160616051753

Updating External dependencies to rc4-24216-00

Commit migrated from https://github.com/dotnet/coreclr/commit/5de21b3b4d5dad2f069d1dfd4f8efe6d88f4e6f8

8 years agoRemove end labels from regular asm procs on Unix (dotnet/coreclr#5777)
Jan Vorlicek [Thu, 16 Jun 2016 13:15:08 +0000 (15:15 +0200)]
Remove end labels from regular asm procs on Unix (dotnet/coreclr#5777)

All ASM proc now unnecessarily have xxx_End label marking
the end of the proc. This causes confusing stack traces in
some cases, especially on OSX, when instead of a name of
an actual function, a name of the previous one with the
_End attached to it is shown.
This change fixes that by modifying the LEAF_END macro to
not to be defined as an equivalent of the LEAF_END_MARKED.

Commit migrated from https://github.com/dotnet/coreclr/commit/aaf5e7d6a1fa53576bbaa057eb7b7147281284cf

8 years agoMerge pull request dotnet/coreclr#5819 from AndyAyersMS/InlineTestsV1
Andy Ayers [Thu, 16 Jun 2016 05:53:47 +0000 (22:53 -0700)]
Merge pull request dotnet/coreclr#5819 from AndyAyersMS/InlineTestsV1

Inliner: simple performance tests

Commit migrated from https://github.com/dotnet/coreclr/commit/d5a0338ddefc9551f3f573b4950ab046f58d9464

8 years agoUpdating External dependencies to rc4-24216-00
dotnet-bot [Thu, 16 Jun 2016 05:17:53 +0000 (05:17 +0000)]
Updating External dependencies to rc4-24216-00

Commit migrated from https://github.com/dotnet/coreclr/commit/d861cbe4febdbf3deff214c5444daf422e9adef2

8 years agoMerge pull request dotnet/coreclr#5794 from briansull/vm-retbuf
Brian Sullivan [Thu, 16 Jun 2016 01:10:01 +0000 (18:10 -0700)]
Merge pull request dotnet/coreclr#5794 from briansull/vm-retbuf

Fixes for two JIT helpers that should not use the x8 RetBuf argument on ARM64

Commit migrated from https://github.com/dotnet/coreclr/commit/9ec70e119cca0cf317e1d64a3efd2bb9021e6d80

8 years agoRemove set -x from tests/setup-runtime-dependencies.sh.
Aditya Mandaleeka [Thu, 16 Jun 2016 00:26:05 +0000 (17:26 -0700)]
Remove set -x from tests/setup-runtime-dependencies.sh.

Commit migrated from https://github.com/dotnet/coreclr/commit/0aed7c9a2c88a9332712905dbcd06c855cf7586d

8 years agoFixes for two JIT helpers that should not use the x8 RetBuf argument on ARM64
Brian Sullivan [Mon, 13 Jun 2016 21:06:14 +0000 (14:06 -0700)]
Fixes for two JIT helpers that should not use the x8 RetBuf argument on ARM64

Fixes these two JIT helpers" CORINFO_HELP_GETFIELDSTRUCT and CORINFO_HELP_UNBOX_NULLABLE
We no longer set GTF_CALL_M_RETBUFFARG for the two special Jit helpers
We insert the extra byref argument in the x0 position for these two JIT helpers

Commit migrated from https://github.com/dotnet/coreclr/commit/987536accfc50a689b914f343d79fb3588cc552b

8 years agoMerge pull request dotnet/coreclr#5820 from wtgodbe/groovyR2R
William Godbe [Wed, 15 Jun 2016 22:57:56 +0000 (15:57 -0700)]
Merge pull request dotnet/coreclr#5820 from wtgodbe/groovyR2R

Update crossgen strings for coreclr coverage tests

Commit migrated from https://github.com/dotnet/coreclr/commit/65786f04d36e9886c4e1b004e5d233eb708fa0b9

8 years agoUpdate crossgen strings for coreclr coverage tests
wtgodbe [Wed, 15 Jun 2016 22:54:33 +0000 (15:54 -0700)]
Update crossgen strings for coreclr coverage tests

Commit migrated from https://github.com/dotnet/coreclr/commit/e071b691843ae71b81855a8704862871dbb9975d

8 years agoMerge pull request dotnet/coreclr#5815 from BruceForstall/RemoveAmd64Legacy
Bruce Forstall [Wed, 15 Jun 2016 22:54:22 +0000 (15:54 -0700)]
Merge pull request dotnet/coreclr#5815 from BruceForstall/RemoveAmd64Legacy

Remove AMD64 code from legacy code path

Commit migrated from https://github.com/dotnet/coreclr/commit/9a28e845d94df0f3d95903e9cfd77251d67b061e

8 years agoMerge pull request dotnet/coreclr#5814 from JohnChen0/r2rtest
John Chen [Wed, 15 Jun 2016 22:29:56 +0000 (15:29 -0700)]
Merge pull request dotnet/coreclr#5814 from JohnChen0/r2rtest

Modify CrossGen test script to work around cmd.exe bug

Commit migrated from https://github.com/dotnet/coreclr/commit/b3806248c80471c70d5fb80b0f4676bda2cc49f0

8 years agoInliner: simple performance tests
Andy Ayers [Fri, 10 Jun 2016 21:58:11 +0000 (14:58 -0700)]
Inliner: simple performance tests

Tests that demonstrate that constant arguments passed to callees can
lead to inlining performance wins. All numeric types are tested, as
well as strings.

Tests are generally written as positive/negative pairs with calls to
the same inlinee. This exposes the call site sensitivity. Performance
of the positive test should be better than the negative test.

The overall benchmarking approach used here is something that we might
consider adopting for other small-scale codegen performance tests.

Commit migrated from https://github.com/dotnet/coreclr/commit/1b34b726c3644ca494be54f90bbb190905e52e4e

8 years agoFix exception stacktrace when ulimit is hit OSX. (dotnet/coreclr#5802)
Mike McLaughlin [Wed, 15 Jun 2016 22:03:57 +0000 (15:03 -0700)]
Fix exception stacktrace when ulimit is hit OSX. (dotnet/coreclr#5802)

* Fix exception stacktrace when ulimit is hit OSX.

Issue dotnet/coreclr#5782.

Wrap the everything in try/catch replacing the existing try/finally
and removed the recursion protection thread var.

* Restore recursion protection.

Commit migrated from https://github.com/dotnet/coreclr/commit/93a9d70bfa87193d29b69b3242f5cc588f417f0d

8 years agoMerge pull request dotnet/coreclr#5786 from prajwal-aithal/devel/arm-ci-cross-build-fix
Jarret Shook [Wed, 15 Jun 2016 21:38:29 +0000 (14:38 -0700)]
Merge pull request dotnet/coreclr#5786 from prajwal-aithal/devel/arm-ci-cross-build-fix

ARM-CI: Convert Linux ARM emulator CI check to cross build (fixes PR dotnet/coreclr#5680)

Commit migrated from https://github.com/dotnet/coreclr/commit/ab4cc73d46fd733fb3976b4fe53d8837257cc948

8 years agoRemove AMD64 code from legacy code path
Bruce Forstall [Wed, 15 Jun 2016 19:44:19 +0000 (12:44 -0700)]
Remove AMD64 code from legacy code path

There were some AMD64 #ifdefs and code in the legacy code path from an
ancient AMD64 porting effort. They are unused, and were confusing to me
when searching the code base, so I removed them.

Commit migrated from https://github.com/dotnet/coreclr/commit/f03d7f5655f4f0d1f3d6be6f66965a2f5e6c477d

8 years agoUpdate SpecializeComparer for enums (dotnet/coreclr#5805)
James Ko [Wed, 15 Jun 2016 19:15:12 +0000 (15:15 -0400)]
Update SpecializeComparer for enums (dotnet/coreclr#5805)

Fixes dotnet/coreclr#5751

Commit migrated from https://github.com/dotnet/coreclr/commit/b3b183e7b4b384792370fae56dcb702afbfcb2a9

8 years agoFix sos.DumpIL on LP64 systems with s/long/LONG/g (dotnet/coreclr#5810)
Ivan Baravy [Wed, 15 Jun 2016 19:14:52 +0000 (23:14 +0400)]
Fix sos.DumpIL on LP64 systems with s/long/LONG/g (dotnet/coreclr#5810)

sos.DumpIL command used readData<long> to disassemble CIL,
this failed on LP64 systems like Linux where long is 8 bytes.

This commit tries to fix dotnet/coreclr#5457.

Commit migrated from https://github.com/dotnet/coreclr/commit/bc273bb498c51720e7199ea44d15ee6b1bed07d4

8 years agoRemove useless gtSetFlags calls
Mike Danes [Wed, 15 Jun 2016 18:06:36 +0000 (21:06 +0300)]
Remove useless gtSetFlags calls

For xarch `gtSetFlags` returns true and that makes `genIntToIntCast` use an `and` instruction instead of `mov`/`movzx`. This serves no purpose as no code ever calls `gtRequestSetFlags` on cast nodes nor does `GT_JTRUE` expects a cast node as its operand.

`gtSetFlags` seems to be a leftover from the legacy codegen.

Commit migrated from https://github.com/dotnet/coreclr/commit/845d34814cbe4f0f8cd342d04bd47fc7ef1c79b2

8 years agoMerge pull request dotnet/coreclr#5807 from Maoni0/obj_addr
Maoni Stephens [Wed, 15 Jun 2016 18:13:02 +0000 (11:13 -0700)]
Merge pull request dotnet/coreclr#5807 from Maoni0/obj_addr

Need to filter addresses not in the heap range in NextObj

Commit migrated from https://github.com/dotnet/coreclr/commit/b8813ee80bc00ccf46cc781de5d2f5f807813319

8 years agoModify CrossGen test script to work around cmd.exe bug
John Chen (CLR) [Wed, 15 Jun 2016 18:11:37 +0000 (11:11 -0700)]
Modify CrossGen test script to work around cmd.exe bug

Commit migrated from https://github.com/dotnet/coreclr/commit/d33d62e74cd8577420160685190e5c1eabfed9bb

8 years agoMerge pull request dotnet/coreclr#5682 from lemmaa/fix-error-index-must-be-an-integer...
Rahul Kumar [Wed, 15 Jun 2016 17:44:16 +0000 (10:44 -0700)]
Merge pull request dotnet/coreclr#5682 from lemmaa/fix-error-index-must-be-an-integer-in-range

[ARM64/Linux] Fix `error: index must be an integer in range.`

Commit migrated from https://github.com/dotnet/coreclr/commit/25b1e6a9eb3cac4abadaf1a65d7a75448cc7597e

8 years agoInitial support of breakpoint setting by source file + line on Linux using portable...
Evgeny Pavlov [Wed, 15 Jun 2016 16:23:30 +0000 (19:23 +0300)]
Initial support of breakpoint setting by source file + line on Linux using portable pdb reader (dotnet/coreclr#5688)

* Initial support of breakpoint setting by source + line on Linux

* Fix macro redefinition error in OSX build

* Fix after review from Mike McLaughlin

Commit migrated from https://github.com/dotnet/coreclr/commit/859307b4787bbacbe28d2efe1d54c49177525562

8 years ago[ARM64/Linux] Fix `error: index must be an integer in range.`
Sung-Jae Lee [Fri, 10 Jun 2016 07:33:17 +0000 (16:33 +0900)]
[ARM64/Linux] Fix `error: index must be an integer in range.`

- Fix invalid varible name `*X19_X28' to '*X19_X29'
- Remove code for capturing `fp` status.

Commit migrated from https://github.com/dotnet/coreclr/commit/3b2ce833f869cbc8abd5a586b671eb03e8948185

8 years agoNeed to filter addresses not in the heap range in the NextObj verification function.
Maoni0 [Tue, 14 Jun 2016 02:28:03 +0000 (19:28 -0700)]
Need to filter addresses not in the heap range in the NextObj verification function.

Commit migrated from https://github.com/dotnet/coreclr/commit/c8cbe2aef8b3c11709c287f344871602d8731f37

8 years agoMerge pull request dotnet/coreclr#5773 from Maoni0/grow_card_2
Maoni Stephens [Wed, 15 Jun 2016 00:38:55 +0000 (17:38 -0700)]
Merge pull request dotnet/coreclr#5773 from Maoni0/grow_card_2

Making the fix of runtime suspension check complete

Commit migrated from https://github.com/dotnet/coreclr/commit/488c377745cd2cbdfac711d2199dfeefeb24c5f1

8 years agoMerge pull request dotnet/coreclr#5803 from dotnet-bot/from-tfs
Jan Kotas [Wed, 15 Jun 2016 00:33:12 +0000 (17:33 -0700)]
Merge pull request dotnet/coreclr#5803 from dotnet-bot/from-tfs

Merge changes from TFS

Commit migrated from https://github.com/dotnet/coreclr/commit/9ea104961f899c3b092bf958fa21a7e07e493c09

8 years agoMy last fix of checking whether the runtime was suspended was incomplete.
Maoni0 [Mon, 13 Jun 2016 21:57:12 +0000 (14:57 -0700)]
My last fix of checking whether the runtime was suspended was incomplete.
I needed to check at the 3 other places. Before the software write watch
implementation, this check was in the write barrier code itself and was
doing the right thing. So I am just using the same thing (ie, IsGCThread)
to check whether the runtime is suspended.

Commit migrated from https://github.com/dotnet/coreclr/commit/f1aeb18e104cf02439c948ab5f20cf4bc8a27b03