Santiago Fernandez Madero [Fri, 21 Jun 2019 06:05:24 +0000 (23:05 -0700)]
Add nullable annotations to System.Diagnostics.StackTrace ref (dotnet/corefx#38428)
* Add nullable annotations to System.Diagnostics.StackTrace ref
* Address nullable feedback from API Review
Commit migrated from https://github.com/dotnet/corefx/commit/
f0b1b6ee70a36a13d097582bf7c982b7b9e8530d
Santiago Fernandez Madero [Fri, 21 Jun 2019 06:01:57 +0000 (23:01 -0700)]
Add nullable annotations to System.Diagnostics.Tracing ref (dotnet/corefx#38434)
* Add nullable annotations to System.Diagnostics.Tracing ref
* Address API Review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
96fe425e1ae8e16dcd726b6bea7bf4bd6295ba6c
Santiago Fernandez Madero [Fri, 21 Jun 2019 04:45:36 +0000 (21:45 -0700)]
Regenerate ref assembly and add nullable annotations for System.Reflection.Emit.Lightweight (dotnet/corefx#38515)
* Regenerate ref assembly against implementation
* Add nullable attributes to System.Reflection.Emit.LightWeight ref
Commit migrated from https://github.com/dotnet/corefx/commit/
32d256ed4bf4daeab4b6b866fdef9fe921c8aa5f
Krzysztof Wicher [Fri, 21 Jun 2019 04:07:00 +0000 (21:07 -0700)]
Fix failing PostAsyncExpect100Continue_LateForbiddenResponse_Ok (dotnet/corefx#38742)
* PostAsyncExpect100Continue: Keep client alive until server finishes
* replace MRE with ShutdownIgnoringErrorsAsync
Commit migrated from https://github.com/dotnet/corefx/commit/
bff9c7b2ac6b0608f555b0d4b82b5ffb983a8f2f
Carlos Sanchez Lopez [Fri, 21 Jun 2019 02:58:33 +0000 (19:58 -0700)]
Fix for issue where iterating over directories ending in a dot would unexpectedly throw (dotnet/corefx#38489)
Issue
In Windows, when iterating over the files of a directory whose name ends in a dot, the iteration fails by throwing an unexpected exception, even when using the proper prefix "\\?\" for the full directory path.
Fix
Add a new boolean argument at the end of the enumeration function signatures that will indicate if the passed path is normalized or not. If it is normalized (which only happens when the path is created by us, not by the user), then we can create the handle using that path. If it's not normalized, we attempt to get its full path before creating the handle, which will throw if a full path can't be obtained.
Added a new unit test to verify the fixed behavior and updated some others whose behavior changed with this fix.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e95261ef710e0df980a6d46923eb3c0e8b0bc83
Jan Kotas [Fri, 21 Jun 2019 01:37:04 +0000 (18:37 -0700)]
Improve AssertExtensions.Equal performance for large arrays (dotnet/corefx#38725)
Assert.Equals on arrays boxes each element and then performs a complex
operation to compare each box. This is slow for large arrays, and extremely
slow for large arrays on checked CoreCLR.
Use AssertExtensions.Equal for large arrays in File.Copy tests to make
them reasonably fast on checked CoreCLR.
Commit migrated from https://github.com/dotnet/corefx/commit/
c53300f0696c4817bc06a8ef8711a0bb46f362ec
Jeremy Kuhne [Thu, 20 Jun 2019 23:50:02 +0000 (16:50 -0700)]
Fix factory converters used as attributes (dotnet/corefx#38740)
* Fix factory converters used as attributes
Need to unpack the type specific converter when associating directly with a property.
Add default constructor to StringEnum converter.
* Move the factory unpack per feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c6c1890ecd8e258f4a6e97a94e23881ed7a88392
Layomi Akinrinade [Thu, 20 Jun 2019 22:38:10 +0000 (18:38 -0400)]
Add support for Uri to JsonSerializer (dotnet/corefx#38655)
* Add support for Uri to JsonSerializer
* Address review feedback
* Original string -> ToString
Commit migrated from https://github.com/dotnet/corefx/commit/
b2aee04410ad2f3d4cd372b84b74bb246cb04e7d
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:36:27 +0000 (15:36 -0700)]
Add nullable annotations to System.Security.Principal ref assembly (dotnet/corefx#38519)
Commit migrated from https://github.com/dotnet/corefx/commit/
fb38d14bd501f05dbd2f8c3c85ac262b821d97ca
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:35:53 +0000 (15:35 -0700)]
Regenerate ref assembly and add nullable annotations to ref assembly for System.Text.Encoding.Extensions (dotnet/corefx#38520)
* Regenerate ref assembly against implementation
* Add nullable annotations to ref assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
1f4de5dff6dbfad36662af015142db5f6cb317f7
Santiago Fernandez Madero [Thu, 20 Jun 2019 22:18:57 +0000 (15:18 -0700)]
Update StringTests for Span.ToLower/Upper with null culture (dotnet/corefx#38692)
* Update StringTests for Span.ToLower/Upper with null culture
* Darc update for dotnet/coreclr from build
20190619.2
* Darc update for dotnet/coreclr from build
20190620.2
Commit migrated from https://github.com/dotnet/corefx/commit/
149bde31df743ba2a3d79a1944de411a8016acb4
Jose Perez Rodriguez [Thu, 20 Jun 2019 20:20:10 +0000 (13:20 -0700)]
Adding validation to ensure all runtime-only files are present on all runtime-specific packages (dotnet/corefx#38730)
Commit migrated from https://github.com/dotnet/corefx/commit/
f80d2324feaf77b902ea93d76a3aa5236b0e2f27
David Cantu [Thu, 20 Jun 2019 20:12:18 +0000 (13:12 -0700)]
Adding unit test to cover NullReferenceException when passing null to a collection (dotnet/corefx#38566)
* Adding unit test to cover NullReferenceException when passing null to a collaction (issue dotnet/corefx#37078)
* Adding Peer Review suggestions.
* Splitting referece type and value type test scenarios into separate methods.
Commit migrated from https://github.com/dotnet/corefx/commit/
e044c800294595ad3abc6b6f3b4ff739a5b3c83a
Jeremy Kuhne [Thu, 20 Jun 2019 19:07:20 +0000 (12:07 -0700)]
String enum converter (dotnet/corefx#38702)
* String enum converter
Adds public converter for converting enums to strings and vice-versa.
* Address feedback.
* Missing a readonly
* Fix exception and swtich to ConcurrentDictionary
* Merge fixup
Commit migrated from https://github.com/dotnet/corefx/commit/
66a18944db6d64b67adb1320d41004a9140babc1
Kevin Jones [Thu, 20 Jun 2019 18:25:09 +0000 (14:25 -0400)]
Increase sample size of random number generation tests
Commit migrated from https://github.com/dotnet/corefx/commit/
ddb08d9df0b6206833f5ba143403a0a52cca2f40
Jan Kotas [Thu, 20 Jun 2019 18:15:44 +0000 (11:15 -0700)]
Improve test coverage for Convert.FromBase64 (dotnet/corefx#38724)
Commit migrated from https://github.com/dotnet/corefx/commit/
707b15859af2fb23e17acfdc915d4cb5ee9112ad
Maryam Ariyan [Thu, 20 Jun 2019 17:49:32 +0000 (10:49 -0700)]
[Tests]: JsonSerializer.ToString serialization tests containing Enum (dotnet/corefx#38531)
Commit migrated from https://github.com/dotnet/corefx/commit/
046dbada036d786f420a7775ebcfd51a2a777add
Anirudh Agnihotry [Thu, 20 Jun 2019 17:47:42 +0000 (10:47 -0700)]
supporting duplicate using hashsets (dotnet/corefx#38705)
Commit migrated from https://github.com/dotnet/corefx/commit/
24e81ed6260fabf1211510a93c24385204f08323
Dan Moseley [Thu, 20 Jun 2019 17:21:08 +0000 (10:21 -0700)]
Fix exception tests to match CoreCLR change (dotnet/corefx#38727)
Commit migrated from https://github.com/dotnet/corefx/commit/
41f0787f93d6c51baf3cd90b39b6e572ce5c6582
Tom Deseyn [Thu, 20 Jun 2019 16:31:19 +0000 (18:31 +0200)]
Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)
* Socket: Linux: unblock synchronous socket operations on Dispose
* Fix windows build
* TryUnblockSocket: always do an abortive close for TCP
* TryUnblockSocket: experiment, always call Shutdown
* SyncTcpReceiveSendGetsCancelledByDisposeOrClose: Don't check for abortive close
* Fix build
* Revert always shutdown to compare CI results
* PR feedback
* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race
* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race II
* Fix test
* TcpReceiveSendGetsCanceledByDisposeOrClose: fix timing race III
* TcpReceiveSendGetsCanceledByDisposeOrClose: only run on Sync
* Also perform abortive close when canceling async send/receive
* Fix aborted set to true
* Check what fails on OSX with Shutdown
* Revert "Check what fails on OSX with Shutdown"
This reverts commit dotnet/corefx@
5ab7fce93c9f95a07ce8a1a3cdd3839ca4e6eb31.
* Don't perform abortive close for operations that were already canceled
* interrup Accept/Listen on OSX
* Find out what Disconnectx does for different tests on CI machines
* Move Linux connect AF_UNSPEC and OSX disconnectx into pal Disconnect function, update tests for OSX
* Trigger CI
* TcpReceiveSendGetsCanceledByDispose: check SocketErrorCode
* TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx
* Revert "TcpReceiveSendGetsCanceledByDispose: OSX is also performing an RST close for disconnectx"
This reverts commit dotnet/corefx@
a8d5b02724d650866388b816cde58cb082a53d6e.
* TcpReceiveSendGetsCanceledByDispose: fix test for OSX
* call CancelIoEx to kick out pending operations
* Socket interop: replace IntPtr with SafeHandle
* Windows: RST close when operations were canceled
* Extend tests to check local SocketError
* test: update expected SocketErrors
* update tests: Apm API throws ObjectDisposedException instead of SocketException
* Extend asserts
* Update expected result for ConnectTask
* Update tests based on Windows behavior (https://github.com/dotnet/corefx/pull/37706)
* Map SocketErrors in Socket.cs
* Rewrite nullable asserts
* Fix test for Mac
* Handle SendFile SocketError
* SyncSendFileGetsCanceledByDispose: change how we generate the large file
* SyncSendFileGetsCanceledByDispose: ensure unique filename
* Fix NETFX build
* SyncSendFileGetsCanceledByDispose: skip on NetFramework
* PR feedback
* Fix broken build
* Perform DangerousAddRef for Socket used with UpdateAcceptContext socket option
Commit migrated from https://github.com/dotnet/corefx/commit/
3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4
Viktor Hofer [Thu, 20 Jun 2019 14:45:26 +0000 (16:45 +0200)]
Fix sequencing of MakeCommonResourcesPriFile (dotnet/corefx#38707)
* Fix sequencing of MakeCommonResourcesPriFile
* Disable pri file generation on allconfigs
* Disable testhost binplacing on allconfigurations
* Disable uap tool restore without testhost
* Manual darc update from build '
20190421.1'
Commit migrated from https://github.com/dotnet/corefx/commit/
375ba8f48581e36b02ee99691f55380bb42557c5
Steve Harter [Thu, 20 Jun 2019 14:41:49 +0000 (07:41 -0700)]
Enforce JsonSerializerOptions.MaxDepth on write (dotnet/corefx#38706)
Commit migrated from https://github.com/dotnet/corefx/commit/
10a074131a98a41ee4542ac4ea7039f1f41b212b
Marco Rossignoli [Thu, 20 Jun 2019 14:24:33 +0000 (16:24 +0200)]
Fix ipv6 address parsing with leading compressor (dotnet/corefx#38654)
* fix ipv6 parse
* address PR feedback
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
600469a826ecd26ea5710847557819eff78e3759
Eric StJohn [Thu, 20 Jun 2019 13:56:15 +0000 (06:56 -0700)]
Disable SocketsHttpHandlerTest_Http2.InboundWindowSize_Exceeded_Throw (dotnet/corefx#38722)
Test is consistently failing in CI.
Commit migrated from https://github.com/dotnet/corefx/commit/
468355e66daf9eaeb1978703fa6365cd1e37e644
Steven Kirbach [Thu, 20 Jun 2019 05:09:50 +0000 (22:09 -0700)]
updates to packaging APIs and fixes (dotnet/corefx#38699)
* updates to packaging APIs and fixes
* removing checks entirely and fixing tests
* removing newline
* skipping tests on desktop
Commit migrated from https://github.com/dotnet/corefx/commit/
74032a608cf39d8eaa2955cc46d0ac677e3ae12c
Ryan Lucia [Thu, 20 Jun 2019 03:18:55 +0000 (23:18 -0400)]
Remove extended option in System.Reflection.AssemblyNameTests.FullName (dotnet/corefx#38687)
* Remove extended option in System.Reflection.AssemblyNameTests.FullName
* Remove ToLowerInvariant calls
* Remove another ToLowerInvariant call
* Remove another 'extended' option
Commit migrated from https://github.com/dotnet/corefx/commit/
6c95084f64df294b645729aea9934f72271292eb
Santiago Fernandez Madero [Thu, 20 Jun 2019 02:43:27 +0000 (19:43 -0700)]
Add nullable annotations to System.Diagnostics.Tools ref (dotnet/corefx#38432)
Commit migrated from https://github.com/dotnet/corefx/commit/
f99d24a5eef5aeaa897e62b471c1815ea0175b9e
Anirudh Agnihotry [Thu, 20 Jun 2019 02:23:25 +0000 (19:23 -0700)]
Adding New Idictionary tests and fixing test name and input for type Mismatch (dotnet/corefx#38660)
* Adding New Idictionary tests and fixing test name and inout for type mismatch
* Changing name of the variable
Commit migrated from https://github.com/dotnet/corefx/commit/
36678a0eabe03d786a5f16563ee04abd4b640d24
Dan Moseley [Thu, 20 Jun 2019 01:56:10 +0000 (18:56 -0700)]
Update unix-instructions.md (dotnet/corefx#38703)
* Update unix-instructions.md
* Update unix-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
055052f451d01c6f00209a682cac6f354caaa888
dotnet-maestro[bot] [Thu, 20 Jun 2019 01:50:19 +0000 (01:50 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38679)
* Update dependencies from https://github.com/dotnet/coreclr build
20190618.4
- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19318.4
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19318.4
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19318.4
* IndexOfAny ZeroLength values
* Test updates for relaxed Array.Copy type checks
Fixes dotnet/corefx#38535
Commit migrated from https://github.com/dotnet/corefx/commit/
51a9c8f1dc56d366f5eb435f231052e2614c7a76
Santiago Fernandez Madero [Thu, 20 Jun 2019 01:25:48 +0000 (18:25 -0700)]
Add nullable annotations to System.Diagnostics.Debug ref (dotnet/corefx#38427)
Commit migrated from https://github.com/dotnet/corefx/commit/
8f98894f55cafc2f51adf40b380fcd194c596bb8
Santiago Fernandez Madero [Thu, 20 Jun 2019 00:26:05 +0000 (17:26 -0700)]
Add nullable annotations to System.Diagnostics.Contracts ref assembly (dotnet/corefx#38288)
Commit migrated from https://github.com/dotnet/corefx/commit/
eaa0079941923b4f903344130315f4cd332b84fe
Steve Harter [Thu, 20 Jun 2019 00:15:39 +0000 (17:15 -0700)]
Add additional deserialization array tests (dotnet/corefx#38693)
Commit migrated from https://github.com/dotnet/corefx/commit/
d612cbe52cd8213fb3f8141ca20b50fdf380b521
Steve Harter [Wed, 19 Jun 2019 23:57:42 +0000 (16:57 -0700)]
Add back KeyValuePair functionality (dotnet/corefx#38700)
Commit migrated from https://github.com/dotnet/corefx/commit/
98a5211f1e2b14ab42e52c28f9ca54d41d8e8751
Krzysztof Wicher [Wed, 19 Jun 2019 23:34:29 +0000 (16:34 -0700)]
Add test support for multiple connections in Http2 (dotnet/corefx#38561)
* Add test support for multiple connections in Http2
* manual merge conflict fix, fix recently broken test (also in dotnet/corefx#38694)
Commit migrated from https://github.com/dotnet/corefx/commit/
290a6e54a482ee950c4b812ad85f8de2d795932f
Viktor Hofer [Wed, 19 Jun 2019 21:28:19 +0000 (23:28 +0200)]
Update sln configurations (dotnet/corefx#38698)
Commit migrated from https://github.com/dotnet/corefx/commit/
5ec88f81af71d253cfa74f9982abf748ccbd529b
Krzysztof Wicher [Wed, 19 Jun 2019 20:30:05 +0000 (13:30 -0700)]
Fix http2 tests (SettingsFrame does not propagate flags) (dotnet/corefx#38694)
Commit migrated from https://github.com/dotnet/corefx/commit/
37a56121a88d8e67da75e2e5201f2c1c87c7b551
Steve Harter [Wed, 19 Jun 2019 18:27:09 +0000 (11:27 -0700)]
Custom converter feature for JSON serializer (dotnet/corefx#38578)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b41813015ad0db7740523d65acfcd6a6d7b2df5
Viktor Hofer [Wed, 19 Jun 2019 17:40:49 +0000 (19:40 +0200)]
Disable running tests on ilproj non test projects (dotnet/corefx#38680)
Commit migrated from https://github.com/dotnet/corefx/commit/
376408d6d3768660b7f9bc184c4d3b695221c37b
Cory Nelson [Wed, 19 Jun 2019 17:38:22 +0000 (10:38 -0700)]
Add HTTP2 receive window size enforcement test. (dotnet/corefx#38623)
* Add test for inbound window size enforcement. Resolves dotnet/corefx#35653.
* Correct timeout handling of Http2LoopbackServer.
Commit migrated from https://github.com/dotnet/corefx/commit/
3863ec17c8ea61e72ef2240f23e4518788a2e8ae
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:32:59 +0000 (10:32 -0700)]
Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref (dotnet/corefx#38003)
* Add nullable annotations to System.Runtime.InteropServices.WindowsRuntime ref
* Apply nullable attributes
Commit migrated from https://github.com/dotnet/corefx/commit/
36ff261d4ec19933dde77c11c78256f62a5a4487
Santiago Fernandez Madero [Wed, 19 Jun 2019 17:30:56 +0000 (10:30 -0700)]
Add nullable annotations to System.Runtime.InteropServices ref assembly (dotnet/corefx#37987)
* Add nullable annotations to System.Runtime.InteropServices ref assembly
* Add nullable attributes
* Address nullable feedback from API Review, object -> notnull constraint
Commit migrated from https://github.com/dotnet/corefx/commit/
e1454c1aee299a4f96f718083c89f1b2b952f26c
Ben Adams [Wed, 19 Jun 2019 14:21:25 +0000 (15:21 +0100)]
Shrink System.Diagnostics.Activity by 40 bytes (dotnet/corefx#37395)
* Shrink Activity
* fix threading issues
* Handle parsing issues
* Fix
Commit migrated from https://github.com/dotnet/corefx/commit/
edc88b0fe55278ee43c821ab05707d8bb0befded
Filip Navara [Wed, 19 Jun 2019 10:32:08 +0000 (12:32 +0200)]
Guard for large array support in System.Drawing.Common tests (dotnet/corefx#38672)
Commit migrated from https://github.com/dotnet/corefx/commit/
fd9801068f1baf8d69893da2a414eee7556e51b0
Stephen Toub [Wed, 19 Jun 2019 08:31:31 +0000 (04:31 -0400)]
Add debugging info for sporadic Dns.GetHostEntry("") CI failures (dotnet/corefx#38665)
Commit migrated from https://github.com/dotnet/corefx/commit/
a3fc1b83b5f1d70d6b8529a9ec55178d959fa70d
Charles Stoner [Wed, 19 Jun 2019 08:26:05 +0000 (01:26 -0700)]
Port DynamicMetaObjectProviderDebugView (dotnet/corefx#38656)
* Port DynamicMetaObjectProviderDebugView
* Remove System.Diagnostics.CodeAnalysis.SuppressMessage attributes
* Add explicit private modifier
Commit migrated from https://github.com/dotnet/corefx/commit/
af04307b356e38e2b74df1f05f735ebc462850da
Adam Sitnik [Wed, 19 Jun 2019 08:06:28 +0000 (10:06 +0200)]
writing to too small buffer should throw an exception (dotnet/corefx#37661)
fixes dotnet/corefx#35231
Commit migrated from https://github.com/dotnet/corefx/commit/
721a570b005c53a839947603dcf76f8a3e5fc56a
Jeremy Barton [Wed, 19 Jun 2019 05:18:35 +0000 (22:18 -0700)]
Update the PackageReferences for crypto OOBs in netstandard.depproj
The 4.5.0 ref/netstandard2.0 had three properties declared get/set which were
actually get-only. Updating the depproj version allows removal of the
ApiCompat errors in the shims.
While only 4.5.1 is required, the consensus was to just upgrade all of these
references to the latest versions. Cng (4.5.0) is already at the newest.
Commit migrated from https://github.com/dotnet/corefx/commit/
8b16e3ebf4f4c8be6ed6d744451c512a4d927750
Stephen Toub [Wed, 19 Jun 2019 02:25:24 +0000 (22:25 -0400)]
Disable InvokeOnEventsThreadRunsAsynchronously test on netfx (dotnet/corefx#38662)
And avoid the whole suite from hanging by changing an ~3hr timeout to a 30s timeout.
Commit migrated from https://github.com/dotnet/corefx/commit/
818465ad8624c0231262dba6e7c3a0fc4ca42a7a
Santiago Fernandez Madero [Wed, 19 Jun 2019 01:35:07 +0000 (18:35 -0700)]
Add nullable annotations to System.Collections.Concurrent ref assembly (dotnet/corefx#38189)
* Add nullable annotations to System.Collections.Concurrent ref assembly
* Re-run GenAPI after some attribute fixes
* Update attributes and object -> notnull constraint
Commit migrated from https://github.com/dotnet/corefx/commit/
1494abacb0ec55e7065282311966b1c32329a1f5
Hong Li [Wed, 19 Jun 2019 00:34:13 +0000 (17:34 -0700)]
update system.transaction owner names (dotnet/corefx#38664)
Commit migrated from https://github.com/dotnet/corefx/commit/
c0ed16860e62eea24620b7144ef72d5819ddb2b2
Santiago Fernandez Madero [Tue, 18 Jun 2019 23:16:18 +0000 (16:16 -0700)]
Add nullable annotations to System.Memory ref assembly (dotnet/corefx#38299)
* Add nullable annotations to System.Memory ref assembly
* Nullable feedback
* Include where T inside pragma to be consistent with sources
* Make CultureInfo nullable in ToLower/Upper to match updates we did on String
* Revert comparer nullable change in BinarySearch per pr feedback in implementation
Commit migrated from https://github.com/dotnet/corefx/commit/
ad961d0dc9d9054942c6a7e3a8c96c8684dd16cc
Stephen Toub [Tue, 18 Jun 2019 22:08:38 +0000 (18:08 -0400)]
Adapt existing HttpClientMiniStress tests to support HTTP/2 (dotnet/corefx#38619)
This adapts the existing HttpClientMiniStress tests to run with HTTP/2 as well as HTTP/1.1. Some caveats, though:
- All of these existing tests spin up a new server per request, so they're not stressing arguably the most important aspect of the client's HTTP/2 implementation, that of sharing the single connection across all requests. Our loopback server is not currently robust enough to handle concurrent requests; we should look at switching over to using Kestrel.
- The tests run really slowly, ~40x slower than for HTTP/1.1. However, the HTTP/1.1 tests are non-SSL, these are of course SSL, and it looks like that's actually the difference. In particular, something about how our test server gets its test certificate appears to be taking the vast majority of the time. (We should separately see if we could tweak that, not just for this purpose, but more so to help speed up the whole suite.)
Commit migrated from https://github.com/dotnet/corefx/commit/
a7c893ab3d3e50b11c7fa2338882c8964e0a290d
Stephen Toub [Tue, 18 Jun 2019 22:08:20 +0000 (18:08 -0400)]
Try to make MonitoringIsEnabled more stable (dotnet/corefx#38651)
Add a GC.Collect call to ensure the GC.GetMemoryInfo sees the object being kept alive.
Commit migrated from https://github.com/dotnet/corefx/commit/
471edf259604905535f147ddfb2c8fe5a37ce81d
Stephen Toub [Tue, 18 Jun 2019 22:06:45 +0000 (18:06 -0400)]
Fix GetLogInformation_UsingLogName_DoesNotThrow test (dotnet/corefx#38653)
The test was doing multiple reads from the underlying log and expecting them to be equivalent. That's not guaranteed, as it's a global machine resource.
Commit migrated from https://github.com/dotnet/corefx/commit/
475056abaaf3b1e9e29088c992157b415a800e54
Santiago Fernandez Madero [Tue, 18 Jun 2019 18:44:55 +0000 (11:44 -0700)]
Disable System.Drawing.Common tests for RedHat6 (dotnet/corefx#38649)
Commit migrated from https://github.com/dotnet/corefx/commit/
a7e0c8d9e14a4f814a7e08ddfd0316353c37dd95
Marco Rossignoli [Tue, 18 Jun 2019 06:26:21 +0000 (08:26 +0200)]
remove active issues (dotnet/corefx#38411)
Commit migrated from https://github.com/dotnet/corefx/commit/
1fca079ddec2aabf56e256dab03e39b31b5036c7
Erhan Atesoglu [Tue, 18 Jun 2019 05:32:43 +0000 (22:32 -0700)]
Fixed CaseSenstive Issues (dotnet/corefx#38532)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc9a0f2c5c3e1718a75a9ed508e8a06309c174fb
Santiago Fernandez Madero [Tue, 18 Jun 2019 04:22:06 +0000 (21:22 -0700)]
Add nullable annotations to System.Numerics.Vectors ref assembly (dotnet/corefx#38511)
* Add nullable annotations to System.Numerics.Vectors ref assembly
* Fix various missing ? on ToString(string format)
Commit migrated from https://github.com/dotnet/corefx/commit/
85a2e0c1a3eebf0c937d26de1aafe4e4687b2d4f
Santiago Fernandez Madero [Tue, 18 Jun 2019 03:47:53 +0000 (20:47 -0700)]
Add nullable annotations to System.Runtime.Loader ref (dotnet/corefx#38417)
Commit migrated from https://github.com/dotnet/corefx/commit/
753ae3bca0330fbf80cf20bed0a676d317eefa08
Jeremy Barton [Tue, 18 Jun 2019 01:25:56 +0000 (18:25 -0700)]
Have consistent Dispose behaviors for AsymmetricAlgorithm objects
The AsymmetricAlgorithm types weren't consistent in how they handled Dispose. There were four predominant behaviors on use-after-Dispose
* NullReferenceException (mainly from the OpenSsl implementations)
* Generate a new key, like the object was fresh (the public Cng implementations)
* Not notice that anything was Disposed, keep on keepin' on (the private Cng implementations in Algorithms)
* Indirect ObjectDisposedExceptions 95% of the time (the Windows CSP types)
This change makes all of the types consistently go into (and stay in) a Disposed state, throwing ObjectDisposedExceptions when asked to do work in that state.
Commit migrated from https://github.com/dotnet/corefx/commit/
fb81332b9643ecf8c0bb34d7938da97aa5e13e03
Anirudh Agnihotry [Mon, 17 Jun 2019 22:48:41 +0000 (15:48 -0700)]
Providing support for duplicate keys in dictionary (dotnet/corefx#38524)
* providing support for duplicate keys in dictionary
* Improving failure message
* fixing merge conflicts
Commit migrated from https://github.com/dotnet/corefx/commit/
ef0578fd6abeba406ddffbb1591c1a618bca9dae
Santiago Fernandez Madero [Mon, 17 Jun 2019 21:52:19 +0000 (14:52 -0700)]
Remove StructLayoutAttribute from GdipImageCodecInfo (dotnet/corefx#38607)
* Remove StructLayoutAttribute from GdipImageCodecInfo
* PR Feedback
* Remove wrong comment
Commit migrated from https://github.com/dotnet/corefx/commit/
422e295955841aa2d87d41812e7eef1a755f1e0e
Jose Perez Rodriguez [Mon, 17 Jun 2019 21:10:20 +0000 (14:10 -0700)]
Removing the Manual reference file from System.Text.Json (dotnet/corefx#38409)
* Removing the Manual reference file from System.Text.Json
* Readd the netcoreapp and uap configurations so that we don't have to bring AsyncInterfaces package into the shared framework closure
* Revert param name change as per PR Feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
5b3d41c1c63c4ebd93af7e6482e954e104827884
Stephen Toub [Mon, 17 Jun 2019 20:25:38 +0000 (16:25 -0400)]
Add missing .ConfigureAwait(false) in HttpConnectionPool (dotnet/corefx#38610)
Commit migrated from https://github.com/dotnet/corefx/commit/
3b2707b4b672af99d9d7ac3d57352099f1ff3ff1
Stephen Toub [Mon, 17 Jun 2019 20:25:23 +0000 (16:25 -0400)]
Change DiagnosticsHandler to special-case base cancellation exception (dotnet/corefx#38601)
It should be treating all OperationCanceledExceptions as cancellation, not just TaskCanceledException.
Commit migrated from https://github.com/dotnet/corefx/commit/
dd6b0669bec5ac3b72b2b3a015f42c403c3ec0f1
Santiago Fernandez Madero [Mon, 17 Jun 2019 16:12:53 +0000 (09:12 -0700)]
Re-generate System.Collections.Immutable ref assembly and fix a param name (dotnet/corefx#38264)
* Re-generate System.Collections.Immutable ref assembly and fix a param name
* Use builder as the param name instead
Commit migrated from https://github.com/dotnet/corefx/commit/
2e6661d4cceeff2549b0299ec54e9f3b34c09b20
Viktor Hofer [Mon, 17 Jun 2019 14:55:45 +0000 (16:55 +0200)]
Merge pull request dotnet/corefx#38593 from ViktorHofer/YamlOfficialFix
Fix leg configurations in official builds and converge redhat6 with linux
Commit migrated from https://github.com/dotnet/corefx/commit/
c7178a34416ceb17240b9b3312a5740616555527
Viktor Hofer [Mon, 17 Jun 2019 08:44:59 +0000 (10:44 +0200)]
Move redhat6 into linux group
Commit migrated from https://github.com/dotnet/corefx/commit/
519eccdf8e9c8cb0390f91da8561fcf98a19b838
Stephen Bonikowsky [Mon, 17 Jun 2019 07:59:53 +0000 (00:59 -0700)]
Re-activate test Transactions test. (dotnet/corefx#38554)
* This test was disabled a long time ago with failures only occuring in CI.
* Re-enabling to see if the issue still exists.
* System.Transactions.Tests.AsyncTransactionScopeTests.AsyncTSTest
Commit migrated from https://github.com/dotnet/corefx/commit/
7acfe7156497d667fc39bc1cdb5a7e95d12f5dca
Viktor Hofer [Mon, 17 Jun 2019 07:34:19 +0000 (09:34 +0200)]
Fix leg configurations in official builds
Commit migrated from https://github.com/dotnet/corefx/commit/
32c7d6dad79ec54cd23e5f4bbdf2ce3e827fa1bd
Tarek Mahmoud Sayed [Sun, 16 Jun 2019 19:38:38 +0000 (20:38 +0100)]
Fix the failure in RegionInfo Tests (dotnet/corefx#38577)
* Fix the failure in RegionInfo Tests
China region name has changed to "China mainland", we are updating the test to accept this new name too.
Commit migrated from https://github.com/dotnet/corefx/commit/
d3b6b4aff1dd10afdc83ecfd01ee462737693077
Layomi Akinrinade [Sun, 16 Jun 2019 10:57:34 +0000 (06:57 -0400)]
Add support for serializing types that implement IDictionary<string, object> (dotnet/corefx#38512)
* Add support for serializing types that implement IDictionary<string, object>
* Add test for string to string IDictionary
* fixup
* Address review feedback
* Rename dict -> dictionary
Commit migrated from https://github.com/dotnet/corefx/commit/
e2e5fb23280b3962dcb0422b0df7930387c8ac24
Tomas Weinfurt [Sun, 16 Jun 2019 04:40:37 +0000 (21:40 -0700)]
make sure we close OS handle if socket is finalized without disposing (dotnet/corefx#38499)
* socket_finalize_37044
* update test
Commit migrated from https://github.com/dotnet/corefx/commit/
23faf5d032feef556f5399b46a92a6e4aef7d84a
Layomi Akinrinade [Sat, 15 Jun 2019 23:49:03 +0000 (19:49 -0400)]
Add support for more collections (dotnet/corefx#38319)
* Add support for ISet
* Add support for IEnumerable, IList, and ICollection (non-generic)
* Add support for non-generic IDictionary
* Address review feedback
* Remove unused exception resource and remove ISet<ISet<T>> (de)serialization limitation
* Add support for non-generic collections that have a constructor that takes an IEnumerable or IDictionary
* Condense branches for types we need to set runtime types for
* Add support for non-generic collections that have a constructor that takes an IList
* Add support for Hashtable and SortedList
* Verify sorted dictionary works
* Add support for KeyValuePair
* Create concrete instance of types Foo where possible
* Use generic constructor for KeyValuePair
* Fix KeyValuePair creation in tests
Commit migrated from https://github.com/dotnet/corefx/commit/
4aece7a121a164e68954d79a0ec2569bd71cf125
Egor Bogatov [Sat, 15 Jun 2019 21:44:42 +0000 (00:44 +0300)]
Allow interface names in IPv6 link-local addresses (dotnet/corefx#35278)
* Handle interface names in ipv6 addresses (link-local)
* fix test projects
* Address feedback
* Add SetLastError to if_nametoindex
* fix tests
* fix tests
* Add more tests
* move native impl to pal_networking.c/h
* add newlines to pal_networking
* fix build
* remove "Vista" comment from Interop.if_nametoindex.cs
* test fix for Uri.cs
* undo changes
* Always return 0 for if_nametoindex on UAP
Commit migrated from https://github.com/dotnet/corefx/commit/
fef0f817013ca7ebd39857b7aeecd369a9c36af5
Viktor Hofer [Sat, 15 Jun 2019 19:27:13 +0000 (21:27 +0200)]
Enable project restore for test projects (dotnet/corefx#38151)
* Factor out repo restore into seperate props/targets
* Use configuration system msbuild sdk
* Remove XUnit.Runtime.depproj
* Remove TargetGroup usages in test projects
* Fix ILLink configuration
The ILLink package contains netcoreapp2.0 assets which are compatible
with netstandard2.0. Removing the old TargetFramework to restore
successfully.
* Remove usages from TargetGroup in Directory.Build.props
* Remove dead net4* configurations
* Change tests.builds to tests.proj sdk proj
* Make externals dir proj an sdk project
* Consume Microsoft.DotNet.CoreFxTesting as an msbuild sdk
* Use runtimeconfig.template.json
* Remove SupplementalTestData
* Map shared framework version to product version
* Stop binplacing tests
* Move some tool depprojs to targets during restore
* Remove dead code
* Use PackageReference instead of RefFromRuntime in test
* Disable using an apphost
* Copy compression testdata manually cause unicode bug
* Remove target batching in optimizationData
* Reference packaging tools from CoreFx.Private.TestUtilities
Commit migrated from https://github.com/dotnet/corefx/commit/
c4c1985531cc1f25c805bbc4801b85c98e0dfee0
Jeremy Barton [Sat, 15 Jun 2019 17:28:23 +0000 (10:28 -0700)]
Add S.S.C.Pkcs and S.S.C.Cng netstandard2.1 ref and lib (dotnet/corefx#38439)
* Add S.S.C.Pkcs and S.S.C.Cng netstandard2.1 ref and lib
The netstandard2.1 ref is equivalent to the netcoreapp3.0 ref in these two
OOB packages.
Ref changes:
Cng:
* Adds DSACng and ECDiffieHellmanCng (and related types)
Pkcs:
* Adds RSA-OAEP option to CmsRecipient
* Adds custom private key option to CmsSigner
* Adds custom private key decrypt option to EnvelopedCms
* Adds Pkcs12Info and Pkcs12Builder (and associated types)
* Adds Pkcs8PrivateKeyInfo
* Adds RFC3161 timestamp types
* Adds AddCertificate/RemoveCertificate to SignedCms
* Adds AddUnsignedAttribute/RemoveUnsignedAttribute to SignerInfo
* Adds SignatureAlgorithm/GetSignature to SignerInfo
* Adds MatchesCertificate to SubjectIdentifier
Impl changes:
Cng:
* The netstandard2.1 impl is a generated PNSE, the real impl is inbox on Windows.
Pkcs:
* The impls are the same as the netcoreapp3.0 impls, but are required
because netstandard2.0 is a better match for netstandard2.1 than netcoreapp3.0 is.
* Use shared netstandard21 DefineConstant
* Add netstandard2.1 to ref AdditionalBuildConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
985334c90d6b181cd47cd42c4c958d9dd34ab90b
Santiago Fernandez Madero [Sat, 15 Jun 2019 01:55:50 +0000 (18:55 -0700)]
Add nullable annotations to System.Threading.Overlapped ref (dotnet/corefx#38298)
* Add nullable attributes to System.Threading.Overlapped ref
* Address feedback from API Review
Commit migrated from https://github.com/dotnet/corefx/commit/
5fa3d3b8f89302202091993681391c9b356755a7
Santiago Fernandez Madero [Sat, 15 Jun 2019 01:55:23 +0000 (18:55 -0700)]
Add nullable annotations to System.Threading.ThreadPool ref assembly. (dotnet/corefx#38239)
* Re-generate System.Threading.ThreadPool ref assembly against implementation
* Enable nullable context on System.Threading.ThreadPool
* Add nullable annotations to System.Threading.ThreadPool
Commit migrated from https://github.com/dotnet/corefx/commit/
040b28ca57fbe57db32a0b56c977d4956991e34c
Dilip Ojha [Fri, 14 Jun 2019 23:27:45 +0000 (16:27 -0700)]
Moving System.Security.Permissions Types from WPF
* moved wpf types
* added new types to ref
* addressed comments
* addressing comments
* addressed more comments
* addressed comment
* updated ref
* added typeforwardedfrom and addressed comment
* updated publickeytoken
* added tests, addressed comments
* added mediapermissionattribute test
Commit migrated from https://github.com/dotnet/corefx/commit/
df5bb8e4509ca5166f83abbd4cfe4a063433fee7
Viktor Hofer [Fri, 14 Jun 2019 13:12:42 +0000 (15:12 +0200)]
Delete dead uapaot code (dotnet/corefx#38330)
* Delete dead uapaot code
Commit migrated from https://github.com/dotnet/corefx/commit/
8c2be7893fa585cba9c094c27b69d7c8e0822ef3
Santiago Fernandez Madero [Fri, 14 Jun 2019 03:16:26 +0000 (20:16 -0700)]
Add nullable annotations to System.Threading.Timer ref assembly (dotnet/corefx#38284)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3f4524c785a226bae79cc82a96f7525460e2b5e
Santiago Fernandez Madero [Fri, 14 Jun 2019 03:13:21 +0000 (20:13 -0700)]
Add nullable annotations to System.Threading.Tasks ref assembly (dotnet/corefx#38265)
Commit migrated from https://github.com/dotnet/corefx/commit/
3f94d610c133440eeb06f418540be6d8fd782ca0
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:10:11 +0000 (17:10 -0700)]
Add nullable annotations to System.Threading.Thread ref assembly (dotnet/corefx#38236)
Commit migrated from https://github.com/dotnet/corefx/commit/
44d305e2f0a312bb0506e0e1ef1fcafeb07b2bb1
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:09:44 +0000 (17:09 -0700)]
Add nullable annotations to System.Threading ref (dotnet/corefx#38223)
* Add nullable annotations to System.Threading
* Update nullable attributes
Commit migrated from https://github.com/dotnet/corefx/commit/
6538c26973d574e9ef92790210f11d11fd2d750f
Jeremy Barton [Fri, 14 Jun 2019 00:09:16 +0000 (17:09 -0700)]
Define osx.10.15 RID (dotnet/corefx#38509)
Commit migrated from https://github.com/dotnet/corefx/commit/
2458de0ada6a2eac4c36cc07628f4e7b3a02ad73
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:49 +0000 (17:08 -0700)]
Update one annotation on System.Runtime ref assembly (dotnet/corefx#38529)
Commit migrated from https://github.com/dotnet/corefx/commit/
b9bb7c8ec3c6011c0f5815edf38c211982193718
Santiago Fernandez Madero [Fri, 14 Jun 2019 00:08:20 +0000 (17:08 -0700)]
Enable nullable context to System.Buffers (dotnet/corefx#38530)
Commit migrated from https://github.com/dotnet/corefx/commit/
66d5a9410a2e163452e9e8b15328d3caf8c336d5
Stephen Toub [Thu, 13 Jun 2019 20:55:11 +0000 (16:55 -0400)]
Update corefx for compiler nullable attribute updates
Commit migrated from https://github.com/dotnet/corefx/commit/
3c129ac0340a3843ab5b00a9c730730e7b60729b
Anirudh Agnihotry [Thu, 13 Jun 2019 22:14:00 +0000 (15:14 -0700)]
Tests for nullable reference types in Span apis (dotnet/corefx#38468)
Commit migrated from https://github.com/dotnet/corefx/commit/
159fbc07c938f5ee6f136c60559ca16dc295d859
Anirudh Agnihotry [Thu, 13 Jun 2019 22:10:13 +0000 (15:10 -0700)]
Correcting some invalid array json inputs (dotnet/corefx#38323)
* correcting some invalid array json inputs
* adding comments and modifiers
* addressing feedback
* correcting issue number
Commit migrated from https://github.com/dotnet/corefx/commit/
eaee16b5c9d3e020b5892a28a204ceb5da4d6a4a
Viktor Hofer [Thu, 13 Jun 2019 13:21:00 +0000 (15:21 +0200)]
Remove inbox mark for both packages
Commit migrated from https://github.com/dotnet/corefx/commit/
2a26a601ca062223f36bfa0c4e51ea70cfd419f2
Viktor Hofer [Wed, 12 Jun 2019 12:44:11 +0000 (14:44 +0200)]
Add inbox for xamarin on ref context
Commit migrated from https://github.com/dotnet/corefx/commit/
1a4c723839585e8ffe82e508bc2a795dfa3fc4db
Viktor Hofer [Wed, 12 Jun 2019 08:36:27 +0000 (10:36 +0200)]
Add uap test target to ref context
Commit migrated from https://github.com/dotnet/corefx/commit/
5472beffe38d96b39639d57b8993de4064003433
Viktor Hofer [Wed, 12 Jun 2019 08:26:59 +0000 (10:26 +0200)]
Mark registration pkg inbox on Xamarin
Commit migrated from https://github.com/dotnet/corefx/commit/
a57ca7747c2d67f63f5f5bb9eecb0cb4539d7ddc
Viktor Hofer [Wed, 12 Jun 2019 08:25:42 +0000 (10:25 +0200)]
Add uap configuration to registration tests
Commit migrated from https://github.com/dotnet/corefx/commit/
278614e178eaa7a185f8fa5930e5646175ce3fad
Viktor Hofer [Fri, 7 Jun 2019 22:31:07 +0000 (00:31 +0200)]
Remove XamarinTfm support check
Commit migrated from https://github.com/dotnet/corefx/commit/
07778aa8dd42b456f1f932f54e0dd2bf3890c597
Viktor Hofer [Tue, 4 Jun 2019 08:45:56 +0000 (10:45 +0200)]
Retarget RefContext and CompRegistration to NS2.1
Commit migrated from https://github.com/dotnet/corefx/commit/
97a07058b7cdb4f066fd81562102a44adbde5338
Viktor Hofer [Thu, 13 Jun 2019 15:54:11 +0000 (17:54 +0200)]
Move to up2date macOS pool
Commit migrated from https://github.com/dotnet/corefx/commit/
6ea902fc02ed698e190fd891416677f51ac3770c