Mike Gorse [Thu, 26 Apr 2012 21:06:34 +0000 (16:06 -0500)]
Fix the gdbus-proxy async test
The async test had several problems:
- It created a proxy and did not launch a main loop, meaning that its
callback would usually not get called, or, if it did get called, the
test harness would have taken down the connection already, causing an
assertion failure when the proxy had an error.
- It was dependent on the proxy test to set up the server and would fail
because some properties were modified by that test.
https://bugzilla.gnome.org/show_bug.cgi?id=674805
Colin Walters [Mon, 27 Aug 2012 18:37:21 +0000 (14:37 -0400)]
gstdio: Harden g_open() against EINTR
Noticed by code inspection, when auditing some of my code for EINTR
handling.
https://bugzilla.gnome.org/show_bug.cgi?id=682819
Colin Walters [Wed, 28 Mar 2012 17:53:37 +0000 (13:53 -0400)]
gvariant: Add tests for exact SHA256 checksums
I'd like to use GVariant as a data format in my userspace filesystem,
and having the actual bits be stable means I can reliably compute
cryptographic checksums.
This updated patch removes vardict checks, because Ryan wants the
flexibility to change them in the future.
https://bugzilla.gnome.org/show_bug.cgi?id=673012
Ryan Lortie [Mon, 27 Aug 2012 20:12:30 +0000 (16:12 -0400)]
GVariantType: gut g_variant_type_check()
This function is causing an insane amount of wasted time on some
real-world profiles and it's pretty useless since we already have
GVariantType (as a type different from a string) for the purpose of
static type safety.
Disable it for now. We can possibly turn this back on again if we solve
bug #544026.
https://bugzilla.gnome.org/show_bug.cgi?id=679835
Nilamdyuti Goswami [Mon, 27 Aug 2012 18:09:52 +0000 (23:39 +0530)]
Implemented FUEL entries to Assamese translation
Dan Winship [Thu, 23 Aug 2012 16:48:49 +0000 (12:48 -0400)]
glib/tests: fix leaks
https://bugzilla.gnome.org/show_bug.cgi?id=682560
Dan Winship [Thu, 23 Aug 2012 16:29:36 +0000 (12:29 -0400)]
gtestutils: add g_test_add_data_func_full()
Like g_test_add_data_func(), but includes a GDestroyNotify for the
test data.
https://bugzilla.gnome.org/show_bug.cgi?id=682560
Dan Winship [Thu, 23 Aug 2012 16:38:17 +0000 (12:38 -0400)]
gmain: remove unix signal watch if its GSourceFunc returns FALSE
g_unix_signal_watch_dispatch() was ignore the callback's return value.
Fix that.
https://bugzilla.gnome.org/show_bug.cgi?id=682560
Dan Winship [Thu, 23 Aug 2012 16:35:20 +0000 (12:35 -0400)]
gmain: don't leak child sources that are destroyed before their parents
A parent source holds refs on its children, so if the child source is
destroyed, we need to drop that ref. Fix, and reorganize to make this
all more obvious.
https://bugzilla.gnome.org/show_bug.cgi?id=682560
Dan Winship [Thu, 23 Aug 2012 16:33:43 +0000 (12:33 -0400)]
gmain: free source_lists when freeing GMainContext
If a context was freed with sources still attached, those sources
correctly got destroyed, but the corresponding GSourceList structs
were being leaked.
https://bugzilla.gnome.org/show_bug.cgi?id=682560
Dan Winship [Sun, 26 Aug 2012 18:40:13 +0000 (14:40 -0400)]
Update .gitignores
Colin Walters [Sat, 25 Aug 2012 21:13:43 +0000 (17:13 -0400)]
docs: Ensure CLEANFILES is set before we use +=
We need to be defensive about this in the case where gtk-doc.make is
empty.
William Jon McCann [Fri, 24 Aug 2012 17:32:25 +0000 (13:32 -0400)]
Don't crash if set_app_info is called before adding metadata
set_mime_type, set_is_private, add_group, set_groups, set_icon, etc
all added metadata before using it. If set_app_info was called before
any of those it would crash when trying to access the metadata.
OKANO Takayoshi [Thu, 23 Aug 2012 10:15:09 +0000 (19:15 +0900)]
[l10n] Update Japanese translation
A S Alam [Thu, 23 Aug 2012 02:27:51 +0000 (07:57 +0530)]
update Punjabi Translation
Piotr Drąg [Wed, 22 Aug 2012 20:36:15 +0000 (22:36 +0200)]
Updated Polish translation
Colin Walters [Wed, 22 Aug 2012 18:48:41 +0000 (14:48 -0400)]
Fix regression when TMPDIR/TMP are unset
We should just be returning /tmp as a default, not calling g_getenv
("/tmp") which makes no sense.
https://bugzilla.gnome.org/show_bug.cgi?id=672329
Kjartan Maraas [Wed, 22 Aug 2012 08:29:16 +0000 (10:29 +0200)]
Updated Norwegian bokmål translation
Nguyễn Thái Ngọc Duy [Wed, 22 Aug 2012 02:15:00 +0000 (09:15 +0700)]
Updated Vietnamese translation
Nguyễn Thái Ngọc Duy [Wed, 22 Aug 2012 01:51:44 +0000 (08:51 +0700)]
po/vi: imported from Damned Lies
Duarte Loreto [Tue, 21 Aug 2012 23:54:09 +0000 (00:54 +0100)]
Updated Portuguese translation
Ryan Lortie [Tue, 21 Aug 2012 20:32:17 +0000 (16:32 -0400)]
*bump*
thanks rico :)
Dieter Verfaillie [Tue, 21 Aug 2012 19:10:16 +0000 (21:10 +0200)]
win32: fix tests/sources.c
"make check" was failing on sys/resource.h not being available on
win32. Seeing that this test just spews some numbers on stdout
whithout really testing anything we can safely replace them with
similar enough numbers by relying on g_get_monotonic_time ().
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=682386
Stef Walter [Tue, 21 Aug 2012 11:26:27 +0000 (13:26 +0200)]
Revert "gtlscertificate: Add certificate-bytes and private-key-bytes props"
* In order to add contstruct properties to an abstract base
calls, and retain ABI stability, the base class must add a
default implementation of those properties.
* We cannot add a default implementation of certificate-bytes
or private-key-bytes since certificate and private-key properties
are writable on construct-only.
This reverts commit
541c985869fe9f2c0a858c0a91b4eb60f99d19f0.
https://bugzilla.gnome.org/show_bug.cgi?id=682081
Stef Walter [Fri, 17 Aug 2012 08:55:10 +0000 (10:55 +0200)]
gdbus: Fix double free and use after free of object path
* This occurs when the 'g-object-path' property is read
on a GDBusObjectSkeleton
https://bugzilla.gnome.org/show_bug.cgi?id=682075
Chao-Hsiung Liao [Tue, 21 Aug 2012 11:16:27 +0000 (19:16 +0800)]
Updated Traditional Chinese translation(Hong Kong and Taiwan)
Cosimo Cecchi [Mon, 20 Aug 2012 17:46:33 +0000 (19:46 +0200)]
mount-op: use gint64 instead of guint64 for time_left and bytes_left
Since those can be -1, they need to be signed.
https://bugzilla.gnome.org/show_bug.cgi?id=682284
Andika Triwidada [Tue, 21 Aug 2012 06:53:46 +0000 (13:53 +0700)]
Updated Indonesian translation
Ryan Lortie [Mon, 20 Aug 2012 22:32:25 +0000 (18:32 -0400)]
NEWS, versions, etc.
Ryan Lortie [Mon, 20 Aug 2012 22:32:46 +0000 (18:32 -0400)]
Revert the GMarkup attribute collect changes
We need to have some more discussion on this topic.
This reverts commits
86329ba44fc7662c0bad37955f0ec980a24be495 and
8d40389d15544bdc612989157f80380badce52f7.
https://bugzilla.gnome.org/show_bug.cgi?id=665634
Ryan Lortie [Mon, 20 Aug 2012 21:57:13 +0000 (17:57 -0400)]
gmarkup test: fix use of message expect API
Dan Winship [Mon, 20 Aug 2012 21:26:45 +0000 (17:26 -0400)]
tests/protocol: update the messages to reflect G_LOG_DOMAIN being set now
Ryan Lortie [Mon, 20 Aug 2012 20:25:09 +0000 (16:25 -0400)]
g_test_expect_message: add some g_return_if_fail
NULL domain is not supported and some might expect this to work, so make
sure they don't get the wrong idea...
Lars Uebernickel [Mon, 20 Aug 2012 12:32:14 +0000 (14:32 +0200)]
GMenuModel: add test for the new GMenuItem API
Ryan Lortie [Sat, 18 Aug 2012 18:24:46 +0000 (14:24 -0400)]
GMenuItem: add constructor to copy from model
Add g_menu_item_new_from_model() for constructing a GMenuItem that is a
copy of a menu item that's in a GMenuModel.
Ryan Lortie [Sat, 18 Aug 2012 18:20:59 +0000 (14:20 -0400)]
GMenuItem: add getter APIs
GMenuItem has been write-only up to this point. Add some APIs for
reading back values as well.
Ryan Lortie [Sat, 18 Aug 2012 18:14:21 +0000 (14:14 -0400)]
GMenuModel: remove a type safety bug
There was a /* XXX */ in the code here to do proper typechecking of the
GVariant in the menu model when using g_menu_model_get_item_attribute().
We have g_variant_check_format_string() now, so use it.
Ryan Lortie [Sat, 18 Aug 2012 18:12:55 +0000 (14:12 -0400)]
GVariant: add g_variant_check_format_string()
For some time now people have been asking for a way to check for type
compatibility between GVariant instances and format strings. There are
several APIs inside of GLib itself that would benefit from this.
This patch introduces a way to do that.
Aurimas Černius [Mon, 20 Aug 2012 20:10:25 +0000 (23:10 +0300)]
Updated Lithuanian translation
Dan Winship [Mon, 30 Jul 2012 20:38:30 +0000 (16:38 -0400)]
glib/tests: use g_test_expect_message()
Replace some tests that used to use g_test_trap_fork() with
g_test_expect_message() instead.
https://bugzilla.gnome.org/show_bug.cgi?id=679556
Dan Winship [Mon, 30 Jul 2012 20:05:08 +0000 (16:05 -0400)]
gtestutils: add g_text_expect_message()
Add g_test_expect_message() and g_test_assert_expected_messages(), to
allow tests of warnings, error messages, return-if-fails, etc.
https://bugzilla.gnome.org/show_bug.cgi?id=679556
Dan Winship [Mon, 30 Jul 2012 19:32:31 +0000 (15:32 -0400)]
g_logv: only expand the message once
Hoist the g_strdup_printf()'ing out of the loop, since the message is
the same for every handler that gets called.
https://bugzilla.gnome.org/show_bug.cgi?id=679556
Dan Winship [Wed, 1 Aug 2012 13:49:10 +0000 (09:49 -0400)]
glib/tests/testing, logging: don't use g_test_undefined()
We are verifying the behavior of the test/logging functions here; this
is not undefined behavior.
https://bugzilla.gnome.org/show_bug.cgi?id=679556
Marc-André Lureau [Tue, 3 Jul 2012 00:04:08 +0000 (02:04 +0200)]
win32: add pipe-io-cancel-test
Test that win32 streams can be cancelled.
It can even be tested with wine on Linux!
https://bugzilla.gnome.org/show_bug.cgi?id=679288
Marc-André Lureau [Tue, 7 Aug 2012 23:02:40 +0000 (01:02 +0200)]
win32: add pipe-io-concurrent
Implement test case suggested by Ryan Lortie on bug:
https://bugzilla.gnome.org/show_bug.cgi?id=679288
"There is a potential race here that's really unlikely to happen, but
here we go: We are trying to read from the same socket in two threads.
Some data comes. That causes the poll() in both threads (above) to
finish running. Then the cancellable is checked above. We now find
ourselves here. Only one thread will read the data. The other will
block on this function. Then the user may cancel the cancellable while
we are blocked here, but we will stay blocked...."
Marc-André Lureau [Mon, 20 Aug 2012 13:47:15 +0000 (15:47 +0200)]
win32: add pipe-io-overlap-test
Marc-André Lureau [Thu, 5 Jul 2012 22:46:32 +0000 (00:46 +0200)]
win32: make gio stream cancellable
v2:
- fix cancellation of concurrent readers
- replace g_assert() usage with g_warn_if_fail()
v3:
- fix indentation
- fix loop code to not leak (silly me)
https://bugzilla.gnome.org/show_bug.cgi?id=679288
Marc-André Lureau [Tue, 7 Aug 2012 23:08:15 +0000 (01:08 +0200)]
win32: handle ERROR_MORE_DATA
If a named pipe is being read in message mode and the next message is
longer than the nNumberOfBytesToRead parameter specifies, ReadFile
returns FALSE and GetLastError returns ERROR_MORE_DATA.
Since the API doesn't allow to return both a GError and the number of
bytes read so far, it makes more sense to return nread, and let the
client call GetLastError() himself to check if ERROR_MORE_DATA.
The current alternative loses the nread information.
https://bugzilla.gnome.org/show_bug.cgi?id=679288
Marc-André Lureau [Mon, 2 Jul 2012 19:45:41 +0000 (21:45 +0200)]
win32: use overlapped events for streams
Any file handle created with FLAG_OVERLAPPED must have
ReadFile()/WriteFile() called with an OVERLAPPED structure.
Failing to do so will give unspecified results, invalid read/write or
corruption.
Without FLAG_OVERLAPPED, it is not possible to read and write
concurrently, even with two seperate threads, created by 2 input and
output gio streams. Also, only with FLAG_OVERLAPPED may an IO
operation be asynchronous and thus be cancellable.
We may want to call ReOpenFile() to make sure the FLAG is set, but
this API is only available since Vista+.
According to MSDN doc, adding the OVERLAPPED argument for IO operation
on handles without FLAG_OVERLAPPED is allowed, and indeed the existing
test still passes.
v2:
- update GetLastError() after _g_win32_overlap_wait_result ()
- split the unrelated ERROR_MORE_DATA handling
https://bugzilla.gnome.org/show_bug.cgi?id=679288
Thomas Hindoe Paaboel Andersen [Mon, 20 Aug 2012 14:41:42 +0000 (16:41 +0200)]
gmem.c: array is only paritally filled by memcpy
The size of the local_data arrray is too large. It should not be
multiplied by the sizeof guint.
The memcpy of profile_data to local_data later will only fill a part of the
array.
Spotted with the PVS-Studio static analyzer
https://bugzilla.gnome.org/show_bug.cgi?id=681501
Daniel Mustieles [Mon, 20 Aug 2012 12:15:39 +0000 (14:15 +0200)]
Updated Spanish translation
Matthias Clasen [Sun, 19 Aug 2012 06:27:04 +0000 (02:27 -0400)]
Remove some more 'the the'
Matthias Clasen [Sun, 19 Aug 2012 06:26:42 +0000 (02:26 -0400)]
Improve test coverage for GSocketConnection
Matthias Clasen [Sun, 19 Aug 2012 06:26:05 +0000 (02:26 -0400)]
Improve test coverage for unix socket addresses
Matthias Clasen [Sun, 19 Aug 2012 06:25:37 +0000 (02:25 -0400)]
Improve test coverage for resources
Matthias Clasen [Sun, 19 Aug 2012 06:25:21 +0000 (02:25 -0400)]
Improve test coverage for filter streams
Matthias Clasen [Sun, 19 Aug 2012 06:25:02 +0000 (02:25 -0400)]
Improve test coverage for unix streams
Matthias Clasen [Sun, 19 Aug 2012 06:24:44 +0000 (02:24 -0400)]
Improve test coverage for pollable streams
Matthias Clasen [Sun, 19 Aug 2012 06:24:04 +0000 (02:24 -0400)]
Improve GSettings test coverage
Matthias Clasen [Sun, 19 Aug 2012 06:23:32 +0000 (02:23 -0400)]
Improve GAppInfo test coverage
Matthias Clasen [Sun, 19 Aug 2012 06:22:59 +0000 (02:22 -0400)]
Add some GInetAddress tests
Matthias Clasen [Sun, 19 Aug 2012 06:22:33 +0000 (02:22 -0400)]
Add some GPermission tests
Matthias Clasen [Sun, 19 Aug 2012 06:21:02 +0000 (02:21 -0400)]
Cosmetic change
gtk-doc doesn't need <!-- --> anymore to recognize plural
forms of links.
Matthias Clasen [Sun, 19 Aug 2012 06:19:27 +0000 (02:19 -0400)]
Make GPermission more forgiving
It is not great if calling g_permission_acquire on a simple
permission object just segfaults. This commit arranges for
this to return a G_IO_ERROR_NOT_SUPPORTED error.
Matthias Clasen [Sun, 19 Aug 2012 03:17:47 +0000 (23:17 -0400)]
It is 'registered', not 'registred'
Matthias Clasen [Sun, 19 Aug 2012 03:15:58 +0000 (23:15 -0400)]
Exterminate 'the the'
Matthias Clasen [Sat, 18 Aug 2012 18:42:10 +0000 (14:42 -0400)]
Improve utils test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:41:48 +0000 (14:41 -0400)]
Improve uri test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:41:35 +0000 (14:41 -0400)]
Improve strfuncs tests coverage
Matthias Clasen [Sat, 18 Aug 2012 18:41:23 +0000 (14:41 -0400)]
Improve GRegex test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:41:07 +0000 (14:41 -0400)]
Improve GPrivate test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:40:33 +0000 (14:40 -0400)]
Improve file utils test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:40:15 +0000 (14:40 -0400)]
Improve GError test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:39:52 +0000 (14:39 -0400)]
Improve atomic ops test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:39:28 +0000 (14:39 -0400)]
Improve array test coverage
Matthias Clasen [Sat, 18 Aug 2012 18:38:53 +0000 (14:38 -0400)]
Improve threadpool test coverage
Fran Diéguez [Fri, 17 Aug 2012 21:17:51 +0000 (23:17 +0200)]
Updated Galician translations
Owen W. Taylor [Fri, 17 Aug 2012 02:06:45 +0000 (22:06 -0400)]
Fix problems with CLEANFILES and automake-1.11.1
Running with automake-1.11.1, a couple fixes are needed
for CLEANFILES when gtk-doc is not installed.
(Found with Amazon Linux AMI release 2012.03)
https://bugzilla.gnome.org/show_bug.cgi?id=682067
Krishnababu Krothapalli [Fri, 17 Aug 2012 14:13:40 +0000 (19:43 +0530)]
Updated Telugu Translations
Krishnababu Krothapalli [Fri, 17 Aug 2012 13:52:00 +0000 (19:22 +0530)]
Updated Telugu Translations
Chun-wei Fan [Fri, 17 Aug 2012 11:22:43 +0000 (19:22 +0800)]
Fix build on Visual C++
-glib/gmarkup.c: Use G_VA_COPY() instead of va_copy() as va_copy() may not
be universally available.
-gio/gtestdbus.c: Include io.h on Windows for close()
Мирослав Николић [Fri, 17 Aug 2012 10:59:44 +0000 (12:59 +0200)]
Updated Serbian translation
Nilamdyuti Goswami [Fri, 17 Aug 2012 08:52:32 +0000 (14:22 +0530)]
Assamese translation updated
Sandeep Sheshrao Shedmake [Fri, 17 Aug 2012 06:54:15 +0000 (12:24 +0530)]
Updated Marathi Translations
David King [Fri, 17 Feb 2012 11:15:08 +0000 (11:15 +0000)]
docs: Describe GCompletion item memory management
https://bugzilla.gnome.org/show_bug.cgi?id=600751
Matthias Clasen [Fri, 17 Aug 2012 05:14:51 +0000 (01:14 -0400)]
Adapt schema tests to changed error messages
Colin Walters [Tue, 29 May 2012 22:54:58 +0000 (18:54 -0400)]
GMappedFile: Add g_mapped_file_get_bytes()
This is yet another API that has a data/length/refcount combination
that one might often want to turn into a GBytes.
https://bugzilla.gnome.org/show_bug.cgi?id=677065
Matthias Clasen [Fri, 17 Aug 2012 04:27:10 +0000 (00:27 -0400)]
GDateTime: pack the struct better
Makes a difference in 32bit.
Matthias Clasen [Fri, 17 Aug 2012 03:41:19 +0000 (23:41 -0400)]
gdbus: Use g_markup_collect_known_attributes() in GDBus introspection
In order to be able to cope with the introspection XML
from the Telepathy specification, which uses attributes
like tp:type and tp:name-for-bindings, we need to ignore
unknown attributes when parsing.
Closes: https://bugzilla.gnome.org/show_bug.cgi?id=665634
Matthias Clasen [Fri, 17 Aug 2012 03:40:08 +0000 (23:40 -0400)]
gmarkup: Add g_markup_collect_known_attributes()
Add a variant of g_markup_collect_attributes() which will
ignore unknown attributes (such as those from different XML
namespaces) when parsing markup, rather than returning
G_MARKUP_ERROR_UNKNOWN_ATTRIBUTE as g_markup_collect_attributes()
does.
Patch by Philip Withnall,
https://bugzilla.gnome.org/show_bug.cgi?id=665634
Matthias Clasen [Fri, 17 Aug 2012 03:23:16 +0000 (23:23 -0400)]
Fix 'make report'
Turns out this doesn't work unless every Makefile.am includes
Makefile.decl.
Matthias Clasen [Fri, 17 Aug 2012 03:02:41 +0000 (23:02 -0400)]
Miscellaneous string fixes
Typo and punctuation fixes, and some rewording, based
on a patch by Philip Withnall, bug
https://bugzilla.gnome.org/review?bug=628193
Matthias Clasen [Fri, 17 Aug 2012 02:47:43 +0000 (22:47 -0400)]
Make capitalisation of "UNIX" consistent in translatable strings
Based on a patch by Philip Withnall, bug
https://bugzilla.gnome.org/review?bug=628193
Matthias Clasen [Fri, 17 Aug 2012 02:23:20 +0000 (22:23 -0400)]
Change "dash" to "hyphen" in translatable strings
GSchemas use hyphens, not dashes.
Patch by Philip Withnall, bug
https://bugzilla.gnome.org/review?bug=628193
Matthias Clasen [Fri, 17 Aug 2012 02:17:46 +0000 (22:17 -0400)]
Fix leak in GWinHttpVfs
Patch by Ole André Vadla Ravnås, bug
https://bugzilla.gnome.org/show_bug.cgi?id=627423
Matthias Clasen [Fri, 17 Aug 2012 02:15:54 +0000 (22:15 -0400)]
Fix leak in GFileAttributeInfoList
Patch by Ole André Vadla Ravnås, bug
https://bugzilla.gnome.org/show_bug.cgi?id=627423
Matthias Clasen [Fri, 17 Aug 2012 00:18:37 +0000 (20:18 -0400)]
GTest: Improve --help output
https://bugzilla.gnome.org/show_bug.cgi?id=550433
David King [Fri, 17 Feb 2012 14:42:58 +0000 (14:42 +0000)]
docs: Improve G_GNUC_* documentation
Mention where the GCC attributes should be placed for functions and
arguments. Add an example for G_GNUC_UNUSED.
https://bugzilla.gnome.org/show_bug.cgi?id=326931
Matthias Clasen [Thu, 16 Aug 2012 22:44:41 +0000 (18:44 -0400)]
Improve glib-genmarshal man page
Expand the example in glib-genmarshal.1 to include the actual
commandline invocations, and update the generated function
names to match reality.
https://bugzilla.gnome.org/show_bug.cgi?id=637460
Colin Walters [Thu, 16 Aug 2012 22:31:02 +0000 (18:31 -0400)]
build: Fix the --disable-man case
The manpage listing needs to be inside the conditional.