joshualitt [Tue, 21 Jul 2015 15:05:03 +0000 (08:05 -0700)]
rename BitmapTextBlob and move it to its own file
BUG=skia:
Review URL: https://codereview.chromium.org/
1249663002
caryclark [Tue, 21 Jul 2015 14:42:45 +0000 (07:42 -0700)]
make xfermode* portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1243103002
borenet [Tue, 21 Jul 2015 12:57:22 +0000 (05:57 -0700)]
Skip imagefiltersclipped GM on Galaxy S4
BUG=skia:4079
Review URL: https://codereview.chromium.org/
1250473005
mtklein [Tue, 21 Jul 2015 12:02:40 +0000 (05:02 -0700)]
Revert of 565 support for SIMD xfermodes (patchset #3 id:40001 of https://codereview.chromium.org/
1245673002/)
Reason for revert:
942930d (included in this roll) introduced a 140 kB sizes regression in
libskia.so. Please investigate and reland if this regression is necessary.
Original issue's description:
> 565 support for SIMD xfermodes
>
> This uses the most basic approach possible:
> - to load an Sk4px from 565, convert to SkPMColors on the stack serially then load those SkPMColors.
> - to store an Sk4px to 565, store to SkPMColors on the stack then convert to 565 serially.
>
> Clearly, we can optimize these loads and stores. That's a TODO.
>
> The code using SkPMFloat is the same idea but a little more long-term viable, as we're only operating on one pixel at a time anyway. We could probably write 565 <-> SkPMFloat methods, but I'd rather not until it's really compelling.
>
> The speedups are varied but similar across SSE and NEON: a few uninteresting, many 50% faster, some 2x faster, and SoftLight ~4x faster.
>
> This will cause minor GM diffs, but I don't think any layout test changes.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
942930dcaa51f66d82cdaf46ae62efebd16c8cd0
TBR=msarett@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1242973004
rileya [Mon, 20 Jul 2015 22:00:03 +0000 (15:00 -0700)]
Add Rec709 YUV color space support to GrYUVtoRGBEffect.
This change is motivated by a recent switch in how chromium handles
<video> color spaces, making rec709 more commonly used. This will
allow video -> canvas copies to take the fast GPU path when we're using
709, just as we do with 601 and jpeg.
Chromium-side change: https://codereview.chromium.org/
1236313002
Review URL: https://codereview.chromium.org/
1241723005
caryclark [Mon, 20 Jul 2015 20:38:56 +0000 (13:38 -0700)]
Generate platform specific fontmgr gm.
The gm output on different font platforms is so different
that comparing images in Gold has little value. Separate the
images by appending platform information to the gm name to
group somewhat similar images together.
Note that this does not attempt to make sure that all images
generated by Gold are nearly pixel identical; it only reduces
the number of nonsensical comparisons.
R=bungeman@google.com
Review URL: https://codereview.chromium.org/
1245643002
emmaleer [Mon, 20 Jul 2015 20:38:44 +0000 (13:38 -0700)]
removing png_read_end from SkPngScanlineDecoder
BUG=skia:4041
Review URL: https://codereview.chromium.org/
1242423002
caryclark [Mon, 20 Jul 2015 17:48:01 +0000 (10:48 -0700)]
make stroketext textblob* texteffects tileimagefilter gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1244833002
mtklein [Mon, 20 Jul 2015 17:35:30 +0000 (10:35 -0700)]
565 support for SIMD xfermodes
This uses the most basic approach possible:
- to load an Sk4px from 565, convert to SkPMColors on the stack serially then load those SkPMColors.
- to store an Sk4px to 565, store to SkPMColors on the stack then convert to 565 serially.
Clearly, we can optimize these loads and stores. That's a TODO.
The code using SkPMFloat is the same idea but a little more long-term viable, as we're only operating on one pixel at a time anyway. We could probably write 565 <-> SkPMFloat methods, but I'd rather not until it's really compelling.
The speedups are varied but similar across SSE and NEON: a few uninteresting, many 50% faster, some 2x faster, and SoftLight ~4x faster.
This will cause minor GM diffs, but I don't think any layout test changes.
BUG=skia:
Review URL: https://codereview.chromium.org/
1245673002
robertphillips [Mon, 20 Jul 2015 17:22:29 +0000 (10:22 -0700)]
Fix textureDomain/bleed prevention in msaa
This updates Ganesh's bleed avoidance check to handle the case where the
sample location may be outside of the rect geometry but used because it
partially covers the pixel.
BUG=skia:4066
Review URL: https://codereview.chromium.org/
1237623012
borenet [Mon, 20 Jul 2015 16:43:36 +0000 (09:43 -0700)]
Split llvm_coverage_run into two scripts
... One for running to generate the coverage data, another to parse the data into various formats.
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/
1239963002
mtklein [Mon, 20 Jul 2015 14:14:19 +0000 (07:14 -0700)]
Clean up dead xfermode opts code.
Now that SK_SUPPORT_LEGACY_XFERMODES is unused, tons of code becomes dead.
Nothing is needed in opts/ anymore for x86.
We still do runtime NEON detection, which just duplicates Sk4pxXfermode.
TBR=reed@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1230023011
skia.buildbots [Sun, 19 Jul 2015 07:19:11 +0000 (00:19 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
NO_MERGE_BUILDS
Review URL: https://codereview.chromium.org/
1241073002
wangxianzhu [Sat, 18 Jul 2015 00:23:15 +0000 (17:23 -0700)]
Reland "SkPDF: Annotations are clipped by canvas clip stack."
Original patch was created by halcanary@google.com, and was reverted
because it triggered crbug.com/503541.
This patch fixes a bug in the original patch about clip path
transformation.
> Also, remove some SkPDFDevice functions.
> Will fix this GM: http://crrev.com/
1159273003
> BUG=skia:3872
> Review URL: https://codereview.chromium.org/
1148263005
BUG=skia:3872
BUG=503514
Review URL: https://codereview.chromium.org/
1238503007
caryclark [Fri, 17 Jul 2015 20:20:48 +0000 (13:20 -0700)]
make drawbitmaprect lighting lumafilter matrixconvolution srcmode gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1240843005
joshualitt [Fri, 17 Jul 2015 19:47:39 +0000 (12:47 -0700)]
adding unit test for textblob cache / GrBatchAtlas
BUG=skia:
Review URL: https://codereview.chromium.org/
1233253003
caryclark [Fri, 17 Jul 2015 16:39:16 +0000 (09:39 -0700)]
make arithmode bigtext colortype* degeneratesegments gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1235343004
joshualitt [Fri, 17 Jul 2015 16:09:23 +0000 (09:09 -0700)]
Some cleanups of VisualBench
BUG=skia:
Review URL: https://codereview.chromium.org/
1240633005
borenet [Fri, 17 Jul 2015 14:31:07 +0000 (07:31 -0700)]
llvm_coverage_build: Use CC and CXX variables by default
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/
1242573003
jvanverth [Fri, 17 Jul 2015 14:22:30 +0000 (07:22 -0700)]
Reland of Add fast normalize for SkLightingImageFilter. (patchset #1 id:1 of https://codereview.chromium.org/
1244523002/)
Reason for revert:
Florin will rebaseline the images.
Original issue's description:
> Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/
1240023002/)
>
> Reason for revert:
> Speculative revert -- DEPS roll block on linux_blink_rel
>
> https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html
>
> Original issue's description:
> > Add fast normalize for SkLightingImageFilter.
> >
> > The normalize routine in SkPoint3 is very robust. However, for simple
> > lighting cases we prefer speed over robustness. This fixes a perf
> > regression in smoothness.tough_filters_cases.
> >
> > BUG=chromium:510562
> >
> > Committed: https://skia.googlesource.com/skia/+/
dfa0ecf169db87f7afddd93bc1c500de481a62c7
>
> TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chromium:510562
>
> Committed: https://skia.googlesource.com/skia/+/
ac66a8122b27c388cc74b3913d9a9be351a44e54
TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:510562
Review URL: https://codereview.chromium.org/
1241583007
reed [Fri, 17 Jul 2015 14:09:43 +0000 (07:09 -0700)]
Revert[2] of guard to remove DrawBitmapRectFlags
This reverts commit
91110195a2eee170c11885da9d16f94b00a39f87.
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
1240753003
tfarina [Fri, 17 Jul 2015 14:07:25 +0000 (07:07 -0700)]
Add an entry in directory for BugChomper.
BUG=None
R=borenet@google.com
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1239803008
Review URL: https://codereview.chromium.org/
1239803008
ethannicholas [Fri, 17 Jul 2015 13:44:02 +0000 (06:44 -0700)]
No longer using non-antialiased fast path for lines when antialiasing is on.
BUG=skia:3776
Review URL: https://codereview.chromium.org/
1223323003
joshualitt [Fri, 17 Jul 2015 13:40:29 +0000 (06:40 -0700)]
Removing GrTemplates.h
BUG=skia:
Review URL: https://codereview.chromium.org/
1233923004
joshualitt [Fri, 17 Jul 2015 13:19:19 +0000 (06:19 -0700)]
Cleanup of GrFontDescKey
BUG=skia:
Review URL: https://codereview.chromium.org/
1238473004
scroggo [Fri, 17 Jul 2015 12:57:34 +0000 (05:57 -0700)]
Revert of guard to remove DrawBitmapRectFlags (patchset #1 id:1 of https://codereview.chromium.org/
1235393003/)
Reason for revert:
breaking android framework build
Original issue's description:
> guard to remove DrawBitmapRectFlags
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
6fb0b6779e40ce05c20cf279f0ecff31fa3cd60d
TBR=fmalita@chromium.org,djsollen@google.com,reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1230823007
reed [Thu, 16 Jul 2015 23:02:39 +0000 (16:02 -0700)]
Revert of Add fast normalize for SkLightingImageFilter. (patchset #2 id:20001 of https://codereview.chromium.org/
1240023002/)
Reason for revert:
Speculative revert -- DEPS roll block on linux_blink_rel
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/71483/layout-test-results/results.html
Original issue's description:
> Add fast normalize for SkLightingImageFilter.
>
> The normalize routine in SkPoint3 is very robust. However, for simple
> lighting cases we prefer speed over robustness. This fixes a perf
> regression in smoothness.tough_filters_cases.
>
> BUG=chromium:510562
>
> Committed: https://skia.googlesource.com/skia/+/
dfa0ecf169db87f7afddd93bc1c500de481a62c7
TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:510562
Review URL: https://codereview.chromium.org/
1244523002
senorblanco [Thu, 16 Jul 2015 22:19:11 +0000 (15:19 -0700)]
Now that the SkImageFilter::CropRect crop edges refer to
width & height, name them appropriately.
BUG=240827
Review URL: https://codereview.chromium.org/
1234873005
joshualitt [Thu, 16 Jul 2015 21:23:22 +0000 (14:23 -0700)]
Fix visual bench memory leak
BUG=skia:
Review URL: https://codereview.chromium.org/
1239103002
caryclark [Thu, 16 Jul 2015 21:16:04 +0000 (14:16 -0700)]
make glyph_pos imageblur* largeglyphblur portable
R=reed@google.com,bungeman@google.com
Review URL: https://codereview.chromium.org/
1243493003
joshualitt [Thu, 16 Jul 2015 20:40:51 +0000 (13:40 -0700)]
Small fix for visualbench
BUG=skia:
Review URL: https://codereview.chromium.org/
1237563005
reed [Thu, 16 Jul 2015 20:17:13 +0000 (13:17 -0700)]
refactor code to apply the croprect
BUG=skia:
Review URL: https://codereview.chromium.org/
1218993002
jvanverth [Thu, 16 Jul 2015 19:56:46 +0000 (12:56 -0700)]
Add fast normalize for SkLightingImageFilter.
The normalize routine in SkPoint3 is very robust. However, for simple
lighting cases we prefer speed over robustness. This fixes a perf
regression in smoothness.tough_filters_cases.
BUG=chromium:510562
Review URL: https://codereview.chromium.org/
1240023002
scroggo [Thu, 16 Jul 2015 19:36:10 +0000 (12:36 -0700)]
Stop running image tests on msaa.
Blacklist all image tests on msaa. We do not run them anyway (since
they will not do anything interestingly different from drawing to the
raster backend) - we early exit from Src::draw(), but we still need to
create a render target that matches the size of the image (when not
blacklisted).
Remove the more specific blacklist of a particular image, which is
covered by this one.
BUG=skia:4045
Review URL: https://codereview.chromium.org/
1234313006
caryclark [Thu, 16 Jul 2015 19:35:58 +0000 (12:35 -0700)]
make imagefilters* imagemagnifier imageresizetiled portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1238083004
bsalomon [Thu, 16 Jul 2015 17:00:28 +0000 (10:00 -0700)]
Revert of Remove rt flags that are not necessary (patchset #1 id:1 of https://codereview.chromium.org/
1226123012/)
Reason for revert:
breaks tests, e.g.
https://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nexus9-GPU-TegraK1-Arm64-Release/builds/752/steps/dm/logs/stdio
Original issue's description:
> Remove rt flags that are not necessary
>
> Committed: https://skia.googlesource.com/skia/+/
b6b0a6ef179f4143c94ba7e0e1be6e7ce4b0a23a
TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1234503004
bsalomon [Thu, 16 Jul 2015 16:34:57 +0000 (09:34 -0700)]
Remove rt flags that are not necessary
Review URL: https://codereview.chromium.org/
1226123012
joshualitt [Thu, 16 Jul 2015 16:13:50 +0000 (09:13 -0700)]
All batches do their own pipeline compare
BUG=skia:
Review URL: https://codereview.chromium.org/
1242033002
bsalomon [Thu, 16 Jul 2015 15:23:13 +0000 (08:23 -0700)]
Make readpixels work on GrTextures
Review URL: https://codereview.chromium.org/
1234313002
joshualitt [Thu, 16 Jul 2015 15:12:45 +0000 (08:12 -0700)]
Give GrBatch a pointer to GrPipeline
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
1170a12839218f7a23c93487bf95fd83aae0201f
Review URL: https://codereview.chromium.org/
1237283007
jvanverth [Thu, 16 Jul 2015 14:46:07 +0000 (07:46 -0700)]
Various GL testing fixes
Check for GL context when printing NVPR error string.
Fix some indenting.
Review URL: https://codereview.chromium.org/
1235283004
reed [Thu, 16 Jul 2015 14:40:45 +0000 (07:40 -0700)]
have canvas send discard instead of retain if the draw would overwrite everything
Motivation:
- perf win for clients that overwrite the surface after a snapshot.
- may allow us to eliminate SkDeferredCanvas, as this was its primary advantage.
BUG=skia:
Review URL: https://codereview.chromium.org/
1236023004
joshualitt [Thu, 16 Jul 2015 14:16:53 +0000 (07:16 -0700)]
Revert of Give GrBatch a pointer to GrPipeline (patchset #1 id:1 of https://codereview.chromium.org/
1237283007/)
Reason for revert:
breaking nanobench
Original issue's description:
> Give GrBatch a pointer to GrPipeline
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
1170a12839218f7a23c93487bf95fd83aae0201f
TBR=bsalomon@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1239073002
joshualitt [Thu, 16 Jul 2015 14:06:50 +0000 (07:06 -0700)]
Give GrBatch a pointer to GrPipeline
BUG=skia:
Review URL: https://codereview.chromium.org/
1237283007
caryclark [Thu, 16 Jul 2015 14:06:46 +0000 (07:06 -0700)]
increase gm offsetimagefilter stroke width
With a hairline width, offsetimagefilter fails to draw the
rectangle on some platforms. Make the width 2 so that it
shows up everywhere.
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1236133003
borenet [Thu, 16 Jul 2015 14:01:44 +0000 (07:01 -0700)]
Coverage script: fix missing data
BUG=skia:2430
Review URL: https://codereview.chromium.org/
1242023002
mtklein [Thu, 16 Jul 2015 14:01:39 +0000 (07:01 -0700)]
Replace buggy_blend_modes GM with an exhaustive test.
The new test is disabled by default, as it's quite slow.
We can run it if we suspect problems by passing -x to DM.
This test would have been failing before the bug fix, and now is passing.
Assuming the Priv on the end means it's not considered public API...
TBR=reed@google.com
BUG=skia:4052
Review URL: https://codereview.chromium.org/
1228333003
reed [Thu, 16 Jul 2015 13:10:02 +0000 (06:10 -0700)]
guard to remove DrawBitmapRectFlags
BUG=skia:
Review URL: https://codereview.chromium.org/
1235393003
caryclark [Wed, 15 Jul 2015 21:23:50 +0000 (14:23 -0700)]
make *imagefilter morphology iamge bitmapsource gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1236403002
caryclark [Wed, 15 Jul 2015 21:03:12 +0000 (14:03 -0700)]
make strokefill gm portable
Convert the Mac-specific font text statically into
paths so that they draw the same on all platforms.
Add drawing portable text using the fake bold paint
setting so that the code path is tested everywhere
and but draws the same thing.
R=reed@google.com
Review URL: https://codereview.chromium.org/
1234463006
reed [Wed, 15 Jul 2015 20:42:32 +0000 (13:42 -0700)]
rename utility to see if a paint will overwrite its pixels
BUG=skia:
Review URL: https://codereview.chromium.org/
1228853005
wangyix [Wed, 15 Jul 2015 19:26:07 +0000 (12:26 -0700)]
Added GLVec4ScalarBench that doesn't use VAOs
BUG=skia:
Review URL: https://codereview.chromium.org/
1235153008
caryclark [Wed, 15 Jul 2015 18:57:00 +0000 (11:57 -0700)]
make gradtext quadpaths gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1234233003
bungeman [Wed, 15 Jul 2015 18:29:25 +0000 (14:29 -0400)]
Fix leak in Android FontMgr test.
FontMgrAndroidParserTest deos not free the font families it creates.
This issue was discovered by asan when enabling this test on Linux
platforms.
bungeman [Wed, 15 Jul 2015 17:58:47 +0000 (10:58 -0700)]
Allow Android font manager on *nix.
There is nothing left in the SkFontMgr_android.cpp which is specific
to Android, so allow it to be built and used on *nix platforms. This
allows for easier development and testing.
The only reason to limit to *nix platforms are the dependencies on
Expat and FreeType. This should be buildable and runnable on other
platforms when these dependencies are also available.
Review URL: https://codereview.chromium.org/
1228833003
joshualitt [Wed, 15 Jul 2015 17:17:20 +0000 (10:17 -0700)]
Fix for android command line arguments to VisualBench
BUG=skia:
Review URL: https://codereview.chromium.org/
1241923002
jvanverth [Wed, 15 Jul 2015 17:16:56 +0000 (10:16 -0700)]
Only run test_wrapped_resources() when GL is active
Review URL: https://codereview.chromium.org/
1234233002
bsalomon [Wed, 15 Jul 2015 17:12:16 +0000 (10:12 -0700)]
Don't upload texture smaller than the min texture size when stretching a bmp up to a POT
BUG=skia:3932
Review URL: https://codereview.chromium.org/
1238913002
caryclark [Wed, 15 Jul 2015 16:29:32 +0000 (09:29 -0700)]
make colorwheelnative displacement dropshadowimagefilter getposttextpath gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1237233004
caryclark [Wed, 15 Jul 2015 15:58:12 +0000 (08:58 -0700)]
make path-reverse gm portable
Put font glyph data in test as path
instead of getting data from the Mac
font. THe font may change, and is
not available on most platforms.
Also remove unreachable code.
R=reed@google.com
Review URL: https://codereview.chromium.org/
1230703005
joshualitt [Wed, 15 Jul 2015 15:38:02 +0000 (08:38 -0700)]
Match works correctly on visualbench
BUG=skia:
Review URL: https://codereview.chromium.org/
1234123004
halcanary [Wed, 15 Jul 2015 15:06:29 +0000 (08:06 -0700)]
experimental: remove old PDF benchmarking tools
TBR=
Review URL: https://codereview.chromium.org/
1233093004
borenet [Wed, 15 Jul 2015 14:43:06 +0000 (07:43 -0700)]
llvm-coverage script: respect SKIA_OUT
NOTRY=true
BUG=skia:2430
Review URL: https://codereview.chromium.org/
1239803002
herb [Wed, 15 Jul 2015 14:40:37 +0000 (07:40 -0700)]
Fix undefined behavior.
BUG=skia:4050
Review URL: https://codereview.chromium.org/
1232003008
yang.zhang [Wed, 15 Jul 2015 14:07:30 +0000 (07:07 -0700)]
Optimize RGB16 blitV functions with NEON for ARM platform.
Here are some performance resultsi on Nexus 9:
SkRGB16BlitterBlitV_neon:
+--------+-----------+
|height | C/NEON |
+--------+-----------+
|1 | 0.765230 |
+--------+-----------+
|8 | 1.273330 |
+--------+-----------+
|18 | 1.441462 |
+--------+-----------+
|32 | 1.627798 |
+--------+-----------+
|76 | 1.683131 |
+--------+-----------+
|85 | 1.679456 |
+--------+-----------+
|120 | 1.721311 |
+--------+-----------+
|128 | 1.725482 |
+--------+-----------+
|512 | 1.784117 |
+--------+-----------+
BUG=skia:
Review URL: https://codereview.chromium.org/
1213723002
scroggo [Wed, 15 Jul 2015 13:36:42 +0000 (06:36 -0700)]
Revert of Added a GLBench for testing performance of vec4 vs scalar for coverage in generated shaders. (patchset #6 id:90001 of https://codereview.chromium.org/
1225383002/)
Reason for revert:
Still failing on Windows. e.g. https://uberchromegw.corp.google.com/i/client.skia/builders/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-ANGLE/builds/231/steps/nanobench/logs/stdio
skbug.com/4053
Original issue's description:
> Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders.
>
> Added bench for timing vec4 vs scalar type for coverage in shaders
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
6104ced165f17eb2f765ace354d5895c0bc890c5
>
> Committed: https://skia.googlesource.com/skia/+/
c734e69e8cf94bacaf68d3d8ee3310d1ad1fe8b8
TBR=joshualitt@google.com,tomhudson@google.com,wangyix@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1239503003
joshualitt [Wed, 15 Jul 2015 13:18:57 +0000 (06:18 -0700)]
Fix VisualBench to hold onto a surface
BUG=skia:
Review URL: https://codereview.chromium.org/
1236723003
caryclark [Wed, 15 Jul 2015 13:18:47 +0000 (06:18 -0700)]
make linepaths gm portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1225303010
caryclark [Wed, 15 Jul 2015 12:43:38 +0000 (05:43 -0700)]
remove funkster from dcshader gm
The multicolored font that funster enables
only draws and measures on some platforms.
Removing it from the dcshader gm allows
the layout to be uniform on all devices,
making it easier to compare the output
in gold.
TBR=bsalomon@google.com
Review URL: https://codereview.chromium.org/
1231853004
rmistry [Wed, 15 Jul 2015 11:40:54 +0000 (04:40 -0700)]
Document new CQ keyword
BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
1237693005
TBR=jcgregorio
Review URL: https://codereview.chromium.org/
1237693005
msarett [Tue, 14 Jul 2015 21:39:59 +0000 (14:39 -0700)]
Fixed valgrind issues with libjpeg-turbo
The fixes are in the updated libjpeg-turbo repository
pulled in by DEPS. The fixes are detailed in the linked
skia bug. To summarize briefly, we now use calloc()
instead of malloc().
BUG=skia:4030
Review URL: https://codereview.chromium.org/
1237213004
fmalita [Tue, 14 Jul 2015 21:15:08 +0000 (14:15 -0700)]
Updated PDFViewer drawImageRect() overrides
R=reed@google.com
Review URL: https://codereview.chromium.org/
1240573008
scroggo [Tue, 14 Jul 2015 20:59:10 +0000 (13:59 -0700)]
Let Android use old version of onDrawBitmapRect.
Define SK_SUPPORT_LEGACY_ONDRAWIMAGERECT when building for the
Android framework, since SkiaCanvasProxy overrides the old version
of the method.
Fixes master-skia build.
NOTRY=True
Review URL: https://codereview.chromium.org/
1237903002
mtklein [Tue, 14 Jul 2015 20:38:28 +0000 (13:38 -0700)]
Fix buggy blend modes.
The problem turns out to be not over- or underflow like I thought, but that I used different math for x*y/255 for alphas and colors, sometimes resulting in colors where alpha was one less than the maximum color component, which is not a valid SkPMColor.
To be safe, I've switched over all four of these similar complex modes to use exact math everywhere. They now match the byte-by-byte code in SkXfermode.cpp exactly.
This will slow down Darken and Lighten by about 2x. I plan to follow up with a CL to see if I can eek out some speed there, and another CL to add asserts that Sk4px code always writes valid SkPMColors.
BUG=skia:4052
Review URL: https://codereview.chromium.org/
1241683003
fmalita [Tue, 14 Jul 2015 20:12:25 +0000 (13:12 -0700)]
Preserve SKP cullrects on deserialization
Let's not ignore the offset.
R=reed@google.com,mtklein@google.com
Review URL: https://codereview.chromium.org/
1235953004
caryclark [Tue, 14 Jul 2015 18:19:26 +0000 (11:19 -0700)]
Very tiny paths are subsumed by the Convexicator
and are treated as convex when they are not.
Allow the SkPath::Iter to leave degenerate path
segments unmolested by passing an additional exact
bool to next().
Treat any non-zero length as significant in addPt().
R=reed@google.com,robertphillips@google.com
BUG=493450
Review URL: https://codereview.chromium.org/
1228383002
joshualitt [Tue, 14 Jul 2015 18:07:53 +0000 (11:07 -0700)]
Remove GrRedBlackTree
BUG=skia:
Review URL: https://codereview.chromium.org/
1226203013
jvanverth [Tue, 14 Jul 2015 18:02:52 +0000 (11:02 -0700)]
Rename backing texture testing routines
Review URL: https://codereview.chromium.org/
1230193006
joshualitt [Tue, 14 Jul 2015 18:02:45 +0000 (11:02 -0700)]
Another trivial cleanup
TBR=bsalomon@google.com
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
52e7657cd850f95e66eb23c6d138ee45149a1039
Review URL: https://codereview.chromium.org/
1229303003
djsollen [Tue, 14 Jul 2015 17:59:28 +0000 (10:59 -0700)]
Disable optimization as HWUI does not yet support color shaders.
Review URL: https://codereview.chromium.org/
1235913005
kkinnunen [Tue, 14 Jul 2015 17:59:23 +0000 (10:59 -0700)]
Implement support for CHROMIUM_path_rendering pseudo extension
Implement support for path rendering in Chromium through
CHROMIUM_path_rendering pseudo extension.
The extension defines a new pseudo-gl function,
BindFragmentInputLocation. This behaves similarly to the
BindUniformLocation pseudo-gl function. The idea is to assign fragment
input location to a fragment input before linking the program.
BUG=chromium:344330
Committed: https://skia.googlesource.com/skia/+/
eeef46d181f9f8db388ecea81df699fc1b3c9280
Review URL: https://codereview.chromium.org/
1192663002
mtklein [Tue, 14 Jul 2015 17:54:19 +0000 (10:54 -0700)]
3-15% speedup to HardLight / Overlay xfermodes.
While investigating my bug (skia:4052) I saw this TODO and figured
it'd make me feel better about an otherwise unsuccessful investigation.
This speeds up HardLight and Overlay (same code) by about 15% with SSE, mostly
by rewriting the logic from 1 cheap comparison and 2 expensive div255() calls
to 2 cheap comparisons and 1 expensive div255().
NEON speeds up by a more modest ~3%.
BUG=skia:
Review URL: https://codereview.chromium.org/
1230663005
reed [Tue, 14 Jul 2015 17:54:12 +0000 (10:54 -0700)]
add src-rect-constraint to drawImageRect
Follow-on work
- unify around SrcRectConstraint (i.e. drawBitmapRect)
- remove silly drawBitmapRectToRect alias
- clean-up (possibly remove) alias problems around drawBitmapRect + IRect parameter
BUG=skia:
Review URL: https://codereview.chromium.org/
1228083004
mtklein [Tue, 14 Jul 2015 12:52:52 +0000 (05:52 -0700)]
Add a GYP flag to define SKNX_NO_SIMD when set.
Will use this with a new -SKNX_NO_SIMD bot.
BUG=skia:
Review URL: https://codereview.chromium.org/
1227163016
mtklein [Tue, 14 Jul 2015 12:23:50 +0000 (05:23 -0700)]
Fix typo in non-SIMD Sk4f::thenElse().
This was causing the 3 xfermodes that use floats and conditionals
to draw wrong when SKNX_NO_SIMD was defined.
BUG=skia:4051
Review URL: https://codereview.chromium.org/
1229013003
joshualitt [Mon, 13 Jul 2015 20:29:13 +0000 (13:29 -0700)]
Revert of Another trivial cleanup (patchset #6 id:100001 of https://codereview.chromium.org/
1229303003/)
Reason for revert:
breaking things
Original issue's description:
> Another trivial cleanup
>
> TBR=bsalomon@google.com
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
52e7657cd850f95e66eb23c6d138ee45149a1039
TBR=robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1233853004
robertphillips [Mon, 13 Jul 2015 20:16:44 +0000 (13:16 -0700)]
Add new SkPoint3 class
The existing Light filter and the upcoming Lighting Shader both need a Point3 class
Review URL: https://codereview.chromium.org/
1229693009
joshualitt [Mon, 13 Jul 2015 20:11:40 +0000 (13:11 -0700)]
Another trivial cleanup
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
1229303003
wangyix [Mon, 13 Jul 2015 20:09:17 +0000 (13:09 -0700)]
Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders.
Added bench for timing vec4 vs scalar type for coverage in shaders
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
6104ced165f17eb2f765ace354d5895c0bc890c5
Review URL: https://codereview.chromium.org/
1225383002
joshualitt [Mon, 13 Jul 2015 19:49:13 +0000 (12:49 -0700)]
Get rid of GrMurmur3Hash
BUG=skia:
Review URL: https://codereview.chromium.org/
1233933002
caryclark [Mon, 13 Jul 2015 19:08:45 +0000 (12:08 -0700)]
use portable typeface
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1235873004
mtklein [Mon, 13 Jul 2015 19:06:33 +0000 (12:06 -0700)]
Add a GM that reproduces layout test failures with my new xfermode code.
Inspired by https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/69169/layout-test-results/results.html
I think the root cause is overflow.
Also, adds tests for Sk16b::operator<(). It wasn't wrong, but it was suspect
(used in all three of these xfermode implementations) and so it's best to have
tests.
BUG=skia:
Review URL: https://codereview.chromium.org/
1228393006
scroggo [Mon, 13 Jul 2015 19:03:39 +0000 (12:03 -0700)]
Revert of Added a GLBench for testing performance of vec4 vs scalar for coverage in generated shaders. (patchset #4 id:40002 of https://codereview.chromium.org/
1225383002/)
Reason for revert:
This is breaking a buildbot. See https://chromegw.corp.google.com/i/client.skia/builders/Test-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Debug-ANGLE/builds/172/steps/nanobench/logs/stdio
We get the following error: ERROR::SHADER::COMPLIATION_FAILED: ERROR: 0:8: '0.f' : Floating-point suffix unsupported prior to GLSL ES 3.00
ERROR: 0:8: '0.f' : syntax error
Original issue's description:
> Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders.
>
> Added bench for timing vec4 vs scalar type for coverage in shaders
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
6104ced165f17eb2f765ace354d5895c0bc890c5
TBR=joshualitt@google.com,tomhudson@google.com,wangyix@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
1235533004
wangyix [Mon, 13 Jul 2015 17:46:34 +0000 (10:46 -0700)]
Added a glBench for testing performance of vec4 vs scalar coverage in generated shaders.
Added bench for timing vec4 vs scalar type for coverage in shaders
BUG=skia:
Review URL: https://codereview.chromium.org/
1225383002
senorblanco [Mon, 13 Jul 2015 17:27:05 +0000 (10:27 -0700)]
Fix for partially-specified crop rects.
When only the left or top edge of a crop rect is given, the
right and bottom should be computed based on the incoming width
and height, not based on the crop rect's width & height. This
complies more accurately with SVG semantics.
BUG=240827
Review URL: https://codereview.chromium.org/
1232873002
joshualitt [Mon, 13 Jul 2015 16:36:41 +0000 (09:36 -0700)]
small cleanups after fixing const of GrPipelineBuilder on DrawTarget
Fuse AutoRestoreFragmentProcessors and AutoRestoreProcessorDataManager into new AutoRestoreFragmentProcessorState class
BUG=skia:
Review URL: https://codereview.chromium.org/
1228763005
joshualitt [Mon, 13 Jul 2015 16:29:42 +0000 (09:29 -0700)]
Add GrNonAtomicRef
BUG=skia:
Review URL: https://codereview.chromium.org/
1238523002
ethannicholas [Mon, 13 Jul 2015 15:51:36 +0000 (08:51 -0700)]
reenabled GrAALinearizingConvexPathRenderer, but only for stroked paths
Review URL: https://codereview.chromium.org/
1237693002
joshualitt [Mon, 13 Jul 2015 15:44:06 +0000 (08:44 -0700)]
ovals now take a const GrPipelineBuilder
BUG=skia:
Review URL: https://codereview.chromium.org/
1232163002
caryclark [Mon, 13 Jul 2015 15:19:58 +0000 (08:19 -0700)]
make gm text and colors portable
TBR=reed@google.com
Review URL: https://codereview.chromium.org/
1236893002