Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I6ca6dbc9b10c6a6ab76bae3c9f2593be1f9f811e

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ia7e33918ec57b26ca43a9b8468bc134c15ea9915

Fix colorAttachmentCount mismatch in stencil tests

pColorBlendState::attachmentCount must match colorAttachmentCount of the
subpass used in the pipeline

Components: Vulkan

VK-GL-CTS issue: 4229

Affected tests:
dEQP-VK.pipeline.*.stencil.*

Change-Id: I1656cda0af45ae3df65c25790e360a17863273d4

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ib94de3bf6ded8ac215a706e0005631d397fce704

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Ic6015e95ad8e7d411948ec7ef1ccaf33081212f7

Fix rgba10x6 feature check in texture filtering tests

If VK_IMAGE_USAGE_SAMPLED_BIT is used when creating the image
VkSamplerYcbcrConversionInfo is required in the pNext chain, if format
is  VK_FORMAT_R10XgG10X6B10X6A10X6_UNORM_4PACK16 and
formatRgba10x6WithoutYCbCrSampler feature is not enabled

Components: Vulkan

VK-GL-CTS issue: 4206

Affected tests:
dEQP-VK.texture.filtering.*

Change-Id: I296ac69902f87b301f4e2930d28b171e8ce02a13

Add missing support check in texture filtering with rgba10x6 format

Feature formatRgba10x6WithoutYCbCrSampler must be enabled when
VK_FORMAT_R10X6G10X6B10X6A10X6_UNORM_4PACK16 is used in these tests,
because more than 1 mip level is used and only formats which do not
require sampler YCbCR conversion can be used

Components: Vulkan

VK-GL-CTS issue: 4205

Affected tests:
dEQP-VK.texture.filtering.cube.*

Change-Id: I3bdd286af2d0f2c19443e5d64304c69e43a43095

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I29ea16db0e7ddc2b374888f41ed07523b233aedb

Fix image barrier in ray tracing pipeline build tests

Use the correct combination of access mask and pipeline stage

Components: Vulkan

VK-GL-CTS issue: 4202

Affected tests:
dEQP-VK.ray_tracing_pipeline.build.*

Change-Id: I185c3787b6bfa24c79f5fbd063fc041d000ae0f4

Do not allow to call vkSetEvent after submission, which is invalid.

The spec says:

"If a command buffer submission waits for any events to be signaled,
the application must ensure that command buffer submissions will be
able to complete without any subsequent operations by the application.
Events signaled by the host must be signaled before the command buffer
waits on those events."

This means it's not valid to signal an event on the host after submission
of a command buffer containing a wait for the event. Also it forces the
command buffer to stop for an unknown amount of time, as much as the time
needed for the host to signal the event with vkSetEvent.

However there were some CTS tests doing like this, which should be
fixed.

For vktApiExternalMemoryTests.cpp,
There was a vkSetEvent call after submission to hold a command to be
executed before signaling to get a native file descriptor, which is
not valid. So the tests should allow to get -1. Also we do an atomic calculation
to avoid singalling right after submit when trying to get a native fd.
The simple atomic calculation is evaluated to take about 10ms.

For vktApiExternalMemoryTests.cpp and vktMemoryExternalMemoryHostTests.cpp,
replace vkSetEvent with timeline semaphore to signal from the host.

Affects:
dEQP-VK.api.external.semaphore.*
dEQP-VK.api.external.fence.*
dEQP-VK.api.command_buffers.secondary_execute_twice
dEQP-VK.memory.external_memory_host.synchronization.synchronization

VK-GL-CTS Issue: 4075

Components: Vulkan
Change-Id: I5544bb15a418bbbbd6552ca04bec673a56ca3109

Add missing buffer memory flush

We do a memcpy to the buffer, but don't flush it. If we don't use
host-coherent memory for this buffer it might sometimes lead to
corruption (when we later invalidate the buffer's memory to get
results from the shader).

Components: Vulkan

Affected tests:
dEQP-VK.query_pool.statistics_query.compute_shader_invocations.*
dEQP-VK.query_pool.statistics_query.*.compute_shader_invocations.*

Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Change-Id: I2f9491d6cacf39fe6a00d7624e2aa474615421ce

Use correct extent for 1D compute texel_view_compatible tests

We weren't sanitizing the size in the parameters, resulting in
copyDataToImage() passing an extent with a non-1 height to when
uploading to a 1D image. Sanitize fullSize, and remove a case where
where we were workaround it not being sanitized.

Components: Vulkan

Affects: dEQP-VK.image.texel_view_compatible.compute.basic.1d_image.*

VK-GL-CTS Issue: 4143

Change-Id: Icdb50c09137a947f47b1afc7426e53e73c31f689

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I45389a45424b0978ce6ac4b08108717c486e1bee

Added missing android hardware buffer formats

Android hardware buffer formats are added in image compression
control test. Also, updated the test names.

Components: Vulkan
VK-GL-CTS issue: 3883

Affects:
dEQP-VK.api.image_compression_control.android_hardware_buffer.*

Change-Id: I39643d186200d63a81cff2eb244bbdf085954a03

ycbcr: Align properly offset used for BindImageMemory2

The test is using directly the requirements size, but it should be
ensure that is aligned to the requirements alignment.

Components: Vulkan

VK-GL-CTS Issue: 4223

Affects:
dEQP-VK.ycbcr.subresource_offset.*

Change-Id: I219fb38704ac3b2c0bd6d4f9afbde6d2265e1be6

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I63428d6dfccd323392ff975aef0a1a3ace0f52da

Allow sample mask test after sample counting

After vulkan!5640 it is now legal for sample mask test to be executed
after sample counting when Early Fragment Tests is enabled.

Update the early fragment tests with sample counting to allow for this
behaviour by reporting a Quality Warning if the sample mask is ignored
when calcuating the returned sample count.

Affects: dEQP-VK.fragment_operations.early_fragment.sample_count_early_fragment_tests_depth_*

Components: vulkan

VK-GL-CTS issue: 4218

Change-Id: I61ca28f6570e1835b19c03ae1b1d93cad0228190

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: Ie8b2a9e9b203ff93bd2c6f30c796bf6f560a9c40

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Iaa91df30fc4231c3a428fef1c74c8d9aa72720ba

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I40db0dabbedb2e8245c3597bec80832a47f1658d

Fix merge error in FSR srlayered tests

Reapply last chunk from 853897a8722 which seems to
have been broken in a merge: layercount value was passed
instead of viewFormatCount.

This is fixes a regression introduced by  10618, which was exposed
after being promoted to vulkan-cts-1.2.8+.

Components: Vulkan

VK-GL-CTS Issue: 4224
VK-GL-CTS Issue: 4226

Affects: dEQP-VK.fragment_shading_rate.*
Change-Id: Ib8f5b180368fe9bf3c32f349c2475a4932f30fbf

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Iaae2490f0ec3069759a7660dee175cfdc3668622

Update scripts for Android build

 - Use d8 instead of dx due to deprecation
 - Use apksigner instead of jarsigner for signature scheme v2 required by newer SDKs
 - Move apk signing to be last step (required for signature scheme v2)
 - Force uncompressed arsc files (required for SDK versions 30 and up)
 - Add '--tool-api' argument for selecting build tools version
 - Add permission for reading external storage in manifest

VK-GL-CTS Issue: 4163

Components: Framework
Change-Id: Iea4429f861148168ffe680cdf9a497cb467b8d6a

Fix merge mistake related to android/*/*.txt files

In recent merge from 1.3.1 to 1.3.2 branch a mistake was made
that affected five android related txt files. This change
restores those files to content before the merge.

Components: Vulkan

VK-GL-CTS issue: 4228

Removed tests:
dEQP-VK.*

Change-Id: I51cb8a3869883621edd8e3af4c2863adfd8739ba

Remove tests that use DS format in inheritance info, but have no depth attachment in vkCmdBeginRendering

Remove test cases, that target functionality that is against following spec wording:

"""
If vkCmdExecuteCommands is being called within a render pass instance begun with vkCmdBeginRendering and the
VkRenderingInfo::pDepthAttachment->imageView parameter to vkCmdBeginRendering was VK_NULL_HANDLE, the value of the  >
depthAttachmentFormat member of the VkCommandBufferInheritanceRenderingInfo structure included in the pNext chain of
VkCommandBufferBeginInfo::pInheritanceInfo used to begin recording each element of pCommandBuffers must be VK_FORMAT_UNDEFINED
"""

VK-GL-CTS Issue: 4160

Components: Vulkan

Affects: dEQP-VK.dynamic_rendering.partial_secondary_cmd_buff.*.unused_clear_attachments

Change-Id: Ia67e0e7115dc69e55544c5de60b9a4ed6c17f60c

Remove OpImage*Dref* from mismatch type tests

Mismatch type group testing non-depth formats and using
OpImage*Dref* instructions with vulkan formats not having depth
component is invalid usage.

Extending the mismatch test type group to include depth/stencil
format later would require checking format features for
VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_DEPTH_COMPARISON_BIT

Components: Vulkan

Affects: dEQP-VK.spirv_assembly.instruction.graphics.image_sampler.*

VK-GL-CTS issue: 4172

Change-Id: I2353e235295cff4609799e14298e6df7d6a66221

Fix layer count in barriers in shader_layer tests

Some barriers only transition the first layer of the image, instead of
all the layers used

Components: Vulkan

VK-GL-CTS issue: 4191

Affected tests:
dEQP-VK.draw.dynamic_rendering.*.shader_layer.*

Change-Id: I35d78b4575d450fbd7c3718ff2a639316f6113e4

Fix stencilAttachmentFormat in dynamic render clear tests

The format in VkPipelineRenderingCreateInfo::stencilAttachmentFormat
must have a stencil aspect or be VK_FORMAT_UNDEFINED

Components: Vulkan

VK-GL-CTS issue: 4192

Affected tests:
dEQP-VK.draw.dynamic_rendering.*.load_clear_draw*

Change-Id: Ib0f055dd5ce49f5a2dff797274d5a243c46e8619

Add missing flags in dynamic rendering with secondary cmd buffers tests

If vkCmdExecuteCommands is called within a dynamic render pass,
VkRenderingInfo::flags must include
VK_RENDERING_CONTENTS_SSECONDARY_COMMAND_BUFFERS_BIT

Components: Vulkan

VK-GL-CTS issue: 4194

Affected tests:
dEQP-VK.draw.dynamic_rendering.*.differing_interpolation.*

Change-Id: Ib8e3fa1e3144a6847a87dbf1542912c5c179e903

Fix tests that enable depth testing on undefined depth buffer

There are tests in the load_store_op_none category set up like this:

Depth load: NONE
Depth store: NONE
Depth testing: ON
Depth op: GREATER
Depth write: OFF

This configuration is bogus because the depth buffer will be
undefined as this particular test won't initialize the render
area inside the render pass and it enabled depth testing
with a comparison function that depends on the contents of the
depth buffer.

Fix it by detecting this scenario and making the depth comparison
ALWAYS to ensure that depth testing doesn't drop any samples,
which is what the test expects.

Affects:
dEQP-VK.*.load_store_op_none.depth*

Components: Vulkan
VK-GL-CTS issue: 4209

Change-Id: Icab24dcf7f46156b7b59541ea64e5823deec53d1

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I17cf242ff0a054151c0af294fdfb84646e743244

Use tolerance for comparison in linear interpolation tests.

Components: Vulkan
VK-GL-CTS issue: 4159

Affected tests:
dEQP-VK.draw.*.linear_interpolation.*

Change-Id: I026bb0128dc78ddab75cbfdcaabab00a8d05386a

Fix memory offset in dedicated_allcation tests

When dedicated allocation is used, memory offset must be 0

Components: Vulkan

VK-GL-CTS issue: 4195

Affected tests:
dEQP-VK.api.copy_and_blit.dedicated_allocation.*

Change-Id: I3bee6c17e7de2ee8bae5f218df9d2e03dc37689d

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I7cfcfe8c9e3549a509420cbe1b63d089b3ee00dc

Fix color blend state in multisample mixed count tests

Some test variants were passing a null color blend attachment state on
pipeline creation, when the subpass was being created with one color
attachment.

Affects:
dEQP-VK.pipeline.*.multisample.mixed_count.*

VK-GL-CTS issue: 4208
Components: Vulkan

Change-Id: I9e0c7a5be907baef3c2b7bb6286d92eaa6749a66

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I8ca4c0773084ff7b66bf7378ee9b610c693f15c6

Fix bind-transfer synchronization in sparse texture tests

The copyBufferToImage() utility function submits a command buffer with a
copy-buffer-to-image transfer operation. The caller can optionally pass
a semaphore for the transfer to wait on, but the semaphore's wait flags
are set to VK_PIPELINE_STAGE_ALL_GRAPHICS_BIT, which does not include
transfer operations.

As a consequence of this, the transfer operation may ignore the wait
semaphore. In the affected test set this means that the transfer may
happen before sparse bind operations are completed.

Affects: dEQP-VK.texture.*sparse*

Components: Vulkan

VK-GL-CTS issue: 4183

Change-Id: Ia0f0c721e492703301440dbfcf07ed6495fddb1e

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Icc5dc1c0cbfd798e6df0e7b88d4830e1549a4126

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I2142832024febea1baee33b1df04af6921edb846

Remove duplicated test groups

While adding support for dynamic rendering to renderpass group
a mistake was made that added 3 groups with the same tests to both
renderpass2 group and legacy renderpass group.

This mistake was fixed on 1.3.1 branch but is present on 1.2.8
and 1.3.0. There is no need to execute same tests twice - this
change removes duplicates. This fix should be propagated only to
1.3.0.

Components: Vulkan

VK-GL-CTS issue: 4225

Removed tests:
dEQP-VK.renderpass.depth_stencil_resolve.*
dEQP-VK.renderpass.fragment_density_map.*
dEQP-VK.renderpass2.multiple_subpasses_multiple_command_buffers.test

Change-Id: I571e499ead038acf1744c356b884f2be966e3c15

Fix oldLayout in image barriers in copy and blit tests

The same barriers are used twice, but the oldLayout is not updated

Components: Vulkan

VK-GL-CTS issue: 4054

Affected tests:
dEQP-VK.api.copy_and_blit.*

Change-Id: I8fd622846a2c9ce840ec6bfb5a431ae66a5af06f

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I1139cfa0a1d27a08bd6d3c72b2d65fd754edc886

Remove invalid separate_layouts tests on older branches

These tests were fixed, but only on 1.3.2 newer, they should be removed
on older branches

Components: Vulkan

VK-GL-CTS issue: 3527

Removed tests:
dEQP-VK.renderpass2.depth_stencil_resolve.*separate_layouts.*

Change-Id: I467ea14cc5c2eb26723cc9e2453ea5a11a1556b9

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: If8b58ba0befe6c8e2beb9a1867656da231a6cf87

Require sampleRateShading in multisample linear interpolation tests

While these tests normally set sampleShadingEnable to VK_FALSE, their
shaders enable the SampleRateShading capability, which means
sampleRateShading is required to run them.

Affects:
dEQP-VK.draw.*.linear_interpolation.*

VK-GL-CTS issue: 4167
Components: Vulkan

Change-Id: I52f9f81b13186d2b152f46ecadbc73455ffbf063

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I467e6a22adfe0bd549a37378b9eee8220859d0e0

Make depth_bias_triangle_list_point write to PointSize

VK-GL-CTS Issue: 4197
Components: Vulkan

Affect tests:
dEQP-VK.draw.renderpass.depth_bias.depth_bias_triangle_list_point

Change-Id: I21c223ff1e986c48fc90f97d21d472cfa713abdf

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I1ed2965c43158b0131f340237dbebfcf5b2aaf5f

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Ie8e4ee5b77cbea1aa87664a38a074f2381d2ea15

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I7507fe1cee9b7bccdbfc4883f0ee6937c116b30a

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Iea24c631e95fad0dbf694e67f141c243fda3a3d9

Fix 2d image views in fragment shading rate tests

If viewType is VK_IMAGE_VIEW_TYPE_2D then subresourceRange.layerCount
must be 1

Components: Vulkan

VK-GL-CTS issue: 4124

Affected tests:
dEQP-VK.fragment_shading_rate.*

Change-Id: I32db55ce0785a2d91c391625bfed312d5e7371f0

Fix src stage value in pipeline barrier used to init resolve images

srcStage cannot be 0 it synchronization2 feature is not explicitely
required (enabled) by the test.

Components: Vulkan

VK-GL-CTS Issue: 3949

Change-Id: I66d3b5b55ca3732ede7284a010a68841c0a04275
Affects: dEQP-VK.pipeline.*.multisample.misc.dynamic_rendering.*

Allow 0 creation duration for pipeline libraries without shaders

Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*

VK-GL-CTS Issue: 4130

Components: Vulkan
Change-Id: Iebdeb76d30d4144ccba83c7d3ad4de7f269552c8

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I473fdbb6258063ddc4b07598519f9212cf4850ef

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: I5b755219964c807f381973f14ad15f7806eb44ab

Add randomized constants to shaders in compare_link_times test

Add some randomization to shaders in compare_link_times test
to get reproductible compilation times.

VK-GL-CTS Issue: 4109

Components: Vulkan

Affects:
dEQP-VK.pipeline.pipeline_library.graphics_library.misc.timing.compare_link_times

Change-Id: Idbd38d611edc955916b2c756115702cccd16a7d8

Fix invalid framebuffer in compressed texture 3D tests

Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D

Components: Vulkan

VK-GL-CTS issue: 4118

Affected tests:
dEQP-VK.texture.compressed_3D.*

Change-Id: I221fcc033266f8c344079f9ee9b1fa70c56d9dd9

Fix stencil op in depth bounds tests

If stencil attachment is in a read only layout and stencil test is
enabled, the stencil ops in VkPipelineDepthStencilStateCreateInfo must
be VK_STENCIL_OP_KEEP

Components: Vulkan

VK-GL-CTS issue: 4155

Affected tests:
dEQP-VK.dynamic_state.*.ds_state.depth_bounds_2*

Change-Id: Ifeb2ddca71e5cbd60afebd8d8b6dd77b5e7f2e9b

Fix result image format in RT pipeline flags test

Tests were using an rgba32i format (VK_FORMAT_R32G32B32A32_SINT) but
declaring it in the shader as r32i.

Affects:
dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.*

Components: Vulkan
VK-GL-CTS issue: 4151
VK-GL-CTS public issue: 365

Change-Id: Ia9dbd97544fce8a29a4fe7270fc617981648032f

Adds missing multisample state structs.

When compiling a fragment shader pipeline library, the fragment shader
state is defined by, among other state, the
VkPipelineMultisampleStateCreateInfo if sample shading is enabled.

In the affected tests, a fragment shader module was being compiled
which accessed builtins decorated with SampleId. This in turn enabled
sample shading, and in such cases, the
VkPipelineMultisampleStateCreateInfo is potentially required by
drivers for their internal logic. For this reason the spec mandates
the struct's inclusion in the fragment shader state when sample
shading is enabled.

Unfortunately it's not simple to change the GraphicsPipelineWrapper to
avoid this erroneous configuration, since in general it would require
parsing the SPIR-V to check if the fragment shader is accessing any
input builtins with the problematic decorations.

Instead a validation run was done over
dEQP-VK.pipeline.pipeline_library.* to ensure there aren't other
callsites falling into this trap, and no other cases were found.

Components: Vulkan

Affects:
dEQP-VK.pipeline.pipeline_library.multisample.*

VK-GL-CTS issue: 3975

Change-Id: I33a6b391af800eb6c23d846b70a4aac2387a74e3

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I2d8979c34c4b9a18509e5c00ba123fa2a7520451

Fix VK_KHR_global_priority tests

Use enabledExtensions to properly enable VK_EXT_global_priority_query
along with passing the globalPriorityQueryFeatures struct.

Components: Vulkan

VK-GL-CTS issue: 4157

Affected tests:
dEQP-VK.api.device_init.create_device_global_priority*

Change-Id: Ib024f187f835914bbcb94e42a40d60a32fed0f99

Work around deArraySizeHelper deficiency with multi-dimension arrays

This fixes a compilation issue with some compilers with deArraySizeHelper
and implicitly sized multi-dimensional arrays.

Affects:

Compilation only.

Components: Framework, Vulkan

VK-GL-CTS issue: 4158

Change-Id: Ie200647f34096b54544aff7f8d82b1eefabbd586

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Id3cf5e258bce8b7aec13bc44abdada774159136b

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ifdc6f7c08ccb5f65d44e406a7dc6ea6866102ad5

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib14adccc08aa0dd8767e6dea0199e021885d292d

Fix errors in sparse resources tests

VK_EXT_shader_image_atomic_int64 extension must be enabled on the device
if used
Feature structs from non-enabled extensions must not be passed to
VkDeviceCreateInfo pNext
Checks if image formats are supported are missing

Components: Vulkan

VK-GL-CTS issue: 4122

Affected tests:
dEQP-VK.sparse_resources.shader_intrinsics.*

Change-Id: I4fcac8eae1d53826d5ef5f8a7dcc04bfe95f7360

Fix subpass dependency dstStageMask in shader_fragment_mask tests

Stage VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUT_BIT must be included if
access mask is VK_ACCESS_COLOR_ATTACHMENT_READ_BIT

Components: Vulkan

VK-GL-CTS issue: 4120

Affected tests:
dEQP-VK.pipeline.*.shader_fragment_mask.*

Change-Id: Iea2a62ff5781c50ad39d707a8eb0f1f4ce344f48

Set correct pipeline barrier between clear image and trace ray

The image is cleared with fixed value, then used as write destination
in ray tracing shaders. The pipeline barrier set for the image is
incorrect between clear command and trace ray command.

Affects:

dEQP-VK.ray_tracing_pipeline.large_shader_set.*

Components: Vulkan

VK-GL-CTS issue: 4137

Change-Id: I41dd55d51ea995c4c878e053f6d617b2e38ba5b1

Add check for the return value of vkGetPhysicalDeviceImageFormatProperties2

Also do not attempt to create images for depth/stencil usage using color formats.

Components: Vulkan

VK-GL-CTS issue: 4125

Affected tests:
dEQP-VK.api.external.memory.dma_buf.suballocated.image.info

Change-Id: If1f41b967d03f1b862c85277d6fe30b20ab1a110

Remove clearing of pipeline creation feedbacks while veryfying them

This re-enables verification of pipeline creation feedbacks by not
zeroing them out just before verification.

VK-GL-CTS Issue: 4129

Affects: dEQP-VK.pipeline.pipeline_library.creation_feedback.graphics_tests.*

Components: Vulkan
Change-Id: I37010973db235f993b85e9ac3c2645ae5b2db79e

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: Ieafa2f3085c673bd861f1e4ddff26897a16b43d9

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ie018c65908482fac3de9a6030d79029e2429d734

Fix to get supported depth format instead of using VK_FORMAT_D32_SFLOAT
always.

Affets:
dEQP-VK.pipeline.pipeline_library.graphics_library.*

VK-GL-CTS Issue: 4142

Components: Vulkan
Change-Id: Ia8cb48061acd4813aecabb050c775a27ce1b4926

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I193ea9253a0d2d405e25d951ba1564f5ad805f3b

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Icc350abe29e7c1545a65d99884a281cd63239fc4

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: Ibfc5624676bae49d9630978494cdfdc660a0fba4

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: If5512ea90e2442bc7304502d78cc3b1333f53479

Write gl_PointSize in depth tests

Some depth tests use VK_PRIMITIVE_TOPOLOGY_POINT_LIST but the shaders
don't write the point size

Components: Vulkan

VK-GL-CTS issue: 4153

Affected tests:
dEQP-VK.pipeline.*.depth.*

Change-Id: Idaa9ea65f7c43ca02d7780d1825d4558b712a133

Add check if format is supported in external memory host tests

Format properties for format used for color attachment must contain
VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT

Components: Vulkan

VK-GL-CTS issue: 4156

Affected tests:
dEQP-VK.memory.external_memory_host.bind_image_memory_and_render.*

Change-Id: Ib0346cbc849b94a5af67e5645cc057ca392f9b2f

Fix invalid framebuffer in compressed texture 3D tests

Framebuffer attachments must be created with viewType not equal to
VK_IMAGE_VIEW_TYPE_3D

Components: Vulkan

VK-GL-CTS issue: 4118

Affected tests:
dEQP-VK.texture.compressed_3D.*

Change-Id: I9ae036d02daa3579567bf514c70bf623a0bc9aa9

Fix flushing memory range in memory model shared tests

Each size of pMemRanges in vkFlushMappedMemoryRanges must be either a
multiple of VkPhysicalDeviceLimits::nonCoherentAtomSize or equal to the
size of memory

Components: Vulkan

VK-GL-CTS issue: 4123

Affected tests:
dEQP-VK.memory_model.shared.*

Change-Id: I0f3ea96736aa73eb92c7809c04297923d84e348c

Fix errors in dynamic rendering suballocation tests

attachmentCount in vkCmdClearAttachments must be greater than 0
depth aspect must only be cleared if depth attachment is set
stencil aspect must only be clear if stencil attachment is set

Components: Vulkan

VK-GL-CTS issue: 4102

Affected tests:
dEQP-VK.dynamic_rendering.*.suballocation.*

Change-Id: Id7cc51794883863aa9add62adee55ef30c0f6a28

Fixes for VK_EXT_image_compression_control swapchain tests

Ensure VK_KHR_get_surface_capabilities2 is requested when creating
Vulkan instances for the swapchain tests. This is required by
functions:
- vkGetPhysicalDeviceSurfaceCapabilities2KHR
- vkGetPhysicalDeviceSurfaceFormats2KHR

Enable imageCompressionControlSwapchain when creating devices for the
swapchain tests.

Properly set compressionControlPlaneCount depending on compression
flags.

Components: Vulkan

VK-GL-CTS issue: 4105

Affects:
dEQP-VK.api.image_compression_control.swapchain.*

Change-Id: I6b1ac25724ac605b91824e784a018f3e4fd717b7

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I4d3f1c8018aa246031409d52a6aa6716a95a67c7

Fixes for VK_EXT_image_compression_control tests

Fix the validation logic to check planes depending on format, not
compressionControlPlaneCount.

Properly set compressionControlPlaneCount and
pFixedRateFlags depending on compression flags.

Components: Vulkan

VK-GL-CTS issue: 4105

Affects:
dEQP-VK.api.image_compression_control.*

Change-Id: I492febb4163867ee722cd49e75cc8646aa8376f5

Merge vk-gl-cts/vulkan-cts-1.3.2 into vk-gl-cts/vulkan-cts-1.3.3

Change-Id: Ibbddec7b6ff3801fef7d359eb08935808a7cfe65

Use pipeline layout alongside with fragment shader stage

In pipeline libraries, pipeline layout is requried if fragment
shader is present in the pipeline.

Affects: dEQP-VK.pipeline.pipeline_library.graphics_library.misc.bind_null_descriptor_set.*

VK-GL-CTS Issue: 4096

Components: Vulkan
Change-Id: Ia70b0f18f497e2e9102e7748c87ea5e5092098bc

Fix color blend state color attachments in depth tests

The number of color attachment in pColorBLendState must match the number
of color attachment in the subpass when creating the pipeline

Components: Vulkan

VK-GL-CTS issue: 4058

Affected tests:
dEQP-VK.pipeline.*.depth.*

Change-Id: Ibce5ff044c0804218d56d452eea7973c4c3a2990

Merge vk-gl-cts/vulkan-cts-1.3.1 into vk-gl-cts/vulkan-cts-1.3.2

Change-Id: I699095999ad69b1ce79e50c3db6a06410005bdb5

Merge vk-gl-cts/vulkan-cts-1.3.0 into vk-gl-cts/vulkan-cts-1.3.1

Change-Id: Iacdc3192254c41c569dbad94d8025b936f93cc25

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/vulkan-cts-1.3.0

Change-Id: I7a7605b2dffeaedac543e32d97f13f552d6ab68f

Re-add texture filtering tests with rgba10x6 format

These tests were removed when only the check for
formatRgba10x6WithoutYCbCrSampler feature was missing

Components: Vulkan

VK-GL-CTS issue: 3646

New tests:
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_nearest
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_nearest_mipmap_linear
dEQP-VK.texture.filtering.3d.formats.r10x6g10x6b10x6a10x6_unorm.r10x6g10x6b10x6a10x6_unorm_linear_mipmap_linear

Change-Id: Ida3cb9f1abd95f57908b9540c65605cbb1b40fa3

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I36f8b8142517f82d581ee2bc365a97ff37a63dc8

Fix invalid usage of descriptorCount for inline uniform
 blocks.

Affects:
dEQP-VK.binding_model.descriptorset_random.*.iublimit*

VK-GL-CTS Issue: 4115

Components: Vulkan

Change-Id: I649d86b859ca642b47c1fda4aa915e1d6616c898

Fix for 16 to 8-bit storage spirv_assembly tests

The output buffer was being made smaller than it was required to
hold all the results. Robust buffer accesss prevented the writes
from trampling memory after the buffer, but could mean that the
data in the valid part of the buffer was incorrectly written instead.

This change makes the output buffer large enough to prevent the
out-of-bounds writes.

Components: Vulkan

VK-GL-CTS issue: 4126

Affected tests:
dEQP-VK.spirv_assembly.instruction.graphics.8bit_storage.storagebuffer_int_16_to_8.*

Change-Id: I59145be8012f7a31037ee3fee4d7ac96a198bc00

Fix barriers in dynamic rendering fragment density tests

Added additional barrier to ensure work on subsampled image is
complete before copy to output image.

Manual cherry-pick from vulkan-cts-1.3.1

Affects: dEQP-VK.dynamic_rendering.primary_cmd_buff.fragment_density_map*
 dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.fragment_density_map*
 dEQP-VK.dynamic_rendering.partial_secondary_cmd_buff.fragment_density_map*

Components: Vulkan

VK-GL-CTS Issue: 3796

Change-Id: I8d2276f6517cea7cd173a8f9b3bd7d40cebf3e6d

Fix to use the correct vulkan device

Wrong device used to create secondary command buffer with
command pool created with different vulkan device.

Affected tests:
dEQP-VK.dynamic_rendering.complete_secondary_cmd_buff.
fragment_density_map.*

Components: Vulkan
VK-GL-CTS issue: 4084

Change-Id: I878a3d43eb48cf033379da92d06c212f7a70ec29

Merge vk-gl-cts/vulkan-cts-1.3.3 into vk-gl-cts/vulkan-cts-1.3.4

Change-Id: I3aae4026dd68350cf7f4e402e94f315498dfe4d8