platform/upstream/pulseaudio.git
13 years agobuild-sys: Use configure AC_OUTPUT to process config files
Maarten Bosmans [Wed, 29 Jun 2011 13:16:09 +0000 (15:16 +0200)]
build-sys: Use configure AC_OUTPUT to process config files

Don't use sed to replace @variable@ in file.in.

13 years agobuild-sys: Move some more defines to configure.ac
Maarten Bosmans [Wed, 29 Jun 2011 13:16:08 +0000 (15:16 +0200)]
build-sys: Move some more defines to configure.ac

13 years agoalsa-sink: fix mmap_write() work_done
Wu Fengguang [Tue, 28 Jun 2011 16:57:33 +0000 (09:57 -0700)]
alsa-sink: fix mmap_write() work_done

mmap_write() work_done is wrongly initilized to TRUE. It ends up never
being FALSE. Fix it to reduce the costly update_smoother() calls.

13 years agoparecord: Automatically detect file format from extension
Maarten Bosmans [Sun, 26 Jun 2011 23:19:07 +0000 (01:19 +0200)]
parecord: Automatically detect file format from extension

And fix a small bug in pa_sndfile_format_from_string.

13 years agobuild-sys: look for function 'backtrace' also in library 'ubacktrace'
Henning Heinold [Sun, 22 May 2011 21:02:44 +0000 (23:02 +0200)]
build-sys: look for function 'backtrace' also in library 'ubacktrace'

Using OpenEmbedded with 'minimal-uclibc' for 'MACHINE = "beagleboard"'
compilation fails with the following error [1].

        […]
          CCLD   pulseaudio
        ./.libs/libpulsecommon-0.9.22.so: undefined reference to `backtrace_symbols'
        ./.libs/libpulsecommon-0.9.22.so: undefined reference to `backtrace'
        collect2: ld returned 1 exit status
        make[3]: *** [pulseaudio] Error 1

Using uClibc 'backtrace' is in the library 'ubacktrace' and needs to be
searched in there. This patch is used successfully in OpenEmbedded[2].

[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032979.html
[2] http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=0086e0506eb4939150bb50ec337d7f6787b8ae8a

13 years agoalsa-mixer: Whoops, forgot to git-add this in a previous.
Colin Guthrie [Sun, 26 Jun 2011 13:51:31 +0000 (14:51 +0100)]
alsa-mixer: Whoops, forgot to git-add this in a previous.

13 years agoalsa-mixer: Add UAC1.0 Sennheiser Dongle to the usb-headset profile.
Colin Guthrie [Sun, 26 Jun 2011 13:22:06 +0000 (14:22 +0100)]
alsa-mixer: Add UAC1.0 Sennheiser Dongle to the usb-headset profile.

Reported by Sean McNamara

13 years agobuild-sys: Move some more defines from CFLAGS to config.h
Maarten Bosmans [Sat, 25 Jun 2011 14:36:08 +0000 (16:36 +0200)]
build-sys: Move some more defines from CFLAGS to config.h

13 years agobuild-sys: Use AX_DEFINE_DIR macro instead of setting AM_CFLAGS
Maarten Bosmans [Sat, 25 Jun 2011 14:36:07 +0000 (16:36 +0200)]
build-sys: Use AX_DEFINE_DIR macro instead of setting AM_CFLAGS

This makes the compiler command line a bit shorter, useful for compiling with make V=1.

13 years agobuild-sys: Use ax_check_flag macros from autoconf archive
Maarten Bosmans [Sat, 25 Jun 2011 14:36:06 +0000 (16:36 +0200)]
build-sys: Use ax_check_flag macros from autoconf archive

Those macros cover almost all functionality of attributes.m4 that was
used, so that file can be removed.
The CC_NOUNDEFINED macro is used directly in configure.ac.

13 years agoalsa-mixer: Add an mixer profile exception for a BT Agile handset
Colin Guthrie [Sat, 25 Jun 2011 12:02:02 +0000 (13:02 +0100)]
alsa-mixer: Add an mixer profile exception for a BT Agile handset

13 years agoalsa-mixer: Add workaround for some USB headsets
David Henningsson [Tue, 5 Apr 2011 09:37:59 +0000 (11:37 +0200)]
alsa-mixer: Add workaround for some USB headsets

This is a workaround - these usb headsets have one output volume
control only, labeled "Speaker". This causes the default profile
set to not control the volume at all, which is a bug. Workaround
that by creating a separate profile set.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agobuild-sys: Update orc.m4 to latest upstream version
Maarten Bosmans [Thu, 23 Jun 2011 20:21:06 +0000 (22:21 +0200)]
build-sys: Update orc.m4 to latest upstream version

ORCC is now correctly set to orcc on build system instead of host for cross-compiling

13 years agoRemove libpulse-browse and pabrowse
Maarten Bosmans [Thu, 23 Jun 2011 20:21:05 +0000 (22:21 +0200)]
Remove libpulse-browse and pabrowse

13 years agoUpdate todo
Maarten Bosmans [Thu, 23 Jun 2011 20:21:04 +0000 (22:21 +0200)]
Update todo

13 years agowin32: Make some unused-variable warnings go away
Maarten Bosmans [Thu, 23 Jun 2011 20:21:03 +0000 (22:21 +0200)]
win32: Make some unused-variable warnings go away

13 years agowin32: Make once-test work
Maarten Bosmans [Thu, 23 Jun 2011 20:21:02 +0000 (22:21 +0200)]
win32: Make once-test work

The barrier is not used when pthread is not available.

13 years agobuild-sys: Cleanup Makefile.am
Maarten Bosmans [Thu, 23 Jun 2011 20:21:01 +0000 (22:21 +0200)]
build-sys: Cleanup Makefile.am

No need to keep some tests in two lists.

13 years agoAdd sys/time.h include to rtclock.c
Maarten Bosmans [Thu, 23 Jun 2011 20:21:00 +0000 (22:21 +0200)]
Add sys/time.h include to rtclock.c

Cross-compiling for win32 failed after the previous #include removal.
Somehow when building for Linux the struct timeval definition got picked up elsewhere.

13 years agoRemove obsolete description property from modules
Maarten Bosmans [Tue, 29 Mar 2011 20:40:49 +0000 (22:40 +0200)]
Remove obsolete description property from modules

13 years agobuild-sys: bump soname
Colin Guthrie [Thu, 23 Jun 2011 20:22:19 +0000 (21:22 +0100)]
build-sys: bump soname

13 years agoraop: Change socket buffer size handling to avoid playback underruns
Bryan Gleeson [Fri, 10 Jun 2011 20:02:20 +0000 (13:02 -0700)]
raop: Change socket buffer size handling to avoid playback underruns

When a TCP socket is created the size of the send buffer (SO_SNDBUF) used is
determined by the OS, using the net.ipv4.tcp_wmem sysctl parameter. Previously
a call to setsockopt set the buffer size to a value that was too small, and
that in some cases could result in underruns and choppy playback. This
setsockopt call has now been removed so that the value determined by the OS
is used unchanged.

Note that the value used for the send buffer size is the 2nd value in
net.ipv4.tcp_wmem, e.g. if this is set to "4096 65536 8388608" the send buffer
size is set to 65536.

13 years agoRemove unnecessary #includes
Maarten Bosmans [Mon, 13 Jun 2011 13:04:33 +0000 (15:04 +0200)]
Remove unnecessary #includes

13 years agodatabase: Support legacy format database entries.
Colin Guthrie [Tue, 7 Jun 2011 23:47:19 +0000 (00:47 +0100)]
database: Support legacy format database entries.

This adds code to specifically support legacy entries.
I kept this code in a separate commit so that it can be (relatively)
easily removed at some point in the future.

13 years agodevice-restore: Add a new protocol extension for device-restore.
Colin Guthrie [Tue, 7 Jun 2011 10:18:17 +0000 (12:18 +0200)]
device-restore: Add a new protocol extension for device-restore.

This simply exposes the formats that a device supports
via a simple protocol extension that will allow clients
to setup what a connected receiver supports format wise.

13 years agodatabase: Convert our use of database files to save in tagstruct format.
Colin Guthrie [Tue, 7 Jun 2011 22:21:04 +0000 (23:21 +0100)]
database: Convert our use of database files to save in tagstruct format.

This has the advantage of allowing versioned updates in the future,
thus allowing us to be more user friendly going forward (as opposed
to just ignoring entries from old versions).

The primary motivation for this, however, is to allow variable length
storage in each entry which will be needed for upcoming work.

At present this commit will ignore any legacy entries but support
for reading and subsequently converting legacy entries will be added
shortly.

13 years agoesound,streams: Fix some crashes.
Colin Guthrie [Wed, 8 Jun 2011 19:18:12 +0000 (20:18 +0100)]
esound,streams: Fix some crashes.

After the rework to the add pa_sink_input_new_data_set_sink() (and
the source equiv) calling with a NULL sink object will hit an assert.

This caused crashes with the esd protocol and there was the potential
(albeit unlikely) for a crash when creating a sink input without any
sinks available (module-always-sink mitigates this risk but it's still
a potential crasher).

13 years agopactl: Add a set-source-output-volume command
Arun Raghavan [Sun, 22 May 2011 07:41:30 +0000 (13:11 +0530)]
pactl: Add a set-source-output-volume command

13 years agosource-output: Trivial code move
Arun Raghavan [Sun, 22 May 2011 07:41:02 +0000 (13:11 +0530)]
source-output: Trivial code move

Makes diff'ing with sink-input.c easier

13 years agocapture: Remove support for synchronised capture streams.
Colin Guthrie [Fri, 20 May 2011 07:33:56 +0000 (08:33 +0100)]
capture: Remove support for synchronised capture streams.

This was added to ensure symmetry between playback and recording streams
code, but in reality this makes little sense practically speaking and thus
it is removed.

13 years agoalsa-mixer: select nearest alsa volume step in sync-volume mode
Juho Hämäläinen [Mon, 20 Dec 2010 16:25:59 +0000 (18:25 +0200)]
alsa-mixer: select nearest alsa volume step in sync-volume mode

13 years agoalsa-mixer: When setting hw volume, always round up with playback and down with capture.
Colin Guthrie [Sun, 8 May 2011 11:44:50 +0000 (12:44 +0100)]
alsa-mixer: When setting hw volume, always round up with playback and down with capture.

The previous logic in ade0a6f88464d8aecf83982d400ccfc402341920
does not work with for input volumes.

This was discussed on the mailing list:

https://tango.0pointer.de/pipermail/pulseaudio-discuss/2011-May/010091.html

This approach can introduce a problem when setting the volumes
for sources. What follows is Tanu Kaskinen's analysis:

[quote]
I'll quote the log:

D: protocol-native.c: Client pavucontrol changes volume of source alsa_input.pci-0000_00_1b.0.analog-stereo.
D: alsa-source.c: Requested volume: 0:  45% 1:  45%
D: alsa-source.c:            in dB: 0: -20.71 dB 1: -20.71 dB
D: alsa-source.c: Got hardware volume: 0:  45% 1:  45%
D: alsa-source.c:               in dB: 0: -21.00 dB 1: -21.00 dB
D: alsa-source.c: Calculated software volume: 0: 101% 1: 101% (accurate-enough=no)
D: alsa-source.c:                      in dB: 0: 0.29 dB 1: 0.29 dB
D: source.c: Volume going up to 29273 at 270475970821
D: source.c: Volume change to 29273 at 270475970821 was written 34 usec late
D: alsa-source.c: Written HW volume did not match with the request: 0: 45% 1:  45% (request) != 0:  42% 1:  42%
D: alsa-source.c:                                            in dB: 0: -21.00 dB 1: -21.00 dB (request) != 0: -22.50 dB 1: -22.50 dB

Looking at the last line, the requested volume seems to hit exactly the
right step (-21.00dB), but for some reason Alsa decides to choose
something else. I'm pretty sure that this happens because of rounding
errors. In the first phase we ask Alsa what dB value we should set, and
it returns -21.00 dB. The value is given as a long int, but we convert
that to pa_cvolume. Then when we set the volume, we convert the
pa_cvolume value back to a long integer. At this point I believe it gets
converted to -2101. This is not visible in the debug message for some
reason - the rounding algorithm must be different from what was used
with the pa_cvolume -> long conversion.
[/quote]

The commit after this contains a patch that addresses this issue.

13 years agostreams: Tidy up includes
Colin Guthrie [Wed, 11 May 2011 10:54:04 +0000 (11:54 +0100)]
streams: Tidy up includes

13 years agoalsa: Remove unneeded include
Colin Guthrie [Wed, 11 May 2011 10:53:23 +0000 (11:53 +0100)]
alsa: Remove unneeded include

13 years agointrospect: Get format of source output
Colin Guthrie [Mon, 16 May 2011 21:23:24 +0000 (22:23 +0100)]
introspect: Get format of source output

This gets the negotiated format of source outputs in
pa_context_get_source_output*(). Also prints the format and volume
in 'pactl list'.

13 years agocapture: Implement per-stream volume control for capture streams.
Colin Guthrie [Tue, 17 May 2011 21:31:10 +0000 (22:31 +0100)]
capture: Implement per-stream volume control for capture streams.

This piggy backs onto the previous changes for protocol 22 and
thus does not bump the version. This and the previous commits should be
seen as mostly atomic. Apologies for any bisecting issues this causes
(although I would expect these to be minimal)

13 years agointrospect: Get formats for sources
Colin Guthrie [Mon, 16 May 2011 21:15:57 +0000 (22:15 +0100)]
introspect: Get formats for sources

This gets the list of supported formats for a source in
pa_context_get_source_info*(). Also prints these in 'pactl list'.

13 years agocapture: Add the passthrough format negotiation to capture streams.
Colin Guthrie [Tue, 17 May 2011 20:56:10 +0000 (21:56 +0100)]
capture: Add the passthrough format negotiation to capture streams.

This helps to keep the API more symmetrical and also potentially
allows support for passthrough monitor sources at some point in the future.

13 years agodef: Add some flags for source outputs.
Colin Guthrie [Tue, 17 May 2011 20:48:29 +0000 (21:48 +0100)]
def: Add some flags for source outputs.

These flags will be required in upcoming work to integrate format and volume
support for source outputs.

13 years agointrospect: Clear out memory properly on error.
Colin Guthrie [Mon, 16 May 2011 21:14:48 +0000 (22:14 +0100)]
introspect: Clear out memory properly on error.

13 years agoalsa-sink: Some trivial tidyups
Colin Guthrie [Tue, 17 May 2011 18:50:32 +0000 (19:50 +0100)]
alsa-sink: Some trivial tidyups

Mostly typo fixes but also a change to make a function relating
to sink inputs use more generic variable names.

13 years agobluetooth-discover: Remove remaining ifdef NOKIAs.
Tanu Kaskinen [Mon, 13 Jun 2011 15:47:43 +0000 (18:47 +0300)]
bluetooth-discover: Remove remaining ifdef NOKIAs.

These were supposed to be removed already in 13849f153, but
at that time I missed the ifdefs in
module-bluetooth-discover.c.

13 years agobuild-sys: module-equalizer-sink needs dbus.
Colin Guthrie [Wed, 22 Jun 2011 13:16:21 +0000 (14:16 +0100)]
build-sys: module-equalizer-sink needs dbus.

13 years agoMerge remote-tracking branch 'mkbosmans/merge/build-sys'
Colin Guthrie [Wed, 22 Jun 2011 13:07:15 +0000 (14:07 +0100)]
Merge remote-tracking branch 'mkbosmans/merge/build-sys'

13 years agoSSE/MMX: Fix problem with highpitched noise on i386
David Henningsson [Fri, 27 May 2011 07:28:57 +0000 (09:28 +0200)]
SSE/MMX: Fix problem with highpitched noise on i386

The "rm" basm constraint doesn't work with my version of gcc (4.5.2),
not even in a simple example. Since we usually only have 5 registers
available on i386, force it to be memory on that architecture.

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
13 years agobuild-sys: Use AX_PTHREAD macro from autoconf archive
Maarten Bosmans [Wed, 8 Jun 2011 16:23:23 +0000 (18:23 +0200)]
build-sys: Use AX_PTHREAD macro from autoconf archive

13 years agobuild-sys: Use AX_CHECK_DEFINE macro from autoconf archive
Maarten Bosmans [Wed, 15 Jun 2011 16:49:22 +0000 (18:49 +0200)]
build-sys: Use AX_CHECK_DEFINE macro from autoconf archive

It has no new functionality over the existing macro that is relevant for
us, but it is good to have use a macro with a clearly defined upstream.

13 years agobuild-sys: Use AX_TLS macro from autoconf archive
Maarten Bosmans [Wed, 8 Jun 2011 16:15:21 +0000 (18:15 +0200)]
build-sys: Use AX_TLS macro from autoconf archive

It has no new functionality over the existing macro that is relevant for
us, but it is good to have use a macro with a clearly defined upstream.

13 years agobuild-sys: Move acx_lirc.m4 contents to configure.ac
Maarten Bosmans [Wed, 8 Jun 2011 20:25:48 +0000 (22:25 +0200)]
build-sys: Move acx_lirc.m4 contents to configure.ac

The file is so small, that it is clearer just to do it in the main file.

13 years agobuild-sys: Move some stuff around in configure.ac
Maarten Bosmans [Sat, 11 Jun 2011 15:27:49 +0000 (17:27 +0200)]
build-sys: Move some stuff around in configure.ac

For more logical grouping of functionality.

13 years agobuild-sys: Clean up configure.ac
Maarten Bosmans [Sat, 11 Jun 2011 15:22:58 +0000 (17:22 +0200)]
build-sys: Clean up configure.ac

Mostly whitespace and other trivial stuff.

13 years agobuild-sys: Define PA_CFLAGS at right time
Maarten Bosmans [Wed, 8 Jun 2011 15:24:55 +0000 (17:24 +0200)]
build-sys: Define PA_CFLAGS at right time

To ensure that all the changes to CFLAGS are also stored into PA_CFLAGS.

13 years agobuild-sys: Reset CFLAGS after DBUS check
Maarten Bosmans [Wed, 8 Jun 2011 15:24:16 +0000 (17:24 +0200)]
build-sys: Reset CFLAGS after DBUS check

13 years agobuild-sys: Consolidate host_os handling
Maarten Bosmans [Wed, 8 Jun 2011 11:40:49 +0000 (13:40 +0200)]
build-sys: Consolidate host_os handling

Use os_is_* shell variables instead of pulse_target_os.

13 years agobuild-sys: Remove unnecessary AC_SUBST calls
Maarten Bosmans [Sat, 11 Jun 2011 14:42:30 +0000 (16:42 +0200)]
build-sys: Remove unnecessary AC_SUBST calls

These HAVE_* variables are only used as AM_CONDITIONAL, so AC_SUBST is not needed.

13 years agostream: Simplify passing of formats in extended API
Arun Raghavan [Sat, 18 Jun 2011 22:36:18 +0000 (15:36 -0700)]
stream: Simplify passing of formats in extended API

Passing a NULL-terminated array of pa_format_info pointers is a bit
unwieldy for clients. Instead of this, let's pass in an array of
pointers and the number of elements in the array.

13 years agostream: Fix a couple of format_info leaks
Arun Raghavan [Sat, 18 Jun 2011 18:35:41 +0000 (11:35 -0700)]
stream: Fix a couple of format_info leaks

13 years agoprotocol-native: Don't leak formats
Arun Raghavan [Thu, 2 Jun 2011 14:05:09 +0000 (19:35 +0530)]
protocol-native: Don't leak formats

This clarifies some ownership issues with the formats idxset on the
server side so we don't end up leaking formats on errors.

13 years agoDisable check for pthreads on win32
Fritz Elfert [Fri, 17 Jun 2011 23:10:57 +0000 (01:10 +0200)]
Disable check for pthreads on win32

And do not use sched_get_priority on mingw with win32 pthreads installed

13 years agoprotocol-native: Use original requested latency on stream moves
Arun Raghavan [Tue, 14 Jun 2011 23:38:02 +0000 (16:38 -0700)]
protocol-native: Use original requested latency on stream moves

We were calculating new latency based on the latency set on the old
sink/source, rather than the actual latency requested by the client.
Over a series of moves, this will lead the latency being ~halved each
time, resulting in an eventual rewind flood from a latency that cannot
be handled.

13 years agoecho-cancel: More preprocessing fixes
Arun Raghavan [Mon, 13 Jun 2011 20:42:01 +0000 (13:42 -0700)]
echo-cancel: More preprocessing fixes

The speex_preprocess_ctl() function takes a spx_int32_t, but we've been
passing a pa_bool_t, which could potentially crash.

13 years agoecho-cancel: Fix preprocessor initialisation
Arun Raghavan [Mon, 13 Jun 2011 20:40:33 +0000 (13:40 -0700)]
echo-cancel: Fix preprocessor initialisation

We were using the block size in bytes instead of samples, which meant
preprocessing was broken. This fix makes a large-ish difference in the
quality of echo-cancellation with speex.

13 years agowin32: define WIN32_LEAN_AND_MEAN
Maarten Bosmans [Tue, 7 Jun 2011 21:46:08 +0000 (23:46 +0200)]
win32: define WIN32_LEAN_AND_MEAN

This makes windows.h include less headers.
Otherwise boolean is typedef'ed and that clashes with libjson.

13 years agogitignore: Add connect-stress, extended-test and format-test.
Tanu Kaskinen [Sat, 11 Jun 2011 16:02:07 +0000 (19:02 +0300)]
gitignore: Add connect-stress, extended-test and format-test.

13 years agotests: Update extended API test
Arun Raghavan [Thu, 2 Jun 2011 14:06:08 +0000 (19:36 +0530)]
tests: Update extended API test

The test wasn't updated after we changed the pa_format_info proplist
format.

13 years agocombine: Fix a crash on shutdown if the module is loaded outside of our control.
Colin Guthrie [Wed, 8 Jun 2011 19:26:07 +0000 (20:26 +0100)]
combine: Fix a crash on shutdown if the module is loaded outside of our control.

By using module indexes rather than module pointers we avoid this posibility.

13 years agodevice-manager: Free a hook slot to prevent segv on unload
Colin Guthrie [Mon, 6 Jun 2011 19:16:11 +0000 (21:16 +0200)]
device-manager: Free a hook slot to prevent segv on unload

13 years agopulsecore: Add a couple pa_asserts() on pa_tagstruct* calls.
Colin Guthrie [Mon, 6 Jun 2011 12:56:55 +0000 (14:56 +0200)]
pulsecore: Add a couple pa_asserts() on pa_tagstruct* calls.

13 years agomodule-combine-sink: Check running flag before rendering in null mode
Forest Bond [Fri, 20 May 2011 16:16:54 +0000 (12:16 -0400)]
module-combine-sink: Check running flag before rendering in null mode

This makes process_render_null consistent with render_memblock and
avoids introducing slight inaccuracies in early latency estimates.

13 years agomodule-combine-sink: Initialize smoother in paused state
Forest Bond [Fri, 20 May 2011 16:21:13 +0000 (12:21 -0400)]
module-combine-sink: Initialize smoother in paused state

The smoother is paused on initialization and resumed when the sink
state is set to running.  Otherwise, early latency estimates are
too low since there is some delay between module initialization and
entering the running state.

After the smoother is initially resumed, it is paused when the sink
state is not running.  The previous behavior was to pause only when
the sink enters suspended state, however, this would lead to large
errors in latency estimates after the sink has been idle for some
time.

13 years agomodule-combine-sink: Initialize smoother with offset pa_rtclock_now()
Forest Bond [Fri, 20 May 2011 16:07:05 +0000 (12:07 -0400)]
module-combine-sink: Initialize smoother with offset pa_rtclock_now()

The smoother was being initialized with offset zero, which caused
the sink latency to be unconditionally reported as zero.

13 years agostreams: Fix the actual resampler method shown in debug messages.
Colin Guthrie [Thu, 2 Jun 2011 09:44:21 +0000 (11:44 +0200)]
streams: Fix the actual resampler method shown in debug messages.

13 years agoosx: pass -headerpad_max_install_names to the linker, too
Daniel Mack [Fri, 27 May 2011 13:33:17 +0000 (15:33 +0200)]
osx: pass -headerpad_max_install_names to the linker, too

This option won't make it to the actual libtool command which does the
linking when not prefixed with -Wl,

13 years agoalsa-mixer: Fix the assumption that volume is always positive
Lu Guanqun [Thu, 26 May 2011 08:49:52 +0000 (16:49 +0800)]
alsa-mixer: Fix the assumption that volume is always positive

Add a variable to track whether the actual volume is set or not.
Suppose this:
min volume: -126 max volume: 0
then when user wants to set some constant volume to -10, it would fail.

While the alsa values are typically positive, some values are "funky"
and have negative values. It is desirable to fix this at the alsa
level so that the numbers are positive, but it's not technically
invalid, and thus we have to support it.

Discussed here:
http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/9832
and
http://thread.gmane.org/gmane.linux.alsa.devel/85459

13 years agoecho-cancel: Fix a crash is speex cleanup
Arun Raghavan [Sat, 28 May 2011 02:21:35 +0000 (07:51 +0530)]
echo-cancel: Fix a crash is speex cleanup

If module initialisation fails, the speex done() function might try to
free a value that's not been allocated yet. Adding protection for this
condition.

13 years agoecho-cancel: Fix echo suppression, add some knobs
Bart Cerneels [Sat, 28 May 2011 02:27:22 +0000 (07:57 +0530)]
echo-cancel: Fix echo suppression, add some knobs

The echo suppress attenuation value was being incorrectly modified.
Fixed and added 2 arguments to change the attenuation of the residual
echo filter. Default values of the speex preprocessor will be used when
omitted.

13 years agoecho-cancel: Speex preprocessor has to run *after* the AEC.
Bart Cerneels [Sat, 28 May 2011 02:26:00 +0000 (07:56 +0530)]
echo-cancel: Speex preprocessor has to run *after* the AEC.

This is how it is expected to be run.

13 years agoecho-cancel: Add speex preprocessing
Arun Raghavan [Thu, 19 May 2011 07:59:49 +0000 (13:29 +0530)]
echo-cancel: Add speex preprocessing

This allows the selective enabling of speex' preprocessing algorithms
before running the echo-canceller -- for now this includes automatic
gain control, noise suppression and echo suppression. It's all off by
default for now, though at some point in the near future we might want
to enable at least denoising by default.

The denoising works pretty well, though we might want to add a way to
tweak the noise-suppression knob that libspeex provides.

The AGC option is just a stop-gap -- we need a real AGC mechanism that
tweaks the source volume rather than doing this in software.

The speex documentation mentions VAD and dereverb, but it appears that
these are not complete yet.

We don't do all this in a separate module from module-echo-cancel to
avoid the overhead of adding another virtual source. It makes more sense
to make a separate virtual source module that can be used for cases
where preprocessing is useful but AEC is not (for e.g. noise suppression
for fan noise in a recording application).

Another reason to keep this integrated with the AEC module is that the
echo suppression bits use the speex echo canceller state. This does leak
some information about the AEC implementation into module-echo-cancel,
but this is unavoidable.

13 years agoformat: Fix channel map handling
Arun Raghavan [Fri, 20 May 2011 13:51:02 +0000 (19:21 +0530)]
format: Fix channel map handling

Channel map handling in the extended API was broken. Thanks for Milos_SD
for pointing this out on IRC.

13 years agoecho-cancel: Remove extraneous debug message
Arun Raghavan [Fri, 20 May 2011 04:31:16 +0000 (10:01 +0530)]
echo-cancel: Remove extraneous debug message

This was making it impossible to run in debug mode with save_aec=1

13 years agoecho-cancel: Don't overpad variable
Arun Raghavan [Sat, 14 May 2011 12:14:23 +0000 (17:44 +0530)]
echo-cancel: Don't overpad variable

The padding was to be 16 bytes, not 16 elements.

13 years agobuild-sys: Link libpulse directly to libdbus-1 if needed
Sjoerd Simons [Mon, 16 May 2011 10:00:37 +0000 (10:00 +0000)]
build-sys: Link libpulse directly to libdbus-1 if needed

Linking libpulse with gold or when using ld --no-add-needed fails
as libpulse uses dbus methods directly but isn't explicitly linked to it.
So link to it when needed :)

13 years agoprotocol-native: Fix memory leaks introduced in protocol 21 (passthrough support)
Colin Guthrie [Mon, 16 May 2011 08:26:32 +0000 (09:26 +0100)]
protocol-native: Fix memory leaks introduced in protocol 21 (passthrough support)

The proplist used may never be freed if an error condition was found with
CHECK_VALIDITY macro and the formats idxset was never freed regardless
of error state.

This change fixes adds a new maco CHECK_VALIDITY_GOTO() which allows
for cleanup to be done before returning.

13 years agosink-input: Fix memory leak of proplist when sending format-changed events
Colin Guthrie [Sun, 15 May 2011 17:41:31 +0000 (18:41 +0100)]
sink-input: Fix memory leak of proplist when sending format-changed events

13 years agoloopback: Add a modarg for disabling remixing.
Tanu Kaskinen [Sat, 14 May 2011 13:11:25 +0000 (16:11 +0300)]
loopback: Add a modarg for disabling remixing.

13 years agobluetooth: Fix early return styling and add missing return value
Colin Guthrie [Sun, 15 May 2011 14:05:44 +0000 (15:05 +0100)]
bluetooth: Fix early return styling and add missing return value

Thanks to Tanu Kaskinen for pointing out the missing return.

13 years agosuspend-on-idle: Trigger mempool vacuuming
Jyri Sarha [Fri, 8 Apr 2011 14:18:13 +0000 (17:18 +0300)]
suspend-on-idle: Trigger mempool vacuuming

In a setup with one or more filter sinks or sources there is always at
least one stream existing. In such a situation normal mempool
vacuuming never happens. This patch causes suspend-on-idle module to
vacuum memory when ever it notices that all sinks and sources are
suspended. The behavior can be enabled with a module parameter.

13 years agoprotocol-native: Stop auto timing updates if connected to suspended sink or source
Jyri Sarha [Fri, 8 Apr 2011 14:18:12 +0000 (17:18 +0300)]
protocol-native: Stop auto timing updates if connected to suspended sink or source

This quite is an old patch. It was added to N900 to avoid unnecessary
wake-ups when the phone is in power save mode (= blank screen and
no user interaction). In this situation if the user had a browser
window with flash animation open pulseaudio kept waking up every
10 seconds, causing a severe hit to use times.

Anyway I do not see any reason to send timing updates if the sink or
source where the stream is connected to is suspended.

13 years agoi18n: Fix POTFILES
Colin Guthrie [Sun, 15 May 2011 13:31:22 +0000 (14:31 +0100)]
i18n: Fix POTFILES

13 years agotests: Fix resampler-test.
Colin Guthrie [Sun, 15 May 2011 13:16:52 +0000 (14:16 +0100)]
tests: Fix resampler-test.

This has been broken since c376ac5920fdeb46ca844d9518e22f17adffb635 when run
without any arguments. Passing in -v (verbose) caused the test to work fine.

I think this oversight is just a thinko in the original work but it obviously
broke 'make check' and thus distcheck.

Also fix a couple compiler warnings.

13 years agoMerge branch 'passthrough'
Colin Guthrie [Sun, 15 May 2011 12:14:33 +0000 (13:14 +0100)]
Merge branch 'passthrough'

13 years agomodule-tunnel: Update for recent protocol changes
Arun Raghavan [Sun, 15 May 2011 04:24:17 +0000 (09:54 +0530)]
module-tunnel: Update for recent protocol changes

This updates the tunnel module for protocol version >= 19.

module-tunnel-sink does not proxy server-side passthrough support (yet).
This would require a few more changes, namely keeping track of what
formats are available and if any other sink inputs are connected on the
server-side.

13 years agodoxygen: generate documentation for format.h
Arun Raghavan [Thu, 5 May 2011 10:28:46 +0000 (15:58 +0530)]
doxygen: generate documentation for format.h

13 years agoformat: Add some convenience API for setting properties
Arun Raghavan [Wed, 13 Apr 2011 10:07:25 +0000 (15:37 +0530)]
format: Add some convenience API for setting properties

Adds functions to set sample format, rate, channels and channel map on a
format to make life easier for users of the API.

13 years agoformat: Extend properties to handle lists/ranges
Arun Raghavan [Wed, 13 Apr 2011 08:35:18 +0000 (14:05 +0530)]
format: Extend properties to handle lists/ranges

This replaces the simple string used by pa_format_info's proplist with a
JSON string (accessed via new API only). This allows us to express lists
and ranges more cleanly, and embed type information for future
extensibility.

We use json-c for JSON parsing. This is a lightweight depdency (32 KB on
my system) and avoids the hassle of having to reinvent a JSON parser.

Also included is a test which verifies functionality and is
valgrind-clean.

13 years agosink-input: Provide more information to client when format is lost
Arun Raghavan [Sun, 10 Apr 2011 10:54:33 +0000 (16:24 +0530)]
sink-input: Provide more information to client when format is lost

When the sink format changes and we kill the stream, clients need a way
to know (a) what device they should reconnect to, and (b) what the
stream running time was when the stream got killed (pa_stream_get_time()
won't work after the stream has been killed). This adds these two bits
of information in the event callback's proplist parameter.

13 years agoformat: Add correct sample spec conversion for E-AC3
Arun Raghavan [Sat, 9 Apr 2011 04:06:25 +0000 (09:36 +0530)]
format: Add correct sample spec conversion for E-AC3

IEC61937-encapsulated E-AC3 frames contain 6 audio blocks per substream,
which corresponds to 1536 samples contained a 24576-byte frame. To cope
with this, we maintain the s16le stereo sample spec, but quadruple the
sample rate so that the conversion remains accurate.

13 years agoformat: Export pa_format_info_is_compatible in API
Arun Raghavan [Tue, 29 Mar 2011 11:46:08 +0000 (17:16 +0530)]
format: Export pa_format_info_is_compatible in API

This allows clients to perform checks between formats as well.

13 years agosink-input: Add a format-lost event
Arun Raghavan [Mon, 28 Mar 2011 03:16:40 +0000 (08:46 +0530)]
sink-input: Add a format-lost event

This event is emitted if the sink-input could not be moved to a new sink
because it doesn't support the format of the sink-input. Clients can
reconnect their stream with a different format if they wish or
gracefully exit.

13 years agosink-input: Don't restore volume for passthrough streams
Arun Raghavan [Mon, 28 Mar 2011 03:16:20 +0000 (08:46 +0530)]
sink-input: Don't restore volume for passthrough streams