Hui Wang [Mon, 7 Jun 2021 08:58:36 +0000 (16:58 +0800)]
alsa-sink/source: set volume to hw immediately if ucm_port changing
Recently we found an issue of output volume on speaker and headphone,
they should have their own volume but in practice they share one
output volume.
This issue happens on the laptops which use the ucm2 sof-hda-dsp,
originally the speaker has output volume A while the headphone has the
output volume B, suppose the speaker is the active port at the moment
and the output volume is A, users plug a headphone to the jack and the
headphone becomes the active port, in this process, ucm_set_port()
calls _disdev/_enadev which triggers the io_mixer_callback(), in the
meanwhile, the module_device_restore will restore the headphone's
volume to B, it will call set_volume_cb() to set the volume to B, but
this value is not written to hw immediately, during the time of
waiting for the B to be written to the hw, the io_mixer_callback()
calls get_volume_cb(), it reads hw volume and gets the volume A, then
it overrides the output volume to A, this results in the headphone
gets the volume A instead of B.
If a machine doesn't use the ucm, this issue will not happen since the
set_port_cb() will not trigger the io_mixer_callback(). If the ports
don't belong to the same sink/source, this issue also doesn't happen.
BugLink: http://bugs.launchpad.net/bugs/1930188
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/577>
Patrick Gaskin [Sun, 30 May 2021 19:28:46 +0000 (15:28 -0400)]
win32: Add DACLs for directories created by system daemon
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/549>
Patrick Gaskin [Sun, 30 May 2021 19:28:30 +0000 (15:28 -0400)]
daemon: Add support for running as a service on win32
* Minimal implementation of --system on win32.
* Wrap main with a Windows Service on win32 (with a fallback to
running it directly).
* Update PA_SYSTEM_{RUNTIME,STATE,CONFIG}_PATH and HOME dynamically
on Windows (overrides the build config, similar to the existing
config path replacement logic).
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/549>
Hui Wang [Fri, 28 May 2021 02:25:27 +0000 (10:25 +0800)]
alsa-mixer: only use switch to mute Front in the Headphone path
According to the alsa-info.txt in the pipewire issues of 747 and 1206,
the Front Playback Volume is shared by Headphone and Lineout or
Headphone and Speaker, But Headphone, Lineout or Speaker they all have
independent Playback Switch, change to only use switch to mute the
Lineout or Speaker. This could resolve the issues of 747 and 1206.
BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1206
BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/747
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/565>
Patrick Gaskin [Sun, 30 May 2021 19:25:10 +0000 (15:25 -0400)]
win32: Misc Unix socket fixes
* Make pa_parse_address recognize Unix socket addresses with
Windows-style absolute paths.
* Treat WASEINVAL as a stale socket.
* Make HAVE_AF_UNIX in config templates recognize winsock2.h.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/546>
Patrick Gaskin [Sun, 30 May 2021 19:24:56 +0000 (15:24 -0400)]
win32: Fix environment variables set with pa_{unset,set}_env not taking effect
SetEnvironmentVariable is not visible to getenv.
See https://github.com/curl/curl/issues/4774.
See https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/getenv-wgetenv.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/546>
Patrick Gaskin [Sun, 30 May 2021 19:24:26 +0000 (15:24 -0400)]
win32: Fix minimum Windows version for inet_{ntop,pton}
https://docs.microsoft.com/en-us/windows/win32/api/ws2tcpip/nf-ws2tcpip-inet_ntop#requirements
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/546>
Scott Worley [Mon, 14 Jun 2021 03:11:34 +0000 (20:11 -0700)]
gsettings: Emit glib logs on stderr, not stdout
Having G_MESSAGES_DEBUG=all set in the environment (a normal thing to do
when debugging Gnome troubles) causes gsettings-helper to emit a bunch
of helpful gnome debug logs (which is good), but before this change they
were printed on stdout rather than stderr (which was bad!). Rather than
going somewhere the user could see, these log messages were being sent
to the pulesaudio server and interpreted as the src/modules/stdin-util.c
protocol. pulseadio waits to see a '!' message from gsettings-helper
before continuing startup. With the log messages mixed in messing up
the stdin-util protocol, pulseaudio never saw the '!' message, and so
never completed startup.
This simple fix relies on a recent glib > 2.68 (Mar 2021), so builds
against old versions of glib will still have this problem! We consider
this good enough until some complains otherwise.
Fixes: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/1222
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/579>
Igor V. Kovalenko [Tue, 15 Jun 2021 06:19:09 +0000 (09:19 +0300)]
alsa-mixer: updated Sennheiser GSX 1200 device ID
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/581>
Igor V. Kovalenko [Mon, 14 Jun 2021 15:53:43 +0000 (18:53 +0300)]
doc: link to site documentation for IRC channels
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/580>
Johannes Wolf [Thu, 27 May 2021 16:39:40 +0000 (18:39 +0200)]
alsa-profiles: Add NI Komplete Audio 6 profiles
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/564>
Igor V. Kovalenko [Tue, 15 Dec 2020 21:35:05 +0000 (00:35 +0300)]
card: handle sticky profile flag
New card database entry version 5 for card profile is sticky flag.
New messaging API handlers set-profile-sticky and get-profile-sticky.
When card profile is sticky, always restore it even if it is unavailable,
and prevent switching from it when ports become unavailable.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/568>
Igor V. Kovalenko [Mon, 7 Jun 2021 05:53:24 +0000 (08:53 +0300)]
alsa-mixer: check if mapping is NULL before using it
Fix Debian bullseye bug where adding this line makes pulseaudio crash on startup
`load-module module-alsa-sink device=hw:1,0 control=Wave`
See https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=989103
Fixes:
dacfcbb09 ("alsa-ucm: use the proper mixer name for ucm pcm sink/source")
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/576>
garrison [Fri, 4 Jun 2021 22:13:02 +0000 (22:13 +0000)]
build-sys: meson: check if NEON code can be compiled on arm
When Meson SIMD module returns HAVE_NEON=1 on arm host, do extra compile check
to verify compiler can actually handle NEON code.
Related Meson issue #6361 https://github.com/mesonbuild/meson/issues/6361
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/574>
Igor V. Kovalenko [Sat, 5 Jun 2021 09:37:24 +0000 (12:37 +0300)]
build-sys: meson: check HAVE_MMX and HAVE_SSE before calling initializers
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/575>
Igor V. Kovalenko [Tue, 1 Jun 2021 19:35:26 +0000 (22:35 +0300)]
json: remove json from public API
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/570>
Felipe Sateler [Wed, 2 Jun 2021 00:42:44 +0000 (20:42 -0400)]
tests: fix json test for large numbers
PRIu64 means print a uint64_t, not an unsigned long. This
is warned by the compiler:
warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'long unsigned int'
This causes build failures on some 32-bit archs
https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=i386&ver=14.99.1%2Bdfsg1-2&stamp=
1622553415&raw=0
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/571>
Igor V. Kovalenko [Thu, 3 Jun 2021 06:43:10 +0000 (09:43 +0300)]
build-sys: meson: restore big endian detection
Autotools used AC_C_BIGENDIAN to set WORDS_BIGENDIAN, add Meson implementation.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/572>
Ilja van Sprundel [Sun, 23 May 2021 21:10:49 +0000 (21:10 +0000)]
webrtc: Avoid using dynamic strings as format strings
Properly call format functions, dynamic strings shouldn't be passed as
format strings. Instead a format string of "%s" should be used, with the
dynamic string as it's argument.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/563>
Ricky Tigg [Fri, 28 May 2021 13:46:13 +0000 (13:46 +0000)]
Translated using Weblate (Finnish)
Currently translated at 90.9% (515 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/fi/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
scootergrisen [Fri, 21 May 2021 22:52:52 +0000 (22:52 +0000)]
Translated using Weblate (Danish)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/da/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
scootergrisen [Fri, 21 May 2021 22:33:37 +0000 (22:33 +0000)]
Translated using Weblate (Danish)
Currently translated at 97.7% (553 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/da/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Yuri Chornoivan [Tue, 18 May 2021 11:01:49 +0000 (11:01 +0000)]
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/uk/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Yaron Shahrabani [Tue, 11 May 2021 10:53:45 +0000 (10:53 +0000)]
Translated using Weblate (Hebrew)
Currently translated at 29.6% (168 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/he/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Yaron Shahrabani [Mon, 10 May 2021 05:46:44 +0000 (05:46 +0000)]
Translated using Weblate (Hebrew)
Currently translated at 28.6% (162 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/he/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Anders Jonsson [Mon, 3 May 2021 15:28:27 +0000 (15:28 +0000)]
Translated using Weblate (Swedish)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/sv/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Milo Casagrande [Sun, 18 Apr 2021 19:42:14 +0000 (19:42 +0000)]
Translated using Weblate (Italian)
Currently translated at 98.5% (558 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/it/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
scootergrisen [Thu, 15 Apr 2021 12:23:52 +0000 (12:23 +0000)]
Translated using Weblate (Danish)
Currently translated at 97.3% (551 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/da/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
simmon [Mon, 12 Apr 2021 05:11:25 +0000 (05:11 +0000)]
Translated using Weblate (Korean)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/ko/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Toni Estevez [Sun, 11 Apr 2021 07:19:23 +0000 (07:19 +0000)]
Translated using Weblate (Spanish)
Currently translated at 91.5% (518 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/es/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
simmon [Tue, 6 Apr 2021 04:25:12 +0000 (04:25 +0000)]
Translated using Weblate (Korean)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/ko/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
simmon [Thu, 1 Apr 2021 06:02:28 +0000 (06:02 +0000)]
Translated using Weblate (Korean)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/ko/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Pjotr Vertaalt [Mon, 29 Mar 2021 22:09:17 +0000 (22:09 +0000)]
Translated using Weblate (Dutch)
Currently translated at 99.1% (561 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Pjotr Vertaalt [Thu, 25 Mar 2021 20:36:38 +0000 (20:36 +0000)]
Translated using Weblate (Dutch)
Currently translated at 99.1% (561 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
simmon [Thu, 25 Mar 2021 07:51:29 +0000 (07:51 +0000)]
Translated using Weblate (Korean)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/ko/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Yaron Shahrabani [Thu, 25 Mar 2021 08:05:57 +0000 (08:05 +0000)]
Translated using Weblate (Hebrew)
Currently translated at 27.0% (153 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/he/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Göran Uddeborg [Tue, 23 Mar 2021 12:06:02 +0000 (12:06 +0000)]
Translated using Weblate (Swedish)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/sv/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Pjotr Vertaalt [Wed, 24 Mar 2021 08:53:48 +0000 (08:53 +0000)]
Translated using Weblate (Dutch)
Currently translated at 98.9% (560 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Pjotr Vertaalt [Mon, 22 Mar 2021 19:39:13 +0000 (19:39 +0000)]
Translated using Weblate (Dutch)
Currently translated at 97.5% (552 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Pjotr Vertaalt [Mon, 22 Mar 2021 18:00:58 +0000 (18:00 +0000)]
Translated using Weblate (Dutch)
Currently translated at 97.5% (552 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
simmon [Fri, 19 Mar 2021 18:25:46 +0000 (18:25 +0000)]
Translated using Weblate (Korean)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/ko/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Milo Casagrande [Thu, 18 Mar 2021 10:29:19 +0000 (10:29 +0000)]
Translated using Weblate (Italian)
Currently translated at 97.8% (554 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/it/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Karl Ove Hufthammer [Wed, 10 Mar 2021 19:59:00 +0000 (19:59 +0000)]
Translated using Weblate (Norwegian Nynorsk)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/nn/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Oğuz Ersen [Tue, 9 Mar 2021 10:14:28 +0000 (10:14 +0000)]
Translated using Weblate (Turkish)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/tr/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Ricky Tigg [Tue, 9 Mar 2021 13:14:08 +0000 (13:14 +0000)]
Translated using Weblate (Finnish)
Currently translated at 90.9% (515 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/fi/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Piotr Drąg [Tue, 9 Mar 2021 15:55:30 +0000 (15:55 +0000)]
Translated using Weblate (Polish)
Currently translated at 100.0% (566 of 566 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/pl/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Yaron Shahrabani [Mon, 8 Mar 2021 08:42:31 +0000 (08:42 +0000)]
Translated using Weblate (Hebrew)
Currently translated at 26.0% (147 of 564 strings)
Translation: pulseaudio/pulseaudio
Translate-URL: https://translate.fedoraproject.org/projects/pulseaudio/pulseaudio/he/
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/573>
Igor V. Kovalenko [Tue, 1 Jun 2021 17:27:03 +0000 (20:27 +0300)]
alsa-mixer: prevent double-free on decibel fixes object key
When decibel fixes object is cloned, there is only a shallow copy of `key`
string member of original object. This may lead to double-free crash reported in
pipewire tracker https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1125
Fix this by doing a deep copy of `key` string to maintain correct ownership.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/569>
Felipe Sateler [Wed, 19 May 2021 04:15:29 +0000 (00:15 -0400)]
Don't link libpulsecommon with GLib and GTK
This was the behaviour with the autotools build.
Fixes #1210
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/559>
Takashi Sakamoto [Sun, 30 May 2021 04:09:44 +0000 (13:09 +0900)]
udev: fix match expression to Focusrite Saffire Pro i/o series for ignorance
It seems that in sound context environment variable is not available for
match expression.
This commit utilizes walkthrough to refer to attributes in fw node. The
combination of vendor, model, units is enough to match the node since
the attributes of fw unit doesn't have vendor.
Fix:
37358e42c49a ("alsa: Suppress udev detection of sound card for some units on IEEE 1394 bus")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/566>
Igor V. Kovalenko [Wed, 19 May 2021 17:57:52 +0000 (20:57 +0300)]
alsa-mixer: Add support for usb audio in the Dell dock WD19
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/562>
Sanchayan Maity [Wed, 19 May 2021 13:55:08 +0000 (19:25 +0530)]
bluetooth: aptX: Improve error message for when aptX element is not found
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/561>
Sanchayan Maity [Wed, 19 May 2021 08:07:37 +0000 (13:37 +0530)]
bluetooth: ldac: Fix missing check for RTP LDAC payloader element
While at it, improve the error message to include the name of the
element which was not found.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/560>
Igor V. Kovalenko [Tue, 18 May 2021 21:52:56 +0000 (00:52 +0300)]
build-sys: meson: make doxygen optional
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/558>
Igor V. Kovalenko [Tue, 18 May 2021 16:47:32 +0000 (19:47 +0300)]
build-sys: meson: only require libltdl if daemon is built
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/557>
Arun Raghavan [Mon, 17 May 2021 20:03:28 +0000 (16:03 -0400)]
build-sys: Fix a couple of meson warnings
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/556>
Arun Raghavan [Mon, 17 May 2021 15:32:35 +0000 (11:32 -0400)]
build-sys: Bump libpulse soversion
Lots of changes, particularly related to the messaging API.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/555>
Jason Nader [Sat, 13 Mar 2021 23:49:44 +0000 (23:49 +0000)]
Apply 3 suggestion(s) to 1 file(s)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Mon, 1 Feb 2021 10:06:21 +0000 (10:06 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Mon, 1 Feb 2021 10:06:06 +0000 (10:06 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Mon, 1 Feb 2021 10:06:04 +0000 (10:06 +0000)]
Apply 1 suggestion(s) to 1 file(s)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Klaas van Schelven [Mon, 18 Jan 2021 12:55:29 +0000 (13:55 +0100)]
pactl: add `get-(source|sink)-mute` commands
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Thu, 10 Dec 2020 04:58:20 +0000 (13:58 +0900)]
pactl: add `get_source_volume` command
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Thu, 10 Dec 2020 04:49:53 +0000 (13:49 +0900)]
pactl: add `get_default_source` command
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Tue, 8 Dec 2020 04:55:31 +0000 (13:55 +0900)]
pactl: add `get-sink-volume` command
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Jason Nader [Mon, 7 Dec 2020 14:28:34 +0000 (23:28 +0900)]
pactl: add `get_default_sink` command
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/430>
Marijn Suijten [Thu, 22 Apr 2021 19:59:37 +0000 (21:59 +0200)]
bluetooth: Add avrcp_absolute_volume module flag for disablement
Not all peers might work fine with Absolute Volume, provide the user
with an option to disable it without impairing other AVRCP-related
commands like media status and playback controls.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Marijn Suijten [Sat, 27 Mar 2021 13:05:00 +0000 (14:05 +0100)]
bluetooth: Delay A2DP Absolute Volume setup until property is available
The Volume property on org.bluez.MediaTransport1 is required to utilize
Absolute Volume, but it will only become availabe if the peer device
supports the feature. This happens asynchronously somewhere after the
transport itself has been acquired, after which the callbacks are
attached and software volume is reset.
To prevent race conditions availability of the property is also checked
on startup through a "Get" call.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Marijn Suijten [Thu, 16 Jan 2020 14:39:41 +0000 (15:39 +0100)]
bluetooth: Report a2dp_source volume changes to the source device
Write the current volume to the `Volume` DBus property to keep the
volume on the remote in sync. Without this the remote device shows the
wrong volume, and any attempts to change it will cause an unexpected
jump when the local volume has also been adjusted.
Thanks to prior investments to improve volume synchronization, setting
up callbacks and sending initial volume to the peer for HFP/HSP
implementing this feature is as easy as unconditionally assigning a
valid function to `set_source_volume`. `source_setup_volume_callback`
is already responsible for attaching a `SOURCE_VOLUME_CHANGED` hook and
sending initial (restored) volume to the peer (signifying support for
Absolute Volume - if not derived from the presence of FEATURE_CATEGORY_2
on the profile yet).
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Marijn Suijten [Thu, 16 Jan 2020 01:49:01 +0000 (02:49 +0100)]
bluetooth: Synchronize AVRCP Absolute Volume with A2DP sink
Like the previous commit this handles `Volume` property changes but
applies them to an A2DP sink instead of source stream. As mentioned in
the AVRCP spec v1.6.2 §5.8 the rendering device (A2DP sink) is
responsible for performing volume attenuation meaning PulseAudio should
pass through audio as-is without performing any attenuation in SW.
Setting a valid pointer to `set_sink_volume` and returning `true` from
`should_attenuate_volume` attaches a hardware callback to `pa_sink` such
that no volume attenuation is performed anymore.
In addition to receiving volume change notifications it is also possible
to control remote volume by writing a new value to the DBus property.
This is especially useful when playing back to in-ear audio devices
which usually lack physical buttons to adjust the final volume on the
sink.
While software volume (used before this patch) is generally fine it is
annoying to crank it up all the way to 100% when a previous connection
to a different device left saved volume on the peer at a low volume.
Providing this bidirectional synchronization is most natural to users
who wish to use physical controls on their headphones, are used to this
from their smartphone, or aforementioned volume mismatches where both PA
as source and the peer as sink/rendering device are performing
attenutation.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Marijn Suijten [Sat, 27 Mar 2021 09:53:07 +0000 (10:53 +0100)]
bluetooth: Update source software volume on AVRCP SetAbsoluteVolume
The A2DP spec mandates that the audio rendering device - the device
receiving audio, in our case a `pa_source` - is responsible for
performing attenuation:
AVRCP v1.6.2, §5.8:
The SetAbsoluteVolume command is used to set an absolute volume to be used by the rendering device.
BlueZ models this call as a change of the `Volume` property on the
`org.bluez.MediaTransport1` interface. Supporting Absolute Volume is
optional but BlueZ unconditionally reports feature category 2 in its
profile, mandating support. Hence remote devices (ie. a phone) playing
back audio to a machine running PulseAudio assume volume is to be
changed through SetAbsoluteVolume, without performing any local
attenuation.
Future changes will implement this feature the other way around: setting
an initial value for the `Volume` property as well as propagating
`pa_source` volume changes back to the peer.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Marijn Suijten [Sat, 27 Mar 2021 10:42:37 +0000 (11:42 +0100)]
bluetooth: Move HSP_MAX_GAIN to header for reuse in n_volume_steps
Instead of hardcoding the number `16`, use `HSP_MAX_GAIN + 1`.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/239>
Georg Chini [Sun, 16 May 2021 17:03:58 +0000 (19:03 +0200)]
null-sink: Request no more than the configured latency from sink-input
In the case, where the latency is larger than the maximum block size,
module-null-sink will request multiples of the maximum block size from
the sink input instead of limiting the requested amount of data to the
the configured latency.
This patch fixes the problem.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/554>
Hui Wang [Thu, 13 May 2021 01:16:58 +0000 (09:16 +0800)]
Revert "alsa-mixer: Set "Front" control to 0 dB on headphone path"
This reverts commit
96369919e5100865e2469e42fb8f4b8e38e41aef.
The commit was originally for the issue of Headphone can't output
sound, that was because the Headphone and Lineout share the 1st alsa
mixer and DAC, but this commit introduced a new issue of the speaker
is not muted after switching to headphone.
A recent merged kernel commit (
f48652bbe3ae@linux) could fix the 1st
issue, so we could revert the fix of the 1st issue from PA, then the
2nd issue is fixed automatically.
BugLink: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/747
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/553>
Jan Alexander Steffens (heftig) [Wed, 12 May 2021 19:10:54 +0000 (21:10 +0200)]
build-sys: meson: Add missing include dir
Otherwise building module-echo-cancel fails here:
FAILED: src/modules/module-echo-cancel.so.p/echo-cancel_adrian-aec.c.o
cc -Isrc/modules/module-echo-cancel.so.p -I. -I../pulseaudio -Isrc -I../pulseaudio/src -I/usr/include/orc-0.4 -flto=auto -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=gnu11 -march=x86-64 -mtune=generic -O2 -p>
../pulseaudio/src/modules/echo-cancel/adrian-aec.c:30:10: fatal error: adrian-aec-orc-gen.h: No such file or directory
30 | #include "adrian-aec-orc-gen.h"
| ^~~~~~~~~~~~~~~~~~~~~~
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/552>
Christopher Arndt [Sat, 1 May 2021 14:57:13 +0000 (16:57 +0200)]
Add port order metadata to JACK sink / source ports
Adds JACK metadata property to ports created by *module-jack-sink*
and *module-jack-source* with key `JACK_METADATA_ORDER`, the port index
(1-based, in order of creation) as value and type
`http://www.w3.org/2001/XMLSchema#int`.
This allows JACK applications, which use JACK metadata, to list or display
these ports in correct order.
See also: https://jackaudio.org/api/group__Metadata.html
Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/550>
Patrick Gaskin [Fri, 23 Apr 2021 01:44:40 +0000 (21:44 -0400)]
win32: Use DACLs when setting socket permissions
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/548>
Patrick Gaskin [Fri, 23 Apr 2021 06:25:58 +0000 (02:25 -0400)]
cli-command: Replace config dir with toplevel for .include on win32
This makes the behaviour match pa_{open,find}_config_file by
replacing PA_DEFAULT_CONFIG_DIR with the toplevel.
This fixes the hardcoded paths for {default,system}.pa.d introduced
in
45abd0b43c7901b375afcba6d9b0e1cca2f349a8 (!361).
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/545>
Igor V. Kovalenko [Wed, 21 Apr 2021 21:09:09 +0000 (00:09 +0300)]
bluetooth: adjust sync to source with different sample spec
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/544>
Patrick Gaskin [Thu, 22 Apr 2021 13:04:43 +0000 (09:04 -0400)]
build-sys: meson: Merge system_conf config data from default_conf
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/547>
Georg Chini [Tue, 20 Apr 2021 10:18:43 +0000 (12:18 +0200)]
stream-restore: Fix use of uninitialized variable
The variable card_name in sink_input_preferred_sink_changed_cb and
source_output_preferred_source_changed_cb could be used uninitialized,
which leads to invalid database entries.
This patch fixes the problem.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/543>
Igor V. Kovalenko [Mon, 19 Apr 2021 17:02:19 +0000 (20:02 +0300)]
build-sys: meson: do not install manpages for disabled parts
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/540>
Igor V. Kovalenko [Sun, 18 Apr 2021 10:13:52 +0000 (13:13 +0300)]
build-sys: meson: allow building client libraries only
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/540>
Martin Wilck [Mon, 19 Apr 2021 15:55:28 +0000 (17:55 +0200)]
parecord: really fix recording OGG
432a91ed ("fix "Failed to open audio file" for FLAC and OGG)" claimed
to fix recording of OGG files with pacat, but it really fixed only
FLAC. This patch must be added on top to fix OGG, too.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/542>
Georg Chini [Mon, 19 Apr 2021 06:19:50 +0000 (08:19 +0200)]
loopback: Fix crash bug
The loopback message may be called after the sink input is already destroyed which causes
a crash. Also memory is leaked because the message object is not correctly freed.
This patch fixes the problems by adding a "dead" flag to the message structure and freeing
the message object on exit.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/541>
Igor V. Kovalenko [Fri, 16 Apr 2021 20:42:00 +0000 (23:42 +0300)]
alsa-mixer: Allow selected fallback mappings in all profile sets
When fallback mapping is selected all subsequent profile sets containing
selected mapping are ignored. When there are only e.g. fallback input mappings
available, admitted profile set will only contain one profile with selected
first input fallback mapping and no outputs, and rest of profiles will only
contain outputs and no inputs. When there are only fallback input and output
mappings, there will be no profiles admitted at all.
Fix this by making sure that selected first fallback input or output mapping
is actually allowed to exist in all probed profile sets.
Note while this change allows selected fallback mappings to be found in duplex
configuraitons, probing fallbacks still can fail if there is more than one input
fallback and first one (selected) does not work in duplex configurations.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/539>
Martin Wilck [Mon, 15 Mar 2021 12:01:28 +0000 (13:01 +0100)]
parecord: fix "Failed to open audio file" for FLAC and OGG
This patch fixes the following error:
$ pacat --file-format=ogg -r test.ogg
Failed to open audio file.
$ parecord sep.flac
Failed to open audio file.
libsndfile errors out if a WAV or OGG file is set to have anything but
SF_ENDIAN_FILE:
https://github.com/libsndfile/libsndfile/commit/
f4d1646e5cd96444a75c6327a9d49739f81d251e
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/526>
Igor V. Kovalenko [Thu, 15 Apr 2021 17:19:27 +0000 (20:19 +0300)]
bluetooth: disable HSP HS profile by default
A few headsets have issues if HFP HF profile connection is attempted before
HSP HS profile connection is closed. Looks like this could happen because
bluez bluetoothd alows to make simultaneous HSP HS and HFP HF peer connections.
One of affected headsets is WH-1000XM2
Until we find out how to prevent simultaneous HSP HS and HFP HF connections,
when native backend has HFP HF profile enabled (this is the default) do disable
HSP HS completely unless user explicitly request it via discovery modarg.
Do this by adding module-bluetooth-discover arg enable_native_hsp_hs,
default to inverse of enable_native_hfp_hf.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/538>
Igor V. Kovalenko [Wed, 14 Apr 2021 19:55:38 +0000 (22:55 +0300)]
bluetooth: handle HFP codec list in any order
HFP HF peer can send +BAC= list of codecs in any order and pa only expects "1,2"
Fix this by actually parsing codec list elements while looking for "2" (mSBC)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/537>
Lyndon Brown [Fri, 9 Apr 2021 00:47:58 +0000 (01:47 +0100)]
proplist: tweak documentation for `pa_proplist_get()`
to clarify that only mutating proplist calls potentially invalidate results
of earlier get requests, thus addressing the confusion found at [1].
[1]: https://github.com/jnqnfe/pulse-binding-rust/issues/38
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/536>
Igor V. Kovalenko [Thu, 4 Mar 2021 13:24:31 +0000 (16:24 +0300)]
bluetooth: mSBC: log lost input audio packets at debug level
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Wed, 3 Mar 2021 16:32:43 +0000 (19:32 +0300)]
bluetooth: add modarg to allow disabling mSBC codec
Add module-bluetooth-discover argument enable_msbc, default is true (enabled)
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Tue, 2 Mar 2021 18:33:24 +0000 (21:33 +0300)]
bluetooth: split BT codec from A2DP SEP configuration api
Common API for all bluetooth codecs is now pa_bt_codec.
API to negotiate and configure A2DP SEP over Bluez is now pa_a2dp_endpoint_conf.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Mon, 1 Mar 2021 21:52:59 +0000 (00:52 +0300)]
bluetooth: set initial packet size to 60
Raise initial MTU size to fix frame size when hci can do 60 byte frames.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Tue, 23 Feb 2021 21:58:43 +0000 (00:58 +0300)]
bluetooth: add more call indicators
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Thu, 25 Feb 2021 21:00:47 +0000 (00:00 +0300)]
bluetooth: produce silence on mSBC decoding error
We are supposed to conceal packet loss. This is not trivial but we can at least
produce silence instead of breaking on mSBC decoding error.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Thu, 25 Feb 2021 21:23:18 +0000 (00:23 +0300)]
bluetooth: remember negotiated HFP codec in native backend
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Mon, 22 Feb 2021 20:14:37 +0000 (23:14 +0300)]
bluetooth: show negotiated HFP codec
While codec switching for HFP is not implemented, show current codec via
messaging api.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Thu, 25 Feb 2021 19:36:31 +0000 (22:36 +0300)]
bluetooth: add mSBC to backend-ofono
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>
Igor V. Kovalenko [Sun, 21 Feb 2021 08:41:52 +0000 (11:41 +0300)]
bluetooth: prepare to redo transport writeout scheduling
Bluetooth SCO is synchronous stream, make our writes more uniformly paced.
To do this, first separate writing to socket from rendering a frame.
Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/507>