Courtney Goeltzenleuchter [Wed, 13 Sep 2017 21:49:39 +0000 (21:49 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests am:
b446f2dd21
am:
7148462684
Change-Id: Ic67d81ea7008a6cca1dfb17f181ccf6b525144ce
Courtney Goeltzenleuchter [Wed, 13 Sep 2017 21:32:07 +0000 (21:32 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests
am:
b446f2dd21
Change-Id: I3cee6f50232dcb639f4aba9e51c3c050b18bc2cc
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 23:10:51 +0000 (17:10 -0600)]
Require EGL_KHR_gl_colorspace for wide_color tests
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
v3: use EGL_NONE instead of DE_NULL when indicating that test
should use the default colorspace. That is do not include
the EGL_GL_COLORSPACE_KHR attribute in the appropriate
create function.
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Bug:
65291400
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
(cherry picked from commit
fbf132dcf9467388408627bee73d90f7e8a1d401)
Change-Id: I6bd6423e6eb5fe4bb4df0222ab624c41446b0b60
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 14:13:15 +0000 (14:13 +0000)]
Fix handling of EGL_NONE as color space am:
dd7aa9e15d
am:
5b6a83de51
Change-Id: I0274f44ebed4df844d90252cfcda800ae7fc2f79
Courtney Goeltzenleuchter [Tue, 12 Sep 2017 14:10:14 +0000 (14:10 +0000)]
Fix handling of EGL_NONE as color space
am:
dd7aa9e15d
Change-Id: Iae79d7d37f1147fca2c956a2497da0047e5c1176
Courtney Goeltzenleuchter [Mon, 11 Sep 2017 19:06:48 +0000 (13:06 -0600)]
Fix handling of EGL_NONE as color space
Color space of EGL_NONE was getting passed down and
driver threw EGL_BAD_ATTRIBUTE in response.
Issue was caused when changing the colorspace from nullptr
to EGL_NONE, missed a couple of places that needed to
test against EGL_NONE instead of nullptr.
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: If8812725be9d3858bf610c647ba53ff38944dd50
(cherry picked from commit
0d4e616c35fd3cbad82eb3c1f0a604dbbc6c8662)
Kenneth Graunke [Mon, 11 Sep 2017 19:40:36 +0000 (19:40 +0000)]
Merge changes Id437e220,I9d6b3fba am:
94b6d11640
am:
8a7aa6197d
Change-Id: I265da403e05540802aa8f9502c5c0466cf2e0c1b
Kenneth Graunke [Mon, 11 Sep 2017 19:36:02 +0000 (19:36 +0000)]
Merge changes Id437e220,I9d6b3fba
am:
94b6d11640
Change-Id: Ide9468359dc4bdfd9e47a3f5f3aaa345d8096cd8
Kenneth Graunke [Mon, 11 Sep 2017 19:31:58 +0000 (19:31 +0000)]
Merge "Use 64-bit math in work group size assertion." am:
bc6743fe27
am:
6c4a5cde18
Change-Id: I2894fbf53a863b6a76281cbe9b7a9614c671dc7f
Kenneth Graunke [Mon, 11 Sep 2017 19:31:44 +0000 (19:31 +0000)]
Merge "Delete incorrect invalid map tests." am:
6352f3c7c0
am:
5b357ce430
Change-Id: I7b1f588efdb92ad1c00b6b66d3377df6de184356
Treehugger Robot [Mon, 11 Sep 2017 19:30:30 +0000 (19:30 +0000)]
Merge changes Id437e220,I9d6b3fba
* changes:
Allow ES 3.2 contexts to run sRGB write control unsupported test.
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
Kenneth Graunke [Mon, 11 Sep 2017 19:27:27 +0000 (19:27 +0000)]
Merge "Use 64-bit math in work group size assertion."
am:
bc6743fe27
Change-Id: I8852b7cb4f89e1a7500cf5e216731a9b9f10ae31
Kenneth Graunke [Mon, 11 Sep 2017 19:27:13 +0000 (19:27 +0000)]
Merge "Delete incorrect invalid map tests."
am:
6352f3c7c0
Change-Id: I66916c3bcd4a064719062e3bb87c24c5f6ac2414
Treehugger Robot [Mon, 11 Sep 2017 18:58:52 +0000 (18:58 +0000)]
Merge "Use 64-bit math in work group size assertion."
Treehugger Robot [Mon, 11 Sep 2017 18:57:22 +0000 (18:57 +0000)]
Merge "Delete incorrect invalid map tests."
Kenneth Graunke [Sat, 9 Sep 2017 06:30:15 +0000 (23:30 -0700)]
Allow ES 3.2 contexts to run sRGB write control unsupported test.
GL_EXT_sRGB_write_control functionality is not part of ES 3.2.
So there's no need to restrict this to older contexts.
Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_unsupported_enum
Components: AOSP
Change-Id: Id437e220958c66acf65fd5c40004e1fde13fdf64
Kenneth Graunke [Sat, 9 Sep 2017 06:26:15 +0000 (23:26 -0700)]
Require GL_EXT_sRGB_write_control for GL_FRAMEBUFFER_SRGB enable/disable
This test required GL_EXT_sRGB_write_control or ES 3.2. But glEnable
and glDisable of GL_FRAMEBUFFER_SRGB requires the extension - ES 3.2
doesn't provide that functionality. ES 3.2 implementations without the
extension would fail. Now they report NotSupported.
Affects:
dEQP-GLES31.functional.fbo.srgb_write_control.framebuffer_srgb_enabled
Components: AOSP
Change-Id: I9d6b3fba892288354620ecbbc51ef7a351507e43
Kenneth Graunke [Fri, 8 Sep 2017 22:37:38 +0000 (15:37 -0700)]
Delete incorrect invalid map tests.
The citation given in these tests comes from the OpenGL man pages, which
are not authoritative. The ES 3.2 specification says:
"6.3.2 Effects of Mapping Buffers on Other GL Commands
Any GL command which attempts to read from, write to, or change the
state of a buffer object may generate an INVALID_OPERATION error if
all or part of the buffer object is mapped. However, only commands
which explicitly describe this error are required to do so. If an
error is not generated, using such commands to perform invalid
reads, writes, or state changes will have undefined results and may
result in GL interruption or termination."
Importantly, it says "_may_ generate an INVALID_OPERATION error". Some
drivers choose not to implement this to avoid the CPU overhead required
to enforce this optional restriction.
Affects:
- dEQP-GLES31.functional.debug.negative_coverage.*.vertex_array.*_invalid_map
Components: AOSP
Change-Id: I26eb6ac0dfffbfc50612bed44d1beb6eb3d366c9
james.glanville [Fri, 8 Sep 2017 21:41:01 +0000 (21:41 +0000)]
Merge "Relax EGL functional test thresholds" am:
a1ec716449
am:
db760778a9
Change-Id: I997bdf950f65300a677703b54ed6262702e52a73
james.glanville [Fri, 8 Sep 2017 21:39:27 +0000 (21:39 +0000)]
Merge "Relax EGL functional test thresholds"
am:
a1ec716449
Change-Id: I719ba3fa67da541722ac65f2b5d2c847b98824e0
Treehugger Robot [Fri, 8 Sep 2017 21:25:48 +0000 (21:25 +0000)]
Merge "Relax EGL functional test thresholds"
Kenneth Graunke [Thu, 13 Jul 2017 01:44:11 +0000 (18:44 -0700)]
Use 64-bit math in work group size assertion.
If the maximum workgroup size in each dimension is large enough, this
can overflow, causing the comparison to fail. For example, on Intel
Haswell, we get:
assert(2048 * 2048 * 2048 > 2048) -> assert(0 > 2048) -> fail
Casting one value to deInt64 causes the multiplications to occur as
64-bit values, so we don't overflow.
Affects:
dEQP-GLES31.functional.debug.negative_coverage.*.compute.invalid_maximum_work_group_sizes
Components: AOSP
Change-Id: Ie03627a378f4fdc46ce241bbdd3693ae829c217d
james.glanville [Tue, 29 Aug 2017 10:40:53 +0000 (11:40 +0100)]
Relax EGL functional test thresholds
The current threshold of 0.02 was selected as suitable for 8-bit color depths.
However, for smaller bit depths such as RGB565 this threshold is too strict
and it has been relaxed to allow a larger error for low bit depth formats.
Affects:
dEQP-EGL.functional.render.*
Change-Id: I6d6e061be02bc8e63cb5d9662feb804bc839d567
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:47:58 +0000 (16:47 +0000)]
Check for EGL_KHR_gl_colorspace before using it am:
2cf32ffa6e
am:
e3992de385
Change-Id: Ia9a47fb3071a9c7d679bebc7343d551c4c7e0317
Courtney Goeltzenleuchter [Wed, 6 Sep 2017 16:45:57 +0000 (16:45 +0000)]
Check for EGL_KHR_gl_colorspace before using it
am:
2cf32ffa6e
Change-Id: I862ea02e9803fc946a2e71e3145d806f76278676
Courtney Goeltzenleuchter [Tue, 5 Sep 2017 23:48:27 +0000 (17:48 -0600)]
Check for EGL_KHR_gl_colorspace before using it
Bug:
65376495
Test: adb -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: Ief654c998e93d72899225120b0ca1ab2fa3ca624
Alexander Galazin [Tue, 5 Sep 2017 21:47:03 +0000 (21:47 +0000)]
Merge "Add more allowed 'dot' alternatives" am:
7e8c3b2d00
am:
c6aef79622
Change-Id: I498ba85cd282a17b9fdb8a3c5381981a45521739
Alexander Galazin [Tue, 5 Sep 2017 21:44:31 +0000 (21:44 +0000)]
Merge "Add more allowed 'dot' alternatives"
am:
7e8c3b2d00
Change-Id: I8ea74cc7658e034905be82c02fafc7f01b4e3705
Treehugger Robot [Tue, 5 Sep 2017 21:35:29 +0000 (21:35 +0000)]
Merge "Add more allowed 'dot' alternatives"
Mika Isojrvi [Tue, 5 Sep 2017 19:49:21 +0000 (19:49 +0000)]
Fix unused uniform bug in EGL robustness tests am:
7806d74666
am:
32fe3869a7
Change-Id: Ic02f5be9192c5295cc56be26f06cd76bf2e6bdde
Mika Isojrvi [Tue, 5 Sep 2017 19:47:23 +0000 (19:47 +0000)]
Fix unused uniform bug in EGL robustness tests
am:
7806d74666
Change-Id: I7bdb3742437ed0abe590f5c011bf1b78cade9419
Mika Isojärvi [Tue, 5 Sep 2017 17:43:35 +0000 (17:43 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests" am:
e19c3ff127
am:
fb660dc26b
Change-Id: I3266c0593f72429a2c3fe3e619cd94d129c2dd63
Mika Isojärvi [Tue, 5 Sep 2017 17:33:37 +0000 (17:33 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
am:
e19c3ff127
Change-Id: I4eadac66e4d313347a6b3fea1c4585bb98507641
Mika Isojärvi [Thu, 31 Aug 2017 19:13:05 +0000 (12:13 -0700)]
Fix unused uniform bug in EGL robustness tests
Bug:
64845766
Bug:
65175554
Test: Ran tests on couple of Google devices
Change-Id: Iee2918c1e45ad305dd9ca30f1b81998bdac06127
Treehugger Robot [Tue, 5 Sep 2017 17:18:37 +0000 (17:18 +0000)]
Merge "Fix missing SSBO binding in EGL robustness tests"
Pyry Haulos [Tue, 5 Sep 2017 16:07:54 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253 am:
745856554f am:
2b79153434
am:
c0fc41f6bc
Change-Id: Id806b46d9b9c1001a694ae637539fa6f36aa4aea
Pyry Haulos [Tue, 5 Sep 2017 16:07:31 +0000 (16:07 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe am:
f909a2d16c am:
3976e3eade
am:
4564f27dba
Change-Id: I18a102999357266e6c37f1da9f7248c6daf11e06
Pyry Haulos [Tue, 5 Sep 2017 15:59:55 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253 am:
745856554f
am:
2b79153434
Change-Id: I59da57b654d86c8e5a49068db970566c8e5373d8
Pyry Haulos [Tue, 5 Sep 2017 15:59:31 +0000 (15:59 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe am:
f909a2d16c
am:
3976e3eade
Change-Id: I6cb9841790f4027016df0c7cf8023ab991334125
Pyry Haulos [Tue, 5 Sep 2017 15:51:16 +0000 (15:51 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac am:
c3c3b95253
am:
745856554f
Change-Id: Ie2af4250a408f55c2857629e00b3915e23a5268b
Pyry Haulos [Tue, 5 Sep 2017 15:51:00 +0000 (15:51 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
6d0cee6923 am:
4fa7f75d5f
am:
eecfee50a9
Change-Id: I9949dddd9c57e5817c618e19a67c75393e33b3d5
Pyry Haulos [Tue, 5 Sep 2017 15:50:59 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f am:
36b26f80fe
am:
f909a2d16c
Change-Id: I3056d6017cd988ff62104131642a22a88b26b24f
Pyry Haulos [Tue, 5 Sep 2017 15:50:28 +0000 (15:50 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283 am:
79f028e0ac
am:
c3c3b95253
Change-Id: I62ff995a5e6b0140777b13848af33ece4f6248e8
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
6d0cee6923
am:
4fa7f75d5f
Change-Id: I940607508851c13fd4ae3a35e0eb427f96efc571
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
342eb176e6
am:
1b6fe918aa
Change-Id: I10245b13f72c7b0cc51367f8f0fab516d60538f2
Pyry Haulos [Tue, 5 Sep 2017 15:41:29 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2 am:
ac400ff59f
am:
36b26f80fe
Change-Id: Ie960b01bc31c94107bf7c545aef03b2e9d5671ed
Pyry Haulos [Tue, 5 Sep 2017 15:41:28 +0000 (15:41 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3 am:
0d9b810283
am:
79f028e0ac
Change-Id: I9523ce132950603adc6a0adf77b9833f670dd6c4
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
342eb176e6
Change-Id: Iad7f205649553e7096d52a0cbf16d868ba405085
Pyry Haulos [Tue, 5 Sep 2017 15:31:57 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
6d0cee6923
Change-Id: I2c843552baf45bfc918fce8cb7a9c40b3fd8adad
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
9e85a126d2
am:
ac400ff59f
Change-Id: I8fd3f2dac244cddb228d780cb2e7ab4943b1cb9b
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3
am:
0d9b810283
Change-Id: Ic07c0dafc51bf12a82794d02786b885f8b1323f8
Pyry Haulos [Tue, 5 Sep 2017 15:22:27 +0000 (15:22 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: I86a852a2216971095d4aa256a97f0b8e68e73646
Pyry Haulos [Tue, 5 Sep 2017 15:21:58 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Ia7cd7612e6c2f0f961837734f1900a21b52a0e39
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Idf3c0904f9695e04b48901c23c79b7dcd101d0dc
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
338a411fd3
Change-Id: I6edcc0661c9d702a5bb518d24eebf7702145318f
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Pyry Haulos [Tue, 5 Sep 2017 15:13:55 +0000 (15:13 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: I41d95ce51483f786706f9402701208801e73ecdc
Alexander Galazin [Tue, 22 Aug 2017 13:59:49 +0000 (15:59 +0200)]
Add more allowed 'dot' alternatives
Expanded dot may be re-associated in multiple ways.
Add all possible alternatives to prevent precision failures.
Components: AOSP
VK-GL-CTS issue: 634
Google issue:
28767510
Affects:
dEQP-GLES3.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES3.functional.shaders.builtin_functions.precision.reflect.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.dot.*
dEQP-GLES31.functional.shaders.builtin_functions.precision.reflect.*
Change-Id: I2a91add1b92363acab2172179320cd880da779ec
Mika Isojärvi [Thu, 31 Aug 2017 18:54:48 +0000 (11:54 -0700)]
Fix missing SSBO binding in EGL robustness tests
Bug:
64845581
Bug:
65175642
Test: Ran the tests on couple of Google devices
Change-Id: I3a98fe12802e6951483499e800cd3fe7412e37f0
Pyry Haulos [Thu, 9 Mar 2017 17:46:29 +0000 (09:46 -0800)]
Fix issues in pipeline.timestamp.transfer_tests
This change fixes two issues:
* Buffer overrun in vkCmdCopyBufferToImage and vkCmdCopyImageToBuffer
tests.
* Validation error (srcStageMask must not be 0).
VK-GL-CTS issue: 185
Components: Vulkan
Change-Id: I9679566f08c4a914eb6066bab248abd6d51e0f7e
Tapani Plli [Wed, 30 Aug 2017 17:58:00 +0000 (17:58 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests. am:
2a3edba962
am:
3dc144a93d
Change-Id: I7ae4e8ef94f7231cdec7e7ef4cc9e3d5b7613df4
Tapani Plli [Wed, 30 Aug 2017 17:51:01 +0000 (17:51 +0000)]
Require EGL_KHR_gl_colorspace for wide_color tests.
am:
2a3edba962
Change-Id: Ib187061a097641d56876d85b1af68baae7bc6f1d
Tapani Pälli [Mon, 28 Aug 2017 06:20:53 +0000 (09:20 +0300)]
Require EGL_KHR_gl_colorspace for wide_color tests.
These tests utilize enum EGL_GL_COLORSPACE_KHR which is introduced by
EGL_KHR_gl_colorspace extension, check first for support and skip the
test if extension is not supported.
v2: loosen the check, only check when enum in use (Courtney)
Change-Id: I891a6fdcce49ac6dcd42577076d4cf64a143dd38
Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Courtney Goeltzenleuchter [Thu, 24 Aug 2017 23:19:28 +0000 (23:19 +0000)]
Merge "Check only what's needed and use threshold" am:
923d047106
am:
7fd5af1735
Change-Id: I2663d7c9638d0040dd8a500ae0aa8090844e578b
Courtney Goeltzenleuchter [Thu, 24 Aug 2017 23:11:50 +0000 (23:11 +0000)]
Merge "Check only what's needed and use threshold"
am:
923d047106
Change-Id: I375f81f9ea270da5ca86bbb9c0a0465a82dbec19
Treehugger Robot [Thu, 24 Aug 2017 22:57:17 +0000 (22:57 +0000)]
Merge "Check only what's needed and use threshold"
Mika Isojärvi [Thu, 24 Aug 2017 22:40:34 +0000 (22:40 +0000)]
Merge Vulkan CTS 1.0.2.5 into aosp/master am:
76a147bf66
am:
9f330c685b
Change-Id: I5cca00d1f902a169550e2077e17c2fd52cb7ac9b
Mika Isojärvi [Thu, 24 Aug 2017 22:35:31 +0000 (22:35 +0000)]
Merge Vulkan CTS 1.0.2.5 into aosp/master
am:
76a147bf66
Change-Id: I05b18f9180285aa9b140b63f132020874d83e9d4
Mika Isojärvi [Thu, 24 Aug 2017 20:13:19 +0000 (13:13 -0700)]
Merge Vulkan CTS 1.0.2.5 into aosp/master
Bug:
64932237
Change-Id: Ic2758a85f3a8f8cf00985b03a89830ba509f824d
Courtney Goeltzenleuchter [Fri, 28 Jul 2017 19:51:31 +0000 (13:51 -0600)]
Check only what's needed and use threshold
Check for only the functionality needed for a specific test.
E.g. if testing floating point color, don't need to check
for support of 10:10:10:2 pixel format.
Some devices are not able to hit the exact values calculated.
Not unexpected, update tests to use thresholds.
Note: waiting on results of b/
64487716. Seeing failure on
Pixel devices. Need to make sure it's not a test issue.
Test: adb -s
0424415804161004f80d -d shell am start \
-n com.drawelements.deqp/android.app.NativeActivity \
-e cmdLine '"deqp --deqp-case=dEQP-EGL.functional.wide_color.* \
--deqp-log-filename=/sdcard/dEQP-Log.qpa"'
Change-Id: I2adb31eaa3b189179aeceb9e8f6b1ac8587b6027
(cherry picked from commit
041a1b5e82db7a6945aaefd791639de1c8c9e84d)
Michael Chock [Tue, 22 Aug 2017 18:43:02 +0000 (18:43 +0000)]
Merge "Avoid thread state races in EGL multithread tests" am:
5a0d512e5b am:
0efcf60ff5
am:
d3f6571fff
Change-Id: I66748716e20fea93d29cbb114ed7301908657f16
Alexander Galazin [Tue, 22 Aug 2017 18:42:43 +0000 (18:42 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present" am:
4929480c47 am:
df3f2b14f6
am:
a7b9f7a5d9
Change-Id: I2b6fcc4798f08029ae47f83ca699aa9e6c1dc4d3
Michael Chock [Tue, 22 Aug 2017 18:39:28 +0000 (18:39 +0000)]
Merge "Avoid thread state races in EGL multithread tests" am:
5a0d512e5b
am:
0efcf60ff5
Change-Id: Ide30bf228e53857ea93ce7a91e4c2b10d8a845a0
Alexander Galazin [Tue, 22 Aug 2017 18:39:11 +0000 (18:39 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present" am:
4929480c47
am:
df3f2b14f6
Change-Id: I330781b5ea59882db46629591b30f49ae6486a6a
Michael Chock [Tue, 22 Aug 2017 18:32:44 +0000 (18:32 +0000)]
Merge "Avoid thread state races in EGL multithread tests"
am:
5a0d512e5b
Change-Id: I775814f0bfe3cad21a3cada9c017d08e5a2aa739
Alexander Galazin [Tue, 22 Aug 2017 18:32:21 +0000 (18:32 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present"
am:
4929480c47
Change-Id: Ie0e580b58bace63bb7dafc4fafdbe17f766ae3a3
Treehugger Robot [Tue, 22 Aug 2017 18:13:36 +0000 (18:13 +0000)]
Merge "Avoid thread state races in EGL multithread tests"
Treehugger Robot [Tue, 22 Aug 2017 18:10:07 +0000 (18:10 +0000)]
Merge "Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present"
Alexander Galazin [Wed, 16 Aug 2017 09:36:01 +0000 (11:36 +0200)]
Run Draw*BaseVertex if EXT_draw_elements_base_vertex is present
Draw*BaseVertex methods are enabled if
the EXT_draw_elements_base_vertex extension is present
Follow-up on
1b1ea05b
Components: AOSP
Affects: dEQP-GLES31.functional.draw_base_vertex.*
Change-Id: If8a4860a956c771ec5ea3341e2227f437b12a286
Mika Isojrvi [Thu, 17 Aug 2017 00:28:39 +0000 (00:28 +0000)]
Fix texture mip level size in framebuffer fetch tests am:
be0d165a5d am:
0f01836518
am:
cc06f40d06
Change-Id: Ia5336f05e320268f49b41a10f419c01b690e291f
Mika Isojrvi [Thu, 17 Aug 2017 00:17:54 +0000 (00:17 +0000)]
Fix texture mip level size in framebuffer fetch tests am:
be0d165a5d
am:
0f01836518
Change-Id: I39f281404c2497d957ae91d93d368202f83febfb
Mika Isojrvi [Thu, 17 Aug 2017 00:08:48 +0000 (00:08 +0000)]
Fix texture mip level size in framebuffer fetch tests
am:
be0d165a5d
Change-Id: I7fb9c075ee79e411ea295999e9edd7f38a5e5bc9
Mika Isojärvi [Wed, 16 Aug 2017 20:40:22 +0000 (13:40 -0700)]
Fix texture mip level size in framebuffer fetch tests
Bug:
64280744
Test: Ran tests with multiple Google devices
Change-Id: I369a3c9b16270655332d5a608207f0da2633e0fe
james.glanville [Wed, 16 Aug 2017 19:12:11 +0000 (19:12 +0000)]
Merge "Use safe glFramebufferTexture* function" am:
ec5ccbe144 am:
d4c3e6e71b
am:
1f2e434e86
Change-Id: I05b273c4c5842ef9713cea1e0ee5db14965bc6df
Michael Chock [Wed, 16 Aug 2017 19:11:52 +0000 (19:11 +0000)]
Merge "Do not use degenerate frames in EGL tests" am:
f5971fe17f am:
4a2d8af710
am:
bdab538931
Change-Id: I659eb59a332af92c90de471a3cdb6eb2ce9ec4d2
james.glanville [Wed, 16 Aug 2017 19:08:36 +0000 (19:08 +0000)]
Merge "Use safe glFramebufferTexture* function" am:
ec5ccbe144
am:
d4c3e6e71b
Change-Id: I31749dfd7ca7258c702b3d00c3f438cebbbf4056
Michael Chock [Wed, 16 Aug 2017 19:08:22 +0000 (19:08 +0000)]
Merge "Do not use degenerate frames in EGL tests" am:
f5971fe17f
am:
4a2d8af710
Change-Id: I86d818ee189deef3102b0f112378cef1723edad0
james.glanville [Wed, 16 Aug 2017 19:04:43 +0000 (19:04 +0000)]
Merge "Use safe glFramebufferTexture* function"
am:
ec5ccbe144
Change-Id: I156ecc2a6ed17e3e23ef17ebbe026be27c1670c3
Michael Chock [Wed, 16 Aug 2017 19:04:22 +0000 (19:04 +0000)]
Merge "Do not use degenerate frames in EGL tests"
am:
f5971fe17f
Change-Id: I9807e27047a0d0280e06bc826cab3e6cb88b5ab6
Treehugger Robot [Wed, 16 Aug 2017 18:59:45 +0000 (18:59 +0000)]
Merge "Use safe glFramebufferTexture* function"
Treehugger Robot [Wed, 16 Aug 2017 18:59:42 +0000 (18:59 +0000)]
Merge "Do not use degenerate frames in EGL tests"
Alexander Galazin [Wed, 16 Aug 2017 18:54:52 +0000 (18:54 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported" am:
f96636fdfa am:
eaf6e29e46
am:
3946a20ebc
Change-Id: Ifc2e7f4ef52d03eb2f6570f5fc83818ee4e2c190
Alexander Galazin [Wed, 16 Aug 2017 18:51:50 +0000 (18:51 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported" am:
f96636fdfa
am:
eaf6e29e46
Change-Id: If70e55237194763a02f31d3a20bbc475403d8670
Alexander Galazin [Wed, 16 Aug 2017 18:47:50 +0000 (18:47 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"
am:
f96636fdfa
Change-Id: Iccb20250f9b98f983fc831911a1f9b4d4a98fbfb
Treehugger Robot [Wed, 16 Aug 2017 18:36:54 +0000 (18:36 +0000)]
Merge "Report tests using Draw*BaseVertex as NotSupported"
Alexander Galazin [Wed, 16 Aug 2017 18:27:18 +0000 (18:27 +0000)]
Merge "Fix error double accounting in fuzzyCompare()" am:
0cf17c4bf8 am:
f64327185c
am:
aca02e1db5
Change-Id: I33c50071a663091adfc992b518610b68ed46b303
Alexander Galazin [Wed, 16 Aug 2017 18:23:48 +0000 (18:23 +0000)]
Merge "Fix error double accounting in fuzzyCompare()" am:
0cf17c4bf8
am:
f64327185c
Change-Id: I5a42417bee0eab58fc2cae3a653e41e4624cb2eb
Alexander Galazin [Wed, 16 Aug 2017 18:20:18 +0000 (18:20 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"
am:
0cf17c4bf8
Change-Id: Ife3e4f1bd13c6f4cb939950635880ce32d2b1df3
Treehugger Robot [Wed, 16 Aug 2017 18:06:52 +0000 (18:06 +0000)]
Merge "Fix error double accounting in fuzzyCompare()"
Michael Chock [Mon, 14 Aug 2017 15:36:11 +0000 (08:36 -0700)]
Avoid thread state races in EGL multithread tests
Previously, threads objects inside dEQP-EGL.functional.multithread.*
tests would conflate thread execution status with test results. The
former would only be set inside the thread, but the latter could be set
by other threads (e.g., a test thread might set its status to RUNNING
while another test might attempt to set the status of NOT_SUPPORTED).
These race conditions could lead to incorrect results.
Fix this by moving error and not-supported states out of the thread
execution state, and instead storing them as single-purpose flags inside
the test case object, avoiding the possibility of conflicting writes.
Change-Id: I2b117aa98c1c2b69b0d134610d6fd37656083e54