scroggo@google.com [Tue, 25 Sep 2012 17:36:36 +0000 (17:36 +0000)]
Fix a warning in PictureBenchmark.
Forgot to change from false to NULL. False does the right thing,
but gives a warning. Fix the warning.
Review URL: https://codereview.appspot.com/6570049
git-svn-id: http://skia.googlecode.com/svn/trunk@5666
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 25 Sep 2012 15:37:50 +0000 (15:37 +0000)]
Reimplement drawBitmapRectToRect to correctly handle fraction srcRect.
The prev impl relied on drawBitmap "deducing" the destination rect by applying
the computed matrix to the bitmap's bounds. This cannot be done if the srcRect
is fractional, and therefore not representable w/ a bitmap.
The new impl computes the same matrix, but calls down to the device via drawRect
+ a bitmap_shader. This allows us to specfiy the dstRect explicitly.
The possible down-side is that we now rely on the device subclass to efficiently
handle draRect+shader, instead of calling its drawBitmap entry-point.
To give the device the chance to handle this differently, I now call through to
a new device virtual: drawBitmapRect. The default impl is to create the shader
and call drawRect, but a subclass can intercept that.
For now, the GPU override of drawBitmapRect is mimicing the old behavior (by
rounding the srcRect to an iRect). This preserves its ability to call drawBitmap
which handles very-large textures, but shows some gittering/imprecision, due to
the rounding. ... this is the same GPU behavior we have before this CL.
Review URL: https://codereview.appspot.com/6542065
git-svn-id: http://skia.googlecode.com/svn/trunk@5663
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 25 Sep 2012 14:32:42 +0000 (14:32 +0000)]
This patch adds support for optional processing of the alpha channel in
the matrix convolution filter. Test cases are added to the GM and the
bench.
NOTE: This will require rebaselining the matrixconvolution GM, so it will
likely turn the bots red until that is done.
https://codereview.appspot.com/6547049/
git-svn-id: http://skia.googlecode.com/svn/trunk@5661
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 25 Sep 2012 02:01:21 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5656
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 25 Sep 2012 00:39:51 +0000 (00:39 +0000)]
"fix" chrome build
git-svn-id: http://skia.googlecode.com/svn/trunk@5655
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 21:38:38 +0000 (21:38 +0000)]
fix mac builds
comment out 64 bit / mac error check
git-svn-id: http://skia.googlecode.com/svn/trunk@5654
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Mon, 24 Sep 2012 21:27:14 +0000 (21:27 +0000)]
Build fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5653
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 20:08:43 +0000 (20:08 +0000)]
unbreak the build part ii
allow android in debugger.gyp
git-svn-id: http://skia.googlecode.com/svn/trunk@5651
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 19:41:43 +0000 (19:41 +0000)]
unbreak the build
move define of skia_arch_type to front
git-svn-id: http://skia.googlecode.com/svn/trunk@5650
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Mon, 24 Sep 2012 19:33:57 +0000 (19:33 +0000)]
iOS support work in progress
include/core/SkTypes.h
- address unsigned warning
include/core/SkInstCnt.h
src/core/SkInstCnt.cpp
gyp/common.gypi
- always define SK_ENABLE_INST_COUNT for debug builds
src/views/mac/SkNSView.mm
- only call glClear if there is a GL context
src/ports/SkImageDecoder_CG.cpp
- fix iOS hack by using proper include
gyp/opts.gyp
- exclude more ARM files from iOS for now (see issue 900)
gyp/common_conditions.gypi
- add release, more ios specific common settings
gyp/bench.gyp
- add iOS condition
gyp/SampleApp.gyp
- remove precompiled header, hardcoded SDK path
- add more frameworks
gyp/debugger.gyp
- fix syntax error
- add iOS/Android condition
gyp/core.gyp
- remove hardcoded SDK path, add more frameworks
gyp/common_variables.gypi
- add ios SDK path
- add ios SDK version
gyp/iOSSampleApp.gyp
- remove obsolete project
gyp/zlib.gyp
- add ios library path
Review URL: https://codereview.appspot.com/6551070
git-svn-id: http://skia.googlecode.com/svn/trunk@5649
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 24 Sep 2012 19:33:59 +0000 (19:33 +0000)]
Fix for GrTextureStripAtlas memory leak
https://codereview.appspot.com/6549050/
git-svn-id: http://skia.googlecode.com/svn/trunk@5648
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 24 Sep 2012 14:20:00 +0000 (14:20 +0000)]
Addressed xcode analysis complaints
http://codereview.appspot.com/6558048/
git-svn-id: http://skia.googlecode.com/svn/trunk@5646
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 24 Sep 2012 13:16:52 +0000 (13:16 +0000)]
Whitespace change to trigger rebuild after tweaking Windows build slaves
git-svn-id: http://skia.googlecode.com/svn/trunk@5645
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 21 Sep 2012 19:12:32 +0000 (19:12 +0000)]
When recording a GM to a picture, pass the GM's size to beginRecording.
Review URL: https://codereview.appspot.com/6552047
git-svn-id: http://skia.googlecode.com/svn/trunk@5644
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 21 Sep 2012 17:54:46 +0000 (17:54 +0000)]
Make flattenables no longer depend on global static initializers.
Instead, force all builds to call InitializeFlattenables.
Remove the make_debugger script, which was created to force
rebuilding without global static initializers so that all flattenables
would be linked. It is no longer necessary since all flattenables
will be linked thanks to InitializeFlattenables, which now can (and
must) be called when global static initializers are turned on.
BUG=https://code.google.com/p/skia/issues/detail?id=903
BUG=https://code.google.com/p/skia/issues/detail?id=902
Review URL: https://codereview.appspot.com/6548044
git-svn-id: http://skia.googlecode.com/svn/trunk@5642
2bbb7eff-a529-9590-31e7-
b0007b416f81
vandebo@chromium.org [Fri, 21 Sep 2012 17:50:50 +0000 (17:50 +0000)]
[PDF] Fix name generation - / needs to be escaped.
BUG=chromium 148422
Review URL: https://codereview.appspot.com/6542044
git-svn-id: http://skia.googlecode.com/svn/trunk@5641
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Sep 2012 17:38:06 +0000 (17:38 +0000)]
check for very large blurs, and don't try to cache the result in fontcache
http://code.google.com/p/chromium/issues/detail?id=138208
git-svn-id: http://skia.googlecode.com/svn/trunk@5640
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 21 Sep 2012 12:15:13 +0000 (12:15 +0000)]
disable experiemental hack to try to speedup floor
git-svn-id: http://skia.googlecode.com/svn/trunk@5636
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 21 Sep 2012 02:01:01 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5635
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 22:10:33 +0000 (22:10 +0000)]
Adding hasPendingCommands API method to SkDeferredCanvas
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
Review URL: https://codereview.appspot.com/6550050
git-svn-id: http://skia.googlecode.com/svn/trunk@5632
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 22:05:27 +0000 (22:05 +0000)]
Whitespace change to trigger a bot cycle after r5630
git-svn-id: http://skia.googlecode.com/svn/trunk@5631
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 20:42:44 +0000 (20:42 +0000)]
Fixing how deferred canvas purges itself when a clear is recoreded.
This fixes performance because the old code was not reconstructing the clip
state correctly. This was causing a major performance degradation in the
Galactic IE testdrive demo. This fix also enbles the purge
on clear optimization when there is saved state on the matrix/clip stack.
The approach taken to solve the problem consists in purging by running the
playback silently. The previous approach was tearing down and
restarting the gpipe, which required reconstructing state, which is fragile
and hard to do correctly, and has the side effect of clearing the bitmap heap
and the flattened dictionary.
Note: This CL is expected to slightly degrade performance of the
deferred_canvas_record bench, which uses the skip on clear optimization.
This is because a silent playback takes more time that just destroying
the SkGPipe. Correctness trumps performance.
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
Review URL: https://codereview.appspot.com/6531048
git-svn-id: http://skia.googlecode.com/svn/trunk@5627
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Thu, 20 Sep 2012 19:35:43 +0000 (19:35 +0000)]
Adding a silent playback option to SkGPipeRead
Testing state consistency after silent playback in CanvasTest indirectly
through SkDeferredCanvas.
BUG=http://code.google.com/p/chromium/issues/detail?id=146178
TEST=CanvasTest unit test, and bench with --mode deferredSilent
Review URL: https://codereview.appspot.com/6542047
git-svn-id: http://skia.googlecode.com/svn/trunk@5619
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 20 Sep 2012 19:09:17 +0000 (19:09 +0000)]
Got debugger compiling again after SkCanvas API change
http://codereview.appspot.com/6543047/
git-svn-id: http://skia.googlecode.com/svn/trunk@5616
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 19:05:33 +0000 (19:05 +0000)]
Prevent LinearRegression from dividing by zero so the GenerateBenchGraphs step doesn't blow up if the data is all zeroes.
http://codereview.appspot.com/6546049/
git-svn-id: http://skia.googlecode.com/svn/trunk@5615
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 18:54:04 +0000 (18:54 +0000)]
Remove automatic resizing in *_pictures
Review URL: https://codereview.appspot.com/6554045
git-svn-id: http://skia.googlecode.com/svn/trunk@5614
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 20 Sep 2012 18:52:10 +0000 (18:52 +0000)]
Update bench_expectations
We only have three runs since the regression was fixed in r5605:
153.68, 154.09, 153.71
These bounds seem reasonable to me.
Review URL: https://codereview.appspot.com/6541049
git-svn-id: http://skia.googlecode.com/svn/trunk@5613
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 18:19:26 +0000 (18:19 +0000)]
remove use of SkRefPtr in public header (SkPDFDocument.h)
Review URL: https://codereview.appspot.com/6546048
git-svn-id: http://skia.googlecode.com/svn/trunk@5612
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 18:04:12 +0000 (18:04 +0000)]
remove unused parameter (that also slowed us down) to SkAutoTDelete
git-svn-id: http://skia.googlecode.com/svn/trunk@5611
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 17:59:49 +0000 (17:59 +0000)]
Fix premul alpha problems w/matrix convolution filter, and re-enable the bench.
http://codereview.appspot.com/6541043/
git-svn-id: http://skia.googlecode.com/svn/trunk@5610
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 20 Sep 2012 17:52:20 +0000 (17:52 +0000)]
remove all SkRefPtr from SkPDFDevice.h
Review URL: https://codereview.appspot.com/6542049
git-svn-id: http://skia.googlecode.com/svn/trunk@5609
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Thu, 20 Sep 2012 16:10:02 +0000 (16:10 +0000)]
Pull SDKROOT into a gyp variable, so it can be locally overridden. This
allows building on Lion or Mountain Lion using XCode 4.4.
http://codereview.appspot.com/6553044/
git-svn-id: http://skia.googlecode.com/svn/trunk@5607
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Thu, 20 Sep 2012 15:45:41 +0000 (15:45 +0000)]
first cut at making iOS work
Replace __arm__ with SK_CPU_ARM
add support for iOS simulator and device
fix const warning in iOSSampleApp
update gyp files
https://code.google.com/p/skia/issues/detail?id=900
tracks fixing missing arm assembly
Review URL: https://codereview.appspot.com/6552045
git-svn-id: http://skia.googlecode.com/svn/trunk@5606
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Thu, 20 Sep 2012 15:37:30 +0000 (15:37 +0000)]
Fix GrTextureAccess::operator ==
compare the textures, correctly intepret memcmp result, don't compare last byte of swizzle array which must be 0.
BUG=895
Review URL: https://codereview.appspot.com/6542048
git-svn-id: http://skia.googlecode.com/svn/trunk@5605
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 20 Sep 2012 14:54:21 +0000 (14:54 +0000)]
In render_pictures tiled rendering, draw a separate PNG for each tile.
Since the passed in picture may represent an image which is too large
to be represented on the GPU, never create such a large canvas. Instead,
after drawing to each tile, create a file showing just that tile.
Review URL: https://codereview.appspot.com/6532056
git-svn-id: http://skia.googlecode.com/svn/trunk@5603
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 20 Sep 2012 14:42:33 +0000 (14:42 +0000)]
In bench_pictures, use a pool of tiles for multicore drawing.
Also includes some code cleanup and code sharing.
Allow setting the number of threads on the command line.
Rename ThreadSafePipeController::playback to ::draw, to be the same
as SkPicture so DrawTileToCanvas can take a template parameter.
Disallow multithreading with GPU turned on.
Display help information with improper tiled arguments.
BUG=https://code.google.com/p/skia/issues/detail?id=871
Review URL: https://codereview.appspot.com/6536050
git-svn-id: http://skia.googlecode.com/svn/trunk@5602
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Sep 2012 22:50:21 +0000 (22:50 +0000)]
Yet another speculative Android fix. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5600
2bbb7eff-a529-9590-31e7-
b0007b416f81
junov@chromium.org [Wed, 19 Sep 2012 22:48:34 +0000 (22:48 +0000)]
Renaming a couple methods in SkDeferredCanvas.cpp to improve readability
Review URL: https://codereview.appspot.com/6536060
git-svn-id: http://skia.googlecode.com/svn/trunk@5599
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 19 Sep 2012 22:40:54 +0000 (22:40 +0000)]
Speculative fix for Android GMs. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5598
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 19 Sep 2012 17:28:29 +0000 (17:28 +0000)]
Skip empty directories and input files not ending in .skp in *_pictures
Addressing https://code.google.com/p/skia/issues/detail?id=886
Review URL: https://codereview.appspot.com/6531047
git-svn-id: http://skia.googlecode.com/svn/trunk@5597
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 19 Sep 2012 17:05:55 +0000 (17:05 +0000)]
begin to skiafy PDF headers : removing use of SkRefPtr
Review URL: https://codereview.appspot.com/6526050
git-svn-id: http://skia.googlecode.com/svn/trunk@5596
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Wed, 19 Sep 2012 12:32:06 +0000 (12:32 +0000)]
Whitespace change to trigger a rebuild after removing bad bench data from r5592
This should stop the failures from GenerateBenchGraphs
git-svn-id: http://skia.googlecode.com/svn/trunk@5595
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 19 Sep 2012 02:01:47 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5594
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 18 Sep 2012 20:44:01 +0000 (20:44 +0000)]
Unreviewed; build fix.
Disable matrixconvolution bench until I can figure out the
premul issues.
git-svn-id: http://skia.googlecode.com/svn/trunk@5593
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 18 Sep 2012 20:32:34 +0000 (20:32 +0000)]
Implements a matrix convolution filter (raster path only). The filtering loop
is templated on the tiling mode for speed: interior pixels are unconditionally
fetched; border pixels apply the appropriate tiling mode before fetching. It
handles target, bias, divisor (as gain), and edge modes (named to be more
skia-like). It does not handle the "preserveAlpha" semantics of
feConvolveMatrix, nor "kernelUnitLength".
git-svn-id: http://skia.googlecode.com/svn/trunk@5592
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 18 Sep 2012 20:08:37 +0000 (20:08 +0000)]
shape ops work in progress
at least 12M of the quad/quad intersection tests pass
git-svn-id: http://skia.googlecode.com/svn/trunk@5591
2bbb7eff-a529-9590-31e7-
b0007b416f81
george@mozilla.com [Tue, 18 Sep 2012 19:05:48 +0000 (19:05 +0000)]
Explicitly convert from int to SkScalar to avoid a compiler error on gcc 4.5
Review URL: https://codereview.appspot.com/6526047
git-svn-id: http://skia.googlecode.com/svn/trunk@5589
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Sep 2012 17:30:47 +0000 (17:30 +0000)]
Fix for r5587 compiler error (removed ../src/gpu in HashCacheTest.cpp)
git-svn-id: http://skia.googlecode.com/svn/trunk@5588
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Tue, 18 Sep 2012 17:16:33 +0000 (17:16 +0000)]
Added functor to GrTHashCache to allow discovery of un-reffed resources
http://codereview.appspot.com/6503126/
git-svn-id: http://skia.googlecode.com/svn/trunk@5587
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Tue, 18 Sep 2012 15:41:18 +0000 (15:41 +0000)]
update gyp files to build on iOS
Note that there's a hack in SkImageDecoder_CG.cpp --
the necessary defines are included directly. This
is temporary until I can figure out how to include
them properly.
Review URL: https://codereview.appspot.com/6523044
git-svn-id: http://skia.googlecode.com/svn/trunk@5586
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Sep 2012 15:14:33 +0000 (15:14 +0000)]
re-re-land 5578
will follow w/ new .skp files to keep the waterfall green (I hope)
git-svn-id: http://skia.googlecode.com/svn/trunk@5584
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Tue, 18 Sep 2012 14:32:35 +0000 (14:32 +0000)]
Reuse one canvas for every tile in bench_pictures (in single threaded mode).
Turn off multi threaded option for now.
In bench_pictures, do not create a large canvas, since we never use it.
Remove unused functions on TiledPictureRenderer.
Review URL: https://codereview.appspot.com/6521043
git-svn-id: http://skia.googlecode.com/svn/trunk@5583
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Tue, 18 Sep 2012 14:14:49 +0000 (14:14 +0000)]
Move GrTextureParams from GrSamplerState to GrTextureAccess
Review URL: https://codereview.appspot.com/6496135/
git-svn-id: http://skia.googlecode.com/svn/trunk@5582
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Sep 2012 14:04:54 +0000 (14:04 +0000)]
revert 5580
git-svn-id: http://skia.googlecode.com/svn/trunk@5581
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Sep 2012 13:47:20 +0000 (13:47 +0000)]
re-land 5578 w/ pipe fix
git-svn-id: http://skia.googlecode.com/svn/trunk@5580
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Sep 2012 13:20:52 +0000 (13:20 +0000)]
revert 5578 -- broke pipe
git-svn-id: http://skia.googlecode.com/svn/trunk@5579
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 18 Sep 2012 12:59:44 +0000 (12:59 +0000)]
Change drawBitmapRect to take a float-src-rect instead of integer-src-rect. This
allows the client more control over the scaling. Because of virtual overrides
and wanting to keep the old call-sites up and running, this CL renames the
virtual entry-point to drawBitmapRectToRect, and downgrades drawBitmapRect to
a non-virtual helper function.
The implementation is to use the float-rect for computing the matrix, but still
cons-up an integer rect for the purposes of subsetting the original bitmap. We
do this by calling float_src->roundOut(&int_src) so that we include all
(partially) covered src pixels.
No change needed on SkDevice, since that signature is explicitly passed the
computed matrix.
Review URL: https://codereview.appspot.com/6501140
git-svn-id: http://skia.googlecode.com/svn/trunk@5578
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 18 Sep 2012 02:01:09 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5577
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Tue, 18 Sep 2012 01:52:20 +0000 (01:52 +0000)]
Add a header for OverView.cpp as well.
This fixes another FIXMEs.
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6492125
git-svn-id: http://skia.googlecode.com/svn/trunk@5576
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 17 Sep 2012 21:10:05 +0000 (21:10 +0000)]
Set DEFAULT_REPEATS to 1
bench defaults to 1 repeat, so bench_pictures should do the same.
This is causing the Android build cycles to be *hours* long.
Review URL: https://codereview.appspot.com/6490123
git-svn-id: http://skia.googlecode.com/svn/trunk@5575
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Mon, 17 Sep 2012 18:26:06 +0000 (18:26 +0000)]
Check for invalid SkPictures
- Remove hasRecorded() since nobody uses it.
- Add "success" boolean to SkPicture stream constructor
- Track failures in render_pictures and bench_pictures
Review URL: https://codereview.appspot.com/6493105
git-svn-id: http://skia.googlecode.com/svn/trunk@5573
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Mon, 17 Sep 2012 17:23:21 +0000 (17:23 +0000)]
Add GrColor to RGBA float helper func
Review URL: https://codereview.appspot.com/6518044/
git-svn-id: http://skia.googlecode.com/svn/trunk@5572
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 17 Sep 2012 14:25:42 +0000 (14:25 +0000)]
Fix a Ref count bug in SkFontHost_win_dw.cpp
https://codereview.appspot.com/6495133
Props tinytail.
git-svn-id: http://skia.googlecode.com/svn/trunk@5568
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Sep 2012 13:38:57 +0000 (13:38 +0000)]
Fixed unused variable compiler complaint
http://codereview.appspot.com/6496129/
git-svn-id: http://skia.googlecode.com/svn/trunk@5567
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Sep 2012 13:36:47 +0000 (13:36 +0000)]
Fixed valgrind complaint in MatrixBench
https://codereview.appspot.com/6492129/
git-svn-id: http://skia.googlecode.com/svn/trunk@5566
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Sep 2012 12:05:40 +0000 (12:05 +0000)]
fixed compiler complaints
http://codereview.appspot.com/6499124/
git-svn-id: http://skia.googlecode.com/svn/trunk@5565
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Sep 2012 11:52:48 +0000 (11:52 +0000)]
Fixed memory leak in deferred_canvas_record bench
http://codereview.appspot.com/6499123/
git-svn-id: http://skia.googlecode.com/svn/trunk@5564
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 17 Sep 2012 10:49:30 +0000 (10:49 +0000)]
Made more benchs non-rendering
http://codereview.appspot.com/6498132/
git-svn-id: http://skia.googlecode.com/svn/trunk@5562
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Sat, 15 Sep 2012 02:01:41 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5561
2bbb7eff-a529-9590-31e7-
b0007b416f81
bsalomon@google.com [Fri, 14 Sep 2012 20:30:37 +0000 (20:30 +0000)]
Temporarily revert r5433 due to crbug.com/148637 until after M23 branch.
git-svn-id: http://skia.googlecode.com/svn/trunk@5557
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Sep 2012 19:07:28 +0000 (19:07 +0000)]
speculative fix for crbug.com/147406 -- disabling save/clip/restore peephole
optimization, to see if it reduces crash rates.
git-svn-id: http://skia.googlecode.com/svn/trunk@5556
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Fri, 14 Sep 2012 19:03:42 +0000 (19:03 +0000)]
Double size of buffer for SkString::printf()
Review URL: https://codereview.appspot.com/6503120
git-svn-id: http://skia.googlecode.com/svn/trunk@5555
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 14 Sep 2012 18:52:10 +0000 (18:52 +0000)]
Add file I forgot in https://code.google.com/p/skia/source/detail?r=5552
git-svn-id: http://skia.googlecode.com/svn/trunk@5554
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 14 Sep 2012 18:47:13 +0000 (18:47 +0000)]
Update expected bench results for picture_playback_drawText_GPU_c
to fix http://code.google.com/p/skia/issues/detail?id=877
git-svn-id: http://skia.googlecode.com/svn/trunk@5553
2bbb7eff-a529-9590-31e7-
b0007b416f81
epoger@google.com [Fri, 14 Sep 2012 18:42:01 +0000 (18:42 +0000)]
Add a header file for TransitionView.cpp
committed from https://codereview.appspot.com/6492119/ for Thiago Farina <tfarina@chromium.org>
git-svn-id: http://skia.googlecode.com/svn/trunk@5552
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 14 Sep 2012 17:37:46 +0000 (17:37 +0000)]
Turn serialization back on in GM.
With https://codereview.appspot.com/6503106/ it is now safe to do
serialization by default.
Review URL: https://codereview.appspot.com/6498121
git-svn-id: http://skia.googlecode.com/svn/trunk@5551
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Fri, 14 Sep 2012 17:26:37 +0000 (17:26 +0000)]
For a picture playback with nothing written, use an empty SkData.
This prevents crashing when attempting to access fOpData.
BUG=https://code.google.com/p/skia/issues/detail?id=870
Review URL: https://codereview.appspot.com/6499108
git-svn-id: http://skia.googlecode.com/svn/trunk@5550
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Sep 2012 16:00:01 +0000 (16:00 +0000)]
landing https://codereview.appspot.com/6506117
git-svn-id: http://skia.googlecode.com/svn/trunk@5549
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Fri, 14 Sep 2012 15:52:47 +0000 (15:52 +0000)]
Fix some nits from codereview.appspot.com/6506103/
git-svn-id: http://skia.googlecode.com/svn/trunk@5547
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 14 Sep 2012 15:27:41 +0000 (15:27 +0000)]
Scale even smaller in bench_pictures to get things green
Over-the-shoulder review from reed@
Review URL: https://codereview.appspot.com/6512043
git-svn-id: http://skia.googlecode.com/svn/trunk@5545
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Fri, 14 Sep 2012 15:18:41 +0000 (15:18 +0000)]
fix fragile cubic stepper, where we want to assert that each tesselated segment
is monotonically going down, but the finite math we use cannot ensure that...
so we explicitly pin the y-value after it is calculated.
add unittest that exercises the bug/assert that was found on an SVG site
git-svn-id: http://skia.googlecode.com/svn/trunk@5544
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Fri, 14 Sep 2012 14:34:28 +0000 (14:34 +0000)]
Enable automatic rescaling in bench_pictures
bench_pictures with "--device gpu" is failing because we're trying to allocate
too much GPU memory. Move the recently-added scaling code into picture_utils
and share it between render_pictures and bench_pictures.
Review URL: https://codereview.appspot.com/6495125
git-svn-id: http://skia.googlecode.com/svn/trunk@5543
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Fri, 14 Sep 2012 14:24:14 +0000 (14:24 +0000)]
Fix picture refcnt bug in distantclip gm. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5542
2bbb7eff-a529-9590-31e7-
b0007b416f81
caryclark@google.com [Fri, 14 Sep 2012 14:19:30 +0000 (14:19 +0000)]
shape ops work in progress
add quartic solution for intersecting quadratics
git-svn-id: http://skia.googlecode.com/svn/trunk@5541
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Fri, 14 Sep 2012 13:53:36 +0000 (13:53 +0000)]
Add gm to test SkRegion/clipPath bug.
Review URL: https://codereview.appspot.com/6501131
git-svn-id: http://skia.googlecode.com/svn/trunk@5540
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Fri, 14 Sep 2012 02:01:10 +0000 (02:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping
git-svn-id: http://skia.googlecode.com/svn/trunk@5539
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 13 Sep 2012 21:47:48 +0000 (21:47 +0000)]
Fix for gcc compile error. Unreviewed.
git-svn-id: http://skia.googlecode.com/svn/trunk@5538
2bbb7eff-a529-9590-31e7-
b0007b416f81
rileya@google.com [Thu, 13 Sep 2012 21:41:51 +0000 (21:41 +0000)]
Add R-Tree record flag to SkPicture, plus some cleanup/fixes in associated classes.
Review URL: https://codereview.appspot.com/6506103
git-svn-id: http://skia.googlecode.com/svn/trunk@5537
2bbb7eff-a529-9590-31e7-
b0007b416f81
bensong@google.com [Thu, 13 Sep 2012 21:08:52 +0000 (21:08 +0000)]
Adds bench expectation file and mechanism for triggering bench-out-of-range alerts from bench_graph_svg.
git-svn-id: http://skia.googlecode.com/svn/trunk@5536
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 13 Sep 2012 18:54:48 +0000 (18:54 +0000)]
Do not exit on failure to open logFile
Temporary solution for write-protected Android devices. Intention is to revert
in favor of a more permanent solution.
Review URL: https://codereview.appspot.com/6497132
git-svn-id: http://skia.googlecode.com/svn/trunk@5535
2bbb7eff-a529-9590-31e7-
b0007b416f81
george@mozilla.com [Thu, 13 Sep 2012 17:55:34 +0000 (17:55 +0000)]
Check if SK_BUILD_FOR_MAC is defined rather than whether it's 1
git-svn-id: http://skia.googlecode.com/svn/trunk@5532
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Thu, 13 Sep 2012 17:44:32 +0000 (17:44 +0000)]
To avoid running out of memory, we rescale very large pictures before we
render them.
Review URL: https://codereview.appspot.com/6504045
git-svn-id: http://skia.googlecode.com/svn/trunk@5530
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 13 Sep 2012 16:39:08 +0000 (16:39 +0000)]
Make all random path benchs non-rendering
https://codereview.appspot.com/6490111/
git-svn-id: http://skia.googlecode.com/svn/trunk@5527
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 13 Sep 2012 15:50:24 +0000 (15:50 +0000)]
Let SkBenchmark classes specify that they do no rendering.
Doing this gives us a 15-20% speedup in bench cycle time.
Here again I'm just picking the easy targets.
http://codereview.appspot.com/6500115/
git-svn-id: http://skia.googlecode.com/svn/trunk@5525
2bbb7eff-a529-9590-31e7-
b0007b416f81
tomhudson@google.com [Thu, 13 Sep 2012 15:42:33 +0000 (15:42 +0000)]
Turn down repeat count on ref counting and memory pool benches.
No reason these things need to run for 10s of ms.
http://codereview.appspot.com/6501122/
git-svn-id: http://skia.googlecode.com/svn/trunk@5524
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 13 Sep 2012 15:40:37 +0000 (15:40 +0000)]
Added GPU resource cache stats printing to render_pictures
https://codereview.appspot.com/6492104/
git-svn-id: http://skia.googlecode.com/svn/trunk@5523
2bbb7eff-a529-9590-31e7-
b0007b416f81
scroggo@google.com [Thu, 13 Sep 2012 15:26:51 +0000 (15:26 +0000)]
Keep the entries in .gitignore sorted in alphabetical order.
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: https://codereview.appspot.com/6506107
git-svn-id: http://skia.googlecode.com/svn/trunk@5522
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 13 Sep 2012 14:53:15 +0000 (14:53 +0000)]
Revert r5520
Unfortunately, since we can only build ANGLE by including a gypi, and since
gyp cannot process includes conditionally, we *have* to have a build_angle.gypi
file in the third_party/externals/ANGLE/src directory. We could do a hack
where we create an empty gypi if ANGLE is not checked out, but for now we just
check out ANGLE on all platforms.
git-svn-id: http://skia.googlecode.com/svn/trunk@5521
2bbb7eff-a529-9590-31e7-
b0007b416f81
borenet@google.com [Thu, 13 Sep 2012 14:38:04 +0000 (14:38 +0000)]
Only check out ANGLE on Windows
Review URL: https://codereview.appspot.com/6500118
git-svn-id: http://skia.googlecode.com/svn/trunk@5520
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Thu, 13 Sep 2012 14:05:00 +0000 (14:05 +0000)]
Added GPU resource cache stats printing to bench & removed some noise from inst counting information
https://codereview.appspot.com/6497125/
git-svn-id: http://skia.googlecode.com/svn/trunk@5519
2bbb7eff-a529-9590-31e7-
b0007b416f81