Aditya Mandaleeka [Tue, 2 May 2017 05:03:25 +0000 (22:03 -0700)]
Fix rgTail corruption in rare scavenging cases [Desktop port]. (#11327)
Jan Kotas [Tue, 2 May 2017 03:10:26 +0000 (20:10 -0700)]
Partial revert "Move a few more files to shared CoreLib partition" (#11328)
Revert change from Hashtable to Dictionary
Wes Haggard [Mon, 1 May 2017 22:37:14 +0000 (15:37 -0700)]
Merge pull request #11323 from dotnet-bot/master-UpdateDependencies
Update CoreClr to preview2-25301-03 (master)
Bruce Forstall [Mon, 1 May 2017 21:12:19 +0000 (14:12 -0700)]
Merge pull request #11067 from sjsinju/model_kill_set
[WIP][RyuJIT/ARM32] Implement the model kill for CORINFO_HELP_ASSGN_BYREF helper
dotnet-bot [Mon, 1 May 2017 21:03:47 +0000 (21:03 +0000)]
Update CoreClr to preview2-25301-03
Pat Gavlin [Mon, 1 May 2017 19:31:25 +0000 (12:31 -0700)]
Merge pull request #11304 from pgavlin/GH11273
Fix #11273 by adjusting the fix for VSO 406163.
Jan Kotas [Sun, 16 Apr 2017 22:14:48 +0000 (15:14 -0700)]
Move a few more files to shared CoreLib partition
Hyung-Kyu Choi [Mon, 1 May 2017 19:00:01 +0000 (04:00 +0900)]
[ARM] Update rootfs for Tizen armel (#11202)
* [ARM] Update cross rootfs for armel Tizen
Update cross rootfs for armel Tizen
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
* [ARM] Update cmake file and CI for armel Tizen
Update CI and cmake file for armel Tizen, because rootfs for Tizen is updated.
And rootfs for Tizen is embedded in Docker image for CI as Ubuntu for arm does.
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Davis Goodin [Mon, 1 May 2017 18:35:13 +0000 (13:35 -0500)]
Fix current publish build warnings (#11317)
* Make VSTS Drop metadata distinct
* Remove PublishLogs artifact publish: no matches
William Godbe [Mon, 1 May 2017 17:49:46 +0000 (10:49 -0700)]
Merge pull request #11309 from dotnet-bot/master-UpdateDependencies
Update CoreClr, CoreFx to preview2-25301-01, preview2-25301-02, respectively (master)
Jan Kotas [Sat, 29 Apr 2017 14:43:23 +0000 (07:43 -0700)]
Fetch secondary handle only if primary is non-null
The GC is not tracking the secondary handle once primary gets cleared.
Fixes #11270
Jan Kotas [Fri, 28 Apr 2017 01:28:34 +0000 (18:28 -0700)]
Avoid unnecessary out arguments in DependentHandle FCalls
Make the signatures closer to what they are in CoreRT
Pat Gavlin [Mon, 1 May 2017 17:21:28 +0000 (10:21 -0700)]
Merge pull request #11262 from pgavlin/NoCompatJit
Remove support for the x86 compat JIT from .NET Core.
Pat Gavlin [Mon, 1 May 2017 17:14:48 +0000 (10:14 -0700)]
Format code and fix a comment.
Davis Goodin [Mon, 1 May 2017 14:54:03 +0000 (09:54 -0500)]
Add symbol publish (index/archive) build leg (#11300)
* Add symbol publish (index/archive) build leg
* Use BuildType property name in symbol publish leg
Carol Eidt [Mon, 1 May 2017 14:47:50 +0000 (07:47 -0700)]
Merge pull request #11275 from CarolEidt/Fix11141
Avoid over-constrained delayed-use register case
dotnet-bot [Mon, 1 May 2017 14:10:46 +0000 (14:10 +0000)]
Update CoreClr, CoreFx to preview2-25301-01, preview2-25301-02, respectively
Jan Kotas [Mon, 1 May 2017 05:52:25 +0000 (22:52 -0700)]
Rename internal field of primitive type structs and make it private (#11312)
Reduce diffs with CoreRT and conform to coding conventions
Drew Scoggins [Sat, 29 Apr 2017 22:03:00 +0000 (07:03 +0900)]
Merge pull request #11297 from DrewScoggins/AddPerfRunInstr
Add instructions for running local perf tests
William Godbe [Sat, 29 Apr 2017 20:58:30 +0000 (13:58 -0700)]
Merge pull request #11272 from wtgodbe/CrossgenMove
Ensure we run the Crossgened test executable in R2R tests
Yi Zhang (CLR) [Sat, 29 Apr 2017 16:51:03 +0000 (09:51 -0700)]
Bring back Marshal.Read/Write overloads that takes object (#11251)
* Bring back desktop version of Marshal.Read/Write APIs that takes object and add a test
dotnet bot [Sat, 29 Apr 2017 06:08:49 +0000 (23:08 -0700)]
Update CoreClr to preview2-25229-01 (#11303)
William Godbe [Sat, 29 Apr 2017 01:54:48 +0000 (18:54 -0700)]
Update runtest.sh
Update if statement
Pat Gavlin [Fri, 28 Apr 2017 23:31:25 +0000 (16:31 -0700)]
Fix #11273 by adjusting the fix for VSO 406163.
Issue #11273 revealed an issue with the fix for VSO 406163: as of today,
the compiler models the incoming exception object in a handler by
looking for `GT_CATCH_ARG` in the first block of a handler and if found
marking the register that contains the exception object as holding a GC
pointer. Unfortunately, this breaks down under the transform that the
original fix (#11134) was performing for single-block filters. That
transformation was from this:
```
filter start: BBN (BBJ_EHFILTERRET)
```
to this:
```
filter start: BBN + 1 (BBJ_ALWAYS -> BBN)
BBN + 2 (jumpKind)
BBN (BBJ_EHFILTERRET)
```
After this transform, `BBN` still contains the `GT_CATCH_ARG`, but the
register containing the exception object must be live through `BBN + 1`
as well as live in to `BBN`.
There are a number of possible solutions to this problem (e.g. modeling
the liveness of the exception object in some fashion or splitting the
single-block filter either after the catch arg or before the filter
ret), but many of them are complicated by the fact that this
transformation needs to operate on both HIR and LIR and must be be able
to run in a variety of locations, including after registers have been
allocated. Instead, this change takes the approach of ensuring that no
single-block filter regions exist on platforms that target the JIT32 GC
encoder by inserting a spill of the exception object to a local var in
its own block at the start of a filter.
wtgodbe [Thu, 27 Apr 2017 22:40:23 +0000 (15:40 -0700)]
Ensure we run the Crossgened test executable in R2R tests
Gaurav Khanna [Fri, 28 Apr 2017 23:06:54 +0000 (16:06 -0700)]
Correctly enumerate loaded assemblies in AppDomain (#11294)
* Correctly enumerate loaded assemblies in AppDomain
* Remove unrequired attribute
Drew Scoggins [Fri, 28 Apr 2017 22:56:36 +0000 (15:56 -0700)]
Fix typo
Drew Scoggins [Fri, 28 Apr 2017 18:45:01 +0000 (11:45 -0700)]
Add instructions for running local perf tests
dotnet bot [Fri, 28 Apr 2017 19:50:38 +0000 (12:50 -0700)]
Update CoreClr, CoreFx to preview2-25228-02, preview2-25228-02, respectively (#11283)
Jonghyun Park [Fri, 28 Apr 2017 18:08:36 +0000 (03:08 +0900)]
Enable interpreter build (#11252)
Enable FEATURE_INTERPRETER build
Brian Sullivan [Fri, 28 Apr 2017 17:57:50 +0000 (10:57 -0700)]
Merge pull request #11268 from sdmaclea/PR-ARM64-two-gc-attributes
[Arm64] Support two GC attributes in pair forms
Carol Eidt [Thu, 27 Apr 2017 22:28:17 +0000 (15:28 -0700)]
Avoid over-constrained delayed-use register case
When a node has a delayed-use register (either due to an RMW def or due to an internalRegDelayFree),
if its result has a fixed-use, don't propagate the register constraint to the def, because there's
no associated fixed-reference to ensure that it will not be used by the delay-free register.
Fix #11141
Yi Zhang (CLR) [Fri, 28 Apr 2017 15:41:29 +0000 (08:41 -0700)]
Fix R2R issue with virtual method resolving to non-generic base (#11289)
Jan Kotas [Thu, 27 Apr 2017 23:47:53 +0000 (16:47 -0700)]
Merge pull request dotnet/corert#3446 from jkotas/nmirror-merge
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Steve MacLean [Fri, 28 Apr 2017 02:08:48 +0000 (22:08 -0400)]
Add assert
Steve MacLean [Fri, 28 Apr 2017 02:03:49 +0000 (22:03 -0400)]
Remove comment
dotnet bot [Fri, 28 Apr 2017 01:26:02 +0000 (18:26 -0700)]
Update CoreClr, CoreFx to preview2-25227-03, preview2-25227-02, respectively (#11249)
Sergey Andreenko [Fri, 28 Apr 2017 01:06:34 +0000 (18:06 -0700)]
Fix lsra memory consumption (#11233)
* Rename ClearD to OldStyleClearD
* create fast ClearD function.
The new ClearD reuses existing buffer and assumes that epoch wasn't
changed.
* Reuse existing buffer for the predSet in lsra.
* Use fast ClearD in LSRA.
* Use fast ClearD in liveness
* Fix the comment
* delete the test from issues
Xiang Fan [Thu, 27 Apr 2017 23:48:13 +0000 (16:48 -0700)]
Fix issues exposed by building with MSVC and /permissive-. (#11269)
Using full-qualified name to declare members inside class is ill-formed and incorrectly allowed by MSVC.
MSVC now gives error when /permissive- is used.
Russ Keldorph [Thu, 27 Apr 2017 22:25:59 +0000 (15:25 -0700)]
Enable R2R jitstress jobs for x86
Jan Kotas [Thu, 27 Apr 2017 20:49:10 +0000 (13:49 -0700)]
Allow conversions between enum and underlying type
Fixes https://github.com/dotnet/corefx/issues/13816
Jan Kotas [Thu, 27 Apr 2017 20:48:16 +0000 (13:48 -0700)]
Disallow conversions between Object* and Object in Array.Copy
Fixes https://github.com/dotnet/coreclr/issues/10646
Gaurav Khanna [Thu, 27 Apr 2017 22:36:24 +0000 (15:36 -0700)]
Unify fetching LoadContext for Dynamic Assemblies (#11264)
Pat Gavlin [Wed, 26 Apr 2017 23:01:52 +0000 (16:01 -0700)]
Remove support for the x86 compat JIT from .NET Core.
These changes remove support for the x86 compat JIT from the build, the
runtime, and the various perf/test scripts.
Fixes #10733, #10734.
[Arm64] Use ldp for mismatched GC types in genPutArgStk
[Arm64] Support two GC attributes in pair forms
Also use in genCodeForCpObj
Steve MacLean [Thu, 27 Apr 2017 21:32:29 +0000 (17:32 -0400)]
[Arm64] Clean up genPutArgStk (#11239)
* [Arm64] Clean up genPutArgStk
Use ldp/stp in more case
Simplify code by eliminating most addrReg conflict cases
* Fix formatting
Vance Morrison [Thu, 27 Apr 2017 19:43:38 +0000 (12:43 -0700)]
Turn on unwind information at informational level rather than Info level. (#11257)
This is bascically a bug fix. Quite a while ago we wanted to be able to collect stacks (which needed JIT names, and unwind information)
without collecting all verbose CLR events (in particular the GC allocation Tick events). We did this in most places but missed this one.
Bruce Forstall [Thu, 27 Apr 2017 19:41:43 +0000 (12:41 -0700)]
Remove unused TreeNodeInfo::isHelperCallWithKills field (#11259)
Remove unused TreeNodeInfo::isHelperCallWithKills field
Bruce Forstall [Thu, 27 Apr 2017 18:21:27 +0000 (11:21 -0700)]
Merge pull request #11224 from parjong/fix/arm_unaligned_ldobj
[ARM/Linux] Honor unaligned prefix for ldobj instruction
Gaurav Khanna [Thu, 27 Apr 2017 17:46:47 +0000 (10:46 -0700)]
[WIP] Enable binding to CoreLib as NI image (#11040)
Enable binding to CoreLib as NI image
Bruce Forstall [Thu, 27 Apr 2017 17:45:36 +0000 (10:45 -0700)]
Merge pull request #11255 from mskvortsov/FixPutArgReg
[RyuJIT/ARM32] Update putarg_reg codegen
Bruce Forstall [Thu, 27 Apr 2017 17:19:10 +0000 (10:19 -0700)]
Merge pull request #11258 from mskvortsov/FixConsumeReporting
Do not report out-of-order consuming if a node wasn't consumed at all
Sean Gillespie [Thu, 27 Apr 2017 17:09:32 +0000 (10:09 -0700)]
Fix a double-free encountered when failing to initialize a handle table bucket (#11244)
* Fix a double-free encountered when failing to initialize a handle table bucket
* Don't free m_bucket in the destructor of HandleTableBucketHolder
Hanjoung Lee [Thu, 27 Apr 2017 16:39:47 +0000 (01:39 +0900)]
Fix unittest `LPSTRTest` (#11096)
* Fix unittest `LPSTRTest`
The test case Interop.StringMarshalling.LPSTR.LPSTRTest
always returned exit code 100(pass) even if it actually failed.
This implements `ExitTest()` in the same manner with `LPTSTRTest`.
* Fix unittest `LPSTRTest` native
Brian Sullivan [Thu, 27 Apr 2017 15:53:42 +0000 (08:53 -0700)]
Merge pull request #11219 from sdmaclea/PR-ARM64-CpObj-Use-LDP-STP
[Arm64] Use ldp/stp in genCodeForCpObj()
Brian Sullivan [Thu, 27 Apr 2017 15:51:39 +0000 (08:51 -0700)]
Merge pull request #11243 from sdmaclea/PR-ARM64-LDP-ALLOW-GCREFS
[Arm64] Update emitOutputInstr to support GC refs in ldp forms
Mikhail Skvortcov [Thu, 27 Apr 2017 14:53:53 +0000 (17:53 +0300)]
Do not report out-of-order consuming if node wasn't consumed at all
Jonghyun Park [Thu, 27 Apr 2017 14:50:39 +0000 (23:50 +0900)]
[x86/Linux] Disable USE_CALLER_SP_IN_FUNCLET in EH (#11247)
Mikhail Skvortcov [Thu, 27 Apr 2017 10:54:35 +0000 (13:54 +0300)]
RyuJIT/ARM32: Update GT_PUTARG_REG codegen.
Steve MacLean [Thu, 27 Apr 2017 04:50:37 +0000 (00:50 -0400)]
[Arm64/Unix] Revise JIT_MemCpy (#11143)
* [Arm64/Unix] Revise JIT_MemCpy
Use ldp/stp
Correctly handle short copy lengths
Simplify code & pseudo code
Use uint*_t to make pseudo code more readable
Felipe Pessoto [Thu, 27 Apr 2017 04:50:04 +0000 (01:50 -0300)]
Fix building with only VS2017 installed. (#11182)
The fix was originally made in https://github.com/dotnet/corefx/pull/18700
William Godbe [Thu, 27 Apr 2017 01:55:16 +0000 (18:55 -0700)]
Merge pull request #11240 from wtgodbe/SourceBranch
Use SourceBranch from pipebuild to define Helix Branch
Koundinya Veluri [Thu, 27 Apr 2017 01:42:48 +0000 (18:42 -0700)]
Fix to respect readonly prefix for multidimensional array Address method (#11245)
Fixes #9414
- Added missing 'else' back from regression in https://github.com/dotnet/coreclr/commit/
97b4ff0b438261ba11b357008630076054a6f25d#diff-edc46b80f57431489a82311948a8234dL6424, which has the effect of passing null to the Address method's instParam to indicate the readonly prefix in order to bypass the type check
Gaurav Khanna [Wed, 26 Apr 2017 23:53:58 +0000 (16:53 -0700)]
Fix filename display in exception messages (#11238)
dotnet bot [Wed, 26 Apr 2017 23:21:04 +0000 (16:21 -0700)]
Update CoreClr, CoreFx to preview2-25226-02, preview2-25226-02, respectively (#11127)
Jan Kotas [Wed, 26 Apr 2017 21:01:22 +0000 (14:01 -0700)]
Delete moved file
Faizur Rahman [Wed, 26 Apr 2017 03:39:46 +0000 (20:39 -0700)]
Move DllNotFoundException, EntryPointNotFoundException to CoreLib (#3415)
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Koundinya Veluri [Wed, 26 Apr 2017 23:08:53 +0000 (16:08 -0700)]
Fix timer callback time drift (#11220)
Fixes #6408:
- The change to S.T.Timer is the actual fix, but fixed the timer firing on the thread pool timer thread similarly as well
Steve MacLean [Wed, 26 Apr 2017 22:53:08 +0000 (18:53 -0400)]
Fix comment
[Arm64] Update emitOutputInstr to support GC refs in ldp forms
Pat Gavlin [Wed, 26 Apr 2017 22:37:39 +0000 (15:37 -0700)]
Merge pull request #11235 from pgavlin/VSO424019
Require a frame pointer in methods with throw blocks for sources that…
wtgodbe [Wed, 26 Apr 2017 21:54:04 +0000 (14:54 -0700)]
Use SourceBranch from pipebuild to define Helix Branch
Sean Gillespie [Wed, 26 Apr 2017 21:50:19 +0000 (14:50 -0700)]
Fix and re-enable some GC finalizer tests (#11216)
* Fix and re-enable some GC finalizer tests
* Make the Usage test a little more robust
[Arm64] CpObj ldp/stp review feedback
Rework asserts
Add comments
Format
Sven Boemer [Wed, 26 Apr 2017 21:02:36 +0000 (14:02 -0700)]
Merge pull request #11178 from sbomer/ilrt_factoring
Refactor ildasm round trip logic
Pat Gavlin [Wed, 26 Apr 2017 20:23:59 +0000 (13:23 -0700)]
Require a frame pointer in methods with throw blocks for sources that have mismatched stack depths.
This requirement effectively disables double-aligned frames (which are
effectively a special case of ESP frames). Without this change it is
possible for the JIT to generate a throw block with sources that have
mismatched offsets, which can lead to GC holes.
Fixes VSO 424019.
Andy Ayers [Wed, 26 Apr 2017 20:04:14 +0000 (13:04 -0700)]
Merge pull request #11218 from AndyAyersMS/FixReturnTypeMismatch
JIT: fix return type mismatch inlining block
Michael Letterle [Fri, 31 Mar 2017 15:31:53 +0000 (11:31 -0400)]
Lookup System.Runtime and mscorlib references by Assembly name
Rather than by alias.
Fixes #10595
William Godbe [Wed, 26 Apr 2017 18:29:52 +0000 (11:29 -0700)]
Merge pull request #11229 from wtgodbe/CrossgenFix
Exit on failure of HelixPrep.proj
wtgodbe [Wed, 26 Apr 2017 18:29:10 +0000 (11:29 -0700)]
Exit on failure of HelixPrep.proj
Sven Boemer [Mon, 24 Apr 2017 17:12:38 +0000 (10:12 -0700)]
Refactor ildasm round trip logic
This change factors the Ildasm round trip logic so that it should not
require a separate test build. The ildasmroundtrip flag is no longer
passed to build-test.cmd; instead the wrapper scripts are always
generated with a check for an environment variable that can be set from
runtests.
Also remove separate test build for ilrt in the ci scripts
Jan Vorlicek [Wed, 26 Apr 2017 14:10:13 +0000 (07:10 -0700)]
Enable build with clang 4.0 (#11226)
This change enables build with clang 4.0 and fixes a bunch of new errors that
the stricter compiler was reporting.
Jan Vorlicek [Wed, 26 Apr 2017 13:48:20 +0000 (06:48 -0700)]
Fix thread wait to be resilient to real time clock changes on Unix (#11213)
This change fixes a problem that happens when a thread uses a timed wait
and the real time clock change in the system (e.g. due to the user action,
time server sync, leap second, etc). In such case, the wait may end up waiting
for shorter or longer period of time.
It fixes the issue for Thread.Sleep and timed wait on a process local synchronization
primitives by using CLOCK_MONOTONIC instead of CLOCK_REALTIME for waiting on
cond vars.
Unfortunately, the waits on cross process synchronication primitives like
named mutexes always use CLOCK_REALTIME, so this fix works on process local primitives
only.
Jonghyun Park [Wed, 26 Apr 2017 12:49:07 +0000 (21:49 +0900)]
[x86/Linux] Stack alignment check in Hijack Helpers (#11221)
Jonghyun Park [Wed, 26 Apr 2017 12:18:33 +0000 (21:18 +0900)]
[x86/Linux] Use appropriate FCALL macro for DateMarshaler__ConvertToNative (#11194)
Michal Strehovský [Tue, 25 Apr 2017 20:13:36 +0000 (13:13 -0700)]
Merge pull request dotnet/corert#3429 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Alan Lawrence [Wed, 26 Apr 2017 11:14:11 +0000 (12:14 +0100)]
Comment explaining use of FlushProcessWriteBuffers in StompWriteBarrier. (#10924)
Jan Vorlicek [Wed, 26 Apr 2017 08:52:35 +0000 (01:52 -0700)]
Fix few clang analyzer warnings (#11185)
This change fixes two issues reported by the clang analyzer. In both cases, uninitialized
variable value was used in an error code path.
Jonghyun Park [Wed, 26 Apr 2017 06:24:44 +0000 (15:24 +0900)]
[ARM/Linux] Honor unaligned prefix for ldobj instruction
Bruce Forstall [Wed, 26 Apr 2017 04:17:48 +0000 (21:17 -0700)]
Merge pull request #11107 from BruceForstall/NumSuccImprovement
Num succ improvement
Bruce Forstall [Wed, 26 Apr 2017 04:16:29 +0000 (21:16 -0700)]
Merge pull request #11204 from BruceForstall/FixArmAltjitGcinfo
Fix GCInfo library used by ARM/ARM64 protononjit builds
William Godbe [Wed, 26 Apr 2017 04:16:09 +0000 (21:16 -0700)]
Merge pull request #11215 from wtgodbe/ActuallyDoCrossgen
Set RunCrossGen=true for non-Windows R2R runs
[Arm64] Use ldp/stp in genCodeForCpObj()
Jonghyun Park [Tue, 25 Apr 2017 23:31:29 +0000 (08:31 +0900)]
Move DynamicHelperFrame::UpdateRegDisplay into cgenx86.cpp (#11193)
* Move DynamicHelperFrame::UpdateRegDisplay into cgenx86.cpp
* Fix x86/Windows link error
Andy Ayers [Tue, 25 Apr 2017 23:06:44 +0000 (16:06 -0700)]
JIT: fix return type mismatch inlining block
If caller passes a directly substitutable expression whose
type is compatible with but not the same as the callee argument type,
and that argument is the callee's return value, the jit may
reject inlining the method because of a return type mismatch.
Fix is to retype the expressions we use in the callee's body
as the callee's type.
Closes #11211.
wtgodbe [Tue, 25 Apr 2017 22:40:22 +0000 (15:40 -0700)]
Set RunCrossGen=true for non-Windows R2R runs
Pat Gavlin [Tue, 25 Apr 2017 22:36:37 +0000 (15:36 -0700)]
Merge pull request #11134 from pgavlin/VSO406163
Fix fgNewBBinRegion when inserting into filters.
Roman Artemev [Tue, 25 Apr 2017 22:24:09 +0000 (15:24 -0700)]
Merge pull request #11110 from rartemev/issue_9880
Made behavior to conform to ECMA for 'tail.call, pop, ret' case
mskvortsov [Tue, 25 Apr 2017 22:01:43 +0000 (01:01 +0300)]
[RyuJIT/ARM32] Move genJumpKindsForTree into common part (#11103)
* Move genJumpKindsForTree() into codegenarmarch.cpp.
* Edit genJumpKindsForTree().
* Introduce genCodeForJumpTrue() for both ArmArch and XArch.
* Fix GT_JTRUE codegen for ARM32 by using genCodeForJumpTrue().