platform/upstream/gcc.git
3 years agoAdd libcody
Nathan Sidwell [Mon, 14 Dec 2020 16:10:27 +0000 (08:10 -0800)]
Add libcody

In order to separate compiler from build system, C++ Modules, as
implemented in GCC introduces a communication channel between those
two entities.  This is implemented by libcody.  It is anticipated that
other implementations will also implement this protocol, or use
libcody to provide it.

* Makefile.def: Add libcody.
* configure.ac: Add libcody.
* Makefile.in: Regenerated.
* configure: Regenerated.
gcc/
* Makefile.in (CODYINC, CODYLIB, CODYLIB_H): New. Use them.
libcody/
* configure.ac: New.
* CMakeLists.txt: New.
* CODING.md: New.
* CONTRIB.md: New.
* LICENSE: New.
* LICENSE.gcc: New.
* Makefile.in: New.
* Makesub.in: New.
* README.md: New.
* buffer.cc: New.
* build-aux/config.guess: New.
* build-aux/config.sub: New.
* build-aux/install-sh: New.
* client.cc: New.
* cmake/libcody-config-ix.cmake
* cody.hh: New.
* config.h.in: New.
* config.m4: New.
* configure: New.
* configure.ac: New.
* dox.cfg.in: New.
* fatal.cc: New.
* gdbinit.in: New.
* internal.hh: New.
* netclient.cc: New.
* netserver.cc: New.
* packet.cc: New.
* resolver.cc: New.
* server.cc: New.
* tests/01-serialize/connect.cc: New.
* tests/01-serialize/decoder.cc: New.
* tests/01-serialize/encoder.cc: New.
* tests/02-comms/client-1.cc: New.
* tests/02-comms/pivot-1.cc: New.
* tests/02-comms/server-1.cc: New.
* tests/Makesub.in: New.
* tests/jouster: New.

3 years agoAdd toplevel dirs
Nathan Sidwell [Tue, 15 Dec 2020 14:49:06 +0000 (09:49 -0500)]
Add toplevel dirs

contrib/
* gcc-changelog/git_commit.py (changelog_locations): Add
libcody, c++tools.

3 years agoc++: module-related tweak
Nathan Sidwell [Mon, 14 Dec 2020 19:44:12 +0000 (11:44 -0800)]
c++: module-related tweak

In manually applying a name-lookup patch, I managed to transpose two
calls.  That caused a test failure.  Fixed thusly.

gcc/cp/
* name-lookup.c (do_namespace_alias): Set originating module
before pushing.

3 years agolibstdc++: Fix required locales of a testcase
Marius Hillenbrand [Tue, 15 Dec 2020 11:40:07 +0000 (11:40 +0000)]
libstdc++: Fix required locales of a testcase

The testsuite for libstdc++ aims to skips test cases for which not all
required locales are installed. This patch adds missing directives about
required locales to one test case to avoid false positive test failures
on systems that have a partial set of locales installed.

Verified by test suite runs that this patch changes the test case from
FAIL to UNSUPPORTED when not all required locales are available and that
the test case will run and PASS when the necessary locales have been
added.

libstdc++-v3/ChangeLog:

* testsuite/22_locale/locale/cons/5.cc: Add missing directives
for required locales.

3 years agolibstdc++: Remove workaround for PR c++/78173
Jonathan Wakely [Tue, 15 Dec 2020 11:40:07 +0000 (11:40 +0000)]
libstdc++: Remove workaround for PR c++/78173

Now that the G++ bug is fixed we no longer need to protect this partial
specialization from complaining about subtracting void pointers.

libstdc++-v3/ChangeLog:

* include/bits/iterator_concepts.h (incrementable_traits<Tp>):
Remove workaround for PR c++/78173.

3 years agolibstdc++: Disabling AC_LIBTOOL_DLOPEN check if building with avr-libc
Vladimir Vishnevsky [Tue, 15 Dec 2020 11:40:07 +0000 (11:40 +0000)]
libstdc++: Disabling AC_LIBTOOL_DLOPEN check if building with avr-libc

The AC_LIBTOOL_DLOPEN checks were previously disabled for newlib targets.
The patch applies similar logic to avr-libc based builds.

libstdc++-v3/ChangeLog:

* configure.ac: Skip AC_LIBTOOL_DLOPEN check if avr-libc is used.
* configure: Regenerate.

3 years agolibstdc++: Use init_priority attribute for Init object [PR 98108]
Jonathan Wakely [Tue, 15 Dec 2020 11:40:06 +0000 (11:40 +0000)]
libstdc++: Use init_priority attribute for Init object [PR 98108]

This causes the global objects that run the <iostream> initialization
code to be constructed earlier, which avoids some bugs in user code due
to incorrectly relying on static initialization order.

libstdc++-v3/ChangeLog:

PR libstdc++/98108
* include/std/iostream (__ioinit): Add init_priority attribute.

3 years ago[Ada] Fix serial port baud rate setting on GNU/Linux
Pascal Obry [Sat, 7 Nov 2020 09:31:43 +0000 (10:31 +0100)]
[Ada] Fix serial port baud rate setting on GNU/Linux

gcc/ada/

* libgnat/g-sercom__linux.adb (Set): Use cfsetospeed and
cfsetispeed to set the baud rate. Clear non-blocking serial port
status when blocking is requested.

3 years ago[Ada] Small adjustment to System.Val_Real
Eric Botcazou [Thu, 26 Nov 2020 14:58:24 +0000 (15:58 +0100)]
[Ada] Small adjustment to System.Val_Real

gcc/ada/

* libgnat/s-valrea.adb (Integer_to_Real): Always use Extra.

3 years ago[Ada] Simplify check for extra parens
Piotr Trojanek [Thu, 26 Nov 2020 17:37:09 +0000 (18:37 +0100)]
[Ada] Simplify check for extra parens

gcc/ada/

* par-ch5.adb (P_Condition): Simplify condition for warning
about extra parens and make it easier to understand.

3 years ago[Ada] Refactor repeated complains about missing -gnat2005 switch
Piotr Trojanek [Wed, 25 Nov 2020 21:02:29 +0000 (22:02 +0100)]
[Ada] Refactor repeated complains about missing -gnat2005 switch

gcc/ada/

* errout.ads (Error_Msg_Ada_2005_Extension): New routine (spec).
* errout.adb (Error_Msg_Ada_2005_Extension): New routine (body).
* par-ch10.adb: Reuse new routine; correct casing for "LIMITED
WITH".
* par-ch11.adb: Likewise.
* par-ch12.adb: Likewise.
* par-ch3.adb: Likewise.
* par-ch4.adb: Likewise; replace "box" with "<>".
* par-ch6.adb: Likewise.
* par-ch9.adb: Likewise; correct casing for "THEN ABORT".

3 years ago[Ada] Small adjustment to parameterization of System.Value_R
Eric Botcazou [Wed, 25 Nov 2020 18:32:15 +0000 (19:32 +0100)]
[Ada] Small adjustment to parameterization of System.Value_R

gcc/ada/

* doc/gnat_ugn/gnat_and_program_execution.rst: Minor fix.
* gnat_ugn.texi: Regenerate.
* libgnat/s-valuer.ads (Precision_Limit): New formal parameter.
* libgnat/s-valuer.adb (Precision_Limit): Remove.
(Scan_Decimal_Digits): Robustify overflow check.
(Scan_Integral_Digits): Likewise.
* libgnat/s-valrea.adb: Add assertion on the size of the unsigned
type and instantiate System.Value_R with the mantissa limit.
(Integer_to_Real): Add Extra parameter and take it into account.
(Scan_Real): Pass Extra to Integer_to_Real.
(Value_Real): Likewise.
* libgnat/s-valued.adb: Add assertion on the size of the unsigned
type and instantiate System.Value_R with the mantissa limit.
* libgnat/s-valuef.adb: Likewise.

3 years ago[Ada] Postcondition checks performed before finalization
Justin Squirek [Mon, 16 Nov 2020 14:08:51 +0000 (09:08 -0500)]
[Ada] Postcondition checks performed before finalization

gcc/ada/

* contracts.adb, contracts.ads (Build_Postconditions_Procedure):
Add declarations for Postcond_Enabled,
Result_Object_For_Postcondition, and
Return_Success_For_Postcond, and place all postconditions within
an if statement to control their execution for interactions when
cleanup actions get generated.
(Get_Postcond_Enabled): Created to fetch object declared to
handle new expansion of postconditions.
(Get_Result_Object_For_Postcond): Created to fetch object
declared to handle new expansion of postconditions.
(Get_Return_Success_For_Postcond): Created to fetch object
declared to handle new expansion of postconditions.
* einfo.adb, einfo.ads: Modify flag Stores_Attribute_Old_Prefix
to apply to constants, variables, and types.
* exp_ch6.adb (Add_Return): Add assignment to
Return_Success_For_Postcond.
(Expand_Non_Function_Return): Add assignment to
Return_Success_For_Postcond
(Expand_Simple_Function_Return): Add assignment to
Result_Object_For_Postcond and Return_Success_For_Postcond.
* exp_ch7.adb (Build_Finalization_Master): Mark finalization
masters which finalize types created store 'Old objects as
storing 'Old objects.
(Build_Finalizer): Created to generated a unified and special
expansion for finalization when postconditions are present.
(Build_Finalizer_Helper): Renamed Build_Finalizer and added
parameter to facilitate the creation of separate finalization
routines for 'Old objects and general objects.
(Create_Finalizer): Add condition for the insertion of the
finalizer spec to avoid malformed trees.
(Expand_Cleanup_Actions): Move _postconditions and related
declarations to the new declarative section.  Fix the loop to
properly stop at the subprogram declaration for the
postconditions procedure and exclude its body from being moved
to the new list of declarations to avoid freezing issues.
* exp_prag.adb (Expand_Attributes): Mark temporary created to
store 'Old objects as storing a 'Old attribute.
* sem_ch6.adb (Find_What_Applies_To): Remove strange exception
to postconditions when traversing the scope stack.
* sem_prag.adb (Find_Related_Declaration_Or_Body): Use the newly
created Enclosing_HSS function to find the HSS for a potentially
nested statement.
* sem_util.adb, sem_util.ads (Declare_Indirect_Temp): Mark types
created to store 'Old objects as storing 'Old attributes.
(Enclosing_HSS): Created to find the enclosing handled sequence
of statements for a given statement.
* snames.ads-tmpl: Add multiple names to aid in the expansion of
finalization and to control the evaluation of postconditions.
Including _finalization_controller, a new routine to centralize
finalization actions and postcondition evaluation.

3 years ago[Ada] Complain about missing -gnat2020 switch on iterator_filter
Piotr Trojanek [Wed, 25 Nov 2020 11:05:47 +0000 (12:05 +0100)]
[Ada] Complain about missing -gnat2020 switch on iterator_filter

gcc/ada/

* par-ch5.adb (P_Loop_Parameter_Specification): Complain about
missing -gnat2020 switch.
(P_Iterator_Specification): Likewise.

3 years ago[Ada] Reuse Append_New in parsing aggregates
Piotr Trojanek [Wed, 25 Nov 2020 11:27:23 +0000 (12:27 +0100)]
[Ada] Reuse Append_New in parsing aggregates

gcc/ada/

* par-ch4.adb (P_Aggregate_Or_Paren_Expr): Simplify with
Append_New.

3 years ago[Ada] Implement tiered support for floating-point input operations
Eric Botcazou [Mon, 23 Nov 2020 14:42:08 +0000 (15:42 +0100)]
[Ada] Implement tiered support for floating-point input operations

gcc/ada/

* Makefile.rtl (GNATRTL_NONTASKING_OBJS): Remove s-fatsfl$(objext)
and add s-valflt$(objext), s-vallfl$(objext), s-valllf$(objext).
* exp_attr.adb (Find_Fat_Info): Merge Short_Float and Float cases.
* exp_imgv.adb (Expand_Value_Attribute): Replace RE_Value_Real with
RE_Value_Long_Long_Float for fixed-point types and use appropriate
base type for floating-point types.
* rtsfind.ads (RTU_Id): Remove System_Fat_IEEE_Long_Float,
System_Fat_IEEE_Short_Float and System_Val_Real, add System_Val_Flt,
System_Val_LFlt and System_Val_LLF.
(RE_Id): Remove RE_Attr_IEEE_Long, RE_Fat_IEEE_Long,
RE_Attr_IEEE_Short, RE_Fat_IEEE_Short, RE_Attr_Short_Float, add
RE_Value_Float, RE_Value_Long_Float, RE_Value_Long_Long_Float,
(RE_Unit_Table): Likewise.
* libgnat/a-ticoau.ads: Add with clause for Float_Aux and make the
package generic.
(Get): Change parameter types to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-ticoau.adb: Remove clause and renaming for Float_Aux.
(Get): Change parameter types to Num.
(Gets): Likewise.
(Put): Likewise.
(Puts): Likewise.  Add conversion to Long_Long_Float.
* libgnat/a-ticoio.adb: Remove with clause for Ada.Text_IO, add with
clause for Float_Aux, add with and use clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Instantiate Float_Aux and
Complex_Aux on Float, Long_Float, and Long_Long_Float.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.
(Get): Call appropriate Gets routine from auxiliary package.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-tideau.adb: Remove with and use clause for Float_Aux.
* libgnat/a-tifiau.adb: Likewise.
* libgnat/a-tifiio.adb: Add with and use clause for System.Val_LLF.
Instantiate Float_Aux on Long_Long_Float.
(Get): Adjust call to Get routine from auxiliary package.
(Get): Adjust call to Gets routine from auxiliary package.
(Put): Adjust call to Put routine from auxiliary package.
(Put): Adjust call to Puts routine from auxiliary package.
* libgnat/a-tifiio__128.adb: Likewise.
(Get): Likewise.
(Get): Likewise.
(Put): Likewise.
(Put): Likewise.
* libgnat/a-tiflau.ads: Make the package generic.
(Get): Change parameter type to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-tiflau.adb: Remove clauses for System.Val_Real.
(Get): Change parameter type to Num and call Scan routine.
(Gets): Likewise.
(Load_Real): Move to...
(Put): Change parameter type and add conversion to Long_Long_Float.
(Puts): Likewise.
* libgnat/a-tiflio.adb: Add with and use clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Instantiate Float_Aux on Float,
Long_Float and Long_Long_Float.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.
(Get): Call previous variant.
(Get): Call appropriate Gets routine from auxiliary package.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call previous variant.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-tigeau.ads (Load_Real): New procedure.
* libgnat/a-tigeau.adb (Load_Real): ...here.
* libgnat/a-wtcoau.ads: Add with clause for Float_Aux and make the
package generic.
(Get): Change parameter types to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-wtcoau.adb: Remove clause and renaming for Float_Aux.
(Get): Change parameter types to Num.
(Gets): Likewise.
(Put): Likewise.
(Puts): Likewise.  Add conversion to Long_Long_Float.
* libgnat/a-wtcoio.ads: Remove use clause for Complex_Types and use
qualified names throughout accordingly.
* libgnat/a-wtcoio.adb: Remove clause for Ada.Unchecked_Conversion,
add with clause for Float_Aux, add clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Add clause for Complex_Types.
Instantiate Float_Aux and Complex_Aux on Float, Long_Float, and
Long_Long_Float.  Remove LLF subtype and TFT instantiation.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.
(Get): Call appropriate Gets routine from auxiliary package.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-wtdeau.adb: Remove with and use clause for Float_Aux.
* libgnat/a-wtfiau.adb: Likewise.
* libgnat/a-wtfiio.adb: Add with and use clause for System.Val_LLF.
Instantiate Float_Aux on Long_Long_Float.
(Get): Adjust call to Get routine from auxiliary package.
(Get): Adjust call to Gets routine from auxiliary package.
(Put): Adjust call to Put routine from auxiliary package.
(Put): Adjust call to Puts routine from auxiliary package.
* libgnat/a-wtfiio__128.adb: Likewise.
(Get): Likewise.
(Get): Likewise.
(Put): Likewise.
(Put): Likewise.
* libgnat/a-wtflau.ads: Make the package generic.
(Get): Change parameter type to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-wtflau.adb: Remove clauses for System.Val_Real.
(Get): Change parameter type to Num and call Scan routine. Set
Ptr parameter lazily.
(Gets): Likewise.
(Load_Real): Move to...
(Put): Change parameter type and add conversion to Long_Long_Float.
Bump buffer length to Max_Real_Image_Length.
(Puts): Likewise.
* libgnat/a-wtflio.adb: Add with and use clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Instantiate Float_Aux on Float,
Long_Float and Long_Long_Float.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.  Add
pragma Unsuppress (Range_Check) and manual validity check.
(Get): Call appropriate Gets routine from auxiliary package. Add
pragma Unsuppress (Range_Check) and manual validity check.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-wtgeau.ads (Load_Real): New procedure.
* libgnat/a-wtgeau.adb (Load_Real): ...here.
* libgnat/a-ztcoau.ads: Add with clause for Float_Aux and make the
package generic.
(Get): Change parameter types to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-ztcoau.adb: Remove clause and renaming for Float_Aux.
(Get): Change parameter types to Num.
(Gets): Likewise.
(Put): Likewise.
(Puts): Likewise.  Add conversion to Long_Long_Float.
* libgnat/a-ztcoio.ads: Remove use clause for Complex_Types and use
qualified names throughout accordingly.
* libgnat/a-ztcoio.adb: Remove clause for Ada.Unchecked_Conversion,
add with clause for Float_Aux, add clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Add clause for Complex_Types.
Instantiate Float_Aux and Complex_Aux on Float, Long_Float, and
Long_Long_Float. Remove LLF subtype and TFT instantiation.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.
(Get): Call appropriate Gets routine from auxiliary package.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-ztdeau.adb: Remove with and use clause for Float_Aux.
* libgnat/a-ztfiau.adb: Likewise.
* libgnat/a-ztfiio.adb: Add with and use clause for System.Val_LLF.
Instantiate Float_Aux on Long_Long_Float.
(Get): Adjust call to Get routine from auxiliary package.
(Get): Adjust call to Gets routine from auxiliary package.
(Put): Adjust call to Put routine from auxiliary package.
(Put): Adjust call to Puts routine from auxiliary package.
* libgnat/a-ztfiio__128.adb: Likewise.
(Get): Likewise.
(Get): Likewise.
(Put): Likewise.
(Put): Likewise.
* libgnat/a-ztflau.ads: Make the package generic.
(Get): Change parameter type to Num.
(Put): Likewise.
(Gets): Likewise.
(Puts): Likewise.
* libgnat/a-ztflau.adb: Remove clauses for System.Val_Real.
(Get): Change parameter type to Num and call Scan routine. Set
Ptr parameter lazily.
(Gets): Likewise.
(Load_Real): Move to...
(Put): Change parameter type and add conversion to Long_Long_Float.
Bump buffer length to Max_Real_Image_Length.
(Puts): Likewise.
* libgnat/a-ztflio.adb: Add with and use clauses for System.Val_Flt,
System.Val_LFlt and System.Val_LLF. Instantiate Float_Aux on Float,
Long_Float and Long_Long_Float.
(OK_Float): New boolean constant.
(OK_Long_Float): Likewise.
(Get): Call appropriate Get routine from auxiliary package.  Add
pragma Unsuppress (Range_Check) and manual validity check.
(Get): Call appropriate Gets routine from auxiliary package. Add
pragma Unsuppress (Range_Check) and manual validity check.
(Put): Call appropriate Put routine from auxiliary package.
(Put): Call appropriate Puts routine from auxiliary package.
* libgnat/a-ztgeau.ads (Load_Real): New procedure.
* libgnat/a-ztgeau.adb (Load_Real): ...here.
* libgnat/s-fatsfl.ads: Delete.
* libgnat/s-valflt.ads: New package.
* libgnat/s-vallfl.ads: Likewise.
* libgnat/s-valllf.ads: Likewise.
* libgnat/s-valrea.ads: Make generic. Add assertions, defensive
code and clarify intent.
(Scan_Real): Change parameter type to Num.
(Value_Real): Likewise.
* libgnat/s-valrea.adb: Instantiate Value_R on Uns.
(Integer_to_Real): Change parameter and result to Num.
Call Float_Control.Reset only if the mantissa is 64 bits.  Use
a divide to compute the final value if the scale is negative.
(Scan_Real): Change result to Num.
(Value_Real): Likewise.
* libgnat/s-valuer.adb: Add assertions, defensive code and
clarify intent.
(F_Limit): Delete.
(I_Limit): Likewise.
(Precision_Limit): Always use the integer limit.
* libgnat/s-fatgen.adb: Add pragma Annotate.

3 years ago[Ada] Mark generic body outside of SPARK
Yannick Moy [Wed, 25 Nov 2020 09:33:54 +0000 (10:33 +0100)]
[Ada] Mark generic body outside of SPARK

gcc/ada/

* libgnat/a-tiflio.adb: Mark body not in SPARK.
* libgnat/a-tiflio.ads: Mark spec in SPARK.

3 years ago[Ada] Transform_Function_Array issues
Arnaud Charlet [Mon, 16 Nov 2020 17:10:25 +0000 (18:10 +0100)]
[Ada] Transform_Function_Array issues

gcc/ada/

* exp_ch6.adb (Build_Procedure_Body_Form): Adjust, the
declaration of the procedure form is now insert before the
original function body rather than after.
(Expand_N_Subprogram_Declaration): Deal with private types whose
full views are arrays.
* exp_unst.adb (Unnest_Subprogram): Deal with private types.
(Needs_Fat_Pointer): Code cleanup.
* freeze.adb (Freeze_Subprogram): Ditto.
* exp_util.adb (Build_Procedure_Form): Insert the procedure form
decl before and not after.
* sem_ch6.adb (Analyze_Subprogram_Body_Helper): Build missing
spec when needed for Transform_Function_Array.
* sem_util.adb (Get_Fullest_View): Deal with null entity.

3 years ago[Ada] Simplify discarding nodes when processing aspect/pragma Priority
Piotr Trojanek [Tue, 24 Nov 2020 21:56:40 +0000 (22:56 +0100)]
[Ada] Simplify discarding nodes when processing aspect/pragma Priority

gcc/ada/

* sem_ch13.adb (Analyze_Aspect_Specifications): Simplify code
for aspect Priority.
* sem_prag.adb (Analyze_Pragma): Simplify code for pragma
Priority.

3 years ago[Ada] Crash on unnesting unnamed blocks
Arnaud Charlet [Tue, 24 Nov 2020 16:53:28 +0000 (17:53 +0100)]
[Ada] Crash on unnesting unnamed blocks

gcc/ada/

* exp_ch7.adb (Reset_Scopes_To_Block_Elab_Proc): Do not crash on
a block with no Identifier. Code cleanups.

3 years ago[Ada] Refactor repeated code for Value attributes
Piotr Trojanek [Tue, 24 Nov 2020 15:01:52 +0000 (16:01 +0100)]
[Ada] Refactor repeated code for Value attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Reuse existing code for
attribute Value when analyzing attributes Wide_Value and
Wide_Wide_Value.

3 years ago[Ada] Fix possible infinite recursion in directory iterator
Pascal Obry [Fri, 20 Nov 2020 16:28:50 +0000 (17:28 +0100)]
[Ada] Fix possible infinite recursion in directory iterator

gcc/ada/

* libgnat/g-diopit.adb (Find): Fix possible infinite recursion
in Find iterator.
* libgnat/g-diopit.ads (Find): Update comments accordingly.

3 years ago[Ada] Refactor repeated code for Callable and Terminated attributes
Piotr Trojanek [Mon, 23 Nov 2020 23:31:49 +0000 (00:31 +0100)]
[Ada] Refactor repeated code for Callable and Terminated attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Callable and Terminated attributes; refactor calls to Set_Etype
occurring in both THEN and ELSE branches of an IF statement for
attribute Storage_Size.

3 years ago[Ada] Refactor repeated code for Width attributes
Piotr Trojanek [Mon, 23 Nov 2020 23:18:47 +0000 (00:18 +0100)]
[Ada] Refactor repeated code for Width attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Wide_Wide_Width, Wide_Width and Width attributes.

3 years ago[Ada] Refactor repeated code for Pred and Succ attributes
Piotr Trojanek [Mon, 23 Nov 2020 23:17:02 +0000 (00:17 +0100)]
[Ada] Refactor repeated code for Pred and Succ attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Pred and Succ attributes.

3 years ago[Ada] Refactor repeated code for size attributes
Piotr Trojanek [Mon, 23 Nov 2020 23:05:44 +0000 (00:05 +0100)]
[Ada] Refactor repeated code for size attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Size, Object_Size and Value_Size attributes.

3 years ago[Ada] Refactor repeated code for fixed point attributes
Piotr Trojanek [Mon, 23 Nov 2020 23:00:17 +0000 (00:00 +0100)]
[Ada] Refactor repeated code for fixed point attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Consistently call
Check_Fixed_Point_Type before checking the number of attribute
expressions (like it is done for floating point types); reuse
Check_Fixed_Point_Type_0.

3 years ago[Ada] Remove redundant calls to UI_To_Int in relational operands
Piotr Trojanek [Mon, 23 Nov 2020 22:52:59 +0000 (23:52 +0100)]
[Ada] Remove redundant calls to UI_To_Int in relational operands

gcc/ada/

* exp_disp.adb (Make_Tags): Remove call to UI_To_Int.
* sem_attr.adb (Check_Array_Type): Likewise; also, refine type
of a local variable.
(Analyze_Attribute): Likewise.
(Get_Enclosing_Object): Likewise.
* sem_util.adb (Get_Enum_Lit_From_Pos): Likewise.

3 years ago[Ada] Refactor repeated code for component attributes
Piotr Trojanek [Mon, 23 Nov 2020 22:44:06 +0000 (23:44 +0100)]
[Ada] Refactor repeated code for component attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
First_Bit/Last_Bit and Position attributes.

3 years ago[Ada] Refactor repeated code for real type attributes returning integers
Piotr Trojanek [Mon, 23 Nov 2020 22:30:32 +0000 (23:30 +0100)]
[Ada] Refactor repeated code for real type attributes returning integers

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Machine_Radix and Mantissa attributes.

3 years ago[Ada] Refactor repeated code for real type attributes returning booleans
Piotr Trojanek [Mon, 23 Nov 2020 22:28:46 +0000 (23:28 +0100)]
[Ada] Refactor repeated code for real type attributes returning booleans

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Machine_Overflows and Machine_Rounds attributes.

3 years ago[Ada] Refactor repeated code for real type attributes returning reals
Piotr Trojanek [Mon, 23 Nov 2020 22:27:21 +0000 (23:27 +0100)]
[Ada] Refactor repeated code for real type attributes returning reals

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Large, Small, Safe_Large and Safe_Small attributes.

3 years ago[Ada] Refactor repeated code for floating point attributes returning reals
Piotr Trojanek [Mon, 23 Nov 2020 22:21:19 +0000 (23:21 +0100)]
[Ada] Refactor repeated code for floating point attributes returning reals

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Epsilon, Model_Epsilon, Model_Small, Safe_First and Safe_Las
attributes.

3 years ago[Ada] Refactor repeated code for floating point attributes returning ints
Piotr Trojanek [Mon, 23 Nov 2020 15:54:58 +0000 (16:54 +0100)]
[Ada] Refactor repeated code for floating point attributes returning ints

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Emax, Machine_Emax, Machine_Emin, Machine_Mantissa, Model_Emin,
Model_Mantissa and Safe_Emax attributes.

3 years ago[Ada] Refactor duplicated code for Denorm and Signed_Zeros attributes
Piotr Trojanek [Mon, 23 Nov 2020 15:50:17 +0000 (16:50 +0100)]
[Ada] Refactor duplicated code for Denorm and Signed_Zeros attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Denorm and Signed_Zeros attributes.

3 years ago[Ada] Refactor duplicated code for Adjacent, Copy_Sign and Remainder
Piotr Trojanek [Mon, 23 Nov 2020 15:40:06 +0000 (16:40 +0100)]
[Ada] Refactor duplicated code for Adjacent, Copy_Sign and Remainder

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Adjacent, Copy_Sign and Remainder attributes.
(Check_Floating_Point_Type_2): Fix style in comment.

3 years ago[Ada] Refactor duplicated code for Compose, Leading_Part and Scaling
Piotr Trojanek [Mon, 23 Nov 2020 14:39:32 +0000 (15:39 +0100)]
[Ada] Refactor duplicated code for Compose, Leading_Part and Scaling

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Compose, Leading_Part and Scaling attributes.

3 years agoi386: Fix up -march=x86-64-v[234] vs. target attribute [PR98274]
Jakub Jelinek [Tue, 15 Dec 2020 09:16:08 +0000 (10:16 +0100)]
i386: Fix up -march=x86-64-v[234] vs. target attribute [PR98274]

The following testcase fails to compile.  The problem is that
when ix86_option_override_internal is called the first time for command
line, it sees -mtune= wasn't present on the command line and so as fallback
sets ix86_tune_string to ix86_arch_string value ("x86-64-v2"), but
ix86_tune_specified is false, so we don't find the tuning in the table
but don't error on it.
When processing the target attribute, ix86_tune_string is what
it was earlier left with, but this time ix86_tune_specified is true and
so we error on it.

The following patch does what is done already e.g. for "x86-64" march,
in particular default the tuning to "generic".

2020-12-15  Jakub Jelinek  <jakub@redhat.com>

PR target/98274
* config/i386/i386-options.c (ix86_option_override_internal): Set
ix86_tune_string to "generic" even when it wasn't specified and
ix86_arch_string is "x86-64-v2", "x86-64-v3" or "x86-64-v4".
Remove useless {}s around a single statement.

* gcc.target/i386/pr98274.c: New test.

3 years agolto: set nthreads_var to 1 if it is zero
Martin Liska [Tue, 15 Dec 2020 08:59:04 +0000 (09:59 +0100)]
lto: set nthreads_var to 1 if it is zero

gcc/ChangeLog:

PR lto/98275
* lto-wrapper.c: Do not use -j0 when we are unable to detect
number of cores.

3 years agoi386: Make -march=x86-64-v[234] behave more like other -march= options
Jakub Jelinek [Tue, 15 Dec 2020 08:51:28 +0000 (09:51 +0100)]
i386: Make -march=x86-64-v[234] behave more like other -march= options

If somebody has -march=x86-64-v2 (or -v3 or -v4) in $CFLAGS, $CXXFLAGS etc.,
then -m32 or -mabi=ms stops working.
What is worse, if one configures gcc --with-arch-64=x86-64-v2 (or -v3 or -v4),
then -mabi=ms stops working.

I think that is a nightmare user experience.  It is ok that x86-64-v[234]
behave slightly different from other -march= options (in that they imply
unless overridden -mtune=generic rather then -mtune= equal to the -march
argument), but the error when one mixes it with -mabi=ms, or -m32 doesn't
improve anything.
It is true that the exact option set is only defined in the x86-64 psABI
(IMHO that is a mistake too, we should copy that into the GCC documentation
like we document it for any other -march= option), but there is no reason
why that exact set of CPU features can't be used for other ABIs, it is just
a set of CPU features.  If we add micro-architecture levels to the 32-bit
ABI (I doubt anyone wants to do that, but just hypothetically), then those
micro-architecture levels wouldn't certainly be called x86-64-v* but perhaps
i386-v*.
In the tests, __GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 can't be expected on -m32
not because the CPU feature wouldn't be set, but because the instruction
is 64-bit only and 32-bit code doesn't have __int128 etc. support.

2020-12-15  Jakub Jelinek  <jakub@redhat.com>

* config/i386/i386-options.c (ix86_option_override_internal): Don't
error on -march=x86-64-v[234] with -m32 or -mabi=ms.
* config.gcc: Don't reject --with-arch=x86-64-v[234] or
--with-arch_32=x86-64-v[234].
* doc/invoke.texi (-march=x86-64-v[234]): Document what the option
does for other ABIs.

* gcc.target/i386/x86-64-v2.c: Don't expect
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 to be defined with -m32.
* gcc.target/i386/x86-64-v2-other.c: New test.
* gcc.target/i386/x86-64-v2-msabi.c: New test.
* gcc.target/i386/x86-64-v3.c: Fix a comment pasto.  Don't expect
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 to be defined with -m32.
* gcc.target/i386/x86-64-v3-other.c: New test.
* gcc.target/i386/x86-64-v3-msabi.c: New test.
* gcc.target/i386/x86-64-v4.c:Don't expect
__GCC_HAVE_SYNC_COMPARE_AND_SWAP_16 to be defined with -m32.
* gcc.target/i386/x86-64-v4-other.c: New test.
* gcc.target/i386/x86-64-v4-msabi.c: New test.

3 years agogcov: fix line output for nested functions in JSON format
Martin Liska [Mon, 14 Dec 2020 13:00:08 +0000 (14:00 +0100)]
gcov: fix line output for nested functions in JSON format

gcc/ChangeLog:

PR gcov-profile/98273
* gcov.c (output_json_intermediate_file): Use stack of nested
functions for lines in a source file.  Pop when a function ends.

3 years agolibstdc++: Update link to Unicode-HOWTO
Gerald Pfeifer [Tue, 15 Dec 2020 08:33:18 +0000 (09:33 +0100)]
libstdc++: Update link to Unicode-HOWTO

libstdc++-v3/ChangeLog:

2020-12-15  Gerald Pfeifer  <gerald@pfeifer.com>

* doc/xml/manual/codecvt.xml: Update link to Unicode-HOWTO.
* doc/html/manual/facets.html: Regenerate.

3 years agodoc: Update link to KernelAddressSanitizer
Gerald Pfeifer [Tue, 15 Dec 2020 07:26:50 +0000 (08:26 +0100)]
doc: Update link to KernelAddressSanitizer

gcc/ChangeLog:

2020-12-15  Gerald Pfeifer  <gerald@pfeifer.com>

* doc/invoke.texi (Instrumentation Options): Update link to
KernelAddressSanitizer.

3 years agogcc: xtensa: fix PR target/98285
Max Filippov [Sat, 12 Dec 2020 20:14:40 +0000 (12:14 -0800)]
gcc: xtensa: fix PR target/98285

2020-12-14  Max Filippov  <jcmvbkbc@gmail.com>
gcc/
* config/xtensa/predicates.md (addsubx_operand): Change accepted
values from 2/4/8 to 1..3.
* config/xtensa/xtensa.md (*addx, *subx): Change RTL pattern
to use 'ashift' instead of 'mult'. Update operands[3] value.

gcc/testsuite/
* gcc.target/xtensa/pr98285.c: New test.

3 years agogo-test.exp: retain any characters at end of ERROR line
Ian Lance Taylor [Tue, 15 Dec 2020 04:39:53 +0000 (20:39 -0800)]
go-test.exp: retain any characters at end of ERROR line

* go.test/go-test.exp (errchk): Retain any characters at the end
of the comment.

3 years agoFix up testcase.
liuhongt [Wed, 9 Dec 2020 09:58:22 +0000 (17:58 +0800)]
Fix up testcase.

gcc/testsuite

* gcc.target/i386/pr78102.c: Adjust testcase.

3 years agoDaily bump.
GCC Administrator [Tue, 15 Dec 2020 00:16:35 +0000 (00:16 +0000)]
Daily bump.

3 years agors6000: Update the processor defaults for FreeBSD
Gerald Pfeifer [Sun, 13 Dec 2020 00:00:36 +0000 (01:00 +0100)]
rs6000: Update the processor defaults for FreeBSD

gcc/ChangeLog:

2020-12-13  Piotr Kubaj  <pkubaj@FreeBSD.org>
    Gerald Pfeifer  <gerald@pfeifer.com>

* config/rs6000/freebsd64.h (PROCESSOR_DEFAULT): Update
to PROCESSOR_PPC7450.
(PROCESSOR_DEFAULT64): Update to PROCESSOR_POWER8.

3 years agolibstdc++: Make tests with Undefined Behavior in C++11 UNSUPPORTED
François Dumont [Mon, 14 Dec 2020 21:21:47 +0000 (22:21 +0100)]
libstdc++: Make tests with Undefined Behavior in C++11 UNSUPPORTED

libstdc++-v3/ChangeLog:

* testsuite/23_containers/array/debug/back1_neg.cc: Target c++14 because assertion
is disabled in C++11.
* testsuite/23_containers/array/debug/front1_neg.cc: Likewise.
* testsuite/23_containers/array/debug/square_brackets_operator1_neg.cc: Likewise.

3 years agoaix: Fixinclude updates [PR98208]
Ilya Leoshkevich [Thu, 10 Dec 2020 23:54:49 +0000 (00:54 +0100)]
aix: Fixinclude updates [PR98208]

After 92648faa1cb2 ("aix: Fixinclude") make check-fixincludes began to
fail (at least on gcc121 machine).  Fix by updating fixincludes/tests
and rerunning genfixes.

Co-developed-by: Nathan Sidwell <nathan@acm.org>
fixincludes/ChangeLog:

2020-12-11  Ilya Leoshkevich  <iii@linux.ibm.com>

* fixincl.x: Rerun genfixes.
* inclhack.def(aix_physadr_t): Change test_text to something
that needs to be replaced.
* tests/base/sys/types.h(aix_physadr_t): Add expectation.

3 years agoCorrect/improve maybe_emit_free_warning (PR middle-end/98166, PR c++/57111, PR middle...
Martin Sebor [Mon, 14 Dec 2020 20:30:00 +0000 (13:30 -0700)]
Correct/improve maybe_emit_free_warning (PR middle-end/98166, PR c++/57111, PR middle-end/98160).

Resolves:
PR middle-end/98166 - bogus -Wmismatched-dealloc on user-defined allocator and inlining
PR c++/57111 - 57111 - Generalize -Wfree-nonheap-object to delete
PR middle-end/98160 - ICE in default_tree_printer at gcc/tree-diagnostic.c:270

gcc/ChangeLog:

PR middle-end/98166
PR c++/57111
PR middle-end/98160
* builtins.c (check_access): Call tree_inlined_location
fndecl_alloc_p): Handle BUILT_IN_ALIGNED_ALLOC and
BUILT_IN_GOMP_ALLOC.
call_dealloc_p): Remove unused function.
(new_delete_mismatch_p): Call valid_new_delete_pair_p and rework.
(matching_alloc_calls_p): Handle built-in deallocation functions.
(warn_dealloc_offset): Corrct the handling of user-defined operators
delete.
(maybe_emit_free_warning): Avoid assuming expression is a decl.
Simplify.
* doc/extend.texi (attribute malloc): Update.
* tree-ssa-dce.c (valid_new_delete_pair_p): Factor code out into
valid_new_delete_pair_p in tree.c.
* tree.c (tree_inlined_location): Define new function.
(valid_new_delete_pair_p): Define.
* tree.h (tree_inlined_location): Declare.
(valid_new_delete_pair_p): Declare.

gcc/c-family/ChangeLog:

PR middle-end/98166
PR c++/57111
PR middle-end/98160
* c-attribs.c (maybe_add_noinline): New function.
(handle_malloc_attribute): Call it.  Use ATTR_FLAG_INTERNAL.
Implicitly add attribute noinline to functions not declared inline
and warn on those.

libstdc++-v3/ChangeLog:
* testsuite/ext/vstring/requirements/exception/basic.cc: Suppress
a false positive warning.
* testsuite/ext/vstring/requirements/exception/propagation_consistent.cc:
  Same.

gcc/testsuite/ChangeLog:

PR middle-end/98166
PR c++/57111
PR middle-end/98160
* g++.dg/warn/Wmismatched-dealloc-2.C: Adjust test of expected warning.
* g++.dg/warn/Wmismatched-new-delete.C: Same.
* gcc.dg/Wmismatched-dealloc.c: Same.
* c-c++-common/Wfree-nonheap-object-2.c: New test.
* c-c++-common/Wfree-nonheap-object-3.c: New test.
* c-c++-common/Wfree-nonheap-object.c: New test.
* c-c++-common/Wmismatched-dealloc.c: New test.
* g++.dg/warn/Wfree-nonheap-object-3.C: New test.
* g++.dg/warn/Wfree-nonheap-object-4.C: New test.
* g++.dg/warn/Wmismatched-dealloc-2.C: New test.
* g++.dg/warn/Wmismatched-new-delete-2.C: New test.
* g++.dg/warn/Wmismatched-new-delete.C: New test.
* gcc.dg/Wmismatched-dealloc-2.c: New test.
* gcc.dg/Wmismatched-dealloc-3.c: New test.
* gcc.dg/Wmismatched-dealloc.c: New test.

3 years agodisable --with-{cpu,arch,tune}-32
Sebastian Pop [Thu, 3 Dec 2020 17:35:18 +0000 (17:35 +0000)]
disable --with-{cpu,arch,tune}-32

gcc/
* config.gcc (aarch64*-*-*): Remove --with-{cpu,arch,tune}-32 flags.

3 years agoAArch64: Add support for --with-tune
Wilco Dijkstra [Thu, 3 Dec 2020 18:40:34 +0000 (18:40 +0000)]
AArch64: Add support for --with-tune

Add support for --with-tune. Like --with-cpu and --with-arch, the argument is
validated and transformed into a -mtune option to be processed like any other
command-line option.  --with-tune has no effect if a -mcpu or -mtune option
is used. The validating code didn't allow --with-cpu=native, so explicitly
allow that.

Co-authored-by: Delia Burduv <delia.burduv@arm.com>
Bootstrap OK, regress pass, OK to commit?

2020-09-03  Wilco Dijkstra  <wdijkstr@arm.com>

gcc/
* config.gcc (aarch64*-*-*): Add --with-tune. Support --with-cpu=native.
* config/aarch64/aarch64.h (OPTION_DEFAULT_SPECS): Add --with-tune.

gcc/testsuite/
* lib/target-supports.exp (check_effective_target_tune_cortex_a76): New
effective target test.
* gcc.target/aarch64/with-tune-config.c: New test.
* gcc.target/aarch64/with-tune-march.c: Likewise.
* gcc.target/aarch64/with-tune-mcpu.c: Likewise.
* gcc.target/aarch64/with-tune-mtune.c: Likewise.

3 years agogcov: Update comments.
Martin Liska [Mon, 14 Dec 2020 12:07:14 +0000 (13:07 +0100)]
gcov: Update comments.

gcc/ChangeLog:

* gcov.c (output_json_intermediate_file): Update comments.

3 years ago[Ada] Analyze second parameter of attribute Scaling
Piotr Trojanek [Mon, 23 Nov 2020 14:30:06 +0000 (15:30 +0100)]
[Ada] Analyze second parameter of attribute Scaling

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Resolve second parameter of
attribute Scaling just like it is resolved for a similar
attribute Compose.

3 years ago[Ada] Refactor duplicated code for First and Last attributes
Piotr Trojanek [Mon, 23 Nov 2020 13:38:45 +0000 (14:38 +0100)]
[Ada] Refactor duplicated code for First and Last attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
First/Last, First_Bit/Last_Bit and First_Valid/Last_Valid
attributes.

3 years ago[Ada] Process Truncation just like other floating point attributes
Piotr Trojanek [Mon, 23 Nov 2020 13:24:50 +0000 (14:24 +0100)]
[Ada] Process Truncation just like other floating point attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge similar code for
Truncation and other floating point attributes.

3 years ago[Ada] Refactor duplicated code for floating point attributes
Piotr Trojanek [Mon, 23 Nov 2020 12:47:39 +0000 (13:47 +0100)]
[Ada] Refactor duplicated code for floating point attributes

gcc/ada/

* sem_attr.adb (Analyze_Attribute): Merge identical code for
Ceiling, Floor, Fraction, Machine, Machine_Rounding, Model,
Rounding and Unbiased_Rounding.

3 years ago[Ada] Small adjustments to fixed-point I/O units
Eric Botcazou [Mon, 23 Nov 2020 10:39:05 +0000 (11:39 +0100)]
[Ada] Small adjustments to fixed-point I/O units

gcc/ada/

* libgnat/a-tifiio.adb: Adjust documentation.
(OK_Get_32): Compare the object size of the base type.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise.
* libgnat/a-tifiio__128.adb: Adjust documentation.
(OK_Get_32): Compare the object size of the base type.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise.
(OK_Get_128): Likewise.
(OK_Put_128): Likewise.
* libgnat/a-wtfiio.adb (OK_Get_32): Likewise.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise
* libgnat/a-wtfiio__128.adb (OK_Get_32): Likewise.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise.
(OK_Get_128): Likewise.
(OK_Put_128): Likewise.
* libgnat/a-ztfiio.adb (OK_Get_32): Likewise.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise
* libgnat/a-ztfiio__128.adb (OK_Get_32): Likewise.
(OK_Put_32): Likewise.
(OK_Get_64): Likewise.
(OK_Put_64): Likewise.
(OK_Get_128): Likewise.
(OK_Put_128): Likewise.

3 years ago[Ada] Small cleanup in the Ada.Text_IO hierarchy
Eric Botcazou [Mon, 23 Nov 2020 07:50:10 +0000 (08:50 +0100)]
[Ada] Small cleanup in the Ada.Text_IO hierarchy

gcc/ada/

* libgnat/a-tifiio.adb (Get): Replace Current_Input with Current_In.
* libgnat/a-tifiio__128.adb: (Get): Likewise.
* libgnat/a-wtcoio.adb (Get): Likewise.
(Put): Replace Current_Output with Current_Out.
* libgnat/a-wtdeio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtdeio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtenio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtfiio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtfiio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtflio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtinio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtinio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtmoio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-wtmoio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztcoio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztdeio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztdeio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztenio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztfiio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztfiio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztflio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztinio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztinio__128.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztmoio.adb (Get): Likewise.
(Put): Likewise.
* libgnat/a-ztmoio__128.adb (Get): Likewise.
(Put): Likewise.

3 years ago[Ada] Incorrect accessibility level on type in formal package
Justin Squirek [Fri, 20 Nov 2020 13:11:12 +0000 (08:11 -0500)]
[Ada] Incorrect accessibility level on type in formal package

gcc/ada/

* sem_util.adb, sem_util.ads (In_Generic_Formal_Package):
Created to identify type declarations occurring within generic
formal packages.
* sem_res.adb (Resolve_Allocator): Add condition to avoid
emitting an error for allocators when the type being allocated
is class-wide and from a generic formal package.

3 years ago[Ada] Fix alignment warning in System.Fat_Gen unit
Eric Botcazou [Sun, 22 Nov 2020 11:00:02 +0000 (12:00 +0100)]
[Ada] Fix alignment warning in System.Fat_Gen unit

gcc/ada/

* libgnat/s-fatgen.adb (Tiny80): Add alignment clause.

3 years ago[Ada] Add annotation after recent compiler changes
Arnaud Charlet [Sun, 22 Nov 2020 10:34:54 +0000 (05:34 -0500)]
[Ada] Add annotation after recent compiler changes

gcc/ada/

* exp_util.adb (Process_Current_Value_Condition): Add assertion.
* libgnat/s-fatgen.adb (Scaling): Add annotation.

3 years ago[Ada] Fix compile time evaluation of shift intrinsics
Arnaud Charlet [Fri, 20 Nov 2020 15:18:22 +0000 (10:18 -0500)]
[Ada] Fix compile time evaluation of shift intrinsics

gcc/ada/

* sem_eval.adb (Fold_Shift): Compute values using the base type.

3 years ago[Ada] Adjust again previous change to System.Fat_Gen
Eric Botcazou [Sat, 21 Nov 2020 23:54:18 +0000 (00:54 +0100)]
[Ada] Adjust again previous change to System.Fat_Gen

gcc/ada/

* libgnat/s-fatgen.adb: Add with clause for Interfaces and use
type clause for Interfaces.Unsigned_64.
(Small): Comment out.
(Tiny): Likewise.
(Tiny16): New integer constant.
(Tiny32): Likewise.
(Tiny64): Likewise.
(Tiny80): New integer array constant.
(Pred): Declare a local overlay for Tiny.
(Succ): Likewise.

3 years ago[Ada] Fix internal error on bit-packed array in Volatile_Full_Access record
Eric Botcazou [Fri, 20 Nov 2020 20:29:13 +0000 (21:29 +0100)]
[Ada] Fix internal error on bit-packed array in Volatile_Full_Access record

gcc/ada/

* exp_pakd.adb (Expand_Bit_Packed_Element_Set): Fix again packed
array type in complex cases where array is Volatile.
* exp_util.adb (Remove_Side_Effects): Do not force a renaming to
be handled by the back-end.

3 years ago[Ada] Adjust previous change to System.Fat_Gen
Eric Botcazou [Fri, 20 Nov 2020 18:33:21 +0000 (19:33 +0100)]
[Ada] Adjust previous change to System.Fat_Gen

gcc/ada/

* libgnat/s-fatgen.adb: Remove use clause for
System.Unsigned_Types.
(Scaling): Add renaming of System.Unsigned_Types and use type
clause for Long_Long_Unsigned.

3 years ago[Ada] Implement part of System.Fat_Gen more efficiently
Eric Botcazou [Thu, 19 Nov 2020 14:35:35 +0000 (15:35 +0100)]
[Ada] Implement part of System.Fat_Gen more efficiently

gcc/ada/

* libgnat/s-fatgen.ads (Compose): Add pragma Inline.
(Copy_Sign): Likewise.
(Exponent): Likewise.
(Fraction): Likewise.
* libgnat/s-fatgen.adb: Remove with clause for System, add
with and use clauses for System.Unsigned_Types.
Add pragma Warnings (Off) for non-static constants.
Remove precomputed tables of powers of radix and add a few
constants describing the floating-point format.
(Gradual_Scaling): Delete.
(Copy_Sign): Reimplement directly.
(Decompose): Likewise.
(Scaling): Likewise.
(Pred): Speed up.
(Succ): Likewise.
(Truncation): Tidy up.
(Valid): Move constants to library level.

3 years ago[Ada] Remove double initialization of the known value cache
Piotr Trojanek [Fri, 6 Nov 2020 11:01:52 +0000 (12:01 +0100)]
[Ada] Remove double initialization of the known value cache

gcc/ada/

* sem_eval.adb (CV_Cache): Remove initialization at elaboration.

3 years ago[Ada] Fix documentation of -gnatw.K switch (activates => disables)
Gary Dismukes [Thu, 19 Nov 2020 20:18:39 +0000 (15:18 -0500)]
[Ada] Fix documentation of -gnatw.K switch (activates => disables)

gcc/ada/

* doc/gnat_ugn/building_executable_programs_with_gnat.rst:
Correct documentation of the -gnatw.K switch to say that it
disables rather than activates the warning.
* gnat_ugn.texi: Regenerate.

3 years ago[Ada] armhf-linux: symbolic tracebacks
Doug Rupp [Thu, 19 Nov 2020 16:35:47 +0000 (08:35 -0800)]
[Ada] armhf-linux: symbolic tracebacks

gcc/ada/

* tracebak.c: Add a section for ARM Linux.

3 years ago[Ada] Implement AI12-0398-1/03
Ghjuvan Lacambre [Wed, 18 Nov 2020 10:23:05 +0000 (11:23 +0100)]
[Ada] Implement AI12-0398-1/03

gcc/ada/

* par-ch3.adb (P_Discriminant_Part_Opt): Parse aspects, update
documentation.
* par-ch6.adb (P_Return_Statement): Likewise.
* par-ch9.adb (P_Entry_Index_Specification): Likewise.

3 years ago[Ada] Additional fixes for Default_Initial_Condition
Gary Dismukes [Wed, 18 Nov 2020 23:06:14 +0000 (18:06 -0500)]
[Ada] Additional fixes for Default_Initial_Condition

gcc/ada/

* exp_aggr.adb (Build_Array_Aggr_Code.Gen_Assign): Move
generation of the call for DIC check past the optional
generation of calls to controlled Initialize procedures.
* exp_ch3.adb
(Build_Array_Init_Proc.Init_One_Dimension.Possible_DIC_Call):
Suppress generation of a DIC call when the array component type
is controlled.  The call will now be generated later inside the
array's DI (Deep_Initialize) procedure.
* exp_ch7.adb
(Make_Deep_Array_Body.Build_Initialize_Statements): Generate a
DIC call (when needed by the array component type) after any
call to the component type's controlled Initialize procedure, or
generate the DIC call by itself if there's no Initialize to
call.
* sem_aggr.adb (Resolve_Record_Aggregate.Add_Association):
Simplify condition to only test Is_Box_Init_By_Default (previous
condition was overkill, as well as incorrect in some cases).
* sem_elab.adb (Active_Scenarios.Output_Call): For
Default_Initial_Condition, suppress call to
Output_Verification_Call when the subprogram is a partial DIC
procedure.

3 years ago[Ada] Fix couple of bugs in the implementation of Round attribute
Eric Botcazou [Wed, 18 Nov 2020 20:42:18 +0000 (21:42 +0100)]
[Ada] Fix couple of bugs in the implementation of Round attribute

gcc/ada/

* exp_attr.adb (Expand_N_Attribute_Reference) <Attribute_Round>:
Adjust commentary and set the Rounded_Result flag on the type
conversion node when the node is needed.
* exp_ch4.adb (Expand_N_Type_Conversion): Minor tweak.
(Fixup_Universal_Fixed_Operation): Look through the type conversion
only when it is to Universal_Real.
* exp_fixd.adb: Remove with and use clauses for Snames.
(Build_Divide): Remove redundant test.
(Expand_Convert_Float_To_Fixed): Use Rounded_Result flag on the
node to set the truncation parameter.

3 years ago[Ada] Simplify prevention of cascaded errors for Refined_State
Piotr Trojanek [Wed, 18 Nov 2020 14:52:55 +0000 (15:52 +0100)]
[Ada] Simplify prevention of cascaded errors for Refined_State

gcc/ada/

* sem_prag.adb (Analyze_Refinement_Clause): Simplify recently
added code for preventing cascaded errors.

3 years ago[Ada] Compiler crash on call to function instance
Bob Duff [Mon, 16 Nov 2020 20:02:47 +0000 (15:02 -0500)]
[Ada] Compiler crash on call to function instance

gcc/ada/

* exp_ch6.adb (Is_Build_In_Place_Result_Type): Further narrow
the conditions under which we enable build-in-place for
controlled types.

3 years ago[Ada] Fix warning control character for message on IN OUT parameter
Yannick Moy [Tue, 17 Nov 2020 15:04:34 +0000 (16:04 +0100)]
[Ada] Fix warning control character for message on IN OUT parameter

gcc/ada/

* sem_warn.adb (Output_Non_Modified_In_Out_Warnings): Use right
warning control character 'k' in both comment and call to
Errout_Msg_N.

3 years ago[Ada] Refine error messages on illegal Refined_State in SPARK
Yannick Moy [Mon, 16 Nov 2020 20:50:17 +0000 (21:50 +0100)]
[Ada] Refine error messages on illegal Refined_State in SPARK

gcc/ada/

* sem_prag.adb (Analyze_Refined_State_In_Decl_Part): Refine the
error message for missing Part_Of on constituent. Avoid
cascading error.

3 years ago[Ada] Avoid reanalysis of malformed dependency relations
Piotr Trojanek [Mon, 16 Nov 2020 20:40:56 +0000 (21:40 +0100)]
[Ada] Avoid reanalysis of malformed dependency relations

gcc/ada/

* sem_prag.adb (Analyze_Depends_In_Decl_Part): Replace early
returns with goto Leave.
(Collect_Subprogram_Inputs_Outputs): Fix style in comment.

3 years ago[Ada] Tidy up implementation of System.Fat_Gen.Valid and inline it again
Eric Botcazou [Tue, 17 Nov 2020 08:21:19 +0000 (09:21 +0100)]
[Ada] Tidy up implementation of System.Fat_Gen.Valid and inline it again

gcc/ada/

* libgnat/s-fatgen.ads (Valid): Add again pragma Inline.
* libgnat/s-fatgen.adb (Valid): Improve commentary, tidy up left
and right, and remove superfluous trick for denormalized numbers.

3 years ago[Ada] Fix analysis of access objects in Depends contracts
Piotr Trojanek [Mon, 16 Nov 2020 14:21:20 +0000 (15:21 +0100)]
[Ada] Fix analysis of access objects in Depends contracts

gcc/ada/

* sem_prag.adb (Find_Role): Constant object of
access-to-constant and access-to-subprogram types are not
writable.
(Collect_Subprogram_Inputs_Outputs): In-parameters of
access-to-variable type can act as outputs of the Depends
contracts.

3 years ago[Ada] Update comment for processing of pragma Assertion_Policy
Piotr Trojanek [Thu, 5 Nov 2020 09:14:36 +0000 (10:14 +0100)]
[Ada] Update comment for processing of pragma Assertion_Policy

gcc/ada/

* sa_messages.ads: Reference Subprogram_Variant in the comment
for Assertion_Check.
* sem_prag.adb (Analyze_Pragma): Add Subprogram_Variant as an
ID_ASSERTION_KIND; move Default_Initial_Condition as an
RM_ASSERTION_KIND.

3 years ago[Ada] Correctly mark subprogram as not always inlined in GNATprove mode
Yannick Moy [Mon, 16 Nov 2020 11:06:32 +0000 (12:06 +0100)]
[Ada] Correctly mark subprogram as not always inlined in GNATprove mode

gcc/ada/

* inline.adb (Cannot_Inline): Add No_Info parameter to disable
info message.
* inline.ads (Cannot_Inline): When No_Info is set to True, do
not issue info message in GNATprove mode, but still mark the
subprogram as not always inlined.
* sem_res.adb (Resolve_Call): Always call Cannot_Inline inside
an assertion expression.

3 years ago[Ada] Adjust documentation of System.Img_Util.Set_Decimal_Digits
Eric Botcazou [Mon, 16 Nov 2020 11:03:31 +0000 (12:03 +0100)]
[Ada] Adjust documentation of System.Img_Util.Set_Decimal_Digits

gcc/ada/

* libgnat/s-imguti.ads (Set_Decimal_Digits): Adjust documentation.

3 years agopreprocessor: Deferred macro support
Nathan Sidwell [Mon, 14 Dec 2020 15:21:49 +0000 (07:21 -0800)]
preprocessor: Deferred macro support

For deferred macros we also need a new field on the macro itself, so
that the module machinery can determine the macro was imported.  Also
the documentation for the hashnode's deferred field was incomplete.

libcpp/
* include/cpplib.h (struct cpp_macro): Add imported_p field.
(struct cpp_hashnode): Tweak deferred field documentation.
* macro.c (_cpp_new_macro): Clear new field.
(cpp_get_deferred_macro, get_deferred_or_lazy_macro): Assert
more.

3 years agomiddle-end: Exclude TOP permute from blend considerations
Tamar Christina [Mon, 14 Dec 2020 15:20:05 +0000 (15:20 +0000)]
middle-end: Exclude TOP permute from blend considerations

Similarly to UNKNOWN permutes, TOP needs to be excluded from being considered
for blends because it produces no permute to check.

gcc/ChangeLog:

PR middle-end/98264
* tree-vect-slp-patterns.c (linear_loads_p): Exclude TOP permute.

gcc/testsuite/ChangeLog:

PR middle-end/98264
* gcc.target/i386/pr98264.c: New test.

3 years agoLimit perf data buffer during feature checking
Ilya Leoshkevich [Tue, 8 Dec 2020 12:17:58 +0000 (13:17 +0100)]
Limit perf data buffer during feature checking

Commit 2ead1ab91123 ("Limit perf data buffer during profiling") added
-m8 to perf invocations during running tests, but the same problem
exists for checking whether perf is working in the first place.

gcc/testsuite/ChangeLog:

2020-12-08  Ilya Leoshkevich  <iii@linux.ibm.com>

* lib/target-supports.exp(check_profiling_available): Limit
perf data buffer.

3 years ago.dir-locals.el: Set 'fill-column' to 80 for c-mode
Andrea Corallo [Fri, 11 Dec 2020 14:35:25 +0000 (15:35 +0100)]
.dir-locals.el: Set 'fill-column' to 80 for c-mode

ChangeLog

2020-12-11  Andrea Corallo  <andrea.corallo@arm.com>

* .dir-locals.el (c-mode): Set 'fill-column' to 80 columns.

3 years agoarm: Auto-vectorization for MVE: vneg
Christophe Lyon [Mon, 7 Dec 2020 14:43:18 +0000 (14:43 +0000)]
arm: Auto-vectorization for MVE: vneg

This patch enables MVE vneg instructions for auto-vectorization.  MVE
vnegq insns in mve.md are modified to use 'neg' instead of unspec
expression.  The neg<mode>2 expander is added to vec-common.md.

Existing patterns in neon.md are prefixed with neon_.
It's not clear why we have different patterns for VDQW
and VH in neon.md, when WDQWH handles both, and patterns
with VDQ have provision for attributes for FP modes.

Another question is why <absneg_str><mode>2 always sets
neon_abs<q> type when it also handles neon_neq<q> cases.

2020-12-11  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/
* config/arm/mve.md (mve_vnegq_f): Use 'neg' instead of unspec.
(mve_vnegq_s): Likewise.
* config/arm/neon.md (neg<mode>2): Rename into neon_neg<mode>2.
(<absneg_str><mode>2): Rename into neon_<absneg_str><mode>2.
(neon_v<absneg_str><mode>): Call gen_neon_<absneg_str><mode>2.
(vashr<mode>3): Call gen_neon_neg<mode>2.
(vlshr<mode>3): Call gen_neon_neg<mode>2.
(neon_vneg<mode>): Call gen_neon_neg<mode>2.
* config/arm/unspecs.md (VNEGQ_F, VNEGQ_S): Remove.
* config/arm/vec-common.md (neg<mode>2): New expander.

gcc/testsuite/
* gcc.target/arm/simd/mve-vneg.c: Add tests for vneg.

3 years agoarm: Auto-vectorization for MVE: vmvn
Christophe Lyon [Wed, 2 Dec 2020 12:20:02 +0000 (12:20 +0000)]
arm: Auto-vectorization for MVE: vmvn

This patch enables MVE vmvnq instructions for auto-vectorization.  MVE
vmvnq insns in mve.md are modified to use 'not' instead of unspec
expression to support one_cmpl<mode>2.  The one_cmpl<mode>2 expander
is added to vec-common.md.

2020-12-11  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/
* config/arm/iterators.md (VDQNOTM2): New mode iterator.
(supf): Remove VMVNQ_S and VMVNQ_U.
(VMVNQ): Remove.
* config/arm/mve.md (mve_vmvnq_u<mode>): New entry for vmvn
instruction using expression not.
(mve_vmvnq_s<mode>): New expander.
* config/arm/neon.md (one_cmpl<mode>2): Renamed into
one_cmpl<mode>2_neon.
* config/arm/unspecs.md (VMVNQ_S, VMVNQ_U): Remove.
* config/arm/vec-common.md (one_cmpl<mode>2): New expander.

gcc/testsuite/
* gcc.target/arm/simd/mve-vmvn.c: Add tests for vmvn.

3 years agoarm: Auto-vectorization for MVE: vbic
Christophe Lyon [Wed, 25 Nov 2020 11:08:48 +0000 (11:08 +0000)]
arm: Auto-vectorization for MVE: vbic

This patch enables MVE vbic instructions for auto-vectorization.  MVE
vbicq insns in mve.md are modified to use 'and not' instead of unspec
expression.

2020-12-11  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/
* config/arm/iterators.md (supf): Remove VBICQ_S and VBICQ_U.
(VBICQ): Remove.
* config/arm/mve.md (mve_vbicq_u<mode>): New entry for vbic
instruction using expression and not.
(mve_vbicq_s<mode>): New expander.
(mve_vbicq_f<mode>): Replace use of unspec by 'and not'.
* config/arm/unspecs.md (VBICQ_S, VBICQ_U, VBICQ_F): Remove.

gcc/testsuite/
* gcc.target/arm/simd/mve-vbic.c: Add tests for vbic.

3 years agoarm: Auto-vectorization for MVE: veor
Christophe Lyon [Fri, 13 Nov 2020 13:05:43 +0000 (13:05 +0000)]
arm: Auto-vectorization for MVE: veor

This patch enables MVE veorq instructions for auto-vectorization.  MVE
veorq insns in mve.md are modified to use xor instead of unspec
expression to support xor<mode>3.  The xor<mode>3 expander is added to
vec-common.md

2020-12-11  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/
* config/arm/iterators.md (supf): Remove VEORQ_S and VEORQ_U.
(VEORQ): Remove.
* config/arm/mve.md (mve_veorq_u<mode>): New entry for veor
instruction using expression xor.
(mve_veorq_s<mode>): New expander.
(mve_veorq_f<mode>): Use 'xor' code instead of unspec.
* config/arm/neon.md (xor<mode>3): Renamed into xor<mode>3_neon.
* config/arm/unspecs.md (VEORQ_S, VEORQ_U, VEORQ_F): Remove.
* config/arm/vec-common.md (xor<mode>3): New expander.

gcc/testsuite/
* gcc.target/arm/simd/mve-veor.c: Add tests for veor.

3 years agoarm,testsuite: Fix vect-half-floats.c test
Christophe Lyon [Mon, 14 Dec 2020 10:40:45 +0000 (10:40 +0000)]
arm,testsuite: Fix vect-half-floats.c test

This patch fixes typos in effective targets which otherwise lead to
DejaGnu errors.

It also replaces dg-additional-options with dg-options to avoid
compiling with -ansi -pedantic-errors, resulting in
error: ISO C does not support the '_Float16' type [-Wpedantic]

2020-12-14  Christophe Lyon  <christophe.lyon@linaro.org>

gcc/testsuite/
* gcc.target/arm/vect-half-floats.c: Fix typos.

3 years agosanitizer: do not ICE for pointer cmp/sub
Martin Liska [Wed, 9 Dec 2020 15:21:18 +0000 (16:21 +0100)]
sanitizer: do not ICE for pointer cmp/sub

gcc/c/ChangeLog:

PR sanitizer/98204
* c-typeck.c (pointer_diff): Do not emit a top-level
sanitization.
(build_binary_op): Likewise.

gcc/testsuite/ChangeLog:

PR sanitizer/98204
* c-c++-common/asan/pr98204.c: New test.

3 years agoaarch64: Add support for Cortex-A78C
Przemyslaw Wirkus [Mon, 14 Dec 2020 09:22:47 +0000 (09:22 +0000)]
aarch64: Add support for Cortex-A78C

This patch adds support for -mcpu=cortex-a78c command line option.
For more information about this processor, see [0]:

[0] https://developer.arm.com/ip-products/processors/cortex-a/cortex-a78c

gcc/ChangeLog:

* config/aarch64/aarch64-cores.def (AARCH64_CORE): Add Cortex-A78C core.
* config/aarch64/aarch64-tune.md: Regenerate.
* doc/invoke.texi: Update docs.

3 years ago-fgo-dump-spec: skip typedefs that match struct tag
Nikhil Benesch [Mon, 14 Dec 2020 07:37:11 +0000 (23:37 -0800)]
-fgo-dump-spec: skip typedefs that match struct tag

gcc/:
* godump.c (go_output_typedef): Suppress typedefs whose name
matches the tag of the underlying struct, union, or enum.
Output declarations for enums that do not appear in typedefs.
gcc/testsuite:
* gcc.misc-tests/godump-1.c: Add test cases.

3 years agolibstdc++: Fix several _GLIBCXX_DEBUG tests
François Dumont [Sat, 12 Dec 2020 17:02:47 +0000 (18:02 +0100)]
libstdc++: Fix several _GLIBCXX_DEBUG tests

libstdc++-v3/ChangeLog:

* testsuite/23_containers/array/debug/back2_neg.cc: target c++14 because assertion
for constexpr is disabled in C++11.
* testsuite/23_containers/array/debug/front2_neg.cc: Likewise.
* testsuite/23_containers/array/debug/square_brackets_operator2_neg.cc: Likewise.
* testsuite/23_containers/vector/debug/multithreaded_swap.cc: Include <memory>
for shared_ptr.

3 years agoDaily bump.
GCC Administrator [Mon, 14 Dec 2020 00:16:29 +0000 (00:16 +0000)]
Daily bump.

3 years agoVAX: Unify push operation selection
Maciej W. Rozycki [Sun, 13 Dec 2020 20:46:17 +0000 (20:46 +0000)]
VAX: Unify push operation selection

Avoid the possibility of code discrepancies like one fixed with the
previous change and improve the structure of code by selecting between
push and non-push operations in a single place in `vax_output_int_move'.

The PUSHAB/MOVAB address moves are never actually produced from this
code as the SImode invocation of this function is guarded with the
`nonsymbolic_operand' predicate, but let's not mess up with this code
too much on this occasion and keep the piece in place.

* config/vax/vax.c (vax_output_int_move): Unify push operation
selection.

3 years agoVAX: Check the correct operand for constant 0 push operation
Maciej W. Rozycki [Sun, 13 Dec 2020 20:46:17 +0000 (20:46 +0000)]
VAX: Check the correct operand for constant 0 push operation

Check the output operand for representing pushing a value onto the stack
rather than the constant 0 input in determining whether to use the PUSHL
or the CLRL instruction for a SImode move.  The latter actually works by
means of using the predecrement addressing mode with the SP register and
the machine code produced even takes the same number of bytes, however
at least with some VAX implementations it incurs a performance penalty.
Besides, we don't want to check the wrong operand anyway and have code
that works by chance only.

Add a test case covering push operations; for operands different from
constant zero there is actually a code size advantage for using PUSHL
rather than the equivalent MOVL instruction.

gcc/
* config/vax/vax.c (vax_output_int_move): Check the correct
operand for constant 0 push operation.

gcc/testsuite/
* gcc.target/vax/push.c: New test.