platform/upstream/bluez.git
4 years agoadapter: Fix length calculation of filter UUIDs on big endian
Luiz Augusto von Dentz [Wed, 6 Mar 2019 12:39:41 +0000 (14:39 +0200)]
adapter: Fix length calculation of filter UUIDs on big endian

The management interface expect all values to be in little endian
thus the length of uuids needs to be converted on big endian.

Change-Id: I0f9759f49fb8a91a9e7f2cdf8d7b50228ded85c9
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding for HCI LE Transmitter Test command [v3]
Luiz Augusto von Dentz [Thu, 28 Feb 2019 08:47:49 +0000 (10:47 +0200)]
monitor: Add decoding for HCI LE Transmitter Test command [v3]

This decodes LE Transmitter Test command [v3] introduced in 5.1.

Change-Id: Icb918f6cfa05322437a99627b04746c73878fa69
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding for HCI LE Receiver Test command [v3]
Luiz Augusto von Dentz [Wed, 27 Feb 2019 14:35:44 +0000 (16:35 +0200)]
monitor: Add decoding for HCI LE Receiver Test command [v3]

This decodes LE Receiver Test command [v3] introduced in 5.1.

Change-Id: I11ba98e6d7b529790cf8db876fb3cad28eaf793c
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Decode LL_CLOCK_ACCURACY_*
Luiz Augusto von Dentz [Wed, 27 Feb 2019 11:19:11 +0000 (13:19 +0200)]
monitor: Decode LL_CLOCK_ACCURACY_*

This introduces the command passing for LL_CLOCK_ACCURACY_* PDUs added
in 5.1.

Change-Id: I1ea4b2c13c60ffc842ae50fbc5c55830a0603e35
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Decode LL_PERIODIC_SYNC_IND
Luiz Augusto von Dentz [Wed, 27 Feb 2019 11:12:27 +0000 (13:12 +0200)]
monitor: Decode LL_PERIODIC_SYNC_IND

This introduces the command passing for LL_PERIODIC_SYNC_IND PDU added
in 5.1.

Change-Id: I6bbc4ef6107c3bf0045ef3427458bacfec95ea92
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Decode LL_CTE_*
Luiz Augusto von Dentz [Tue, 26 Feb 2019 17:01:14 +0000 (19:01 +0200)]
monitor: Decode LL_CTE_*

This introduces the command passing for LL_CTE_* PDUs added in 5.1.

Change-Id: Ife9c82a0497872b29672ecbb4b6c2d5622a32eee
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding support for LL_MIN_USED_CHANNELS
Luiz Augusto von Dentz [Tue, 26 Feb 2019 13:30:46 +0000 (15:30 +0200)]
monitor: Add decoding support for LL_MIN_USED_CHANNELS

This prints makes the fields to be printed instead of just decoding
the PDU name.

Change-Id: Ida4330e9418ed7be5a6d4118d1e9097d4901aea8
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding support for LL_PHY_UPDATE_IND
Luiz Augusto von Dentz [Tue, 26 Feb 2019 13:17:05 +0000 (15:17 +0200)]
monitor: Add decoding support for LL_PHY_UPDATE_IND

This prints makes the fields to be printed instead of just decoding
the PDU name.

Change-Id: Ie073880a8ed77c59d84c2e585486b2222a16926a
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding support for LL_PHY_*
Luiz Augusto von Dentz [Tue, 26 Feb 2019 12:51:25 +0000 (14:51 +0200)]
monitor: Add decoding support for LL_PHY_*

This prints makes the fields to be printed instead of just decoding
the PDU name.

Change-Id: I0b18a0e73a7e818276151369424757dfbf59223c
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add decoding support for LL_LENGTH_*
Luiz Augusto von Dentz [Tue, 26 Feb 2019 11:38:30 +0000 (13:38 +0200)]
monitor: Add decoding support for LL_LENGTH_*

This prints makes the fields to be printed instead of just decoding
the PDU name.

Change-Id: I827ee274dc83c747df247a6cc9b79a5bf7f17fdc
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agotest/example-advertisement: add shutdown code
Hunt, Preston [Mon, 24 Sep 2018 15:46:41 +0000 (15:46 +0000)]
test/example-advertisement: add shutdown code

The previous sample code did not release all resources when shutting
down. This is fine when it's a standalone program since Python will free
all resources automatically when the process terminates. However, in a
long-running process, this will eventually cause problems.

This changeset shows how to properly release all resources, if an optional
command line "--timeout" argument is used. The default is no timeout to
maintain behavior of the previous implementation (advertisements will run
forever).

Change-Id: Ica1bbbf1f9a78625e2a6d5f9ac5570609c5376e5
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Fix build with older version on libdbus
Luiz Augusto von Dentz [Tue, 26 Feb 2019 17:24:40 +0000 (19:24 +0200)]
client: Fix build with older version on libdbus

This fixes the following error when building with older version of
D-Bus:

client/gatt.c:2973: undefined reference to `dbus_message_iter_get_element_count'

Change-Id: Ie285fced42f67448a6a075f2e65a7726be10956c
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshell: Allow multiple prompt inputs
Luiz Augusto von Dentz [Fri, 22 Feb 2019 11:32:25 +0000 (13:32 +0200)]
shell: Allow multiple prompt inputs

This allow queueing input prompts so that the application don't have to
queue themselves.

Change-Id: I5316426ce3dd2e24ff24c30276ca0f538c6d48ee
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Print AdvertisingManager properties on command 'show'
Luiz Augusto von Dentz [Thu, 21 Feb 2019 12:05:57 +0000 (14:05 +0200)]
client: Print AdvertisingManager properties on command 'show'

This outputs the AdvertisingManager properties command 'show':

bluetoothctl> show
...
Advertising Features:
ActiveInstances: 0x00
SupportedInstances: 0x05
SupportedIncludes: tx-power
SupportedIncludes: appearance
SupportedIncludes: local-name

Change-Id: I351131b1041ba749a1ee8afdb209dd03891c11a8
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Add advertise.secondary command
Luiz Augusto von Dentz [Fri, 15 Feb 2019 14:19:59 +0000 (16:19 +0200)]
client: Add advertise.secondary command

This adds advertose.secondary command which can be used to set a
secondary channel to advertise.

Change-Id: I3bfeb3620583efbe77150617b659ef02b5375dd2
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoadvertising: Add implementation of SecondaryChannel
Luiz Augusto von Dentz [Fri, 15 Feb 2019 12:23:22 +0000 (14:23 +0200)]
advertising: Add implementation of SecondaryChannel

This add the parsing for SecondaryChannel which indicates what secondary
PHY shall be used.

Change-Id: I419f0bfa4d53c359c767e0493170d664f7493ef7
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoadvertising: Add implementation of SupportedSecondaryChannels
Luiz Augusto von Dentz [Fri, 15 Feb 2019 11:53:08 +0000 (13:53 +0200)]
advertising: Add implementation of SupportedSecondaryChannels

This implements SupportedSecondaryChannels property which expose what
the supported secondary channels.

Change-Id: I95c8ba8ecb2d8379d334bbe5532fc53b90ebdeae
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/advertising-api: Add support for setting Secondary Channel
Luiz Augusto von Dentz [Fri, 15 Feb 2019 09:15:28 +0000 (11:15 +0200)]
doc/advertising-api: Add support for setting Secondary Channel

This enables reading and setting the Secondary Channel/PHY supported
by the controller.

Change-Id: Id935400b376be31cefe18a9af93181b68d2e7ba3
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Fix LE Read Transmit Power Command deconding
Szymon Janc [Fri, 15 Feb 2019 12:58:28 +0000 (13:58 +0100)]
monitor: Fix LE Read Transmit Power Command deconding

Min and max TX power are signed intergers.

Change-Id: I09cedfce59a4519cce689ee4d69dd489fea01f74
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Fix uninitialized error
Luiz Augusto von Dentz [Wed, 13 Feb 2019 15:07:25 +0000 (17:07 +0200)]
client: Fix uninitialized error

trusted should be initialized with false since the property may not be
available.

Change-Id: Id1529b0821d3b7a466bab8c52c150dac0d2a3714
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Improve logging of GATT operations
Luiz Augusto von Dentz [Wed, 13 Feb 2019 15:05:21 +0000 (17:05 +0200)]
client: Improve logging of GATT operations

This prints the UUID along with attribute path and also print the
hexdump when payload is available.

Change-Id: If48e517894a93572f0e7a19a16fe58c85a3fbfb1
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Forward notifications from cloned attributes
Luiz Augusto von Dentz [Wed, 13 Feb 2019 14:25:05 +0000 (16:25 +0200)]
client: Forward notifications from cloned attributes

Notifications come in a form of 'Value' property changes thus this
copies the values to the local attribute so they are in sync.

Change-Id: I76b8d58a4518c8059eb84cd3d0cdfebc0fd7daa3
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Remove cloned services if the proxy is removed
Luiz Augusto von Dentz [Tue, 12 Feb 2019 11:38:46 +0000 (13:38 +0200)]
client: Remove cloned services if the proxy is removed

This unregister the cloned services if the proxy is removed since they
would no longer be accessible.

Change-Id: I657787c1f534cc2493e77a61f3f062dca20494ec
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Proxy calls to StartNotify/StopNotify
Luiz Augusto von Dentz [Tue, 12 Feb 2019 11:23:06 +0000 (13:23 +0200)]
client: Proxy calls to StartNotify/StopNotify

This uses the proxies created by clone command to forward the
subscriptions to the cloned services.

Change-Id: I04ba4be9b9e6208afe2ea1cbcff7642e2fa3c053
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Proxy calls to ReadValue and WriteValue
Luiz Augusto von Dentz [Tue, 12 Feb 2019 10:00:08 +0000 (12:00 +0200)]
client: Proxy calls to ReadValue and WriteValue

This uses the proxies created by clone command to forward the requests
to the cloned services.

Change-Id: Icd16e294a5811f8ea7ba71622d3ee2079708213b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Add gatt.clone command
Luiz Augusto von Dentz [Mon, 11 Feb 2019 16:36:27 +0000 (18:36 +0200)]
client: Add gatt.clone command

This adds clone command to gatt submenu which can be use to clone
services as follow:

Clone all services from the connected device:
> gatt.clone

Clone a given service
> gatt.select-attribute <attribute/uuid>
> gatt.clone

In either case there is a prompt to confirm since this may add a lot of
service the user must confim before proceding.

Then finally:

> gatt.register-application

Change-Id: Ia3298b1f1a52c04b0dad34a7b794c9f177c8978d
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Fix not allowing 'extended-properties' as flags
Luiz Augusto von Dentz [Mon, 11 Feb 2019 16:33:58 +0000 (18:33 +0200)]
gatt: Fix not allowing 'extended-properties' as flags

Allows 'extended-propeties' as flags.

Change-Id: I6b8c9952dd97fd0392acefe7ba687b3f07f0abf7
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-db: Fix crash if next_handle is 0
Luiz Augusto von Dentz [Tue, 12 Feb 2019 14:38:58 +0000 (16:38 +0200)]
shared/gatt-db: Fix crash if next_handle is 0

If the database is reseted all the services shall be ignored and no
hash shall be generated.

Change-Id: I4e396dd0c5e0e9823f307115cbdebd21bb5b88ad
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodevice: Store Database Hash on storage
Luiz Augusto von Dentz [Mon, 12 Mar 2018 13:30:37 +0000 (15:30 +0200)]
device: Store Database Hash on storage

This stores the hash on the storage so it can be reloaded when the
daemon/system restarts.

Change-Id: Ie8d397ab41ceb60b143998a0a516b392088d5e62
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-client: Write Client Features
Luiz Augusto von Dentz [Tue, 6 Mar 2018 12:11:14 +0000 (14:11 +0200)]
shared/gatt-client: Write Client Features

This writes the supported client features setting Robust Caching bit.

Change-Id: I13dec10d7b2888fb4d8d0774d12a06ee1f026522
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-client: Read database hash if available
Luiz Augusto von Dentz [Tue, 6 Mar 2018 08:29:25 +0000 (10:29 +0200)]
shared/gatt-client: Read database hash if available

This reads the database hash if available and compares to the existing
value, if it matches consider the discovery is completed.

Change-Id: I5dabc14550049afe4bc1e4c6ab790cd2d25e57e2
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Implement Robust Caching handling for server
Luiz Augusto von Dentz [Fri, 2 Mar 2018 12:27:48 +0000 (14:27 +0200)]
gatt: Implement Robust Caching handling for server

This detects when a client becomes change-unware returning
DB Out of Sync error when that happens.

Change-Id: I0377d966ac00fbb5e17b0f2b74c660ca72d71c83
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-server: Add bt_gatt_server_set_authorize
Luiz Augusto von Dentz [Wed, 25 Apr 2018 12:06:47 +0000 (15:06 +0300)]
shared/gatt-server: Add bt_gatt_server_set_authorize

bt_gatt_server_set_authorize can be used to set the callback to
authorize attribute operations which is required in order to send
out of sync error as that has to happen even in case the handle is
not valid.

Change-Id: I884c18492254b8401966a83b448e965b3f244bd6
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-db: Add gatt_db_set_authorize
Luiz Augusto von Dentz [Fri, 2 Mar 2018 08:05:04 +0000 (10:05 +0200)]
shared/gatt-db: Add gatt_db_set_authorize

gatt_db_set_authorize can be used to set the callback to authorize
attribute operations.

Change-Id: Ibf79fc30ce75cff20c235371507c05ad02739105
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Add caching support for server
Luiz Augusto von Dentz [Thu, 1 Mar 2018 15:43:22 +0000 (17:43 +0200)]
gatt: Add caching support for server

This registers both Client Features and Database Hash Characteristics
which are mandatory for the server.

Change-Id: Ic4d808830fbc54852e77fc7a741fbf9e9d61e44b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-db: Generate database hash
Luiz Augusto von Dentz [Mon, 5 Mar 2018 09:33:48 +0000 (11:33 +0200)]
shared/gatt-db: Generate database hash

This use bt_crypto_hash (AES-CMAC) to generate a database hash
using the content of the attribute:

In ascending order of attribute handles, starting with the first handle,
concatenate the fields Attribute Handle, Attribute Type, and Attribute
Value if the attribute has one of the following types:
«Primary Service», «Secondary Service», «Included Service»,
«Characteristic», or «Characteristic Extended Properties», concatenate
the fields Attribute Handle and Attribute Type if the attribute has one
of the following types: «Characteristic User Description»,
«Client Characteristic Configuration»,
«Server Characteristic Configuration», «Characteristic Format», or
«Characteristic Aggregate Format», and ignore the attribute if it has
any other type (such attributes are not part of the concatenation).

Change-Id: If27ed2e2a6bfbf2549492061c928cf64afbaf10e
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-db: Introduce Database Hash
Luiz Augusto von Dentz [Thu, 1 Mar 2018 15:41:05 +0000 (17:41 +0200)]
shared/gatt-db: Introduce Database Hash

This introduces a database hash which is generate whenever the database
changes.

Change-Id: I901800b64b7811527b7b978498ac8f0ceebe7403
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Decode GATT Caching errors
Luiz Augusto von Dentz [Tue, 6 Mar 2018 15:56:13 +0000 (17:56 +0200)]
monitor: Decode GATT Caching errors

This enables decoding of Database Out of Sync and Value Not Allowed
ATT errors introduced with GATT Caching improvements.

Change-Id: Ia130b26716745691b3cf72e81d2b9aac643657b5
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/att-types: Add errors introduced by GATT caching
Luiz Augusto von Dentz [Thu, 1 Mar 2018 15:39:21 +0000 (17:39 +0200)]
shared/att-types: Add errors introduced by GATT caching

This adds Database Out of Sync and Value Not Allowed errors.

Change-Id: Icfc819ee46fc159e665c2e4becfef6d779da66a7
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/util: Add decoding support for GATT caching attributes
Luiz Augusto von Dentz [Tue, 6 Mar 2018 14:58:14 +0000 (16:58 +0200)]
shared/util: Add decoding support for GATT caching attributes

This adds support to decode Client Supported Features and Database
Hash.

Change-Id: I1b7bbff5a4882d478158f5545d89783d09831b83
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agolib/uuid: Introduce definition for GATT caching attributes
Luiz Augusto von Dentz [Thu, 1 Mar 2018 15:36:47 +0000 (17:36 +0200)]
lib/uuid: Introduce definition for GATT caching attributes

This introduces UUIDs for Client Features and Database Hash
characteristics.

Change-Id: I17fb8fd9db5309bec713b72a3ac9caee14f04974
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agounit/test-crypto: Add test for bt_crypto_gatt_hash
Luiz Augusto von Dentz [Mon, 5 Mar 2018 14:36:55 +0000 (16:36 +0200)]
unit/test-crypto: Add test for bt_crypto_gatt_hash

This adds test case base on the example given in the spec.

Change-Id: Ibc713afd03926375087c248a4fe9882784ea95a7
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/crypto: Add bt_crypto_gatt_hash
Luiz Augusto von Dentz [Mon, 5 Mar 2018 09:30:43 +0000 (11:30 +0200)]
shared/crypto: Add bt_crypto_gatt_hash

The bt_crypto_gatt_hash uses AES-CCM to create a hash with the contents
stored in the iovec.

Note: The spec disregards the byte order so both the key, msg and res
are not swapped.

Change-Id: Ifaa2b5ce256c17344b6a78b5f056ad5b1d63e1d7
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Don't expose pointer value in attribute path
Luiz Augusto von Dentz [Wed, 30 Jan 2019 13:24:18 +0000 (15:24 +0200)]
client: Don't expose pointer value in attribute path

Instead use the position in the list to create a unique path:

[bluetooth]# register-service 0x1820
[NEW] Primary Service (Handle 0x0000)
/org/bluez/app/service0
0x1820
Internet Protocol Support

Change-Id: I79485003fd2b645ff5e8698c98f52ba4ae9ce8cd
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Enable list-attributes to print local attributes
Luiz Augusto von Dentz [Tue, 29 Jan 2019 14:20:41 +0000 (16:20 +0200)]
client: Enable list-attributes to print local attributes

This enable passing "local" to list-attributes to print the attributes
registered locally:

> list-attributes local
Primary Service (Handle 0x0400)
/org/bluez/app/service0x74ccb0
0x1820
Internet Protocol Support

Change-Id: I13a383687c6c653097917093388f1ec41ce656f4
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Enable setting attribute handles
Luiz Augusto von Dentz [Mon, 28 Jan 2019 18:52:23 +0000 (20:52 +0200)]
client: Enable setting attribute handles

This emulates application setting their attribute handles.

Change-Id: Ia5e84fbc3ed591856680fb025238b12f451f1e7c
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoclient: Enable Handle property for GATT attributes
Luiz Augusto von Dentz [Mon, 28 Jan 2019 15:21:27 +0000 (17:21 +0200)]
client: Enable Handle property for GATT attributes

This enable bluetoothd to write back the actual value of attribute
handles.

Change-Id: I6ac327f90c2be775fa72fd95cc200a638b950358
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Write back the handle to Handle property
Luiz Augusto von Dentz [Mon, 28 Jan 2019 15:19:13 +0000 (17:19 +0200)]
gatt: Write back the handle to Handle property

If the application has set an attribute with Handle set to 0 inform the
allocated handle by writting the Handle property.

Change-Id: Ia1e9d3bcc55d1f7a476560c0d8bb712cdaf45194
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Implement Handle property
Luiz Augusto von Dentz [Mon, 28 Jan 2019 14:39:51 +0000 (16:39 +0200)]
gatt: Implement Handle property

This parses the Handle property and if it exists attempt to insert
attributes in their locations.

Change-Id: I90f34b5dae5415a4243a643d0ab034c964fd8c6b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/gatt-db: Allow passing 0 as handle to gatt_db_insert_*
Luiz Augusto von Dentz [Mon, 28 Jan 2019 14:38:17 +0000 (16:38 +0200)]
shared/gatt-db: Allow passing 0 as handle to gatt_db_insert_*

Handle 0 should be allocate on the next handle just as any of
gatt_db_add_* functions.

Change-Id: I5d16794c2db66203c2ccae0893ce42505f33f62f
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/gatt-api: Add Handle property
Luiz Augusto von Dentz [Fri, 25 Jan 2019 14:32:48 +0000 (16:32 +0200)]
doc/gatt-api: Add Handle property

When acting as server it is useful to select where to allocate the
handle for an attribute so it can be restored in the same position when
restarting the daemon or rebooting the system.

In order to do that the application also needs to know in which handle
the attribute is allocated the very first time it is registered, this
also allows for a better integration with PTS and tools like auto-pts
which needs to know the handles where the attributes have been
allocated.

Change-Id: I298c07b8e6e6cb1bc163412b5c7acaed9a64b004
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Fix SBC_MAX_BITPOOL and add SBC quality modes
Pali Rohár [Tue, 29 Jan 2019 17:12:07 +0000 (18:12 +0100)]
a2dp-codecs: Fix SBC_MAX_BITPOOL and add SBC quality modes

According to A2DP specification; section SBC; Codec Specific Information
Elements; Minimum / Maximum Bitpool Value, range for Bitpool value is from
2 to 250.

A2DP specification also defines bitpool values for two SBC modes: Middle
Quality and High Quality. They depends on channel mode and frequency. So
add definitions for them into a2dp-codecs file too.

File android/hal-audio-sbc.c was updated to use High Quality mode for
chosen frequency.

Change-Id: I77cfd4c13314abf223e64cec5bab98f1d42b92a6
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavinfo: Fix parsing capabilities
Pali Rohár [Sat, 26 Jan 2019 10:24:15 +0000 (11:24 +0100)]
avinfo: Fix parsing capabilities

Function print_caps() expects capabilities buffer without AVDTP header.
Previously avinfo somehow worked, because AVDTP header looks like
capability header with unknown category which was skipped.

Change-Id: Ieaf08b3cd128893d29b11d92f13f0d301059a26e
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavinfo: Dump unknown codecs and unknown categories
Pali Rohár [Sat, 26 Jan 2019 10:24:50 +0000 (11:24 +0100)]
avinfo: Dump unknown codecs and unknown categories

Change-Id: Id80736771383aa6e33d66d52009c7bbc562b09ee
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs & avinfo: Simplify defintions and parsing of aptX family
Pali Rohár [Sat, 26 Jan 2019 10:46:06 +0000 (11:46 +0100)]
a2dp-codecs & avinfo: Simplify defintions and parsing of aptX family

Reuse whole a2dp_aptx_t structure and defines as they are same for aptX Low
Latency and aptX HD.

Change-Id: Ibeebd93c7c795f86ba07a8b2ce6df056c4c5c1a0
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agolib: Add version number for Bluetooth 5.1
Johan Hedberg [Tue, 29 Jan 2019 15:33:15 +0000 (17:33 +0200)]
lib: Add version number for Bluetooth 5.1

Change-Id: If48f1b76a41c2891b49acecc7f2bdede93b0204f
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Add Bluetooth 5.1 features and version information
Johan Hedberg [Tue, 29 Jan 2019 15:32:45 +0000 (17:32 +0200)]
monitor: Add Bluetooth 5.1 features and version information

Change-Id: I150d8cdf1780f4b06e91f2f567717d15328435a9
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor: Reformat LE features table
Johan Hedberg [Tue, 29 Jan 2019 15:31:34 +0000 (17:31 +0200)]
monitor: Reformat LE features table

Bluetooth 5.1 has many features with long names, so reformat the table
before adding any new ones.

Change-Id: Id13571a5807d86c5c83b92501f69746e4495959b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp: Add reverse discovery
Luiz Augusto von Dentz [Tue, 22 Jan 2019 13:28:12 +0000 (15:28 +0200)]
a2dp: Add reverse discovery

Now that remote endpoints are exposed there is a chance that a
configured device will reconnect and initiate SetConfiguration skipping
the discovery phase which is now required in order to be able to switch
endpoints, so this introduces the reverse discovery logic in order to
find out about remote endpoints capabilities if they have not been
found yet.

Change-Id: Ib92837aca13a17ccc1b37e363d157f0cdb6e13bc
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp: Add implementation of MediaEndpoint.Device
Luiz Augusto von Dentz [Tue, 15 Jan 2019 14:07:13 +0000 (11:07 -0300)]
a2dp: Add implementation of MediaEndpoint.Device

This adds the implementation of MediaEndpoint.Device property so the
clints don't need to guess what device the endpoint belongs.

Change-Id: I29a24302fced1922df417735b8b07d3fd92bc590
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/media-api: Add Device property to MediaEndpoint
Luiz Augusto von Dentz [Tue, 15 Jan 2019 14:06:04 +0000 (11:06 -0300)]
doc/media-api: Add Device property to MediaEndpoint

This adds Device property which indicates which device the endpoint
belongs to.

Change-Id: Ic93c2478aae90e856480cd6dc51df0d4e46706c8
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp: Cache remote endpoints
Luiz Augusto von Dentz [Tue, 8 Jan 2019 13:34:42 +0000 (10:34 -0300)]
a2dp: Cache remote endpoints

In order to always have the Endpoint interface available the remote
endpoints needs to be cached since the remote stack may config a stream
on its own there may not be a chance to discover the endpoits available
which would make it impossible to switch endpoints.

Change-Id: I2d82cc4dd30c919428c6f21b0148710a3f458689
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/settings-storage: Add Endpoint group to cache
Luiz Augusto von Dentz [Tue, 8 Jan 2019 13:56:13 +0000 (10:56 -0300)]
doc/settings-storage: Add Endpoint group to cache

This documents how A2DP endpoints should be stored in the cache.

Change-Id: Id84cd397f7b065cb25a308606bfe0cf75261dc4f
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp: Implement MediaTransport.Endpoint
Luiz Augusto von Dentz [Fri, 4 Jan 2019 19:24:18 +0000 (16:24 -0300)]
a2dp: Implement MediaTransport.Endpoint

This implements MediaTransport.Endpoint property which exposes what
endpoint is being used by the transport.

Change-Id: I423a774f8b5bd57f34ac206f65f81b7cfa1a6806
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/media-api: Add Endpoint property to MediaTransport
Luiz Augusto von Dentz [Fri, 4 Jan 2019 19:22:05 +0000 (16:22 -0300)]
doc/media-api: Add Endpoint property to MediaTransport

Adds endpoint object to MediaTransport so application can resolve which
MediaEndpoint is in use.

Change-Id: I46106a3c0fa474409a04d29cf8eb9e8f3aff9a3f
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp: Expose remote SEP
Luiz Augusto von Dentz [Thu, 3 Jan 2019 16:45:43 +0000 (13:45 -0300)]
a2dp: Expose remote SEP

This implements MediaEndpoint for remote SEP which can be used by
clients to switch configuration on demand.

Change-Id: I52edc5217fd404757fd2162f9c0b7dfa65379bfb
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agodoc/media-api: Enable MediaEndpoint to expose remote SEP
Luiz Augusto von Dentz [Thu, 3 Jan 2019 15:30:34 +0000 (12:30 -0300)]
doc/media-api: Enable MediaEndpoint to expose remote SEP

This adds the possibility to expose remote SEP using MediaEndpoint
interface to allow setting a configuration.

Change-Id: I627aee5cc4b3391c0f54fe39fe46aa0158132717
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agomonitor/avctp: Fix parsing of GetFolderItems attributes
Luiz Augusto von Dentz [Tue, 22 Jan 2019 12:29:54 +0000 (14:29 +0200)]
monitor/avctp: Fix parsing of GetFolderItems attributes

Attributes in GetFolderItems are 32 bytes long not 16.

Change-Id: I5d18af080373e5bf51fea6a8f935530e8c32e818
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavdtp: Fix always destroying session immediatelly
Luiz Augusto von Dentz [Mon, 21 Jan 2019 11:29:09 +0000 (13:29 +0200)]
avdtp: Fix always destroying session immediatelly

In case the remote device sent a close/abort the session shall not be
free immediatelly as the remote may want to reconfigure the stream.

Change-Id: I7934f4a837c910ee80df64f24face6980dc476ad
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agobtmon: Fix parsing A2DP FastStream codec configuration
Pali Rohár [Sun, 13 Jan 2019 17:23:20 +0000 (18:23 +0100)]
btmon: Fix parsing A2DP FastStream codec configuration

This codec is bi-directional, therefore both sink and source directions may
be present in configuration at same time.

Some Creative headsets send more frequency bits in configuration and when
both 41kHz and 48kHz are present then headset expects 48kHz. So adjust
FastStream frequency table as find_value_bit() takes first matched bit.

Change-Id: I06430869dfb766a0099d916f2447b90196d586f3
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agounit: Fix fsanitize-address-use-after-scope with GCC 9
Luiz Augusto von Dentz [Fri, 11 Jan 2019 13:16:17 +0000 (10:16 -0300)]
unit: Fix fsanitize-address-use-after-scope with GCC 9

Raw data payload must be copied since the declaration goes out of
scope:

Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=202213

Change-Id: I33aa4edf5f2cac3f8d0a7995027be36d10ff8464
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agounit/test-sdp: Avoid extra copies when sending a PDU
Luiz Augusto von Dentz [Fri, 11 Jan 2019 13:14:50 +0000 (10:14 -0300)]
unit/test-sdp: Avoid extra copies when sending a PDU

Make use of writev instead of creating a separate buffer to transmit
the data.

Change-Id: I3d86b09dce12c3e5438ada46b9d77a7b94125ee5
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/shell: Fix compilation error
Luiz Augusto von Dentz [Wed, 9 Jan 2019 15:42:47 +0000 (12:42 -0300)]
shared/shell: Fix compilation error

asprintf return is not check which is catch by -Werror=unused-result
so in case asprintf fails don't set any prompt.

Change-Id: I8c0e3ea9151f8fb115246bde62a1850b43e7fecf
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agobtmon: Parse new A2DP codecs
Pali Rohár [Sun, 23 Dec 2018 10:00:43 +0000 (11:00 +0100)]
btmon: Parse new A2DP codecs

Parse information about additional A2DP codecs: FastStream, aptX Low
Latency and aptX HD.

Change-Id: I5340eaa580539704e8658f0e9000d8667a19a608
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavinfo: Parse new A2DP codecs
Pali Rohár [Sun, 23 Dec 2018 10:40:21 +0000 (11:40 +0100)]
avinfo: Parse new A2DP codecs

Parse information about additional A2DP codecs: FastStream, aptX Low
Latency, aptX HD and LDAC.

Change-Id: I90d5b74cd90660500783097ba510bbad69ac8ba6
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Add macros and structures for new codecs
Pali Rohár [Sun, 23 Dec 2018 10:40:20 +0000 (11:40 +0100)]
a2dp-codecs: Add macros and structures for new codecs

Add additional codecs: FastStream, aptX Low Latency and aptX HD codecs.

Change-Id: I069747942b12e5eeb3ffd17818117a44ad5c373a
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Properly define macros and struct for LDAC codec
Pali Rohár [Sun, 23 Dec 2018 10:40:19 +0000 (11:40 +0100)]
a2dp-codecs: Properly define macros and struct for LDAC codec

Change-Id: I92f334de26bde0e7fdb470c2c8ec659c1961ee4f
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Add needed includes and properly check for endian macros
Pali Rohár [Sun, 23 Dec 2018 10:40:18 +0000 (11:40 +0100)]
a2dp-codecs: Add needed includes and properly check for endian macros

Without stdint.h type uint8_t cannot be used.

And without endian.h macros __BYTE_ORDER, __LITTLE_ENDIAN and __BIG_ENDIAN
are not defined.

When both __BYTE_ORDER and __LITTLE_ENDIAN macros are not defined, then
condition #if __BYTE_ORDER == __LITTLE_ENDIAN is true.

Change-Id: I8e583cbf8c2f05cb5c2980301d383904b3e42020
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral way
Pali Rohár [Sun, 23 Dec 2018 10:40:17 +0000 (11:40 +0100)]
a2dp-codecs: Define a2dp_vendor_codec_t struct in endian neutral way

And define new macros A2DP_GET_VENDOR_ID(), A2DP_GET_CODEC_ID() and
A2DP_SET_VENDOR_ID_CODEC_ID() for easily filling a2dp_vendor_codec_t
struct.

Change-Id: Ia517e52fce660b3e5f073a3009e460da0ca7a15a
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs & avinfo: Fix parsing MPEG bit rate values
Pali Rohár [Sun, 23 Dec 2018 10:40:16 +0000 (11:40 +0100)]
a2dp-codecs & avinfo: Fix parsing MPEG bit rate values

Redefine bitrate field in a2dp_mpeg_t struct in endian neutral way and
separate vbr field according to A2DP specification. Define new macros
MPEG_GET_BITRATE() and MPEG_SET_BITRATE() for manipulating with bitrate
like for a2dp_aac_t struct.

And fix meaning of bitrate field. According to A2DP specification, it is
bitrate index, not bitrate itself. According to MPEG specification, each
MPEG layer have different bitrates for bitrate indexes. Therefore define
correctly bitrates for Layers 1, 2 and 3.

This fixes problems with parsing bitrate field in a2dp_mpeg_t struct as it
was broken due to endianity and it was broken for Layer 1 and 2 as bitrate
definitions was for Layer 3.

Change-Id: Ied2e860f5c54ccd6bbef7770959f5ac553022a56
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Fix codec id for ATRAC
Pali Rohár [Sun, 23 Dec 2018 10:40:15 +0000 (11:40 +0100)]
a2dp-codecs: Fix codec id for ATRAC

According to Bluetooth Assigned Numbers for Audio/Video ATRAC has codec id 0x04.
See: https://www.bluetooth.com/specifications/assigned-numbers/audio-video

Change-Id: Ia45a0ec8a415f73f6180d3b684ee39c0c70a5e57
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoa2dp-codecs: Add SBC prefix for MIN/MAX_BITPOOL constants
Pali Rohár [Sun, 23 Dec 2018 10:40:14 +0000 (11:40 +0100)]
a2dp-codecs: Add SBC prefix for MIN/MAX_BITPOOL constants

Those two constants are SBC codec specific.

Change-Id: I184ab28fcc4566d02449ed07ac68c3e26d4c41cf
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavinfo: Show Vendor Specific Data
Pali Rohár [Sun, 23 Dec 2018 10:40:13 +0000 (11:40 +0100)]
avinfo: Show Vendor Specific Data

Change-Id: I6ac47da5f045b7214531192d5e58c82ddb3eb9b8
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavinfo: Fix buffer overflow when parsing broken/malicious data
Pali Rohár [Sun, 23 Dec 2018 10:40:12 +0000 (11:40 +0100)]
avinfo: Fix buffer overflow when parsing broken/malicious data

Check size of buffer prior casting it to struct.

Change-Id: I8a3ee8d8bf2dfef7b37a7075f2062804268de639
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agounit/test-gdbus-client: Fix using invalid interface name
Luiz Augusto von Dentz [Tue, 18 Dec 2018 15:01:05 +0000 (12:01 -0300)]
unit/test-gdbus-client: Fix using invalid interface name

Each element must only contain the ASCII characters "[A-Z][a-z][0-9]_"
and must not begin with a digit so '-' cannot be used.

Change-Id: I176162c288973b9db672bbb9c5eacd896dd94b41
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogdbus: Split validation of object path and interface
Luiz Augusto von Dentz [Tue, 18 Dec 2018 15:02:22 +0000 (12:02 -0300)]
gdbus: Split validation of object path and interface

This splits the validation of object and interface so and error is
properly printed for each of those.

Change-Id: Ic936f70c7b94b9ec51c047d10d90628c66893cde
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogdbus: Make sure the object path and interface are valid
Luiz Augusto von Dentz [Wed, 5 Dec 2018 23:57:51 +0000 (20:57 -0300)]
gdbus: Make sure the object path and interface are valid

D-Bus object path and interface must be validate otherwise it can cause
errors as follow:

0  0xb7f67ab1 in __kernel_vsyscall ()
1  0xb7ca1cc1 in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
2  0xb7ca50ee in abort () at abort.c:92
3  0xb7e30ba5 in _dbus_abort () at dbus-sysdeps.c:94
4  0xb7e267a6 in _dbus_warn_check_failed (
    format=0xb7e36cd4 "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:290
5  0xb7e16d9f in dbus_message_iter_append_basic (iter=0xbf864400, type=111,
    value=0xd70940) at dbus-message.c:2586
6  0x004fcdec in emit_interfaces_added (user_data=0xd70938)
    at gdbus/object.c:574

Change-Id: I84ad3ffe13e16d6275fb5f9df4013a4804ad2aaf
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoavrcp: Fix error creating media items
Luiz Augusto von Dentz [Wed, 5 Dec 2018 12:17:02 +0000 (09:17 -0300)]
avrcp: Fix error creating media items

Don't use item name in the object path since it would need to be
properly escaped if the remote stack uses UID 0 even though it is
invalid to have 0 as UID:

AVRCP 1.6.1, page 84:

  'The value of UID=0x0 is a special value used only to request
   the metadata for the currently playing media using the
   GetElementAttributes command and shall not be used for any item
   in a folder.'

Change-Id: Id31a0ed0ebab207b5552466a051f1b9161d7b76b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agogatt: Register GATT and GAP services as SDP records
Luiz Augusto von Dentz [Tue, 4 Dec 2018 19:17:57 +0000 (16:17 -0300)]
gatt: Register GATT and GAP services as SDP records

This ensures that GATT and GAP services can be discover over SDP as well
as over GATT.

Change-Id: Ibf4ac7da55ba8eb63d5e5eacf0b8ded6ae4f1aa5
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/tester: Make use of mainloop_run_with_signal
Luiz Augusto von Dentz [Wed, 28 Nov 2018 14:54:40 +0000 (16:54 +0200)]
shared/tester: Make use of mainloop_run_with_signal

This don't require setting up signalfd.

Change-Id: I2bc0b624e5768fc64085438054e3679cf8cbbe9b
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agocore: Make use of mainloop_run_with_signal
Luiz Augusto von Dentz [Wed, 28 Nov 2018 14:27:38 +0000 (16:27 +0200)]
core: Make use of mainloop_run_with_signal

This don't require setting up signalfd.

Change-Id: I662835f2fb18e3d30aca89dc2150b977a46db939
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/mainloop: Remove mainloop_set_signal
Luiz Augusto von Dentz [Wed, 28 Nov 2018 14:01:40 +0000 (16:01 +0200)]
shared/mainloop: Remove mainloop_set_signal

This removes mainloop_set_signal and replaces it usage with
mainloop_run_with_signal.

Change-Id: I7354a76436348520ee814c513294fdfe80a33c41
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/mainloop: Add mainloop_run_with_signal
Luiz Augusto von Dentz [Wed, 28 Nov 2018 13:41:35 +0000 (15:41 +0200)]
shared/mainloop: Add mainloop_run_with_signal

This consolidates the handling of signalfd in similar ways as ELL does.

Change-Id: Iaf082f7534a7444a7b3fc29ed5a6423f666f3f86
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshared/timeout-glib: Check 0 id when removing timeout
Luiz Augusto von Dentz [Mon, 26 Nov 2018 16:01:47 +0000 (18:01 +0200)]
shared/timeout-glib: Check 0 id when removing timeout

If the id is 0 that makes it is invalid already.

Change-Id: Icd116c07be4db784ee8cd0be66560b14a74bc069
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agocore: Use mainloop_sd_notify instead of sd_notify
Luiz Augusto von Dentz [Mon, 26 Nov 2018 15:48:50 +0000 (17:48 +0200)]
core: Use mainloop_sd_notify instead of sd_notify

mainloop_sd_notify takes care of sending the messages to NOTIFY_SOCKET
and includes the handling of WATCHDOG_USEC as well.

Change-Id: Ibaf2e3af9cd0d492cd10576f671e16d54dcca287
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agotool/btmon-logger: Use mainloop_notify instead of sd_notify
Luiz Augusto von Dentz [Mon, 26 Nov 2018 14:23:37 +0000 (16:23 +0200)]
tool/btmon-logger: Use mainloop_notify instead of sd_notify

mainloop_notify takes care of sending the messages to NOTIFY_SOCKET and
includes the handling of WATCHDOG_USEC as well.

Change-Id: Iea22016e179e2714e94ac89dfa8c06d21573c277
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshare/mainloop: Add watchdog support
Luiz Augusto von Dentz [Mon, 26 Nov 2018 14:16:15 +0000 (16:16 +0200)]
share/mainloop: Add watchdog support

This adds watchdog notification support by sending "WATCHDOG=1" twice
as frequent as required by WATCHDOG_USEC.

Change-Id: I713883290a03961276d8f981818abbc922018bd0
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agoshare/mainloop: Add handling of NOTIFY_SOCKET
Luiz Augusto von Dentz [Mon, 26 Nov 2018 13:54:00 +0000 (15:54 +0200)]
share/mainloop: Add handling of NOTIFY_SOCKET

This adds handling of systemd NOTIFY_SOCKET so application using
mainloop instance do properly notify systemd what is their state.

Change-Id: Ie58d7641eb76c8e77482ad78e86ed0ecac0e0ae5
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agotools/btpclient: Fix compile warning with strncpy
Tedd Ho-Jeong An [Thu, 29 Nov 2018 23:24:26 +0000 (15:24 -0800)]
tools/btpclient: Fix compile warning with strncpy

This patch fixes the boundry warning-to-error in GCC 8.1.1 with strncpy.

Change-Id: I606199afaa5de1dc56f043160b1f6a53f3092b81
Signed-off-by: himanshu <h.himanshu@samsung.com>
4 years agotools: Use l_main_run_with_signal instead of open coding it
Marcel Holtmann [Mon, 3 Dec 2018 18:48:08 +0000 (19:48 +0100)]
tools: Use l_main_run_with_signal instead of open coding it

Change-Id: Idca5ab5133fad95a9480c0216ad377c777d96f61
Signed-off-by: himanshu <h.himanshu@samsung.com>