Chris Ross [Fri, 19 Apr 2019 05:27:38 +0000 (22:27 -0700)]
Implement server-side of NegotiateStream on Unix (dotnet/corefx#36827)
Commit migrated from https://github.com/dotnet/corefx/commit/
0a9a366e290aded3e9bf5d082d6beee5ff560177
Tomas Weinfurt [Fri, 19 Apr 2019 04:15:37 +0000 (21:15 -0700)]
add test for connection timeouts (dotnet/corefx#36990)
* add test for connection timeouts
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
2a6ee34edd98c1746c11c9354bef12654822f5ee
Ponant [Fri, 19 Apr 2019 04:14:10 +0000 (06:14 +0200)]
Performance improvements in EmailAddressAttribute (dotnet/corefx#36994)
* performance improvements by a factor of 2 to 10
I get a perf improvement by using IndexOf which ranges from a a factor of two for an email address having 20 char to nearly 10 for 60 char.
* Update src/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/EmailAddressAttribute.cs
force explicit type
* Simplify code
Commit migrated from https://github.com/dotnet/corefx/commit/
556e080cce3bbd075f7199286b33842f5c0a0c61
Sung Yoon Whang [Fri, 19 Apr 2019 01:04:39 +0000 (18:04 -0700)]
Add missing method
Commit migrated from https://github.com/dotnet/corefx/commit/
c150a145990a662258e685ea204a8e83a7333111
Sung Yoon Whang [Fri, 19 Apr 2019 00:56:07 +0000 (17:56 -0700)]
I'm stupid
Commit migrated from https://github.com/dotnet/corefx/commit/
d64827a410909d18d90c0fa2b25c52f65ce59e2c
Sung Yoon Whang [Fri, 19 Apr 2019 00:49:51 +0000 (17:49 -0700)]
splitting implementation of EventCounter to non-uap/uap
Commit migrated from https://github.com/dotnet/corefx/commit/
2d1e2ff48e61a70ef990f48e677f6237b044fe52
Sung Yoon Whang [Thu, 18 Apr 2019 23:39:08 +0000 (16:39 -0700)]
try to exclude new counters for uap
Commit migrated from https://github.com/dotnet/corefx/commit/
c29c7b4a5630b896bbbb73f18f0de2dea9e0d123
Sung Yoon Whang [Thu, 18 Apr 2019 22:50:48 +0000 (15:50 -0700)]
disable exposing new counter types on ProjectN until they are propagated through the targetingpack
Commit migrated from https://github.com/dotnet/corefx/commit/
33724212beccbdca43d020f595dce88e38eaab31
Sung Yoon Whang [Thu, 18 Apr 2019 06:33:42 +0000 (23:33 -0700)]
some type annotation stuff
Commit migrated from https://github.com/dotnet/corefx/commit/
c478c7c2d86b31917e6bd8dd62c66d8f00cac10a
Sung Yoon Whang [Thu, 18 Apr 2019 06:32:41 +0000 (23:32 -0700)]
remove extra nl
Commit migrated from https://github.com/dotnet/corefx/commit/
0955fc31dfd9fca8b200aa5f1c59a453c01ca0ef
Sung Yoon Whang [Thu, 18 Apr 2019 06:16:47 +0000 (23:16 -0700)]
Exposing the new counter APIs in System.Diagnostics.Tracing
Commit migrated from https://github.com/dotnet/corefx/commit/
c042b3aa7de95332624f3d725e8abdb4d3d043f5
Jose Perez Rodriguez [Thu, 18 Apr 2019 23:21:48 +0000 (16:21 -0700)]
Fix Json Source package not includding ArrayBufferWriter (dotnet/corefx#37009)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1b0a40964253b1bc48dd3be734eb2e1cf716db3
Charles Stoner [Thu, 18 Apr 2019 21:23:40 +0000 (14:23 -0700)]
Port StringType (dotnet/corefx#36951)
Commit migrated from https://github.com/dotnet/corefx/commit/
d69b4f7864a76a375d4178b1afa8c9e97ee549b8
buyaa-n [Thu, 18 Apr 2019 19:46:20 +0000 (12:46 -0700)]
Hashcode calculation update (dotnet/corefx#37002)
Seems packaging failure is not related, merging, thank you all for feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e816593d49d87ec2a5815e34b82c5c8ba86aa85f
Tomas Weinfurt [Thu, 18 Apr 2019 19:10:31 +0000 (12:10 -0700)]
allow Http2 loopback test be unencrypted (dotnet/corefx#36968)
* fix tests with http/2
* make SSL on Loopback server configurable via environment
* update variable names
Commit migrated from https://github.com/dotnet/corefx/commit/
95987e3e3aa95b2ae6386b17271a172d20fe50cc
David Fowler [Thu, 18 Apr 2019 17:32:55 +0000 (10:32 -0700)]
Handle concurrent dispose and WriteAsync calls (dotnet/corefx#36988)
- lock the entire Write operation
- Added a test that Completes both reader and writer in the middle of writing a large buffer
Commit migrated from https://github.com/dotnet/corefx/commit/
90d98b9abb87743c2340506a7823e452c757767c
Tomas Weinfurt [Thu, 18 Apr 2019 12:42:24 +0000 (05:42 -0700)]
handle bad Expires better (dotnet/corefx#36908)
* handle bad Expires better
* update tests
* internal -> private
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
82eedbff6b767c0bd9297d3dd27c89d925a28e93
Ahson Khan [Thu, 18 Apr 2019 06:57:50 +0000 (23:57 -0700)]
Re-design Utf8JsonWriter as a regular class rather than a ref struct. (dotnet/corefx#36961)
* Add an in-box array-backed IBufferWriter<T>
* Update Utf8JsonWriter ref and main writer file.
* Fix JsonWriter WriteValue APIs.
* Use Environment.NewLine static and invert some stream conditions.
* Update JsonWriter properties and fix serializer build breaks.
* Update JsonWriter unit tests.
* Add xml comments, clean up, and improve test coverage.
* Update JsonDocument and JsonSerializer to react to JsonWriter changes.
* Normalize the reference assembly.
* Do not escape/validate comments and update issue number.
* Do not escape comments and validate they don't contain embedded
delimiter
* Remove dead code and update issue number in comments.
* Throw InvalidOEx instead of ArgEx if IBW doesn't give requested memory.
* Fix test build breaks for netfx.
* Remove dead code and fix source packaging.
* Address PR feedback.
* Disable writing floats test on windows
* 8 digit floats don't work well on older TFMs. Reduce to 7.
Commit migrated from https://github.com/dotnet/corefx/commit/
1f9b84a0804e868c7e0f37a3c10fbaf7c735ae14
Stephen Toub [Thu, 18 Apr 2019 04:01:04 +0000 (00:01 -0400)]
Fix SocketsHttpHandler streams to do sync I/O in sync methods (dotnet/corefx#36946)
* Fix SocketsHttpHandler response streams to do sync I/O in sync methods
SocketsHttpHandler hands back response Streams for reading response body content. While we encourage developers to use the async Stream APIs, Stream does expose synchronous APIs, yet the current implementations are just wrapping the async ones and doing sync-over-async.
This fixes the response stream synchronous APIs to be sync down to the underlying networking stream.
It also fixes a couple other minor issues, e.g. Flush{Async} on read-only stream should be nops rather than throwing, we should include an error message about a stream being read-only when trying to write to it, etc.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
315fd00cb2465390900209919cdb2bf6bc44ae0e
David Shulman [Thu, 18 Apr 2019 03:33:23 +0000 (20:33 -0700)]
Fix ClientWebSocket closing handshake logic (dotnet/corefx#36975)
An HttpListener websocket test was failing after the change from PR dotnet/corefx#36928. That PR made changes
to tighten up the transition to the Closed state after the closing handshake had completed.
That PR missed some additional changes needed especially in cases where a server (such as loopback)
sends the close frame almost concurrently with the client sending the close frame.
This PR fixes the close frame handshake logic and also makes some optimizations in cases where the
websocket has already transitioned to the Aborted state during the closing handshake. In that case,
the websocket should not wait for a close frame to be received but should simply proceed to closing
the connection.
Fixes dotnet/corefx#36963
Commit migrated from https://github.com/dotnet/corefx/commit/
1824535f95defea3ba464599ee4b9937a82eaaf9
Adeel Mujahid [Thu, 18 Apr 2019 03:02:55 +0000 (04:02 +0100)]
Improve System.Native build experience for new platforms (dotnet/corefx#36926)
Commit migrated from https://github.com/dotnet/corefx/commit/
65f07a9cf6e3d53cbd77c52d5ecffe00be0ff804
Levi Broderick [Thu, 18 Apr 2019 02:35:56 +0000 (19:35 -0700)]
Add extra tests for UTF-16 validation of random 8-char data (dotnet/corefx#36903)
Commit migrated from https://github.com/dotnet/corefx/commit/
60aee3575e21af1070e7b834905d1864a401828d
Eric StJohn [Thu, 18 Apr 2019 01:11:05 +0000 (18:11 -0700)]
Fix SDK downgrading Platforms package (dotnet/corefx#36981)
Commit migrated from https://github.com/dotnet/corefx/commit/
dcd80906ded9fee765d7ce4de4d992d5108df63c
Jose Perez Rodriguez [Thu, 18 Apr 2019 00:48:24 +0000 (17:48 -0700)]
Manually updating dependencies in order to get the new coreclr packages. (dotnet/corefx#36976)
* Update the Index and Range interfaces and tests
* Fix api compat failure with utf8string
* Fix the test to use Assert.Throws
* Update dependencies manually
Commit migrated from https://github.com/dotnet/corefx/commit/
d5a5f3c9eb96adf38115cbc04e5664abf328b02d
dotnet-maestro[bot] [Wed, 17 Apr 2019 23:18:59 +0000 (16:18 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36922)
* Update dependencies from https://github.com/dotnet/coreclr build
20190415.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27615-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27615-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27615-72
* Update dependencies from https://github.com/dotnet/coreclr build
20190416.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27616-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27616-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27616-72
* Update CoreCLR dependencies to 3.0.0-preview5-27616-73
* Fixing the Min/Max and MinMagnitude/MaxMagnitude for System.Math and System.MathF to expect NaN propagation
Commit migrated from https://github.com/dotnet/corefx/commit/
818355a02ec70c72d44e4ad2b1b95943350d55bb
Steve Harter [Wed, 17 Apr 2019 22:52:49 +0000 (15:52 -0700)]
Add Json serializer property name related features (dotnet/corefx#36940)
Commit migrated from https://github.com/dotnet/corefx/commit/
bc8c22291049b2626ec5b102869685fc95fa41cc
Adeel Mujahid [Wed, 17 Apr 2019 18:44:46 +0000 (19:44 +0100)]
Use NativeLibrary.[Try]Load for netcoreapp3 (dotnet/corefx#36944)
Commit migrated from https://github.com/dotnet/corefx/commit/
fbc748b93e65600a68b217ec59fc4522d5df4ffb
Tanner Gooding [Wed, 17 Apr 2019 17:07:51 +0000 (10:07 -0700)]
Regenerating the System.Runtime.Intrinsics reference source (dotnet/corefx#36965)
Commit migrated from https://github.com/dotnet/corefx/commit/
fa25b86d6789440f42ba391deda428e302f584f9
Stephen Toub [Wed, 17 Apr 2019 15:15:40 +0000 (11:15 -0400)]
Disable asserting HttpListener web socket test (dotnet/corefx#36964)
Commit migrated from https://github.com/dotnet/corefx/commit/
18cd561127e35841db2775dc7a85adad70363e18
Anirudh Agnihotry [Wed, 17 Apr 2019 06:22:12 +0000 (23:22 -0700)]
adding default encoder as png when we are not able to find encoder (dotnet/corefx#36937)
Commit migrated from https://github.com/dotnet/corefx/commit/
dbbabfbf3e5a355b9bde2a01f2effde96631242a
Michal Strehovský [Wed, 17 Apr 2019 04:47:15 +0000 (06:47 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36924)
This reverts commit dotnet/corefx@
8e843314e1dbd3b3f26abb1f285349be8920cce4.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9f88bd7fd774ce433a764b6d388517c6460164a
Tomas Weinfurt [Wed, 17 Apr 2019 04:00:27 +0000 (21:00 -0700)]
fix tests with http/2 (dotnet/corefx#36945)
Commit migrated from https://github.com/dotnet/corefx/commit/
f80cf8c360ef00c9a5fdc990e3abd7df23ee0015
Viktor Hofer [Wed, 17 Apr 2019 00:40:30 +0000 (02:40 +0200)]
Update testdata versions (dotnet/corefx#36938)
* Update testdata versions
* Bump versions in projects and group in TestData
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
e5d2b5291277dbd7444d0a17a2bff4784265d917
David Shulman [Wed, 17 Apr 2019 00:15:30 +0000 (17:15 -0700)]
Fix ClientWebSocket close handshake when using proxy (dotnet/corefx#36928)
When the client websocket was going through a proxy, it would sometimes transition to the
'Aborted' state and not the 'Closed' state after a successful closing handshake.
I first opened this bug a year ago but finally was able to get back to it and root cause the
problem. The problem only occured with the managed websocket. The .NET Framework did not have
this problem. And some proxies didn't cause a problem with managed websocket (such as Fiddler).
The root cause is a misinterpretation of RFC 6455, Section 7.1.1. This describes the behavior
of how the websocket's TCP connection should be closed. The most graceful way is to wait for
the server to initiate the close of the socket. In cases where it is taking too long to wait
for the server to start the TCP close, then the client can start the TCP close of the socket.
But no matter how the socket is finally closed, the websocket state should transition to 'Closed'
as soon as a valid closing handshake was performed (i.e. close frames both sent and received).
And this occurs before any logic for closing the TCP connection.
The code in managed websocket has a timer to wait 1 second for the server to start a close. If
the timer finishes, then the managed websocket calls an Abort() method to close the socket. This
ends up transitioning the websocket to an 'Aborted' state which is incorrect. The state should
only be moved to the 'Aborted' state if a closing handshake was not completed.
I added a new test to support this change and moved the LoopbackProxyServer code to Common.
Fixes dotnet/corefx#28027
Commit migrated from https://github.com/dotnet/corefx/commit/
0c9684c2c4057908cf697a366a3b1527326e507d
Eric StJohn [Tue, 16 Apr 2019 23:06:39 +0000 (16:06 -0700)]
Fix VB.Core SLN configurations (dotnet/corefx#36934)
Commit migrated from https://github.com/dotnet/corefx/commit/
39cc91592c3d9c8fe7700a6323755cd7747c34ab
Tomas Weinfurt [Tue, 16 Apr 2019 21:53:07 +0000 (14:53 -0700)]
add tests for invalid HTTP headers (dotnet/corefx#36898)
* add SendAsync_InvalidHeader_Throw
* fix tests
* move SendAsync_InvalidHeader_Throw
Commit migrated from https://github.com/dotnet/corefx/commit/
18e1fabd13b40eb6ea88c1b7bae8c4e14a927019
Carlos Sanchez Lopez [Tue, 16 Apr 2019 21:24:34 +0000 (14:24 -0700)]
Update owners (dotnet/corefx#36936)
Updating ownership in the System.Net area (removing Max and Caesar).
URI - Will.
Commit migrated from https://github.com/dotnet/corefx/commit/
c3c0efd9029370ab9762ee254e3db8b8e3dddf34
Filip Navara [Sun, 14 Apr 2019 20:50:50 +0000 (22:50 +0200)]
Move EventSource to shared CoreLib partition
Commit migrated from https://github.com/dotnet/corefx/commit/
00279f8fd11a96f57b8a56855d313f9e2c9bb513
Tomas Weinfurt [Tue, 16 Apr 2019 18:54:24 +0000 (11:54 -0700)]
support HTTP/2 without TLS (dotnet/corefx#36753)
* support HTTP/2 without ssl
* feedback from review
* revert changes GetAsync->SendAsync
* remove unused variable
* feedback from review
* feedback from review
* add missong Trace().
Commit migrated from https://github.com/dotnet/corefx/commit/
7ed0c5338941346a3cacb4e18f19aaddb283da90
Viktor Hofer [Tue, 16 Apr 2019 17:41:48 +0000 (19:41 +0200)]
React to RunTests CLI changes & Manual darc update (dotnet/corefx#36915)
* Manual darc update from build '
20190415.12'
* React to RunTests CLI changes
Commit migrated from https://github.com/dotnet/corefx/commit/
53f9e9e7fc87cbc08449307fbb0fbe567516e38f
Hugh Bellamy [Tue, 16 Apr 2019 14:59:12 +0000 (15:59 +0100)]
Remove devdocs from System.Runtime.InteropServices code (dotnet/corefx#36669)
* Cleanup System.Runtime.InteropServices code
- Move public classes/enums to their own file
- Use summary instead of devdoc
- Misc
Commit migrated from https://github.com/dotnet/corefx/commit/
8d79b6117e9d584eebb8b6933bba83dd514010ca
Viktor Hofer [Tue, 16 Apr 2019 11:59:00 +0000 (13:59 +0200)]
Update SDK requirement in windows-instructions
Commit migrated from https://github.com/dotnet/corefx/commit/
e2ecd2c33aed216f9a1062044aedf10e25ee8ca4
Viktor Hofer [Tue, 16 Apr 2019 07:19:21 +0000 (09:19 +0200)]
Upgrade dotnet SDK to 3.0-preview3 (dotnet/corefx#36859)
* Upgrade SDK to 3.0
* Remove asp and desktop framework references
* Manual darc update from build '
20190415.1'
* Suppress type overlap with ns2.1
* Make SDK use output of core-setup for both ref and runtime
SDK is ignoring RuntimeFrameworkVersion for ref packs. Set TargetingPackVersion
on KnownFrameworkReference instead.
https://github.com/dotnet/sdk/issues/3129
Commit migrated from https://github.com/dotnet/corefx/commit/
66bcc2d2b1248ed5384393adf5f3a647d18b75f1
Grant [Tue, 16 Apr 2019 01:24:04 +0000 (18:24 -0700)]
Ref Assembly and Units for Span.Trim (dotnet/corefx#35576)
* Units for Trim
* Add ref assembly
* Bug
* Add char units
* Bugs
* CR fixes - 1
* CR fixes - 2
* CR fixes - 3
* CR fixes - 4
* CR fixes - 5
* Revert formatting
* unfo formatting
* Get MemberData working
* Normalize ref
* Manual revert changes
* CR fixes
* Undo code cleanup
* Fixes
* Update ref
* Update ref
* Update ref
* Move memory tests
* Revert StringTests
* Remove redundant unit code
* Add missing refs
* Bug
* dotnet msbuild /t:GenerateReferenceSource
* Revert unintended changes
* POC : Check if fix works
* Fix units
* Revert temp test
* Update ApiCompatBaseline.uapaot.txt
Commit migrated from https://github.com/dotnet/corefx/commit/
2191763a765654710df5317dc65dc7cd935bc8c1
Tomas Weinfurt [Mon, 15 Apr 2019 22:15:32 +0000 (15:15 -0700)]
add test for lower casing header name logic (dotnet/corefx#36708)
* add test for 35164
* update SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2
* fix uwp tests
* change port from 123 to 443
Commit migrated from https://github.com/dotnet/corefx/commit/
4e3b46c22cec88a1f0deaa2f594634e5553412e1
Steve Harter [Mon, 15 Apr 2019 21:44:04 +0000 (14:44 -0700)]
Remove null coalescing assignment operator to avoid build-from-source compile issues (dotnet/corefx#36890)
Commit migrated from https://github.com/dotnet/corefx/commit/
f78e9881bd8ef1def0227569d822693b944378a7
Omair Majid [Mon, 15 Apr 2019 20:55:02 +0000 (16:55 -0400)]
Close the socket if bind() fails (dotnet/corefx#36769)
When using a socket with bind() and bind fails, close the socket to free
up the resources associated with the socket.
Commit migrated from https://github.com/dotnet/corefx/commit/
03ae543d4da4e539b9915a5f38f36a69739fa9d9
Steve Harter [Mon, 15 Apr 2019 17:58:03 +0000 (10:58 -0700)]
Json deserializer collection perf improvements by avoiding boxing (dotnet/corefx#36865)
Commit migrated from https://github.com/dotnet/corefx/commit/
6bfaf4116b5180c857bf6ad531f0655fd57c5eef
Santiago Fernandez Madero [Mon, 15 Apr 2019 17:55:42 +0000 (12:55 -0500)]
Remove myget publish entirely (dotnet/corefx#36886)
Commit migrated from https://github.com/dotnet/corefx/commit/
d601d2e7602c9dbb6ae0d95c450bce2db027f78d
Filip Navara [Mon, 15 Apr 2019 16:46:18 +0000 (18:46 +0200)]
Add guard for runtimes that support large arrays (dotnet/corefx#36883)
Commit migrated from https://github.com/dotnet/corefx/commit/
679dba7531d3be10b387203c9a9f350f39ea3a8a
Santiago Fernandez Madero [Mon, 15 Apr 2019 16:03:58 +0000 (11:03 -0500)]
Restore internal tools using .net core restore (dotnet/corefx#36840)
* Restore internal tools using .net core restore
* Restore internal tools from dnceng-internal
Bump TestILC version
* Manual Darc update from build '
20190414.2'
* Add buildExtraArguments to common
Commit migrated from https://github.com/dotnet/corefx/commit/
10d7d6f812295a572eb148aedb19efd2f96fbe17
Hugh Bellamy [Mon, 15 Apr 2019 14:15:24 +0000 (15:15 +0100)]
Add more number converter tests (dotnet/corefx#36653)
* Add more number converter tests
* Fix if bug in BaseNumberConverter
* Address PR feedback
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
25c10204a69c09afd0701740d1555eba04496c71
dotnet-maestro-bot [Mon, 15 Apr 2019 04:10:26 +0000 (21:10 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27612-00, beta-27612-00, respectively (dotnet/corefx#36867)
Commit migrated from https://github.com/dotnet/corefx/commit/
81e0e2cb79e272e6e270c6562017b64f9c773e99
Tom Deseyn [Mon, 15 Apr 2019 01:48:56 +0000 (03:48 +0200)]
SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling (dotnet/corefx#36721)
* SocketPal.Unix: replace DangerousGetHandle with SafeHandle marshalling
DangerousGetHandle was used here for performance. SafeHandle marshalling is
faster now, and preferable to avoid using invalid handles.
* Socket.Windows: replace DangerousGetHandle with SafeHandle marshalling for async operations
Commit migrated from https://github.com/dotnet/corefx/commit/
88b6ebe8faaadb027c1378132dc9767c13912159
David Shulman [Mon, 15 Apr 2019 01:34:25 +0000 (18:34 -0700)]
Cleanup SocketOptionNameTest (dotnet/corefx#36864)
One of the oldest issues dotnet/corefx#4887 was about the Windows socket option, ReuseUnicastPort.
This test was disabled several years ago because it was very difficult to test in CI since it
required not only a newer version of Windows but also specific network settings on the machine.
At this point, there is not any way to reliably test this. And the end-to-end test isn't really
of high value for .NET Core since we would really be mostly testing an OS feature.
As part of cleaning that issue up, I cleaned up the rest of the tests, some of which were marked
as Outerloop but didn't need to be.
Closes dotnet/corefx#29929
Closes dotnet/corefx#21327
Closes dotnet/corefx#4887
Commit migrated from https://github.com/dotnet/corefx/commit/
f389a14d375ef90f971bc15095b925f73845a7d3
Tanner Gooding [Mon, 15 Apr 2019 00:46:34 +0000 (17:46 -0700)]
Remove IgnoredTypes entries for the System.Runtime.Intrinsics.Arm.Arm64 types (dotnet/corefx#36866)
Commit migrated from https://github.com/dotnet/corefx/commit/
7336f57f745e7399803902efca8fd085ff6ca326
Ganbarukamo41 [Sun, 14 Apr 2019 23:34:34 +0000 (00:34 +0100)]
Implement IEquatable to Memory and ReadOnlyMemory (dotnet/corefx#36497)
* Implement IEquatable to Memory and ReadOnlyMemory
* Add equality tests using IEquatable of ReadOnlyMemory and Memory
* Fix and add tests for Memory and ReadOnlyMemory
* Fixed where IEquatable interface tests were using object.Equals(object) instead of T.Equals(T)
* Added IEquatable interface tests for Memory of different types (char, string)
* Fix IEquatable tests for Memory and ReadOnlyMemory
* Fix tests that were missed in the previous commit (IEquatable tests calling object.Equals(object))
* Should use ReadOnlyMemory in ReadOnlyMemory tests
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Remove baselines added to System.Runtime by mistake
* Add baselines to System.Memory
* Update uapaot baseline for dotnet/corefx#36497
Implementing IEquatable to Memory and ReadOnlyMemory (see dotnet/corefx#32905)
* Add removed baselines to System.Runtime again
Commit migrated from https://github.com/dotnet/corefx/commit/
68920bb0764fb13257f710f44dd08e85e4a35c7c
Krzysztof Wicher [Sun, 14 Apr 2019 19:31:59 +0000 (12:31 -0700)]
Fix build (dotnet/corefx#36862)
Commit migrated from https://github.com/dotnet/corefx/commit/
822da3133d02da072843ffe7715c6af29d0c4192
Santiago Fernandez Madero [Sun, 14 Apr 2019 17:31:01 +0000 (12:31 -0500)]
Remove myget feeds (dotnet/corefx#36797)
* Remove myget feeds
* Bump compression testdata package version
Commit migrated from https://github.com/dotnet/corefx/commit/
0aa6ccc261165e9e045a6aab6218f3e71f99e0f4
David Shulman [Sun, 14 Apr 2019 03:16:43 +0000 (20:16 -0700)]
Improve HttpClient POST with REDIRECT tests (dotnet/corefx#36848)
This PR is similar to dotnet/corefx#36801 and dotnet/corefx#36828 which improved upload tests stability.
Modify the POST with REDIRECT test to use the VerifyUpload endpoint which avoids
having to echo back the large request body.
Closes dotnet/corefx#36220
Commit migrated from https://github.com/dotnet/corefx/commit/
52d4723aaa8e561a6f36589a6d1e112287c0308b
Steve MacLean [Sun, 14 Apr 2019 01:57:06 +0000 (21:57 -0400)]
Add Assembly.LoadWithPartialName cases (dotnet/corefx#36803)
* Add Assembly.LoadWithPartialName cases
Cover hole reported in dotnet/coreclrdotnet/corefx#19817
* Verify argument parameter name
* Disable new test on .NetFramework
Commit migrated from https://github.com/dotnet/corefx/commit/
5ae3c5655cd84bf3c7f9568477153642fdd7c95e
Steve MacLean [Sun, 14 Apr 2019 01:56:49 +0000 (21:56 -0400)]
Contextual reflection (dotnet/corefx#36845)
* Add ContextualReflection facade
* Update ApiCompatBaseline.uapaot
Commit migrated from https://github.com/dotnet/corefx/commit/
3e2be4796df626d7f4e73c0018992c4f4aa60627
Omair Majid [Mon, 8 Apr 2019 14:40:49 +0000 (10:40 -0400)]
Fix bad null check in pal_dsa.c
The code calls DSA_new() and then, only after assigning the value from
DSA_new to a pointer, tries to check that the pointer was not null.
Assigning to a null pointer leads to undefined behaviour and a compiler
can assume that assignment-to-a-null-pointer wont happen. Subsequently,
the compiler can remove the entire check because the pointer can't be
null.
Fix that by:
1. Moving the check for whether the pointer is null before dereferncing
the pointer.
2. Checking the return value of DSA_new() spearately after it has been
called.
Commit migrated from https://github.com/dotnet/corefx/commit/
e7fd1669eafafd16de85cd90b558d54abb3a3343
Steve Harter [Sat, 13 Apr 2019 22:32:49 +0000 (15:32 -0700)]
JsonSerializerOptions API update and ignore property features (dotnet/corefx#36776)
Commit migrated from https://github.com/dotnet/corefx/commit/
b06250eb9ef50bca50cf7676e87753dbd8b5470a
dotnet-maestro[bot] [Sat, 13 Apr 2019 18:53:57 +0000 (11:53 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36816)
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27612-73
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27612-73
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27612-73
- Also react to changes in the UTF-8 transcoding logic (dotnet/corefx#36712)
Commit migrated from https://github.com/dotnet/corefx/commit/
4c3d4a083488b9f89676926a8b75aa5f7572f67f
Krzysztof Wicher [Sat, 13 Apr 2019 17:46:05 +0000 (10:46 -0700)]
address feedback from 36775 (dotnet/corefx#36839)
Commit migrated from https://github.com/dotnet/corefx/commit/
c3981ca2455f8a6593301bac1adb363d02934954
Hugh Bellamy [Sat, 13 Apr 2019 16:52:14 +0000 (17:52 +0100)]
Fix LsaOpenPolicy interop definition
* Move Lsa handles to Interop code
* Fix implementation of LsaOpenPolicy
* Move LSA_STRING and LSA_UNICODE_STRING to Advapi32
* Consolidate LSA_UNICODE_STRING and UNICODE_STRING
Commit migrated from https://github.com/dotnet/corefx/commit/
f5e2679e76c102aea8218ae290ffb7f4d97e9cc2
Filip Navara [Sat, 13 Apr 2019 16:07:10 +0000 (18:07 +0200)]
Fix encoding of Digest authentication headers (dotnet/corefx#36627)
* Fix encoding of Digest authentication headers for servers that don't understand RFC 5987 encoding
* Quote-prefix special characters when encoding Digest headers
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
cce7870129dcca472f4e6108e21e87bc9573b8d2
Paito Anderson [Sat, 13 Apr 2019 15:28:21 +0000 (11:28 -0400)]
Allow cookies with spaces in the name (dotnet/corefx#36566)
* Allow cookies with spaces in the name
* Apply suggestions from code review
Co-Authored-By: PaitoAnderson <pj.paito@gmail.com>
* Added supporting HttpClient functional cookie test
* Updated UWP cookie class and added additional tests
* Prevent cookies with spaces at the start or end
* Forgot UWP
* Fix could allocate on trim
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Better cookie space start/end check
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Bring checks into line
Co-Authored-By: Ben Adams <thundercat@illyriad.co.uk>
* Skip test on .net framework
* Skip additional tests on .net framework
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
8a22438a1af870cdd04eaf798b155b8a1ab04cb4
Filip Navara [Sat, 13 Apr 2019 15:19:53 +0000 (17:19 +0200)]
Read system proxy information on macOS (dotnet/corefx#36177)
* Read system proxy information on macOS
* Replace CFRunLoopRemoveSource with CFRunLoopSourceInvalidate to mimic recommended flow from Chromium / WebKit
Commit migrated from https://github.com/dotnet/corefx/commit/
2aa2518a47c541148e2dc3f9d040942e44395acd
Alexander Köplinger [Sat, 13 Apr 2019 04:47:30 +0000 (06:47 +0200)]
Fix TypeInfoTests.GenericParameterConstraints() test (dotnet/corefx#36832)
It was a Theory instead of a Fact and the method parameter wasn't being used.
Commit migrated from https://github.com/dotnet/corefx/commit/
1a83ff9b6d6d3406a6ef800dbe2bc7a74e4d5d3c
Maira Wenzel [Sat, 13 Apr 2019 04:46:42 +0000 (21:46 -0700)]
overwrite -> overwriteFiles (dotnet/corefx#36831)
Commit migrated from https://github.com/dotnet/corefx/commit/
326246059f3e7422e39dd71f2e1541c0288777d0
Charles Stoner [Sat, 13 Apr 2019 04:45:11 +0000 (21:45 -0700)]
Port ErrObject and CreateProjectError (dotnet/corefx#36808)
* Port ErrObject and CreateProjectError
* PR feedback
* Add FilterDefaultMessage test
Commit migrated from https://github.com/dotnet/corefx/commit/
e2ab05d35f00f9cd9a92a94284698cc241f8380d
Layomi Akinrinade [Sat, 13 Apr 2019 01:44:18 +0000 (21:44 -0400)]
Add support for generic interface-based collections in JsonSerializer (dotnet/corefx#36756)
* Add support for generic interface-based collections in JsonSerializer
Specifically, add enumerable converters for:
* IEnumerable<T>
* ICollection<T>
* IList<T>
* IReadOnlyCollection<T>
* IReadOnlyList<T>
This partially addresses https://github.com/dotnet/corefx/issues/36643
* Address review comments
* Add serialization tests for generic interface collection as members of class objects
Commit migrated from https://github.com/dotnet/corefx/commit/
cc01ec9a781c4af5afd495c5b80a1f7d9616bed2
Krzysztof Wicher [Sat, 13 Apr 2019 01:23:31 +0000 (18:23 -0700)]
CipherSuitePolicy implementation (dotnet/corefx#36775)
* CipherSuitePolicy implementation (Linux)
* SSL_CIPHER_find
* do not call TLS1.3 APIs on platforms which don't support it
* Non-TLS1.3 specific tests are skipped when not enough cipher suites is enabled
* clean ups
* attempt to fix OSX
* another attempt to fix OSX
* missing define
* address some feedback, try to fix test failures
* portable build fix
* do not call old set ciphers API when only TLS 1.3 is requested
* apply feedback
* add OSX implementation
* fixes to OSX
* explicit convert
* use explicit SSLCipherSuite instead of uint16_t
* random change to trigger CI
* s/unsafe/fixed
* fixes
* random change to trigger CI
* client ordering does not have to win
* tests: AllowedCipherSuites, new CipherSuitesPolicy(null)
* run AllowedCipherSuites tests only when CSP is supported
* add summary on CipherSuitesPolicy
* address feedback
* move OS specific files to CipherSuitesPolicyPal
* FALLBACK->LIGHTUP and remove local_
* do not call 1.1.1 function on non-portable build when lower openssl version is installed
* get rid of warning that arg is unused
* make CipherSuitesPolicyPal public members internal
Commit migrated from https://github.com/dotnet/corefx/commit/
07f443b6c9f27dd050ffb5eb3afa126a2b1bdddd
Jeremy Barton [Sat, 13 Apr 2019 00:37:52 +0000 (17:37 -0700)]
Add JsonElement.Clone to make a long-term persistable copy
Commit migrated from https://github.com/dotnet/corefx/commit/
cd020c11b563b51f439324bcefc559d1408f4e09
David Shulman [Sat, 13 Apr 2019 00:27:40 +0000 (17:27 -0700)]
Improve WebClient upload tests stability (dotnet/corefx#36828)
This PR is a follow-up to PR dotnet/corefx#36801 which improved HttpClient tests stability.
Some of the WebClient tests were failing with WebExceptions being caused by the
Azure remote endpoint returning 500 status code. Similar to the fixes done to
the HttpClient tests, this PR updates some of the WebClient upload tests to use
the VerifyUpload endpoint which doesn't have to echo back the request body payload.
Some of the WebClient tests upload more complex multi-part formats and can't be
easily changed to use the VerifyUpload endpoint. But those tests aren't using large
data sets so it should be ok.
Closes dotnet/corefx#36226
Commit migrated from https://github.com/dotnet/corefx/commit/
00e9390eb0e9b95a410bd3e91b2c58cf9ec85d95
Anirudh Agnihotry [Fri, 12 Apr 2019 19:07:39 +0000 (12:07 -0700)]
embed generated files into pdbs (dotnet/corefx#36825)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1730e55ba3e1a4d2ae22d052fe17694d2c69379
David Fowler [Fri, 12 Apr 2019 18:55:20 +0000 (11:55 -0700)]
This should fix the flaky test (dotnet/corefx#36826)
- The pool in the test wasn't being used (This was changed in a previous commit)
- Use the DisposeTrackingBufferPool to make sure we allocated the number of segments we expect
Commit migrated from https://github.com/dotnet/corefx/commit/
6eeed98a406adf281649e94546975d52c72465e6
Eric StJohn [Fri, 12 Apr 2019 13:20:07 +0000 (06:20 -0700)]
Update zlib-intel to v1.2.11.1_jtkv6.3 (dotnet/corefx#36795)
* inflate: handle windowBits == 16
* deflate_medium: add dist -1 to hash even for long matches
This fixes an issue where a repeat sequence longer than 258 would be
encoded using longer distance values after the first match.
* deflate_medium: avoid emitting a suboptimal literal in the restart case
When we load new data into the window, we invalidate the next match, in
case the match would improve. In this case, the hash has already been
updated with this data, so when we look for a new match it will point
it back at itself. As a result, a literal is generated even when a
better match is available.
This avoids that by catching this case and ensuring we're looking at the
past.
Commit migrated from https://github.com/dotnet/corefx/commit/
6322a406f88e854c5b827ab838f988f8992048f8
Krzysztof Wicher [Fri, 12 Apr 2019 13:19:51 +0000 (06:19 -0700)]
remove copy of Interop.GetCurrentThreadId.cs (dotnet/corefx#36807)
Commit migrated from https://github.com/dotnet/corefx/commit/
46f57de34bc4df79e50911dce6ec9abb4f35b553
David Fowler [Fri, 12 Apr 2019 11:42:34 +0000 (04:42 -0700)]
Get more information about a flaky test (dotnet/corefx#36810)
Commit migrated from https://github.com/dotnet/corefx/commit/
f843b9ca2ecdc1b3f52d6ab9dfb094689281dee3
Stephen Toub [Fri, 12 Apr 2019 02:11:51 +0000 (22:11 -0400)]
Update Version comparison operator tests (dotnet/corefx#36799)
* Update Version comparison operator tests
Better validate the operators, and update the tests now that the operators won't throw for null.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
599955ac3c2c6625c7baae46be301767b1f074d2
Kevin Jones [Fri, 12 Apr 2019 01:20:23 +0000 (21:20 -0400)]
Remove octet string wrapping from EnvelopedCms
Removes the octet string wrapping from EnvelopedCms encrypt if the content type is id-data.
Commit migrated from https://github.com/dotnet/corefx/commit/
2cd5d08337a7c5fadf90c7d2a571cc18709601d2
David Shulman [Fri, 12 Apr 2019 00:31:25 +0000 (17:31 -0700)]
Improve HttpClient POST tests stability (dotnet/corefx#36801)
Several of the HttpClient POST scenario tests were failing with HTTP status code 500. This was caused
by the Azure remote endpoint generating OutOfMemoryException at times. The tests are sending
large amounts of request body data to the Echo endpoint. That endpoint will respond back with all
the headers and request body data serialized into a JSON payload. The OOM exceptions were
coming from the Newtonsoft JSON serialization code currently used by the server endpoint.
These tests don't really require that the request body data be sent back. The purpose of the tests is
to verify that the request body payload was correctly sent by the client. We already have an endpoint,
VerifyUpload, that can do that without echo'ing back the large request body data.
This PR modifies the tests to use that endpoint. This should mitigate the OOM exceptions
currently being generated in the server-side code. Additional mitigations/fixes will be done later on the server-side code to improve robustness. But fixing the tests to be more streamlined is goodness and will result in these tests being faster and more stable.
Closes dotnet/corefx#36782
Commit migrated from https://github.com/dotnet/corefx/commit/
288ce93787799052705814876d6e5ccb0523797d
Marco Rossignoli [Thu, 11 Apr 2019 20:53:08 +0000 (22:53 +0200)]
Fixes race in NamespaceCache (dotnet/corefx#36699)
* fix race
* address PR feedback
* address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ce62a086814fdfecea1d6ba6657c3fb88763e1d6
dotnet-maestro[bot] [Thu, 11 Apr 2019 19:37:46 +0000 (12:37 -0700)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#36788)
* Update dependencies from https://github.com/dotnet/coreclr build
20190410.72
- Microsoft.NET.Sdk.IL - 3.0.0-preview5-27610-72
- Microsoft.NETCore.ILAsm - 3.0.0-preview5-27610-72
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview5-27610-72
* Regenerating the System.Runtime.Intrinsics ref assembly to pick up the API changes.
* Update Range.GetOffsetAndLength Contract
* Fix return Tuple fields names
* Fix apicompat failure with Range type
Commit migrated from https://github.com/dotnet/corefx/commit/
2cae2dbe1f8b687b15c5e7e3acffb0942524cfe4
Afsaneh Rafighi [Thu, 11 Apr 2019 18:24:31 +0000 (11:24 -0700)]
Merge pull request dotnet/corefx#36735 from Wraith2/sqlfix-envchangepool
SqlClient fix SqlEnvChangePool thread safety bug
Commit migrated from https://github.com/dotnet/corefx/commit/
af562e84b8b5a4a335ceb5006886a6c42c1c023e
Max Kerr [Thu, 11 Apr 2019 18:23:45 +0000 (11:23 -0700)]
HTTP/2 Request Cancellation (dotnet/corefx#35118)
HTTP/2 cancellation support, plus improvements to outgoing write buffering.
Commit migrated from https://github.com/dotnet/corefx/commit/
d6e36e4ecb0d004de54eb7bdf0ed6cdcb042e3c9
Viktor Hofer [Thu, 11 Apr 2019 17:43:27 +0000 (19:43 +0200)]
Remove NETSTandard Test Suite (dotnet/corefx#36784)
Commit migrated from https://github.com/dotnet/corefx/commit/
d26c6cdd6895e8df5ac665ce23f20bbaa42a2a9f
Alexander Köplinger [Thu, 11 Apr 2019 17:07:13 +0000 (19:07 +0200)]
System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available (dotnet/corefx#36785)
* System.Linq.Expressions: Skip tests if DebuggerTypeProxy attribute isn't available
These tests failed on Xamarin.iOS since the linker strips out most Debugger*
attributes in release builds. We can gracefully handle this case and simply
skip the tests instead.
* Use ConditionalFact/Theory
Commit migrated from https://github.com/dotnet/corefx/commit/
7b7345665ec28a85084b3ad2932e03f7641d6151
Eric StJohn [Thu, 11 Apr 2019 15:42:19 +0000 (08:42 -0700)]
Fix -allconfigurations build on linux (dotnet/corefx#36780)
* Fix -allconfigurations build on linux
* Fix whitespace
Commit migrated from https://github.com/dotnet/corefx/commit/
80672656a723818863ae0021370cc4f9ddfbdc73
Michal Strehovský [Thu, 11 Apr 2019 15:42:00 +0000 (17:42 +0200)]
Revert "Run IBCMerge on Linux build (dotnet/corefx#36763)" (dotnet/corefx#36791)
This reverts commit dotnet/corefx@
ef2ee1291ea6140cb462ead8b4cc86a762b58f64.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e843314e1dbd3b3f26abb1f285349be8920cce4
Hugh Bellamy [Thu, 11 Apr 2019 12:46:33 +0000 (13:46 +0100)]
Remove NativeMethods from System.IO.Ports (dotnet/corefx#36740)
* Remove NativeMethods from System.IO.Ports
Commit migrated from https://github.com/dotnet/corefx/commit/
e4dbfa4cbb0ff67efab2bf4214f34125892df986
Michal Strehovský [Thu, 11 Apr 2019 12:08:14 +0000 (14:08 +0200)]
Run IBCMerge on Linux build (dotnet/corefx#36763)
* Restores IBC data for both Linux and Windows on all platforms
* Chooses the right IBC data based on the target OS
* When target OS isn't anything specific (like, e.g. System.Linq and other assemblies that are not OS specific), embeds Windows IBC data
Commit migrated from https://github.com/dotnet/corefx/commit/
ef2ee1291ea6140cb462ead8b4cc86a762b58f64
Tom Deseyn [Thu, 11 Apr 2019 09:20:43 +0000 (11:20 +0200)]
SocketAsyncEngine.Unix: use ConcurrentDictionary to get rid of lock for context lookup (dotnet/corefx#36358)
Commit migrated from https://github.com/dotnet/corefx/commit/
1c881ce4e49d723891d10ffabb171dc07b75972e
Levi Broderick [Thu, 11 Apr 2019 07:01:56 +0000 (00:01 -0700)]
Add ref asms and unit tests for string.GetPinnableReference (dotnet/corefx#36777)
Commit migrated from https://github.com/dotnet/corefx/commit/
4672a7b5d28070bd3dc8431887b3474a04249ccf
Alan Parr [Wed, 10 Apr 2019 22:45:45 +0000 (23:45 +0100)]
Removed FEATURE_NOTIFYPROPERTYCHANGED checks (dotnet/corefx#36774)
Commit migrated from https://github.com/dotnet/corefx/commit/
1ae46a2b2a7719e0fd8d30b5df14b7e181d1c963
Levi Broderick [Wed, 10 Apr 2019 19:24:55 +0000 (12:24 -0700)]
Add Win10 19H1 platform detection (dotnet/corefx#36767)
Commit migrated from https://github.com/dotnet/corefx/commit/
dc63fa0a60e68174f423fe5316e323c6635c08fe
Santiago Fernandez Madero [Wed, 10 Apr 2019 18:59:29 +0000 (11:59 -0700)]
Fix outerloop linux build missing container resource (dotnet/corefx#36773)
Commit migrated from https://github.com/dotnet/corefx/commit/
3773daaaba958e65f87e54fc0ec64c4a02282282