platform/upstream/mesa.git
3 years agost/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT and skip gs
Mike Blumenkrantz [Mon, 14 Dec 2020 16:48:39 +0000 (11:48 -0500)]
st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT and skip gs

the previous commit handling this forced geometry shader usage for all cases,
but this is not ideal, so instead there are now fragment shader variants for
both depth==1 and depth!=1, corresponding to the existence of gl_Layer in the
shader

Fixes: 614c77772ac ("st/pbo: fix pbo uploads without PIPE_CAP_TGSI_VS_LAYER_VIEWPORT")

Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8089>

3 years agovirgl: fix BGRA emulation artifacts during window resize
Ryan Neph [Wed, 16 Dec 2020 01:18:09 +0000 (01:18 +0000)]
virgl: fix BGRA emulation artifacts during window resize

On some devices, window resizing results in flashes of blue- and
orange-tinted versions of the current frame until resizing is
finished.

This fix ensures that the emubgra tweak used for GLES virgl hosts
has its enabled state flag set properly during resize events.

v2: removed unrelated whitespace change

Fixes: 6f68cacf619 ("virgl: Always enable emulated BGRA and swizzling unless specifically told not to")
Signed-off-by: Ryan Neph <ryanneph@google.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8119>

3 years agosvga: Fix typos in comments.
Vinson Lee [Sun, 6 Dec 2020 06:01:35 +0000 (22:01 -0800)]
svga: Fix typos in comments.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7943>

3 years agomicrosoft/clc: Hook up printf
Jesse Natalie [Wed, 18 Nov 2020 20:22:27 +0000 (12:22 -0800)]
microsoft/clc: Hook up printf

Rewrites the original lowering pass to use the one shared with Clover,
instead only handling the new load_printf_buffer_address intrinsic.

Exports the new metadata to the runtime containing strings and arg sizes.

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agoclover/nir: hookup printf (v3)
Dave Airlie [Wed, 28 Oct 2020 01:46:49 +0000 (11:46 +1000)]
clover/nir: hookup printf (v3)

This connects printf up for NIR drivers, it lowers using the NIR
pass where it places the idx to the strings into the output buffer.

It also sets the global buffer header to the nir paths.

v2: remove dead function temps after lowering

v3: move to single string

Acked-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agonir: Add an algebraic optimization for float->double->float
Jesse Natalie [Mon, 22 Jun 2020 15:12:54 +0000 (08:12 -0700)]
nir: Add an algebraic optimization for float->double->float

As part of this series, it removes the need for float->double conversion,
just to be able to print a single float.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agonir: Add a printf lowering pass (v5)
Jesse Natalie [Fri, 14 Aug 2020 00:21:18 +0000 (17:21 -0700)]
nir: Add a printf lowering pass (v5)

This pass creates a SSBO var for the printf buffer. It does an atomic increment
at the beginning of the buffer to determine where to write, then dumps
the args after that.

v2: [airlied]
Enhanced to use an index into a set of format info that is passed
back to the caller. The format info contains the number of args,
argument sizes and the format string.

v3: move format string lowering to vtn

v4: Jason reworked it.

v5: assume buffer has initial offset prebaked in and work from there.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agonir/vtn: Implement printf opcode in terms of intrinsic (v9)
Jesse Natalie [Sun, 21 Jun 2020 21:36:00 +0000 (14:36 -0700)]
nir/vtn: Implement printf opcode in terms of intrinsic (v9)

[airlied: rebase fixup types]

v2: add support for storing strings in a sideband storage,
just store the index in print buffer.

v3: move the format strings into the nir shader as well

v4: simplify the write constant string + explicit sizes
move printf cap definition.

v5: just parse the format string to find string specifiers
using util code.
add vtn_fail_if if we can't get the correct type.

v6: use ralloc + avoid instr handler for srcs > 5

v7: use a packed struct 4 bytes align all of it

v8: simplify constant copy

v9: rework to use a single string and common string
extract code, (Jason)

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agonir: Add intrinsic and string ptrs
Jesse Natalie [Sun, 21 Jun 2020 21:35:29 +0000 (14:35 -0700)]
nir: Add intrinsic and string ptrs

This just adds the basic nir support for printf,
intrinsic, and support for storing the printf info.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agoclover: add core clover printf support (v12)
Serge Martin [Thu, 29 Oct 2020 00:05:45 +0000 (10:05 +1000)]
clover: add core clover printf support (v12)

"The implementation is based on what LLVM AMD target expect.
The compiler provided an id link to argument desc and format used.
The runtime need to store them to be able to parse the buffer filled by
the device during the kernel execution, ie, an id value to find the
format and followed by the arguments values"

v2: airlied
Split out the core code to a separate patch, add support for the
different global buffer formats, and move the LLVM specific code
as much as possible to the backend.

v3: handle strings differences better
llvm backend stores strings to the printf buffer
nir backend stores them to a sideband storage in NIR and stores
an index in the buffer.

v4: move specifier parsing to util code.

v5: rename buffer fmt + make printf code work

v6: handle args/specifier number mismatch support

v7: move to single string + struct

v8: use "%s" to print strings to avoid bad specifier, fix str
calcs.

v9: move to the same global buffer format as llvm, just strings
are different now. This requires changes to nir lowering.
buffer format:
[0] contains offset into buffer at start contains 8
[1] contains length of buffer

v10: printf const clean,  add warning,  endian assert, print %%
at end, fix specifiers to vector

v11: minor cleanups, make sure the format string never contains
an n.

v12: validate format string

Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agoclover/module: add a printf support to module (v5)
Dave Airlie [Wed, 28 Oct 2020 21:15:02 +0000 (07:15 +1000)]
clover/module: add a printf support to module (v5)

This adds storage for printf formats encoded as number of
argument sizes + the printf format string, and storage
for sideband printf strings if the backend wants them.

It adds a flag that decides if the backend wants AMD (LLVM)
behaviour or NIR wrt the format of the global buffer and
how to decode strings.

Based on work by EdB in his printf support, but made useful
to be generic.

I'm not a huge fan of the buffer format flag, but this was
the easiest way to denote the llvm abi buffer format.

v3: rename buffer fmt

v4: use a single strings storage and one struct

v5: move printf_info into module, cleanup serialisation struct

Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agoutil: add printf specifier shared helper code.
Dave Airlie [Wed, 18 Nov 2020 06:20:50 +0000 (16:20 +1000)]
util: add printf specifier shared helper code.

clover needs to walk valid specifiers in C++, vtn needs
to find string specifiers in C, let's do both.

This writes the format walker in C++, and wraps it with C.

Acked-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8254>

3 years agopanfrost: Fix discard behaviour on Bifrost
Icecream95 [Wed, 23 Dec 2020 10:30:24 +0000 (23:30 +1300)]
panfrost: Fix discard behaviour on Bifrost

Set zs_update_operation to FORCE_LATE, as we don't want to update
depth if the fragment is discarded.

Set pixel_kill_operation to WEAK_EARLY to match the blob.

Reviewed-and-tested-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8235>

3 years agozink: add support for VK_EXT_4444_formats
Hoe Hao Cheng [Sat, 26 Dec 2020 17:43:52 +0000 (01:43 +0800)]
zink: add support for VK_EXT_4444_formats

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8240>

3 years agozink: fix more instance detection stuff
Mike Blumenkrantz [Mon, 28 Dec 2020 20:26:09 +0000 (15:26 -0500)]
zink: fix more instance detection stuff

this was broken during the transition to generated code

Fixes: fe669ff4a02 ("zink: replace old code with generated zink_instance")

Reviewed-by: Hoe Hao Cheng <haochengho12907@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8250>

3 years agofreedreno/ir3: remap FRAG_RESULT_COLOR to _DATA* for dual-src blending
Danylo Piliaiev [Mon, 28 Dec 2020 13:53:08 +0000 (15:53 +0200)]
freedreno/ir3: remap FRAG_RESULT_COLOR to _DATA* for dual-src blending

gl_SecondaryFragColorEXT is mapped to FRAG_RESULT_COLOR and just
have a different io.dual_source_blend_index. We don't need to replicate
the color to other render targets in case of dual source blending, so
we could just remap it to FRAG_RESULT_DATA0 + index.

Fixes piglit test:
 arb_blend_func_extended-fbo-extended-blend-pattern_gles2

Signed-off-by: Danylo Piliaiev <dpiliaiev@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8245>

3 years agoci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.
Eric Anholt [Fri, 18 Dec 2020 17:48:46 +0000 (09:48 -0800)]
ci/deqp: Fix inverted meaning of DEQP_NO_SAVE_RESULTS.

When set, we want to summary-limit 0, but the meaning was inverted.  Sigh,
coding in bash.

Fixes: bf29daa1b5a3 ("ci/deqp: Switch to a new dEQP runner written in Rust.")
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8164>

3 years agoandroid: pan/bi: Generate bi_opcodes.{c,h}
Mauro Rossi [Sat, 26 Dec 2020 13:02:13 +0000 (14:02 +0100)]
android: pan/bi: Generate bi_opcodes.{c,h}

Porting of commits 25c9946883ce and f9084b6c3f13 to Android makefile

Fixes the following building error:

In file included from external/mesa/src/panfrost/bifrost/bifrost_compile.c:36:
external/mesa/src/panfrost/bifrost/compiler.h:31:10: fatal error: 'bi_opcodes.h' file not found
         ^~~~~~~~~~~~~~
1 error generated.

Fixes: 25c9946883ce ("pan/bi: Generate bi_opcodes.c")
Fixes: f9084b6c3f13 ("pan/bi: Generate bi_opcodes.h")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8239>

3 years agoandroid: pan/bi: Add explicit dependency on the ISA helpers
Mauro Rossi [Sat, 26 Dec 2020 12:58:06 +0000 (13:58 +0100)]
android: pan/bi: Add explicit dependency on the ISA helpers

Porting of commit 4d76a3d4a19b to Android makefile

Fixes: 4d76a3d4a19b ("pan/bi: Add explicit meson dependency on the ISA helpers")
Signed-off-by: Mauro Rossi <issor.oruam@gmail.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8239>

3 years agor600/sfn: merge SpecialValue and InlineConstValue
Gert Wollny [Wed, 23 Dec 2020 14:25:23 +0000 (15:25 +0100)]
r600/sfn: merge SpecialValue and InlineConstValue

The latter is the only child class of the former and no other use for
SpecialValue is needed.

Signed-off-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8210>

3 years agomesa: glProgramBinary add resource_hash
cheyang [Fri, 25 Dec 2020 08:20:43 +0000 (16:20 +0800)]
mesa: glProgramBinary add resource_hash

reduce search time(E.g glGetUniformLocation) when use glProgramBinary

Signed-off-by: cheyang <cheyang@bytedance.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8238>

3 years agovirgl: next_handle variable modify to atomic inc in virgl_object_assign_handle
cheyang [Sun, 13 Dec 2020 03:52:02 +0000 (11:52 +0800)]
virgl: next_handle variable modify to atomic inc in virgl_object_assign_handle

virgl_object_assign_handle will be called by multiple threads,
if you do not use atomic operations, there may be duplicate handle.

Signed-off-by: cheyang <cheyang@bytedance.com>
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8078>

3 years agogallium/ntt: Fix check for "is there anything in the else block?"
Eric Anholt [Tue, 22 Dec 2020 20:18:28 +0000 (12:18 -0800)]
gallium/ntt: Fix check for "is there anything in the else block?"

The cf list will always be non-empty, with at least a block in it.
Noticed while checking codegen of a piglit test that was really slow on
softpipe.

Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>

3 years agoci/softpipe: Include a piglit run.
Eric Anholt [Fri, 11 Dec 2020 18:43:15 +0000 (10:43 -0800)]
ci/softpipe: Include a piglit run.

It's been regressed a couple of times recently, so let's try to make sure
it doesn't happen again.  The setup here is mostly like llvmpipe-quick-gl,
but using quick_gl+quick_shader together, and a few more spectacularly
long-running tests dropped.  I also excluded a bunch of unsupported
extensions, to minimize the size of the skip list checked into the tree
(it's still 200k, though).

The unfortunate exclusions in here are fp64 and int64 -- most of the
piglit tests for them don't run because softpipe is still GL3.3, and it's
an egregious number of skips to add to the checked in list.

Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>

3 years agoci/piglit: Include the updated piglit results list in the job results.
Eric Anholt [Fri, 11 Dec 2020 18:40:57 +0000 (10:40 -0800)]
ci/piglit: Include the updated piglit results list in the job results.

If you're standing up a new piglit CI, you're going to want it.

Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>

3 years agosoftpipe: Enable GLSL 400 for compat contexts too.
Eric Anholt [Fri, 11 Dec 2020 23:47:11 +0000 (15:47 -0800)]
softpipe: Enable GLSL 400 for compat contexts too.

This bumps the compat profile supported from 3.1 to 3.3, matching our GL
core profile.  Motivated by getting the piglit skip list cut down.

Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8068>

3 years agoturnip: Remove unsigned nonnegative check.
Vinson Lee [Thu, 24 Dec 2020 21:59:36 +0000 (13:59 -0800)]
turnip: Remove unsigned nonnegative check.

index is of type uint32_t.

Fix defect reported by Coverity Scan.

Macro compares unsigned to 0 (NO_EFFECT)
unsigned_compare: This greater-than-or-equal-to-zero comparison of
an unsigned value is always true. index >= 0U.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8231>

3 years agod3d12: Initialize TransitionableResourceState m_SupportsSimultaneousAccess.
Vinson Lee [Tue, 22 Dec 2020 01:26:56 +0000 (17:26 -0800)]
d3d12: Initialize TransitionableResourceState m_SupportsSimultaneousAccess.

Fix defect reported by Coverity Scan.

Uninitialized scalar field (UNINIT_CTOR)
uninit_member: Non-static class member m_SupportsSimultaneousAccess is
not initialized in this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8192>

3 years agod3d12: Fix memory leak if state is NULL.
Vinson Lee [Sun, 20 Dec 2020 23:44:20 +0000 (15:44 -0800)]
d3d12: Fix memory leak if state is NULL.

Fix defect reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable ss going out of scope leaks the storage it points to.

Fixes: 2ea15cd661c ("d3d12: introduce d3d12 gallium driver")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8179>

3 years agonir/tests: Initialize nir_serialize_test member dup.
Vinson Lee [Fri, 18 Dec 2020 22:08:58 +0000 (14:08 -0800)]
nir/tests: Initialize nir_serialize_test member dup.

Fix defect reported by Coverity Scan.

Uninitialized pointer field (UNINIT_CTOR)
uninit_member: Non-static class member dup is not initialized in
this constructor nor in any functions that it calls.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8168>

3 years agozink: handle 0 as valid pipeline hash value
Mike Blumenkrantz [Mon, 21 Dec 2020 14:24:20 +0000 (09:24 -0500)]
zink: handle 0 as valid pipeline hash value

xxhash can return 0 as a valid hash so it needs to be handled

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8201>

3 years agozink: handle null ubos
Mike Blumenkrantz [Thu, 15 Oct 2020 15:20:20 +0000 (11:20 -0400)]
zink: handle null ubos

for drivers that don't support robustness features (nullDescriptor)
we can just jam in the dummy buffer here and yolo

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8202>

3 years agoRevert "radv: use 32-bit predication for skipping FCE on GFX10.3+"
Samuel Pitoiset [Wed, 23 Dec 2020 17:03:13 +0000 (18:03 +0100)]
Revert "radv: use 32-bit predication for skipping FCE on GFX10.3+"

This is actually wrong because we still assume 64-bit in a bunch
of places.

This reverts commit b24b3026cc0541c59613463a124b16954b2a7cd8.

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8214>

3 years agov3d: Fix typos.
Vinson Lee [Fri, 18 Dec 2020 22:52:00 +0000 (14:52 -0800)]
v3d: Fix typos.

Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8171>

3 years agozink: fix debug utils init
Mike Blumenkrantz [Thu, 24 Dec 2020 00:15:38 +0000 (19:15 -0500)]
zink: fix debug utils init

this was moved to a different struct without being updated

Fixes: fe669ff4a02 ("zink: replace old code with generated zink_instance")

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8220>

3 years agogallivm: Use the proper enum for the texture target bitfield.
Eric Anholt [Wed, 16 Dec 2020 18:47:06 +0000 (10:47 -0800)]
gallivm: Use the proper enum for the texture target bitfield.

This gets you nice output in gdb when trying to figure out why your 2D
sample shader is hitting the cube paths.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>

3 years agost/mesa: Generate NIR for ATI_fragment_shader instead of TGSI.
Eric Anholt [Mon, 24 Aug 2020 20:07:35 +0000 (13:07 -0700)]
st/mesa: Generate NIR for ATI_fragment_shader instead of TGSI.

Compiling NIR is much less code, gives us optimization across drivers, and
is one less chunk of TGSI in the mesa frontend.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>

3 years agomesa/ati_fs: Clean up writemask handling.
Eric Anholt [Mon, 24 Aug 2020 20:50:45 +0000 (13:50 -0700)]
mesa/ati_fs: Clean up writemask handling.

Just put it into the op in core Mesa and explain what it's doing.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>

3 years agomesa/prog_to_nir: Factor out the texture-target-to-sampler-dim helper.
Eric Anholt [Fri, 11 Dec 2020 01:20:12 +0000 (17:20 -0800)]
mesa/prog_to_nir: Factor out the texture-target-to-sampler-dim helper.

I'll be using this switch statement and extending it for
ATI_fragment_shader.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>

3 years agomesa/st: Update FP state when textures change with an ATI_fs bound.
Eric Anholt [Wed, 16 Dec 2020 19:03:17 +0000 (11:03 -0800)]
mesa/st: Update FP state when textures change with an ATI_fs bound.

We may have to make a new ATI_fs variant when the texture target changes.
Fixes a regression on piglit ati_fragment_shader-render-textargets on
llvmpipe after the switch to NIR ATI_fragment_shader.

Cc: mesa-stable
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8118>

3 years agoradeon/vcn: fix hevc 10bit profile error
Ruijing Dong [Thu, 3 Dec 2020 20:34:56 +0000 (15:34 -0500)]
radeon/vcn: fix hevc 10bit profile error

hevc main10 profile error fix

CC: mesa-stable
Signed-off-by: Ruijing Dong <Ruijing.Dong@amd.com>
Reviewed-by: Leo Liu <leo.liu@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8038>

3 years agolavapipe: add basic vulkan device group support.
Dave Airlie [Fri, 18 Dec 2020 02:29:59 +0000 (12:29 +1000)]
lavapipe: add basic vulkan device group support.

This just add the basic for vulkan device group support, base
dispatch, and dummy funcs

Reviewed-by: Adam Jackson <ajax@redhat.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviweed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8154>

3 years agollvmpipe: enable lower device id to zero
Dave Airlie [Fri, 18 Dec 2020 02:29:27 +0000 (12:29 +1000)]
llvmpipe: enable lower device id to zero

this is to support vulkan device group

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviweed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8154>

3 years agollvmpipe: add support for grid base
Dave Airlie [Fri, 18 Dec 2020 02:29:03 +0000 (12:29 +1000)]
llvmpipe: add support for grid base

This adds the grid base into the compute launch

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviweed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8154>

3 years agogallium: add grid base to dispatch info
Dave Airlie [Fri, 18 Dec 2020 02:28:20 +0000 (12:28 +1000)]
gallium: add grid base to dispatch info

Vulkan device group support allows launching grids from
a grid base set of values. Add the interface for gallium

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviweed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8154>

3 years agozink: zero VkMemoryRequirements on init
Mike Blumenkrantz [Wed, 23 Dec 2020 20:36:50 +0000 (15:36 -0500)]
zink: zero VkMemoryRequirements on init

ensure no part of this is uninitialized just to be safe

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8217>

3 years agoci/deqp: Move the load reporting to a quiet block.
Eric Anholt [Mon, 21 Dec 2020 19:25:10 +0000 (11:25 -0800)]
ci/deqp: Move the load reporting to a quiet block.

No need for debug printing of how we computed it any more, brings the deqp
failures more into highlight in the job log.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>

3 years agoci/deqp: Upgrade the runner, enable junit output.
Eric Anholt [Sat, 19 Dec 2020 00:47:51 +0000 (16:47 -0800)]
ci/deqp: Upgrade the runner, enable junit output.

I moved QPA-to-XML conversion to the runner, so Mesa CI (and developers!)
don't need to do quite so much in bash.  I also made it clean up caselist
.qpa files since nobody ever wants them and we deleted them anyway.  This
cleans up a ton of the job log output.

Additionally, I added a subcommend to turn the .csv into a junit output
that we can expose to gitlab.  Now, the pipeline's status page will report
the failed testcases, and the "detail" button will give you a link to the
.XML to view for the failure.  (We don't report all testcases because it's
too much load for the gitlab server).  Note that this will 404 for the
LAVA runners for now, as they don't retain artifacts in gitlab (the plan
is to eventually have them minio upload the artifacts).

This uprev also includes a deqp output parsing fix, resulting in us
catching a couple more failures in some drivers.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>

3 years agoci/deqp: Move .shader_cache artifacts exclusion to the yml.
Eric Anholt [Mon, 21 Dec 2020 18:55:40 +0000 (10:55 -0800)]
ci/deqp: Move .shader_cache artifacts exclusion to the yml.

Less noise in the job log when we want to be highlighting deqp-runner's
output.

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>

3 years agoci: Disable the now flaky Portals.trace on a630.
Eric Anholt [Wed, 23 Dec 2020 20:03:40 +0000 (12:03 -0800)]
ci: Disable the now flaky Portals.trace on a630.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8206>

3 years agomesa/st: Fix use-after-free of the draw VS.
Eric Anholt [Wed, 23 Dec 2020 00:42:49 +0000 (16:42 -0800)]
mesa/st: Fix use-after-free of the draw VS.

If the program with a draw variant gets deleted, it could leave a dangling
pointer in st's draw module that would get referenced next state update of
a draw fallback.

Fixes a valgrind complaint in piglit's rasterpos test, which is flaky on
softpipe (but not due to this).

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8207>

3 years agosoftpipe: count CS invocations for pipeline stats queries.
Eric Anholt [Fri, 11 Dec 2020 20:39:22 +0000 (12:39 -0800)]
softpipe: count CS invocations for pipeline stats queries.

Part of fixing KHR-GL33.pipeline_statistics_query_tests_ARB.
  functional_compute_shader_invocations

(also requires a test bugfix:
https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/2694).

Fixes: e749c30cebe0 ("softpipe: add support for compute shaders. (v2)")
Reviewed-by: Gert Wollny <gert.wollny@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8065>

3 years agopan/bi: Add builder data structure
Alyssa Rosenzweig [Fri, 27 Nov 2020 23:56:11 +0000 (18:56 -0500)]
pan/bi: Add builder data structure

In preparation for builder routines.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add cursor data structures
Alyssa Rosenzweig [Fri, 27 Nov 2020 23:54:49 +0000 (18:54 -0500)]
pan/bi: Add cursor data structures

To be used in conjunction with the builder.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add new bi_instr data structure
Alyssa Rosenzweig [Fri, 27 Nov 2020 19:23:32 +0000 (14:23 -0500)]
pan/bi: Add new bi_instr data structure

This models instructions closer to the hardware. We'll deduplicate by
the end of the series, but for now this will allow us to add routines
operating on bi_instr without regressing existing users of
bi_instruction.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_{abs, neg} helpers
Alyssa Rosenzweig [Mon, 21 Dec 2020 22:00:50 +0000 (17:00 -0500)]
pan/bi: Add bi_{abs, neg} helpers

Just conveniences.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_imm_u{8, 16} helpers
Alyssa Rosenzweig [Mon, 21 Dec 2020 22:12:02 +0000 (17:12 -0500)]
pan/bi: Add bi_imm_u{8, 16} helpers

Common compositions which make building for <32-bit types easier.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add imm_f32 helper
Alyssa Rosenzweig [Wed, 16 Dec 2020 15:28:17 +0000 (10:28 -0500)]
pan/bi: Add imm_f32 helper

Pattern comes up surprisingly often.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_half and bi_byte selectors
Alyssa Rosenzweig [Mon, 21 Dec 2020 22:11:36 +0000 (17:11 -0500)]
pan/bi: Add bi_half and bi_byte selectors

Useful for extracting out part of an index, internally implemented via a
subword swizzle.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add node_to_index helper
Alyssa Rosenzweig [Wed, 16 Dec 2020 17:56:45 +0000 (12:56 -0500)]
pan/bi: Add node_to_index helper

To invert index_to_node for RA.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add a helper to convert to old-style nodes
Alyssa Rosenzweig [Sat, 12 Dec 2020 01:03:46 +0000 (20:03 -0500)]
pan/bi: Add a helper to convert to old-style nodes

RA, DCE, and liveness assume that SSA and non-SSA normal indices are
indexed from 1 in a shared address space, with a maximum given by
bi_max_temp. As a stop gap, let's translate bi_index to old style
node numbers so those passes can be updated cleanly.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add helpers to generate bi_index from NIR
Alyssa Rosenzweig [Sat, 12 Dec 2020 01:03:02 +0000 (20:03 -0500)]
pan/bi: Add helpers to generate bi_index from NIR

Corresponding to the existing pan_{...}_index helpers, except returning
a new-style index instead.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_temp{_reg} for new-style bi_index
Alyssa Rosenzweig [Sat, 12 Dec 2020 01:02:25 +0000 (20:02 -0500)]
pan/bi: Add bi_temp{_reg} for new-style bi_index

Variant of bi_make_temp{_reg} returning a bi_index.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add helper to extract a word from an index
Alyssa Rosenzweig [Mon, 14 Dec 2020 21:19:15 +0000 (16:19 -0500)]
pan/bi: Add helper to extract a word from an index

This pattern comes up surprisingly often due to the prevalance of
vectors.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add nullity/equality helpers for bi_index
Alyssa Rosenzweig [Sat, 12 Dec 2020 01:01:38 +0000 (20:01 -0500)]
pan/bi: Add nullity/equality helpers for bi_index

We can no longer use the builtin equals, since they're structs now, but
these helpers are almost as convenient.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_index constructors
Alyssa Rosenzweig [Sat, 12 Dec 2020 01:00:28 +0000 (20:00 -0500)]
pan/bi: Add bi_index constructors

These add succinct helpers to generate well-formed references.

Note for semantic that bi_zero represents the immediate value #0, while
bi_null represents a value that does not exist ("undefined").

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_index data structure
Alyssa Rosenzweig [Sat, 12 Dec 2020 00:57:39 +0000 (19:57 -0500)]
pan/bi: Add bi_index data structure

Rather than open-coding indices with manual bit packing flying around,
let's add a data structure corresponding to a reference to some data.
(Think nir_src, ibc_ref, etc). In particular this allows us to pack in
more metadata, like an offset, for properly supporting limited vectors
(for I/O) without bloating the IR with swizzle fields.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Add bi_swizzle enum
Alyssa Rosenzweig [Mon, 21 Dec 2020 22:10:10 +0000 (17:10 -0500)]
pan/bi: Add bi_swizzle enum

We need to represent subword swizzles at a somewhat higher level than
the hardware.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Make BIR_INDEX_ZERO less special
Alyssa Rosenzweig [Fri, 27 Nov 2020 20:43:14 +0000 (15:43 -0500)]
pan/bi: Make BIR_INDEX_ZERO less special

It can be implemented as a constant that just shifts beyond the 64-bits
available for the instruction, and then we can avoid special handling in
a bunch of places.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Remove BIR_INDEX_UNIFORM
Alyssa Rosenzweig [Fri, 27 Nov 2020 20:36:39 +0000 (15:36 -0500)]
pan/bi: Remove BIR_INDEX_UNIFORM

It too is a special case of BIR_INDEX_FAU, although its printing is
special-cased for readability.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Merge BIR_INDEX_FAU and BIR_INDEX_BLEND
Alyssa Rosenzweig [Fri, 27 Nov 2020 20:31:28 +0000 (15:31 -0500)]
pan/bi: Merge BIR_INDEX_FAU and BIR_INDEX_BLEND

There's no reason to separate these, and it's more convenient not to.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Generate bi_opcodes.c
Alyssa Rosenzweig [Wed, 23 Dec 2020 17:29:34 +0000 (12:29 -0500)]
pan/bi: Generate bi_opcodes.c

So we can lookup various properties rather than generating piles of
switch statements.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Use autogenerated modifiers
Alyssa Rosenzweig [Wed, 23 Dec 2020 17:29:08 +0000 (12:29 -0500)]
pan/bi: Use autogenerated modifiers

Step in the right direction to deduplicate.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Generate bi_opcodes.h
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:51:00 +0000 (13:51 -0500)]
pan/bi: Generate bi_opcodes.h

A header for enums for each opcode and each modifier.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Move modifier prints out of common code
Alyssa Rosenzweig [Fri, 27 Nov 2020 23:37:19 +0000 (18:37 -0500)]
pan/bi: Move modifier prints out of common code

These will get in the way of what we want and aren't used by the
disassembler.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agopan/bi: Remove reference to 64-bit RA
Alyssa Rosenzweig [Wed, 9 Dec 2020 19:59:34 +0000 (14:59 -0500)]
pan/bi: Remove reference to 64-bit RA

Not something we plan to ever support on Bifrost. v7 needs 64-bit
lowered at the NIR level. The support for 64-bit clauses on v6 is iffy
and not worth worrying about at this point.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8215>

3 years agozink: document some more features for higher GL versions
Erik Faye-Lund [Wed, 23 Dec 2020 16:05:33 +0000 (17:05 +0100)]
zink: document some more features for higher GL versions

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8212>

3 years agopan/bi: Add helpers for manipulating the ISA
Alyssa Rosenzweig [Wed, 23 Dec 2020 16:38:06 +0000 (11:38 -0500)]
pan/bi: Add helpers for manipulating the ISA

These will be used to generate various files for the IR.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Move copyright notice to common code
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:46:45 +0000 (13:46 -0500)]
pan/bi: Move copyright notice to common code

No reason to duplicate this all over the place.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Add explicit meson dependency on the ISA helpers
Alyssa Rosenzweig [Tue, 8 Dec 2020 00:58:22 +0000 (19:58 -0500)]
pan/bi: Add explicit meson dependency on the ISA helpers

This logic was slightly busted before.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Rename isa_parse to bifrost_isa
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:24:53 +0000 (13:24 -0500)]
pan/bi: Rename isa_parse to bifrost_isa

We use this for non-parsing code as well. Make the name clear.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Add pseudo register formats to XML
Alyssa Rosenzweig [Wed, 16 Dec 2020 18:09:50 +0000 (13:09 -0500)]
pan/bi: Add pseudo register formats to XML

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Add staging register counts to ISA.xml
Alyssa Rosenzweig [Wed, 23 Dec 2020 16:30:17 +0000 (11:30 -0500)]
pan/bi: Add staging register counts to ISA.xml

Message-passing instructions that read/write staging registers access
either:

* a fixed number of registers
* vecsize registers (/2 for LD/ST_CVT if register_format is 16-bit)
* a computed number for TEXC

This adds the fixed counts into the XML for the first type and space to
specify the latter types.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Fix rounding name for HADD in XML
Alyssa Rosenzweig [Thu, 10 Dec 2020 20:19:35 +0000 (15:19 -0500)]
pan/bi: Fix rounding name for HADD in XML

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Mark message types in ISA.xml
Alyssa Rosenzweig [Wed, 9 Dec 2020 19:55:05 +0000 (14:55 -0500)]
pan/bi: Mark message types in ISA.xml

Message-passing instructions have an associated message type, which the
clause header needs to signal. Instead of open coding this, let's
annotate the XML. Instructions not otherwise marked do not generate
messages.

Three exceptions apply:

* UBO loads need to use the attribute message type.
* Tile buffer access to Z/S needs ZS message type
* LD_VAR_SPECIAL.fragz needs ZS message type

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use consistent neg naming
Alyssa Rosenzweig [Sat, 28 Nov 2020 00:16:17 +0000 (19:16 -0500)]
pan/bi: Use consistent neg naming

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical inactive result
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:31:49 +0000 (13:31 -0500)]
pan/bi: Use canonical inactive result

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical subgroup size
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:31:13 +0000 (13:31 -0500)]
pan/bi: Use canonical subgroup size

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical lane ops
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:30:01 +0000 (13:30 -0500)]
pan/bi: Use canonical lane ops

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical name for segments
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:28:33 +0000 (13:28 -0500)]
pan/bi: Use canonical name for segments

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical min/max semantics
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:47:28 +0000 (10:47 -0500)]
pan/bi: Use canonical min/max semantics

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical update modes
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:44:25 +0000 (10:44 -0500)]
pan/bi: Use canonical update modes

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical sample names
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:43:06 +0000 (10:43 -0500)]
pan/bi: Use canonical sample names

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical varying names
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:41:47 +0000 (10:41 -0500)]
pan/bi: Use canonical varying names

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical names for rounding modes
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:37:33 +0000 (10:37 -0500)]
pan/bi: Use canonical names for rounding modes

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use canonical names for clamps
Alyssa Rosenzweig [Fri, 27 Nov 2020 15:33:19 +0000 (10:33 -0500)]
pan/bi: Use canonical names for clamps

Prepare to generate this enum by correctly naming the open-coded
variant.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Don't treat extend as per-source
Alyssa Rosenzweig [Fri, 27 Nov 2020 19:59:12 +0000 (14:59 -0500)]
pan/bi: Don't treat extend as per-source

There is only one per instruction so it just complicates things.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use consistent naming of lane/lane0
Alyssa Rosenzweig [Fri, 27 Nov 2020 19:48:44 +0000 (14:48 -0500)]
pan/bi: Use consistent naming of lane/lane0

It's always a source modifier.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use consistent wls naming
Alyssa Rosenzweig [Fri, 27 Nov 2020 18:53:28 +0000 (13:53 -0500)]
pan/bi: Use consistent wls naming

Compare naming in the data structures.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>

3 years agopan/bi: Use consistent negX/absX naming
Alyssa Rosenzweig [Thu, 26 Nov 2020 23:07:52 +0000 (18:07 -0500)]
pan/bi: Use consistent negX/absX naming

We already use plain neg/abs for this, don't mix it. Will avoid weird
enums for abs/neg with a generated IR.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8213>