Sergey Andreenko [Tue, 12 Sep 2017 20:11:29 +0000 (13:11 -0700)]
fix stack depth in DevDiv_278523 test source code(#13912)
Mike McLaughlin [Tue, 12 Sep 2017 19:41:14 +0000 (12:41 -0700)]
Fix core dump generation on Centos. (#13887)
Fix core dump generation on Centos.
Issue #13764
Michelle McDaniel [Tue, 12 Sep 2017 18:02:12 +0000 (11:02 -0700)]
Merge pull request #13918 from adiaaida/unifyPerfConfigs
Add OptLevel and JitName configurations
Carol Eidt [Tue, 12 Sep 2017 17:26:49 +0000 (10:26 -0700)]
Merge pull request #13715 from CarolEidt/LsraInfoInLsra
Do TreeNodeInfoInit in buildIntervals
Michelle McDaniel [Tue, 12 Sep 2017 16:56:30 +0000 (09:56 -0700)]
Add OptLevel and JitName configurations
To unify the configuration names in benchview, add OptLevel and JitName
configurations in run-xunit-perf.sh. This change does not add min_opts
to perf.groovy.
Viktor Hofer [Tue, 12 Sep 2017 16:45:42 +0000 (18:45 +0200)]
Merge pull request #13242 from ViktorHofer/BinarySerializationCleanup
Binary serialization unused methods and attributes cleanup and misc code cleanup
José Rivero [Tue, 12 Sep 2017 15:15:37 +0000 (08:15 -0700)]
Fixing archiving of Linux perf artifacts. (#13911)
- Previous change did not fix archiving artifacts
Viktor Hofer [Tue, 12 Sep 2017 09:09:40 +0000 (11:09 +0200)]
ResourceSet
Viktor Hofer [Thu, 7 Sep 2017 19:21:45 +0000 (21:21 +0200)]
TextInfo
Viktor Hofer [Thu, 7 Sep 2017 17:28:18 +0000 (19:28 +0200)]
Reflection
Viktor Hofer [Thu, 24 Aug 2017 16:29:57 +0000 (18:29 +0200)]
IO
Konstantin Baladurin [Tue, 12 Sep 2017 10:44:24 +0000 (13:44 +0300)]
[GDBJIT] Specify C# language in DWARF debug information (#13720)
* [GDBJIT] Specify C# language in DWARF debug information
To correctly support C# language in lldb DWARF debug information
should contain correct information about language.
Now we use 0x9e57 constant for specify C# language.
* [GDBJIT] Introduce FEATURE_GDBJIT_LANGID_CS
If this feature is set gdbjit will use 0x9e57 as c# lang id,
otherwise it will use DW_LANG_C89.
Stephen Toub [Tue, 12 Sep 2017 06:49:53 +0000 (23:49 -0700)]
Merge pull request #13907 from stephentoub/valuetask_astask_caching
Use AsyncTaskCache in ValueTask.AsTask()
dotnet bot [Tue, 12 Sep 2017 02:54:33 +0000 (19:54 -0700)]
Merge changes from TFS (#13884)
Add new GetMethodNameFromMetadata interface member to ILGEN.
Also fix warning in the build.
[tfs-changeset: 1673078]
[Hand edited to fix break in SPMI]
Stephen Toub [Mon, 11 Sep 2017 21:40:57 +0000 (14:40 -0700)]
Use AsyncTaskCache in ValueTask.AsTask()
We can avoid task allocations for common values by using the same task cache that async methods do. This is important to avoid allocations in certain cases when switching from Task-returning to ValueTask-returning methods. If at some point we change Task.FromResult to use the same cache, this can be reverted.
William Godbe [Mon, 11 Sep 2017 18:49:57 +0000 (11:49 -0700)]
Merge pull request #13875 from wtgodbe/RevertLabel
Revert PreReleaseLabel to preview1
Andy Ayers [Mon, 11 Sep 2017 18:12:45 +0000 (11:12 -0700)]
JIT: optimize Enum.HasFlag (#13748)
Check for calls to `Enum.HasFlag` using the new named intrinsic support
introduced in #13815. Implement a simple recognizer for these named
intrinsics (currently just recognizing `Enum.HasFlag`).
When the call is recognized, optimize if both operands are boxes with
compatible types and both boxes can be removed. The optimization changes the
call to a simple and/compare tree on the underlying enum values.
To accomplish this, generalize the behavior of `gtTryRemoveBoxUpstreamEffects`
to add a "trial removal" mode and to optionally suppress narrowing of the
copy source.
Invoke the optimization during importation (which will catch most cases) and
again during morph (to get the post-inline cases).
Added test cases. Suprisingly there were almost no uses of HasFlag in the
current CoreCLR test suite.
Closes #5626.
Konstantin Baladurin [Mon, 11 Sep 2017 17:23:16 +0000 (20:23 +0300)]
[GDBJIT] Fix calculation of debuginfo's size. (#13899)
Information about each type is dumped once but during debuginfo's
size calculation it was taken into account several time. Due to it
size of debuginfo section could be in several times bigger than
needed that in some cases leaded to OOM.
Eric Erhardt [Mon, 11 Sep 2017 16:30:56 +0000 (11:30 -0500)]
Merge pull request #13876 from eerhardt/UpdateBuildTools
Update BuildTools automatically when new versions are available.
José Rivero [Mon, 11 Sep 2017 16:10:02 +0000 (09:10 -0700)]
Ubuntu runs are not archiving perf results because rsync does not create destination folder (#13858)
Eric Erhardt [Mon, 11 Sep 2017 14:52:39 +0000 (09:52 -0500)]
Merge branch 'master' into UpdateBuildTools
Alfred Myers [Mon, 11 Sep 2017 14:51:58 +0000 (11:51 -0300)]
fixed minor typo (#13898)
Konstantin Baladurin [Mon, 11 Sep 2017 14:48:01 +0000 (17:48 +0300)]
Fix building of rootfs for Tizen armel (#13854)
Now there isn't arm buildtarget in tizen-base repository.
Use standard one to fetch packages for rootfs.
Kevin Gosse [Mon, 11 Sep 2017 14:14:11 +0000 (16:14 +0200)]
Make order of elements consistent (#13892)
When the cache is only partially populated, MemberInfoCache.Insert will
insert the new members into the cache. But then, it will return the
original list. In subsequent calls, it will return the cached list.
However, the order of elements can be different, which can cause issues
with methods that rely on the order of elements returned by
Type.GetFields (for instance, Attribute.GetHashCode)
Stephen Toub [Mon, 11 Sep 2017 14:09:31 +0000 (10:09 -0400)]
Merge pull request #13894 from dotnet-maestro-bot/master-UpdateDependencies
Update PgoData to master-
20170911-0041 (master)
Eric Erhardt [Mon, 11 Sep 2017 14:02:42 +0000 (09:02 -0500)]
Merge branch 'master' into UpdateBuildTools
dotnet-maestro-bot [Mon, 11 Sep 2017 07:57:00 +0000 (00:57 -0700)]
Update PgoData to master-
20170911-0041
Stephen Toub [Mon, 11 Sep 2017 06:55:58 +0000 (02:55 -0400)]
Merge pull request #13893 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview2-25711-01 (master)
dotnet-maestro-bot [Mon, 11 Sep 2017 00:15:37 +0000 (17:15 -0700)]
Update CoreClr to preview2-25711-01
Eric Erhardt [Sun, 10 Sep 2017 20:36:19 +0000 (15:36 -0500)]
Merge branch 'master' into UpdateBuildTools
Eric Erhardt [Sun, 10 Sep 2017 20:35:25 +0000 (15:35 -0500)]
Merge branch 'master' into UpdateBuildTools
Stephen Toub [Sun, 10 Sep 2017 13:20:14 +0000 (09:20 -0400)]
Merge pull request #13847 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, PgoData to preview2-25709-04, master-
20170910-0049, respectively (master)
dotnet-maestro-bot [Sun, 10 Sep 2017 08:06:00 +0000 (01:06 -0700)]
Update CoreClr, PgoData to preview2-25709-04, master-
20170910-0049, respectively
Stephen Toub [Sun, 10 Sep 2017 03:25:18 +0000 (23:25 -0400)]
Merge pull request #13849 from stephentoub/string_create
Add String.Create span-based method
Jan Kotas [Sun, 10 Sep 2017 01:48:20 +0000 (18:48 -0700)]
Merge pull request #13888 from jkotas/corelib-mirror
Mirror changes from dotnet/corert
Stephen Toub [Sat, 9 Sep 2017 23:44:19 +0000 (19:44 -0400)]
Merge pull request #13886 from ahsonkhan/SpanReadOnlyStruct
Marking {ReadOnly}Span with IsReadOnly attribute
Jan Kotas [Sat, 9 Sep 2017 23:32:23 +0000 (16:32 -0700)]
Finish moving files to shared CoreLib partition
Jan Kotas [Sat, 9 Sep 2017 22:51:05 +0000 (15:51 -0700)]
Move PInvoke interop related attributes to shared CoreLib partition
[tfs-changeset: 1673253]
Jan Kotas [Sat, 9 Sep 2017 16:06:21 +0000 (09:06 -0700)]
Finish moving files to shared partition
Jan Kotas [Sat, 9 Sep 2017 11:57:48 +0000 (04:57 -0700)]
Fix IntrinsicAttribute build break
Eric Erhardt [Sat, 9 Sep 2017 22:37:14 +0000 (17:37 -0500)]
Merge branch 'master' into UpdateBuildTools
Daniel Podder [Sat, 9 Sep 2017 19:33:18 +0000 (12:33 -0700)]
Enable auto-update for PGO data (#13883)
Move PgoDataPackageVersion into dependencies.props, which enables auto-update functionality.
Also, update optdata version to
20170908-1805.
Jan Kotas [Sat, 9 Sep 2017 07:28:46 +0000 (00:28 -0700)]
Cleanup Guid formatting (#13885)
ahsonkhan [Sat, 9 Sep 2017 05:23:16 +0000 (22:23 -0700)]
Marking {ReadOnly}Span with IsReadOnly attribute.
Pat Gavlin [Sat, 9 Sep 2017 04:18:07 +0000 (21:18 -0700)]
Merge pull request #13842 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Sat, 9 Sep 2017 04:14:13 +0000 (21:14 -0700)]
Merge pull request #13110 from pgavlin/SPMIJitOptions
Add the capability to specify JIT options on the SPMI command line.
Stephanie Niu [Sat, 9 Sep 2017 02:58:35 +0000 (19:58 -0700)]
Guid span-based APIs (ctor, TryWriteBytes, TryFormat) (#13323)
* standardized style changes
* 3 span-ified guid methods
throw null exception for readonlyspan ctor
full changes
* restructured trywritebytes
* changed writebytehelper from feedback
* changed casing of switch statement
* indentation
Pat Gavlin [Sat, 9 Sep 2017 01:56:36 +0000 (18:56 -0700)]
Merge pull request #13863 from pgavlin/DevDiv491211
Properly update GTF_{ASG,EXCEPT} in call morphing.
Steve MacLean [Sat, 9 Sep 2017 01:41:42 +0000 (21:41 -0400)]
[Arm64] Optimize System.Buffer:Memmove (#13793)
* [Arm64] Optimize System.Buffer:Memmove
Enable HAS_BLOCKS
Disable code to fall back to native memmove until memmove
optimizations are merged to OS mainline
* Add links to issues
Jan Kotas [Sat, 9 Sep 2017 01:16:01 +0000 (18:16 -0700)]
Move files to shared partition (#13870)
Moved pseudo-custom attribute reflection helpers from attribute definitions to reflection to prepare attribute definitions to be moved to shared partition.
Koundinya Veluri [Sat, 9 Sep 2017 00:14:09 +0000 (17:14 -0700)]
Port some concurrent collection implementations with latest fixes from CoreFX into CoreCLR copies (#12939)
Daniel Podder [Fri, 8 Sep 2017 23:55:04 +0000 (16:55 -0700)]
Add a <clear /> to packageSources in src/NuGet.Config (#13874)
Fixes #13873
Viktor Hofer [Fri, 8 Sep 2017 22:10:51 +0000 (00:10 +0200)]
Merge pull request #13845 from ViktorHofer/DBNull-Serialization
Make DBNull serializable
Jan Kotas [Fri, 8 Sep 2017 04:33:15 +0000 (21:33 -0700)]
Non-shared changes
Jan Kotas [Sun, 3 Sep 2017 16:57:12 +0000 (09:57 -0700)]
Delete redundant PInvokes
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Sun, 3 Sep 2017 16:40:43 +0000 (09:40 -0700)]
Move HResults to shared partition
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jan Kotas [Fri, 8 Sep 2017 22:04:56 +0000 (15:04 -0700)]
Fix CoreLib build warnings (#13851)
Eric Erhardt [Fri, 8 Sep 2017 22:02:55 +0000 (17:02 -0500)]
Update CLI version to match other dotnet repos and unblock new BuildTools
Eric Erhardt [Fri, 8 Sep 2017 21:21:15 +0000 (16:21 -0500)]
Update BuildTools automatically when new versions are available.
Koundinya Veluri [Fri, 8 Sep 2017 21:19:05 +0000 (14:19 -0700)]
Change lock used for initializing YieldProcessorNormalized from Crst to CrstStatic (#13857)
Fixes https://github.com/dotnet/coreclr/issues/13779
wtgodbe [Fri, 8 Sep 2017 21:10:10 +0000 (14:10 -0700)]
Revert PreReleaseLabel to preview1
Pat Gavlin [Fri, 8 Sep 2017 18:55:07 +0000 (11:55 -0700)]
Address PR feedback.
Matt Mitchell [Fri, 8 Sep 2017 17:26:37 +0000 (10:26 -0700)]
Only delete agent when not succesful (#13865)
Spinup for this agent is unreliable (docker fails to start a lot). Only delete when the build fails.
Pat Gavlin [Fri, 8 Sep 2017 17:19:18 +0000 (10:19 -0700)]
Properly update GTF_{ASG,EXCEPT} in call morphing.
The former is only necessary if it is set on any of the call's
arguments; the latter is necessary if the call may throw or if it is set
on any of the call's arguments.
Fixes DevDiv 491211.
Viktor Hofer [Fri, 8 Sep 2017 16:35:23 +0000 (18:35 +0200)]
Adding serializable attribute to type
Viktor Hofer [Fri, 8 Sep 2017 14:56:25 +0000 (16:56 +0200)]
PR feedback
Stephen Toub [Fri, 8 Sep 2017 01:42:42 +0000 (21:42 -0400)]
Add String.Create span-based method
Dan Moseley [Sat, 2 Sep 2017 07:47:53 +0000 (00:47 -0700)]
Fix EventProvider to build on Linux
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Viktor Hofer [Thu, 7 Sep 2017 23:36:46 +0000 (01:36 +0200)]
Remove unused params
Viktor Hofer [Thu, 7 Sep 2017 23:25:51 +0000 (01:25 +0200)]
Add exception handling for other input and add comments
Pat Gavlin [Sat, 29 Jul 2017 22:42:39 +0000 (15:42 -0700)]
Add the capability to specify JIT options on the SPMI command line.
This change adds two new flags, `-jitoption` and `-jit2option`, to the
SuperPMI command line. These flags are cumulative, and are used to
specify JIT config options (e.g. `COMPlus_JitDisasm`, albeit without the
`COMPlus_` prefix) to the base and diff JITs, respectively.
This change also removes Smarty-specific code and support for capturing
and replaying environment variables. The former is no longer terribly
useful and the latter has been obviated by the JIT host interface.
Viktor Hofer [Thu, 7 Sep 2017 23:12:19 +0000 (01:12 +0200)]
Revert access modifier change and update its comment
Pat Gavlin [Thu, 7 Sep 2017 23:04:55 +0000 (16:04 -0700)]
Merge pull request #13838 from pgavlin/DevDiv489992
Copy `GTF_{ASG,EXCEPT}` flags in `gtCloneExpr`.
Viktor Hofer [Thu, 7 Sep 2017 23:04:15 +0000 (01:04 +0200)]
More comments and remove of corert special case
Viktor Hofer [Thu, 7 Sep 2017 23:01:50 +0000 (01:01 +0200)]
PR feedback
David Mason [Thu, 7 Sep 2017 22:56:30 +0000 (15:56 -0700)]
Make dumpmd work with tiered jitting. Now displays previous code addresses (#13805)
* Make dumpmd work with tiered jitting. Now displays previous code addresses
* add tier info and nativecodeversionnode ptr to dumpmd output
* fix warnings on non-rejit platforms
Karthik Rajasekaran [Thu, 7 Sep 2017 22:39:06 +0000 (15:39 -0700)]
Retry linux arm legs on a new agent (#13839)
Viktor Hofer [Thu, 7 Sep 2017 21:57:22 +0000 (23:57 +0200)]
Make DBNull serializable
Jarret Shook [Thu, 7 Sep 2017 21:34:20 +0000 (14:34 -0700)]
Merge pull request #12334 from sdmaclea/PR-Optimize-Jit-WriteBarriers
[Arm64] Optimize JIT_WriteBarriers
Andy Ayers [Thu, 7 Sep 2017 21:28:07 +0000 (14:28 -0700)]
New jit intrinsic support (#13815)
Support for new-style intrinsics where corelib methods can have both IL
implementations and optional jit-supplied implementations.
Mark such methods with the [Intrinsic] attribute, then recognize the
intrinsic methods by name in the jit.
Jit currently has a placeholder for the Enum.HasFlag method.
Andy Ayers [Thu, 7 Sep 2017 21:26:46 +0000 (14:26 -0700)]
Desktop changes corresponding to https://github.com/dotnet/coreclr/pull/13815
The new jit interface method is stubbed out in desktop, as we will not see any of these new style intriniscs there (at least for now).
[tfs-changeset: 1673063]
Viktor Hofer [Wed, 23 Aug 2017 14:54:39 +0000 (16:54 +0200)]
ConcurrentQueue
Pat Gavlin [Thu, 7 Sep 2017 19:47:42 +0000 (12:47 -0700)]
Copy `GTF_{ASG,EXCEPT}` flags in `gtCloneExpr`.
These flags from the source were being unioned with those of the copy,
which was incorrect in cases where the copy's flags were overly
conservative. This change simply copies the values of these flags from
the source.
Fixes VSO 489992.
Pat Gavlin [Thu, 7 Sep 2017 19:30:51 +0000 (12:30 -0700)]
Merge pull request #13821 from pgavlin/DevDiv487701_487702
Fix VSO 487701 and 487702.
Brian Chavez [Thu, 7 Sep 2017 18:36:37 +0000 (11:36 -0700)]
Spelling and grammar corrections - A through L (#13683)
Pat Gavlin [Thu, 7 Sep 2017 18:33:59 +0000 (11:33 -0700)]
Merge pull request #13817 from pgavlin/DevDiv487703
Do not remove NOPs used by calls.
dotnet-maestro-bot [Thu, 7 Sep 2017 18:19:20 +0000 (11:19 -0700)]
Update CoreClr, CoreFx to preview2-25707-02, preview2-25707-02, respectively (#13808)
sergey ignatov [Thu, 7 Sep 2017 18:14:29 +0000 (21:14 +0300)]
Fix for #13830 issue (#13831)
Victor "Nate" Graf [Thu, 7 Sep 2017 15:55:21 +0000 (08:55 -0700)]
Fix incorrect treatment of pointer as fixed (#13816)
Jarret Shook [Thu, 7 Sep 2017 02:47:52 +0000 (19:47 -0700)]
Merge pull request #13797 from jashook/arm64_green_ci
Disable tests based on 13796
Joseph Tremoulet [Thu, 7 Sep 2017 01:14:19 +0000 (21:14 -0400)]
Segregate merged returns by constant value (#13792)
The JIT enforces a limit on the number of epilogs emitted in any given
method. Change the logic so that when this merging kicks in, returns of
constant values are given merged return blocks distinct from each other
and from the general return block, as long as we can do so without going
over the limit. This particularly helps avoid redundancy (while still
keeping method size down) in methods with a large number of constant
returns but only a few distinct constants, which is true of many
predicate methods with bool return type.
This is the compiler portion of #13466 and dotnet/corefx#23395.
Sean Gillespie [Wed, 6 Sep 2017 23:12:25 +0000 (16:12 -0700)]
Vendor the volatile.h header into src/gc/env for the standalone GC build (#13656)
* Vendor the volatile.h header into src/gc/env for the standalone GC build
* Repair the GC sample
* Remove some unneeded defines (fixes the sample build)
Pat Gavlin [Wed, 6 Sep 2017 22:51:22 +0000 (15:51 -0700)]
Fix VSO 487701 and 487702.
Both of these issues stem from attempting to unassign a copied interval
from the copied-to register and then reassigning the interval to the
same. This corrupts some of the bookkeeping necessary to track whether
or not the interval in the register needs to be spilled, and the RA ends
up attempting to spill the interval being allocated even though it is
not assigned a register.
Pat Gavlin [Wed, 6 Sep 2017 22:49:27 +0000 (15:49 -0700)]
Add tests for VSO 487701 and 487702.
Pat Gavlin [Wed, 6 Sep 2017 21:34:48 +0000 (14:34 -0700)]
Add a regression test.
Pat Gavlin [Wed, 6 Sep 2017 19:48:51 +0000 (12:48 -0700)]
Do not remove NOPs used by calls.
Instead of removing dead stores that are marked as late args, we replace
them with NOPs. This obviates the need to update the call's argument
table, but requires that the NOP itself not be DCE'd. This change marks
these NOPs with the `ORDER_SIDEEFF` flag s.t. DCE will not remove them.
Fixes VSO 487703.
Sergey Andreenko [Wed, 6 Sep 2017 19:38:58 +0000 (12:38 -0700)]
Fix DevDiv_278523 test for r2r x86. (#13709)
* separate sources into 2 files: for 32 and for 64.
danmosemsft [Sat, 2 Sep 2017 00:55:10 +0000 (17:55 -0700)]
Restore Array.Empty
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Jarret Shook [Wed, 6 Sep 2017 18:16:57 +0000 (11:16 -0700)]
Merge pull request #13811 from jashook/fix_xarch_warning
Fix potentially uninitialized local variable 'regCount'
Sergey Andreenko [Wed, 6 Sep 2017 18:00:18 +0000 (11:00 -0700)]
Jit doesn't reload shift index if it was spilled to rcx. (#13757)
Repro test. Fix and additional assert.