eric@webkit.org [Mon, 3 Oct 2011 20:09:25 +0000 (20:09 +0000)]
PerformanceTests/Parser/html-parser is only testing parsing of the head element
https://bugs.webkit.org/show_bug.cgi?id=69283
Reviewed by Adam Barth.
While investigating https://bugs.webkit.org/show_bug.cgi?id=68944
I found that the html-parser benchmark was only parsing up to the
first script tag per loop! We've fixed this by adding the sandbox
tag which will deny all external loads and allow the parser to
synchronously continue parsing the entire document to completion
(as we had expected it was doing).
This changes the profile somewhat. Line number counting is much
hotter, since we're actually accounting for the parse of the entire
document in our sample.
Total sample time only about doubles, from 1800ms to 3800ms on my machine
which is less than I would have expected.
* Parser/html-parser.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 3 Oct 2011 19:54:45 +0000 (19:54 +0000)]
SVG Pattern tile pixelated on patternTransform
https://bugs.webkit.org/show_bug.cgi?id=69261
Source/WebCore:
Reviewed by Rob Buis.
Scale the SVG pattern tile by the scale level of patternTransform to avoid pixelation.
Test: svg/custom/pattern-scaled-pattern-space.svg
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::applyResource):
LayoutTests:
Reviewed by Rob Buis.
Add a new test to check that SVG pattern tiles are not pixelated on
scaling with patternTransform.
Updated two more pixel tests. Both changes are progressions.
* platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.png:
* platform/mac/svg/custom/non-scaling-stroke-expected.png:
* svg/custom/pattern-scaled-pattern-space-expected.png: Added.
* svg/custom/pattern-scaled-pattern-space-expected.txt: Added.
* svg/custom/pattern-scaled-pattern-space.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 3 Oct 2011 19:52:01 +0000 (19:52 +0000)]
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181
Reviewed by Darin Fisher.
Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.
Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.
* public/WebWidget.h:
(WebKit::WebWidget::compositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 19:44:22 +0000 (19:44 +0000)]
Another round of updates after trac.webkit.org/changeset/96509.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png:
* platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png:
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png:
* platform/chromium-win/fast/invalid/017-expected.png:
* platform/chromium-win/fast/invalid/018-expected.png:
* platform/chromium-win/fast/invalid/020-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 3 Oct 2011 19:25:16 +0000 (19:25 +0000)]
DFG should speculate more aggressively on obvious cases on
polymorphic get_by_id
https://bugs.webkit.org/show_bug.cgi?id=69235
Reviewed by Oliver Hunt.
This implements trivial polymorphic get_by_id. It also fixes
problems in the CSE for CheckStructure in the put_by_id
transition case.
Doing this required knowing whether a polymorphic get_by_id stub
was doing a direct access rather than a call of some kind.
Slight speed-up on Kraken and SunSpider. 0.5% speed-up in the
scaled mean of all benchmarks.
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::addStructureSet):
(JSC::DFG::Graph::addStructureTransitionData):
* dfg/DFGNode.h:
(JSC::DFG::StructureTransitionData::StructureTransitionData):
(JSC::DFG::Node::hasStructureTransitionData):
(JSC::DFG::Node::structureTransitionData):
(JSC::DFG::Node::hasStructureSet):
(JSC::DFG::Node::structureSet):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::tryBuildGetByIDProtoList):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureSet.h: Added.
(JSC::DFG::StructureSet::StructureSet):
(JSC::DFG::StructureSet::add):
(JSC::DFG::StructureSet::addAll):
(JSC::DFG::StructureSet::remove):
(JSC::DFG::StructureSet::contains):
(JSC::DFG::StructureSet::isSubsetOf):
(JSC::DFG::StructureSet::isSupersetOf):
(JSC::DFG::StructureSet::size):
(JSC::DFG::StructureSet::at):
(JSC::DFG::StructureSet::operator[]):
(JSC::DFG::StructureSet::last):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::getPolymorphicAccessStructureListSlot):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Mon, 3 Oct 2011 19:21:01 +0000 (19:21 +0000)]
Enable WEB_AUDIO by default in the WebKit/mac port.
https://bugs.webkit.org/show_bug.cgi?id=68587
Reviewed by Simon Fraser.
Source/JavaScriptCore:
* Configurations/FeatureDefines.xcconfig:
* wtf/Platform.h:
Source/WebCore:
No new tests; existing webaudio/ layout tests cover this.
* Configurations/FeatureDefines.xcconfig:
* WebCore.xcodeproj/project.pbxproj: Add a build step which copies audio resources to
the WebCore.framework bundle.
Source/WebKit/mac:
* Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
* Configurations/FeatureDefines.xcconfig:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Mon, 3 Oct 2011 19:13:22 +0000 (19:13 +0000)]
BiquadFilterNode .type attribute is not handled correctly
https://bugs.webkit.org/show_bug.cgi?id=69182
Reviewed by Kenneth Russell.
Source/WebCore:
Test: webaudio/biquadfilternode-basic.html
* platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::initialize):
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
* webaudio/AudioChannelMerger.cpp:
(WebCore::AudioChannelMerger::AudioChannelMerger):
* webaudio/AudioChannelSplitter.cpp:
(WebCore::AudioChannelSplitter::AudioChannelSplitter):
* webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
* webaudio/AudioGainNode.cpp:
(WebCore::AudioGainNode::AudioGainNode):
* webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::~AudioNode):
(WebCore::AudioNode::setNodeType):
(WebCore::AudioNode::ref):
(WebCore::AudioNode::finishDeref):
* webaudio/AudioNode.h:
(WebCore::AudioNode::nodeType):
* webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::AudioPannerNode):
(WebCore::AudioPannerNode::notifyAudioSourcesConnectedToNode):
* webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
(WebCore::BiquadFilterNode::setType):
* webaudio/BiquadFilterNode.h:
* webaudio/BiquadFilterNode.idl:
* webaudio/BiquadProcessor.h:
(WebCore::BiquadProcessor::setType):
* webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
* webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
* webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
* webaudio/HighPass2FilterNode.cpp:
(WebCore::HighPass2FilterNode::HighPass2FilterNode):
* webaudio/JavaScriptAudioNode.cpp:
(WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
* webaudio/LowPass2FilterNode.cpp:
(WebCore::LowPass2FilterNode::LowPass2FilterNode):
* webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
* webaudio/RealtimeAnalyserNode.cpp:
(WebCore::RealtimeAnalyserNode::RealtimeAnalyserNode):
* webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
LayoutTests:
* webaudio/biquadfilternode-basic-expected.txt: Added.
* webaudio/biquadfilternode-basic.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 3 Oct 2011 19:01:28 +0000 (19:01 +0000)]
AX: support role mapping for HTML5 section elements
https://bugs.webkit.org/show_bug.cgi?id=69150
Source/WebCore:
We need to map these HTML5 elements to appropriate ARIA roles. That mapping is:
article -> Document article
nav -> Landmark navigation
aside -> Landmark complementary
section -> Document region
address -> Landmark content info
header -> Landmark banner (unless it's in an article or section)
footer -> Landmark content info (unless it's in an article or section)
Reviewed by Darin Adler.
Test: platform/mac/accessibility/html-section-elements.html
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isDescendantOfElementType):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/AccessibilityRenderObject.h:
LayoutTests:
Reviewed by Darin Adler.
* platform/mac/accessibility/html-section-elements-expected.txt: Added.
* platform/mac/accessibility/html-section-elements.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ademar@webkit.org [Mon, 3 Oct 2011 18:55:46 +0000 (18:55 +0000)]
Unreviewed: change my e-mail in commiters.py
(I'm leaving the company and my @openbossa.org will be no more)
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 3 Oct 2011 18:09:28 +0000 (18:09 +0000)]
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262
Actually commit the files this time.
Reviewed by John Sullivan.
* platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
* platform/mac/accessibility/heading-clickpoint.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 18:05:37 +0000 (18:05 +0000)]
Results from more bots for trac.webkit.org/changeset/96498.
* platform/chromium-cg-mac-leopard/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-win-vista/svg/filters: Removed.
* platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Mon, 3 Oct 2011 18:04:54 +0000 (18:04 +0000)]
AX: click point for AXHeadings often returns point on empty space (results in wrong context menu)
https://bugs.webkit.org/show_bug.cgi?id=69262
Source/WebCore:
When the contextual menu is opened for a heading, often it will open on empty space because
the heading is wider than the content inside. The click point should thus use the content
inside the heading as the click point.
To accomplish this we need to query whether we have children using children() which is a non-const
method, hence the removal of const from clickPoint().
Reviewed by John Sullivan.
Test: platform/mac/accessibility/heading-clickpoint.html
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clickPoint):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::clickPoint):
* accessibility/AccessibilityRenderObject.h:
LayoutTests:
Reviewed by John Sullivan.
* platform/mac/accessibility/heading-clickpoint-expected.txt: Added.
* platform/mac/accessibility/heading-clickpoint.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 18:00:05 +0000 (18:00 +0000)]
Unreviewed, rolling out r96500.
http://trac.webkit.org/changeset/96500
https://bugs.webkit.org/show_bug.cgi?id=69268
Breaks inspector, change landed with no test. (Requested by
pfeldman on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessageImpl.prototype._linkifyLocation):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation.updateAnchor):
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/Linkifier.js: Removed.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyLocation):
(WebInspector.TimelinePanel.FormattedRecord.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 17:51:36 +0000 (17:51 +0000)]
Unbork the test_expectations file.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 3 Oct 2011 17:40:18 +0000 (17:40 +0000)]
Add exact match attribute selectors to the fast path
https://bugs.webkit.org/show_bug.cgi?id=69159
Reviewed by Sam Weinig.
Attribute selectors are increasingly common and we have them in our default style sheet too.
[foo] and [foo="bar"] type selectors can be resolved quickly and easily in the fast path.
- Implement fast path checking for simple attribute selectors.
- Get rid of the ill-defined CSSSelector::hasAttribute(), inline CSSSelector::attribute()
This is ~20% progression in styleForElement() performance loading the full HTML5 spec (~0.8s).
* css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::hasTag):
(WebCore::CSSSelector::attribute):
(WebCore::CSSSelector::isAttributeSelector):
* css/CSSSelectorList.cpp:
(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::checkSelector):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::isFastCheckableMatch):
(WebCore::isFastCheckableRightmostSelector):
(WebCore::SelectorChecker::isFastCheckableSelector):
(WebCore::SelectorChecker::checkSelector):
(WebCore::htmlAttributeHasCaseInsensitiveValue):
(WebCore::anyAttributeMatches):
(WebCore::SelectorChecker::checkOneSelector):
* css/SelectorChecker.h:
(WebCore::SelectorChecker::attributeNameMatches):
(WebCore::SelectorChecker::checkExactAttribute):
(WebCore::SelectorChecker::fastCheckRightmostAttributeSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 17:37:05 +0000 (17:37 +0000)]
Update expectations for tables tests after trac.webkit.org/changeset/96509.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug113235-2-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug23994-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56405-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Added.
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium-cg-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.png: Added.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium-win-xp/fast/forms/file-input-disabled-expected.txt: Added.
* platform/chromium-win/fast/forms/file-input-disabled-expected.txt:
* platform/chromium-win/fast/invalid/residual-style-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium/fast/invalid: Added.
* platform/chromium/fast/invalid/017-expected.txt: Added.
* platform/chromium/fast/invalid/018-expected.txt: Added.
* platform/chromium/fast/invalid/020-expected.txt: Added.
* platform/chromium/fast/invalid/residual-style-expected.txt: Added.
* platform/chromium/fast/invalid/table-inside-stray-table-content-expected.txt: Added.
* platform/chromium/fast/table: Added.
* platform/chromium/fast/table/inline-form-assert-expected.txt: Added.
* platform/chromium/tables: Added.
* platform/chromium/tables/mozilla: Added.
* platform/chromium/tables/mozilla/bugs: Added.
* platform/chromium/tables/mozilla/bugs/bug113235-2-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug23994-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug56405-expected.txt: Added.
* platform/chromium/tables/mozilla/bugs/bug56563-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug220653-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/core: Added.
* platform/chromium/tables/mozilla_expected_failures/core/conflicts-expected.txt: Added.
* platform/chromium/tables/mozilla_expected_failures/other: Added.
* platform/chromium/tables/mozilla_expected_failures/other/empty_cells-expected.txt: Added.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/mac/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* platform/qt/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Removed.
* tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Mon, 3 Oct 2011 17:20:36 +0000 (17:20 +0000)]
respect other paint flags when setting flags for the font. No need to fiddle with DC(0) in paintSkiaText.
https://bugs.webkit.org/show_bug.cgi?id=69172
Reviewed by Stephen White.
No new tests. This is a cleanup/optimization, existing tests apply
* platform/graphics/skia/SkiaFontWin.cpp:
(WebCore::getDefaultGDITextFlags):
(WebCore::setupPaintForFont):
(WebCore::paintSkiaText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Oct 2011 16:57:43 +0000 (16:57 +0000)]
[Qt] REGRESSION(r95526): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=69265
* platform/qt/Skipped: Skip failing tests to make buildbot happy.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 16:56:27 +0000 (16:56 +0000)]
Delete bogus expected PNG.
* platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 16:50:53 +0000 (16:50 +0000)]
FontFallbackList: Glyph pages waste a lot of memory.
https://bugs.webkit.org/show_bug.cgi?id=69260
Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.
Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.
The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.
* platform/graphics/FontFallbackList.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 3 Oct 2011 16:36:46 +0000 (16:36 +0000)]
[GTK] Add failing uri parameter to provisional-load-failed and load-failed signals
https://bugs.webkit.org/show_bug.cgi?id=69252
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
(didFailProvisionalLoadWithErrorForFrame): Pass failing URL to
signal handler.
(didFailLoadWithErrorForFrame): Ditto.
(webkit_web_loader_client_class_init): Add failing URL parameter
to provisional-load-failed and load-failed signals.
* UIProcess/API/gtk/WebKitWebLoaderClient.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadStatusProvisionalLoadFailed): Update to API changes.
(loadStatusLoadFailed): Ditto.
(loadErrorProvisionalLoadFailed): Ditto.
* UIProcess/API/gtk/webkit2marshal.list:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 16:19:59 +0000 (16:19 +0000)]
Fix typo causing race condition in this test.
* svg/as-object/embedded-svg-immediate-offsetWidth-query.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 16:19:06 +0000 (16:19 +0000)]
Right border missing from table with colspan and collapsing border
https://bugs.webkit.org/show_bug.cgi?id=14274
Patch by Konstantin Scheglov <scheglov@google.com> on 2011-10-03
Reviewed by David Hyatt.
Source/WebCore:
Test: fast/table/border-collapsing/bug14274.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
* rendering/RenderTable.h:
(WebCore::RenderTable::colToEffCol):
LayoutTests:
* fast/table/border-collapsing/bug14274-expected.png: Copied from LayoutTests/platform/chromium-win/fast/invalid/020-expected.png.
* fast/table/border-collapsing/bug14274-expected.txt: Added.
* fast/table/border-collapsing/bug14274.html: Added.
* platform/chromium-linux/fast/forms/file-input-disabled-expected.txt:
* platform/chromium-linux/fast/invalid/residual-style-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug56563-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug7121-2-expected.png:
* platform/chromium-win/fast/invalid/017-expected.png:
* platform/chromium-win/fast/invalid/017-expected.txt:
* platform/chromium-win/fast/invalid/018-expected.png:
* platform/chromium-win/fast/invalid/018-expected.txt:
* platform/chromium-win/fast/invalid/020-expected.png:
* platform/chromium-win/fast/invalid/020-expected.txt:
* platform/chromium-win/fast/invalid/table-inside-stray-table-content-expected.txt:
* platform/chromium-win/fast/table/inline-form-assert-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug23994-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56405-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug56563-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug220653-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug3517-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
* platform/chromium-win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
* platform/gtk/fast/invalid/table-residual-style-crash-expected.txt:
* platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
* platform/qt/fast/invalid/table-residual-style-crash-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 3 Oct 2011 16:17:49 +0000 (16:17 +0000)]
[GTK] Fix memory leak when loading url
https://bugs.webkit.org/show_bug.cgi?id=69247
Reviewed by Martin Robinson.
Release URL created with WKURLCreateWithUTF8CString().
Source/WebKit2:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_load_uri):
Tools:
* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback):
* MiniBrowser/gtk/main.c:
(loadURI):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Mon, 3 Oct 2011 16:16:21 +0000 (16:16 +0000)]
Update baselines after trac.webkit.org/changeset/96498.
* platform/chromium-linux-x86/svg/filters: Removed.
* platform/chromium-linux/svg/filters/feColorMatrix-values-expected.png: Added.
* platform/chromium-mac/svg/filters/feColorMatrix-saturate-expected.png: Added.
* platform/chromium-win-vista/svg/filters: Added.
* platform/chromium-win-vista/svg/filters/feColorMatrix-values-expected.png: Added.
* platform/chromium-win/svg/filters/feColorMatrix-saturate-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 3 Oct 2011 16:14:43 +0000 (16:14 +0000)]
[UNIX] Rename NetscapePluginModule::pluginInfo to NetscapePluginModule::getPluginInfoForLoadedPlugin()
https://bugs.webkit.org/show_bug.cgi?id=69147
Reviewed by Martin Robinson.
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
(WebKit::NetscapePluginModule::getPluginInfoForLoadedPlugin):
(WebKit::NetscapePluginModule::getPluginInfo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 3 Oct 2011 16:11:48 +0000 (16:11 +0000)]
[GTK] Fix make distcheck build
https://bugs.webkit.org/show_bug.cgi?id=69243
Reviewed by Martin Robinson.
Source/JavaScriptCore:
* GNUmakefile.list.am:
Source/WebCore:
* GNUmakefile.am:
* GNUmakefile.list.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 3 Oct 2011 16:02:19 +0000 (16:02 +0000)]
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245
Unreviewed rebaseline of Win Chromium DRT results.
* platform/chromium-win/svg/filters/feColorMatrix-values-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Oct 2011 15:58:32 +0000 (15:58 +0000)]
[Qt] Build fix: Qt::escape is deprecated in Qt5
https://bugs.webkit.org/show_bug.cgi?id=69162
Use QString::toHtmlEscaped in the Qt5 case.
Source/JavaScriptCore:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.
* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Added.
(escapeHtml):
* wtf/wtf.pri:
Source/WebCore:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas Kling.
No new tests needed.
* WebCore.pro: adjust the include path accordingly
in the v8 case.
Source/WebKit/qt:
Patch by Pierre Rossi <pierre.rossi@gmail.com> on 2011-10-03
Reviewed by Andreas.
* Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 3 Oct 2011 15:51:45 +0000 (15:51 +0000)]
Not reviewed: [chromium] clean up inspector layout test suppressions on chromium.
https://bugs.webkit.org/show_bug.cgi?id=69263
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Oct 2011 15:43:13 +0000 (15:43 +0000)]
Unreviewed gardening after r96404.
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03
* platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/qt-4.8/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 3 Oct 2011 15:07:00 +0000 (15:07 +0000)]
Web Inspector: debuggerPresentatioModel.linkifyLocation leaks updateAnchor closure instances.
https://bugs.webkit.org/show_bug.cgi?id=69146
In many places we use linkifyLocation function to produce a link node which updates automatically when the source file is changed on the fly.
Such changes happen when we use pretty print or another operation that changes the source code somehow.
linkifyLocation associates a new instance of updateAnchor closure with the each link node and add the closure to the SourceMappingUpdated event's list.
As the result the node<->closure pairs wouldn't be collected until reset the UI and DebuggerPresentationModel.
Reviewed by Yury Semikhatsky.
Test: inspector/performance/resources/network-append-30-requests.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.prototype._linkifyLocation):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._consoleCleared):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/EventListenersSidebarPane.js:
(WebInspector.EventListenersSidebarPane.prototype.update.callback):
(WebInspector.EventListenersSidebarPane.prototype.update):
():
* inspector/front-end/Linkifier.js: Added.
(WebInspector.Linkifier):
(WebInspector.Linkifier.prototype.linkifyLocation):
(WebInspector.Linkifier.prototype.reset):
(WebInspector.Linkifier.prototype._updateSourceAnchors):
(WebInspector.Linkifier.prototype._updateAnchor):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.createCell):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileView):
(WebInspector.CPUProfileView.prototype._resetClicked):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._linkifyLocation):
(WebInspector.TimelinePanel.prototype._linkifyCallFrame):
(WebInspector.TimelinePanel.prototype._clearPanel):
(WebInspector.TimelinePanel.FormattedRecord):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
(WebInspector.TimelinePanel.PopupContentHelper):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendLinkRow):
(WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 3 Oct 2011 14:56:25 +0000 (14:56 +0000)]
Source/WebCore: Web Inspector: more compilation fixes including making ConsoleMessage a part of console model.
https://bugs.webkit.org/show_bug.cgi?id=69253
Reviewed by Yury Semikhatsky.
* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleMessageImpl):
* inspector/front-end/ConsoleModel.js:
(WebInspector.ConsoleModel.prototype._messageRepeatCountUpdated):
(WebInspector.ConsoleMessage.create):
(WebInspector.ConsoleMessage.createTextMessage):
(WebInspector.ConsoleDispatcher.prototype.messageAdded):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleCommandResult):
(WebInspector.ConsoleCommandResult.prototype.toMessageElement):
* inspector/front-end/CookieParser.js:
(WebInspector.Cookie.prototype.get path):
(WebInspector.Cookie.prototype.get domain):
(WebInspector.Cookie.prototype.expires):
* inspector/front-end/DOMAgent.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddConsoleMessage):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype.requestWillBeSent):
(WebInspector.NetworkDispatcher.prototype.requestServedFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.webSocketCreated):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.setContent):
(WebInspector.Resource.prototype.searchInContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._createResource):
* inspector/front-end/externs.js:
(WebInspector.linkifyStringAsFragmentWithCustomLinkifier):
(WebInspector.extensionServer.notifyResourceContentCommitted):
(WebInspector.resourceForURL):
(WebInspector.debuggerPresentationModel.linkifyLocation):
(WebInspector.ObjectPropertiesSection):
(WebInspector.ElementsTreeOutline):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.log.logMessage):
(WebInspector.log):
* inspector/generate-protocol-externs:
Tools: Unreviewed. Add Zoltán Árvai as contributor.
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2011-10-03
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 3 Oct 2011 14:27:24 +0000 (14:27 +0000)]
feColorMatrix saturation is not limited to range 0..1 anymore
https://bugs.webkit.org/show_bug.cgi?id=69245
Source/WebCore:
Reviewed by Nikolas Zimmermann.
Opera doesn't limit the range of values for saturation on feColorMatrix from 0 to 1. The limitation
was also removed from the new Filter Effects 1.0 specification. Values outside this range lead to
under- or oversaturation of the filter input image.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/publish/Filters.html#feColorMatrixElement
Test: svg/filters/feColorMatrix-saturate.svg
* svg/SVGFEColorMatrixElement.cpp:
(WebCore::SVGFEColorMatrixElement::build):
LayoutTests:
Reviewed by Nikolas Zimmermann.
Added new test case to test under- or oversaturation of the filter input image if the value
is not in the range of 0..1.
feColorMatrix-values needed a change, since it relies to the old specification text.
* platform/mac/svg/filters/feColorMatrix-values-expected.png:
* platform/mac/svg/filters/feColorMatrix-values-expected.txt:
* svg/filters/feColorMatrix-saturate-expected.png: Added.
* svg/filters/feColorMatrix-saturate-expected.txt: Added.
* svg/filters/feColorMatrix-saturate.svg: Added.
* svg/filters/feColorMatrix-values.svg:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 14:21:17 +0000 (14:21 +0000)]
[EFL] DRT: Add DumpHistoryItem.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=63992
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-03
Reviewed by Antonio Gomes.
This is the code responsible for dumping the back and forward history
list.
* DumpRenderTree/efl/DumpHistoryItem.cpp: Added.
(dumpHistoryItem):
(dumpBackForwardListForWebView):
(dumpBackForwardListForWebViews):
* DumpRenderTree/efl/DumpHistoryItem.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 14:16:46 +0000 (14:16 +0000)]
Shrink HTMLLIElement.
https://bugs.webkit.org/show_bug.cgi?id=69250
Patch by Andreas Kling <kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.
Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.
* html/HTMLLIElement.cpp:
(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):
* html/HTMLLIElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ryuan.choi@samsung.com [Mon, 3 Oct 2011 14:13:19 +0000 (14:13 +0000)]
[EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp
https://bugs.webkit.org/show_bug.cgi?id=68599
Use a C++ compiler for these files and fix compile issues and coding style.
Reviewed by Hajime Morita.
* CMakeListsEfl.txt:
* ewk/ewk_tiled_backing_store.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_backing_store.c.
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_tiled_matrix.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_matrix.c.
* ewk/ewk_tiled_model.cpp: Renamed from Source/WebKit/efl/ewk/ewk_tiled_model.c.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 14:04:16 +0000 (14:04 +0000)]
[Qt][WebKit2][Mac] WebProcess should exit automatically when UIProcess dies.
https://bugs.webkit.org/show_bug.cgi?id=68439
We use a dispatch queue and a dispatch source in the WebProcess
to receive a notification when the UI Process dies.
The WebProcess then commits suicide.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::parentProcessDiedCallback):
(WebKit::WebProcess::platformInitializeWebProcess):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 3 Oct 2011 13:58:35 +0000 (13:58 +0000)]
Unreviewed gardening after r96257.
https://bugs.webkit.org/show_bug.cgi?id=69257
Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-10-03
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 3 Oct 2011 13:06:58 +0000 (13:06 +0000)]
libdispatch based ParallelJobs is not enough parallel
https://bugs.webkit.org/show_bug.cgi?id=66378
Reviewed by Zoltan Herczeg.
Use the appropriate libdispatch API for our use case.
Throw away the hard coded limit of parallel threads
and use dispatch_apply with the default priority normal
queue istead of using our own custom serial queue (which
was a misuse of the API). Enabling PARALLEL_JOBS is now
a 60% win (2.63x as fast) on the methanol benchmark
(https://gitorious.org/methanol) with an SVG centric test set
while the old implementation was almost identical (less than 5% win).
* wtf/ParallelJobsLibdispatch.h:
(WTF::ParallelEnvironment::ParallelEnvironment):
(WTF::ParallelEnvironment::execute):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Mon, 3 Oct 2011 12:56:52 +0000 (12:56 +0000)]
Web Inspector: Add support for backend search in script content.
https://bugs.webkit.org/show_bug.cgi?id=69015
Reviewed by Pavel Feldman.
Source/WebCore:
Tests: http/tests/inspector/search/search-in-concatenated-script.html
http/tests/inspector/search/search-in-script.html
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ScriptContentProvider.prototype.searchInContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.maybeCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent.searchCallback):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.searchInContent):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.requestSource):
(WebInspector.Script.prototype.searchInContent):
LayoutTests:
* http/tests/inspector/resource-tree/resource-tree-test.js:
(initialize_ResourceTreeTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.maybeCallback):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.addSniffer):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.resourceAddedToFrame):
(initialize_ResourceTest.InspectorTest._runAfterResourcesAreFinished.visit):
(initialize_ResourceTest):
* http/tests/inspector/search/resources/search-concatenated.html: Added.
* http/tests/inspector/search/search-in-concatenated-script-expected.txt: Added.
* http/tests/inspector/search/search-in-concatenated-script.html: Added.
* http/tests/inspector/search/search-in-resource.html:
* http/tests/inspector/search/search-in-script-expected.txt: Added.
* http/tests/inspector/search/search-in-script.html: Added.
* http/tests/inspector/search/search-test.js:
(initialize_SearchTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 11:58:07 +0000 (11:58 +0000)]
Unreviewed, rolling out r96481.
http://trac.webkit.org/changeset/96481
https://bugs.webkit.org/show_bug.cgi?id=69251
Breaks webkit_unit_tests on Linux(dbg) (Requested by hwennborg
on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-03
* WebKit.gypi:
* public/WebCompositor.h:
* public/WebWidgetClient.h:
* src/WebCompositorImpl.cpp:
(WebKit::WebCompositorImpl::WebCompositorImpl):
(WebKit::WebCompositorImpl::~WebCompositorImpl):
(WebKit::WebCompositorImpl::setClient):
(WebKit::WebCompositorImpl::handleInputEvent):
* src/WebCompositorImpl.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):
* tests/WebCompositorImplTest.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 11:37:54 +0000 (11:37 +0000)]
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223
WebKitTestRunner must include Qt / qnamespace header
to get a definition of Qt::MouseButtons.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-03
Reviewed by Andreas Kling.
* WebKitTestRunner/EventSenderProxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 3 Oct 2011 10:55:11 +0000 (10:55 +0000)]
Unreviewed. Add Zoltán Árvai as contributor.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 3 Oct 2011 09:54:27 +0000 (09:54 +0000)]
Web Inspector: move console message formatting from ConsoleView.js into ConsoleMessage.js
https://bugs.webkit.org/show_bug.cgi?id=69244
Reviewed by Yury Semikhatsky.
* inspector/front-end/ConsoleMessage.js:
(WebInspector.ConsoleMessage):
(WebInspector.ConsoleMessage.prototype._formatMessage.else.else.linkifier):
(WebInspector.ConsoleMessage.prototype._formatMessage):
(WebInspector.ConsoleMessage.prototype._format):
(WebInspector.ConsoleMessage.prototype._formatParameter):
(WebInspector.ConsoleMessage.prototype._formatParameterAsValue):
(WebInspector.ConsoleMessage.prototype._formatParameterAsObject):
(WebInspector.ConsoleMessage.prototype._formatParameterAsNode):
(WebInspector.ConsoleMessage.prototype._formatParameterAsArray):
(WebInspector.ConsoleMessage.prototype._formatParameterAsString):
(WebInspector.ConsoleMessage.prototype._printArray):
(WebInspector.ConsoleMessage.prototype._formatAsArrayEntry):
(WebInspector.ConsoleMessage.prototype._formatWithSubstitutionString):
* inspector/front-end/ConsoleView.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Mon, 3 Oct 2011 09:30:18 +0000 (09:30 +0000)]
Unreviewed Qt gardening after r96404
Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-03
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/qt/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 3 Oct 2011 09:16:12 +0000 (09:16 +0000)]
Web Inspector: restore partial front-end compilability
https://bugs.webkit.org/show_bug.cgi?id=69221
Removed unused isWhitespace; introduced missing classes in Inspector.json;
generated externs for the protocol types along with the commands.
Patch by Pavel Feldman <pfeldman@chromium.org> on 2011-10-03
Reviewed by Yury Semikhatsky.
* inspector/Inspector.json:
* inspector/compile-front-end.sh:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable.onDocumentAvailable):
(WebInspector.DOMAgent.prototype._dispatchWhenDocumentAvailable):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
* inspector/front-end/ElementsTreeOutline.js:
():
* inspector/front-end/Object.js:
* inspector/front-end/Popover.js:
(WebInspector.PopoverHelper.prototype._mouseMove):
* inspector/front-end/View.js:
* inspector/front-end/externs.js:
(Array.prototype.remove):
* inspector/generate-protocol-externs:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 3 Oct 2011 06:59:23 +0000 (06:59 +0000)]
method/enctype/formMethod/formEnctype properties should be limited to known values.
https://bugs.webkit.org/show_bug.cgi?id=68887
Reviewed by Hajime Morita.
Source/WebCore:
According to the standard and other browser behaviors, the
following IDL properties should be reflected to the corresponding
HTML attributes on setting, but should return normalized values on
getting.
- HTMLFormElement::method
- HTMLFormElement::enctype
- HTMLInputElement::formMethod
- HTMLInputElement::formEnctype
- HTMLButtonElement::formMethod
- HTMLButtonElement::formEnctype
Tests: fast/forms/enctype-attribute.html
fast/forms/method-attribute.html
* html/HTMLButtonElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formEnctype):
Normalizes the value by parseEncodingType().
(WebCore::HTMLFormControlElement::setFormEnctype):
Simply calls setAttribute()
(WebCore::HTMLFormControlElement::formMethod):
Normalizes the value by parseMethodType().
(WebCore::HTMLFormControlElement::setFormMethod):
Simply calls setAttribute()
* html/HTMLFormControlElement.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseMappedAttribute):
Follow the Attributes function renaming.
(WebCore::HTMLFormElement::method):
Normalizes the value by parseMethodType().
* html/HTMLFormElement.idl:
Replace 'Reflect' with 'ConvertNullToNullString' in order to use a
getter function.
* html/HTMLInputElement.idl: ditto.
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseEncodingType):
New function made from a part of old parseEncodingType().
(WebCore::FormSubmission::Attributes::updateEncodingType):
Renamed from parseEncodingType().
(WebCore::FormSubmission::Attributes::parseMethodType):
New function made from a part of old parseMethodType().
(WebCore::FormSubmission::Attributes::updateMethodType):
Renamed from parseMethodType().
(WebCore::FormSubmission::create):
Follow the Attributes function renaming.
* loader/FormSubmission.h:
(WebCore::FormSubmission::Attributes::methodString):
A helper function to provide normalized strings for FormSubmission::Method.
LayoutTests:
* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/element-attribute-js-null.html: Correct an expectation for HTMLFormElement::method.
* fast/forms/enctype-attribute-expected.txt: Added.
* fast/forms/enctype-attribute.html: Added.
* fast/forms/method-attribute-expected.txt: Added.
* fast/forms/method-attribute.html: Added.
* fast/forms/script-tests/submit-form-attributes.js: Correct expectations.
* fast/forms/submit-form-attributes-expected.txt: ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Mon, 3 Oct 2011 06:49:50 +0000 (06:49 +0000)]
[Qt]REGRESSION(r95912): It made sputnik tests flakey
https://bugs.webkit.org/show_bug.cgi?id=68990
Reviewed by Geoffrey Garen.
Changing signed char to int in r96354 solved the
problem. However transitionCount still returns
with a signed char and should be changed to int.
* runtime/Structure.h:
(JSC::Structure::transitionCount):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Mon, 3 Oct 2011 02:13:11 +0000 (02:13 +0000)]
DFG misses some obvious opportunities for common subexpression elimination
https://bugs.webkit.org/show_bug.cgi?id=69233
Reviewed by Oliver Hunt.
0.7% speed-up on SunSpider.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 3 Oct 2011 01:11:45 +0000 (01:11 +0000)]
[chromium] Add WebWidget API for accessing the current WebCompositor
https://bugs.webkit.org/show_bug.cgi?id=69181
Patch by James Robinson <jamesr@chromium.org> on 2011-10-02
Reviewed by Darin Fisher.
Add new WebWidgetClient::did(Activate|Deactivate)Compositor calls intended to replace
didActivateAccleratedCompositing(bool) so that the enable call can be parameterized.
Add a WebCompositor identifier parameter to didEnableAcceleratedCompositing that can be used on the compositor
thread to get access to a WebCompositor pointer.
* public/WebWidget.h:
(WebKit::WebWidget::compositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::compositor):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 3 Oct 2011 00:40:43 +0000 (00:40 +0000)]
Strength reduce Mac only Frame::searchForLabelsBeforeElement and Frame::matchLabelsAgainstElement into callers
https://bugs.webkit.org/show_bug.cgi?id=69230
Reviewed by Anders Carlsson.
../WebCore:
* WebCore.exp.in:
* page/Frame.h:
* page/mac/FrameMac.mm:
../WebKit/mac:
* WebView/WebHTMLRepresentation.mm:
(regExpForLabels):
(searchForLabelsBeforeElement):
(matchLabelsAgainstString):
(matchLabelsAgainstElement):
(-[WebHTMLRepresentation searchForLabels:beforeElement:resultDistance:resultIsInCellAbove:]):
(-[WebHTMLRepresentation matchLabels:againstElement:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Mon, 3 Oct 2011 00:22:04 +0000 (00:22 +0000)]
Bug 67455 - Different regular expression result
Reviewed by Darin Adler.
Fix a regression introduced in r72140. A return was added to the backtracking loop for
backtrackParentheses with QuantifierNonGreedy, so it always returns after one iteration.
This is incorrect. The additional return should only trigger to force an early return if
an error has occured.
Source/JavaScriptCore:
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::matchParentheses):
- Simplify some nested if else logic.
(JSC::Yarr::Interpreter::backtrackParentheses):
- Simplify some nested if else logic.
- Only return early from backtrackParentheses on success/error, not on failure.
LayoutTests:
* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
- Added test cases from bug.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sun, 2 Oct 2011 20:02:03 +0000 (20:02 +0000)]
REGRESSION (r95474): Unable to type anywhere in nightly builds in WebKit1 mode
https://bugs.webkit.org/show_bug.cgi?id=68542
Reviewed by Mark Rowe.
* WebView/WebView.mm: (-[WebView _usesDocumentViews]): Re-add this method for now.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sun, 2 Oct 2011 19:54:31 +0000 (19:54 +0000)]
[Qt][WK2][Mac] WebKit2 does not build on mac after merge of Qt5 refactor branch.
https://bugs.webkit.org/show_bug.cgi?id=69223
Source/WebCore:
Add a missing import (NSWindow.h) in WebVideoFullscreenHUDWindowController.
Add a missing include path and a missing objective source file to WebCore.pro.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.
No new tests, build fix.
* WebCore.pro:
* platform/mac/WebVideoFullscreenHUDWindowController.h:
Source/WebKit2:
After the merge of the Qt5 refactor branch, networking stuff has been
extracted into a separate library. The qmlplugin needs to link to that
library to get QNetworkReply defined.
Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-02
Reviewed by Noam Rosenthal.
* UIProcess/API/qt/qmlplugin/qmlplugin.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Sun, 2 Oct 2011 19:41:08 +0000 (19:41 +0000)]
Remove an unused member in RenderTable::ColumnStruct
https://bugs.webkit.org/show_bug.cgi?id=69119
Reviewed by Darin Adler.
No test as there should be no change in behavior.
The member was added several years ago and its users were removed or changed. The code would
need a refactoring but this would be tricky to get right. This change just removes the member
to reap the short-term benefits.
* rendering/RenderTable.h:
(WebCore::RenderTable::ColumnStruct::ColumnStruct): Remove anything associated with m_width.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Oct 2011 17:38:09 +0000 (17:38 +0000)]
Remove temporary baselines after trac.webkit.org/changeset/96470.
* platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/css: Removed.
* platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-win-xp/svg/css: Removed.
* platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/chromium-win/svg/filters/filter-clip-expected.txt: Removed.
* platform/chromium/svg/filters: Removed.
* platform/chromium/svg/filters/filter-clip-expected.txt: Removed.
* platform/gtk/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/mac/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt: Removed.
* svg/css/circle-in-mask-with-shadow-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Oct 2011 17:35:35 +0000 (17:35 +0000)]
Clean up obsolete code in gardeningserver.py related to
STATIC_FILE_NAMES. Rather than serve the UI via the Python HTTP
server, we just serve it off the filesystem directly.
We had planned to serve the UI off build.webkit.org, but that server is
somewhat slow. We'll probably serve the UI of some web server, but
we'll need to work that out later.
* Scripts/webkitpy/tool/commands/gardenomatic.py:
* Scripts/webkitpy/tool/servers/gardeningserver.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Oct 2011 17:18:28 +0000 (17:18 +0000)]
Rip out half-backed garden-o-matic features in preparation for wider use
https://bugs.webkit.org/show_bug.cgi?id=69226
This patch rips out a bunch of half-baked features and cleans up a
bunch of small nits with the core set of features. We're going to ask
more folks to start using the tool, and having a bunch of half-baked
features around is distracting. We can add these features back under a
flag and interate on them after we've got the core functionality
nailed.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Oct 2011 15:25:49 +0000 (15:25 +0000)]
Update baseline and expectations after trac.webkit.org/changeset/96470
* platform/chromium-cg-mac-leopard/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-cg-mac-leopard/svg/custom/mask-colorspace-expected.png: Removed.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Added.
* platform/chromium-cg-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.png:
* platform/chromium-cg-mac/svg/custom/grayscale-gradient-mask-expected.txt: Added.
* platform/chromium-cg-mac/svg/custom/mask-colorspace-expected.png: Added.
* platform/chromium-cg-mac/svg/custom/mask-with-all-units-expected.png: Added.
* platform/chromium-cg-mac/svg/filters/filter-clip-expected.png: Added.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-linux-x86/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-linux/svg/custom/mask-colorspace-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-mac/svg/custom/mask-colorspace-expected.png:
* platform/chromium-mac/svg/filters/filter-clip-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
* platform/chromium-win-vista/svg/css: Added.
* platform/chromium-win-vista/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-win-xp/svg/css: Added.
* platform/chromium-win-xp/svg/css/circle-in-mask-with-shadow-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
* platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
* platform/chromium-win/svg/custom/mask-colorspace-expected.png:
* platform/chromium-win/svg/filters/filter-clip-expected.txt: Added.
* platform/chromium/svg/filters: Added.
* platform/chromium/svg/filters/filter-clip-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/gtk/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/gtk/svg/filters/filter-clip-expected.txt: Removed.
* platform/mac/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/mac/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/mac/svg/filters/filter-clip-expected.txt: Removed.
* platform/qt/svg/custom/grayscale-gradient-mask-expected.txt: Removed.
* platform/qt/svg/custom/mask-with-all-units-expected.txt: Removed.
* platform/qt/svg/filters/filter-clip-expected.txt: Removed.
* svg/custom/grayscale-gradient-mask-expected.txt: Added.
* svg/custom/mask-with-all-units-expected.txt: Added.
* svg/filters/filter-clip-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 2 Oct 2011 08:25:34 +0000 (08:25 +0000)]
REGRESSION (r95502): Assertion failure in CSSPrimitiveValue::computeLengthDouble() when media query specifies unit-less length
https://bugs.webkit.org/show_bug.cgi?id=68760
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/media/invalid-lengths.html
Made length-comparison media queries accept only length values. In compatibility mode, numbers
are allowed as well, and they are interpreted as pixels.
* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength): Added this helper function.
(WebCore::device_heightMediaFeatureEval): Changed to use computeLength().
(WebCore::device_widthMediaFeatureEval): Ditto.
(WebCore::heightMediaFeatureEval): Ditto.
(WebCore::widthMediaFeatureEval): Ditto.
LayoutTests:
* fast/media/invalid-lengths-expected.txt: Added.
* fast/media/invalid-lengths.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Sun, 2 Oct 2011 07:15:08 +0000 (07:15 +0000)]
SVG Mask should take 'color-interpolation' into account to determine the color space of the mask image
https://bugs.webkit.org/show_bug.cgi?id=69076
Source/WebCore:
Reviewed by Simon Fraser.
SVG Masks should take 'color-interpolation' into account to determine the color space of the mask image.
The behavior was changed in SVG 1.1 SE. The color space of the mask image gets defined by the computed value of the
'color-interpolation' property. This will switch the default color space from linearRGB to sRGB for mask images and
is a performance improvement for platforms without native support for linearRGB color space. The
color space transformation can be avoided.
Test: svg/custom/grayscale-gradient-mask-2.svg
* rendering/svg/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
* rendering/svg/RenderSVGResourceMasker.h:
LayoutTests:
Reviewed by Simon Fraser.
Added a new test case to check the behavior of SVG Masks on different values for the 'color-interpolation' property.
Since the default color space of the mask image changes from linearRGB to sRGB, a test needed an update.
* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.png: Added.
* platform/mac/svg/custom/grayscale-gradient-mask-2-expected.txt: Added.
* platform/mac/svg/custom/grayscale-gradient-mask-expected.png:
* platform/mac/svg/custom/grayscale-gradient-mask-expected.txt:
* svg/custom/grayscale-gradient-mask-2.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 2 Oct 2011 06:49:32 +0000 (06:49 +0000)]
Tweak expectations for leopard some more.
* platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Sun, 2 Oct 2011 04:34:17 +0000 (04:34 +0000)]
Correct post-build step for WinCairo test runs.
https://bugs.webkit.org/show_bug.cgi?id=69191
Reviewed by Brian Weinstein.
* DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
shell case to handle the CFLite build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Sun, 2 Oct 2011 02:21:48 +0000 (02:21 +0000)]
[chromium] Fixing draw matrix for composited layers. This
was a regression introduced by:
http://trac.webkit.org/changeset/96454
https://bugs.webkit.org/show_bug.cgi?id=69217
Reviewed by James Robinson.
Tests: compositor test now pass
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 2 Oct 2011 01:13:04 +0000 (01:13 +0000)]
Leopard build fix: Updated for Strong<T> changes.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
* WebView/WebScriptDebugger.mm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Sun, 2 Oct 2011 00:54:56 +0000 (00:54 +0000)]
Removed redundant helper functions for allocating Strong handles
https://bugs.webkit.org/show_bug.cgi?id=69218
Reviewed by Sam Weinig.
../JavaScriptCore:
* heap/Heap.h:
(JSC::Heap::handleHeap):
* runtime/JSGlobalData.h: Removed these helper functions, since they
just created indirection.
* heap/StrongInlines.h: Added. Broke out a header for inline functions
to resolve circular dependencies created by inlining. I'm told this is
the future for JavaScriptCore.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj: Go forth and build.
* API/JSCallbackObjectFunctions.h:
(JSC::::init):
* runtime/WeakGCMap.h:
(JSC::WeakGCMap::add):
(JSC::WeakGCMap::set):
* runtime/StructureTransitionTable.h:
(JSC::StructureTransitionTable::setSingleTransition):
* heap/Local.h:
(JSC::::Local):
* heap/Strong.h:
(JSC::::Strong):
(JSC::::set):
* heap/Weak.h:
(JSC::Weak::Weak):
(JSC::Weak::set): Allocate handles directly instead of going through a
chain of forwarding functions.
* bytecompiler/BytecodeGenerator.cpp:
* runtime/JSGlobalData.cpp:
* runtime/LiteralParser.cpp:
* runtime/RegExpCache.cpp: Updated for header changes.
../JavaScriptGlue:
* JSRun.cpp:
* JSValueWrapper.cpp:
../WebCore:
* ForwardingHeaders/heap/StrongInlines.h: Added.
* bindings/js/JSCallbackData.h:
* bindings/js/JSDOMWindowShell.cpp:
* bindings/js/ScheduledAction.h:
* bindings/js/ScriptCachedFrameData.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptState.cpp:
* bindings/js/ScriptValue.h:
* bindings/js/WorkerScriptController.cpp:
* bridge/runtime_root.cpp:
../WebKit2:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 1 Oct 2011 22:08:07 +0000 (22:08 +0000)]
Added myself to reviewers, because I'm now a reviewer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 1 Oct 2011 22:03:22 +0000 (22:03 +0000)]
All of JSC's heuristics should be in one place for easier tuning
https://bugs.webkit.org/show_bug.cgi?id=69201
Reviewed by Oliver Hunt.
This makes it possible to change tiered compilation heuristics in
one place (Heuristics.cpp) without recompiling the whole project.
It also makes it possible to enable setting heuristics using
environment variables. This is off by default. When turned on, it
makes tuning the system much easier.
* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.pro:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* runtime/Heuristics.cpp: Added.
(JSC::Heuristics::parse):
(JSC::Heuristics::setHeuristic):
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h: Added.
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 1 Oct 2011 21:58:45 +0000 (21:58 +0000)]
Bencher script makes it difficult to do automated performance testing
https://bugs.webkit.org/show_bug.cgi?id=69207
Reviewed by Sam Weinig.
This adds two new features:
The ability to disable automatic VM detection, which is flaky if any
profiling features are enabled in jsc.
The ability to compute, and report, a scaled result for all benchmark
suites. It is the geometric mean of three numbers: SunSpider's
arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
It is also possible to turn off all other output from bencher and just
get this number with the --brief option.
* Scripts/bencher:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Sat, 1 Oct 2011 21:46:51 +0000 (21:46 +0000)]
Support string length in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69215
Reviewed by Geoff Garen.
Adds a GetStringLength node to the DFG so that we can support
string.length inline.
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isKnownString):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSString.h:
(JSC::JSString::offsetOfLength):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 1 Oct 2011 20:48:57 +0000 (20:48 +0000)]
WTR is not successfully changing the NSUserDefaults
https://bugs.webkit.org/show_bug.cgi?id=69204
Reviewed by Dan Bernstein.
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):
Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
get our overrides picked up.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 19:56:47 +0000 (19:56 +0000)]
Delete bogus text expectation.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Oct 2011 19:21:44 +0000 (19:21 +0000)]
JSVALUE32_64 DFG JIT - unboxed integers and cells in register file must be reboxed before exiting from DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69205
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-01
Reviewed by Gavin Barraclough.
If there are unboxed integers and cells in register file (e.g. by SetLocal),
they must be reboxed before exiting from the speculative DFG JIT execution.
This patch also adds a new ValueSourceKind (CellInRegisterFile) and a new
ValueRecoveryTechnique (AlreadyInRegisterFileAsCell).
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::ValueSource::dump):
(JSC::DFG::ValueRecovery::dump):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueRecovery::alreadyInRegisterFileAsUnboxedCell):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 17:32:10 +0000 (17:32 +0000)]
Note test as timing out.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 17:29:56 +0000 (17:29 +0000)]
Update Mac baselines.
* platform/chromium-cg-mac-leopard/fast/css/last-of-type-pseudo-class-expected.txt: Added.
* platform/chromium-cg-mac-leopard/http/tests/misc/acid3-expected.txt: Removed.
* platform/chromium-cg-mac-leopard/svg/as-object: Added.
* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.png: Added.
* platform/chromium-cg-mac-leopard/svg/as-object/embedded-svg-immediate-offsetWidth-query-expected.txt: Added.
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-cg-mac/http/tests/misc/acid3-expected.txt: Removed.
* platform/chromium-mac/http/tests/misc/acid3-expected.png:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Oct 2011 07:22:29 +0000 (07:22 +0000)]
Unreviewed, rolling out r96421.
http://trac.webkit.org/changeset/96421
https://bugs.webkit.org/show_bug.cgi?id=69206
It broke Qt-WK2 build (Requested by ossy on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-01
Source/JavaScriptCore:
* JavaScriptCore.pri:
* wtf/qt/UtilsQt.h: Removed.
* wtf/wtf.pri:
Source/WebCore:
* WebCore.pro:
Source/WebKit/qt:
* Api/qwebpage.cpp:
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::setToolTip):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Sat, 1 Oct 2011 03:15:10 +0000 (03:15 +0000)]
[chromium] Track separate scroll deltas on the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=69034
Reviewed by James Robinson.
Source/WebCore:
Test: new tests in CCLayerTreeHostImplTest/CCLayerTreeHostTest
Track scroll deltas and maximum scrolls on LayerChromium/CCLayerImpl.
The CCLayerImpl tree is now able to adjust these scroll deltas
independent of the main thread. To push them back to the main thread,
CCLayerTreeHostImpl collects them all and then bakes them into the
scroll position during a begin frame and commit call. This allows new
deltas to be collected while the scroll position containing the old
delta and the old scroll position will be overwritten during the next
commit.
Only the main frame is supported right now for pushing this scroll
delta back into the authoritative WebKit source to keep both sides in
sync.
Move tilingTransform() to the impl tree because drawTransform() is now
updated using scroll deltas and so the results from calculating draw
transforms needs to be dynamic so that children are updated properly.
Also, exposed DebugScopedSetImplThread public because it's used in a
few places.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::maxScrollPosition):
(WebCore::LayerChromium::setMaxScrollPosition):
(WebCore::LayerChromium::scrollDelta):
(WebCore::LayerChromium::scrollable):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setViewport):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/TiledLayerChromium.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::scrollBy):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::maxScrollPosition):
(WebCore::CCLayerImpl::setMaxScrollPosition):
(WebCore::CCLayerImpl::scrollDelta):
(WebCore::CCLayerImpl::setScrollDelta):
(WebCore::CCLayerImpl::scrollable):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCProxy.h:
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::start):
(WebCore::CCSingleThreadProxy::context):
(WebCore::CCSingleThreadProxy::finishAllRendering):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::setNeedsCommit):
(WebCore::CCSingleThreadProxy::stop):
(WebCore::CCSingleThreadProxy::recreateContextIfNeeded):
(WebCore::CCSingleThreadProxy::commitIfNeeded):
(WebCore::CCSingleThreadProxy::doComposite):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore::DebugScopedSetImplThread::DebugScopedSetImplThread):
(WebCore::DebugScopedSetImplThread::~DebugScopedSetImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::createBeginFrameAndCommitTaskOnCCThread):
(WebCore::CCThreadProxy::beginFrameAndCommit):
* platform/graphics/chromium/cc/CCThreadProxy.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
(WebCore::CCTiledLayerImpl::draw):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
Add testing support for scroll deltas on layers.
* WebKit.gypi:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyScrollDelta):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostImplTest.cpp: Added.
(WebCore::CCLayerTreeHostImplTest::CCLayerTreeHostImplTest):
(WebCore::CCLayerTreeHostImplTest::expectClearedScrollDeltasRecursive):
(WebCore::CCLayerTreeHostImplTest::expectContains):
(WebCore::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::applyScrollDelta):
(WTF::MockLayerTreeHostClient::applyScrollDelta):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestThreadOnly::runTest):
(WTF::CCLayerTreeHostTestScrollSimple::CCLayerTreeHostTestScrollSimple):
(WTF::CCLayerTreeHostTestScrollSimple::beginTest):
(WTF::CCLayerTreeHostTestScrollSimple::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollSimple::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollSimple::afterTest):
(WTF::TEST_F):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::CCLayerTreeHostTestScrollMultipleRedraw):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginTest):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::applyScrollDelta):
(WTF::CCLayerTreeHostTestScrollMultipleRedraw::afterTest):
* tests/TreeSynchronizerTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 1 Oct 2011 03:12:37 +0000 (03:12 +0000)]
2011-09-30 Daniel Bates <dbates@webkit.org>
Attempt to fix the Apple Windows and WinCairo Debug builds after
<http://trac.webkit.org/changeset/96446> (https://bugs.webkit.org/show_bug.cgi?id=69203).
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Remove the symbol
?toStrictThisObject@JSObject@JSC@@UBE?AVJSValue@2@PAVExecState@2@@Z since the
corresponding function, JSValue::toStrictThisObject(), was removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 1 Oct 2011 03:07:46 +0000 (03:07 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69202
[CSS3 Regions] Make positioned objects use the first region as the ICB when it
is their containing block. Make sure static distance computations take into
account the current region as well.
Reviewed by Sam Weinig.
Source/WebCore:
Added new tests in fast/regions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustPositionedBlock):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::startOffsetForContent):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::computeInlineStaticDistance):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::computeLogicalTopPositionedOffset):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::contentLogicalWidthOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalHeightOfFirstRegion):
(WebCore::RenderFlowThread::contentLogicalLeftOfFirstRegion):
* rendering/RenderFlowThread.h:
LayoutTests:
* fast/regions/positioned-objects-block-static-in-regions.html: Added.
* fast/regions/positioned-objects-block-static-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-in-regions.html: Added.
* fast/regions/positioned-objects-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-inline-static-in-regions.html: Added.
* fast/regions/positioned-objects-inline-static-in-rtl-regions.html: Added.
* fast/regions/positioned-objects-perpendicular-flows-in-regions.html: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt: Added.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.png: Added.
* platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Oct 2011 02:14:36 +0000 (02:14 +0000)]
DFG operation results are not set correctly in JSVALUE32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69126
Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-09-30
Reviewed by Gavin Barraclough.
The setupResults routine has the bug of reversing the source and destination.
Also some other trivial (but stupid) bugs need to be fixed in JSVALUE32_64 DFG JIT.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::setupTwoStubArgs):
(JSC::DFG::setupResults):
* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):
(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompare):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Oct 2011 02:12:06 +0000 (02:12 +0000)]
Adding unit tests for LayerChromium. Emphasis on verifying
behavior of notifySyncRequired callback and tree manipulations.
https://bugs.webkit.org/show_bug.cgi?id=68572
Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-30
Reviewed by James Robinson.
* WebKit.gypi:
* tests/LayerChromiumTest.cpp: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 1 Oct 2011 01:43:20 +0000 (01:43 +0000)]
Implement currentColor support for CSS gradients
https://bugs.webkit.org/show_bug.cgi?id=58730
Patch by David Barr <davidbarr@chromium.org> on 2011-09-30
Reviewed by Adam Barth.
Source/WebCore:
Allow currentColor as a CSS3 gradient color-stop.
Test: fast/css/linear-gradient-currentcolor.html
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::isCacheable): Make currentColor uncacheable since the
background image may be invalidated if currentColor is used as a gradient stop and
the value of the 'color' property changes.
* css/CSSParser.cpp:
(WebCore::parseGradientColorOrKeyword): Accept the currentColor keyword.
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image): Initialize document styleSelector so that
currentColor may be computed for a StyleGeneratedImage.
LayoutTests:
* fast/css/linear-gradient-currentcolor-expected.txt: Added.
* fast/css/linear-gradient-currentcolor.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/css/linear-gradient-currentcolor-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Sat, 1 Oct 2011 01:40:31 +0000 (01:40 +0000)]
Cleanup: Extract code to launch a Mac WebKit application into a common function
https://bugs.webkit.org/show_bug.cgi?id=68662
Reviewed by Adam Roben.
Extracts common code to launch a WebKit application on Mac OS X into a function
so that we can remove duplicate code.
* Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
* Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
(runMacWebKitApp): Added.
(runSafari): Modified to use webkitdirs::runMacWebKitApp().
(runMiniBrowser): Ditto.
(runWebKitTestRunner): Ditto.
(runTestWebKitAPI): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 01:37:02 +0000 (01:37 +0000)]
Update baseline for this test on Leopard.
* platform/chromium-cg-mac-leopard/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 1 Oct 2011 01:29:34 +0000 (01:29 +0000)]
Remove toStrictThisObject, toThisString, toThisJSString
https://bugs.webkit.org/show_bug.cgi?id=69203
Rubber stamped by Sam Weinig
These are no longer used.
../JavaScriptCore:
* JavaScriptCore.exp:
* runtime/JSActivation.cpp:
* runtime/JSActivation.h:
* runtime/JSObject.cpp:
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
* runtime/JSStaticScopeObject.h:
* runtime/JSValue.h:
* runtime/StrictEvalActivation.cpp:
* runtime/StrictEvalActivation.h:
../WebCore:
* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 01:17:06 +0000 (01:17 +0000)]
Remove ASSERT introduced in trac.webkit.org/changeset/96427
which is triggering all over the place.
Sorting this out is covered in this bug:
https://bugs.webkit.org/show_bug.cgi?id=69200
* rendering/RenderView.cpp:
(WebCore::RenderView::layout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 1 Oct 2011 01:08:15 +0000 (01:08 +0000)]
watchlist: Add webkit-patch command to run watchlist.
https://bugs.webkit.org/show_bug.cgi?id=68973
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/host.py: Exposed the watch_list.
* Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
the cc and messages as sorted lists. To allow for deterministic ordering.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
* Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
that it will be exposed as a command by webkit-patch.
* Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
* Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
* Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
* Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
* Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
* Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
* Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
* Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Sat, 1 Oct 2011 00:58:15 +0000 (00:58 +0000)]
DFG does not speculate aggressively enough on put_by_id
https://bugs.webkit.org/show_bug.cgi?id=69114
Reviewed by Oliver Hunt.
This adds new nodes along with optimizations for those nodes:
GetPropertyStorage: CheckStructure used to do both the structure
check and retrieve the storage pointer. Now CheckStructure just
checks the structure, and GetPropertyStorage retrieves the
storage pointer.
PutStructure: Changes the structure, and has the expected store
to load optimization with CheckStructure.
PutByOffset: Directly sets the value. Has store to load
optimization with GetByOffset.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::cellConstant):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::writeBarrier):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGNode.h:
(JSC::DFG::Node::hasStructure):
(JSC::DFG::Node::hasStorageAccessData):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::impureCSE):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::eliminate):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 1 Oct 2011 00:46:50 +0000 (00:46 +0000)]
Unreviewed, rolling out r96426.
http://trac.webkit.org/changeset/96426
https://bugs.webkit.org/show_bug.cgi?id=69199
Broke a zillion image results on Chromium Skia Mac (Requested
by abarth|gardener on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-30
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Sat, 1 Oct 2011 00:39:52 +0000 (00:39 +0000)]
watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
https://bugs.webkit.org/show_bug.cgi?id=69031
Reviewed by Adam Barth.
* Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
a comment to explain something important about the email addresses, and
a comment to let emacs know to treat the file as a python file.
* Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
Detects increases or decreases in a pattern.
* Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
* Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
Added unit tests for watchlist which has "more" or "less".
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
Added support for "more" or "less".
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
isherman@chromium.org [Sat, 1 Oct 2011 00:25:09 +0000 (00:25 +0000)]
Fix assertion failure in XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=69050
https://code.google.com/p/chromium/issues/detail?id=97346
Reviewed by Daniel Bates.
Source/WebCore:
Test: fast/forms/xss-auditor-doesnt-crash.html
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init): Don't try to decode the HTML body if it is empty.
LayoutTests:
* fast/forms/xss-auditor-doesnt-crash-expected.txt: Added.
* fast/forms/xss-auditor-doesnt-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 1 Oct 2011 00:16:48 +0000 (00:16 +0000)]
Add support for eventSender.mouseScrollBy in WTR
https://bugs.webkit.org/show_bug.cgi?id=69189
Source/WebKit2:
Reviewed by Simon Fraser.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::wheelEventSyncForTesting):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
Add sync version of wheel event handling for use in testing.
Tools:
Add implementation of eventSender.mouseScrollBy for the mac.
Reviewed by Simon Fraser.
* WebKitTestRunner/EventSenderProxy.h:
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::mouseScrollBy):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
LayoutTests:
Reviewed by Simon Fraser.
* platform/mac-wk2/Skipped:
Removes tests that used eventSender.mouseScrollBy.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 30 Sep 2011 23:54:44 +0000 (23:54 +0000)]
StringRecursionChecker should not work in terms of EncodedJSValue
https://bugs.webkit.org/show_bug.cgi?id=69188
Reviewed by Oliver Hunt.
0 is not the empty value on 32_64.
Code that casts literals to EncodedJSValues may be unsafe if we change our internal representation.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
* runtime/ErrorPrototype.cpp:
(JSC::errorProtoFuncToString):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncToString):
* runtime/StringRecursionChecker.cpp:
(JSC::StringRecursionChecker::throwStackOverflowError):
(JSC::StringRecursionChecker::emptyString):
* runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::earlyReturnValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Fri, 30 Sep 2011 23:30:59 +0000 (23:30 +0000)]
Loading page on potterybankids causes reproducible assertion failure in debug builds
https://bugs.webkit.org/show_bug.cgi?id=69185
<rdar://problem/
10218241>
Reviewed by Simon Fraser.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeRepaintRects): Remove assert condition that isn't guaranteed
to be true.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 30 Sep 2011 23:05:59 +0000 (23:05 +0000)]
DFG JIT, Branch on integer can always be a 32-bit compare.
https://bugs.webkit.org/show_bug.cgi?id=69174
Reviewed by Sam Weinig.
if (shouldSpeculateInteger(node.child1()) && !isStrictInt32(node.child1())),
the JSVALUE64 JIT will currently compare all 64bits in the register, but in
these cases the DataFormat is always a JS boxed integer. In these cases we
can just compare the low 32bits anyway - no need to check the tag.
This allows the code to be unified with the JSVALUE32_64 JIT.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Fri, 30 Sep 2011 23:01:23 +0000 (23:01 +0000)]
[Qt] Add missing include for QMimeData
https://bugs.webkit.org/show_bug.cgi?id=69178
Reviewed by Tor Arne Vestbø.
This was implicitly included by other headers, but due to changes in
Qt5 we need to include explicitly.
* UIProcess/qt/QtWebPageProxy.cpp:
* WebProcess/WebPage/WebPage.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 30 Sep 2011 22:53:53 +0000 (22:53 +0000)]
fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
https://bugs.webkit.org/show_bug.cgi?id=35273
Reviewed by Dan Bernstein.
There are two types of font issue that can cause layout test failure.
First, the user may have non-standard fonts installed that affect the layout
of some tests. For example, some tests use the MS Gothic font if installed.
Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
which override the system fonts (e.g. a copy of Arial from MS Office). For
some tests, this can affect font metrics or fallback behavior.
This change addresses the first problem only. It limits the set of fonts
available through NSFontManager, by swizzling some methods to return
a list of fonts or font families which only include fonts from a hardcoded
whitelist.
* DumpRenderTree/mac/DumpRenderTree.mm:
(allowedFontFamilySet):
(drt_NSFontManager_availableFontFamilies):
(drt_NSFontManager_availableFonts):
(swizzleNSFontManagerMethods):
(activateTestingFonts):
(adjustFonts):
(createWebViewAndOffscreenWindow):
(prepareConsistentTestingEnvironment):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::allowedFontFamilySet):
(WTR::drt_NSFontManager_availableFontFamilies):
(WTR::drt_NSFontManager_availableFonts):
(WTR::swizzleNSFontManagerMethods):
(WTR::InjectedBundle::platformInitialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jnd@chromium.org [Fri, 30 Sep 2011 22:31:01 +0000 (22:31 +0000)]
Source/WebCore: Support -webkit-tap-highlight-color when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544
Reviewed by Kenneth Rohde Christiansen.
Original code from the iOS WebCore code dump, extracted and modified by tijiang@rim and jnd@chromium.
Supports the new CSS property -webkit-tap-highlight-color on platforms which support touch events.
Platform can override WebCore::RenderTheme::platformTapHighlightColor to use its own platform
specific default tap highlight color. Otherwise RenderTheme::defaultTapHighlightColor will be
used as default tap highlight color.
Test: fast/events/touch/tap-highlight-color.html
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::tapHighlightColor):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::platformTapHighlightColor):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::initialTapHighlightColor):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::tapHighlightColor):
(WebCore::InheritedFlags::setTapHighlightColor):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
LayoutTests: Support -webkit-tap-highlight-color in WebCore when enabling touch events support.
https://bugs.webkit.org/show_bug.cgi?id=48544.
Reviewed by Kenneth Rohde Christiansen.
Add a layout test to get customized tap highlight color set by page author.
* fast/css/getComputedStyle/computed-style-without-renderer.html:
* fast/css/getComputedStyle/computed-style.html:
* fast/events/touch/script-tests/tap-highlight-color.js: Added.
(onTouchStart):
(touchTargets):
* fast/events/touch/tap-highlight-color-expected.txt: Added.
* fast/events/touch/tap-highlight-color.html: Added.
* svg/css/getComputedStyle-basic.xhtml:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 30 Sep 2011 22:23:33 +0000 (22:23 +0000)]
2011-09-30 Oliver Hunt <oliver@apple.com>
Need a sensible GGC policy
Reviewed by Geoff Garen.
This replaces the existing random collection policy
with a deterministic policy based on nursery size.
* heap/AllocationSpace.cpp:
(JSC::AllocationSpace::allocateSlowCase):
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::collect):
* heap/Heap.h:
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocator):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::nurseryWaterMark):
(JSC::MarkedSpace::allocate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc