commit-queue@webkit.org [Thu, 19 Jan 2012 04:02:28 +0000 (04:02 +0000)]
Remove some unused code in AudioContext
https://bugs.webkit.org/show_bug.cgi?id=76506
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-18
Reviewed by Kenneth Russell.
No new tests required.
* webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
(WebCore::AudioContext::uninitialize):
* webaudio/AudioContext.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105375
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 19 Jan 2012 03:28:57 +0000 (03:28 +0000)]
Fix path to chromium_src_dir introduced in previous change.
Unreviewed, build fix.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Jan 2012 03:22:57 +0000 (03:22 +0000)]
Only create AudioBus with required number of channels for AudioNodeOutput
https://bugs.webkit.org/show_bug.cgi?id=76417
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-01-18
Reviewed by Kenneth Russell.
No new tests required.
* webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::setNumberOfChannels):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::updateNumberOfChannels):
(WebCore::AudioNodeOutput::pull):
* webaudio/AudioNodeOutput.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105373
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 19 Jan 2012 02:55:03 +0000 (02:55 +0000)]
Cache and reuse the NodeList returned by Node::childNodes().
<http://webkit.org/b/76591>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Instead of only caching the DynamicNodeList::Caches for .childNodes on NodeRareData,
cache the full ChildNodeList object. Lifetime management is left to wrappers who
invalidate the cached (raw) pointer via Node::removeCachedChildNodeList(), called
from ~ChildNodeList().
This is a slight behavior change, in that Node.childNodes === Node.childNodes will
now be true. This matches the behavior of both Firefox and Opera.
This reduces memory consumption by 192 kB (on 32-bit) when viewing the full
HTML5 spec at <http://whatwg.org/c>
Test: fast/dom/gc-9.html
fast/dom/node-childNodes-idempotence.html
* dom/Node.cpp:
(WebCore::Node::childNodes):
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::childNodeList):
(WebCore::NodeRareData::setChildNodeList):
Only construct one ChildNodeList per Node and store it on NodeRareData for
retrieval across childNodes() calls.
* dom/ChildNodeList.h:
(WebCore::ChildNodeList::create):
* dom/ChildNodeList.cpp:
(WebCore::ChildNodeList::ChildNodeList):
Construct the Caches at creation instead of passing it to the constructor.
(WebCore::ChildNodeList::reset):
Added, resets the internal cache.
(WebCore::ChildNodeList::~ChildNodeList):
Call Node::removeCachedChildNodeList().
* dom/DynamicNodeList.cpp:
* dom/DynamicNodeList.h:
Have DynamicNodeList (and subclasses) respond "true" to isDynamicNodeList().
Previously only DynamicSubtreeNodeList (and subclasses) were doing this.
Without it, JSC may GC our ChildNodeLists prematurely (due to NodeList's
isReachableFromOpaqueRoots() implementation checking isDynamicNodeList().)
* dom/Node.h:
* dom/Node.cpp:
(WebCore::Node::removeCachedChildNodeList):
Added for ~ChildNodeList() to remove the pointer to itself from the Node.
(WebCore::NodeRareData::clearChildNodeListCache):
Call ChildNodeList::reset().
LayoutTests:
Updated gc-9.html to document the new lifetime characteristics of a .childNodes with
custom properties. Also added a test to verify that .childNodes === .childNodes.
* fast/dom/gc-9-expected.txt:
* fast/dom/gc-9.html:
* fast/dom/node-childNodes-idempotence-expected.txt: Added.
* fast/dom/node-childNodes-idempotence.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105372
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 19 Jan 2012 02:39:04 +0000 (02:39 +0000)]
Unreviewed, rolling out r105366.
http://trac.webkit.org/changeset/105366
https://bugs.webkit.org/show_bug.cgi?id=76015
Breaks CCLayerTreeHostImplTest unit test
Source/WebCore:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::drawsOpaque):
(WebCore::CCDrawQuad::needsBlending):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
* platform/graphics/chromium/cc/CCSolidColorDrawQuad.cpp:
(WebCore::CCSolidColorDrawQuad::CCSolidColorDrawQuad):
* platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
* platform/graphics/chromium/cc/CCTileDrawQuad.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::syncTextureId):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
* tests/CCQuadCullerTest.cpp:
(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
* tests/CCTiledLayerImplTest.cpp:
(WebCore::createLayer):
(WebCore::TEST):
(WebCore::getQuads):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105371
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Jan 2012 02:02:04 +0000 (02:02 +0000)]
Save two ID checks on CSS Min/Width property validation
https://bugs.webkit.org/show_bug.cgi?id=76565
The same validation is done again in the next case statement. Check for
CSSValueIntrinsic and CSSValueMinIntrinsic was done twice when the value
is a number.
Patch by Thiago Marcos P. Santos <tmpsantos@gmail.com> on 2012-01-18
Reviewed by Andreas Kling.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105370
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 19 Jan 2012 01:54:40 +0000 (01:54 +0000)]
Need infrastructure to test Content-Disposition filename encoding support
https://bugs.webkit.org/show_bug.cgi?id=76572
<rdar://problem/6421825>
Reviewed by Sam Weinig.
Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
WebKitTestRunner does not have a policy delegate yet, bug 42546.
* DumpRenderTree/mac/PolicyDelegate.mm:
(dispositionTypeFromContentDispositionHeader):
(-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105369
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 19 Jan 2012 01:53:12 +0000 (01:53 +0000)]
Another build fix for r105364.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Missing #if.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105368
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 19 Jan 2012 01:44:29 +0000 (01:44 +0000)]
Build fix for r105364. Unreviewed.
* WebProcess/Notifications/WebNotificationManager.cpp: Wrap methods in #if ENABLE(NOTIFICATIONS)
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision):
(WebKit::WebNotificationManager::didRemoveNotificationDecisions):
(WebKit::WebNotificationManager::policyForOrigin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105367
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 19 Jan 2012 01:42:30 +0000 (01:42 +0000)]
[chromium] Use region reported painted opaque for draw culling
https://bugs.webkit.org/show_bug.cgi?id=76015
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
New unit tests in CCQuadCullerTest.cpp and CCTiledLayerImplTest.cpp
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore::CCDrawQuad::opaqueRect):
(WebCore::CCDrawQuad::needsBlending):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
(WebCore::CCQuadCuller::cullOccludedQuads):
* platform/graphics/chromium/cc/CCTileDrawQuad.cpp:
(WebCore::CCTileDrawQuad::create):
(WebCore::CCTileDrawQuad::CCTileDrawQuad):
* platform/graphics/chromium/cc/CCTileDrawQuad.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::DrawableTile::opaqueRect):
(WebCore::DrawableTile::setOpaqueRect):
(WebCore::CCTiledLayerImpl::appendQuads):
(WebCore::CCTiledLayerImpl::pushTileProperties):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
Source/WebKit/chromium:
* tests/CCQuadCullerTest.cpp:
(WebCore::TestDrawQuad::TestDrawQuad):
(WebCore::TestDrawQuad::create):
(WebCore::setQuads):
(WebCore::TEST):
* tests/CCTiledLayerImplTest.cpp:
(WebCore::createLayer):
(WebCore::TEST):
(WebCore::getQuads):
(WebCore::coverageVisibleRectOnTileBoundaries):
(WebCore::coverageVisibleRectIntersectsTiles):
(WebCore::coverageVisibleRectIntersectsBounds):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105366
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vrk@chromium.org [Thu, 19 Jan 2012 01:19:29 +0000 (01:19 +0000)]
HTMLMediaElement should fire 'progress' event before 'idle' if it was previously loading
https://bugs.webkit.org/show_bug.cgi?id=76568
Reviewed by Eric Carlson.
This fires a progress event when going from a non-empty state to idle,
for the same reason that a progress event is fired when going from a
non-idle state to loaded. Also consolidated logic in a single helper method.
No new tests because the decision of if/when a user agent sets the network state
to idle is up to the user agent in this scenario.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setNetworkState):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
* html/HTMLMediaElement.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105365
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 19 Jan 2012 01:14:55 +0000 (01:14 +0000)]
[WK2] Sync call for notifications permissions causes flashes on gmail.com
https://bugs.webkit.org/show_bug.cgi?id=76570
<rdar://problem/
10647155>
Reviewed by Anders Carlsson and Sam Weinig.
Source/WebCore:
* WebCore.exp.in: Export SecurityOrigin::toString().
Add runtime setting to enable/disable notifications.
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h: Add new bit for whether notifications are enabled.
(WebCore::Settings::setNotificationsEnabled):
(WebCore::Settings::notificationsEnabled):
Source/WebKit2:
The website code figures out the permission level for its security origin by making a JS call (called
checkPermission()) that is synchronous. The way this was implemented was to make a synchronous call from
the WebNotificationManager to its proxy. That call goes to the WK API layer to find the policy, and
returns that policy back to the JS.
The synchronous nature of this call causes the white flash to appear in certain cases.
To fix this, the checkPermission() call is handled all within the web process, instead of going up into
the UI process. To do this, the web process initializes the WebNotificationManager with a copy of the
notification permissions. Any time the WK client makes a change to the permissions, that gets sent down
asynchronously, and the cached copy in WebNotificationManager gets updated.
A page's settings may disable notifications altogether. Before, this would have been handled by the WK
client, since retrieving the permissions were also handled there. Now that the lookup happens in the web
process, we need to add that setting in WebCore.
== Update notification permissions to use the security origin's string representation, rather than its
database identifier.
* UIProcess/Notifications/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
* UIProcess/Notifications/WebNotification.h:
(WebKit::WebNotification::create):
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::show): Registering the provider with the manager is handled in
initialize() now.
(WebKit::WebNotificationManagerProxy::cancel): Registering the provider with the manager is handled in
initialize() now.
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestNotificationPermission):
(WebKit::WebPageProxy::showNotification):
* UIProcess/WebPageProxy.h:
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::startRequest): Only start the request if notifications
are enabled.
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::show): Only show notification is they are enabled.
(WebKit::WebNotificationManager::cancel): Only cancel if notifications are enabled.
== Remove synchronous message to get policy for a given origin. Instead, use the cached copy in
WebNotificationManager.
* WebProcess/Notifications/WebNotificationManager.h:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::policyForOrigin): Looks for the permission in the cached copy.
If it doesn't exist, return NotificationPresenter::PermissionNotAllowed.
* WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
(WebKit::NotificationPermissionRequestManager::permissionLevel): Update permissionLevel to use
policyForOrigin().
Remove old WK API function to get the policy. Because this function was the only synchronous message,
we remove the sync-message-related functions also. Also, add in some #includes that might have been
omitted in prior patches.
* UIProcess/API/C/WKNotificationProvider.h:
* UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Remove NotificationPermissionLevel.
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
* UIProcess/Notifications/WebNotificationProvider.h: Remove policyForNotificationPermissionAtOrigin().
* UIProcess/Notifications/WebNotificationProvider.cpp:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage): Remove conditional to forward sync messages to the
notification manager proxy.
== Mechanism for client to update the permissions copy in WebNotificationManager.
* WebProcess/Notifications/WebNotificationManager.messages.in: Add new messages
didUpdateNotificationDecision and didRemoveNotificationDecisions.
* WebProcess/Notifications/WebNotificationManager.h:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize):
(WebKit::WebNotificationManager::didUpdateNotificationDecision): Update the entry.
(WebKit::WebNotificationManager::didRemoveNotificationDecisions): Remove the entry.
* UIProcess/Notifications/WebNotificationManagerProxy.h:
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies): Convert the array of
origins to remove, and send it to the WebNotificationManager.
* UIProcess/API/C/WKNotificationManager.h: Expose these update functions as WK API.
* UIProcess/API/C/WKNotificationManager.cpp:
(WKNotificationManagerProviderDidUpdateNotificationPolicy):
(WKNotificationManagerProviderDidRemoveNotificationPolicies):
== Initialize WebNotificationManager with permissions. Initialize WebPage with notifications enabled bit
from settings.
* Shared/WebProcessCreationParameters.h: Add map of notification permissions as part of the
parameters.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* UIProcess/Notifications/WebNotificationProvider.h: Retrieve copy of existing notification permissions.
* UIProcess/Notifications/WebNotificationProvider.cpp:
* UIProcess/API/C/WKNotificationProvider.h: Add WK API to get a copy of the permissions.
* UIProcess/Notifications/WebNotificationManagerProxy.h: Add populateCopyOfNotificationPermissions().
* UIProcess/Notifications/WebNotificationManagerProxy.cpp:
(WebKit::WebNotificationManagerProxy::initializeProvider): Add the manager at the time of initialization.
Similar calls in show() and cancel() are removed in following patch.
(WebKit::WebNotificationManagerProxy::populateCopyOfNotificationPermissions): Clear the existing copy.
Populate with origin string, and whether that origin is allowed to post. If no decision has been made
by the user, then there should be no item in this dictionary.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess): When the web process is initialized, we get a copy of the
permissions, and send it to the web process to initialize the notification manager.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize the notification manager.
* WebProcess/Notifications/WebNotificationManager.h:
* WebProcess/Notifications/WebNotificationManager.cpp:
(WebKit::WebNotificationManager::initialize): Initialize the permissions copy.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Set notifications enabled bit from settings.
== Expose toString() method from WebCore::SecurityOrigin. Work is also towards bug 74956.
* Shared/API/c/WKSecurityOrigin.h: Refactor WKSecurityOriginCreateFromIdentifier to
WKSecurityOriginCreateFromDatabaseIdentifier and add WKSecurityOriginCreateFromString function.
* Shared/API/c/WKSecurityOrigin.cpp:
(WKSecurityOriginCreateFromString):
(WKSecurityOriginCreateFromDatabaseIdentifier):
(WKSecurityOriginCopyToString):
Refactor WebSecurityOrigin::create() to WebSecurityOrigin::createFromDatabaseIdentifier()
and add WebSecurityOrigin::createFromString().
* Shared/WebSecurityOrigin.h:
(WebKit::WebSecurityOrigin::createFromString):
(WebKit::WebSecurityOrigin::createFromDatabaseIdentifier):
(WebKit::WebSecurityOrigin::toString): Added function.
Refactor with renamed createFromDatabaseIdentifier() method.
* UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::didModifyOrigin):
(WebKit::WebDatabaseManagerProxy::didModifyDatabase):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):
== Add WK API calls to change notificationsEnabled bit in WebCore::Settings.
* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetNotificationsEnabled):
(WKPreferencesGetNotificationsEnabled):
* UIProcess/API/C/WKPreferences.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105364
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 19 Jan 2012 01:11:06 +0000 (01:11 +0000)]
IndexedDB: Fix InjectIDBKeyTest.SubProperty test failure
https://bugs.webkit.org/show_bug.cgi?id=76582
Correct the test, now that https://bugs.webkit.org/show_bug.cgi?id=76493
changes the semantics so that intermediate objects are created if possible
to satisfy autoIncrement keypaths.
Patch by Joshua Bell <jsbell@chromium.org> on 2012-01-18
Reviewed by James Robinson.
* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105363
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 19 Jan 2012 00:16:50 +0000 (00:16 +0000)]
REGRESSION (r88886): Tabs restore blank when running Safari with a nightly build for the first time
https://bugs.webkit.org/show_bug.cgi?id=76587
<rdar://problem/9739135>
Reviewed by Sam Weinig.
* UIProcess/cf/WebPageProxyCF.cpp:
Change CurrentSessionStateDataVersion back to 2.
* WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::decodeString):
* WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::encodeString):
Backport the CoreIPC string encoding and decoding functions that were in place prior to r88886.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 19 Jan 2012 00:07:00 +0000 (00:07 +0000)]
Fix tests from trac.webkit.org/changeset/105332.
The code assumed that if you passed an options object with a configuration
attribute that it would have a valid value. A bunch of the testing mocks
do things like having a configuration value of None.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 23:40:25 +0000 (23:40 +0000)]
[chromium] Update a few chromium expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 18 Jan 2012 23:29:27 +0000 (23:29 +0000)]
Provide access to user's list of preferred languages
https://bugs.webkit.org/show_bug.cgi?id=76138
Reviewed by Timothy Hatcher.
No new tests, tested by fast/harness/user-preferred-language.html.
* platform/mac/Language.mm:
(WebCore::platformUserPreferredLanguages): Don't over-release a the CFStrings returned by
CFLocaleCopyPreferredLanguages.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Wed, 18 Jan 2012 23:14:56 +0000 (23:14 +0000)]
Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=76576
Reviewed by Adam Barth.
Avoid calling default_configuration in base.py. We don't need it for
checking test_expectations.txt style. It takes ~0.5 seconds to run on my
Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
from common.executive.
At some point someone should probably look into why that call is so slow
since it's on the critical path for run-webkit-tests and build-webkit startup.
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.__init__):
* Scripts/webkitpy/style/checkers/test_expectations.py:
(TestExpectationsChecker._determine_port_from_exepectations_path):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 18 Jan 2012 23:07:26 +0000 (23:07 +0000)]
IndexedDB: Implement create-intermediate-objects semantics when injecting values via keyPaths
https://bugs.webkit.org/show_bug.cgi?id=76493
Source/WebCore:
Reviewed by Tony Chang.
Tests: storage/indexeddb/objectstore-autoincrement.html
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoSerializedValue):
LayoutTests:
Per discussion on public-webapps, when injecting a key into a value, create intermediate
objects if necessary.
Reviewed by Tony Chang.
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 18 Jan 2012 23:03:04 +0000 (23:03 +0000)]
[chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
https://bugs.webkit.org/show_bug.cgi?id=76505
Reviewed by Tony Chang.
.:
Update with newly-generated files.
* .gitignore:
Source/WebKit/chromium:
Update path to Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp.
* All.gyp:
* gyp_webkit:
- change to using All.gyp
- change build_webkit_exes_from_webkit_gyp to 0
Tools:
Update chromium build script to use All.gyp instead of WebKit.gyp
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
* Scripts/webkitdirs.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 18 Jan 2012 22:58:56 +0000 (22:58 +0000)]
IndexedDB: Invalid keys yielded by key paths should raise exceptions, not error callbacks
https://bugs.webkit.org/show_bug.cgi?id=76075
Reviewed by Tony Chang.
Source/WebCore:
Tests: storage/indexeddb/objectstore-basics.html
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::put):
LayoutTests:
* storage/indexeddb/mozilla/bad-keypath-expected.txt:
* storage/indexeddb/mozilla/bad-keypath.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 22:49:59 +0000 (22:49 +0000)]
[chromium] Fix compile error from bug #76211
https://bugs.webkit.org/show_bug.cgi?id=76575
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
No new tests. Fixing compile only.
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerTextureUpdater::prepareToUpdate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 22:49:02 +0000 (22:49 +0000)]
[chromium] Update chromium linux pixel baseline for svg test
* platform/chromium-linux/svg/custom/linking-a-03-b-viewBox-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 18 Jan 2012 22:48:42 +0000 (22:48 +0000)]
[GTK] WebKit-3.0.gir does not include information about C includes or exported packages
https://bugs.webkit.org/show_bug.cgi?id=49875
Patch by Evan Nemerson <evan@coeus-group.com> on 2012-01-18
Reviewed by Martin Robinson.
* GNUmakefile.am: Add some information to the GIR generator to fix
Vala binding generation.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 18 Jan 2012 22:43:20 +0000 (22:43 +0000)]
Don’t hardcode the path to ‘make‘.
Patch by Sam Weinig <sam@webkit.org> on 2012-01-18
Reviewed by Dan Bernstein.
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dgrogan@chromium.org [Wed, 18 Jan 2012 22:39:19 +0000 (22:39 +0000)]
IndexedDB: Check for permission before using IndexedDB from a worker.
https://bugs.webkit.org/show_bug.cgi?id=76500
Reviewed by David Levin.
* src/IDBFactoryBackendProxy.cpp:
(WebKit::AllowIndexedDBMainThreadBridge::create):
(WebKit::AllowIndexedDBMainThreadBridge::cancel):
(WebKit::AllowIndexedDBMainThreadBridge::result):
(WebKit::AllowIndexedDBMainThreadBridge::signalCompleted):
(WebKit::AllowIndexedDBMainThreadBridge::AllowIndexedDBMainThreadBridge):
(WebKit::AllowIndexedDBMainThreadBridge::allowIndexedDBTask): Call
webView->permissionClient()->allowIndexedDB on the main thread because
ContentSettingsObserver::AllowIndexedDB(), which is called down the
chain, expects to be run on the main thread.
(WebKit::AllowIndexedDBMainThreadBridge::didComplete):
(WebKit::IDBFactoryBackendProxy::allowIDBFromWorkerThread): Wait for
main permission check to complete on main thread before proceeding on
worker thread.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 18 Jan 2012 22:37:34 +0000 (22:37 +0000)]
[Mac] Add a flag telling plug-in if it can enter sandbox
https://bugs.webkit.org/show_bug.cgi?id=76467
Reviewed by Anders Carlsson.
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue): Added a private flag.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Wed, 18 Jan 2012 22:34:51 +0000 (22:34 +0000)]
Adding myself to committers.py
https://bugs.webkit.org/show_bug.cgi?id=76569
Unreviewed.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 18 Jan 2012 22:32:25 +0000 (22:32 +0000)]
REGRESSION (r104000): AdBlock extension fails to load/function
https://bugs.webkit.org/show_bug.cgi?id=75554
Reviewed by Andy Estes.
Source/WebCore:
Previously, we would claim the documentElement was available before
we'd actually attached it to the DOM (which we now do via the
attachment queue). This issue was noted in the code with a FIXME
comment, but there was no test coverage for the issue. This patch
resolves the FIXME and adds a test.
Test: userscripts/document-element-available-at-start.html
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
LayoutTests:
This test checks that the documentElement is available when user
scripts are run at document start.
* userscripts/document-element-available-at-start-expected.txt: Added.
* userscripts/document-element-available-at-start.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 22:27:41 +0000 (22:27 +0000)]
[SKIA / CHROMIUM] Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469
Patch by Brian Salomon <bsalomon@google.com> on 2012-01-18
Reviewed by Stephen White.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 18 Jan 2012 22:13:41 +0000 (22:13 +0000)]
Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
https://bugs.webkit.org/show_bug.cgi?id=76567
Reviewed by Eric Seidel.
Current the AppleMac port has slightly more failures than we allow on
the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
which should hopefully let the mac-ews run to completion. Once
AppleMac has fewer failures, we can lower the cap again.
* Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
(LayoutTestResultsReaderTest.test_layout_test_results):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests):
* Scripts/webkitpy/tool/steps/steps_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tommyw@google.com [Wed, 18 Jan 2012 22:07:58 +0000 (22:07 +0000)]
[chromium] MediaStream API: Make WebMediaStreamDescriptor copyable
https://bugs.webkit.org/show_bug.cgi?id=76526
Reviewed by Darin Fisher.
This patch adds a copy constructor and a assignment operator to WebMediaStreamDescriptor.
* public/platform/WebMediaStreamDescriptor.h:
(WebKit::WebMediaStreamDescriptor::WebMediaStreamDescriptor):
(WebKit::WebMediaStreamDescriptor::operator=):
* src/WebMediaStreamDescriptor.cpp:
(WebKit::WebMediaStreamDescriptor::assign):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 21:58:03 +0000 (21:58 +0000)]
[Qt] REGRESSION(r105310): Two inspector tests fails
https://bugs.webkit.org/show_bug.cgi?id=76566
* platform/qt/Skipped: Skip failing tests to paint the bot green.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 21:47:47 +0000 (21:47 +0000)]
[chromium] Update expectations, add a few new baselines.
* platform/chromium/http/tests/misc/bubble-drag-events-expected.txt: Added.
* platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
* platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Wed, 18 Jan 2012 21:45:15 +0000 (21:45 +0000)]
Provide access to user's list of preferred languages
https://bugs.webkit.org/show_bug.cgi?id=76138
Reviewed by Alexey Proskuryakov.
.:
* Source/autotools/symbols.filter: List the new functions.
Source/WebCore:
Test: fast/harness/user-preferred-language.html
* WebCore.exp.in: Export the new functions.
* WebCore.order: Ditto.
* Target.pri: Include new files.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCoreTestSupport.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/Language.cpp:
(WebCore::defaultLanguage): Return userPreferredLanguages[0].
(WebCore::preferredLanguagesOverride): New, return the languages override.
(WebCore::overrideUserPreferredLanguages): New, set the languages override.
(WebCore::userPreferredLanguages): New, return the languages array.
* platform/Language.h:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* platform/chromium/LanguageChromium.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* platform/gtk/LanguageGtk.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* platform/mac/Language.mm:
(+[WebLanguageChangeObserver _webkit_languagePreferencesDidChange]): Flag the user languages
as invalid.
(WebCore::platformLanguage): Removed.
(WebCore::platformUserPreferredLanguages): New, return the list of user preferred languages.
* platform/qt/LanguageQt.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* platform/win/LanguageWin.cpp:
(WebCore::platformLanguage): Renamed from platformDefaultLanguage, now static.
(WebCore::platformUserPreferredLanguages): New.
* testing/Internals.cpp:
(WebCore::Internals::userPreferredLanguages): New, return the platform's user preferred languages.
(WebCore::Internals::setUserPreferredLanguages): New, override the user's preferred languages.
* testing/Internals.h:
* testing/Internals.idl: Add userPreferredLanguages.
* testing/js/JSInternalsCustom.cpp:
(WebCore::JSInternals::userPreferredLanguages): New.
(WebCore::JSInternals::setUserPreferredLanguages): New.
* testing/v8/V8InternalsCustom.cpp:
(WebCore::V8Internals::userPreferredLanguagesAccessorGetter): New.
(WebCore::V8Internals::userPreferredLanguagesAccessorSetter): New.
Source/WebKit2:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode): Encode the languages array.
(WebKit::WebProcessCreationParameters::decode): Decode the languages array.
* Shared/WebProcessCreationParameters.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::languageChanged): Override the WebProcess userPreferredLanguages.
(WebKit::WebContext::ensureWebProcess): Initialize parameters.languages.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess): Override user languages array.
(WebKit::WebProcess::userPreferredLanguagesChanged): Ditto.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in: Define UserPreferredLanguagesChanged.
* win/WebKit2.def: Export the new functions.
* win/WebKit2CFLite.def: Ditto.
Tools:
* GNUmakefile.am: Add JSInternalsCustom.cpp.
LayoutTests:
* fast/harness/user-preferred-language-expected.txt: Added.
* fast/harness/user-preferred-language.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 21:41:51 +0000 (21:41 +0000)]
[chromium] Enable tracking opaque region in Skia graphics context, return it from LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=76211
Patch by Dana Jansens <danakj@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
New unit tests in LayerTextureUpdaterTest.cpp
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/BitmapCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::BitmapSkPictureCanvasLayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/BitmapSkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerTextureUpdater.h:
(WebCore::LayerTextureUpdater::prepareToUpdate):
* platform/graphics/chromium/PlatformCanvas.h:
(WebCore::PlatformCanvas::Painter::skiaContext):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::SkPictureCanvasLayerTextureUpdater):
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):
(WebCore::SkPictureCanvasLayerTextureUpdater::setOpaque):
* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.h:
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::prepareToUpdateTiles):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/LayerTextureUpdaterTest.cpp: Added.
(WebCore::TestLayerPainterChromium::TestLayerPainterChromium):
(WebCore::TestLayerPainterChromium::paint):
(WebCore::PaintFillOpaque::operator()):
(WebCore::PaintFillAlpha::operator()):
(WebCore::TEST):
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeLayerTextureUpdater::prepareToUpdate):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 21:34:28 +0000 (21:34 +0000)]
[Qt] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76563
* platform/qt/Skipped: Skip http/tests/misc/iframe-invalid-source-crash.html until fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 21:23:34 +0000 (21:23 +0000)]
[chromium] Update pixel results due to skia roll
* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-leopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 21:03:19 +0000 (21:03 +0000)]
[chromium] Refactor canvas, plugin, and video drawing to be more data-driven
https://bugs.webkit.org/show_bug.cgi?id=76274
Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-18
Reviewed by James Robinson.
Source/WebCore:
This is the first step in refactoring canvas, plugin, and video drawing.
The CCCustomLayerDrawQuad implementation has been copied to CCCanvasDrawQuad, CCPluginDrawQuad and CCVideoDrawQuad.
All references to CustomLayer have been removed.
As this is a refactor, no new tests were added. CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers was modified to
no longer test culling.
* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCanvasQuad):
(WebCore::LayerRendererChromium::drawVideoQuad):
(WebCore::LayerRendererChromium::drawPluginQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):
* platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCCanvasDrawQuad::layer):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toCanvasDrawQuad):
(WebCore::CCDrawQuad::toVideoDrawQuad):
(WebCore::CCDrawQuad::toPluginDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):
* platform/graphics/chromium/cc/CCPluginDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCPluginDrawQuad::layer):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCVideoDrawQuad::layer):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:
Source/WebKit/chromium:
No longer test culling in CCLayerTreeHostImplTest.blendingOffWhenDrawingLayers.
* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setExpectation):
(WebKit::BlendStateCheckLayer::quadsAppended):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(WebKit::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 18 Jan 2012 20:59:10 +0000 (20:59 +0000)]
Web Inspector: Unsafe cross origin access errors should show stack trace in console.
https://bugs.webkit.org/show_bug.cgi?id=73099
Reviewed by Pavel Feldman.
Source/WebCore:
Test: http/tests/inspector/console-cross-origin-iframe-logging.html
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addConsoleMessage):
* dom/ScriptExecutionContext.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldAllowNavigation):
* page/Console.cpp:
(WebCore::Console::addMessage):
* page/Console.h:
* page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::stackTrace):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::printErrorMessage):
LayoutTests:
* http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
* http/tests/inspector/console-cross-origin-iframe-logging.html: Added.
* http/tests/inspector/resources/cross-origin-iframe.html: Added.
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 20:29:30 +0000 (20:29 +0000)]
Add [CallWith] support for attributes in JSC/V8 idl code generators.
Part of https://bugs.webkit.org/show_bug.cgi?id=76035
Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-18
Reviewed by Adam Barth.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateAttributeCallWith):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateAttributeCallWith):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::withScriptStateAttribute):
(WebDOMTestObj::setWithScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAttribute):
(WebDOMTestObj::withScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAttributeRaises):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptStateAttribute]):
(-[DOMTestObj setWithScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAttribute:]):
(-[DOMTestObj withScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAttributeRaises:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrSetter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 18 Jan 2012 20:18:34 +0000 (20:18 +0000)]
file:// doesn't work as base URL
https://bugs.webkit.org/show_bug.cgi?id=76496
Updating more layout test results.
* fast/loader/url-parse-1-expected.txt: This was already in the patch, just failed to land.
* http/tests/misc/bubble-drag-events-expected.txt: Missed that one among failure noise.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 20:12:51 +0000 (20:12 +0000)]
[Qt][WK2] Broken build with undefined reference to shm_open and shm_unlink
https://bugs.webkit.org/show_bug.cgi?id=76538
Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-01-18
Reviewed by Tor Arne Vestbø.
The -lrt parameter was coming before -lWebKit2 during linkage.
Moved rt lib inclusion from Source/api.pri to WebKit2.pri as it should be aware
of its own dependencies instead of letting WebKit guess about. Letting
it on api.pri can lead to a wrong parameter's order during linker phase.
Ubuntu 11.10 was giving errors about SharedMemory (shm_open and
shm_unlink undefined symbols).
.:
* Source/api.pri:
Source/WebKit2:
The issue was fixed with the help of Aloisio Almeida and Lauro Venancio.
* WebKit2.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Wed, 18 Jan 2012 19:59:39 +0000 (19:59 +0000)]
add test expections ahead of skia DEPS roll
https://bugs.webkit.org/show_bug.cgi?id=76477
Reviewed by NOBODY: Unreviewed
see http://code.google.com/p/chromium/issues/detail?id=110493
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 18 Jan 2012 19:48:05 +0000 (19:48 +0000)]
[chromium] Update expectations and baselines for various tests
* platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-all-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
* platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 18 Jan 2012 19:39:04 +0000 (19:39 +0000)]
Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
configurations.
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 Jan 2012 18:58:52 +0000 (18:58 +0000)]
Not reviewed: fix failing inspector test.
* inspector/elements/set-html-via-resource.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Wed, 18 Jan 2012 18:49:51 +0000 (18:49 +0000)]
[CG] Rasterized scaling of transformed SVG shapes with gradient fill and -webkit-svg-shadow applied
https://bugs.webkit.org/show_bug.cgi?id=76482
<rdar://problem/
10415483>
Reviewed by Simon Fraser.
Scale the CGLayer used when filling or stroking a shadowed path or rect with
a gradient in GraphicsContextCG. Previously, the CGLayer was created and rendered
into at the untransformed size of the shape, leading to pixelation when it was
then scaled up and drawn into the destination.
Add AffineTransform::mapSize() to map a size through a transformation.
Test: svg/custom/transform-with-shadow-and-gradient.svg
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapSize): Added.
* platform/graphics/transforms/AffineTransform.h:
Add a test that ensures that SVG shapes are drawn crisply when transformed
if they have both a gradient fill and -webkit-svg-shadow applied.
* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
* svg/custom/transform-with-shadow-and-gradient.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Wed, 18 Jan 2012 18:46:41 +0000 (18:46 +0000)]
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
platform/chromium/accessibility/scroll-to-global-point-nested.html
platform/chromium/accessibility/scroll-to-global-point-iframe.html
platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html
platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
platform/chromium/accessibility/scroll-to-make-visible-iframe.html
platform/chromium/accessibility/scroll-to-make-visible-main-window.html
platform/chromium/accessibility/scroll-to-make-visible-nested.html
platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html
* accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
* accessibility/AccessibilityScrollView.h:
Source/WebKit/chromium:
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):
Tools:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
LayoutTests:
* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Wed, 18 Jan 2012 18:41:43 +0000 (18:41 +0000)]
file:// doesn't work as base URL
https://bugs.webkit.org/show_bug.cgi?id=76496
Reviewed by Darin Adler.
Test: fast/url/degenerate-file-base.html
* platform/KURL.cpp: (WebCore::KURL::parse): Handle degenerate file URLs properly.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 18 Jan 2012 18:20:40 +0000 (18:20 +0000)]
[chromium] Web Inspector: highlight DOM nodes from detached DOM trees.
https://bugs.webkit.org/show_bug.cgi?id=76545
Reviewed by Yury Semikhatsky.
* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isNativeRoot):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
* inspector/front-end/heapProfiler.css:
(.detached-dom-tree-node):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Wed, 18 Jan 2012 18:12:19 +0000 (18:12 +0000)]
Source/WebKit/mac: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>
Starting with Lion, there is no more NSForegroundColor attribute in the dictionary
if the color matches the default (solid black).
The fix consists in treating the lack of color as solid black instead of transparent as
we did before.
Added a TestWebKitAPI test.
Reviewed by Darin Adler and Dan Bernstein.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]):
Tools: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>
Added TestWebKitAPI test.
Reviewed by Dan Bernstein.
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
* TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
changeAttributes to the WebView.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 18:10:30 +0000 (18:10 +0000)]
Cross-platform processor core counter fix
https://bugs.webkit.org/show_bug.cgi?id=76540
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.
I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
and I removed the OS checking macros from ParallelJobsGeneric.cpp because
the NumberOfCores.cpp contains them for counting CPU cores.
The processor core counter patch located at
https://bugs.webkit.org/show_bug.cgi?id=76530
* wtf/NumberOfCores.cpp:
* wtf/ParallelJobsGeneric.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 18:06:55 +0000 (18:06 +0000)]
[GTK] Listen to GDK_SCROLL_MASK
https://bugs.webkit.org/show_bug.cgi?id=76529
Source/WebKit/gtk:
Set GDK_SCROLL_MASK explicitly, as WebKitWebView does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.
Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.
* webkit/webkitwebview.cpp:
(webkit_web_view_realize):
Source/WebKit2:
Set GDK_SCROLL_MASK explicitly, as WebKitWebViewBase does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.
Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 Jan 2012 17:56:42 +0000 (17:56 +0000)]
Web Inspector: there should be a way to set HTML for given frame.
https://bugs.webkit.org/show_bug.cgi?id=76548
Reviewed by Yury Semikhatsky.
* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
* inspector/InspectorPageAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMModelResourceBinding.prototype.setContent.callbackWrapper):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 17:41:51 +0000 (17:41 +0000)]
[Qt] fontCache related assertion revealed by r105143
https://bugs.webkit.org/show_bug.cgi?id=76534
Unreviewed gardening. Skip a guilty test to paint the bot green.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Wed, 18 Jan 2012 17:40:46 +0000 (17:40 +0000)]
[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549
Reviewed by Gustavo Noronha Silva.
Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().
No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Wed, 18 Jan 2012 17:35:27 +0000 (17:35 +0000)]
[Qt][WK2] Fix the debug build.
Unreviewed.
* UIProcess/qt/QtWebPageEventHandler.cpp:
(setInputPanelVisible): Remove assertion from non-member function.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 Jan 2012 17:27:52 +0000 (17:27 +0000)]
Not reviewed: adding missing test data file.
* inspector/elements/resources/set-html-via-resource-iframe.html: Added.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 17:19:35 +0000 (17:19 +0000)]
[Qt] Unreviewed gardening after r105262.
https://bugs.webkit.org/show_bug.cgi?id=76457
* platform/qt/Skipped: Skip inspector/elements/set-html-via-resource.html until proper fix.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 18 Jan 2012 17:14:12 +0000 (17:14 +0000)]
Web Inspector: omit compression field in HAR entries for resources coming from cache
https://bugs.webkit.org/show_bug.cgi?id=76543
Reviewed by Yury Semikhatsky.
Source/WebCore:
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype.get responseCompression):
LayoutTests:
* http/tests/inspector/resource-har-conversion-expected.txt:
* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-parameters-expected.txt:
* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 17:09:01 +0000 (17:09 +0000)]
[Qt] Unreviewed gardening. Skip failing tests, simplify qt-wk2 skipped list.
* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Wed, 18 Jan 2012 16:57:16 +0000 (16:57 +0000)]
[CSSRegions]Fix region style code in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=76453
Reviewed by Antti Koivisto.
Source/WebCore:
Follow up after comments in https://bugs.webkit.org/show_bug.cgi?id=76064.
With the new approach, the css rule specificity is correctly taken into account
when applying the region style rule.
No new tests, the region style tests are still disabled.
* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::checkRegionStyle):
(WebCore::CSSStyleSelector::checkRegionSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
LayoutTests:
Fix the test as it was not taking into account the selector specificity.
* fast/regions/region-style-block-background-color.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Wed, 18 Jan 2012 16:39:05 +0000 (16:39 +0000)]
Mac fails to fire an 'error' event for a <video> <source> having an URL with no file extension
https://bugs.webkit.org/show_bug.cgi?id=76494
Reviewed by Eric Carlson.
No new tests; fixes compositing/video/video-with-invalid-source.html. Modified
media/video-source-error-no-candidate.html to check error condition.
When we run out of media engines for a given resource, inform the media player client
that resource loading failed by calling mediaPlayerResourceNotSupported().
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerResourceNotSupported):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerResourceNotSupported):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 16:06:55 +0000 (16:06 +0000)]
WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197
Unreviewed gardening, skip failing tests due to this bug.
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 16:02:07 +0000 (16:02 +0000)]
[Qt] Test fonts metric differencies with Qt5
https://bugs.webkit.org/show_bug.cgi?id=75710
Unreviewed gardening, unskip now passing tests after tesfont fix
* platform/qt-5.0/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Wed, 18 Jan 2012 15:42:34 +0000 (15:42 +0000)]
CSS Shaders: Parse float parameters for the custom() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=76253
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Custom CSS filters allow passing parameters from CSS to the underlying rendering technology (in this case WebGL Shaders).
This patch adds support for parameters of types float, vec2, vec3 and vec4.
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustomParamsAttribute
Tests: css3/filters/effect-custom-combined-missing.html
css3/filters/effect-custom-parameters.html
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Added CustomFilterParameter.h, CustomFilterNumberParameter.h and CustomFilterOperation.cpp to the projects.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
Added the computed parameters in alphabetic order (CustomFilterOperation always keeps the parameters sorted).
* css/CSSComputedStyleDeclaration.h:
* css/CSSStyleSelector.cpp:
(WebCore::sortParametersByNameComparator):
(WebCore::CSSStyleSelector::parseCustomFilterNumberParamter):
(WebCore::CSSStyleSelector::parseCustomFilterParameterList):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
Added parsing for float, vec2, vec3 and vec4. The values are space separated.
* css/CSSStyleSelector.h:
* platform/graphics/filters/CustomFilterNumberParameter.h: Added.
(WebCore::CustomFilterNumberParameter::create):
(WebCore::CustomFilterNumberParameter::size):
(WebCore::CustomFilterNumberParameter::valueAt):
(WebCore::CustomFilterNumberParameter::addValue):
(WebCore::CustomFilterNumberParameter::CustomFilterNumberParameter):
* platform/graphics/filters/CustomFilterOperation.cpp: Added.
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::~CustomFilterOperation):
Moved constructor and destructor in CustomFilterOperation.cpp to avoid including CustomFilterParameter everywhere.
(WebCore::CustomFilterOperation::hasSortedParameterList):
Debug runtime check that we always have parameters in alphabetic order.
* platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::parameters):
Just added the parameters list. Not using a map, but keeping the items sorted by name. We need them sorted
to make it easy and fast to merge two CustomFilterOperations during animations.
* platform/graphics/filters/CustomFilterParameter.h: Added.
(WebCore::CustomFilterParameter::~CustomFilterParameter):
(WebCore::CustomFilterParameter::parameterType):
(WebCore::CustomFilterParameter::name):
(WebCore::CustomFilterParameter::CustomFilterParameter):
* platform/graphics/filters/CustomFilterShader.cpp:
(WebCore::CustomFilterShader::uniformLocationByName):
* platform/graphics/filters/CustomFilterShader.h:
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::bindProgramNumberParameters):
(WebCore::FECustomFilter::bindProgramParameters):
Added code that maps the parameters from CSS to WebGL.
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
Fixed a case when the filter was not created, letting the filter add itself as a source of its own.
Also added a test case for this particular case: css3/filters/effect-custom-combined-missing.html.
LayoutTests:
* css3/filters/custom-filter-property-computed-style-expected.txt:
* css3/filters/effect-custom-combined-missing-expected.png: Added.
* css3/filters/effect-custom-combined-missing-expected.txt: Added.
* css3/filters/effect-custom-combined-missing.html: Added.
Testing that missing shader filters will not enter an infinite loop.
* css3/filters/effect-custom-parameters-expected.png: Added.
* css3/filters/effect-custom-parameters-expected.txt: Added.
* css3/filters/effect-custom-parameters.html: Added.
* css3/filters/resources/color-offset-parameters.fs: Added.
* css3/filters/resources/vertex-offset-parameters.vs: Added.
Testing parameter passing from CSS to WebGL.
* css3/filters/script-tests/custom-filter-property-computed-style.js:
Added computed style checks for number parameters.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Wed, 18 Jan 2012 15:36:47 +0000 (15:36 +0000)]
[Qt] Zoom in to the focused node only when vkb starts becoming visible https://bugs.webkit.org/show_bug.cgi?id=76174
Reviewed by Simon Hausmann.
Remove the old code which always zoomed in when something got focus,
even via JavaScript, and replaced it with code checking the state of
the Qt input panel.
Also make sure that we do not zoom in or request the input panel if
the item is not focused.
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::inputPanelVisibleChanged):
* UIProcess/qt/QtWebPageEventHandler.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 18 Jan 2012 15:21:48 +0000 (15:21 +0000)]
Web Inspector: resource tree model leaks frames
https://bugs.webkit.org/show_bug.cgi?id=76533
Reviewed by Pavel Feldman.
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._removeFrame):
(WebInspector.ResourceTreeFrame.prototype._removeChildFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 15:07:13 +0000 (15:07 +0000)]
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Unreviewed cross-MinGW buildfix after r105270.
* wtf/NumberOfCores.cpp: Use windows.h instead of Windows.h.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Wed, 18 Jan 2012 14:20:26 +0000 (14:20 +0000)]
Web Inspector: Enable support for Open Script dialog based on FilteredItemSelectionDialog.
https://bugs.webkit.org/show_bug.cgi?id=76466
Reviewed by Pavel Feldman.
* English.lproj/localizedStrings.js:
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.install):
(WebInspector.OpenResourceDialog._show):
(WebInspector.OpenResourceDialog.createShortcut):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showUISourceCode):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Wed, 18 Jan 2012 14:15:06 +0000 (14:15 +0000)]
[Qt] Update another SVG expected after r105247.
Unreviewed.
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 14:15:05 +0000 (14:15 +0000)]
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.
Source/JavaScriptCore:
Two files have been created that include the processor core counter function.
It used to be in ParallelJobsGeneric.h/cpp before.
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* wtf/CMakeLists.txt:
* wtf/NumberOfCores.cpp: Added.
(WTF::numberOfProcessorCores):
* wtf/NumberOfCores.h: Added.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
* wtf/ParallelJobsGeneric.h:
Source/WTF:
Two files have been added to the project, namely NumberOfCores.h/cpp,
that include a CPU core number determining function.
* WTF.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Wed, 18 Jan 2012 13:57:05 +0000 (13:57 +0000)]
[Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143
https://bugs.webkit.org/show_bug.cgi?id=76534
Reviewed by Csaba Osztrogonác.
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 Jan 2012 13:52:02 +0000 (13:52 +0000)]
Not reviewed: follow up to r105262, fixing front-end compilation.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Wed, 18 Jan 2012 13:35:57 +0000 (13:35 +0000)]
[Qt] Consolidate layout test crash logging
https://bugs.webkit.org/show_bug.cgi?id=75088
Reviewed by Simon Hausmann.
Move backtrace generating logic into WTFReportBacktrace
and add a way to deinstall signal handlers if we know
that we have already printed the backtrace.
.:
* Source/qtwebkit-export.map:
Source/JavaScriptCore:
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/Assertions.cpp:
(WTFLogLocker::WTFReportBacktrace):
(WTFLogLocker::WTFSetCrashHook):
(WTFLogLocker::WTFInvokeCrashHook):
* wtf/Assertions.h:
Tools:
* DumpRenderTree/qt/main.cpp:
(crashHandler):
(setupSignalHandlers):
(WTFCrashHook):
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::crashHandler):
(WTR::setupSignalHandlers):
(WTR::crashHook):
(WTR::InjectedBundle::platformInitialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 18 Jan 2012 13:26:54 +0000 (13:26 +0000)]
[Qt] Unreviewed gardening after testfonts update.
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png:
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rgabor@webkit.org [Wed, 18 Jan 2012 13:15:09 +0000 (13:15 +0000)]
[Qt] Update some SVG expected after r105247.
Unreviewed.
* platform/qt/svg/custom/linking-a-03-b-all-expected.png:
* platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-image-expected.png:
* platform/qt/svg/custom/pointer-events-image-expected.txt:
* platform/qt/svg/custom/pointer-events-text-expected.png:
* platform/qt/svg/custom/pointer-events-text-expected.txt:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Wed, 18 Jan 2012 13:00:55 +0000 (13:00 +0000)]
[GTK] platform/gtk/accessibility/combo-box-collapsed-selection-changed.html is failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76531
Unreviewed. Skip test now failing in the GTK port.
* platform/gtk/Skipped: Skip test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Wed, 18 Jan 2012 13:00:45 +0000 (13:00 +0000)]
Unreviewed build fix after r105256.
There was a cyclic dependency between self._port and self._host assigments.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 18 Jan 2012 12:52:46 +0000 (12:52 +0000)]
Web Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
https://bugs.webkit.org/show_bug.cgi?id=76457
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: inspector/elements/set-html-via-resource.html
* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.setAttributeValue):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._buildHighlightConfig):
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype._captureDOM.callback):
(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
(WebInspector.DOMModelResourceBinding.prototype.setContent.withDocument):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
LayoutTests:
* inspector/elements/resources/set-outer-html-body-iframe.html:
* inspector/elements/set-html-via-resource-expected.txt: Added.
* inspector/elements/set-html-via-resource.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Wed, 18 Jan 2012 12:46:55 +0000 (12:46 +0000)]
Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363
Reviewed by Pavel Feldman.
This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 18 Jan 2012 11:33:06 +0000 (11:33 +0000)]
Add new watchlist rule for the Qt build system
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:48 +0000 (11:32 +0000)]
[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:33 +0000 (11:32 +0000)]
[Qt] Allow building only a subset of the WebKit sub-projects
Fixes build-jsc, broken in r104825.
We no longer need the intermediate buildQMakeQtProject(), as we're the
only port using qmake, and buildQMakeProject is now highly Qt specific.
<http://webkit.org/b/76179>
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Wed, 18 Jan 2012 11:25:21 +0000 (11:25 +0000)]
Unreviewed, GTK rebaseline after r105247 and r105253.
* platform/gtk/css3/images/cross-fade-overflow-position-expected.txt:
* platform/gtk/fast/forms/implicit-submission-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 18 Jan 2012 10:52:41 +0000 (10:52 +0000)]
run-perf-tests should generate a json file that summaries the result
https://bugs.webkit.org/show_bug.cgi?id=76504
Reviewed by Adam Barth.
Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
New option --outout-json-path specifies the json file's path, and --source-json-path specifies
another json file to be merged into the generated json file.
Also fixed a bug that --build wasn't set by default.
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.webkit_base):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json_if_specified):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest):
(create_runner):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_summary_json):
(test_collect_tests):
(test_parse_args):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 10:52:07 +0000 (10:52 +0000)]
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=76525
Removed missing build headers.
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 18 Jan 2012 10:40:43 +0000 (10:40 +0000)]
[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 10:39:31 +0000 (10:39 +0000)]
Use RenderTheme in HTMLSelectElement instead of #defines.
<http://webkit.org/b/76519>
Patch by Jun Mukai <mukai@chromium.org> on 2012-01-18
Reviewed by Kent Tamura.
Tests: no new tests because of no behavioral changes.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuByArrowKeys):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::popsMenuByArrowKeys):
(WebCore::RenderTheme::popsMenuBySpaceOrReturn):
* rendering/RenderThemeChromiumLinux.h:
(WebCore::RenderThemeChromiumLinux::popsMenuBySpaceOrReturn):
* rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::popsMenuByArrowKeys):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 18 Jan 2012 10:08:22 +0000 (10:08 +0000)]
Unreviewed: Chromium test_expectations.txt update
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 18 Jan 2012 10:00:20 +0000 (10:00 +0000)]
Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309
Reviewed by Nikolas Zimmermann.
updateWidgetPositions can blow away the owning renderer
and its frameview, so need to protect it with refptr.
Test: svg/dom/parent-view-layout-crash.html
* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
LayoutTests: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309
Reviewed by Nikolas Zimmermann.
* svg/dom/parent-view-layout-crash-expected.txt: Added.
* svg/dom/parent-view-layout-crash.html: Added.
* svg/dom/resources/svg-font-face.svg: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 09:15:24 +0000 (09:15 +0000)]
Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=76241
Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
Reviewed by Dimitri Glazkov.
.:
* Source/autotools/symbols.filter: Exposed necessary symbols.
Source/WebCore:
Renamed ShadowContentElement to HTMLContentElement, and move it from dom/ to html/.
Also, ShadowInclusionSelector and ShadowContentSelectorQuery are renamed to
Content InclusionSelector and ContentSelectorQuery respectively.
No new tests, because no change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
* dom/NodeRenderingContext.h:
(WebCore::NodeRenderingContext::includer):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
* dom/ShadowRoot.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* html/shadow/ContentInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowInclusionSelector.cpp.
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ContentInclusionSelector::ContentInclusionSelector):
(WebCore::ContentInclusionSelector::~ContentInclusionSelector):
(WebCore::ContentInclusionSelector::select):
(WebCore::ContentInclusionSelector::unselect):
(WebCore::ContentInclusionSelector::findFor):
(WebCore::ContentInclusionSelector::didSelect):
(WebCore::ContentInclusionSelector::willSelectOver):
* html/shadow/ContentInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowInclusionSelector.h.
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ContentInclusionSelector::hasCandidates):
* html/shadow/ContentSelectorQuery.cpp: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.cpp.
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.h.
* html/shadow/HTMLContentElement.cpp: Renamed from Source/WebCore/dom/ShadowContentElement.cpp.
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::~HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::select):
(WebCore::HTMLContentElement::setSelect):
* html/shadow/HTMLContentElement.h: Renamed from Source/WebCore/dom/ShadowContentElement.h.
(WebCore::HTMLContentElement::inclusions):
(WebCore::HTMLContentElement::isContentElement):
(WebCore::HTMLContentElement::rendererIsNeeded):
(WebCore::HTMLContentElement::createRenderer):
(WebCore::toHTMLContentElement):
* testing/Internals.cpp:
(WebCore::Internals::createContentElement):
* testing/Internals.h:
* testing/Internals.idl:
Source/WebKit2:
* win/WebKit2.def: Exposed necessary symbols.
* win/WebKit2CFLite.def: ditto.
LayoutTests:
Renamed internals.createShadowContentElement to internals.createContentElement.
* fast/dom/shadow/content-element-includer.html:
* fast/dom/shadow/content-element-renderers.html:
* fast/dom/shadow/create-content-element.html:
* fast/dom/shadow/shadow-contents-select.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Wed, 18 Jan 2012 09:04:22 +0000 (09:04 +0000)]
Unreviewed. Fix GTK+ build after r105245.
* Source/autotools/symbols.filter: Fix symbol name.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Wed, 18 Jan 2012 08:45:17 +0000 (08:45 +0000)]
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446
Reviewed by Zoltan Herczeg.
Source/WebCore:
Let RenderSVGRoot inherit from RenderReplaced, instead of faking RenderReplaced, by inherting from RenderBox
and calling setReplaced(true) in the constructor. The outermost <svg> element is a replaced element in the
sense of CSS, and thus this is just a logical move. It fixes some issues where the <svg> root appeared
as selection leaf, covered by existing tests.
It allows us to simplify the painting, as outlines, etc. are painted by RenderReplaced now.
While I was it, speed up the local to border box computations by caching the result.
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::willBeDestroyed):
(WebCore::RenderSVGRoot::styleWillChange):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::updateFromElement):
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
(WebCore::RenderSVGRoot::canBeSelectionLeaf):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):
LayoutTests:
Update test results after making RenderSVGRoot inherit from RenderReplaced.
* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/linking-a-03-b-all-expected.png: Text layout changed, we didn't relayout the tree when entering a new view before.
* platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Moving the circle, triggered a selection before, where it shouldn't. It's gone now.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Caret position which is reported changed, due the selection leaf changes.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.txt: Ditto.
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png: This now reports a valid size for the RenderSVGRoot in the <fO> subtree.
* svg/foreignObject/text-tref-02-b-expected.txt: Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Wed, 18 Jan 2012 07:36:49 +0000 (07:36 +0000)]
Unreviewed, rolling out r105244.
http://trac.webkit.org/changeset/105244
https://bugs.webkit.org/show_bug.cgi?id=76518
broke Chromium Mac (Requested by rolandsteiner on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-17
Source/WebCore:
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
* accessibility/AccessibilityScrollView.h:
Source/WebKit/chromium:
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
Tools:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::removeSelection):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::removeSelection):
LayoutTests:
* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 06:55:01 +0000 (06:55 +0000)]
[Internals] Should be able to access corresponding Document object.
https://bugs.webkit.org/show_bug.cgi?id=76425
.:
Added exported symbols.
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.
* Source/autotools/symbols.filter:
Source/WebCore:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.
- Allow FrameDestructionObserver to re-setting the Frame reference.
- Make Internals a subclass of FrameDestructionObserver.
Since Internals::reset() is called for each test, we can access
the acive Frame object during the test. The frame reference will be
used by coming changes.
No new tests. Covered by existing tests.
* WebCore.exp.in:
* page/FrameDestructionObserver.cpp:
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::observe):
* page/FrameDestructionObserver.h:
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::reset):
* testing/Internals.h:
Source/WebKit2:
Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.
* win/WebKit2.def: Added exporting symbols.
* win/WebKit2CFLite.def: Added exporting symbols.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dmazzoni@google.com [Wed, 18 Jan 2012 06:41:51 +0000 (06:41 +0000)]
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460
Reviewed by Chris Fleizach.
Source/WebCore:
Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
platform/chromium/accessibility/scroll-to-global-point-nested.html
platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
platform/chromium/accessibility/scroll-to-make-visible-iframe.html
platform/chromium/accessibility/scroll-to-make-visible-main-window.html
platform/chromium/accessibility/scroll-to-make-visible-nested.html
platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html
* accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
* accessibility/AccessibilityScrollView.h:
Source/WebKit/chromium:
* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):
Tools:
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
LayoutTests:
* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Wed, 18 Jan 2012 06:39:17 +0000 (06:39 +0000)]
Fixing broken build. Missed a file in r105234.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 18 Jan 2012 06:06:09 +0000 (06:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75089
Access-Control-Request-Headers value should be lowercase
Source/WebCore:
Access-Control-Request-Headers is used when issuing a preflight request to let the server know
the HTTP headers that will be used when the actual request is made.
As per the W3C specification, Access-Control-Request-Headers value should be set in lowercase.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.
Test: http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html
* loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): setting Access-Control-Request-Headers value to lowercase
LayoutTests:
Added test to verify that the Access-Control-Request-Headers value is sent in lowercase.
Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.
* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html: Added.
* http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc