platform/upstream/libSkiaSharp.git
11 years agoFix alpha computation in SkArithmeticMode.
senorblanco@chromium.org [Tue, 28 May 2013 19:43:05 +0000 (19:43 +0000)]
Fix alpha computation in SkArithmeticMode.

Note: this will require new baselines for the arithmode GM.

R=reed@google.com

Review URL: https://codereview.chromium.org/15917010

git-svn-id: http://skia.googlecode.com/svn/trunk@9302 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBuild fix
junov@chromium.org [Tue, 28 May 2013 18:17:23 +0000 (18:17 +0000)]
Build fix

TBR=reed

git-svn-id: http://skia.googlecode.com/svn/trunk@9299 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanging SkDeferredCanvas to use factories for creation
junov@chromium.org [Tue, 28 May 2013 17:39:08 +0000 (17:39 +0000)]
Changing SkDeferredCanvas to use factories for creation

The objective of this change is to remove all calls to
SkCanvas::setDevice. The factory API is hidden behind
a build flag in order to ease the roll into chromium.

A side-effect of the factory pattern is that it will
no longer be possible to allocate a SkDeferredCanvas on
the stack.  This changes nothing for chrome, but it
impacts skia test programs.

Review URL: https://codereview.chromium.org/16040002

git-svn-id: http://skia.googlecode.com/svn/trunk@9298 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrContext track the current matrix, render target, and clip directly rather...
commit-bot@chromium.org [Tue, 28 May 2013 17:25:49 +0000 (17:25 +0000)]
Make GrContext track the current matrix, render target, and clip directly rather than using GrDrawState.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/15821008

git-svn-id: http://skia.googlecode.com/svn/trunk@9297 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland 'Add path utils, plus a test for it.'
scroggo@google.com [Tue, 28 May 2013 16:45:07 +0000 (16:45 +0000)]
Reland 'Add path utils, plus a test for it.'

Build SkPathJoin and SkBasename on windows also.

Previous CL did not build on Windows because the two functions were
accidentally placed inside an ifdef that did not include windows.
Move the functions to the top of the file, and add a comment by the
endif for clarity.

Previously reviewed at https://codereview.chromium.org/15747004/

Review URL: https://codereview.chromium.org/15740024

git-svn-id: http://skia.googlecode.com/svn/trunk@9295 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't unref() null (from typeface::create) you gunky
reed@google.com [Tue, 28 May 2013 16:39:52 +0000 (16:39 +0000)]
don't unref() null (from typeface::create) you gunky

git-svn-id: http://skia.googlecode.com/svn/trunk@9294 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse inttoscalar to fix warning
reed@google.com [Tue, 28 May 2013 15:42:21 +0000 (15:42 +0000)]
use inttoscalar to fix warning

BUG=

Review URL: https://codereview.chromium.org/15929006

git-svn-id: http://skia.googlecode.com/svn/trunk@9293 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse explicit conversion for int->scalar
reed@google.com [Tue, 28 May 2013 15:35:47 +0000 (15:35 +0000)]
use explicit conversion for int->scalar

BUG=

Review URL: https://codereview.chromium.org/16123004

git-svn-id: http://skia.googlecode.com/svn/trunk@9292 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new gm for bicubic filtering
reed@google.com [Tue, 28 May 2013 15:29:25 +0000 (15:29 +0000)]
add new gm for bicubic filtering

BUG=

Review URL: https://codereview.chromium.org/16123003

git-svn-id: http://skia.googlecode.com/svn/trunk@9291 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSplit GM json schema out of display_json_results.py, for sharing with other tools
epoger@google.com [Tue, 28 May 2013 15:25:38 +0000 (15:25 +0000)]
Split GM json schema out of display_json_results.py, for sharing with other tools

R=rmistry@google.com

Review URL: https://codereview.chromium.org/16155002

git-svn-id: http://skia.googlecode.com/svn/trunk@9290 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDecrease GPU drawn brightness for < 1 pixel wide/high rects
robertphillips@google.com [Tue, 28 May 2013 13:16:20 +0000 (13:16 +0000)]
Decrease GPU drawn brightness for < 1 pixel wide/high rects

https://codereview.chromium.org/15715012/

git-svn-id: http://skia.googlecode.com/svn/trunk@9288 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck texture is not NULL to aovid segmentation fault. If the texture created by...
commit-bot@chromium.org [Tue, 28 May 2013 13:13:56 +0000 (13:13 +0000)]
check texture is not NULL to aovid segmentation fault. If the texture created by GrLockAndRefCachedBitmapTexture() is NULL, ColorTableEffect::Create will cause segmentation fault by GrAssert in src/gpu/GrTextureAccess.cpp. The simple patch checked texture to avoid segment fault, and returned a NULL effect to the caller. The caller will handle NULL effect, for example, it will set default effect.

R=bsalomon@google.com, robertphillips@google.com

Author: yunchao.he@intel.com

Review URL: https://chromiumcodereview.appspot.com/15824003

git-svn-id: http://skia.googlecode.com/svn/trunk@9287 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 25 May 2013 07:01:12 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9285 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAndroid specific changes that are upstreamed from the android framework.
djsollen@google.com [Fri, 24 May 2013 20:31:57 +0000 (20:31 +0000)]
Android specific changes that are upstreamed from the android framework.

R=reed@google.com

Review URL: https://codereview.chromium.org/15720006

git-svn-id: http://skia.googlecode.com/svn/trunk@9283 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix slowness of getImageData() for CanvasRenderingContext2D in linux due to un-optimi...
commit-bot@chromium.org [Fri, 24 May 2013 18:52:52 +0000 (18:52 +0000)]
fix slowness of getImageData() for CanvasRenderingContext2D in linux due to un-optimized format for glReadPixels

This is a continuation of https://codereview.chromium.org/15331003/

BUG=242093
R=robertphillips@google.com, jun.a.jiang@intel.com, bsalomon@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/15746007

git-svn-id: http://skia.googlecode.com/svn/trunk@9280 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix degenerate and near-degenerate hairlines on the gpu
commit-bot@chromium.org [Fri, 24 May 2013 18:51:55 +0000 (18:51 +0000)]
Fix degenerate and near-degenerate hairlines on the gpu

R=robertphillips@google.com, bsalomon@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/16035002

git-svn-id: http://skia.googlecode.com/svn/trunk@9279 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add path utils, plus a test for it."
scroggo@google.com [Fri, 24 May 2013 18:28:57 +0000 (18:28 +0000)]
Revert "Add path utils, plus a test for it."

This reverts commit d172374b46cae0bd5d7c024b9848f5bdafcc6a16.

This CL broke on Windows.

Review URL: https://codereview.chromium.org/15986004

git-svn-id: http://skia.googlecode.com/svn/trunk@9278 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd path utils, plus a test for it.
scroggo@google.com [Fri, 24 May 2013 18:12:17 +0000 (18:12 +0000)]
Add path utils, plus a test for it.

SkOSFile:
Added class SkOSPath with functions for
modifying strings representing path names.

OSPathTest.cpp:
Test of the new utilities.

factory.cpp:
Use SkPathJoin.

gmmain and gm_expectations:
Use SkOSPath::SkPathJoin instead of a local version.

skimage_main.cpp:
Use the new location of SkPathJoin and SkBasename.

R=epoger@google.com

Review URL: https://codereview.chromium.org/15747004

git-svn-id: http://skia.googlecode.com/svn/trunk@9277 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding setSurface public API method to SkDeferredCanvas
junov@chromium.org [Fri, 24 May 2013 17:13:00 +0000 (17:13 +0000)]
Adding setSurface public API method to SkDeferredCanvas

The purpose of this change is to provide an API that Blink 2D canvas layers can use
to install a new render target when recovering from a lost graphics context.

Review URL: https://codereview.chromium.org/15896005

git-svn-id: http://skia.googlecode.com/svn/trunk@9276 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Patch to prevent chromium breakage until the DEPS."
scroggo@google.com [Fri, 24 May 2013 16:31:30 +0000 (16:31 +0000)]
Revert "Patch to prevent chromium breakage until the DEPS."

This reverts commit d2a284728d30082d46b02c39d916294c6d36e11f.

Review URL: https://codereview.chromium.org/16019005

git-svn-id: http://skia.googlecode.com/svn/trunk@9275 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SkImageFilter::getInputResult(), since its return value is not
senorblanco@chromium.org [Fri, 24 May 2013 15:04:07 +0000 (15:04 +0000)]
Remove SkImageFilter::getInputResult(), since its return value is not
style-compliant, and doesn't allow us to abort on failure.

R=reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9245

Review URL: https://codereview.chromium.org/15600003

git-svn-id: http://skia.googlecode.com/svn/trunk@9274 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd flag to gradients to interpolate colors in premul space. Experimental API to...
reed@google.com [Fri, 24 May 2013 14:58:44 +0000 (14:58 +0000)]
Add flag to gradients to interpolate colors in premul space. Experimental API to encapsulate the shared parameters for all gradients into a struct.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/15893002

git-svn-id: http://skia.googlecode.com/svn/trunk@9273 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkDrawLooper implementation to its own file.
commit-bot@chromium.org [Fri, 24 May 2013 14:57:53 +0000 (14:57 +0000)]
Move SkDrawLooper implementation to its own file.

It previously lived in SkPaint.cpp.

BUG=
R=reed@google.com, tomhudson@chromium.org, jbroman@chromium.org

Author: jbroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15896004

git-svn-id: http://skia.googlecode.com/svn/trunk@9272 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value...
epoger@google.com [Fri, 24 May 2013 14:33:28 +0000 (14:33 +0000)]
GM: create GmResultDigest that encapsulates digest type ("bitmap-64bitMD5") and value (12345)

R=scroggo@google.com

Review URL: https://codereview.chromium.org/15883004

git-svn-id: http://skia.googlecode.com/svn/trunk@9271 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 24 May 2013 07:01:26 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9266 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't reference missing header
reed@google.com [Thu, 23 May 2013 20:16:17 +0000 (20:16 +0000)]
don't reference missing header

BUG=

Review URL: https://codereview.chromium.org/15888004

git-svn-id: http://skia.googlecode.com/svn/trunk@9265 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoclone of https://codereview.chromium.org/15316014/ with teaks
reed@google.com [Thu, 23 May 2013 20:11:56 +0000 (20:11 +0000)]
clone of https://codereview.chromium.org/15316014/ with teaks

BUG=

Review URL: https://codereview.chromium.org/15904005

git-svn-id: http://skia.googlecode.com/svn/trunk@9264 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkScalar instead of int for loops, to avoid warning in canvas->translate() calls
reed@google.com [Thu, 23 May 2013 19:47:05 +0000 (19:47 +0000)]
use SkScalar instead of int for loops, to avoid warning in canvas->translate() calls

BUG=

Review URL: https://codereview.chromium.org/15875012

git-svn-id: http://skia.googlecode.com/svn/trunk@9263 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodon't overclamp cubics (see skbug.com/1316)
reed@google.com [Thu, 23 May 2013 19:39:15 +0000 (19:39 +0000)]
don't overclamp cubics (see skbug.com/1316)

BUG=

Review URL: https://codereview.chromium.org/15924003

git-svn-id: http://skia.googlecode.com/svn/trunk@9262 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd comment
reed@google.com [Thu, 23 May 2013 19:30:48 +0000 (19:30 +0000)]
add comment

add test for skbug/com/1316

BUG=

Review URL: https://codereview.chromium.org/15790006

git-svn-id: http://skia.googlecode.com/svn/trunk@9261 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse Descriptor struct to encapsulate all the common paramaeters between our various...
reed@google.com [Thu, 23 May 2013 19:03:05 +0000 (19:03 +0000)]
use Descriptor struct to encapsulate all the common paramaeters between our various gradient types. If we like it, might promote it to the public API.

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/15733007

git-svn-id: http://skia.googlecode.com/svn/trunk@9260 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SK_OVERRIDE and DEF_GM
reed@google.com [Thu, 23 May 2013 17:04:19 +0000 (17:04 +0000)]
use SK_OVERRIDE and DEF_GM

BUG=

Review URL: https://codereview.chromium.org/15873004

git-svn-id: http://skia.googlecode.com/svn/trunk@9259 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove outdated debugging code now that we no longer support fixed point
commit-bot@chromium.org [Thu, 23 May 2013 16:41:42 +0000 (16:41 +0000)]
remove outdated debugging code now that we no longer support fixed point

R=reed@google.com, djsollen@google.com

Author: djsollen@google.com

Review URL: https://chromiumcodereview.appspot.com/15879003

git-svn-id: http://skia.googlecode.com/svn/trunk@9258 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bug in SkAutoSMalloc::reset
robertphillips@google.com [Thu, 23 May 2013 14:59:40 +0000 (14:59 +0000)]
Fix bug in SkAutoSMalloc::reset

https://codereview.chromium.org/15858007/

git-svn-id: http://skia.googlecode.com/svn/trunk@9257 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix compiler error/warning in r9255
robertphillips@google.com [Thu, 23 May 2013 14:11:41 +0000 (14:11 +0000)]
Fix compiler error/warning in r9255

git-svn-id: http://skia.googlecode.com/svn/trunk@9256 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd printing of SkColorFilter-derived classes to debugger
robertphillips@google.com [Thu, 23 May 2013 14:00:17 +0000 (14:00 +0000)]
Add printing of SkColorFilter-derived classes to debugger

https://codereview.chromium.org/15697012/

git-svn-id: http://skia.googlecode.com/svn/trunk@9255 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline performance triggers
robertphillips@google.com [Thu, 23 May 2013 13:41:55 +0000 (13:41 +0000)]
Rebaseline performance triggers

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9254 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove offsetcanvas from debugger
robertphillips@google.com [Thu, 23 May 2013 13:21:18 +0000 (13:21 +0000)]
Remove offsetcanvas from debugger

https://codereview.chromium.org/15746003/

git-svn-id: http://skia.googlecode.com/svn/trunk@9253 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 23 May 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9252 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r9245 due to Chrome breakage
robertphillips@google.com [Wed, 22 May 2013 23:56:49 +0000 (23:56 +0000)]
Reverting r9245 due to Chrome breakage

git-svn-id: http://skia.googlecode.com/svn/trunk@9250 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark SkDrawPictureCallback with SK_API, so that it can be derived from by SK_API...
commit-bot@chromium.org [Wed, 22 May 2013 21:11:42 +0000 (21:11 +0000)]
Mark SkDrawPictureCallback with SK_API, so that it can be derived from by SK_API classes

R=reed@google.com

Author: vmpstr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15745015

git-svn-id: http://skia.googlecode.com/svn/trunk@9249 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse macro to encapsulate building get_mtname() specializations
reed@google.com [Wed, 22 May 2013 20:53:42 +0000 (20:53 +0000)]
use macro to encapsulate building get_mtname() specializations

BUG=

Review URL: https://codereview.chromium.org/15773002

git-svn-id: http://skia.googlecode.com/svn/trunk@9248 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpand SkLua to handle creation of its own State
reed@google.com [Wed, 22 May 2013 20:12:50 +0000 (20:12 +0000)]
expand SkLua to handle creation of its own State

add lua sample

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15742009

git-svn-id: http://skia.googlecode.com/svn/trunk@9247 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove SkImageFilter::getInputResult(), since its return value is not
senorblanco@chromium.org [Wed, 22 May 2013 18:59:58 +0000 (18:59 +0000)]
Remove SkImageFilter::getInputResult(), since its return value is not
style-compliant, and doesn't allow us to abort on failure.

R=reed@google.com

Review URL: https://codereview.chromium.org/15600003

git-svn-id: http://skia.googlecode.com/svn/trunk@9245 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix int -> bool warning
reed@google.com [Wed, 22 May 2013 15:43:21 +0000 (15:43 +0000)]
fix int -> bool warning

BUG=

Review URL: https://codereview.chromium.org/15737012

git-svn-id: http://skia.googlecode.com/svn/trunk@9243 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd dumpops.lua as a sample scraper that just dumps the arguments
reed@google.com [Wed, 22 May 2013 15:13:18 +0000 (15:13 +0000)]
add dumpops.lua as a sample scraper that just dumps the arguments

add SkLua.h for common utilities

BUG=
R=rmistry@google.com

Review URL: https://codereview.chromium.org/15737010

git-svn-id: http://skia.googlecode.com/svn/trunk@9242 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate bench expectations for nexus7 on tabl_hsfi.skp (256x256_gpu)
djsollen@google.com [Wed, 22 May 2013 14:44:16 +0000 (14:44 +0000)]
Update bench expectations for nexus7 on tabl_hsfi.skp (256x256_gpu)

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15743004

git-svn-id: http://skia.googlecode.com/svn/trunk@9241 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake GrGLProgramDesc's key variable length by compacting the effect key array
bsalomon@google.com [Wed, 22 May 2013 14:34:04 +0000 (14:34 +0000)]
Make GrGLProgramDesc's key variable length by compacting the effect key array

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15252004

git-svn-id: http://skia.googlecode.com/svn/trunk@9239 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomove all flag bits up by 1, to accomodate new flag in SkPaint
reed@google.com [Wed, 22 May 2013 14:03:45 +0000 (14:03 +0000)]
move all flag bits up by 1, to accomodate new flag in SkPaint

BUG=

Review URL: https://codereview.chromium.org/15739006

git-svn-id: http://skia.googlecode.com/svn/trunk@9237 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd kBicubicFilterBitmap_Flag to paint, just for testing purposes.
reed@google.com [Wed, 22 May 2013 13:55:54 +0000 (13:55 +0000)]
add kBicubicFilterBitmap_Flag to paint, just for testing purposes.

BUG=

Review URL: https://codereview.chromium.org/15553005

git-svn-id: http://skia.googlecode.com/svn/trunk@9236 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd return param to SkAutoSMalloc::reset() that indicates whether the allocation...
bsalomon@google.com [Wed, 22 May 2013 13:35:37 +0000 (13:35 +0000)]
Add return param to SkAutoSMalloc::reset() that indicates whether the allocation changed or not.

Review URL: https://codereview.chromium.org/15558005

git-svn-id: http://skia.googlecode.com/svn/trunk@9235 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoreenable lerpmode in gms, now that I think we fixed the global-initialization
reed@google.com [Wed, 22 May 2013 13:21:32 +0000 (13:21 +0000)]
reenable lerpmode in gms, now that I think we fixed the global-initialization

BUG=

Review URL: https://codereview.chromium.org/15737004

git-svn-id: http://skia.googlecode.com/svn/trunk@9234 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd methods to SkLayerDrawLooper to allow adding layers on top
commit-bot@chromium.org [Wed, 22 May 2013 12:35:50 +0000 (12:35 +0000)]
Add methods to SkLayerDrawLooper to allow adding layers on top
as well as on the bottom.

This is more convenient for some callers who generate layers
from a data structure in bottom-to-top, rather than top-to-bottom,
order.

BUG=242529
R=tomhudson@chromium.org

Author: jbroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15314003

git-svn-id: http://skia.googlecode.com/svn/trunk@9233 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 22 May 2013 07:01:13 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9232 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix clang warnings/errors in Android only code
robertphillips@google.com [Wed, 22 May 2013 00:12:43 +0000 (00:12 +0000)]
Fix clang warnings/errors in Android only code

git-svn-id: http://skia.googlecode.com/svn/trunk@9231 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable lerpmode gm until we fix serialization
reed@google.com [Tue, 21 May 2013 21:52:03 +0000 (21:52 +0000)]
disable lerpmode gm until we fix serialization

BUG=

Review URL: https://codereview.chromium.org/15462004

git-svn-id: http://skia.googlecode.com/svn/trunk@9230 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkLerpXfermode
reed@google.com [Tue, 21 May 2013 21:33:11 +0000 (21:33 +0000)]
add SkLerpXfermode

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/15602003

git-svn-id: http://skia.googlecode.com/svn/trunk@9229 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch to prevent chromium breakage until the DEPS.
scroggo@google.com [Tue, 21 May 2013 20:45:03 +0000 (20:45 +0000)]
Patch to prevent chromium breakage until the DEPS.

Once https://codereview.chromium.org/15489004/ is submitted to
Skia, a DEPS roll into chrome will break due to a change in the
API. A long term fix for chrome to use the new API is at
https://codereview.chromium.org/15496006/, but since it depends
on the earlier Skia change, this patch fills in the gap.

Will be reverted once https://codereview.chromium.org/15496006/
is submitted to chrome.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/15538005

git-svn-id: http://skia.googlecode.com/svn/trunk@9228 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd prototype for warning.
scroggo@google.com [Tue, 21 May 2013 20:38:40 +0000 (20:38 +0000)]
Add prototype for warning.

Fixes build.

Review URL: https://codereview.chromium.org/15536007

git-svn-id: http://skia.googlecode.com/svn/trunk@9227 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew API for encoding bitmaps during serialization.
scroggo@google.com [Tue, 21 May 2013 20:31:23 +0000 (20:31 +0000)]
New API for encoding bitmaps during serialization.

This change gives more flexibility to the implementation of
EncodeBitmap to prefer calling refEncodedData, doing its own
encode, or even doing both and making a decision about which
to use.

The new function signature also allows the implementation to
tell the ordered write buffer whether to store the pixel offset,
in the case where the encoded bitmap represents the larger
bitmap, or to ignore the pixel offset, in the case where the
implementation only encoded the subset that is used.

Requires changes to chromium to use the new function signature.
(https://codereview.chromium.org/15496006/)

SkPicture:
New API for EncodeBitmap.

SkOrderedReadBuffer:
Ifdef'd out addition of reading the offset.

SkOrderedWriteBuffer:
Never call refEncodedData. Allow the user to call that from their
EncodeBitmap function, if desired.
This addresses https://code.google.com/p/skia/issues/detail?id=1239
Add in ifdef'd out code to record the offset.

PictureTest and PictureRenderer:
Implement the new definition of EncodeBitmap. Also update the name
of the function to meet coding style guidelines.

BUG=https://code.google.com/p/skia/issues/detail?id=1239
R=reed@google.com

Review URL: https://codereview.chromium.org/15489004

git-svn-id: http://skia.googlecode.com/svn/trunk@9226 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove extra return statement (doh)
reed@google.com [Tue, 21 May 2013 20:30:17 +0000 (20:30 +0000)]
remove extra return statement (doh)

git-svn-id: http://skia.googlecode.com/svn/trunk@9225 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixing deferred canvases so that they do not return deferred devices on createCompati...
junov@chromium.org [Tue, 21 May 2013 20:16:17 +0000 (20:16 +0000)]
Fixing deferred canvases so that they do not return deferred devices on createCompatibleDevice

TEST= DeferredCanvas unit test.

Review URL: https://codereview.chromium.org/15594004

git-svn-id: http://skia.googlecode.com/svn/trunk@9224 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android font lookup bug
djsollen@google.com [Tue, 21 May 2013 20:08:10 +0000 (20:08 +0000)]
Fix android font lookup bug

R=reed@google.com

Review URL: https://codereview.chromium.org/15602002

git-svn-id: http://skia.googlecode.com/svn/trunk@9223 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkPath as real lua object
reed@google.com [Tue, 21 May 2013 17:52:33 +0000 (17:52 +0000)]
add SkPath as real lua object

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15563013

git-svn-id: http://skia.googlecode.com/svn/trunk@9221 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix release build warnings for unused variables
djsollen@google.com [Tue, 21 May 2013 17:15:27 +0000 (17:15 +0000)]
Fix release build warnings for unused variables

R=rmistry@google.com

Review URL: https://codereview.chromium.org/15565008

git-svn-id: http://skia.googlecode.com/svn/trunk@9220 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a fontConfig interface for android.
djsollen@google.com [Tue, 21 May 2013 16:53:50 +0000 (16:53 +0000)]
Add a fontConfig interface for android.

The contents of this CL are based on the SkFontHost_android.cpp found
in the android repository.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/14731025

git-svn-id: http://skia.googlecode.com/svn/trunk@9219 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd buffer helper to read directly into SkString to avoid extra copying
djsollen@google.com [Tue, 21 May 2013 16:17:14 +0000 (16:17 +0000)]
Add buffer helper to read directly into SkString to avoid extra copying

R=reed@google.com

Review URL: https://codereview.chromium.org/15179008

git-svn-id: http://skia.googlecode.com/svn/trunk@9218 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImprove tool that analyzes gm JSON summary
epoger@google.com [Tue, 21 May 2013 16:06:40 +0000 (16:06 +0000)]
Improve tool that analyzes gm JSON summary
BUG=https://code.google.com/p/skia/issues/detail?id=1300
R=borenet@google.com

Review URL: https://codereview.chromium.org/15298010

git-svn-id: http://skia.googlecode.com/svn/trunk@9217 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd startcanvas/endcanvas entry-points for the script. rename all "official" entry...
reed@google.com [Tue, 21 May 2013 16:05:53 +0000 (16:05 +0000)]
add startcanvas/endcanvas entry-points for the script. rename all "official" entry-points to use "sk_scrape_" prefix

BUG=

Review URL: https://codereview.chromium.org/15511006

git-svn-id: http://skia.googlecode.com/svn/trunk@9216 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM: make behavior of make_filename() more late-binding
epoger@google.com [Tue, 21 May 2013 15:45:45 +0000 (15:45 +0000)]
GM: make behavior of make_filename() more late-binding

This will be needed to add the option of writing out files with
checksum-based filenames.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/15415003

git-svn-id: http://skia.googlecode.com/svn/trunk@9215 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoGM self-tests: add testing for non --hierarchy case
epoger@google.com [Tue, 21 May 2013 15:41:35 +0000 (15:41 +0000)]
GM self-tests: add testing for non --hierarchy case

R=scroggo@google.com

Review URL: https://codereview.chromium.org/15397007

git-svn-id: http://skia.googlecode.com/svn/trunk@9214 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable dumping the ctm on every drawRect verb (was there for testing)
reed@google.com [Tue, 21 May 2013 14:19:53 +0000 (14:19 +0000)]
disable dumping the ctm on every drawRect verb (was there for testing)

BUG=

Review URL: https://codereview.chromium.org/15470017

git-svn-id: http://skia.googlecode.com/svn/trunk@9213 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix flaky Ubuntu performance trigger
robertphillips@google.com [Tue, 21 May 2013 12:26:58 +0000 (12:26 +0000)]
Fix flaky Ubuntu performance trigger

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9209 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agosupport SkCanvas as a real lua object
mike@reedtribe.org [Tue, 21 May 2013 12:20:39 +0000 (12:20 +0000)]
support SkCanvas as a real lua object

git-svn-id: http://skia.googlecode.com/svn/trunk@9208 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 21 May 2013 07:01:40 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9207 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow multiple lua files to be used in lua_pictures
mike@reedtribe.org [Tue, 21 May 2013 03:24:37 +0000 (03:24 +0000)]
allow multiple lua files to be used in lua_pictures
begin "stdlib" for skia in lua
add comments to scrape.lua

git-svn-id: http://skia.googlecode.com/svn/trunk@9206 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoprintf name of picture *before* we try to scrape it.
mike@reedtribe.org [Tue, 21 May 2013 01:49:06 +0000 (01:49 +0000)]
printf name of picture *before* we try to scrape it.

git-svn-id: http://skia.googlecode.com/svn/trunk@9205 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkImage::encode to SkImage_Codec.cpp.
commit-bot@chromium.org [Mon, 20 May 2013 23:57:38 +0000 (23:57 +0000)]
Move SkImage::encode to SkImage_Codec.cpp.

Chrome depends on SkImage.cpp, but does not include SkImageDecoder,
so having SkImage::encode in SkImage.cpp breaks chromium. Temporarily
fix the problem by moving the implementation into SkImage_Codec.cpp.

The larger fix will be to solve
https://code.google.com/p/skia/issues/detail?id=1275

R=reed@google.com, robertphillips@google.com

Author: scroggo@google.com

Review URL: https://chromiumcodereview.appspot.com/15314004

git-svn-id: http://skia.googlecode.com/svn/trunk@9204 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a comment to the top of images.gyp.
scroggo@google.com [Mon, 20 May 2013 22:15:32 +0000 (22:15 +0000)]
Add a comment to the top of images.gyp.

Tells vi to color it properly.

Review URL: https://codereview.chromium.org/15502002

git-svn-id: http://skia.googlecode.com/svn/trunk@9203 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerformance trigger rebaselines
robertphillips@google.com [Mon, 20 May 2013 19:23:55 +0000 (19:23 +0000)]
Performance trigger rebaselines

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9199 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix boolean check for unknown rtconf variables in files.
humper@google.com [Mon, 20 May 2013 17:14:40 +0000 (17:14 +0000)]
fix boolean check for unknown rtconf variables in files.

BUG=

Review URL: https://codereview.chromium.org/15300019

git-svn-id: http://skia.googlecode.com/svn/trunk@9198 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd SkDrawPictureCallback optional parameter to drawPicture(), which can abort the...
reed@google.com [Mon, 20 May 2013 17:02:41 +0000 (17:02 +0000)]
add SkDrawPictureCallback optional parameter to drawPicture(), which can abort the picture drawing.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/14598023

git-svn-id: http://skia.googlecode.com/svn/trunk@9197 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake DecodeMemoryToTarget handle more configs.
scroggo@google.com [Mon, 20 May 2013 16:58:16 +0000 (16:58 +0000)]
Make DecodeMemoryToTarget handle more configs.

In SkImageDecoder::DecodeMemoryToTarget, if SkBitmapToImageInfo fails due to an unsupported config, copy to 8888.

Needed for https://codereview.chromium.org/15145004/ and
https://codereview.chromium.org/12851012/ for all bitmaps to be
decoded properly in render_pictures and bench_pictures.

R=reed@google.com

Review URL: https://codereview.chromium.org/14772035

git-svn-id: http://skia.googlecode.com/svn/trunk@9196 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland path bounds change with correct bounds for convex and hairline path renderers.
bsalomon@google.com [Mon, 20 May 2013 16:49:06 +0000 (16:49 +0000)]
Reland path bounds change with correct bounds for convex and hairline path renderers.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15465005

git-svn-id: http://skia.googlecode.com/svn/trunk@9194 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd encodeData() to SkImageEncoder, and add encoding to SkImage
reed@google.com [Mon, 20 May 2013 16:33:41 +0000 (16:33 +0000)]
add encodeData() to SkImageEncoder, and add encoding to SkImage

BUG=
R=scroggo@google.com

Review URL: https://codereview.chromium.org/15002004

git-svn-id: http://skia.googlecode.com/svn/trunk@9193 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Mon, 20 May 2013 11:51:35 +0000 (11:51 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9189 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPerformance trigger rebaselines (mainly due to r9175)
robertphillips@google.com [Sun, 19 May 2013 12:33:15 +0000 (12:33 +0000)]
Performance trigger rebaselines (mainly due to r9175)

git-svn-id: http://skia.googlecode.com/svn/trunk@9188 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOne SkTSearch to rule them all. Allow key to be of different type than the array.
bsalomon@google.com [Fri, 17 May 2013 19:05:03 +0000 (19:05 +0000)]
One SkTSearch to rule them all. Allow key to be of different type than the array.

R=bungeman@google.com

Review URL: https://codereview.chromium.org/15070011

git-svn-id: http://skia.googlecode.com/svn/trunk@9182 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Revert "Revert "Pass bounds into draw calls in path renderers."""
bsalomon@google.com [Fri, 17 May 2013 18:01:38 +0000 (18:01 +0000)]
Revert "Revert "Revert "Pass bounds into draw calls in path renderers."""

git-svn-id: http://skia.googlecode.com/svn/trunk@9181 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake rebaseline.py pull msaa images
bsalomon@google.com [Fri, 17 May 2013 14:10:59 +0000 (14:10 +0000)]
Make rebaseline.py pull msaa images

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/15299005

git-svn-id: http://skia.googlecode.com/svn/trunk@9179 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix uninitialized adcd
bsalomon@google.com [Fri, 17 May 2013 13:31:57 +0000 (13:31 +0000)]
fix uninitialized adcd

git-svn-id: http://skia.googlecode.com/svn/trunk@9177 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Revert "Pass bounds into draw calls in path renderers.""
bsalomon@google.com [Fri, 17 May 2013 13:31:40 +0000 (13:31 +0000)]
Revert "Revert "Pass bounds into draw calls in path renderers.""

This reverts commit 2b80eb179df14c7c8d67b8ef2b2ee60efc504f65.

git-svn-id: http://skia.googlecode.com/svn/trunk@9176 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd special handling of rectori case for gpu
robertphillips@google.com [Fri, 17 May 2013 12:50:27 +0000 (12:50 +0000)]
Add special handling of rectori case for gpu

https://codereview.chromium.org/15080010/

git-svn-id: http://skia.googlecode.com/svn/trunk@9175 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 17 May 2013 07:01:11 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9174 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Pass bounds into draw calls in path renderers."
bsalomon@google.com [Thu, 16 May 2013 20:54:05 +0000 (20:54 +0000)]
Revert "Pass bounds into draw calls in path renderers."

This reverts commit 9e6c4259d8453b893b4abc28beba8f77226d18d1.

git-svn-id: http://skia.googlecode.com/svn/trunk@9173 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPass bounds into draw calls in path renderers.
bsalomon@google.com [Thu, 16 May 2013 19:58:46 +0000 (19:58 +0000)]
Pass bounds into draw calls in path renderers.

R=jvanverth@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/14882011

git-svn-id: http://skia.googlecode.com/svn/trunk@9171 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBand-aid for subsetted bitmaps in SKPs.
scroggo@google.com [Thu, 16 May 2013 19:35:39 +0000 (19:35 +0000)]
Band-aid for subsetted bitmaps in SKPs.

Partial fix for https://code.google.com/p/skia/issues/detail?id=1301.

Instead of firing an assert when the recorded width and height do
not match the encoded data's width and height, take a subset of
the bitmap of the correct size.

The bitmap may be drawn incorrectly, since it will not necessarily
be the correct subset (though it will be the correct size). The
complete fix will be to record the offset to the stream. Holding off
on that since it will change the PICTURE_VERSION. There is still
more work to do on read/writeBitmap, and I would like to change
PICTURE_VERSION as few times as possible.

BUG=https://code.google.com/p/skia/issues/detail?id=1301
R=djsollen@google.com

Review URL: https://codereview.chromium.org/15159004

git-svn-id: http://skia.googlecode.com/svn/trunk@9169 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake the use of fallback fonts in Android a runtime decision.
djsollen@google.com [Thu, 16 May 2013 18:38:43 +0000 (18:38 +0000)]
Make the use of fallback fonts in Android a runtime decision.

R=reed@google.com

Review URL: https://codereview.chromium.org/14972022

git-svn-id: http://skia.googlecode.com/svn/trunk@9168 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android_run_skia to work with multiple attached devices
borenet@google.com [Thu, 16 May 2013 18:12:34 +0000 (18:12 +0000)]
Fix android_run_skia to work with multiple attached devices

(SkipBuildbotRuns)

R=djsollen@google.com

Review URL: https://codereview.chromium.org/15199005

git-svn-id: http://skia.googlecode.com/svn/trunk@9167 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove the fno-rtti excluders now that fno-rtti is only passed to c++ files.
commit-bot@chromium.org [Thu, 16 May 2013 14:53:28 +0000 (14:53 +0000)]
Remove the fno-rtti excluders now that fno-rtti is only passed to c++ files.

R=djsollen@google.com

Author: bungeman@google.com

Review URL: https://chromiumcodereview.appspot.com/15210003

git-svn-id: http://skia.googlecode.com/svn/trunk@9165 2bbb7eff-a529-9590-31e7-b0007b416f81