dotnet-bot [Mon, 15 Nov 2021 04:17:15 +0000 (04:17 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Mon, 15 Nov 2021 04:14:32 +0000 (21:14 -0700)]
[release/6.0] Fix UnobservedTaskException from SemaphoreSlim.WaitAsync (#61491)
* Fix UnobservedTaskException from SemaphoreSlim.WaitAsync
If a SemaphoreSlim.WaitAsync times out, it correctly returns false, but it also results in TaskScheduler.UnobservedTaskException being raised unexpectedly, due to internal use of a faulted task whose exception isn't observed. This fixes that by marking any such exceptions as having been observed.
* Fix wasm build
Co-authored-by: Stephen Toub <stoub@microsoft.com>
dotnet-bot [Fri, 12 Nov 2021 22:29:21 +0000 (22:29 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Fri, 12 Nov 2021 22:25:43 +0000 (15:25 -0700)]
[release/6.0] Fix: add missed open curly (#61332)
* fix: add missed open curly
* feat: add test
Co-authored-by: annchous <annchooousss@gmail.com>
dotnet-bot [Fri, 12 Nov 2021 17:48:45 +0000 (17:48 +0000)]
Merge in 'release/6.0' changes
Vlad Brezae [Fri, 12 Nov 2021 17:45:23 +0000 (19:45 +0200)]
[mono][interp] Fix GetType called on ptr constrained to Nullable` (#61020) (#61305)
* [interp] Fix GetType called on ptr constrained to Nullable`
We were statically optimizing this call to return the actual constrained class type, which is incorrect for nullables, because boxing of a nullable (as part of the constrained call) actually creates an object with the type of the nullable's value (or null if there is no value).
* Add test for GetType call on ptr constrained to nullable
dotnet-bot [Fri, 12 Nov 2021 17:01:17 +0000 (17:01 +0000)]
Merge in 'release/6.0' changes
Adam Sitnik [Fri, 12 Nov 2021 16:57:37 +0000 (17:57 +0100)]
Support unseekable filestream when ReadAllBytes[Async] (#58434) (#61410)
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: LateApexEarlySpeed <72254037+lateapexearlyspeed@users.noreply.github.com>
dotnet-bot [Fri, 12 Nov 2021 14:59:15 +0000 (14:59 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Fri, 12 Nov 2021 14:55:46 +0000 (06:55 -0800)]
[wasm] Allow enums in unmanaged callbacks. (#61393)
Fixes https://github.com/dotnet/runtime/issues/61144.
Co-authored-by: Zoltan Varga <vargaz@gmail.com>
dotnet-bot [Thu, 11 Nov 2021 23:39:37 +0000 (23:39 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Thu, 11 Nov 2021 23:36:36 +0000 (15:36 -0800)]
Preserve last error in call-counting stubs (#60887)
Fixes #60819
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
dotnet-bot [Thu, 11 Nov 2021 21:49:15 +0000 (21:49 +0000)]
Merge in 'release/6.0' changes
dotnet-bot [Thu, 11 Nov 2021 21:45:44 +0000 (21:45 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Thu, 11 Nov 2021 21:44:12 +0000 (13:44 -0800)]
Allow nfloat to be in the ObjCRuntime namespace, and make it work for Xamarin.MacCatalyst.dll as well. (#60861)
Ref: https://github.com/xamarin/xamarin-macios/pull/13092
Ref: https://github.com/mono/mono/pull/21261
Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
Anirudh Agnihotry [Thu, 11 Nov 2021 21:42:46 +0000 (13:42 -0800)]
Update the ref pack version to 6.0.0 for apicompat (#61429)
* üpdate the apicompat for the ref pack
* update previous netcoreapp
dotnet-bot [Thu, 11 Nov 2021 17:27:31 +0000 (17:27 +0000)]
Merge in 'release/6.0' changes
Omair Majid [Thu, 11 Nov 2021 17:24:23 +0000 (12:24 -0500)]
The 6.0 branch is no longer pre-release (#61442)
This has limited affects, but it should have been set to false since 6.0
is now stable/released.
The one difference it makes is that -Werror is disabled when building
native code.
dotnet-bot [Thu, 11 Nov 2021 15:46:44 +0000 (15:46 +0000)]
Merge in 'release/6.0' changes
Matt Mitchell [Thu, 11 Nov 2021 15:43:24 +0000 (07:43 -0800)]
Remove pre-release version iteration (#61438)
This should always be empty in servicing.
dotnet-bot [Wed, 10 Nov 2021 18:44:30 +0000 (18:44 +0000)]
Merge in 'release/6.0' changes
Tomas Weinfurt [Wed, 10 Nov 2021 18:39:07 +0000 (10:39 -0800)]
[release/6.0.1] add support for macOS 12 (#61028)
* RID work for macOS 12 (#59066)
* fix rid processing on macOS (#60494)
* fix rid processing on macOS
* Update src/native/corehost/hostmisc/pal.unix.cpp
* Update src/native/corehost/hostmisc/pal.unix.cpp
* remove extra size calculation
* Fix "fix rid processing on macOS" (#60668)
The `else if (major == 12)` is dead code, since the previous if `if (major > 11)` would be true for `major == 12`. Judging by the comment and code, it looks like the intention of this `else if` statement was to match `major == 11`.
* add the packaging for platforms package
Co-authored-by: Austin Wise <AustinWise@gmail.com>
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
dotnet-bot [Wed, 10 Nov 2021 18:27:46 +0000 (18:27 +0000)]
Merge in 'release/6.0' changes
dotnet-bot [Wed, 10 Nov 2021 18:23:39 +0000 (18:23 +0000)]
Merge in 'release/6.0' changes
Mike McLaughlin [Wed, 10 Nov 2021 18:21:27 +0000 (10:21 -0800)]
[release/6.0.x] Add System.Diagnostics.StackFrame.GetMethodInfoFromNativeIP API for VS4Mac (#61298)
* Add System.Diagnostics.StackFrame.GetMethodInfoFromNativeIP API for VS4Mac
VS4Mac needs a way to symbolize managed IPs when rethrowing a native NSException from Objective C++. This is a short term API needed for the next 6.0 service release discoverable only through reflection.
Issue: #61186
* Code review feedback
* Remove unneccesary blank line
Radek Doulik [Wed, 10 Nov 2021 18:19:35 +0000 (19:19 +0100)]
[release/6.0][wasm] Change dotnet.wasm link optimization (#60632)
* [wasm] Change dotnet.wasm link optimization
Context: https://github.com/dotnet/runtime/issues/60349
When we switched to Emscripten 2.0.21, we stopped using deprecated
`--llvm-opts 2` option. This caused unwanted performance degradation.
Switching to `-O2` get us similar performance as with `--llvm-opts`.
Blazor wasm test app `Time to first UI` benchmark times:
branch/commit link option time dotnet.wasm size
--------------------+------------+--------+-----------------
release/6.0 92ff02 -Oz 491ms 2,430,639
release/6.0 92ff02 -O2 457ms 2,474,518
release/6.0 92ff02 -O3 444ms 2,555,824
* Fix native build too
Co-authored-by: Larry Ewing <lewing@microsoft.com>
dotnet-bot [Tue, 9 Nov 2021 20:58:49 +0000 (20:58 +0000)]
Merge in 'release/6.0' changes
Jan Jahoda [Tue, 9 Nov 2021 20:55:51 +0000 (21:55 +0100)]
Credential fixes (#61114) (#61372)
* fix HttpClientHandlerTest.RemoteServer.cs
* fix HttpClientHandlerTest.Authentication.cs
* fix HttpClientHandlerTest.cs
github-actions[bot] [Tue, 9 Nov 2021 20:54:50 +0000 (12:54 -0800)]
[release/6.0] Fix for InformationalVersion (#61240)
* Fix for #60532
In stable package mode we should be setting CoreLib informational
version to the ProductVersion according to the discussion on the
issue thread. I have verified locally that this fixes the processinfo2
test for me that was previously failing in the StabilizePackageVersion
mode. Please let me know how to proceed with the fix, whether you
want me to just merge it into dotnet/runtime main, whether I should
pursue its backport into 6.0 release and / or whether Matt considers
cherry-picking my change to his stabilization PR.
Thanks
Tomas
* Port InformationVersion fix to Mono corelib (#60614)
https://github.com/dotnet/runtime/pull/60572 for Mono's corelib.
Co-authored-by: Tomas Rylek <trylek@microsoft.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
dotnet-bot [Tue, 9 Nov 2021 19:07:27 +0000 (19:07 +0000)]
Merge in 'release/6.0' changes
dotnet-bot [Tue, 9 Nov 2021 19:06:13 +0000 (19:06 +0000)]
Merge in 'release/6.0' changes
Alex Perovich [Tue, 9 Nov 2021 19:04:05 +0000 (11:04 -0800)]
Only run source-index on main branch. (#61271)
Tom McDonald [Tue, 9 Nov 2021 19:02:38 +0000 (11:02 -0800)]
Fix incorrect CCW decoding in GetObjectForCCW (#61193) (#61341)
* Fix incorrect CCW decoding in GetObjectForCCW
* Fix linux/mac build
github-actions[bot] [Tue, 9 Nov 2021 19:01:58 +0000 (11:01 -0800)]
[release/6.0] Don't create a COM weak reference if the object is an aggregated COMWrappers RCW. (#61283)
* Don't create a COM weak reference if the object is an aggregated COMWrappers RCW.
* Add test for weak reference + aggregation with native weak reference impl.
* Apply suggestions from code review
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jekoritz@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
Co-authored-by: Aaron Robinson <arobins@microsoft.com>
dotnet-bot [Tue, 9 Nov 2021 18:28:00 +0000 (18:28 +0000)]
Merge in 'release/6.0' changes
Santiago Fernandez Madero [Tue, 9 Nov 2021 18:23:43 +0000 (10:23 -0800)]
Disable a couple of pen tests on Windows (#60746) (#60789)
Davis Goodin [Tue, 9 Nov 2021 18:23:12 +0000 (12:23 -0600)]
[release/6.0] Disable package validation in source-build for reliability (#60881)
* Disable package validation in source-build for reliability
* Add tracking issue to comment
* Switch from property overwrite to a condition
github-actions[bot] [Tue, 9 Nov 2021 18:20:10 +0000 (10:20 -0800)]
[release/6.0] Revise descriptions of VS workloads, and add missing ones (#60835)
* Revise descriptions of VS workloads, and add missing ones
* typo
Co-authored-by: Jo Shields <joshield@microsoft.com>
github-actions[bot] [Tue, 9 Nov 2021 18:17:57 +0000 (10:17 -0800)]
DotNetHost packages are not created during source-build (#60577)
The subset `host.pkg` is not producing the DotNetHost* NuGet packages. This is because the "Pack" target is getting invoked on the pkgprojs, but pkgprojs expect the "Build" target to be called. Since the "Pack" target is overriden in the Directory.Build.targets to be empty, no one is calling the "Build" target on the pkgprojs.
In an official build, a later subset `packs.tests` comes through and builds `Microsoft.DotNet.CoreSetup.Packaging.Tests.csproj`, which explicitly calls "Build" on the pkgprojs. So official builds still get these packages produced.
In source-build, we are no longer building the `packs.tests` subset, so the packages are not produced.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
github-actions[bot] [Tue, 9 Nov 2021 18:17:29 +0000 (10:17 -0800)]
[mono/win] Increase stack size (reserve) to 8MB (#60561)
Fix https://github.com/dotnet/runtime/issues/57141 in windows build.
Set the stack size (reserve) to 8MB, which is usually a default
on linux. This way we should get similar behavior on windows.
Co-authored-by: Radek Doulik <radekdoulik@gmail.com>
Mike McLaughlin [Tue, 9 Nov 2021 18:16:52 +0000 (10:16 -0800)]
Fix dump generation issues for VS4Mac (#61063)
The VS4Mac team found two issues preventing them from successfully diagnosing VS4Mac failures
on .NET:
1) Multiple "crashed" threads in the crash report json (#60932).
2) No flag or way to generate the crash report for hangs via the diagnostic server IPC commands (#60775).
Add new generate core dump IPC command that allows the generate crash report flag to be passed through to createdump for
VS4Mac. VS4Mac needs to distinguish between WriteDump/no signal and unknown signal ExceptionType. Change unknown signal
exception type to 0.
Issue: https://github.com/dotnet/runtime/issues/60775
Fix how the load bias is calculate for shared modules
Local testing with the SOS tests. VS4Mac team testing and verification.
Low risk because it only affects createdump, dump IPC command and the runtime dump generation path.
Anirudh Agnihotry [Fri, 5 Nov 2021 02:39:54 +0000 (19:39 -0700)]
update branding to 6.0.1 (#61176)
dotnet-bot [Sat, 23 Oct 2021 18:06:13 +0000 (18:06 +0000)]
Merge in 'release/6.0' changes
dotnet-maestro[bot] [Fri, 22 Oct 2021 20:27:45 +0000 (13:27 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20211022.3 (#60783)
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21519.3 -> To Version 6.0.0-beta.21522.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
github-actions[bot] [Fri, 22 Oct 2021 20:21:03 +0000 (13:21 -0700)]
[release/6.0] [wasm][debugger] Fix loading a non wasm page and then returning to a wasm page. (#60777)
* Fix loading a non wasm page and then returning to a wasm page.
* Adding non-wasm-page.html
* fixing other method
* addressing @radical comments
* adding last empty line
Co-authored-by: DESKTOP-GEPIA6N\Thays <thaystg@gmail.com>
github-actions[bot] [Thu, 21 Oct 2021 18:43:50 +0000 (14:43 -0400)]
[release/6.0] Create a parent CMake project for building app bundles on CI (#59154)
Backport of #58965 to release/6.0
This allows us to not run the CMake configure step separately for each libraries test suite which speeds up the build.
Helps with #58549
dotnet-maestro[bot] [Thu, 21 Oct 2021 15:07:10 +0000 (08:07 -0700)]
[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk (#60684)
* Update dependencies from https://github.com/dotnet/icu build
20211019.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-rtm.21515.1 -> To Version 6.0.0-rtm.21519.1
* Update dependencies from https://github.com/dotnet/emsdk build
20211020.1
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0 -> To Version 6.0.0
* Update dependencies from https://github.com/dotnet/emsdk build
20211020.3
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0 -> To Version 6.0.0
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-bot [Wed, 20 Oct 2021 22:39:44 +0000 (22:39 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Wed, 20 Oct 2021 22:36:28 +0000 (15:36 -0700)]
[release/6.0] Tweak workload build to use _GenerateMsiVersionString target (#60695)
* Tweak workload build to use _GenerateMsiVersionString target
Replaces GenerateVersions that wasn't quite accurate enough for what we need
* Pulled in arcade target that will be removed at a later date
* More tweaks
* Forget dependsontargets
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
dotnet-bot [Wed, 20 Oct 2021 14:07:17 +0000 (14:07 +0000)]
Merge in 'release/6.0' changes
dotnet-maestro[bot] [Wed, 20 Oct 2021 14:00:53 +0000 (07:00 -0700)]
[release/6.0] Update dependencies from dotnet/icu dotnet/emsdk dotnet/runtime-assets dotnet/arcade (#60495)
* Update dependencies from https://github.com/dotnet/runtime-assets build
20211015.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21515.1
* Update dependencies from https://github.com/dotnet/arcade build
20211015.3
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21515.3
* Update dependencies from https://github.com/dotnet/icu build
20211015.1
Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-rtm.21513.2 -> To Version 6.0.0-rtm.21515.1
* Update dependencies from https://github.com/dotnet/emsdk build
20211018.1
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0
* Update dependencies from https://github.com/dotnet/emsdk build
20211018.2
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0-rtm.21514.1 -> To Version 6.0.0
* [wasm] Fix workload install for tests, with 6.0.0
Move to using the generated nuget.config, which has the feeds added by
darc. The target is a duplicate from
`src/installer/tests/PrepareTestAssets/PrepareTestAssets.proj`, and
should be moved to a common location in future.
Thanks to @lewing for the suggestion.
* [wasm] Remove unused bits
* Update dependencies from https://github.com/dotnet/runtime-assets build
20211018.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 6.0.0-beta.21514.1 -> To Version 6.0.0-beta.21518.1
* Update dependencies from https://github.com/dotnet/arcade build
20211019.3
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21514.2 -> To Version 6.0.0-beta.21519.3
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <radical@gmail.com>
Co-authored-by: Matt Mitchell <mmitche@microsoft.com>
dotnet-bot [Tue, 19 Oct 2021 23:31:16 +0000 (23:31 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Tue, 19 Oct 2021 23:27:01 +0000 (16:27 -0700)]
[release/6.0] Don't special case "Experimental" projects (#60643)
* Don't special case "Experimental" projects
We only have one experimental project, System.Runtime.Experimental and
we want it to behave like any other package.
* Make coreclr packages use `IsShipping`
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
dotnet-bot [Tue, 19 Oct 2021 23:25:32 +0000 (23:25 +0000)]
Merge in 'release/6.0' changes
Matt Mitchell [Tue, 19 Oct 2021 23:21:40 +0000 (16:21 -0700)]
[release/6.0] Fix stable builds for some transport packages (#60635)
* Fix stable builds for some transport packages
Some non-shipping transport and sources packages were getting incorrectly getting stable versions. This didn't show up in the servicing excercise, though they probably did the right thing for unrelated reasons.
* Fix transport package version by not using PackageVersion property on workloads-testing.targets
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
dotnet-bot [Tue, 19 Oct 2021 17:11:41 +0000 (17:11 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Tue, 19 Oct 2021 17:08:51 +0000 (10:08 -0700)]
Update mac installers location string (#60500)
Co-authored-by: sfoslund <sfoslund@microsoft.com>
dotnet-bot [Tue, 19 Oct 2021 17:07:20 +0000 (17:07 +0000)]
Merge in 'release/6.0' changes
dotnet-bot [Tue, 19 Oct 2021 17:04:38 +0000 (17:04 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Tue, 19 Oct 2021 17:02:56 +0000 (10:02 -0700)]
[release/6.0] Enforce scatter/gather file I/O Windows API requirements et. al. (#58423)
* Move checking and pinning Windows vectored I/O buffers to a dedicated method.
* Refactor the scatter/gather APIs to use the common checking method.
And use pinned GCHandles and IntPtrs instead of MemoryHandles when passing the segment array to the bottom-most method.
* Shorten the name of the buffer-checking method.
* Directly get the pinned array's address instead of calling GCHandle.AddrOfPinnedObject.
* Refactor the error handling logic in TryPrepareScatterGatherBuffers.
* Allocate the segment array from native memory and at TryPrepareScatterGatherBuffers.
* Cache the page size on a static readonly field and add a couple of TODOs.
* Make the memory handlers readonly structs.
* Add a test.
* Reorder some methods with PR feedback taken into consideration.
* Stop special-casing scatter/gather operations with zero or one buffer.
* Factor the cleaning-up of the segment buffers into a separate method.
* Follow up on Scatter/Gather API changes (#58447)
* Allocate an array of memory handles only if needed.
* Remove an unnecessary variable in the multiple-syscall write gather.
* Actually verify the content read by the read scatter operation.
* Delay allocating native memory.
* Verify that the whole file was read in the scatter/gather test.
* Test the case when the scatter/gather buffers are acceptable by the Windows API.
* Avoid null pointer dereferences when passing an empty segment array.
* Test performing scatter/gather I/O with an empty segment array.
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Co-authored-by: Theodore Tsirpanis <teo.tsirpanis.718@gmail.com>
Co-authored-by: Theodore Tsirpanis <12659251+teo-tsirpanis@users.noreply.github.com>
Co-authored-by: Stephen Toub <stoub@microsoft.com>
github-actions[bot] [Tue, 19 Oct 2021 17:01:37 +0000 (10:01 -0700)]
[release/6.0] Use custom error message when running out of syncblocks (#60592)
* Use custom error message when running out of syncblocks
Contributes to #49215
* Update src/coreclr/dlls/mscorrc/mscorrc.rc
update message
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Co-authored-by: Manish Godse <61718172+mangod9@users.noreply.github.com>
github-actions[bot] [Tue, 19 Oct 2021 17:01:06 +0000 (10:01 -0700)]
[release/6.0] Update IntelliSense package (#60621)
* Update IntelliSense package
* Fixed package version
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
Co-authored-by: carlossanlop <1175054+carlossanlop@users.noreply.github.com>
dotnet-bot [Tue, 19 Oct 2021 01:56:43 +0000 (01:56 +0000)]
Merge in 'release/6.0' changes
Matt Mitchell [Tue, 19 Oct 2021 01:53:32 +0000 (18:53 -0700)]
[release/6.0] Stabilize for RTM (#60294)
* Stabilize for RTM
* revert xunit version to fix MEDIspecificationTests package
* pass the correct wasm package version and disable the coreclr failing test
* Update wcf and system.data.sqlclient compat pack dependencies
* Update WCF dependencies
Co-authored-by: Anirudh Agnihotry <anagniho@microsoft.com>
Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
dotnet-bot [Mon, 18 Oct 2021 21:07:46 +0000 (21:07 +0000)]
Merge in 'release/6.0' changes
Nikola Milosavljevic [Mon, 18 Oct 2021 21:03:44 +0000 (14:03 -0700)]
[release/6.0] Update THIRD-PARTY-NOTICES.TXT (#60092)
* Update THIRD-PARTY-NOTICES.TXT
* Regenerating to incorporate a change in infra
* Fixes for duplicate instance and misplaced header
* Remove duplicate corefx header
dotnet-bot [Mon, 18 Oct 2021 18:24:35 +0000 (18:24 +0000)]
Merge in 'release/6.0' changes
Eric Erhardt [Mon, 18 Oct 2021 18:19:08 +0000 (13:19 -0500)]
Update NetFramework.ReferenceAssemblies version to 1.0.2 (#60554)
dotnet-bot [Mon, 18 Oct 2021 17:59:04 +0000 (17:59 +0000)]
Merge in 'release/6.0' changes
Anirudh Agnihotry [Mon, 18 Oct 2021 17:56:01 +0000 (10:56 -0700)]
Revert "Update IntelliSense package (#60488)" (#60567)
This reverts commit
f39a90b2778665046d56b5699e89ff7f305bd353.
dotnet-bot [Mon, 18 Oct 2021 17:45:53 +0000 (17:45 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Mon, 18 Oct 2021 17:42:22 +0000 (10:42 -0700)]
Update IntelliSense package (#60488)
Co-authored-by: carlossanlop <carlossanlop@users.noreply.github.com>
dotnet-bot [Mon, 18 Oct 2021 16:11:32 +0000 (16:11 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Mon, 18 Oct 2021 16:06:27 +0000 (10:06 -0600)]
[release/6.0] Fix Int32 overflow bug in buffering logic (#60460)
* add a failing test
* fix the bug in BufferedFileStreamStrategy
* extend the test and fix it in the BufferedStream as well
* large files are currently not supported on WASM
* Apply suggestions from code review
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
* Exclude test from running in 32 bits
* fix the ConditionalFact attribute usage
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
Co-authored-by: Carlos Sanchez <1175054+carlossanlop@users.noreply.github.com>
Co-authored-by: David Cantu <dacantu@microsoft.com>
dotnet-bot [Mon, 18 Oct 2021 05:10:53 +0000 (05:10 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Mon, 18 Oct 2021 05:07:24 +0000 (22:07 -0700)]
[wasm] Fix typedef for non-void interp entry callbacks (#59990)
For UnmanagedCallersOnly methods that return non-void, pass the address of the
return variable to the interp entry method.
Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
dotnet-bot [Sat, 16 Oct 2021 00:05:53 +0000 (00:05 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Fri, 15 Oct 2021 23:59:37 +0000 (16:59 -0700)]
[reflection] Initialize default ALC gchandle in GetLoadContext (#60399)
If we try to get the ALC of an assembly from the default context before the
managed default ALC object has been created, the native gchandle has a null
target.
Ensure it is not null by explicitly referencing the Default ALC.
Fixes https://github.com/dotnet/runtime/issues/60348
Co-authored-by: Aleksey Kliger <alklig@microsoft.com>
dotnet-bot [Fri, 15 Oct 2021 22:13:00 +0000 (22:13 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Fri, 15 Oct 2021 22:09:32 +0000 (15:09 -0700)]
[release/6.0] Remove duplicate entries from dotnet --info (#60446)
* Remove duplicate entries from dotnet --info
* Remove trailing slashes from globally registered locations as well
* PR feedback
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Co-authored-by: vitek-karas <vitek.karas@microsoft.com>
dotnet-bot [Fri, 15 Oct 2021 19:46:40 +0000 (19:46 +0000)]
Merge in 'release/6.0' changes
Jeff Handley [Fri, 15 Oct 2021 19:43:21 +0000 (12:43 -0700)]
[release/6.0] Apply custom Message and Url to all [RequiresPreviewFeatures] attributes (#60456)
* Apply custom messages and urls to all generic math [RequiresPreviewFeatures] attributes
* Update AvxVnni message and remove the url
Co-authored-by: Buyaa Namnan <bunamnan@microsoft.com>
dotnet-bot [Fri, 15 Oct 2021 16:51:05 +0000 (16:51 +0000)]
Merge in 'release/6.0' changes
Santiago Fernandez Madero [Fri, 15 Oct 2021 16:48:15 +0000 (09:48 -0700)]
[release/6.0] Move 2 Drawing APIs that are not implemented in netfx to netcoreapp3.1 or later (#60371)
dotnet-bot [Fri, 15 Oct 2021 14:42:08 +0000 (14:42 +0000)]
Merge in 'release/6.0' changes
dotnet-maestro[bot] [Fri, 15 Oct 2021 14:36:45 +0000 (07:36 -0700)]
[release/6.0] Update dependencies from dotnet/emsdk dotnet/runtime-assets dotnet/arcade (#60398)
* Update dependencies from https://github.com/dotnet/runtime-assets build
20211014.1
Microsoft.DotNet.CilStrip.Sources , System.ComponentModel.TypeConverter.TestData , System.Drawing.Common.TestData , System.IO.Compression.TestData , System.IO.Packaging.TestData , System.Net.TestData , System.Private.Runtime.UnicodeData , System.Runtime.Numerics.TestData , System.Runtime.TimeZoneData , System.Security.Cryptography.X509Certificates.TestData , System.Windows.Extensions.TestData
From Version 6.0.0-beta.21511.1 -> To Version 6.0.0-beta.21514.1
* Update dependencies from https://github.com/dotnet/emsdk build
20211014.1
Microsoft.NET.Workload.Emscripten.Manifest-6.0.100
From Version 6.0.0-rtm.21512.1 -> To Version 6.0.0-rtm.21514.1
* Update dependencies from https://github.com/dotnet/arcade build
20211014.2
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21513.3 -> To Version 6.0.0-beta.21514.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-bot [Thu, 14 Oct 2021 19:11:30 +0000 (19:11 +0000)]
Merge in 'release/6.0' changes
Mike McLaughlin [Thu, 14 Oct 2021 19:08:26 +0000 (12:08 -0700)]
Fix VS4Mac crash report and core dump generation perf problems (#60319)
This is a VS4Mac show stopper. The performance (4 min or so) of taking a core dump
when VS4Mac crashes or hangs is unacceptable.
Backport of #60205
Refactor the DAC enumerate memory region phase out of gather crash info
This is so the crash report json is written and available before the core
dump which for VS4Mac currently takes 4 minutes.
Since on both Linux and MacOS all the RW regions have been already added
by createdump itself for heap dumps, then the sometimes slow (4 minutes for
VS4Mac) heap enum memory region is changed to the faster normal one. It adds
necessary DAC globals, etc. without the costly assembly, module, class, type
runtime data structure enumeration.
This fast heap dumps is opt'ed in with COMPlus_DbgEnableFastHeapDumps=1 env var to mitigate the
risk of something missing from these dumps.
Tested creating a crash report/core dump against VS4Mac process. Ran all the SOS tests on MacOS and Linux against this change.
Low since there is an opt-in env var that enables the most risk part.
github-actions[bot] [Thu, 14 Oct 2021 19:07:49 +0000 (12:07 -0700)]
Fix CRC32 encoding (#60360)
On x64, when the crc32 instruction 2nd operand is a memory address
(such as for a static field), and that address is containable
(which normally doesn't happen, because the address will be above
the 4GB lower address space), then the instruction was being
improperly encoded.
Co-authored-by: Bruce Forstall <brucefo@microsoft.com>
dotnet-bot [Thu, 14 Oct 2021 06:36:49 +0000 (06:36 +0000)]
Merge in 'release/6.0' changes
dotnet-maestro[bot] [Thu, 14 Oct 2021 06:34:05 +0000 (23:34 -0700)]
[release/6.0] Update dependencies from dotnet/arcade dotnet/icu (#60361)
* Update dependencies from https://github.com/dotnet/arcade build
20211013.3
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21512.4 -> To Version 6.0.0-beta.21513.3
* Update dependencies from https://github.com/dotnet/icu build
20211013.2
Microsoft.NETCore.Runtime.ICU.Transport
From Version 6.0.0-rtm.21507.1 -> To Version 6.0.0-rtm.21513.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-bot [Wed, 13 Oct 2021 22:51:29 +0000 (22:51 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Wed, 13 Oct 2021 22:48:14 +0000 (18:48 -0400)]
[release/6.0] Fix: CTS.TryReset() concurrency issue #60182 (#60323)
* Quick fix of #60182
* Fixed reset condition when there is no timer
* Simplify branching
Co-authored-by: sakno <roman.sakno@gmail.com>
dotnet-bot [Wed, 13 Oct 2021 22:30:39 +0000 (22:30 +0000)]
Merge in 'release/6.0' changes
Juan Hoyos [Wed, 13 Oct 2021 22:27:11 +0000 (15:27 -0700)]
Merge pull request #60358 from hoyosjs/juhoyosa/merge-rc2-rel
Merge RC2 tag into release/6.0 branch
Juan Sebastian Hoyos Ayala [Wed, 13 Oct 2021 19:01:48 +0000 (12:01 -0700)]
Merge tag 'v6.0.0-rc.2.21480.5' into juhoyosa/merge-rc2-rel
dotnet-bot [Wed, 13 Oct 2021 17:37:17 +0000 (17:37 +0000)]
Merge in 'release/6.0' changes
dotnet-maestro[bot] [Wed, 13 Oct 2021 17:33:22 +0000 (10:33 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20211012.4 (#60337)
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.GenFacades , Microsoft.DotNet.GenAPI , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SharedFramework.Sdk
From Version 6.0.0-beta.21511.3 -> To Version 6.0.0-beta.21512.4
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
dotnet-bot [Wed, 13 Oct 2021 14:00:41 +0000 (14:00 +0000)]
Merge in 'release/6.0' changes
github-actions[bot] [Wed, 13 Oct 2021 13:56:09 +0000 (06:56 -0700)]
Make upgrade install new host first, then uninstall old (#60317)
This should preserve the ordering of PATH, since the old MSI will never
remove its entry.
Co-authored-by: Eric StJohn <ericstj@microsoft.com>