Lauro Moura [Tue, 10 Sep 2019 23:15:59 +0000 (20:15 -0300)]
csharp: Add test for static interface members
For the checks added in D9893
Yeongjong Lee [Tue, 10 Sep 2019 22:47:47 +0000 (19:47 -0300)]
csharp: skip static members from interfaces
Summary:
Static methods of eo-interface are generated in c# interface-concrete. there are
4 methods
`efl_access_object_access_root_get`, `efl_access_object_event_emit`,
`efl_access_object_event_handler_add`, `efl_access_object_event_handler_del`
If a class that inherits that interface, static method can't be called via
classname.
This commit changes eolian_mono by removing those static members from the C#
interface-concretes. If a generated class implements the interface, the static
member is generated as static member of the class directly.
Depends on D9800
Test Plan: Check that `Efl.Ui.Widget` has `public static Efl.Object AccessRoot` property.
Reviewers: lauromoura, felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9893
Lauro Moura [Tue, 10 Sep 2019 22:30:46 +0000 (19:30 -0300)]
csharp: Skip non-public members from interfaces
Summary:
Eolian allows non-public members in interfaces and mixins (usually
@protected). As both kinds are converted to C# interfaces, this
causes problem as non-public members are forbidden in C# interfaces.
This commit changes eolian_mono by removing those members from the C#
interfaces. If a generated class implements the interface, the method is
generated as if it were a protected member of the class directly.
For mixed properties like `Efl.Io.Reader.CanRead { get; set @protected; }`,
the interface has only the public getter and the the implementing class has both
the public getter and the protected setter.
With this, C# devs won't be able to directly implement protected Eo
methods from interfaces. (But this really does not make sense from the
C# point of view).
ref T7494
Reviewers: segfaultxavi, felipealmeida, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, brunobelo, Jaehyun_Cho, #reviewers, woohyun, #committers
Tags: #efl
Maniphest Tasks: T7494
Differential Revision: https://phab.enlightenment.org/D9800
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 22:01:19 +0000 (23:01 +0100)]
efl task - change exit method to use normal event for multiple listeners
we couldn't have multilpe listeners before. now we can. better this
way. have to do this now because i can't mark efl task as @beta
without taking out massive wads of efl with it.
Felipe Magno de Almeida [Tue, 10 Sep 2019 21:58:31 +0000 (18:58 -0300)]
CSharp: Cleanup test that inserts idle event and do not remove it
Summary: Remove idle event after running test so it doesn't impact with other tests that run after it
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9887
Bruno da Silva Belo [Tue, 10 Sep 2019 20:42:19 +0000 (17:42 -0300)]
csharp: Adding ToString methods to Strbuf and custommarshaler.
Summary:
WIN32 should use a allocator and deallocator different from EFL, sometimes, when
freeing a pointer, it should use win32_free. To stardardize, A custommarshaler
is used to fix this problem.
Fixes T8201
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers
Tags: #efl
Maniphest Tasks: T8201
Differential Revision: https://phab.enlightenment.org/D9842
Bruno da Silva Belo [Tue, 10 Sep 2019 20:06:17 +0000 (17:06 -0300)]
eolian-mono: Changing order of scope and modifier.
Summary: sealed public is now public sealed and virtual public is public virtual
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers
Tags: #refactoring, PHID-PROJ-uhnmnvlvunw6jgoqdnd4, #efl_language_bindings
Maniphest Tasks: T8172
Differential Revision: https://phab.enlightenment.org/D9725
Mike Blumenkrantz [Tue, 10 Sep 2019 18:03:04 +0000 (15:03 -0300)]
build: unbreak destructors
Summary:
the following commits did not correctly add super calls to the destructor,
resulting in a massive number of build errors as well as some unit test failures
ref
e51699afbc6094fcfc0f62ca2071ae7b8c6e313b
ref
38be95b0b6fd93df01636ae0a7c974b32ed694a1
Reviewers: raster, lauromoura
Reviewed By: lauromoura
Subscribers: lauromoura, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9902
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:53:59 +0000 (17:53 +0100)]
efl task - go back to non beta... this breaks the world
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:43:02 +0000 (17:43 +0100)]
eo beta - mark task, io classes as beta because they are...
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:29:01 +0000 (17:29 +0100)]
efl core cmommand line - implement destructor and thus fix leak
Carsten Haitzler (Rasterman) [Tue, 10 Sep 2019 16:28:40 +0000 (17:28 +0100)]
efl gfx path - implement destructor and thus fix leak
Xavi Artigas [Tue, 10 Sep 2019 15:14:33 +0000 (17:14 +0200)]
efl_ui/alert_popup: More documentation nitpicks
Mike Blumenkrantz [Tue, 10 Sep 2019 15:08:44 +0000 (17:08 +0200)]
efl_ui/alert_popup: improve docs
Summary:
class and property docs
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9883
Xavi Artigas [Tue, 10 Sep 2019 14:05:44 +0000 (16:05 +0200)]
docs: nicer formatting of the NULL keyword, everywhere
Mike Blumenkrantz [Tue, 10 Sep 2019 13:44:29 +0000 (15:44 +0200)]
efl_ui/popup: improve docs
Summary:
this provides full documentation for the class and all properties
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9882
Marcel Hollerbach [Tue, 10 Sep 2019 13:21:56 +0000 (09:21 -0400)]
efl_ui_suite: resolve focus errors
Summary:
unregsiter shound never call unprotected eo API on the object,
unregister can be called with a object that is dead.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9898
Yeongjong Lee [Tue, 10 Sep 2019 13:09:00 +0000 (09:09 -0400)]
efl_ui_widget: make Efl_Ui_Scrollable_On_Show_Region legacy
Summary:
`Efl_Ui_Scrollable_On_Show_Region` is only used for legacy EAPI. it moved to
elm_widget.h from eo file. also, it renamed `Elm_Widget_On_Show_Region_Cb`.
Reviewers: Jaehyun_Cho, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9896
Daniel Kolesa [Tue, 10 Sep 2019 12:35:41 +0000 (14:35 +0200)]
eolian: hard ban usage of ptr() in stable API
Daniel Kolesa [Tue, 10 Sep 2019 12:29:06 +0000 (14:29 +0200)]
efl: replace usage of ptr() in all stable APIs
Daniel Kolesa [Tue, 10 Sep 2019 12:25:03 +0000 (14:25 +0200)]
eolian: fix default value handling for @by_ref types
We must check all pointerness first, and append NULL as default
when that applies, because @by_ref is not carried in the typedecl
info. Therefore, it would result in a false positive and try to
make a zeroed struct, which we don't want.
Daniel Kolesa [Tue, 10 Sep 2019 12:17:25 +0000 (14:17 +0200)]
eolian: account for @by_ref when serializing return types
This fixes cases such as missing const when having a @by_ref
return type. The const should not be avoided there because it
is not returning the whole type as const, just what the pointer
dereferences to.
Daniel Kolesa [Tue, 10 Sep 2019 12:10:10 +0000 (14:10 +0200)]
eolian: consider @by_ref marked elements ownable
Daniel Kolesa [Tue, 10 Sep 2019 12:06:46 +0000 (14:06 +0200)]
eolian: add an optional warning for ptr() usage in stable API
JunsuChoi [Tue, 10 Sep 2019 11:06:18 +0000 (20:06 +0900)]
evas_vg_cache: Hashkey in cache uses evas
Summary:
Vg_entry is shared by different child windows.
When two or more objects load the same file
When resizing, cache_vg_entry_render can delete an active entry
while creating a new entry and deleting an existing entry.
Therefore, use cache data added evas
Test Plan:
[enable json loader]
--- a/meson_options.txt
+++ b/meson_options.txt
@@ -203,7 +203,7 @@ option('evas-loaders-disabler',
type : 'array',
description : 'List of modular image/vector load .....
choices : ['gst', 'pdf', 'ps', 'raw', 'svg', 'rs .....
- value : ['webp', 'json']
+ value : ['webp']
[Test]
elementary_test -> Animation View click -> play -> Animation View click again -> ...
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9740
Xavi Artigas [Tue, 10 Sep 2019 10:26:03 +0000 (12:26 +0200)]
efl_task/exe: Further update docs
Wonki Kim [Tue, 10 Sep 2019 10:11:06 +0000 (12:11 +0200)]
efl_exe: Enhance class description
Summary: This patch ehnance the description of efl_exe, regarding task T7717.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9889
Xavi Artigas [Tue, 10 Sep 2019 09:34:50 +0000 (11:34 +0200)]
efl_ui/box_flow: Improve docs a bit further
Mike Blumenkrantz [Tue, 10 Sep 2019 09:25:55 +0000 (11:25 +0200)]
efl_ui/flox_box: improve docs
Summary:
expand the description for the class a bit
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9885
Mike Blumenkrantz [Tue, 10 Sep 2019 09:21:39 +0000 (11:21 +0200)]
efl_ui/popup: improve backwall docs
Summary: ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9884
Mike Blumenkrantz [Tue, 10 Sep 2019 07:58:49 +0000 (09:58 +0200)]
efl_ui/scrollable_content: improve docs
Summary:
this describes more behaviors of the mixin, various internal properties
used, and removes some incorrect references
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9881
Marcel Hollerbach [Tue, 27 Aug 2019 17:00:43 +0000 (19:00 +0200)]
efl_ui_position_manager: only fill as many items as we need
prior to this commit, we just passed the start_id and the end_id the
end_id was the start_id plus the size of the memory buffer. However,
making this depending on the size of the memory buffer is a bad idea, as
changing it based on our needs is rather painfull.
With this commit we have explicit passing of the start_id, end_id and
memory len. This is kind of redundant, however, its very convenient, and
easy to write. The buffer will be filled with the maximum size that is
possible with length of the buffer, however, the end_id will not be
filled anymore.
Differential Revision: https://phab.enlightenment.org/D9756
Marcel Hollerbach [Thu, 5 Sep 2019 12:06:15 +0000 (14:06 +0200)]
efl_ui_collection: update theme name
item_container was the wrong name here. this fixes this to use the
correct name in the theme. Additionally the file name in the file is
adjusted.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9849
Marcel Hollerbach [Thu, 5 Sep 2019 08:38:56 +0000 (10:38 +0200)]
efl_ui_position_manager_list: support odd even styles
this was simply forgotten, but was part of the previous widget, so this
fixes the missing widget.
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9846
Daniel Kolesa [Mon, 9 Sep 2019 16:26:49 +0000 (18:26 +0200)]
eolian: remove second parameter for eolian_type_c_type_get
This has been replaced by newer APIs.
Lauro Moura [Mon, 9 Sep 2019 16:10:02 +0000 (18:10 +0200)]
eolian_cxx: Add support for @by_ref
Summary:
It will coexist with `eolian_type_is_ptr` while we phase out the latter.
Fixes: T8211
Depends on D9866
Reviewers: q66, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9867
Mike Blumenkrantz [Mon, 9 Sep 2019 14:02:51 +0000 (16:02 +0200)]
docs: fix invalid $class reference to use @class
Summary: ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9876
Mike Blumenkrantz [Mon, 9 Sep 2019 13:56:26 +0000 (15:56 +0200)]
docs: remove nstate preview
Summary: this widget no longer exists
Reviewers: q66
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Differential Revision: https://phab.enlightenment.org/D9875
Marcel Hollerbach [Mon, 9 Sep 2019 13:15:00 +0000 (09:15 -0400)]
build: fix disabling of audio
Summary: this supports disabling audio building in efl.
Reviewers: tasn, zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9873
Daniel Kolesa [Mon, 9 Sep 2019 13:10:57 +0000 (15:10 +0200)]
evas_filter_parser: add a workaround for in-tree runs
Without this, the prefix would get pointed to something like
/path/to/efl/build/share/evas, which is not a valid path when
building. That would cause the docs build to fail.
Marcel Hollerbach [Mon, 9 Sep 2019 13:03:33 +0000 (09:03 -0400)]
efl_ui_position_manager_list: fix return on viewport changes
Summary:
we also need to return here when the position is not the same, or we are
going to place items in the wrong spot.
Reviewers: segfaultxavi, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9869
Stefan Schmidt [Mon, 9 Sep 2019 10:27:44 +0000 (12:27 +0200)]
release: Update NEWS and bump version for 1.23.0-beta1 release
Yeongjong Lee [Mon, 9 Sep 2019 01:13:40 +0000 (22:13 -0300)]
eolian_mono: remove redundant code in NativeMethods
Summary:
Duplicated interface's NativeMethods code will be removed. they are called in
`GetInterfaces`.
Size of efl_mono.dll
6,587,392 bytes(6.6MB) -> 4,112,384 bytes (4.1MB)
Test Plan: ninja test
Reviewers: felipealmeida, lauromoura, vitor.sousa
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, woohyun, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9752
Lauro Moura [Fri, 6 Sep 2019 22:57:05 +0000 (00:57 +0200)]
eolian_cxx: Remove last usage of type_is_owned
Reviewers: q66, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9866
Mike Blumenkrantz [Fri, 6 Sep 2019 16:43:32 +0000 (12:43 -0400)]
efl_ui/box: restore previous behavior for passing null reference objects
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9865
Daniel Kolesa [Fri, 6 Sep 2019 16:02:50 +0000 (18:02 +0200)]
eolian_gen: make errors compile/work
This is not thread safe, but I don't see any better way out for
now. We'd probably need a different error API for that.
Ref T6890
Daniel Kolesa [Fri, 6 Sep 2019 15:07:01 +0000 (17:07 +0200)]
eolian: remove @owned keyword
Daniel Kolesa [Fri, 6 Sep 2019 15:01:05 +0000 (17:01 +0200)]
efl: change all occurences of @owned to @move
Daniel Kolesa [Fri, 6 Sep 2019 14:58:08 +0000 (16:58 +0200)]
eolian: disallow duplicate entries in requires/composite sections
Carsten Haitzler (Rasterman) [Fri, 6 Sep 2019 14:39:10 +0000 (15:39 +0100)]
fix xpm again - to be threaded not region decode capable
Marcel Hollerbach [Fri, 6 Sep 2019 14:25:57 +0000 (16:25 +0200)]
efl_ui_tab_*: enhance documentation
Summary: just a commit bringing more information.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9864
Marcel Hollerbach [Fri, 6 Sep 2019 12:00:58 +0000 (14:00 +0200)]
efl_ui_spec: add tests for the previous fixes
we should check that if existing is not added before, that we do not
perform reparenting, and that we return false.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9863
Marcel Hollerbach [Fri, 6 Sep 2019 12:00:32 +0000 (14:00 +0200)]
efl_ui_tab_bar: do not perform insertion if existing is not added
same as the previous commit, just for efl_ui_tab_bar.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9862
Marcel Hollerbach [Fri, 6 Sep 2019 11:58:19 +0000 (13:58 +0200)]
efl_ui_spotlight: do not perform insertion if existing is not added
same as the previous commit, just for spotlight.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9861
Marcel Hollerbach [Fri, 6 Sep 2019 11:55:28 +0000 (13:55 +0200)]
efl_ui_box: do not perform insertion if existing is not added
this was brought up recently and it is true that this should be fixed.
If existing is not registered in the container, then we should not
perform the operation at all.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9860
Marcel Hollerbach [Mon, 2 Sep 2019 08:26:40 +0000 (10:26 +0200)]
efl_ui_spotlight: migrate from active_index to active_element
after playing arround with the widget, we found out that it feels quite
weird to have a index, where most of the time you work with widgets.
We might want to add syntax suger in the future to make it easier to
just jump to the next element, or to the previous, but that still is to
be decided.
The event and the communication to the spotlight manager are still left
to be used with the index, reason for this is, that we might need to
fill there an invalid pointer, if a deletion is triggering an animation,
which seems quite weird. That needs further discussing.
Docx have been updated, the sitemarks about the shifting of the
active_index can be removed, as the element is not subject of change
during content adds/deletes.
ref T7991
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9813
Bruno da Silva Belo [Fri, 6 Sep 2019 14:03:23 +0000 (16:03 +0200)]
eolian-mono: Removing I prefix from classes.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers
Tags: #efl
Maniphest Tasks: T8166
Differential Revision: https://phab.enlightenment.org/D9816
Bruno da Silva Belo [Fri, 6 Sep 2019 13:45:18 +0000 (15:45 +0200)]
eolian-mono: Renaming suffix for event and event args
Summary: suffix _Args to Args, Evt to Event
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: Jaehyun_Cho, woohyun, segfaultxavi, cedric, felipealmeida, #reviewers, lauromoura, #committers
Tags: #refactoring, PHID-PROJ-uhnmnvlvunw6jgoqdnd4, #efl_language_bindings
Maniphest Tasks: T8164, T8163
Differential Revision: https://phab.enlightenment.org/D9692
Carsten Haitzler (Rasterman) [Fri, 6 Sep 2019 13:17:10 +0000 (14:17 +0100)]
fix xpm loader to be threadable - fixes so much stuff...
fixes ylee's xpm loading issue... it really is just that xpm's didn't
load if you preload/load from a thread... because it wass the only
loader that claimed it couldnt be threaded... which it can be.
@fix
Daniel Kolesa [Fri, 6 Sep 2019 13:08:27 +0000 (15:08 +0200)]
eolian: change composite syntax from block to inheritance section
This makes more sense as these are related to inheritance tree.
Therefore, change while we still can.
Fixes T8183
Yeongjong Lee [Fri, 6 Sep 2019 07:29:09 +0000 (09:29 +0200)]
efl_ui_table: respect col,row span in last_position calculation
Summary:
col,row spen is needed to get correct last_position.
Thanks to segfaultxavi for refporting.
ref T8182
Test Plan:
https://git.enlightenment.org/tools/examples.git/tree/reference/c/ui/src/ui_container.c
Check that long button and small button are not overlapped.
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8182
Differential Revision: https://phab.enlightenment.org/D9854
Yeongjong Lee [Fri, 6 Sep 2019 07:20:13 +0000 (09:20 +0200)]
efl_ui_table: update recalc boolean in child delete callback
Test Plan:
1. elementary_test -to 'efl.ui.table (linear api)'
2. Click `Append` button 3 times.
3. Click `appended 6` button to delete
4. Click `Append` button.
5. Check that `appended 7` button position (1,1).
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9856
Lauro Moura [Thu, 5 Sep 2019 18:05:11 +0000 (20:05 +0200)]
bindings: Rename test cxx and csharp eo ownership tags
Summary:
Ref T8199
Depends on D9843
Reviewers: q66, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, brunobelo, #committers
Tags: #efl
Maniphest Tasks: T8199
Differential Revision: https://phab.enlightenment.org/D9844
Lauro Moura [Thu, 5 Sep 2019 18:04:34 +0000 (20:04 +0200)]
eolian_cxx: Replace type_is_owned with is_move
Summary:
is_owned is being replaced with the is_move family of functions.
This commit changes only the libeolian usage inside libeolian_cxx,
keeping the has_own naming in the generators for a simpler patch
during this freeze period.
Fixes T8199
Reviewers: q66, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, brunobelo, #committers
Tags: #efl
Maniphest Tasks: T8199
Differential Revision: https://phab.enlightenment.org/D9843
Vincent Torri [Thu, 5 Sep 2019 16:32:17 +0000 (12:32 -0400)]
evil: add newline at end of meson.build
Reviewers: cedric, raster, zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9848
Xavi Artigas [Thu, 5 Sep 2019 15:01:02 +0000 (17:01 +0200)]
docs: minor tweaks to efl_io_model
This file's docs are far from complete but this idea had to be
written down before it was forgotten.
Also, TABS.
Carsten Haitzler (Rasterman) [Thu, 5 Sep 2019 13:33:00 +0000 (14:33 +0100)]
fix more edje file set breaks
if group does change unloaidng first is bad because of the same
reasons - losing swallowed etc. content. so disable entirely.
Carsten Haitzler (Rasterman) [Thu, 5 Sep 2019 13:22:03 +0000 (14:22 +0100)]
fix a bunch of breaks that having a blind file unload has brought
We can't blindly unload here - this loses swallowed content (in swallows,
boxes, tables etc.) ... this here along with an actual implementation of file
unload broke the pager in E for starters as shading then unshading (double
click titlebar) a window would lose the mini preview image obj swallowed in.
also fullscreening would do it. this also broke gadget bar, the xkb gadget in
it too and more... so this is a particularly bad thing break.
@fix
Daniel Kolesa [Thu, 5 Sep 2019 13:14:39 +0000 (15:14 +0200)]
eolian: update C generator to respect by_ref as well as tests
Christopher Michael [Thu, 5 Sep 2019 12:22:56 +0000 (08:22 -0400)]
ecore-wl2: Update doxygen for various functions
Small patch to update some missing doxygen parameter information.
ref T8014
Christopher Michael [Thu, 5 Sep 2019 11:57:41 +0000 (07:57 -0400)]
ecore-wl2: Fix formatting and remove duplicate EAPI
Fix some doxygen formatting issues and remove a duplicated EAPI in
front of function.
NB: No functional changes
Vincent Torri [Thu, 5 Sep 2019 09:21:10 +0000 (09:21 +0000)]
Evil: remove installation of header and pc files, remove from git Evil.h
this patch finishes to remove Evil public headers
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9847
Ali Alzyod [Tue, 3 Sep 2019 11:05:08 +0000 (11:05 +0000)]
evas_textblock: apply coding convention
Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9819
abdulleh Ghujeh [Wed, 28 Aug 2019 15:04:51 +0000 (15:04 +0000)]
efl_ui_text: EFL_UI_EVENT_SELECTION_CLEARED not called
-Add a callback to ui_text for event EFL_UI_EVENT_SELECTION_CLEARED
-Select any text in the ui_text
-Clear selection by clicking any area by mouse or pressing arrows in keyboard
-The selection get cleared but the callback will never be called.
Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9771
abdulleh Ghujeh [Wed, 28 Aug 2019 11:22:38 +0000 (11:22 +0000)]
efl_ui_text : Clear selection after past on selected text
{
F3752242}Select part of a text and past a smaller text on it the selection will still there.
Reviewed-by: Tom Hacohen <tom@stosb.com>
Differential Revision: https://phab.enlightenment.org/D9766
Marcel Hollerbach [Wed, 28 Aug 2019 19:11:11 +0000 (21:11 +0200)]
efl_ui_collection: use the correct min size hint
there are not enough size hints, we should add more!
I mixed up which size hints i should have used here, after some back and
forth it turns out that i should use the combined. This fixes the list
example.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9779
Mike Blumenkrantz [Tue, 3 Sep 2019 17:13:40 +0000 (13:13 -0400)]
elm_test: don't use legacy win api in interfaces tags case
fix T7754
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9829
Mike Blumenkrantz [Tue, 3 Sep 2019 18:11:25 +0000 (14:11 -0400)]
tests/check: use test namespace for legacy check test function names
no functional changes
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9830
Mike Blumenkrantz [Fri, 30 Aug 2019 17:39:17 +0000 (13:39 -0400)]
efl/widget: un-@protected style property set
this is needed for some cases and there isn't a specific reason to keep
it proected
fix T8100
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9803
Ali Alzyod [Thu, 5 Sep 2019 08:26:57 +0000 (08:26 +0000)]
evas_textblock: fix compilation without harfbuzz
Differential Revision: https://phab.enlightenment.org/D9845
Ali Alzyod [Thu, 5 Sep 2019 05:52:51 +0000 (14:52 +0900)]
elm_entry: handle cursor delete/backspace with clusters consist of one or multible glyphs
Summary:
Cluster consist of one glyph, expected to be removed on backspace or delete key.
Cluster consist of multible glyph, expectd to remove part of on backspace or delete key.
This is behaviour founded in Android. (our current way of handling similar to Qt)
**New Behaviour**
{
F3750386}
**Old Behaviour**
{
F3750387}
Test Plan:
Auto Testing is challenging because there are no easy way to emulate keyboard down on elm_entry
```
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc, char **argv)
{
Evas_Object *win,*box,*entry;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("", "");
elm_win_autodel_set(win, EINA_TRUE);
box = elm_box_add(win);
entry = elm_entry_add(box);
evas_object_size_hint_weight_set(box,EVAS_HINT_EXPAND,EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(box,EVAS_HINT_FILL,EVAS_HINT_FILL);
elm_entry_entry_set(entry,"<font=NotoColorEmoji wrap=mixed >🇧🇬à¸à¸±ðŸ‡§ðŸ‡¬à¸à¸±😀😀😀😀😀à¸à¸±</font>");
evas_object_size_hint_weight_set(entry,EVAS_HINT_EXPAND,0.9);
evas_object_size_hint_align_set(entry,EVAS_HINT_FILL,EVAS_HINT_FILL);
evas_object_show(entry);
evas_object_show(box);
elm_box_pack_end(box,entry);
elm_win_resize_object_add(win,box);
evas_object_resize(win,320,480);
evas_object_size_hint_weight_set(entry,EVAS_HINT_EXPAND,0.1);
evas_object_size_hint_align_set(entry,EVAS_HINT_FILL,EVAS_HINT_FILL);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: tasn, woohyun, bowonryu
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9628
Vincent Torri [Wed, 4 Sep 2019 19:09:41 +0000 (20:09 +0100)]
Efreet_Uri: fix URI decoding when a Windows path (letter followed by :) is passed to efreet_uri_decode()
Summary: uri decoding returned a wrong URI when a Windows path is given
Test Plan: rage, which is using efreet_uri is now playing files on Windows
Reviewers: raster, cedric, zmike, stefan_schmidt
Reviewed By: raster
Subscribers: stefan_schmidt, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9839
Marcel Hollerbach [Wed, 4 Sep 2019 17:39:42 +0000 (13:39 -0400)]
efl_io_model: remove custom counting logic
Summary:
this logic brings a few problems:
- When files are annonced here, without the monitor having the context
of the files, immidiat actions like deletion of the file are resulting
in no deletion event. Which is definitly a bug, so we need to wait here
for the monitor.
- When a new count is annonced before the files are there from the
monitor, we are heading towards the same issue - additionally, we might
already have files available, due to the custom counting that are not
annoncned through the monitor, which means, at a later pointer we are
annoncing a new file which is already available via the API.
Right now i do not see a way to continue with this code, it caused major
issues with our CI and the POLL backend, for now things do work again.
Depends on D9624
Reviewers: zmike, stefan_schmidt, cedric, felipealmeida
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9625
Daniel Kolesa [Wed, 4 Sep 2019 16:05:49 +0000 (18:05 +0200)]
eolian: make sure to include by_ref in validation of expressions
Daniel Kolesa [Wed, 4 Sep 2019 16:00:58 +0000 (18:00 +0200)]
eolian: remove the expression eval_type API
This is unnecessary because for all contexts where type is
relevant the validator already makes sure the type and expression
match correctly, so you don't ever need to re-validate it. If you
are doing a generic case and are not sure, just use MASK_ALL.
Vincent Torri [Wed, 4 Sep 2019 15:39:02 +0000 (16:39 +0100)]
fix parsing module path on Windows
Summary: only '/' path separator is used while on Windows it can also be '\\'. Fix rage and emotion_test play of videos
Test Plan: emotion_test plays videos while it didn't before this patch
Reviewers: raster, cedric, zmike
Reviewed By: raster
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9837
SangHyeon Jade Lee [Wed, 4 Sep 2019 15:07:37 +0000 (11:07 -0400)]
Efl_Ui: Move elementary and change namespace Ui for ui related models
Summary:
Select and View is ui characteristic features,
so Efl_Select_Model and Efl_View_Model move to elementary from ecore
seems more natural.
namespace also should changed to Efl.Ui as it's right place.
Test Plan: run the test while building it
Reviewers: cedric, felipealmeida, bu5hm4n, zmike, lauromoura
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9820
Daniel Kolesa [Wed, 4 Sep 2019 14:01:01 +0000 (16:01 +0200)]
eolian tests: use new c_type APIs
Daniel Kolesa [Wed, 4 Sep 2019 13:58:48 +0000 (15:58 +0200)]
eolian: proper error message for @by_ref on pointer types
Daniel Kolesa [Wed, 4 Sep 2019 13:56:32 +0000 (15:56 +0200)]
eolian: add APIs to get full C types of parameters/returns/fields
These are needed because the type itself does not carry all the
information it needs to carry (particularly by_ref).
Hermet Park [Wed, 4 Sep 2019 11:01:53 +0000 (20:01 +0900)]
ector: add FIXME for coming issues.
We have no any test resouce but it seems very weird code...
Leave a comment for future task.
WooHyun Jung [Wed, 4 Sep 2019 05:06:23 +0000 (14:06 +0900)]
efl_ui_timepicker: change a property name (ampm -> is_24hour)
Summary:
For better understanding of the property, "is_24hour" looks
better than "ampm".
@ref T7901
Reviewers: zmike, segfaultxavi, bu5hm4n, kimcinoo
Reviewed By: segfaultxavi, kimcinoo
Subscribers: kimcinoo, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7901
Differential Revision: https://phab.enlightenment.org/D9811
Xavi Artigas [Tue, 3 Sep 2019 15:56:23 +0000 (15:56 +0000)]
docs: Update focus documentation
Lots of improvements to the focus-related classes.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9828
Marcel Hollerbach [Tue, 3 Sep 2019 08:55:40 +0000 (10:55 +0200)]
efl_ui_position_manager_grid: honor NULL objects
its sometimes possible that there is a NULL object returned by the batch
call. We should not just access the NULL element. Additionally, if NULL
was returned during visibility setting, we need to set visibility here.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9827
Marcel Hollerbach [Tue, 3 Sep 2019 08:52:04 +0000 (10:52 +0200)]
efl_ui_grid_position_manager: recalculate max min size correctly
we are walking all the items anyways, so we can recalc the minsize here
anyways. Additionally, this pm was never tested with code that just
passes a set of items at data-access init time, without calling
item_added for each item. (Which is perfectly fine). With this commit
this is now perfectly possible,
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9826
Marcel Hollerbach [Tue, 3 Sep 2019 08:26:05 +0000 (10:26 +0200)]
efl_ui_position_manager_list: skip cache calculation for not finalized
if we are not finalized yet, there is no reason to calculate the caches,
as this will be redone later on anyways.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9825
Marcel Hollerbach [Tue, 3 Sep 2019 08:25:48 +0000 (10:25 +0200)]
efl_ui_positon_manager_list: skip viewport size setting if its the same
this can be skipped.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9824
Marcel Hollerbach [Tue, 3 Sep 2019 08:23:49 +0000 (10:23 +0200)]
efl_ui_position_manager_list: require cache here
the cache need to be required here, as we are going to access it later
on.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9823
Marcel Hollerbach [Tue, 3 Sep 2019 08:23:29 +0000 (10:23 +0200)]
efl_ui_position_manager_list: set visibilitly more often
it is possible that the object returned by the batching call is NULL.
That is valid, however, if the batching call for the visibility is
getting the NULL element, but the placement is getting the none NULL
element, then the item on screen will not be visible. This commit
ensures that those items will be visible.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9822
Marcel Hollerbach [Tue, 3 Sep 2019 08:21:38 +0000 (10:21 +0200)]
efl_ui_position_manager_list: error when we detect that sizes are wrong
when sizes are different to the cached size, then the displayed items
are out of order, or do not fill the whole viewport. This should not
happen. In case that this is detected, print an error.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9821