platform/core/csapi/xsf.git
5 years agofix abi breaks (#5620) fixes #5288
Shane Neuville [Thu, 21 Mar 2019 10:00:59 +0000 (04:00 -0600)]
fix abi breaks (#5620) fixes #5288

5 years ago[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987
Pavel Yakovlev [Fri, 1 Mar 2019 17:22:18 +0000 (20:22 +0300)]
[iOS] Fix tapping a ViewCell after close ContextActionMenu (#5425) fixes #4987

5 years agopreviewer; PageRenderer trap for missing bg image (#5342)
kingces95 [Thu, 28 Feb 2019 02:32:57 +0000 (16:32 -1000)]
previewer; PageRenderer trap for missing bg image (#5342)

* previewer; PageRenderer trap for missing bg image

* previewer; PageRenderer trap for missing bg image

* fix macOS; remove ext for macOS

fixes #5300

5 years ago[iOS, Android] Prevent NREs in ScrollViews (#5383)
Samantha Houts [Thu, 28 Feb 2019 02:08:47 +0000 (18:08 -0800)]
[iOS, Android] Prevent NREs in ScrollViews (#5383)

* Add null checks on new code paths added in #4522

fixes #5161

* Fix cast...

Fixes #5247

5 years ago[Android] Fix SearchBar renderer height on API24 (#5329)
Rui Marinho [Fri, 22 Feb 2019 00:23:32 +0000 (00:23 +0000)]
[Android] Fix SearchBar renderer height on API24 (#5329)

5 years agoFix NRE in Android ResourceManager when reference resource in Previewer (#5331)
Tim Barham [Thu, 21 Feb 2019 01:24:18 +0000 (11:24 +1000)]
Fix NRE in Android ResourceManager when reference resource in Previewer (#5331)

Fixes part of #5300

(cherry picked from commit fb59591580ea474e7f48e5941854fd790dc5a8cb)

5 years agoAdd (passing) test for #5290
Stephane Delcroix [Tue, 19 Feb 2019 10:17:02 +0000 (11:17 +0100)]
Add (passing) test for #5290

5 years ago[C] Binding null on nullable (#5255)
Stephane Delcroix [Thu, 14 Feb 2019 19:08:16 +0000 (20:08 +0100)]
[C] Binding null on nullable (#5255)

* fixes #5274

bindings should allow null for nullable valuetypes!

* [C] Binding null on nullable

@kicsiede's fix for #5242, plus unit test, targetted to 3.6.0

- closes #5242

5 years ago[iOS] add single parameter constructor back (#5281) * fixes #5278
Shane Neuville [Mon, 18 Feb 2019 11:31:55 +0000 (04:31 -0700)]
[iOS] add single parameter constructor back (#5281) * fixes #5278

5 years ago[Android] Fix ImageRenderer URI (#5241)
Rui Marinho [Thu, 14 Feb 2019 00:22:40 +0000 (00:22 +0000)]
[Android] Fix ImageRenderer URI (#5241)

* ignore check if imageview isn't set

* [Controls] Add repo case for #5172

* [Controls] Use xf github image url

fixes #5172

5 years agoFixed passing container (#5158)
Andrei Nitescu [Wed, 13 Feb 2019 23:33:14 +0000 (01:33 +0200)]
Fixed passing container (#5158)

fixes #5156

5 years agoRevert "[Android] fixes issue content set after an await is not visible (#4861)"...
Samantha Houts [Wed, 13 Feb 2019 23:21:31 +0000 (15:21 -0800)]
Revert "[Android] fixes issue content set after an await is not visible (#4861)" (#5245)

This reverts commit bf0733129dda78349c14d7cb6ae39cd61ebe2288.

5 years agoBackport some 3.6 previewer changes to 3.5 (#5227)
Stephane Delcroix [Wed, 13 Feb 2019 21:41:45 +0000 (22:41 +0100)]
Backport some 3.6 previewer changes to 3.5 (#5227)

* [X] add callback for previewer on failing ctor (#5101)

Add a callback when object instantiation or creation fails, so the
previewer can replace it by an educated guess

* Allow the previewer to use design flag on RDs (#5096)

* [Xaml] Better handling of exception on properties (#5099)

Allow the previewer to recover and continue on throwing property setters
or BindableProperties.

* [Previewer] Fallback for factorymethod not found (#5139)

- fixes #5138

* [previewer] more info to the callback (#5155)

5 years agoReinstate and obsolete IPlatform, et al (#5181)
E.Z. Hart [Tue, 12 Feb 2019 20:27:00 +0000 (13:27 -0700)]
Reinstate and obsolete IPlatform, et al (#5181)

* Reanimate IPlatform and mark it obsolete

* Reinstate IPlatform everywhere in case someone is using it or subscribing to
PlatformSet

* Revert breaking parameter name change

* Obsolete IsEnabledPropertyName

* Reinstate and obsolete Realized property and constructor

* Escape string format so solution will build

* Fix previewer reflection test

* Fix interface on Tizen/TizenPlatformServices

* Update Xamarin.Forms.Core/Element.cs

Co-Authored-By: hartez <hartez@users.noreply.github.com>
5 years agoCake build script (#5074)
Shane Neuville [Tue, 12 Feb 2019 13:05:51 +0000 (06:05 -0700)]
Cake build script (#5074)

* cake

* cake

* android fix

* fix clean

* version fix

* android deploy updates

* move to cake tools

* add clean bin obj back in

* git versioning

* fix vs mac target

* vs mac fixes

* remove default config on sh

* add UAP pdbs

5 years ago[Xaml] don't use context before checking it's not null (#5124)
Stephane Delcroix [Tue, 5 Feb 2019 08:12:25 +0000 (09:12 +0100)]
[Xaml] don't use context before checking it's not null (#5124)

5 years ago[Controls] Ignore random failures on AppCenter
Rui Marinho [Mon, 4 Feb 2019 20:01:49 +0000 (20:01 +0000)]
[Controls] Ignore random failures on AppCenter

5 years agoMerge branch '3.4.0' into 3.5.0
Samantha Houts [Sat, 2 Feb 2019 01:56:58 +0000 (17:56 -0800)]
Merge branch '3.4.0' into 3.5.0

5 years agoFix ScrollToPosition.MakeVisible on iOS (was scrolling to Start) (#5063)
E.Z. Hart [Thu, 31 Jan 2019 19:13:57 +0000 (12:13 -0700)]
Fix ScrollToPosition.MakeVisible on iOS (was scrolling to Start) (#5063)

5 years ago[Mac] fixes NRE when changing MainPage. Refactoring tab order. (#4962) fixes #4156
Pavel Yakovlev [Thu, 31 Jan 2019 13:31:07 +0000 (16:31 +0300)]
[Mac] fixes NRE when changing MainPage. Refactoring tab order. (#4962) fixes #4156

5 years agoRevert "[Android] Ensure the page background can be un-set (#4916)"
Samantha Houts [Thu, 31 Jan 2019 02:57:42 +0000 (18:57 -0800)]
Revert "[Android] Ensure the page background can be un-set (#4916)"

This reverts commit 1c27d0bcff769b6b341e5934539726effbcb6231.

5 years ago[Android] fixes app crash when next control in FocusSearch isn't focusable (#5031)
Pavel Yakovlev [Wed, 30 Jan 2019 22:01:02 +0000 (01:01 +0300)]
[Android] fixes app crash when next control in FocusSearch isn't focusable (#5031)

fixes #5030

5 years agoupdate to support less prone to freezing (#5080)
Shane Neuville [Tue, 29 Jan 2019 22:52:41 +0000 (15:52 -0700)]
update to support less prone to freezing (#5080)

5 years ago[Android] fixes issue content set after an await is not visible (#4861)
Pavel Yakovlev [Tue, 29 Jan 2019 03:29:18 +0000 (06:29 +0300)]
[Android] fixes issue content set after an await is not visible (#4861)

* [Android] fixes issue content set after an await is not visible

* [Android] refactoring. Fixes frame inside frame does not resize after visibility changed.

* - add on-screen description to 1332 test

* - add 1760 uitest uses StackLayout

* fix autotest

5 years ago[iOS] Move Material iOS components to a separate nuget (#5026)
Shane Neuville [Mon, 28 Jan 2019 23:53:22 +0000 (16:53 -0700)]
[iOS] Move Material iOS components to a separate nuget (#5026)

* [ios] extract ios material out to its own project

* [core] fix platform messaging

* add material to other test projects

* update MaterialComponents on all test projects

* remove material from platform

* yml updates

* nuspec

* add iOS description

* language

* add dummy file so package installs into netstandard/android

* Add Target Framework checks

5 years ago[iOS] CollectionView single selection (#4985)
E.Z. Hart [Fri, 25 Jan 2019 16:40:17 +0000 (09:40 -0700)]
[iOS] CollectionView single selection (#4985)

* Working single selection on iOS

* Fix rebase errors

* Make ItemsLayout a constructor parameter for the Delegator

* Make common VSM states public consts

* Make file and type name match

* Simplify method we'll be completely rewriting while implementing the next feature

* VS didn't save project file changes

* Update submodule

5 years ago[Android] Fixes keyboard navigation in custom view (#4612)
Pavel Yakovlev [Thu, 24 Jan 2019 20:50:54 +0000 (23:50 +0300)]
[Android] Fixes keyboard navigation in custom view (#4612)

5 years ago[Android] Tests for multiple item collection changes in CollectionView (#4869)
E.Z. Hart [Thu, 24 Jan 2019 18:22:18 +0000 (11:22 -0700)]
[Android] Tests for multiple item collection changes in CollectionView (#4869)

* Add multi-item removal test; handle multi-item removal scenarios on Android;

* Add test harness for adding multiple items to CollectionView at once

* Add test harness for multi-item move/replace; handle Android multi-item move;
Fix bug when replacing differently-sized item sets on Android;

* Add test harness for INotifyCollectionChanged Reset

* Performance improvements and clearer test code

* Remove private modifier

* Fix bug where updating items sources changed source types

* Remove private modifier

* Make index checks clearer

* Remove private modifier

* Remove private modifier

* Move code into if clause

* Use local variable

* Better indication of how to use collection modification tests

* Include end index in items moved

* Make update range include items between source and destination indexes

* Remove commented code

5 years agoRemove unnecessary search for root (#5036)
E.Z. Hart [Thu, 24 Jan 2019 17:57:36 +0000 (10:57 -0700)]
Remove unnecessary search for root (#5036)

5 years ago[Build] Update build settings
Rui Marinho [Thu, 24 Jan 2019 15:26:46 +0000 (15:26 +0000)]
[Build] Update build settings

5 years ago[Build] Update variable for keychain pass
Rui Marinho [Thu, 24 Jan 2019 15:10:29 +0000 (15:10 +0000)]
[Build] Update variable for keychain pass

5 years ago[Build] Update build def
Rui Marinho [Thu, 24 Jan 2019 14:17:40 +0000 (14:17 +0000)]
[Build] Update build def

5 years ago[Build] Fix provisioning
Rui Marinho [Thu, 24 Jan 2019 13:32:15 +0000 (13:32 +0000)]
[Build] Fix provisioning

5 years ago[UWP] Fixes hide DisplayActionSheet behind the dialog box (#3163)
Pavel Yakovlev [Tue, 22 Jan 2019 20:15:42 +0000 (23:15 +0300)]
[UWP] Fixes hide DisplayActionSheet behind the dialog box (#3163)

5 years ago[UWP] fixes crashing ActivityIndicator with COMException (#4988)
Pavel Yakovlev [Sat, 19 Jan 2019 18:18:01 +0000 (21:18 +0300)]
[UWP] fixes crashing ActivityIndicator with COMException (#4988)

fixes #4982

5 years ago[C] add null check for FlexLayout.OnPropChanged (#5012)
Stephane Delcroix [Fri, 18 Jan 2019 12:42:21 +0000 (13:42 +0100)]
[C] add null check for FlexLayout.OnPropChanged (#5012)

We had null checks in 3 places, not the fourth one. and that case was
hit by #5001.

- fixes #5001

5 years agoMerge branch '3.4.0' into 3.5.0
Samantha Houts [Thu, 17 Jan 2019 00:57:38 +0000 (16:57 -0800)]
Merge branch '3.4.0' into 3.5.0

5 years ago.create-nuget.bat + maps (#4952)
kingces95 [Wed, 16 Jan 2019 23:07:46 +0000 (13:07 -1000)]
.create-nuget.bat + maps (#4952)

5 years agoImplement CollectionView item replace on iOS (#4865)
E.Z. Hart [Wed, 16 Jan 2019 21:42:48 +0000 (14:42 -0700)]
Implement CollectionView item replace on iOS (#4865)

5 years agoAdd preserve attr to 1326,1400
Samantha Houts [Tue, 15 Jan 2019 23:55:57 +0000 (15:55 -0800)]
Add preserve attr to 1326,1400

5 years ago[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4954) fixes #4789
Shane Neuville [Tue, 15 Jan 2019 16:01:42 +0000 (09:01 -0700)]
[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4954) fixes #4789

5 years ago[UITests] Fix #1685 UITest
Rui Marinho [Tue, 15 Jan 2019 14:49:40 +0000 (14:49 +0000)]
[UITests] Fix #1685 UITest

5 years ago[Shell] fixes navigate to a relative URI (#4977)
Pavel Yakovlev [Tue, 15 Jan 2019 14:05:51 +0000 (17:05 +0300)]
[Shell] fixes navigate to a relative URI (#4977)

5 years ago[UITest] Add Preserve to issue #1931 uitest
Rui Marinho [Tue, 15 Jan 2019 11:54:14 +0000 (11:54 +0000)]
[UITest] Add Preserve to issue #1931 uitest

5 years agoAdd instructions to test 33450
Samantha Houts [Tue, 15 Jan 2019 00:19:57 +0000 (16:19 -0800)]
Add instructions to test 33450

fixes #2246

5 years ago[ios] clear perfect value add ui test (#4968)
Shane Neuville [Mon, 14 Jan 2019 17:05:51 +0000 (10:05 -0700)]
[ios] clear perfect value add ui test (#4968)

- fixes #4957

5 years ago[iOS, Android] Implement Snap alignment for CollectionView (#4414)
E.Z. Hart [Mon, 14 Jan 2019 11:48:59 +0000 (04:48 -0700)]
[iOS, Android] Implement Snap alignment for CollectionView (#4414)

* Implement snap alignment for iOS CollectionView

* Add missing End/MandatorySingle implementation for Android

* Implement MandatorySingle snapping on iOS

* Fix issues with Android MandatorySingle skipping items;

* Fix rebase issue

5 years agoDisable suggestions for all Pickers (#4824) fixes #4629
Gerald Versluis [Mon, 14 Jan 2019 11:02:08 +0000 (12:02 +0100)]
Disable suggestions for all Pickers (#4824) fixes #4629

* Disable suggestions for all Pickers

* Removed redundant disabling of spellcheck

5 years ago[iOS] Fix unsubscribing the `PropertyChanged` event of the ViewCell (#4728)
Rui Marinho [Mon, 14 Jan 2019 10:51:49 +0000 (10:51 +0000)]
[iOS] Fix unsubscribing the `PropertyChanged` event of the ViewCell (#4728)

* [Controls] Add repo for comment related with #4186

* [iOS] Fix unsubscribing PropertyChanged when disposing ViewTableCell

* [Controls] Fix test

5 years agoChanges that VS Mac and Dev16 automatically make when you open SLN (#4969)
Shane Neuville [Mon, 14 Jan 2019 10:41:46 +0000 (03:41 -0700)]
Changes that VS Mac and Dev16 automatically make when you open SLN (#4969)

* vsmac changes these when you open it

* dev 16 changes

5 years agoMerge branch 'easy-tests' into 3.5.0
E.Z. Hart [Sat, 12 Jan 2019 00:02:04 +0000 (17:02 -0700)]
Merge branch 'easy-tests' into 3.5.0

5 years agoAutomate test for Issue 1700
E.Z. Hart [Sat, 12 Jan 2019 00:01:22 +0000 (17:01 -0700)]
Automate test for Issue 1700

5 years agoAutomate test for Issue 1685
E.Z. Hart [Fri, 11 Jan 2019 22:44:29 +0000 (15:44 -0700)]
Automate test for Issue 1685

5 years agoAutomate test for Issue 1590
E.Z. Hart [Fri, 11 Jan 2019 22:11:29 +0000 (15:11 -0700)]
Automate test for Issue 1590

5 years agoAutomate test for Issue 1557
E.Z. Hart [Fri, 11 Jan 2019 22:02:17 +0000 (15:02 -0700)]
Automate test for Issue 1557

5 years agoAuotmate test for Issue 1538
E.Z. Hart [Fri, 11 Jan 2019 21:38:41 +0000 (14:38 -0700)]
Auotmate test for Issue 1538

5 years ago[tests] UWP requires file extensions (#4944)
Matthew Leibowitz [Fri, 11 Jan 2019 20:32:57 +0000 (22:32 +0200)]
[tests] UWP requires file extensions (#4944)

5 years ago[UITests] Ignore test failure on iOS9, use manual review
Rui Marinho [Thu, 10 Jan 2019 18:50:18 +0000 (18:50 +0000)]
[UITests] Ignore test failure on iOS9, use manual review

5 years ago[Android] fixes Right-to-Left Hamburger icon in MasterDetailPage (#4716) fixes #2818
Pavel Yakovlev [Thu, 10 Jan 2019 17:56:11 +0000 (20:56 +0300)]
[Android] fixes Right-to-Left Hamburger icon in MasterDetailPage (#4716) fixes #2818

5 years ago[UITests] Disable test #1931 on iOS12 for now
Rui Marinho [Thu, 10 Jan 2019 12:59:38 +0000 (12:59 +0000)]
[UITests] Disable test #1931 on iOS12 for now

5 years agohide obsolete API from editor (#4938)
Stephane Delcroix [Thu, 10 Jan 2019 11:53:48 +0000 (12:53 +0100)]
hide obsolete API from editor (#4938)

- fixes #4772

5 years agoFix incorrect bug description
E.Z. Hart [Wed, 9 Jan 2019 22:40:27 +0000 (15:40 -0700)]
Fix incorrect bug description

5 years ago[iOS] CollectionView EmptyView (#4870)
E.Z. Hart [Wed, 9 Jan 2019 22:24:17 +0000 (15:24 -0700)]
[iOS] CollectionView EmptyView (#4870)

* Implement EmptyView for iOS

* Allow for changes to EmptyView on iOS; rename confusing variables;

5 years ago[Android] If drawable doesn't exist don't dispose of it (#4904)
Shane Neuville [Wed, 9 Jan 2019 14:06:49 +0000 (07:06 -0700)]
[Android] If drawable doesn't exist don't dispose of it (#4904)

5 years ago[Android] Ensure the page background can be un-set (#4916)
Matthew Leibowitz [Wed, 9 Jan 2019 14:06:00 +0000 (16:06 +0200)]
[Android] Ensure the page background can be un-set (#4916)

5 years agoMaterial Design Renderers for the Material Visual (#4733)
Shane Neuville [Tue, 8 Jan 2019 00:07:50 +0000 (17:07 -0700)]
Material Design Renderers for the Material Visual (#4733)

* Use the auto-generated constants

* [Visual] Work on the Material Frame

* Improving the code for the sample

* Added a controller to help with frames that have additional padding
 - Android MaterialCardView does not use the default padding to determine where the content starts, rather it uses the content padding of the view because there is a border that does not affect the content

* [Visual] Added a few extra checks on Android to reduce unnecessary interop

* [Visual] A few more frame changes and some button tweaks

* [Visual] use the themers on iOS and save default properties

* [Visual] Add placeholders for themer and cache defaults

* [Visual] Added the material slider for iOS
 - Android does not have a custom control, so uses the existing renderer

* [enhancements] Move from duplicate LoadImageAsync code to GetNativeImageAsync

* [visual] Updated the controls to use the new iOS bits

* [visual] some fixes for material components

* [visual] Added hacks for material alerts

* [visual] removing the alert changes for the main branch

* [visual] Update the MaterialComponents NuGet

* [visual] Rework the theming/customization of Material controls on iOS

* [visual] fix the places where the user colors were being changed

* [visual] Improve the ColorStateList management for Android

* [visual] Re-implemented the Android ProgressBar as a fast, material renderer

* Material Entry

* [visual] Add Android ActivityIndicator

* filter out material layouts for 8.1

* remove folder

* fix __ANDROID_28__

* MaterialContextThemeWrapper

* [visual] remove the `IFrameController` interface

* [visual] reverting the changes to the Frame layout

* [visual] reverting whitespace

* [visual] make sure to raise both property changed

* formatting changes

* fixing colors on android to match with ios themes

* Update Xamarin.Forms.Platform.Android/Material/MaterialButtonRenderer.cs

Co-Authored-By: mattleibow <mattleibow@live.com>
* fix sizing of entry with infinite width size request

* update to release 28 of support

* Update Xamarin.Forms.Platform.Android/Resources/values/styles.xml

Co-Authored-By: PureWeen <shane94@hotmail.com>
* Update Xamarin.Forms.Platform.Android/Resources/values/styles.xml

Co-Authored-By: PureWeen <shane94@hotmail.com>
* PR Comment changes

5 years agoUse PushAsync for 1305 UI test so the toolbar shows up
E.Z. Hart [Mon, 7 Jan 2019 21:12:01 +0000 (14:12 -0700)]
Use PushAsync for 1305 UI test so the toolbar shows up

5 years ago[iOS] Implement item move on iOS CollectionView (#4863)
E.Z. Hart [Mon, 7 Jan 2019 12:13:32 +0000 (05:13 -0700)]
[iOS] Implement item move on iOS CollectionView (#4863)

* Implement item move on iOS CollectionView

* Remove private modifier

5 years agoAdd missing preserve attribute for UI test 1267
E.Z. Hart [Mon, 7 Jan 2019 00:37:42 +0000 (17:37 -0700)]
Add missing preserve attribute for UI test 1267

5 years agoFix test 852
E.Z. Hart [Sat, 5 Jan 2019 23:42:09 +0000 (16:42 -0700)]
Fix test 852

5 years agoMerge branch '3.5.0' of github.com:xamarin/Xamarin.Forms into 3.5.0
E.Z. Hart [Fri, 4 Jan 2019 23:39:44 +0000 (16:39 -0700)]
Merge branch '3.5.0' of github.com:xamarin/Xamarin.Forms into 3.5.0

5 years agoAutomate UI test 1267
E.Z. Hart [Fri, 4 Jan 2019 21:11:33 +0000 (14:11 -0700)]
Automate UI test 1267

5 years agoAutomate UI test 1236
E.Z. Hart [Fri, 4 Jan 2019 20:12:51 +0000 (13:12 -0700)]
Automate UI test 1236

5 years agoAutomate UI test 1219
E.Z. Hart [Fri, 4 Jan 2019 19:55:50 +0000 (12:55 -0700)]
Automate UI test 1219

5 years agoAdd manual test instructions for 1075, match button text with actual color
E.Z. Hart [Fri, 4 Jan 2019 19:34:15 +0000 (12:34 -0700)]
Add manual test instructions for 1075, match button text with actual color

5 years agoAutomate UI test 1028
E.Z. Hart [Fri, 4 Jan 2019 19:08:48 +0000 (12:08 -0700)]
Automate UI test 1028

5 years agoAdd manual instructions to UI test 1026
E.Z. Hart [Fri, 4 Jan 2019 18:34:07 +0000 (11:34 -0700)]
Add manual instructions to UI test 1026

5 years agoAdd manual test run instructions for UI test 1025
E.Z. Hart [Fri, 4 Jan 2019 18:21:24 +0000 (11:21 -0700)]
Add manual test run instructions for UI test 1025

5 years agoClean up old comments
E.Z. Hart [Thu, 3 Jan 2019 22:56:42 +0000 (15:56 -0700)]
Clean up old comments

5 years agoAdd instructions for test 764; remove automated test that did nothing;
E.Z. Hart [Thu, 3 Jan 2019 22:37:36 +0000 (15:37 -0700)]
Add instructions for test 764; remove automated test that did nothing;

5 years agoMake test button visible on UWP
E.Z. Hart [Thu, 3 Jan 2019 17:01:57 +0000 (10:01 -0700)]
Make test button visible on UWP

5 years agoRemove nonsensical comments
E.Z. Hart [Thu, 3 Jan 2019 16:57:30 +0000 (09:57 -0700)]
Remove nonsensical comments

5 years agoAdd instructions to manual UI test
E.Z. Hart [Thu, 3 Jan 2019 01:40:48 +0000 (18:40 -0700)]
Add instructions to manual UI test

5 years agoImplement Android single selection in CollectionView (#4651)
E.Z. Hart [Thu, 27 Dec 2018 02:16:36 +0000 (19:16 -0700)]
Implement Android single selection in CollectionView (#4651)

* Implement Android single selection

* Fix naming conflicts with SelectionChangedEventArgs

* Split files by class; make SelectionChangedEventArgs constructors internal;
Optimizations for SelectionChangedEventArgs;
Fire selection changed event/command from property changed handler;

* Update Xamarin.Forms.Core/Items/SelectableItemsView.cs

Co-Authored-By: StephaneDelcroix <stephane@delcroix.org>
* Set default value for SelectedItemProperty

* Remove unnecessary null check

* Fix order of OnElementChanged and Setup/Teardown Element

* Fix project file weirdness

5 years agoMake ListView CachingStrategy property visible to Intellisense (#4846)
E.Z. Hart [Sat, 22 Dec 2018 13:54:18 +0000 (06:54 -0700)]
Make ListView CachingStrategy property visible to Intellisense (#4846)

5 years ago[Shell] fix queryParam navigation (#4843)
Stephane Delcroix [Fri, 21 Dec 2018 15:27:13 +0000 (16:27 +0100)]
[Shell] fix queryParam navigation (#4843)

when navigating to pages, not shell-section, handle the queryParams

- fixes #4837

5 years ago[Flex] fix Padding on the FlexLayout (#4823)
Stephane Delcroix [Fri, 21 Dec 2018 08:23:41 +0000 (09:23 +0100)]
[Flex] fix Padding on the FlexLayout (#4823)

As the flex engine doesn't handle x,y offset on the root layout,
handle that at the XF.FlexLayout level.

- fixes #2663

5 years ago[*] Drop MenuItem.IsEnabledPropertyName (#4659)
Stephane Delcroix [Fri, 21 Dec 2018 08:06:52 +0000 (09:06 +0100)]
[*] Drop MenuItem.IsEnabledPropertyName (#4659)

* [*] Drop MenuItem.IsEnabledPropertyName

While doing one of the big refactoring of 2006, we missed an
opportunity to use a propertyKey for IsEnabled, ending up in some
less-than-optimal  design choices, like IMenuController.IsEnabledPropertyName.

Properly using a public r-o BP removes the need for IsEnabledPropertyName.

* other plats

* use the key

5 years agoRemove unnecessary OK button check that won't pass on older Android versions
E.Z. Hart [Thu, 20 Dec 2018 21:58:22 +0000 (14:58 -0700)]
Remove unnecessary OK button check that won't pass on older Android versions

5 years ago[X] Design time properties (#4743)
Stephane Delcroix [Thu, 20 Dec 2018 12:16:40 +0000 (13:16 +0100)]
[X] Design time properties (#4743)

An alternate xaml resource file provider can request the XamlLoader to
_not_ ignore normally ignored properties in prebuilt XF design xmlns, as
in the following snippet:

```xaml
<ContentPage
    xmlns="http://xamarin.com/schemas/2014/forms""
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml""
    xmlns:d="http://xamarin.com/schemas/2014/forms/design""
    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006""
    mc:Ignorable="d"">
  <Label d:Text="Bar" Text="Foo" x:Name="label" />
</ContentPage>
```

The `d:` should be the prefix used by default for this, but any other
prefix will do too.

The `d:Text` property maps to the exact same property as `Text`, as the
XmllnsDefinitionAttributes are identical (that's convenient from a Intelisense
point of view), but, when (and only when) instructed by a provided Xaml resource
loader, the `d:Text` will override the `Text` property.

This works with virtually all properties defined on built-in Xamarin.Forms
controls, but it doesn't mean it's a sane idea to try to assign design value
to all existing properties.

The APi ofr setting the ResourceLoader had to change, and instead of taking
pre-defined arguments, it accepts and returns query and response types. This
is slightly less convenient to invoke through reflection, but way more easy
to extend in the future.

5 years ago[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4819)
Shane Neuville [Thu, 20 Dec 2018 08:27:01 +0000 (01:27 -0700)]
[Android] set ClipBounds to use ViewCompat.SetClipBounds (#4819)

5 years ago[XamlC] instantiate generic parameter on base types (#4776)
Stephane Delcroix [Wed, 19 Dec 2018 14:10:08 +0000 (15:10 +0100)]
[XamlC] instantiate generic parameter on base types (#4776)

* [XamlC] Instantiate generic parameters in base type generic arguments

* Add unit test for #4047

- fixes #4760
- closes #4047

5 years ago[Android] Check if Drawable is null in Draw override (#4783)
Shane Neuville [Wed, 19 Dec 2018 01:22:12 +0000 (18:22 -0700)]
[Android] Check if Drawable is null in Draw override (#4783)

- fixes #4782

5 years ago[X] throw XPE on missing element .ctor (#4786)
Stephane Delcroix [Tue, 18 Dec 2018 23:54:45 +0000 (00:54 +0100)]
[X] throw XPE on missing element .ctor (#4786)

* [X] throw XPE on missing element .ctor

In case of runtime parse, wrap the MissingMethodException in a
XamlParseException, to get lineInfo. In case of XamlC, detect missing
constructor and fail early.

- fixes #4751

* fix for ns1.0

5 years ago[XamlC] Always enable implicit casting, boxing and unboxing (#4238)
Akihiko Odaki [Tue, 18 Dec 2018 19:21:53 +0000 (04:21 +0900)]
[XamlC] Always enable implicit casting, boxing and unboxing (#4238)

5 years agoMerge branch '3.4.0' into 3.5.0
Rui Marinho [Tue, 18 Dec 2018 14:18:26 +0000 (14:18 +0000)]
Merge branch '3.4.0' into 3.5.0

5 years ago[Controls] Remove default timeout test #2482
Rui Marinho [Tue, 18 Dec 2018 13:03:25 +0000 (13:03 +0000)]
[Controls] Remove default timeout test #2482

5 years ago[Android] Avoid acting on a disposed reference (#4780)
Samantha Houts [Tue, 18 Dec 2018 13:01:48 +0000 (05:01 -0800)]
[Android] Avoid acting on a disposed reference (#4780)

5 years ago[XamlC] Resolve generic parameters of a method with generic return type (#4244)
Akihiko Odaki [Tue, 18 Dec 2018 11:07:49 +0000 (20:07 +0900)]
[XamlC] Resolve generic parameters of a method with generic return type (#4244)

5 years agoRevert "Properly detect SDK style projects (#4699)"
Stephane Delcroix [Mon, 17 Dec 2018 19:10:18 +0000 (20:10 +0100)]
Revert "Properly detect SDK style projects (#4699)"

This reverts commit 36b5345596180a62c732836b7ff20484b76861af.